1 2005-05-10 Jim Meyering <jim@meyering.net>
5 * tests/touch/not-owner: Skip the test if the user running it
6 has write access to `/'.
8 * src/copy.c (abandon_move): Remove erroneous UNWRITABLE check.
9 This makes `mv -i --reply=no f1 f2' work as expected (in not
10 performing the move operation). But note that specifying `-i'
11 after `--reply=no' does *not* work.
12 Tiny patch from Vlada Macek.
14 * tests/mv/reply-no: New file. Test for the above fix.
15 * tests/mv/Makefile.am (TESTS): Add reply-no.
17 * tests/ls-2/tests: Don't print PATH to stderr.
19 2005-05-08 Paul Eggert <eggert@cs.ucla.edu>
21 * NEWS: cp, ln, mv, rm no longer discard white space when intepreting
24 2005-05-06 Paul Eggert <eggert@cs.ucla.edu>
26 * NEWS: dd has new iflag= and oflag= flags "binary" and "text".
27 * src/dd.c (flags, usage): Add support for "binary" and "text".
29 2005-05-04 Paul Eggert <eggert@cs.ucla.edu>
31 * NEWS: chmod -w now complains if it differs from chmod a-w.
32 * src/chmod.c: Include quotearg.h.
33 (diagnose_surprises): New var.
34 (process_file): Diagnose surprises. Simplify the logic a bit,
36 (main): Prepare to diagnose surprises. Remove useless code for
38 * tests/chmod/Makefile.am (TESTS): Add umask-x.
39 * tests/chmod/umask-x: New file.
41 2005-05-02 Paul Eggert <eggert@cs.ucla.edu>
43 * NEWS: ls --indicator-style=directory renamed to ls
44 --indicator-style=slash, to avoid confusion with ls --directory.
45 * src/ls.c (usage): Likewise.
46 (slash): Renamed from directory_only. All uses changed.
48 2005-05-01 Paul Eggert <eggert@cs.ucla.edu>
50 * NEWS: "chmod +1 foo" is now diagnosed.
52 2005-04-29 Paul Eggert <eggert@cs.ucla.edu>
54 * NEWS: ls -p now marks only directories. New option
55 --indicator-style=directory equivalent to -p.
56 * doc/coreutils.texi (ls invocation): Document this.
57 Also, mention ">" is for doors.
58 * src/ls.c (enum indicator_style): New constant directory_only,
60 (indicator_style_args, indicator_style_types): Set it appropriately.
61 (decode_switches, gobble_file, print_type_indicator):
62 (length_of_file_name_and_frills):
63 Implement the change described in NEWS.
64 (decode_switches): Quote ">", too.
65 (usage): Update to match the new behavior. Describe ">".
66 * tests/ls/file-type: Test for new behavior. Omit -1 option.
67 The "ls --color" test wasn't being checked; add a check for
68 "ls --color=auto" instead.
70 * tests/head/Test.pm: Don't set _POSIX2_VERSION; no longer needed.
71 * tests/misc/split-fail: Likewise.
72 * tests/pr/Test.pm: Likewise.
73 * tests/sort/Test.pm: Fix comment to match new behavior of "sort".
74 * tests/tail/Test.pm (tv): Rename tests from obs to obs-plus
75 if they use file names starting with +.
76 (test_vector): Don't set _POSIX2_VERSION if obs but not obs-plus.
77 * tests/uniq/Test.pm (tv, test_vector): Likewise.
79 The following was partly derived from a tiny change by Eric Blake:
80 * tests/misc/nice: Don't use 'set -'. It's not portable to strict
81 POSIX 1003.1-2001 hosts. Also, don't set _POSIX2_VERSION.
82 * tests/mkdir/perm: Don't use 'set -'. Simplify test construction.
83 Work even if the underyling system attaches ACLs to new dirs.
84 * tests/mv/part-hardlink: Don't use 'set -'.
85 * tests/stty/row-col-1: Don't use 'set -'.
87 2005-04-28 Paul Eggert <eggert@cs.ucla.edu>
89 * NEWS: Document fixes described below.
90 * src/chmod.c (change, umask_value): New static vars.
91 (reference_file): Move this static var to inside "main".
92 (process_file, process_files): Remove CHANGES arg; now taken from
93 static var. All uses changed.
94 (usage): Fix incorrect description of MODE operand.
95 (main): For invalid mode usages, output a brief usage message.
96 Adjust to new modechange API.
97 * install.c (main): Adjust to new modechange API.
98 Also, free the mode_change object when done.
99 * mkdir.c (main): Likewise.
100 * mkfifo.c (main): Likewise.
101 * mknod.c (main): Likewise.
102 * tests/chmod/equal-X: Check for =xX bug.
103 * tests/chmod/equals: Check for =u bug.
104 * tests/chmod/usage: Check for u+gr and ug,+x bugs.
106 2005-04-26 Paul Eggert <eggert@cs.ucla.edu>
108 Restore support for usages like "head -1" and "tail -1",
109 even when conforming to POSIX 1003.1-2001.
110 Fix bug with "POSIXLY_CORRECT=1 fold file -3".
111 join now supports a NUL field separator, e.g., "join -t '\0'".
112 join now detects and reports incompatible options, e.g.,
114 * NEWS: Document this.
115 * src/date.c: Remove posixver.h and its uses.
116 (COMMON_SHORT_OPTIONS): Remove.
117 (short_options): New constant.
118 (short_options, usage): -I now always takes an optional arg.
119 * src/expand.c: Remove posixver.h and its uses.
120 (shortopts): New constant. -DIGIT now always takes an optional arg.
121 (main): Revamp parsing of -DIGIT to let parse_tab_stops handle it.
122 Don't complain about -DIGIT.
123 * src/fold.c: Remove posixver.h and its uses.
124 (shortopts): New constant. -DIGIT now always takes an optional arg.
125 (main): Don't preprocess arg list; that was buggy. Use method
127 * src/head.c: Remove posixver.h and its uses.
128 (header_mode_option): Remove.
129 (main): Don't complain about obsolete -NUM args.
130 * src/join.c: Remove posixver.h and its uses.
131 (obsolete_usage): Remove.
132 (join_field_1, join_field_2): Initialize to SIZE_MAX to indicate
133 they haven't been set yet.
134 (tab): Now int, not char. Initialize to -1 to indicate white space
135 separates columns, so that we can use NUL as a separator.
137 (OBSOLETE_LONG_OPTIONS, get_option): Remove.
138 (string_to_join_field): Remove ERR_MSG_FMT arg; a single format
139 suffices. Use xstrtoul for sizes; it suffices.
140 (decode_field_spec): Report an error and exit on failure. Return void,
142 (add_field_list): Likewise.
143 (set_join_field): New function.
144 (enum operand_status): New enum.
145 (add_file_name): New args OPERAND_STATUS, JOPTION_COUNT,
146 PREV_OPTC_STATUS, OPTC_STATUS to handle the bewildering array of
147 possibilities with obsolete option parsing.
148 (main): Use it. Do not depend on POSIX version.
149 Check for conflicting options. Parse obsolete options -j1 and -j2
150 so that it is a pure extension to POSIX 1003.1-2001.
151 Allow '-t\0' to specify a NUL tab, stealing the code from 'sort'.
152 * src/nice.c: Remove posixver.h and its uses.
153 (main): Always support -NUM option.
154 * src/od.c: Remove posixver.h and its uses.
155 (short_options): New constant, which always supports -w[num].
156 (COMMON_SHORT_OPTIONS): Remove.
157 * src/pr.c: Remove posixver.h and its uses.
158 (short_options): New constant, which always supports -S[string].
159 (COMMON_SHORT_OPTIONS): Remove.
160 * src/sort.c: Remove posixver.h and its uses.
161 (short_options): New constant, which always supports -y arg.
162 (COMMON_SHORT_OPTIONS): Remove.
163 (main): Redo workaround for Solaris compatibility with -y.
164 This change isn't visible to the user; it just cleans up the
165 code so that we don't need posixver.h.
166 * src/split.c: Remove posixver.h and its uses.
167 (main): Don't complain about -NUM option.
168 * src/tail.c (parse_obsolete_option): Don't complain about -NUM.
169 * src/unexpand.c: Remove posixver.h and its uses.
170 (main): Don't complain about -TAB.
171 * src/uniq.c (main): Don't complain about -NUM.
173 2005-04-22 Paul Eggert <eggert@cs.ucla.edu>
175 * src/nohup.c (main): If getopt fails, exit with status 127,
176 not status 1. POSIX requires this.
177 * NEWS: Document this.
179 * src/nice.c (main): Report proper program name when getopt finds
180 trouble. Problem reported by Behdad Esfahbod.
182 * NEWS: Fix bug with "mkdir -m =+x dir"; the umask was being ignored
183 when the "+x" was being evaluated.
184 * mkdir.c (main): Compile mode with MODE_MASK_ALL and initial umask.
185 * mkfifo.c (main): Likewise.
186 * mknod.c (main): Likewise.
187 * tests/mkdir/perm: Test for the above bug.
189 2005-04-20 Paul Eggert <eggert@cs.ucla.edu>
191 Port test cases to Microsoft-Windows-related environments,
192 following suggestions from Eric Blake.
193 * tests/install/Makefile.am (TESTS_ENVIRONMENT): Add EXEEXT.
194 * tests/install/basic-1: Undo previous change.
195 (dd, dd2): New vars, which use $EXEEXT. All uses of dd and dd2 changed.
196 * tests/install/trap: Undo previous change.
197 (sig): New var. Use it insted of "trap '' CHLD".
198 Append $EXEEXT to executable name.
200 "fetish" -> "coreutils" in more places.
201 * tests/Coreutils.pm: Renamed from tests/Fetish.pm.
202 (package Coreutils): Renamed from package Fetish. All uses changed.
203 * tests/Makefile.am (EXTRA_DIST): Add Coreutils.pm and
206 2005-04-19 Paul Eggert <eggert@cs.ucla.edu>
208 * tests/mv/setup (dot_mount_point): Use stat -L, in case the
209 directory is actually a symbolic link. Problem reported by
212 * tests/mv/mv-special-1: Use test -p to test for fifos, rather
213 than the (incorrect) test -f and the (inadequate) ls. ls is
214 inadequate because on some hosts a buggy mv will create a file of
215 the wrong type (problem reported by Eric Blake). Skip this test
216 if test -p doesn't work.
218 * tests/chmod/setgid: Use numeric group ids, not symbolic group names,
219 since the latter can have shell metacharacters in them (e.g., spaces).
220 This follows up to the 2005-01-17 patch, which missed this occurrence.
222 2005-04-18 Paul Eggert <eggert@cs.ucla.edu>
224 "fetish" -> "coreutils" in several places.
225 * Makefile.cfg (ftp): Remove fetish.sf.net.
226 * Makefile.maint (emit_upload_commands): Likewise.
227 * src/Makefile.am (LDADD, $(PROGRAMS)): fetish -> coreutils.
228 * tests/group-names (COREUTILS_GROUPS): Renamed from FETISH_GROUPS.
229 * tests/chmod/setgid (FETISH_GROUP): Renamed from COREUTILS_GROUP.
231 * tests/install/basic-1: Use "cat", not "test", to test for
232 ../../src/dd. Problem reported by Eric Blake.
234 2005-04-18 Jim Meyering <jim@meyering.net>
236 * src/dd.c: Don't include stat-macros.h directly. system.h does that.
238 2005-04-17 Paul Eggert <eggert@cs.ucla.edu>
240 Work around a couple of "make check" failures reported for Cygwin
241 and ash by Eric Blake.
242 * tests/install/basic-1: Skip this test if ../../src/dd isn't readable.
243 * tests/install/trap: Skip this test if "trap '' CHLD" doesn't work.
245 2005-04-16 Jim Meyering <jim@meyering.net>
247 * src/dd.c (S_TYPEISSHM): Remove definition.
248 Get the definition by including "stat-macros.h", instead.
250 2005-04-14 Paul Eggert <eggert@cs.ucla.edu>
252 Fix test suite problems reported by Eric Blake on Cygwin.
253 * tests/mv/mv-special-1: Ignore chatter about when files are removed,
254 since POSIX doesn't require rename to fail across file systems.
255 * tests/mv/setup (dot_mount_point): Use stat rather than df, as
257 (other_partition_tmpdir): Remove df from name as that would be
260 2005-04-14 Jim Meyering <jim@meyering.net>
262 * src/chown-core.c: Correct typo, fchmod -> fchown, in a comment.
264 2005-04-12 Paul Eggert <eggert@cs.ucla.edu>
266 * src/ls.c (usage): "uid" -> "user ID".
268 2005-04-12 Jim Meyering <jim@meyering.net>
270 * src/tsort.c (tsort): Use "%s" as the format string,
271 rather than a diagnostic or a file name.
273 * src/comm.c (compare_files): Remove declaration of unused local.
275 * src/chown-core.c (chopt_free): Mark parameter as unused.
277 2005-04-11 Paul Eggert <eggert@cs.ucla.edu>
279 * man/chown.x: Reword to match user manual.
280 * man/id.x: Likewise.
281 * src/setuidgid.c (usage): Use "user ID", not "UID", and similarly
283 * src/whoami.c (usage, main): Likewise.
285 Add bulletproofing for cases where stdin, stdout, or stderr are closed.
286 * src/comm.c: Include stdio-safer.h.
287 (compare_files): Exit right away on I/O error rather than continuing
288 and producing confusing output and error messages.
289 Return void, not int; all callers changed.
290 Use fopen_safer to avoid confusion with file descriptors.
291 * src/copy.c: Include unistd-safer.h.
292 (copy_reg): Use fd_safer.
293 * src/csplit.c: Include stdio-safer.h.
294 (input_desc): Remove unnecessary static initialization.
295 (set_input_file): Use STDIN_FILENO, not 0.
296 (create_output_file): Use fopen_safer.
297 * src/dircolors.c (dc_parse_file): Don't assume fopen does not
299 * src/head.c (head_file): Don't assume open does not return 0.
300 * src/join.c: Include stdio-safer.h.
301 (main): Use fopen_safer. Simplify the resulting code.
302 * src/md5sum.c (digest_file, digest_check):
303 Don't assume that fopen does not return stdin.
304 * src/nohup.c: Include unistd-safer.h.
305 (main): Don't dup stderr to stdin or stdout by mistake.
306 * src/od.c (check_and_close): Don't assume fopen does not return stdin.
307 * src/paste.c (paste_serial): Likewise.
308 * src/pr.c: Include stdio-safer.h.
309 (open_file): Use fopen_safer.
310 (close_file): Don't assume fopen does not return stdin.
311 * src/ptx.c (main): Don't assume fopen returns stdout after closing
312 stdout. Use freopen instead.
313 * src/shred.c: Include unistd-safer.h.
314 (wipename): Use fd_safer on directory file descriptor.
315 (wipefile): Remove special case for /dev/fd/* on older hosts.
316 It didn't work in general, and wasn't documented.
318 * src/sort.c: Include unistd-safer.h.
319 (create_temp_file): Use fd_safer.
320 (xfclose): Don't assume fileno (stdin) == STDIN_FILENO, etc.
321 * src/split.c: Include unistd-safer.h.
322 (cwrite): Use fd_safer. Replace mystery constant 0666 with symbolic
323 version, as POSIX requires.
324 * src/sum.c (bsd_sum_file, sysv_sym_file):
325 Use same pattern as elsewhere for checking for stdin.
326 * src/tac.c: Include unistd-safer.h.
327 (copy_to_temp): Use fd_safer.
328 (tac_file): Don't assume fopen cannot return stdin.
329 * src/tail.c: Include unistd-safer.h rather than fcntl-safer.h.
330 (recheck, tail_file): Use fd_safer rather than open_safer.
331 * src/tee.c: Include stdio-safer.h.
332 (tee): Use fopen_safer.
333 * src/touch.c: Include unistd-safer.h.
334 (touch): Use fd_safer.
335 * src/tsort.c (have_read_stdin): Remove; no longer needed. All uses
337 (tsort): Do not assume fopen can't return stdin.
338 Close stdin before returning. All uses changed.
339 * src/unexpand.c (next_file): Don't assume fopen cannot return stdin.
340 * src/uniq.c: Include stdio_safer.h.
341 (check_file): Don't assume fopen cannot return stdin or stdout.
343 2005-04-09 Jim Meyering <jim@meyering.net>
345 * src/dd.c (quit): Define with ATTRIBUTE_NORETURN.
347 Now that close_stdout closes standard output unconditionally,
348 these workarounds for dd and cat are no longer necessary.
349 * src/dd.c (close_stdout_wrapper): Remove function.
350 (main): Call atexit with close_stdout, instead.
351 * src/cat.c (close_stdout_wrapper): Likewise.
352 Don't close STDOUT_FILENO explicitly; close_stdout does it.
354 * src/system.h (__attribute__): Readability nit:
356 # define __attribute__(x)
358 # define __attribute__(x) /* empty */
360 2005-04-09 Jim Meyering <jim@meyering.net>
362 * src/rm.c (usage): Mention that --recursive removes listed
363 directories too, not just their contents.
364 Say that by default, rm does not remove directories.
366 * src/pr.c: Don't include "timespec.h". system.h does that.
367 * Makefile.maint (sc_system_h_headers): Propagate exit status
370 2005-04-08 Paul Eggert <eggert@cs.ucla.edu>
372 * NEWS: Document that dd no longer treats QUIT or PIPE specially,
373 and when conforming to POSIX no longer treats USR1 specially.
374 Document that dd no longer dumps core when handling signals.
375 * src/system.h (RETSIGTYPE): Remove; no longer needed. All uses
377 * src/csplit.c (SA_NOCLDSTOP): Define to 0 if not defined.
379 (siginterrupt) [!HAVE_SIGINTERRUPT]: New macro.
380 (delete_all_files): New arg IN_SIGNAL_HANDLER, to avoid undefined
381 behavior when called from a signal handler. All uses changed.
382 (main) [!defined SA_NOCLDSTOP]:
383 Use siginterrupt to specify that system calls should be interrupted.
384 * src/dd.c: Do not include safe-read.h or full-write.h; no longer needed.
385 (process_signals): Add forward decl.
386 (SA_NOCLDSTOP, sigprocmask, sigset_t) [!defined SA_NOCLDSTOP]:
388 (siginterrupt) [! HAVE_SIGINTERRUPT]: New macro.
389 (SA_NODEFER) [!defined SA_NODEFER]: New macro.
390 (SA_RESETHAND) [!defined SA_RESETHAND]: New macro.
391 (caught_signals, interrupt_signal, info_signal_count, catch_siginfo):
393 (usage): Mention -USR1 versus -INFO.
394 (cleanup): Don't invoke print_stats; the caller must do it now.
396 (quit): Process signals just before exiting.
397 (interrupt_handler): Simply record the signal and return.
398 (siginfo_handler): Simply increment the signal counter and return.
399 (install_handler): Remove, replacing with:
400 (install_signal_handlers, process_signals, iread, iwrite):
401 New functions. All callers to safe_read and full_write replaced
402 by iread and iwrite. All callers to install_handler replaced by
404 * src/ls.c (SA_NOCLDSTOP): Define to 0 if not defined.
406 (siginterrupt) [! HAVE_SIGINTERRUPT]: New macro.
407 (main) [! SA_NOCLDSTOP]: Use it.
408 * src/shred.c: Remove all uses of signals; modern hosts have
409 /dev/random and don't need this gorp.
410 Do not include signal.h.
411 (env, sigill_handler, isaac_seed_machdep): Remove. All uses removed.
412 * src/sort.c (SA_NOCLDSTOP): Define to 0 if not defined.
414 (siginterrupt) [! HAVE_SIGINTERRUPT]: New macro.
415 (main) [! SA_NOCLDSTOP]: Use it.
417 * src/dd.c: Do not include inttostr.h, no longer needed.
418 (print_stats, main): Rewrite and simplify formats to use PRIuMAX
419 instead of umaxtostr.
420 (print_stats): Work even in languages that have special
421 forms for two of things, for r_truncate and w_bytes. We can't
422 fix delta_s in this way, since ngettext doesn't support floating-point.
423 (main): Rewrite to avoid casts.
425 2005-04-07 Jim Meyering <jim@meyering.net>
427 Placate gcc-4's -Wuninitialized.
428 * src/md5sum.c (digest_check) [lint]: Initialize hex_digest to NULL.
429 * src/test.c (binary_operator) [lint]: Initialize lt and rt to 0.
431 * src/test.c (is_int, age_of, binop): Declare `char *' parameters to
433 (binop): Move function definition to precede first use so we can...
434 (binop): ...remove prototype.
436 2005-04-05 Paul Eggert <eggert@cs.ucla.edu>
438 * man/Makefile.am (.x.1): Remove "COMMAND.td/" from examples.
439 * src/basename.c (usage): Add examples.
440 * src/cat.c (usage): Likewise.
441 * src/chgrp.c (usage): Likewise.
442 * src/chown.c (usage): Likewise.
443 * src/dirname.c (usage): Likewise.
445 2005-04-05 Jim Meyering <jim@meyering.net>
447 * src/nice.c (usage): Mention that some shells provide a
448 built-in function by the same name.
449 * src/nohup.c (usage): Likewise.
450 * src/printenv.c (usage):Likewise.
452 2005-04-04 Dmitry V. Levin <ldv@altlinux.org>
454 * src/tee.c (tee): When closing files, do not close stdout,
455 leave this job to close_stdout() instead.
456 * configure.ac (AC_CONFIG_FILES): Add tests/tee/Makefile.
457 * tests/Makefile.am (SUBDIRS): Add tee.
458 * tests/tee/Makefile.am: New file.
459 * tests/tee/.cvsignore: Likewise.
460 * tests/tee/{basic,dash}: New tee tests.
462 2005-04-04 Jim Meyering <jim@meyering.net>
464 * src/echo.c (usage): Mention that some shells provide a
465 built-in function by the same name.
466 * src/kill.c (usage): Likewise
467 * src/printf.c (usage): Likewise.
468 * src/pwd.c (usage): Likewise.
469 * src/stat.c (usage): Likewise.
470 * src/test.c (usage): Likewise.
471 * src/true.c (usage):
472 * src/system.h (USAGE_BUILTIN_WARNING): New macro.
474 * man/echo.x: Remove `DESCRIPTION' section, now that --help includes it.
475 * man/printf.x: Likewise.
476 * man/pwd.x: Likewise.
478 2005-04-03 Jim Meyering <jim@meyering.net>
480 * src/pr.c (main): Fix off-by-one error.
481 pr -$(perl -e 'print "0"x63 . 1') would write one byte beyond the
482 end of a malloc'd buffer.
484 2005-04-01 Jim Meyering <jim@meyering.net>
486 * src/pr.c (main): Free column_count_string when done with it.
488 Don't let pr treat +1:-1 like +1:18446744073709551615.
489 * src/pr.c (strtoumax): Remove declaration.
490 (first_last_page): Use xstrtoumax in place of strtoumax,
491 so we don't interpret a negative page number (e.g., in an option
492 like --pages=1:-1) as valid.
493 * tests/pr/Test.pm (neg-page): Add a test for this.
495 2005-03-30 Paul Eggert <eggert@cs.ucla.edu>
497 * src/pinky.c (short_pinky): Adjust to read_utmp signature change.
498 * src/uptime.c (uptime): New arg OPTIONS. All uses changed.
499 * src/users.c (users): Likewise.
500 * src/who.c (who): Likewise.
501 * src/uptime.c (main): Check PIDs when invoked with zero arguments.
502 * src/users.c (main): Likewise.
503 * src/who.c (main): Likewise. Also with two arguments.
504 Omit duplicate code in 2-arg case.
505 (UT_PID): Moved to ../lib/readutmp.h.
507 2005-03-29 Jim Meyering <jim@meyering.net>
509 * src/system.h (ptr_align): Declare `ptr' parameter to be a
510 `const' pointer, since this function never writes through it.
512 * src/uname.c: Indent cpp directives to reflect nesting.
514 2005-03-28 Jim Meyering <jim@meyering.net>
516 * src/seq.c (get_width_format) [HAVE_RINT && HAVE_MODF && HAVE_FLOOR]:
517 Add `void' to make this an ANSI-style function declaration.
518 * src/remove.c (ds_init): Likewise.
519 * src/pr.c (print_sep_string): Likewise.
521 * src/stty.c (speeds): Declare this array to be static.
522 * src/Makefile.am (sc_tight_scope): Adjust to catch any
523 new declarations like that of stty.c's `speeds'.
525 * src/system.h (GETOPT_HELP_OPTION_DECL): Use NULL, not `0'.
526 (GETOPT_VERSION_OPTION_DECL): Likewise.
527 * src/chown.c (long_options): Likewise.
528 * src/chgrp.c (long_options): Likewise.
529 * src/chmod.c (long_options): Likewise.
530 * src/cp.c (sparse_type_string, reply_args, decode_preserve_arg):
532 * src/chown-core.c (chopt_init): Likewise.
533 * src/comm.c (long_options): Likewise.
534 * src/copy.c (copy_reg): Likewise.
535 * src/csplit.c (extract_regexp): Likewise.
536 * src/cut.c (longopts): Likewise.
537 * src/date.c (time_spec_string): Likewise.
538 * src/df.c (find_mount_point, show_point): Likewise.
539 * src/expr.c (docolon): Likewise.
540 * src/fmt.c (long_options): Likewise.
541 * src/ls.c (time_style_args, indicator_style_args, long_options)
542 (format_args, sort_args, time_args, decode_switches)
543 (gobble_file): Likewise.
544 * src/md5sum.c (long_options): Likewise.
545 * src/mv.c (reply_args): Likewise.
546 * src/paste.c (longopts): Likewise.
547 * src/pinky.c (print_entry): Likewise.
548 * src/pr.c (long_options): Likewise.
549 * src/ptx.c (long_options, format_args): Likewise.
550 * src/readlink.c (longopts): Likewise.
551 * src/sort.c (long_options, mergefps): Likewise.
552 * src/stat.c (long_options): Likewise.
553 * src/tac.c (main): Likewise.
554 * src/tail.c (follow_mode_string): Likewise.
555 * src/touch.c (longopts, time_args): Likewise.
556 * src/uniq.c (delimit_method_string): Likewise.
557 * src/uptime.c (print_uptime): Likewise.
558 * src/who.c (print_user): Likewise.
560 2005-03-27 Jim Meyering <jim@meyering.net>
562 * src/dcgen: Simplify further, clean up.
563 Add a standard-output-closing global destructor.
565 * src/wheel-gen.pl: Use the same global destructor as dcgen.
567 2005-03-26 Paul Eggert <eggert@cs.ucla.edu>
569 * src/dcgen: Squeeze multiple blanks into one. Output a simple
570 array of adjacent strings rather than a more complicated data
571 structure; this saves space in the dircolors executable.
572 * src/dircolors.c (parse_line): Use char *, not unsigned char *.
574 (dc_parse_stream, main): Avoid casts.
575 Adjust to simpler data structure generated by new dcgen.
577 2005-03-25 Eric Blake <ebb9@byu.net> (tiny change)
579 * src/ls.c (usage): Document usage of LS_COLORS.
581 2005-03-25 Paul Eggert <eggert@cs.ucla.edu>
583 * src/dircolors.hin: Add "TERM cygwin".
585 2005-03-25 Jim Meyering <jim@meyering.net>
587 * src/system.h (DECIMAL_DIGIT_ACCUMULATE): Reverse the sense of
588 the return value, and update callers:
589 * src/cut.c (set_fields): Update use of DECIMAL_DIGIT_ACCUMULATE.
590 * src/expand.c (parse_tab_stops, main): Likewise.
591 * src/split.c (main): Likewise.
592 * src/unexpand.c (parse_tab_stops, main): Likewise.
593 * src/uniq.c (main): Likewise.
595 2005-03-22 Jim Meyering <jim@meyering.net>
597 * build-aux: New directory. Renamed from config.
598 * configure.ac: Reflect renaming: config -> build-aux.
599 * Makefile.am (dist-hook): Likewise.
600 * Makefile.maint: Likewise.
601 * Makefile.cfg (cvs_files): Likewise.
602 * .x-sc_sun_os_names: Likewise.
603 * .x-sc_trailing_blank: Likewise.
605 * src/ls.c (get_funky_string): Use '\a', rather than 7, for
606 portability to EBCDIC hosts.
608 2005-03-20 Jim Meyering <jim@meyering.net>
610 * src/pr.c (init_header): Add missing `%' in new format string.
611 (init_header): Use zero-filled `.%09d' format, not space-filled `.%9d'.
613 2005-03-19 Jim Meyering <jim@meyering.net>
615 * src/Makefile.am (pr_LDADD): Now that pr uses gettime, add
616 $(LIB_CLOCK_GETTIME) to get the required -lrt on newer Linux systems.
618 2005-03-18 Paul Eggert <eggert@cs.ucla.edu>
620 * NEWS: pr -D "FORMAT" now accepts the same formats that
622 * src/pr.c: Include strftime.h, timespec.h.
623 (init_header): Obtain and format nanosecond part of time stamp.
625 * NEWS: nohup now ignores the umask when creating nohup.out.
626 nohup now closes stderr if it is a terminal and stdout is closed.
627 * src/nohup.c (main): Likewise. Be a little more paranoid about
628 return values; e.g., check for any negative return from open.
629 Assume free (NULL) works.
630 Close file descriptor leak when redirecting standard output to a file.
632 2005-03-17 Jim Meyering <jim@meyering.net>
634 * src/cut.c (set_fields): Use DECIMAL_DIGIT_ACCUMULATE macro,
635 in place of functionally-equivalent code.
636 * src/expand.c (parse_tab_stops, main): Likewise.
637 * src/split.c (main): Likewise.
638 * src/unexpand.c (parse_tab_stops, main): Likewise.
639 * src/uniq.c (main): Likewise.
640 * src/od.c: Use VERIFY macro in place of an equivalent open-coded
642 * src/system.h (VERIFY, VERIFY_EXPR, DECIMAL_DIGIT_ACCUMULATE):
645 Before, this command would make uniq skip 11 fields and print
647 $ _POSIX2_VERSION=1 ./uniq -f1 -1 <(seq --format='1 %g' 2)
650 * src/uniq.c (main): Interpret `uniq -f1 -1' like `uniq -f1',
651 not like `uniq -f11'.
653 2005-03-15 Jim Meyering <jim@meyering.net>
655 Both `pr -0' and e.g., `pr -03' would evoke `column count too large'.
656 `pr -0' should give a better diagnostic and `pr -03' should be
657 equivalent to `pr -3'.
658 * src/pr.c (parse_column_count): Change return type to void.
659 Call error (EXIT_FAILURE, ... for an invalid string.
660 (main): Allocate space for column_count_string using malloc.
661 Accumulate all old-style column-count digits before converting.
662 When the number of columns is specified via both old-style,
663 (e.g., -3), and a long option (--columns=5), ensure that only
664 the last one specified takes effect.
665 * tests/pr/Test.pm: Add tests for the above.
667 2005-03-15 Corinna Vinschen <corinna@vinschen.de> (tiny change)
669 * src/copy.c (copy_reg): Copy regular files in binary mode.
671 2005-03-14 Paul Eggert <eggert@cs.ucla.edu>
673 * NEWS: Restate why ls limits time stamp lengths.
675 2005-03-12 Jim Meyering <jim@meyering.net>
677 Add a little infrastructure to help prevent future bugs like the
679 * src/stat.c (xstrcat): New function.
680 (print_statfs, print_stat): Add buf_len parameter and convert all
681 uses of strcat to xstrcat. Update callers.
682 (print_it): Call print_func with buf_len parameter.
684 Invoking stat -c FMT with a lone format directive of %s, %f, %h, %s,
685 could cause a buffer overrun error.
686 * src/stat.c (print_it): Allocate 2 more bytes, to accommodate our
687 conversion of the stat %s format string to the longer printf %llu one.
688 Patch from Guochun Shi.
690 2005-03-11 Paul Eggert <eggert@cs.ucla.edu>
692 * src/ls.c (TIME_STAMP_LEN_MAXIMUM): New constant.
693 (long_time_expected_width, print_long_format): Use it, to avoid
694 some possible denial-of-service attacks.
695 * NEWS: Document this.
697 2005-03-11 Jim Meyering <jim@meyering.net>
699 Prompt once again for `mv -i A B' when A and B are hard links
700 to the same file. This fixes a bug introduced by my 2003-04-04
701 (coreutils-5.0.1) change. Reported by Thomas Wolff via Eric Blake.
702 * src/copy.c (abandon_move): New function, factored out of
703 copy_internal, now that this code is being used from two places.
704 (copy_internal): Perform the same interactive-related test for
705 whether it's alright to proceed and (usually) overwrite the
707 * tests/mv/i-4: Add tests for the above.
709 Don't segfault for a very long date format string, e.g.,
710 ls -ld --time-style=+%99999999H .
711 * src/ls.c (long_time_expected_width): Use x2nrealloc, not alloca,
712 so format string abuse cannot provoke stack overflow.
713 (print_long_format): Likewise.
715 Don't segfault for a long header date string, e.g.,
716 echo a|pr -D +%9999999A
717 * src/pr.c (init_header): Use x2nrealloc, rather than alloca.
718 Don't bother with fixed-sized initial buffer; always use x*alloc.
720 * src/pr.c (init_header): Use slightly clearer INT_BUFSIZE_BOUND
721 in place of equivalent INT_STRLEN_BOUND + 1.
722 * src/expr.c (tostring, printv): Likewise.
724 2005-03-09 Paul Eggert <eggert@cs.ucla.edu>
726 * src/system.h: Include intprops.h.
727 (TYPE_SIGNED, TYPE_MINIMUM, TYPE_MAXIMUM, INT_STRLEN_BOUND): Remove;
728 they are now defined in intprops.h.
730 2005-03-09 Jim Meyering <jim@meyering.net>
732 * TODO: Remove entry about named pipes. It was fixed in 5.3.0.
734 2005-03-08 Paul Eggert <eggert@cs.ucla.edu>
736 * src/date.c (usage): Redo to match recent documentation changes.
737 Don't bother documenting which usages are GNU extensions; the list
738 wasn't correct, and is better left to the printed manual anyway.
740 2005-03-06 Jim Meyering <jim@meyering.net>
742 Factor out column-count processing.
743 * src/pr.c: Include "inttostr.h".
744 (parse_column_count): New function.
745 (main): Use the new function for both old-style, -9, and long,
746 --columns=-9, options.
748 * src/cksum.c: Remove `register' keyword.
749 * src/cut.c: Likewise.
750 * src/dd.c: Likewise.
751 * src/env.c: Likewise.
752 * src/factor.c: Likewise.
753 * src/fmt.c: Likewise.
754 * src/fold.c: Likewise.
755 * src/id.c: Likewise.
756 * src/logname.c: Likewise.
757 * src/ls.c: Likewise.
758 * src/pr.c: Likewise.
759 * src/printf.c: Likewise.
760 * src/shred.c: Likewise.
761 * src/sort.c: Likewise.
762 * src/sum.c: Likewise.
763 * src/test.c: Likewise.
764 * src/tsort.c: Likewise.
765 * src/uniq.c: Likewise.
766 * src/wc.c: Likewise.
767 * src/whoami.c: Likewise.
769 2005-03-01 Paul Eggert <eggert@cs.ucla.edu>
771 * src/Makefile.am (nanosec_libs): Remove $(LIB_XANOSLEEP); no
774 2005-03-01 Jim Meyering <jim@meyering.net>
776 * src/copy.c (copy_internal): Change test of source type from
777 !S_ISREG to S_ISLNK. Reported by Paul Eggert in
778 http://lists.gnu.org/archive/html/bug-coreutils/2004-10/msg00050.html.
780 2005-02-28 Jim Meyering <jim@meyering.net>
782 * NEWS: Mention that xnanosleep fixes sleep failure on linux-2.6.8.1.
784 2005-02-21 Paul Eggert <eggert@cs.ucla.edu>
786 * src/Makefile.am (dd_LDADD, shred_LDADD): Add $(LIB_GETHRXTIME).
787 (nanosec_libs): Add $(LIB_XNANOSLEEP). Needed for newer GNU/Linux
788 hosts with clock_gettime.
790 2005-02-20 Paul Eggert <eggert@cs.ucla.edu>
792 * NEWS: Describe user-visible change to dd.
793 * src/Makefile.am (dd_LDADD, shred_LDADD, nanosec_libs):
794 Remove $(LIB_CLOCK_GETTIME). These functions now use
796 * src/dd.c: Include gethrxtime.h, xtime.h.
797 (start_time): Now of type xtime_t, not struct timespec.
798 (print_stats, main): Use gethrxtime rather than gettime.
799 * src/ls.c (time): Remove obsolete decl.
800 (get_current_time): gettimeofday always returns 0, so don't
802 * src/shred.c: Include gethrxtime.h.
803 (isaac_seed): Use gethrxtime rather than a mishmash.
804 * src/touch.c (time): Remove obsolete decl.
806 * tests/misc/split-fail: Don't assume that the current host
807 supports integers wider than 32 bits. Fix comment typo.
808 * tests/od/x8: Likewise.
810 * src/chown-core.c (enum RCH_status): Remove trailing comma,
811 as it's not valid in standard C89.
813 2005-02-15 Jim Meyering <jim@meyering.net>
815 * src/stat.c (human_fstype): Add case/definition for S_MAGIC_XFS
816 so that file systems of type `xfs' are recognized as such.
817 * src/fs.h: Regenerate.
818 Reported by Bernd Eckenfels.
819 * src/stat.c (human_fstype): Likewise for S_MAGIC_JFS/jfs.
820 * src/fs.h: Regenerate.
821 Reported by Andreas Schwab.
823 * src/nice.c (NZERO) [NZERO == 0]: Undefine and define to 20,
824 to work around the invalid definition from Darwin 7.7.0.
825 Test failure reported by Sébastien Maret.
827 2005-02-14 Paul Eggert <eggert@cs.ucla.edu>
829 * src/sort.c (mergefps): Use binary search rather than linear one
830 when comparing new line to lines already in main memory.
831 Idea suggested by James Lemley.
833 2005-02-09 Jim Meyering <jim@meyering.net>
835 * src/copy.c (valid_options): Add an assertion that
836 not both hard_link and symbolic_link are set.
838 2005-02-08 Paul Eggert <eggert@cs.ucla.edu>
840 * NEWS: Document stat -f -c %S, plus changes to default formats.
841 * doc/coreutils.texi (stat invocation): Normalize terminology,
842 capitalization, and sort order to match --help output. Mention %c
843 for file systems. Add new -f -c format %S, and document %s versus %S;
844 problem reported by Jeroen van Wolffelaar.
845 * src/stat.c (usage): Likewise.
846 (STATFS_FRSIZE): New macro.
847 (print_statfs): Use it, for stat -f -c %S.
848 (do_statfs): Change default formats to output %S.
850 2005-02-03 Paul Eggert <eggert@cs.ucla.edu>
852 * src/system.h: Include "memrchr.h".
853 (memrchr) [!HAVE_DECL_MEMRCHR]: Remove decl.
855 2005-02-02 Jim Meyering <jim@meyering.net>
857 * tests/du/8gb: Also adjust the test (s/64/128/) to detect
858 systems that don't support sparse files.
859 Check for $2 -ge 128, rather than $2 = 128, in case
860 there is a file system type that doesn't support sparse files,
861 yet for which metadata takes up additional space.
862 Both reported by Andreas Schwab.
864 2005-02-01 Eric Blake <ebb9@byu.net> (tiny change)
866 * tests/du/8gb: Create a larger test file, so we properly
867 detect that sparse files can be created on NTFS under cygwin.
869 2005-01-30 Jim Meyering <jim@meyering.net>
871 * src/head.c (elide_tail_bytes_pipe): Correct wording in diagnostic.
873 * src/stty.c: Remove unnecessary parentheses in all #if directives.
875 2005-01-29 Eric Blake <ebb9@byu.net> (tiny change)
877 * .cvsignore: Ignore config.cache and config.status.lineno.
878 * src/stty.c [VSWTCH]: Some systems, like Cygwin, use VSWTC
879 instead of VSWTCH, for use with CSWTCH.
881 2005-01-29 Eric Blake <ebb9@byu.net> (tiny change)
883 * tests/Makefile.am (.PHONY): Add check-root and root-hint.
884 * tests/rwx-to-mode: Ignore ACL designation.
885 * tests/setgid-check: Likewise.
886 * tests/chown/separator: Quote user and group names.
888 2005-01-24 Jim Meyering <jim@meyering.net>
890 * src/cp.c (usage): Merge the descriptions of --no-dereference and -P.
891 Suggestion from Johan Boule.
893 2005-01-17 Eric Blake <ebb9@byu.net> (tiny change)
895 * src/Makefile.am (all_programs.list): Strip $(EXEEXT) and remove
897 * man/Makefile.am (all_programs): Revert previous patch; updated
898 all_programs.list fixes this.
899 (.x.1): No need to add $(EXEEXT).
901 2005-01-03 Corinna Vinschen <corinna@vinschen.de> (tiny change)
903 * src/system.h: Use S_BLKSIZE value for ST_NBLOCKSIZE where
906 2005-01-22 Jim Meyering <jim@meyering.net>
908 * Makefile.maint (v_etc_file): The version string has moved to
909 version-etc-fsf.c, search that new file, not version-etc.c.
911 2005-01-17 Paul Eggert <eggert@cs.ucla.edu>
913 * tests/group-names: Use numeric group ids, not symbolic group names,
914 since the latter can have shell metacharacters in them (e.g., spaces).
915 Problem reported by Eric Blake.
916 * tests/chgrp/basic: Assume groups are numeric, not symbolic.
917 * tests/chgrp/deref: Likewise.
918 * tests/chgrp/posix-H: Likewise.
919 * tests/chgrp/recurse: Likewise.
921 2005-01-15 Jim Meyering <jim@meyering.net>
923 * src/shred.c (isaac_seed) [HAVE_GETHRTIME]: #if-0 this block,
924 because just calling gethrtime evokes an `illegal instruction'
925 failure when compiled with Sun's c89 on Solaris 8 and 9.
926 Reported by Nelson Beebe.
928 * src/shred.c (isaac_seed) [HAVE_GETHRTIME]: Don't call ISAAC_SEED
929 twice with the same value of `t'.
930 Replace nested #if-#else blocks with #if-#elif-#elif chain.
932 2005-01-14 Jim Meyering <jim@meyering.net>
934 The test, tests/tail/f-1, failed on powerpc-apple-darwin7.7.0.
935 * src/tail.c (IS_TAILABLE_FILE_TYPE): Adjust definition also to include
936 sockets, since that's what you get when reading from a command-line-
937 supplied pipe on Darwin 7.7.
938 (IS_PIPE_LIKE_FILE_TYPE): Define.
939 (main): Use new IS_PIPE_LIKE_FILE_TYPE rather than simply S_ISFIFO.
940 Reported by Nelson Beebe.
941 This same change is also required on NetBSD/sparc-1.5.
942 Reported by Adrian Bunk.
944 * src/expr.c (toarith): Rewrite to detect/diagnose integer overflow,
945 rather than suffering silently.
946 Before, expr would silently overflow and wrap around:
947 $ expr 9223372036854775808 = 0 # $(echo 2^63|bc)
949 Now it detects the problem and exits nonzero:
950 $ ./expr $(echo 2^63|bc) = 0
951 ./expr: 9223372036854775808: integer is too large
953 * tests/chown/separator (id_gn): Exit 77, not 1, for a test-framework
954 failure, so that doesn't cause `make check' to stop. Nelson Beebe
955 reported that this test would fail with the diagnostic,
956 `cannot find name for group ID 10', on one of his systems.
958 2005-01-13 Jim Meyering <jim@meyering.net>
960 * src/test.c (is_int): Don't overflow when evaluating integer
961 constants. Before, ./test $(echo 2^64|bc) -eq 0 && echo FAIL
964 * tests/Fetish.pm (run_tests): Add code (if-0'd out) to detect
965 names of temporary files that would clash on 8.3 file systems.
966 * tests/mk-script (validate): Likewise.
968 2005-01-12 Jim Meyering <jim@meyering.net>
970 * tests/dd/skip-seek: Shorten test names to accommodate 8.3 systems.
972 * tests/tr/Test.pm (repeat-xC): Change test name from
973 `repeat-Compl', to avoid 8.3 conflict with `repeat-compl'.
974 Reported by Eric Blake.
975 (repeat-000): Rename to `repeat-zeros' for the same reason.
977 2005-01-11 Jim Meyering <jim@meyering.net>
979 * configure.ac: Update version to 5.3.1.
981 2005-01-11 Eric Blake <ebb9@byu.net>
983 * src/Makefile.am (check-README, check-AUTHORS): Account for $(EXEEXT).
984 * man/Makefile.am (all_programs): Account for $(EXEEXT).
986 2005-01-11 Jim Meyering <jim@meyering.net>
988 * src/unexpand.c (add_tab_stop): Properly diagnose a tabstop list
989 with decreasing values.
991 * src/expand.c (main): Likewise.
992 * src/unexpand.c (main): Check for overflow in tabstop values
993 specified via the obsolete form. E.g., now this command fails:
994 _POSIX2_VERSION=1 ./unexpand -$(echo '2^64+1'|bc)
995 Before it would act like `_POSIX2_VERSION=1 ./unexpand -1'.
996 * tests/unexpand/basic-1 (obs-ovflo): New test for this.
998 2005-01-10 Paul Eggert <eggert@cs.ucla.edu>
1000 Respond to POSIX interpretations about pathchk -p dated 2005-01-06.
1001 * NEWS: Document the changes.
1002 * doc/coreutils.texi (pathchk invocation): Likewise.
1003 * src/pathchk.c (PORTABILITY_OPTION): New constant.
1004 (longopts, usage, main, validate_file_name):
1005 Add support for new -P option.
1006 Reject empty file names (unless -p is not specified and the
1007 current system allows empty file names).
1008 Change --portability so that is now equivalent to -p -P.
1009 Don't test whether file name is too long, if it is known to exist.
1010 (no_leading_hyphen): New function.
1011 * tests/misc/pathchk1: Add tests for empty file names and
1014 2005-01-08 Jim Meyering <jim@meyering.net>
1018 `pr --columns=N' was not equivalent to `pr -N' when also using
1021 * src/pr.c (main): Set `explicit_columns' for --columns=N,
1022 not just for -N. This bug has existed since the introduction
1023 of the --columns=N option on 1998-08-15.
1024 * NEWS: Document this.
1025 * tests/pr/Test.pm (test_vector): For each -N test, automatically
1026 create a new test vector using --columns=N.
1028 2005-01-07 Paul Eggert <eggert@twinsun.com>
1030 * src/pr.c (main): Check for column count overflow with
1031 usages like "pr -2147483648".
1033 2005-01-07 Jim Meyering <jim@meyering.net>
1035 * src/pr.c (init_fps): Use xnmalloc, rather than xmalloc.
1037 2005-01-06 Jim Meyering <jim@meyering.net>
1039 * README: List the precise HP-UX version numbers that are affected.
1040 Suggestion from Bob Proulx.
1042 * Makefile.maint (sc_changelog): Specify find's `-maxdepth 2'
1043 predicate before `-name ChangeLog' to avoid a harmless warning
1046 2005-01-05 Jim Meyering <jim@meyering.net>
1048 * tests/help-version: Punt on the uptime test, since it fails when
1049 it can't get boot time, and I don't want that to stop `make check'.
1051 * src/du.c (process_file): Evaluate exclusion rules against
1052 the entire file name, not just the last component.
1053 Reported by Robert Lindgren.
1054 * tests/du/exclude: Test for this.
1055 * NEWS: Document this.
1057 Ensure that tests/Makefile.am's check-root actions stay up to date.
1058 * Makefile.maint (sc_root_tests): New rule.
1059 (syntax-check-rules): Add it to the list.
1061 2005-01-04 Jim Meyering <jim@meyering.net>
1063 * man/shred.x: Change one-line summary to reflect that shred does
1064 not remove files by default. Suggestion from Helen Faulkner in
1065 http://bugs.debian.org/288552
1067 * README: Request VERBOSE=yes output when reporting test failures.
1068 Other minor changes.
1070 * tests/Makefile.am (check-root): Update.
1072 2005-01-03 Paul Eggert <eggert@cs.ucla.edu>
1074 * src/system.h: Undo previous change; we now use Autoconf.
1076 2005-01-03 Jim Meyering <jim@meyering.net>
1078 * tests/stty/row-col-1: Don't set rows or columns to zero, to avoid
1079 a bug in the TIOCGWINSZ ioctl on at least Solaris5.9 systems. Setting
1080 either (or both) to zero would succeed, but subsequent `stty size'
1081 would say `no size information for this device' due to the ioctl
1082 failing with EINVAL.
1084 * src/system.h: If PRIdMAX, PRIoMAX, PRIuMAX, and PRIxMAX are
1085 not all defined and either ULONG_MAX or ULLONG_MAX is not defined,
1086 then fail at compile-time rather than let tools like od produce
1087 invalid results at run time.
1089 2004-12-21 Jim Meyering <jim@meyering.net>
1091 * src/csplit.c (usage): Say the default names are `xx00, xx01, ...',
1092 not `xx01, xx02, ...'.
1093 Reported by Matt Kraai in http://bugs.debian.org/286605
1095 * tests/misc/split-fail: Avoid spurious failure on x86 Solaris5.9
1098 2004-12-20 Paul Eggert <eggert@cs.ucla.edu>
1100 * src/split.c (usage): Mention default size. Suggested by Dan Jacobson.
1102 2004-12-19 Paul Eggert <eggert@cs.ucla.edu>
1104 * NEWS: Mention that one should eval "`dircolors`" rather than
1107 2004-12-17 Jim Meyering <jim@meyering.net>
1109 * tests/mv/hard-link-1: Rearrange to use newer trap-handling code,
1110 so temporary directories aren't left behind upon e.g., interrupt.
1112 2004-12-16 Paul Eggert <eggert@cs.ucla.edu>
1114 * src/ls.c (print_dir): Use "%s: not listing already-listed
1115 directory", not "not listing already-listed directory: %s", to
1116 format already-listed directories, to be consistent with other
1117 diagnostics involving file names and colons.
1119 2004-12-15 Jim Meyering <jim@meyering.net>
1121 * src/Makefile.am (__LDADD): Define, so that building `[' on
1122 Solaris still uses the -lgen library that it requires in order
1123 to get a definition of eaccess.
1125 2004-12-14 Jim Meyering <jim@meyering.net>
1127 tac would exit immediately upon I/O or temp-file creation failure.
1128 Now it continues on, processing any remaining command line arguments.
1130 * src/tac.c: Include quotearg.h.
1131 Use quotearg_colon in most diagnostics.
1132 (copy_to_temp): Rewrite not to exit upon I/O or temp-file-creation
1133 failure. Before, this command (with /full/tmp being a full partition)
1134 TMPDIR=/full/tmp ./tac /proc/modules tac.c
1135 would exit immediately upon the write error while trying to copy
1136 non-seekable /proc/modules to the full partition. Now it still
1137 reports the failure but continues on with the remaining file.
1138 (tac_nonseekable): Return false also if copy_to_temp fails.
1139 [DONT_UNLINK_WHILE_OPEN]: Add a FIXME comment explaining that
1140 using atexit like this is wrong.
1141 * NEWS: Document this.
1142 * tests/misc/tac-continue: New test for this.
1143 * tests/misc/Makefile.am (TESTS): Add tac-continue.
1145 * tests/chown/basic: Add a few more tests.
1147 2004-12-13 Paul Eggert <eggert@cs.ucla.edu>
1149 * src/ls.c (gobble_file): Change arg name to be command_line_arg
1150 rather than explicit_arg, for consistency with copy.c.
1151 (extract_dirs_from_files): Remove ignore_dot_and_dot_dot arg, since
1152 it is deducible from dirname arg. All callers changed.
1153 (extract_dirs_from_files, print_dir, queue_directory):
1154 Add command_line_arg arg. All callers changed.
1155 (struct pending): Add command_line_arg member.
1156 (main): Use NULL rather than 0 when appropriate.
1157 (set_exit_status, file_failure): New functions.
1158 (queue_directory): Store command_line_arg into new structure.
1159 (print_dir, gobble_file, get_link_name):
1160 Use file_failure to report problems in accessing files,
1161 so that the exit status is set consistently.
1162 (print_dir): Simplify readdir failure code yet again.
1163 If closedir fails, report "closing directory" rather than "reading
1165 (xstrcoll): Use set_exit_status to set status on failure.
1166 * tests/ls-2/tests (no-a-isdir-b): This now exits with status 2,
1169 2004-12-11 Jim Meyering <jim@meyering.net>
1171 Avoid a race condition vulnerability in chown, when used with
1172 --from=O:G and without the (-h) --no-dereference option.
1173 * src/chown-core.c (restricted_chown): New function.
1174 (change_file_owner): Call it.
1175 Reported by Ulrich Drepper.
1176 * NEWS: Mention this.
1178 2004-12-09 Paul Eggert <eggert@cs.ucla.edu>
1180 * ls now exits with status 1 on minor problems, 2 if serious trouble.
1181 * NEWS: Document this.
1182 * src/ls.c (LS_MINOR_PROBLEM, LS_FAILURE): New constants.
1183 All uses of EXIT_FAILURE replaced with LS_FAILURE, unless
1185 (main): Initialize exit failure to LS_FAILURE.
1186 (print_dir, gobble_file, get_link_name, xstrcoll):
1187 Set exit status to LS_MINOR_PROBLEM if the failure is minor.
1188 (print_dir): Do not give up on entire directory merely because readdir
1190 (usage): Explain exit status.
1191 * tests/help-version: ls and variants now exit with status 2
1194 2004-12-08 Paul Eggert <eggert@cs.ucla.edu>
1196 * NEWS: Document new UTC+HH:MM date syntax, and put date changes
1199 2004-12-07 Paul Eggert <eggert@cs.ucla.edu>
1201 * src/factor.c (factor): Don't list 1 as a factor of 1.
1202 Problem reported by Thomas Folz-Donahue.
1204 2004-12-06 Jim Meyering <jim@meyering.net>
1206 * tests/du/files0-from: Sanitize environment.
1207 Otherwise, e.g., BLOCKSIZE=k would cause a failure, and that
1208 setting is the default (exported from /etc/profile) on at least one
1210 * tests/du/no-deref: Likewise.
1211 * tests/cp/symlink-slash: Likewise.
1212 * tests/ls/symlink-slash: Likewise
1214 2004-12-05 Jim Meyering <jim@meyering.net>
1216 * tests/tail/Test.pm (err-6) ["tail -c"]: Avoid test failure when
1217 _POSIX2_VERSION=199209 is in the environment, or when building on
1220 2004-12-04 Jim Meyering <jim@meyering.net>
1222 * NEWS: Mention cut's new --complement option.
1224 2004-10-01 Paolo Bonzini <bonzini@gnu.org>
1226 * cut.c (complement, COMPLEMENT_OPTION): New.
1227 (longopts): Add --complement.
1228 (usage): Say not that -b, -c, and -f `print' fields,
1229 but rather that they `select' fields for printing.
1230 Describe the new --complement option.
1231 (mark_range_start): Extracted from set_fields.
1232 (print_kth): Support --complement.
1233 (compare_ranges): New function.
1234 (set_fields): Rewrite the part that populates range_start_ht,
1235 merging it with the part that populates printable_field.
1236 (main): Handle --complement.
1238 2004-12-03 Paul Eggert <eggert@cs.ucla.edu>
1240 * src/tail.c (tail_file): Set errnum to -1 if the initial "tail"
1241 failed. This works around an assertion failure reported by
1243 http://lists.gnu.org/archive/html/bug-coreutils/2004-12/msg00012.html
1245 2004-12-02 Jim Meyering <jim@meyering.net>
1247 With using --color and with LS_COLORS saying not to color
1248 executables, don't stat every file.
1249 * src/ls.c (is_colored): New function.
1250 (gobble_file): Use it.
1251 (main): Use it here, in place of too-strict tests against NULL:
1252 if either ORPHAN or MISSING was set to 0 from LS_COLORS, the
1253 old test would fail.
1255 2004-12-01 Paul Eggert <eggert@cs.ucla.edu>
1257 * src/comm.c (compare_files): Assume setlocale exists.
1258 * src/join.c (keycmp): Likewise.
1259 * src/seq.c (decimal_point): Treat like sort. Now char.
1261 (main): Assume localeconv exists. Use same code as sort.
1262 * src/sort.c (C_DECIMAL_POINT): Remove. Use changed to '.'.
1263 Assume setlocale exists.
1264 (thousands_sep): Renamed from th_sep.
1265 (IS_THOUSANDS_SEP): Remove. All uses replaced by comparisons.
1266 (NONZERO): Parenthesize use of arg.
1267 (numcompare): Avoid duplicate loads. Use ISDIGIT as boolean, for
1268 consistency. Avoid unnecessary negation by reversing
1270 (main): Rewrite localeconv call to match seq.c.
1271 * src/system.h: Assume locale.h exists.
1272 (HAVE_SETLOCALE): Remove.
1273 * src/uniq.c (different): Assume setlocale exists.
1275 * src/ls.c (sort_files): Minor cleanup. Remove an unnecessary
1276 'volatile' on a local variable. Rewrite to avoid unnecessary
1277 double-assignment to 'func' in the usual case where strcoll does
1280 2004-11-30 Paul Eggert <eggert@cs.ucla.edu>
1282 * src/pinky.c (gethostname): Remove decl.
1283 (scan_entries): Use IS_USER_PROCESS instead of by-hand code.
1284 * src/uptime.c (print_uptime): Use IS_USER_PROCESS and
1285 UT_TYPE_BOOT_TIME instead of by-hand code.
1286 * src/users.c (list_entries_users): Use IS_USER_PROCESS
1287 instead of by-hand code.
1288 * src/who.c (USER_PROCESS, RUN_LVL, INIT_PROCESS, LOGIN_PROCESS,
1289 DEAD_PROCESS, BOOT_TIME, NEW_TIME, UT_TYPE_UNDEF, UT_TYPE): Remove.
1290 (IS_USER_PROCESS): Move to ../lib/readutmp.h.
1291 (UT_TYPE_RUN_LVL, UT_TYPE_INIT_PROCESS, UT_TYPE_LOGIN_PROCESS,
1292 UT_TYPE_DEAD_PROCESS, UT_TYPE_NEW_TIME): New macros.
1293 (gethostname): Remove decl.
1294 (list_entries_who, scan_entries): Use the new macros defined above,
1295 for consistency with pinky, uptime, and users.
1297 2004-11-25 Paul Eggert <eggert@cs.ucla.edu>
1299 Fix problem reported by Scott S. Tinsley for HP-UX 11.11 using
1300 HP's ANSI C compiler. Declaring int functions causes warnings on
1301 some modern systems and shouldn't be needed to compile on ancient
1303 * src/copy.h (stat, lstat, rename): Remove decls.
1304 * src/install.c (stat): Remove decl.
1305 * src/ln.c (link, symlink): Remove decls.
1307 2004-11-25 Jim Meyering <jim@meyering.net>
1309 * man/help2man: Import help2man-1.35.1.
1310 * man/Makefile.am (.x.1): Remove now-unnecessary use of
1311 locally-added --program-name=NAME option. Now, help2man gets
1312 the name from the [NAME] section (i.e. from our .x file).
1313 * man/install.x: Use `install', not `ginstall' in the one-line
1314 description. Reported by Brendan O'Dea.
1315 * man/sha1sum.x: Use `sha1sum', not `shasum'.
1317 2004-11-24 Jim Meyering <jim@meyering.net>
1319 Since the changes of 2004-05-22, the u.saved_cwd member at
1320 the bottom of the active-directory stack was no longer
1321 strictly necessary. This change removes that member and uses
1322 the newer cwd_state parameter for the final restore_cwd.
1324 * src/remove.c (struct AD_ent) [u]: Remove now-unnecessary union.
1325 [dev_ino]: Rename from `a'.
1326 (AD_pop_and_chdir): Add a parameter to play the role of just-removed
1327 bottom-of-stack cwd-state member.
1328 (AD_pop_and_chdir): No longer return boolean. Adjust caller.
1329 (AD_push_initial): Remove CWD parameter. Adjust caller.
1331 2004-11-23 Paul Eggert <eggert@cs.ucla.edu>
1333 Minor performance improvements and cleanups for "touch".
1334 * src/touch.c (posix_date): Remove; not needed as a static var.
1336 (touch): Use new futimens function to operate more efficiently
1337 in some cases. Don't stat/fstat existing file when
1338 (!amtime_now && change_times == (CH_ATIME | CH_MTIME)); the
1339 old time stamps aren't needed in that case.
1340 (main): change_times is int, not bool. Simplify test for
1343 2004-11-20 Paul Eggert <eggert@cs.ucla.edu>
1345 * src/install.c (usage): Avoid usage that runs afoul of Docbook
1346 translation. Problem reported by Eric S. Raymond.
1348 Restore dd's noctty flag, reverting the change of 2004-04-08.
1349 POSIX does not allow "dd" to use O_NOCTTY by default.
1350 * NEWS: Add noctty flag to dd.
1351 * doc/coreutils.texi (dd invocation): Likewise.
1352 * src/dd.c (flags, usage, main): Likewise.
1354 2004-11-19 Alfred M. Szmidt <ams@gnu.org>
1356 * src/ls.c (usage): Clarified description of --no-group (-G),
1357 --human-readable (-h), --inode (-i), --size (-s), --time,
1360 2004-11-19 Jim Meyering <jim@meyering.net>
1362 * src/ls.c (usage): Clarify description of --author.
1363 Tweak indentation so that help2man creates better nroff.
1364 Reported by Dan Jacobson.
1366 * src/uniq.c (check_file): Don't check stdout for errors here.
1368 * src/pwd.c (find_dir_entry): Update comment to match reality.
1370 2004-11-18 Jim Meyering <jim@meyering.net>
1372 * src/pwd.c (robust_getcwd): Correct the comment: this function
1373 constructs the directory name. The caller prints it.
1375 2004-11-16 Paul Eggert <eggert@cs.ucla.edu>
1377 * src/stat.c (STATFS): New macro, for portability to Solaris 9.
1378 (do_statfs): Use it.
1380 * src/basename.c, src/chroot.c, src/cksum.c, src/dd.c, src/dirname.c,
1381 src/factor.c, src/hostid.c, src/hostname.c, src/link.c, src/logname.c,
1382 src/nohup.c, src/printenv.c, src/pwd.c, src/setuidgid.c, src/sleep.c,
1383 src/sync.c, src/tsort.c, src/unlink.c, src/uptime.c, src/users.c,
1384 src/whoami.c, src/yes.c (main): Use getopt_long rather than getopt.
1385 * src/readlink.c (main): argv is not const.
1387 * src/cut.c (usage): Improve documentation along the lines suggested
1389 * src/echo.c (usage): Likewise.
1390 * src/expr.c (usage): Likewise.
1392 * src/dircolors.hin: Add putty, screen-bce.
1394 * src/pinky.c (print_entry): Fix memory leak.
1395 * src/who.c (print_user): Likewise.
1397 2004-11-15 Paul Eggert <eggert@cs.ucla.edu>
1399 * NEWS: New dd operand "status=noxfer".
1400 * src/dd.c (C_ASCII, C_EBCDIC, C_IBM, C_BLOCK, C_UNBLOCK,
1401 C_LCASE, C_UCASE, C_SWAB, C_NOERROR, C_NOTRUNC, C_SYNC, C_TWOBUFS,
1402 C_NOCREAT, C_EXCL, C_FDATASYNC, C_FSYNC): Now constants, not
1404 (STATUS_NOXFER, statuses): New constants.
1405 (usage, print_stats, scanargs): Add support for status=noxfer.
1406 (usage): Update status output to match new behavior.
1407 (print_stats): Always output complete byte count.
1408 Put space between numbers and units, as SI requires.
1409 Use ngettext so that i18n can use plurals for "byte" and "second".
1410 Don't multiply by 1e-9 (inexact); divide by 1e9 (which is exact).
1411 (iflag_error_msgid, oflag_error_msgid): Remove; replace uses by
1413 * tests/dd/skip-seek (@Tests): Use status=noxfer to avoid
1414 problems with regression testing.
1416 2004-11-14 Paul Eggert <eggert@cs.ucla.edu>
1418 * NEWS: dd now outputs total bytes, seconds, and bytes per second.
1419 * src/Makefile.am (dd_LDADD): Add $(LIB_CLOCK_GETTIME).
1420 * src/dd.c: Include "human.h".
1421 (w_bytes, start_time): New vars.
1422 (usage): Document new I/O statistics output
1423 (print_stats): Output new I/O statistics.
1424 (cleanup): Do statistics after closing stdin and stdout, so that
1425 the times are more accurate.
1426 (write_output, dd_copy): Count output bytes.
1427 (main): Get initial value of clock.
1429 2004-11-14 Jim Meyering <jim@meyering.net>
1431 Backslash-escape `-'s in email addresses, so that they are
1432 rendered properly in UTF-locales.
1433 * man/help2man (escape_hyphens): New function.
1434 (main): Call it on email addresses.
1436 * src/sort.c (zaptemp): Mark new diagnostic for translation.
1438 * tests/misc/close-stdout: New file. Test today's closeout.c change.
1439 * tests/misc/Makefile.am (TESTS): Add close-stdout.
1441 2004-11-13 Jim Meyering <jim@meyering.net>
1443 * src/test.c (usage): Put the description of `[-n] STRING'
1444 on two lines, one for `-n STRING' and one for `STRING' so that
1445 help2man properly escapes the `-'. Otherwise, the hyphen is
1446 rendered inappropriately in UTF-8 locales.
1447 Reported by Uwe Zeisberger in http://bugs.debian.org/281069.
1449 2004-11-12 Paul Eggert <eggert@cs.ucla.edu>
1451 * NEWS: Document the following changes.
1453 * src/sort.c: Avoid O(N**2) behavior when there are many temporary
1455 (temptail): New variable, so that we can easily append to list.
1456 (create_temp_file): Create new files at end of list, so that
1457 searching the list has O(N*NMERGE) behavior instead of O(N**2).
1458 (zaptemp): Update temptail if needed.
1459 (mergefps, merge): Accept new arg that counts temp files, and keep it
1460 up to date as we create and remove temporaries. This is for
1461 efficiency, so that we don't call zaptemp so often.
1462 All callers changed.
1463 (sort): Don't create array in reverse order, since the list of
1464 temporaries is now in the correct order.
1466 (zaptemp): Protect against race condition: if 'sort' is
1467 interrupted in the middle of zaptemp, it might unlink the
1468 temporary file twice, and the second time this happens the file
1469 might already have been created by some other process.
1471 (zaptemp): Warn if a temporary file is not removed.
1473 (create_temp_file): Use offsetof for clarity.
1474 (die): Move it up earlier, to clean up the code a bit.
1476 * src/pr.c (strtoumax): Declare if not declared.
1477 (skip_to_page, first_page_number, last_page_number, page_number,
1478 first_last_page, print_header):
1479 Use uintmax_t for page numbers.
1480 (first_last_page): Remove unnecessary forward declaration.
1481 Do not modify arg (it is now a const pointer).
1482 Return a true if successful, false (without print a diagnostic)
1484 (main): If +XXX does not specify a valid page range, treat it
1485 as a file name. This follows the response to Open Group XCU ERN 41
1486 <http://www.opengroup.org/sophocles/show_mail.tpl?source=L&listname=austin-group-l&id=7717>,
1487 which says the behavior is allowed.
1488 (skip_to_page): When starting page number exceeds page count,
1489 print both numbers in the diagnostic.
1490 (print_header): Detect page number overflow.
1492 2004-11-07 Jim Meyering <jim@meyering.net>
1494 * src/uname.c [__APPLE__]: Include <mach/machine.h> and <mach-o/arch.h>.
1495 (main) [__APPLE__]: Get the processor type via syscall rather than
1496 hard-coding "powerpc". From Toby Peterson.
1498 * src/sort.c (merge): Remove declarations of now-unused variables.
1500 2004-11-06 Paul Eggert <eggert@cs.ucla.edu>
1502 * src/sort.c (first_same_file): Remove. Move most of the code to....
1503 (avoid_trashing_input): New function.
1504 (merge): Avoid some silly merges, e.g., copying a single file to
1505 a temporary file when there are exactly 17 input files to merge.
1506 Take a count of temporary files rather than a max_merge arg.
1509 2004-11-06 Jim Meyering <jim@meyering.net>
1511 * src/sort.c (xfclose): Don't close stdout here (just flush it),
1512 since close_stdout now closes stdout unconditionally.
1514 2004-11-05 Paul Eggert <eggert@cs.ucla.edu>
1516 * src/sort.c (inittables, sort_buffer_size, getmonth, mergefps,
1517 first_same_file, merge, sort, main): Use size_t for indexes to arrays.
1518 This fixes some unlikely havoc-wreaking bugs (e.g., more than INT_MAX
1520 (getmonth, keycompare, compare): Rewrite to avoid need for alloca,
1521 thus avoiding unchecked stack overflow in some cases. As a side
1522 effect this improve the performance of "sort -M" by a factor of 4
1525 2004-11-03 Paul Eggert <eggert@cs.ucla.edu>
1527 * src/stty.c: Include "vasprintf.h" since we use vasprintf now.
1529 * src/Makefile.am (check-AUTHORS): Don't assume \? works in a sed
1530 expression; it's not portable. Problem reported by Albert Chin.
1531 Don't invoke a program more than once.
1532 * src/groups.sh (version): New variable, containing author info,
1533 for benefit of AUTHORS check. Use it when acting on --version option.
1534 * AUTHORS: Remove duplicate lines. Remove bogus "chroot:"
1537 * src/system.h: Don't #define and #undef getopt around <stdlib.h>,
1538 as this breaks the new regime that does "#define getopt rpl_getopt".
1539 Problem reported by Albert Chin for Solaris 9 with Sun cc in:
1540 http://lists.gnu.org/archive/html/bug-gnulib/2004-11/msg00019.html
1541 I suppose this may cause problems on ancient hosts with
1542 incompatible getopt declarations, but we'll cross that bridge if
1543 the problem gets reported to us by someone who can test the fix.
1545 2004-11-03 Jim Meyering <jim@meyering.net>
1547 * src/tac.c: quote(...) file names in diagnostics.
1549 2004-10-29 Paul Eggert <eggert@cs.ucla.edu>
1551 * NEWS: Document getdate changes.
1553 2004-10-29 Jim Meyering <jim@meyering.net>
1555 * src/tac.c (tac_file): Remove temporary prototype and move this
1556 function `down' so that it precedes definition of tac_nonseekable.
1558 `tac /proc/modules' would print nothing
1559 Reported by Harald Dunkel in http://bugs.debian.org/278604.
1561 * src/tac.c (copy_to_temp): Renamed from save_stdin, since
1562 now it copies a general file descriptor, not just stdin.
1563 (tac_nonseekable): Renamed/adapted from tac_stdin.
1564 (tac_file): Get fd via `open' directly rather than via fopen/fileno,
1565 since we never used the stream. Perform "-" to stdin mapping here
1566 rather than in main. Determine whether a file is seekable,
1567 by trying to `lseek' to its end, and dispatch to tac_seekable or
1568 tac_nonseekable accordingly.
1569 (main): Rewrite argument handling now that it uses only tac_file.
1570 * NEWS: Mention it here.
1572 2004-10-21 Jim Meyering <jim@meyering.net>
1574 * tests/mv/leak-fd: New file.
1575 * tests/mv/Makefile.am (TESTS): Add it.
1576 * tests/rm/dot-rel: New file.
1577 * tests/rm/Makefile.am (TESTS): Add it.
1579 Correct my patch of 2004-10-18.
1580 * src/remove.c (rm): Destroy the saved_cwd here (via cwd_state),
1581 if necessary, not in remove_dir. Otherwise, removing multiple
1582 `.'-relative nonempty directories no longer worked.
1584 2004-10-20 Paul Eggert <eggert@cs.ucla.edu>
1586 * src/fmt.c (usage): Improve description of --prefix.
1587 Problem reported by Edward Welbourne.
1589 * man/uniq.x: Change summary so that it doesn't imply that
1590 uniq writes to its input file. Problem reported by
1593 2004-10-18 Jim Meyering <jim@meyering.net>
1595 Plug a leak that would cause a cross-device mv to fail when
1596 operating on too many command-line-specified nonempty directories.
1597 * src/remove.c (remove_dir): Destroy the `struct saved_cwd' on the
1598 top of the stack before returning. This usually closes the file
1599 descriptor that was used to return to the original working directory.
1600 Reported by Cyril Bouthors in
1601 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/3048
1602 * NEWS: Mention it here.
1604 * src/pathchk.c (validate_file_name): Give a more descriptive
1605 diagnostic when pathconf fails. This also avoids an unwarranted
1606 warning from gcc-3.3.5 about a format not being a string literal.
1608 * src/sleep.c (main): Remove declaration of unused local, c.
1609 * src/printenv.c (main): Likewise.
1610 * src/logname.c (main): Likewise.
1611 * src/uptime.c (main): Likewise, for optc.
1612 * src/tsort.c (main): Likewise, for opt.
1614 2004-10-17 Paul Eggert <eggert@cs.ucla.edu>
1616 * AUTHORS: Add self to pathchk.
1617 * src/pathchk.c (AUTHORS): Add self.
1618 Change "path" to "file name" whenever possible.
1619 Remove usage comment, as it was a duplication of the code or doc.
1620 Include <wchar.h> if available.
1621 (mbrlen, mbstate_t) [! (HAVE_MBRLEN && HAVE_MBSTATE_T)]: Define.
1622 (NEED_PATHCONF_WRAPPER, PATH_MAX, PATH_MAX_FOR, NAME_MAX,
1623 pathconf_wrapper, portable_chars, dir_ok): Remove.
1624 (NAME_MAX_MINIMUM, PATH_MAX_MINIMUM): New macros.
1625 (pathconf, _PC_NAME_MAX, _PC_PATH_MAX): Define if nonexistent.
1626 (portable_chars_only): New arg FILELEN.
1627 Don't assume ASCII; we might be on an EBCDIC host.
1628 Don't assume unibyte locale in diagnostic.
1629 (component_start, component_len): New functions.
1630 (validate_file_name): Renamed from validate_path. All uses changed.
1631 Pretty much a complete rewrite.
1632 Don't make copy of file arg. Always append trailing slash to
1633 pathconf arg, just in case it's a symlink (this is pure paranoia;
1634 we don't know of any hosts where the trailing slash is required).
1635 Use size_t instead of long int when possible.
1636 Avoid need to call pathconf in most practical cases.
1637 Don't use euidaccess several times to test searchability;
1638 just use lstat once. Reword diagnostic to put the (often very long)
1641 2004-10-15 Paul Eggert <eggert@cs.ucla.edu>
1643 * src/printf.c (usage): Mention Unicode, and use H for hex digits.
1645 2004-10-13 Jim Meyering <jim@meyering.net>
1647 * NEWS: Mention today's fts.c fix.
1649 2004-10-13 Paul Eggert <eggert@cs.ucla.edu>
1651 * tests/stty/row-col-1: Set LC_ALL=C.
1653 2004-10-12 Jim Meyering <jim@meyering.net>
1655 * src/dircolors.hin: Add .flac and .mpc as audio suffixes.
1656 From Jesus Climent in http://bugs.debian.org/276149.
1658 2004-10-05 Paul Eggert <eggert@cs.ucla.edu>
1660 * src/ls.c (ignore_mode): Renamed from ignore, to avoid shadowing
1661 problems. All uses changed.
1663 2004-10-05 Jim Meyering <jim@meyering.net>
1665 * .x-sc_trailing_blank: Add an exclusion for config/texinfo.tex,
1666 since Karl says its trailing blanks are there to stay :-)
1668 2004-10-04 Paul Eggert <eggert@cs.ucla.edu>
1670 * src/expr.c (NEW, OLD): Remove, partly to avoid
1671 reference to obsolescent macro XMALLOC.
1672 All uses replaced by xmalloc and free.
1674 2004-09-28 Jim Meyering <jim@meyering.net>
1676 * src/tail.c (usage): Clarify: --retry works only with --follow=name.
1677 Reported by Nik A. Melchior in http://bugs.debian.org/273781.
1679 2004-09-27 Paul Eggert <eggert@cs.ucla.edu>
1681 * src/od.c (format_address_paren): c is optional, so don't output
1684 2004-09-26 Paul Eggert <eggert@cs.ucla.edu>
1686 Add support for ls --hide. Idea suggested by Bardur Arantsson.
1687 * NEWS: Document this.
1688 * src/ls.c (file_ignored): Renamed from file_interesting, with
1689 inverted return value. Accept the file name, not a struct dirent *.
1690 All uses changed. Avoid the expense of calling fnmatch if the
1691 file is ignorable due to leading '.'.
1692 (all_files, really_all_files): Removed; replaced by:
1693 (ignore): New variable. All uses changed.
1694 (IGNORE_DEFAULT, IGNORE_DOT_AND_DOTDOT, IGNORE_MINIMAL, HIDE_OPTION):
1696 (hide_patterns): New variable.
1697 (long_options, decode_switches, file_ignored, usage):
1698 Add support for --hide.
1699 (patterns_match): New function.
1700 (usage): Replace "hide" with "ignore" in explanation, to avoid
1703 2004-09-25 Paul Eggert <eggert@cs.ucla.edu>
1705 * src/ls.c (gobble_file, print_long_format): Don't assume that
1706 human-readable output has a byte count equal to its column width;
1707 this isn't always true in locales where the radix character is not
1709 (format_user_or_group): Revamp code to match the above fix;
1710 this avoids the (very faint) possibility of integer overflow.
1712 2004-09-24 Paul Eggert <eggert@cs.ucla.edu>
1714 * NEWS: Mention that "chmod -r -w x" now works as expected.
1715 * src/chmod.c (main): Revamp option processing to support this.
1716 * tests/chmod/Makefile.am (TESTS): Add 'usage'.
1717 * tests/chmod/usage: New set of tests for usage like that.
1719 2004-09-24 Jim Meyering <jim@meyering.net>
1721 * Makefile.maint (CVS_LIST): Use --types=AFGM option so that
1722 it lists only cvs-controlled regular files.
1724 * src/csplit.c (xalloc_die): Declare to be `extern', not `static'
1725 to avoid a warning from gcc-3.4.1. Reported by Paul Eggert.
1727 2004-09-23 Paul Eggert <eggert@cs.ucla.edu>
1729 * Makefile.maint (CVS_LIST): New macro.
1730 (sc_space_tab, sc_prohibit_atoi_atof, sc_file_system,
1731 sc_prohibit_jm_in_m4, sc_system_h_headers, sc_sun_os_names,
1732 sc_trailing_blank, po-check): Use it instead of the
1733 nonstandard "cvsu --list".
1735 * src/tail.c (parse_obsolete_option): Bring back support
1736 for obsolete option followed by non-obsolete, or by more
1737 than one file. When obsolete, conform to SUSv2 rather than
1738 original POSIX 1003.2-1992, as SUSv2 corrected the case of
1739 "tail -c". Add support for the SUSv2 "b" modifier.
1740 * NEWS: Mention the above.
1741 * tests/tail/Test.pm: New test case obs-b to check the above.
1742 err-[134] no longer need _POSIX2_VERSION=199209.
1743 Fix comments to match revised behavior.
1745 2004-09-22 Jim Meyering <jim@meyering.net>
1747 * Use automake-1.9.2. Regenerate dependent files.
1749 * src/remove.c (struct dirstack_state) [current_arg_jumpbuf]:
1750 Improve the comment.
1752 Clean up scoping etc. so that some make `distcheck' tests pass.
1753 * src/csplit.c (xalloc_die): Declare to be static.
1754 * src/chown-core.c (chown_files): Declare as `extern'.
1755 * src/cp-hash.c (remember_created): Likewise.
1756 * src/copy.c (copy): Likewise.
1757 * src/checksum.h (enum) [ALG_MD5]: Define to be 1, not 0.
1759 * src/id.c, src/nl.c, src/expand.c: Remove trailing blanks.
1760 * src/unexpand.c: Likewise.
1762 * src/Makefile.am (check-AUTHORS): New rule.
1763 (check): Depend on it.
1766 * Makefile.maint (syntax-check-rules): Remove duplicate sc_tight_scope.
1767 (sc_system_h_headers): Also exclude copy.h; it includes <stdbool.h>.
1769 2004-09-22 Paul Eggert <eggert@cs.ucla.edu>
1771 * src/ls.c (decode_switches): Don't compare a short value
1772 to SIZE_MAX: GCC sometimes complains.
1774 2004-09-21 Paul Eggert <eggert@cs.ucla.edu>
1776 * NEWS: The following commands now reject unknown options:
1777 basename dirname factor hostname link nohup sync unlink yes
1778 Also, pathchk no longer accepts trailing options.
1780 * src/basename.c: Include <getopt.h>.
1781 * src/chroot.c: Likewise.
1782 * src/dirname.c: Likewise.
1783 * src/factor.c: Likewise.
1784 * src/hostid.c: Likewise.
1785 * src/hostname.c: Likewise.
1786 * src/nohup.c: Likewise.
1787 * src/pwd.c: Likewise.
1788 * src/setuidgid.c: Likewise.
1789 * src/sync.c: Likewise.
1791 * src/basename.c (main): Reject unknown options.
1792 * src/dirname.c (main): Likewise.
1793 * src/factor.c (main): Likewise.
1794 * src/hostid.c (main): Likewise.
1795 * src/hostname.c (main): Likewise.
1796 * src/link.c (main): Likewise.
1797 * src/nohup.c (main): Likewise.
1798 * src/pwd.c (main): Likewise.
1799 * src/setuidgid.c (main): Likewise.
1800 * src/sync.c (main): Likewise.
1801 * src/unlink.c (main): Likewise.
1802 * src/yes.c (main): Likewise.
1804 * src/cat.c (main): Remove unused "case 0".
1805 * src/chgrp.c (main): Likewise.
1806 * src/chmod.c (main): Likewise.
1807 * src/chown.c (main): Likewise.
1808 * src/comm.c (main): Likewise.
1809 * src/cp.c (main): Likewise.
1810 * src/csplit.c (main): Likewise.
1811 * src/cut.c (main): Likewise.
1812 * src/date.c (main): Likewise.
1813 * src/df.c (main): Likewise.
1814 * src/du.c (main): Likewise.
1815 * src/env.c (main): Likewise.
1816 * src/expand.c (main): Likewise.
1817 * src/fold.c (main): Likewise.
1818 * src/head.c (main): Likewise.
1819 * src/id.c (main): Likewise.
1820 * src/install.c (main): Likewise.
1821 * src/join.c (main): Likewise.
1822 * src/ln.c (main): Likewise.
1823 * src/ls.c (decode_switches): Likewise.
1824 * src/mkdir.c (main): Likewise.
1825 * src/mkfifo.c (main): Likewise.
1826 * src/mknode.c (main): Likewise.
1827 * src/mv.c (main): Likewise.
1828 * src/nl.c (main): Likewise.
1829 * src/paste.c (main): Likewise.
1830 * src/pinky.c (main): Likewise.
1831 * src/pr.c (main): Likewise.
1832 * src/ptx.c (main): Likewise.
1833 * src/readlink.c (main): Likewise.
1834 * src/rm.c (main): Likewise.
1835 * src/rmdir.c (main): Likewise.
1836 * src/seq.c (main): Likewise.
1837 * src/shred.c (main): Likewise.
1838 * src/split.c (main): Likewise.
1839 * src/sum.c (main): Likewise.
1840 * src/tac.c (main): Likewise.
1841 * src/tail.c (main): Likewise.
1842 * src/tee.c (main): Likewise.
1843 * src/touch.c (main): Likewise.
1844 * src/tr.c (main): Likewise.
1845 * src/tty.c (main): Likewise.
1846 * src/uname.c (main): Likewise.
1847 * src/unexpand.c (main): Likewise.
1848 * src/wc.c (main): Likewise.
1849 * src/who.c (main): Likewise.
1851 * src/chroot.c (main): Use getopt where it suffices, not getopt_long.
1852 * src/cksum.c (main): Likewise.
1853 * src/dd.c (main): Likewise.
1854 * src/logname.c (main): Likewise.
1855 * src/printenv.c (main): Likewise.
1856 * src/sleep.c (main): Likewise.
1857 * src/tsort.c (main): Likewise.
1858 * src/uptime.c (main): Likewise.
1859 * src/users.c (main): Likewise.
1860 * src/whoami.c (main): Likewise.
1862 * src/du.c (long_options): Standardize on NULL vs 0.
1863 * src/rm.c (long_opts): Likewise.
1865 * src/logname.c (long_options): Remove.
1866 * src/printenv.c (long_options): Likewise.
1867 * src/sleep.c (long_options): Likewise.
1868 * src/tsort.c (long_options): Likewise.
1869 * src/uptime.c (longopts): Likewise.
1870 * src/users.c (longopts): Likewise.
1871 * src/whoami.c (long_options): Likewise.
1873 * src/pathchk.c (longopts): Add --help, --version.
1874 (main): Use longopts rather than parse_long_options.
1875 * src/stty.c (longpts, main): Likewise.
1877 * src/pathchk.c (main): Don't reorder arguments, so that
1878 we can check weird file names.
1880 * src/readlink.c: Don't include "long-options.h".
1881 * src/sort.c: Likewise.
1882 * src/stty.c: Likewise.
1884 * src/split.c (verbose): Now bool, not int.
1885 (VERBOSE_OPTION): New enum.
1886 (longopts, main): Use it.
1888 * tests/factor/basic: Adjust to new wording in diagnostic
1889 that results from the above changes.
1891 2004-09-21 Jim Meyering <jim@meyering.net>
1893 * man/rm.x: Say "the response is affirmative" rather than "the
1894 response begins with y or Y", so that the documentation is
1895 accurate in non-English locales. Problem reported by Munzir Taha.
1897 2004-09-19 Paul Eggert <eggert@cs.ucla.edu>
1899 * src/echo.c (main): Don't pass NULL to strcmp when
1900 POSIXLY_CORRECT and given no arguments.
1902 * src/md5sum.c (STRING_OPTION): Remove.
1903 (long_options, main): Remove support for undocumented and
1904 obsolete --string option, as suggested in the 1996-09-26 patch.
1905 * NEWS: Document this.
1907 * tests/rm/fail-eperm: Don't try to remove writeable files in a
1908 sticky /tmp directory, as SVR4-like systems (e.g., Solaris 9) let
1909 you remove such files. Problem reported by Bert Fischer in:
1910 http://lists.gnu.org/archive/html/bug-coreutils/2004-09/msg00074.html
1912 2004-09-18 Paul Eggert <eggert@cs.ucla.edu>
1914 * src/md5sum.c (STATUS_OPTION, STRING_OPTION): New enums.
1915 (long_options, main): Use them instead of magic numbers 2 and 1.
1916 For --string, optarg can't possibly be NULL.
1918 * src/dd.c (usage): Distinguish between options and operands.
1919 (scanargs): Don't mess with argc, argv; getopt_long handles this now.
1920 Say "operands" for operands, not "options".
1921 (main): Use getopt_long, so that "dd --" works as POSIX requires.
1922 * tests/dd/misc: Check for "dd --".
1924 * src/chroot.c (main): Reject unknown options instead of
1925 interpreting them as a directory to chroot to.
1927 * src/cksum.c: Remove obsolete comment about POSIX 1003.2/D11.2.
1928 The current standard (POSIX 1003.1-2004) is correct.
1929 (crc_remainder) [defined CRCTAB]: Renamed from "remainder" to avoid
1930 collision with builtin function.
1931 (main) [defined CRCTAB]: Output in lowercase hexadecimal, and
1932 output the first 0 as 8 digits, to make it easier to compare to
1933 the text of the standard. Output crctab to be a const array.
1934 (crctab): Use result of above changes.
1935 (long_options): Remove; not needed if empty.
1936 (main): getopt_long can't return 0 here, so simplify the code.
1938 2004-09-13 Jim Meyering <jim@meyering.net>
1940 * src/Makefile.am (localedir.h): Don't redirect directly to target.
1942 2004-09-13 Paul Eggert <eggert@cs.ucla.edu>
1944 * src/id.c (print_full_info): Don't exit with failure status simply
1945 because a user or group number can't be turned into a name.
1946 Problem reported by Felipe Kellermann in:
1947 http://lists.gnu.org/archive/html/bug-coreutils/2004-09/msg00081.html
1949 2004-09-12 Jim Meyering <jim@meyering.net>
1951 * Makefile.maint (my-distcheck): When building with -Werror, also
1954 2004-09-10 Paul Eggert <eggert@cs.ucla.edu>
1956 * NEWS: "tail" now handles obscure POSIX 1003.2-1992 cases better.
1957 * src/tail.c (parse_obsolete_option): Renamed from
1958 parse_obsolescent_option, since the options are obsolete now.
1959 Remove bool *arg; just exit if there's an error. Revamp to follow
1960 POSIX 1003.2-1992 more precisely, to handle cases like "tail -
1961 file" and "tail -10 -- file" correctly when we are conforming to
1963 (main): Adjust to this change.
1964 * tests/tail/Test.pm (test_vector): minus-* requires
1965 _POSIX2_VERSION=199209 now, to work correctly if there is
1966 an input file. err-1 and err-3 no longer errors if there
1969 2004-09-09 Paul Eggert <eggert@cs.ucla.edu>
1971 * src/test.c (usage): Document -r, -w, -x more carefully.
1973 2004-09-08 Paul Eggert <eggert@cs.ucla.edu>
1975 * src/test.c (usage): Document "test" (with no args) and "[ ]".
1976 Document that -h and -L don't dereference.
1978 * NEWS: Document that "tr xy -z" now works as per POSIX.
1979 Sort the descriptions.
1980 * src/tr.c (main): Don't reorder options.
1981 * tests/tr/Test.pm (fowler-1): New test case.
1983 2004-09-06 Paul Eggert <eggert@cs.ucla.edu>
1985 * src/touch.c (main): Fix POSIX-conformance bug: "touch --
1986 MMDDhhmm file" must be treated like "touch MMDDhhmm file" when
1987 conforming to pre-2001 POSIX.
1988 * NEWS: Document this.
1989 * tests/touch/obsolescent: Test for this bug. Also, set
1990 _POSIX2_VERSION=199209 and POSIXLY_CORRECT=1 so that it's
1991 a better test for obsolescent features.
1993 * src/sort.c (main): Emulate Solaris 8 and 9 "sort -y", so that
1994 "sort -y abc" is like "sort abc" whereas "sort -y 100" is like
1997 * src/od.c: Several changes for POSIX and FreeBSD compatibility.
1998 (COMMON_SHORT_OPTIONS): Add -B, -D, -e, -F, -H, -I, -L, -O, -s, -X.
1999 (long_options, main): --strings is now -S, not -s.
2000 (usage): Reflect the usage changes.
2001 (parse_old_offset): Do not issue a diagnostic on failure;
2002 callers now do this as necessary.
2003 (main): Support POSIX syntax. Remove unused case 0 from getopt_long.
2004 Add support for new short options (many undocumented) for
2005 compatibility with FreeBSD. Remove FIXME for -s; it's now
2006 POSIX-compatible. Default format is now oS, not o2.
2007 * NEWS: Describe the above.
2009 2004-09-05 Paul Eggert <eggert@cs.ucla.edu>
2011 * src/stty.c (valid_options): Remove.
2012 (main): Fix some bugs in handling invalid option-combinations
2014 (recover_mode): Arg is now char const *, not char *.
2015 (main): Use STDIN_FILENO, not 0.
2016 Simplify option-parsing code a tad.
2017 * tests/stty/basic-1: Check for the fixed bugs.
2019 2004-09-03 Paul Eggert <eggert@cs.ucla.edu>
2021 * src/stat.c (HAVE_STRUCT_STATXFS_F_TYPE): Fix typo that prevented
2022 it from ever being nonzero. Reported by Pozsar Balazs in:
2023 http://lists.gnu.org/archive/html/bug-coreutils/2004-08/msg00189.html
2024 (human_fstype): Add ramfs, squashfs, sysfs.
2025 Reported by Pozsar Balazs in:
2026 http://lists.gnu.org/archive/html/bug-coreutils/2004-08/msg00188.html
2027 (human_fstype): Return char const *, not char *.
2028 Simplify internals a bit, and avoid casts.
2030 * src/dd.c (usage): "alternated EBCDIC" -> "alternate EBCDIC".
2031 (bit_count): Remove. All uses changed to....
2032 (multiple_bits_set): New function.
2033 (scanargs): Use it, and check separately for each set of
2034 incompatible options, to improve diagnostics.
2036 (apply_translations): Move checks for incompatible options
2037 to scanargs, so that they're done consistently.
2039 2004-09-02 Paul Eggert <eggert@cs.ucla.edu>
2041 Output correct errno-related diagnostic on "paste" I/O errors.
2042 * src/paste.c (write_error, xputchar): New functions.
2043 (paste_parallel): Use correct errno value after input error.
2044 (paste_parallel, paste_serial): Report errno value after output error.
2046 Port to diet libc. Problem reported by Felix von Leitner in:
2047 http://lists.gnu.org/archive/html/bug-coreutils/2004-08/msg00171.html
2048 * src/paste.c (dummy_closed, CLOSED, dummy_endlist, ENDLIST): Remove;
2049 it's not portable C to assume FILE is a complete type.
2050 (paste_parallel): Use index test instead of ENDLIST, and NULL
2053 2004-08-24 Paul Eggert <eggert@cs.ucla.edu>
2055 POSIX-conformance fixes for "expand" and "unexpand".
2056 Also, consistently use "tab stop" rather than "tabstop".
2057 * NEWS: Document fixes.
2058 * src/expand.c: Revamp to resemble the new unexpand.c better.
2059 (usage): -i does not convert tabs after non-tabs.
2060 (add_tab_stop): Renamed from add_tabstop. All uses changed.
2061 (parse_tab_stop): Renamed from parse_tabstop. All uses changed.
2062 (validate_tab_stop): Renamed from validate_tabstop. All uses changed.
2063 (next_file, main): Check fclose against 0, not EOF.
2064 (expand): Remove unnecessary casts.
2065 Add another loop nesting level, for lines, so that per-line variables
2066 are initialized cleanly.
2067 Revamp tab checking. Check for write error immediately, rather
2068 than just once at the end of the program.
2069 * src/unexpand.c: Lkewise (for the expand.c changes).
2070 (TAB_STOP_SENTINEL): Remove.
2071 (tab_size): Now size_t, not uintmax_t, since we need to store
2072 the sequences of blanks.
2073 (max_column_width): New var.
2074 (usage): Say "blank" where POSIX requires this.
2075 (add_tab_stop): Calculate maximum column width.
2076 (unexpand): Store the pending blanks, instead of merely counting them.
2077 Follow POSIX's rules about -a requiring two blanks before a tab stop.
2078 Get rid of internal label and goto.
2079 * tests/unexpand/basic-1: Fix infloop-3 to match POSIX.
2080 Add blanks-1 through blanks-13.
2082 2004-08-19 Paul Eggert <eggert@cs.ucla.edu>
2084 * NEWS: "chown : file", "chown '' file", and "chgrp '' file" now
2085 succeed without changing the uid and gid, like FreeBSD.
2086 * src/chgrp.c (parse_group): Return gid_t rather than storing it
2087 through a pointer. Treat "chgrp '' file" as a no-op change,
2089 (main): Set chopt.group_name to NULL if the group is the empty
2091 * src/chown-core.c (describe_change): Describe changes to -1:-1
2092 without using "to OWNERSHIP" phrase.
2093 * src/chown.c (usage): "chown '' file" is now allowed.
2094 (main): Do not set user name to the empty string if the group
2096 * tests/chgrp/basic: Test "chgrp '' file".
2097 * tests/chown/Makefile.am (TESTS): Add separator.
2098 * tests/chown/separator: New file, partly taken from
2099 Dmitry V. Levin's suggestion in
2100 <http://lists.gnu.org/archive/html/bug-coreutils/2004-08/msg00102.html>
2102 2004-08-11 Paul Eggert <eggert@cs.ucla.edu>
2104 * tests/install/basic-1: Test for the -d regression.
2106 2004-08-11 Dmitry V. Levin <ldv@altlinux.org>
2108 * src/install.c (main): Fix -d regression introduced with
2109 --target-directory support at 2004-06-25.
2111 2004-08-11 Paul Eggert <eggert@cs.ucla.edu>
2113 * src/copy.c (copy_internal): When preserving links, unlink
2114 a destination with link count greater than one. This is so
2115 that commands like "cp -a" don't get confused when copying into
2116 a destination that already contains many hard links. Problem
2117 reported by Tim Waugh in:
2118 http://lists.gnu.org/archive/html/bug-coreutils/2004-08/msg00053.html
2120 2004-08-10 Paul Eggert <eggert@cs.ucla.edu>
2122 Convert all files to UTF-8.
2123 * tests/fmt/basic (8-bit-pfx): Use UTF-8, not Latin-1.
2124 * tests/sort/Test.pm (16a): Likewise.
2125 * tests/uniq/Test.pm (8): Likewise.
2126 * tests/misc/printf-hex: Use ASCII, not Latin-1.
2128 * NEWS: Document "sort -o -" and "tee -" POSIX-conformance fixes.
2129 * src/shred.c (usage): "-" is an operand, not an option.
2130 * src/sort.c (die, xfopen, mergefps, first_same_file, merge):
2131 A null file arg means standard output.
2132 (main): "-o -" means to write to a file named "-",
2133 not to standard output.
2134 * src/tee.c (usage, tee): "tee -" writes to standard output, not
2135 to a file named "-".
2137 2004-08-10 Dmitry V. Levin <ldv@altlinux.org>
2139 * src/install.c (change_timestamps): Fix int->bool conversion
2140 bugs introduced on 2004-07-29.
2142 2004-08-09 Paul Eggert <eggert@cs.ucla.edu>
2144 * src/shred.c (wipename): Work even if the directory is writeable
2145 and not readable. Prefer write access, since this should work
2146 better with fdatasync.
2148 * src/csplit.c (xalloc_die): New function.
2149 (main): Remove now-obsolete initialization of xalloc_fail_func.
2151 * src/md5sum.c: Adjust to sha->sha1 renaming.
2153 2004-08-08 Dmitry V. Levin <ldv@altlinux.org>
2156 * src/readlink.c (canonicalize_fname): Remove unneeded proxy function.
2157 (can_mode): Make variable local.
2159 2004-08-07 Paul Eggert <eggert@cs.ucla.edu>
2161 * src/system.h (O_BINARY) [!O_BINARY && defined O_BINARY]:
2162 Do not define, to avoid annoying compiler messages on QNX 6.3.
2163 Problem reported by Johan in:
2164 http://lists.gnu.org/archive/html/bug-coreutils/2004-08/msg00050.html
2166 2004-08-04 Paul Eggert <eggert@cs.ucla.edu>
2168 * src/system.h (PRIdMAX, PRIoMAX, PRIuMAX, PRIxMAX):
2169 Define to a concatenation of string literals, not to an expression;
2170 needed for concatenation contexts.
2171 (INTMAX_MAX, INTMAX_MIN): New macros.
2173 * src/stat.c (print_stat): Don't assume st_ino / st_dev fits in
2174 unsigned long; this isn't true for st_ino on Solaris 9.
2176 2004-08-03 Paul Eggert <eggert@cs.ucla.edu>
2178 * src/uname.c: Do not depend on HAVE_SYSCTL when deciding
2179 whether to include files. Include <sys/param.h> if
2180 HAVE_SYS_PARAM_H (not HAVE_SYSCTL).
2181 (main) [defined __POWERPC__]: Add a kludge to work around a
2182 Mac OS X bug, so that uname -p defaults to "powerpc" if
2183 sysctl ((int[]) {CTL_HW, HW_MACHINE_ARCH}, 2, buffer, &bufsize, 0, 0)
2184 fails. Problem reported by Petter Reinholdtsen in:
2185 http://lists.gnu.org/archive/html/bug-gnu-utils/2003-02/msg00201.html
2187 * src/uniq.c (hard_LC_COLLATE, ignore_case, different, check_file,
2188 main): Use bool for booleans.
2189 (writeline, check_file): Use uintmax_t for line counts.
2190 (check_file): Check for and report line number overflow,
2192 * src/wc.c (iswspace, wc): Use to_uchar rather than a cast.
2193 (print_lines, print_words, print_chars, print_bytes, print_linelength,
2194 have_read_stdin, wc, wc_file, main):
2195 Use bool for booleans.
2196 (exit_status): Remove.
2197 (wc, wc_file): Return bool status. All callers changed.
2198 * src/who.c (scan_entries): 0 -> STDIN_FILENO.
2199 * src/whoami.c (main): Print uids using unsigned long int, not
2202 * src/unexpand.c: Int cleanup and minor reorganization to be more
2204 Include quote.h, xstrndup.h.
2205 (TAB_STOP_SENTINEL): Increase from INT_MAX to INTMAX_MAX.
2206 (convert_entire_line, have_read_stdin, parse_tabstops, next_file,
2208 Use bool for booleans.
2209 (tab_size, tab_list, add_tabstop, validate_tabstops, unexpand):
2210 Use uintmax_t for column counts.
2211 (first_free_tab, validate_tabstops, unexpand): Use size_t for sizes.
2212 (add_tabstop, parse_tabstops, main): Don't reserve UINTMAX_MAX
2214 (parse_tabstops): Don't use ISBLANK on possibly-signed char.
2215 Detect overflow in tab stop string.
2216 (next_file, main): Use EXIT_FAILURE/EXIT_SUCCESS instead of 1/0.
2217 (unexpand): Concatenate input files the same way expand does.
2219 * src/touch.c (no_create, use_ref, posix_date, amtime_now,
2220 touch, main): Use bool for booleans.
2221 (main): Avoid integer overflow when given more than INT_MAX
2223 * src/tsort.c (struct item, n_strings): Use size_t for sizes.
2224 (have_read_stdin, count_items, scan_zeros, detect_loop,
2225 recurse_tree, walk_tree, tsort, main):
2226 Use bool for booleans.
2227 (exit_status): Remove.
2228 (tsort): Return a success flag instead of storing into a global.
2230 * src/tty.c (silent, main): Use bool for booleans.
2231 (main): 0 -> STDIN_FILENO.
2232 * src/uname.c (print_element): Use bool for booleans.
2234 * src/test.c (TRUE, FALSE, SHELL_BOOLEAN, TRUTH_OR, TRUTH_AND):
2235 Remove. All uses replaced by C99 boolean primitives.
2236 (TEST_TRUE, TEST_FALSE): New constants, for readability.
2237 (test_unop, binop, unary_operator, binary_operator, two_arguments,
2238 three_arguments, posixtest, expr, term, and, or, is_int, age_of,
2239 one_argument, main): Use bool for booleans.
2240 (advance, unary_advance): Now inline procedures rather than a macros.
2241 (is_int): Renamed from isint, to avoid namespace clash with ctype.h.
2242 (term, and, or): When it's easy, loop instead of recursing.
2243 (term): Avoid integer overflow if there are INT_MAX-3 args (!).
2244 (binary_operator, unary_operator): Simplify by systematically rewriting
2245 true==FOO to FOO (where FOO is a boolean).
2246 (unary_operator): Don't consider a file to be a regular file
2247 merely because its mode&S_IFMT is zero. Just use S_ISREG.
2248 Remove unnecessary casts. Remove ifdefs for things like
2249 S_ISSOCK that are no longer needed, since stat-macros.h always
2252 * src/tac-pipe.c (buf_init_from_stdin, find_bol, tac_mem):
2253 Use bool for booleans.
2254 (buf_init_from_stdin, buf_free, find_bol, print_line):
2255 Use size_t for sizes.
2256 * src/tac.c (separator_ends_record, tac_seekable, tac_file,
2257 tac_stdin, tac_stdin_to_mem, main): Use bool for booleans.
2258 (match_length, G_buffer_size, tac_seekable, main): Use size_t for sizes.
2259 (tac_seekable): Use ptrdiff_t for pointer subtraction.
2260 Report an error if the result is out of range.
2261 (tac_seekable, main): Check for integer overflow in buffer size
2263 (main): Remove unnecessary casts.
2265 * src/su.c (run_shell): Pass a new n_additional_args arg, so that
2266 the callee doesn't have to count 'em. All callers changed.
2267 Don't allocate more space for the arg vector than we'll need.
2268 Use memcpy to copy the args rather than rolling our own loop.
2269 Use size_t for sizes.
2270 (fast_startup, simulate_login, change_environment, log_su,
2271 correct_password, restricted_shell, main): Use bool for booleans.
2272 (longopts): Don't assume change_environment is an int.
2273 Use NULL, not 0, for pointers.
2274 (xsetenv): New function, replacing xputenv and concat.
2275 All callers changed.
2276 (elements): Remove; no longer needed.
2277 (log_su, correct_passwd, main): Prefer !x to x==NULL.
2278 (log_su): 2 -> STDERR_FILENO.
2279 (modify_environment, main): Don't assume that getenv's returned value
2280 has an indefinite lifetime.
2281 (modify_environment): Allocate a larger environ.
2282 (main): Remove an impossible 'case 0'; if it happens now, it'll
2283 get diagnosed. Don't assume getpwnam results outlive endpwent.
2284 Check for null or empty pw_name, pw_dir and for null pw_passwd.
2286 * src/stty.c (VA_START): Remove. All callers now use va_start.
2287 (_POSIX_VDISABLE): Remove unnecessary cast.
2288 (struct control_info, visible): Use cc_t for control chars.
2289 (struct control_info): Use size_t for sizes.
2290 (recover_mode, set_mode, display_speed, display_window_size,
2291 valid_options, main, display_changed):
2292 Use bool for booleans.
2293 (integer_arg): Return unsigned long int, not long int.
2294 Accept new max arg; all callers changed, to specify a maximum
2295 value for integer parameters instead of silently overflowing.
2296 (wrap): Do not overrun the stack buffer if the output contains
2297 more than 1024 bytes. Instead, malloc a buffer.
2298 (main): Remove a "what is this?!?" FIXME. Nobody knows what it is.
2299 Remove unnecessary casts.
2300 (set_control_char): Allow int values only up to cc_t range.
2301 (screen_columns): Don't reject INT_MAX.
2302 (display_changed, display_all, display_speed, recover_mode):
2303 Don't assume cc_t fits in int.
2305 * src/remove.h: Add copyright notice.
2306 (struct rm_options): Use bool for booleans.
2307 * src/rmdir.c (empty_paths, ignore_fail_on_non_empty, verbose,
2308 errno_rmdir_non_empty, remove_parents, main): Likewise.
2309 * src/sum.c (have_read_stdin, bsd_sum_file, sysv_sum_file,
2311 (main): Don't dump core if invoked with argv[0]==NULL.
2312 * src/tee.c (tee, append, ignore_interrupts, main, tee):
2313 Use bool for booleans.
2314 (tee): Use ssize_t for read returns.
2316 * src/ptx.c: Add a FIXME mentioning that there are many
2317 unchecked integer overflows in this file.
2318 (gnu_extensions, auto_reference, input_reference, right_reference,
2319 ignore_case, initialize_regex, fix_output_parameters,
2320 output_one_roff_line, output_one_text_line, output_one_dumb_line, main):
2321 Use bool for booleans.
2322 (SKIP_SOMETHING, compare_words, digest_break_file,
2323 find_occurs_in_text, fix_output_parameters):
2324 Use to_uchar instead of a caset.
2325 (print_field): Rewrite to avoid cast.
2327 * src/printf.c (posixly_correct): Use bool for booleans.
2328 (verify, main): Use EXIT_FAILURE/EXIT_SUCCESS instead of 1/0.
2329 (STRTOX): Rewrite to avoid casts.
2330 (print_esc_char): Arg is char, not int.
2331 * src/readlink.c (canonicalize): Remove. All uses now merely inspect
2333 (no_newline, verbose): Use bool for booleans.
2334 (can_mode): Now of type int; use -1 to denote otherwise-uninitialized.
2335 * src/shred.c (struct Options, main): Use bool for booleans.
2336 (isaac_seed_data, fillpattern, wipefile): Rewrite to avoid casts.
2337 * src/split.c (cwrite, bytes_split, lines_split, line_bytes_split):
2338 Use bool for booleans.
2339 * src/stat.c (G_fail): Remove.
2340 (print_statfs): Print various gotta-be-nonnegative values using
2341 unsigned long int, not long int or int.
2342 (do_statfs, do_stat): Return a boolean success flag.
2343 (do_stat, main): Use bool for booleans.
2345 * src/pr.c: Add a FIXME mentioning that there are many
2346 unchecked integer overflows in this file.
2347 (TRUE, FALSE): Remove. All uses replaced by true and false.
2348 (struct COLUMN, read_line, print_page, print_stored, open_file,
2349 skip_to_page, init_fps, parallel_files, align_empty_cols,
2350 empty_line, FF_only, explicit_columns, extremities, keep_FF,
2351 print_a_FF, print_a_header, use_form_feed, have_read_stdin,
2352 print_across_flag, storing_columns, balance_columns,
2353 truncate_lines, join_lines, untabify_input, failed_opens,
2354 numbered_lines, skip_count, use_esc_sequence, use_cntrl_prefix,
2355 double_space, ignore_failed_opens, use_col_separator,
2356 pad_vertically, last_line, main, init_parameters, skip_read,
2357 read_line, print_stored):
2358 Use bool for booleans.
2359 (struct COLUMN, char_to_clump, store_char, print_char):
2361 (clump_buff, print_clump): Use char[], not int[], for an array whose
2362 elements are always chars.
2363 (first_last_page, main, getoptarg, balance, add_line_number,
2364 char_to_uclump): Remove unnecessary casts.
2365 (init_parameters): Allocate chars, not ints, for clump_buff.
2366 (print_char): Use to_uchar before invoking ISPRINT.
2367 (char_to_clump): Convert to unsigned char before invoking ISPRINT.
2369 * src/nohup.c (main): Use bool for booleans.
2370 * src/paste.c (paste_parallel, paste_serial, main): Likewise.
2371 * src/pathchk.c (validate-path, main, portable_chars_only): Likewise.
2372 (portable_chars_only): Use to_uchar rather than a cast.
2373 * src/printenv.c (main): Use bool for booleans.
2374 Do not assume that the environ has at most one matching entry
2375 for each option (integer overflow was possible otherwise).
2377 * src/od.c (FMT_BYTES_ALLOCATED): Now an enum, not a decimal
2378 constant. Do not assume PRIdMAX etc. are strings of length 3 or
2380 (struct tspec): Use it. fmt_string is now an array, not
2381 a pointer, as there's little point to the indirection here.
2382 (struct tspec, flag_dump_strings,
2383 traditional, flag_pseudo_start, limit_bytes_to_format,
2384 abbreviate_duplicate_blocks, have_read_stdin, simple_strtoul,
2385 decode_one_format, open_next_file, check_and_close,
2386 decode_format_string, skip, write_block, read_char, read_block,
2387 parse_old_offset, dump, dump_strings, main):
2388 Use bool for booleans.
2389 (struct tspec): Use void *, not char *, for generic pointers.
2390 (bytes_to_oct_digits, bytes_to_signed_dec_digits,
2391 bytes_to_unsigned_dec_digits, bytes_to_hex_digits):
2392 Use char, not unsigned int, since char suffices.
2393 (print_s_char, print_char, print_s_short, print_short,
2394 print_int, print_long, print_long_long, print_float,
2395 print_double, print_long_double): Rewrite to avoid casts.
2396 These now take void * arguments, instead of char *.
2397 Use the same body for all functions, except for the choice
2398 of type. Assume C89 to simplify handling of signed char.
2399 (dump_hexl_mode_trailer, print_named_ascii, print_ascii):
2400 Rewrite to avoid casts.
2401 (print_named_ascii, print_ascii): Now takes void *, not char *.
2402 (decode_one_format): Use int for printf field widths, not
2403 unsigned int. Pass void * to subsidiary printers,
2404 not char *. Simplify handling of floating-point formats
2405 by factoring out common code dealing with precision and field width.
2406 (decode_format_string): Avoid need for temporary copy of
2407 each decoded struct tspec.
2408 (get_lcm): Remove unnecessary cast.
2409 (main): Fix bug where more than INT_MAX failed decodes were ignored.
2411 2004-08-02 Paul Eggert <eggert@cs.ucla.edu>
2413 * src/nl.c (TRUE, FALSE): Remove; all uses changed to true, false.
2414 (enum number_format): Remove.
2415 (FORMAT_RIGHT_NOLZ, FORMAT_RIGHT_LZ, FORMAT_LEFT): Now strings,
2417 (DEFAULT_SECTION_DELIMITERS): Now an array constant, not a macro.
2418 (section_del): Now const.
2419 (print_fmt): Remove.
2420 (starting_line_number, page_incr, blank_join, line_no,
2421 print_lineno, proc_text, main):
2422 Use intmax_t for line numbers.
2423 (reset_numbers, have_read_stdin, build_type_arg, nl_file, main):
2424 Use bool for booleans.
2425 (lineno_format): Now a string, not an enum value.
2426 (build_print_fmt): Remove. All calls removed. This work is
2427 now done within print_lineno.
2428 (build_type_arg): Use size_t for sizes.
2429 (print_lineno): Check for line number overflow.
2430 (proc_text, main): Remove unnecessary cast.
2432 * src/ln.c (symbolic_link, interactive, remove_existing_files,
2433 verbose, hard_dir_link, dereference_dest_dir_symlinks,
2434 do_link, main): Use bool for booleans.
2436 * src/ls.c (struct fileinfo, file_interesting,
2437 extract_dirs_from_files, color_symlink_as_referent,
2438 FILE_OR_LINK_MODE, sort_reverse, print_owner, print_group,
2439 numeric_ids, print_block_size, dired, print_with_color,
2440 check_symlink_color, print_inode, recursive, immediate_dirs,
2441 all_files, really_all_files, qmark_funny_chars,
2442 print_dir_name, format_needs_stat, format_needs_type, visit_dir,
2443 main, decode_switches, parse_ls_color, print_dir, file_interesting,
2444 gobble_file, make_link_path, basename_is_dot_or_dotdot,
2445 extract_dirs_from_files, print_long_format):
2446 Use bool for booleans.
2447 (dir_defaulted): Remove; no longer needed.
2448 (main): Use int to count files, since it suffices for argv.
2449 Rewrite to avoid need for dir_defaulted.
2450 (main, print_dir, gobble_file, get_link_name,
2452 Set exit status to EXIT_SUCCES/EXIT_FAILURE rather than 0/1.
2453 (decode_switches): Put back check for ws.ws_col <= SIZE_MAX.
2454 Remove unnecessary cast to int. Use int instead of unsigned
2455 int to count from 0 to 1.
2456 (get_funky_string, print_type_indicator): Use char for bytes, not int.
2457 (make_link_path): Use NULL for null pointers.
2458 (quote_name): Use to_uchar instead of cast.
2460 * src/id.c (use_name, main, print_user, xgetgroups, print_group_list,
2461 print_full_info): Use bool for booleans.
2462 (problems): Remove, replacing with....
2463 (ok): New var (inverted from old sense).
2464 (print_user, print_group, print_full_info):
2465 Print uids/gids with %lu, not %u.
2466 (xgetgroups): Don't run out of memory if getgroups or getugroups
2468 * src/setuidgid.c (main): Print uids/gids with %lu, not %ld.
2470 * src/factor.c (wheel_tab): Use unsigned char instead of unsigned
2471 int, since it suffices.
2472 (factor, print_factors): Use size_t for sizes.
2473 (print_factors, do_stdin, main): Use bool for booleans.
2474 * src/fold.c (TAB_WIDTH): New macro; use it instead of "8".
2475 (fold_file, main): Use bool for booleans.
2476 (fold_file, main): Use size_t for sizes.
2477 (main): Allow -w options up to SIZE_MAX - TAB_WIDTH - 1, instead
2478 of prohibiting widths greater than INT_MAX.
2479 * src/head.c (presume_input_pipe, print_headers, have_read_stdin,
2480 write_header, elide_tail_bytes_pipe, elide_tail_bytes_file,
2481 elide_tail_lines_pipe, elide_tail_lines_seekable,
2482 elide_tail_lines_file, head_bytes, head_lines, head, head_file,
2483 string_to_integer, main):
2484 Use bool for booleans.
2485 (main): Rewrite to avoid cast.
2487 * src/csplit.c (struct line): Use size_t for sizes.
2488 (main): Remove unnecessary cast.
2489 * src/cut.c (cut_fields): Use to_uchar rather than a cast.
2490 * src/cut.c (cut_file, main): Use bool for booleans.
2491 * src/date.c (show_date, rfc_format, batch_convert, main): Likewise.
2492 * src/env.c (main): Likewise.
2493 * src/expr.c (nextarg): Likewise.
2494 * src/env.c (main): Remove unused and nonstandard envp arg.
2496 * src/fmt.c (COST, MAXWORDS): Add a comment describing some of
2497 fmt's arbitrary limits.
2498 (TRUE, FALSE): Remove; all uses changed to (true, false).
2499 (main): Use bool for booleans.
2500 Limit maximum width to MAXCHARS / 2. Use xstrtoul, not xstrtol,
2502 (copy_rest): Remove unnecessary cast.
2503 (get_prefix): Rewrite to avoid cast.
2504 (check_punctuation): Use char *, not unsigned char *; C89 requires
2505 this. Avoid off-by-one buffer read overrun when line is empty.
2506 (flush_paragraph): Don't assume wptr-parabuf is <= INT_MAX.
2507 Remove unnecessary casts.
2508 * tests/fmt/basic (wide-1, wide-2, bad-suffix): Adjust to above
2511 * src/expand.c (convert_entire_line, have_read_stdin, parse_tabstops,
2512 next_file, expand, main):
2513 Use bool for booleans.
2514 (tab_size, tab_list, add_tabstop, parse_tabstops, validate_tabstops,
2516 Use uintmax_t for column counts.
2517 (add_tabstop): Don't reserve -1 (now UINTMAX_MAX) as a special value.
2518 All callers changed.
2519 (parse_tabstops): Don't pass a negative char to isblank.
2520 Avoid memory leak with large tab stops.
2521 (validate_tabstops, expand): Don't assume number of tab stops is
2523 (next_file, main): Use EXIT_SUCCESS/EXIT_FAILURE rather than 0/1 when
2524 storing values into exit_status.
2525 (expand): Use same pattern as unexpand for reading chars.
2526 Report an error when input line is too long, instead of silently
2527 screwing up. Do not mishandle tab stops when backspacing left
2530 * src/dircolors.c (have_read_stdin, append_quoted,
2531 dc_parse_stream, dc_parse_file, main): Use bool for booleans.
2532 (dc_parse_stream): Use enum for state, rather than int.
2533 Use ssize_t to store getline result.
2535 * src/dd.c (translation_needed, parse_integer, scanargs,
2536 apply_translations, char_is_saved, swab_buffer, skip_via_lseek):
2537 Use bool for booleans.
2538 (translate_buffer): Use to_uchar rather than a cast.
2539 (swab_buffer, copy_simple, copy_with_unblock):
2540 Use size_t for sizes.
2542 * src/seq.c (equal_width, valid_format, main): Use bool for booleans.
2543 * src/sleep.c (apply_suffix): Likewise.
2544 * src/tail.c (struct File_spec, reopen_inaccessible_files, count_lines,
2545 forever, from_start, print_headers, have_read_stdin, valid_file_spec,
2546 write_header, file_lines, pipe_lines, pipe_bytes, recheck,
2547 tail_forever, tail_bytes, tail_lines, tail, tail_file,
2548 parse_obsolescent_option, parse_options, main): Likewise.
2549 * src/sleep.c (apply_suffix): Invert sense of result.
2550 Use int (not unsigned int) for multiplier, as this generates better
2551 code with some compilers. Simplify code a bit.
2552 * src/tail.c (struct File_spec, max_n_unchanged_stats_between_opens,
2553 parse_options): Use uintmax_t, not unsigned int or unsigned long int,
2555 (tail_bytes, tail_lines): Redo test of return value (-1, 0, 1) to
2556 make it a bit clearer.
2558 * src/hostname.c: Include "xgethostname.h".
2559 (xgethostname): Remove decl; xgethostname.h has it.
2560 (sethostname) [!defined(HAVE_SETHOSTNAME) && defined(HAVE_SYSINFO)
2561 && defined (HAVE_SYS_SYSTEMINFO_H) && defined(HAVE_LIMITS_H)]: Use
2562 prototypes rather than K&R form. Assume any negative value from
2563 sysinfo denotes failure, not just -1.
2564 (main): Simplify use of sethostname.
2566 * src/pinky.c (include_idle, include_heading, include_fullname,
2567 include_project, include_plan, include_home_and_shell, do_short_format,
2568 include_where, main): Use bool for booleans.
2569 (count_ampersands, create_fullname, scan_entries, short_pinky):
2570 Use size_t for sizes.
2571 (create_fullname): Check for overflow in size calculations.
2572 (idle_string): Don't assume that the number of idle days
2573 is less than 10**8 and/or INT_MAX/(24*60*60).
2574 (main): No need to pass a non-NULL last arg to getopt_long.
2575 * src/uptime.c (print_uptime, uptime): Use size_t for sizes.
2576 (print_uptime): Remove unused local variable.
2577 (main): No need to pass a non-NULL last arg to getopt_long.
2578 * src/users.c (list_entries_users, users): Use size_t for sizes.
2579 (list_entries_users): Use char for bytes.
2580 (main): No need to pass a non-NULL last arg to getopt_long.
2581 * src/who.c (do_lookup, short_list, short_output, include_idle,
2582 include_heading, include_mesg, include_exit, need_boottime,
2583 need_deadprocs, need_login, need_initspawn, need_clockchange,
2584 need_runlevel, need_users, my_line_only, main): Use bool for booleans.
2585 (print_runlevel): Use unsigned char for bytes.
2586 (list_entries_who, scan_entries, who): Use size_t for sizes.
2587 (main): No need to pass a non-NULL last arg to getopt_long.
2589 * src/install.c (isdir): Remove decl.
2590 (install_file_to_path): Rely on make_path to fail if the destination
2591 is not a directory, by passing preserve_existing==true to it.
2592 Hence we no longer need to call isdir.
2593 Free dest_dir immediately when it's no longer needed, rather than
2594 waiting until the end of the function.
2595 (copy_file): Don't bother calling isdir, as copy will do the
2596 right thing if the destination is a directory.
2598 * src/du.c (fts_debug, opt_all, apparent_size, opt_count_all,
2599 print_grand_total, opt_separate_dirs, hash_ins, process_file, main):
2600 Use bool for booleans.
2601 (max_depth): Now size_t, not int, to avoid an arbitrary limit
2602 of INT_MAX on depth.
2603 (G_fail): Remove: no longer needed, now that the relevant
2604 functions return bool.
2605 (process_file): Use return value to signal success rather than
2606 setting a global. Remove first_call static var; not needed, since
2607 we can look at n_alloc. Use size_t for depths. Remove FIXME
2608 about size_t casts, as it's now fixed. Use xnrealloc rather
2609 than the obsolescent XREALLOC. Don't bother to check whether
2610 reallocation is needed unless level > prev_level.
2611 (du_files): Invert sense of result, for consistency with
2612 other coreutils code. All callers changed.
2613 (main): Allow --max-depth values up to SIZE_MAX.
2615 * src/df.c (inode_format, show_all_fs, show_local_fs,
2616 show_listed_fs, posix_format, require_sync, print_type,
2617 selected_fstype, excluded_fstype, show_dev, show_point, main):
2618 Use bool for booleans.
2619 (df_readable, show_dev): Use UINTMAX_MAX instead of -1.
2620 (show_dev, show_point, main):
2621 Use EXIT_SUCCESS/EXIT_FAILURE instead of 0/1.
2622 Don't assume disk name lengths are <= INT_MAX.
2623 Rewrite pct calculation to avoid cast.
2624 (show_point): Don't assume resolved length is <= SSIZE_MAX.
2626 * src/cut.c (hash_int) [!defined UINTPTR_MAX]: Use size_t
2627 instead of uintptr_t.
2628 * src/shred.c (UINT_MAX_32_BITS): Remove.
2629 (word32): Remove. All uses changed to uint32_t.
2630 (isaac_seed_data): Remove unnecessary cast.
2631 * src/system.h (ptr_align): Use size_t; in practice, this is just as
2632 good as uintptr_t in checking for alignments, and has fewer
2633 configuration hassles.
2635 * src/Makefile.am (localedir.h): Make it readonly; this
2636 undoes part of the 2004-07-27 patch.
2638 2004-07-30 Paul Eggert <eggert@cs.ucla.edu>
2640 * src/sort.c (UCHAR): Remove; all uses changed to to_uchar.
2641 (IS_THOUSANDS_SEP): Use bool when appropriate.
2642 (numcompare, main): Use char, not int, when the value is always a char.
2643 (numcompare): Remove "register"; compilers are smart enough these days.
2644 * src/system.h (errno, CHAR_BIT): Remove decls;
2645 no longer needed now we assume C89 or better.
2646 Include <inttypes.h> before <stdint.h>, as it's the
2647 Autoconf-recommended pattern.
2648 (to_uchar): New inline function, moved here from tr.c.
2649 Use full names for int types, e.g. "long int" rather than "long".
2650 * src/tr.c (to_uchar): Remove; now in system.h.
2651 (is_char_class_member): Use bool when appropriate.
2653 * src/mkdir.c (create_parents, main): Use bool when appropriate.
2654 (main): Use EXIT_SUCCESS/EXIT_FAILURE instead of 0/1.
2656 2004-07-29 Paul Eggert <eggert@cs.ucla.edu>
2658 * src/mkfifo.c (main): Use EXIT_SUCCESS and EXIT_FAILURE, not 0 and 1.
2660 * src/chmod.c (recurse, force_silent, process_file, process_files,
2661 main): Use bool when appropriate.
2662 * src/cksum.c (cksum, main): Likewise.
2663 * src/comm.c (hard_LC_COLLATE, only_file_1, only_file_2, both,
2664 compare_files, main): Likewise.
2666 * src/copy.h (struct cp_options): Likewise.
2667 * src/copy.c (copy_internal, is_ancestor, copy_dir, copy_reg,
2668 same_file_ok, seen_file, copy_internal, valid_options, copy): Likewise.
2669 * src/cp-hash.h (remember_created): Likewise.
2670 * src/cp-hash.c (remember_created): Likewise.
2671 * src/cp.c (struct dir_attr, flag_path, remove_trailing_slashes,
2672 re_protect, make_path_private, target_directory_operand, do_copy,
2673 cp_option_init, decode_preserve_arg, main): Likewise.
2674 * src/install.c (isdir, change_timestamps, change_attributes,
2675 copy_file, install_file_to_path, install_file_in_dir,
2676 install_file_in_file, strip_files, dir_arg, cp_option_init, main,
2677 change_attributes, change_timestamps): Likewise.
2678 * src/mv.c (remove_trailing_slashes, rm_option_init,
2679 cp_option_init, do_move, movefile, main): Likewise.
2680 * src/remove.c (right_justify), full_filename_, AD_pop_and_chdir,
2681 AD_push, prompt, remove_dir): Likewise.
2682 * src/rm.c (rm_option_init, main): Likewise.
2684 * src/remove.c (top_dir, pop_dir, full_filename_):
2685 Use size_t for sizes.
2686 * src/cp.c (target_directory_operand): Do not clear *NEW_DST if stat
2687 succeeds. It's not necessary in that case, as *NEW_DST is always
2689 (do_copy): Rewrite slightly to avoid need for "unreachable" comment.
2690 (main): Use EXIT_SUCCESS, EXIT_FAILURE instead of 0, 1.
2691 * src/rm.c (main): Likewise.
2693 md5sum, sha1sum integer cleanups.
2695 * src/checksum.h: Don't include config.h, sys/types.h, stdio.h:
2697 (ALG_UNSPECIFIED): Remove.
2698 (ALG_MDT): Don't make it equal to CHAR_MAX + 1; this isn't necessary.
2699 * src/md5.c: Don't include any files other than checksum.h.
2700 * src/sha1sum.c: Likewise.
2701 * src/md5sum.c (OPENOPTS, have_read_stdin, status_only, warn,
2702 bsd_split_3, split_3, hex_digits, digest_file, digest_check, main):
2703 Use bool when appropriate.
2704 (digest_check): Increase limit of number of input lines to
2705 UINTMAX_MAX from INT_MAX. Diagnose any overflows of this counter.
2706 Use ngettext instead of hard-to-i18nize hardcoded stuff for plurals.
2708 2004-07-28 Paul Eggert <eggert@cs.ucla.edu>
2710 * src/cat.c (exit_status): Remove. Now done by passing a boolean
2712 (simple_cat, cat): Return true if successful. All callers changed.
2713 (simple_cat, cat, main): Use bool for booleans.
2714 (simple_cat): Use size_t for sizes.
2715 (cat, main): Use the same names for parameters that we use for
2716 long options, to avoid confusion. This inverts the sense of the
2717 show_tabs (formerly output_tabs) and number_nonblank
2718 (formerly numbers_at_empty_lines) variables.
2719 (main): Don't mess up (due to integer overflow) if we are given
2720 INT_MAX - INT_MIN + 1 options.
2721 [O_BINARY]: Don't invoke isatty unless the other options require it.
2722 (main): When deciding whether to use simple_cat, don't worry
2723 about binary option; it's irrelevant.
2725 * src/dcgen: Remove comments, trailing white space, and empty
2726 lines from the output strings, to save space.
2727 Use a narrower type like 'unsigned char' for line lengths, if
2729 Make the output variables static, not extern.
2731 * src/chgrp.c (parse_group): Require base 10 when parsing
2733 (main): int -> bool when appropriate.
2734 * src/chown.c (main): Likewise.
2735 * src/chown-core.c: Include inttostr.h.
2736 (UINT_MAX_DECIMAL_DIGITS, uint_to_string): Remove.
2737 (gid_to_name, uid_to_name): Use imaxtostr/umaxtostr
2738 instead of uint_to_string).
2739 (describe_change): Instead of an int flag, use a char *
2740 auxiliary; this avoids the need for casts.
2741 Assume free (NULL) works.
2742 (change_file_owner): Return true/false, not 0/-1, since
2743 we don't set errno. All callers changed.
2744 Use bool when appropriate.
2745 (chown_files): Likewise.
2746 * src/chown-core.h (chown_files): Likewise.
2748 * tests/chown/basic: Test for proper handling of uids like
2749 "010", which must be parsed as decimal.
2751 * tests/misc/pwd: Don't assume that Perl's getpwd agrees with our
2752 pwd when there are multiple names for the working directory
2753 (which can happen with an automounter, sigh).
2755 * src/Makefile.am ($(SCRIPTS)): Don't depend on Makefile;
2756 this causes Solaris 8 'make' to refuse to build "groups".
2757 (localedir.h): Don't depend on Makefile: this causes Solaris
2758 8 'make' to build localedir.h unnecessarily. The dependence
2759 on Makefile is ineffective anyway, since $(localedir) might
2760 change even if Makefile hasn't.
2762 * src/remove.c (remove_dir): If we can't save the state of the
2763 working directory, pretend we started from "/", not ".".
2764 This avoids a bug on hosts like Solaris that don't let you
2765 remove the working directory.
2767 2004-07-27 Paul Eggert <eggert@cs.ucla.edu>
2769 * src/printf.c (strtiomax, strtoumax): Declare if not already
2770 declared: this fixes a portability bug with Solaris 8 + GCC.
2771 (STRTOX): Parenthesize use of macro arg as expression.
2772 (vstrtoimax, vstrtoumax, vstrtold): Remove now-unnecessary
2774 * configure.ac: Check for declaration of strtoumax, for
2777 * src/Makefile.am (cp_LDADD, ginstall_LDADD, mv_LDADD,
2778 pathchk_LDADD, rm_LDADD, test_LDADD): New vars, for eaccess.
2780 * tests/readlink/can-e: Don't assume that we can remove the
2781 working directory: this isn't possible under Solaris 8, say.
2782 * tests/readlink/can-f: Likewise.
2783 * tests/readlink/can-m: Likewise.
2785 * src/copy.c (copy_internal): find_backup_file_name no longer
2786 returns NULL, so don't bother to check for this.
2787 * src/cp.c (do_copy): Likewise.
2788 * src/ln.c (do_link): Likewise.
2790 2004-07-25 Paul Eggert <eggert@cs.ucla.edu>
2792 * src/nice.c (GET_NICE_VALUE): Renamed from GET_PRIORITY.
2794 (NZERO): New macro, if system doesn't define it already.
2795 (usage): Distinguish priorities from nice values.
2796 Don't assume NZERO is 20.
2797 (main): Use bool instead of int where appropriate.
2798 If user specifies an adjustment out of range, always truncate it
2799 to an inrange value instead of sometimes giving an error message
2801 Do not assume that -1 is an error return from "nice" or
2802 "getpriority", as it might be the current nice value minus NZERO.
2803 If nice/setpriority fails with errno == EPERM, go ahead and run
2804 the command anyway; POSIX requires this.
2806 * src/pathchk.c: Include euidaccess.h.
2807 (dir_ok): Use euidaccess, not access.
2808 * src/test.c (R_OK, W_OK, X_OK, FOK): Remove; system.h defines them.
2809 (eaccess): Remove. All users changed to use euidaccess instead.
2811 2004-07-24 Paul Eggert <eggert@cs.ucla.edu>
2813 * src/uptime.c (print_uptime) [defined BOOT_MSG]:
2814 Don't assume ut_line is null-terminated.
2815 * src/who.c (print_line): New arguments USERLEN and LINELEN,
2816 since USER and LINE might not be null terminated. All callers
2819 2004-07-23 Paul Eggert <eggert@cs.ucla.edu>
2821 Fix bug with "tail -f" reported by Rob Holland in
2822 <http://lists.gnu.org/archive/html/bug-coreutils/2004-07/msg00054.html>.
2823 Also, remove the undocumented and unsupported-since-2000
2824 --max-consecutive-size-changes options. Fix another related bug:
2825 "tail" got confused if stdin, stdout, or stderr were closed.
2826 Also, use output buffering even with "tail -f".
2828 * NEWS: Document this, plus yesterday's patch.
2829 * doc/coreutils.texi (tail invocation): "size has remained the same"
2830 -> "file has not changed", which is more accurate for fifos.
2831 * src/tail.c: Include fcntl-safer.h.
2832 (COPY_TO_EOF): Set to UINTMAX_MAX, not OFF_T_MAX (which was wrong).
2833 (COPY_A_BUFFER): New macro.
2834 (struct File_spec): New members mtime, mode, blocking.
2835 Remove member n_consecutive_size_changes.
2836 (DEFAULT_MAX_N_CONSECUTIVE_SIZE_CHANGES,
2837 max_n_consecutive_size_changes_between_opens,
2838 MAX_CONSECUTIVE_SIZE_CHANGES_OPTION): Remove.
2839 (long_options, tail_forever, parse_options):
2840 Remove (non-)support for --max-consecutive-size-changes.
2841 (record_open_fd): New function.
2842 (recheck, tail_file): Use it. Don't assume that stdin is open.
2843 (dump_remainder): Add support for new COPY_A_BUFFER special value.
2844 Treat errno==EAGAIN like EOF, since it might be a nonblocking read.
2845 (recheck): New arg BLOCKING, specifying whether to use blocking reads.
2847 (n_live_files): Remove, replacing with...
2848 (any_live_files): New function. All uses changed.
2849 (tail_forever): Use nonblocking I/O unless we know that blocking I/O
2850 is safe; this avoids some hangs when reading from a fifo.
2851 Avoid invoking fstat or sleep when using blocking I/O.
2852 Do not check for changes to size if the file is not a regular file,
2853 as the size is undefined in that case.
2854 Check for changes to mtime or mode, too; this works for non-regular
2856 (tail_forever, main): Redo fflush strategy to work even when input
2857 is nonblocking. Don't use unbuffered output; just flush when needed.
2859 2004-07-22 Paul Eggert <eggert@cs.ucla.edu>
2861 * src/tail.c (main): Ignore -f if no file operand is specified
2862 and standard input is a pipe.
2863 * doc/coreutils.texi (tail invocation): Do not ignore -f for
2864 all pipes, just for when standard input is a pipe and no
2865 file operand is specified.
2866 * tests/tail/Test.pm: Reinstate f-1 test, since we now pass.
2867 Add a new commented-out f-2 test, which we still fail.
2868 (test_vector): All f-* tests are special cases, not just f-1.
2870 2004-07-12 Paul Eggert <eggert@cs.ucla.edu>
2872 * src/uptime.c: Include c-strtod.h.
2873 (print_uptime): Use c_strtod instead of setlocale and sscanf.
2874 Use long int rather than int to count days (for 64-bit hosts),
2875 and check for arithmetic overflow when converting double to time_t.
2877 2004-07-11 Paul Eggert <eggert@cs.ucla.edu>
2879 * src/printf.c (vstrtold): Renamed from vstrtod.
2880 Now returns long double. All uses changed.
2881 (print_direc): Use "L" length modifier when printing floating point
2882 numbers, since we're now printing long double.
2884 2004-07-06 Paul Eggert <eggert@cs.ucla.edu>
2886 printf cleanup, to avoid undefined behavior, to add support for
2887 formats that Bash supports, and to support wide integers like
2890 * NEWS: Document this.
2891 * src/printf.c (UNSPECIFIED): Remove. All uses now replaced by
2892 booleans, so that we don't reserve any values for precision or
2894 (STRTOX): Use prototype, not K&R-style definition.
2895 (vstrtoimax): Renamed from xstrtol (to avoid confusion with xstrtol
2896 in ../lib), with type change to intmax_t.
2898 (vstrtoumax): Renamed from xstrtoul, with type change to uintmax_t.
2900 (vstrtod): Renamed from xstrtod. All uses changed.
2901 (print_direc): Use boolean arg instead of special value to indicate
2902 a missing precision or width. LENGTH no longer includes
2903 length modifiers or conversion character. New arg CONVERSION
2904 now specifies conversion character.
2905 Use intmax_t-width formatting for integers (like Bash).
2906 Add support for C99 %a, %A, %F (like Bash).
2907 Add support for field width with %c (POSIX requires this).
2908 Add a FIXME for lack of support for field width and precision
2910 Add support for '\'', '0' flags.
2911 Check for invalid combinations of flags, field width, precision,
2912 and conversion, to prevent use of undefined behavior.
2913 Allow multiple length modifiers, for formats like "%lld" (like Bash).
2914 Add support for C99 'j', 't', 'z' length modifiers (like Bash).
2915 In error message, output entire invalid conversion specification,
2916 instead of merely outputting % followed by the conversion char.
2917 * tests/misc/printf: Add tests for the above.
2919 2004-04-03 Dmitry V. Levin <ldv@altlinux.org>
2921 Change "readlink -f" to be more compatible with prior implementations.
2922 Add more canonicalize options, -e and -m.
2923 Add comprehensive tests for all readlink modes.
2925 * m4/canonicalize.m4 (AC_FUNC_CANONICALIZE_FILE_NAME):
2926 Do not add canonicalize.c here.
2928 * src/readlink.c (longopts): Add new options.
2929 (usage): Document them.
2930 (canonicalize_fname): New proxy function.
2931 (main): Handle new options.
2932 * doc/coreutils.texi (readlink invocation): Document new
2933 "readlink -f" behaviour and new canonicalize options, -e and -m.
2935 * configure.ac (AC_CONFIG_FILES): Add tests/readlink/Makefile.
2936 * tests/Makefile.am (SUBDIRS): Add readlink.
2937 * tests/readlink/Makefile.am: New file.
2938 * tests/readlink/{rl-1,can-e,can-f,can-m}: New readlink tests.
2939 * tests/misc/Makefile.am (TESTS): Remove basic readlink test.
2940 * tests/misc/readlink: Remove file.
2942 2004-07-04 Jim Meyering <jim@meyering.net>
2944 * src/copy.c (copy_internal): Add a FIXME comment.
2946 2004-07-02 Paul Eggert <eggert@cs.ucla.edu>
2948 * src/copy.c (copy_dir): Assume path_concat returns non-NULL.
2949 * src/cp.c (do_copy): Likewise.
2950 * src/mv.c (movefile): Likewise.
2952 * src/cp.c (make_path_private): 2nd arg is now size_t, not int,
2953 to avoid problem when path_concat dir name is longer than 2 GiB (!).
2955 * src/nohup.c (main): Don't pass NULL first argument to path_concat.
2956 This cleans up the semantics a bit, as we no longer try to open the
2959 2004-07-01 Paul Eggert <eggert@cs.ucla.edu>
2961 * NEWS: Add short names -t and -T for --target-directory
2962 and --no-target-directory options, respectively.
2964 * src/cp.c (NO_TARGET_DIRECTORY_OPTION, TARGET_DIRECTORY_OPTION):
2965 Remove. All uses changed to 'T' and 't', respectively.
2966 * src/install.c, src/ln.c, src/mv.c: Likewise.
2968 * src/cp.c (long_opts, usage, do_copy, main): Add -t and -T as
2969 aliases for --target-directory and --no-target-directory,
2971 * src/install.c (long_options, main, usage): Likewise.
2972 * src/ln.c, src/mv.c: Likewise.
2974 2004-07-01 Jim Meyering <jim@meyering.net>
2976 * Makefile.maint (sc_file_system): New target.
2977 (syntax-check-rules): Add it.
2978 .x-sc_file_system: New file.
2979 * Makefile.am (EXTRA_DIST): Add it.
2981 * man/sync.x: Use "file system" rather than "filesystem".
2982 * man/stat.x, man/df.x: Likewise.
2984 2004-06-30 Paul Eggert <eggert@cs.ucla.edu>
2986 * src/df.c (usage, main): Output "file system" rather than
2988 * src/du.c (usage): Likewise.
2989 * src/shred.c (usage): Likewise.
2990 * src/stat.c (usage): Likewise.
2991 * src/stat.c (long_options, usage): Rename "--filesystem" to
2992 "--file-system". But keep the old name around, for compatibility
2995 2004-06-29 Paul Eggert <eggert@cs.ucla.edu>
2997 Add support for --no-target-directory option.
2999 * NEWS: Document it.
3000 * doc/coreutils.texi (Common options, Target directory, cp
3001 invocation, install invocation, mv invocation, ln invocation):
3003 (link invocation): Explain how to rewrite link using ln now
3004 that we have --no-target-directory.
3005 (ln invocation): Explain that --no-target-directory subsumes
3007 (unlink invocation): Modify wording to match new wording in
3010 * src/cp.c (NO_TARGET_DIRECTORY_OPTION): New constant.
3011 (long_opts, usage, do_copy, main): Add support for
3012 --no-target-directory,
3013 * src/install.c (NO_TARGET_DIRECTORY_OPTION, long_options, main,
3015 * src/ln.c (NO_TARGET_DIRECTORY_OPTION, long_options, usage,
3017 * src/mv.c (NO_TARGET_DIRECTORY_OPTION, long_options, usage,
3019 * src/mv.c (enum): Sort values.
3021 2004-06-29 Jim Meyering <jim@meyering.net>
3023 Don't let verbose-mode output from a subshell obscure actual differences.
3024 * tests/rm/inaccessible: Turn off command-echoing just before
3025 invoking subshell, then turn it back on if VERBOSE=yes afterward.
3027 2004-06-25 Paul Eggert <eggert@cs.ucla.edu>
3029 Add support for 'install --target-directory', an option
3030 that has been documented for years but not implemented (!).
3031 * doc/coreutils.texi (install invocation): Document
3032 --target-directory in synopsis, too.
3033 * src/install.c (TARGET_DIRECTORY_OPTION): New var.
3034 (long_options, main, usage): Add --target-directory.
3035 (target_directory_operand): New function, stolen from mv.c.
3036 (main): Use it. Check for -d and --target-directory.
3037 Alter wording of diagnostics to match other programs.
3039 2004-06-28 Jim Meyering <jim@meyering.net>
3041 * src/cp.c (usage): Fix copy+paste error in description of
3042 --target-directory: s/move/copy/. From Paul Jarc.
3044 2004-06-27 Paul Eggert <eggert@cs.ucla.edu>
3046 Use more-consistent rules among cp, ln, and mv when dealing with
3047 last operands that are (or look like) directories.
3049 * src/cp.c (target_directory_operand): New, nearly-common function,
3050 It reports an error if the destination appears to be a directory
3051 (e.g., because it has a trailing slash) but is not.
3052 * src/ln.c, src/mv.c: Likewise.
3053 * src/cp.c (do_copy): Use it.
3054 * src/ln.c (main): Likewise.
3055 * src/mv.c (main): Likewise.
3057 * src/cp.c (do_copy): Don't assume argc is positive.
3058 Don't bother to lstat dest, since copy() will do that for us.
3059 Use "const" to avoid the need for cast.
3061 * src/cp.c (do_copy): Don't output a usage message because of file
3062 problems (e.g., an operand is not a directory). Use it only for
3063 syntax. Standardize on "target %s is not a directory" for the
3065 * src/ln.c (main): Likewise.
3066 * src/mv.c (main): Likewise.
3068 * src/cp.c (do_copy): Remove test for trailing slash, since
3069 target_directory_operand now does this.
3070 * src/ln.c (main): Likewise.
3071 * src/mv.c (movefile): Likewise.
3073 * src/cp.c (main): Reject multiple target directories.
3074 Check whether a specified target is a directory when parsing the
3075 options, using stat. This gives more-accurate diagnostics.
3076 * src/ln.c (main): Likewise.
3078 * src/ln.c (isdir): Remove decl; no longer needed.
3079 * src/mv.c (isdir, lstat): Likewise.
3081 * src/ln.c (do_link): New arg dest_is_dir. All uses changed.
3082 Don't check the destination ourself; rely on dest_is_dir.
3083 This way we can avoid lstatting the destination in the
3084 usual case, and in the worst case we lstat 1, not 3 times.
3085 Don't bother to unlink unless link failed; this saves a syscall.
3086 Remove unnecessary backup_succeeded flag;
3087 it was identical to "dest_backup != NULL".
3089 * src/ln.c (main): Use int to count to argc, not unsigned int.
3090 This handles negative operand counts.
3091 * src/mv.c (main): Likewise.
3093 * src/mv.c (do_move): Don't call hash_init; expect the caller to
3094 do it, for consistency with cp.c and ln.c. All callers changed.
3095 (movefile): dest_is_dir parameter is now bool, not int.
3096 (main): Standardize on "missing destination file operand after %s"
3097 for the diagnostic, for consistency with cp.c.
3099 * tests/mv/diag: Don't assume "mv --target=nonexistentdir"
3100 will complain about the arg count.
3101 Adjust to new (briefer) diagnostics.
3102 * tests/cp/fail-perm: Add a test to verify that we get the new
3103 diagnostic when failing to copy through a symlink-to-inaccessible-dir.
3105 2004-06-27 Paul Eggert <eggert@cs.ucla.edu>
3107 Fix a bug: formerly, if d/x was a directory and x a file, "ln x
3108 d/" incorrectly created a link d/x/x. It also saves some system
3111 * NEWS: Document the fix.
3113 * src/ln.c (main): Don't append basename to dest if this
3114 results in an existing directory name.
3115 * tests/ln/misc: See whether a trailing slash is followed too far.
3117 2004-06-26 Jim Meyering <jim@meyering.net>
3119 * src/printf.c (main): When given no arguments, print the standard
3120 "missing operand\nTry printf --help..." message -- to be consistent.
3122 2004-06-26 Jim Meyering <jim@meyering.net>
3124 * src/mknod.c (main): Add \n at the end of message output via fprintf.
3126 2004-06-25 Jim Meyering <jim@meyering.net>
3128 * tests/ln/misc: Add test for ln subscript error.
3130 2004-06-23 Paul Eggert <eggert@cs.ucla.edu>
3132 * src/ln.c (do_link): Remove unnecessary call to lstat.
3133 (main): Avoid subscript error when the destination is "".
3135 2004-06-23 Jim Meyering <jim@meyering.net>
3137 * tests/*: Replace all occurrences of `(exit N); exit' with
3138 `(exit N); exit N'. Otherwise, those many tests could exit with
3139 improper exit status when exiting via e.g., a trapped interrupt.
3140 Thanks to a report from Bob Proulx.
3142 2004-06-22 Paul Eggert <eggert@cs.ucla.edu>
3144 * src/who.c (idle_string, print_user): New arg boottime,
3145 specifying the most recent boot time. All uses changed.
3146 (idle_string) Consider a line to be "old" if it hasn't been used
3147 since the last boot time. Watch out for overflow when computing
3148 times, and for times in the future.
3149 (idle_string): Record latest boot time.
3151 2004-06-22 Jim Meyering <jim@meyering.net>
3153 * src/test.c (usage): Correct description of `-t FD'. The file
3154 descriptor, FD, is no longer optional. Reported by Ton Nijkes.
3156 2004-06-21 Paul Eggert <eggert@cs.ucla.edu>
3158 The 2004-06-19 fix for who and pinky was incomplete, as ctime
3159 has undefined behavior if the year precedes -999 or follows 9999.
3160 Since we have to stop using ctime anyway, we might as well use
3161 strftime and fix the FIXME, and support internationalized dates.
3163 * NEWS: Document the new behavior.
3164 * src/who.c: Include "hard-locale.h".
3165 (time_format, time_format_width): New vars.
3166 (time_string, print_line): Use them.
3168 (time_string): Use localtime + strftime instead of
3169 ctime, to avoid problems with years before -999 or after 9999.
3170 * src/pinky.c: Likewise.
3172 2004-06-21 Paul Eggert <eggert@cs.ucla.edu>
3174 Fix bug: GNU 'ls' didn't count columns correctly if user or group
3175 names contained multibyte characters where the column count
3176 differed from the byte count. This patch also corrects
3179 * src/ls.c (format_user_or_group): New function, which counts
3181 (format_user, format_group): Use it.
3182 (format_user_or_group_width): New function, which counts columns
3184 (format_user_width, format_group_width): Use it.
3186 2004-06-21 Jim Meyering <jim@meyering.net>
3188 * tests/priv-check: Quote "$PATH" in PATH=$PATH.
3189 Suggestion from Andreas Schwab.
3191 * tests/priv-check: When running as root, be sure to propagate
3192 PATH through to the process we exec as non-root.
3193 Reported by michael@aplatform.com.
3195 * src/mknod.c (main): Don't segfault when calculating the
3196 expected number of operands for `mknod NAME'.
3198 2004-06-20 Jim Meyering <jim@meyering.net>
3200 * src/dd.c (input_seek_errno): Declare file-scoped variable as static.
3202 2004-06-20 Paul Eggert <eggert@cs.ucla.edu>
3204 * src/basename.c (main):
3205 Standardize on the diagnostics given when someone gives
3206 too few operands ("missing operand after `xxx'") or
3207 too many operands ("extra operand `xxx'").
3208 Include "quote.h" and/or "error.h" if it wasn't already being included.
3209 * src/chgrp.c (main): Likewise.
3210 * src/chmod.c (main): Likewise.
3211 * src/chown.c (main): Likewise.
3212 * src/chroot.c (main): Likewise.
3213 * src/comm.c (main): Likewise.
3214 * src/cp.c (do_copy): Likewise.
3215 * src/csplit.c (main): Likewise.
3216 * src/date.c (main): Likewise.
3217 * src/dircolors.c (main): Likewise.
3218 * src/dirname.c (main): Likewise.
3219 * src/du.c (main): Likewise.
3220 * src/expr.c (main): Likewise.
3221 * src/hostid.c (main): Likewise.
3222 * src/hostname.c (main): Likewise.
3223 * src/id.c (main): Likewise.
3224 * src/install.c (main): Likewise.
3225 * src/join.c (add_file_name, main): Likewise.
3226 * src/link.c (main): Likewise.
3227 * src/ln.c (main): Likewise.
3228 * src/logname.c (main): Likewise.
3229 * src/md5sum.c (main): Likewise.
3230 * src/mkdir.c (main): Likewise.
3231 * src/mkfifo.c (main): Likewise.
3232 * src/mknod.c (main): Likewise.
3233 * src/mv.c (main): Likewise.
3234 * src/nohup.c (main): Likewise.
3235 * src/od.c (main): Likewise.
3236 * src/pathchk.c (main): Likewise.
3237 * src/ptx.c (main): Likewise.
3238 * src/readlink.c (main): Likewise.
3239 * src/rm.c (main): Likewise.
3240 * src/rmdir.c (main): Likewise.
3241 * src/seq.c (main): Likewise.
3242 * src/setuidgid.c (main): Likewise.
3243 * src/shred.c (main): Likewise.
3244 * src/sleep.c (main): Likewise.
3245 * src/sort.c (main): Likewise.
3246 * src/split.c (main): Likewise.
3247 * src/stat.c (main): Likewise.
3248 * src/test.c (beyond, main): Likewise.
3249 * src/touch.c (main): Likewise.
3250 * src/tr.c (main): Likewise.
3251 * src/tsort.c (main): Likewise.
3252 * src/tty.c (main): Likewise.
3253 * src/uname.c (main): Likewise.
3254 * src/uniq.c (main): Likewise.
3255 * src/unlink.c (main): Likewise.
3256 * src/uptime.c (main): Likewise.
3257 * src/users.c (main): Likewise.
3258 * src/who.c (main): Likewise.
3259 * src/whoami.c (main): Likewise.
3261 * tests/basename/basic: Adjust to new diagnostics.
3262 * tests/du/files0-from: Likewise.
3263 * tests/expr/basic: Likewise.
3264 * tests/mv/diag: Likewise.
3265 * tests/tsort/basic-1: Likewise.
3267 2004-06-20 Jim Meyering <jim@meyering.net>
3269 * src/ln.c: Remove declaration of yesno.
3270 Instead, include yesno.h.
3271 * src/copy.c: Likewise.
3273 * src/remove.c: Remove declaration of yesno.
3274 Instead, include yesno.h.
3275 (top_dir): Remove now-unnecessary cast of obstack_base.
3276 (pop_dir): Likewise.
3277 (full_filename_): Likewise.
3279 2004-06-19 Paul Eggert <eggert@cs.ucla.edu>
3281 Don't dump core if ctime returns NULL; this is possible on
3282 hosts with 64-bit time_t and 32-bit int.
3283 * src/who.c: Include "inttostr.h".
3284 (time_string): If ctime fails, print the raw time as an integer
3285 instead of dumping core.
3286 * src/pinky.c: Likewise, as follows:
3287 Include "inttostr.h".
3288 (time_string): New function, copied from who.c.
3289 (print_entry): Use it.
3291 2004-06-19 Paul Eggert <eggert@cs.ucla.edu>
3293 * src/who.c (print_line): Don't truncate user names at 8 bytes.
3294 Problem reported by Guido Leenders in:
3295 http://lists.gnu.org/archive/html/bug-coreutils/2004-06/msg00056.html
3296 * NEWS: document this.
3298 2004-06-19 Jim Meyering <jim@meyering.net>
3300 * src/system.h (case_GETOPT_VERSION_CHAR): Switch back to
3301 using GNU_PACKAGE (from PACKAGE) once again. This restores
3302 `GNU' to the parenthesized package name in --version output.
3303 Before, the first argument from AC_INIT, `GNU coreutils', would
3304 be propagated to the PACKAGE variable. Now, `GNU ' is trimmed.
3305 Reported by Richard Stallman.
3307 2004-06-17 Jim Meyering <jim@meyering.net>
3309 * src/tr.c (to_uchar): Rename function from `uchar'. The latter
3310 would clash with a typedef in Tru64's <sys/types.h>. From Albert Chin.
3312 2004-06-15 Paul Eggert <eggert@cs.ucla.edu>
3314 * NEWS: Remove more special cases for POSIXLY_CORRECT when POSIX
3315 allows the GNU behavior. "--" is now supported by chroot, hostid,
3316 hosname, pwd, sync, yes.
3317 * doc/coreutils.texi (yes invocation, false invocation,
3318 true invocation): Document this.
3319 * src/chroot.c (main): Handle "--".
3320 * src/hostid.c (main): Likewise.
3321 * src/hostname.c (main): Likewise.
3322 * src/pwd.c (main): Likewise.
3323 * src/sync.c (main): Likewise.
3324 * src/yes.c (main): Likewise.
3325 * src/true.c (main): Recognize --help and --version even if
3326 POSIXLY_CORRECT is set.
3327 * src/yes.c (main): Likewise.
3329 2004-06-09 Paul Eggert <eggert@cs.ucla.edu>
3331 * NEWS: Remove special cases for POSIXLY_CORRECT when POSIX allows
3333 * doc/coreutils.texi (pr invocation, unlink invocation): Document this.
3334 * src/ls.c (decode_switches): Pay attention to TABSIZE even if
3335 POSIXLY_CORRECT is set. POSIX reserves upper-case environment
3336 variables to the implementation, so it's OK for ls to depend on
3338 * src/pr.c: Include "hard-locale.h".
3339 (main): When in a non-POSIX locale, ignore POSIXLY_CORRECT, since
3340 POSIX specifies the behavior only in the POSIX locale.
3341 * src/printf.c (print_esc): Support \x, \u, \U even if POSIXLY_CORRECT,
3342 since POSIX says the behavior is unspecified here.
3343 * src/tail.c (parse_obsolescent_option): Support multiple file operands
3344 even if POSIXLY_CORRECT, since POSIX does not require a diagnostic.
3345 * src/printf.c (main): Recognize --help, --version even if
3346 POSIXLY_CORRECT. POSIX does not specify any options, but it
3347 does not prohibit options either, so "printf" is like "expr" here.
3348 * src/unlink.c (main): Likewise.
3349 * tests/misc/printf: Adjust to the new semantics for \x if
3352 2004-06-14 Jim Meyering <jim@meyering.net>
3354 * tests/misc/pwd: New test, for fix of 2004-04-19.
3355 * tests/misc/Makefile.am (TESTS): Add pwd.
3356 (BUILD_SRC_DIR): Define BUILD_SRC_DIR.
3358 * src/copy.c: Remove declaration of euidaccess.
3359 Instead, include "euidaccess.h".
3361 2004-06-13 Paul Eggert <eggert@cs.ucla.edu>
3363 * src/who.c (PIDSTR_DECL_AND_INIT): Don't assume pid_t fits in int.
3364 (UT_ID) [!HAVE_STRUCT_XTMP_UT_ID]: Remove bogus comment,
3365 as (sizeof "??") reliably returns 3.
3366 (print_line): Guard against idle and pid being too long
3367 (which is possible when printing headers).
3368 (print_user): Allocate enough bytes for idlestr. Use IDLESTR_LEN.
3369 Avoid unnecessary cast of sizeof to int.
3370 (make_id_equals_comment): Do not assume that UT_ID returns
3371 a string; it might return a non-null-terminated array.
3372 Use strncat instead. It's not very often where strncat is
3373 exactly what you want, but this is one of those rare cases.
3375 2004-06-11 Paul Eggert <eggert@cs.ucla.edu>
3377 * src/who.c (list_entries_who): Don't output a trailing space.
3379 2004-06-09 Jim Meyering <jim@meyering.net>
3381 * src/touch.c (usage): Improve wording in description of the
3382 --time=WORD option. Reported by Dan Jacobson.
3384 * src/chown-core.c (change_file_owner): Change names of parameters
3385 old_uid and old_gid to required_uid and required_gid respectively.
3387 * src/chmod.c (mode_changed): Return false, not 0, now that the
3388 function returns `bool'.
3390 2004-06-08 Paul Eggert <eggert@cs.ucla.edu>
3392 Adjust chmod and chown to be similar if -c or -v are given. In
3393 particular, a no-op chown is no longer reported as a change; this
3394 reverts to previous behavior. Also, fix both commands so that -v
3395 report failures even if the failure is not due to the chmod or
3398 * src/chmod.c (CH_NOT_APPLIED): New constant.
3399 (describe_change): Handle it.
3400 (process_file): Use it, if a symlink wasn't changed.
3401 (mode_changed): Return bool, not int. Accept new argument
3402 NEW_MODE; all callers changed. This lets us avoid statting the
3403 file unless the new mode has unusual bits.
3404 (process_file): Return -1 on error. With -v, report all errors
3405 verbosely, not just some.
3407 * src/chown-core.c (change_file_owner): Return -1 on error, not
3408 1 sometimes and -1 on others. Our caller ORs together our results,
3409 and (-1 | 1) == 0 on ones-complement hosts.
3410 With -v report all errors verbosely, not just some.
3411 Fix bug when chopt->root_dev_ino && !chopt->affect_symlink_referent:
3412 file_stats wasn't set properly in that case.
3414 * tests/chgrp/basic: Adjust to above changes.
3416 2004-05-20 Paul Eggert <eggert@cs.ucla.edu>
3418 * tests/chgrp/basic: Test that chgrp -h does not fail on
3419 symlinks, even on hosts where that's not supported.
3420 Test that if -R is specified without -H or L, -h is assumed.
3421 Test that chown() is not optimized away.
3423 2004-05-18 Paul Eggert <eggert@cs.ucla.edu>
3425 Several fixes to chgrp and chown for compatibility with POSIX and BSD:
3427 Check for incompatible options. When -R and --dereference are
3428 both used, then either -H or -L must also be used. When -R and -h
3429 are both used, then -P must be in effect.
3431 -H, -L, and -P have no effect unless -R is also specified.
3432 If -P and -R are both specified, -h is assumed.
3434 Do not optimize away the chown() system call when the file's owner
3435 and group already have the desired value. This optimization was
3436 incorrect, as it failed to updated the last-changed time and reset
3437 special permission bits, as POSIX requires.
3439 Do not report an error if the owner or group of a
3440 recursively-encountered symbolic link cannot be updated because
3441 the file system does not support it.
3443 * NEWS: Document the above.
3445 * src/chgrp.c (main): Check for incompatible options. -R --dereference
3446 requires either -H or -L, and -R -h requires -P. If -H, specify
3447 FTS_PHYSICAL as well as FTS_COMFOLLOW; this is faster. Make this
3448 file as much like chown.c as possible.
3449 * src/chown.c (main): Likewise.
3451 * src/chown-core.c (change_file_owner): Use ent->fts_statp only if
3452 needed. Chown a directory only after chowning its children; this
3453 avoids problems if the new directory ownership doesn't permit
3454 access to the children. Dereference symlinks before doing
3455 ROOT_DEV_INO_CHECK, not after, so that we catch symlinks to /.
3456 Do not optimize away the chown() system call when the file's owner
3457 and group already have the desired value. POSIX does not permit
3458 this optimization. Rely on chown and lchown to do the right
3459 thing with symlinks and/or -1 arguments, now that we have wrappers
3460 to do this. Use ENOTSUPP not ENOSYS, and ignore all ENOTSUPP
3461 errors, not just command-line errors.
3462 (chown_files): Pass FTS_NOSTAT to xfts_open if we don't need file status.
3464 * src/system.h (ENOTSUP): Remove.
3466 * tests/chgrp/basic: Use chown --from to discover whether the
3467 group changed, since chgrp now changes unconditionally. This
3468 complicates the sed script a bit. Do not specify --dereference,
3469 since it's the default (and we want to test this). Adjust output
3470 to match the fact that chgrp no longer optimizes the case of
3471 changing a file's group to the same value as before.
3472 * tests/chgrp/posix-H: Do not attempt to combine -h and -H; these
3473 options are incompatible, and their behavior is undefined with POSIX.
3474 (changed, not_changed): Adjust to match the fact that -h is no longer
3475 specified. Sort names.
3476 * tests/chown/deref: Adjust error-diagnostic spelling to match new
3479 2004-06-07 Paul Eggert <eggert@cs.ucla.edu>
3481 * src/uname.c (main): Fix typo introduced on 2003-05-10 that
3482 prevented a diagnostic of any operands.
3484 2004-06-08 Jim Meyering <jim@meyering.net>
3486 * src/shred.c (direct_mode): Turn it on/off with directio, too.
3488 2004-06-07 Jim Meyering <jim@meyering.net>
3490 Enable direct-mode I/O (bypassing the buffer cache), if possible.
3491 Prompted by a suggestion from Kalle Olavi Niemitalo
3492 in http://bugs.debian.org/207035.
3493 * src/shred.c (direct_mode): New function.
3494 (do_wipefd): Turn on direct-mode I/O.
3495 (dopass): If a file's first write fails with EINVAL,
3496 turn off direct-mode I/O and retry the write.
3498 2004-06-05 Paul Eggert <eggert@cs.ucla.edu>
3500 * src/tr.c (main): "tr -d a b" is now a fatal error even if
3501 POSIXLY_CORRECT is set. The POSIX SYNOPSIS does not allow this
3504 2004-06-04 Paul Eggert <eggert@cs.ucla.edu>
3506 * src/shred.c (dopass): Don't subtract 1 from the offset after
3507 a write error. Problem reported by Jon Peatfield in:
3508 http://lists.gnu.org/archive/html/bug-coreutils/2004-06/msg00020.html
3510 2004-06-02 Paul Eggert <eggert@cs.ucla.edu>
3512 Fix bug reported by Buciuman Adrian in
3513 <http://mail.gnu.org/archive/html/bug-coreutils/2003-08/msg00105.html>
3514 where 'dd' created a file that was too large. The bug was that dd
3515 assumed that the input file offset does not advance after a failed
3516 read; but POSIX says that the input file offset is undefined after
3519 * src/dd.c (MAX_BLOCKSIZE): New macro.
3520 (input_seekable, input_seek_errno, input_offset,
3521 input_offset_overflow): New vars.
3522 (scanargs): Reject block sizes greater than MAX_BLOCKSIZE.
3523 (advance_input_offset): New function.
3524 (skip_via_lseek): Set errno to zero when reporting our failure,
3525 so that we don't report based on garbage errno.
3526 (skip): If fdesc is standard input, advance the input offset.
3527 Do not quit if reading, and if noerror was specified;
3528 POSIX seems to require this.
3529 If read fails on output file, report the earlier lseek failure
3530 instead; this fixes a FIXME in dd_copy.
3531 (advance_input_after_read_error): New function.
3532 (dd_copy): Use it, instead of assuming that failed reads
3533 do not advance the file pointer. Advance input offset
3534 after nonfailed reads. Advance only a partial block if
3535 the previous read (before the failed read) succeeded, and
3536 do not generate an output block of zeros in this case.
3537 (main): Determine initial input offset, seekability of input,
3538 and error if it wasn't seekable.
3540 2004-06-02 Jim Meyering <jim@meyering.net>
3542 rm (without -f) could hang unnecessarily when attempting to
3543 remove a symlink to a file on an off-line NFS-mounted partition.
3544 Reported by David Howells in https://bugzilla.redhat.com/124699.
3545 * src/remove.c (write_protected_non_symlink): New function.
3546 Don't invoke euidaccess on symlinks.
3547 (prompt): Use write_protected_non_symlink rather than using
3548 euidaccess directly, being careful not to call lstat twice for a file.
3550 Fix a bug in how the --output-delimiter=D option works with
3551 abutting byte or character ranges. Reported by David Krider in
3552 http://lists.gnu.org/archive/html/bug-coreutils/2004-05/msg00132.html
3553 * src/cut.c (print_kth): Remove special case for open-ended range.
3554 (set_fields): Record the range start index for an interval even
3555 when it abuts another interval on its low side.
3556 Also record the range start index of the longest right-open-interval.
3557 * tests/cut/Test.pm: Add tests of --output-delimiter=S with
3558 abutting and overlapping byte ranges.
3560 2004-06-01 Paul Eggert <eggert@cs.ucla.edu>
3562 Some POSIX-conformance cleanups for tr.
3564 * src/tr.c (posix_pedantic): Remove; no longer needed since
3565 we need to test this in just one place now.
3566 (usage): Mention -C.
3567 (unquote): Note that \055, \n, etc are escaped.
3568 Do not worry about POSIXLY_CORRECT when warning about ambiguous
3570 \ at end of string stands for itself.
3571 Do not diagnose invalid backslash escapes: POSIX says the behavior
3572 is unspecified in this case, so we don't need to diagnose it.
3573 (main): Add support for -C (currently an alias for -c).
3574 Do not diagnose 'tr [:upper:] [:upper:], as POSIX does not require
3576 * tests/tr/Test.pm: New tests bs-055, bs-at-end, repeat-Compl.
3577 Fix comment for range-a-a.
3579 2004-05-25 Paul Eggert <eggert@cs.ucla.edu>
3581 Improve the efficiency (and in one case, correctness) of code
3582 that reads symlinks.
3584 * src/copy.c (copy_internal): Don't use alloca, as it can mess up
3585 royally if the link length is long (e.g., GNU/Hurd). Use
3586 xreadlink instead, it's safer. Don't bother to read the link if
3587 it's the wrong size. Add a FIXME because this area is a bit murky
3589 * src/ls.c (get_link_name): Update use of xreadlink.
3590 * src/readlink.c (main): Likewise.
3591 * src/stat.c (print_stat): Likewise.
3593 2004-06-01 Jim Meyering <jim@meyering.net>
3595 * src/env.c (main): Prefer the notation `STREQ (a, b)'
3596 over `!strcmp (a, b)'.
3597 * src/sort.c (main, sort_buffer_size): Prefer the notation
3598 `STREQ (a, b)' over `strcmp (a, b) == 0'.
3599 * src/date.c (batch_convert): Likewise.
3600 * src/expr.c (nextarg): Likewise.
3601 * src/su.c (correct_password, restricted_shell, main): Likewise.
3602 * src/ptx.c (swallow_file_in_memory, main): Likewise.
3603 * src/test.c (binary_operator, and, or, main): Likewise.
3605 2004-05-13 Paul Eggert <eggert@cs.ucla.edu>
3607 * NEWS: echo compatibility cleanup.
3608 * doc/coreutils.texi (echo invocation): Document the changes.
3609 * src/echo.c (V9_ECHO): Remove; always enabled.
3610 (DEFAULT_ECHO_TO_XPG): Renamed from V9_DEFAULT, so that
3611 we use the same naming convention as bash. Now an enum,
3613 (usage): Reword to mention -e/-E more accurately.
3614 Mention \0NNN (the POSIX syntax) rather than \NNN (nonstandard).
3615 (hextobin): New function.
3616 (main): Use bool rather than int for local vars when appropriate.
3617 Do not allow options if POSIXLY_CORRECT, unless we are using
3618 BSD semantics and the first argument is "-n".
3619 Don't pass unnecessary extra arg to parse_long_options.
3620 do_v9 now defaults to DEFAULT_ECHO_TO_XPG, not to allow_options.
3621 Do not look for options if !allow_options.
3622 Use size_t rather than int when appropriate.
3623 Open-code option test rather than using strrchr.
3624 Use faster test for "-".
3625 Avoid redundant argc test.
3626 Add support for \x, for Bash compatibility.
3627 Use e.g. '\a' rather than '\007', for portability to EBCDIC hosts.
3628 When '\c' is encountered, stop printing immediately, as POSIX
3630 Add support for \xhh syntax.
3631 Add support for \0ooo syntax; POSIX requires this.
3633 2004-06-01 Jim Meyering <jim@meyering.net>
3635 * Use automake-1.8b. Regenerate dependent files.
3637 2004-05-31 Jim Meyering <jim@meyering.net>
3639 * tests/Makefile.am.in (TESTS_ENVIRONMENT): Define PATH to include
3640 the build src/ directory -- at the front.
3641 ($(srcdir)/$x-tests): Depend on Makefile.am.
3642 Use $x as the program name, except when it would be `test' (test is
3643 the sole program tested via mk-script that is also a shell built-in).
3644 In that case, use the old ../../src/$x.
3646 2004-05-30 Jim Meyering <jim@meyering.net>
3648 Work around HPUX /bin/cc compiler bug that is exposed, now that
3649 sets are arrays of type `bool'. More details here:
3650 http://lists.gnu.org/archive/html/bug-gnulib/2004-05/msg00094.html
3651 FIXME: verify that the above URL points to the right message
3653 * src/tr.c (card_of_complement): Use cleaner `sizeof in_set'
3654 rather than `N_CHARS * sizeof(in_set[0])'. Using HPUX's /bin/cc
3655 (aC++/ANSI C B3910B A.05.55 [Dec 04 2003]) on an ia64-hp-hpux11.22
3656 system, those two expressions are not the same (256 vs. 1024).
3657 The effect of this problem was that `tr -c x y' would fail:
3658 tr: when not truncating set1, string2 must be non-empty
3659 (set_initialize): Remove unnecessary initialization of the `in_set'
3660 buffer; that initialization triggered the same compiler bug as above.
3662 2004-05-29 Paul Eggert <eggert@cs.ucla.edu>
3664 tr cleanup, mostly having to do with integer type ranges.
3667 * tests/tr/Test.pm: Add a few tests for the below. Alas, most of
3668 the test cases wouldn't be portable, or would take too much CPU
3671 * src/tr.c (N_CHARS, N_CHAR_CLASSES): Now an enum, not a macro.
3672 This is safe since the code already assumes N_CHARS fits in int.
3673 (Filter): Remove: we want to prototype everything.
3674 (ORD, CHR): Remove. All uses removed. Some replaced with:
3675 (uchar): New function. All places where a char must be converted
3676 to an unsigned char are now done this way, not by ad-hoc methods.
3677 (count): New type. Use it whenever counts or states are needed.
3678 (BEGIN_STATE): Increase from INT_MAX - 1 (which was bogus, anyway,
3679 since we used it in an unsigned int context) to UINTMAX_MAX - 1.
3680 (REPEAT_COUNT_MAXIMUM): New macro. Use it in place of BEGIN_STATE
3681 whenever appropriate.
3682 (NOT_A_CHAR): Remove global macro; now a local enum.
3683 (UL_LOWER, UL_UPPER, UL_NONE): No longer specify values, since
3684 the rest of the code no longer depends on them.
3685 (class_ok): Remove; all uses changed to use inline comparisons.
3686 (RE_NO_TYPE): Remove; wasn't used or needed.
3687 (struct List_element): normal_char and equiv_code are now unsigned
3689 first_char, last_char, and the_repeated_char are now unsigned char,
3690 not unsigned int. repeat_count is now count, not size_t.
3692 (struct Spec_list): state is now count, not unsigned int.
3693 lengthis now count, not size_t.
3694 n_indefinite_repeats is now size_t, not int.
3695 has_equiv_class, has_char_class, and has_restricted_char_class
3696 are now bool, not int. All uses changed.
3697 (struct E_string): s is now char *, not unsigned char *.
3698 escaped is now bool *, not int *. All uses changed.
3699 (ES_MATCH): Remove macro, replacing with:
3700 (es_match): New inline function. All uses changed.
3701 (squeeze_repeats, complement, posix_pedantic, truncate_set1,
3702 translating): Now bool, not int.
3703 (io_buf): Now char array, not unsigned char.
3704 (SET_TYPE): Remove. All uses replaced with bool.
3705 (is_equiv_class_member, unquote, append_range, append_char_class,
3706 append_equiv_class, find_closing_delim, star_digits_closebracket,
3707 build_spec_list, parse_str, homogeneous_spec_list):
3708 Now returns bool, not int. All uses changed.
3709 (is_equiv_class_member): Now inline.
3710 (is_equiv_class_member, is_char_class_member, make_printable_str,
3711 append_normal_char, append_range, append_repeated_char,
3713 Args are now of proper integer type.
3714 (unquote, look_up_char_class, make_printable_str,
3715 append_equiv_class, build_spec_list, squeeze_filter):
3716 Avoid unsigned char *p; gently convert *p to unsigned char instead.
3717 (unquote, get_spec_stats): Do not jump past declarations and then
3718 use them; C doesn't allow this in portable programs.
3719 (make_printable_str): Check for overflow in size calculations.
3720 (xmemdup): Remove. All uses rewritten.
3721 (find_bracketed_repeat): Args are now of proper pointer-to-integer
3722 type. Do not reject [c*0]. Use xstrtoumax, not xstrtoul.
3723 (find_bracketed_repeat, star_digits_closebracket): Check that the
3724 digits are not escaped.
3725 (build_spec_list): Don't bother to copy opnd_str; not needed.
3726 (build_spec_list, get_next): Simplify internal logic a bit.
3727 (card_of_complement): Fix bug due to char overflow.
3728 (get_spec_stats): Don't assume len fits into int.
3729 Check for integer overflow. Use abort() rather than assert(0).
3730 (string2_extend): Fix subscript error: is_char_class_member (..., 255)
3732 (squeeze_filter): READER is never null now; simplify code.
3733 READER arg now has a simpler type. Remove unnecessary casts.
3734 (squeeze_filter, main): Calls to fwrite improperly checked result
3735 against zero, rather than against requested size.
3736 (plain_read): New function.
3737 (read_and_delete, read_and_xlate):
3738 Remove unused filter arg, and don't worry about hit_eof.
3739 Simplify by using plain_read.
3740 (set_initialize): Args are bool and bool *, not int and SET_TYPE *.
3741 (main): Always pass a non-null procedure to squeeze_filter.
3742 Rewrite so that class_ok isn't needed.
3744 2004-05-29 Paul Eggert <eggert@cs.ucla.edu>
3746 * src/shred.c (dosync): Ignore EBADF errors, as IRIX 6.5
3747 fdatasync reports EBADF when syncing (unwritable) directories.
3748 Problem reported by Albert Chin-A-Young in:
3749 http://lists.gnu.org/archive/html/bug-coreutils/2004-05/msg00165.html
3751 2004-05-29 Jim Meyering <jim@meyering.net>
3753 * tests/chown/deref: Fix typo: use ls -ldo, not ls -ldg.
3754 Patch from Albert Chin.
3756 * src/ptx.c (text_buffer_maxend): Remove declaration of unused variable.
3758 * src/remove.c (push_dir): Merge declaration and adjacent assignment
3759 into a single statement.
3761 2004-05-28 Jim Meyering <jim@meyering.net>
3763 * src/remove.c (AD_mark_helper): Eliminate an unnecessary comparison.
3765 2004-05-22 Jim Meyering <jim@meyering.net>
3767 rm -r would get a failed assertion when run from an inaccessible
3768 directory and with two or more command line arguments including an
3769 absolute-named directory followed by a relative-named directory.
3771 * src/remove.h (struct rm_options) [require_restore_cwd]: New member.
3772 * src/remove.c (struct cwd_state): Define.
3773 (AD_pop_and_chdir): Redesign interface so that a restore_cwd failure
3774 can be detected by the caller. Instead of returning a malloc'd
3775 directory name, communicate it to caller via a new parameter, and
3776 return an indication of whether restore_cwd failed. Update caller.
3777 Eliminate an unnecessary call to AC_stack_top.
3778 (remove_dir): Change type of cwd_state parameter to `struct cwd_state'
3779 so we can now communicate to caller whether/how functions like
3780 restore_cwd have failed. Update caller.
3781 (rm_1): Fail if we've failed to restore the working directory
3782 and the name of the next file to remove is `.'-relative.
3783 (rm): Fail if the require_restore_cwd flag is true and we've
3784 failed to restore the working directory.
3785 * src/mv.c (rm_option_init): Initialize new member,
3786 x->require_restore_cwd.
3787 * src/rm.c (rm_option_init): Likewise.
3789 2004-05-21 Jim Meyering <jim@meyering.net>
3791 * tests/rm/inaccessible: New test for the above fix.
3792 * tests/rm/Makefile.am (TESTS): Add inaccessible.
3794 * src/remove.c (rm): Use free rather than XFREE.
3795 (remove_dir): Use xmalloc, not XMALLOC.
3796 (ds_init): Likewise.
3798 2004-05-20 Jim Meyering <jim@meyering.net>
3800 * Makefile.maint (sc_unmarked_diagnostics): Now that the unmarked
3801 diagnostics in shred.c have been fixed, don't exempt shred.c from
3804 * src/shred.c: Use translatable diagnostics, e.g.
3805 change "%s: remove" to _("%s: failed to remove") and
3806 change "%s: close" to _("%s: failed to close").
3808 2004-05-17 Paul Eggert <eggert@cs.ucla.edu>
3810 * src/shred.c (names): Bring back lower-case letters, "_", and
3811 ".". But continue to omit +, =, %, @, #, as they're either
3812 shell metacharacters (for some shells) or are not in some
3813 character sets, or (in the case of '%') must be a
3814 metacharacter somewhere.
3816 2004-05-16 Paul Eggert <eggert@cs.ucla.edu>
3818 * src/cut.c (cut_fields): Adjust to new signature of getndelim2.
3820 2004-05-17 Jim Meyering <jim@meyering.net>
3822 * src/shred.c (incname): Decrement `len' only once per loop iteration.
3824 chgrp and chown now dereference symlinks by default, per POSIX.
3825 Reported by Michal Politowski as http://bugs.debian.org/249177.
3827 * src/chown-core.c (chopt_init): Affect each symlink referent by default.
3828 * src/chown.c (usage): Update to reflect this.
3829 * src/chgrp.c (usage): Likewise.
3830 * NEWS: Describe the change.
3831 Adapt tests accordingly.
3832 * tests/chgrp/basic: Use -h where necessary to retain semantics.
3833 * tests/chgrp/deref: Likewise.
3834 * tests/chgrp/posix-H: Likewise.
3836 2004-05-15 Paul Eggert <eggert@cs.ucla.edu>
3838 In shred, check for errors from fdatasync more carefully. If
3839 fdatasync fails with errno==EINVAL, it means this implementation
3840 does not support synchronized I/O for this file. Do not report
3841 this as an error, as (for example) AIX 5.2 fdatasync reports it
3842 for raw disk devices. Problem reported by Albert Chin in
3843 <http://mail.gnu.org/archive/html/bug-gnu-utils/2004-05/msg00028.html>.
3845 Check for write errors, though: the old code ignored them.
3846 Improve error checking in a few other cases, too (e.g., close of a
3849 Also, change several 'int' values to 'bool', so that the error
3850 checking is a bit clearer. Similarly, change unsigned values
3851 to size_t where appropriate.
3853 * src/shred.c: Include "dirname.h".
3854 (datasync) [!HAVE_FDATASYNC]: Remove.
3855 (dosync): New function.
3856 (dopass): Use it. Return 1 on write error, -1 on other error.
3857 All callers changed. Report write error if dosync does.
3858 (do_wipefd, wipefd, wipename, wipefile): Return bool (true/false),
3859 not int (0/-1). All callers changed. Return false if there's a
3861 (incname): Return bool (true/false), not int (0/1). Accept
3862 size_t length, not unsigned. All callers changed. Do not
3863 bother checking for non-digits; it can't happen. Replace
3864 recursion with iteration.
3865 (wipename): Use dir_name, base_name, etc. instead of assuming
3866 Unix file names. Use size_t for length, not unsigned.
3867 Report error if unlink or close fails.
3868 (wipename, main): Use bool for booleans.
3870 (names): Use only digits and uppercase letters, for greater
3873 2004-05-16 Jim Meyering <jim@meyering.net>
3875 * tests/chown/deref: New test for the yesterday's change.
3876 * tests/chown/Makefile.am (TESTS): Add deref.
3878 2004-05-15 Jim Meyering <jim@meyering.net>
3880 chown --dereference did nothing when the owner/group of a
3881 symlink matched the desired owner/group. Reported by David Malone.
3882 Also reported in 1999 as http://bugs.debian.org/39642.
3884 * src/chown-core.c (change_file_owner): When --dereference has
3885 been specified, and when processing a symlink, stat it to get the
3886 owner and group of the referent.
3888 2004-05-14 Jim Meyering <jim@meyering.net>
3890 * man/pwd.x, man/echo.x, man/printf.x: Fix typo:
3891 s/supercede/supersede/ reported by Andrew Fabbro.
3893 2004-05-13 Paul Eggert <eggert@cs.ucla.edu>
3895 Improve performance of `sort -m' on large files, at the cost of
3896 making some contrived examples unsafe. POSIX allows this
3897 optimization. Performance problem reported by Jonathan Baker in
3898 <http://mail.gnu.org/archive/html/bug-coreutils/2004-05/msg00071.html>.
3900 * src/sort.c (first_same_file): Do not treat input pipes
3901 differently from other files.
3902 * doc/coreutils.texi (sort invocation): Document that "sort -m -o F"
3903 might write F before reading all the input.
3906 2004-05-12 Paul Eggert <eggert@cs.ucla.edu>
3908 * src/od.c (print_ascii, dump_strings): Use e.g. '\a' rather than
3909 '\007', for portability to EBCDIC hosts.
3910 * src/printf.c (print_esc_char): Likewise.
3911 * src/tr.c (unquote, make_printable_str): Likewise.
3913 2004-05-12 Jim Meyering <jim@meyering.net>
3915 * src/remove.c (AD_pop_and_chdir): Move lstat-`.' into if-block
3916 where the result is used. This avoids one unnecessary lstat call
3917 per command line argument.
3919 2004-05-12 Paul Eggert <eggert@cs.ucla.edu>
3921 Don't assume that "make -C" works; Solaris "make" doesn't have -C.
3923 * src/Makefile.am (all_programs.list): New rule, copied from
3924 man/Makefile.am and tests/Makefile.am, except that we use the
3925 system tr rather than ./tr and we don't use tr -s.
3926 * tests/Makefile.am (all_programs): Use it.
3927 * man/Makefile.am (all_programs): Likewise. Renamed from programs,
3928 for consistency. All uses changed.
3930 2004-05-11 Jim Meyering <jim@meyering.net>
3932 * tests/rm/unread3: New test, for the above fix and today's
3933 lib/save-cwd.c improvement.
3934 * tests/rm/Makefile.am (TESTS): Add unread3.
3936 * src/rm.c: Don't include "save-cwd.h". It's no longer used.
3938 2004-05-10 Jim Meyering <jim@meyering.net>
3940 * tests/install/trap: New file. Test for bug fix of 2004-04-18.
3941 * tests/install/Makefile.am (TESTS): Add trap.
3943 * src/remove.c (AD_push): Don't use errno in diagnostic about
3946 Remove these generated files from CVS.
3947 * tests/cut/cut-tests, tests/date/date-tests, tests/join/join-tests:
3948 * tests/ls/ls-tests, tests/pr/pr-tests, tests/tac/tac-tests:
3949 * tests/tail/tail-tests, tests/test/test-tests, tests/tr/range-tests:
3950 * tests/tr/tr-tests, tests/wc/wc-tests:
3952 2004-05-09 Jim Meyering <jim@meyering.net>
3954 * src/tr.c (unquote): Use xcalloc rather than xmalloc and
3955 a loop initializing the just-allocated memory to zero.
3957 2004-05-08 Jim Meyering <jim@meyering.net>
3959 * tests/rm/no-give-up: New file; check for today's fix.
3960 * tests/rm/Makefile.am (TESTS): Add no-give-up.
3962 2004-05-08 Paul Eggert <eggert@cs.ucla.edu>
3964 Fix bug where "rm" gave up too easily, reported by Dan Jacobsen in
3965 <http://mail.gnu.org/archive/html/bug-coreutils/2004-05/msg00013.html>.
3967 * src/remove.c (remove_entry): Check for errno values like ENOENT
3968 that show the file cannot be directory, instead of for errno
3969 values like EPERM that show the file might be a directory. This
3970 is necessary because, when a single unlink() call has multiple
3971 reasons to fail, it can set errno to any of those reasons; it's
3972 only the rare errno value like ENOENT that excludes all the other
3973 possible reasons to fail even when the file is a directory.
3974 (remove_cwd_entries): Don't attempt chdir if the file is known
3975 to not be a directory.
3976 (remove_dir): Use the same method that remove_cwd_entries uses
3977 (for some reason they differed). Don't assert that saved_errno
3978 must be EPERM; it might be just about anything.
3980 2004-05-06 Jim Meyering <jim@meyering.net>
3982 * src/id.c (xgetgroups): Use xnmalloc, rather than xmalloc.
3983 Don't add `1' to the buffer size (it was to protect against malloc
3984 implementations that fail to allocate a buffer of size zero).
3985 That is no longer necessary, since we use a malloc wrapper
3988 * src/wc.c (get_input_fstatus): Use xnmalloc, rather than xmalloc.
3989 * src/head.c (elide_tail_bytes_pipe): Likewise.
3990 * src/df.c (main): Likewise.
3991 * src/shred.c (do_wipefd): Likewise.
3992 * src/users.c (list_entries_users): Likewise.
3993 * src/tail.c (main): Likewise.
3994 * src/md5sum.c (main): Likewise.
3996 2004-04-29 Paul Eggert <eggert@cs.ucla.edu>
3998 * src/df.c (show_disk, show_point): If several filesystems are
3999 mounted on the same mount point, prefer the last one, not the first.
4000 Problem reported by Christian Jones in
4001 <http://mail.gnu.org/archive/html/bug-coreutils/2004-04/msg00200.html>.
4002 (show_disk): Remove unused statp arg. Return bool, not int.
4003 (show_point): Rewrite to avoid gotos. Use the same algorithm
4004 for lofs and dummies for each pass through the mount table,
4005 rather than subtly different algorithms (which are probably
4008 2004-05-03 Jim Meyering <jim@meyering.net>
4010 * Makefile.am (EXTRA_DIST): Add m4/ChangeLog, now that we no longer
4013 2004-05-01 Jim Meyering <jim@meyering.net>
4015 When chown or chgrp is modifying the referent of a symlink,
4016 use the chown(2) function, if possible.
4017 * src/chown-core.c (change_file_owner): Don't hard-code the
4018 open/fchown/close kludge here. Use `chown' instead.
4019 The chown function works just fine on conforming systems.
4020 Other systems now go through the new chown wrapper that
4021 resorts to the old kludge.
4023 * src/chown-core.c (change_file_owner): Add a comment.
4025 2004-04-27 Jim Meyering <jim@meyering.net>
4027 * src/ptx.c: Make over 40 global extern variables `static'.
4028 (syntax_table, re_syntax_table): Remove declarations of two unused
4029 variables (they were exposed by the above change).
4031 * src/du.c (G_fail, opt_nul_terminate_output): Declare `static'.
4032 * src/ln.c (backup_type): Likewise.
4034 * src/remove.c (rm): Add `extern' keyword.
4035 * src/cp-hash.c (forget_created, remember_created)
4036 (src_to_dest_lookup, remember_copied, hash_init, forget_all): Likewise.
4037 * src/copy.c (dest_info_init, src_info_init, copy): Likewise.
4038 * src/chown-core.c (chopt_init, chopt_free, gid_to_name)
4039 (uid_to_name, chown_files): Likewise.
4041 * src/Makefile.am (sc_tight_scope): New rule.
4042 * Makefile.maint (sc_tight_scope): New rule.
4043 (syntax-check-rules): Add it.
4045 2004-04-26 Jim Meyering <jim@meyering.net>
4047 * Use automake-1.8.4. Regenerate dependent files.
4049 * src/sort.c (limfield): Make a comment clearer.
4051 2004-04-25 Paul Eggert <eggert@twinsun.com>
4053 Fix POSIX-conformance bug: "sort -k 3,3.5b" is supposed to skip
4054 leading blanks when computing the location of the field end;
4055 it is not supposed to skip trailing blanks. Solaris 8 "sort"
4056 does conform to POSIX. Also fix the documentation to clarify
4057 this and related issues.
4059 * doc/coreutils.texi (sort invocation): Mention -k earlier, so
4060 that the options are in alphabetical order. Describe how -b works
4061 more-accurately; this involves fixing some examples, too. Mention
4062 what happens if the start field falls after an end field or after
4063 a line end. Warn about using -k without -b, -g, -M, -n, or -t.
4064 Add an example of how to sort IPv4 addresses and Apache Common
4065 Log Format dates. Remove a duplicate example.
4066 (Putting the tools together): Use separate options rather
4067 than agglomerating them.
4068 * src/sort.c (limfield): Use skipeblanks, not skipsblanks, to
4069 decode whether to skip leading blanks.
4070 (trailing_blanks): Remove.
4071 (fillbuf, getmonth, keycompare): Don't trim trailing blanks.
4073 * tests/pr/Test.pm: Fix typo in env_default comment.
4074 * tests/sort/Test.pm: Likewise.
4075 (18c, 18d): Reverse the order of output lines, so that the
4076 test cases conform to POSIX.
4078 2004-04-22 Paul Eggert <eggert@twinsun.com>
4080 More signal-handling cleanup for ls.c. Do not allow signals to
4081 happen between arbitrary output bytes, as the
4082 restore-default-color sequence can bollix up multibyte chars or
4083 color-change sequences in the ordinary output. Instead, process
4084 signals only between printing a file name and changing the color
4085 back to non_filename_text color. That way, if the signal handler
4086 changes the color (to the default), 'ls' will change it back when
4087 'ls' continues (after being suspended).
4089 Also, do not bother with signal-handling unless stdout is a
4090 controlling terminal; this lets stdio buffer better when "ls
4091 --color" is piped or sent to a file.
4093 * src/ls.c (sigprocmask, sigset_t) [!defined SA_NOCLDSTOP]: New macros.
4094 Do not include "full-write.h"; no longer needed.
4095 (tcgetpgrp) [! HAVE_TCGETPGRP]: New macro.
4096 (put_indicator_direct): Remove. All callers changed to use
4098 (caught_signals, interrupt_signal, stop_signal_count): New vars.
4099 (restore_default_color): Don't bother checking for put_indicator
4101 (sighandler): Don't handle SIGTSTP; that's another handler now.
4102 Simply set interrupt_signal to the signal, then exit.
4103 (stophandler, process_signals): New functions.
4104 (main): Don't output any color changes until _after_ the signal
4105 handlers are set up. This fixes a race condition where 'ls'
4106 could be interrupted while initializing colors, and leaving the
4107 terminal in an undesirable state.
4108 Don't mess with signal-handling if standard output is not a
4109 controlling terminal.
4110 When exiting, restore the default color, then restore the
4111 default signal handling, then act on any signals that weren't
4113 Do not print //DIRED// etc. in colors; this avoids the need
4114 to catch signals when printing them.
4115 (print_name_with_quoting): Process signals just before switching
4116 color back to non_filename_text.
4118 2004-04-23 Jim Meyering <jim@meyering.net>
4120 Avoid segfault on systems for which SIZE_MAX != (size_t) -1.
4121 * src/ls.c (quote_name): Use SIZE_MAX, not -1, in calls
4122 of quotearg_buffer. Patch by Mikulas Patocka.
4124 2004-04-18 Paul Eggert <eggert@twinsun.com>
4126 tee ignored SIGPIPE, but POSIX doesn't allow this.
4128 * src/tee.c (main): Do not ignore SIGPIPE, as POSIX 1003.1-2001
4129 does not allow this. This undoes the 1996-10-24 patch.
4131 2004-04-18 Paul Eggert <eggert@twinsun.com>
4133 Signal-handling cleanup for coreutils. Here are the highlights:
4135 - csplit sometimes failed to remove files when interrupted.
4136 - csplit didn't clean up if two signals arrived nearly simultaneously.
4137 - install -s would infloop on System V if SIGCHLD was ignored.
4138 - ls could incorrectly restore color if multiple signals
4139 arrived nearly simultaneously.
4141 * src/csplit.c (sigprocmask, sigset_t) [!defined SA_NOCLDSTOP]:
4143 (filename_space, prefix, suffix, digits, files_created, remove_files):
4145 (caught_signals): New var.
4146 (cleanup): Block signals while deleting all files.
4147 (cleanup_fatal, handle_line_error, regexp_error):
4148 Mark with ATTRIBUTE_NORETURN.
4149 (create_output_file, close_output_file, interrupt_handler):
4150 Block signals while changing the number of output files,
4151 to fix some race conditions.
4152 (delete_all_files): Do nothing if remove_files is zero.
4153 Clear files_created.
4154 (main): Don't mess with signals until after argument processing
4157 * src/csplit.c (main): Rewrite signal-catching code to make it
4158 similar to other coreutils programs. When processing signals,
4159 block all signals that we catch, but do not block signals that we
4160 don't catch. Avoid problems with unsigned int warnings.
4161 * src/ls.c (main): Likewise.
4162 * src/sort.c (main): Likewise.
4164 * src/csplit.c (interrupt_handler):
4165 Use void, not (obsolete) RETSIGTYPE.
4166 * src/shred.c (sigill_handler, isaac_seed_machdep): Likewise.
4168 * src/csplit.c (interrupt_handler) [defined SA_NOCLDSTOP]:
4169 Use simpler "signal (sig, SIG_DFL)" rather than sigaction equivalent.
4170 * src/ls.c (sighandler) [defined SA_NOCLDSTOP]: Likewise.
4171 * src/sort.c (sighandler) [defined SA_NOCLDSTOP]: Likewise.
4172 * src/nohup.c (main) [!defined _POSIX_SOURCE]: Likewise, except
4174 * src/tee.c (main) [!defined _POSIX_SOURCE]: Likewise.
4176 * src/install.c: Include <signal.h>.
4177 (main) [defined SIGCHLD]: Set SIGCHLD handler to the default, if -s is
4178 given, since System V fork+wait does not work if SIGCHLD is ignored.
4180 * src/ls.c (sighandler) [!defined SA_NOCLDSTOP]: Reset signal
4181 handler to self, not to SIG_IGN, since SIGTSTP can be received
4183 (main): Use SA_RESTART, as that is simpler than checking for EINTR
4184 failures all over the place.
4186 2004-04-20 Jim Meyering <jim@meyering.net>
4188 * src/remove.c (is_empty_dir): Clarify comment.
4190 * man/help2man: Accept new option: --program-name=NAME, so that we
4191 can override the one in --version output. This is needed solely
4192 so that test.1 doesn't refer to `[' as the program name.
4193 Reported by Benjamin Cutler as http://bugs.debian.org/205251.
4194 * man/Makefile.am (.x.1): Use help2man's new --program-name option.
4196 * src/pwd.c: Don't include pathmax.h; system.h already does it.
4198 * src/cut.c (cut_fields): Free buffer upon getndelim2 failure.
4200 2004-04-19 Jim Meyering <jim@meyering.net>
4202 * src/shred.c (isaac_seed_start) [AVOID_USED_UNINITIALIZED_WARNINGS]:
4203 Initialize a buffer to avoid warnings from tools like valgrind.
4205 * Makefile.maint (sc_trailing_blank): New rule.
4206 (syntax-check-rules): Add it.
4207 * .x-sc_trailing_blank: New file.
4209 Make pwd work even if the resulting name is so long that getcwd fails.
4210 * src/pwd.c: (path_free, path_init, path_prepend): New functions.
4211 (nth_parent, find_dir_entry, robust_getcwd): New functions.
4212 (main): First try getcwd, then, upon failure, robust_getcwd.
4214 2004-04-18 Jim Meyering <jim@meyering.net>
4216 * src/who.c (print_user): Use xrealloc here, rather than
4217 unchecked realloc. Remove anachronistic casts.
4219 * src/remove.c (full_filename_): Don't leak upon failed realloc.
4221 * src/system.h (readdir_ignoring_dot_and_dotdot): New inline function,
4223 * src/remove.c (readdir_ignoring_dotdirs): Move function to system.h,
4224 renaming it. Update uses.
4226 2004-04-17 Jim Meyering <jim@meyering.net>
4228 * configure.ac: Depend on automake-1.8.3.
4230 * src/join.c (add_file_name): Declare function to be `static'.
4231 (string_to_join_field): Likewise.
4232 * src/remove.c (ds_init, ds_free): Likewise.
4234 * Makefile.maint (sc_prohibit_jm_in_m4): New rule.
4235 (syntax-check-rules): Add to the list.
4237 2004-04-13 Paul Eggert <eggert@twinsun.com>
4239 Use page-aligned buffers whenever we bother to do I/O using buffer
4240 sizes that are tailored for the files.
4242 * src/cat.c: Include getpagesize.h.
4243 * src/copy.c: Likewise.
4244 * src/shred.c: Likewise.
4245 * src/split.c: Likewise.
4246 * src/cat.c (main): Align I/O buffers to page boundaries.
4247 * src/copy.c (copy_reg): Likewise.
4248 * src/shred.c (dopass): Likewise.
4249 * src/split.c (main): Likewise.
4250 * src/dd.c (ROUND_UP_OFFSET, PTR_ALIGN): Remove.
4251 All uses replaced by ptr_align.
4252 * src/od.c (gcd, lcm): Remove; now in system.h.
4253 * src/system.h (gcd, lcm, ptr_align): New functions, moved from od.c.
4255 2004-04-14 Jim Meyering <jim@meyering.net>
4257 Remove m4/Makefile.am: it's no longer needed, with newer automake
4258 * configure.ac (AC_CONFIG_FILES): Remove m4/Makefile.in from the list.
4259 * Makefile.am (SUBDIRS): Remove `m4' from the list.
4261 2004-04-13 Jim Meyering <jim@meyering.net>
4263 * configure.ac: Change `jm_' in AC_DEFINE'd names to `gl_'.
4265 2004-03-27 Paul Eggert <eggert@twinsun.com>
4267 * NEWS: cp -pu and mv -u (when copying) now take the destination
4268 file system time stamp resolution into account.
4269 * doc/coreutils.texi (mv invocation): Document this.
4270 (cp invocation): Document -u (it was missing!) with new behavior.
4272 * src/copy.c: Include "utimecmp.h".
4273 (copy_internal): Compare time stamps using utimecmp rather than
4276 2004-04-09 Jim Meyering <jim@meyering.net>
4278 * Makefile.maint (.re-list): New rule/file, to replace
4279 hard-coded list of header file names.
4280 (sc_system_h_headers): Use the new file.
4281 Don't look for sys2.h anymore.
4283 * src/system.h: Include new "stat-macros.h" rather than hard-coding
4284 all of its macro definitions -- the list was slightly out of date.
4285 Suggestion from Dmitry V. Levin.
4287 2004-04-08 Paul Eggert <eggert@cs.ucla.edu>
4289 * NEWS: Remove noctty flag from dd. Suggested by Philippe Troin.
4290 * doc/coreutils.texi (dd invocation): Likewise.
4291 * src/shred.c (O_NOCTTY): Remove redundant decl.
4292 * src/dd.c (flags, usage): Remove noctty flag.
4293 (main): Always use O_NOCTTY when opening files.
4295 2004-04-08 Jim Meyering <jim@meyering.net>
4297 * src/dd.c (dd_copy): Mark two diagnostics for translations.
4298 (set_fd_flags): Undo part of today's change: it's a little
4299 cleaner -- and more efficient in the common case -- to go
4300 ahead and OR in the -1 when fcntl fails.
4302 * Makefile.maint (sc_dd_max_sym_length): New target.
4303 (syntax-check-rules): Add it.
4305 * src/md5sum.c (PROGRAM_NAME) [algorithm == ALG_SHA1]:
4306 Correct spelling: s/shasum/sha1sum. Reported by Jesse Kornblum.
4308 * src/dd.c (set_fd_flags): Don't OR in -1 when fcntl fails.
4309 Rename parameter, flags, to avoid shadowing global.
4310 (LONGEST_SYMBOL): Tweak comment.
4312 2004-04-07 Paul Eggert <eggert@twinsun.com>
4314 * NEWS: New dd conv= symbols nocreat, excl, fdatasync, fsync,
4315 and new dd options iflag= and oflag=.
4316 * src/dd.c (usage): Likewise.
4317 * src/Makefile.am (dd_LDADD, shred_LDADD): Add fdatasync's lib.
4318 * src/dd.c (fdatasync) [!HAVE_FDATASYNC]: New macro.
4319 (C_NOCREAT, C_EXCL, C_FDATASYNC, C_FSYNC): New macros.
4320 (input_flags, output_flags): New vars.
4321 (LONGEST_SYMBOL): New macro.
4322 (struct symbol_value): Renamed from struct conversion. Members
4323 symbol and value renamed from convname and conversion. The
4324 symbol value is now an array instead of a pointer; this saves
4325 a bit of space and time in practice. All uses changed.
4326 (conversions): Add nocreat, excl, fdatasync, fsync. Now const.
4327 (flags): New constant array.
4328 (iflag_error_msgid, oflag_error_msgid): New constants.
4329 (parse_symbols): Renamed from parse_conversion and generalized
4330 to handle either conversion or flag symbols.
4331 (scanargs): Adjust uses of parse_symbols accodingly. Add
4332 support for iflag= and oflag=. Reject attempts to use
4333 both excl and nocreat.
4334 (set_fd_flags): New function.
4335 (dd_copy): Just return X rather than calling quit (X), since our
4336 caller invokes quit with the returned value. Add support for
4337 fdatasync and fsync.
4338 (main): Add support for iflag=, oflag=, and new conv= symbols.
4339 * src/system.h (O_DIRECT, O_DSYNC, O_NDELAY, O_NOFOLLOW,
4340 O_RSYNC, O_SYNC): Define to 0 if not already defined.
4342 * NEWS: Remove duplicate mention of BLOCKSIZE.
4344 2004-04-02 Andreas Schwab <schwab@suse.de>
4346 * src/stty.c: Add support for IUTF8 input flag.
4348 2004-04-06 Jim Meyering <jim@meyering.net>
4350 * src/system.h (makedev) [mkdev && !makedev]: Define in terms of mkdev.
4351 Interix spells it `mkdev'. Reported by Mark Funkenhauser.
4353 2004-04-04 Jim Meyering <jim@meyering.net>
4355 A specified format is no longer automatically newline terminated.
4356 If you want a newline at the end of your format, use `\n'.
4357 * src/stat.c (print_it): Don't print a newline at the end of
4359 (do_statfs): Add a newline at end of each default format string.
4361 2004-03-30 Paul Eggert <eggert@twinsun.com>
4363 * src/nohup.c (main): Adjust to new calling convention
4364 for set_cloexec_flag.
4366 2004-03-31 Jim Meyering <jim@meyering.net>
4368 * tests/Fetish.pm (run_tests): Remove `.orig' file.
4369 Remove debugging diagnostic.
4371 Specifying an invalid --width=N (-w) or --gap-size=N (-g)
4372 would not elicit an error.
4373 * src/ptx.c: Include "xstrtol.h" and "quotearg.h".
4374 (main): Don't use atoi. Use xstrtoul instead.
4376 2004-03-30 Jim Meyering <jim@meyering.net>
4378 * Makefile.maint (sc_prohibit_atoi_atof): New rule.
4379 (syntax-check-rules): Add it.
4380 * .x-sc_prohibit_atoi_atof: New file.
4382 2004-03-29 Jim Meyering <jim@meyering.net>
4384 * tests/du/files0-from: Use new OUT_SUBST directive, so that this
4385 test is not sensitive to system-dependent block size differences.
4386 Prompted by a report of Solaris 8 differences from Paul Eggert.
4388 * tests/Fetish.pm: Accept new directives: OUT_SUBST, ERR_SUBST.
4389 Rename `%tmp' to `%actual'. Reverse order of last two args to
4390 _compare_files (to $actual, $expected) so as to match declaration.
4392 2004-03-28 Paul Eggert <eggert@twinsun.com>
4394 Fix some gotchas encountered when porting to Solaris 8, using
4395 the Forte 6u2 compiler.
4397 * src/hostname.c [HAVE_SETHOSTNAME && !defined sethostname]:
4398 Declare sethostname, since no Solaris header does it.
4399 * src/who.c: Include "vasprintf.h", for asprintf.
4401 2004-03-28 Jim Meyering <jim@meyering.net>
4404 * src/du.c (process_file): Don't record dev/inode for directories.
4406 Under some circumstances, without -c, du would mistakenly count the
4407 space of hard-linked files, not just the first one it encountered.
4408 Reported by Anthony Thyssen.
4409 * src/du.c (du_files): Don't ever clear the set of `seen' dev/inodes.
4411 * src/du.c: Rename global `print_totals' to `print_grand_total'.
4413 * src/du.c (main): Rearrange filtering loop to be a tiny bit
4416 * src/chown-core.c: Don't include savedir.h -- no longer needed.
4417 * src/chmod.c: Likewise.
4419 2004-03-25 Jim Meyering <jim@meyering.net>
4421 * src/du.c (main): Remove now-unused declaration of `i'.
4423 2004-03-24 Paul Eggert <eggert@twinsun.com>
4425 * src/du.c (main): Filter out file names of length zero before
4426 invoking fts, so that they don't cause fatal errors.
4428 2004-03-25 Jim Meyering <jim@meyering.net>
4430 * tests/du/files0-from (zero-len): Add a test for the above.
4432 2004-02-25 Paul Eggert <eggert@twinsun.com>
4434 * NEWS: New environment var BLOCKSIZE.
4435 * lib/human.c (humblock): Support BLOCKSIZE as well as BLOCK_SIZE.
4436 * tests/envvar-check: Test for it. Factor the code to simplify it.
4438 2004-03-23 Paul Eggert <eggert@twinsun.com>
4440 * NEWS: Shorten the du --files0-from announcement, and say
4441 "NUL-terminated" rather than "NUL-separated".
4442 * src/du.c (EXPECTED_BYTES_PER_FILE_NAME, DEFAULT_PROJECTED_N_FILES):
4444 (usage): Say "NUL-terminated", not "NUL-separated".
4445 (main): Check for I/O error when istream is closed.
4446 Allow --files0-from=F even if F is empty; this specifies no files.
4447 (du_files): Now that we allow the list of files to be empty,
4449 * tests/du/files0-from: Adjust to above changes to src/du.c.
4451 2004-03-24 Jim Meyering <jim@meyering.net>
4453 * tests/tail-2/assert: Avoid race condition that could cause
4454 spurious failure. Based on a patch from Andreas Schwab.
4456 2004-03-23 Jim Meyering <jim@meyering.net>
4458 * src/du.c (main): Free the hash table, too.
4460 2004-03-22 Jim Meyering <jim@meyering.net>
4462 * man/Makefile.am (.x.1): Remove --info-page= option, reverting
4463 the change of 2004-01-22. I can no longer reproduce the problem
4464 that prompted that change, and `info coreutils pr' would display the
4465 `printing text' section of the manual, not the one on `pr invocation'.
4467 * tests/du/files0-from (nul-1, nul-2): Adjust expected diagnostics
4468 to match corrected output.
4470 * src/du.c: Include "readtokens0.h" rather than "readtokens.h".
4471 (main): Use readtoken0 functions rather than readtokens.
4472 Don't use errno when diagnosing readtokens0 failure.
4473 Fix off-by-one error in the token number reported in a diagnostic.
4474 (du_files): Return bool, rather than int.
4475 (main): Call readtokens0_free.
4477 2004-03-21 Jim Meyering <jim@meyering.net>
4479 * src/remove.c (ds_free): Plug a small leak.
4481 * tests/Fetish.pm: Fix typo in comment.
4483 2004-03-07 Jim Meyering <jim@meyering.net>
4485 * NEWS: du accepts a new option --files0-from=FILE, where FILE
4486 contains a list of NUL-separated file names.
4488 * src/du.c: Include "readtokens.h".
4489 (usage): Describe the new option, and adjust the `Usage':
4490 with this option, no FILE may be specified on the command line.
4491 (main): Handle the new option.
4493 * tests/du/files0-from: New tests, for the above.
4494 * tests/du/Makefile.am (TESTS): Add files0-from.
4496 * src/factor.c (do_stdin): Reflect changes in use of readtoken.
4497 * src/tsort.c (tsort): Likewise.
4499 2004-02-29 Paul Eggert <eggert@twinsun.com>
4501 * NEWS: Add support for a new notation @N to get_date to represent
4502 the time stamp with numeric value N. Improve support for
4503 fractional time stamps. date's -d and -f options now accept them.
4504 Likewise for touch -t. date has a new option --iso-8601=ns.
4506 * doc/coreutils.texi (touch invocation):
4507 Describe use of fractional seconds.
4508 (date invocation, Options for date): Likewise.
4509 * doc/getdate.texi (General date syntax, Time of day items): Likewise.
4510 * doc/coreutils.texi (date invocation): Mention effect of LC_TIME.
4511 (Options for date): Describe new --iso-8601=ns option.
4513 * doc/getdate.texi: Add copyright notice. Change getdate to
4514 get_date when talking about the function name.
4515 (Seconds since the Epoch): New section, containing the time_t
4516 info moved from Date input formats section, along with new
4517 info about the @ syntax. Mention negative time stamps,
4518 fractional time stamps, and leap seconds.
4519 (General date syntax): Modernize examples a bit to reflect new
4521 (General date syntax, Relative items in date strings):
4522 Use ' rather than " to quote formats.
4523 (Time of day items): Add an example with fractional seconds.
4524 Describe fractional-second syntax.
4526 * src/Makefile.am (touch_LDADD): New macro, since `touch' now
4527 needs clock_gettime.
4529 * src/date.c (enum Time_spec): New enum TIME_SPEC_NS.
4530 (time_spec_string, time_spec, show_date): Support it.
4531 (usage): Remove description of -ITIMESPEC, as it's obsolete and
4532 confusing. Mention --iso-8601=ns.
4533 (batch_convert): getline returns ssize_t, not int.
4535 * src/touch.c (newtime): Now an array of two timespecs, one
4536 for access and one for modification.
4537 (ref_stats): Remove.
4538 (get_reldate): Use get_date's parameter profile.
4539 (touch, main): Adjust to above changes.
4540 (main): Work even if tm_year == INT_MAX (so long as long int is wider).
4541 Use gettime instead of gettimeofday, for new get_date signature.
4543 * tests/date/Test.pm (test_vector): New tests epoch, ns-10, ns-max32,
4546 2004-03-15 Jim Meyering <jim@meyering.net>
4548 * Makefile.maint (alpha beta major): `Make' the emit_upload_commands
4549 target before updating $(prev_version_file).
4551 * tests/misc/date-sec: New file, to test for just-fixed bug in date.
4552 See today's change in lib/getdate.y.
4553 * tests/misc/Makefile.am (TESTS): Add date-sec.
4555 2004-03-14 Jim Meyering <jim@meyering.net>
4557 * announce-gen (print_changelog_deltas): Use `.sig' suffix for
4558 signature files, not `.asc'. Reported by angico@yahoo.com.
4560 2004-03-13 Jim Meyering <jim@meyering.net>
4562 * src/cp.c (do_copy): Tweak wording in a diagnostic.
4563 Suggestion from Karl Berry.
4564 Include "quoatearg.h".
4565 (do_copy): Use quotearg_colon (not quote) for diagnostics
4566 that begin with `"%s:'.
4568 * src/nl.c (usage): Specify that nl uses _basic_ regular expressions.
4569 Suggestion from Dan Jacobson.
4571 2004-03-12 Jim Meyering <jim@meyering.net>
4575 Sometimes, when source and destination partition are different,
4576 mv mistakenly fails to preserve a hard link. Reported by IIDA Yosiaki.
4578 * src/copy.c: When moving a set of N hard-linked files between
4579 partitions, via two or more command line arguments where the
4580 command line argument containing the Nth link contains no other
4581 link to that same file, mv would mistakenly copy the file, rather
4582 than hard-linking it to the other(s). That happens because when the
4583 final link is processed, its link count has been reduced to 1 since
4584 the other links have been `copied' to the destination partition
4585 and the source links have been removed.
4586 (copy_internal): When in move mode, use the source dev/inode
4587 pair to look up destination name even when st_nlink == 1.
4588 * src/cp-hash.c (src_to_dest_lookup): New function.
4589 * src/cp-hash.h (src_to_dest_lookup): Add prototype.
4590 * tests/mv/part-hardlink: New file. Test for the above fix.
4591 * tests/mv/Makefile.am (TESTS): Add part-hardlink.
4593 * announce-gen: Sync with autoconf.
4595 * tests/ls/time-1: Exit 77 (not 1) if we can't set up for the test.
4596 This was triggered on a Linux-2.2.19 system using a file system
4597 NFS-mounted from some sort of Sun.
4599 2004-03-11 Jim Meyering <jim@meyering.net>
4601 * Use automake-1.8.3. Regenerate dependent files.
4603 2004-03-10 Jim Meyering <jim@meyering.net>
4605 * tests/du/deref-args: Also convert sizes in the 70-79 kB range,
4606 so that this test works with SELinux-enabled systems.
4607 Based on a patch from Tim Waugh.
4609 `join -1 x' would give a misleading diagnostic
4610 * src/join.c (string_to_join_field): Report that a non-numeric field
4611 number is invalid, rather than `so large that it is not representable'.
4612 * tests/join/Test.pm (invalid-j): New partial test for the above fix.
4614 2004-03-06 Jim Meyering <jim@meyering.net>
4616 cp --sparse=always sparse-image-file.img /dev/hda1 could
4617 produce an invalid copy on the destination device.
4619 * src/copy.c (copy_reg): Even with --sparse=always, try to
4620 make `holes' only if the destination is a regular file.
4621 Reported by Szakacsits Szabolcs.
4623 2004-03-03 Paul Eggert <eggert@twinsun.com>
4625 * src/nohup.c (main): Don't invoke set_cloexec_flag with
4626 a file descriptor of -1.
4628 2004-03-02 Dmitry V. Levin <ldv@altlinux.org>
4630 * src/nohup.c: Include "cloexec.h".
4631 (main): Set the copy of stderr to close on exec.
4633 2004-03-01 Paul Eggert <eggert@twinsun.com>
4635 * configure.ac: Include <signal.h> when checking for strsignal,
4636 sys_siglist, and friends. Problem reported by Tony Leneis in
4637 <http://mail.gnu.org/archive/html/bug-coreutils/2004-02/msg00136.html>.
4639 2004-02-25 Paul Eggert <eggert@twinsun.com>
4641 * tests/du/deref-args, tests/du/exclude, tests/du/slash:
4642 * tests/du/trailing-slash: Run envvar-check in case BLOCK_SIZE
4645 2004-02-23 Paul Eggert <eggert@twinsun.com>
4647 * NEWS: Document how chown's USER.GROUP argument is now parsed.
4649 2004-02-23 Jim Meyering <jim@meyering.net>
4651 * src/seq.c (usage): Remove stray space after \n in --help output.
4653 2004-02-22 Jim Meyering <jim@meyering.net>
4655 * src/du.c (usage): Separate -H and --si. Say that the meaning
4656 of -H will soon change to that of --dereference-args (-D).
4658 2004-02-21 Jim Meyering <jim@meyering.net>
4660 * src/comm.c (usage): Tell what comm does when there are no options.
4661 Reword in terms of FILE1 and FILE2 rather than `left file' and
4662 `right file'. Suggestion from Dan Jacobson.
4664 2004-02-15 Paul Eggert <eggert@twinsun.com>
4666 Fix some POSIX-conformance bugs in expr.
4668 * NEWS: document the following changes to src/expr.c.
4669 * doc/coreutils.texi (expr invocation): Likewise.
4670 Document what forms integers may take, and say "integer"
4671 consistently instead of "number". Warn about operands
4672 that "expr" can misinterpret, and how to work around the
4674 * src/expr.c (eval, eval7, eval6, eval5, eval4, eval3, eval2, eval1):
4675 Accept a bool argument specifying whether to evaluate the
4676 expression. This is to allow short-circuit evaluation. All
4678 (null): Report that a string is zero even if it has
4679 a form like "-0" or "00".
4680 (eval1, eval): Use short-circuit evaluation for | and &.
4681 (eval): Return 0 if both arguments are null or zero, instead
4682 of returning the first argument.
4683 * tests/expr/basic: Add some tests for the above.
4685 2004-02-17 Jim Meyering <jim@meyering.net>
4689 `make check' from a build inside a chroot environment would fail
4690 * tests/help-version: Specify an argument (`/') for df, in the
4691 unusual event that there is no valid entry in /etc/mtab.
4692 Likewise for id: add the -u option, so we don't get spurious
4693 failures when there are no user or group names.
4696 * src/sort.c (usage) [-u]: Add punctuation so that the description in
4697 the help2man-generated (line-joined) man page is more readable.
4698 Reported by Tim Waugh.
4699 [-T]: Add a semicolon, for the same reason.
4701 2004-02-15 Jim Meyering <jim@meyering.net>
4703 * Makefile.am (dist-hook): Qualify target with $(srcdir)/ prefix.
4705 2004-02-11 Jim Meyering <jim@meyering.net>
4707 * tests/Makefile.am.in ($(srcdir)/Makefile.am): Use more portable
4708 $(srcdir)/../Makefile.am.in, rather than $<.
4709 Suggestion from Michael Elizabeth Chastain.
4711 2004-02-10 Jim Meyering <jim@meyering.net>
4713 * config/install-sh: Make this script executable.
4714 * Makefile.am (dist-hook): New target, to ensure that config/install-sh
4715 is executable. Otherwise, on systems that lack a suitable install
4716 binary, `make install' would fail, because of the way this script
4717 is invoked (without `$SHELL ' prefix).
4718 Reported by Bob Proulx.
4720 2004-02-08 Jim Meyering <jim@meyering.net>
4724 * tests/rm/rm5: Avoid triggering a bug in OSF/Tru64's sed
4725 that would cause an unwarranted test failure.
4726 * tests/rm/rm3: Likewise.
4728 2004-02-07 Jim Meyering <jim@meyering.net>
4730 Remove xstat function pointer member. The way it was used was not
4731 portable, since some systems (OSF V5.1, Solaris 2.5.1) provide static
4732 inline `stat' and `lstat' functions, thus making the tests of
4733 `xstat == lstat' in copy.c always fail.
4734 * src/copy.h (struct cp_options) [xstat]: Remove member.
4736 * src/copy.c (copy_dir): Set `.dereference' member, not .xstat.
4737 (copy_internal): Use `XSTAT (x, ...)' in place of `*(x->xstat) (...)'.
4738 Use `x->dereference == DEREF_NEVER' in place of `x->xstat == lstat'.
4739 (valid_options): Remove now-obsolete FIXME comments.
4741 * src/cp.c (re_protect): Use `XSTAT (x, ...)' in place of
4742 `*(x->xstat) (...)'.
4743 (do_copy): Declare/use local xstat rather than x->xstat.
4744 (main): Remove code that set x.xstat.
4745 * src/mv.c (cp_option_init): Don't initialize xstat member.
4746 * src/install.c (cp_option_init): Likewise.
4748 * Makefile.cfg (gnu_ftp_host-alpha, etc.): Un-factor .gnu.org suffix,
4749 so that emit_upload_commands can use these variables, too.
4751 2004-02-06 Jim Meyering <jim@meyering.net>
4753 * tests/rm/deep-1: Remove `du' stack space test.
4754 Apparently, `ulimit -s N' isn't portable enough.
4755 This test will be restored (with a guard against losing ulimit)
4756 in its own file later.
4758 * tests/rm/deep-1 (deep): Remove progress-style diagnostics,
4759 since this test doesn't take long enough to merit them.
4760 Run du on $tmp (the containing dir), not $deep, the full path to leaf.
4762 * Makefile.maint (signatures): Remove definition.
4763 Now, automake's gnupload handles this.
4764 (%.sig: %): Remove now-unused rule.
4765 (rel-files): Use automake's $(DIST_ARCHIVES), rather than
4766 `$(distdir).tar.bz2 $(distdir).tar.gz'.
4767 (emit-upload-commands): Adjust to use gnupload.
4769 2004-02-05 Jim Meyering <jim@meyering.net>
4771 * src/system.h (ST_TIME_CMP_NS, ST_TIME_CMP): Remove definitions.
4772 (ATIME_CMP, CTIME_CMP, MTIME_CMP, TIMESPEC_NS): Likewise.
4773 Now, those are all defined in timespec.h.
4776 * src/date.c: Don't include timespec.h, now that system.h does it.
4778 2004-02-02 Paul Eggert <eggert@twinsun.com>
4780 Don't dump core if localtime returns NULL (possible on
4781 hosts with 64-bit time_t and 32-bit int).
4782 * src/date.c: Include "inttostr.h".
4783 (batch_convert, main):
4784 If time conversion fails, exit with nonzero status.
4785 (show_date): Return int to report conversion failure.
4786 Print the time as an int if localtime fails.
4787 * src/uptime.c: Print "??" if the current clock can't
4788 be converted by localtime. This won't happen until the year
4789 2*31 + 1900, but we don't want to dump core even if the current
4790 clock has the wrong value.
4792 * src/stat.c: Include "inttostr.h".
4793 (human_time): Print the date/time as a number of seconds since the
4794 epoch if it can't be converted by localtime. This is better than
4795 just saying "invalid", and is consistent with what "ls" does.
4796 Don't dump core if the year has more than 48 digits; this isn't
4797 possible on any contemporary host, but we might as well do it right.
4799 2004-01-31 Paul Eggert <eggert@twinsun.com>
4801 * src/stat.c (human_time): Accept time rather than
4802 pointer-to-const-time parameter, for clarity. All callers changed.
4804 2004-02-02 Jim Meyering <jim@meyering.net>
4806 * src/stat.c (do_stat): Remove extra trailing newline from
4807 default formats. Reported by Nelson H. F. Beebe.
4809 Print actual fractional seconds in time stamps, not just `.00000000'.
4810 * src/stat.c (human_time): Add and use new parameter, t_ns.
4811 (print_stat): Update callers.
4812 * src/ls.c (TIMESPEC_NS): Remove definition.
4813 * src/system.h (TIMESPEC_NS): Define here, instead, now that stat.c
4814 also uses this macro.
4815 Nelson H. F. Beebe noticed that ls --full-time printed nonzero
4816 fractional seconds for files on an XFS file system, but that stat's
4817 fractional seconds were always zero.
4819 2004-01-28 Paul Eggert <eggert@twinsun.com>
4821 * src/seq.c (print_numbers): Use 'double' for loop index, not
4822 'int', to avoid problems with integer overflow. On almost all
4823 machines 'double' works in every case where 'int' works, and
4824 it works on other cases besides.
4826 2004-01-27 Jim Meyering <jim@meyering.net>
4828 * src/seq.c (usage): Mention that if INCREMENT is omitted,
4829 it defaults to 1, even when FIRST is larger than LAST.
4830 Reword so as not to exclude the possibility that INCREMENT be zero.
4832 2004-01-25 Jim Meyering <jim@meyering.net>
4836 * Makefile.maint (signatures): Comment out definition.
4838 2004-01-23 Jim Meyering <jim@meyering.net>
4840 * Makefile.maint (header_regexp): Add exitfail.
4842 * man/Makefile.am (EXTRA_DIST): Add help2man.
4843 Reported by Nelson H. F. Beebe.
4845 * man/Makefile.am (.x.1): Prefix help2man invocation with `$(PERL) --'
4846 so it works on systems with Perl installed somewhere other than in
4849 * src/paste.c (paste_parallel): Declare local, chr, to be of type
4850 `int', not `char', since it must hold EOF. This bug would make
4851 paste infloop on some systems. Test failures reported by
4852 Nelson H. F. Beebe and Christian Krackowizer.
4854 2004-01-22 Jim Meyering <jim@meyering.net>
4856 * tests/rmdir/fail-perm: New file. Test for just-fixed rmdir bug.
4857 * tests/rmdir/Makefile.am (TESTS): Add fail-perm.
4859 * man/help2man: Fix it so using --info-page='coreutils PROG' works.
4860 * man/Makefile.am (.x.1): Invoke our own (tweaked) copy of help2man.
4861 Use --info-page='coreutils PROG' option.
4862 Now, readlink.1 refers the user to `info coreutils readlink'
4863 rather than to `info readlink'. Reported by Matt Swift.
4865 2004-01-21 Paul Eggert <eggert@twinsun.com>
4867 Exit status cleanup.
4869 * src/basename.c (usage): Use EXIT_SUCCESS, not 0, for clarity.
4870 * src/cat.c, src/chgrp.c, src/chmod.c, src/chown.c, src/chroot.c,
4871 * src/cksum.c, src/comm.c, src/cp.c, src/csplit.c, src/cut.c,
4872 * src/date.c, src/dd.c, src/df.c, src/dircolors.c, src/dirname.c,
4873 * src/du.c, src/echo.c, src/env.c, src/expand.c, src/expr.c,
4874 * src/factor.c, src/fmt.c, src/fold.c, src/head.c, src/hostid.c,
4875 * src/hostname.c, src/id.c, src/install.c, src/join.c, src/kill.c,
4876 * src/link.c, src/ln.c, src/logname.c, src/ls.c, src/md5sum.c,
4877 * src/mkdir.c, src/mkfifo.c, src/mknod.c, src/mv.c, src/nice.c,
4878 * src/nl.c, src/nohup.c, src/od.c, src/paste.c, src/pathchk.c,
4879 * src/pinky.c, src/pr.c, src/printenv.c, src/printf.c, src/pwd.c,
4880 * src/rm.c, src/rmdir.c, src/seq.c, src/setuidgid.c, src/shred.c,
4881 * src/sleep.c, src/sort.c, src/split.c, src/stat.c, src/stty.c,
4882 * src/su.c, src/sum.c, src/sync.c, src/tac.c, src/tail.c, src/tee.c,
4883 * src/test.c, src/touch.c, src/tr.c, src/tsort.c, src/tty.c,
4884 * src/uname.c, src/unexpand.c, src/uniq.c, src/unlink.c, src/uptime.c,
4885 * src/users.c, src/wc.c, src/who.c, src/whoami.c, src/yes.c: Likewise.
4887 * src/cat.c (usage): Don't bother normalizing exit status
4888 since the arg is already the correct exit status now.
4889 * src/cksum.c, src/comm.c, src/csplit.c, src/cut.c,
4890 * src/dircolors.c, src/expand.c, src/fmt.c, src/fold.c, src/head.c,
4891 * src/join.c, src/md5sum.c, src/nl.c, src/od.c, src/paste.c,
4892 * src/pr.c, src/split.c, src/sum.c, src/tac.c, src/tail.c, src/tr.c,
4893 * src/tsort.c, unexpand.c, src/src/uniq.c, src/src/wc.c: Likewise.
4895 * src/chown.c (main): Removed unused local 'fail'.
4897 * src/chroot.c (CHROOT_FOUND_BUT_CANNOT_INVOKE, CHROOT_FAILURE):
4900 * src/chroot.c (main): Initialize exit_failure to EXIT_FAIL.
4901 * src/env.c, src/nice.c, src/su.c: Likewise.
4902 * src/nohup.c (main): Likewise, to NOHUP_FAILURE.
4903 * src/setuidgid.c (main): Likewise, to SETUIDGID_FAILURE.
4904 * src/expr.c (main): Use initialize_exit_failure rather than
4905 setting exit_failure directly; this optimizes away redundant
4907 * src/printenv.c, src/sort.c, src/test.c, src/tty.c: Likewise.
4909 * src/chroot.c (main): Exit with status 1 rather than 127
4910 if chroot itself fails, as per documentation.
4912 * src/chroot.c (main): Use EXIT_ENOENT and EXIT_CANNOT_INVOKE
4913 rather than roll-your-own symbols or integers.
4914 * src/env.c (main): Likewise.
4915 * src/nohup.c (main): Likewise.
4916 * src/su.c (run_shell): Likewise.
4918 * src/cp.c (exit_status): Remove static var....
4919 (main): Making it local here instead. Use =, not |=, to set it.
4921 * src/cut.c (FATAL_ERROR, main): Exit with status EXIT_FAILURE,
4923 * src/date.c (batch_convert, main): Likewise.
4924 * src/dd.c (dd_copy): Likewise.
4925 * src/pr.c (first_last_page, main, getoptarg): Likewise.
4926 * src/tr.c (main): Likewise.
4927 * src/date.c (main): Don't assume EXIT_FAILURE == 1, as
4928 POSIX doesn't require it.
4929 * src/dd.c (write_output, skip, dd_copy): Likewise.
4930 * src/df.c (main): Likewise.
4931 * src/id.c (main): Likewise.
4932 * src/install.c (main): Likewise.
4933 * src/ln.c (main): Likewise.
4934 * src/ls.c (main): Likewise.
4935 * src/mv.c (main): Likewise.
4936 * src/shred.c (main): Likewise.
4938 * src/env.c (main): Exit with status 1, not 2, on errors detected
4940 * src/hostname.c (main): Likewise.
4941 * src/nl.c (main): Likewise.
4942 * src/stty.c (main): Likewise.
4944 * src/expr.c (EXPR_FAILURE): Renamed from EXPR_ERROR, for
4945 consistency with the other programs' naming conventions.
4948 * src/factor.c (main): Do not report a usage error simply
4949 because stdin has bad numbers.
4951 * src/id.c (problems): Now a boolean int, not a counter,
4952 so that we don't have to worry about int overflow. All uses changed.
4953 * src/touch.c (err): Likewise.
4955 * src/md5sum.c (main): Use int, not size_t, to store boolean int.
4957 * src/mkfifo.c (main): Exit with status 1, not 4, if not implemented.
4958 * src/mknod.c: Likewise.
4960 * src/nice.c (main): Exit with status EXIT_FAIL, not EXIT_FAILURE,
4961 on error; this is in case EXIT_FAILURE is unusual.
4962 * src/su.c (main): Likewise.
4964 * src/nohup.c (NOHUP_FOUND_BUT_CANNOT_INVOKE): Remove; all uses
4965 changed to EXIT_CANNOT_INVOKE.
4967 * src/printenv.c (PRINTENV_FAILURE): New constant.
4968 (main): Exit with status PRINTENV_FAILURE, not EXIT_FAILURE, on
4969 command-line syntax problems.
4971 * src/rmdir.c (remove_parents): Don't set 'fail' to a negative number.
4972 (main): Avoid integer overflow when seeing whether errors occurred.
4974 * src/seq.c (print_numbers): Now returns void, not (zero) int.
4975 All callers changed.
4976 (main): Remove unused local variable 'errs'. Always exit successfully
4977 if we reach the end.
4979 * src/setuidgid.c (SETUIDGID_FAILURE): Renamed from FAIL_STATUS,
4980 for consistency with other programs here. All uses changed.
4981 (main): Use 'error' to exit rather than invoking 'exit' here.
4983 * src/sort.c: Don't include <assert.h>.
4984 (SORT_OUT_OF_ORDER, SORT_FAILURE): Now enums, not macros.
4985 (usage): Don't use 'assert'.
4986 (main): Remove redundant assignment to exit_failure.
4988 * src/system.h (EXIT_FAIL, EXIT_CANNOT_INVOKE, EXIT_ENOENT):
4990 (initialize_exit_failure): New inline function.
4991 Include exitfail.h here, since we refer to exit_failure.
4992 All callers changed to not include exitfail.h.
4994 * src/tty.c (TTY_FAILURE, TTY_WRITE_ERROR): New enum values;
4995 substitute them for the corresponding integer constants.
4997 * tests/help-version (expected_failure_status_date): Remove, as
4998 'date' is now normal.
4999 (expected_failure_status_nohup): New var.
5001 2004-01-21 Jim Meyering <jim@meyering.net>
5003 * tests/touch/relative: Remove `command' syntax.
5004 Thanks to Nelson H. F. Beebe and Paul Eggert.
5006 * tests/touch/relative: Test only year/month/day, not hours/min/sec,
5007 so as to avoid problems with systems using TAI clocks.
5008 Although it's no longer necessary, set TZ=UTC0 also for the
5009 initial touch command. Reported by Paul Jarc here:
5010 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/1504
5012 2004-01-20 Diego Biurrun <diego@biurrun.de>
5014 * src/dircolors.hin: Add .mov to the list of media files.
5016 2004-01-19 Paul Eggert <eggert@twinsun.com>
5018 * tests/touch/relative: Use TZ=UTC0, not TZ=utc (which isn't
5019 portable). Problem reported by Christian Krackowizer. Also, use
5020 +0000 rather than +0 to specify a time zone, as the documentation
5021 requires four digits.
5023 2004-01-19 Jim Meyering <jim@meyering.net>
5025 * tests/mv/hard-4: Run envvar-check in case SIMPLE_BACKUP_SUFFIX is set.
5026 * tests/mv/backup-is-src: Likewise.
5027 Problem reported by Peter Horst
5029 2004-01-17 Jim Meyering <jim@meyering.net>
5031 * announce-gen (print_changelog_deltas): Use .sig suffix, not .asc.
5035 2003-12-15 Paul Eggert <eggert@twinsun.com>
5037 * NEWS, doc/coreutils.texi: touch -r and -d can now both be specified,
5038 with -r specifying the origin for -d.
5039 * src/touch.c (flexible_date): Remove static var.
5040 (get_reldate): New function.
5041 (main): Use it, to implement this new behavior.
5043 2004-01-16 Jim Meyering <jim@meyering.net>
5045 * tests/touch/relative: New test for the above.
5046 * tests/touch/Makefile.am (TESTS): Add relative.
5048 2004-01-13 Jim Meyering <jim@meyering.net>
5050 * src/system.h: Include contents of sys2.h.
5051 * src/sys2.h: Remove file.
5052 * src/Makefile.am (noinst_HEADERS): Remove sys2.h.
5054 * Use automake-1.8.2. Regenerate dependent files.
5056 * Update to gettext-0.13.1.
5057 * configure.ac: Use gettext-0.13.1.
5058 * .x-sc_space_tab: Add m4/po.m4 to the list of exceptions.
5060 2004-01-12 Jim Meyering <jim@meyering.net>
5062 * Makefile.maint (%.sig): Use .sig suffix rather than .asc.
5064 * Makefile.maint (po-check): Ensure that cvsu works before using it.
5065 Reported by Alexandre Duret-Lutz.
5067 * src/tail.c (main): Warn about following stdin only when it's a tty.
5069 * configure.ac: Use gl_DEFAULT_POSIX2_VERSION.
5071 2004-01-10 Jim Meyering <jim@meyering.net>
5073 * tests/misc/stat-fmt: Use backticks, not `$()' notation.
5075 2004-01-09 Jim Meyering <jim@meyering.net>
5077 * configure.ac: Quote underquoted `jm_DUMMY_1' to avoid new warning.
5079 2004-01-08 Jim Meyering <jim@meyering.net>
5081 * src/stat.c (human_fstype): Use %lx, not %x format for `unsigned long'.
5082 From Andreas Schwab.
5084 * tests/Makefile.am (TESTS_ENVIRONMENT): Remove `/vg' (prerelease test
5085 remnant) from PATH component. That would cause tests in this directory
5086 not to run the just-built binaries, but rather whatever happened
5087 to be in one's PATH. Reported by Christian Krackowizer.
5089 2004-01-04 Jim Meyering <jim@meyering.net>
5091 * src/csplit.c (new_control_record): Use x2nrealloc
5092 rather than xrealloc.
5094 * src/cp.c (re_protect): Use ASSIGN_STRDUPA rather than
5096 (make_path_private): Likewise.
5098 2004-01-03 Jim Meyering <jim@meyering.net>
5100 * src/paste.c: Use `bool' (not int) as the type for a few
5102 (collapse_escapes): Rewrite to set globals rather than modifying
5104 Use size_t (not int) for all counters and related index variables.
5105 (paste_parallel): Remove needless complexity of
5106 using xrealloc in the loop; just allocate the buffers up front.
5107 Free the two temporary buffers.
5108 Move declarations of locals `down' into scope where used.
5109 (paste_serial): Remove `register' attributes.
5110 (main): Simplify delim-related code.
5111 Free `delims', now that it's malloc'd.
5113 2004-01-02 Jim Meyering <jim@meyering.net>
5115 * src/chroot.c: Include "quote.h".
5116 (CHROOT_FOUND_BUT_CANNOT_INVOKE, CHROOT_FAILURE): Define.
5117 (main): Exit with status of 127, not 1, for too-few-args,
5118 chroot failure, or chdir failure.
5119 Give a better diagnostic upon execvp failure.
5121 * src/du.c (usage): Mention that, with its current meaning,
5124 * src/tail.c (main): Warn about following stdin when it's a tty.
5125 Fail when following by name but no names are specified.
5127 2003-12-30 Jim Meyering <jim@meyering.net>
5129 * src/fold.c (main): Use memcpy, not strcpy.
5131 * src/copy.c (copy_internal): Use ASSIGN_STRDUPA rather than
5134 2003-12-28 Jim Meyering <jim@meyering.net>
5136 * src/unexpand.c (n_tabs_allocated): New global.
5137 (add_tabstop): Use x2nrealloc rather than xrealloc.
5138 * src/expand.c: Likewise.
5140 * tests/misc/expand: New file.
5141 * tests/misc/Makefile.am (TESTS): Add expand.
5143 * src/sort.c (add_temp_dir): Use x2nrealloc rather than xrealloc.
5144 (fillbuf): Use x2nrealloc rather than xrealloc.
5145 (sort): Use xnmalloc rather than xmalloc.
5148 2003-12-27 Jim Meyering <jim@meyering.net>
5150 * src/tee.c (tee): Use xnmalloc rather than xmalloc.
5152 2003-12-29 Paul Eggert <eggert@twinsun.com>
5154 * NEWS: Remove support for join -j1 FIELD, -j2 FIELD, and -o LIST1
5155 LIST2 in POSIX 1003.1-2001 hosts, as required by POSIX.
5157 * doc/coreutils.texi (join invocation): Remove documentation
5158 accordingly. Document that -t makes all separators significant.
5160 * src/join.c: Include posixver.h.
5161 (obsolete_usage): New var.
5162 (longopts): Put obsolete options first.
5163 (OBSOLETE_LONG_OPTIONS): New constant.
5164 (get_option, add_file_name): New functions.
5165 (main): Use them to support new behavior.
5166 (usage): Remove documentation for -j1 FIELD and -j2 FIELD.
5167 Do not mark -j FIELD as obsolescent; it is longstanding
5168 UNIX tradition and is a valid extension to POSIX.
5170 * tests/join/Test.pm (tv): Avoid obsolete -o usage.
5172 2003-12-28 Paul Eggert <eggert@twinsun.com>
5174 * src/join.c (add_field_list): Don't use alloca with unbounded
5175 size; just modify the argument, which is no longer const *.
5177 Various other minor cleanups, mostly to avoid the need for casts.
5179 (extract_field): Renamed from ADD_FIELD, as it's now a function.
5181 (struct field.beg): Now char *, not unsigned char const *. All
5182 uses changed. It shouldn't be const since xmemcoll writes on its
5184 (extract_field): Likewise, for 2nd arg.
5185 (keycmp): Remove now-unnecessary cast of xmemcoll args.
5187 (is_blank): New function, to avoid need to cast arg to unsigned char.
5188 (extract_field): Use it.
5190 (xfields): Rewrite pretty much from scratch.
5192 (hard_LC_COLLATE): Now bool, not int.
5193 (get_line, getseq, add_field_list): Now returns bool, not int.
5194 (decode_field_spec, add_field_list): Return true on success (not
5195 false), for consistency with the rest of the code. All uses changed.
5197 (tab): Now char, not unsigned char. This wasn't 100% necessary
5198 but is slightly cleaner.
5199 (prjoin): Hoist (tab ? tab : ' ') expression, to help the compiler.
5201 (empty_filler): Now const *.
5203 (make_blank): Remove; wasn't needed. Remove all calls.
5204 (main): Don't set uni_blank.nfields; zero is fine.
5206 2003-12-27 Jim Meyering <jim@meyering.net>
5208 * src/join.c: Include "quote.h".
5209 (min, max): Remove definitions.
5210 Make a few function parameters and corresponding
5211 locals `const'. Use bool for boolean variables.
5212 Use size_t (not int) for all counters and related index variables.
5213 (prjoin): Remove now-useless assertion.
5214 (string_to_join_field): New function.
5215 (main): Accept join fields as large as SIZE_MAX.
5216 (keycmp): Rename `min' to MIN and max to MAX.
5218 2003-12-26 Jim Meyering <jim@meyering.net>
5220 fold -s didn't work on e.g., alpha-based systems.
5221 * src/fold.c (fold_file): Adjust types (int->size_t) so that using
5222 x2nrealloc works properly on systems with differing sizes for int
5223 and size_t. Reported by Nelson Beebe.
5225 * src/fold.c: Use `bool' (not int) as the type for a few
5228 2003-12-23 Paul Eggert <eggert@twinsun.com>
5230 * src/ls.c (length_of_file_names_and_frills):
5231 Remove forward decl; not needed.
5232 (print_file_name_and_frills, length_of_file_name_and_frills):
5233 With -m, don't output spaces before inum or size.
5234 (print_with_commas): Don't output space just before newline.
5236 2003-12-24 Jim Meyering <jim@meyering.net>
5238 * tests/ls/Makefile.am (TESTS): Add m-option.
5239 * tests/ls/m-option: New file. Test for above fixes.
5241 2003-12-20 Jim Meyering <jim@meyering.net>
5245 * src/pr.c: Change type of global, buff_allocated, to size_t.
5247 * src/join.c [struct seq]: Change types of members count and alloc
5248 from `int' to `size_t'.
5250 * tests/Makefile.am (root-hint): Tweak wording.
5252 * src/du.c: Accept new option (-0, --null) that makes it so each
5253 output line is NUL-terminated rather than newline-terminated.
5255 * src/dd.c (apply_translations): Don't prohibit conv=unblock,sync.
5256 Reported by Volker Paul.
5257 * tests/dd/Makefile.am (TESTS): Add unblock-sync.
5258 * tests/dd/unblock-sync: New test for the above.
5260 2003-12-19 Jim Meyering <jim@meyering.net>
5262 * tests/misc/nohup: Double quote back-ticked expression,
5263 in case it ends up having an unexpected value.
5265 * tests/ls/no-arg: Use ls's -1 option in both runs.
5267 * src/du.c (fts_debug): New global.
5268 (FTS_CROSS_CHECK, DEBUG_OPT): Define.
5269 (main): Make fts use FTS_TIGHT_CYCLE_CHECK.
5270 (main) [DU_DEBUG]: Accept -d option.
5272 2003-12-18 Jim Meyering <jim@meyering.net>
5274 * src/ls.c (format_user): Increment dired_pos via two statements,
5275 `dired_pos += width; dired_pos++;' rather than one,
5276 `dired_pos += width + 1;' since the latter could conceivably overflow.
5277 (format_group): Likewise.
5280 * configure.ac: Require automake-1.8.
5282 2003-12-12 Jim Meyering <jim@meyering.net>
5284 * Use automake-1.8. Regenerate dependent files.
5286 2003-12-08 Jim Meyering <jim@meyering.net>
5288 * Makefile.maint (news-date-check): New rule.
5289 (alpha beta major): Depend on it.
5291 2003-12-03 Paul Eggert <eggert@twinsun.com>
5293 * NEWS: ls -l (and similar options) now adjust all columns to
5294 fit the data. Generalized from a suggestion by Leah Q for file sizes.
5295 * src/ls.c (INODE_DIGITS, LOGIN_NAME_MAX, ID_LENGTH_MAX): Remove.
5296 (format_user_width, format_group_width, unsigned_file_size,
5297 format_group): New functions.
5298 (block_size_width): Renamed from block_size_size.
5299 (inode_number_width, nlink_width, owner_width, group_width,
5300 author_width, major_device_number_width, minor_device_number_width,
5301 file_size_width): New vars.
5302 (clear_files): Initialize them.
5303 (gobble_file): Set them. Don't ceiling block_size_width to 7.
5304 (print_long_file): Use them.
5305 (gobble_file): Use a new local variable 'f' to make the code
5306 smaller and more consistent with other functions.
5307 (format_user): Output to stdout, not to a buffer, so that we
5308 don't have to worry about buffer overrun. Update dired_pos.
5309 (print_long_file): Don't put owner, group, author into buffer;
5310 just print them directly. Don't assume link counts and
5311 major and minor numbers fit into unsigned long int.
5312 * tests/cp/same-file, tests/mv/part-symlink: Don't assume that
5313 'ls' output is fixed-width.
5315 2003-12-02 Jim Meyering <jim@meyering.net>
5317 * src/md5sum.c: Include sha1.h (reflect renaming: sha.h -> sha1.h.
5319 2003-11-27 Jim Meyering <jim@meyering.net>
5321 * Use automake-1.7f. Regenerate dependent files.
5323 2003-11-24 Paul Eggert <eggert@twinsun.com>
5325 Parse floating-point operands and options in the C locale.
5326 POSIX requires this for printf, and we might as well be
5327 consistent elsewhere (tail, sleep, seq).
5329 * src/printf.c: Remove decls of strtod, strtol, strtoul; no longer
5330 needed now that we assume C89. Include "c-strtod.h".
5331 (xstrtod): Call c_strtod, not strtod.
5332 * src/sleep.c: Include "c-strtod.h".
5333 (main): Update xstrtod call to include new argument, c_strtod.
5334 * src/seq.c (scan_double_arg): Likewise.
5335 * src/tail.c (parse_options): Likewise.
5337 2003-11-24 Jim Meyering <jim@meyering.net>
5339 * tests/rm/fail-2eperm: Handle another errno variant (HPUX, EPERM).
5340 Reported by Mark Conty.
5342 2003-11-22 Jim Meyering <jim@meyering.net>
5344 * Makefile.maint (sc_xalloc_h_in_src): Remove rule. Subsumed by...
5345 (sc_system_h_headers): Do this test only if sys2.h exists.
5347 2003-11-20 Jim Meyering <jim@meyering.net>
5349 * tests/help-version: Ensure that the bug-reporting address is
5350 included in the --help output for every program.
5351 * tests/Makefile.am (TESTS_ENVIRONMENT): Add $PACKAGE_BUGREPORT.
5353 * src/ptx.c (usage): Output bug-reporting address.
5354 Reported by Dan Jacobson.
5356 2003-11-19 Jim Meyering <jim@meyering.net>
5358 * src/join.c (usage): Mention that FILE1 and FILE2 must be sorted
5359 on the join fields. Suggestion from Bruce Robertson.
5361 2003-11-18 Jim Meyering <jim@meyering.net>
5363 `od -c -w9999999' could segfault
5364 * src/od.c (dump): Use xnmalloc/free, not alloca.
5366 2003-11-16 Jim Meyering <jim@meyering.net>
5368 * Use autoconf-2.59. Regenerate dependent files.
5370 * tests/du/hard-link: Minor tweak: use mkdir -p.
5372 Fix read-from-free'd-buffer error detected by valgrind.
5373 * src/csplit.c (remove_line): Don't return a pointer to data in
5374 a freed buffer. Instead, arrange to free the buffer on the
5377 * tests/misc/csplit: New test for above fix.
5379 2003-11-11 Jim Meyering <jim@meyering.net>
5381 * src/ls.c (extract_dirs_from_files): Avoid useless copy operations.
5382 This avoids a warning from valgrind about memcpy with overlapping
5383 source and destination.
5385 * configure.ac: Require automake-1.7.8.
5387 2003-11-09 Jim Meyering <jim@meyering.net>
5389 * Use automake-1.7.9. Regenerate dependent files.
5391 * src/rm.c: Support new options: --preserve-root and --no-preserve-root.
5392 * src/chown.c: Likewise.
5394 * src/chown-core.c: Include "root-dev-ino.h".
5395 (chopt_init): Initialize new member.
5396 (change_file_owner): Support rm's new --preserve-root option.
5398 * src/remove.c: Include "root-dev-ino.h".
5399 (remove_cwd_entries): Remove now-obsolete FIXME comment.
5400 (remove_dir): Support rm's new --preserve-root option.
5402 * src/chown.c: Include "root-dev-ino.h".
5403 Add new options: --preserve-root and --no-preserve-root.
5405 * src/chmod.c: Include "root-dev-ino.h".
5406 (process_file): Use newly-factored-out ROOT_DEV_INO_CHECK and
5407 ROOT_DEV_INO_WARN macros.
5408 (get_root_dev_ino): Remove function definition, now that it's
5409 been moved to a separate file.
5410 (usage): Describe new options.
5412 * src/mv.c (rm_option_init): Initialized new member.
5414 * src/remove.h: Include "dev-ino.h".
5415 (struct rm_options): Add new member: root_dev_ino.
5416 * src/chown-core.h: Include "dev-ino.h".
5417 (struct Chown_option): Add new member: root_dev_ino.
5419 2003-11-06 Jim Meyering <jim@meyering.net>
5421 * src/paste.c (paste_parallel): Use `sizeof *var' rather than
5422 hard-coding `sizeof FILE*'.
5424 2003-11-05 Dennis Smit <ds@nerds-incorporated.org>
5426 * src/wc.c (main): Free `fstatus' so there is no confusion about
5427 whether it's leaked or not.
5428 * src/who.c (who): Likewise for `utmp_buf'.
5430 2003-11-05 Paul Eggert <eggert@twinsun.com>
5432 Fix 'cut' problems with size_t overflow and unsigned int.
5433 More generally, resize integer variables to fit use more precisely.
5434 * src/cut.c (ADD_RANGE_PAIR): Remove unnecessary parens.
5435 (struct range_pair): Make members to be of type size_t, not unsigned.
5436 (max_range_endpoint, eol_range_start): Now size_t, not unsigned.
5437 (suppress_non_delimited, output_delimiter_specified,
5438 have_read_stdin, print_kth, set_fields): Now bool, nt int.
5439 (delim): Now unsigned char, not int.
5440 (mark_printable_field, is_printable_field, is_range_start_index,
5441 set_fields, set_fields, cut_bytes, cut_fields):
5442 Use size_t, not unsigned, for field and byte counts.
5443 (hash_int): Use uintptr_t, not unsigned, for pointers converted
5444 to integers. This squeezes more info out of them.
5445 (set_fields, cut_bytes, cut_fields, main):
5446 Use bool, not int, for booleans.
5447 (set_fields): Allocate zeroed byte array with xzalloc, not xcalloc.
5449 2003-11-05 Paul Eggert <eggert@twinsun.com>
5451 * man/Makefile.am (check-programs-vs-x):
5452 Work even if $(programs) contains '$'.
5453 Work even if 'missing=1' in environment.
5454 Don't report an error simply because $(programs) outputs nothing.
5456 2003-11-05 Jim Meyering <jim@meyering.net>
5458 * Use autoconf-2.58. Regenerate dependent files.
5460 * src/tr.c (spec_init): Fix typo in last change.
5462 * src/sys2.h (case_GETOPT_VERSION_CHAR): Cast NULL to `(char *)' in
5463 call to variadic version_etc function, so that it works even on systems
5464 for which sizeof char* != sizeof int.
5465 * src/true.c (main): Likewise.
5466 * basename.c, chroot.c, cksum.c, dd.c, dirname.c, echo.c, expr.c:
5467 * factor.c, hostid.c, hostname.c, link.c, logname.c, nice.c, nohup.c:
5468 * pathchk.c, printenv.c, printf.c, pwd.c, setuidgid.c, sleep.c, stty.c:
5469 * sync.c, test.c, tsort.c, unlink.c, uptime.c, users.c, whoami.c, yes.c:
5470 Similarly, cast NULL to `(char *)' in call to variadic function,
5471 parse_long_options, so that it works even on systems for which
5472 sizeof char* != sizeof int.
5473 A similar problem was reported by Harti Brandt in
5474 http://mail.gnu.org/archive/html/bug-gnu-utils/2003-10/msg00320.html.
5476 * src/users.c (users): Free `utmp_buf' explicitly so that people
5477 don't mistake this for a real leak.
5478 Patch by Dennis Smit <ds@nerds-incorporated.org.
5480 2003-11-04 Paul Eggert <eggert@twinsun.com>
5482 * README: Document _POSIX2_VERSION.
5484 2003-11-04 Jim Meyering <jim@meyering.net>
5486 * src/tac.c (memrchr): Remove #if-0'd function.
5487 (tac_stdin_to_mem): Clean up #if-0'd code.
5489 * src/od.c (decode_format_string): Remove unnecessary casts.
5490 Use more maintainable `sizeof *var'.
5491 (main): Call decode_format_string rather than decode_one_format,
5492 now that `spec' may be NULL.
5494 * src/chmod.c (AUTHORS): Add my name.
5496 * src/split.c (next_file_name): Use `sizeof *var' rather than
5497 hard-coding `sizeof size_t'.
5499 * src/sort.c (new_key): Use xzalloc, not xcalloc (1, ...).
5501 * src/cut.c (ADD_RANGE_PAIR): Use x2nrealloc rather than xrealloc,
5502 to avoid potential overflow in pointer arithmetic.
5503 (set_fields): Use not `1', but rather `sizeof *printable_field' as
5504 second argument to xcalloc.
5505 * src/od.c (decode_format_string, dump_strings): Use x2nrealloc
5506 rather than xrealloc.
5507 * src/date.c (show_date): Likewise.
5508 * src/join.c (ADD_FIELD, initseq, getseq): Likewise.
5509 * src/pr.c (store_char): Likewise.
5510 * src/fold.c (fold_file): Likewise.
5512 * src/copy.c (triple_hash, triple_hash_no_name): Adjust to reflect
5513 type changes (unsigned int -> size_t) in hash.c.
5514 * src/cp-hash.c (src_to_dest_hash): Likewise.
5515 * src/du.c (entry_hash): Likewise.
5516 * src/ls.c (dev_ino_hash): Likewise.
5517 * src/cut.c (hash_int): Likewise. Declare function as static.
5519 2003-11-03 Jim Meyering <jim@meyering.net>
5521 * tests/misc/Makefile.am (TESTS_ENVIRONMENT): Define PACKAGE_VERSION.
5522 * tests/misc/fold: Fail the test immediately if we're not running
5523 the expected version of fold.
5525 2003-11-02 Jim Meyering <jim@meyering.net>
5527 * src/tr.c (append_normal_char, append_range, append_char_class)
5528 (append_repeated_char, append_equiv_class, spec_init): Use `sizeof *var'
5529 rather than `sizeof EXPLICIT_TYPE'. The former is more maintainable
5530 and usually shorter.
5531 * src/copy.c (copy_internal): Likewise.
5532 * src/join.c (initseq, add_field, make_blank): Likewise.
5533 * src/od.c (main): Likewise.
5534 * src/cp.c (make_path_private): Likewise.
5535 * src/tsort.c (new_item, record_relation): Likewise.
5537 * src/df.c (add_fs_type, add_excluded_fs_type, main): Likewise.
5538 (main): Also remove anachronistic cast of xmalloc return value.
5539 * src/ptx.c (alloc_and_compile_regex, main): Likewise.
5540 (main): Also remove anachronistic cast of xmalloc return value.
5541 * src/sort.c (inittables): Likewise.
5542 (sort): Also Split a long line.
5544 2003-10-25 Jim Meyering <jim@meyering.net>
5546 * src/copy.c (triple_hash, triple_hash_no_name): Adjust to reflect
5547 type changes (unsigned int -> size_t) in hash.c.
5548 * src/cp-hash.c (src_to_dest_hash): Likewise.
5549 * src/du.c (entry_hash): Likewise.
5550 * src/ls.c (dev_ino_hash): Likewise.
5551 * src/cut.c (hash_int): Likewise. Declare function as static.
5553 2003-10-21 Jim Meyering <jim@meyering.net>
5555 Don't fail when run with VERBOSE=yes.
5556 * tests/chgrp/basic: Do `set +x' before starting the subshell
5557 from which we invoke chgrp. Otherwise, the output from the
5558 VERBOSE=yes-induced `set -x' would result in spurious differences.
5559 Reported by Russel Coker via Michael Stone.
5561 2003-10-19 Jim Meyering <jim@meyering.net>
5563 chmod now uses fts to perform a directory traversal when -R is
5564 specified. Before, it operated on full path names, and as such
5565 would encounter the PATH_MAX (often 4096) limit.
5567 * src/chmod.c: Include "xfts.h".
5568 (process_file): Rename from change_file_mode.
5569 Adapt to be used with fts.
5570 (process_files): New function.
5572 2003-10-18 Jim Meyering <jim@meyering.net>
5574 * tests/du/deref-args: Ensure that du -D now dereferences all
5575 symlinks specified on the command line, not just those that
5576 reference directories.
5578 * basename.c, cat.c, chroot.c, cksum.c, comm.c, cp.c, csplit.c, cut.c:
5579 * dd.c, df.c, dirname.c, du.c, echo.c, env.c, expr.c, factor.c, head.c:
5580 * hostid.c, hostname.c, id.c, link.c, ln.c, logname.c, ls.c, md5sum.c:
5581 * mv.c, nice.c, nl.c, nohup.c, paste.c, pathchk.c, pinky.c, pr.c:
5582 * printenv.c, printf.c, pwd.c, rm.c, setuidgid.c, sleep.c, sort.c:
5583 * split.c, stty.c, sum.c, sync.c, tac.c, tail.c, tee.c, test.c:
5584 * touch.c, tsort.c, uniq.c, unlink.c, uptime.c, users.c, wc.c:
5585 * who.c, whoami.c, yes.c (AUTHORS): Revert the WRITTEN_BY/AUTHORS change
5586 of 2003-09-19. Now, AUTHORS is a comma-separated list of strings.
5587 Update the call to parse_long_options so that `AUTHORS, NULL' are the
5589 * src/true.c (main): Append NULL to version_etc argument list.
5590 * src/sys2.h (case_GETOPT_VERSION_CHAR): Likewise.
5592 2003-10-17 Andreas Schwab <schwab@suse.de>
5594 * tests/mk-script: Get $srcdir from first parameter instead of
5596 (main): Update usage.
5598 * tests/Makefile.am.in ($(srcdir)/$x-tests): Pass $(srcdir) as
5599 first argument of mk-script.
5600 ($(srcdir)/Makefile.am): Likewise. Prepend $(srcdir) to target.
5602 2003-10-17 Jim Meyering <jim@meyering.net>
5604 * src/mv.c (usage): Tweak descriptions of -i and -f so that the
5605 generated `man' page is more readable. Suggestion from Dan Jacobson.
5607 * src/chown-core.c (change_file_owner): Handle the cases in
5608 which fts_info indicates an error with the given entry.
5610 * src/du.c (main): Simply assign to bit_flags.
5611 Don't bother with bit arithmetic.
5613 * tests/chmod/no-x: New file.
5614 * tests/chgrp/no-x: New file.
5615 * tests/chmod/Makefile.am (TESTS): Add no-x.
5616 * tests/chgrp/Makefile.am (TESTS): Likewise.
5618 * src/du.c: Include "xfts.h".
5619 (du_files): Use xfts_open, rather than fts_open.
5620 * src/chown-core.c (chown_files): Likewise.
5622 2003-10-16 Jim Meyering <jim@meyering.net>
5624 * src/chgrp.c (main): Simply assign to bit_flags.
5625 Don't bother with bit arithmetic.
5626 * src/chown.c (main): Likewise.
5627 Rename a couple of local variables.
5628 Remove unnecessary casts.
5630 * src/tail.c (start_bytes): Rename local, remainder, to avoid
5631 gcc's warning about shadowing a global.
5633 2003-10-15 Jim Meyering <jim@meyering.net>
5635 chown and chgrp now accept POSIX-mandated -H, -L, -P options and
5636 use fts to perform a directory traversal when -R is specified.
5637 Before, they operated on full path names, and as such would
5638 encounter the PATH_MAX (often 4096) limit.
5639 They are more efficient. For example, before, chgrp -R would
5640 take almost 5 seconds to change about 2000 directories and fail
5641 (with `File name too long'), while now it succeeds on a hierarchy
5642 of depth 20,000 in 1/10 the time.
5644 * src/chown.c: Include "userspec.h" and "fts_.h".
5645 (WRITTEN_BY): Add my name.
5646 (getpwnam, getgrnam, getgrgid): Remove declarations.
5647 (endpwent): Remove definition.
5649 (main): Handle new options.
5650 Call new function, chown_files rather than change_file_owner.
5652 * src/chgrp.c: Include "fts_.h".
5653 (WRITTEN_BY): Add my name.
5654 (MAXUID, MAXGID): Remove definitions. Use GID_T_MAX instead of
5657 (main): Handle new options.
5658 Call new function, chown_files rather than change_file_owner.
5660 Rewrite to iterate through hierarchies using fts rather than
5661 via explicit recursion.
5662 * src/chown-core.c: Include "fts_.h"
5663 (change_file_owner): Rewrite to use FTS* and FTSENT* and to operate
5664 on a single file at a time.
5665 (chown_files): New function.
5666 * src/chown-core.h [enum Dereference_symlink]: Remove declaration.
5667 [struct Chown_option] (recurse, force_silent): Change type to `bool'.
5668 [struct Chown_option] (dereference): Remove member with ambiguous name.
5669 [struct Chown_option] (affect_symlink_referent): New member.
5670 (chown_files): New prototype.
5672 * tests/chgrp/recurse: Update tests accordingly.
5673 * tests/chgrp/posix-H: New tests for the above.
5674 * tests/chgrp/Makefile.am (TESTS): Add posix-H.
5676 * src/ln.c (usage): Clarify that --directory, -d, -F probably won't
5677 work even for superuser. Suggestion from Dan Jacobson.
5679 2003-10-14 Paul Eggert <eggert@twinsun.com>
5681 Fix some number-parsing bugs, e.g., "head -n 100k@" wasn't
5683 * lib/human.c, lib/xstrtoimax.c, lib/xstrtol.c, lib/xstrtol.h,
5684 lib/xstrtoul.c, lib/xstrtoumax.c: Sync with gnulib.
5685 * src/sort.c (parse_field_count): Handle the case where overflow
5686 and invalid suffix char are both reported.
5688 2003-10-14 Jim Meyering <jim@meyering.net>
5690 * src/ls.c (decode_switches) [TIOCGWINSZ]: Comment out the
5691 warning-inducing test, ws.ws_col <= SIZE_MAX, since it was always
5694 2003-10-13 Paul Eggert <eggert@twinsun.com>
5696 Fix to avoid a denial-of-service attack if the display width is
5697 enormous. Also, clean up the code a bit by removing duplicate code.
5699 * src/ls.c (init_column_info): Remove forward decl; no longer needed.
5700 (calculate_columns): New function, that contains code that used
5701 to be common to print_many_per_line and print_horizontal.
5702 (print_many_per_line, print_horizontal): Use it.
5703 (decode_switches): Set max_idx here, not in calculate_columns.
5704 (print_current_files): Don't call init_column_info; calculate_columns
5706 (init_column_info): Don't allocate a lot more space than is needed
5707 to represent the current set of files. Allocate all the new
5708 size_t cells in one call to xnmalloc, rather than a row at a time.
5710 2003-10-13 Jim Meyering <jim@meyering.net>
5712 * src/ls.c (init_column_info): Add another FIXME comment.
5714 2003-10-13 Paul Eggert <eggert@twinsun.com>
5716 Fix address-arithmetic bug in 'ls', reported by Georgi Guninski.
5717 Remove several arbitrary limits on hosts where int cannot represent
5720 * src/ls.c (struct bin_str.len, length_of_file_name_and_frills, indent,
5721 nfiles, files_index, tabsize, line_length, struct column_info.line_len,
5722 struct column_info.col_arr[0], max_idx):
5723 Now size_t, not int.
5724 (get_funky_string): Return bool indicating success, instead of
5725 a negative count to indicate failure. Store number of columns
5726 through new parameter OUTPUT_COUNT; that way, they can never
5727 go negative. Change equals_end from int to bool. All uses
5729 (struct column_info.valid_len): Now bool, not int. All uses changed.
5730 (dired_dump_obstack, get_funky_string, clear_files,
5731 extract_dirs_from_files, print_current_files,
5732 print_many_per_line, print_horizontal, init_column_info,
5733 put_indicator, length_of_file_name_and_frills,
5734 print_with_commas): Use size_t, not int, for local variables
5736 (decode_switches): Decode sizes using xstrtoul, not xstrtol.
5737 Check for TIOCGWINSZ returing negative values (or values greater
5739 (visit_dir, main, parse_ls_color, queue_directory, add_ignore_pattern,
5741 Use xmalloc and xnmalloc, not XMALLOC.
5742 (gobble_file): Use xnrealloc, not XREALLOC.
5743 (print_color_indicator): Remove now-unnecessary cast to size_t.
5745 2003-10-12 Paul Eggert <eggert@twinsun.com>
5747 * tests/du/no-x: Change wording of diagnostic to match latest du.c.
5748 * tests/sort/sort-tests: Remove from CVS; assume that people
5749 brave enough to check coreutils out from CVS can rebuild it.
5751 2003-10-12 Jim Meyering <jim@meyering.net>
5753 New options: --preserve-root and --no-preserve-root.
5754 * src/chmod.c (change_file_mode): Honor new option.
5755 (change_file_mode): Strip trailing slashes on directory
5756 argument passed to change_dir_mode.
5757 (get_root_dev_ino): New function.
5758 (main): Initialize global, root_dev_ino.
5760 * src/copy.c (copy_internal): Don't #ifdef-out simple uses of
5761 S_ISLNK or S_ISSOCK. The S_IS* macros are guaranteed to be defined
5763 * src/chmod.c (change_file_mode): Likewise.
5765 2003-10-08 Jim Meyering <jim@meyering.net>
5767 * src/csplit.c (main): Remove obsolete FIXME.
5769 2003-10-07 Jim Meyering <jim@meyering.net>
5771 * Use automake-1.7.8. Regenerate dependent files.
5773 2003-09-29 Paul Eggert <eggert@twinsun.com>
5777 * doc/coreutils.texi (csplit invocation):
5778 The regexp offset need not have a sign; POSIX requires support
5779 for signless offets.
5781 Be more careful about int widths. For example, remove some
5782 arbitrary limits by replacing 'unsigned' with 'size_t',
5783 'uintmax_t', etc. Use standard bool rather than a homegrown type.
5784 * lib/Makefile.am (libfetish_a_SOURCES): Add xstrtoimax.c.
5785 * src/csplit.c (FALSE, TRUE, boolean): Remove. All uses changed
5786 to <stdbool.h> usage.
5787 (struct control): offset is now intmax_t, not int.
5788 repeat_forever is now bool, not int.
5789 (struct cstring): len is now size_t, not unsigned int.
5790 (struct buffer_record): bytes_alloc, bytes_used, num_lines are now
5791 size_t, not unsigned. start_line, first_available are now
5792 uintmax_t, not unsigned.
5793 (hold_count, control_used): Now size_t, not unsigned.
5794 (last_line_number, current_line, bytes_written):
5795 Now uintmax_t, not unsigned.
5796 (save_to_hold_area, red_input, keep_new_line, record_line_starts,
5797 create_new_buffer, get_new_buffer, load_buffer, find_line,
5798 process_regexp, split_file, new_control_record, extract_regexp,
5799 get_format_width, get_format_prec, max_out):
5800 size args, locals, and returned values are now size_t, not unsigned
5802 (get_first_line_in_buffer, find_line, write_to_file,
5803 handle_line_error, process_line_count, regexp_error, process_regexp,
5805 File line, byte, and repetition counts are now uintmax_t, not unsigned.
5806 (check_for_offset): Don't require a sign before the offset.
5807 Use xstrtoimax to do the real work.
5808 (extract_regexp): Remove harmful cast of size to unsigned.
5809 256 -> 1<<CHAR_BIT, for clarity.
5810 (get_format_flags): Return at most 3, to avoid worries about overflow.
5812 (bytes_to_octal_digits): Remove.
5814 (cleanup): Don't check whether output_stream is NULL, since
5815 close_output_file does that for us.
5817 (new_line_control, create_new_buffer): Use "foo *p = xmalloc
5818 (sizeof *p);" instead of the more long-winded alternatives.
5820 (get_new_buffer): Use O(1) algorithm for resizing a buffer
5821 to a much larger size, instead of an O(N) algorithm.
5823 (process_regexp): Use plain NULL rather than casted 0.
5825 (make_filename): Use %u, not %d, to format unsigned file number.
5827 (new_control_record): Use xrealloc exclusively, since it handles
5830 (extract_regexp): Change misspelled word in diagnostic.
5832 (get_format_width): Even if a minimum field width is specified,
5833 allow room for enough octal digits to represent the value of
5834 the maximum representible integer. This fixes a potential
5835 buffer overrun. Calculate this room at compile-time, not
5836 at run-time; this removes the need for bytes_to_octal_digits.
5837 Check for overflow; this removes a FIXME.
5839 (get_format_prec): Don't allow precision to be signed; it's
5840 not ANSI. Check for overflow. Remove hardcoded "11" as
5841 default precision; this fixes a potential buffer overrun
5842 on hosts with wider size_t.
5844 (get_format_conv_type): Change local variable to be of type
5845 unsigned char, not int; this removes a potential subscript
5846 violation on hosts where char is signed.
5848 (max_out): Replace "for (;*p;)" with more-standard "while (*p)".
5849 Allow "%%" in format. Don't overflow when
5850 counting lots of percents.
5852 (usage): Default sprintf format is %02u, not %d.
5854 2003-10-05 Jim Meyering <jim@meyering.net>
5856 * src/chown-core.c (change_file_owner): Remove set-but-not-used local.
5858 * src/du.c (du_files): Mark diagnostic for translation.
5860 2003-10-04 Jim Meyering <jim@meyering.net>
5862 * src/du.c (du_files): Ignore any failure of fts_close.
5863 Give better diagnostics for failed fts_open.
5865 * src/du.c (MAX_N_DESCRIPTORS): Remove now-unused definition.
5867 Deprecate existing use of -H (aka --si).
5868 * src/du.c (enum) [HUMAN_SI_OPTION]: New member.
5869 [long_options]: Use HUMAN_SI_OPTION, not 'H'.
5870 (main): Warn that the meaning of -H will soon change to be
5873 2003-10-03 Jim Meyering <jim@meyering.net>
5875 * src/du.c: Accept --no-dereference (-P).
5877 2003-10-02 Jim Meyering <jim@meyering.net>
5879 * tests/du/trailing-slash: Adjust for slightly different output.
5881 Rewrite du.c to use fts.
5882 * src/du.c: Include "fts_.h", not ftw.h.
5883 (opt_dereference_arguments, arg_length, suffix_length): Remove globals.
5884 (IS_FTW_DIR_TYPE): Remove definition.
5885 (IS_DIR_TYPE): Define.
5886 (is_symlink_to_dir): Remove now-unnecessary function.
5887 (process_file, du_files): Rewrite to use fts.
5889 * tests/du/inaccessible-cwd: Ensure that even when run from an
5890 inaccessible directory, du can still operate on accessible
5891 directories elsewhere.
5892 * tests/du/Makefile.am (TESTS): Add inaccessible-cwd.
5894 * tests/rm/deep-1: Ensure that du can process a hierarchy
5895 of depth 400 while using no more than 50KB of stack space.
5897 2003-10-01 Akim Demaille <akim@epita.fr>
5899 * announce-gen (print_news_deltas): New function, extracted from main.
5900 (main): Make `news_file' an array.
5901 Use '...=s' => \@var for --news and --url-directory specs.
5902 Before there were a couple of portability problems.
5904 2003-09-28 Jim Meyering <jim@meyering.net>
5906 * Makefile.maint (sc_cast_of_alloca_return_value): New rule.
5907 (syntax-check-rules): Add it.
5909 * src/copy.c: Remove unnecessary cast of alloca, since now it's
5910 guaranteed to be (void *).
5911 * src/cp.c: Likewise.
5912 * src/join.c: Likewise.
5913 * src/ln.c: Likewise.
5914 * src/ls.c: Likewise.
5915 * src/od.c: Likewise.
5916 * src/sys2.h (ASSIGN_STRDUPA): Likewise.
5918 2003-09-27 Jim Meyering <jim@meyering.net>
5920 Don't exhaust virtual memory when processing large inputs.
5921 Fix this by removing csplit's internal free-list management;
5922 instead rely on malloc for that.
5924 * src/csplit.c (free_list): Remove global.
5925 (clear_all_line_control): Remove function.
5926 (get_new_buffer): Always use create_new_buffer to obtain a
5927 new buffer, rather than searching free_list.
5928 (free_buffer): Just call free.
5929 Reported by Nikola Milutinovic.
5931 2003-09-26 Jim Meyering <jim@meyering.net>
5933 * man/rm.x: Also list `chattr' in SEE ALSO section.
5934 Suggestion from Mark Hubbart.
5936 2003-09-25 Jim Meyering <jim@meyering.net>
5938 * configure.ac: Don't invoke AC_AIX or AC_MINIX explicitly, now
5939 that we use gl_USE_SYSTEM_EXTENSIONS, since it AC_REQUIREs them.
5941 * Use autoconf-2.57d. Regenerate dependent files.
5943 2003-09-24 Jim Meyering <jim@meyering.net>
5945 Minor efficiency tweak.
5946 * src/ln.c (PATH_BASENAME_CONCAT): Use memcpy rather than strcpy.
5947 (do_link): Likewise.
5949 2003-09-23 Jim Meyering <jim@meyering.net>
5951 * src/paste.c (paste_serial): Save errno after input error,
5952 to report proper errno value.
5953 Based on a patch from Paul Eggert.
5955 * src/tee.c (tee): Adjust fwrite arguments so that the return
5956 value is the number of bytes written.
5958 2003-09-16 Paul Eggert <eggert@twinsun.com>
5960 Don't assume ferror sets errno. Bug reported by Bruno Haible.
5962 * src/comm.c (compare_files): Save errno after input error,
5963 to report proper errno value.
5964 * src/fold.c (fold_file): Likewise.
5965 * src/od.c (check_and_close, skip, read_char, read_block): Likewise.
5966 * src/unexpand.c (unexpand): Likewise.
5968 * src/csplit.c (close_output_file): Don't report bogus errno value
5969 after ferror discovers an output error. We don't know the proper
5970 errno value, since it might have been caused by any of a whole
5971 bunch of calls, and it might have been trashed in the meantime.
5972 Fixing this problem will require much more extensive changes;
5973 in the meantime just say "write error".
5974 * src/od.c (check_and_close, dump, dump_strings): Likewise.
5975 * src/uniq.c (check_file): Likewise.
5977 * src/join.c (get_line): Report error right away if I/O fails,
5978 so that the proper errno value is used.
5979 * src/tac.c (tac_seekable, tac_file, save_stdin): Likewise.
5980 * src/tee.c (tee): Likewise.
5981 * src/uniq.c (check_file): Likewise.
5983 * src/od.c (skip): If a read fails, don't retry it later, so
5984 that we report the proper errno.
5986 * src/tac.c (tac_mem): Don't return a value; nobody uses it.
5988 * src/tee.c (tee): Once a write failure has occurred, don't bother
5989 writing anything more to that stream.
5991 * src/uniq.c (check_file): Check for ferror (stdout) even if
5994 * src/yes.c (UNROLL): Remove.
5995 (main): Exit immediately when write failure is detected.
5996 Simplify code by assigning to argv when argc == 1.
5998 2003-09-21 Paul Eggert <eggert@twinsun.com>
6000 * src/ptx.c: Switch encoding from Latin-1 to UTF-8.
6001 (WRITTEN_BY): Change "Franc,ois" (actually using
6002 c-with-cedilla in Latin-1) to "F.", so that it's ASCII, as
6005 2003-09-19 Jim Meyering <jim@meyering.net>
6007 `du -D symlink-to-dir' would mistakenly omit the slash in
6008 lines like this: 24 symlink-to-dir/subdir
6009 * src/du.c (process_file): Fix offset calculation.
6010 Reported by Jeff Sheinberg as Debian bug #211591;
6011 http://bugs.debian.org/205251
6013 * tests/du/deref-args: New file/test for the above.
6014 * tests/du/Makefile.am (TESTS): Add deref-args.
6016 * src/du.c (process_file): Remove useless disjunct.
6018 * src/sys2.h (case_GETOPT_VERSION_CHAR): Rename parameter, Authors,
6020 * nearly all src/*.c files (WRITTEN_BY): Rename from AUTHORS.
6021 Begin each WRITTEN_BY string with `Written by ' and end it with `.'.
6022 Mark each WRITTEN_BY string as translatable.
6024 * basename.c, cat.c, chroot.c, cksum.c, comm.c, cp.c, csplit.c, cut.c:
6025 * dd.c, df.c, dirname.c, du.c, echo.c, env.c, expr.c, factor.c, head.c:
6026 * hostid.c, hostname.c, id.c, link.c, ln.c, logname.c, ls.c, md5sum.c:
6027 * mv.c, nice.c, nl.c, nohup.c, paste.c, pathchk.c, pinky.c, pr.c:
6028 * printenv.c, printf.c, pwd.c, rm.c, setuidgid.c, sleep.c, sort.c:
6029 * split.c, stty.c, sum.c, sync.c, tac.c, tail.c, tee.c, test.c:
6030 * touch.c, tsort.c, uniq.c, unlink.c, uptime.c, users.c, wc.c:
6031 * who.c, whoami.c, yes.c: Revert yesterday's changes.
6032 Instead, a subsequent change will embed `Written by ' in
6033 each string along with the author names.
6035 * src/true.c: Revert yesterday's changes.
6036 * src/sys2.h: Likewise.
6038 2003-09-18 Jim Meyering <jim@meyering.net>
6040 * basename.c, cat.c, chroot.c, cksum.c, comm.c, cp.c, csplit.c, cut.c:
6041 * dd.c, df.c, dirname.c, du.c, echo.c, env.c, expr.c, factor.c, head.c:
6042 * hostid.c, hostname.c, id.c, link.c, ln.c, logname.c, ls.c, md5sum.c:
6043 * mv.c, nice.c, nl.c, nohup.c, paste.c, pathchk.c, pinky.c, pr.c:
6044 * printenv.c, printf.c, pwd.c, rm.c, setuidgid.c, sleep.c, sort.c:
6045 * split.c, stty.c, sum.c, sync.c, tac.c, tail.c, tee.c, test.c:
6046 * touch.c, tsort.c, uniq.c, unlink.c, uptime.c, users.c, wc.c:
6047 * who.c, whoami.c, yes.c: Update AUTHORS definition to be a
6048 comma-separated list of strings and/or update the call to
6049 parse_long_options so that `AUTHORS, NULL' are the last parameters.
6050 * src/true.c (main): Append NULL to version_etc argument list.
6051 * src/sys2.h (case_GETOPT_VERSION_CHAR): Likewise.
6053 * src/sort.c (numcompare): Rename local, logb, to log_b to avoid
6054 shadowing the math function name. Also rename loga to log_a.
6056 2003-09-14 Jim Meyering <jim@meyering.net>
6058 * src/factor.c (print_factors): Give a separate diagnostic
6059 for numbers that are too large, but otherwise valid.
6060 Reported by Dániel Varga.
6062 2003-09-10 Jim Meyering <jim@meyering.net>
6064 * Use automake-1.7.7. Regenerate dependent files.
6066 * tests/Makefile.am (all_programs): Use ../src/tr -s ' ' '\n' in place
6067 of `fmt -1'. Using the just-built tr is a little cleaner.
6068 Christian Krackowizer reported that HPUX 10.20 doesn't have fmt.
6069 * man/Makefile.am (programs, check-x-vs-1): Likewise.
6071 2003-09-09 Jim Meyering <jim@meyering.net>
6073 * src/copy.c: Alphabetize includes.
6074 Remove duplicate inclusion of "same.h".
6076 2003-09-08 Jim Meyering <jim@meyering.net>
6078 * Makefile.maint (GZIP_ENV): Remove --rsyncable.
6079 Didn't give enough of a benefit, mainly because it's not yet
6084 * man/Makefile.am (programs): Use ../src, not $(srcdir)/../src.
6085 (check-programs-vs-x): Fail if $(programs) is empty.
6087 * src/remove.c: Add a comment.
6089 2003-09-07 Jim Meyering <jim@meyering.net>
6091 * src/remove.c (D_INO, ENABLE_CYCLE_CHECK) [D_INO_IN_DIRENT]:
6092 Don't define. These symbols are no longer used.
6094 * tests/misc/tty-eof: Write ^D as \cD.
6095 Complete the change of 2003-08-02.
6097 * Makefile.maint (po-check): Use cvsu, so that a temporary source
6098 file in lib/ or src/ doesn't induce an unwarranted failure.
6099 Add a kludge to filter out the sole generated source file that
6100 also has translatable messages: src/false.c.
6102 2003-09-06 Jim Meyering <jim@meyering.net>
6104 * src/tail.c (enum): Add ALLOW_MISSING_OPTION.
6105 (parse_options): Give a diagnostic for (but still accept) the
6106 deprecated --allow-missing option.
6108 2003-09-04 Paul Eggert <eggert@twinsun.com>
6110 Don't ignore -S if input is a pipe. Bug report by Michael McFarland in
6111 <http://mail.gnu.org/archive/html/bug-coreutils/2003-09/msg00008.html>.
6113 * src/sort.c (sort_buffer_size): Omit SIZE_BOUND arg. Compute the
6114 size_bound ourselves. if an input file is a pipe and the user
6115 specified a size, use that size instead of trying to guess the
6116 pipe size. This has the beneficial side effect of avoiding the
6117 overhead of default_sort_size in that case. All callers changed.
6118 (sort): Remove static var size; now done by sort_buffer_size.
6120 2003-09-05 Jim Meyering <jim@meyering.net>
6122 * Use automake-1.7.6b and autoconf-2.57b. Regenerate dependent files.
6124 * tests/tail-2/tail-n0f: Wait .5 seconds for backgrounded process
6125 to start, rather than just .1. Upon failure, print unexpected state.
6127 2003-09-04 Paul Eggert <eggert@twinsun.com>
6129 * src/head.c (elide_tail_lines_pipe): Don't assign 0 or
6130 SAFE_READ_ERROR to tmp->nbytes.
6131 * src/tail.c (pipe_lines, pipe_bytes): Likewise.
6133 * src/head.c (struct linebuffer): Change nbytes and nlines
6134 from unsigned int to size_t. unsigned int is safe (after the
6135 2003-09-03 patch) but size_t is cleaner.
6136 * src/tail.c (struct linebuffer, struct charbuffer): Likewise.
6137 (pipe_bytes): Likewise for local variable 'i', which was 'int'.
6139 Standardize on BUFSIZ as opposed to other macro names and values.
6140 * src/head.c (BUFSIZE): Remove. All uses changed to BUFSIZ.
6141 * src/tail.c (BUFSIZ) [!defined BUFSIZ]: Remove.
6142 stdio.h has always defined it,
6143 and other code already assumes it's defined.
6144 * src/tr.c (BUFSIZ) [!defined BUFSIZ]: Likewise.
6145 (IO_BUF_SIZE): Remove; replace all uses with sizeof io_buf.
6146 (io_buf): IO_BUF_SIZE -> BUFSIZ.
6148 2003-09-04 Paul Eggert <eggert@twinsun.com>
6150 * src/seq.c (step): Default to 1.
6151 (print_numbers): Allow the output to be empty.
6152 (main): The default step is 1, even if LAST < FIRST;
6153 as per documentation.
6154 * tests/seq/basic (onearg-2): Output should be empty.
6156 2003-09-05 Jim Meyering <jim@meyering.net>
6158 * Makefile.cfg (wget_files): Temporarily disable, until master
6159 versions are restored to ftp.gnu.org.
6161 * configure.ac (AM_INIT_AUTOMAKE): Specify automake-1.7.6.
6163 Make seq's --width (-w) option work properly even when the
6164 endpoint requiring the larger width is negative and smaller than
6166 * src/seq.c (get_width_format): Include `-' in the set of bytes
6167 allowed in a `simple' number (no decimal point, no exponent).
6168 Reported by Patrick Mauritz.
6170 2003-09-02 Paul Eggert <eggert@twinsun.com>
6172 * NEWS: sort -t '\0' now uses a NUL tab.
6173 sort option order no longer matters, unless POSIX requires it.
6174 * src/sort.c (usage): Say "blanks" instead of "whitespace",
6175 Similar fixes for many comments.
6176 (TAB_DEFAULT): New constant, so that we can support NUL as
6177 the field separator.
6178 (tab): Now int, not char. Initialize to TAB_DEFAULT.
6179 (specify_sort_size): If multiple sizes are specified, use the largest.
6180 (begfield, limfield): Support NUL tab char.
6181 (set_ordering): Do not let -i override -d.
6182 (main): Report an error if incompatible -o or -t options are given.
6183 Report an error for "-t ''". Allow "-t '\0'" to specify a NUL tab.
6185 2003-09-05 Jim Meyering <jim@meyering.net>
6187 * tests/sort/Test.pm [o2, nul-tab]: New tests for the above.
6189 2003-09-03 Andreas Schwab <schwab@suse.de>
6191 Bug report and patch here:
6192 <http://mail.gnu.org/archive/html/bug-coreutils/2003-09/msg00009.html>
6193 * src/tail.c (pipe_lines): Don't truncate return value from safe_read.
6194 * src/head.c (elide_tail_lines_pipe): Likewise.
6196 2003-09-03 Jim Meyering <jim@meyering.net>
6198 * src/du.c (AUTHORS): Remove Larry McVoy's name, since the relatively
6199 small amount of code from him was first moved to lib/human.c, and was
6200 subsequently rewritten entirely.
6201 * src/df.c (AUTHORS): Likewise.
6203 2003-08-22 Lawrence Teo <lcteo@uncc.edu>
6205 * src/md5sum.c (split_3): Accept the BSD format for generic
6206 message digest modes. Currently works with BSD's MD5 and SHA1
6207 formats since these are the two algorithms presently used in
6208 coreutils. Updated comments to reflect this change.
6209 (bsd_split_3): Updated comments.
6211 * tests/md5sum/basic-1: New test to make sure that
6212 `md5sum --check' doesn't accept the BSD SHA1 format (adapted
6213 from `check-bsd' test in tests/sha1sum/basic-1).
6215 * tests/sha1sum/basic-1 (check-bsd2, check-bsd3): New tests for
6216 --check exit status and BSD SHA1 format (adapted from tests
6217 in tests/md5sum/basic-1).
6219 2003-08-30 Jim Meyering <jim@meyering.net>
6221 * src/ln.c (do_link): Use SAME_INODE rather than open-coding it.
6223 When source and destination arguments refer to the same file, reside
6224 on a partition (e.g. VFAT) on which distinct names may refer to the
6225 same directory entry (often due to variations in case), and when the
6226 link count for the file is 1, mv no longer unlinks the file. Instead,
6227 it gives the expected diagnostic that the source and destination are
6228 the same. WARNING: this is an incomplete fix. If the file happens
6229 to have a link count of 2 or greater, such an erroneous mv command
6230 will still unlink it.
6231 Although that is not possible on vfat or umsdos, it is possible on
6232 other file system types, e.g., ntfs, and hpfs.
6233 * src/copy.c (same_file_ok): Invoke same_name (which might still
6234 return false for names that refer to the same directory entry)
6235 only if the link count is 2 or more.
6236 * tests/mv/vfat: Show how to demonstrate the above problem.
6237 This test is not run.
6238 * tests/mv/Makefile.am (EXTRA_DIST): Add vfat.
6240 2003-08-27 Jim Meyering <jim@meyering.net>
6242 * src/who.c: Change meaning of -l from --lookup to --login, per POSIX.
6243 who's -l option has been eliciting an unconditional warning about
6244 this impending change since sh-utils-2.0.12 (April 2002).
6246 * src/paste.c (paste_parallel): Don't output `EOF' (aka -1) as a `char'.
6247 This would happen for nonempty files not ending with a newline.
6248 Reported by Dan Jacobson.
6249 * tests/misc/paste-no-nl: New file. Test for above-fixed bug.
6250 * tests/misc/Makefile.am (TESTS): Add paste-no-nl.
6252 * src/stat.c (print_it): Avoid buffer overrun that would
6253 occur when the user-specified format string ends with `%'.
6254 Patch by Tommi Kyntola.
6255 * tests/misc/stat-fmt: New file. Test for above-fixed bug.
6256 * tests/misc/Makefile.am (TESTS): Add stat-fmt.
6258 2003-08-26 Jim Meyering <jim@meyering.net>
6260 Apply changes from bison.
6261 * GNUmakefile (SHELL): Define to `sh', if necessary.
6263 * Makefile.maint (WGETFLAGS): Define to `-C off'.
6264 Update all uses of $(WGET).
6266 2003-08-22 Akim Demaille <akim@epita.fr>
6268 * Makefile.cfg (local-checks-to-skip): New.
6269 * Makefile.maint (local-check): Rename as...
6270 (local-checks-available): this.
6273 2003-08-26 Akim Demaille <akim@epita.fr>
6275 * announce-gen (print_changelog_deltas): Neutralize "<#" as
6276 "<\#" to avoid magic from Gnus when posting parts of this script.
6278 2003-08-25 Jim Meyering <jim@meyering.net>
6280 * src/stat.c (main): Warn about use of deprecated `-l' option.
6282 2003-08-22 Jim Meyering <jim@meyering.net>
6284 * src/stat.c (do_stat): For link count at end of line, use %h format,
6285 instead of %-5h. The latter would make stat emit trailing spaces.
6286 Reported by Dan Jacobson.
6288 2003-08-20 Jim Meyering <jim@meyering.net>
6290 * Makefile.am (EXTRA_DIST): Add .x-sc_space_tab .x-sc_sun_os_names
6292 2003-08-19 Jim Meyering <jim@meyering.net>
6294 * src/system.h: Include stdlib.h unconditionally,
6295 as we're now assuming that part of hosted C89.
6297 2003-08-18 Jim Meyering <jim@meyering.net>
6299 * src/sys2.h (textdomain, bindtextdomain) [! ENABLE_NLS]: Define away,
6300 to avoid warnings from gcc.
6302 2003-08-17 Jim Meyering <jim@meyering.net>
6304 Avoid unnecessary and sometimes time-consuming hostname lookups.
6305 * src/who.c (print_user): Use strchr, not strrchr.
6306 * src/pinky.c (print_entry): Likewise.
6307 Patch by Michael Stone.
6308 This fixes a typo I introduced in who-users.c on 1996-02-23.
6310 * Makefile.maint (makefile-check): Add 0-9 to the range of characters
6311 disallowed between `@...@'.
6313 2003-08-16 Paul Eggert <eggert@twinsun.com>
6315 * configure.ac (fu_cv_sys_truncating_statfs): Remove; now
6316 done by gnulib .m4 files.
6317 (jm_DUMMY_1): Require gl_READUTMP, not jm_PREREQ_READUTMP.
6318 * src/sys2.h (strtoull): Remove unused declaration.
6320 2003-08-16 Jim Meyering <jim@meyering.net>
6322 * man/Makefile.am (.x.1): Ensure that generated PROGRAM.1 files
6325 * src/tail.c (tail_lines): Fix a potential (but very hard to exercise)
6326 race condition bug. The bug would be triggered when tailing a file
6327 with file pointer not at beginning of file, and where the file was
6328 truncated to have a length of less than the initial offset at just
6329 the right moment (between the two lseek calls in this function).
6331 An invalid initial value for *read_pos would result in
6332 `tail -n0 -f FILE' and `tail -c0 -f FILE' doing what amounted to a
6333 busy-wait rather than sleeping between iterations. The bug manifests
6334 itself only when tailing regular files that are initially nonempty.
6335 * src/tail.c (tail_bytes): Set *read_pos to new file offset after
6337 (tail_lines): Likewise, after lseek calls.
6338 Reported by Nick Estes. See http://bugs.debian.org/205251 for details.
6339 * tests/tail-2/tail-n0f: New file. Test for above fix.
6340 * tests/tail-2/Makefile.am (TESTS): Add tail-n0f.
6342 2003-08-15 Jim Meyering <jim@meyering.net>
6344 * Makefile.maint (sc_space_tab): Use exclusion list in separate file.
6345 (sc_sun_os_names): Likewise.
6346 * .x-sc_space_tab, .x-sc_sun_os_names: New files.
6348 * man/help2man: Remove some SPACEs before TAB.
6350 2003-08-14 Paul Eggert <eggert@twinsun.com>
6352 * Makefile.maint (LC_ALL): Set to C.
6353 * man/Makefile.am (ASSORT): New var.
6354 (check-x-vs-1, programs): Use it.
6355 * src/Makefile.am (ASSORT, check-README, ../AUTHORS): Likewise.
6356 * tests/Makefile.am (ASSORT, all_programs): Likewise.
6358 2003-08-11 Jim Meyering <jim@meyering.net>
6360 fold -s -wN would infloop for N < 8 with TABs in the input.
6361 E.g., this would not terminate: printf 'a\tb' | fold -w2 -s
6362 * src/fold.c (fold_file): Move contents of `else'-block
6363 out of conditional so it's used also for --spaces (-s).
6364 * tests/misc/fold: Test for the above fix.
6365 * tests/misc/Makefile.am (TESTS): Add fold.
6367 2003-08-10 Jim Meyering <jim@meyering.net>
6369 * src/nice.c [!NICE_PRIORITY]: Include <sys/resource.h> after
6370 system.h so the types from time.h and sys/time.h are available.
6371 It appears that this is necessary for OpenBSD, NetBSD, and
6372 Darwin 6.5 (MacOS 10.2.5). Reported by Nelson Beebe.
6374 2003-08-06 Paul Eggert <eggert@twinsun.com>
6376 * NEWS: Add support for setting file timestamps to microsecond
6377 resolution, on hosts that support this.
6378 * src/copy.c, src/cp.c, src/install.c, src/touch.c: Include utimens.h.
6379 * src/copy.c (copy_internal):
6380 Set file timestamps with utimens, not utime.
6381 * src/cp.c (re_protect): Likewise.
6382 * src/install.c (change_timestamps): Likewise.
6383 * src/touch.c (newtime, touch, main): Likewise.
6385 2003-08-09 Jim Meyering <jim@meyering.net>
6387 * Makefile.maint (sc_sun_os_names): New rule based on a regexp
6389 (syntax-check-rules): Add it.
6391 * src/tail.c (main): Tweak Solaris OS version number in comment.
6392 * src/wc.c (wc): Likewise
6393 * tests/tail-2/fflush: Likewise.
6395 * src/tail.c: Add new undocumented option, --presume-input-pipe.
6396 (pipe_lines): Use memchr to skip lines, rather than an explicit loop.
6398 2003-08-08 Paul Eggert <eggert@twinsun.com>
6400 Use new gnulib 'extensions' module.
6401 * configure.ac: Invoke gl_USE_SYSTEM_EXTENSIONS instead of
6404 2003-08-08 Paul Eggert <eggert@twinsun.com>
6406 * tests/du/basic: Ensure that a/b/F has at least 65 bytes too.
6408 2003-08-09 Jim Meyering <jim@meyering.net>
6410 * tests/misc/split-fail: Reflect that `split -a 0' is now accepted.
6411 For tests of obsolete behavior, don't presume that unsetting
6412 _POSIX2_VERSION is equivalent to _POSIX2_VERSION=199209.
6414 2003-08-07 Paul Eggert <eggert@twinsun.com>
6416 * doc/coreutils.texi (split invocation):
6417 Add -d or --numeric-suffixes option to 'split'.
6418 From a suggestion by Jesse Kornblum.
6419 * src/split.c (suffix_alphabet): New var.
6420 (longopts, usage, next_file_name, main): Support -d.
6421 (next_file_name, main): Allow -a0, as POSIX requires.
6422 (next_file_name): Don't assume ASCII-like encoding;
6423 'a' through 'z' are not contiguous in EBCDIC.
6425 2003-08-05 Paul Eggert <eggert@twinsun.com>
6427 Merge getline from gnulib.
6428 * lib/getline.h, lib/getline.c, m4/getline.m4: Merge from gnulib.
6429 * lib/getndelim2.h, lib/getndelim2.c, m4/getndelim2.m4, m4/ssize_t.m4:
6430 New files, from gnulib.
6431 * lib/getdelim2.c, lib/getdelim2.h: Remove.
6432 * lib/Makefile.am (libfetish_a_SOURCES): Change getdelim2.c and
6433 getdelim2.h to getndelim2.c and getndelim2.h.
6434 * m4/jm-macros.m4 (jm_MACROS): Use gl_GETNDELIM2 rather than
6435 checking for getdelim.
6436 (jm_CHECK_ALL_TYPES): Use gt_TYPE_SSIZE_T for ssize_t rather
6437 than rolling our own.
6438 * src/cut.c: Include getndelim2.h rather than getdelim2.h.
6439 (cut_fields): Invoke getndelim2 rather than getdelim2.
6441 2003-08-04 Jim Meyering <jim@meyering.net>
6443 * src/sort.c (main): Use unsigned int instead of int for `nsigs'
6444 and for the indices to iterate through nsigs.
6446 2003-08-02 Paul Eggert <eggert@twinsun.com>
6448 * src/sort.c: Minor code cleanups, mostly to use more accurate
6449 types and to remove unnecessary casts.
6450 (min, max): Remove. All uses changed to MIN and MAX.
6451 (hard_lc_collate, hard_LC_TIME, struct buffer.eof, struct
6452 keyfield.skipsblanks, struct keyfield.skipeblanks, struct
6453 keyfield.numeric, struct keyfield.general_numeric, struct
6454 keyfield.month, struct keyfield.reverse, reverse, unique,
6455 have_read_stdin): Now bool, not int. All uses changed.
6456 (eolchar): Now char, not int.
6457 (struct keyfield.ignore): Now bool const *, not int *.
6458 (struct keyfield.translate): Now char const *, not char *.
6459 (struct month.name): Likewise.
6460 (blanks, nonprinting, nondictionary): Now bool[], not int[].
6461 (cleanup, inittables, keycompare, check, mergefps, first_same_file,
6462 check, sort, main): Use const * pointers when possible.
6463 (month_cmp): Rewrite to avoid casts.
6464 (inittables): Initialize tables unconditionally, to avoid branches.
6465 (fillbuf): Return bool, not int. All uses changed.
6466 (fillbuf, keycompare, new_key, main):
6467 Use SIZE_MAX rather than (size_t) -1.
6468 (trailing_blanks): Renamed from trim_trailing_blanks.
6469 Return the number of blanks to trim. All uses changed.
6470 (getmonth): Use trailing_blanks rather than open code.
6471 (keycompare): Do not cast char * to unsigned char *; not needed.
6472 CMP_WITH_IGNORE converts args to UCHAR, so no need to convert it
6474 (compare, main): Use | rather than || to avoid jumps.
6475 Replace "diff = NONZERO (alen)" with "diff = 1", since alen must
6477 (check, first_same_file, sort, main):
6478 Use bool instead of int local vars when possible.
6479 (check): Merge the old 'checkfp' and 'check' into a single function,
6480 that returns a boolean (true if the file was ordered).
6482 (main): Use int instead of unsigned for iterating through nsigs.
6483 Rename local var "posix_pedantic" to "posixly_correct".
6485 2003-08-02 Jim Meyering <jim@meyering.net>
6487 * src/nice.c [!NICE_PRIORITY]: Include <time.h> before <sys/resource.h>
6488 to avoid compilation error on Ultrix. Reported by Christian Krackowizer.
6490 * src/cut.c (cut_fields): Don't read again after encountering an
6491 initial EOF. E.g., `cut -f2' would do so.
6492 * tests/misc/tty-eof: Add a test for the above fix.
6494 * src/sort.c (sortlines): Add description and references.
6497 * tests/Makefile.am (TESTS_ENVIRONMENT): Set PATH so that
6498 the tests in help-version will use the just-built binaries.
6499 Reported by Christian Krackowizer.
6501 2003-07-31 Paul Eggert <eggert@twinsun.com>
6503 * NEWS: Add --rfc-2822 option to GNU date.
6504 * doc/coreutils.texi (Time directives, Options for date, Examples
6506 * src/date.c (long_options, usage, main): Likewise.
6507 * doc/getdate.texi (General date syntax): Likewise.
6508 * doc/coreutils.texi (Options for date): Fix a typo in format:
6509 it's now %d not %_d. Add URLs.
6511 2003-08-01 Jim Meyering <jim@meyering.net>
6513 * tests/shred/remove: Ensure that $? is 0 for the final `exit 0'.
6514 Otherwise, with at least the /bin/sh from HPUX 10.20,
6515 the trap code would end up converting that to exit 1 and thus an
6516 unexpected test failure. Reported by Christian Krackowizer.
6518 2003-07-31 Paul Eggert <eggert@twinsun.com>
6520 * src/ptx.c: Do not include bumpalloc.h.
6521 (WORD_TABLE): New member alloc.
6522 (ALLOC_NEW_WORD): Remove.
6523 (occurs_alloc): New var.
6524 (digest_word_file, find_occurs_in_text): Check for arithmetic
6525 overflow when computing table size. Use xrealloc rather than
6526 bumpalloc primitives.
6528 2003-07-29 Jim Meyering <jim@meyering.net>
6532 * README: When running tests as root, suggest using
6533 sudo with NON_ROOT_USERNAME=$USER.
6535 * tests/Makefile.am (all_programs): Makefile is in ../src, not
6538 2003-07-28 Jim Meyering <jim@meyering.net>
6540 * Makefile.maint (GZIP_ENV): Try Debian/gzip's new --rsyncable option.
6542 2003-07-28 Paul Eggert <eggert@twinsun.com>
6544 * lib/stdbool.hin (_Bool): Make it signed char, instead of
6545 an enum type, so that it's guaranteed to promote to int.
6546 * src/sort.c (sortlines_temp): Undo previous change.
6548 2003-07-28 Jim Meyering <jim@meyering.net>
6550 * src/sort.c (sortlines_temp): Declare local `swap' to be `int', not
6551 `bool'. Otherwise, at least one buggy compiler (alpha gcc-2.95.4)
6552 would cause lines[-1 - swap] (with swap = false) to evaluate to
6555 2003-07-27 Jim Meyering <jim@meyering.net>
6557 * tests/priv-check (my_uid): Use `!', not `^' in case pattern `[!0-9]',
6558 since /bin/sh of at least NetBSD 1.6 and OpenBSD 3.2 don't accept `^'.
6560 * src/remove.c (prompt) [! recursive]: Don't prompt about unwritable
6561 directories, as required by POSIX. Reported by Karl Berry.
6562 * tests/rm/dir-no-w: New file. Test for the above fix.
6563 * tests/rm/Makefile.am (TESTS): Add dir-no-w.
6565 * tests/mk-script: Emit `$xx', not its expansion.
6567 2003-07-27 Paul Eggert <eggert@twinsun.com>
6569 This change was inspired by a similar proposal by Stepan Kasal.
6570 * src/sort.c (mergelines, sortlines_temp): New functions.
6571 (sortlines): Use them, to reduce the number of times that
6572 we need to copy 'struct line' values. This improved CPU
6573 performance by about 30% on one 18 MB test.
6574 (sort): Don't invoke sortlines unless we have 2 or more lines.
6576 2003-07-26 Stepan Kasal <kasal@ucw.cz>
6578 * src/sort.c (sort): Don't require two `struct line's per text line,
6579 the new sort algorithm requires just 1.5.
6581 2003-07-27 Jim Meyering <jim@meyering.net>
6583 * src/pathchk.c (validate_path): Use %lu, not %ld.
6585 * src/cut.c (is_printable_field): Simplify bit arithmetic.
6587 * src/ls.c (sort_files): Put `volatile' in the right place.
6590 2003-07-26 Jim Meyering <jim@meyering.net>
6592 Use only one bit per field/offset in array, not one `int'.
6593 * src/cut.c (printable_field): Change type to `unsigned char'.
6594 (mark_printable_field, is_printable_field): New functions.
6595 Use them in place of all direct accesses of `printable_field'.
6597 * src/expand.c (parse_tabstops): Detect overflow properly.
6598 * src/cut.c (set_fields): Likewise.
6600 * src/rm.c: Include "dirname.h".
6601 (usage): Use base_name (program_name) in body of --help output.
6603 * man/Makefile.am (.x.1): ...back out the kludge of 2003-07-22.
6604 Idea from Brendan O'Dea, who suggested using
6605 `program_name = basename (argv[0]);' everywhere --
6606 can't do that, but using base_name works just fine here.
6608 * src/Makefile.am (AM_INSTALLCHECK_STD_OPTIONS_EXEMPT): Exempt test.
6610 2003-07-24 Paul Eggert <eggert@twinsun.com>
6612 Fix some POSIX-compliance problems with 'test'. This makes
6613 'test' more compatible with Bash.
6615 * NEWS, doc/coreutils.texi: Document the following.
6616 * src/test.c: Include exitfail.h.
6617 (TEST_FAILURE): New constant, used for exit status if 'test' fails.
6618 (test-syntax_error): Use it.
6619 (binary_operator): Now takes bool arg specifying whether left operand
6620 is -l ARG, so that caller determines this rather than us.
6622 (term): Use posixtest to evaluate parenthesized subexpressions.
6623 (unary_operator, one_argument): Remove support for -t without operand.
6624 (one_argument): Take argument from argv[pos].
6625 (one_argument, two_arguments, three_arguments): Advance pos.
6626 All callers changed.
6627 (three_arguments): Look for binary ops before "!". Then look
6628 for parenthesized one_argument expressions, instead of trusting
6629 expr () to do the right thing.
6630 (posixtest): Now takes number of args. All callers changed.
6631 Treat "( A B )" like "A B".
6632 (main): Set exit_failure to TEST_FAILURE. Don't depend on
6633 POSIXLY_CORRECT, as we now conform to POSIX by default.
6634 (main) [!LBRACKET]: Do not recognize "--help" or "--verbose" unless.
6635 * tests/test/Test.pm (test_vector): Add several tests to check
6636 the above. Syntax errors now exit with status 2, not 1.
6637 * man/Makefile.am (mapped_name): Use `../src/[' binary to create test.1.
6639 2003-07-26 Jim Meyering <jim@meyering.net>
6641 * tests/help-version: Adjust for above change in test behavior:
6642 `[' exits with 2, not 1, and test doesn't accept --help or --version.
6644 * Makefile.maint (ME): Don't use trick suggested in Make manual.
6645 It doesn't work for make-3.79.1. Reported by Christian Krackowizer.
6647 * Makefile.maint (sc_system_h_headers): Another syntax check.
6648 (syntax-check-rules): Add it to the list.
6650 * src/pathchk.c (validate_path): Cast strlen value to `unsigned long'
6651 so it matches `%ld' format even on 32-bit systems.
6653 * src/fmt.c (flush_paragraph): Cast field width to `int' to
6654 avoid warning on 64-bit systems.
6656 * src/ls.c (sort_files): Make `func' volatile, so it can't be
6657 clobbered by a `longjmp' into this function.
6659 2003-07-25 Jim Meyering <jim@meyering.net>
6661 * src/pathchk.c (validate_path): Use %ld format (not %d) for size_t
6664 * tests/misc/split-fail: Disable the --line-bytes=$_4gb test,
6665 because it'd evoke spurious failure on 64-bit systems.
6667 2003-07-24 Jim Meyering <jim@meyering.net>
6669 * src/dd.c (usage): Document the fact that SIGUSR1 makes dd
6670 output its current record counts. Reported by Jurriaan.
6672 * tests/wc/Test.pm (test_vector): Disable the `PIPE' tests when running
6673 `wc' with no options. This goes along with the change of 2003-07-20.
6675 2003-07-23 Jim Meyering <jim@meyering.net>
6677 Don't include headers already included by system.h:
6678 * src/tr.c: Don't include errno.h.
6679 * src/true.c: Don't include version-etc.h.
6680 * src/test.c: Don't include limits.h or error.h.
6681 * src/stat.c: Don't include unistd.h or time.h.
6682 * src/readlink.c: Don't include stdlib.h, unistd.h, or limits.h.
6683 * src/pr.c: Don't include time.h.
6684 * src/pathchk.c: Don't include errno.h.
6685 * src/nice.c: Don't include sys/time.h.
6686 * src/ls.c: Don't include stdlib.h.
6688 * basename.c, cat.c, chroot.c, cksum.c, comm.c, csplit.c, cut.c, date.c:
6689 * dd.c, dirname.c, echo.c, env.c, expand.c, expr.c, factor.c, fmt.c:
6690 * fold.c, head.c, hostid.c, hostname.c, id.c, join.c, kill.c, logname.c:
6691 * md5sum.c, nice.c, nl.c, nohup.c, od.c, paste.c, pathchk.c, pinky.c:
6692 * pr.c, printenv.c, printf.c, ptx.c, pwd.c, seq.c, setuidgid.c, shred.c:
6693 * sleep.c, sort.c, split.c, stat.c, stty.c, su.c, sum.c, tac.c, tail.c:
6694 * tee.c, test.c, tr.c, true.c, tsort.c, tty.c, uname.c, unexpand.c:
6695 * uniq.c, uptime.c, users.c, wc.c, who.c, whoami.c, yes.c:
6696 Don't include closeout.h.
6698 * tests/rm/fail-2eperm: Add a check for whether $NON_ROOT_USERNAME
6699 can access the required version of rm.
6700 * tests/rm/Makefile.am (TESTS_ENVIRONMENT): Define PACKAGE_VERSION.
6702 * tests/cut/Test.pm (out-delim3a): New test.
6704 * man/help2man: Update to version 1.33.
6706 * src/expand.c (parse_tabstops): Detect overflow in tabstop sizes.
6708 * src/dircolors.c: Include xstrndup.h.
6709 (xstrndup): Remove function, now that it's been factored out into
6712 2003-07-22 Paul Eggert <eggert@twinsun.com>
6714 * src/wc.c (wc): Fix typo in computation of file from file_x,
6715 which caused the former to be used uninitialized if file_x was
6718 2003-07-22 Jim Meyering <jim@meyering.net>
6720 * src/cut.c (set_fields): Use xcalloc in place of xmalloc+memset.
6722 * man/Makefile.am (.x.1): Substitute 's,$t/$*,$*,' on output of
6723 help2man, to avoid having `rm.td/rm' appear in rm.1. Reported by
6724 Thomas Luzat. See http://bugs.debian.org/202413 for details.
6726 * src/cut.c (main) [lint]: Initialize spec_list_string to avoid warning.
6728 * src/hostid.c: Don't include <unistd.h>. system.h already does that.
6730 * src/cut.c (set_fields): Mark all selected indices before trying to
6731 determine range endpoints.
6732 * tests/cut/Test.pm: New test for the above fix.
6734 Begin to address this comment: What if someone wants to
6735 extract the 1,000,000-th field of some huge input file?
6736 The first step is to rearrange things so that the values
6737 in the printable_field array are all 0/1 rather than 0/1/2.
6738 * src/cut.c (RANGE_START_SENTINEL): Remove.
6739 Store range-start indices in a hash table, rather than
6740 overloading the `printable_field' array.
6741 (range_start_ht): New global.
6742 (hash_int, hash_compare_ints, is_range_start_index): New functions.
6743 (print_kth): Use is_range_start_index; don't test printable_field.
6744 (set_fields): Detect overflow.
6745 (set_fields): Insert each range-start index into range_start_ht.
6746 (main): Call set_fields only once, and only after
6747 output_delimiter_specified and (if required) range_start_ht have
6750 2003-07-20 Paul Eggert <eggert@twinsun.com>
6752 * src/wc.c (get_input_fstatus): Fix typo: `stat' was being
6753 invoked with a null pointer when there were no file arguments.
6755 2003-07-20 Jim Meyering <jim@meyering.net>
6757 * Makefile.maint (sc_changelog): Add another nit-picky check.
6759 * src/wc.c (write_counts): Add a comment.
6760 (wc): Rename `file' parameter.
6761 Set new local, `file', to be the file name, or (when it's NULL)
6762 _("standard output") so that all uses of `file' use the proper value.
6763 Use STREQ, not strcmp.
6765 2003-07-20 Paul Eggert <eggert@twinsun.com>
6767 wc count field widths now are heuristically adjusted depending
6768 on the input size, if known. If only one count is printed, it
6769 is guaranteed to be printed without leading spaces.
6771 Previously, wc did not align the count fields if
6772 POSIXLY_CORRECT was set, but POSIX did not actually require
6773 this undesirable behavior, so it has been removed.
6775 * NEWS: Document this.
6776 * doc/coreutils.texi (wc invocation): Likewise.
6778 * src/wc.c (number_width): New var.
6779 (posixly_correct): Remove.
6780 (struct fstatus): New struct.
6781 (write_counts): Output fields of width number_width.
6782 Do not worry about POSIXLY_CORRECT.
6783 Use null file, not empty-string file, to denote stdin,
6784 since "" is a valid file name on some hosts.
6785 (wc, wc_file): New arg fstatus. Use it to avoid invoking fstat
6787 (wc): Avoid problems if end_pos - current_pos overflows.
6788 Do not print odd message if stdin has a read error.
6789 (get_input_fstatus, compute_number_width): New functions.
6790 (main): Use them to implement the new behavior.
6791 Ignore POSIXLY_CORRECT.
6793 * tests/wc/Test.pm: Adjust to the new output widths.
6795 2003-07-19 Jim Meyering <jim@meyering.net>
6797 * tests/rm/fail-eperm: Don't create temporary directory --
6800 * tests/shred/remove: Don't open-code test for UID != 0.
6801 Use priv-check's require-non-root instead.
6802 Update to use newer framework.
6804 * tests/help-version (expected_failure_status_expr): Record that
6805 expr exits with status of 3 for e.g., a write error.
6807 * tests/priv-check: Use `id -u' to see if we're running as root,
6808 rather than trying go write to an write-protected file.
6809 When running as root, ensure $NON_ROOT_USERNAME is valid.
6810 When running as root with `require-non-root', ensure that `.'
6811 is writable by $NON_ROOT_USERNAME, then reinvoke $0 set-user-ID
6812 to $NON_ROOT_USERNAME. If `.' is not writable, then skip the test.
6814 * src/printenv.c: Include "exitfail.h".
6815 (main): Set exit_failure rather than calling close_stdout_set_status.
6816 * src/date.c: Likewise.
6817 * src/sort.c: Likewise.
6818 * src/tty.c: Likewise.
6820 2003-07-18 Jim Meyering <jim@meyering.net>
6822 * tests/touch/not-owner: Update to use newer framework.
6824 * tests/rm/fail-eperm: Use $srcdir/../priv-check, create a temporary
6825 directory, and remove Perl-coded `you may not run as root' test.
6826 * tests/cp/fail-perm: Use $srcdir/../priv-check, rather than
6827 hard-coding something not quite equivalent.
6828 Paul Jarc reported the inconsistent diagnostics.
6830 * src/sort.c (main): Use close_stdout via atexit.
6831 Now `sort --version' and `sort --help' fail, as they should
6832 when their output is redirected to /dev/full.
6834 * src/su.c (usage): Don't call close_stdout here.
6835 (main): Use close_stdout via atexit.
6836 Now `su --version > /dev/full' fails, as it should.
6837 Somehow, the change of 2000-05-07 that purports to fix this
6840 * tests/help-version (--help/--version vs. /dev/full): Special-case
6841 `[' to protect it from expected_failure_status-`eval'.
6843 * src/uniq.c (writeline): Use a SPACE, not a TAB between the
6844 count and the corresponding line, as required by POSIX.
6845 Reported by Clement Wang.
6846 * tests/uniq/Test.pm (101, 102): Update tests of -c accordingly.
6848 * tests/expr/basic: Add tests for when exit status is 2.
6850 * src/nohup.c (NOHUP_FOUND_BUT_CANNOT_INVOKE, NOHUP_FAILURE):
6851 Use an anonymous `enum', rather than #define.
6853 2003-07-17 Paul Eggert <eggert@twinsun.com>
6855 * src/expr.c: Include "exitfail.h", "quotearg.h".
6856 (EXPR_INVALID, EXPR_ERROR): New constants.
6857 (nomoreargs, null, toarith, nextarg): Return bool, not int.
6858 (syntax_error): New function, exiting with status 2. Use it
6859 insteading of printing "syntax error" ourselves.
6860 (main): Initialize exit_failure to EXPR_ERROR.
6861 Exit with EXPR_INVALID on syntax error (too few arguments).
6862 (nextarg): Use strcmp, not strcoll; strcoll might return
6863 an undesirable 0, or might fail.
6864 (docolon, eval4, eval3): Exit with status 3 on invalid argument type
6865 or other such error.
6866 (eval2): Report an error if strcoll fails in a string comparison.
6867 * src/sort.c: Include "exitfail.h".
6868 (main): Set exit_failure, not xalloc_exit_failure and
6869 xmemcoll_exit_failure.
6870 * tests/expr/basic: Invalid value exits with status 3, not 2.
6872 2003-07-16 Jim Meyering <jim@meyering.net>
6874 * configure.ac (AC_INIT): Use 5.0.90 as the version, rather than 5.0.2,
6875 per GNU maintainer guidelines. The next non-beta release will be 5.1.
6877 This script would have caught at least two recent bugs:
6878 those in [ and kill.
6879 * tests/help-version: Revive this script.
6880 It wasn't doing anything useful, since $all_programs wasn't being
6881 defined by the invoking Makefile.am.
6882 Reflect that nohup is no longer a script, so don't exclude it.
6883 Add framework to handle the programs added since it was last run:
6884 kill, stat, unlink, [, link, readlink.
6885 Fix path-related problems deriving from the move of this script
6886 from src/ to its present location.
6887 * tests/Makefile.am (all_programs): Define.
6888 (TESTS_ENVIRONMENT): Use it.
6890 * src/kill.c (main): Fix bug introduced on 2003-05-10 (for 5.0.1)
6891 whereby kill would always attempt to operate on argv[0] and fail.
6893 * src/test.c (integer_expected_error): Improve diagnostic -- now,
6894 it also matches the one from bash's builtin test.
6895 (binary_operator): Add \n at end of diagnostic.
6897 * tests/rm/fail-2eperm: Remove setuidgid-related code. Move it to ...
6898 * tests/priv-check: Move setuidgid-related and
6899 NON_ROOT_USERNAME-checking code to this file.
6901 * README: Update section on testing as `root'.
6902 Suggestion from Paul Jarc.
6904 * src/test.c (AUTHORS): Replace 3-letter usernames with the actual
6905 names of authors that I just found in bash's builtins/test.def.
6907 Running `[' with no arguments would evoke a segfault.
6908 * src/test.c (main) [LBRACKET]: Move initialization of argv to
6909 precede potential use via test_syntax_error.
6911 * src/Makefile.am (AM_CPPFLAGS): Rename from `INCLUDES', to avoid
6912 warning from automake -Wall.
6914 2003-07-15 Jim Meyering <jim@meyering.net>
6918 * Makefile.maint (%.asc): Remove target first, so gpg doesn't
6921 * announce-gen (print_changelog_deltas): Relax tests for matching
6922 version-number line in NEWS.
6923 Change the .sig suffix to .asc here, too.
6925 2003-07-14 Jim Meyering <jim@meyering.net>
6927 * Makefile.maint (%.asc): Renamed from %.sig.
6928 Generate and use ascii-armored signatures.
6929 Use gpg's -o option.
6931 2003-07-13 Jim Meyering <jim@meyering.net>
6933 * src/nohup.c (NOHUP_FAILURE, NOHUP_FOUND_BUT_CANNOT_INVOKE): Define.
6936 * Makefile.maint (syntax-check): Move each individual check into
6938 (syntax-check-rules): This is the list of syntax-check targets.
6939 (sc_unmarked_diagnostics, sc_cast_of_argument_to_free):
6940 (sc_cast_of_x_alloc_return_value, sc_space_tab):
6941 (sc_error_exit_success, sc_xalloc_h_in_src): New targets.
6943 2003-07-12 Jim Meyering <jim@meyering.net>
6945 * configure.ac: Remove uses of OPTIONAL_BIN_ZCRIPTS and last
6946 traces of the nohup script.
6948 * src/Makefile.am (bin_SCRIPTS): Remove use of just-removed
6949 $(OPTIONAL_BIN_ZCRIPTS).
6951 * src/Makefile.am (localedir.h): Put the `2>&1' after the redirect
6952 target, not before the `>'.
6954 * src/remove.c (remove_dir): Give a diagnostic upon failed save_cwd,
6955 now that that function no longer calls `error'.
6957 * src/df.c (find_mount_point): Emit a diagnostic for each
6958 failed syscall, rather than relying on caller to do that.
6959 The caller couldn't do a good job, anyhow -- too many different
6960 ways to fail (each with a different referent).
6961 Give a diagnostic upon failed save_cwd, now that that function
6962 no longer calls `error'.
6963 (show_point): Don't diagnose find_mount_point's errors, now that
6964 it handles them itself.
6966 * src/df.c (find_mount_point): Don't let free clobber errno upon
6969 * src/sys2.h: Remove alloca-related block.
6970 * src/system.h: Include <alloca.h> here, instead.
6972 It appears that the `#pragma alloca' included via "system.h" is
6973 adequate, since join.c uses alloca, yet lacked an in-file #pragma.
6974 * src/copy.c, src/cp.c, src/df.c, src/install.c, src/ln.c:
6975 * src/ls.c, src/mv.c, src/remove.c: Remove `#pragma alloca'.
6977 * src/chown-core.c (change_file_owner): Do not restore any special
6978 permission bits (e.g., set-user-ID, set-group-ID) that are reset
6979 by chown(2) on some systems. Suggestion and insistence :-) from
6982 * tests/input-tty: Also check `test -t 1'.
6983 This is necessary on linux-2.4.21. Otherwise, the stty/basic-1
6984 test would block when run in the background.
6986 2003-07-11 Jim Meyering <jim@meyering.net>
6988 * tests/sample-test: Also fail if cat-to-create-expected-output
6989 fails. Otherwise, if both `exp' and `out' were to end up empty
6990 because of e.g., a full disk, they would mistakenly compare equal.
6992 * src/nohup.c: New file. Rewrite of nohup.sh in C.
6993 This solves a portability problem: on at least Solaris systems,
6994 when nohup.sh used the vendor /bin/sh, it would exit with status
6995 of `1' rather than the required 126 or 127 upon failure to exec
6996 the specified program.
6998 * src/Makefile.am (EXTRA_SCRIPTS): Remove definition.
6999 (bin_PROGRAMS): Add nohup.
7000 (EXTRA_DIST): Remove nohup.sh.
7001 (all_programs): Remove use of $(EXTRA_SCRIPTS).
7002 * src/nohup.sh: Remove file.
7003 * man/Makefile.am (nohup.1): Depend on nohup.c, rather than nohup.sh.
7005 * tests/misc/nohup: Tests for the above.
7006 * tests/misc/Makefile.am (TESTS): Add nohup.
7008 * src/head.c (diagnose_copy_fd_failure): New function, renamed from
7009 the macro, COPY_FD_DIAGNOSE.
7010 (diagnose_copy_fd_failure): Enclose diagnostic in _(...).
7011 (head_file): Likewise.
7013 * src/date.c: Include "quote.h".
7014 (batch_convert): Use the quote function rather than using literal `...'
7017 * src/setuidgid.c (main): Enclose diagnostic in _(...).
7018 * src/fmt.c (main): Likewise.
7019 * src/mknod.c (main): Likewise.
7020 * src/tac.c (tac_seekable): Likewise.
7021 * src/yes.c (main): Likewise.
7022 * src/od.c (main): Likewise.
7023 * src/install.c (change_attributes): Likewise.
7025 2003-07-10 Jim Meyering <jim@meyering.net>
7027 * src/head.c (usage): Use 1024*1024 in place of 1048576.
7028 * src/tail.c (usage): Likewise.
7030 * tests/rm/fail-2eperm: Now that we have setuidgid, use it in
7031 place of the kludge in this test. Suggestion from Paul Jarc.
7033 * src/Makefile.am (noinst_PROGRAMS): Define to setuidgid.
7034 * src/setuidgid.c: New program, solely for testing (not installed).
7036 * src/chown-core.c (change_file_owner): Don't leak file descriptors
7037 when dereferencing symlinks.
7039 2003-07-09 Jim Meyering <jim@meyering.net>
7041 * tests/du/slash: New file/test for today's lib/ftw.c fix.
7042 * tests/du/Makefile.am (TESTS): Add slash
7044 * src/tail.c (xlseek): Avoid warning about ``return without value
7045 from function returning non-void''.
7047 2003-07-08 Jim Meyering <jim@meyering.net>
7049 * man/help2man: Update to version 1.29.
7051 * man/help2man: Add END handler to close STDOUT and check for errors.
7053 2003-06-30 Paul Eggert <eggert@twinsun.com>
7055 Add support for a "[" that conforms to the GNU coding standards,
7056 i.e., that does not depend on its name.
7057 * src/lbracket.c: New file.
7059 * man/Makefile.am (programs): Ignore "[", since it doesn't have
7060 a separate man page.
7061 * src/Makefile.am (bin_PROGRAMS): Add "[".
7062 (__SOURCES): New var.
7063 * src/test.c (LBRACKET): Define to 0 if not defined.
7064 (main): Use LBRACKET rather than argv[0].
7066 * src/test.c (one_argument): Do not check for -t if POSIXLY_CORRECT.
7067 Reported by Paul Jarc and Dan Jacobson.
7069 * src/test.c (main): Do not recognize --help or --version if
7070 POSIXLY_CORRECT, when invoked as "test". Handle "[ ]" correctly.
7071 Do not bother testing that margv[margc] is non-null.
7073 2003-07-04 Jim Meyering <jim@meyering.net>
7075 * src/who.c (print_line): Rewrite to use asprintf, in order to be
7076 able to avoid emitting trailing spaces. Reported by Dan Jacobson.
7078 * tests/misc/head-elide-tail: Add tests of head's new --lines=-N
7079 option, and perform the +1600 invocations of head IFF the envvar
7080 RUN_EXPENSIVE_TESTS is set.
7082 2003-07-03 Jim Meyering <jim@meyering.net>
7084 * src/cp.c (do_copy): Give a better diagnostic when failing due
7085 to nonexistent destination directory. Reported by Dmitry Rutsky.
7086 See http://bugs.debian.org/199730 for details.
7088 2003-06-27 Jim Meyering <jim@meyering.net>
7090 split's --verbose option did nothing [broken in 4.5.10 and 5.0]
7091 * src/split.c (longopts): Use `1', not `0' as the value for
7092 for &verbose. Reported by Keith Thompson.
7094 Test for the above fix.
7095 * tests/misc/split-a: Also use --verbose and compare stderr
7096 output with what we'd expect.
7098 2003-06-20 Jim Meyering <jim@meyering.net>
7100 * src/copy.c (copy_internal) [HAVE_STRUCT_STAT_ST_AUTHOR]:
7101 Use `error_t' (rather than int) as type for local `err'.
7102 From Alfred M. Szmidt.
7104 2003-06-19 Marcus Brinkmann <marcus@gnu.org>
7106 * src/copy.c (copy_internal) [HAVE_STRUCT_STAT_ST_AUTHOR]:
7107 Fix author preservation code.
7109 2003-06-19 Jim Meyering <jim@meyering.net>
7111 * src/ln.c (ENABLE_HARD_LINK_TO_SYMLINK_WARNING): Define to 0.
7112 (do_link): Don't warn about hard link to symlink.
7114 2003-06-18 Jim Meyering <jim@meyering.net>
7116 * src/cut.c: Include "getdelim2.h", not "getstr.h".
7117 Reflect renaming: getstr -> getdelim2.
7119 * src/comm.c, src/join.c, src/nl.c, src/uniq.c: Reflect renaming:
7120 readline -> readlinebuffer.
7122 2003-06-09 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
7124 * src/readlink.c: Include <sys/types.h> before system.h (because
7125 the latter includes <sys/stat.h>). Required on Ultrix 4.3.
7127 2003-06-17 Jim Meyering <jim@meyering.net>
7129 * src/system.h (initialize_main): Define.
7130 Use it in every `main'. Applied via this:
7131 p='initialize_main (&argc, &argv);'
7132 perl -ni -e '/program_name.=.argv.0/ and print " '"$p"'\n"; print' \
7133 $(grep -l program_name.=.argv.0 *.c)
7134 test.c uses margc/margv, so I made the change manually for that file.
7135 Based on a patch from Bernard Giroud.
7137 2003-06-09 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
7139 Fix for build failure on Ultrix 4.3.
7140 * src/stat.c: Include sys/statvfs.h in preference to sys/vfs.h.
7141 Include sys/param.h and sys/mount.h on ultrix.
7143 2003-06-16 Jim Meyering <jim@meyering.net>
7145 * src/touch.c (O_NDELAY, O_NONBLOCK, O_NOCTTY, EISDIR): Remove
7147 * src/system.h (O_NDELAY, O_NONBLOCK, O_NOCTTY, EISDIR): Define
7148 them here instead, but with one change: define EISDIR to -1, not 0.
7150 * src/cat.c (cat): Remove `#ifndef ENOSYS', now that it's
7151 guaranteed to be defined.
7152 * src/system.h (ENOSYS, ENOTSUP): Define to -1 if not defined.
7154 * README: Mention the CVS repository.
7155 Encourage addition of test cases.
7157 2003-06-12 Jim Meyering <jim@meyering.net>
7159 * src/touch.c (touch): Call close only if necessary.
7162 * src/wc.c (usage): Correct wording: wc prints counts in the order
7163 `newline, word, byte'. Reported by Keith M. Briggs.
7164 * man/wc.x: Fix it here, too. And change `lines' to `newlines'.
7166 2003-06-10 Jim Meyering <jim@meyering.net>
7168 * tests/date/Test.pm: Add a test for the new format, e.g., May-23-2003.
7170 2003-06-07 Jim Meyering <jim@meyering.net>
7172 * Makefile.maint (syntax-check): Add commented-out (over-aggressive)
7175 2003-06-06 Jim Meyering <jim@meyering.net>
7177 * src/extract-magic (main): Avoid newer 3-arg form of open,
7178 so this script works also with e.g., perl5.005_03.
7179 Patch by John David Anglin.
7181 2003-06-04 Paul Eggert <eggert@twinsun.com>
7183 * src/system.h: Include <stdbool.h> unconditionally.
7185 2003-06-04 Jim Meyering <jim@meyering.net>
7187 * man/Makefile.am (check-programs-vs-x): Rename target
7188 from check-programs-vs-1. Adjust rule to check for the
7189 primary (.x) file, not the generated one (.1).
7191 2003-06-03 Tim Mooney <mooney@dogbert.cc.ndsu.NoDak.edu>
7193 * man/kill.x: New file.
7194 * man/Makefile.am (dist_man_MANS): Add kill.1.
7197 2003-06-04 Jim Meyering <jim@meyering.net>
7199 Ensure that the .x file for a new program is never forgotten again.
7200 * man/Makefile.am (programs): Define.
7201 (check-programs-vs-1): New phony target.
7202 (check-local): Depend on it.
7204 2003-06-03 Jim Meyering <jim@meyering.net>
7206 Avoid unnecessary copying of environment.
7207 * src/env.c (main): Rather than clearing the environment and --
7208 unless told to ignore environment -- copying all settings from
7209 the saved, original environment, clear the environment only when
7210 that is requested. Suggested by Jens Elkner.
7212 2003-06-02 Jim Meyering <jim@meyering.net>
7214 * src/system.h: Always include <string.h>, since we assume C89.
7215 Include <limits.h> without checking for HAVE_LIMITS_H.
7217 * src/test.c [!TEST_STANDALONE]: Remove #if-0'd block.
7218 (STREQ, S_IXUGO): Remove redundant (in system.h) definitions.
7220 2003-06-01 Jim Meyering <jim@meyering.net>
7222 Avoid a race condition in `tail -f' described by Ken Raeburn in
7223 http://mail.gnu.org/archive/html/bug-textutils/2003-05/msg00007.html
7224 * src/tail.c (file_lines): Add new parameter, *read_pos, and set it.
7225 (pipe_lines, pipe_bytes, start_bytes, start_lines): Likewise.
7226 (tail_bytes, tail_lines, tail): Likewise.
7227 (tail_file): Use the new `read_pos' value as the size,
7228 rather than stats.st_size from the fstat call.
7230 2003-05-28 Jim Meyering <jim@meyering.net>
7232 * src/extract-magic: Allow expansion of `$file' in the here-
7233 document corresponding to the comment at the top of fs.h.
7235 2003-05-26 Jim Meyering <jim@meyering.net>
7237 * src/stat.c: Fix portability problem on FreeBSD5.0: don't include
7238 <sys/statvfs.h> on systems without HAVE_STRUCT_STATVFS_F_BASETYPE.
7239 Use #if/#elif/... cascade so we get only one set of include files.
7240 Reported by Nelson Beebe.
7242 2003-05-24 Jim Meyering <jim@meyering.net>
7244 * src/md5sum.c (split_3): Accept the BSD format only when in MD5 mode.
7245 * tests/sha1sum/basic-1: Make sure `sha1sum --check' doesn't
7246 accept the BSD format.
7248 2003-03-28 Joe Orton <jorton@redhat.com>
7250 * src/md5sum.c (bsd_split_3): New function.
7251 (split_3): Detect checksums from BSD 'md5' command and handle them
7254 * tests/md5sum/basic-1: New tests for --check exit status, and for
7255 BSD-style checksum files.
7257 2003-05-21 Jim Meyering <jim@meyering.net>
7259 * src/head.c (elide_tail_lines_pipe): Fix a thinko.
7260 This sort of thing is why it'd be *Really Good* to factor
7261 out the common code used here and in tail.c.
7263 2003-05-14 Jim Meyering <jim@meyering.net>
7265 * src/head.c (usage): Document new feature: --bytes=-N and --lines=-N.
7267 * tests/du/slink: Skip this test if `.' is on an XFS file system.
7269 * tests/du/fd-leak: New file. Test for the bug in du that
7270 was fixed by the 2003-05-12 change to lib/ftw.c.
7271 * tests/du/Makefile.am (TESTS): Add fd-leak.
7273 * src/head.c (AUTHORS): Enclose string in N_(...), now that it
7274 includes a translatable word, `and'.
7276 * src/dd.c (usage): Don't use `,' as the thousands separator
7277 in e.g. 1,000,000 and 1,048,576. Instead, do this:
7278 `SIZE may be ..., MB 1000*1000, M 1024*1024 and so on...'
7279 * src/df.c (usage): Likewise.
7280 * src/du.c (usage): Likewise.
7281 * src/ls.c (usage): Likewise.
7283 * Makefile.maint (syntax-check): Add another check.
7285 2003-05-13 Paul Eggert <eggert@twinsun.com>
7287 Fix uniq to conform to POSIX, which requires that "uniq -d -u"
7288 must output nothing. Problem reported by Josh Hyman.
7290 * src/uniq.c (enum output_mode, mode): Remove, replacing with:
7291 (output_unique, output_first_repeated, output_later_repeated):
7292 New vars. All uses of "mode" changed to use these variables,
7293 which are not mutually exclusive as "mode" was.
7294 (writeline): New arg "match", used to control whether to
7295 obey output_first_repeated or output_later_repeated.
7296 All callers changed.
7297 (check_file, main): Adjust to above changes.
7299 * tests/uniq/Test.pm: Test that 'uniq -d -u' outputs nothing.
7301 2003-05-14 Jim Meyering <jim@meyering.net>
7303 * tests/rm/rm3: Use tr's \n notation rather than \012.
7304 This package can afford to do that, since its tests are guaranteed use
7305 GNU tr, which has accepted the more modern notation for 10 years.
7306 * tests/rm/rm5: Likewise.
7307 * tests/cp/same-file: Likewise.
7308 * tests/stty/row-col-1: Likewise.
7309 * tests/stty/basic-1: Likewise.
7310 * tests/rm/deep-1: Likewise.
7311 * tests/mv/part-symlink: Likewise.
7312 * tests/mkdir/perm: Likewise.
7313 * tests/misc/nice: Likewise.
7315 2003-05-13 Jim Meyering <jim@meyering.net>
7317 * src/copy.c (struct F_triple) [name]: Remove const attribute.
7318 (triple_free): Don't apply cast to argument of free.
7319 (seen_file): Add cast here instead.
7321 * src/cp-hash.c (struct Src_to_dest) [name]: Remove const attribute.
7322 (src_to_dest_free): Don't apply cast to argument of free.
7324 * src/sort.c (zaptemp): Don't apply cast to argument of free.
7325 * src/pr.c (init_fps, init_store_cols): Likewise.
7326 * src/join.c (delseq, freeline): Likewise.
7327 * src/expr.c (OLD): Likewise.
7328 * src/sort.c (sort): Likewise.
7329 * src/head.c (elide_tail_lines_pipe): Likewise.
7331 * src/tail.c: Include "quote.h".
7332 Use quote in diagnostics. Change many error format strings
7333 from just `%s' to e.g., `error reading %s'.
7334 (pipe_lines): Change type of parameter, n_lines, to uintmax_t.
7335 Rewrite newline-counting loop to use memchr.
7337 * src/head.c (elide_tail_lines_pipe): Use `if', not assert.
7338 Now that assert is no longer used, don't include <assert.h>.
7340 2003-05-12 Jim Meyering <jim@meyering.net>
7342 * src/head.c: Include <assert.h>.
7343 (AUTHORS): Add my name.
7344 (elide_tail_lines_pipe): New function.
7346 2003-05-10 Jim Meyering <jim@meyering.net>
7348 * Makefile.maint (syntax-check): Check for `error (EXIT_SUCCESS,'.
7350 * src/readlink.c (main): Set program_name before first use.
7351 Remove that (redundant) first use.
7352 Don't exit successfully just because --verbose was specified.
7353 Pass 0, not EXIT_SUCCESS, as first argument to error; when that
7354 parameter is 0, error does not exit.
7356 * src/uname.c (main): When failing due to too many arguments, also say
7357 that, rather than just "Try `uname --help' for more information.".
7358 * src/comm.c (main): Likewise, but for too few arguments.
7359 * src/logname.c: Include error.h.
7360 (main): Say why we're failing.
7362 * src/uniq.c (main): Don't segfault when argc < optind.
7363 * src/who.c (main): Handle argc < optind.
7364 * src/df.c (main): Likewise.
7365 * src/install.c (main): Likewise.
7366 * src/mv.c (main): Likewise.
7367 * src/pwd.c (main): Likewise.
7368 * src/tty.c (main): Likewise.
7369 * src/chroot.c (main): Likewise.
7370 * src/hostname.c: Likewise.
7371 * src/du.c (main): Likewise.
7372 * src/expand.c (main): Likewise.
7373 * src/env.c (main): Likewise.
7374 * src/unexpand.c (main): Likewise.
7375 * src/printenv.c (main): Likewise.
7376 * src/sync.c (main): Handle argc == 0.
7377 * src/expr.c (main): Likewise.
7378 * src/printf.c (main): Likewise.
7379 * src/basename.c (main): Likewise.
7380 * src/ln.c (main): Test for `missing argument' before computing n_files.
7381 * src/tail.c (main): Test for the case of no arguments before
7384 * src/kill.c (send_signals): Don't check command line arguments here.
7385 (main): Check them here instead. Handle argc < optind.
7387 * src/logname.c (main): Use error, rather than fprintf, for the sake
7390 * src/rm.c (main): Don't overrun array bound if argc is 0.
7392 2003-05-09 Jim Meyering <jim@meyering.net>
7394 * src/sort.c (main): Don't overrun array bound if argc is 0.
7395 That would happen when invoked via: execl ("/usr/bin/sort", NULL);
7396 Reported by Wartan Hachaturow.
7398 2003-05-07 Jim Meyering <jim@meyering.net>
7400 Implement support so that `head --lines=-N' works on seekable files.
7401 * src/head.c (enum Copy_fd_status): Define.
7402 (COPY_FD_DIAGNOSE): New macro.
7403 (elide_tail_lines_seekable): New funtion.
7404 (elide_tail_lines_file): Call it here.
7406 2003-05-06 Jim Meyering <jim@meyering.net>
7408 * src/sys2.h (CHAR_BIT): Remove duplicate definition.
7410 2003-05-04 Jim Meyering <jim@meyering.net>
7412 * tests/head/Test.pm: Remove tests of --bytes=-N; using that framework
7413 caused the addition of thousands of small files to the tar archive.
7414 * tests/misc/head-elide-tail: New file. Add them here instead.
7415 * tests/misc/Makefile.am (TESTS): Add head-elide-tail.
7417 2003-05-04 Paul Eggert <eggert@twinsun.com>
7419 * src/remove.c (HAVE_WORKING_READDIR): Define to 0 if not defined.
7420 (IF_READDIR_NEEDS_REWINDDIR): Remove.
7421 (remove_cwd_entries): Rewrite to avoid IF_READDIR_NEEDS_REWINDDIR,
7422 which was a bit weird because it couldn't be emulated by a function.
7424 2003-05-03 Jim Meyering <jim@meyering.net>
7426 Extend head to accept --lines=-N (--bytes=-N) and to print all
7427 but the N lines (bytes) at the end of the file.
7428 * src/head.c: Include full-write.h, full-read.h, inttostr.h, quote.h.
7429 Use quote() in diagnostics, rather than literal `' marks.
7430 (copy_fd, elide_tail_bytes_pipe, elide_tail_bytes_file):
7432 (elide_tail_lines_pipe, elide_tail_lines_file): New functions.
7433 (head_file): Reorganize so as to call head from only one place.
7434 (main): Likewise, for head_file.
7435 Handle new, undocumented option, --presume-input-pipe.
7436 Handle negative line and byte counts.
7437 * tests/head/Test.pm: Add lots of tests to exercise --bytes=-N.
7439 * tests/du/8gb: Skip test if the file system of `.' doesn't support
7440 sparse files -- otherwise it'd create a file of size 8GB.
7442 2003-05-02 Jim Meyering <jim@meyering.net>
7444 * src/fmt.c (usage): Don't mention obsolescent -WIDTH option.
7445 Instead explain about `-' and standard input.
7446 (main): Give a proper diagnostic for e.g., `fmt -c -72'.
7447 Reported by Keith Thompson.
7448 * tests/fmt/basic: Add test for the above fix.
7450 * src/fmt.c: Include "quote.h".
7451 Use quote() in diagnostics, rather than literal `' marks.
7452 (main): Exit nonzero when unable to open an input file.
7453 * tests/fmt/basic: Add test for the above fix.
7455 * src/fmt.c (main): Diagnose invalid suffix on obsolescent width
7456 specifications like `-72x'.
7457 * tests/fmt/basic: Add test for the above fix.
7459 Work around nasty readdir bug on Darwin6.5.
7460 * src/remove.c (IF_READDIR_NEEDS_REWINDDIR): Define.
7461 [! HAVE_WORKING_READDIR] (remove_cwd_entries): If readdir has just
7462 returned NULL and there has been at least one successful unlink or
7463 rmdir call since the opendir or previous rewinddir, then call
7464 rewinddir and reiterate the loop.
7466 Factor out common code.
7467 * src/remove.c (readdir_ignoring_dotdirs): New function.
7468 (is_empty_dir): Use it here.
7469 (remove_cwd_entries): Use it here.
7471 2003-05-01 Jim Meyering <jim@meyering.net>
7473 * tests/rm/r-3: Create 500 rather than just 300 files.
7474 There's a bug in Darwin6.5's readdir that shows up only with
7476 Fix a bug in this test: `cd $pwd' (not to `..'), now that $tmp
7480 Change type of n_units, n_bytes, n_lines to be `uintmax_t'.
7481 (dump_remainder): Move two declarations `down' into the scope
7482 where they are used.
7483 (xlseek): Return the resulting offset.
7484 (file_lines): Rename parameter, file_length, to end_pos.
7485 (pipe_lines): Don't coerce safe_read return value to `int'.
7486 Adapt tests accordingly.
7487 (pipe_bytes) [struct charbuffer] (nbytes): Change type from `int'
7489 Change type of `total_bytes' from `int' to `size_t',
7490 since the former wouldn't always be wide enough.
7491 Don't coerce safe_read return value to `int',
7492 and adapt tests accordingly.
7493 Now that testing for a read error no longer involves
7494 using `tmp', handle that case *after* freeing `tmp'.
7495 (start_bytes): Clean up.
7496 (tail_bytes): Now that `n_bytes' may be larger than
7497 OFF_T_MAX, test for that condition and, if it's true, don't
7498 use lseek optimizations.
7499 (parse_options): Don't fail just because N_UNITS is larger than
7500 the maximum size of a file -- tail may be applied to an input
7501 stream (e.g., a pipe) with more data than that.
7503 * Makefile.maint (syntax-check): Rename from alloc-check.
7504 Also check for SPACE-TAB sequences.
7505 Also check for malloc/calloc/realloc casts.
7507 2003-05-01 Jim Meyering <jim@meyering.net>
7509 * src/tail.c (start_lines): Rewrite to use memchr. Clean up.
7511 2003-04-28 Jim Meyering <jim@meyering.net>
7513 * tests/misc/tty-eof: Send two tokens, not just one, so we don't
7514 make the now-more-picky tsort fail.
7516 2003-04-24 Jim Meyering <jim@meyering.net>
7518 * src/tsort.c (tsort): Remove unnecessary test of have_read_stdin.
7519 (main): Minor syntactic clean-up.
7521 * src/tsort.c (tsort): Fail if the input contains an odd number of
7522 tokens. Reported by junkio@cox.net.
7524 * tests/tsort/basic-1: Test for the above fix.
7526 2003-04-21 Jim Meyering <jim@meyering.net>
7528 * tests/misc/printf: Add tests for the printf fixes below.
7530 * Makefile.cfg (cvs_files): Add $(srcdir)/config/depcomp to the list.
7532 2003-04-20 Paul Eggert <eggert@twinsun.com>
7534 Fix printf POSIX compatibility bug reported by Ben Harris in
7535 <http://mail.gnu.org/archive/html/bug-coreutils/2003-04/msg00070.html>.
7536 * doc/coreutils.texi (printf invocation): It's \NNN in the format,
7537 \0NNN in the %b operand.
7538 * src/printf.c (usage): Likewise.
7539 (print_esc): New arg OCTAL0 to specify whether \0NNN or \NNN
7540 is desired. All uses changed. Behave like Bash printf if %b
7541 operand uses \NNN where the initial N is not 0.
7543 2003-04-17 Jim Meyering <jim@meyering.net>
7545 * src/stty.c: Remove uses of PROTOTYPE macro.
7547 2003-04-15 Jim Meyering <jim@meyering.net>
7549 * Makefile.maint: Remove (or replace-with-TAB(s) to retain alignment)
7550 each sequence of spaces before a TAB character.
7552 2003-04-13 Jim Meyering <jim@meyering.net>
7554 * src/remove.c (is_empty_dir): Don't closedir (NULL).
7556 2003-04-12 Jim Meyering <jim@meyering.net>
7558 Giving nl an invalid STYLE argument (in --header-numbering=STYLE (-h),
7559 --body-numbering=STYLE (-b), or --footer-numbering=STYLE (-f)) or
7560 FORMAT (--number-format=FORMAT (-n)) would not give a useful diagnostic.
7561 * src/nl.c (main): Fix those problems and remove literal quote marks
7562 (e.g., "`%s'") from format string; instead use "%s" in each format
7563 string and `quote (optarg)' as the corresponding argument.
7564 Also, diagnose all invalid command line options before failing.
7566 * src/nl.c (proc_text): Fix a bug that would make nl output extra
7567 newlines in some cases. Details here: http://bugs.debian.org/177256.
7568 This bug was introduced on 2001-11-10 for textutils-2.0.17.
7569 * tests/misc/nl: Add test for the above-fixed bug.
7571 * tests/misc/readlink: New file. Test the --canonicalize option.
7572 * tests/misc/Makefile.am (TESTS): Add readlink.
7574 2003-04-11 Jim Meyering <jim@meyering.net>
7577 * src/chown.c, src/cp.c, src/dircolors.hin, src/du.c, src/ln.c:
7578 * src/mkfifo.c, src/ptx.c, src/spline.c, src/stty.c, src/tail.c:
7579 * src/test.c, src/unexpand.c: Remove (or replace-with-TAB(s) to
7580 retain alignment) each sequence of spaces before a TAB character.
7582 * src/ls.c: Include <stdlib.h> unconditionally.
7584 * Makefile.maint (xalloc-check): Rename from header-check.
7586 * src/yes.c: Include error.h after system.h, not before.
7589 * src/copy.c, src/cp-hash.c, src/cp.c, src/csplit.c, src/cut.c:
7590 * src/date.c, src/df.c, src/du.c, src/expand.c, src/expr.c, src/id.c:
7591 * src/join.c, src/md5sum.c, src/nl.c, src/od.c, src/paste.c, src/pr.c:
7592 * src/ptx.c, src/sort.c, src/split.c, src/su.c, src/tail.c, src/tee.c:
7593 * src/tr.c: * src/unexpand.c, src/users.c:
7594 Remove anachronistic casts of xmalloc, xrealloc, and xcalloc
7595 return values and of xrealloc's first argument.
7596 Fix the former with this:
7597 perl -pi -e 's/\([^(]*?\*\) *(x(m|c|re)alloc)\b/$1/'
7599 2003-04-10 Jim Meyering <jim@meyering.net>
7601 * src/stty.c (wrapf): Declare with format attribute.
7603 The S_MAGIC_... names shouldn't be maintained in two places (prior
7604 to this change, one would have to keep stat.c and fs.h in sync).
7605 This change makes it so those names and the corresponding
7606 hexadecimal constants all reside in stat.c. fs.h is now generated.
7607 * src/Makefile.am (fs.h): New rule to generate fs.h from stat.c.
7608 (BUILT_SOURCES): Add fs.h, now that it's generated.
7609 (EXTRA_DIST): Add extract-magic.
7610 * src/extract-magic: New script to extract fs.h definitions from stat.c.
7611 * src/stat.c (human_fstype) [__linux__]: Append each hex constant from
7612 fs.h in a comment after the corresponding `case S_MAGIC_...:' statement.
7614 * tests/tail-2/big-4gb: Skip this test (don't fail) if creating a
7615 file with nominal length > 4GB fails. Reported by Michael Deutschmann.
7617 * man/unexpand.x: Add `SEE ALSO' reference to expand.
7618 * man/expand.x: Add `SEE ALSO' reference to unexpand.
7619 Suggestion from Dan Jacobson.
7621 2003-04-10 Maciej W. Rozycki <macro@ds2.pg.gda.pl>
7623 * src/fs.h (S_MAGIC_DEVPTS): New magic for Linux's devpts.
7624 * src/stat.c (human_fstype): Handle Linux's devpts.
7626 2003-04-09 Paul Eggert <eggert@twinsun.com>
7628 * src/split.c (line_bytes_split): Arg is of type size_t, since
7629 that's all that is supported for now.
7630 (main): Check for overflow in obsolescent line count option.
7632 2003-04-09 Jim Meyering <jim@meyering.net>
7634 * tests/misc/split-fail: Add a new test for the above fix.
7636 * src/split.c (bytes_split): Use size_t temporary (rather than
7637 uintmax_t original) in remaining computations. From Paul Eggert.
7639 Handle command line option arguments larger than 2^31.
7640 This allows e.g., splitting into files of size 2GB and larger,
7641 and running split --lines=N with N=2^31 or more.
7642 But for --line-bytes=N, the restriction that N <= SIZE_MAX
7643 remains (for now), due to the way it is implemented.
7645 * src/split.c: Include "inttostr.h".
7646 (bytes_split, lines_split, line_bytes_split, main):
7647 Use uintmax_t, not size_t, for file sizes.
7648 (main): Give a better diagnostic for option arguments == 0.
7649 Use umaxtostr to print file sizes.
7650 Reported by Luke Hassell.
7652 2003-04-08 Jim Meyering <jim@meyering.net>
7654 * src/rm.c (usage): Mention that --directory (-d) works only
7655 on some systems. Suggestion from Samuel Tardieu.
7657 * tests/basename/basic: Run $PERL to see if it is available,
7658 rather than testing its value.
7659 * tests/sum/sysv, tests/tsort/basic-1, tests/unexpand/basic-1:
7660 * tests/basename/basic, tests/dd/skip-seek, tests/dircolors/simple:
7661 * tests/expr/basic, tests/factor/basic, tests/fmt/basic:
7662 * tests/ls-2/tests, tests/md5sum/basic-1, tests/md5sum/newline-1:
7663 * tests/misc/sort, tests/misc/tty-eof, tests/mv/i-1:
7664 * tests/rm/empty-name, tests/rm/fail-eperm, tests/rm/unreadable:
7665 * tests/seq/basic, tests/sha1sum/basic-1, tests/sha1sum/sample-vec:
7666 * tests/sum/basic-1, tests/seq/basic: Likewise.
7668 * tests/misc/Makefile.am (TESTS): Add split-fail.
7669 * tests/misc/split-fail: New file.
7671 * src/split.c: Rename local variables: nchars -> n_bytes.
7672 (lines_split): Rename local, nlines -> n_lines.
7673 (main): Rename local variable: s/accum/n_units/.
7674 (main): Use STDIN_FILENO, not literal `0'.
7676 2003-04-07 Jim Meyering <jim@meyering.net>
7678 * src/stat.c: Add #include directives for Ultrix 4.4.
7679 Based on a suggested change from Bert Deknuydt.
7681 2003-04-06 Jim Meyering <jim@meyering.net>
7683 * Makefile.maint (makefile-check): New rule.
7684 (local-check): Add it.
7686 2003-04-05 Jim Meyering <jim@meyering.net>
7688 * Makefile.am (nearly all of them):
7689 Use $(VAR) rather than @VAR@, now that we can rely on automake to
7690 emit a definition for each substituted variable.
7691 * tests/Makefile.am.in: Likewise.
7693 * tests/rm/rm5: Add a comment explaining why this test fails when
7694 using Tru64's broken sed.
7695 * tests/rm/rm3: Likewise.
7697 Make `kill -t' output signal descriptions (not `?') on Tru64.
7698 * src/kill.c (sys_siglist): Also check for __sys_siglist.
7699 Patch by Tony Leneis.
7700 * configure.ac: Also check for declaration of __sys_siglist.
7701 Required for Tru64 4.0D, 4.0F, and 5.1.
7702 Reported by Tony Leneis.
7704 2003-04-04 Jim Meyering <jim@meyering.net>
7706 * src/Makefile.am (PERL): Remove unnecessary definition.
7708 Because of inappropriate (but POSIX-mandated) behavior of rename,
7709 `mv a b' would not remove `a' in some unusual cases. Work around
7710 this by unlinking `a' when necessary.
7712 * src/copy.c (same_file_ok): Add an output parameter.
7713 Set it in the offending case.
7714 (copy_internal): When necessary, unlink SRC_PATH and inform caller.
7715 Reported by Ed Avis.
7716 * tests/mv/hard-4: New test for the above.
7717 * tests/mv/Makefile.am (TESTS): Add hard-4.
7719 Clean up rules for automatically generated sources:
7720 * src/Makefile.am (dircolors.h, wheel-size.h, wheel.h, false.c):
7721 Make each generated file be read-only.
7722 Add each file name to BUILT_SOURCES separately.
7723 (MAINTAINERCLEANFILES): Set to $(BUILT_SOURCES).
7725 Put LOCALEDIR macro definition in new file: localedir.h.
7726 * src/Makefile.am (DEFS): Remove definition.
7727 (localedir.h): New rule.
7728 (BUILT_SOURCES, DISTCLEANFILES): Add localedir.h.
7729 * src/system.h: Include "localedir.h".
7731 2003-04-02 Jim Meyering <jim@meyering.net>
7735 * tests/misc/Makefile.am (TESTS): Add false.
7737 * Makefile.maint (TMPDIR): Make sure it's defined.
7738 (my-distcheck): Build in $(TMPDIR), not `.'.
7740 * src/Makefile.am (false.c): Change all occurrences of
7741 `(EXIT_SUCCESS)' to `(EXIT_FAILURE)' so that false exits
7742 unsuccessfully also with --help. Reported by Paul Jarc,
7743 * tests/misc/false: New test for the above.
7745 2003-03-30 Jim Meyering <jim@meyering.net>
7747 * NEWS: Note the location of older NEWS files.
7749 * src/remove.c (is_empty_dir): Don't let a failing closedir
7750 clobber errno. Spotted by Arnold Robbins.
7752 * src/env.c: Fix typo in comment. From Arnold Robbins.
7754 2003-03-29 Jim Meyering <jim@meyering.net>
7758 * README: Note to expect build problems for stat.c on Ultrix 4.3.
7759 Note that there are some harmless test failures when running
7760 `make check' as root on some systems.
7762 2003-03-28 Jim Meyering <jim@meyering.net>
7764 * tests/stty/row-col-1: Skip this test if stty can't get window size.
7765 This happens when connecting to sparc-solaris5.7 via ssh from within
7766 emacs. Reported by Karl Berry.
7768 * tests/du/basic: Use seq, not `yes' to generate 4KB of data.
7769 Otherwise, on systems (DJGPP) that emulate pipes using files,
7770 this test would never complete, waiting for `yes' to terminate.
7771 * tests/du/slink: As above, use seq, not `yes' to generate link target.
7772 * tests/rm/hash: As above, use seq, not `yes' to generate dir name.
7773 Reported by Rich Dawe.
7775 2003-03-27 Jim Meyering <jim@meyering.net>
7777 * src/id.c: Remove Arnold Robbins' obsolete e-mail address
7778 from `written by...' comment, at his request.
7780 2003-03-24 Paul Eggert <eggert@twinsun.com>
7782 Fix buffer overrun problem reported by TAKAI Kousuke, along
7783 with some other POSIX incompatibilities.
7785 * src/printf.c (print_esc): Do not treat \x specially if
7786 POSIXLY_CORRECT. Avoid buffer overrun if the format ends
7787 in backslash. Treat incomplete escape sequences as strings
7788 of characters, as POSIX requires.
7789 (print_formatted): Allow multiple flags. Avoid buffer overrun
7790 if the format is incomplete.
7792 2003-03-24 Jim Meyering <jim@meyering.net>
7794 * tests/misc/printf: Add tests for the above fixes and changes.
7796 2003-03-26 Jim Meyering <jim@meyering.net>
7798 * src/copy.h (struct cp_options): Add a comment.
7800 2003-03-23 Jim Meyering <jim@meyering.net>
7802 * README: Describe problem with 64-bit mode on HPUX 11.x,
7803 with patch for /usr/include/inttypes.h.
7804 * TODO: Plan to add an autoconf test to work around the bug.
7806 2003-03-22 Jim Meyering <jim@meyering.net>
7808 * src/stat.c: Don't include <sys/sysmacros.h>.
7809 That is already done via system.h. Otherwise, the multiple
7810 inclusion would evoke redefinition warnings from Cray's /bin/cc,
7811 aka Cray Standard C Version 4.0.3 (057126) Mar 22 2003 22:02:28.
7812 (human_fstype): Factor some directives `up', out of this function.
7813 Cast away `const' to avoid error from Cray's /bin/cc.
7815 2003-03-20 Jim Meyering <jim@meyering.net>
7817 * announce-gen (print_changelog_deltas): Ensure that a newline
7818 precedes each row of `*'s.
7820 2003-03-20 Jim Meyering <jim@meyering.net>
7824 * src/seq.c (valid_format): Also accept ` ' and `'' as valid
7825 format flag characters.
7826 Do not require that a field width be specified.
7827 Do not fail when given a field width of `0'.
7828 Reported by Dan Jacobson.
7829 * tests/seq/basic: Add new tests for the above-fixed bug.
7831 * src/Makefile.am (all-local): Append $(EXEEXT) to use of `su'
7832 (install-root): Likewise.
7833 (install-exec-local): Likewise.
7834 Based on a patch from Richard Dawe.
7836 2003-03-19 Jim Meyering <jim@meyering.net>
7838 * man/Makefile.am (.x.1): Use $(LN_S) instead of 'ln -s',
7839 because the DJGPP 2.03 port of 'ln -s' doesn't work.
7840 Include $(EXEEXT) in program names.
7841 Since $(LN_S) may degenerate to `cp -p', be careful
7842 to invoke it from the destination directory.
7843 Mostly from Richard Dawe.
7844 * configure.ac: Use AC_PROG_LN_S.
7846 * tests/mv/part-symlink: Unset CDPATH. Otherwise, having the
7847 CDPATH shell variable set could cause this test to fail.
7848 Reported by Karl Berry.
7850 2003-03-18 Jim Meyering <jim@meyering.net>
7852 * src/fmt.c [struct Word] (paren, period, punct, final): Change the
7853 type of each member from bool <MEMBER>:1 to unsigned int <MEMBER>:1.
7854 AIX 5.1's xlc could not compile the former.
7855 Patch by Petter Reinholdtsen. Also reported by Mike Jetzer.
7857 2003-03-17 Richard Dawe <rich@phekda.freeserve.co.uk>
7859 * configure.ac: Include $(EXEEXT) in OPTIONAL_BIN_PROGS'
7860 program names, since automake only adds $(EXEEXT) to programs
7863 2003-03-16 Jim Meyering <jim@meyering.net>
7865 * src/remove.c (rm): Put two local variables in static storage,
7866 so they can't be clobbered by the potential longjmp.
7868 2003-03-15 Jim Meyering <jim@meyering.net>
7870 * Makefile.cfg (gnu_rel_host): Fix code to match the comment
7871 so that a version number with a two-digit component can still count
7872 as an alpha release. Reported by Richard A Downing.
7873 (gnu_rel_host): Define in terms of $(RELEASE_TYPE) instead.
7875 2003-03-14 Jim Meyering <jim@meyering.net>
7877 * src/ansi2knr.c: Remove no-longer-used file.
7878 * src/ansi2knr.1: Likewise.
7880 * Makefile.maint (prev_version_file): Don't use ?= for this particular
7881 assignment, since it causes trouble with old versions of GNU make
7882 (e.g. 3.76.1). The other uses of `?=' are inoffensive. Details here.
7883 http://mail.gnu.org/archive/html/bug-coreutils/2003-03/msg00028.html
7884 Patch from Alexandre Duret-Lutz.
7886 * Use patched automake-1.7.3. Regenerate Makefile.in files in
7887 subdirectories so that each includes a definition of ACLOCAL_M4.
7889 * announce-gen (main): Label the compressed source URLs.
7893 * tests/du/slink: Relax the test for the `local'ness of a file system,
7894 so that now it works also for tmpfs.
7896 * tests/du/hard-link: Transform output from first du, so that this
7897 test doesn't fail on file systems like tmpfs that order directory
7898 entries differently.
7900 2003-03-13 Jim Meyering <jim@meyering.net>
7902 * tests/du/8gb: Work around what appears to be an NFS failure that
7903 would make this test fail on some systems.
7905 2003-03-11 Jim Meyering <jim@meyering.net>
7907 * tests/du/basic: Make the test file exactly 4k bytes long.
7909 * src/split.c (longopts): Don't hard-code `2' here.
7910 Instead, just specify `&verbose', and ...
7911 (main): ... remove the `case 2:' block for --verbose.
7913 * tests/du/basic: Make the test file larger than 64 bytes, so that
7914 we don't immediately disqualify file systems (e.g., NetApp) on which
7915 smaller files take up zero disk blocks. Reported by Vin Shelton.
7917 2003-03-10 Jim Meyering <jim@meyering.net>
7919 Don't segfault for a negative field width or precision in format string.
7920 Note that this is just a stopgap fix. The longer term solution may
7921 involve adapting bash's builtins/printf.def.
7923 * src/printf.c: (UNSPECIFIED): Define.
7924 (print_direc): Use the special value, UNSPECIFIED, to indicate
7925 that field_width or precision has not been specified.
7926 (print_formatted): Fail if field_width or precision is the
7927 special value, UNSPECIFIED.
7928 Reported by Oliver Kiddle <okiddle@yahoo.co.uk>
7930 * src/sys2.h (INT_MIN): Define, if necessary.
7931 * tests/misc/printf: Add a test for the above-fixed bug.
7933 2003-03-09 Jim Meyering <jim@meyering.net>
7935 * src/remove.c (AD_stack_pop): Cast sizeof... to int before
7936 changing its sign. This avoids a warning from gcc on 64-bit systems.
7937 Reported by Bob Proulx.
7938 (pop_dir): Reverse order of sign change and cast, to be consistent
7941 2003-03-08 Jim Meyering <jim@meyering.net>
7943 * tests/Makefile.am (evar-check): Check for POSIXLY_CORRECT not as a
7944 shell variable, but only in the environment. With /bin/sh->bash, the
7945 shell variable is set to `y', and that would cause a spurious warning.
7946 Reported by Bob Proulx.
7948 * tests/Makefile.am (check-root): Remove touch/fifo.
7949 It doesn't appear to have to be run as root.
7951 * tests/rm/fail-2eperm: Rather than simply using the first non-root
7952 user name, make sure that the selected user name has a usable shell.
7953 Reported by Paul Jarc.
7955 Before, when using shred on a device, one had to specify --exact,
7956 or be careful to choose a size that would not be rounded up and
7957 exceed the maximum value; that could result in a failure of
7959 * src/shred.c (do_wipefd): --exact is now the default for non-regular
7960 files. Suggestion from Ben Elliston.
7963 * tests/misc/tty-eof: Require at least version 1.11 of Expect.pm.
7964 Old versions of Expect.pm (e.g., 1.07) lack the log_user function.
7965 Patch by Bob Proulx.
7967 * src/Makefile.am (check-misc): Check for use of `defined' in
7969 Change to $(srcdir) before running grep.
7971 * src/sleep.c: Remove now-unused #include and #define directives.
7973 * src/du.c (process_file): If a file's size is not being counted
7974 e.g., because it's a hard link to a file we've already counted,
7975 then don't print a line for it.
7977 * tests/du/hard-link: New test for the above-fixed bug.
7978 * tests/du/Makefile.am (TESTS): Add hard-link.
7981 * src/du.c: Revert most of the `reorganization' change of 2003-02-20,
7982 and make the two-array approach work.
7984 * tests/du/basic: Correct/add tests for the above fix.
7985 Set LC_ALL, etc., now that we use sort.
7986 Check the block/size of a small file, too.
7987 Correct expected results for simple dir1/dir2/file case.
7988 Add another test of du -S.
7990 2003-03-07 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
7992 Avoid build failure with gcc on hppa1.1-hp-hpux10.20 (see GCC PR
7993 middle-end/9986). As one of GCC's optimizations, it transforms a
7994 fputs_unlocked call to a fputc_unlocked call when the string is
7995 one character long. However, hpux doesn't have fputc_unlocked.
7997 * expr.c (usage): Use putchar, not fputs, to output a single character.
7998 * ls.c (dired_dump_obstack): Likewise.
7999 * ptx.c (output_one_tex_line, output_one_dumb_line): Likewise.
8000 * stat.c (print_it): Likewise.
8002 2003-03-07 Jim Meyering <jim@meyering.net>
8004 * src/cp.c: Remove everything associated with mmap-stack.c.
8005 This reverts the two changes of 2003-02-21.
8006 * src/du.c: Remove everything associated with mmap-stack.c.
8007 This reverts the change of 2003-02-19.
8009 2003-03-06 Jim Meyering <jim@meyering.net>
8011 * tests/cp/same-file: Unset CDPATH. Otherwise, having the
8012 CDPATH shell variable set could cause this test to fail.
8013 Reported by Karl Berry.
8015 2003-03-05 Jim Meyering <jim@meyering.net>
8019 * src/printf.c (print_esc): Remove pointless comparison of unsigned
8020 integer with zero, to avoid a warning from Intel's ecc.
8021 Reported by Nelson Beebe.
8023 * src/du.c (process_file): Sizes must all be of type uintmax_t.
8024 Otherwise, for files or totals that are too big, numbers would
8025 be truncated. Patch mostly by Michael Stone.
8026 Reported by Ingo Saitz as Debian bug #183210.
8028 * tests/du/8gb: New test for the above-fixed bug.
8029 * tests/du/Makefile.am (TESTS): Add 8gb.
8031 * src/du.c (MAX_N_DESCRIPTORS): Use 3 * UTILS_OPEN_MAX / 4
8032 rather than UTILS_OPEN_MAX - 10.
8034 2003-03-04 Jim Meyering <jim@meyering.net>
8036 * README: Refer new feature discussion to bug-coreutils@gnu.org,
8037 rather than bug-gnu-utils, now that the former is better known.
8038 Suggestion from Göran Uddeborg.
8040 * src/stat.c (usage): Capitalize consistently.
8041 Reported by Göran Uddeborg.
8043 * Makefile.maint (rel-files): Include $(signatures), so that
8044 those files are also copied into $(release_archive_dir).
8046 * src/df.c (find_mount_point): Call error here, now that restore_cwd
8048 * src/remove.c (AD_pop_and_chdir): Likewise.
8050 * tests/Makefile.am (check-root): Add fail-2eperm.
8052 2003-03-03 Jim Meyering <jim@meyering.net>
8054 * src/remove.c (remove_cwd_entries): Include the full filename of
8055 the offending file, not just the basename.
8057 * tests/misc/tty-eof: Set $ME properly.
8059 * Makefile.maint (THIS_VERSION_REGEXP, PREV_VERSION_REGEXP):
8060 Remove now-unused variables.
8061 (tag-prev-version, prev-cvs-tag): Likewise.
8063 * src/remove.c (remove_cwd_entries) [!ROOT_CAN_UNLINK_DIRS]: Give an
8064 accurate diagnostic when failing to remove a file owned by some other
8065 user. Reported by Ivo Timmermans via Michael Stone.
8066 This fixes Debian bug# 178471.
8068 * tests/rm/Makefile.am (TESTS): Add fail-2eperm.
8069 * tests/rm/fail-2eperm: New test, for the above-fixed bug.
8070 Based on a report from Ivo Timmermans.
8072 2003-03-02 Jim Meyering <jim@meyering.net>
8074 * src/copy.c (copy_internal) [un_backup]: When recovering from a
8075 failure to create a hard link, do not remove the entry associating
8076 the source dev/ino with the destination file name.
8077 * tests/mv/Makefile.am (TESTS): Add hard-3.
8078 * tests/mv/hard-3: New test, for the above-fixed bug.
8079 Inspired by a report from Iida Yosiaki.
8081 2003-03-01 Jim Meyering <jim@meyering.net>
8083 * src/df.c (print_header): Don't embed spaces in a separate `Type'
8084 header string. Instead, put `Filesystem' and `Type' headers in the
8085 same string, so translators can use horizontal space as needed.
8086 Reported by Jean Charles Delepine.
8088 2003-02-28 Jim Meyering <jim@meyering.net>
8090 * src/copy.c (copy_internal): When link fails because of an
8091 existing destination file, unlink that file and try again.
8092 Reported by Iida Yosiaki.
8094 * tests/mv/Makefile.am (TESTS): Add hard-2.
8095 * tests/mv/hard-2: New test for the above-fixed bug.
8096 Based on a test case from Iida Yosiaki.
8098 2003-02-26 Jim Meyering <jim@meyering.net>
8100 * tests/du/basic: Don't test du's -b option here. Directory byte
8101 counts are smaller (512 rather than 4096) on at least OSF/1 5.1
8102 and IBM AIX 4.2. Reported by Nelson Beebe.
8104 2003-02-25 Jim Meyering <jim@meyering.net>
8106 * Makefile.maint (announcement): Now that ChangeLog entries
8107 are output by announce-gen, don't do it here.
8108 * announce-gen (print_changelog_deltas): New function.
8111 2003-02-22 Jim Meyering <jim@meyering.net>
8113 * announce-gen: New option: --release-type=TYPE
8114 * Makefile.maint (beta, major): New targets. Remove `release'.
8115 Put them all together on a line.
8116 Pass the release type (via RELEASE_TYPE envvar) to the MAKE
8117 invocation of `announcement'.
8118 (announcement): Invoke announce-gen with --release-type=$RELEASE_TYPE.
8120 * announce-gen: New option: --news=NEWS_FILE.
8121 Extract NEWS entries here, not via rules in Makefile.maint.
8122 * Makefile.maint (announcement): Now that NEWS entries are
8123 extracted by announce-gen, don't do it here.
8124 (news-r1, news-r2): Remove now-unused definitions.
8126 2003-02-21 Jim Meyering <jim@meyering.net>
8130 Merge in changes from autoconf's version of this file.
8131 * Makefile.maint (www-gnu): Define.
8132 (standards.texi-url_prefix): Use $(www-gnu).
8133 (make-stds.texi-url_prefix): Likewise.
8135 * src/cp.c: Include "mmap-stack.h".
8136 (main): Invoke `run' through a macro that (when possible) runs it
8137 with a large, mmap'd stack.
8139 * src/cp.c (run): New function, preparing for the above.
8140 Exit from this function, not from main
8143 * src/du.c: New option: --apparent-size.
8144 (enum) [APPARENT_SIZE_OPTION]: New member.
8145 (long_options): Add it.
8146 (usage): Describe it.
8148 ['b']: Set apparent_size.
8149 David Eisner reported that the behavior of --bytes had changed.
8150 Paul Eggert proposed the use of a new option, --apparent-size.
8152 * src/du.c (apparent_size): New global.
8153 (print_only_size): Reflect the fact that we're printing byte counts,
8154 not ST_NBLOCKSIZE-byte-block counts.
8155 (print_size): Call print_only_size rather than duplicating its code.
8156 (process_file): Accumulate byte counts, rather than block counts.
8158 * src/du.c (process_file): Always reset size_to_propagate_to_parent
8159 for --separate-dirs (-S).
8161 2003-02-20 Jim Meyering <jim@meyering.net>
8163 * Use automake-1.7.3. Regenerate dependent files.
8165 * src/stat.c (print_stat): New format: %B (to print ST_NBLOCKSIZE).
8166 This makes %b (number of ST_NBLOCKSIZE-byte blocks) more useful.
8167 (usage) [%B]: Describe it.
8170 * src/du.c (process_file): Reorganize the code to use only
8171 one `sum' array, and change how -S works back to the way it was
8172 before 2003-01-31. Patch by Bruno Haible.
8174 * tests/du/basic: New test.
8175 * tests/du/Makefile.am (TESTS): Add basic.
8177 * tests/envvar-check: Add checks for the following:
8178 BLOCK_SIZE, DU_BLOCK_SIZE, DF_BLOCK_SIZE, LS_BLOCK_SIZE.
8180 * tests/Makefile.am: Rename phony target envvar-check to evar-check
8181 so as not to conflict with the distributed file by the same name.
8183 * src/du.c (process_file): Set info->skip before any possible return.
8185 Report correct usage for directories, not 0.
8186 * src/du.c (process_file): Return for `file_type == FTW_DPRE'
8187 _before_ recording the dev/ino of a directory.
8188 Reported by Bruno Haible.
8190 Now, df always displays the device file name corresponding to the
8191 listed mount point under `Filesystem'. Before, for an unmounted
8192 block- or character-special file argument, it would display the
8193 command-line argument instead.
8194 * src/df.c (show_disk): Return a value indicating whether
8195 there was a match. Don't try to find a mount point here.
8196 (show_entry): If show_disk doesn't find a match, call show_point.
8198 2003-02-19 Jim Meyering <jim@meyering.net>
8200 * src/du.c: Include "mmap-stack.h".
8201 (du_files): Add prototype with ATTRIBUTE_NORETURN.
8202 Exit from this function, not from...
8204 Instead, if possible, invoke du_files through a macro that
8205 runs it with a large, mmap'd stack.
8207 * src/join.c (usage): Change wording in --help output:
8208 use FILENUM instead of `SIDE' and say what FILENUM means.
8209 Reported by Bernhard Gabler.
8211 * src/df.c (print_header): Rather than using a hard-coded literal
8212 string of spaces matching the length of the English `...Type' header,
8213 output the right number of spaces to match the selected translation.
8214 Reported by Yann Dirson and Jean Charles Delepine as Debian bug 131113.
8216 * src/split.c (bytes_split): Remove unnecessary `else' after break.
8217 (lines_split): Likewise. and correct misleading indentation.
8219 * src/split.c: Include "full-read.h".
8220 (bytes_split, lines_split, line_bytes_split): Use full_read,
8221 not safe_read. The way split was using the latter, a short read
8222 could cause split to terminate before EOF.
8224 * tests/misc/tty-eof: Test all programs that can read stdin,
8225 requiring no arguments and that write to standard output.
8227 * tests/misc/tty-eof: New file. Renamed from ...
8228 * tests/misc/cat-tty-eof: Remove file. Rename to tty-eof.
8229 * tests/misc/Makefile.am (TESTS): Reflect renaming.
8231 2003-02-18 Jim Meyering <jim@meyering.net>
8233 cksum would perform an extra read after encountering EOF
8234 * src/cksum.c (cksum): Exit the loop upon EOF, too.
8235 Patch by Michael Bacarella.
8237 Test for the bug fixed today in cksum, md5sum, and sha1sum.
8238 * tests/misc/cat-tty-eof: Generalize, clean-up, and test for
8239 cat, cksum, md5sum, and sha1sum all in the same loop.
8241 2003-02-14 Jim Meyering <jim@meyering.net>
8243 * src/remove.c: Include "euidaccess.h".
8244 Remove declaration of euidaccess.
8246 2003-02-12 Jim Meyering <jim@meyering.net>
8248 * src/pathchk.c (portable_chars_only): Remove unnecessary `const'
8249 in cast to avoid warning from icc. Reported by Alexandre Duret-Lutz.
8251 2003-02-10 Jim Meyering <jim@meyering.net>
8253 * src/test.c: Don't include group-member.h.
8254 Include euidaccess.h.
8255 (eaccess): Rewrite function to set the real uid and gid temporarily
8256 to the effective uid and gid, then invoke 'access', and then set the
8257 real uid and gid back. On systems that lack setreuid or setregid,
8258 fall back on the kludges in euidaccess. Before, it would not work
8259 for e.g., files with ACLs, files that were marked immutable,
8260 or on file systems mounted read-only. Nelson Beebe raised the issue.
8261 Paul Eggert suggested the new implementation.
8263 2003-02-09 Jim Meyering <jim@meyering.net>
8265 * src/test.c (test_stat): Remove function. It's job is done (only
8266 when necessary) by the wrapper in lib/stat.c. Adjust all uses.
8268 2003-02-08 Jim Meyering <jim@meyering.net>
8272 * tests/mv/part-symlink: Don't assume that the file owner username
8273 length is less than 9 in ls output: instead, omit that field
8274 altogether. Reported by, and suggested fix from, Ferdinand.
8276 * tests/du/restore-wd: New test for just-fixed bug in ftw.c.
8277 * tests/du/Makefile.am (TESTS): Add restore-wd.
8279 * src/rm.c: Correct now-invalid comment about cycle-detection.
8281 2003-02-06 Jim Meyering <jim@meyering.net>
8283 * NEWS: Add entries from old/*/NEWS
8284 from fileutils-4.1 through 4.1.11 and
8285 from sh-utils-2.0 through 2.0.15. Suggestion from Karl Berry.
8289 * src/du.c (process_file): Don't return early for excluded files
8290 or for files whose dev/inode we've already seen.
8292 2003-02-05 Jim Meyering <jim@meyering.net>
8294 * tests/du/exclude: New file.
8295 * tests/du/Makefile.am (TESTS): Add exclude.
8297 2003-02-04 Dmitry V. Levin <ldv@altlinux.org>
8299 * src/who.c (print_boottime, print_deadprocs, print_runlevel):
8300 Fix memory allocation arithmetic.
8302 2003-02-04 Jim Meyering <jim@meyering.net>
8304 `df /dev/block-or-char-device-file--not-mounted' now reports
8305 the name of the file system on which the file resides, usually `/'.
8306 Before, it would leave the `Mounted on' field blank.
8307 * src/df.c (show_disk): Move function to precede find_mount_point.
8308 (show_disk): Add parameter: STATP.
8309 If we don't find a matching device name, then resort to calling
8310 find_mount_point. Reported by Bob Proulx.
8312 2003-02-03 Andreas Schwab <schwab@suse.de>
8314 * tests/rm/cycle: Require non-root.
8315 * tests/rm/isatty: Likewise.
8317 2003-02-02 Jim Meyering <jim@meyering.net>
8321 * man/Makefile.am (check-x-vs-1): Use @PATH_SEPARATOR@, not `:'.
8323 Ensure that there are no offending uses of `:'.
8324 * Makefile.maint (makefile_path_separator_check): New rule.
8325 (local-check): Add it to the list.
8327 2003-02-01 Jim Meyering <jim@meyering.net>
8329 * src/du.c (MAX_N_DESCRIPTORS): Define.
8331 * src/stat.c (G_fail): New global.
8332 (human_time): Diagnose failed localtime, not failed nstrftime.
8333 (main): Fail if G_fail is set.
8335 2003-01-31 Richard Dawe <rich@phekda.freeserve.co.uk>
8337 * tests/basename/Makefile.am: Use @PATH_SEPARATOR@ instead of
8338 hard-coding the path-separator. Also double-quote the new PATH,
8339 to avoid problems when the path-separator is a semi-colon or when
8340 `pwd` contains e.g. a space.
8341 * tests/chgrp/Makefile.am: Likewise.
8342 * tests/chmod/Makefile.am: Likewise.
8343 * tests/chown/Makefile.am: Likewise.
8344 * tests/cp/Makefile.am: Likewise.
8345 * tests/dd/Makefile.am: Likewise.
8346 * tests/dircolors/Makefile.am: Likewise.
8347 * tests/du/Makefile.am: Likewise.
8348 * tests/expr/Makefile.am: Likewise.
8349 * tests/factor/Makefile.am: Likewise.
8350 * tests/fmt/Makefile.am: Likewise.
8351 * tests/install/Makefile.am: Likewise.
8352 * tests/ln/Makefile.am: Likewise.
8353 * tests/ls/Makefile.am: Likewise.
8354 * tests/ls-2/Makefile.am: Likewise.
8355 * tests/md5sum/Makefile.am: Likewise.
8356 * tests/misc/Makefile.am: Likewise.
8357 * tests/mkdir/Makefile.am: Likewise.
8358 * tests/mv/Makefile.am: Likewise.
8359 * tests/od/Makefile.am: Likewise.
8360 * tests/rm/Makefile.am: Likewise.
8361 * tests/rmdir/Makefile.am: Likewise.
8362 * tests/seq/Makefile.am: Likewise.
8363 * tests/sha1sum/Makefile.am: Likewise.
8364 * tests/shred/Makefile.am: Likewise.
8365 * tests/stty/Makefile.am: Likewise.
8366 * tests/sum/Makefile.am: Likewise.
8367 * tests/tail-2/Makefile.am: Likewise.
8368 * tests/touch/Makefile.am: Likewise.
8369 * tests/tsort/Makefile.am: Likewise.
8370 * tests/unexpand/Makefile.am: Likewise.
8372 2003-01-31 Jim Meyering <jim@meyering.net>
8374 * src/stat.c: Include "file-type.h"
8375 (print_human_type): Remove function.
8376 (human_access): Rename from print_human_access. Return a string.
8377 (human_time): Rename from print_human_time. Return a string.
8378 (print_stat): Arrange so that field width and an alignment specifier
8379 are honored for the %A, %F, %x, %y, and %z formats.
8380 [%F]: Use file_type; this gives slightly different file type strings,
8381 e.g., `directory' instead of `Directory' and `regular file' or
8382 `regular empty file' instead of `Regular file'.
8383 Prompted by a report from Richard Dawe that the uses of
8384 S_IFSOCK and S_IFIFO in print_human_time were not portable
8385 to systems using e.g., DJGPP.
8387 2003-01-31 Richard Dawe <rich@phekda.freeserve.co.uk>
8389 * src/stat.c (print_stat): Use S_ISLNK rather than an explicit
8390 test using S_IFMT and S_IFLNK. S_IFLNK may not be defined.
8392 2003-01-31 Jim Meyering <jim@meyering.net>
8394 * src/du.c (main): Upon processing an invalid option or an invalid
8395 --exclude-from or --max-depth option argument, don't exit right away,
8396 in case there are others. Rather record the failure and exit after
8397 processing other options.
8399 * GNUmakefile (TAR_OPTIONS): Set and export, in order to make
8400 tar archive easier to reproduce.
8402 Rewrite to perform directory traversal using nftw.
8404 * src/du.c: Include "dirname.h", "ftw.h", and "quotearg.h".
8405 (AUTHORS): Add self.
8406 (opt_one_file_system): Move global into `main'.
8407 (path, xstat, exit_status): Remove declarations.
8408 (arg_length, suffix_length): New globals.
8409 (G_fail): New global, sort of like the old `exit_status'.
8410 (IS_FTW_DIR_TYPE): Define.
8411 (print_only_size): New function.
8412 (process_file): New function.
8413 (str_init, ensure_space, str_copyc, str_concatc): Remove functions.
8414 (str_trunc, pop_dir, count_entry): Likewise.
8415 (du_files): Rewrite to use nftw.
8417 2003-01-30 Jim Meyering <jim@meyering.net>
8419 * tests/du/trailing-slash: Ensure that du/ftw follows a command-line
8420 symlink-to-directory with -L, even without the trailing slash.
8422 2003-01-27 Jim Meyering <jim@meyering.net>
8424 * src/Makefile.am (check-misc): Check for st_blocks, too.
8426 * src/stat.c (print_stat): Use ST_NBLOCKS rather than `->st_blocks'.
8427 Reported by Richard Dawe.
8429 2003-01-27 Andreas Schwab <schwab@suse.de>
8431 * src/ls.c (quote_name): Add fourth parameter, width, into which to
8432 store the screen columns, and return the number of bytes instead.
8433 (print_dir): Pass NULL as fourth parameter of quote_name.
8434 (print_name_with_quoting): Likewise.
8435 (length_of_file_name_and_frills): Get the width from the fourth
8436 parameter of quote_name instead of return value.
8438 2003-01-27 Jim Meyering <jim@meyering.net>
8440 * src/ls.c (decode_switches): If `dired' is set without
8441 `format == long_format', then silently reset dired. This doesn't
8442 change the behavior of ls (all prior uses of dired were protected
8443 by `&& format == long_format'), and lets us...
8444 (DIRED_INDENT): ... remove the `format == long_format' conjunct.
8445 (PUSH_CURRENT_DIRED_POS): Likewise.
8448 2003-01-22 Jim Meyering <jim@meyering.net>
8450 * tests/du/no-x: New test, for functionality added to lib/ftw.c.
8451 * tests/du/Makefile.am (TESTS): Add no-x.
8453 2003-01-21 Jim Meyering <jim@meyering.net>
8455 * src/remove.c (remove_entry) [ROOT_CAN_UNLINK_DIRS
8456 && HAVE_STRUCT_DIRENT_D_TYPE]: If a file has d_type == DT_UNKNOWN
8457 it may still be a directory -- or not (e.g., with FreeBSD on an
8458 NFS-mounted file system), so resort to calling lstat to find out.
8459 Based on a patch by Michael van Elst.
8461 * tests/cp/same-file: Don't assume that the file owner username
8462 length is less than 9 in ls output: instead, omit that field
8463 altogether. Reported by, and suggested fix from, Ferdinand.
8465 2003-01-20 Jim Meyering <jim@meyering.net>
8467 * tests/date/Test.pm (wide-fmt): New test to demonstrate that
8468 large format widths no longer cause strftime to infloop.
8470 * Makefile.maint (mail_gpg_sign_cookie): Remove now-unused definition.
8472 2003-01-19 Jim Meyering <jim@meyering.net>
8474 * src/readlink.c: Include "canonicalize.h".
8476 2003-01-18 Jim Meyering <jim@meyering.net>
8478 * src/ls.c (Dereference_symlink) [DEREF_COMMAND_LINE_SYMLINK_TO_DIR]:
8480 (enum) [DEREFERENCE_COMMAND_LINE_SYMLINK_TO_DIR_OPTION]: New member.
8481 (long_options): Add option --dereference-command-line-symlink-to-dir.
8482 (main): Make DEREF_COMMAND_LINE_SYMLINK_TO_DIR be the default,
8483 rather than DEREF_COMMAND_LINE_ARGUMENTS, when none of the
8484 -d, -F, -l options is specified.
8485 (decode_switches): Handle --dereference-command-line-symlink-to-dir.
8486 (gobble_file): Honor DEREF_COMMAND_LINE_SYMLINK_TO_DIR.
8487 Change --dereference-command-line (-H) to dereference *all*
8488 command line arguments, including broken symlinks.
8490 2003-01-15 Paul Eggert <eggert@twinsun.com>
8492 Change ls -H back to the way it was yesterday, since this is
8493 compatible with FreeBSD and the POSIX spec is confusing
8494 and somewhat contradictory.
8496 * src/ls.c (DEREF_COMMAND_LINE_ARGUMENTS): Change name back
8497 from DEREF_COMMAND_LINE_SYMLINK_TO_DIR, updating all uses.
8498 (long_options): Change the long option name back.
8499 (usage): Change the usage back.
8500 (gobble_file): When -H is specified, dereference a top-level
8501 arg even if it points to a non-directory.
8503 2003-01-15 Jim Meyering <jim@meyering.net>
8505 * src/ls.c (gobble_file): Fall back on using lstat when required:
8506 when --dereference (-L) is not specified, and
8507 - when operating on a dangling symlink
8508 - when operating on command-line-symlink-to-directories
8509 This fixes numerous problems. Here are examples:
8510 - `ls dangling-symlink' would fail with `no such file...'
8511 Now it prints `dangling-symlink'.
8512 - `ls -i symlink' would mistakenly print the inode of the referent.
8513 Now it prints the inode of the symlink. Likewise for --size (-s).
8514 Based on a patch from Michael Stone.
8515 Reported by Deepak Goel as Debian bug #173793.
8517 Rename ls's --dereference-command-line (-H)
8518 option to --dereference-command-line-symlink-to-dir.
8519 * src/ls.c [enum Dereference_symlink]
8520 (DEREF_COMMAND_LINE_SYMLINK_TO_DIR): Rename from
8521 DEREF_COMMAND_LINE_ARGUMENTS. Update all uses.
8522 (long_options): Rename the long option.
8523 (usage): Say that --dereference-... changes how ls treats
8524 only symlinks to directories specified on the command line.
8526 2003-01-14 Jim Meyering <jim@meyering.net>
8528 * tests/ls/dangle: New file/test, for the above fix.
8529 * tests/ls/inode: Another new file/test, for the above fix.
8530 * tests/ls/Makefile.am (TESTS): Add dangle and inode.
8532 * src/ls.c (gobble_file): Fix a bug introduced in 4.5.4 that made it
8533 so that ls --color would no longer highlight the names of files with
8534 the execute bit set when not specified on the command line.
8535 Patch by Michael Stone. Reported by Stephen Depooter as
8538 * tests/ls-2/tests (color-exe): New test, for the above fix.
8540 2003-01-13 Jim Meyering <jim@meyering.net>
8542 * tests/shred/exact: Also test for just fixed bug with --zero.
8544 * src/shred.c (long_opts): --zero does not require an argument.
8545 Patch by Michael Stone. Reported by Roland Turner as Debian bug 172019.
8547 2003-01-12 Jim Meyering <jim@meyering.net>
8549 * Makefile.maint (cvs-update): Skip any file with local modifications.
8551 * src/unexpand.c (usage): Document --first-only and mention that
8552 --tabs=N (-t) enables --all (-a). Reported by wiregauze@yahoo.com.
8554 2002-12-01 Dmitry V. Levin <ldv@altlinux.org>
8556 * src/df.c: Include "canonicalize.h".
8557 Use canonicalize_file_name unconditionally.
8559 2003-01-09 Jim Meyering <jim@meyering.net>
8561 * README: Add readlink.
8563 2002-11-30 Dmitry V. Levin <ldv@altlinux.org>
8565 * src/df.c: Include "xgetcwd.h".
8566 * src/pwd.c: Likewise.
8568 2002-11-30 Dmitry V. Levin <ldv@altlinux.org>
8570 * src/shred.c: Remove declaration of xstrdup.
8571 We already get it via xalloc.h which is included via system.h.
8573 2002-08-27 Dmitry V. Levin <ldv@altlinux.org>
8575 New program: readlink.
8577 * src/Makefile.am (bin_PROGRAMS): Add readlink.
8578 * src/readlink.c: New file.
8580 * man/readlink.x: New file.
8581 * man/Makefile.am (dist_man_MANS): Add readlink.1.
8582 (readlink.1): New rule.
8584 2003-01-09 Jim Meyering <jim@meyering.net>
8586 When selecting ranges of byte offsets (as opposed to ranges of fields)
8587 and when --output-delimiter=STRING is specified, output STRING between
8588 ranges of selected bytes.
8589 * src/cut.c (RANGE_START_SENTINEL): Define.
8590 (output_delimiter_specified): New global.
8591 (print_kth): Add parameter. Adjust all callers.
8592 (set_fields): Mark each range-start index with RANGE_START_SENTINEL.
8593 (cut_bytes): When requested, output STRING between ranges of
8595 (main): Make a diagnostic a little clearer.
8596 Based on a patch from Jan Nieuwenhuizen.
8598 * tests/cut/Test.pm: New tests for the above.
8600 * src/cut.c (set_fields): Make code agree with comment:
8601 Don't merge abutting ranges like 4- and 2-3. This makes no
8602 difference currently, but is required to support an upcoming change.
8604 2003-01-07 Jim Meyering <jim@meyering.net>
8606 * src/cut.c (set_fields): Fix typo in comment.
8608 * tests/touch/not-owner: New test, mostly extracted from fail-diag.
8609 * tests/touch/Makefile.am (TESTS): Add not-owner.
8610 * tests/touch/fail-diag: Remove the test for non-owner diagnostic.
8611 Now, this tests only the nonexistent-directory diagnostic.
8612 Suggestion from Michael Stone.
8614 * tests/touch/fail-diag: Fix typo: s/ld/ls/.
8616 2003-01-04 Jim Meyering <jim@meyering.net>
8618 * src/copy.h: Remove use of PARAMS.
8619 * src/remove.h: Likewise.
8620 * src/chown-core.h: Likewise.
8622 rm could be tricked into mistakenly reporting a cycle.
8623 * src/remove.c: [cycle_check_state]: New global.
8624 (remove_cwd_entries): Adapt to new semantics of cycle_check.
8625 (rm): Call cycle_check_init and cycle_check_free for each file.
8626 * tests/rm/cycle (rm): New test, for the above fix.
8627 * tests/rm/Makefile.am (TESTS): Add cycle.
8629 When rm detects a cycle, don't abort the entire command,
8630 but rather just the affected command line argument.
8631 * src/remove.c: Include <setjmp.h>
8632 (struct dirstack_state) [current_arg_jumpbuf]: New member.
8633 (remove_cwd_entries): Call longjmp if we detect a cycle.
8634 (rm): Call setjmp here.
8636 * src/remove.c (cycle_check, is_power_of_two): Remove functions.
8637 Instead, include cycle-check.h and use it.
8639 * src/remove.h (struct dev_ino): Remove declaration.
8641 * src/remove.c (remove_cwd_entries): Fix typos in comment.
8643 Don't include trailing /. in diagnostics about directories.
8644 * src/remove.c (full_filename_): When FILENAME is just `.'
8645 and there is a nonempty directory-name part, don't append `/.'.
8646 * tests/rm/unread2: Remove trailing /. from diagnostic.
8647 * tests/rm/rm2: Likewise.
8649 * src/remove.c (struct dirstack_state): Define.
8650 To be used in place of these file-scoped globals ...
8651 (dir_stack, len_stack, Active_dir): Remove globals.
8652 (ds_init, ds_free): New functions.
8653 (full_filename): Define.
8654 (full_filename_): Rename from full_filename.
8656 Begin to make AD_* functions more generic.
8657 * src/remove.c (AD_push_initial): Don't set status to RM_OK here.
8658 (AD_push): Likewise.
8659 (AD_INIT_OTHER_MEMBERS): Define.
8660 (remove_dir): Define the `status' member manually after each
8661 call to AD_push or AD_push_initial.
8663 * src/Makefile.am (check-misc): New rule, to ensure that no more
8664 S_IS* macro definitions sneak into the code.
8665 (check): Depend on check-misc.
8667 * src/remove.c [S_ISLNK]: Don't define. It's already defined in sys2.h.
8668 * src/du.c (count_entry) [S_ISLNK]: Don't define.
8669 * src/shred.c [S_ISLNK, S_ISFIFO, S_ISSOCK]: Don't define.
8671 2003-01-03 Jim Meyering <jim@meyering.net>
8673 * src/true.c: Add copyright.
8674 (AUTHORS): I suppose I've written it.
8676 * src/Makefile.am (false.c): Make the generated file be read-only.
8678 2003-01-04 Jim Meyering <jim@meyering.net>
8680 * src/ls.c: Include "dev-ino.h".
8681 [struct dev_ino]: Remove declaration.
8683 2003-01-02 Jim Meyering <jim@meyering.net>
8685 * src/cp.c (do_copy): Tweak diagnostic to be consistent with the one
8686 from mv: s/missing file arguments/missing file argument/.
8687 With --target-directory=DIR, cp and mv work with a single file argument.
8688 Reported by Karl Berry.
8690 * tests/rm/isatty: Enable this test.
8692 2002-12-31 Jim Meyering <jim@meyering.net>
8694 * src/remove.c (AD_push_initial): Don't set status to RM_OK here.
8695 (AD_push): Likewise.
8696 (AD_INIT_OTHER_MEMBERS): Define.
8697 (remove_dir): Define the `status' member manually after each
8698 call to AD_push or AD_push_initial.
8700 * src/ls.c [struct dev_ino]: Remove definition.
8701 Include "dev-ino.h" instead.
8703 2002-12-28 Jim Meyering <jim@meyering.net>
8705 * tests/du/Makefile.am (TESTS): Add no-deref.
8706 * tests/du/no-deref: New script.
8708 2002-12-23 Jim Meyering <jim@meyering.net>
8710 * src/remove.c (remove_cwd_entries): Fix typo in comment.
8712 2002-12-21 Jim Meyering <jim@meyering.net>
8714 * announce-gen: Generate MML-formatted announcement.
8715 This makes it a *lot* harder to send stale MD5/SHA1 signatures.
8717 2002-12-20 Jim Meyering <jim@meyering.net>
8719 * src/touch.c (touch): Change the wording of a diagnostic so
8720 that it makes sense both when the file exists and when it doesn't.
8721 Suggestion from Michael Stone.
8723 2002-12-18 Jim Meyering <jim@meyering.net>
8725 * src/stty.c (valid_options): Declare to be static.
8727 2002-12-15 Jim Meyering <jim@meyering.net>
8729 * Makefile.cfg: Remove rules related to generating m4/jm-glibc-io.m4.
8731 * src/chmod.c, src/copy.c, src/copy.h, src/cp-hash.h, src/csplit.c:
8732 * src/date.c, src/expr.c, src/fmt.c, src/id.c, src/install.c:
8733 * src/ls.c, src/od.c, src/pathchk.c, src/pr.c, src/remove.c:
8734 * src/shred.c, src/sort.c, src/stat.c, src/stty.c, src/sum.c:
8735 * src/tee.c, src/test.c: Remove all uses of `PARAMS'.
8737 * src/remove.c (PARAMS): Remove definition.
8738 * src/sys2.h: Likewise.
8740 * src/ls.c, src/stat.c, src/date.c: Remove declaration of nstrftime.
8741 Include strftime.h instead.
8743 2002-12-14 Jim Meyering <jim@meyering.net>
8745 * Makefile.cfg ($(url_dir_list)): Use .../coreutils, not .../fetish.
8747 * src/system.h [! HAVE_DECL_MEMRCHR]: Declare memrchr.
8748 This is necessary at least for Irix6.5 when using c89.
8749 Reported by Nelson Beebe.
8751 * tests/misc/Makefile.am (TESTS): Add cat-tty-eof.
8753 * tests/misc/cat-tty-eof: New test.
8755 * src/mknod.c (usage): Specify how major and minor mode numbers
8756 are interpreted. Report forwarded by Kristin E Thomas.
8757 * src/mknod.c: Remove now-redundant usage-specifying comment.
8759 2002-12-13 Jim Meyering <jim@meyering.net>
8763 * tests/du/trailing-slash: Allow for a directory of size `0'.
8764 That happens at least on file systems of type tmpfs on linux-2.4.18.
8766 * announce-gen: New script to begin replacing the commands
8767 associated with the rule here...
8768 * Makefile.maint (announcement): Invoke announce-gen.
8769 * Makefile.am (EXTRA_DIST): Add announce-gen.
8771 * tests/cp/preserve-2: New file/test, for latest fix.
8772 * tests/cp/Makefile.am (TESTS): Add preserve-2.
8774 2002-12-11 TAKAI Kousuke <takai@vlsi.kuee.kyoto-u.ac.jp>
8776 Fix a bug whereby cp would fail to parse an option like
8777 --preserve=mode,ownership.
8778 * src/cp.c (decode_preserve_arg): Advance `comma' to
8779 point the character following the comma.
8781 2002-12-11 Jim Meyering <jim@meyering.net>
8783 * src/pathchk.c (NEED_PATHCONF_WRAPPER): Undefine before defining,
8784 in case it's already defined.
8786 2002-12-09 Jim Meyering <jim@meyering.net>
8788 * tests/touch/fail-diag: Don't get a test failure if /no exists.
8789 Instead, evoke a framework failure if /no-$$ exists.
8790 Reported by Michael Stone.
8792 2002-12-08 Jim Meyering <jim@meyering.net>
8794 * src/du.c (lstat) [! LSTAT_FOLLOWS_SLASHED_SYMLINK]:
8795 Define to rpl_lstat, so that even on systems like Solaris 5.8,
8796 du honors (per POSIX) the trailing slash on an argument referring
8797 to a symlink-to-directory.
8799 2002-12-06 Jim Meyering <jim@meyering.net>
8801 * Use autoconf-2.57. Regenerate dependent files.
8802 * Use automake-1.7.2. Regenerate dependent files.
8804 * src/ls.c (gobble_file): Also stat the file if it's a
8805 regular file and --indicator-style=classify (aka -F).
8806 Thanks to Ed Santiago for opening my eyes.
8808 * tests/ls/file-type: New file. Test for the above.
8809 A test to contrast ls -F and ls --indicator-style=file-type.
8810 * tests/ls/Makefile.am (TESTS): Add file-type.
8812 2002-12-04 Jim Meyering <jim@meyering.net>
8814 * tests/ls/follow-slink: Make sure the symlink was created.
8815 Richard Dawe reported that `ln -s link link' succeeds, but creates
8816 no file on systems running some version of the DJGPP libc.
8818 2002-12-03 Jim Meyering <jim@meyering.net>
8820 * src/Makefile.am (AUTOMAKE_OPTIONS): Remove definition (to ansi2knr)
8821 since this package no longer panders to K&R compilers.
8823 2002-12-02 Jim Meyering <jim@meyering.net>
8825 * tests/du/slink: Skip this test if `.' is on a non-local file system.
8827 * tests/Fetish.pm (_at_replace): Do the substitution only if there's
8828 something to replace.
8830 2002-12-01 Jim Meyering <jim@meyering.net>
8832 * src/stat.c: Don't include <string.h> or <ctype.h>.
8833 That's already done via system.h.
8834 * src/dircolors.c: Don't include <ctype.h>.
8836 2002-11-30 Jim Meyering <jim@meyering.net>
8838 * ls.c (gobble_file): Remove the block of code that caused
8839 `ls --color -F symlink-to-dir' to list the files in
8840 `symlink-to-dir/.'. Now, it prints `symlink-to-dir@', (just
8841 like `ls -F symlink-to-dir') but with the addition of highlighting.
8842 Similarly, `ls --color -dF symlink-to-dir' would print
8843 `symlink-to-dir/'; now it prints `symlink-to-dir@'.
8844 Reported by Jeff Sheinberg as Debian bug #168203.
8845 * tests/ls-2/tests (sl-F-color, sl-dF-color): New tests for the above.
8847 ls is now more efficient: with certain options, it no longer needs
8848 to stat each directory entry on systems with valid dirent.d_type.
8849 * src/ls.c (print_dir): Add DT_LNK and DT_REG.
8850 (main): Make --recursive set format_needs_type, not format_needs_stat.
8851 (gobble_file): Remove a FIXME comment, now that it's fixed.
8853 2002-11-24 Jim Meyering <jim@meyering.net>
8855 * src/du.c (du_files): Don't strip any trailing slash.
8856 Rewrite so that `/' is no longer represented internally as
8858 (count_entry): When appending a file name component,
8859 account for the fact that the current path may end in `/'.
8860 François Pinard reported that `du symlink-to-dir/' was not
8861 equivalent to `du symlink-to-dir/.'. Now it is.
8862 * tests/du/trailing-slash: New file/test, for the above fix.
8863 * tests/du/Makefile.am (TESTS): Add trailing-slash.
8865 2002-11-23 Jim Meyering <jim@meyering.net>
8867 * src/tac.c (output): Declare some local variables to be of type size_t,
8868 rather than `int' to avoid warnings from gcc.
8870 2002-11-21 Paul Eggert <eggert@twinsun.com>
8872 * src/ls.c (decode_switches): Use case-sensitive matching to
8873 decode the QUOTING_STYLE environment variable. This is more
8874 consistent with the documentation, and with --quoting-style.
8876 2002-11-21 Martin Buck <martin.buck@ascom.ch
8878 * src/stty.c (struct speeds): Add support for all baud rates defined
8881 2002-11-19 Jim Meyering <jim@meyering.net>
8883 * tests/sum/sysv: Export LC_ALL=C, to avoid failure when
8884 run in a UTF locale. Report and suggested fix by Bruno Haible.
8885 * tests/fmt/basic: Likewise.
8887 2002-11-17 Jim Meyering <jim@meyering.net>
8889 * configure.ac: Update via autoupdate.
8890 Add `AM_GNU_GETTEXT_VERSION(0.11.5)'.
8892 * src/mv.c (movefile): Don't remove trailing slashes from SOURCE.
8893 Reported by Hans Ginzel.
8895 2002-11-15 Jim Meyering <jim@meyering.net>
8897 * Makefile.cfg (gnu_rel_host): Define.
8898 (url_dir_list): Choose from (alpha|ftp).gnu.org depending
8899 on whether $(VERSION) looks like a major release number.
8901 * Makefile.maint (mail_gpg_sign_cookie): Backslash-escape `#'.
8902 (release): Rename from `alpha'.
8903 (alpha): Depend on release.
8905 * Makefile.maint (signatures): Define with ?=, so it's easy to override.
8907 2002-11-14 Jim Meyering <jim@meyering.net>
8909 * Makefile.maint (mail_gpg_sign_cookie): Make optional.
8910 (announcement): Use the new variable.
8912 * Makefile.maint: Sync with Bison, i.e.:
8913 (po-check): Scan .l and .y files instead of the
8914 .c and the .h files that they generate. This fixes the bug
8915 reported by Tim Van Holder in:
8916 <http://mail.gnu.org/pipermail/bison-patches/2002-November/001352.html>
8917 Look for N_ as well as for _. Try to avoid matching #define for
8921 2002-11-12 Jim Meyering <jim@meyering.net>
8923 * src/ls.c (HAVE_SYMLINKS): Remove unnecessary macro definition.
8924 Replace sole use with equivalent `#ifdef S_ISLNK'.
8925 Inconsistency reported by Dmitry V. Levin.
8927 2002-11-11 Jim Meyering <jim@meyering.net>
8929 * src/stat.c (usage): Transform --help items output via s/ - / /,
8930 so that help2man produces properly formatted man pages.
8931 Reported by Herbert Xu as Debian bug #168400.
8933 2002-11-10 Jim Meyering <jim@meyering.net>
8935 * src/ls.c (sighandler): Handle SIGTSTP specially.
8936 Based on suggestions from Solar Designer and Dmitry V. Levin.
8939 * Makefile.cfg (cvs_files): Define. From autoconf.
8940 (local_updates): Likewise.
8942 * src/ls.c (restore_default_color_handler, sigtstp_handler):
8944 (sighandler): New function, based on the one in sort.c.
8945 (main): Use sigaction, if possible; otherwise signal.
8946 Handle these signals:
8947 SIGHUP, SIGINT, SIGPIPE, SIGQUIT, SIGTERM, SIGTSTP.
8948 Don't register our handler if the signal is already being ignored.
8950 * src/dd.c (interrupt_handler): Use raise, rather than kill+getpid.
8951 * src/csplit.c (interrupt_handler): Likewise.
8952 * src/sort.c (sighandler): Likewise.
8953 (main): Declare `i' and `nsigs' to be unsigned, not int.
8955 2002-11-09 Jim Meyering <jim@meyering.net>
8957 ls --color: restore terminal text color upon signal.
8958 * src/ls.c: Include "full-write.h" and <signal.h>.
8959 (restore_default_color, restore_default_color_handler): New functions.
8960 (sigtstp_handler, put_indicator_direct): New functions.
8961 (main) [print_with_color]: Register signal handlers.
8962 Patch mostly by Solar Designer and Stanislav Ievlev.
8964 Update from autoconf.
8965 * Makefile.maint (AMTAR): Remove definition.
8966 (update, cvs-update, po-update, do-po-update): New rules.
8967 (wget-update): Update (thus renaming to cvs-update).
8968 (automake_repo): Use anoncvs@sources.redhat.com.
8970 2002-11-06 Jim Meyering <jim@meyering.net>
8972 * tests/misc/Makefile.am (TESTS): Add printf-hex.
8974 * tests/misc/printf: Be careful to test the code in this package,
8975 not the shell built-in function.
8977 * src/printf.c (print_esc): A hexadecimal escape sequence has
8978 at most two hex. digits, not three. Reported by Padraig Brady.
8979 (usage): Update description.
8980 * tests/misc/printf-hex: New file/test, for the above fix.
8982 2002-10-07 Paul Eggert <eggert@twinsun.com>
8984 Add support for locale-specific size indications (e.g.,
8985 thousands-separators) and for explicit size suffixes on output.
8987 * doc/coreutils.texi (Block size): Say that:
8988 This affects display format as well as block size.
8989 Fractional block counts are rounded up.
8990 ls file size blocksize defaults to 1.
8991 A block size spec preceded by ' generates thousands separators.
8992 A suffix without a preceding integer generates suffixes.
8993 (tail invocation): 32k -> 32 KiB.
8994 (What information is listed): ls -h is now equivalent to
8995 ls --block-size=human, and ls -H is now equivalent to
8996 ls --block-size=si. Displayed file size is now always affected by
8999 * lib/inttostr.c, lib/inttostr.h, lib/imaxtostr.c, lib/offtostr.c,
9000 lib/umaxtostr.c: New files, taken from GNU tar.
9002 * lib/Makefile.am (libfetish_a_SOURCES): Add imaxtostr.c, offtostr.c,
9004 (EXTRA_DIST): Add inttostr.c.
9006 * lib/human.c, lib/human.h: Rewrite to support locale-specific
9007 notations like thousands separators.
9008 Specify what includer of include.h must include beforehand.
9009 (human_group_digits, human_suppress_point_zero, human_autoscale,
9010 human_base_1024, human_SI, human_B): New enum values.
9011 (human_readable): Rename from human_readable_inexact; put the
9012 options before the sizes. All uses changed. The old human_readable
9013 function has been removed; use inttostr.h instead.
9014 (human_options): Renamed from human_block_size, with new signature
9015 that allows block sizes up to UINTMAX_MAX. All callers changed.
9017 * m4/prereq.m4 (jm_PREREQ_HUMAN): Check for locale.h, localeconv,
9018 AC_HEADER_STDBOOL. No need to check for limits.h since it's in
9019 freestanding C89. No need to check for stdlib.h or string.h since
9020 autoconf does this now.
9022 * src/cksum.c (cksum): Use primitives from inttostr.h, not
9023 human.h, to print large numbers simply.
9024 * src/csplit.c (handle_line_error, parse_patterns): Likewise.
9025 * src/dd.c (print_stats, main): Likewise.
9026 * src/df.c (print_header): Likewise.
9027 * src/factor.c (print_factors): Likewise.
9028 * src/ls.c (print_long_format, print_file_name_and_frills): Likewise.
9029 * src/shred.c (dopass): Likewise.
9030 * src/sort.c (checkfp): Likewise.
9031 * src/sum.c (bsd_sum_file, sysv_sym_file): Likewise.
9032 * src/tail.c (xlseek): Likewise.
9033 * src/wc.c (write_counts, wc): Likewise.
9035 * src/df.c (human_output_opts): New var.
9036 (output_block_size): Now uintmax_t, not int, to handle larger
9037 block sizes. All uses changed.
9038 * src/du.c: Likewise.
9039 * src/ls.c: Likewise.
9041 * src/df.c (print_header): In the header line, prefer SI to human
9042 representation if it's shorter; if neither is shorter, try to
9043 intuit what the user would prefer.
9045 * src/expr.c (inttostr): Remove; use new imaxtostr library
9048 * src/ls.c (file_output_block_size): New var, to distinguish
9049 file sizes from other sizes.
9050 (decode_switches): Set it.
9052 * src/shred.c (OUTPUT_BLOCK_SIZE): remove.
9053 (dopass): When printing progress, use floor for what has been done
9054 so far (since we should be conservative there), and ceiling for
9055 what needs to be done (since that's what other programs use).
9057 2002-10-19 Jim Meyering <jim@meyering.net>
9059 * src/pinky.c (print_heading): Align TTY and Name headings.
9060 Reported by Karl Eichwalder.
9062 2002-10-18 Jim Meyering <jim@meyering.net>
9064 * src/split.c (cwrite): Change type of `bytes' parameter to size_t
9065 Remove now-useless cast.
9066 (stdread): Remove function.
9067 (bytes_split): Use size_t instead of int.
9068 Use safe_read, not stdread.
9069 (lines_split): Likewise.
9070 Use memchr rather than a `while' loop.
9071 (line_bytes_split): Use size_t instead of int.
9072 Use safe_read, not stdread.
9073 (main): Add some FIXME comments to remind me to remove casts.
9075 * src/system.h (ST_BLKSIZE): Correct comment describing how to
9076 reproduce HPUX-11 cat failure. From Petter Reinholdtsen.
9078 2002-10-17 Jim Meyering <jim@meyering.net>
9080 Fix a problem that could make e.g., `cat' misbehave on systems which
9081 give invalid (unreasonably large) values for stat.st_blksize.
9082 * src/system.h (ST_BLKSIZE): Ensure that the result is in [1..4MB].
9083 Reported by Petter Reinholdtsen.
9085 2002-10-14 Jim Meyering <jim@meyering.net>
9087 Specifying a printf conversion specifer as nl's separator string
9088 could cause nl to segfault.
9089 * src/nl.c (build_print_fmt): Don't include separator string
9090 in the printf format; it might contain `%'.
9091 Use a better bound on the length of the print_fmt buffer.
9092 (print_lineno): Print the separator here instead.
9093 Reported by Doug Coleman.
9095 * tests/misc/nl: New file/tests, including a test for the above.
9096 * tests/misc/Makefile.am (TESTS): Add nl.
9098 * tests/misc/split-l: New test, to make sure `split --lines=N' works.
9099 * tests/misc/Makefile.am (TESTS): Add split-l.
9101 2002-10-13 Jim Meyering <jim@meyering.net>
9105 * src/du.c (usage): Tweak description of --dereference-args/-D.
9107 * src/du.c (count_entry): Also save cwd when dereferencing (via
9108 --dereference-args, -D) a command-line argument.
9109 Reported by Michal Svec. Based on a patch by Andreas Schwab.
9111 * src/Makefile.am (../AUTHORS): New target/rule.
9113 2002-10-12 Jim Meyering <jim@meyering.net>
9115 * src/paste.c (paste_parallel): Declare local, `delims_saved', to be
9116 of type size_t, since that's the way it's used and avoids a warning.
9118 * src/csplit.c (struct cstring) [len]: Declare to be unsigned int,
9119 since that's how it's always used and avoids a new warning from gcc.
9120 (read_input): Adapt to new safe_read ABI.
9122 * src/cut.c (cut_fields): Add a temporary size_t variable, n_bytes,
9125 * src/pinky.c (print_long_entry): fread returns size_t.
9126 Declare local `bytes' accordingly, to avoid warning.
9128 tail -c +N would perform an extra read after encountering EOF
9129 [this change is analogous (bytes vs. lines) to the one of 2002-01-27]
9130 * src/tail.c (start_bytes): Detect EOF, inform caller.
9131 (tail_bytes): Upon EOF in start_bytes, return immediately.
9132 (file_lines): Reorganize to use memrchr rather than an explicit loop.
9133 Adapt to new safe_read ABI.
9135 2002-10-11 Jim Meyering <jim@meyering.net>
9137 * tests/du/deref: New file/test, for the above fix.
9138 * tests/du/Makefile.am (TESTS): Add deref.
9140 2002-10-10 Jim Meyering <jim@meyering.net>
9142 * tests/ln/Makefile.am (TESTS): Add target-1.
9143 * tests/ln/target-1: New file/test, for the fix on 2002-10-08.
9145 2002-10-09 Jim Meyering <jim@meyering.net>
9147 * tests/cp/backup-is-src: Ensure that certain environment variables
9148 are not set (e.g., SIMPLE_BACKUP_SUFFIX). Reported by Duncan Roe.
9150 * tests/tail-2/big-4gb: Mark this as an expensive test; it would
9151 consume 4GB of disk space on systems without support for sparse files.
9152 Fix a logic error that'd make it `cat err' even though dd didn't fail.
9154 * src/dircolors.hin (.jar): Fix typo: s/;3$/;31/.
9155 Patch by steven@magelico.net, forwarded by Michael Stone.
9157 * tests/ls/dired: Ensure that ls produces English messages.
9158 Patch by Alexey Vyskubov, forwarded by Michael Stone.
9160 2002-10-08 Dmitry V. Levin <ldv@altlinux.org>
9162 * src/ln.c (main): Fix target_directory parsing when n_files == 1.
9164 2002-10-08 Jim Meyering <jim@meyering.net>
9166 * tests/tail-2/big-4gb: Use double quotes around diagnostic.
9167 Fix syntax in test: use =, not ==.
9168 Reported by Bob Proulx.
9169 Change all the rest like this: grep -lR "testing framework'" .\
9170 |xargs perl -pi -e 's/'\''(\$0: failure in testing framework)'\''/"$1"/'
9172 * src/sum.c (sysv_sum_file): Adapt to new safe_read ABI.
9173 * src/tr.c (squeeze_filter, read_and_delete, read_and_xlate): Likewise.
9174 * src/tac.c (save_stdin, tac_stdin_to_mem): Likewise.
9175 * src/wc.c (wc): Likewise.
9177 2002-10-07 Paul Eggert <eggert@twinsun.com>
9180 Don't advance the write pointer past the end of the write buffer.
9181 * src/sort.c (begfield, limfield): Likewise.
9183 2002-10-07 Jim Meyering <jim@meyering.net>
9185 * src/cat.c (simple_cat, cat): Adapt to new safe_read ABI.
9186 * src/head.c (head_bytes, head_lines): Likewise.
9188 2002-10-06 Jim Meyering <jim@meyering.net>
9190 * src/dd.c (scanargs): Ensure that specified block sizes (specified
9191 via ibs=N, obs=N, and bs=N) are no larger than SSIZE_MAX.
9192 (skip, dd_copy): Adapt to new safe_read ABI.
9194 * Makefile.maint (signatures): Define.
9196 (announcement): Depend on $(signatures).
9198 * Makefile.maint (announcement): Output all URLs for detached
9199 signatures, not just the last one from the previous loop.
9201 2002-10-05 Jim Meyering <jim@meyering.net>
9205 * src/remove.c (remove_entry) [ROOT_CAN_UNLINK_DIRS]: With `rm -i DIR',
9206 don't recurse into directory, DIR. Prompted by a report from
9209 * tests/rm/i-no-r: New file/test, for the above fix.
9210 * tests/rm/Makefile.am (TESTS): Add i-no-r.
9212 * tests/tail-2/big-4gb: New file/test, for the fix of 2002-09-27.
9213 * tests/tail-2/Makefile.am (TESTS): Add big-4gb.
9215 2002-10-03 Jim Meyering <jim@meyering.net>
9217 * src/rm.c (AUTHORS): Mark translatable string with `N_ (...)'.
9218 * src/df.c (AUTHORS): Likewise.
9219 * src/du.c (AUTHORS): Likewise.
9220 * src/tail.c (AUTHORS): Likewise.
9221 * src/touch.c (AUTHORS): Likewise.
9223 2002-10-02 Jim Meyering <jim@meyering.net>
9225 * Makefile.am (SUBDIRS): Remove `old'.
9226 (EXTRA_DIST): List the files in old/.
9227 * configure.ac (AC_CONFIG_FILES): Remove old/* names.
9228 Suggestion from Akim Demaille.
9230 2002-10-01 Jim Meyering <jim@meyering.net>
9232 * src/sys2.h (SSIZE_MAX): Define.
9234 2002-09-30 Jim Meyering <jim@meyering.net>
9236 * src/csplit.c: Don't include stdlib.h here. It's already included
9239 2002-09-29 Jim Meyering <jim@meyering.net>
9241 * src/tr.c (find_bracketed_repeat): Rearrange pointer/integer
9242 expression to avoid bogus warning from gcc.
9244 * src/cat.c (simple_cat): Use a temporary to avoid bogus warnings.
9245 (cat): Declare insize and outsize to be of type size_t, not int.
9246 Rearrange pointer/integer expressions to avoid bogus warnings.
9247 (main): Declare insize and outsize to be of type size_t, not int.
9249 * src/tail.c (parse_options): Give a sensible diagnostic for
9250 an invalid byte or line count. Reported by Mikko Tuumanen.
9252 * src/touch.c (main): Split a long line.
9254 * tests/du/Makefile.am (TESTS): Add slink.
9255 * tests/du/slink: New test for system.h change of 2002-08-31.
9257 In move mode, always first try to rename. Before, upon failure to
9258 rename a directory, this code would never attempt to rename any
9259 other file in that directory, but would thenceforth always copy.
9260 On some systems (e.g., NetApp's OnTap-6.4), renaming a directory
9261 may fail with EXDEV, yet renaming files within that directory to
9262 a newly-created destination directory succeeds.
9263 * src/copy.c (copy_internal): Remove local, move_mode;
9264 use x->move_mode instead. Based on a patch from Tom Haynes.
9266 2002-09-28 Jim Meyering <jim@meyering.net>
9268 * src/split.c (FAIL_ONLY_ONE_WAY): New macro.
9269 Factor out some duplication.
9271 [case 'a']: Use strtoul rather than strtol to avoid compiler warnings.
9273 * src/sort.c (begfield, limfield): Rearrange comparisons to avoid
9275 (fillbuf, keycompare): Cast literal `-1' to size_t in comparisons,
9276 to avoid compiler warnings.
9278 * src/shred.c (dopass): Use a uintmax_t temporary to avoid bogus
9281 Fix things so `mkdir -p' can create very deep directories, e.g.,
9282 mkdir -p $(perl -e 'print "a/" x 40000') now works.
9283 * src/mkdir.c (main): For --parents (-p), call make_path with the
9284 entire directory name, so we don't ever require that file operations
9285 like stat or chmod be performed on the entire command line argument.
9286 * makepath.c (make_path): Restore umask *before* creating the final
9289 2002-09-27 Andreas Schwab <schwab@suse.de>
9291 * src/tail.c (tail_bytes): Change type of bytes_remaining to off_t
9292 to avoid overflow. Reported by Hans Lermen.
9294 2002-09-26 Jim Meyering <jim@meyering.net>
9296 * src/install.c (get_ids): Use strtoul, not strtol. Remove some casts.
9298 2002-09-25 Jim Meyering <jim@meyering.net>
9300 * src/test.c (eaccess): Change type of local `euid' from int to uid_t
9301 and add a cast, to avoid a warning about `signed and unsigned type in
9302 conditional expression'.
9304 2002-09-22 Jim Meyering <jim@meyering.net>
9306 * src/rmdir.c: Include "dirname.h", for declaration of
9307 strip_trailing_slashes.
9309 * src/stat.c (PRIdMAX, PRIuMAX): Remove definitions.
9310 Now they're defined through system.h.
9312 * src/cp-hash.c, src/dd.c, src/df.c, src/du.c, src/ls.c,
9313 * src/stat.c, src/wc.c: Remove all inclusions of inttypes.h,
9314 since it's already included from sys2.h via system.h.
9316 * Use automake-1.6f. Regenerate dependent files.
9318 * src/Makefile.am (PERL): Remove duplicate definition.
9320 fmt's -s, -t, -c options didn't work properly for long lines.
9321 Since get_line may end up calling put_paragraph (for long lines),
9322 be sure to set global, `other_indent', before it is used there.
9324 * src/fmt.c (set_other_indent): New function, factored out of...
9325 (get_paragraph): ... here. Call it.
9326 (get_line): Call set_other_indent before calling flush_paragraph,
9327 which calls fmt_paragraph, which in turn calls put_paragraph,
9328 which uses other_indent.
9330 * tests/fmt/Makefile.am (TESTS): Add long-line.
9331 * tests/fmt/long-line: New file/test, for the above fix.
9333 2002-09-21 Jim Meyering <jim@meyering.net>
9335 * src/od.c: No longer include deprecated <values.h>.
9336 It was required solely for now-removed reference to BITSPERBYTE.
9337 * src/install.c: Likewise.
9338 Suggestion from Bruno Haible.
9340 2002-09-06 Andreas Schwab <schwab@suse.de>
9342 `rmdir -p dir-specified-with-trailing-slash/' would fail.
9343 * src/rmdir.c (remove_parents): Strip trailing slashes.
9345 2002-09-20 Jim Meyering <jim@meyering.net>
9347 * tests/rmdir/t-slash: New file/test, for the above fix.
9348 * tests/rmdir/Makefile.am (TESTS): Add t-slash.
9350 * Makefile.maint (announcement): Arrange to gpg-sign the message.
9351 Add a URL for each detached signature file.
9353 2002-09-07 Bruno Haible <bruno@clisp.org>
9355 * configure.ac: Add need-ngettext to AM_GNU_GETTEXT invocation.
9357 2002-09-18 Jim Meyering <jim@meyering.net>
9359 `od -t x8' used the wrong (`l'-prefixed) printf format.
9360 Likewise for the o8 and u8 formats.
9361 * src/od.c (ISPEC_TO_FORMAT): Define macro.
9362 (decode_one_format): Use PRIdMAX, PRIoMAX, etc. for LONG_LONG.
9363 Reported by Arun Sharma.
9365 2002-09-17 Jim Meyering <jim@meyering.net>
9367 * src/sys2.h (PRIdMAX, PRIoMAX, PRIuMAX, PRIxMAX): Define if necessary.
9368 From gettext's intl/loadmsgcat.c.
9370 * tests/od/x8: New file/test, for the above fix.
9371 * tests/od/Makefile.am (TESTS): Add x8.
9373 2002-09-15 Jim Meyering <jim@meyering.net>
9375 * Use autoconf-2.54. Regenerate dependent files.
9377 * src/csplit.c (get_format_width): Add cast to avoid
9378 warning about `signed and unsigned type in conditional expression'.
9380 2002-09-14 Jim Meyering <jim@meyering.net>
9382 * src/who.c (print_user): Change type of local to size_t
9383 to avoid warnings about `comparison between signed and unsigned'.
9384 * src/ptx.c (generate_all_output): Likewise.
9386 * src/dd.c (main, skip): Add casts to avoid warnings about
9387 `comparison between signed and unsigned'.
9389 * src/id.c (print_full_info, print_group_list): Add casts to avoid
9390 warnings about `signed and unsigned type in conditional expression'.
9392 * src/md5sum.c: Change type of global, digest_hex_bytes, to size_t
9393 to avoid warnings about `comparison between signed and unsigned'.
9394 (split_3): Change parameter names to be readable and add comment.
9395 Clean up the test for whether a line may be ignored.
9397 2002-09-13 Jim Meyering <jim@meyering.net>
9399 * src/printf.c (main): Handle leading command line argument of `--'.
9400 Reported by Raul: DervishD <raul@pleyades.net>
9401 * tests/misc/printf: New file: test for the above.
9402 * tests/misc/Makefile.am (TESTS): Add printf.
9404 * src/date.c (usage): Explain that %S's range of [0..60] is required --
9405 rather than 0..59 -- to accommodate the occasional positive leap second.
9406 Reported by Richard Neill.
9408 2002-09-12 Jim Meyering <jim@meyering.net>
9410 * src/Makefile.am (nanosec_libs): Define.
9411 (sleep_LDADD, tail_LDADD): Use it here.
9413 Factor nanosleep-related code into ../lib/xnanosleep.c.
9414 * src/sleep.c: Include xnanosleep.h.
9415 Factor out fenv.h-related code.
9416 (timespec_subtract): Remove function.
9417 (main): Remove code that deals with computing start and stop times
9418 as well as the loop around nanosleep. Now that's in xnanosleep.c.
9420 Allow S (in --sleep-interval=S) to be a floating point value.
9421 * src/tail.c: Include xnanosleep.h and xstrtod.h.
9422 Move declaration of global variable, sleep_interval, to ...
9424 (usage): Update description of --sleep-interval option.
9425 (tail_forever): New parameter, sleep_interval. Update caller.
9426 Use xnanosleep, rather than sleep.
9427 (parse_options): New parameter, sleep_interval. Update caller.
9428 Use xstrtod, now that we accept floating point values.
9429 Prompted by a patch from Augey Mikus.
9431 2002-09-06 Jim Meyering <jim@meyering.net>
9433 * src/remove.c (prompt): Change comment to give a better note to
9434 translators. From Michael Piefel.
9436 2002-09-02 Jim Meyering <jim@meyering.net>
9438 * README: A good problem report/patch includes diffs against
9439 the most recent test release.
9441 * src/pathchk.c (NEED_PATHCONF_WRAPPER): Define.
9442 (pathconf_wrapper): Define only if NEED_PATHCONF_WRAPPER is set.
9444 * src/kill.c (print_table_row): Use an unsigned type for widths
9445 to avoid warning about comparison between signed and unsigned.
9446 (list_signals): Likewise.
9448 * src/od.c (skip): Add a cast to avoid warning about comparison
9449 between signed and unsigned.
9450 * src/install.c (get_ids): Likewise. Also rearrange range-checking
9451 comparisons to make them more readable.
9453 2002-09-01 Jim Meyering <jim@meyering.net>
9457 2002-08-31 Jim Meyering <jim@meyering.net>
9459 Symlinks were always reported as using 0 blocks.
9460 * src/system.h (ST_NBLOCKS): Don't depend on file type.
9461 This reverts the change of 2000-01-30.
9462 Based on a report and patch from Neil Brown via Michael Stone.
9463 This fixes Debian Bug#156358.
9465 * Most files: Change `exit (0)' to `exit (EXIT_SUCCESS)',
9466 `exit (1)' to `exit (EXIT_FAILURE)', and
9467 `usage (1)' to `usage (EXIT_FAILURE)'.
9469 * chgrp.c, chmod.c, chown.c, chroot.c, cp.c, date.c, dd.c, du.c,
9470 * hostname.c, id.c, install.c, ln.c, mkdir.c, mkfifo.c, mknod.c,
9471 * nice.c, pinky.c, printf.c, pwd.c, shred.c, sleep.c, stty.c,
9472 * su.c, tac-pipe.c, tail.c, tee.c, touch.c, uname.c, uptime.c,
9473 * users.c, who.c: Change `error (1, ...' to `error (EXIT_FAILURE, ...'.
9474 But don't change `error (0, ...' to `error (EXIT_SUCCESS, ...', since
9475 error never exits successfully.
9477 2002-08-29 Jim Meyering <jim@meyering.net>
9479 * src/remove.c (remove_cwd_entries): Use closedir (not CLOSEDIR)
9480 when ignoring any return value.
9482 * src/remove.c (remove_cwd_entries): Detect and diagnose readdir
9483 failures. On some systems (at least EMC Celerra and Solaris5.8),
9484 this appears to be necessary.
9485 (is_empty_dir): Likewise. Also, always close directory handle.
9486 * src/ls.c (print_dir): Likewise.
9487 (print_dir): Rename local variable: reading -> dirp.
9488 Reported by Mike Coleman.
9490 2002-08-28 Jim Meyering <jim@meyering.net>
9492 * src/remove.c (remove_cwd_entries): Use CLOSEDIR, not closedir.
9493 Give a diagnostic and fail if closedir fails.
9495 2002-08-26 Jim Meyering <jim@meyering.net>
9497 * Makefile.am (THANKS-to-translators): New rule.
9498 (EXTRA_DIST): Add both THANKS-to-translators and THANKStt.in.
9499 * THANKStt.in: New file.
9501 * src/cat.c (close_stdout_wrapper): New, kludgey, function and
9503 (main): Register it with atexit.
9504 Close STDOUT_FILENO, to avoid a problem when writing to
9505 /dev/audio on at least Solaris 5.7 and 5.8 systems.
9506 Reported by Shing-Shong Shei.
9508 2002-08-25 Jim Meyering <jim@meyering.net>
9510 * src/cat.c (main): Close STDIN_FILENO rather than a literal `0'.
9511 * src/tac.c (main): Likewise.
9512 * src/tail.c (main): Likewise.
9513 * src/tee.c (main): Likewise.
9514 * src/tr.c (main): Likewise.
9515 * src/wc.c (main): Likewise.
9517 2002-08-20 Jim Meyering <jim@meyering.net>
9519 * tests/mv/setup: Rewrite not to use `: ${VAR=not_set}' paradigm.
9521 2002-08-10 Paul Eggert <eggert@twinsun.com>
9523 * src/nohup.sh: Don't use "exec --"; it's not portable and
9524 shouldn't be needed.
9526 2002-08-09 Jim Meyering <jim@meyering.net>
9528 * src/pr.c (main): Don't ignore -COLUMN if it's the last option.
9529 (usage): Clarify help text for the -COLUMN option.
9530 Patch by Padraig Brady.
9531 * tests/pr/Test.pm [col-last]: New test for the above.
9533 * configure.ac: Start with version 4.5.1, chosen so that it's larger
9534 than the latest version numbers of the component packages.
9536 * man/Makefile.am (check-x-vs-1): Set and export PATH so we use
9539 2002-08-08 Jim Meyering <jim@meyering.net>
9541 * src/date.c: Guard inclusion of <langinfo.h> with
9542 `#if HAVE_LANGINFO_CODESET', not `#if HAVE_LANGINFO_H'.
9543 * src/sort.c: Likewise.
9544 Patch by GOTO Masanori.
9546 2002-08-05 Paul Eggert <eggert@twinsun.com>
9548 Fix some minor time-related bugs with POSIX time arguments.
9549 Some valid time stamps were being rejected (notably -1, and
9550 time stamps before 1900 on 64-bit hosts). And some invalid
9551 time stamps were being accepted, e.g. September 31.
9553 * src/date.c (main): Adjust to posixtime signature change.
9554 * src/touch.c (main): Likewise. Remove unnecessary initialization.
9555 Use localtime, not posixtm, to warn about obsolete "touch".
9557 2002-08-05 Jim Meyering <jim@meyering.net>
9559 * tests/misc/Makefile.am (TESTS): Add nice and pathchk1.
9561 2002-08-04 Jim Meyering <jim@meyering.net>
9563 * src/Makefile.am (check-README): New target/rule.
9564 (check): Depend on it.
9566 * configure.ac (AC_CONFIG_FILES): Add old/Makefile and old/*/Makefile.
9568 2002-08-03 Jim Meyering <jim@meyering.net>
9570 * Makefile.am (SUBDIRS): Add old.
9571 * old/: New directory, containing legacy ChangeLog* and NEWS files
9572 from the fileutils, sh-utils, and textutils packages.
9574 * src/Makefile.am (AM_INSTALLCHECK_STD_OPTIONS_EXEMPT): Set to false.
9576 2002-08-02 Paul Eggert <eggert@twinsun.com>
9578 * NEWS, doc/coreutils.texi: uniq now obeys LC_COLLATE.
9580 * src/uniq.c: Include hard-locale.h, xmemcoll.h.
9581 (hard_LC_COLLATE): New var.
9582 (different): Args are now char *, not const char *.
9583 Use xmemcoll instead of memcmp to compare lines, so that
9584 LC_COLLATE has effect. However, use memcmp if it is an
9586 (check_file): Do not include newline in comparison, so that
9587 xmemcoll has a byte to stomp on temporarily.
9588 (main): Set hard_LC_COLLATE.
9590 2002-07-29 Jim Meyering <jim@meyering.net>
9592 * Makefile.am (SUBDIRS): Remove djgpp, for now.
9594 2002-07-20 Jim Meyering <jim@meyering.net>
9596 * Makefile.am (false.c): Convert only the final EXIT_SUCCESS
9597 into EXIT_FAILURE. Otherwise, false --help and false --version
9600 2002-07-08 Jim Meyering <jim@meyering.net>
9602 * src/Makefile.am (uninstall-local): Search for @GNU_PACKAGE@,
9603 rather than the hard-coded `sh-utils'.
9605 2002-07-01 Jim Meyering <jim@meyering.net>
9607 * configure.ac: Merge the three files from fileutils,
9608 textutils, and sh-utils.
9609 * Makefile.am: Likewise.
9610 * src/Makefile.am: Likewise.
projects / platform / upstream / coreutils.git / blob