1 2006-07-26 Jim Meyering <jim@meyering.net>
3 Prepare for the above change.
4 * src/ls.c [struct fileinfo] (stat_ok): Rename from stat_failed,
5 and adjust uses. From a patch by Paul Eggert.
7 2006-07-26 Jim Meyering <jim@meyering.net>
9 * src/ls.c: Correct indentation/formatting in a few places.
11 2006-07-25 Paul Eggert <eggert@cs.ucla.edu>
13 * tests/cp/fail-perm: Use "chmod 0500" rather than "chmod 500".
14 Problem report and fix from Bob Proulx.
15 * NEWS: Clarify the "chmod 0500" news, and correct the vague
16 statements about compatibility with BSD.
18 2006-07-25 Jim Meyering <jim@meyering.net>
20 * src/ls.c (gobble_file): When handling a stat-failed entry,
21 print the entry name not the absolute_name -- to be consistent
23 * tests/ls/stat-failed: Update accordingly.
25 * src/ls.c: Add parens around the new uses of ?: ternary operator.
27 * src/dircolors.hin: Mention that ORPHAN refers not just to dangling
30 Get --dired offsets right when handling stat-failed entries.
31 * src/ls.c (print_long_format): Be careful to increment P by the
32 appropriate amount, even when inode_number_width and nlink_width
34 * tests/ls/stat-failed: Test for the above.
36 * src/ls.c (gobble_file) [USE_ACL]: Don't use-uninitialized the
37 have_acl member. That would happen for a directory with both a
38 non-stat'able entry and one with an ACL.
40 * src/ls.c (gobble_file): Make it so failure to stat a
41 non-command-line file provokes an exit status of 1, not 0.
42 Say "cannot access" rather than "cannot stat".
43 * tests/ls/stat-failed: New file/test, for the above.
44 * tests/ls/Makefile.am (TESTS): Add stat-failed.
45 * tests/ls-2/tests (no-a-isdir-b): Update to reflect addition
46 of "cannot access " to diagnostic.
48 * src/ls.c: Declare stat_failed to be "bool", not "int" everywhere.
50 * src/ls.c [enum filetype] (command_line): Remove member. Not needed.
51 Replace all occurrences of "type == command_line" with the
52 equivalent, "command_line_arg".
54 * src/ls.c: Apply the stat-failed parts of Red Hat's
55 coreutils-selinux.patch. From Ulrich Drepper.
56 This makes it so files not mentioned on the command line (e.g.,
57 names read from a directory that *is* mentioned on the command
58 line) for which stat fails are still listed. With --color,
59 such files are colored just like ORPHANs (aka dangling symlinks).
61 * src/df.c (n_valid_args): Declare global to be static.
63 2006-07-24 Jim Meyering <jim@meyering.net>
65 * tests/ls/stat-dtype: Skip this test on reiserfs, since that file
66 system lacks d_type support.
68 2006-07-22 Paul Eggert <eggert@cs.ucla.edu>
70 * man/chmod.x: Update to reflect recent changes to coreutils.texi.
72 2006-07-21 Jim Meyering <jim@meyering.net>
74 * src/su.c (usage): Correct typo in --help output: s/commmand/command/
75 Reported by Tim Waugh.
76 Also remove the comment duplicating much of --help output.
78 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): Reposition this new
79 name so the list remains alphabetized.
81 Fix another bug: ls --indicator-style=file-type would call
82 stat for a symlink, even though it wasn't always needed.
83 In some cases, that unnecessary stat would cause ls to fail.
84 * src/ls.c (gobble_file): Don't treat symlinks specially (in
85 requiring a stat syscall). Remove the offending exclusion.
87 * NEWS: Mention the fix.
89 * tests/ls/stat-dtype: New file/test, for the above fix.
90 Also exercises the new df feature, below.
92 * src/df.c (main): Fail and don't print the headers if no
93 file system is processed. This makes it easy to test whether
94 a specified directory is on a file system of a given type or types.
95 Otherwise, applications would have had to parse df's output.
96 E.g., is "." either ext3 or reiserfs: df -t ext3 -t reiserfs .
98 Fix a bug: ls --file-type worked like --indicator-style=slash,
99 rather than like --indicator-style=file-type.
100 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): New enum member.
101 (long_options): Map "file-type" to FILE_TYPE_INDICATOR_OPTION,
103 (decode_switches): Handle new case: FILE_TYPE_INDICATOR_OPTION.
104 * NEWS: Mention the fix.
105 * tests/ls-2/tests (file-type): New test, for the above fix.
107 2006-07-19 Jim Meyering <jim@meyering.net>
109 * src/ls.c (print_dir): Give a better diagnostic for failed opendir.
111 * Makefile.am (EXTRA_DIST): Add build-aux/vc-list-files.
113 2006-07-16 Paul Eggert <eggert@cs.ucla.edu>
115 * NEWS: chmod, install, and mkdir now leave setgid and setuid bits
116 of directories alone unless you specify them explicitly.
117 install and mkdir now implement X correctly.
118 install now creates parent directories with mode 755, without
119 changing their owner or group.
120 * src/chmod.c (process_file): Adjust to mode_adjust API change.
121 * src/install.c: Include mkancesdirs.h.
122 (announce_mkdir, make_ancestor): New functions.
123 (DEFAULT_MODE): New macro, specifying initial value of 'mode'.
125 (dir_mode, dir_mode_bits): New vars.
126 (main): Set dir modes separately from nondir, so that the X
127 op of -m works correctly.
128 (main): Remove cwd_errno cruft, since make_dir_parents no longer
129 affects cwd. Adjust to new make_dir_parents API.
130 (install_file_in_file_parents): 2nd arg is now char *, not char
131 const *. Use mkancesdirs instead of rolling our own code.
132 (change_attributes): Don't worry about AFS, since that kludge
133 should not be needed any more.
134 * src/mkdir.c (struct mkdir_options): New struct.
135 (announce_mkdir, make_ancestor): New functions.
136 (main): Use them. Adjust to mode_adjust API change. Stick with
137 umask 0. Use make_dir_parents for all the work.
138 * src/mkfifo.c (main): Adjust to new mode_adjust API.
139 * src/mknod.c (main): Likewise.
140 * tests/chmod/setgid: Do the setgid test instead of bailing.
141 * tests/mkdir/p-3: Remove re_protect case that no longer applies.
142 GNU chmod now behaves like other versions of chmod.
143 * tests/mkdir/perm: Add a test for the X bug.
145 2006-07-14 Paul Eggert <eggert@cs.ucla.edu>
147 * src/base64.c (do_decode): Output to parameter OUT, not to stdout.
148 This doesn't fix any bugs, since OUT always equals stdout, but it
149 makes the code easier to understand.
151 2006-07-14 Jim Meyering <jim@meyering.net>
153 * Makefile.maint (CVS_LIST): Use new file, build-aux/vc-list-files,
154 rather than open-coding it. Now supports mercurial, too.
155 * .hgignore: New file.
156 * Makefile.am (EXTRA_DIST): Add .hgignore, which ignores nearly
157 all generated files, including ones like configure and po/*.po
158 that are currently version-controlled in cvs.
160 * Makefile.am (EXTRA_DIST): Add a few more .??* files.
161 They've been in CVS, just haven't been distributed before this.
162 Distribute ChangeLog-2005, too.
163 (MAINTAINERCLEANFILES): Add THANKS-to-translators.
165 2006-07-11 Paul Eggert <eggert@cs.ucla.edu>
167 * src/system.h: Assume <dirent.h> exists, since gnulib assumes
170 2006-07-09 Jim Meyering <jim@meyering.net>
172 * tests/mv/dir2dir: Adjust so failing with ENOTEMPTY is ok, too.
173 That happens with Linux/tmpfs.
174 * tests/mv/Makefile.am (TESTS): Add dir2dir.
176 2006-07-09 Paul Eggert <eggert@cs.ucla.edu>
178 Adjust to recent updates from gnulib.
179 * src/dd.c (apply_translations): Use toupper rather than
180 islower followed by toupper; it's simpler and typically
181 faster now that we assume at least C89 semantics. Similarly
183 * src/sort.c (inittables): Likewise.
184 * src/expand.c (expand): Don't assume that isprint etc. return
185 booleans (needed for pre-C99 hosts).
186 * src/fmt.c (check_punctuation): Likewise.
187 * src/ptx.c (initialize_regex, fix_output_parameters): Likewise.
188 * src/tr.c (is_char_class_member): Likewise.
189 * src/unexpand.c (unexpand): Likewise.
190 * src/join.c (is_blank): Remove; no longer needed. All uses
191 replaced by isblank (to_uchar (...)).
192 * src/pinky.c (create_fullname): Don't assume char is unsigned.
193 * src/printf.c (print_esc): Likewise.
194 * src/ptx.c (SKIP_NON_WHITE, SKIP_WHITE, SKIP_WHITE_BACKWARDS):
195 (copy_unescaped_string): Likewise.
196 * src/stat.c (print_it): Likewise.
197 * src/system.h (_D_EXACT_NAMELEN): Renamed from NLENGTH, for
198 convenience on GNU systems. All uses changed. Don't bother
199 looking for any dirent.h substitute other than ndir.h.
200 (D_INO): Remove unnecessary parentheses.
201 (IN_CTYPE_DOMAIN, ISGRAPH, ISPRINT, ISALNUM, ISALPHA):
202 (ISCNTRL, ISLOWER, ISPUNCT, ISSPACE, ISUPPER, ISXDIGIT):
203 (ISDIGIT_LOCALE, TOLOWER, TOUPPER): Remove. All uses changed
204 to ctype.h equivalents.
205 (isblank): Renamed from ISBLANK. Check for HAVE_DECL_ISBLANK too.
208 2006-07-08 Jim Meyering <jim@meyering.net>
210 * tests/mv/dir2dir: New file, test for 2006-07-05 fix in copy.c.
212 * Makefile.maint (sc_the_the): New rule.
214 * src/dd.c (skip): Remove one of two adjacent "the"s in a comment.
215 * tests/Coreutils.pm (run_tests): Remove one of two adjacent "then"s
218 2006-07-07 Jim Meyering <jim@meyering.net>
220 * NEWS: Mention that mv can now remove an empty destination directory,
221 and give an example. Prompted by a report from Florent Bayle.
223 2006-07-05 Jim Meyering <jim@meyering.net>
225 * src/ls.c (usage): Correct the description of -G: it is useful
226 only in a long listing. Reported by Martin Pool in
227 <https://launchpad.net/distros/ubuntu/+source/coreutils/+bug/51653>.
229 * man/chmod.x: Correct the description of the sticky bit. Reported
230 by Chris Moore via Ian Jackson in <http://bugs.debian.org/376745>.
232 * src/copy.c (copy_internal): Don't work around old NFS clients like
233 SunOS-4.1.4 and Irix 5.3 that set errno to values like EIO and
234 ENOTEMPTY upon failed rename. Otherwise, we risk misinterpreting
235 a banal failure as a recursive move-into-self failure.
236 Reported by Florent Bayle in <http://bugs.debian.org/376749>.
238 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
240 2006-07-03 Jim Meyering <jim@meyering.net>
242 Plug another unusual leak.
243 (AD_mark_helper): Free malloc'd filename if hash_insert says
244 that string is already in the hash table.
246 The dev/inode of the topmost directory in each hierarchy were not
248 * src/remove.c (remove_cwd_entries): Don't call cycle_check here.
249 (AD_push): Call it from here instead.
252 * src/remove.c (AD_stack_clear): New function.
254 (AD_pop_and_chdir): Free *prev_dir just before longjmp.
256 * tests/Makefile.am, tests/*/Makefile.am: (TESTS_ENVIRONMENT):
257 Add $VG_PATH_PREFIX as a prefix to $PATH
259 * tests/envvar-check (vars): Add CDPATH and POSIXLY_CORRECT.
260 * tests/Makefile.am (evar-check): Remove rule.
261 (EXTRA_DIST): Remove .env-warn.
262 * tests/.env-warn: Remove file. No longer used.
263 Suggestion from Eric Blake.
265 2006-07-02 Paul Eggert <eggert@cs.ucla.edu>
267 * src/system.h: Include <stdint.h> unconditionally, since we
268 now assume the stdint module.
270 2006-07-01 Paul Eggert <eggert@cs.ucla.edu>
272 * NEWS: With no operand, 'tail -f' now silently ignores the '-f'
273 only if standard input is a FIFO or pipe and POSIXLY_CORRECT is set.
274 * src/tail.c (main): Implement this.
275 * tests/tail/Test.pm (f-pipe-1): Renamed from f-1.
276 (test_vector): Set POSIXLY_CORRECT for the f-pipe-* tests.
278 2006-07-01 Jim Meyering <jim@meyering.net>
280 * src/ln.c (do_link): Use new, shorter URL, for ag-review link.
282 * .x-sc_require_config_h: Add ^lib/xstrtold\.c$, so make distcheck
285 2006-06-30 Paul Eggert <eggert@cs.ucla.edu>
287 * NEWS: seq now uses long double internally rather than double.
288 It now defaults to a minimal fixed point format if possible.
289 It lets you use %a, %A, %E, %F, %G.
290 * src/Makefile.am (seq_LDADD): Remove $(SEQ_LIBM); add $(POW_LIB).
291 * src/seq.c: Don't include <math.h> or <xstrtol.h>; no longer needed.
292 (isfinite) [!defined isfinite]: New macro.
293 (separator, terminator): Now points to const.
294 (first, step, last): Remove.
295 (usage): Update to match new behavior.
296 (struct operand, operand): New type.
297 (scan_arg): Renamed from scan_double_arg, since we no longer use double.
299 Compute and return a value of type operand, not double.
300 (long_double_format): Renamed from valid_format, and now returns a
301 new format with an "L" added if needed, if the original format was
302 valid. Allow %a, %A, %E, %F, and %G formats.
303 (print_numbers): Take numeric values as args rather than from globals.
304 Print long double, not double.
305 (get_width_format): Remove.
306 (get_default_format): New function.
307 (main): Implement new way of calculating default format.
308 Don't worry about locale's representation of the decimal point, since
309 the arguments are always processed in the C locale.
310 * tests/seq/basic (neg-2): Adjust to new default format.
311 (eq-wid-1, eq-wid-2): Resurrect these tests, since the new
312 implementation should do the right thing.
314 2006-06-30 Jim Meyering <jim@meyering.net>
316 * tests/stty/basic-1: Work around an intermittent test failure
317 on HP-UX 11.11. Report and analysis from Bob Proulx.
318 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7475
320 2006-06-28 Paul Eggert <eggert@cs.ucla.edu>
322 * NEWS: Support obsolete usages like "sort +1 -2" even when
323 conforming to POSIX 1003.1-2001, since this is a pure extension to
324 POSIX. Problem reported by Christian in:
325 http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00220.html
326 * src/sort.c (main): Implement this.
328 * src/system.h (CLOSEDIR): Remove. All uses changed to closedir.
329 Autoconf 2.60 says this stuff was obsolete.
331 2006-06-28 Jim Meyering <jim@meyering.net>
333 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
335 2006-06-28 Bob Proulx <bob@proulx.com> (tiny change)
337 * tests/mv/i-link-no: Work around HP-UX /bin/sh tracing problem
338 (set -x when VERBOSE=yes) when stderr is redirected before stdout
339 causing shell tracing of the stdout redirection to be written to
340 the stderr file. Avoid problem and test failure on HP-UX by
341 redirecting stderr last.
342 * tests/dd/unblock-sync: Order shell file redirections for
343 stderr and stdout in the common style.
346 2006-06-27 Jim Meyering <jim@meyering.net>
348 * tests/misc/cat-proc: Try to avoid any spurious numeric
349 differences in frequently-changing /proc/cpuinfo.
350 Reported by Nelson Beebe.
352 2006-06-26 Jim Meyering <jim@meyering.net>
354 Attempt rmdir (actually, unlinkat-with-AT_REMOVEDIR) upon any
355 fd_to_subdirp failure, not just when errno == EACCES.
356 * src/remove.c (remove_dir): Use unlinkat-with-AT_REMOVEDIR, not
357 rmdir, here, even though rmdir may happen to be adequate.
359 * NEWS: rm no longer fails to remove an empty, unreadable directory
360 * src/remove.c (remove_cwd_entries): If we can't open a directory,
361 and the failure is not being ignored, try to remove the directory
362 with rmdir (aka unlinkat-with-AT_REMOVEDIR), in case it's empty.
363 Problem report and test case from Paul Eggert in
364 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7425>.
366 * tests/rm/empty-inacc: New test, for the above.
368 Avoid a segfault for wc --files0=- < /dev/null.
369 * src/wc.c (compute_number_width): Return right away if nfiles == 0.
371 2006-06-25 Jim Meyering <jim@meyering.net>
373 * NEWS: wc accepts a new option --files0-from=FILE, where FILE
374 contains a list of NUL-separated file names.
376 * src/wc.c: Include "readtokens.h".
377 (usage): Describe the new option, and adjust the `Usage':
378 with this option, no FILE may be specified on the command line.
379 (main): Handle the new option.
380 * tests/misc/wc-files0: New tests, for the above.
381 * tests/misc/wc-files0-from: Likewise.
382 * tests/misc/Makefile.am (TESTS): Add wc-files0.
384 2006-06-24 Jim Meyering <jim@meyering.net>
386 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
388 2006-06-22 Jim Meyering <jim@meyering.net>
390 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
391 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
393 2006-06-19 Jim Meyering <jim@meyering.net>
395 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
396 so this check is not run as part of "make distcheck".
398 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
400 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
402 2006-06-18 Jim Meyering <jim@meyering.net>
404 * tests/misc/pwd-long: Make error output a little clearer.
406 2006-06-17 Jim Meyering <jim@meyering.net>
408 * tests/rm/inaccessible: Skip this test on systems without openat
409 support. Reported by Bob Proulx.
411 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
413 * tests/misc/mknod: Improve permission checks to handle
414 running mkdir test in set-gid directories.
416 2006-06-14 Jim Meyering <jim@meyering.net>
418 * tests/du/basic: Revamp not to hard-code file system block sizes.
420 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
422 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
425 2006-06-11 Jim Meyering <jim@meyering.net>
427 * .gitignore: New file.
428 * Makefile.am (EXTRA_DIST): Add .gitignore.
430 Setting TIME_STYLE=long-iso in the environment would make the
431 cp/same-file test fail.
432 * tests/envvar-check (vars): Add TIME_STYLE to the list.
433 * tests/cp/same-file: Revert last change.
434 Source the envvar-check script, to ensure that TIME_STYLE
435 settings don't affect these tests.
437 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
439 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
440 uses POSIX time stamp formats. Problem reported by John Nixon in
441 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
443 2006-06-10 Jim Meyering <jim@meyering.net>
445 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
447 Require a "Version N.M" line at the top of the ChangeLog
448 file only when making the actual release, not when running
450 * Makefile.maint (maintainer-distcheck): Don't depend on
452 (alpha beta major): Depend on it here, instead.
454 2006-06-08 Jim Meyering <jim@meyering.net>
456 Ensure that cat works with any of the options, -A -v -e -E -T,
457 when applied to files in /proc and /sys, even when the FIONREAD
458 ioctl produces nonsensical results. Before this change, cat would
459 produce no output (or truncated output), for some linux kernels.
461 * src/cat.c (write_pending): New function, factored out of cat.
462 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
463 that there are bytes to read. Some versions of linux-2.6.16 do that.
464 Write any pending output before returning.
465 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
466 * NEWS: Mention this bug fix.
467 * tests/misc/cat-proc: New file. Test for the above.
468 * tests/misc/Makefile.am (TESTS): Add cat-proc.
470 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
472 * src/expr.c (eval4): Detect overflow properly when multiplying
475 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
477 * NEWS: The 'expr' command now detects and reports integer overflow.
478 (It would be better to use extended precision instead, but that
480 * src/expr.c (integer_overflow): New function.
481 (eval4, eval3): Check for integer overflow.
483 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
485 Fix problems when building with Solaris/SVR4/etc. make, which uses a
486 different and somewhat bogus implementation of VPATH. In the
487 directory tests/misc, rename tests whose names might appear in the
488 Automake-generated rules. For example, we can't use a test named
489 'test', since Automake generates a rule that contains the text
490 "if test -f ./$$tst; ...", and this might expand to something like
491 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
492 which executes the 'test' script rather than the 'test' command.
493 * tests/misc/false-status: Renamed from tests/misc/false.
494 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
495 * tests/misc/sort-merge: Renamed from tests/misc/sort.
496 ($prog): Set to 'sort' rather than to $PROG.
497 * tests/misc/test-diag: Renamed from tests/misc/test.
498 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
499 in case Solaris make has prepended the directory.
500 (TESTS): Adjust to above renamings.
501 * tests/misc/expand: Don't assign to PROG; no longer needed
502 now that Makefile.am sets PROG to the basename.
503 * tests/misc/fold: Likewise.
505 2006-06-03 Jim Meyering <jim@meyering.net>
507 Make `cp --link --no-dereference' work also on systems where the
508 link system call cannot create a hard link to a symbolic link.
509 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
510 the link syscall on a symlink when it would do the wrong thing.
511 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
512 * tests/cp/link-no-deref: New file/test for the above.
513 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
514 * NEWS: Mention the change (doesn't affect Linux).
516 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
518 Fix some porting problems in the test cases reported by
519 Ralf Wildenhues for HP-UX 11.23 in:
520 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
521 * tests/help-version: Don't assume that \< \> works in sed.
522 * tests/misc/close-stdout: Don't assume that >&- works.
523 Add a /dev/full test.
524 * tests/touch/no-create-missing: Don't assume that >&- works.
526 2006-05-30 Jim Meyering <jim@meyering.net>
528 * src/ls.c (usage): Add `v' to the list of sorting-related options.
531 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
533 * tests/cp/fail-perm: source lang-default.
534 * tests/rm/inaccessible: Likewise.
536 2006-05-28 Jim Meyering <jim@meyering.net>
538 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
539 Recognize it, too. Reported by Ralf Wildenhues, in
540 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
542 2006-05-27 Jim Meyering <jim@meyering.net>
544 * src/chgrp.c: Support new options: --preserve-root and
545 --no-preserve-root. Somehow this program was skipped when those
546 options were added to chown, chmod, and rm. Reported by
547 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
548 * NEWS: Mention this.
550 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
552 * NEWS: Remove mention of --seed. We'll replace it with something
553 better, and don't want to indicate that it is supported.
554 * src/sort.c (usage): Likewise.
556 2006-05-20 Jim Meyering <jim@meyering.net>
558 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
560 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
561 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
562 FTS_COMFOLLOW. Spotted by Justin Pryzby.
564 * gnupload: Merge changes from automake, retaining the ""--to...
565 kludge to placate overzealous `make distcheck' check.
567 2006-05-19 Jim Meyering <jim@meyering.net>
569 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
570 FTS_TIGHT_CYCLE_CHECK directory traversal option.
571 Reported by Justin Pryzby in http://bugs.debian.org/367691
573 2006-05-15 Jim Meyering <jim@meyering.net>
575 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
578 2006-05-13 Jim Meyering <jim@meyering.net>
580 * tests/mv/no-target-dir: Test two more cases.
582 2006-05-11 Jim Meyering <jim@meyering.net>
584 mv -T DIR EMPTY_DIR no longer fails unconditionally
585 * src/copy.c (copy_internal): Don't manually prohibit a move where
586 the destination is an existing directory. Sometimes doing that is
587 valid. Let the rename system call enforce the rules. That is
588 allowed only when the source is a directory and the destination
589 directory (to be replaced) is empty. Reported by Eric Blake.
590 * tests/mv/no-target-dir: New file/test for this.
591 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
592 * NEWS: Mention this.
594 * tests/mv/atomic: New file/test for yesterday's fix.
595 * tests/mv/Makefile.am (TESTS): Add atomic.
597 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
599 2006-05-10 Jim Meyering <jim@meyering.net>
601 * src/copy.c (copy_internal): Don't explicitly unlink the destination
602 when moving a symlink into the place of an existing non-directory.
603 Reported by Joshua Hudson.
604 * NEWS: mention this.
606 2006-05-07 Jim Meyering <jim@meyering.net>
608 * Makefile.maint (patch-check): Fail if patch generates any output,
609 even merely for changed offsets.
611 * src/c99-to-c89.diff: Adjust to reflect new offsets.
613 * NEWS: Mention changes affecting df, pwd, shred.
615 2006-05-06 Jim Meyering <jim@meyering.net>
617 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
618 system condition where dirent.d_ino != stat.st_ino.
619 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
621 2006-05-06 Eric Blake <ebb9@byu.net>
623 * tests/ls/inode: Expand to test inode from readdir case.
624 * tests/ls/follow-slink: Expand to test broken links encountered
625 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
627 2006-05-06 Eric Blake <ebb9@byu.net>
629 * tests/mv/leak-fd: Work even on case-insensitive file system.
631 2006-05-04 Jim Meyering <jim@meyering.net>
633 * NEWS: Mention the 2006-03-19 pwd-related change that makes
634 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
636 2006-05-03 Jim Meyering <jim@meyering.net>
638 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
639 Use better macro parameter names: s/basename/key_name/,
640 s/basefunc/key_cmp_func. Fix typo in comment.
642 2006-04-29 Eric Blake <ebb9@byu.net>
644 * src/ls.c (main): On systems with d_type, directories_first only
645 implies format_needs_type, not format_needs_stat.
647 2006-05-03 Jim Meyering <jim@meyering.net>
649 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
650 after comma in arg list, from Eric Blake.
652 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
654 * tests/misc/date (relative-3): New test, derived from a bug
655 report by John Thomas McDole.
657 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
659 New option for ls: --group-directories-first.
660 It makes ls list directories before files.
661 * NEWS [New features]: Mention it.
662 * src/ls.c (sort_type): Rearrange to use as an array index when
663 choosing sort function; added new sort_numtypes member for
665 (time_type): Add new time_numtypes member for compile-time check.
666 (directories_first): New global variable.
667 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
668 (long_options): Add --directories-first.
669 (main): Support new option.
670 (is_directory): New function.
671 (extract_dirs_from_files): Use it.
672 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
673 (LIST_SORTFUNCTION_VARIANTS): New macros.
674 (sort_functions): New global variable.
675 (sort_files): Use it.
676 (usage): Document new option.
678 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
680 * src/shred.c (fillrand): The assertion was way too weak, due to
681 what must be a typo. Strengthen it to its intended value.
682 (dopass): Don't use alloca; it's not worth the aggravation here,
683 since it's used only to get a page-aligned buffer, and page
684 alignment doesn't buy us much here. I'm suspicious that alloca
685 causes problems on some hosts, due to a recent bug report by Adam
686 Waltman: http://bugs.gentoo.org/130246.
688 2006-04-18 Jim Meyering <jim@meyering.net>
690 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
691 sha384sum, sha512sum.
693 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
695 * src/chmod.c (describe_change): Adjust to filemode changes.
696 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
697 (print_long_format): Use (new) filemodestring rather than
698 (old) mode_string, so that we get more file types right, at least
699 in theory. Adjust to filemode changes.
700 * src/stat.c (human_access): Likewise.
702 2006-04-18 Jim Meyering <jim@meyering.net>
704 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
705 ignore file. This has never been enabled. Reported by Eric Blake.
707 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
709 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
710 bug in Interix. Just call symlink or link directly. All uses changed.
711 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
712 * src/stat.c (USE_STATVFS): New macro.
713 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
714 (NAMEMAX_FORMAT): define a bit more clearly, now that the
715 statvfs-using code is a bit more regular.
716 * src/system.h (sync) [!HAVE_SYNC]: New macro.
718 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
720 * NEWS: csplit, nl, expr now conform to POSIX better, and are
721 more-compatible with traditional Unix, with respect to regular
723 * src/csplit.c (extract_regexp): Set re_syntax_options to a
724 value that is compatible with what POSIX requires.
725 * src/nl.c (build_type_arg): Likewise.
726 * src/expr.c (docolon): Likewise. Also, don't let anchors match
727 newline; this fixes an incompatibility with tradition and with POSIX.
728 Don't warn about leading ^. POSIX says it is unspecified whether
729 ^ is a special character, which means that implementations can
730 either treat it as special or not, but either way a warning is not
731 allowed (unless the regexp is otherwise invalid). Instead, anchor
732 the expression but treat ^ as an anchor; this is the traditional
733 behavior (e.g., Solaris 10).
734 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
735 and the like as invalid expressions (exit status 2), not as
736 failure of 'expr' (exit status 3). This is more consistent with
738 * tests/expr/basic (fail-a): Adjust exit status to match new expr
739 behavior, for status 2 versus 3.
741 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
742 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
743 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
744 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
745 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
746 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
747 (bre61, bre62): New tests.
748 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
752 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
753 "if !". Do not assume that 'sed' can handle long, newline-free input.
754 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
756 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
758 Adjust to new regex.h API (with new fastmap type), and clean
759 up the regex storage allocation a bit.
761 * src/csplit.c (struct control): Put re_compiled member at the
762 end, since it's large. Change regexpr member from char * to bool;
763 all uses changed. Add new member fastmap.
764 (extract_regexp): regexp arg is now char const *, not char *.
765 Don't bother duplicating the regular expression; it's not needed.
766 Set fastmap from new fastmap member. Don't bother allocating
767 a buffer, as the regexp code does a better job than we do.
768 * src/expr.c (docolon): Allocate and use a fastmap.
769 Don't bother allocating a buffer.
770 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
772 (build_type_arg): New fastmap arg. All uses changed.
773 Don't bother allocating a buffer, but set a fastmap.
774 * src/ptx.c (context_regex_string, word_regex_string): Remove.
775 (context_regex, word_regex): New vars, replacing the above.
777 (struct regex_data): New type.
778 (compile_regex): Renamed from alloc_and_compile_regex, since
779 we no longer allocate storage. Arg is now a struct regex_data *,
780 not a const char *. All uses changed. Don't allocate the fastmap;
781 instead, take it from the caller. Don't convert size_t to int,
782 to avoid arithmetic overflow problems. Don't bother freeing
783 storage afterwards; it's not worth the aggravation.
784 * src/tac.c (compiled_separator_fastmap): New ver.
785 (main): Use it. Don't bother allocating a buffer.
787 2006-03-30 Jim Meyering <jim@meyering.net>
789 * src/dd.c (iwrite): Remove assignment without effect.
790 Reported by Felix Rauch Valenti.
792 2006-03-22 Eric Blake <ebb9@byu.net>
794 * src/ptx.c (usage): Remove mention of --copyright/-C.
795 (main): Alias --copyright to --version plus a deprecation warning.
796 * NEWS: Mention this.
798 2006-03-27 Jim Meyering <jim@meyering.net>
800 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
801 use of strtod. Tiny patch from Nickolai Zeldovich.
803 2006-03-11 Eric Blake <ebb9@byu.net>
805 * tests/misc/dirname: New file.
806 * tests/basename/Makefile.am: Delete.
807 * tests/basename/basic: Move to...
808 * tests/misc/basename: ... this new file. Add some tests,
809 including fixed behavior for //.
810 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
811 * tests/Makefile.am (SUBDIRS): Remove basename.
812 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
814 Improvements to dirname/basename handling on platforms like
815 cygwin with distinct // and with drive letters.
816 * NEWS: Document new behavior.
817 * src/basename.c (main): Don't strip suffix from file system
819 * src/cp.c (target_directory_operand): Use new last_component.
820 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
821 traversing the string.
822 * src/dircolors.c (guess_shell_syntax): Use new last_component.
823 * src/install.c (target_directory_operand, install_file_in_dir):
825 * src/ln.c (target_directory_operand, main): Likewise.
826 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
827 * src/mv.c (target_directory_operand, movefile): Likewise.
828 * src/remove.c (rm_1): Likewise.
829 * src/shred.c (wipename): Likewise.
830 * src/split.c (next_file_name): Likewise.
831 * src/su.c (log_su, run_shell): Likewise.
833 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
835 * NEWS: nohup diagnostics are now more precise, and nohup now
836 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
837 * src/nohup.c (main): Implement this.
838 * tests/misc/nohup: Test the new behavior.
840 2006-03-12 Jim Meyering <jim@meyering.net>
842 * src/copy.c (set_author): Rename function, from preserve_author.
844 * src/remove.c (AD_pop_and_chdir): Use new macro,
845 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
847 * src/system.h (SAME_INODE): Remove definition.
848 Include "same-inode.h", instead.
850 2006-03-11 Eric Blake <ebb9@byu.net>
852 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
854 2006-03-10 Jim Meyering <jim@meyering.net>
856 Fix a bug whereby a user with write access to a directory being removed
857 could cause the removal of that directory to fail with an erroneous
858 diagnostic about a directory cycle. Reported by Vineet Chadha.
860 * NEWS: Mention this.
861 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
862 leave (and try to rmdir) is the one whose dev_ino is being used to
863 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
865 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
867 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
868 * src/dd.c (set_fd_flags): Handle file-creation flags on file
869 descriptors, rather than ignoring them.
870 * tests/dd/misc: Add test cases for append, nofollow, directory,
871 and nolinks flags. Simplify redirection to /dev/null in some cases.
873 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
874 noatime test never tested anything.
876 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
878 * src/dd.c (flags, usage): New flags directory, nolinks.
879 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
881 * src/ls.c (usage): Mention that -f disables --color.
882 Problem reported by Niels Möller.
884 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
886 * man/*.x: Add references to syscalls from utilities of the same name.
888 2006-03-05 Jim Meyering <jim@meyering.net>
890 * tests/help-version: Set SHELL, if not already set, in order to
891 avoid failure when `make check' is run through debuild; dircolors
892 would fail due to lack of $SHELL. Reported by Sven Joachim.
894 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
895 * src/base64.c (wrap_write, do_encode, main): Change type of
896 parameters and locals, wrap_column, form size_t to uintmax_t.
897 (main): Adjust to use xstrtoumax, accordingly.
899 2006-03-03 Jim Meyering <jim@meyering.net>
901 Don't fail when run from an environment with SHELL not a Bourne
902 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
903 * tests/dircolors/simple: Invoke each non-failing test with -b.
904 Reported by Michael Stone.
906 2006-02-27 Jim Meyering <jim@meyering.net>
908 * tests/misc/base64: Derive --decode-using tests from the
911 * tests/misc/base64: Factor out a long constant string.
912 Split lines to stay within 80 columns.
914 * tests/misc/Makefile.am (TESTS): Add base64.
915 * tests/misc/base64: Test base64. From Simon Josefsson.
917 * src/base64.c (do_decode): Use correct type for parameter,
918 ignore_garbage: s/size_t/bool/.
920 * src/base64.c: Don't include .h files already included by system.h:
921 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
922 Include "system.h" before the other lib/*.h header files.
923 Include <sys/types.h> before "system.h".
924 (wrap_write): Remove declaration of unused local, initial_column.
925 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
927 * README: Add base64 to the list.
929 2006-02-17 Simon Josefsson <jas@extundo.com>
932 * AUTHORS: Mention base64.
934 * man/Makefile.am: Build base64.1.
935 * man/base64.x: New file.
936 * src/Makefile.am (bin_PROGRAMS): Add base64.
937 * src/base64.c: New file.
939 2006-02-25 Eric Blake <ebb9@byu.net>
941 In ls, avoid calling stat for --inode (-i), when possible.
942 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
943 * src/system.h: ... here, for use in ...
944 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
946 (gobble_file): Add inode argument.
947 (print_dir): Pass inode if available.
948 (usage): Remove inaccuracy.
950 2006-02-23 Jim Meyering <jim@meyering.net>
952 * TODO: Update/correct some obsolete entries.
954 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
956 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
957 * src/join.c (usage): Likewise.
958 Documentation problem reported by Philip Kensche.
960 2006-02-20 Eric Blake <ebb9@byu.net>
962 * man/rm.x: Update documentation to match previous patch.
964 2006-02-18 Eric Blake <ebb9@byu.net>
966 New option for rm: --interactive=once (-I).
967 * NEWS: Document it, along with change to rm --interactive.
968 * TODO: Remove entry for implementing rm -I
969 * src/rm.c (INTERACTIVE_OPTION): New enum value.
970 (interactive_type): New enum.
971 (long_opts): Let interactive take an optional argument.
972 (interactive_args, interactive_types): New option arguments.
973 (usage): Document -I, --interactive=WHEN. Use program_name
974 instead of a basename.
975 (main): New -I option, new behavior to --interactive.
976 * tests/rm/interactive-once: New tests.
977 * tests/rm/interactive-always: Ditto.
978 * tests/rm/Makefile.am (TESTS): Run them.
980 2006-02-18 Jim Meyering <jim@meyering.net>
982 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
983 expression match more of the target lines, e.g., those that start with
984 `-S,' (short option followed by a comma) or that include `=[...]'.
985 Patch by Nicolas François.
986 Fix the four offenders thus exposed:
987 * src/join.c (usage): Use two spaces (not one) to separate the
988 --first-only option string from its description, so help2man formats
989 the derived man page properly.
990 * src/pr.c (usage): Likewise.
991 * src/uniq.c (usage): Likewise.
992 * src/install.c (usage): Likewise.
994 2006-02-15 Jim Meyering <jim@meyering.net>
996 * Makefile.maint (alpha beta major): For `make major', ensure that the
997 version string is of the form N.N[.N]*, where N is one or more digits.
999 2006-02-14 Jim Meyering <jim@meyering.net>
1001 * INSTALL: Update from gnulib.
1003 2006-02-13 Jim Meyering <jim@meyering.net>
1005 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
1007 2006-02-12 Jim Meyering <jim@meyering.net>
1009 * Makefile.maint (patch-check): New target.
1010 (local-checks-available): Add to the list.
1012 2006-02-11 Jim Meyering <jim@meyering.net>
1014 * src/c99-to-c89.diff: New file.
1015 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
1017 * .x-po-check: New file, with exclusions so that `make distcheck'
1019 * Makefile.am (EXTRA_DIST): Add .x-po-check.
1021 rm -r must remove an empty directory, even if it is inaccessible.
1022 * src/remove.c (close_preserve_errno): New function.
1023 (fd_to_subdirp): Don't print a diagnostic in this function.
1024 Do it from the callers instead, unless rmdir succeeds.
1025 (remove_cwd_entries, remove_dir): Adjust callers.
1026 * tests/rm/empty-inacc: New test for the above.
1027 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
1028 * NEWS: Mention this bug fix.
1029 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
1030 a tiny bit less precise: cannot remove `a/1': ... instead of
1031 cannot open directory `a/1': ...
1033 * Makefile.maint (syntax-check-rules): Automatically derive this
1034 list of sc_-prefixed rule names.
1036 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
1038 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
1039 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
1040 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
1041 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
1042 go away? was that an accident?)
1043 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
1044 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
1045 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
1046 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
1047 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
1048 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
1049 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
1050 (author_mark_check, makefile_path_separator_check):
1051 Output line numbers, to simplify navigation of Emacs *compilation*
1053 (sc_prohibit_atoi_atof, sc_file_system):
1054 Rework slightly so that Makefile.maint doesn't get reported as a
1055 violation of its own syntax rules.
1056 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
1057 it at run-time (which didn't work with Bison). Fix a makefile typo,
1058 caught by Makefile.maint itself: spaces where a tab should be.
1059 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
1060 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
1061 Ignore djgpp and man subdirectories, to avoid false matches with
1062 Bison and coreutils, respectively. Use sort -u to remove the
1063 resulting duplicates.
1064 * gnupload: Rework slightly to avoid bogus warning from
1065 sc_two_space_separator_in_usage.
1067 2006-02-10 Jim Meyering <jim@meyering.net>
1069 Use gzip's --rsyncable option only if it's available.
1070 * Makefile.maint (gzip_rsyncable): New variable.
1073 2006-02-08 Jim Meyering <jim@meyering.net>
1075 * Makefile.maint (local-checks-available): Define in terms of
1076 the expansion, $(syntax-check-rules), rather than the single,
1077 top-level target `syntax-check', so that it's easier to exclude
1078 individual rules (via $(local-checks-to-skip)).
1079 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
1081 2006-02-07 Jim Meyering <jim@meyering.net>
1083 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
1084 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
1086 * tests/help-version (expected_failure_status_vdir):
1087 Redirect an expected disk-full diagnostic to /dev/null.
1089 2006-02-06 Jim Meyering <jim@meyering.net>
1091 * src/unexpand.c (usage): Use two spaces (not one) to separate the
1092 --first-only option string from its description, so help2man formats
1093 the derived man page properly.
1094 * src/rm.c (usage): Likewise for --no-preserve-root.
1095 * src/chown.c (usage): Likewise.
1096 * src/chgrp.c (usage): Likewise.
1098 Add a rule to ensure that the above doesn't happen again.
1099 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
1100 (syntax-check-rules): Add it.
1101 * .x-sc_two_space_separator_in_usage: New empty file.
1102 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
1104 2006-02-06 Jim Meyering <jim@meyering.net>
1106 * src/cp.c (usage): Use two spaces (not one) to separate each
1107 option string from its description, so help2man formats the
1108 derived man page properly.
1109 * src/mv.c (usage): Likewise.
1110 Patch from Nicolas François in http://bugs.debian.org/351601.
1112 2006-02-04 Jim Meyering <jim@meyering.net>
1114 * src/copy.c (copy_internal): cp -RL would fail when encountering
1115 the same directory more than once in the hierarchy beneath a single
1116 command-line argument. That is legitimate, e.g. when there are
1117 two or more symbolic links, each pointing to some directory that
1118 would not otherwise be copied. Reported by Christophe LYON.
1119 * tests/cp/cp-deref: New file. Test for today's fix.
1120 * tests/cp/Makefile.am (TESTS): Add cp-deref.
1121 * NEWS: Document this.
1123 2006-02-03 Jim Meyering <jim@meyering.net>
1125 * configure.ac: Require automake-1.9.6, not 1.8.3.
1127 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
1129 * src/od.c (usage): Mention that -t a ignores high order bit.
1130 Documentation problem reported by Ed Avis.
1132 2006-02-01 Jim Meyering <jim@meyering.net>
1134 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
1136 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
1138 * src/head.c (main): Use a better diagnostic when someone uses a
1139 trailing numeric option in an invalid way. Problem reported by
1141 * src/tail.c (parse_options): Likewise.
1143 2006-01-30 Jim Meyering <jim@meyering.net>
1145 * man/wc.x: Include `count' keyword in man page synopsis,
1146 per suggestion from http://bugs.debian.org/181585.
1148 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
1150 * src/df.c (show_dev): If the file system claims to have
1151 more available than total blocks, report the number of used
1152 blocks as being total - available (a negative number) rather
1153 than as garbage. Problem reported by Toralf Foerster.
1155 2006-01-24 Jim Meyering <jim@meyering.net>
1157 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
1158 to put a regular file in O_NONBLOCK mode fails with EPERM.
1159 That happens on Linux (up to 2.6.15) when using tail -f on a file with
1160 the append-only attribute. Reported by Dean Gaudet. For details,
1161 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
1162 * NEWS: Mention this fix.
1163 * tests/tail-2/append-only: New file. Test for the above.
1164 * tests/tail-2/Makefile.am (TESTS): Add append-only.
1165 * tests/Makefile.am (check-root): Add tail-2/append-only
1167 2006-01-21 Jim Meyering <jim@meyering.net>
1169 * NEWS: Mention fts-related improvements and bug fixes.
1171 2006-01-19 Jim Meyering <jim@meyering.net>
1173 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
1174 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
1176 2006-01-18 Jim Meyering <jim@meyering.net>
1178 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
1180 2006-01-17 Jim Meyering <jim@meyering.net>
1182 Now that fts no longer changes the current working directory, adjust
1183 its clients accordingly -- note that du.c uses fts but doesn't need
1184 any adjustment, since it doesn't operate on the actual files,
1185 but rather just uses the stat buffers provided by fts.
1187 * src/chown-core.c: Include "openat.h".
1188 Don't include "lchown.h".
1189 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
1190 calling openat, lchownat, chownat, rather than open, lchown, chown.
1192 * src/chmod.c: Include "openat.h".
1193 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
1195 * tests/du/long-from-unreadable: New test, to exercise one small
1198 2006-01-13 Jim Meyering <jim@meyering.net>
1200 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
1201 addition of new directories under tests/.
1203 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
1206 2006-01-12 Jim Meyering <jim@meyering.net>
1208 * tests/du/long-sloop: Adjust not to hard-code the expected
1209 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
1210 from that of GNU libc. Reported by Paul Eggert.
1212 * tests/du/long-sloop: Create file at end of symlink chain.
1214 * tests/misc/test: New file, with a test for one of the
1215 bugs fixed by yesterday's test.c changes.
1216 * tests/misc/Makefile.am (TESTS): Add test.
1218 2006-01-11 Jim Meyering <jim@meyering.net>
1220 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
1221 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
1222 a very long sequence of symbolic links (not necessarily a loop).
1223 * tests/du/Makefile.am (TESTS): Add long-sloop.
1225 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
1227 * src/test.c (test_syntax_error): Append a newline. All callers
1228 changed, except for the ones that didn't already append a newline.
1229 Bug reported by Eric Blake.
1231 2006-01-11 Jim Meyering <jim@meyering.net>
1233 * src/system.h (X2NREALLOC): Now that verify_true is no longer
1234 void, cast its result to void, to avoid gcc's warning that
1235 ``left-hand operand of comma expression has no effect''.
1236 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
1238 2006-01-10 Jim Meyering <jim@meyering.net>
1240 * tests/chmod/no-x: Add a test for today's fts.c fix.
1242 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
1244 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
1245 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
1247 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
1249 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
1250 Use verify_true instead of verify_expr, to sync with gnulib.
1252 2006-01-08 Jim Meyering <jim@meyering.net>
1254 * src/date.c (usage): Adjust the formatting of the entries for
1255 %::z and %:::z (separate with two spaces, not one) so that help2man
1256 formats them properly. Reported by Philip Rowlands.
1258 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
1260 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
1262 2006-01-06 Jim Meyering <jim@meyering.net>
1264 * Makefile.maint (copyright-check): Use date +%Y in place of
1267 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
1268 First off, the attribute should have been `volatile' (not static)
1269 to avoid longjmp-related risk of clobber. Secondly, now there is
1270 no longer any risk of a local variable being clobbered, so there's
1271 no need for any attribute at all.
1273 2006-01-05 Jim Meyering <jim@meyering.net>
1275 * src/remove.c: Give a few functions the inline attribute.
1276 (AD_pop_and_chdir): Use gotos to avoid some duplication.
1277 (AD_push): Rewrite an assertion so that the entire computation
1278 goes away when assertions are turned off.
1280 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
1281 It's already defined in "system.h".
1282 * Makefile.maint: Add a FIXME comment.
1284 2006-01-04 Jim Meyering <jim@meyering.net>
1286 * ChangeLog: Remove entries from 2005-10-22 and earlier.
1287 * ChangeLog-2005: New file, for entries up to version 5.92.
1289 2006-01-03 Jim Meyering <jim@meyering.net>
1291 * tests/du/no-x: Also allow a slightly different diagnostic -- the
1292 one you get when using openat-enabled fts.c and du (coming soon).
1293 * tests/chmod/no-x: Likewise.
1294 * tests/chgrp/no-x: Likewise.
1296 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
1298 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
1300 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
1301 (restricted_chown): Return it, if the file cannot be accessed due
1302 to EPERM, or if no uid or gid are required, or if the file is
1303 neither a directory nor a regular file. Rewrite to avoid gotos.
1304 (change_file_owner): Handle RC_do_ordinary_chown case.
1305 Rewrite to avoid gotos.
1306 * tests/chgrp/basic: Make sure we can change the group of
1309 * src/date.c (usage): Explain %g, %G, and %V a bit better.
1311 2006-01-02 Jim Meyering <jim@meyering.net>
1313 * src/copy.c (set_owner): Correct a comment.
1315 * src/tail.c (parse_options): Change warning to say that --retry
1316 is useful `mainly' (not `only') when following by name.
1317 Reported here: http://bugs.debian.org/273781
1319 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
1321 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
1322 * src/copy.c: Include lchmod.h.
1323 (copy_internal): Use lchmod rather than chmod.
1324 * src/cp.c: Include lchmod.h.
1325 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
1326 * src/mkdir.c: Include lchmod.h.
1327 (usage): Clarify -m's operation.
1328 (main): Use lchmod rather than chmod. Don't use lchmod unless the
1329 new mode contains bits outside the 777 range.
1330 * src/mkfifo.c (usage): Clarify -m's operation.
1331 (main): If -m is given, don't invoke chmod; use umask 0 instead.
1332 Report an error if -m asks for bits outside the 777 range.
1333 * src/mknod.c (usage, main): Likewise.
1335 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
1337 2005-12-27 Jim Meyering <jim@meyering.net>
1339 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
1340 (sc_prohibit_assert_without_use): New rule.
1341 (syntax-check-rules): Add it to the list.
1342 * .x-sc_prohibit_assert_without_use: New empty file.
1343 * Makefile.am (EXTRA_DIST): Add it.
1345 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
1347 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
1348 Don't include <assert.h>; it wasn't used.
1350 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
1352 * src/chown-core.c (restricted_chown):
1353 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
1354 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
1355 | O_NOFOLLOW too, for consistency with other dir-openers.
1356 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
1357 (is_empty_dir): Likewise.
1358 * src/shred.c (wipename): Likewise. Don't bother trying to open
1359 dir for writing, since POSIX prohibits it.
1361 2005-12-22 Jim Meyering <jim@meyering.net>
1363 * tests/help-version: Redirect stderr to /dev/full, to suppress
1364 write error diagnostic.
1366 2005-12-19 Jim Meyering <jim@meyering.net>
1368 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
1369 Avoid a minor race condition when `-m MODE' is specified, by using
1370 open, fchown, and close rather than just chown. To do that reliably --
1371 even with an overly restrictive umask -- ensure that each mkdir,
1372 mknod and mkfifo call uses a mode including at least owner-read access.
1373 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
1374 the subsequent chown (or equivalent open,fchown,close) fails.
1375 * tests/misc/mknod: New tests.
1376 * tests/misc/Makefile.am (TESTS): Add mknod.
1378 2005-12-17 Jim Meyering <jim@meyering.net>
1380 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
1381 e.g., on a named pipe.
1382 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
1383 place of all uses, since it is guaranteed (system.h) to be defined.
1385 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
1387 Add POSIX ACL support
1388 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
1389 is no requirement for ACL support; particularly, it does not exist
1390 on systems that have POSIX ACLs.
1391 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1392 * src/cp.c (umask_kill): With default acls, the umask is not to be
1393 applied. Remove umask_kill, don't change the process umask, and let
1394 the kernel apply the umask where appropriate.
1395 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1396 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1398 (copy_reg, copy_internal): Use copy_acl and set_acl
1399 instead of fchown/chown. Fix the logic for POSIX ACLs.
1400 (chown_succeded): Remove; we now always copy acls and
1401 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1402 did a chown before or not.
1403 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1404 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1405 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1406 to link with it via $(LIB_ACL), for the utilities that need it.
1408 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1410 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1411 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1412 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1413 value is now signified by whether cwd_errno is null.
1414 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1415 pointer-to-bool to pointer-to-errno-value. All callers changed.
1416 (rm_1): Don't bother setting a local cwd failure flag and then
1417 ORing it into the caller's. Just set the caller's.
1418 (rm): Use cwd failure errno value to print a slightly-better
1421 2005-12-15 Jim Meyering <jim@meyering.net>
1423 * src/stat.c (print_it): Properly handle a backslash at the
1424 end of a --printf format string. Reported by Paul Eggert.
1425 * tests/misc/stat-printf (end-bs): Add a test for the above.
1427 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1429 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1430 Don't assume /etc/passwd contains user names; use 'id' instead.
1432 2005-12-15 Jim Meyering <jim@meyering.net>
1434 stat: revert behavior of --format=FMT (-c)
1435 stat: add new option: --printf=FMT
1436 * NEWS: Mention this.
1437 * src/stat.c (isodigit, octtobin, hextobin): Define.
1438 (PRINTF_OPTION): Define.
1439 (interpret_backslash_escapes, trailing_delim): New globals.
1440 (usage): Document them. Alphabetize on long option names.
1441 (print_esc_char): New function.
1442 (print_it): Rewrite, in order to handle backslash escapes.
1443 (main): Handle new option. Set globals for --format, too.
1445 * tests/misc/stat-printf: Test --printf and --format.
1446 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1448 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1450 * NEWS: sort now reports incompatible options.
1451 * src/sort.c (incompatible_options, check_ordering_compatibility):
1453 (main): Use them. Don't bother with a usage message for
1454 "sort -c a b", for consistency with other error diagnostics.
1455 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1458 * src/cat.c (main): Undo previous change. close_stdout already
1459 does the check, so the previous change wasn't necessary.
1461 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1463 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1465 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1467 Install a more-conservative approach for sort -R. It's the
1468 same basic idea as the existing code, except it uses the full ISAAC
1469 approach (called the "more kosher" approach in the existing comments).
1470 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1471 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1472 better to be conservative here at first, and review any performance
1473 improvements carefully.
1474 * .x-sc_require_config_h: Add src/rand-isaac.c.
1475 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1476 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1477 (shred_SOURCES, sort_SOURCES): Remove.
1478 (EXTRA_DIST): Add rand-isaac.c.
1479 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1480 changing it to allow for varying numbers of words in the state.
1481 Alter so that we include rand-isaac.c directly rather than
1482 compiling it and linking to it. Don't include config.h or
1483 system.h; that's the includer's responsibility.
1484 Omit functions that are specific to shred.
1485 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1486 (isaac_step, struct irand_state):
1487 Resurrect these, with the same defns that used to be in shred.c.
1488 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1489 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1491 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1492 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1493 (irand_init, irand32, irand_mod):
1494 Number of words is constant again.
1495 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1496 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1497 * src/sort.c: Likewise.
1498 * src/shred.c (fillrand, dopass, main): Undo previous change.
1499 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1501 * src/sort.c: Don't include md5.h; it wasn't needed.
1502 (struct keyfield): Rename random_hash to random, for consistency
1503 with the other member names. All uses changed.
1504 (usage): Tweak wording to mention STRING for --seed option.
1505 (short_options): Rorder for consistency with other programs.
1506 (rand_state): Now a struct, not a pointer to one. All uses changed.
1507 (HASH_WORDS, HASH_SIZE): Remove.
1508 (get_hash): Remove comments around resbuf size, since we can assume C89.
1509 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1510 (keycompare): Adjust to the new get_hash.
1512 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1513 (main): Don't set need_random simply because gkey has it set; that
1514 doesn't necessarily mean we'll need random numbers.
1515 Redo seeding to match new get_hash approach.
1517 2005-12-10 Jim Meyering <jim@meyering.net>
1519 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1521 Avoid shred segfault on 64-bit systems.
1522 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1523 local of type uint32_t. Make the local an `int' instead.
1525 * NEWS: Mention sort's new options.
1527 * src/rand-isaac.c (isaac_mix): Declare to be static.
1528 Mark all other functions as `extern' so the tight-scope
1529 part of `make distcheck' passes once again.
1530 * src/rand-isaac.h (isaac_mix): Remove declaration.
1532 * src/sort.c (get_hash): Change position of `*' in parameter
1533 type to conform with convention.
1534 (main): Split a long line so it fits in 80 columns.
1535 (keycompare): Remove stray SPACE before TAB that was
1536 causing `make distcheck' to fail.
1538 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1540 * tests/misc/sort-rand: New file: basic tests for the new options.
1541 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1543 2005-12-10 Frederik Eaton <frederik@ofb.net>
1545 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1546 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1547 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1548 Make state size runtime-configurable.
1549 (isaac_new, isaac_copy): New functions.
1550 * src/rand-isaac.h: New file.
1551 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1552 (fillrand, main): Adjust to the fact that the state size is now
1553 runtime-configurable.
1554 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1555 (usage): Add options --random-sort and --seed to implement a random
1557 Include md5.h and rand-isaac.h.
1558 (get_hash): New function.
1559 (rand_state): New var.
1560 (HASH_WORDS, HASH_SIZE): New macros.
1562 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1564 * tests/dd/misc: Add test for dd iflags=noatime.
1566 2005-12-09 Jim Meyering <jim@meyering.net>
1568 * src/sort.c (usage): Mention white space vs -b and -t options.
1571 2005-12-09 Eric Blake <ebb9@byu.net>
1573 * src/test.c (main): Fix misleading comment.
1575 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1577 * NEWS: Mention dd's new noatime flag.
1578 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1579 * src/dd.c (flags, usage): Add support for noatime flag.
1581 2005-12-07 Jim Meyering <jim@meyering.net>
1583 Distribute the cvsu script, used only by `make syntax-check'.
1584 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1585 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1586 distribute a copy of this script.
1587 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1589 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1590 to create a temporary directory on another partition.
1591 From Andreas Gruenbacher.
1593 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1595 * man/basename.x: Cross-reference to dirname and readlink.
1596 * man/dirname.x: Cross-reference to basename and readlink.
1598 2005-12-05 Andreas Gruenbacher
1600 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1601 (set_owner, preserve_author): New functions, factored out of copy_reg.
1602 (copy_reg): Use them.
1603 (copy_internal): Use them here, too.
1605 2005-12-04 Jim Meyering <jim@meyering.net>
1607 * src/sleep.c (usage): Say what happens with two or more arguments.
1608 Suggested by Justin Pryzby.
1610 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1613 2005-12-03 Jim Meyering <jim@meyering.net>
1615 * src/rm.c (long_opts): Change the name of each undocumented, for-
1616 testing-only option to start with `-', so that it cannot render
1617 ambiguous any prefix it happens to share with some other option name.
1618 Problem reported by Eric Blake.
1619 * src/head.c (long_options): Likewise.
1620 * src/tail.c (long_options): Likewise.
1622 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1623 testing-only --presume* options to start with `---'.
1624 * tests/rm/dangling-symlink: Likewise.
1625 * tests/rm/dir-no-w: Likewise.
1626 * tests/rm/isatty: Likewise.
1628 2005-11-30 Jim Meyering <jim@meyering.net>
1630 * Makefile.maint: Add a comment about cvsu.
1632 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1634 * NEWS: df updates for "none", "proc", inaccessible file systems.
1635 * src/df.c (show_point): Ignore inaccessible file systems.
1636 (usage): -a includes dummy file systems, not size-0 file systems.
1638 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1639 to avoid collision with POSIX name space. All uses changed.
1641 2005-11-24 Jim Meyering <jim@meyering.net>
1643 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1644 * tests/acl: Add `$0: ' prefix to diagnostics.
1646 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1648 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1650 * src/copy.c: Improve performance a bit by optimizing away
1651 unnecessary system calls and going to a block size of at least
1652 8192 (on normal hosts, anyway). This improved performance 5% on my
1653 Debian stable host (2.4.27 kernel, x86, copying from root
1654 ext3 file system to itself).
1655 Include "buffer-lcm.h".
1656 (copy_reg): Omit last argument. All callers changed.
1657 Use xmalloc to allocate rather than trusting alloca
1658 (which is unwise with large block sizes).
1659 Declare locals more locally, if possible.
1660 Use uintptr_t words instead of int words, for a bit more speed
1661 when looking for null blocks on 64-bit hosts.
1662 Optimize away reads of zero bytes on regular files.
1663 In the typical case, insist on 8 KiB buffers, at least.
1664 Avoid unnecessary extra call to fstat when checking for sparse files.
1665 Avoid now-unnecessary cast to off_t, and "0L".
1666 Avoid unnecessary test of *new_dst when checking for same owner
1669 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1671 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1673 2005-11-22 Jim Meyering <jim@meyering.net>
1675 * src/remove.c (AD_push): Remove debugging cruft.
1677 * tests/rm/unread2 (rm): Change expected diagnostic,
1678 `cannot open directory' to `cannot remove', to align with
1680 * tests/rm/rm2: Ensure that rm now continues removing entries
1681 even after certain types of failure.
1683 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1684 that provide openat (Solaris), and on systems like Linux+procfs
1685 where our openat emulation code is reentrant. This also fixes a
1686 few low-probability leaks and eliminates some code that could,
1687 in very unusual circumstances, cause rm() (via a callee) to exit.
1688 * NEWS: Mention this.
1690 * configure.ac: Put copyright dates all on one line so the
1691 emacs function that updates them works properly.
1693 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1695 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1696 Problem reported by Eric Blake.
1697 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1698 we get a standard-conforming compiler. This relies on the new
1699 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1700 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1701 m4/c.m4 can go away with Autoconf 2.60 comes out.
1703 2005-11-17 Jim Meyering <jim@meyering.net>
1705 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1706 (AD_mark_current_as_unremovable): Likewise, but for a local.
1709 * tests/mv/acl: Let traps handle removing temporary directories.
1711 Expect acl-related tests to fail, until the corresponding
1712 patches are committed.
1713 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1714 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1716 ACL tests, from Andreas Gruenbacher.
1717 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1718 * tests/mv/Makefile.am (TESTS): Add acl.
1719 * tests/cp/Makefile.am (TESTS): Add acl.
1721 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1723 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1725 * NEWS: Improve quality of ln's diagnostics.
1726 * src/ln.c (do_link, usage): Likewise.
1727 (do_link): Don't use alloca on a buffer of unbounded size.
1729 2005-11-16 Jim Meyering <jim@meyering.net>
1731 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1732 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1733 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1734 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1735 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1737 2005-11-14 Jim Meyering <jim@meyering.net>
1739 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1741 2005-11-13 Jim Meyering <jim@meyering.net>
1743 * announce-gen: Accept new option, --gpg-key-id=ID and
1744 emit a blurb telling how to use the .sig files.
1745 * Makefile.cfg (gpg_key_ID): Define.
1746 * Makefile.maint (announcement): Use new option and key.
1748 Require that most .c files include <config.h>.
1749 * Makefile.maint (sc_require_config_h): New rule.
1750 (syntax-check-rules): Add it.
1751 * .x-sc_require_config_h: New file listing exceptions to the
1752 above rule. Some are legit, others are simply grandfathered in.
1753 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1755 2005-11-12 Jim Meyering <jim@meyering.net>
1757 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1759 2005-11-11 Jim Meyering <jim@meyering.net>
1761 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1762 Mention new readlink options in 5.3.0's `New features' section.
1763 Spotted by Thomas Hood.
1765 2005-11-08 Jim Meyering <jim@meyering.net>
1767 * NEWS: Merge in changes from b5_9x branch.
1769 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1771 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1772 like --time-style='posix-long-iso' if the locale settings are messed up.
1773 * src/ls.c (decode_switches): Implement this.
1775 2005-11-08 Jim Meyering <jim@meyering.net>
1777 * tests/du/2g: s/expensive/very expensive/ in a comment.
1780 2005-10-17 Eric Blake <ebb9@byu.net>
1782 * src/ls.c (usage): Fix descriptions of --sort, --time.
1783 Reported by Vitaly A. Ostanin.
1785 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1787 * src/ln.c: Include filenamecat.c.
1788 (FILE_BASENAME_CONCAT): Remove.
1789 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1790 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1791 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1794 2005-11-04 Jim Meyering <jim@meyering.net>
1796 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1797 on systems with stat.st_blocks of a signed 32-bit type.
1798 This bug causes trouble on some AIX 5.1 systems.
1799 Report and trivial patch from Paul Townsend:
1800 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1801 * NEWS: Mention this.
1803 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1804 * tests/du/Makefile.am (TESTS): Add it here.
1805 * tests/very-expensive: New file.
1806 * tests/Makefile.am (EXTRA_DIST): Add it here.
1807 * tests/cp/perm: Mark this test as `very-expensive', too.
1809 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1811 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1813 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1815 * src/rm.c (usage): Don't mention rm -d.
1817 2005-11-02 Jim Meyering <jim@meyering.net>
1819 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1820 From Andreas Schwab.
1822 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1823 `M+N records in/out' lines don't pollute `make check' output.
1825 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1826 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1827 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1828 to indicate that the input file should be piped into the command
1829 under test (via `cat FILE | $prog ...').
1831 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1832 (without -r) fails to remove a directory on a non-Linux system.
1833 This change affects only newer Solaris systems (with priv_*
1834 functions like priv_allocset). Reported by Keith Thompson.
1836 * tests/rm/dir-nonrecur: New file/test for the above fix.
1837 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1839 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1841 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1842 POSIX 1002.1-2001 requires.
1843 * src/tail.c (parse_obsolete_option): Implement this.
1844 Problem reported by Vincent Lefevre.
1845 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1846 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1847 (test_vector): Add special cases for _POSIX2_VERSION, and
1848 regularize the old ones a bit.
1849 * tests/touch/obsolescent: Add y2000 test.
1851 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1853 * src/dd.c (skip): Fix off-by-one error reported by
1854 Theodoros V. Kalamatianos.
1856 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1858 * tests/mkdir/p-3: Require that the test be run as non-root.
1859 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1861 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1863 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1864 boundary between DEST and SOURCE in the result.
1866 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1868 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1869 back to text, to sync with documentation and for backwards
1872 2005-10-25 Jim Meyering <jim@meyering.net>
1874 * tests/dircolors/simple (other-wr): Add an explicit test for
1875 the dircolors bug (NULL-dereference) fixed yesterday.
1877 2005-10-24 Jim Meyering <jim@meyering.net>
1879 * src/tac.c (tac_file): When determining whether a file is seekable,
1880 also test whether it is a tty. Using only the lseek-based test would
1881 give a false positive on Solaris. Reported by Peter Fales.
1883 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1885 * tests/install/d-slashdot: New test, for "install -d" failure.
1886 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1887 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1888 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1890 2005-10-24 Jim Meyering <jim@meyering.net>
1892 * src/dircolors.c (ls_codes): Add missing comma.
1893 Anonymous report and patch from
1894 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1896 * src/dircolors.c: Add compile-time assertion that the slack_codes
1897 and ls_codes arrays have the same number of elements. This would
1898 have prevented the above-fixed bug.
1900 * src/expand.c (parse_tab_stops): Add a comment to make this function
1901 identical to the one in unexpand.c.
1902 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1903 identical to the one in expand.c.
1905 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1907 2005-10-23 Jim Meyering <jim@meyering.net>
1909 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1910 a dangerous pointer-value-to-`unsigned' cast.
1911 * NEWS: mention the new sha* programs.
1912 * AUTHORS: Add new sha* programs.
1914 2005-08-28 David Madore <david.madore@ens.fr>
1916 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1917 * README: Add their names to the list.
1918 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1919 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1920 Rules for compiling sha-2 utilities
1921 (noinst_HEADERS): Remove checksum.h.
1922 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1924 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1925 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1926 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1927 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1928 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1929 sha384sum, sha512sum test scripts here rather that each in its
1932 2005-08-28 David Madore <david.madore@ens.fr>
1934 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1935 of the FIPS test vectors).
1937 2005-10-23 Jim Meyering <jim@meyering.net>
1939 * configure.ac: Use 6.0-cvs as the version string.
1940 * NEWS: Adjust accordingly.