1 2006-06-17 Jim Meyering <jim@meyering.net>
3 * tests/rm/inaccessible: Skip this test on systems without openat
4 support. Reported by Bob Proulx.
6 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
8 * tests/misc/mknod: Improve permission checks to handle
9 running mkdir test in set-gid directories.
11 2006-06-14 Jim Meyering <jim@meyering.net>
13 * tests/du/basic: Revamp not to hard-code file system block sizes.
15 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
17 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
20 2006-06-11 Jim Meyering <jim@meyering.net>
22 * .gitignore: New file.
23 * Makefile.am (EXTRA_DIST): Add .gitignore.
25 Setting TIME_STYLE=long-iso in the environment would make the
26 cp/same-file test fail.
27 * tests/envvar-check (vars): Add TIME_STYLE to the list.
28 * tests/cp/same-file: Revert last change.
29 Source the envvar-check script, to ensure that TIME_STYLE
30 settings don't affect these tests.
32 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
34 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
35 uses POSIX time stamp formats. Problem reported by John Nixon in
36 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
38 2006-06-10 Jim Meyering <jim@meyering.net>
40 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
42 Require a "Version N.M" line at the top of the ChangeLog
43 file only when making the actual release, not when running
45 * Makefile.maint (maintainer-distcheck): Don't depend on
47 (alpha beta major): Depend on it here, instead.
49 2006-06-08 Jim Meyering <jim@meyering.net>
51 Ensure that cat works with any of the options, -A -v -e -E -T,
52 when applied to files in /proc and /sys, even when the FIONREAD
53 ioctl produces nonsensical results. Before this change, cat would
54 produce no output (or truncated output), for some linux kernels.
56 * src/cat.c (write_pending): New function, factored out of cat.
57 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
58 that there are bytes to read. Some versions of linux-2.6.16 do that.
59 Write any pending output before returning.
60 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
61 * NEWS: Mention this bug fix.
62 * tests/misc/cat-proc: New file. Test for the above.
63 * tests/misc/Makefile.am (TESTS): Add cat-proc.
65 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
67 * src/expr.c (eval4): Detect overflow properly when multiplying
70 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
72 * NEWS: The 'expr' command now detects and reports integer overflow.
73 (It would be better to use extended precision instead, but that
75 * src/expr.c (integer_overflow): New function.
76 (eval4, eval3): Check for integer overflow.
78 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
80 Fix problems when building with Solaris/SVR4/etc. make, which uses a
81 different and somewhat bogus implementation of VPATH. In the
82 directory tests/misc, rename tests whose names might appear in the
83 Automake-generated rules. For example, we can't use a test named
84 'test', since Automake generates a rule that contains the text
85 "if test -f ./$$tst; ...", and this might expand to something like
86 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
87 which executes the 'test' script rather than the 'test' command.
88 * tests/misc/false-status: Renamed from tests/misc/false.
89 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
90 * tests/misc/sort-merge: Renamed from tests/misc/sort.
91 ($prog): Set to 'sort' rather than to $PROG.
92 * tests/misc/test-diag: Renamed from tests/misc/test.
93 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
94 in case Solaris make has prepended the directory.
95 (TESTS): Adjust to above renamings.
96 * tests/misc/expand: Don't assign to PROG; no longer needed
97 now that Makefile.am sets PROG to the basename.
98 * tests/misc/fold: Likewise.
100 2006-06-03 Jim Meyering <jim@meyering.net>
102 Make `cp --link --no-dereference' work also on systems where the
103 link system call cannot create a hard link to a symbolic link.
104 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
105 the link syscall on a symlink when it would do the wrong thing.
106 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
107 * tests/cp/link-no-deref: New file/test for the above.
108 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
109 * NEWS: Mention the change (doesn't affect Linux).
111 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
113 Fix some porting problems in the test cases reported by
114 Ralf Wildenhues for HP-UX 11.23 in:
115 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
116 * tests/help-version: Don't assume that \< \> works in sed.
117 * tests/misc/close-stdout: Don't assume that >&- works.
118 Add a /dev/full test.
119 * tests/touch/no-create-missing: Don't assume that >&- works.
121 2006-05-30 Jim Meyering <jim@meyering.net>
123 * src/ls.c (usage): Add `v' to the list of sorting-related options.
126 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
128 * tests/cp/fail-perm: source lang-default.
129 * tests/rm/inaccessible: Likewise.
131 2006-05-28 Jim Meyering <jim@meyering.net>
133 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
134 Recognize it, too. Reported by Ralf Wildenhues, in
135 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
137 2006-05-27 Jim Meyering <jim@meyering.net>
139 * src/chgrp.c: Support new options: --preserve-root and
140 --no-preserve-root. Somehow this program was skipped when those
141 options were added to chown, chmod, and rm. Reported by
142 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
143 * NEWS: Mention this.
145 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
147 * NEWS: Remove mention of --seed. We'll replace it with something
148 better, and don't want to indicate that it is supported.
149 * src/sort.c (usage): Likewise.
151 2006-05-20 Jim Meyering <jim@meyering.net>
153 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
155 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
156 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
157 FTS_COMFOLLOW. Spotted by Justin Pryzby.
159 * gnupload: Merge changes from automake, retaining the ""--to...
160 kludge to placate overzealous `make distcheck' check.
162 2006-05-19 Jim Meyering <jim@meyering.net>
164 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
165 FTS_TIGHT_CYCLE_CHECK directory traversal option.
166 Reported by Justin Pryzby in http://bugs.debian.org/367691
168 2006-05-15 Jim Meyering <jim@meyering.net>
170 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
173 2006-05-13 Jim Meyering <jim@meyering.net>
175 * tests/mv/no-target-dir: Test two more cases.
177 2006-05-11 Jim Meyering <jim@meyering.net>
179 mv -T DIR EMPTY_DIR no longer fails unconditionally
180 * src/copy.c (copy_internal): Don't manually prohibit a move where
181 the destination is an existing directory. Sometimes doing that is
182 valid. Let the rename system call enforce the rules. That is
183 allowed only when the source is a directory and the destination
184 directory (to be replaced) is empty. Reported by Eric Blake.
185 * tests/mv/no-target-dir: New file/test for this.
186 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
187 * NEWS: Mention this.
189 * tests/mv/atomic: New file/test for yesterday's fix.
190 * tests/mv/Makefile.am (TESTS): Add atomic.
192 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
194 2006-05-10 Jim Meyering <jim@meyering.net>
196 * src/copy.c (copy_internal): Don't explicitly unlink the destination
197 when moving a symlink into the place of an existing non-directory.
198 Reported by Joshua Hudson.
199 * NEWS: mention this.
201 2006-05-07 Jim Meyering <jim@meyering.net>
203 * Makefile.maint (patch-check): Fail if patch generates any output,
204 even merely for changed offsets.
206 * src/c99-to-c89.diff: Adjust to reflect new offsets.
208 * NEWS: Mention changes affecting df, pwd, shred.
210 2006-05-06 Jim Meyering <jim@meyering.net>
212 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
213 system condition where dirent.d_ino != stat.st_ino.
214 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
216 2006-05-06 Eric Blake <ebb9@byu.net>
218 * tests/ls/inode: Expand to test inode from readdir case.
219 * tests/ls/follow-slink: Expand to test broken links encountered
220 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
222 2006-05-06 Eric Blake <ebb9@byu.net>
224 * tests/mv/leak-fd: Work even on case-insensitive file system.
226 2006-05-04 Jim Meyering <jim@meyering.net>
228 * NEWS: Mention the 2006-03-19 pwd-related change that makes
229 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
231 2006-05-03 Jim Meyering <jim@meyering.net>
233 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
234 Use better macro parameter names: s/basename/key_name/,
235 s/basefunc/key_cmp_func. Fix typo in comment.
237 2006-04-29 Eric Blake <ebb9@byu.net>
239 * src/ls.c (main): On systems with d_type, directories_first only
240 implies format_needs_type, not format_needs_stat.
242 2006-05-03 Jim Meyering <jim@meyering.net>
244 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
245 after comma in arg list, from Eric Blake.
247 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
249 * tests/misc/date (relative-3): New test, derived from a bug
250 report by John Thomas McDole.
252 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
254 New option for ls: --group-directories-first.
255 It makes ls list directories before files.
256 * NEWS [New features]: Mention it.
257 * src/ls.c (sort_type): Rearrange to use as an array index when
258 choosing sort function; added new sort_numtypes member for
260 (time_type): Add new time_numtypes member for compile-time check.
261 (directories_first): New global variable.
262 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
263 (long_options): Add --directories-first.
264 (main): Support new option.
265 (is_directory): New function.
266 (extract_dirs_from_files): Use it.
267 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
268 (LIST_SORTFUNCTION_VARIANTS): New macros.
269 (sort_functions): New global variable.
270 (sort_files): Use it.
271 (usage): Document new option.
273 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
275 * src/shred.c (fillrand): The assertion was way too weak, due to
276 what must be a typo. Strengthen it to its intended value.
277 (dopass): Don't use alloca; it's not worth the aggravation here,
278 since it's used only to get a page-aligned buffer, and page
279 alignment doesn't buy us much here. I'm suspicious that alloca
280 causes problems on some hosts, due to a recent bug report by Adam
281 Waltman: http://bugs.gentoo.org/130246.
283 2006-04-18 Jim Meyering <jim@meyering.net>
285 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
286 sha384sum, sha512sum.
288 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
290 * src/chmod.c (describe_change): Adjust to filemode changes.
291 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
292 (print_long_format): Use (new) filemodestring rather than
293 (old) mode_string, so that we get more file types right, at least
294 in theory. Adjust to filemode changes.
295 * src/stat.c (human_access): Likewise.
297 2006-04-18 Jim Meyering <jim@meyering.net>
299 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
300 ignore file. This has never been enabled. Reported by Eric Blake.
302 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
304 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
305 bug in Interix. Just call symlink or link directly. All uses changed.
306 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
307 * src/stat.c (USE_STATVFS): New macro.
308 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
309 (NAMEMAX_FORMAT): define a bit more clearly, now that the
310 statvfs-using code is a bit more regular.
311 * src/system.h (sync) [!HAVE_SYNC]: New macro.
313 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
315 * NEWS: csplit, nl, expr now conform to POSIX better, and are
316 more-compatible with traditional Unix, with respect to regular
318 * src/csplit.c (extract_regexp): Set re_syntax_options to a
319 value that is compatible with what POSIX requires.
320 * src/nl.c (build_type_arg): Likewise.
321 * src/expr.c (docolon): Likewise. Also, don't let anchors match
322 newline; this fixes an incompatibility with tradition and with POSIX.
323 Don't warn about leading ^. POSIX says it is unspecified whether
324 ^ is a special character, which means that implementations can
325 either treat it as special or not, but either way a warning is not
326 allowed (unless the regexp is otherwise invalid). Instead, anchor
327 the expression but treat ^ as an anchor; this is the traditional
328 behavior (e.g., Solaris 10).
329 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
330 and the like as invalid expressions (exit status 2), not as
331 failure of 'expr' (exit status 3). This is more consistent with
333 * tests/expr/basic (fail-a): Adjust exit status to match new expr
334 behavior, for status 2 versus 3.
336 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
337 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
338 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
339 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
340 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
341 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
342 (bre61, bre62): New tests.
343 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
347 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
348 "if !". Do not assume that 'sed' can handle long, newline-free input.
349 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
351 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
353 Adjust to new regex.h API (with new fastmap type), and clean
354 up the regex storage allocation a bit.
356 * src/csplit.c (struct control): Put re_compiled member at the
357 end, since it's large. Change regexpr member from char * to bool;
358 all uses changed. Add new member fastmap.
359 (extract_regexp): regexp arg is now char const *, not char *.
360 Don't bother duplicating the regular expression; it's not needed.
361 Set fastmap from new fastmap member. Don't bother allocating
362 a buffer, as the regexp code does a better job than we do.
363 * src/expr.c (docolon): Allocate and use a fastmap.
364 Don't bother allocating a buffer.
365 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
367 (build_type_arg): New fastmap arg. All uses changed.
368 Don't bother allocating a buffer, but set a fastmap.
369 * src/ptx.c (context_regex_string, word_regex_string): Remove.
370 (context_regex, word_regex): New vars, replacing the above.
372 (struct regex_data): New type.
373 (compile_regex): Renamed from alloc_and_compile_regex, since
374 we no longer allocate storage. Arg is now a struct regex_data *,
375 not a const char *. All uses changed. Don't allocate the fastmap;
376 instead, take it from the caller. Don't convert size_t to int,
377 to avoid arithmetic overflow problems. Don't bother freeing
378 storage afterwards; it's not worth the aggravation.
379 * src/tac.c (compiled_separator_fastmap): New ver.
380 (main): Use it. Don't bother allocating a buffer.
382 2006-03-30 Jim Meyering <jim@meyering.net>
384 * src/dd.c (iwrite): Remove assignment without effect.
385 Reported by Felix Rauch Valenti.
387 2006-03-22 Eric Blake <ebb9@byu.net>
389 * src/ptx.c (usage): Remove mention of --copyright/-C.
390 (main): Alias --copyright to --version plus a deprecation warning.
391 * NEWS: Mention this.
393 2006-03-27 Jim Meyering <jim@meyering.net>
395 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
396 use of strtod. Tiny patch from Nickolai Zeldovich.
398 2006-03-11 Eric Blake <ebb9@byu.net>
400 * tests/misc/dirname: New file.
401 * tests/basename/Makefile.am: Delete.
402 * tests/basename/basic: Move to...
403 * tests/misc/basename: ... this new file. Add some tests,
404 including fixed behavior for //.
405 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
406 * tests/Makefile.am (SUBDIRS): Remove basename.
407 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
409 Improvements to dirname/basename handling on platforms like
410 cygwin with distinct // and with drive letters.
411 * NEWS: Document new behavior.
412 * src/basename.c (main): Don't strip suffix from file system
414 * src/cp.c (target_directory_operand): Use new last_component.
415 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
416 traversing the string.
417 * src/dircolors.c (guess_shell_syntax): Use new last_component.
418 * src/install.c (target_directory_operand, install_file_in_dir):
420 * src/ln.c (target_directory_operand, main): Likewise.
421 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
422 * src/mv.c (target_directory_operand, movefile): Likewise.
423 * src/remove.c (rm_1): Likewise.
424 * src/shred.c (wipename): Likewise.
425 * src/split.c (next_file_name): Likewise.
426 * src/su.c (log_su, run_shell): Likewise.
428 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
430 * NEWS: nohup diagnostics are now more precise, and nohup now
431 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
432 * src/nohup.c (main): Implement this.
433 * tests/misc/nohup: Test the new behavior.
435 2006-03-12 Jim Meyering <jim@meyering.net>
437 * src/copy.c (set_author): Rename function, from preserve_author.
439 * src/remove.c (AD_pop_and_chdir): Use new macro,
440 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
442 * src/system.h (SAME_INODE): Remove definition.
443 Include "same-inode.h", instead.
445 2006-03-11 Eric Blake <ebb9@byu.net>
447 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
449 2006-03-10 Jim Meyering <jim@meyering.net>
451 Fix a bug whereby a user with write access to a directory being removed
452 could cause the removal of that directory to fail with an erroneous
453 diagnostic about a directory cycle. Reported by Vineet Chadha.
455 * NEWS: Mention this.
456 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
457 leave (and try to rmdir) is the one whose dev_ino is being used to
458 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
460 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
462 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
463 * src/dd.c (set_fd_flags): Handle file-creation flags on file
464 descriptors, rather than ignoring them.
465 * tests/dd/misc: Add test cases for append, nofollow, directory,
466 and nolinks flags. Simplify redirection to /dev/null in some cases.
468 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
469 noatime test never tested anything.
471 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
473 * src/dd.c (flags, usage): New flags directory, nolinks.
474 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
476 * src/ls.c (usage): Mention that -f disables --color.
477 Problem reported by Niels Möller.
479 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
481 * man/*.x: Add references to syscalls from utilities of the same name.
483 2006-03-05 Jim Meyering <jim@meyering.net>
485 * tests/help-version: Set SHELL, if not already set, in order to
486 avoid failure when `make check' is run through debuild; dircolors
487 would fail due to lack of $SHELL. Reported by Sven Joachim.
489 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
490 * src/base64.c (wrap_write, do_encode, main): Change type of
491 parameters and locals, wrap_column, form size_t to uintmax_t.
492 (main): Adjust to use xstrtoumax, accordingly.
494 2006-03-03 Jim Meyering <jim@meyering.net>
496 Don't fail when run from an environment with SHELL not a Bourne
497 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
498 * tests/dircolors/simple: Invoke each non-failing test with -b.
499 Reported by Michael Stone.
501 2006-02-27 Jim Meyering <jim@meyering.net>
503 * tests/misc/base64: Derive --decode-using tests from the
506 * tests/misc/base64: Factor out a long constant string.
507 Split lines to stay within 80 columns.
509 * tests/misc/Makefile.am (TESTS): Add base64.
510 * tests/misc/base64: Test base64. From Simon Josefsson.
512 * src/base64.c (do_decode): Use correct type for parameter,
513 ignore_garbage: s/size_t/bool/.
515 * src/base64.c: Don't include .h files already included by system.h:
516 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
517 Include "system.h" before the other lib/*.h header files.
518 Include <sys/types.h> before "system.h".
519 (wrap_write): Remove declaration of unused local, initial_column.
520 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
522 * README: Add base64 to the list.
524 2006-02-17 Simon Josefsson <jas@extundo.com>
527 * AUTHORS: Mention base64.
529 * man/Makefile.am: Build base64.1.
530 * man/base64.x: New file.
531 * src/Makefile.am (bin_PROGRAMS): Add base64.
532 * src/base64.c: New file.
534 2006-02-25 Eric Blake <ebb9@byu.net>
536 In ls, avoid calling stat for --inode (-i), when possible.
537 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
538 * src/system.h: ... here, for use in ...
539 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
541 (gobble_file): Add inode argument.
542 (print_dir): Pass inode if available.
543 (usage): Remove inaccuracy.
545 2006-02-23 Jim Meyering <jim@meyering.net>
547 * TODO: Update/correct some obsolete entries.
549 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
551 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
552 * src/join.c (usage): Likewise.
553 Documentation problem reported by Philip Kensche.
555 2006-02-20 Eric Blake <ebb9@byu.net>
557 * man/rm.x: Update documentation to match previous patch.
559 2006-02-18 Eric Blake <ebb9@byu.net>
561 New option for rm: --interactive=once (-I).
562 * NEWS: Document it, along with change to rm --interactive.
563 * TODO: Remove entry for implementing rm -I
564 * src/rm.c (INTERACTIVE_OPTION): New enum value.
565 (interactive_type): New enum.
566 (long_opts): Let interactive take an optional argument.
567 (interactive_args, interactive_types): New option arguments.
568 (usage): Document -I, --interactive=WHEN. Use program_name
569 instead of a basename.
570 (main): New -I option, new behavior to --interactive.
571 * tests/rm/interactive-once: New tests.
572 * tests/rm/interactive-always: Ditto.
573 * tests/rm/Makefile.am (TESTS): Run them.
575 2006-02-18 Jim Meyering <jim@meyering.net>
577 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
578 expression match more of the target lines, e.g., those that start with
579 `-S,' (short option followed by a comma) or that include `=[...]'.
580 Patch by Nicolas François.
581 Fix the four offenders thus exposed:
582 * src/join.c (usage): Use two spaces (not one) to separate the
583 --first-only option string from its description, so help2man formats
584 the derived man page properly.
585 * src/pr.c (usage): Likewise.
586 * src/uniq.c (usage): Likewise.
587 * src/install.c (usage): Likewise.
589 2006-02-15 Jim Meyering <jim@meyering.net>
591 * Makefile.maint (alpha beta major): For `make major', ensure that the
592 version string is of the form N.N[.N]*, where N is one or more digits.
594 2006-02-14 Jim Meyering <jim@meyering.net>
596 * INSTALL: Update from gnulib.
598 2006-02-13 Jim Meyering <jim@meyering.net>
600 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
602 2006-02-12 Jim Meyering <jim@meyering.net>
604 * Makefile.maint (patch-check): New target.
605 (local-checks-available): Add to the list.
607 2006-02-11 Jim Meyering <jim@meyering.net>
609 * src/c99-to-c89.diff: New file.
610 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
612 * .x-po-check: New file, with exclusions so that `make distcheck'
614 * Makefile.am (EXTRA_DIST): Add .x-po-check.
616 rm -r must remove an empty directory, even if it is inaccessible.
617 * src/remove.c (close_preserve_errno): New function.
618 (fd_to_subdirp): Don't print a diagnostic in this function.
619 Do it from the callers instead, unless rmdir succeeds.
620 (remove_cwd_entries, remove_dir): Adjust callers.
621 * tests/rm/empty-inacc: New test for the above.
622 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
623 * NEWS: Mention this bug fix.
624 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
625 a tiny bit less precise: cannot remove `a/1': ... instead of
626 cannot open directory `a/1': ...
628 * Makefile.maint (syntax-check-rules): Automatically derive this
629 list of sc_-prefixed rule names.
631 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
633 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
634 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
635 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
636 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
637 go away? was that an accident?)
638 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
639 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
640 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
641 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
642 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
643 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
644 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
645 (author_mark_check, makefile_path_separator_check):
646 Output line numbers, to simplify navigation of Emacs *compilation*
648 (sc_prohibit_atoi_atof, sc_file_system):
649 Rework slightly so that Makefile.maint doesn't get reported as a
650 violation of its own syntax rules.
651 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
652 it at run-time (which didn't work with Bison). Fix a makefile typo,
653 caught by Makefile.maint itself: spaces where a tab should be.
654 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
655 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
656 Ignore djgpp and man subdirectories, to avoid false matches with
657 Bison and coreutils, respectively. Use sort -u to remove the
658 resulting duplicates.
659 * gnupload: Rework slightly to avoid bogus warning from
660 sc_two_space_separator_in_usage.
662 2006-02-10 Jim Meyering <jim@meyering.net>
664 Use gzip's --rsyncable option only if it's available.
665 * Makefile.maint (gzip_rsyncable): New variable.
668 2006-02-08 Jim Meyering <jim@meyering.net>
670 * Makefile.maint (local-checks-available): Define in terms of
671 the expansion, $(syntax-check-rules), rather than the single,
672 top-level target `syntax-check', so that it's easier to exclude
673 individual rules (via $(local-checks-to-skip)).
674 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
676 2006-02-07 Jim Meyering <jim@meyering.net>
678 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
679 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
681 * tests/help-version (expected_failure_status_vdir):
682 Redirect an expected disk-full diagnostic to /dev/null.
684 2006-02-06 Jim Meyering <jim@meyering.net>
686 * src/unexpand.c (usage): Use two spaces (not one) to separate the
687 --first-only option string from its description, so help2man formats
688 the derived man page properly.
689 * src/rm.c (usage): Likewise for --no-preserve-root.
690 * src/chown.c (usage): Likewise.
691 * src/chgrp.c (usage): Likewise.
693 Add a rule to ensure that the above doesn't happen again.
694 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
695 (syntax-check-rules): Add it.
696 * .x-sc_two_space_separator_in_usage: New empty file.
697 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
699 2006-02-06 Jim Meyering <jim@meyering.net>
701 * src/cp.c (usage): Use two spaces (not one) to separate each
702 option string from its description, so help2man formats the
703 derived man page properly.
704 * src/mv.c (usage): Likewise.
705 Patch from Nicolas François in http://bugs.debian.org/351601.
707 2006-02-04 Jim Meyering <jim@meyering.net>
709 * src/copy.c (copy_internal): cp -RL would fail when encountering
710 the same directory more than once in the hierarchy beneath a single
711 command-line argument. That is legitimate, e.g. when there are
712 two or more symbolic links, each pointing to some directory that
713 would not otherwise be copied. Reported by Christophe LYON.
714 * tests/cp/cp-deref: New file. Test for today's fix.
715 * tests/cp/Makefile.am (TESTS): Add cp-deref.
716 * NEWS: Document this.
718 2006-02-03 Jim Meyering <jim@meyering.net>
720 * configure.ac: Require automake-1.9.6, not 1.8.3.
722 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
724 * src/od.c (usage): Mention that -t a ignores high order bit.
725 Documentation problem reported by Ed Avis.
727 2006-02-01 Jim Meyering <jim@meyering.net>
729 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
731 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
733 * src/head.c (main): Use a better diagnostic when someone uses a
734 trailing numeric option in an invalid way. Problem reported by
736 * src/tail.c (parse_options): Likewise.
738 2006-01-30 Jim Meyering <jim@meyering.net>
740 * man/wc.x: Include `count' keyword in man page synopsis,
741 per suggestion from http://bugs.debian.org/181585.
743 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
745 * src/df.c (show_dev): If the file system claims to have
746 more available than total blocks, report the number of used
747 blocks as being total - available (a negative number) rather
748 than as garbage. Problem reported by Toralf Foerster.
750 2006-01-24 Jim Meyering <jim@meyering.net>
752 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
753 to put a regular file in O_NONBLOCK mode fails with EPERM.
754 That happens on Linux (up to 2.6.15) when using tail -f on a file with
755 the append-only attribute. Reported by Dean Gaudet. For details,
756 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
757 * NEWS: Mention this fix.
758 * tests/tail-2/append-only: New file. Test for the above.
759 * tests/tail-2/Makefile.am (TESTS): Add append-only.
760 * tests/Makefile.am (check-root): Add tail-2/append-only
762 2006-01-21 Jim Meyering <jim@meyering.net>
764 * NEWS: Mention fts-related improvements and bug fixes.
766 2006-01-19 Jim Meyering <jim@meyering.net>
768 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
769 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
771 2006-01-18 Jim Meyering <jim@meyering.net>
773 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
775 2006-01-17 Jim Meyering <jim@meyering.net>
777 Now that fts no longer changes the current working directory, adjust
778 its clients accordingly -- note that du.c uses fts but doesn't need
779 any adjustment, since it doesn't operate on the actual files,
780 but rather just uses the stat buffers provided by fts.
782 * src/chown-core.c: Include "openat.h".
783 Don't include "lchown.h".
784 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
785 calling openat, lchownat, chownat, rather than open, lchown, chown.
787 * src/chmod.c: Include "openat.h".
788 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
790 * tests/du/long-from-unreadable: New test, to exercise one small
793 2006-01-13 Jim Meyering <jim@meyering.net>
795 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
796 addition of new directories under tests/.
798 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
801 2006-01-12 Jim Meyering <jim@meyering.net>
803 * tests/du/long-sloop: Adjust not to hard-code the expected
804 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
805 from that of GNU libc. Reported by Paul Eggert.
807 * tests/du/long-sloop: Create file at end of symlink chain.
809 * tests/misc/test: New file, with a test for one of the
810 bugs fixed by yesterday's test.c changes.
811 * tests/misc/Makefile.am (TESTS): Add test.
813 2006-01-11 Jim Meyering <jim@meyering.net>
815 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
816 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
817 a very long sequence of symbolic links (not necessarily a loop).
818 * tests/du/Makefile.am (TESTS): Add long-sloop.
820 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
822 * src/test.c (test_syntax_error): Append a newline. All callers
823 changed, except for the ones that didn't already append a newline.
824 Bug reported by Eric Blake.
826 2006-01-11 Jim Meyering <jim@meyering.net>
828 * src/system.h (X2NREALLOC): Now that verify_true is no longer
829 void, cast its result to void, to avoid gcc's warning that
830 ``left-hand operand of comma expression has no effect''.
831 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
833 2006-01-10 Jim Meyering <jim@meyering.net>
835 * tests/chmod/no-x: Add a test for today's fts.c fix.
837 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
839 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
840 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
842 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
844 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
845 Use verify_true instead of verify_expr, to sync with gnulib.
847 2006-01-08 Jim Meyering <jim@meyering.net>
849 * src/date.c (usage): Adjust the formatting of the entries for
850 %::z and %:::z (separate with two spaces, not one) so that help2man
851 formats them properly. Reported by Philip Rowlands.
853 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
855 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
857 2006-01-06 Jim Meyering <jim@meyering.net>
859 * Makefile.maint (copyright-check): Use date +%Y in place of
862 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
863 First off, the attribute should have been `volatile' (not static)
864 to avoid longjmp-related risk of clobber. Secondly, now there is
865 no longer any risk of a local variable being clobbered, so there's
866 no need for any attribute at all.
868 2006-01-05 Jim Meyering <jim@meyering.net>
870 * src/remove.c: Give a few functions the inline attribute.
871 (AD_pop_and_chdir): Use gotos to avoid some duplication.
872 (AD_push): Rewrite an assertion so that the entire computation
873 goes away when assertions are turned off.
875 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
876 It's already defined in "system.h".
877 * Makefile.maint: Add a FIXME comment.
879 2006-01-04 Jim Meyering <jim@meyering.net>
881 * ChangeLog: Remove entries from 2005-10-22 and earlier.
882 * ChangeLog-2005: New file, for entries up to version 5.92.
884 2006-01-03 Jim Meyering <jim@meyering.net>
886 * tests/du/no-x: Also allow a slightly different diagnostic -- the
887 one you get when using openat-enabled fts.c and du (coming soon).
888 * tests/chmod/no-x: Likewise.
889 * tests/chgrp/no-x: Likewise.
891 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
893 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
895 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
896 (restricted_chown): Return it, if the file cannot be accessed due
897 to EPERM, or if no uid or gid are required, or if the file is
898 neither a directory nor a regular file. Rewrite to avoid gotos.
899 (change_file_owner): Handle RC_do_ordinary_chown case.
900 Rewrite to avoid gotos.
901 * tests/chgrp/basic: Make sure we can change the group of
904 * src/date.c (usage): Explain %g, %G, and %V a bit better.
906 2006-01-02 Jim Meyering <jim@meyering.net>
908 * src/copy.c (set_owner): Correct a comment.
910 * src/tail.c (parse_options): Change warning to say that --retry
911 is useful `mainly' (not `only') when following by name.
912 Reported here: http://bugs.debian.org/273781
914 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
916 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
917 * src/copy.c: Include lchmod.h.
918 (copy_internal): Use lchmod rather than chmod.
919 * src/cp.c: Include lchmod.h.
920 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
921 * src/mkdir.c: Include lchmod.h.
922 (usage): Clarify -m's operation.
923 (main): Use lchmod rather than chmod. Don't use lchmod unless the
924 new mode contains bits outside the 777 range.
925 * src/mkfifo.c (usage): Clarify -m's operation.
926 (main): If -m is given, don't invoke chmod; use umask 0 instead.
927 Report an error if -m asks for bits outside the 777 range.
928 * src/mknod.c (usage, main): Likewise.
930 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
932 2005-12-27 Jim Meyering <jim@meyering.net>
934 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
935 (sc_prohibit_assert_without_use): New rule.
936 (syntax-check-rules): Add it to the list.
937 * .x-sc_prohibit_assert_without_use: New empty file.
938 * Makefile.am (EXTRA_DIST): Add it.
940 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
942 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
943 Don't include <assert.h>; it wasn't used.
945 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
947 * src/chown-core.c (restricted_chown):
948 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
949 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
950 | O_NOFOLLOW too, for consistency with other dir-openers.
951 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
952 (is_empty_dir): Likewise.
953 * src/shred.c (wipename): Likewise. Don't bother trying to open
954 dir for writing, since POSIX prohibits it.
956 2005-12-22 Jim Meyering <jim@meyering.net>
958 * tests/help-version: Redirect stderr to /dev/full, to suppress
959 write error diagnostic.
961 2005-12-19 Jim Meyering <jim@meyering.net>
963 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
964 Avoid a minor race condition when `-m MODE' is specified, by using
965 open, fchown, and close rather than just chown. To do that reliably --
966 even with an overly restrictive umask -- ensure that each mkdir,
967 mknod and mkfifo call uses a mode including at least owner-read access.
968 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
969 the subsequent chown (or equivalent open,fchown,close) fails.
970 * tests/misc/mknod: New tests.
971 * tests/misc/Makefile.am (TESTS): Add mknod.
973 2005-12-17 Jim Meyering <jim@meyering.net>
975 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
976 e.g., on a named pipe.
977 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
978 place of all uses, since it is guaranteed (system.h) to be defined.
980 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
982 Add POSIX ACL support
983 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
984 is no requirement for ACL support; particularly, it does not exist
985 on systems that have POSIX ACLs.
986 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
987 * src/cp.c (umask_kill): With default acls, the umask is not to be
988 applied. Remove umask_kill, don't change the process umask, and let
989 the kernel apply the umask where appropriate.
990 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
991 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
993 (copy_reg, copy_internal): Use copy_acl and set_acl
994 instead of fchown/chown. Fix the logic for POSIX ACLs.
995 (chown_succeded): Remove; we now always copy acls and
996 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
997 did a chown before or not.
998 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
999 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1000 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1001 to link with it via $(LIB_ACL), for the utilities that need it.
1003 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1005 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1006 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1007 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1008 value is now signified by whether cwd_errno is null.
1009 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1010 pointer-to-bool to pointer-to-errno-value. All callers changed.
1011 (rm_1): Don't bother setting a local cwd failure flag and then
1012 ORing it into the caller's. Just set the caller's.
1013 (rm): Use cwd failure errno value to print a slightly-better
1016 2005-12-15 Jim Meyering <jim@meyering.net>
1018 * src/stat.c (print_it): Properly handle a backslash at the
1019 end of a --printf format string. Reported by Paul Eggert.
1020 * tests/misc/stat-printf (end-bs): Add a test for the above.
1022 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1024 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1025 Don't assume /etc/passwd contains user names; use 'id' instead.
1027 2005-12-15 Jim Meyering <jim@meyering.net>
1029 stat: revert behavior of --format=FMT (-c)
1030 stat: add new option: --printf=FMT
1031 * NEWS: Mention this.
1032 * src/stat.c (isodigit, octtobin, hextobin): Define.
1033 (PRINTF_OPTION): Define.
1034 (interpret_backslash_escapes, trailing_delim): New globals.
1035 (usage): Document them. Alphabetize on long option names.
1036 (print_esc_char): New function.
1037 (print_it): Rewrite, in order to handle backslash escapes.
1038 (main): Handle new option. Set globals for --format, too.
1040 * tests/misc/stat-printf: Test --printf and --format.
1041 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1043 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1045 * NEWS: sort now reports incompatible options.
1046 * src/sort.c (incompatible_options, check_ordering_compatibility):
1048 (main): Use them. Don't bother with a usage message for
1049 "sort -c a b", for consistency with other error diagnostics.
1050 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1053 * src/cat.c (main): Undo previous change. close_stdout already
1054 does the check, so the previous change wasn't necessary.
1056 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1058 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1060 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1062 Install a more-conservative approach for sort -R. It's the
1063 same basic idea as the existing code, except it uses the full ISAAC
1064 approach (called the "more kosher" approach in the existing comments).
1065 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1066 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1067 better to be conservative here at first, and review any performance
1068 improvements carefully.
1069 * .x-sc_require_config_h: Add src/rand-isaac.c.
1070 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1071 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1072 (shred_SOURCES, sort_SOURCES): Remove.
1073 (EXTRA_DIST): Add rand-isaac.c.
1074 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1075 changing it to allow for varying numbers of words in the state.
1076 Alter so that we include rand-isaac.c directly rather than
1077 compiling it and linking to it. Don't include config.h or
1078 system.h; that's the includer's responsibility.
1079 Omit functions that are specific to shred.
1080 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1081 (isaac_step, struct irand_state):
1082 Resurrect these, with the same defns that used to be in shred.c.
1083 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1084 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1086 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1087 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1088 (irand_init, irand32, irand_mod):
1089 Number of words is constant again.
1090 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1091 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1092 * src/sort.c: Likewise.
1093 * src/shred.c (fillrand, dopass, main): Undo previous change.
1094 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1096 * src/sort.c: Don't include md5.h; it wasn't needed.
1097 (struct keyfield): Rename random_hash to random, for consistency
1098 with the other member names. All uses changed.
1099 (usage): Tweak wording to mention STRING for --seed option.
1100 (short_options): Rorder for consistency with other programs.
1101 (rand_state): Now a struct, not a pointer to one. All uses changed.
1102 (HASH_WORDS, HASH_SIZE): Remove.
1103 (get_hash): Remove comments around resbuf size, since we can assume C89.
1104 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1105 (keycompare): Adjust to the new get_hash.
1107 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1108 (main): Don't set need_random simply because gkey has it set; that
1109 doesn't necessarily mean we'll need random numbers.
1110 Redo seeding to match new get_hash approach.
1112 2005-12-10 Jim Meyering <jim@meyering.net>
1114 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1116 Avoid shred segfault on 64-bit systems.
1117 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1118 local of type uint32_t. Make the local an `int' instead.
1120 * NEWS: Mention sort's new options.
1122 * src/rand-isaac.c (isaac_mix): Declare to be static.
1123 Mark all other functions as `extern' so the tight-scope
1124 part of `make distcheck' passes once again.
1125 * src/rand-isaac.h (isaac_mix): Remove declaration.
1127 * src/sort.c (get_hash): Change position of `*' in parameter
1128 type to conform with convention.
1129 (main): Split a long line so it fits in 80 columns.
1130 (keycompare): Remove stray SPACE before TAB that was
1131 causing `make distcheck' to fail.
1133 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1135 * tests/misc/sort-rand: New file: basic tests for the new options.
1136 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1138 2005-12-10 Frederik Eaton <frederik@ofb.net>
1140 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1141 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1142 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1143 Make state size runtime-configurable.
1144 (isaac_new, isaac_copy): New functions.
1145 * src/rand-isaac.h: New file.
1146 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1147 (fillrand, main): Adjust to the fact that the state size is now
1148 runtime-configurable.
1149 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1150 (usage): Add options --random-sort and --seed to implement a random
1152 Include md5.h and rand-isaac.h.
1153 (get_hash): New function.
1154 (rand_state): New var.
1155 (HASH_WORDS, HASH_SIZE): New macros.
1157 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1159 * tests/dd/misc: Add test for dd iflags=noatime.
1161 2005-12-09 Jim Meyering <jim@meyering.net>
1163 * src/sort.c (usage): Mention white space vs -b and -t options.
1166 2005-12-09 Eric Blake <ebb9@byu.net>
1168 * src/test.c (main): Fix misleading comment.
1170 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1172 * NEWS: Mention dd's new noatime flag.
1173 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1174 * src/dd.c (flags, usage): Add support for noatime flag.
1176 2005-12-07 Jim Meyering <jim@meyering.net>
1178 Distribute the cvsu script, used only by `make syntax-check'.
1179 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1180 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1181 distribute a copy of this script.
1182 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1184 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1185 to create a temporary directory on another partition.
1186 From Andreas Gruenbacher.
1188 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1190 * man/basename.x: Cross-reference to dirname and readlink.
1191 * man/dirname.x: Cross-reference to basename and readlink.
1193 2005-12-05 Andreas Gruenbacher
1195 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1196 (set_owner, preserve_author): New functions, factored out of copy_reg.
1197 (copy_reg): Use them.
1198 (copy_internal): Use them here, too.
1200 2005-12-04 Jim Meyering <jim@meyering.net>
1202 * src/sleep.c (usage): Say what happens with two or more arguments.
1203 Suggested by Justin Pryzby.
1205 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1208 2005-12-03 Jim Meyering <jim@meyering.net>
1210 * src/rm.c (long_opts): Change the name of each undocumented, for-
1211 testing-only option to start with `-', so that it cannot render
1212 ambiguous any prefix it happens to share with some other option name.
1213 Problem reported by Eric Blake.
1214 * src/head.c (long_options): Likewise.
1215 * src/tail.c (long_options): Likewise.
1217 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1218 testing-only --presume* options to start with `---'.
1219 * tests/rm/dangling-symlink: Likewise.
1220 * tests/rm/dir-no-w: Likewise.
1221 * tests/rm/isatty: Likewise.
1223 2005-11-30 Jim Meyering <jim@meyering.net>
1225 * Makefile.maint: Add a comment about cvsu.
1227 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1229 * NEWS: df updates for "none", "proc", inaccessible file systems.
1230 * src/df.c (show_point): Ignore inaccessible file systems.
1231 (usage): -a includes dummy file systems, not size-0 file systems.
1233 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1234 to avoid collision with POSIX name space. All uses changed.
1236 2005-11-24 Jim Meyering <jim@meyering.net>
1238 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1239 * tests/acl: Add `$0: ' prefix to diagnostics.
1241 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1243 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1245 * src/copy.c: Improve performance a bit by optimizing away
1246 unnecessary system calls and going to a block size of at least
1247 8192 (on normal hosts, anyway). This improved performance 5% on my
1248 Debian stable host (2.4.27 kernel, x86, copying from root
1249 ext3 file system to itself).
1250 Include "buffer-lcm.h".
1251 (copy_reg): Omit last argument. All callers changed.
1252 Use xmalloc to allocate rather than trusting alloca
1253 (which is unwise with large block sizes).
1254 Declare locals more locally, if possible.
1255 Use uintptr_t words instead of int words, for a bit more speed
1256 when looking for null blocks on 64-bit hosts.
1257 Optimize away reads of zero bytes on regular files.
1258 In the typical case, insist on 8 KiB buffers, at least.
1259 Avoid unnecessary extra call to fstat when checking for sparse files.
1260 Avoid now-unnecessary cast to off_t, and "0L".
1261 Avoid unnecessary test of *new_dst when checking for same owner
1264 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1266 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1268 2005-11-22 Jim Meyering <jim@meyering.net>
1270 * src/remove.c (AD_push): Remove debugging cruft.
1272 * tests/rm/unread2 (rm): Change expected diagnostic,
1273 `cannot open directory' to `cannot remove', to align with
1275 * tests/rm/rm2: Ensure that rm now continues removing entries
1276 even after certain types of failure.
1278 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1279 that provide openat (Solaris), and on systems like Linux+procfs
1280 where our openat emulation code is reentrant. This also fixes a
1281 few low-probability leaks and eliminates some code that could,
1282 in very unusual circumstances, cause rm() (via a callee) to exit.
1283 * NEWS: Mention this.
1285 * configure.ac: Put copyright dates all on one line so the
1286 emacs function that updates them works properly.
1288 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1290 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1291 Problem reported by Eric Blake.
1292 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1293 we get a standard-conforming compiler. This relies on the new
1294 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1295 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1296 m4/c.m4 can go away with Autoconf 2.60 comes out.
1298 2005-11-17 Jim Meyering <jim@meyering.net>
1300 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1301 (AD_mark_current_as_unremovable): Likewise, but for a local.
1304 * tests/mv/acl: Let traps handle removing temporary directories.
1306 Expect acl-related tests to fail, until the corresponding
1307 patches are committed.
1308 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1309 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1311 ACL tests, from Andreas Gruenbacher.
1312 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1313 * tests/mv/Makefile.am (TESTS): Add acl.
1314 * tests/cp/Makefile.am (TESTS): Add acl.
1316 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1318 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1320 * NEWS: Improve quality of ln's diagnostics.
1321 * src/ln.c (do_link, usage): Likewise.
1322 (do_link): Don't use alloca on a buffer of unbounded size.
1324 2005-11-16 Jim Meyering <jim@meyering.net>
1326 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1327 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1328 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1329 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1330 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1332 2005-11-14 Jim Meyering <jim@meyering.net>
1334 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1336 2005-11-13 Jim Meyering <jim@meyering.net>
1338 * announce-gen: Accept new option, --gpg-key-id=ID and
1339 emit a blurb telling how to use the .sig files.
1340 * Makefile.cfg (gpg_key_ID): Define.
1341 * Makefile.maint (announcement): Use new option and key.
1343 Require that most .c files include <config.h>.
1344 * Makefile.maint (sc_require_config_h): New rule.
1345 (syntax-check-rules): Add it.
1346 * .x-sc_require_config_h: New file listing exceptions to the
1347 above rule. Some are legit, others are simply grandfathered in.
1348 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1350 2005-11-12 Jim Meyering <jim@meyering.net>
1352 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1354 2005-11-11 Jim Meyering <jim@meyering.net>
1356 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1357 Mention new readlink options in 5.3.0's `New features' section.
1358 Spotted by Thomas Hood.
1360 2005-11-08 Jim Meyering <jim@meyering.net>
1362 * NEWS: Merge in changes from b5_9x branch.
1364 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1366 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1367 like --time-style='posix-long-iso' if the locale settings are messed up.
1368 * src/ls.c (decode_switches): Implement this.
1370 2005-11-08 Jim Meyering <jim@meyering.net>
1372 * tests/du/2g: s/expensive/very expensive/ in a comment.
1375 2005-10-17 Eric Blake <ebb9@byu.net>
1377 * src/ls.c (usage): Fix descriptions of --sort, --time.
1378 Reported by Vitaly A. Ostanin.
1380 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1382 * src/ln.c: Include filenamecat.c.
1383 (FILE_BASENAME_CONCAT): Remove.
1384 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1385 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1386 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1389 2005-11-04 Jim Meyering <jim@meyering.net>
1391 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1392 on systems with stat.st_blocks of a signed 32-bit type.
1393 This bug causes trouble on some AIX 5.1 systems.
1394 Report and trivial patch from Paul Townsend:
1395 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1396 * NEWS: Mention this.
1398 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1399 * tests/du/Makefile.am (TESTS): Add it here.
1400 * tests/very-expensive: New file.
1401 * tests/Makefile.am (EXTRA_DIST): Add it here.
1402 * tests/cp/perm: Mark this test as `very-expensive', too.
1404 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1406 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1408 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1410 * src/rm.c (usage): Don't mention rm -d.
1412 2005-11-02 Jim Meyering <jim@meyering.net>
1414 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1415 From Andreas Schwab.
1417 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1418 `M+N records in/out' lines don't pollute `make check' output.
1420 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1421 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1422 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1423 to indicate that the input file should be piped into the command
1424 under test (via `cat FILE | $prog ...').
1426 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1427 (without -r) fails to remove a directory on a non-Linux system.
1428 This change affects only newer Solaris systems (with priv_*
1429 functions like priv_allocset). Reported by Keith Thompson.
1431 * tests/rm/dir-nonrecur: New file/test for the above fix.
1432 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1434 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1436 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1437 POSIX 1002.1-2001 requires.
1438 * src/tail.c (parse_obsolete_option): Implement this.
1439 Problem reported by Vincent Lefevre.
1440 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1441 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1442 (test_vector): Add special cases for _POSIX2_VERSION, and
1443 regularize the old ones a bit.
1444 * tests/touch/obsolescent: Add y2000 test.
1446 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1448 * src/dd.c (skip): Fix off-by-one error reported by
1449 Theodoros V. Kalamatianos.
1451 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1453 * tests/mkdir/p-3: Require that the test be run as non-root.
1454 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1456 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1458 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1459 boundary between DEST and SOURCE in the result.
1461 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1463 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1464 back to text, to sync with documentation and for backwards
1467 2005-10-25 Jim Meyering <jim@meyering.net>
1469 * tests/dircolors/simple (other-wr): Add an explicit test for
1470 the dircolors bug (NULL-dereference) fixed yesterday.
1472 2005-10-24 Jim Meyering <jim@meyering.net>
1474 * src/tac.c (tac_file): When determining whether a file is seekable,
1475 also test whether it is a tty. Using only the lseek-based test would
1476 give a false positive on Solaris. Reported by Peter Fales.
1478 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1480 * tests/install/d-slashdot: New test, for "install -d" failure.
1481 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1482 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1483 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1485 2005-10-24 Jim Meyering <jim@meyering.net>
1487 * src/dircolors.c (ls_codes): Add missing comma.
1488 Anonymous report and patch from
1489 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1491 * src/dircolors.c: Add compile-time assertion that the slack_codes
1492 and ls_codes arrays have the same number of elements. This would
1493 have prevented the above-fixed bug.
1495 * src/expand.c (parse_tab_stops): Add a comment to make this function
1496 identical to the one in unexpand.c.
1497 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1498 identical to the one in expand.c.
1500 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1502 2005-10-23 Jim Meyering <jim@meyering.net>
1504 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1505 a dangerous pointer-value-to-`unsigned' cast.
1506 * NEWS: mention the new sha* programs.
1507 * AUTHORS: Add new sha* programs.
1509 2005-08-28 David Madore <david.madore@ens.fr>
1511 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1512 * README: Add their names to the list.
1513 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1514 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1515 Rules for compiling sha-2 utilities
1516 (noinst_HEADERS): Remove checksum.h.
1517 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1519 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1520 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1521 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1522 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1523 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1524 sha384sum, sha512sum test scripts here rather that each in its
1527 2005-08-28 David Madore <david.madore@ens.fr>
1529 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1530 of the FIPS test vectors).
1532 2005-10-23 Jim Meyering <jim@meyering.net>
1534 * configure.ac: Use 6.0-cvs as the version string.
1535 * NEWS: Adjust accordingly.