1 2006-06-19 Jim Meyering <jim@meyering.net>
3 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
4 so this check is not run as part of "make distcheck".
6 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
8 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
10 2006-06-18 Jim Meyering <jim@meyering.net>
12 * tests/misc/pwd-long: Make error output a little clearer.
14 2006-06-17 Jim Meyering <jim@meyering.net>
16 * tests/rm/inaccessible: Skip this test on systems without openat
17 support. Reported by Bob Proulx.
19 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
21 * tests/misc/mknod: Improve permission checks to handle
22 running mkdir test in set-gid directories.
24 2006-06-14 Jim Meyering <jim@meyering.net>
26 * tests/du/basic: Revamp not to hard-code file system block sizes.
28 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
30 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
33 2006-06-11 Jim Meyering <jim@meyering.net>
35 * .gitignore: New file.
36 * Makefile.am (EXTRA_DIST): Add .gitignore.
38 Setting TIME_STYLE=long-iso in the environment would make the
39 cp/same-file test fail.
40 * tests/envvar-check (vars): Add TIME_STYLE to the list.
41 * tests/cp/same-file: Revert last change.
42 Source the envvar-check script, to ensure that TIME_STYLE
43 settings don't affect these tests.
45 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
47 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
48 uses POSIX time stamp formats. Problem reported by John Nixon in
49 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
51 2006-06-10 Jim Meyering <jim@meyering.net>
53 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
55 Require a "Version N.M" line at the top of the ChangeLog
56 file only when making the actual release, not when running
58 * Makefile.maint (maintainer-distcheck): Don't depend on
60 (alpha beta major): Depend on it here, instead.
62 2006-06-08 Jim Meyering <jim@meyering.net>
64 Ensure that cat works with any of the options, -A -v -e -E -T,
65 when applied to files in /proc and /sys, even when the FIONREAD
66 ioctl produces nonsensical results. Before this change, cat would
67 produce no output (or truncated output), for some linux kernels.
69 * src/cat.c (write_pending): New function, factored out of cat.
70 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
71 that there are bytes to read. Some versions of linux-2.6.16 do that.
72 Write any pending output before returning.
73 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
74 * NEWS: Mention this bug fix.
75 * tests/misc/cat-proc: New file. Test for the above.
76 * tests/misc/Makefile.am (TESTS): Add cat-proc.
78 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
80 * src/expr.c (eval4): Detect overflow properly when multiplying
83 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
85 * NEWS: The 'expr' command now detects and reports integer overflow.
86 (It would be better to use extended precision instead, but that
88 * src/expr.c (integer_overflow): New function.
89 (eval4, eval3): Check for integer overflow.
91 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
93 Fix problems when building with Solaris/SVR4/etc. make, which uses a
94 different and somewhat bogus implementation of VPATH. In the
95 directory tests/misc, rename tests whose names might appear in the
96 Automake-generated rules. For example, we can't use a test named
97 'test', since Automake generates a rule that contains the text
98 "if test -f ./$$tst; ...", and this might expand to something like
99 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
100 which executes the 'test' script rather than the 'test' command.
101 * tests/misc/false-status: Renamed from tests/misc/false.
102 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
103 * tests/misc/sort-merge: Renamed from tests/misc/sort.
104 ($prog): Set to 'sort' rather than to $PROG.
105 * tests/misc/test-diag: Renamed from tests/misc/test.
106 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
107 in case Solaris make has prepended the directory.
108 (TESTS): Adjust to above renamings.
109 * tests/misc/expand: Don't assign to PROG; no longer needed
110 now that Makefile.am sets PROG to the basename.
111 * tests/misc/fold: Likewise.
113 2006-06-03 Jim Meyering <jim@meyering.net>
115 Make `cp --link --no-dereference' work also on systems where the
116 link system call cannot create a hard link to a symbolic link.
117 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
118 the link syscall on a symlink when it would do the wrong thing.
119 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
120 * tests/cp/link-no-deref: New file/test for the above.
121 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
122 * NEWS: Mention the change (doesn't affect Linux).
124 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
126 Fix some porting problems in the test cases reported by
127 Ralf Wildenhues for HP-UX 11.23 in:
128 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
129 * tests/help-version: Don't assume that \< \> works in sed.
130 * tests/misc/close-stdout: Don't assume that >&- works.
131 Add a /dev/full test.
132 * tests/touch/no-create-missing: Don't assume that >&- works.
134 2006-05-30 Jim Meyering <jim@meyering.net>
136 * src/ls.c (usage): Add `v' to the list of sorting-related options.
139 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
141 * tests/cp/fail-perm: source lang-default.
142 * tests/rm/inaccessible: Likewise.
144 2006-05-28 Jim Meyering <jim@meyering.net>
146 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
147 Recognize it, too. Reported by Ralf Wildenhues, in
148 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
150 2006-05-27 Jim Meyering <jim@meyering.net>
152 * src/chgrp.c: Support new options: --preserve-root and
153 --no-preserve-root. Somehow this program was skipped when those
154 options were added to chown, chmod, and rm. Reported by
155 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
156 * NEWS: Mention this.
158 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
160 * NEWS: Remove mention of --seed. We'll replace it with something
161 better, and don't want to indicate that it is supported.
162 * src/sort.c (usage): Likewise.
164 2006-05-20 Jim Meyering <jim@meyering.net>
166 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
168 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
169 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
170 FTS_COMFOLLOW. Spotted by Justin Pryzby.
172 * gnupload: Merge changes from automake, retaining the ""--to...
173 kludge to placate overzealous `make distcheck' check.
175 2006-05-19 Jim Meyering <jim@meyering.net>
177 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
178 FTS_TIGHT_CYCLE_CHECK directory traversal option.
179 Reported by Justin Pryzby in http://bugs.debian.org/367691
181 2006-05-15 Jim Meyering <jim@meyering.net>
183 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
186 2006-05-13 Jim Meyering <jim@meyering.net>
188 * tests/mv/no-target-dir: Test two more cases.
190 2006-05-11 Jim Meyering <jim@meyering.net>
192 mv -T DIR EMPTY_DIR no longer fails unconditionally
193 * src/copy.c (copy_internal): Don't manually prohibit a move where
194 the destination is an existing directory. Sometimes doing that is
195 valid. Let the rename system call enforce the rules. That is
196 allowed only when the source is a directory and the destination
197 directory (to be replaced) is empty. Reported by Eric Blake.
198 * tests/mv/no-target-dir: New file/test for this.
199 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
200 * NEWS: Mention this.
202 * tests/mv/atomic: New file/test for yesterday's fix.
203 * tests/mv/Makefile.am (TESTS): Add atomic.
205 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
207 2006-05-10 Jim Meyering <jim@meyering.net>
209 * src/copy.c (copy_internal): Don't explicitly unlink the destination
210 when moving a symlink into the place of an existing non-directory.
211 Reported by Joshua Hudson.
212 * NEWS: mention this.
214 2006-05-07 Jim Meyering <jim@meyering.net>
216 * Makefile.maint (patch-check): Fail if patch generates any output,
217 even merely for changed offsets.
219 * src/c99-to-c89.diff: Adjust to reflect new offsets.
221 * NEWS: Mention changes affecting df, pwd, shred.
223 2006-05-06 Jim Meyering <jim@meyering.net>
225 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
226 system condition where dirent.d_ino != stat.st_ino.
227 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
229 2006-05-06 Eric Blake <ebb9@byu.net>
231 * tests/ls/inode: Expand to test inode from readdir case.
232 * tests/ls/follow-slink: Expand to test broken links encountered
233 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
235 2006-05-06 Eric Blake <ebb9@byu.net>
237 * tests/mv/leak-fd: Work even on case-insensitive file system.
239 2006-05-04 Jim Meyering <jim@meyering.net>
241 * NEWS: Mention the 2006-03-19 pwd-related change that makes
242 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
244 2006-05-03 Jim Meyering <jim@meyering.net>
246 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
247 Use better macro parameter names: s/basename/key_name/,
248 s/basefunc/key_cmp_func. Fix typo in comment.
250 2006-04-29 Eric Blake <ebb9@byu.net>
252 * src/ls.c (main): On systems with d_type, directories_first only
253 implies format_needs_type, not format_needs_stat.
255 2006-05-03 Jim Meyering <jim@meyering.net>
257 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
258 after comma in arg list, from Eric Blake.
260 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
262 * tests/misc/date (relative-3): New test, derived from a bug
263 report by John Thomas McDole.
265 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
267 New option for ls: --group-directories-first.
268 It makes ls list directories before files.
269 * NEWS [New features]: Mention it.
270 * src/ls.c (sort_type): Rearrange to use as an array index when
271 choosing sort function; added new sort_numtypes member for
273 (time_type): Add new time_numtypes member for compile-time check.
274 (directories_first): New global variable.
275 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
276 (long_options): Add --directories-first.
277 (main): Support new option.
278 (is_directory): New function.
279 (extract_dirs_from_files): Use it.
280 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
281 (LIST_SORTFUNCTION_VARIANTS): New macros.
282 (sort_functions): New global variable.
283 (sort_files): Use it.
284 (usage): Document new option.
286 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
288 * src/shred.c (fillrand): The assertion was way too weak, due to
289 what must be a typo. Strengthen it to its intended value.
290 (dopass): Don't use alloca; it's not worth the aggravation here,
291 since it's used only to get a page-aligned buffer, and page
292 alignment doesn't buy us much here. I'm suspicious that alloca
293 causes problems on some hosts, due to a recent bug report by Adam
294 Waltman: http://bugs.gentoo.org/130246.
296 2006-04-18 Jim Meyering <jim@meyering.net>
298 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
299 sha384sum, sha512sum.
301 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
303 * src/chmod.c (describe_change): Adjust to filemode changes.
304 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
305 (print_long_format): Use (new) filemodestring rather than
306 (old) mode_string, so that we get more file types right, at least
307 in theory. Adjust to filemode changes.
308 * src/stat.c (human_access): Likewise.
310 2006-04-18 Jim Meyering <jim@meyering.net>
312 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
313 ignore file. This has never been enabled. Reported by Eric Blake.
315 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
317 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
318 bug in Interix. Just call symlink or link directly. All uses changed.
319 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
320 * src/stat.c (USE_STATVFS): New macro.
321 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
322 (NAMEMAX_FORMAT): define a bit more clearly, now that the
323 statvfs-using code is a bit more regular.
324 * src/system.h (sync) [!HAVE_SYNC]: New macro.
326 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
328 * NEWS: csplit, nl, expr now conform to POSIX better, and are
329 more-compatible with traditional Unix, with respect to regular
331 * src/csplit.c (extract_regexp): Set re_syntax_options to a
332 value that is compatible with what POSIX requires.
333 * src/nl.c (build_type_arg): Likewise.
334 * src/expr.c (docolon): Likewise. Also, don't let anchors match
335 newline; this fixes an incompatibility with tradition and with POSIX.
336 Don't warn about leading ^. POSIX says it is unspecified whether
337 ^ is a special character, which means that implementations can
338 either treat it as special or not, but either way a warning is not
339 allowed (unless the regexp is otherwise invalid). Instead, anchor
340 the expression but treat ^ as an anchor; this is the traditional
341 behavior (e.g., Solaris 10).
342 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
343 and the like as invalid expressions (exit status 2), not as
344 failure of 'expr' (exit status 3). This is more consistent with
346 * tests/expr/basic (fail-a): Adjust exit status to match new expr
347 behavior, for status 2 versus 3.
349 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
350 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
351 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
352 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
353 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
354 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
355 (bre61, bre62): New tests.
356 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
360 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
361 "if !". Do not assume that 'sed' can handle long, newline-free input.
362 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
364 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
366 Adjust to new regex.h API (with new fastmap type), and clean
367 up the regex storage allocation a bit.
369 * src/csplit.c (struct control): Put re_compiled member at the
370 end, since it's large. Change regexpr member from char * to bool;
371 all uses changed. Add new member fastmap.
372 (extract_regexp): regexp arg is now char const *, not char *.
373 Don't bother duplicating the regular expression; it's not needed.
374 Set fastmap from new fastmap member. Don't bother allocating
375 a buffer, as the regexp code does a better job than we do.
376 * src/expr.c (docolon): Allocate and use a fastmap.
377 Don't bother allocating a buffer.
378 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
380 (build_type_arg): New fastmap arg. All uses changed.
381 Don't bother allocating a buffer, but set a fastmap.
382 * src/ptx.c (context_regex_string, word_regex_string): Remove.
383 (context_regex, word_regex): New vars, replacing the above.
385 (struct regex_data): New type.
386 (compile_regex): Renamed from alloc_and_compile_regex, since
387 we no longer allocate storage. Arg is now a struct regex_data *,
388 not a const char *. All uses changed. Don't allocate the fastmap;
389 instead, take it from the caller. Don't convert size_t to int,
390 to avoid arithmetic overflow problems. Don't bother freeing
391 storage afterwards; it's not worth the aggravation.
392 * src/tac.c (compiled_separator_fastmap): New ver.
393 (main): Use it. Don't bother allocating a buffer.
395 2006-03-30 Jim Meyering <jim@meyering.net>
397 * src/dd.c (iwrite): Remove assignment without effect.
398 Reported by Felix Rauch Valenti.
400 2006-03-22 Eric Blake <ebb9@byu.net>
402 * src/ptx.c (usage): Remove mention of --copyright/-C.
403 (main): Alias --copyright to --version plus a deprecation warning.
404 * NEWS: Mention this.
406 2006-03-27 Jim Meyering <jim@meyering.net>
408 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
409 use of strtod. Tiny patch from Nickolai Zeldovich.
411 2006-03-11 Eric Blake <ebb9@byu.net>
413 * tests/misc/dirname: New file.
414 * tests/basename/Makefile.am: Delete.
415 * tests/basename/basic: Move to...
416 * tests/misc/basename: ... this new file. Add some tests,
417 including fixed behavior for //.
418 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
419 * tests/Makefile.am (SUBDIRS): Remove basename.
420 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
422 Improvements to dirname/basename handling on platforms like
423 cygwin with distinct // and with drive letters.
424 * NEWS: Document new behavior.
425 * src/basename.c (main): Don't strip suffix from file system
427 * src/cp.c (target_directory_operand): Use new last_component.
428 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
429 traversing the string.
430 * src/dircolors.c (guess_shell_syntax): Use new last_component.
431 * src/install.c (target_directory_operand, install_file_in_dir):
433 * src/ln.c (target_directory_operand, main): Likewise.
434 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
435 * src/mv.c (target_directory_operand, movefile): Likewise.
436 * src/remove.c (rm_1): Likewise.
437 * src/shred.c (wipename): Likewise.
438 * src/split.c (next_file_name): Likewise.
439 * src/su.c (log_su, run_shell): Likewise.
441 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
443 * NEWS: nohup diagnostics are now more precise, and nohup now
444 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
445 * src/nohup.c (main): Implement this.
446 * tests/misc/nohup: Test the new behavior.
448 2006-03-12 Jim Meyering <jim@meyering.net>
450 * src/copy.c (set_author): Rename function, from preserve_author.
452 * src/remove.c (AD_pop_and_chdir): Use new macro,
453 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
455 * src/system.h (SAME_INODE): Remove definition.
456 Include "same-inode.h", instead.
458 2006-03-11 Eric Blake <ebb9@byu.net>
460 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
462 2006-03-10 Jim Meyering <jim@meyering.net>
464 Fix a bug whereby a user with write access to a directory being removed
465 could cause the removal of that directory to fail with an erroneous
466 diagnostic about a directory cycle. Reported by Vineet Chadha.
468 * NEWS: Mention this.
469 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
470 leave (and try to rmdir) is the one whose dev_ino is being used to
471 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
473 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
475 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
476 * src/dd.c (set_fd_flags): Handle file-creation flags on file
477 descriptors, rather than ignoring them.
478 * tests/dd/misc: Add test cases for append, nofollow, directory,
479 and nolinks flags. Simplify redirection to /dev/null in some cases.
481 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
482 noatime test never tested anything.
484 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
486 * src/dd.c (flags, usage): New flags directory, nolinks.
487 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
489 * src/ls.c (usage): Mention that -f disables --color.
490 Problem reported by Niels Möller.
492 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
494 * man/*.x: Add references to syscalls from utilities of the same name.
496 2006-03-05 Jim Meyering <jim@meyering.net>
498 * tests/help-version: Set SHELL, if not already set, in order to
499 avoid failure when `make check' is run through debuild; dircolors
500 would fail due to lack of $SHELL. Reported by Sven Joachim.
502 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
503 * src/base64.c (wrap_write, do_encode, main): Change type of
504 parameters and locals, wrap_column, form size_t to uintmax_t.
505 (main): Adjust to use xstrtoumax, accordingly.
507 2006-03-03 Jim Meyering <jim@meyering.net>
509 Don't fail when run from an environment with SHELL not a Bourne
510 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
511 * tests/dircolors/simple: Invoke each non-failing test with -b.
512 Reported by Michael Stone.
514 2006-02-27 Jim Meyering <jim@meyering.net>
516 * tests/misc/base64: Derive --decode-using tests from the
519 * tests/misc/base64: Factor out a long constant string.
520 Split lines to stay within 80 columns.
522 * tests/misc/Makefile.am (TESTS): Add base64.
523 * tests/misc/base64: Test base64. From Simon Josefsson.
525 * src/base64.c (do_decode): Use correct type for parameter,
526 ignore_garbage: s/size_t/bool/.
528 * src/base64.c: Don't include .h files already included by system.h:
529 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
530 Include "system.h" before the other lib/*.h header files.
531 Include <sys/types.h> before "system.h".
532 (wrap_write): Remove declaration of unused local, initial_column.
533 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
535 * README: Add base64 to the list.
537 2006-02-17 Simon Josefsson <jas@extundo.com>
540 * AUTHORS: Mention base64.
542 * man/Makefile.am: Build base64.1.
543 * man/base64.x: New file.
544 * src/Makefile.am (bin_PROGRAMS): Add base64.
545 * src/base64.c: New file.
547 2006-02-25 Eric Blake <ebb9@byu.net>
549 In ls, avoid calling stat for --inode (-i), when possible.
550 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
551 * src/system.h: ... here, for use in ...
552 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
554 (gobble_file): Add inode argument.
555 (print_dir): Pass inode if available.
556 (usage): Remove inaccuracy.
558 2006-02-23 Jim Meyering <jim@meyering.net>
560 * TODO: Update/correct some obsolete entries.
562 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
564 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
565 * src/join.c (usage): Likewise.
566 Documentation problem reported by Philip Kensche.
568 2006-02-20 Eric Blake <ebb9@byu.net>
570 * man/rm.x: Update documentation to match previous patch.
572 2006-02-18 Eric Blake <ebb9@byu.net>
574 New option for rm: --interactive=once (-I).
575 * NEWS: Document it, along with change to rm --interactive.
576 * TODO: Remove entry for implementing rm -I
577 * src/rm.c (INTERACTIVE_OPTION): New enum value.
578 (interactive_type): New enum.
579 (long_opts): Let interactive take an optional argument.
580 (interactive_args, interactive_types): New option arguments.
581 (usage): Document -I, --interactive=WHEN. Use program_name
582 instead of a basename.
583 (main): New -I option, new behavior to --interactive.
584 * tests/rm/interactive-once: New tests.
585 * tests/rm/interactive-always: Ditto.
586 * tests/rm/Makefile.am (TESTS): Run them.
588 2006-02-18 Jim Meyering <jim@meyering.net>
590 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
591 expression match more of the target lines, e.g., those that start with
592 `-S,' (short option followed by a comma) or that include `=[...]'.
593 Patch by Nicolas François.
594 Fix the four offenders thus exposed:
595 * src/join.c (usage): Use two spaces (not one) to separate the
596 --first-only option string from its description, so help2man formats
597 the derived man page properly.
598 * src/pr.c (usage): Likewise.
599 * src/uniq.c (usage): Likewise.
600 * src/install.c (usage): Likewise.
602 2006-02-15 Jim Meyering <jim@meyering.net>
604 * Makefile.maint (alpha beta major): For `make major', ensure that the
605 version string is of the form N.N[.N]*, where N is one or more digits.
607 2006-02-14 Jim Meyering <jim@meyering.net>
609 * INSTALL: Update from gnulib.
611 2006-02-13 Jim Meyering <jim@meyering.net>
613 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
615 2006-02-12 Jim Meyering <jim@meyering.net>
617 * Makefile.maint (patch-check): New target.
618 (local-checks-available): Add to the list.
620 2006-02-11 Jim Meyering <jim@meyering.net>
622 * src/c99-to-c89.diff: New file.
623 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
625 * .x-po-check: New file, with exclusions so that `make distcheck'
627 * Makefile.am (EXTRA_DIST): Add .x-po-check.
629 rm -r must remove an empty directory, even if it is inaccessible.
630 * src/remove.c (close_preserve_errno): New function.
631 (fd_to_subdirp): Don't print a diagnostic in this function.
632 Do it from the callers instead, unless rmdir succeeds.
633 (remove_cwd_entries, remove_dir): Adjust callers.
634 * tests/rm/empty-inacc: New test for the above.
635 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
636 * NEWS: Mention this bug fix.
637 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
638 a tiny bit less precise: cannot remove `a/1': ... instead of
639 cannot open directory `a/1': ...
641 * Makefile.maint (syntax-check-rules): Automatically derive this
642 list of sc_-prefixed rule names.
644 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
646 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
647 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
648 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
649 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
650 go away? was that an accident?)
651 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
652 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
653 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
654 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
655 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
656 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
657 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
658 (author_mark_check, makefile_path_separator_check):
659 Output line numbers, to simplify navigation of Emacs *compilation*
661 (sc_prohibit_atoi_atof, sc_file_system):
662 Rework slightly so that Makefile.maint doesn't get reported as a
663 violation of its own syntax rules.
664 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
665 it at run-time (which didn't work with Bison). Fix a makefile typo,
666 caught by Makefile.maint itself: spaces where a tab should be.
667 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
668 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
669 Ignore djgpp and man subdirectories, to avoid false matches with
670 Bison and coreutils, respectively. Use sort -u to remove the
671 resulting duplicates.
672 * gnupload: Rework slightly to avoid bogus warning from
673 sc_two_space_separator_in_usage.
675 2006-02-10 Jim Meyering <jim@meyering.net>
677 Use gzip's --rsyncable option only if it's available.
678 * Makefile.maint (gzip_rsyncable): New variable.
681 2006-02-08 Jim Meyering <jim@meyering.net>
683 * Makefile.maint (local-checks-available): Define in terms of
684 the expansion, $(syntax-check-rules), rather than the single,
685 top-level target `syntax-check', so that it's easier to exclude
686 individual rules (via $(local-checks-to-skip)).
687 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
689 2006-02-07 Jim Meyering <jim@meyering.net>
691 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
692 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
694 * tests/help-version (expected_failure_status_vdir):
695 Redirect an expected disk-full diagnostic to /dev/null.
697 2006-02-06 Jim Meyering <jim@meyering.net>
699 * src/unexpand.c (usage): Use two spaces (not one) to separate the
700 --first-only option string from its description, so help2man formats
701 the derived man page properly.
702 * src/rm.c (usage): Likewise for --no-preserve-root.
703 * src/chown.c (usage): Likewise.
704 * src/chgrp.c (usage): Likewise.
706 Add a rule to ensure that the above doesn't happen again.
707 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
708 (syntax-check-rules): Add it.
709 * .x-sc_two_space_separator_in_usage: New empty file.
710 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
712 2006-02-06 Jim Meyering <jim@meyering.net>
714 * src/cp.c (usage): Use two spaces (not one) to separate each
715 option string from its description, so help2man formats the
716 derived man page properly.
717 * src/mv.c (usage): Likewise.
718 Patch from Nicolas François in http://bugs.debian.org/351601.
720 2006-02-04 Jim Meyering <jim@meyering.net>
722 * src/copy.c (copy_internal): cp -RL would fail when encountering
723 the same directory more than once in the hierarchy beneath a single
724 command-line argument. That is legitimate, e.g. when there are
725 two or more symbolic links, each pointing to some directory that
726 would not otherwise be copied. Reported by Christophe LYON.
727 * tests/cp/cp-deref: New file. Test for today's fix.
728 * tests/cp/Makefile.am (TESTS): Add cp-deref.
729 * NEWS: Document this.
731 2006-02-03 Jim Meyering <jim@meyering.net>
733 * configure.ac: Require automake-1.9.6, not 1.8.3.
735 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
737 * src/od.c (usage): Mention that -t a ignores high order bit.
738 Documentation problem reported by Ed Avis.
740 2006-02-01 Jim Meyering <jim@meyering.net>
742 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
744 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
746 * src/head.c (main): Use a better diagnostic when someone uses a
747 trailing numeric option in an invalid way. Problem reported by
749 * src/tail.c (parse_options): Likewise.
751 2006-01-30 Jim Meyering <jim@meyering.net>
753 * man/wc.x: Include `count' keyword in man page synopsis,
754 per suggestion from http://bugs.debian.org/181585.
756 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
758 * src/df.c (show_dev): If the file system claims to have
759 more available than total blocks, report the number of used
760 blocks as being total - available (a negative number) rather
761 than as garbage. Problem reported by Toralf Foerster.
763 2006-01-24 Jim Meyering <jim@meyering.net>
765 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
766 to put a regular file in O_NONBLOCK mode fails with EPERM.
767 That happens on Linux (up to 2.6.15) when using tail -f on a file with
768 the append-only attribute. Reported by Dean Gaudet. For details,
769 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
770 * NEWS: Mention this fix.
771 * tests/tail-2/append-only: New file. Test for the above.
772 * tests/tail-2/Makefile.am (TESTS): Add append-only.
773 * tests/Makefile.am (check-root): Add tail-2/append-only
775 2006-01-21 Jim Meyering <jim@meyering.net>
777 * NEWS: Mention fts-related improvements and bug fixes.
779 2006-01-19 Jim Meyering <jim@meyering.net>
781 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
782 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
784 2006-01-18 Jim Meyering <jim@meyering.net>
786 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
788 2006-01-17 Jim Meyering <jim@meyering.net>
790 Now that fts no longer changes the current working directory, adjust
791 its clients accordingly -- note that du.c uses fts but doesn't need
792 any adjustment, since it doesn't operate on the actual files,
793 but rather just uses the stat buffers provided by fts.
795 * src/chown-core.c: Include "openat.h".
796 Don't include "lchown.h".
797 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
798 calling openat, lchownat, chownat, rather than open, lchown, chown.
800 * src/chmod.c: Include "openat.h".
801 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
803 * tests/du/long-from-unreadable: New test, to exercise one small
806 2006-01-13 Jim Meyering <jim@meyering.net>
808 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
809 addition of new directories under tests/.
811 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
814 2006-01-12 Jim Meyering <jim@meyering.net>
816 * tests/du/long-sloop: Adjust not to hard-code the expected
817 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
818 from that of GNU libc. Reported by Paul Eggert.
820 * tests/du/long-sloop: Create file at end of symlink chain.
822 * tests/misc/test: New file, with a test for one of the
823 bugs fixed by yesterday's test.c changes.
824 * tests/misc/Makefile.am (TESTS): Add test.
826 2006-01-11 Jim Meyering <jim@meyering.net>
828 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
829 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
830 a very long sequence of symbolic links (not necessarily a loop).
831 * tests/du/Makefile.am (TESTS): Add long-sloop.
833 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
835 * src/test.c (test_syntax_error): Append a newline. All callers
836 changed, except for the ones that didn't already append a newline.
837 Bug reported by Eric Blake.
839 2006-01-11 Jim Meyering <jim@meyering.net>
841 * src/system.h (X2NREALLOC): Now that verify_true is no longer
842 void, cast its result to void, to avoid gcc's warning that
843 ``left-hand operand of comma expression has no effect''.
844 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
846 2006-01-10 Jim Meyering <jim@meyering.net>
848 * tests/chmod/no-x: Add a test for today's fts.c fix.
850 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
852 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
853 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
855 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
857 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
858 Use verify_true instead of verify_expr, to sync with gnulib.
860 2006-01-08 Jim Meyering <jim@meyering.net>
862 * src/date.c (usage): Adjust the formatting of the entries for
863 %::z and %:::z (separate with two spaces, not one) so that help2man
864 formats them properly. Reported by Philip Rowlands.
866 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
868 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
870 2006-01-06 Jim Meyering <jim@meyering.net>
872 * Makefile.maint (copyright-check): Use date +%Y in place of
875 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
876 First off, the attribute should have been `volatile' (not static)
877 to avoid longjmp-related risk of clobber. Secondly, now there is
878 no longer any risk of a local variable being clobbered, so there's
879 no need for any attribute at all.
881 2006-01-05 Jim Meyering <jim@meyering.net>
883 * src/remove.c: Give a few functions the inline attribute.
884 (AD_pop_and_chdir): Use gotos to avoid some duplication.
885 (AD_push): Rewrite an assertion so that the entire computation
886 goes away when assertions are turned off.
888 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
889 It's already defined in "system.h".
890 * Makefile.maint: Add a FIXME comment.
892 2006-01-04 Jim Meyering <jim@meyering.net>
894 * ChangeLog: Remove entries from 2005-10-22 and earlier.
895 * ChangeLog-2005: New file, for entries up to version 5.92.
897 2006-01-03 Jim Meyering <jim@meyering.net>
899 * tests/du/no-x: Also allow a slightly different diagnostic -- the
900 one you get when using openat-enabled fts.c and du (coming soon).
901 * tests/chmod/no-x: Likewise.
902 * tests/chgrp/no-x: Likewise.
904 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
906 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
908 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
909 (restricted_chown): Return it, if the file cannot be accessed due
910 to EPERM, or if no uid or gid are required, or if the file is
911 neither a directory nor a regular file. Rewrite to avoid gotos.
912 (change_file_owner): Handle RC_do_ordinary_chown case.
913 Rewrite to avoid gotos.
914 * tests/chgrp/basic: Make sure we can change the group of
917 * src/date.c (usage): Explain %g, %G, and %V a bit better.
919 2006-01-02 Jim Meyering <jim@meyering.net>
921 * src/copy.c (set_owner): Correct a comment.
923 * src/tail.c (parse_options): Change warning to say that --retry
924 is useful `mainly' (not `only') when following by name.
925 Reported here: http://bugs.debian.org/273781
927 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
929 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
930 * src/copy.c: Include lchmod.h.
931 (copy_internal): Use lchmod rather than chmod.
932 * src/cp.c: Include lchmod.h.
933 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
934 * src/mkdir.c: Include lchmod.h.
935 (usage): Clarify -m's operation.
936 (main): Use lchmod rather than chmod. Don't use lchmod unless the
937 new mode contains bits outside the 777 range.
938 * src/mkfifo.c (usage): Clarify -m's operation.
939 (main): If -m is given, don't invoke chmod; use umask 0 instead.
940 Report an error if -m asks for bits outside the 777 range.
941 * src/mknod.c (usage, main): Likewise.
943 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
945 2005-12-27 Jim Meyering <jim@meyering.net>
947 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
948 (sc_prohibit_assert_without_use): New rule.
949 (syntax-check-rules): Add it to the list.
950 * .x-sc_prohibit_assert_without_use: New empty file.
951 * Makefile.am (EXTRA_DIST): Add it.
953 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
955 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
956 Don't include <assert.h>; it wasn't used.
958 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
960 * src/chown-core.c (restricted_chown):
961 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
962 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
963 | O_NOFOLLOW too, for consistency with other dir-openers.
964 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
965 (is_empty_dir): Likewise.
966 * src/shred.c (wipename): Likewise. Don't bother trying to open
967 dir for writing, since POSIX prohibits it.
969 2005-12-22 Jim Meyering <jim@meyering.net>
971 * tests/help-version: Redirect stderr to /dev/full, to suppress
972 write error diagnostic.
974 2005-12-19 Jim Meyering <jim@meyering.net>
976 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
977 Avoid a minor race condition when `-m MODE' is specified, by using
978 open, fchown, and close rather than just chown. To do that reliably --
979 even with an overly restrictive umask -- ensure that each mkdir,
980 mknod and mkfifo call uses a mode including at least owner-read access.
981 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
982 the subsequent chown (or equivalent open,fchown,close) fails.
983 * tests/misc/mknod: New tests.
984 * tests/misc/Makefile.am (TESTS): Add mknod.
986 2005-12-17 Jim Meyering <jim@meyering.net>
988 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
989 e.g., on a named pipe.
990 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
991 place of all uses, since it is guaranteed (system.h) to be defined.
993 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
995 Add POSIX ACL support
996 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
997 is no requirement for ACL support; particularly, it does not exist
998 on systems that have POSIX ACLs.
999 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1000 * src/cp.c (umask_kill): With default acls, the umask is not to be
1001 applied. Remove umask_kill, don't change the process umask, and let
1002 the kernel apply the umask where appropriate.
1003 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1004 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1006 (copy_reg, copy_internal): Use copy_acl and set_acl
1007 instead of fchown/chown. Fix the logic for POSIX ACLs.
1008 (chown_succeded): Remove; we now always copy acls and
1009 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1010 did a chown before or not.
1011 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1012 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1013 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1014 to link with it via $(LIB_ACL), for the utilities that need it.
1016 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1018 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1019 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1020 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1021 value is now signified by whether cwd_errno is null.
1022 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1023 pointer-to-bool to pointer-to-errno-value. All callers changed.
1024 (rm_1): Don't bother setting a local cwd failure flag and then
1025 ORing it into the caller's. Just set the caller's.
1026 (rm): Use cwd failure errno value to print a slightly-better
1029 2005-12-15 Jim Meyering <jim@meyering.net>
1031 * src/stat.c (print_it): Properly handle a backslash at the
1032 end of a --printf format string. Reported by Paul Eggert.
1033 * tests/misc/stat-printf (end-bs): Add a test for the above.
1035 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1037 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1038 Don't assume /etc/passwd contains user names; use 'id' instead.
1040 2005-12-15 Jim Meyering <jim@meyering.net>
1042 stat: revert behavior of --format=FMT (-c)
1043 stat: add new option: --printf=FMT
1044 * NEWS: Mention this.
1045 * src/stat.c (isodigit, octtobin, hextobin): Define.
1046 (PRINTF_OPTION): Define.
1047 (interpret_backslash_escapes, trailing_delim): New globals.
1048 (usage): Document them. Alphabetize on long option names.
1049 (print_esc_char): New function.
1050 (print_it): Rewrite, in order to handle backslash escapes.
1051 (main): Handle new option. Set globals for --format, too.
1053 * tests/misc/stat-printf: Test --printf and --format.
1054 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1056 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1058 * NEWS: sort now reports incompatible options.
1059 * src/sort.c (incompatible_options, check_ordering_compatibility):
1061 (main): Use them. Don't bother with a usage message for
1062 "sort -c a b", for consistency with other error diagnostics.
1063 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1066 * src/cat.c (main): Undo previous change. close_stdout already
1067 does the check, so the previous change wasn't necessary.
1069 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1071 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1073 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1075 Install a more-conservative approach for sort -R. It's the
1076 same basic idea as the existing code, except it uses the full ISAAC
1077 approach (called the "more kosher" approach in the existing comments).
1078 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1079 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1080 better to be conservative here at first, and review any performance
1081 improvements carefully.
1082 * .x-sc_require_config_h: Add src/rand-isaac.c.
1083 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1084 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1085 (shred_SOURCES, sort_SOURCES): Remove.
1086 (EXTRA_DIST): Add rand-isaac.c.
1087 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1088 changing it to allow for varying numbers of words in the state.
1089 Alter so that we include rand-isaac.c directly rather than
1090 compiling it and linking to it. Don't include config.h or
1091 system.h; that's the includer's responsibility.
1092 Omit functions that are specific to shred.
1093 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1094 (isaac_step, struct irand_state):
1095 Resurrect these, with the same defns that used to be in shred.c.
1096 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1097 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1099 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1100 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1101 (irand_init, irand32, irand_mod):
1102 Number of words is constant again.
1103 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1104 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1105 * src/sort.c: Likewise.
1106 * src/shred.c (fillrand, dopass, main): Undo previous change.
1107 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1109 * src/sort.c: Don't include md5.h; it wasn't needed.
1110 (struct keyfield): Rename random_hash to random, for consistency
1111 with the other member names. All uses changed.
1112 (usage): Tweak wording to mention STRING for --seed option.
1113 (short_options): Rorder for consistency with other programs.
1114 (rand_state): Now a struct, not a pointer to one. All uses changed.
1115 (HASH_WORDS, HASH_SIZE): Remove.
1116 (get_hash): Remove comments around resbuf size, since we can assume C89.
1117 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1118 (keycompare): Adjust to the new get_hash.
1120 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1121 (main): Don't set need_random simply because gkey has it set; that
1122 doesn't necessarily mean we'll need random numbers.
1123 Redo seeding to match new get_hash approach.
1125 2005-12-10 Jim Meyering <jim@meyering.net>
1127 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1129 Avoid shred segfault on 64-bit systems.
1130 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1131 local of type uint32_t. Make the local an `int' instead.
1133 * NEWS: Mention sort's new options.
1135 * src/rand-isaac.c (isaac_mix): Declare to be static.
1136 Mark all other functions as `extern' so the tight-scope
1137 part of `make distcheck' passes once again.
1138 * src/rand-isaac.h (isaac_mix): Remove declaration.
1140 * src/sort.c (get_hash): Change position of `*' in parameter
1141 type to conform with convention.
1142 (main): Split a long line so it fits in 80 columns.
1143 (keycompare): Remove stray SPACE before TAB that was
1144 causing `make distcheck' to fail.
1146 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1148 * tests/misc/sort-rand: New file: basic tests for the new options.
1149 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1151 2005-12-10 Frederik Eaton <frederik@ofb.net>
1153 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1154 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1155 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1156 Make state size runtime-configurable.
1157 (isaac_new, isaac_copy): New functions.
1158 * src/rand-isaac.h: New file.
1159 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1160 (fillrand, main): Adjust to the fact that the state size is now
1161 runtime-configurable.
1162 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1163 (usage): Add options --random-sort and --seed to implement a random
1165 Include md5.h and rand-isaac.h.
1166 (get_hash): New function.
1167 (rand_state): New var.
1168 (HASH_WORDS, HASH_SIZE): New macros.
1170 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1172 * tests/dd/misc: Add test for dd iflags=noatime.
1174 2005-12-09 Jim Meyering <jim@meyering.net>
1176 * src/sort.c (usage): Mention white space vs -b and -t options.
1179 2005-12-09 Eric Blake <ebb9@byu.net>
1181 * src/test.c (main): Fix misleading comment.
1183 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1185 * NEWS: Mention dd's new noatime flag.
1186 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1187 * src/dd.c (flags, usage): Add support for noatime flag.
1189 2005-12-07 Jim Meyering <jim@meyering.net>
1191 Distribute the cvsu script, used only by `make syntax-check'.
1192 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1193 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1194 distribute a copy of this script.
1195 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1197 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1198 to create a temporary directory on another partition.
1199 From Andreas Gruenbacher.
1201 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1203 * man/basename.x: Cross-reference to dirname and readlink.
1204 * man/dirname.x: Cross-reference to basename and readlink.
1206 2005-12-05 Andreas Gruenbacher
1208 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1209 (set_owner, preserve_author): New functions, factored out of copy_reg.
1210 (copy_reg): Use them.
1211 (copy_internal): Use them here, too.
1213 2005-12-04 Jim Meyering <jim@meyering.net>
1215 * src/sleep.c (usage): Say what happens with two or more arguments.
1216 Suggested by Justin Pryzby.
1218 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1221 2005-12-03 Jim Meyering <jim@meyering.net>
1223 * src/rm.c (long_opts): Change the name of each undocumented, for-
1224 testing-only option to start with `-', so that it cannot render
1225 ambiguous any prefix it happens to share with some other option name.
1226 Problem reported by Eric Blake.
1227 * src/head.c (long_options): Likewise.
1228 * src/tail.c (long_options): Likewise.
1230 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1231 testing-only --presume* options to start with `---'.
1232 * tests/rm/dangling-symlink: Likewise.
1233 * tests/rm/dir-no-w: Likewise.
1234 * tests/rm/isatty: Likewise.
1236 2005-11-30 Jim Meyering <jim@meyering.net>
1238 * Makefile.maint: Add a comment about cvsu.
1240 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1242 * NEWS: df updates for "none", "proc", inaccessible file systems.
1243 * src/df.c (show_point): Ignore inaccessible file systems.
1244 (usage): -a includes dummy file systems, not size-0 file systems.
1246 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1247 to avoid collision with POSIX name space. All uses changed.
1249 2005-11-24 Jim Meyering <jim@meyering.net>
1251 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1252 * tests/acl: Add `$0: ' prefix to diagnostics.
1254 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1256 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1258 * src/copy.c: Improve performance a bit by optimizing away
1259 unnecessary system calls and going to a block size of at least
1260 8192 (on normal hosts, anyway). This improved performance 5% on my
1261 Debian stable host (2.4.27 kernel, x86, copying from root
1262 ext3 file system to itself).
1263 Include "buffer-lcm.h".
1264 (copy_reg): Omit last argument. All callers changed.
1265 Use xmalloc to allocate rather than trusting alloca
1266 (which is unwise with large block sizes).
1267 Declare locals more locally, if possible.
1268 Use uintptr_t words instead of int words, for a bit more speed
1269 when looking for null blocks on 64-bit hosts.
1270 Optimize away reads of zero bytes on regular files.
1271 In the typical case, insist on 8 KiB buffers, at least.
1272 Avoid unnecessary extra call to fstat when checking for sparse files.
1273 Avoid now-unnecessary cast to off_t, and "0L".
1274 Avoid unnecessary test of *new_dst when checking for same owner
1277 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1279 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1281 2005-11-22 Jim Meyering <jim@meyering.net>
1283 * src/remove.c (AD_push): Remove debugging cruft.
1285 * tests/rm/unread2 (rm): Change expected diagnostic,
1286 `cannot open directory' to `cannot remove', to align with
1288 * tests/rm/rm2: Ensure that rm now continues removing entries
1289 even after certain types of failure.
1291 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1292 that provide openat (Solaris), and on systems like Linux+procfs
1293 where our openat emulation code is reentrant. This also fixes a
1294 few low-probability leaks and eliminates some code that could,
1295 in very unusual circumstances, cause rm() (via a callee) to exit.
1296 * NEWS: Mention this.
1298 * configure.ac: Put copyright dates all on one line so the
1299 emacs function that updates them works properly.
1301 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1303 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1304 Problem reported by Eric Blake.
1305 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1306 we get a standard-conforming compiler. This relies on the new
1307 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1308 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1309 m4/c.m4 can go away with Autoconf 2.60 comes out.
1311 2005-11-17 Jim Meyering <jim@meyering.net>
1313 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1314 (AD_mark_current_as_unremovable): Likewise, but for a local.
1317 * tests/mv/acl: Let traps handle removing temporary directories.
1319 Expect acl-related tests to fail, until the corresponding
1320 patches are committed.
1321 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1322 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1324 ACL tests, from Andreas Gruenbacher.
1325 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1326 * tests/mv/Makefile.am (TESTS): Add acl.
1327 * tests/cp/Makefile.am (TESTS): Add acl.
1329 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1331 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1333 * NEWS: Improve quality of ln's diagnostics.
1334 * src/ln.c (do_link, usage): Likewise.
1335 (do_link): Don't use alloca on a buffer of unbounded size.
1337 2005-11-16 Jim Meyering <jim@meyering.net>
1339 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1340 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1341 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1342 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1343 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1345 2005-11-14 Jim Meyering <jim@meyering.net>
1347 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1349 2005-11-13 Jim Meyering <jim@meyering.net>
1351 * announce-gen: Accept new option, --gpg-key-id=ID and
1352 emit a blurb telling how to use the .sig files.
1353 * Makefile.cfg (gpg_key_ID): Define.
1354 * Makefile.maint (announcement): Use new option and key.
1356 Require that most .c files include <config.h>.
1357 * Makefile.maint (sc_require_config_h): New rule.
1358 (syntax-check-rules): Add it.
1359 * .x-sc_require_config_h: New file listing exceptions to the
1360 above rule. Some are legit, others are simply grandfathered in.
1361 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1363 2005-11-12 Jim Meyering <jim@meyering.net>
1365 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1367 2005-11-11 Jim Meyering <jim@meyering.net>
1369 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1370 Mention new readlink options in 5.3.0's `New features' section.
1371 Spotted by Thomas Hood.
1373 2005-11-08 Jim Meyering <jim@meyering.net>
1375 * NEWS: Merge in changes from b5_9x branch.
1377 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1379 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1380 like --time-style='posix-long-iso' if the locale settings are messed up.
1381 * src/ls.c (decode_switches): Implement this.
1383 2005-11-08 Jim Meyering <jim@meyering.net>
1385 * tests/du/2g: s/expensive/very expensive/ in a comment.
1388 2005-10-17 Eric Blake <ebb9@byu.net>
1390 * src/ls.c (usage): Fix descriptions of --sort, --time.
1391 Reported by Vitaly A. Ostanin.
1393 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1395 * src/ln.c: Include filenamecat.c.
1396 (FILE_BASENAME_CONCAT): Remove.
1397 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1398 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1399 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1402 2005-11-04 Jim Meyering <jim@meyering.net>
1404 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1405 on systems with stat.st_blocks of a signed 32-bit type.
1406 This bug causes trouble on some AIX 5.1 systems.
1407 Report and trivial patch from Paul Townsend:
1408 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1409 * NEWS: Mention this.
1411 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1412 * tests/du/Makefile.am (TESTS): Add it here.
1413 * tests/very-expensive: New file.
1414 * tests/Makefile.am (EXTRA_DIST): Add it here.
1415 * tests/cp/perm: Mark this test as `very-expensive', too.
1417 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1419 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1421 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1423 * src/rm.c (usage): Don't mention rm -d.
1425 2005-11-02 Jim Meyering <jim@meyering.net>
1427 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1428 From Andreas Schwab.
1430 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1431 `M+N records in/out' lines don't pollute `make check' output.
1433 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1434 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1435 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1436 to indicate that the input file should be piped into the command
1437 under test (via `cat FILE | $prog ...').
1439 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1440 (without -r) fails to remove a directory on a non-Linux system.
1441 This change affects only newer Solaris systems (with priv_*
1442 functions like priv_allocset). Reported by Keith Thompson.
1444 * tests/rm/dir-nonrecur: New file/test for the above fix.
1445 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1447 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1449 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1450 POSIX 1002.1-2001 requires.
1451 * src/tail.c (parse_obsolete_option): Implement this.
1452 Problem reported by Vincent Lefevre.
1453 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1454 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1455 (test_vector): Add special cases for _POSIX2_VERSION, and
1456 regularize the old ones a bit.
1457 * tests/touch/obsolescent: Add y2000 test.
1459 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1461 * src/dd.c (skip): Fix off-by-one error reported by
1462 Theodoros V. Kalamatianos.
1464 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1466 * tests/mkdir/p-3: Require that the test be run as non-root.
1467 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1469 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1471 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1472 boundary between DEST and SOURCE in the result.
1474 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1476 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1477 back to text, to sync with documentation and for backwards
1480 2005-10-25 Jim Meyering <jim@meyering.net>
1482 * tests/dircolors/simple (other-wr): Add an explicit test for
1483 the dircolors bug (NULL-dereference) fixed yesterday.
1485 2005-10-24 Jim Meyering <jim@meyering.net>
1487 * src/tac.c (tac_file): When determining whether a file is seekable,
1488 also test whether it is a tty. Using only the lseek-based test would
1489 give a false positive on Solaris. Reported by Peter Fales.
1491 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1493 * tests/install/d-slashdot: New test, for "install -d" failure.
1494 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1495 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1496 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1498 2005-10-24 Jim Meyering <jim@meyering.net>
1500 * src/dircolors.c (ls_codes): Add missing comma.
1501 Anonymous report and patch from
1502 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1504 * src/dircolors.c: Add compile-time assertion that the slack_codes
1505 and ls_codes arrays have the same number of elements. This would
1506 have prevented the above-fixed bug.
1508 * src/expand.c (parse_tab_stops): Add a comment to make this function
1509 identical to the one in unexpand.c.
1510 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1511 identical to the one in expand.c.
1513 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1515 2005-10-23 Jim Meyering <jim@meyering.net>
1517 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1518 a dangerous pointer-value-to-`unsigned' cast.
1519 * NEWS: mention the new sha* programs.
1520 * AUTHORS: Add new sha* programs.
1522 2005-08-28 David Madore <david.madore@ens.fr>
1524 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1525 * README: Add their names to the list.
1526 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1527 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1528 Rules for compiling sha-2 utilities
1529 (noinst_HEADERS): Remove checksum.h.
1530 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1532 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1533 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1534 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1535 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1536 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1537 sha384sum, sha512sum test scripts here rather that each in its
1540 2005-08-28 David Madore <david.madore@ens.fr>
1542 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1543 of the FIPS test vectors).
1545 2005-10-23 Jim Meyering <jim@meyering.net>
1547 * configure.ac: Use 6.0-cvs as the version string.
1548 * NEWS: Adjust accordingly.