1 2005-05-23 John (J5) Palmieri <johnp@redhat.com>
3 * python/decorators.py: import dbus_bindings
5 * python/matchrules.py (SignalMatchRule, SignalMatchTree,
6 SignalMatchNode): new classes that implement wildcard signal
7 callback matching using a tree lookup. Heavily modified from a
8 patch sent by Celso Pinto (fd.o bug #3241)
10 * _dbus.py (add_signal_receiver, remove_signal_receiver, _signal_func):
11 use new match classes to handle signals.
13 2005-05-19 John (J5) Palmieri <johnp@redhat.com>
15 * python/dbus_bindings.pyx.in: s/TYPE_PATH/TYPE_OBJECT_PATH
17 2005-05-18 Havoc Pennington <hp@redhat.com>
19 * configure.in: use GLIB_GNU_GETTEXT to get INTLLIBS and require
20 gettext. Not really worth requiring yet perhaps, but any
21 production quality 1.0 would require it so we should go ahead and
22 get things set up. We do have a couple token calls to
23 bindtextdomain in the code already.
25 2005-05-16 John (J5) Palmieri <johnp@redhat.com>
27 * glib/dbus-gmain.c (io_handler_dispatch): fix deadlock
28 when using recursive g_main_loops
30 * python/_dbus.py (class Bus): add the ProxyObjectClass
31 alias for ProxyObject to make it easier for the Twisted
32 networking framework to integrate dbus.
34 * python/proxies.py (class ProxyObject): add the ProxyMethodClass
35 alias for ProxyMethod to make it easier for the Twisted
36 networking framework to integrate dbus.
38 2005-05-11 Ross Burton <ross@burtonini.com>
40 * glib/dbus-glib-tool.c: Add --prefix argument.
41 * glib/dbus-binding-tool-glib.h: Add prefix argument.
42 * glib/dbus-binding-tool-glib.c (compute_marshaller_name):
44 (generate_glue): Pass prefix argument down.
45 (dbus_binding_tool_output_glib_server): Pass prefix to
48 2005-05-11 Colin Walters <walters@verbum.org>
50 * tools/dbus-send.c (append_array): New function.
51 (append_arg): Broken out from main.
52 (main): Add cheesy hack to send arrays and variants.
54 * tools/dbus-print-message.c (print_iter): Broken out
57 2005-05-11 Colin Walters <walters@verbum.org>
59 * dbus/dbus-signature.c (dbus_signature_iter_get_signature):
60 New function, returns signature string for signature iter.
61 * dbus/dbus-signature.h: Prototype it.
62 * dbus/dbus-message.c (dbus_message_iter_get_signature):
63 New function, returns signature string for message iter.
64 (dbus_message_iter_get_array_len): New function, returns
66 (dbus_message_iter_get_fixed_array): Fix assertion; this
67 function should be used when the iter is pointing to the
69 * dbus/dbus-message.h: Prototypes.
70 * dbus/dbus-marshal-recursive.c (_dbus_type_reader_get_array_length):
71 New function; returns length of an array.
72 * dbus/dbus-marshal-recursive.h: Prototype it.
74 2005-05-11 Colin Walters <walters@verbum.org>
76 * dbus/dbus-sysdeps-util.c <!HAVE_POSIX_GETPWNAM_R>: Fix
79 2005-05-08 Havoc Pennington <hp@redhat.com>
81 * dbus/dbus-sysdeps-util.c (_dbus_become_daemon): write the
82 daemon's pid, not the parent's pid, to the file descriptor.
83 Reported by Taj Morton.
85 2005-05-05 Havoc Pennington <hp@redhat.com>
87 * configure.in (LT_*): add notes on how the libtool versioning
88 works to save thinking. Increment soname to indicate protocol
89 breakage (though really the library interface hasn't changed I
92 * dbus/dbus-transport.c (_dbus_transport_get_is_authenticated):
93 verify the GUID received from server matches what we were
94 expecting, if we had an expectation
96 * dbus/dbus-auth.c (send_ok): send GUID along with the OK command
97 (_dbus_auth_get_guid_from_server): new function
98 (send_begin): parse the OK args
100 * doc/dbus-specification.xml: add GUID to the auth protocol
102 2005-05-05 John (J5) Palmieri <johnp@redhat.com>
104 * Fix my name in previous changelog ;)
106 * python/proxies.py (ProxyObject.__getattr__): add further patch
107 from Anthony Baxter to throw an AttributeError when python
108 __special__ functions are called instead of marshling them over
109 the bus (Bug#1685 comment 3).
111 2005-05-04 John (J5) Palmieri <johnp@redhat.com>
113 * python/Makefile.am: changed to use pyexecdir for the binding
114 shared libraries (Bug#2494)
116 * python/exceptions.py: bring exceptions over from the bindings
117 so they can be used in applications (Bug#2036)
118 Make all exceptions derive from DBusException
120 * python/_dbus.py, python/proxies.py: implement __repr__ in a couple
121 of classes so that print obj doesn't throw an exception (Bug #1685)
123 2005-05-03 Ross Burton <ross@burtonini.com>
125 * glib/dbus-gobject.c (dbus_g_connection_register_g_object):
126 Return if we get an error during registration. Set up a
127 weak reference on object to unregister if object is destroyed.
128 (unregister_gobject): New function.
130 2005-05-01 John (J5) Palmieri <johnp@redhat.com>
132 * python/dbus_bindings.pyx.in:
133 - added new type classes for hinting to the marashaler what type
134 to send over the wire
135 - added int16 and uint16 marshalers
136 - Fixed a bug in the type constants that caused int32 to go out
137 as uint16 over the wire
138 * python/dbus.py: split up into different files and renamed _dbus.py
139 * python/__init__.py, python/_util.py, python/decorators.py,
140 python/exceptions.py, python/proxies.py, python/services.py,
141 python/types.py: new files split off from dbus.py
142 * python/Makefile.am: Add new files, remove dbus.py and
143 install all python files to <python module dir>/dbus
144 * python/examples/*: Added #!/usr/bin/env python to the top of
145 every example. Patch provided by Tatavarty Kalyan
147 2005-04-25 John (J5) Palmieri <johnp@redhat.com>
149 * NEWS: Update to 0.33
151 2005-04-25 John (J5) Palmieri <johnp@redhat.com>
153 * python/dbus_bindings.pyx.in (send_with_reply_handlers): New send
154 method for doing async calls
155 (_pending_call_notification): New C function for handling pendning call
157 (set_notify): New method for setting pending call notification
159 * python/dbus.py: new version tuple "version" is set at (0, 40, 0)
160 Async capabilities added to remote method calls
161 (Sender): class removed
162 (RemoteService): class removed
163 (ObjectTree): class removed for now
164 (RemoteObject): Renamed to ProxyObject
165 (RemoteMethod): Renamed to ProxyMethod
166 (method): Decorator added for decorating python methods as dbus methods
167 (signal): Decorator added for decorating python methods as signal emitters
168 (ObjectType): Metaclass added for generating introspection data and the
169 method callback vtable
170 (Interface): Wrapper class added to wrap objects in a dbus interface
171 (Object): Uses ObjectType as its metaclass and exports Introspect
172 of the org.freedesktop.DBus.Introspectable interface
173 (ValidationException, UnknownMethodException): new exceptions
175 * python/examples/*: Modified to fit with the new bindings
177 2005-04-23 Havoc Pennington <hp@redhat.com>
179 * dbus/dbus-message.c (dbus_message_append_args): fix doc comment,
180 reported by Tony Houghton
182 * test/test-service.c (main): test
183 dbus_connection_get_object_path_data()
185 * dbus/dbus-object-tree.c (find_handler): be sure we always init
187 (_dbus_object_tree_get_user_data_unlocked): new function used by
188 dbus_connection_get_object_path_data()
189 (do_register): add assertion test for get_user_data_unlocked
190 (object_tree_test_iteration): more tests
192 * dbus/dbus-connection.c (dbus_connection_get_object_path_data):
193 new function from Dan Reed to let you get the user data from
194 dbus_connection_register_object_path()
196 2005-04-23 John (J5) Palmieri <johnp@redhat.com>
198 * dbus/dbus-marshal-recursive-util.c: Fixed buffer overflow
199 in numerous places that did not account for the NULL terminator
200 (signature_from_seed): changed the manual string copy loop to
201 just use strcpy instead
202 make check should now pass
204 2005-04-19 John (J5) Palmieri <johnp@redhat.com>
206 * dbus/dbus-marshal-header.c (_dbus_header_create): Fix assert
207 so that it allows messages that are not signals to pass in
208 NULL as the interface.
210 2005-04-18 David Zeuthen <davidz@redhat.com>
212 * glib/dbus-gmain.c (io_handler_destroy_source):
213 (timeout_handler_destroy_source, connection_setup_free):
214 Also unref the source to avoid memory leaks.
216 2005-04-13 David Zeuthen <davidz@redhat.com>
218 * bus/config-parser.c (bus_config_parser_new): Bump this to a
219 more reasonable, yet still totally arbitrary, value :-).
221 2005-04-13 David Zeuthen <davidz@redhat.com>
223 * doc/TODO: Added an "important for 1.0" item about selinux
226 2005-04-13 David Zeuthen <davidz@redhat.com>
228 * bus/selinux.c: Add c-file-style to top of file
229 (log_audit_callback): Don't free the data here anymore
230 (bus_selinux_check): Don't take spid and tpid since appending
231 that to auxdata may OOM.
232 (bus_selinux_allows_acquire_service): Handle OOM and signal back
233 to the caller if we are OOM by taking an error object.
234 (bus_selinux_allows_send): -do-
236 * bus/selinux.h: Fix prototypes for bus_selinux_allows_acquire_service
237 and bus_selinux_allows_send
239 * bus/bus.c (bus_context_check_security_policy): Pass error and
240 pass on OOM thrown by bus_selinux_allows_send()
242 * bus/services.c (bus_registry_acquire_service): Pass error and
243 pass on OOM thrown by bus_selinux_allows_acquire_service()
245 2005-04-13 Havoc Pennington <hp@redhat.com>
247 * glib/dbus-gmain.c (message_queue_dispatch): only dispatch one
248 message at a time to avoid monopolizing the main loop, bug
249 #2953 from Benjamin Otte
251 2005-04-09 Havoc Pennington <hp@redhat.com>
253 * dbus/dbus-string.c (copy): change a memcpy to memmove due to
254 possible overlap, fix from Daniel Reed
255 (fixup_alignment): fix signedness warnings
256 (_dbus_string_append_unichar): ditto
258 2005-04-09 Havoc Pennington <hp@redhat.com>
260 * dbus/dbus-message-util.c (_dbus_message_test): fix signedness warning
262 * glib/dbus-glib-tool.c (main): fix warning
264 * glib/dbus-binding-tool-glib.c (generate_glue): fix warning
266 * dbus/dbus-connection.c (dbus_connection_read_write_dispatch):
267 add a new function that can be used in simple applications that
268 don't have a main loop and are willing to block
270 2005-04-05 David Zeuthen <davidz@redhat.com>
272 Fix https://bugs.freedesktop.org/show_bug.cgi?id=2889
275 (io_handler_destroy_source): Remove from list of IO handlers
276 of the ConnectionSetup object
277 (timeout_handler_destroy_source): -do- for timeout handlers
278 (io_handler_source_finalized): Don't remove from list since
279 we now do that in io_handler_destroy_source(). Renamed from
280 io_handler_source_destroyed
281 (timeout_handler_source_destroyed): -do- for timeout handlers
282 (connection_setup_free): It is now safe to iterate over all
283 IO and timeout handlers as the _destroy_source removes them
284 from the list synchronously
286 2005-03-30 Havoc Pennington <hp@redhat.com>
288 * configure.in: change check to gtk 2.4
290 * tools/dbus-viewer.c (name_combo_changed_callback): remove
291 gtk_combo_box_get_active_text() usage to decrement GTK requirement
294 2005-03-29 John (J5) Palmieri <johnp@redhat.com>
298 * HACKING: Fixed realease instructions. configure.in should be updated to
299 the next release by the person who made the last release.
301 2005-03-29 John (J5) Palmieri <johnp@redhat.com>
303 * python/lvalue_cast_post_process.py - removed. Patch has been
304 submitted to Pyrex maintainers that fixes gcc4.0 errors
306 * python/Makefile.am: removed refrences to lvalue_cast_post_process.py
308 2005-03-24 Daniel Reed <n@ml.org>
310 * tools/Makefile.am: Make print-introspect and
311 dbus-bus-introspect.xml building conditional on HAVE_GLIB.
313 2005-03-22 John (J5) Palmieri <johnp@redhat.com>
315 * tools/Makefile.am: Patch by Colin Walters that fixes distcheck
317 * dbus/dbus-userdb.c, dbus/dbus-userdb-util.c: Add patch we have
318 had in Red Hat packages for a while but for some reason never
320 (_dbus_is_a_number): New checks if a string
321 can be converted to a number and does the conversion if it can
322 (_dbus_user_database_lookup): Add check to see if the given username
323 is a udi. This allows udi's to be used instead of usernames in the
325 (_dbus_user_database_lookup_group): Add check to see if the given groupname
326 is a gdi. This allows gdi's to be used instead of groupnames in the
329 2005-03-21 John (J5) Palmieri <johnp@redhat.com>
331 * python/lvalue_cast_post_process.py - added post processor to fix Pyrex
332 code so that it compiles with gcc4.0
334 * python/Makefile.am: Added lvalue_cast_post_process.py to EXTRA_DIST
335 run dbus_bindings.c through lvalue_cast_post_process.py and copy the
336 results back to dbus_binding.c
338 2005-03-20 Colin Walters <walters@verbum.org>
340 Patch suggested by Inguva Rajasekhar <ringuva@novell.com>.
342 * configure.in: Require GTK+ 2.6.
344 2005-03-20 Colin Walters <walters@verbum.org>
346 * Makefile.am (SUBDIRS, DIST_SUBDIRS): Build tools before test.
348 2005-03-17 Tom Parker <palfrey@tevp.net>
350 * dbus/dbus-userdb.c (_dbus_user_database_lookup): Don't
351 print DBUS_UID_UNSET; instead print passed username. Also
352 be sure to actually use gid looked up in cache.
354 * dbus/dbus-userdb-util.c (_dbus_user_database_lookup_group): Ditto
355 for DBUS_GID_UNSET and groupname.
357 2005-03-17 Colin Walters <walters@verbum.org>
359 * bus/print-introspect.c: Move to tools/.
360 * bus/run-with-tmp-session-bus.sh: Ditto.
362 * glib/Makefile.am (dbus-glib-bindings.h): Move
363 generation to tools/Makefile.am.
365 * test/glib/run-test.sh: Update to handle move
366 of run-with-tmp-session-bus.sh.
368 * test/glib/test-service-glib.c: Update to handle
369 move of dbus-glib-bindings.h.
371 * tools/print-introspect.c: Moved here
372 from bus/, and ported to GLib bindings.
374 * tools/run-with-tmp-session-bus.sh: Moved here
377 * tools/Makefile.am: Generate dbus-glib-bindings.h
378 and dbus-bus-introspect.xml here.
380 * tools/.cvsignore, glib/.cvsignore, bus/.cvsignore:
383 2005-03-17 Colin Walters <walters@verbum.org>
385 * bus/driver.c (write_args_for_direction): Use
386 _dbus_string_get_const_data to retrieve string;
387 _dbus_string_get_const_data_len doesn't actually return
388 a NULL-terminated substring.
390 * test/glib/test-service-glib.c: Include dbus-glib-bindings.h.
391 (main): Change to use org_freedesktop_DBus_request_name
392 instead of using g_proxy_begin_call/end_call.
394 2005-03-15 Joe Shaw <joeshaw@novell.com>
396 * mono/ProxyBuilder.cs (BuildFinalizer): Fix some invalid IL when
397 generating the finalizer. Fixes from Ben Maurer.
399 2005-03-12 Joe Shaw <joeshaw@novell.com>
401 * mono/BusDriver.cs: Update method names: ListServices
402 becomes ListNames; GetOwner becomes GetNameOwner.
404 * mono/ProxyBuilder.cs (BuildFinalizer): Need to load arg 0
405 onto the eval stack when removing the delegate.
407 2005-03-12 Joe Shaw <joeshaw@novell.com>
409 * mono/dbus-sharp.dll.config.in: Don't hardcode 0 for
410 LT_CURRENT. Set it to the autoconf variable.
412 * mono/ProxyBuilder.cs: Add a finalizer to the generated proxy
413 classes that disconnects the signal handler delegate from the
414 service object. Fixes a big leak of proxy objects on the
415 client side of things. Patch from Ben Maurer
418 2005-03-12 Colin Walters <walters@verbum.org>
420 * bus/driver.c (write_args_for_direction): New function,
421 parses a type signature into arguments and outputs to
423 (bus_driver_handle_introspect): Use it instead of
424 hardcoding XML for certain signatures.
426 * bus/Makefile.am (dbus-bus-introspect.xml): Add
427 dependency on dbus-daemon.
429 * glib/dbus-glib-tool.c (main): Parse ignore_unsupported
430 argument, pass it to dbus_binding_tool_output_glib_client.
432 * glib/dbus-binding-tool-glib.c
433 (generate_client_glue): Protect against multiple inclusion.
434 (dbus_binding_tool_output_glib_client): Add
435 G_BEGIN_DECLS/G_END_DECLS.
437 * glib/dbus-binding-tool-glib.c (compute_client_method_name):
438 Change to just take iface prefix directly.
439 (write_formal_parameters): Clarify error message.
440 (check_supported_parameters): New function; checks to see type
441 signatures of method parameters are supported.
442 (generate_client_glue): Handle ignore_unsupported flag.
443 (dbus_binding_tool_output_glib_client): Handle ignore_unsupported
446 * glib/Makefile.am (dbus-glib-bindings.h): Pass
447 --ignore-unsupported by default until glib bindings
450 2005-03-11 Colin Walters <walters@verbum.org>
452 * glib/Makefile.am: Generate dbus-glib-bindings.h and
455 * bus/print-introspect.c: New file; prints introspection
456 data for a given name and object path.
458 * bus/run-with-tmp-session-bus.sh: New file, refactored
459 from test/glib/run-test.sh. Creates a temporary session
460 bus and runs another program.
462 * test/glib/run-test.sh: Refactor to invoke
463 run-with-tmp-session-bus.sh.
465 * bus/driver.c (bus_driver_handle_introspect): Fix to print new
466 introspection format. Also change to use DBUS_TYPE_x_AS_STRING
467 macros instead of hardcoding.
469 * glib/.cvsignore, bus/.cvsignore, test/glib/.cvsignore: Update.
471 2005-03-11 Joe Shaw <joeshaw@novell.com>
473 * dbus/dbus-connection.c (dbus_connection_send_with_reply): Remove
474 this unref; it doesn't match up evenly in some codepaths.
475 (_dbus_connection_block_pending_call): Unref at every exitpoint;
476 this evenly matches with the ref near the top of this function.
478 2005-03-09 Joe Shaw <joeshaw@novell.com>
480 * dbus/dbus-object-tree.c
481 (_dbus_object_tree_unregister_and_unlock): If checks are enabled
482 and we try to unregister a path that's not registered, still go
483 through the process of unlocking and don't just return.
485 2005-03-09 Colin Walters <walters@verbum.org>
487 * glib/dbus-gproxy.c (dbus_g_proxy_invoke): New method; calls
488 to this are generated for client-side wrappers. Invokes a
489 D-BUS method and returns reply values.
491 * glib/dbus-binding-tool-glib.c (write_args_sig_for_direction): New
492 function; writes signature string for argument direction.
493 (write_args_for_direction): Change to pass input values directly
494 instead of via address, and fix indentation.
495 (generate_client_glue): Change to invoke dbus_g_proxy_invoke. Also
496 make generated wrappers inlineable.
498 * dbus/dbus-message.c (dbus_message_iter_get_fixed_array): Add
499 note about using dbus_type_is_fixed.
501 * dbus/dbus-marshal-basic.c (_dbus_type_is_fixed): Moved to
502 dbus/dbus-signature.c as dbus_type_is_fixed.
506 * dbus/dbus-signature.c (dbus_type_is_fixed): Moved here
507 from dbus/dbus-marshal-basic.c:_dbus_type_is_fixed.
509 * dbus/dbus-signature.h: Prototype.
511 * glib/dbus-binding-tool-glib.c (compute_marshaller_name): Fix
514 * test/glib/test-dbus-glib.c (main): Be sure to clear error as
515 appropriate instead of just freeing it.
516 (main): Free returned strings using g_free.
518 * test/glib/Makefile.am (test-service-glib-glue.h)
519 (test-service-glib-bindings.h): Add dependency on dbus-binding-tool.
521 * glib/dbus-gvalue.c (MAP_BASIC): Refactored from MAP_BASIC_INIT;
522 simply maps a simple D-BUS type to GType.
523 (dbus_dbus_type_to_gtype): Function which maps D-BUS type to
525 (dbus_gvalue_init): Just invoke dbus_dbus_type_to_gtype and
526 initialize the value with it.
527 (dbus_gvalue_binding_type_from_type): Unused, delete.
528 (dbus_gvalue_demarshal): Switch to hardcoding demarshalling for
529 various types instead of unmarshalling to value data directly.
530 Remove can_convert boolean.
531 (dbus_gvalue_marshal): Remove duplicate initialization; switch to
532 returning directly instead of using can_convert boolean.
533 (dbus_gvalue_store): New function; not related to D-BUS per-se.
534 Stores a GValue in a pointer to a value of its corresponding C
537 * glib/dbus-gvalue.h: Remove dbus_gvalue_binding_type_from_type,
538 add dbus_gvalue_store.
540 2005-03-08 Joe Shaw <joeshaw@novell.com>
542 Fix a bunch of lifecycle and memory management problems
543 in the mono bindings.
545 * mono/Arguments.cs (Arguments): Implement IDisposable
547 * mono/Bus.cs (Bus): Don't allow public instantiation. This is
548 strictly a static class.
550 * mono/Connection.cs: Move the DBusObjectPathVTable and associated
551 delegates into this file.
552 (Connection): Implement IDisposable.
553 (Dispose): Disconnect the connection and set the raw connection
554 pointer to IntPtr.Zero.
555 (~Connection): Call Dispose().
556 (RegisterObjectPath): Added. Manages the registration of object
557 paths so we can cleanly disconnect them at dispose/finalize time.
558 (UnregisterObjectPath): Ditto.
559 (set_RawConnection): Unregister all of the object paths when
560 changing the underlying DBusConnection. Add them back onto the
561 new connection, if any.
563 * mono/Handler.cs: Don't implement IDisposable; it doesn't use any
564 more unmanaged resources anymore, so it's not necessary. Move all
565 the DBusObjectPathVTable stuff out of here.
566 (Handler): Save references to our delegates so that they don't get
567 finalized. Call Connection.RegisterObjectPath() instead of
568 dbus_connection_register_object_path() directly.
569 (Message_Called): Dispose the message after we're finished with
572 * mono/Message.cs (Message): Implement IDisposable.
573 (Dispose): Dispose the Arguments, and set the RawMessage to
575 (SendWithReplyAndBlock): We own the ref to the reply that comes
576 back from dbus_connection_send_with_reply_and_block() so add a
577 comment about that and unref it after we've constructed a managed
578 MethodReturn class around it. Fixes a big, big leak.
580 * mono/ProxyBuilder.cs: Reflect into Message to get the Dispose
582 (BuildSignalHandler): After we've sent the Signal message, dispose
584 (BuildMethod): Dispose of the method call and reply messages after
585 we've sent the message and extracted the data we want from the
588 * mono/Service.cs (UnregisterObject): Don't call handler.Dispose()
590 (Service_FilterCalled): Dispose of the message after we're
593 2005-03-08 Joe Shaw <joeshaw@novell.com>
595 * dbus/dbus-connection.c (dbus_connection_send_with_reply):
596 After we attach our pending call to the connection, unref
599 * mono/Connection.cs (set_RawConnection): Disconnect our
600 filter and match callbacks from the old connection and
601 reconnect them to the new connection, if any.
603 * mono/DBusType/Array.cs: "Code" is a static member, so
604 don't use "this" to refer to it. Fix for stricter checking
607 * mono/DBusType/ObjectPath.cs (Append): Don't leak the
608 object path that we pass into unmanaged code.
610 * mono/DBusType/String.cs (Append): Don't leak the string
611 that we pass into unmanged code.
613 2005-03-07 John (J5) Palmieri <johnp@redhat.com>
614 * NEWS: Update for 0.31
616 * configure.in: Release 0.31
617 add LT_CURRENT, LT_REVISION, LT_AGE for easy soname bumping
619 * qt/Makefile.am: fixed build
621 * dbus/Makefile.am: soname bump for libdbus
623 * glib/Makefile.am: soname bump for libdbus-glib
625 2005-03-05 Havoc Pennington <hp@redhat.com>
627 * dbus/dbus-sysdeps.c:
628 (pseudorandom_generate_random_bytes_buffer): fix to have no return
630 (_dbus_generate_random_bytes_buffer): fix return value
632 * dbus/dbus-sysdeps-util.c: s/GETPWNAME/GETPWNAM/ so configure
633 checks actually work, from Tom Parker <fdo@tevp.net>
635 2005-03-01 Colin Walters <walters@verbum.org>
637 * test/glib/test-dbus-glib.c (lose, lose_gerror): Utility
638 functions copied from dbus-glib-tool.c.
639 (main): Convert lots of error code to use them.
640 Also add some testing for introspection bits.
642 2005-03-01 Colin Walters <walters@verbum.org>
644 * doc/TODO: Remove introspection signature TODO.
646 2005-02-27 Colin Walters <walters@verbum.org>
648 * glib/dbus-gidl.c (property_info_get_type, arg_info_get_type):
649 Change return value to const char * instead of int so we can do
651 (struct PropertyInfo, struct ArgInfo): Store char *.
652 (property_info_new, arg_info_new): Update parameters, strdup.
653 (property_info_unref, arg_info_unref): Free.
655 * glib/dbus-gidl.h: Update prototypes.
657 * glib/dbus-gparser.c (basic_type_from_string): Delete.
658 (validate_signature): New function, just validates signature and
660 (parse_property, parse_arg): Invoke validate_signature. Store
661 signature instead of just type code.
663 * glib/dbus-gvalue.c (base_type_from_signature): New utility
664 function to return a primary type for a signature, dropping
665 information about types in container types.
666 (dbus_gvalue_genmarshal_name_from_type)
667 (dbus_gvalue_binding_type_from_type)
668 (dbus_gvalue_ctype_from_type): Update to take full signature
669 instead of type code.
670 (dbus_gtype_to_dbus_type): Moved here from glib/dbus-gobject.c.
672 * glib/dbus-gvalue.h: Update prototypes for above.
674 * glib/dbus-gobject.c (gtype_to_dbus_type): Moved to
675 glib/dbus-gvalue.c as dbus_gtype_to_dbus_type.
676 (introspect_properties, introspect_signals, write_interface):
677 Update to handle signatures, and remove usage of
678 _dbus_gutils_type_to_string.
679 (handle_introspect): Print out type codes instead of e.g. "string"
680 in hardcoded introspection XML; also use x_AS_STRING constants
681 instead of hardcoding in string.
683 * glib/dbus-glib-tool.c (pretty_print): Handle signature change
684 to string. Remove usage of _dbus_gutils_type_to_string.
686 * glib/dbus-gutils.c (_dbus_gutils_type_to_string): Delete.
688 * glib/dbus-gutils.h (_dbus_gutils_type_to_string): Update for
691 * glib/dbus-binding-tool-glib.c (compute_marshaller)
692 (compute_marshaller_name, generate_glue): Handle signature change
694 (write_formal_parameters, write_args_for_direction): Ditto, and
697 * tools/dbus-tree-view.c (type_to_string): Delete.
698 (info_set_func_text): Update to print full signatures.
700 * test/glib/test-service-glib.xml: Change types to new
701 introspection format.
703 2005-02-26 Havoc Pennington <hp@redhat.com>
705 * doc/TODO: remove the "guid" item
707 * test/glib/test-profile.c (no_bus_thread_func): use open_private
708 (with_bus_thread_func): use open_private
710 * dbus/dbus-connection.c (dbus_connection_open_private): new
711 function that works like the old dbus_connection_open()
712 (dbus_connection_open): now returns an existing connection if
715 * dbus/dbus-server-unix.c (handle_new_client_fd_and_unlock): pass
716 through the GUID to the transport
718 * dbus/dbus-server.c (_dbus_server_init_base): keep around the
719 GUID in hex-encoded form.
721 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
722 pass GUID argument in to the transport
724 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd): add
727 * dbus/dbus-transport.c (_dbus_transport_init_base): add guid argument
729 * dbus/dbus-auth.c (_dbus_auth_server_new): add guid argument
731 2005-02-25 Havoc Pennington <hp@redhat.com>
733 * doc/dbus-specification.xml: document the GUID thing
735 * dbus/dbus-server.c (_dbus_server_init_base): initialize a
736 globally unique ID for the server, and put a "guid=hexencoded"
739 * dbus/dbus-bus.c: fix missing #include of dbus-threads-internal.h
741 * dbus/dbus-message.c: ditto
743 * dbus/dbus-dataslot.c: ditto
745 * dbus/dbus-list.c: ditto
747 * dbus/dbus-internals.h: wait, just include
748 dbus-threads-internal.h here
750 * dbus/dbus-string.c (_dbus_string_copy_to_buffer): move back for
753 * dbus/dbus-sysdeps.c (_dbus_generate_random_bytes_buffer): new function
755 2005-02-24 Colin Walters <walters@verbum.org>
757 * test/glib/Makefile.am (EXTRA_DIST): Add test-service-glib.xml
759 2005-02-24 John (J5) Palmieir <johnp@redhat.com>
761 * glib/Makefile.am: added dbus-gobject.h to sources list
762 so distcheck doesn't fail
764 2005-02-24 Havoc Pennington <hp@redhat.com>
766 * dbus/dbus-server.c, dbus/dbus-server-unix.c: change semantics so
767 you must disconnect before unref, since locking and other things
768 are screwed up otherwise. Fix assorted other locking stuff.
770 * dbus/dbus-signature.c (dbus_signature_iter_get_element_type):
773 * dbus/dbus-threads-internal.h: move the mutex/condvar wrappers
774 into a private header and don't export from the library
776 * throughout - call _dbus_thread_stuff vs. dbus_thread_stuff
778 2005-02-24 Colin Walters <walters@verbum.org>
780 * dbus/dbus-signature.c: New file; implements various functions
781 related to type signatures. Includes an interator for parsing,
782 validation functions.
783 (dbus_type_is_basic): Moved here from
784 dbus-marshal-basic.c:_dbus_type_is_basic.
785 (dbus_type_is_container): Moved here from
786 dbus-marshal-basic.c:_dbus_type_is_container.
788 All callers of _dbus_type_is_container and _dbus_type_is_basic
789 updated, and include dbus-signature.h.
791 * dbus/dbus-signature.h: New file; prototypes for the above.
793 * dbus/Makefile.am (DBUS_LIB_SOURCES): Add dbus-signature.c,
796 * dbus/dbus-marshal-basic.c (map_type_char_to_type): New utility
797 function factored out of _dbus_first_type_in_signature.
798 (_dbus_first_type_in_signature_c_str): New function; returns first
799 type code for a type signature character.
801 * dbus/dbus-marshal-basic.h: Prototype _dbus_first_type_in_signature_c_str,
802 handle function moves.
804 * dbus/dbus-marshal-recursive.h: Export _dbus_type_signature_next.
806 * dbus/dbus-marshal-recursive.c (_dbus_type_signature_next): New
807 function; skips to next complete type in type signature.
808 Implemented using previous skip_one_complete_type. Now
809 skip_one_complete_type just delegates to
810 _dbus_type_signature_next.
812 * dbus/dbus-marshal-basic.c (_dbus_type_is_basic): Moved
814 (_dbus_type_is_container): Ditto.
816 * doc/dbus-specification.xml: Update introspection sample to
817 use real type signatures.
819 * dbus/dbus-test.h: Prototype signature test.
821 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): Run
824 * dbus/dbus-protocol.h (DBUS_ERROR_INVALID_SIGNATURE): New error.
826 2005-02-23 John (J5) Palmieri <johnp@redhat.com>
828 * python/dbus_bindings.pyx.in (PendingCall::get_reply):
829 s/dbus_pending_call_get_reply/dbus_pending_call_steal_reply
831 2005-02-21 Colin Walters <walters@verbum.org>
833 * dbus/dbus-test-main.c (main): Take optional specific test
836 * dbus/dbus-test.c (run_test): New function, runs a test function
837 with no data directory.
838 (run_data_test): Like above, but takes data directory.
839 (dbus_internal_do_not_use_run_tests): Take
840 specific test argument. Replace lots of cut n' paste code
841 with run_test and run_data_test.
843 * dbus/dbus-test.h: Update prototype for
844 dbus_internal_do_not_use_run_tests.
846 2005-02-20 Havoc Pennington <hp@redhat.com>
848 Fix bugs reported by Daniel P. Berrange
850 * dbus/dbus-server.c (_dbus_server_unref_unlocked): new function
851 (protected_change_watch): new function
852 (_dbus_server_toggle_watch, _dbus_server_remove_watch)
853 (_dbus_server_add_watch): change to work like the
854 dbus-connection.c equivalents; like those, probably kind of
855 busted, but should at least mostly work for now
856 (dbus_server_disconnect): drop the lock if we were already
857 disconnected, patch from Daniel P. Berrange
859 * dbus/dbus-server.c (_dbus_server_toggle_timeout)
860 (_dbus_server_remove_timeout, _dbus_server_add_timeout): all the
863 * doc/TODO: todo about unscrewing this mess
865 2005-02-19 Colin Walters <walters@verbum.org>
867 * glib/dbus-binding-tool-glib.c
868 (dbus_binding_tool_output_glib_server): Fix iochannel refcounting.
870 * glib/dbus-glib-tool.c: Include dbus-glib-tool.h, as well
871 as errno.h and sys/stat.h.
872 (lose): New function, prints error with
874 (lose_gerror): Similar, but takes GError for message.
875 (main): Add --output argument to specify output file to write to,
876 instead of always printing to stdout. In this mode, determine
877 timestamps on source files to see whether any are newer than the
878 target file. If not, exit. Also convert a number of error
879 messages to use lose (since it's shorter), and switch to using
880 g_io_channel_shutdown.
882 2005-02-19 Havoc Pennington <hp@redhat.com>
884 * glib/dbus-gobject.c
885 (_dbus_glib_marshal_dbus_message_to_gvalue_array): add docs
887 * glib/dbus-glib.c: fix doxygen warnings
889 * glib/dbus-gparser.c (parse_annotation): error if an annotation
892 2005-02-17 Colin Walters <walters@verbum.org>
894 * glib/dbus-gobject.h: Don't export
895 _dbus_glib_marshal_dbus_message_to_gvalue_array.
897 * glib/dbus-gobject.c (_dbus_glib_marshal_dbus_message_to_gvalue_array): Do rename.
898 (invoke_object_method): Handle it.
900 * glib/dbus-gproxy.c (marshal_dbus_message_to_g_marshaller):
903 2005-02-17 Colin Walters <walters@verbum.org>
905 * bus/.cvsignore, doc/.cvsignore
906 * test/data/valid-service-files/.cvsignore, test/glib/.cvsignore:
909 2005-02-17 Colin Walters <walters@verbum.org>
911 * dbus/dbus-protocol.h (DBUS_SERVICE_ORG_FREEDESKTOP_DBUS):
912 Rename to DBUS_SERVICE_DBUS.
913 (DBUS_PATH_ORG_FREEDESKTOP_DBUS): Rename to DBUS_PATH_DBUS.
914 (DBUS_PATH_ORG_FREEDESKTOP_LOCAL): Rename to DBUS_PATH_LOCAL.
915 Change the value from "org.freedesktop.Local"
916 to "org.freedesktop.DBus.Local".
917 (DBUS_INTERFACE_ORG_FREEDESKTOP_DBUS): Rename to DBUS_INTERFACE_DBUS.
918 (DBUS_INTERFACE_ORG_FREEDESKTOP_INTROSPECTABLE): Rename to
919 DBUS_INTERFACE_INTROSPECTABLE.
920 Change the value from "org.freedesktop.Introspectable"
921 to "org.freedesktop.DBus.Introspectable".
922 (DBUS_INTERFACE_ORG_FREEDESKTOP_PROPERTIES): Rename to
923 DBUS_INTERFACE_PROPERTIES.
924 Change the value from "org.freedesktop.Properties"
925 to "org.freedesktop.DBus.Properties".
926 (DBUS_INTERFACE_ORG_FREEDESKTOP_PEER): Rename to
928 Change the value from "org.freedesktop.Peer"
929 to "org.freedesktop.DBus.Peer".
930 (DBUS_INTERFACE_ORG_FREEDESKTOP_LOCAL):
931 DBUS_INTERFACE_LOCAL.
932 Change the value from "org.freedesktop.Local"
933 to "org.freedesktop.DBus.Local".
935 All other users of those constants have been changed.
937 * bus/driver.c (bus_driver_handle_introspect): Use constants.
939 * glib/dbus-gobject.c (handle_introspect): Use constants.
941 * doc/dbus-faq.xml, doc/dbus-specification.xml: Update for rename.
943 2005-02-17 Colin Walters <walters@verbum.org>
945 * glib/dbus-gparser.c (struct Parser): Add in_annotation boolean.
946 (parse_node, parse_interface, parse_method, parse_signal)
947 (parse_property, parse_annotation): Lose if we're currently in an
949 (parse_annotation): New function.
950 (parser_start_element, parser_end_element): Handle annotation.
951 (parse_method, parse_interface): Remove support for c_name attribute,
952 switch to annotations.
954 * glib/dbus-gidl.h (interface_info_get_binding_names)
955 (method_info_get_binding_names)
956 (interface_info_get_binding_name, method_info_get_binding_name)
957 (interface_info_set_binding_name, method_info_set_binding_name):
959 (interface_info_get_annotations, method_info_get_annotations)
960 (interface_info_get_annotation, method_info_get_annotation)
961 (interface_info_add_annotation, method_info_add_annotation):
964 * glib/dbus-gidl.c (struct InterfaceInfo): Substitute "annotations"
966 (struct MethodInfo): Ditto.
967 Straightfoward conversion of binding methods into annotation methods
970 * glib/dbus-glib-tool.c (pretty_print): Print annotations.
972 * glib/dbus-binding-tool-glib.h (DBUS_GLIB_ANNOTATION_C_SYMBOL): Define.
974 * glib/dbus-binding-tool-glib.c (gather_marshallers, generate_glue):
975 Use new annotation API.
977 * doc/introspect.dtd: Fix a number of DTD syntax errors. Add
980 * doc/dbus-specification.xml: Discuss introspection annotations,
981 include list of well-known annotations.
983 * test/glib/test-service-glib.xml: Make validate against new DTD.
985 2005-02-17 Colin Walters <walters@verbum.org>
987 This patch is based on initial work from
988 Paul Kuliniewicz <kuliniew@purdue.edu>.
990 * glib/dbus-gvalue.c (dbus_gvalue_init): New function; move
991 initialization of GValue from dbus type to here.
992 (dbus_gvalue_genmarshal_name_from_type): New function; generates a string
993 for the "glib-genmarshal" program from a DBus type.
994 (dbus_gvalue_binding_type_from_type): New function; turns a DBus type
995 into the C name for it we use in the glib bindings.
996 (dbus_gvalue_ctype_from_type): New function; maps a DBus type into a
997 glib C type (not GValue).
998 (dbus_gvalue_demarshal): invoke dbus_gvalue_init.
1000 * glib/dbus-gutils.c (_dbus_gutils_wincaps_to_uscore): Moved here
1001 from dbus-gobject.c.
1003 * glib/dbus-gutils.h: Prototype it.
1005 * glib/dbus-gproxy.c: Include new dbus-gobject.h.
1006 (marshal_dbus_message_to_g_marshaller): Use new shared function
1007 dbus_glib_marshal_dbus_message_to_gvalue_array.
1009 * glib/dbus-gparser.c (parse_interface, parse_method): Handle c_name attribute.
1010 Will be changed once we have annotations.
1012 * glib/dbus-gobject.c: Change info_hash_mutex from GStaticMutex to
1013 GStaticRWLock. Callers updated.
1014 (wincaps_to_uscore): Move to dbus-gutils.c. Callers updated.
1015 (string_table_next): New function for iterating over zero-terminated
1017 (string_table_lookup): New function; retrieves specific entry in
1019 (get_method_data): New function; look up method data in object data chunk.
1020 (object_error_domain_prefix_from_object_info)
1021 (object_error_code_from_object_info): New functions, but not implemented yet.
1022 (method_interface_from_object_info): New function; retrieve interface name.
1023 (method_name_from_object_info): New function; retrieve method name.
1024 (method_arg_info_from_object_info): New function; retrieve argument data.
1025 (arg_iterate): New function; iterates over serialized argument data.
1026 (method_dir_signature_from_object_info): New function; returns a
1027 GString holding type signature for arguments for just one
1028 direction (input or output).
1029 (method_input_signature_from_object_info)
1030 (method_output_signature_from_object_info): New functions.
1031 (dbus_glib_marshal_dbus_message_to_gvalue_array): New shared function;
1032 converts dbus message arguments into a GValue array. Used for both
1033 signal handling and method invocation.
1034 (struct DBusGlibWriteIterfaceData): New utility structure.
1035 (write_interface): New function; generate introspection XML for
1037 (introspect_interfaces): New function; gathers all interface->methods,
1038 generates introspection XML for them.
1039 (handle_introspect): Invoke introspect_interfaces.
1040 (get_object_property): Be sure to zero-initalize stack-allocated GValue.
1041 (lookup_object_and_method): New function; examines an incoming message
1042 and attempts to match it up (via interface, method name, and argument
1043 signature) with a known object and method.
1044 (gerror_domaincode_to_dbus_error_name): New function; converts a
1045 GError domain and code into a DBus error name. Needs GError data
1046 added to object introspection to work well.
1047 (gerror_to_dbus_error_message): Creates a DBusMessage error return from
1049 (invoke_object_method): New function to invoke an object method
1050 looked up via lookup_object_and_method. Parses the incoming
1051 message, turns it into a GValue array, then invokes the marshaller
1052 specified in the DBusGMethodInfo. Creates a new message with
1053 either return values or error message as appropriate.
1054 (gobject_message_function): Invoke lookup_object_and_method and
1055 invoke_object_method.
1057 * glib/dbus-glib-tool.c: Include dbus-binding-tool-glib.h.
1058 (enum DBusBindingOutputMode): New enum for binding output modes.
1059 (pretty_print): Print binding names.
1060 (dbus_binding_tool_error_quark): GError bits.
1061 (version): Fix typo.
1062 (main): Create GIOChannel for output. Parse new --mode argument,
1063 possible values are "pretty-print", "glib-server", "glib-client".
1064 Use mode to invoke appropriate function.
1066 * glib/dbus-gobject.h: Prototype dbus_glib_marshal_dbus_message_to_gvalue_array.
1068 * glib/dbus-glib-tool.h: New header, just includes GError bits
1071 * glib/dbus-gidl.c (struct InterfaceInfo): Add bindings hashtable;
1072 maps binding style to name.
1073 (struct MethodInfo): Ditto.
1074 (get_hash_keys, get_hash_key): Utility function, returns keys for
1076 (interface_info_new, method_info_new): Initialize bindings.
1077 (interface_info_unref, method_info_unref): Destroy bindings.
1078 (method_info_get_binding_names, method_info_get_binding_name)
1079 (interface_info_get_binding_names, interface_info_get_binding_name):
1080 Functions for retrieving binding names.
1081 (method_info_set_binding_name, interface_info_set_binding_name):
1082 Functions for setting binding names.
1084 * glib/dbus-binding-tool-glib.h: New file, has prototypes
1085 for glib binding generation.
1087 * glib/dbus-binding-tool-glib.c: New file, implements server-side
1088 and client-side glib glue generation.
1090 * glib/Makefile.am (dbus_binding_tool_SOURCES): Add
1091 dbus-binding-tool-glib.c, dbus-binding-tool-glib.h,
1094 * dbus/dbus-glib.h (struct DBusGMethodMarshaller): Remove in favor
1095 of using GClosureMarshal directly.
1096 (struct DBusGObjectInfo): Add n_infos member.
1098 * test/glib/test-service-glib.xml: New file; contains introspection data
1099 for MyTestObject used in test-service-glib.c.
1101 * test/glib/test-service-glib.c (enum MyObjectError): New GError enum.
1102 (my_object_do_nothing, my_object_increment, my_object_throw_error)
1103 (my_object_uppercase, my_object_many_args): New test methods.
1104 (main): Use dbus_g_object_class_install_info to include generated object
1107 * test/glib/Makefile.am: Generate server-side glue for test-service-glib.c,
1108 as well as client-side bindings.
1110 * test/glib/test-dbus-glib.c: Include test-service-glib-bindings.h.
1111 (main): Activate TestSuiteGLibService; test invoke a bunch of its methods
1112 using both the dbus_gproxy stuff directly as well as the generated bindings.
1114 2005-02-15 Havoc Pennington <hp@redhat.com>
1116 * dbus/dbus-connection.c (dbus_connection_dispatch): always
1117 complete a pending call, don't run filters first.
1119 * glib/dbus-gproxy.c (dbus_g_proxy_end_call): change to use
1120 dbus_pending_call_steal_reply
1122 * dbus/dbus-pending-call.c (dbus_pending_call_block): just call
1123 _dbus_connection_block_pending_call
1124 (dbus_pending_call_get_reply): change to steal_reply and return a
1127 * dbus/dbus-connection.c
1128 (dbus_connection_send_with_reply_and_block): port to work in terms
1130 (_dbus_connection_block_pending_call): replace block_for_reply
1133 2005-02-14 Havoc Pennington <hp@redhat.com>
1135 * dbus/dbus-userdb-util.c (_dbus_user_database_lookup_group):
1136 properly handle looking up group information by name; fix
1139 2005-02-13 Havoc Pennington <hp@redhat.com>
1141 * dbus/dbus-connection.c (dbus_connection_return_message)
1142 (dbus_connection_borrow_message): hold dispatch lock while message
1144 (_dbus_connection_block_for_reply): hold dispatch lock while we
1145 block for the reply, so nobody steals our reply
1146 (dbus_connection_pop_message): hold the dispatch lock while we
1149 2005-02-13 Havoc Pennington <hp@redhat.com>
1151 * dbus/dbus-connection.c (_dbus_connection_acquire_dispatch)
1152 (_dbus_connection_release_dispatch)
1153 (_dbus_connection_acquire_io_path)
1154 (_dbus_connection_release_io_path): make the mutex and condvar
1155 control access to the "acquired" flag. Drop the connection lock
1156 while waiting on the condvar. Hopefully these are baby steps in
1157 roughly the right direction.
1159 2005-02-13 Havoc Pennington <hp@redhat.com>
1161 * dbus/dbus-connection.c: use separate mutexes for the condition
1162 variables; this is some kind of baseline for sanity, but the
1163 condition variables still aren't used correctly afaict
1165 2005-02-13 Havoc Pennington <hp@redhat.com>
1167 * dbus/dbus-object-tree.c (handle_default_introspect_and_unlock):
1170 * dbus/dbus-connection.c
1171 (_dbus_connection_detach_pending_call_unlocked): add this
1173 Initial semi-correct pass through to fix thread locking; there are
1174 still some issues with the condition variable paths I'm pretty
1177 * dbus/dbus-server.c: add a mutex on DBusServer and appropriate
1180 * dbus/dbus-connection.c (_dbus_connection_do_iteration_unlocked):
1181 rename to add _unlocked
1182 (struct DBusConnection): move "dispatch_acquired" and
1183 "io_path_acquired" to use only one bit each.
1184 (CONNECTION_LOCK, CONNECTION_UNLOCK): add checks with !DBUS_DISABLE_CHECKS
1185 (dbus_connection_set_watch_functions): hacky fix to reentrancy
1186 (_dbus_connection_add_watch, _dbus_connection_remove_watch)
1187 (_dbus_connection_toggle_watch, _dbus_connection_add_timeout)
1188 (_dbus_connection_remove_timeout)
1189 (_dbus_connection_toggle_timeout): drop lock when calling out to
1190 user functions; done in a hacky/bad way.
1191 (_dbus_connection_send_and_unlock): add a missing unlock
1192 (_dbus_connection_block_for_reply): add a missing unlock
1194 * dbus/dbus-transport.c (_dbus_transport_get_is_authenticated):
1195 drop lock in a hacky probably unsafe way to call out to user
1198 2005-02-12 Havoc Pennington <hp@redhat.com>
1200 * tools/dbus-tree-view.c (info_set_func_text): display more
1203 * bus/driver.c (bus_driver_handle_list_services): list the bus
1206 * glib/dbus-gparser.c (parse_arg): generate an arg name if none is supplied
1208 * glib/dbus-gidl.c (signal_info_get_n_args): new function
1209 (method_info_get_n_args): new function
1211 2005-02-12 Havoc Pennington <hp@redhat.com>
1213 * bus/driver.c (bus_driver_handle_introspect): add introspection
1216 2005-02-12 Havoc Pennington <hp@redhat.com>
1218 * bus/driver.c: put the signature of each bus driver method in the
1219 table of handlers and check it on incoming calls; this isn't
1220 really useful, but going to add introspect support in a minute.
1222 2005-02-11 Joe Shaw <joeshaw@novell.com>
1224 * mono/Connection.cs: The unpredictability of finalizers in mono
1225 prevents us from deterministically disconnecting the filters from
1226 the Service class's finalizer, so move tracking of filters and
1227 matches here. Add API for that.
1229 * mono/Service.cs: Remove the code, add code which calls the
1230 methods now on the Connection class.
1232 2005-02-11 John (J5) Palmieri <johnp@redhat.com>
1234 * python/dbus.py (class Sender): added to support dbus signals better
1235 (Bus::add_signal_receiver): added expand_args parameter which defaults
1236 to True. When expand args is True the signal handler will pass the
1237 message arguments as parameters to the signal handler. If False
1238 revert to previous behavior where the signal handler must get the
1239 argument list from the message. This is to help port applications
1240 like HAL that have a tendancy to send variable length argument lists.
1241 self._match_rule_to_receivers is now a dict of dicts.
1242 (Bus::remove_signal_receiver): pop handler off the dict intead of
1243 removing it from a list
1244 (Bus::_signal_func): change signal handlers so that interface,
1245 signal_name, service, path and message are packed into a Sender
1246 object and that is passed to the handler. If expand_args is True
1247 extract the args list from the message and append it to the parameter
1250 * python/dbus_bindings.pyx.in (class Signature): added to support
1252 (MessageIter::__init__): changed iteration limit to match D-BUS
1253 (MessageIter::get*): added INT16, UINT16, SIGNATURE, DICT_ENTRY,
1254 STRUCT and VARIENT type support
1255 (MessageIter::python_value_to_dbus_sig): made recursive to support
1257 (MessageIter::append*): added Signature, dict, tuple
1260 * python/examples/example-client.py: added examples of getting tuples
1263 * python/examples/example-service.py: added examples of sending tuples
1266 * python/examples/example-signal-recipient.py: Fixed to handle new
1267 signal callback format
1269 2005-02-10 Havoc Pennington <hp@redhat.com>
1271 * test/glib/test-dbus-glib.c (main): fix so this test doesn't fail
1272 (call dbus_g_proxy_add_signal)
1274 * dbus/dbus-server-unix.c (_dbus_server_new_for_tcp_socket):
1276 (_dbus_server_new_for_domain_socket): escape the path
1278 * dbus/dbus-address.c (dbus_address_escape_value): new
1279 (dbus_address_unescape_value): new
1280 (dbus_parse_address): unescape values
1282 * dbus/dbus-string.c (_dbus_string_append_byte_as_hex): new function
1284 * doc/dbus-specification.xml: explain how to escape values in
1287 2005-02-10 Havoc Pennington <hp@redhat.com>
1289 * dbus/dbus-message-factory.c (generate_special): modify test to
1290 avoid using a non-basic dict key
1292 * dbus/dbus-marshal-validate-util.c: add test for the below
1294 * doc/dbus-specification.xml: require that dict keys are a basic
1297 * dbus/dbus-marshal-validate.c
1298 (_dbus_validate_signature_with_reason): require that dict key is a
1301 2005-02-10 Havoc Pennington <hp@redhat.com>
1303 * dbus/dbus-object-tree.c (handle_default_introspect_and_unlock):
1304 change to be _and_unlock instead of _unlocked
1306 * dbus/dbus-connection.c
1307 (_dbus_connection_send_preallocated_unlocked_no_update): rename to
1308 have no_update so we can find this bug quickly in future
1310 2005-02-10 Havoc Pennington <hp@redhat.com>
1312 * dbus/dbus-message-util.c (verify_test_message): tests for string
1315 * dbus/dbus-message.c (dbus_message_append_args_valist): add
1316 support for arrays of string/signature/path
1318 2005-02-10 Joe Shaw <joeshaw@novell.com>
1320 * dbus/dbus-connection.c
1321 (_dbus_connection_queue_received_message_link,
1322 _dbus_connection_message_sent): Add the path to
1324 (_dbus_connection_send_preallocated_and_unlock): Added. Calls
1325 _dbus_connection_send_preallocated_unlocked(), updated the
1326 dispatch status, and unlocks. Fixes a bug where certain
1327 situations (like a broken pipe) could cause a Disconnect message
1328 to not be sent, tricking the bus into thinking a service was still
1329 there when the process had quit.
1330 (_dbus_connection_send_preallocated): Call
1331 _dbus_connection_send_preallocated_and_unlock().
1332 (_dbus_connection_send_and_unlock): Added. Calls
1333 _dbus_connection_send_preallocated_and_unlock().
1334 (dbus_connection_send): Call _dbus_connection_send_and_unlock().
1335 (dbus_connection_send_with_reply): Update the dispatch status and
1338 * mono/Service.cs (~Service): Added. Removes the filter so that
1339 we don't get unmanaged code calling back into a GCed delegate.
1340 (RemoveFilter); Added.
1342 2005-02-09 John (J5) Palmieri <johnp@redhat.com>
1344 * dbus/dbus-message.c (dbus_message_iter_open_container):
1345 - Removed check for iterator type being an array because
1346 get_arg_type does not work with writer iterators
1347 - Pass NULL to _dbus_type_writer_recurse if signiture is NULL
1349 2005-02-07 Havoc Pennington <hp@redhat.com>
1351 * doc/dbus-specification.xml: some more language cleanups; add
1352 stuff about how to deal with invalid protocol and extension
1353 points; add _ to allowed chars in auth commands; add EXTENSION_
1356 2005-02-06 Havoc Pennington <hp@redhat.com>
1358 * s/expected/required/ in a couple places for clarity
1360 2005-02-07 Colin Walters <walters@verbum.org>
1362 * bus/selinux.c (bus_selinux_allows_send): Handle NULL for
1363 sender or proposed_recipient.
1365 2005-02-06 Havoc Pennington <hp@redhat.com>
1367 * dbus/dbus-message-factory.c (generate_special): more tests
1369 * dbus/dbus-marshal-validate.c (validate_body_helper): detect
1370 array length that exceeds the maximum
1372 2005-02-05 Havoc Pennington <hp@redhat.com>
1374 * dbus/dbus-message-factory.c (generate_special): more test cases,
1377 * dbus/dbus-marshal-validate.c (validate_body_helper): return the
1378 reason why a signature was invalid
1380 * dbus/dbus-marshal-header.c (load_and_validate_field): fix to
1381 skip the length of the string before we look at it in validation
1383 * dbus/dbus-string-util.c (_dbus_string_test): add tests for
1386 * dbus/dbus-message.c (_dbus_message_loader_new): default
1387 max_message_length to DBUS_MAXIMUM_MESSAGE_LENGTH
1389 2005-02-05 Havoc Pennington <hp@redhat.com>
1391 * dbus/dbus-marshal-validate.c (validate_body_helper): fix crash
1392 if the signature of a variant was empty
1393 (_dbus_validate_signature_with_reason): catch "(a)" (array inside
1394 struct with no element type)
1396 * dbus/dbus-message-factory.c (generate_uint32_changed): add more
1397 mangled messages to break things
1399 2005-02-04 Havoc Pennington <hp@redhat.com>
1401 * glib/dbus-gproxy.c (dbus_g_proxy_disconnect_signal): use
1402 g_quark_try_string() so it actually can return 0
1403 (dbus_g_proxy_connect_signal): ditto
1405 2005-02-04 Havoc Pennington <hp@redhat.com>
1407 * glib/dbus-gproxy.c (dbus_g_proxy_emit_remote_signal): fix a
1409 (tristring_from_message): assert cleanly on null path/interface
1410 (should not be possible though I decided later)
1411 (dbus_g_proxy_dispose): move proxy manager unregistration here
1412 (DBUS_G_PROXY_DESTROYED): add this macro, and use it in a bunch of
1413 g_return_if_fail() checks
1415 2005-02-04 Havoc Pennington <hp@redhat.com>
1417 * doc/Makefile.am (EXTRA_DIST): add DTDs to makefile
1419 * doc/introspect.dtd: add introspect.dtd from David A. Wheeler
1420 (with some minor changes)
1422 * doc/dbus-specification.xml: add deprecated attribute to
1423 introspection format
1425 2005-01-31 Havoc Pennington <hp@redhat.com>
1427 * glib/dbus-gproxy.c: rewrite how signals work again, this time I
1428 think it's sort of right
1430 2005-01-30 Havoc Pennington <hp@redhat.com>
1432 * tools/dbus-viewer.c: kind of half-ass hook up the option menu.
1434 2005-01-30 Havoc Pennington <hp@redhat.com>
1436 * tools/dbus-names-model.c: dynamically watch NameOwnerChanged
1438 * autogen.sh: change to autotools 1.9
1440 * glib/dbus-gproxy.c: completely change how signals work
1441 (dbus_g_proxy_add_signal): new function to specify signature of a
1443 (dbus_g_proxy_emit_received): marshal the dbus message to GValues,
1444 and g_warning if the incoming message has the wrong signature.
1446 2005-01-30 Havoc Pennington <hp@redhat.com>
1448 * tools/dbus-names-model.c (have_names_notify): fix this
1450 * dbus/dbus-message.c (_dbus_message_iter_get_args_valist): clean
1451 up the string array handling a bit
1453 2005-01-30 Havoc Pennington <hp@redhat.com>
1455 * glib/dbus-glib.c (dbus_g_pending_call_set_notify): new function
1456 (dbus_g_pending_call_cancel): new function
1458 * dbus/dbus-glib.h: move GType decls for connection/message here;
1459 * dbus/dbus-glib.c: move all the g_type and ref/unref stuff in
1460 here, just kind of rationalizing how we handle all that
1462 * tools/dbus-names-model.c: new file for a tree model listing the
1465 * tools/dbus-tree-view.c (model_new): use proper typing on the
1468 2005-01-30 Havoc Pennington <hp@redhat.com>
1470 * glib/dbus-gmain.c: add a custom GSource back that just checks
1471 whether the message queue has anything in it; otherwise, there are
1472 cases where we won't see messages in the queue since there was no
1473 IO visible to the glib main loop
1475 * dbus/dbus-connection-internal.h (_DBUS_DEFAULT_TIMEOUT_VALUE):
1476 increase default message timeout to 25 seconds
1478 2005-01-30 Havoc Pennington <hp@redhat.com>
1480 * test/glib/test-profile.c (no_bus_stop_server): remove the
1481 warning about the g_warning that I just fixed
1483 * glib/dbus-gmain.c: rewrite the main loop stuff to avoid the
1484 custom source, seems to be a lot easier to understand and work
1487 2005-01-30 Havoc Pennington <hp@redhat.com>
1489 I think this main loop thing is conceptually broken, but here are
1490 some band aids. I'll maybe rewrite it in a minute.
1492 * glib/dbus-gmain.c (add_timeout): timeout stuff doesn't use the
1493 custom GSource, so don't pass it in; confusing
1494 (gsource_server_finalize, gsource_connection_finalize): add
1495 finalize handlers that remove all the watches.
1497 2005-01-30 Havoc Pennington <hp@redhat.com>
1499 * glib/dbus-gobject.c (introspect_properties): fix the XML
1502 * dbus/dbus-message.c (dbus_message_unref): add an in_cache flag
1503 which effectively detects the use of freed messages
1505 * glib/dbus-gobject.c (handle_introspect): modify and return the
1506 reply message instead of the incoming message
1508 * dbus/dbus-object-tree.c (handle_default_introspect_unlocked):
1509 gee, maybe it should SEND THE XML instead of just making a string
1510 and freeing it again ;-)
1512 * tools/dbus-print-message.c (print_message): improve printing of
1515 * configure.in: add debug-glib.service to the output
1517 2005-01-30 Havoc Pennington <hp@redhat.com>
1519 dbus-viewer introspected and displayed the bus driver
1521 * dbus/dbus-object-tree.c
1522 (object_tree_test_iteration): add tests for a handler registered on "/"
1524 * dbus/dbus-object-tree.c
1525 (_dbus_decompose_path): fix to handle path "/" properly
1526 (run_decompose_tests): add tests for path decomposition
1528 * glib/dbus-gutils.c (_dbus_gutils_split_path): fix to handle "/"
1531 * glib/dbus-gobject.c (handle_introspect): fix quotes
1533 * test/glib/run-test.sh: support launching the bus, then running
1536 * test/glib/test-service-glib.c (main): put in a trivial gobject
1537 subclass and register it on the connection
1539 * bus/driver.c (bus_driver_handle_introspect): implement
1540 introspection of the bus driver service
1542 * dbus/dbus-protocol.h: add #defines for the XML namespace,
1543 identifiers, doctype decl
1545 * bus/driver.c (bus_driver_handle_get_service_owner): handle
1546 attempts to get owner of DBUS_SERVICE_ORG_FREEDESKTOP_DBUS by
1547 returning the service unchanged.
1548 (bus_driver_handle_message): remove old check for reply_serial in
1549 method calls, now the message type deals with that
1550 (bus_driver_handle_message): handle NULL interface
1552 * glib/dbus-gproxy.c (dbus_g_proxy_get_bus_name): new function
1554 * glib/dbus-gloader-expat.c (description_load_from_string): allow
1557 * tools/dbus-viewer.c: add support for introspecting a service on
1560 * glib/dbus-gproxy.c (dbus_g_pending_call_ref): add
1561 (dbus_g_pending_call_unref): add
1563 2005-01-29 Havoc Pennington <hp@redhat.com>
1565 * tools/dbus-tree-view.c: add support for displaying properties.
1566 (run dbus-viewer with an introspect xml file as arg, then resize
1567 the window so the tree elements show up, not sure what that is)
1569 * glib/dbus-gobject.c (handle_introspect): return
1570 org.freedesktop.Properties and org.freedesktop.Introspectable
1571 interfaces when we are introspected.
1573 * doc/dbus-specification.xml: allow empty interface name when
1576 2005-01-29 Havoc Pennington <hp@redhat.com>
1578 * glib/Makefile.am: rename dbus-glib-tool to dbus-binding-tool;
1579 though it uses glib, it could be extended for any binding in
1582 * glib/dbus-gobject.c (gobject_message_function): change to the
1583 new way properties work
1585 * dbus/dbus-protocol.h: add the new interfaces
1587 * doc/dbus-specification.xml: document the introspection format,
1588 Introspectable interface, and add an org.freedesktop.Properties
1591 * glib/dbus-gparser.c: add support for a <property> element
1593 * glib/dbus-gidl.c: add PropertyInfo
1595 * glib/dbus-gobject.c (handle_introspect): put the outermost
1596 <node> outside the signal and property descriptions.
1597 (introspect_properties): export properties as <property> rather
1598 than as method calls
1600 2005-01-28 Havoc Pennington <hp@redhat.com>
1602 * doc/TODO, doc/dbus-specification.xml: spec and TODO tweaks
1603 related to authentication protocol
1605 2005-01-28 John (J5) Palmieri <johnp@redhat.com>
1607 * python/dbus_bindings.pyx.in: Updated to handle new D-BUS type system
1608 - BUS_ACTIVATION -> BUS_STARTER
1609 - DBUS_BUS_ACTIVATION -> DBUS_BUS_STARTER
1610 - class MessageIter (__init__): Added recursion checking
1611 so we throw a nice error instead of just disconnecting from the
1613 (get): Added arg_type parameter for recursion.
1614 Removed the nil type
1615 Added signiture type placeholder (not implemented)
1616 Added struct type placeholder (not implemented)
1617 Added varient type placeholder (not implemented)
1618 Commented out dict type for now
1619 (get_element_type): renamed from get_array_type
1620 (get_*): changed to use the dbus_message_iter_get_basic API
1621 (get_*_array): removed in favor of recursive get_array method
1622 (get_array): new recursive method which calls get to marshal
1623 the elements of the array
1624 (value_to_dbus_sig): New method returns the corrasponding
1625 dbus signiture to a python value
1626 (append): Comment out dict handling for now
1627 Handle lists with the new recursive API
1628 Comment out None handling for now
1629 (append_nil): removed
1630 (append_*): changed to use dbus_message_iter_append_basic API
1631 (append_*_array): removed in favor of recursive append_array
1633 (__str__): Make it easier to print out recursive iterators
1635 - class Message (__str__): moved type inspection to the
1636 MessageIter class' __str__ method
1637 (get_iter): Added an append parameter wich defaults to False
1638 If True use the new API's to create an append iterator
1640 * python/dbus.py: Update to use new bindings API
1641 - TYPE_ACTIVATION -> TYPE_STARTER
1642 - class Bus (_get_match_rule): GetServiceOwner -> GetNameOwner
1643 - class ActivationBus -> class StarterBus
1644 - class RemoteObject (__call__): get an append iterator
1645 - (_dispatch_dbus_method_call): get an append iterator
1646 - class Object (emit_signal): get an append iterator
1648 * python/examples/: Fixed up the examples to work with the new API
1650 2005-01-28 Joe Shaw <joeshaw@novell.com>
1652 * configure.in: Bump version up to 0.30.
1654 * HACKING: Add a release item to bump the version number up after
1657 2005-01-28 Havoc Pennington <hp@redhat.com>
1659 * doc/dbus-specification.xml: update to describe 16-bit types and
1662 * dbus/dbus-marshal-basic.c (_dbus_unpack_uint16): fix broken
1665 * dbus/dbus-protocol.h (DBUS_TYPE_DICT_ENTRY): add DICT_ENTRY as a
1668 * dbus/dbus-marshal-recursive.c: implement
1670 2005-01-27 Havoc Pennington <hp@redhat.com>
1672 * dbus/dbus-arch-deps.h.in: add 16/32-bit types
1674 * configure.in: find the right type for 16 and 32 bit ints as well
1677 * dbus/dbus-protocol.h (DBUS_TYPE_INT16, DBUS_TYPE_UINT16): add
1678 the 16-bit types so people don't have to stuff them in 32-bit or
1681 2005-01-27 Havoc Pennington <hp@redhat.com>
1683 * dbus/dbus-message.c: byteswap the message if you init an
1684 iterator to read/write from it
1686 * dbus/dbus-marshal-byteswap.c: new file implementing
1687 _dbus_marshal_byteswap()
1689 * dbus/dbus-marshal-basic.c: add _dbus_swap_array()
1691 2005-01-26 Havoc Pennington <hp@redhat.com>
1693 * dbus/dbus-marshal-validate-util.c: break this out (and fix
1694 build, apparently - nobody noticed?)
1696 2005-01-26 Havoc Pennington <hp@redhat.com>
1698 * dbus/dbus-marshal-recursive.h: remove todo comment
1700 2005-01-25 Joe Shaw <joeshaw@novell.com>
1702 * Land the mono binding changes to conform to the new APIs.
1704 * mono/Makefile.am: Remove Custom.cs, DBusType/Custom.cs,
1705 DBusType/Dict.cs, and DBusType/Nil.cs from the build.
1707 * mono/Arguments.cs (GetCodeAsString): Added. Returns the dbus
1708 type code as a string.
1709 (InitAppending): Rename dbus_message_append_iter_init() to
1710 dbus_message_iter_init_append().
1712 * mono/BusDriver.cs: Rename ServiceEventHandler to
1713 NameOwnerChangedHandler. Rename GetServiceOwner to GetOwner.
1714 Rename ServiceOwnerChanged to NameOwnerChanged.
1716 * mono/Connection.cs: Rename BaseService to UniqueName, and the
1719 * mono/Custom.cs: Removed. The CUSTOM type has been removed.
1721 * mono/Service.cs: Rename Exists to HasOwner, internally rename
1722 dbus_bus_acquire_service() to dbus_bus_request_name().
1724 * mono/DBusType/Array.cs (ctor): Use Type.GetElementType() instead
1725 of Type.UnderlyingSystemType to get the correct element type for
1727 (ctor): Update code for new APIs: use dbus_message_iter_recurse(),
1728 dbus_message_get_{element|arg}_type() instead of
1729 dbus_message_iter_init_array_iterator().
1730 (Append): Replace dbus_message_iter_append_array() with
1731 dbus_message_iter_open_container() and
1732 dbus_message_iter_close_container().
1734 * mono/DBusType/Custom.cs, mono/DBusType/Nil.cs: Removed. These
1735 types have been removed.
1737 * mono/DBusType/*.cs: Replace calls of
1738 dbus_message_iter_get_[type]() to dbus_message_iter_get_basic(),
1739 but specify the type in the DllImport extern declaration. Ditto
1740 for dbus_message_iter_append_[type]() ->
1741 dbus_message_iter_append_basic().
1743 * mono/example/BusListener.cs: Update for ServiceEventHandler ->
1744 NameOwnerChangedHandler.
1746 2005-01-25 John (J5) Palmieri <johnp@redhat.com>
1748 * python/dbus_bindings.pyx.in: Rename of methods and bindings
1749 - get_base_service -> get_unique_name
1750 - bus_get_base_service -> bus_get_unique_name
1751 - dbus_bus_get_base_service -> dbus_bus_get_unique_name
1752 - ACTIVATION_REPLY_ACTIVATED -> DBUS_START_REPLY_SUCCESS
1753 - ACTIVATION_REPLY_ALREADY_ACTIVE -> DBUS_START_REPLY_ALREADY_RUNNING
1754 - bus_activate_service -> bus_start_service_by_name
1755 - dbus_bus_activate_service -> dbus_bus_start_service_by_name
1756 - bus_acquire_service -> bus_request_name
1757 - dbus_bus_acquire_service -> dbus_bus_request_name
1758 - bus_service_exists -> bus_name_has_owner
1759 - dbus_bus_service_exists -> dbus_bus_name_has_owner
1761 * python/dbus.py: Rename of methods
1762 - activate_service -> start_service_by_name
1763 - bus_acquire_service -> bus_request_name
1764 - ACTIVATION_REPLY_ACTIVATED -> START_REPLY_SUCCESS
1765 - ACTIVATION_REPLY_ALREADY_ACTIVE -> START_REPLY_ALREADY_RUNNING
1768 2005-01-24 Joe Shaw <joeshaw@novell.com>
1770 * dbus/dbus-connection.c (dbus_connection_dispatch): Print out the
1771 signature for the method that can't be found.
1773 * dbus/dbus-message.c (dbus_message_iter_init): To check to see if
1774 the message has any arguments, we need to call
1775 _dbus_type_reader_get_current_type(), not
1776 _dbus_type_reader_has_next().
1778 2005-01-24 Havoc Pennington <hp@redhat.com>
1780 * dbus/dbus-message-factory.c: more testing of message validation
1782 * dbus/dbus-protocol.h (DBUS_MINIMUM_HEADER_SIZE): move to this
1785 2005-01-23 Havoc Pennington <hp@redhat.com>
1787 * dbus/dbus-message-factory.c, dbus/dbus-message-util.c:
1788 get this all working, not many tests in the framework yet though
1790 2005-01-22 Havoc Pennington <hp@redhat.com>
1792 * doc/dbus-faq.xml, doc/dbus-tutorial: add a FAQ and update
1793 tutorial, based on work from David Wheeler.
1795 2005-01-21 Havoc Pennington <hp@redhat.com>
1797 * dbus/dbus-bus.c: add more return_if_fail checks
1799 * dbus/dbus-message.c (load_message): have the "no validation"
1800 mode (have to edit the code to toggle the mode for now though)
1802 * dbus/dbus-marshal-header.c (_dbus_header_load): have a mode that
1803 skips all validation; I want to use this at least for benchmark
1804 baseline, I'm not sure if it should be a publicly-available switch.
1806 2005-01-21 Havoc Pennington <hp@redhat.com>
1808 * glib/dbus-gmain.c: don't put the GLib bindings in the same
1809 toplevel doxygen group as the low-level API stuff
1811 * dbus/dbus.h: note that libdbus is the low-level API
1813 2005-01-20 Havoc Pennington <hp@redhat.com>
1815 * update-dbus-docs.sh: script to update docs on the web site, only
1816 works for me though. neener.
1818 2005-01-20 Havoc Pennington <hp@redhat.com>
1820 * dbus/dbus-sysdeps.c (_dbus_poll): amazingly, trying to compile
1821 code can reveal bugs in it
1823 2005-01-20 Havoc Pennington <hp@redhat.com>
1825 * dbus/dbus-sysdeps.c (_dbus_poll): fix several bugs in the
1826 select() version, patches from Tor Lillqvist
1828 2005-01-20 Havoc Pennington <hp@redhat.com>
1830 * doc/dbus-tutorial.xml: replace > with >
1832 * bus/services.c (bus_registry_acquire_service): validate the name
1833 and return a better error if it's no good.
1835 * doc/dbus-specification.xml: note NO_AUTO_START change
1837 * dbus/dbus-protocol.h (DBUS_HEADER_FLAG_NO_AUTO_START): change
1838 from AUTO_START, we're toggling the default
1840 * bus/dispatch.c: adapt the tests to change of auto-start default
1842 2005-01-18 Havoc Pennington <hp@redhat.com>
1844 * rename dbus-daemon-1 to dbus-daemon throughout
1846 2005-01-18 Havoc Pennington <hp@redhat.com>
1848 * Throughout, grand renaming to strip out the use of "service",
1849 just say "name" instead (or "bus name" when ambiguous). Did not
1850 change the internal code of the message bus itself, only the
1851 programmer-facing API and messages.
1853 * doc/dbus-specification.xml: further update the message bus section
1855 * bus/config-parser.c (all_are_equiv): fix bug using freed string
1858 2005-01-17 Havoc Pennington <hp@redhat.com>
1860 * dbus/dbus-types.h: remove 16-bit types since we don't use them
1863 * dbus/dbus-marshal-validate.c (_dbus_validate_path): disallow any
1864 "invalid name character" not only non-ASCII
1866 * doc/dbus-specification.xml: further update spec, message bus
1867 parts are still out-of-date but the marshaling etc. stuff is now
1870 2005-01-17 Havoc Pennington <hp@redhat.com>
1872 * doc/dbus-specification.xml: partially update spec
1874 2005-01-17 Havoc Pennington <hp@redhat.com>
1876 * Throughout, align variant bodies according to the contained
1877 type, rather than always to 8. Should save a fair bit of space in
1880 * dbus/dbus-marshal-validate.c (_dbus_validate_body_with_reason):
1881 fix handling of case where p == end
1883 * doc/TODO: remove the dbus_bool_t item and variant alignment items
1885 2005-01-17 Havoc Pennington <hp@redhat.com>
1887 * dbus/dbus-types.h: hardcode dbus_bool_t to 32 bits
1889 * Throughout: modify DBUS_TYPE_BOOLEAN to be a 32-bit type instead
1890 of an 8-bit type. Now dbus_bool_t is the type to use whenever you
1891 are marshaling/unmarshaling a boolean.
1893 2005-01-16 Havoc Pennington <hp@redhat.com>
1895 This is about it on what can be disabled/deleted from libdbus
1896 easily, back below 150K anyhow. Deeper cuts are more work than
1897 just turning the code off as I've done here.
1899 * dbus/dbus-marshal-basic.c (_dbus_pack_int32): we don't need the
1900 signed int convenience funcs
1902 * dbus/dbus-internals.c (_dbus_verbose_real): omit when not in
1905 * dbus/dbus-string-util.c, dbus/dbus-string.c: more breaking
1906 things out of libdbus
1908 * dbus/dbus-sysdeps.c, dbus/dbus-sysdeps-util.c: same
1910 * dbus/dbus-hash.c: purge the TWO_STRINGS crap (well, make it
1911 tests-enabled-only, though it should probably be deleted)
1913 * dbus/dbus-message-util.c: same stuff
1915 * dbus/dbus-auth-util.c: same stuff
1917 2005-01-16 Havoc Pennington <hp@redhat.com>
1919 * dbus/dbus-userdb-util.c: split out part of dbus-userdb.c
1921 * dbus/dbus-sysdeps.c (_dbus_uid_from_string): move here to pave
1922 way for stripping down dbus-userdb.c stuff included in libdbus.
1923 Rename _dbus_parse_uid for consistency.
1925 2005-01-16 Havoc Pennington <hp@redhat.com>
1927 * dbus/dbus-internals.c (_dbus_real_assert): print the function
1928 name the assertion failed in
1930 * dbus/dbus-internals.h (_dbus_return_if_fail)
1931 (_dbus_return_val_if_fail): assert that the name of the function
1932 containing the check doesn't start with '_', since we only want to
1933 use checks on public functions
1935 * dbus/dbus-connection.c (_dbus_connection_ref_unlocked): change
1936 checks to assertions
1938 * dbus/dbus-marshal-header.c (_dbus_header_set_field_basic):
1939 change checks to asserts for private function
1941 * dbus/dbus-message.c (_dbus_message_set_serial): checks
1942 to asserts for private function
1944 * dbus/dbus-marshal-recursive.c (skip_one_complete_type): remove
1945 broken assertion that was breaking make check
1946 (_dbus_type_reader_array_is_empty): remove this rather than fix
1947 it, was only used in assertions
1949 2005-01-16 Havoc Pennington <hp@redhat.com>
1951 * test/unused-code-gc.py: hacky script to find code that's used
1952 only by the bus (not libdbus) or used only by tests or not used at
1953 all. It has some false alarms, but looks like we can clean up a
1954 lot of size from libdbus.
1956 * dbus/dbus-sysdeps.c, dbus/dbus-sysdeps-utils.c,
1957 dbus/Makefile.am: initially move 10K of binary size out of libdbus
1959 2005-01-16 Havoc Pennington <hp@redhat.com>
1961 * Add and fix docs according to Doxygen warnings throughout
1964 * dbus/dbus-marshal-recursive.c
1965 (_dbus_type_reader_array_is_empty): change this to just call
1966 array_reader_get_array_len() and make it static
1968 * dbus/dbus-message.c (dbus_message_iter_get_element_type): rename
1970 (dbus_message_iter_init_append): rename from append_iter_init
1972 * dbus/dbus-marshal-recursive.c
1973 (_dbus_type_reader_get_element_type): rename from
1974 _dbus_type_reader_get_array_type
1976 2005-01-15 Havoc Pennington <hp@redhat.com>
1978 * test/glib/test-profile.c (with_bus_server_filter): fix crash
1980 * dbus/dbus-marshal-basic.c (_dbus_unpack_uint32): inline as macro
1981 when DBUS_DISABLE_ASSERT
1982 (_dbus_marshal_set_basic): be sure we align for the string length
1984 * dbus/dbus-marshal-recursive.c (skip_one_complete_type): make
1987 * dbus/dbus-string.c (_dbus_string_get_const_data_len): add an
1988 inline macro version
1989 (_dbus_string_set_byte): provide inline macro version
1991 2005-01-15 Havoc Pennington <hp@redhat.com>
1993 * Land the new message args API and type system.
1995 This patch is huge, but the public API change is not
1996 really large. The set of D-BUS types has changed somewhat,
1997 and the arg "getters" are more geared toward language bindings;
1998 they don't make a copy, etc.
2000 There are also some known issues. See these emails for details
2002 http://lists.freedesktop.org/archives/dbus/2004-December/001836.html
2003 http://lists.freedesktop.org/archives/dbus/2005-January/001922.html
2005 * dbus/dbus-marshal-*: all the new stuff
2007 * dbus/dbus-message.c: basically rewritten
2009 * dbus/dbus-memory.c (check_guards): with "guards" enabled, init
2010 freed blocks to be all non-nul bytes so using freed memory is less
2011 likely to work right
2013 * dbus/dbus-internals.c (_dbus_test_oom_handling): add
2014 DBUS_FAIL_MALLOC=N environment variable, so you can do
2015 DBUS_FAIL_MALLOC=0 to skip the out-of-memory checking, or
2016 DBUS_FAIL_MALLOC=10 to make it really, really, really slow and
2019 * qt/message.cpp: port to the new message args API
2020 (operator<<): use str.utf8() rather than str.unicode()
2021 (pretty sure this is right from the Qt docs?)
2023 * glib/dbus-gvalue.c: port to the new message args API
2025 * bus/dispatch.c, bus/driver.c: port to the new message args API
2027 * dbus/dbus-string.c (_dbus_string_init_const_len): initialize the
2028 "locked" flag to TRUE and align_offset to 0; I guess we never
2029 looked at these anyhow, but seems cleaner.
2031 * dbus/dbus-string.h (_DBUS_STRING_ALLOCATION_PADDING):
2032 move allocation padding macro to this header; use it to implement
2033 (_DBUS_STRING_STATIC): ability to declare a static string.
2035 * dbus/dbus-message.c (_dbus_message_has_type_interface_member):
2036 change to return TRUE if the interface is not set.
2038 * dbus/dbus-string.[hc]: move the D-BUS specific validation stuff
2039 to dbus-marshal-validate.[hc]
2041 * dbus/dbus-marshal-basic.c (_dbus_type_to_string): move here from
2044 * dbus/Makefile.am: cut over from dbus-marshal.[hc]
2045 to dbus-marshal-*.[hc]
2047 * dbus/dbus-object-tree.c (_dbus_decompose_path): move this
2048 function here from dbus-marshal.c
2050 2005-01-12 Joe Shaw <joeshaw@novell.com>
2052 * NEWS: Update for 0.23.
2054 * configure.in: Release 0.23.
2056 2005-01-12 Joe Shaw <joeshaw@novell.com>
2058 * mono/Makefile.am, mono/example/Makefile.am: Always build the
2059 dbus DLL with --debug. Clean up after the .mdb files this leaves
2062 * mono/doc/Makefile.am: Need to uninstall the docs on "make
2065 * mono/Arguments.cs (GetDBusTypeConstructor): If the type
2066 is an enum, get the enum's underlying type. Another mono
2069 2005-01-11 Joe Shaw <joeshaw@novell.com>
2071 Patch from Sjoerd Simons <sjoerd@luon.net>
2073 * mono/Makefile.am, mono/example/Makefile.am: Don't redefine
2074 DESTDIR. It breaks stuff.
2076 2005-01-11 Joe Shaw <joeshaw@novell.com>
2078 Patch from Tambet Ingo <tambet@ximian.com>
2080 * mono/DBusType/Array.cs (Get): Get the underlying element type by
2081 calling type.GetElementType(). The code previously depended on
2082 broken Mono behavior, which was fixed in Mono 1.1.3.
2084 * mono/DBusType/Dict.cs (constructor): Fix the parameters for
2085 Activator.CreateInstance() so that the class's constructor is
2086 called with the right parameters.
2088 2005-01-11 Joe Shaw <joeshaw@novell.com>
2090 Patch from Timo Teräs <ext-timo.teras@nokia.com>
2092 * dbus/dbus-connection.c
2093 (_dbus_connection_queue_received_message_link): Call
2094 _dbus_connection_remove_timeout() instead of the _locked()
2095 variant, since it's always called from
2096 _dbus_connection_handle_watch(), which handles the locking.
2097 Removed the _locked() variant since it's no longer used.
2099 2005-01-03 Havoc Pennington <hp@redhat.com>
2101 * dbus/dbus-internals.h: I'm an idiot, _dbus_assert certainly can
2104 2004-12-26 Havoc Pennington <hp@redhat.com>
2106 * dbus/dbus-internals.h: add _DBUS_GNUC_NORETURN to _dbus_assert
2108 2005-01-03 Havoc Pennington <hp@redhat.com>
2110 * dbus/dbus-sysdeps.c (_dbus_sysdeps_test): fix using == on
2113 * dbus/dbus-string.c (_dbus_string_insert_alignment): new function
2115 2005-01-02 Havoc Pennington <hp@redhat.com>
2117 * dbus/dbus-internals.h (_DBUS_ALIGN_OFFSET): new macro
2119 2005-01-01 Havoc Pennington <hp@redhat.com>
2121 * configure.in: add -Wfloat-equal
2123 2005-01-01 Havoc Pennington <hp@redhat.com>
2125 * dbus/dbus-sysdeps.h: add _DBUS_DOUBLES_BITWISE_EQUAL macro,
2126 for a variety of reasons '==' doesn't do this.
2128 2004-12-31 Havoc Pennington <hp@redhat.com>
2130 * dbus/dbus-string.c (_dbus_string_equal_substrings): new function
2131 I keep wishing I had
2133 2004-12-30 John (J5) Palmieri <johnp@redhat.com>
2135 * python/dbus.py: s/ACTIVATION_REPLY_ACTIVE/ACTIVATION_REPLY_ACTIVATED
2137 2004-12-30 John (J5) Palmieri <johnp@redhat.com>
2139 * python/dbus_bindings.pyx.in: Change DBUS_ACTIVATION_REPLY_ACTIVATED
2140 and DBUS_ACTIVATION_REPLY_ALREADY_ACTIVE to match the values in
2141 dbus-protocol.h. Because they are defines and not enums they are not
2144 2004-12-26 John (J5) Palmieri <johnp@redhat.com>
2146 * python/dbus_bindings.pyx.in (bus_activate_service): Bind
2147 dbus_bus_activate_service
2149 * python/dbus.py (Bus.activate_service): activate a service on the
2152 2004-12-24 Havoc Pennington <hp@redhat.com>
2154 * test/decode-gcov.c: change to use .gcno and .gcda files, but the
2155 file format has also changed and I haven't adapted to that yet
2157 * Makefile.am: load .gcno files from latest gcc
2159 2004-12-23 John (J5) Palmieri <johnp@redhat.com>
2160 * Patch from Rob Taylor <robtaylor@fastmail.fm>
2162 * python/dbus_bindings.pyx.in (bus_get_unix_user): New
2165 * python/dbus.py (get_unix_user): Added binding to
2166 call dbus_bindings.bus_get_unix_user
2168 * python/extract.py: Modified the proto_pat regex to
2169 handle unsigned long
2171 2004-12-21 Olivier Andrieu <oliv__a@users.sourceforge.net>
2173 * dbus/make-dbus-glib-error-enum.sh: omit the function keyword for
2174 better POSIX compliance.
2176 2004-12-19 Havoc Pennington <hp@redhat.com>
2178 * dbus/dbus-string.c (_dbus_string_insert_4_aligned)
2179 (_dbus_string_insert_8_aligned): new functions
2181 * dbus/dbus-string.c (_dbus_string_alloc_space): new function
2183 2004-12-18 Havoc Pennington <hp@redhat.com>
2185 * dbus/dbus-string.c (_dbus_string_validate_ascii): use ISASCII
2188 * dbus/dbus-message.c: fix a comment, and add a still-unused
2189 not-implemented function
2191 * dbus/dbus-marshal.h: fix comment
2193 * dbus/dbus-internals.h (_DBUS_ISASCII): new macro
2195 2004-12-17 Joe Shaw <joeshaw@novell.com>
2197 * mono/DBusType/Byte.cs, mono/DBusType/Int32.cs,
2198 mono/DBusType/Int64.cs, mono/DBusType/UInt32.cs,
2199 mono/DBusType/UInt64.cs: Use Enum.GetUnderlyingType() instead of
2200 Type.UnderlyingSystemType to get the actual system type
2201 underneath. This code previously depended on the broken Mono
2202 behavior, which was fixed in 1.1.3.
2204 2004-11-27 Havoc Pennington <hp@redhat.com>
2206 * dbus/dbus-string.h (_dbus_string_get_byte): inline when asserts
2208 (_dbus_string_get_const_data): inline when asserts are disabled
2210 * dbus/dbus-message.c: record the _dbus_current_generation of
2211 creation so we can complain if dbus_shutdown() is used improperly.
2212 Do this only if checks are enabled.
2214 * dbus/dbus-connection.c: ditto
2216 2004-11-26 Havoc Pennington <hp@redhat.com>
2218 * test/glib/test-profile.c: add with_bus mode to profile echoes
2219 that go through the bus.
2221 * test/glib/run-test.sh: add ability to run test-profile
2223 * bus/dbus-daemon-1.1.in: fix to say that SIGHUP causes partial
2226 2004-11-26 Havoc Pennington <hp@redhat.com>
2228 * test/glib/test-profile.c: clean up how the fake_malloc_overhead
2229 thing was implemented
2231 2004-11-26 Havoc Pennington <hp@redhat.com>
2233 * test/glib/test-profile.c: tweak a bit, add support for some
2234 made-up minimal malloc overhead with plain sockets, since in
2235 real life some sort of buffers are unavoidable thus we could
2236 count them in the theoretical best case
2238 2004-11-26 Havoc Pennington <hp@redhat.com>
2240 * dbus/dbus-message.c (dbus_message_cache_or_finalize): fix bug
2241 where I was trying to cache one too many messages
2243 2004-11-26 Havoc Pennington <hp@redhat.com>
2245 * dbus/dbus-message.c: reimplement message cache as an array which
2246 makes the cache about twice as fast and saves maybe 1.5% overall
2248 2004-11-26 Havoc Pennington <hp@redhat.com>
2250 * dbus/dbus-threads.c (init_global_locks): forgot to put the
2251 message cache lock here
2253 2004-11-26 Havoc Pennington <hp@redhat.com>
2255 * dbus/dbus-message.c (struct DBusMessage): put the locked bit and
2256 the "char byte_order" next to each other to save 4 bytes
2257 (dbus_message_new_empty_header): reduce preallocation, since the
2258 message cache should achieve a similar effect
2259 (dbus_message_cache_or_finalize, dbus_message_get_cached): add a
2260 message cache that keeps a few DBusMessage around in a pool,
2261 another 8% speedup or so.
2263 * dbus/dbus-dataslot.c (_dbus_data_slot_list_clear): new function
2265 2004-11-25 Havoc Pennington <hp@redhat.com>
2267 * dbus/dbus-transport-unix.c (unix_do_iteration): if we're going
2268 to write, without reading or blocking, try it before the poll()
2269 and skip the poll() if nothing remains to write. This is about a
2270 3% speedup in the echo client/server
2272 2004-11-25 Havoc Pennington <hp@redhat.com>
2274 The primary change here is to always write() once before adding
2275 the write watch, which gives us about a 10% performance increase.
2277 * dbus/dbus-transport-unix.c: a number of modifications to cope
2278 with removing messages_pending
2279 (check_write_watch): properly handle
2280 DBUS_AUTH_STATE_WAITING_FOR_MEMORY; adapt to removal of
2281 messages_pending stuff
2282 (check_read_watch): properly handle WAITING_FOR_MEMORY and
2284 (unix_handle_watch): after writing, see if the write watch can be
2286 (unix_do_iteration): assert that write_watch/read_watch are
2287 non-NULL rather than testing that they aren't, since they
2288 aren't allowed to be NULL. check_write_watch() at the end so
2289 we add the watch if we did not finish writing (e.g. got EAGAIN)
2291 * dbus/dbus-transport-protected.h: remove messages_pending call,
2292 since it resulted in too much inefficient watch adding/removing;
2293 instead we now require that the transport user does an iteration
2294 after queueing outgoing messages, and after trying the first
2295 write() we add a write watch if we got EAGAIN or exceeded our
2296 max bytes to write per iteration setting
2298 * dbus/dbus-string.c (_dbus_string_validate_signature): add this
2301 * dbus/dbus-server-unix.c (unix_finalize): the socket name was
2302 freed and then accessed, valgrind flagged this bug, fix it
2304 * dbus/dbus-message.c: fix several bugs where HEADER_FIELD_LAST was taken
2305 as the last valid field plus 1, where really it is equal to the
2306 last valid field. Corrects some message corruption issues.
2308 * dbus/dbus-mainloop.c: verbosity changes
2310 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): handle OOM
2311 instead of aborting in one of the test codepaths
2313 * dbus/dbus-internals.c (_dbus_verbose_real): fix a bug that
2314 caused not printing the pid ever again if a verbose was missing
2315 the newline at the end
2316 (_dbus_header_field_to_string): add HEADER_FIELD_SIGNATURE
2318 * dbus/dbus-connection.c: verbosity changes;
2319 (dbus_connection_has_messages_to_send): new function
2320 (_dbus_connection_message_sent): no longer call transport->messages_pending
2321 (_dbus_connection_send_preallocated_unlocked): do one iteration to
2322 try to write() immediately, so we can avoid the write watch. This
2323 is the core purpose of this patchset
2324 (_dbus_connection_get_dispatch_status_unlocked): if disconnected,
2325 dump the outgoing message queue, so nobody will get confused
2326 trying to send them or thinking stuff is pending to be sent
2328 * bus/test.c: verbosity changes
2330 * bus/driver.c: verbosity/assertion changes
2332 * bus/dispatch.c: a bunch of little tweaks to get it working again
2333 because this patchset changes when/where you need to block.
2335 2004-11-23 Havoc Pennington <hp@redhat.com>
2337 * test/glib/test-profile.c: modify to accept a plain_sockets
2338 argument in which case it will bench plain sockets instead of
2339 libdbus, for comparison purposes.
2341 2004-11-22 Havoc Pennington <hp@redhat.com>
2343 * test/glib/test-profile.c (N_CLIENT_THREADS): run multiple
2344 threads for more time, so sysprof can get a grip on it.
2346 * dbus/dbus-string.c (_dbus_string_validate_utf8): remove
2349 2004-11-13 Havoc Pennington <hp@redhat.com>
2351 * test/glib/test-profile.c: fix this thing up a bit
2353 * dbus/dbus-message.c (dbus_message_new_empty_header): increase
2354 preallocation sizes by a fair bit; not sure if this will be an
2355 overall performance win or not, but it does reduce reallocs.
2357 * dbus/dbus-string.c (set_length, reallocate_for_length): ignore
2358 the test hack that forced constant realloc if asserts are
2359 disabled, so we can profile sanely. Sprinkle in some
2360 _DBUS_UNLIKELY() which are probably pointless, but before I
2361 noticed the real performance problem I put them in.
2362 (_dbus_string_validate_utf8): micro-optimize this thing a little
2363 bit, though callgrind says it didn't help; then special-case
2364 ascii, which did help a lot; then be sure we detect nul bytes as
2365 invalid, which is a bugfix.
2366 (align_length_then_lengthen): add some more _DBUS_UNLIKELY
2367 superstition; use memset to nul the padding instead of a manual
2369 (_dbus_string_get_length): inline this as a
2370 macro; it showed up in the profile because it's used for loop
2373 2004-11-10 Colin Walters <walters@verbum.org>
2375 * dbus/dbus-spawn.c (check_babysit_events): Handle EINTR,
2378 2004-11-09 Colin Walters <walters@verbum.org>
2380 * dbus/dbus-string.c (_dbus_string_get_length): New
2381 function, writes DBusString to C buffer.
2383 * dbus/dbus-string.h: Prototype it.
2385 * dbus/dbus-message.c (dbus_message_type_to_string): New
2386 function, converts message type into C string.
2388 * dbus/dbus-message.h: Prototype it.
2390 * bus/selinux.c (bus_selinux_check): Take source pid,
2391 target pid, and audit data. Pass audit data to
2393 (log_audit_callback): New function, appends extra
2395 (bus_selinux_allows_acquire_service): Also take
2396 service name, add it to audit data.
2397 (bus_selinux_allows_send): Also take message
2398 type, interface, method member, error name,
2399 and destination, and add them to audit data.
2400 (log_cb): Initialize func_audit.
2402 * bus/selinux.h (bus_selinux_allows_acquire_service)
2403 (bus_selinux_allows_send): Update prototypes
2405 * bus/services.c (bus_registry_acquire_service): Pass
2406 service name to bus_selinux_allows_acquire_service.
2408 * bus/bus.c (bus_context_check_security_policy): Pass
2409 additional audit data. Move assignment of dest
2412 2004-11-07 Colin Walters <walters@verbum.org>
2414 * dbus/dbus-transport-unix.c (do_authentication): Always
2415 initialize auth_completed.
2417 2004-11-07 Colin Walters <walters@verbum.org>
2419 * bus/bus.c (load_config): Break into three
2420 separate functions: process_config_first_time_only,
2421 process_config_every_time, and process_config_postinit.
2422 (process_config_every_time): Move call of
2423 bus_registry_set_service_context_table into
2424 process_config_postinit.
2425 (process_config_postinit): New function, does
2426 any processing that needs to happen late
2427 in initialization (and also on reload).
2428 (bus_context_new): Instead of calling load_config,
2429 open config parser here and call process_config_first_time_only
2430 and process_config_every_time directly. Later, after
2431 we have forked but before changing UID,
2432 invoke bus_selinux_full_init, and then call
2433 process_config_postinit.
2434 (bus_context_reload_config): As in bus_context_new,
2435 load parse file inside here, and call process_config_every_time
2436 and process_config_postinit.
2438 * bus/services.h, bus/services.c
2439 (bus_registry_set_service_context_table): Rename
2440 from bus_registry_set_sid_table. Take string hash from config
2441 parser, and convert them here into SIDs.
2443 * bus/config-parser.c (struct BusConfigParser): Have
2444 config parser only store a mapping of service->context
2446 (merge_service_context_hash): New function.
2447 (merge_included): Merge context string hashes instead
2448 of using bus_selinux_id_table_union.
2449 (bus_config_parser_new): Don't use bus_selinux_id_table_new;
2450 simply create a new string hash.
2451 (bus_config_parser_unref): Unref it.
2452 (start_selinux_child): Simply insert strings into hash,
2453 don't call bus_selinux_id_table_copy_over.
2455 * bus/selinux.h, bus/selinux.c (bus_selinux_id_table_union)
2456 (bus_selinux_id_table_copy_over): Delete.
2458 2004-11-03 Colin Walters <walters@verbum.org>
2460 * bus/selinux.c (bus_selinux_pre_init): Kill some unused
2463 2004-11-03 Colin Walters <walters@verbum.org>
2465 * bus/test-main.c (test_pre_hook): Fix test logic,
2466 thanks Joerg Barfurth <Joerg.Barfurth@Sun.COM>.
2468 2004-11-02 Colin Walters <walters@redhat.com>
2470 * bus/selinux.c (bus_selinux_init): Split into two functions,
2471 bus_selinux_pre_init and bus_selinux_post_init.
2472 (bus_selinux_pre_init): Just determine whether SELinux is
2474 (bus_selinux_post_init): Do everything else.
2476 * bus/main.c (main): Call bus_selinux_pre_init before parsing
2477 config file, and bus_selinux_post_init after. This ensures that
2478 we don't lose the policyreload notification thread that
2479 bus_selinux_init created before forking previously.
2481 * bus/test-main.c (test_pre_hook): Update for split.
2483 2004-10-31 Owen Fraser-Green <owen@discobabe.net>
2485 Patch from Johan Fischer <linux@fischaz.com>
2487 * mono/doc/Makefile.am (install-data-local): Added directory
2490 2004-10-29 Colin Walters <walters@redhat.com>
2492 * dbus/dbus-sysdeps.h (_dbus_become_daemon): Also take
2493 parameter for fd to write pid to.
2495 * dbus/dbus-sysdeps.c (_dbus_become_daemon): Implement it.
2497 * bus/bus.c (bus_context_new): Pass print_pid_fd
2498 to _dbus_become_daemon (bug #1720)
2500 2004-10-29 Colin Walters <walters@redhat.com>
2502 Patch from Ed Catmur <ed@catmur.co.uk>
2504 * mono/doc/Makefile.am (install-data-local): Handle
2507 2004-10-29 Colin Walters <walters@redhat.com>
2509 * bus/.cvsignore, qt/.cvsignore: Update.
2511 2004-10-29 Colin Walters <walters@redhat.com>
2513 Patch from Kristof Vansant <de_lupus@pandora.be>
2515 * configure.in: Detect Slackware.
2516 * bus/Makefile.am (SCRIPT_IN_FILES): Add rc.messagebus.in.
2517 * bus/rc.messagebus.in: New file.
2519 2004-10-29 Colin Walters <walters@redhat.com>
2521 * tools/dbus-monitor.c (filter_func): Return
2522 DBUS_HANDLER_RESULT_HANDLED in filter function
2524 http://freedesktop.org/pipermail/dbus/2004-August/001433.html
2526 2004-10-29 Colin Walters <walters@redhat.com>
2528 Patch from Matthew Rickard <mjricka@epoch.ncsc.mil>
2530 * bus/services.c (bus_registry_acquire_service):
2531 Correctly retrieve service name from DBusString
2534 2004-10-29 Colin Walters <walters@redhat.com>
2536 * dbus/dbus-glib.h: Update documentation to not
2537 refer to internal APIs.
2539 2004-10-27 Joe Shaw <joeshaw@novell.com>
2541 * mono/Arguments.cs (GetDBusTypeConstructor):
2542 type.UnderlyingSystemType will return "System.Byte" if you do it
2543 on "byte[]", which is not what we want. So check the type.IsArray
2544 property and use System.Array instead.
2546 2004-10-25 John (J5) Palmieri <johnp@redhat.com>
2548 * dbus/dbus-sysdeps.c (fill_user_info): On errors do not free
2549 the DBusUserInfo structure since this is passed into the function.
2550 This would cause a double free when the function that allocated
2551 the structure would try to free it when an error occured.
2553 * (bus/session.conf.in, bus/Makefile.am, dbus/configure.in):
2554 use /usr/share/dbus-1/services instead of /usr/lib/dbus-1.0/services
2555 for service activation to avoid 32bit/64bit parallel install issues
2557 2004-10-21 Colin Walters <walters@verbum.org>
2559 * AUTHORS: Fix my email address, the @gnu.org one
2560 has been bouncing for some time. Also add J5.
2562 2004-10-21 Colin Walters <walters@verbum.org>
2564 * dbus/dbus-transport-unix.c (do_authentication): Return
2565 authentication status to callers.
2566 (unix_handle_watch): If we completed authentication this round,
2567 don't do another read. Instead wait until the next iteration,
2568 after we've read any pending data in the auth buffer.
2569 (unix_do_iteration): Ditto.
2570 (unix_handle_watch): Updated for new do_authentication prototype.
2572 2004-10-18 Colin Walters <walters@verbum.org>
2574 * bus/selinux.c (bus_selinux_enabled): Handle
2575 --disable-selinux case.
2577 2004-10-18 Colin Walters <walters@verbum.org>
2579 * bus/selinux.h: Add bus_selinux_enabled.
2581 * bus/selinux.c (bus_selinux_enabled): Implement it.
2583 * bus/config-parser.c (struct include): Add
2584 if_selinux_enabled member.
2585 (start_busconfig_child): Parse if_selinux_enabled
2586 attribute for include.
2587 (bus_config_parser_content): Handle it.
2589 * bus/session.conf.in, bus/system.conf.in: Add
2590 inclusion of context mapping to default config files;
2591 conditional on SELinux being enabled.
2593 * doc/busconfig.dtd: Add to if_selinux_enabled to default DTD.
2595 * test/data/invalid-config-files/badselinux-1.conf,
2596 test/data/invalid-config-files/badselinux-2.conf:
2597 Test files for bad syntax.
2599 2004-10-17 Colin Walters <walters@verbum.org>
2601 * dbus/dbus-memory.c (_dbus_initialize_malloc_debug, check_guards)
2602 (dbus_malloc, dbus_malloc0, dbus_realloc): Fix up printf
2603 format specifier mismatches.
2605 2004-10-07 Olivier Andrieu <oliv__a@users.sourceforge.net>
2607 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): fix an incorrect
2610 * glib/dbus-dbus-gmain.c (dbus_g_bus_get): do not mangle NULL
2611 pointer (bug #1540, Leonardo Boiko).
2613 2004-09-28 Jon Trowbridge <trow@ximian.com>
2615 * mono/BusDriver.cs: Changed BusDriver struct to remove
2616 the ServiceCreated and ServiceDeleted events and replace them
2617 with the new ServiceOwnerChanged event.
2619 * mono/example/BusListener.cs: Added a new example program,
2620 which listens for and reports any ServiceOwnerChanged events
2623 * mono/example/Makefile.am (DESTDIR): Build changes for the
2624 new BusListener.cs example.
2626 2004-09-27 Olivier Andrieu <oliv__a@users.sourceforge.net>
2628 * bus/signals.c (bus_match_rule_parse): validate the components of
2629 match rules (bug #1439).
2631 * dbus/dbus-bus.c (dbus_bus_add_match): add a missing OOM test.
2633 2004-09-24 Olivier Andrieu <oliv__a@users.sourceforge.net>
2635 * doc/dbus-specification.xml: document ServiceOwnerChanged
2638 * bus/driver.c, bus/driver.h, bus/services.c: Use
2639 ServiceOwnerChanged signal instead of ServiceCreated and
2642 * bus/dispatch.c: update testcase for the new signal.
2644 2004-09-20 Jon Trowbridge <trow@ximian.com>
2646 Patch from Nat Friedman <nat@novell.com>
2648 * mono/Makefile.am: A number of small build fixes to allow "make
2649 distcheck" to succeed.
2651 * mono/example/Makefile.am: "make distcheck" fixes.
2653 * mono/AssemblyInfo.cs.in: When signing the assembly, look for the
2656 * test/Makefile.am: "make distcheck" fixes.
2658 2004-09-17 Olivier Andrieu <oliv__a@users.sourceforge.net>
2660 * dbus/dbus-sysdeps.c (_dbus_user_at_console): fix memleak in OOM.
2662 * doc/busconfig.dtd: update the DTD for the at_console attribute.
2664 * bus/driver.c (bus_driver_handle_hello): correctly handle Hello
2665 messages after the first one (bug #1389).
2667 * bus/dispatch.c (check_double_hello_message): add a test case for
2668 the double hello message bug.
2669 (check_existent_service_activation): fix check of spawning error.
2671 2004-09-16 David Zeuthen <david@fubar.dk>
2673 * python/dbus_bindings.pyx.in: Add support for int64 and uint64
2675 2004-09-12 David Zeuthen <david@fubar.dk>
2677 Patch from Kay Sievers <kay.sievers@vrfy.org>
2679 * bus/bus.c (bus_context_new):
2681 * bus/main.c (usage)
2683 Add commandline option --nofork to override configuration file
2686 2004-09-09 Olivier Andrieu <oliv__a@users.sourceforge.net>
2688 * dbus/dbus-*.h: remove the ; after DBUS_(BEGIN|END)_DECLS. Some C
2689 compilers don't like it (bug #974).
2691 2004-09-04 Harald Fernengel <harry@kdevelop.org>
2693 * qt/connection.*: Applied patch by Jérôme Lodewyck
2694 <lodewyck@clipper.ens.fr> to integrate an existing
2695 connection into the Qt eventloop
2697 2004-08-30 Jon Trowbridge <trow@ximian.com>
2699 * mono/BusDriver.cs: Added. This is a class for interacting with
2700 the org.freedesktop.DBus service.
2702 * mono/Message.cs: Added a mechanism to expose the message that is
2703 currently being dispatched via the static Message.Current
2704 property. Added Message.Sender and Message.Destination
2707 * mono/Handler.cs: Expose the dispatched message via
2708 Message.Current when handling method calls.
2710 * mono/Service.cs: Expose the dispatched message via
2711 Message.Current when handling signal emissions.
2713 * mono/Connection.cs: Bind dbus_bus_get_base_service via the
2714 Connection.BaseService property.
2716 2004-08-28 Havoc Pennington <hp@redhat.com>
2718 * dbus/dbus-userdb.c (_dbus_is_console_user): remove unused variable
2720 More fixes from Steve Grubb
2722 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): fix fd leak
2723 (_dbus_listen_tcp_socket): fix fd leak
2725 * dbus/dbus-spawn.c (read_pid, read_ints): move the "again:" for
2726 EINTR to a bit lower in the code
2728 2004-08-26 Jon Trowbridge <trow@ximian.com>
2730 * bus/driver.c (bus_driver_handle_service_exists): Respond with
2731 TRUE if we are inquiring about the existence of the built-in
2732 org.freedesktop.DBus service.
2734 2004-08-25 John Palmieri <johnp@redhat.com>
2735 * bus/config-parser.c:
2736 (struct PolicyType): Add POLICY_CONSOLE
2737 (struct Element.d.policy): s/gid_or_uid/gid_uid_or_at_console
2738 (start_busconfig_child): Sets up console element when
2739 <policy at_console=""> is encountered in a policy file
2740 (append_rule_from_element): Convert console elements to console
2744 (bus_policy_create_client_policy): Add console rules to the client
2745 policy based on if the client is at the console
2746 (bus_policy_append_console_rule): New function for adding a
2747 console rule to a policy
2748 (bus_policy_merge): Handle console rule merging
2750 * dbus/dbus-sysdeps.h: Added the DBUS_CONSOLE_DIR constant
2751 where we check for console user files
2753 * dbus/dbus-sysdeps.c:
2754 (_dbus_file_exists): New function which checks if the given
2756 (_dbus_user_at_console): New function which does the system
2757 specific process of checking if the user is at the console
2759 * dbus/dbus-userdb.c:
2760 (_dbus_is_console_user): New function converts a UID to user name
2761 and then calls the system specific _dbus_user_at_console to
2762 see if the user is at the console and therefor a console user
2764 2004-08-25 Olivier Andrieu <oliv__a@users.sourceforge.net>
2766 * bus/config-parser.c (set_limit):
2767 * bus/dbus-daemon-1.1.in:
2768 * test/data/valid-config-files/many-rules.conf: set the
2769 max_match_rules_per_connection limt from the config file.
2771 * doc/busconfig.dtd: update the DTD.
2773 * bus/driver.c: remove some unused variables.
2775 2004-08-24 Mikael Hallendal <micke@imendio.com>
2777 * dbus/dbus-glib-lowlevel.h: Removed dbus_bus_get_with_g_main since
2778 it's been replaced by dbus_g_bus_get
2780 2004-08-23 Colin Walters <walters@redhat.com>
2782 Updated SELinux support from Matthew Rickard <mjricka@epoch.ncsc.mil>
2784 * bus/selinux.h: Prototype bus_selinux_get_policy_root.
2786 * bus/selinux.c: Create a thread for policy reload notification.
2787 (bus_selinux_get_policy_root): Implement.
2789 * bus/config-parser.c (start_busconfig_child)
2790 (bus_config_parser_content): Support SELinux-root relative
2793 * configure.in <HAVE_SELINUX>: Add -lpthread.
2795 * bus/test-main.c (test_pre_hook, test_post_hook): New.
2796 (test_post_hook): Move memory checking into here.
2797 (test_pre_hook, test_post_hook): Move SELinux checks in
2798 here, but conditional on a DBUS_TEST_SELINUX environment
2799 variable. Unfortunately we can't run the SELinux checks
2800 as a normal user, since they won't have any permissions
2801 for /selinux. So this will have to be tested manually
2802 for now, until we have virtualization for most of
2805 2004-08-23 Havoc Pennington <hp@redhat.com>
2807 * dbus/dbus-sysdeps.c (_dbus_change_identity): add setgroups() to
2808 drop supplementary groups, suggested by Steve Grubb
2810 2004-08-20 Colin Walters <walters@redhat.com>
2812 * bus/config-parser.c (start_busconfig_child): Remove some unused
2815 * bus/selinux.c (bus_selinux_id_table_insert): Avoid compiler
2818 2004-08-17 Joe Shaw <joeshaw@novell.com>
2820 * configure.in: If --enable-mono is passed in, if we can't find
2823 * mono/Makefile.am: Use /gacutil to install assemblies into the
2826 2004-08-12 Havoc Pennington <hp@redhat.com>
2828 * NEWS: update for 0.22
2830 * configure.in: release 0.22
2832 2004-08-11 Colin Walters <walters@redhat.com>
2834 * tools/dbus-send.c (main, usage): Add --reply-timeout
2837 2004-08-10 Olivier Andrieu <oliv__a@users.sourceforge.net>
2839 * bus/bus.c (process_config_first_time_only): get rid of an unused
2840 DBusError that was causing a memoy leak (bug #989).
2842 * dbus/dbus-keyring.c, dbus/dbus-message.c:
2843 fix compilation on Solaris/Forte C (bug #974)
2845 * bus/main.c (main): plug two minuscule memleaks.
2847 2004-08-10 Havoc Pennington <hp@redhat.com>
2849 * doc/dbus-tutorial.xml: add some more info on GLib bindings
2851 2004-08-09 Havoc Pennington <hp@redhat.com>
2853 * COPYING: switch to Academic Free License version 2.1 instead of
2854 2.0, to resolve complaints about patent termination clause.
2856 2004-07-31 John (J5) Palmieri <johnp@redhat.com>
2858 * README: added documentation for the --enable-python
2861 2004-07-31 Olivier Andrieu <oliv__a@users.sourceforge.net>
2863 * bus/config-parser.c (bus_config_parser_new): fix an invalid
2864 _unref in the SELinux support.
2866 * doc/busconfig.dtd: update DTD for SELinux support.
2868 * bus/config-loader-libxml.c: fix error handler and parser
2869 initialisation/cleanup. OOM test now works with libxml2 HEAD.
2871 * configure.in: remove the warning about libxml2.
2873 * dbus/dbus-bus.c: silence doxygen warning.
2875 2004-07-31 Colin Walters <walters@redhat.com>
2877 * configure.in: Move #error in SELinux check to its own line.
2879 2004-07-31 Olivier Andrieu <oliv__a@users.sourceforge.net>
2881 * dbus/dbus-internals.h (_DBUS_SET_OOM):
2882 * bus/utils.h (BUS_SET_OOM): use dbus_error_set_const instead of
2885 * bus/dispatch.c (check_send_exit_to_service): fix the test case,
2886 broken by the change in the _SET_OOM macros.
2888 2004-07-31 Colin Walters <walters@redhat.com>
2890 * bus/selinux.c <HAVE_SELINUX>: Include utils.h to get
2893 2004-07-31 Colin Walters <walters@redhat.com>
2895 * configure.in: Use AC_TRY_COMPILE instead of AC_EGREP_HEADER
2896 to correctly detect DBUS__ACQUIRE_SVC. Also add an
2899 2004-07-24 Havoc Pennington <hp@redhat.com>
2901 SELinux support from Matthew Rickard <mjricka@epoch.ncsc.mil>
2903 * bus/selinux.c, bus/selinux.h: new file encapsulating selinux
2906 * configure.in: add --enable-selinux
2908 * bus/policy.c (bus_policy_merge): add FIXME to a comment
2910 * bus/main.c (main): initialize and shut down selinux
2912 * bus/connection.c: store SELinux ID on each connection, to avoid
2913 repeated getting of the string context and converting it into
2916 * bus/bus.c (bus_context_get_policy): new accessor, though it
2918 (bus_context_check_security_policy): check whether the security
2919 context of sender connection can send to the security context of
2920 recipient connection
2922 * bus/config-parser.c: add parsing for <selinux> and <associate>
2924 * dbus/dbus-transport.c (_dbus_transport_get_unix_fd): to
2925 implement dbus_connection_get_unix_fd()
2927 * dbus/dbus-connection.c (dbus_connection_get_unix_fd): new
2928 function, used by the selinux stuff
2930 2004-07-29 Olivier Andrieu <oliv__a@users.sourceforge.net>
2932 * bus/config-loader-libxml.c: complete the implementation of
2933 libxml backend for config file loader. Doesn't work with full OOM
2936 * configure.in: change error when selecting libxml into a warning.
2938 * test/data/invalid-config-files: add two non-well-formed XML
2941 * glib/Makefile.am: libdbus_gtool always uses expat, not libxml.
2943 * dbus/dbus-transport-unix.c (unix_handle_watch): do not
2944 disconnect in case of DBUS_WATCH_HANGUP, several do_reading() may
2945 be necessary to read all the buffer. (bug #894)
2947 * bus/activation.c (bus_activation_activate_service): fix a
2948 potential assertion failure (bug #896). Small optimization in the
2949 case of auto-activation messages.
2951 * dbus/dbus-message.c (verify_test_message, _dbus_message_test):
2952 add test case for byte-through-vararg bug (#901). patch by Kimmo
2955 2004-07-28 Anders Carlsson <andersca@gnome.org>
2958 * python/dbus_bindings.pyx.in:
2959 Add dbus.init_gthreads (), allow emit_signal to pass
2960 arguments to the signal.
2962 2004-07-24 Havoc Pennington <hp@redhat.com>
2964 * AUTHORS: add some people, not really comprehensively, let me
2965 know if I missed you
2967 2004-07-24 Havoc Pennington <hp@redhat.com>
2969 * Makefile.am (DIST_SUBDIRS): add DIST_SUBDIRS, problem solved by
2972 * test/Makefile.am (DIST_SUBDIRS): here also
2974 2004-07-22 Olivier Andrieu <oliv__a@users.sourceforge.net>
2976 * dbus/dbus-sysdeps.c (fill_user_info): fix inexistent label name,
2977 breaking build on Solaris, reported by Farhad Saberi on the ML.
2979 * dbus/dbus-message.c (dbus_message_append_args_valist): fix the
2980 va_arg invocation to account for integer promotion in the case of
2981 DBUS_TYPE_BYTE (unsigned char is promoted to int). (bug #901)
2983 * bus/services.c (bus_service_remove_owner): fix bug #902, use
2984 _dbus_list_get_first_link, not _dbus_list_get_first.
2986 * dbus/dbus-bus.c (dbus_bus_service_exists): plug a memory leak.
2988 * dbus/dbus-object-tree.c (free_subtree_recurse): always null
2989 handler functions so that the asserts in _dbus_object_subtree_unref
2992 * dbus/dbus-transport-unix.c (do_reading):
2993 _dbus_transport_queue_messages return value is of type
2994 dbus_bool_t, not DBusDispatchStatus.
2996 2004-07-19 David Zeuthen <david@fubar.dk>
2998 * dbus/dbus-protocol.h: Add DBUS_ERROR_UNIX_PROCESS_ID_UNKNOWN
3001 (check_get_connection_unix_user): Debug says GetProperty; but the
3002 method is called GetConnectionUnixUser
3003 (check_get_connection_unix_process_id): New function
3004 (bus_dispatch_test): Actually call check_get_connection_unix_user();
3005 also call check_get_connection_unix_process_id()
3008 (bus_driver_handle_get_connection_unix_process_id): New function,
3009 handles GetConnectionUnixProcessID on the org.freedesktop.DBus
3013 (handle_server_data_external_mech): Set pid from the credentials
3014 obtained from the socket
3016 * dbus/dbus-connection.c:
3017 (dbus_connection_get_unix_process_id): New function
3019 * dbus/dbus-connection.h:
3020 Add prototype for dbus_connection_get_unix_process_id
3022 * dbus/dbus-transport.c:
3023 (_dbus_transport_get_unix_process_id): New function
3025 * dbus/dbus-transport.h:
3026 Add prototype for _dbus_transport_get_unix_process_id
3028 2004-07-19 Olivier Andrieu <oliv__a@users.sourceforge.net>
3030 * dbus/dbus-message.c: Message counter fix, patch by Christian
3031 Hammond <chipx86@gnupdate.org>
3033 2004-07-18 Seth Nickell <seth@gnome.org>
3036 * python/dbus_bindings.pyx.in:
3037 * python/tests/test-client.py:
3039 Add dbus.ByteArray and dbus_bindings.ByteArray
3040 types so that byte streams can be passed back.
3042 Give jdahlin the heaps of credit that are so
3045 2004-07-12 Seth Nickell <seth@gnome.org>
3049 Add message argument to the default object_method_handler
3052 * python/dbus_bindings.pyx.in:
3054 Automatically return NIL when passed an empty list
3055 (we can't pass back a list since lists are typed
3056 and we don't have any idea what type the the client
3057 intended the list to be... :-( )
3059 2004-07-10 Seth Nickell <seth@gnome.org>
3061 * python/examples/Makefile.am:
3063 Fix distcheck breakage caused by new examples.
3065 2004-07-10 Seth Nickell <seth@gnome.org>
3069 Add "message" argument to service-side dbus.Object
3070 methods. This will break existing services written
3071 using the python bindings, but will allow extraction
3072 of all the message information (e.g. who its from).
3074 Add improved "object oriented" signal handling/emission.
3076 * python/examples/example-service.py:
3080 * python/examples/example-signal-emitter.py:
3081 * python/examples/example-signal-recipient.py:
3083 Two new examples that show how to emit and receive
3084 signals using the new APIs.
3086 * python/examples/example-signals.py:
3087 * python/examples/gconf-proxy-service.py:
3088 * python/examples/gconf-proxy-service2.py:
3090 Add "message" argument to service methods.
3092 2004-06-28 Kay Sievers <kay.sievers@vrfy.org>
3094 * bus/driver.c (bus_driver_handle_get_connection_unix_user)
3095 * dbus/bus.c (dbus_bus_get_unix_user)
3096 * doc/dbus-specification.xml: implement GetConnectionUnixUser
3097 method of org.freedesktop.DBus interface.
3099 * bus/dispatch.c: test case
3101 2004-06-23 John (J5) Palmieri <johnp@redhat.com>
3103 * python/Makefile.am: switched include directory from glib/ to dbus/
3104 since dbus-glib.h moved
3106 2004-06-22 Olivier Andrieu <oliv__a@users.sourceforge.net>
3108 * configure.in: prevent building the gcj stuff and libxml loader
3109 since they are broken.
3111 2004-06-20 Havoc Pennington <hp@redhat.com>
3113 * dbus/dbus-glib-error-enum.h: autogenerate the GError enum
3114 codes from the dbus error names
3116 * glib/dbus-glib.h: move to subdir dbus/ since it's included
3117 as dbus/dbus-glib.h and that breakage is now visible due to
3118 including dbus/dbus-glib.h in dbus-glib-lowlevel.h
3120 * glib/dbus-glib.h: s/gproxy/g_proxy/
3122 * dbus/dbus-shared.h: new header to hold stuff shared with
3125 * dbus/dbus-protocol.h (DBUS_ERROR_*): move errors here rather
3128 * glib/dbus-glib.h (dbus_set_g_error): move to
3129 dbus-glib-lowlevel.h
3131 * glib/dbus-glib.h: remove dbus/dbus.h from here; change a bunch
3132 of stuff to enable this
3134 * dbus/dbus-glib-lowlevel.h: put dbus/dbus.h here
3136 * a bunch of other changes with the same basic "separate glib
3137 bindings from dbus.h" theme
3139 2004-06-10 Owen Fraser-Green <owen@discobabe.net>
3141 * dbus-sharp.pc.in: Removed glib-sharp inclusion in Libs.
3143 * python/examples/Makefile.am: Fixed typo in EXTRA_DIST.
3145 2004-06-09 Olivier Andrieu <oliv__a@users.sourceforge.net>
3147 * bus/driver.c, dbus/dbus-bus.c: use BOOLEAN instead of UINT32 for
3148 the reply value of the ServiceExists message.
3150 2004-06-07 John (J5) Palmieri <johnp@redhat.com>
3152 * python/dbus_bindings.pyx.in: No longer need to parse path
3153 elements and pass them as arrays of strings. The C API now
3154 accepts plain path strings.
3155 (_build_parsed_path): removed
3157 2004-06-07 Havoc Pennington <hp@redhat.com>
3159 * doc/TODO: remove auto-activation item since it's done; sort
3160 items by importance/milestone
3162 2004-06-07 Havoc Pennington <hp@redhat.com>
3164 * dbus/dbus-message-builder.c (_dbus_message_data_load): append
3165 random signature when using REQUIRED_FIELDS (this hack won't work
3168 * dbus/dbus-message.c: change the signature to be a header field,
3169 instead of message->signature special-case string. Incremental
3170 step forward. Then we can fix up code to send the signature in the
3171 message, then fix up code to validate said signature, then fix up
3172 code to not put the typecodes inline, etc.
3173 (load_one_message): don't make up the signature after the fact
3174 (decode_header_data): require signature field for the known
3177 * dbus/dbus-marshal.c (_dbus_marshal_string_len): new
3179 * dbus/dbus-protocol.h: add DBUS_HEADER_FIELD_SIGNATURE
3181 2004-06-07 Owen Fraser-Green <owen@discobabe.net>
3183 * mono/DBusType/ObjectPath.cs: Renamed PathName argument to Path
3185 * mono/Handler.cs: Updated to follow new path argument for
3186 (un-)registering objects.
3188 * mono/example/Makefile.am:
3190 * configure.in: Bumped required version for mono and use new -pkg
3193 2004-06-05 Olivier Andrieu <oliv__a@users.sourceforge.net>
3195 * dbus/dbus-connection.h, dbus/dbus-connection.c: have object path
3196 registration functions take the path argument as char* instead of
3199 * dbus/dbus-marshal.h, dbus/dbus-marshal.c (_dbus_decompose_path):
3200 split off the path decompostion part of
3201 _dbus_demarshal_object_path. Some misc. fixes to silence compiler
3204 * glib/dbus-gobject.c, test/test-service.c: update accordingly.
3206 2004-06-02 Kristian Høgsberg <krh@redhat.com>
3208 * dbus/dbus-auth.c: Rewrite auth protocol handling to use a state
3209 machine approach. A state is implemented as a function that
3210 handles incoming events as specified for that state.
3212 * doc/dbus-specification.xml: Update auth protocol state machine
3213 specification to match implementation. Remove some leftover
3216 2004-06-02 Kristian Høgsberg <krh@redhat.com>
3218 * glib/dbus-gproxy.c, glib/dbus-gmain.c, dbus/dbus-string.c,
3219 dbus/dbus-object-tree.c, dbus/dbus-message.c: add comments to
3222 * Doxyfile.in: remove deprecated options.
3224 * dbus/dbus-message-handler.c, dbus/dbus-message-handler.h,
3225 glib/test-thread.h, glib/test-thread-client.c,
3226 glib/test-thread-server.c, glib/test-profile.c,
3227 glib/test-dbus-glib.c: remove these unused files.
3229 2004-06-01 Olivier Andrieu <oliv__a@users.sourceforge.net>
3231 * dbus/dbus-object-tree.c
3232 (_dbus_object_tree_dispatch_and_unlock): fix dispatch for
3233 non-fallback handlers (bug #684).
3234 (_dbus_object_subtree_new): initialize invoke_as_fallback field.
3235 (find_subtree_recurse): report wether the returned subtree is an
3236 exact match or a "fallback" match higher up in the tree.
3237 (object_tree_test_iteration): update test case.
3239 2004-06-01 Seth Nickell <seth@gnome.org>
3241 * python/dbus_bindings.pyx.in:
3242 * python/tests/test-client.py:
3244 Round off basic type support. Add dicts (yay!), and
3245 remaining array types.
3247 Make MessageIter more general so it works for dicts too.
3249 Mark all loop variables as C integers.
3251 2004-05-31 Havoc Pennington <hp@redhat.com>
3253 * glib/dbus-gidl.c (method_info_add_arg): keep args sorted with
3256 * glib/dbus-gobject.c (dbus_type_to_string): move to dbus-gutils.c
3258 * glib/dbus-glib-tool.c (main): set up to have a --self-test
3259 option that runs the tests, and start filling in some code
3260 including for starters just dumping the interfaces to stdout
3262 * glib/Makefile.am (INCLUDES): define DBUS_LOCALEDIR
3264 * test/data/valid-introspection-files/lots-of-types.xml: test of
3265 an example introspection file
3267 * glib/dbus-gparser.c (parser_check_doctype): doctype should be
3270 2004-05-31 Seth Nickell <seth@gnome.org>
3272 * python/dbus_bindings.pyx.in:
3273 * python/tests/test-client.py:
3278 Fix string array memory trashing bug... oops...
3280 2004-05-30 Seth Nickell <seth@gnome.org>
3284 Add a nicer-but-less-flexible alternate API for handling
3285 calls to virtual objects in dbus.ObjectTree.
3287 Screw up the argument order to the dbus.Object constructor
3288 for consistency with dbus.ObjectTree (and to make dbus_methods
3289 optional for future extension)
3291 * python/examples/Makefile.am:
3292 * python/examples/gconf-proxy-service.py:
3293 * python/examples/gconf-proxy-service2.py:
3295 Alternate implementation of gconf-proxy-service using the
3296 nicer dbus.ObjectTree API.
3298 * python/examples/example-service.py:
3299 * python/tests/test-server.py
3301 Reverse the argument order to deal with dbus.Object constructor
3304 2004-05-30 Seth Nickell <seth@gnome.org>
3306 * python/examples/example-client.py:
3307 * python/examples/example-service.py:
3309 Take it back. Lists seem to work but they're broken
3310 in the test suite. Make the base examples use
3313 2004-05-30 Seth Nickell <seth@gnome.org>
3315 * python/dbus_bindings.pyx.in:
3316 * python/tests/test-client.py:
3318 Add some more tests and fix errors that crop up.
3319 Unfortunately, currently it seems like marshalling
3320 and unmarshalling of lists is completely broken :-(
3322 2004-05-30 Seth Nickell <seth@gnome.org>
3324 * python/dbus_bindings.pyx.in:
3326 Add support for ObjectPath type.
3330 Refactor message handling code to a common function.
3332 * python/tests/test-client.py:
3333 * python/tests/test-server.py:
3335 Add tests that check to make sure values of all types
3336 can be echoed from a service w/o mangling.
3338 2004-05-29 Seth Nickell <seth@gnome.org>
3342 Add ObjectTree class which allows implementation
3343 of trees of "virtual" objects. Basically the python
3344 wrapper for "register_fallback".
3346 * python/examples/Makefile.am
3347 * python/examples/gconf-proxy-client.py:
3348 * python/examples/gconf-proxy-service.py:
3350 Implement a simple GConf proxy service that supports
3351 get/set on string and int GConf keys using the ObjectTree.
3353 2004-05-29 Seth Nickell <seth@gnome.org>
3356 * python/examples/example-client.py:
3357 * python/examples/example-service.py:
3358 * python/examples/list-system-services.py:
3360 Add SessionBus, SystemBus and ActivationBus classes
3361 so you don't need to know the special little BUS_TYPE
3364 2004-05-29 Havoc Pennington <hp@redhat.com>
3366 * bus/config-parser.c (process_test_valid_subdir): temporarily
3367 stop testing config parser OOM handling, since expat has issues
3368 http://freedesktop.org/pipermail/dbus/2004-May/001153.html
3370 * bus/dbus-daemon-1.1.in: change requested_reply to
3371 send_requested_reply/receive_requested_reply so we can send the
3372 replies, not just receive them.
3374 * bus/config-parser.c: parse the new
3375 send_requested_reply/receive_requested_reply
3377 * bus/policy.c (bus_client_policy_check_can_send): add
3378 requested_reply argument and use it
3380 * bus/bus.c (bus_context_check_security_policy): pass through
3381 requested_reply status to message send check
3383 * bus/system.conf.in: adapt to requested_reply change
3385 2004-05-28 Havoc Pennington <hp@redhat.com>
3387 * test/glib/test-service-glib.c (main): remove unused variable
3389 * glib/dbus-gidl.c (base_info_ref): fix a silly compiler warning
3391 * dbus/dbus-auth.h (enum): remove AUTHENTICATED_WITH_UNUSED_BYTES
3392 from the enum, no longer in use.
3394 * dbus/dbus-sysdeps.h: include config.h so DBUS_VA_COPY actually
3397 * dbus/dbus-message.c: add various _dbus_return_val_if_fail for
3398 whether error_name passed in is a valid error name.
3400 2004-05-28 John (J5) Palmieri <johnp@redhat.com>
3402 * dbus/dbus-message.c (dbus_message_get_args): Added support for
3403 OBJECT_PATH and OBJECT_PATH_ARRAY
3405 2004-05-28 Seth Nickell <seth@gnome.org>
3407 * python/examples/Makefile.am:
3409 Forget to add Makefile.am. Do not pass go.
3411 2004-05-28 Michael Meeks <michael@ximian.com>
3413 * glib/dbus-gvalue.c (dbus_gvalue_marshal, dbus_gvalue_demarshal):
3416 * dbus/dbus-string.c (_dbus_string_parse_basic_type): impl.
3418 * dbus/dbus-message.c (_dbus_message_iter_get_basic_type),
3419 (_dbus_message_iter_get_basic_type_array): impl.
3420 drastically simplify ~all relevant _get methods to use these.
3421 (_dbus_message_iter_append_basic_array),
3422 (dbus_message_iter_append_basic): impl
3423 drastically simplify ~all relevant _append methods to use these.
3425 * dbus/dbus-message-builder.c (parse_basic_type)
3426 (parse_basic_array, lookup_basic_type): impl.
3427 (_dbus_message_data_load): prune scads of duplicate /
3430 * dbus/dbus-marshal.c (_dbus_demarshal_basic_type_array)
3431 (_dbus_demarshal_basic_type): implement,
3432 (demarshal_and_validate_len/arg): beef up debug.
3433 (_dbus_marshal_basic_type, _dbus_marshal_basic_type_array): impl.
3435 2004-05-27 Seth Nickell <seth@gnome.org>
3438 * python/Makefile.am:
3440 Include the example python apps in the tarball.
3442 * python/examples/list-system-services.py
3444 Add a python new example that fetches the list of services
3445 from the system bus.
3447 2004-05-27 Seth Nickell <seth@gnome.org>
3450 * python/dbus_bindings.pyx.in:
3452 Fix failure to notify that a signal was not handled,
3453 resulted in hung functions.
3455 2004-05-25 Colin Walters <walters@redhat.com>
3457 * tools/dbus-monitor.c (main): Monitor all types of messages.
3459 2004-05-23 Owen Fraser-Green <owen@discobabe.net>
3461 * mono/Handler.cs, mono/Service.cs: Added UnregisterObject method
3462 which unregisters the object path and disposes the handler.
3464 2004-05-23 Kristian Høgsberg <krh@redhat.com>
3466 Patch from Timo Teräs <ext-timo.teras@nokia.com> (#614):
3468 * dbus/dbus-message.c (dbus_message_iter_get_args_valist): Swap
3469 operands to && so we call dbus_message_iter_next () for the last
3472 2004-05-21 Olivier Andrieu <oliv__a@users.sourceforge.net>
3474 * dbus/dbus-object-tree.c
3475 (_dbus_object_tree_list_registered_unlock, lookup_subtree): return
3476 children even if the requested path isn't registered.
3477 (object_tree_test_iteration): test object_tree_list_registered.
3479 * configure.in: undefine HAVE_ABSTRACT_SOCKETS instead of defining
3482 2004-05-20 Kristian Høgsberg <krh@redhat.com>
3484 * doc/TODO: Remove resolved items.
3486 * bus/expirelist.h (struct BusExpireList): remove unused n_items
3489 * bus/connection.c (bus_connections_expect_reply): Enforce the
3490 per-connection limit on pending replies.
3492 Patch from Jon Trowbridge <trow@ximian.com>:
3494 * bus/main.c (setup_reload_pipe): Added. Creates a pipe and sets
3495 up a watch that triggers a config reload when one end of the pipe
3497 (signal_handler): Instead of doing the config reload in our SIGHUP
3498 handler, just write to the reload pipe and let the associated
3499 watch handle the reload when control returns to the main loop.
3501 * bus/driver.c (bus_driver_handle_reload_config): Added.
3502 Implements a ReloadConfig method for requesting a configuration
3503 file reload via the bus driver.
3505 2004-05-19 Owen Fraser-Green <owen@discobabe.net>
3507 * HACKING: Updated release instructions concerning the wiki page.
3509 2004-05-18 Kristian Høgsberg <krh@redhat.com>
3511 * dbus/dbus-auth.c (client_try_next_mechanism): Remove logic to
3512 filter against auth->allowed_mechs; we only add allowed mechs in
3513 record_mechanisms().
3515 * dbus/dbus-auth-script.c (_dbus_auth_script_run): Add an
3516 ALLOWED_MECHS to auth-script format so we can set the list of
3519 * data/auth/client-out-of-mechanisms.auth-script: New test to
3520 check client disconnects when it is out of mechanisms to try.
3522 * dbus/dbus-auth.c (process_command): Remove check for lines
3523 longer that 1 MB; we only buffer up maximum 16 kB.
3525 * dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
3526 dbus/dbus-auth-script.c, dbus/dbus-auth.c, dbus/dbus-auth.h:
3527 Remove auth state AUTHENTICATED_WITH_UNUSED_BYTES, instead always
3528 assume there might be unused bytes.
3530 * dbus/dbus-auth.c (_dbus_auth_do_work): Remove check for
3531 client-out-of-mechs, it is handled in process_reject(). Move check
3532 for max failures to send_rejected(), as it's a server-only thing.
3534 * dbus/dbus-auth.c: Factor out protocol reply code into functions
3535 send_auth(), send_data(), send_rejected(), send_error(),
3536 send_ok(), send_begin() and send_cancel().
3538 2004-05-17 Kristian Høgsberg <krh@redhat.com>
3540 Remove base64 encoding, replace with hex encoding. Original patch
3541 from trow@ximian.com, added error handling.
3543 * dbus/dbus-string.c (_dbus_string_base64_encode)
3544 (_dbus_string_base64_decode): Remove.
3545 (_dbus_string_hex_decode): Add end_return argument so we can
3546 distinguish between OOM and invalid hex encoding.
3547 (_dbus_string_test): Remove base64 tests and add test case for
3550 * dbus/dbus-keyring.c, dbus/dbus-auth-script.c, dbus/dbus-auth.c:
3551 Replace base64 with hex.
3553 * test/data/auth/invalid-hex-encoding.auth-script: New test case
3554 for invalid hex encoded data in auth protocol.
3556 2004-05-17 Olivier Andrieu <oliv__a@users.sourceforge.net>
3558 * dbus/dbus-connection.c (check_for_reply_unlocked): plug a memory
3561 2004-05-15 Owen Fraser-Green <owen@discobabe.net>
3563 * mono/dbus-sharp.dll.config.in: Added for GAC
3564 * mono/dbus-sharp.snk: Added for GAC
3565 * mono/Assembly.cs.in: Added for GAC
3566 * mono/Makefile.am: Changes for GAC installation
3567 * configure.in: Added refs for dbus-sharp.dll.config.in and
3568 Assembly.cs.in. More fixes for mono testing
3569 * mono/example/Makefile.am: Changed var to CSC
3570 * Makefile.am: Changed flag name to DBUS_USE_CSC
3572 2004-05-15 Owen Fraser-Green <owen@discobabe.net>
3574 * mono/Makefile.am: Added SUBDIRS for docs. Changed SUBDIRS order
3575 * mono/doc/*: Added documentation framework
3576 * configure.in: Added monodoc check
3577 * README: Added description of mono configure flags
3579 2004-05-11 John (J5) Palmieri <johnp@redhat.com>:
3581 * doc/dbus-specification.xml: Added a "Required" column to the
3582 header fields table and changed the "zero or more" verbage in
3583 the above paragraph to read "The header must contain the required
3584 named header fields and zero or more of the optional named header
3586 * test/data/invalid-messages/*.message: Added the required PATH
3587 named header field to the tests so that they don't fail on
3588 'Missing path field'
3590 2004-05-07 John (J5) Palmieri <johnp@redhat.com>
3592 * python/dbus-bindings.pyx.in: Stopped the bindings from trashing
3593 the stack by implicitly defining variable and parameter types and
3594 removing the hack of defining C pointers as python objects and later
3597 2004-05-02 Owen Fraser-Green <owen@discobabe.net>
3599 * mono/Makefile.am: Removed test-dbus-sharp.exe from all target
3601 2004-05-01 Owen Fraser-Green <owen@discobabe.net>
3603 * mono/DBusType/Dict.cs: Handle empty dicts
3604 * mono/DBusType/Array.cs: Handle empty arrays
3605 * mono/Arguments.cs: Handle empty arguments
3607 2004-04-30 Owen Fraser-Green <owen@discobabe.net>
3609 * dbus-sharp.pc.in: Modified to include include Libs and Requires
3612 2004-04-25 Kristian Høgsberg <krh@redhat.com>
3614 * test/data/valid-messages/standard-*.message: Update message
3615 test scripts to new header field names.
3617 2004-04-22 John (J5) Palmieri <johnp@redhat.com>
3619 * test/break-loader.c (randomly_do_n_things): tracked down buffer
3620 overflow to times_we_did_each_thing array which would chop off the
3621 first character of the failure_dir string. Increased the size of
3622 the array to 7 to reflect the number of random mutation functions
3625 2004-04-21 Kristian Høgsberg <krh@redhat.com>
3627 * dbus/dbus-server-unix.c (unix_finalize): Don't unref
3628 unix_server->watch here, it is unreffed in disconnect.
3629 (_dbus_server_new_for_tcp_socket): convert NULL host to
3630 "localhost" here so we don't append NULL to address.
3632 * dbus/dbus-server.c (_dbus_server_test): Add test case for
3633 various addresses, including tcp with no explicit host.
3635 2004-04-21 Olivier Andrieu <oliv__a@users.sourceforge.net>
3637 * dbus/dbus-message.c (decode_header_data, decode_string_field):
3638 fix incorrect setting of .name_offset in the HeaderField (it was
3639 off by two bytes, positioned right after the name and typecode)
3641 * bus/bus.c (bus_context_new, bus_context_unref): test before
3642 calling dbus_server_free_data_slot and _dbus_user_database_unref
3643 in case of an error.
3645 * tools/Makefile.am: add $(DBUS_GLIB_TOOL_LIBS), xml libs needed
3648 2004-04-19 Kristian Høgsberg <krh@redhat.com>
3650 * dbus/dbus-transport-unix.c (unix_do_iteration): Rewrite to use
3651 _dbus_poll() instead of select().
3653 2004-04-15 Jon Trowbridge <trow@ximian.com>
3655 * bus/main.c (signal_handler): Reload the configuration files
3657 (main): Set up our SIGHUP handler.
3659 * bus/bus.c (struct BusContext): Store the config file, user and
3660 fork flag in the BusContext.
3661 (process_config_first_time_only): Added. Contains the code
3662 (previously in bus_context_new) for setting up the BusContext from
3663 the BusConfigParser that should only be run the first time the
3664 config files are read.
3665 (process_config_every_time): Added. Contains the code (previously
3666 in bus_context_new) for setting up the BusContext from the
3667 BusConfigParser that should be run every time the config files are
3669 (load_config): Added. Builds a BusConfigParser from the config
3670 files and passes the resulting structure off to
3671 process_config_first_time_only (assuming this is the first time)
3672 and process_config_every_time.
3673 (bus_context_new): All of the config-related code has been moved
3674 to process_config_first_time_only and process_config_every_time.
3675 Now this function just does the non-config-related initializations
3676 and calls load_config.
3677 (bus_context_reload_config): Added.
3679 2004-04-15 Olivier Andrieu <oliv__a@users.sourceforge.net>
3681 * bus/driver.c (bus_driver_handle_get_service_owner):
3682 implement a GetServiceOwner method.
3683 * doc/dbus-specification.xml: document it.
3684 * dbus/dbus-errors.h: add a 'ServiceHasNoOwner' error.
3686 * glib/dbus-gproxy.c (dbus_gproxy_new_for_service_owner):
3687 implement, using the bus GetServiceOwner method.
3689 * test/glib/test-dbus-glib.c:
3690 use dbus_gproxy_new_for_service_owner so that we can receive the
3693 2004-04-15 John (J5) Palmieri <johnp@redhat.com>
3695 * dbus/dbus-internals.c, dbus/dbus-message-builder.c,
3696 dbus/dbus-message.c, dbus/dbus-protocol.h
3697 (DBUS_HEADER_FIELD_SERVICE): renamed DBUS_HEADER_FIELD_DESTINATION
3699 * dbus/dbus-internals.c, dbus/dbus-message-builder.c,
3700 dbus/dbus-message.c, dbus/dbus-protocol.h
3701 (DBUS_HEADER_FIELD_SENDER_SERVICE): renamed DBUS_HEADER_FIELD_SENDER
3703 * dbus/dbus-internals.c (_dbus_header_field_to_string):
3704 DBUS_HEADER_FIELD_DESTINATION resolves to "destination"
3705 DBUS_HEADER_FIELD_SENDER resolves to "sender"
3707 * doc/dbus-specification.xml (Header Fields Table):
3708 s/SERVICE/DESTINATION
3709 s/SENDER_SERVICE/SENDER
3712 2004-04-14 Olivier Andrieu <oliv__a@users.sourceforge.net>
3714 * test/glib/test-dbus-glib.c (timed_exit): fail the test after
3717 2004-04-13 Michael Meeks <michael@ximian.com>
3719 * glib/dbus-gobject.c (handle_introspect): split out
3720 (introspect_properties): this.
3721 (handle_introspect): implement this.
3723 * test/glib/Makefile.am: use the absolute path so the bus
3724 daemon's chdir ("/") doesn't kill us dead.
3726 * configure.in: subst ABSOLUTE_TOP_BUILDDIR
3728 2004-04-12 Jon Trowbridge <trow@ximian.com>
3730 * bus/config-parser.c (struct BusConfigParser): Added
3731 included_files field.
3732 (seen_include): Added. Checks whether or not a file has already
3733 been included by any parent BusConfigParser.
3734 (bus_config_parser_new): Copy the parent's included_files.
3735 (include_file): Track which files have been included, and fail on
3736 circular inclusions.
3737 (process_test_valid_subdir): Changed printf to report if we are
3738 testing valid or invalid conf files.
3739 (all_are_equiv): Changed printf to be a bit clearer about
3740 what we are actually doing.
3741 (bus_config_parser_test): Test invalid configuration files.
3743 2004-04-09 Jon Trowbridge <trow@ximian.com>
3745 * bus/config-parser.c (bus_config_parser_new): Added a 'parent'
3746 argument. If non-null, the newly-constructed BusConfigParser will
3747 be initialized with the parent's BusLimits instead of the default
3749 (include_file): When including a config file, pass in
3750 the current parser as the parent and then copy the BusLimits
3751 from the included BusConfigParser pack to the current parser.
3752 (process_test_valid_subdir): Renamed from process_test_subdir.
3753 (process_test_equiv_subdir): Added. Walks through a directory,
3754 descending into each subdirectory and loading the config files
3755 it finds there. If any subdirectory contains two config files
3756 that don't produce identical BusConfigParser structs, fail.
3757 For now, the BusConfigParser's BusPolicies are not compared.
3758 (bus_config_parser_test): Call both process_test_valid_subdir and
3759 process_test_equiv_subdir.
3761 * bus/config-loader-libxml.c (bus_config_load): Take a parent
3762 argument and pass it along to the call to bus_config_parser_new.
3763 Also made a few small changes to allow this code to compile.
3765 * bus/config-loader-expat.c (bus_config_load): Take a parent
3766 argument and pass it along to the call to bus_config_parser_new.
3768 * bus/bus.c (bus_context_new): Load the config file
3769 with a NULL parent argument.
3771 2004-03-29 Michael Meeks <michael@ximian.com>
3773 * glib/dbus-gobject.c (introspect_properties): split
3774 out, fix mangled 'while' flow control.
3775 (introspect_signals): implement.
3776 (handle_introspect): update.
3778 2004-03-29 Michael Meeks <michael@ximian.com>
3780 * glib/dbus-gobject.c (set_object_property): split out /
3781 re-work, use the property type, and not the message type(!)
3782 (get_object_property): ditto.
3784 * glib/dbus-gvalue.c (dbus_gvalue_demarshal),
3785 (dbus_gvalue_marshal): make this code re-usable, needed
3786 for signals too, also on both proxy and server side.
3787 Re-write for more efficiency / readability.
3789 2004-03-29 Michael Meeks <michael@ximian.com>
3791 * dbus/dbus-message.c
3792 (dbus_message_new_error_printf): impl.
3794 * dbus/dbus-connection.c
3795 (dbus_connection_unregister_object_path): fix warning.
3797 * configure.in: fix no-mono-installed situation.
3799 2004-03-27 Havoc Pennington <hp@redhat.com>
3801 Patch from Timo Teräs:
3803 * tools/dbus-send.c (main): if --print-reply, assume type is
3804 method call; support boolean type args
3806 * dbus/dbus-connection.c (dbus_connection_send_with_reply): fix a
3807 bunch of memleak and logic bugs
3809 2004-03-23 Owen Fraser-Green <owen@discobabe.net>
3811 * mono/Arguments.cs:
3812 * mono/Introspector.cs:
3814 * mono/InterfaceProxy.cs:
3816 * mono/ProxyBuilder.cs:
3818 Added InterfaceProxy class to avoid building proxies for every
3822 * dbus-message.c (dbus_message_append_args_valist)
3823 (dbus_message_iter_get_object_path)
3824 (dbus_message_iter_get_object_path_array)
3825 (dbus_message_iter_append_object_path)
3826 (dbus_message_iter_append_object_path_array):
3827 Added object_path iter functions to handle OBJECT_PATH arguments
3829 2004-03-23 Owen Fraser-Green <owen@discobabe.net>
3831 First checkin of mono bindings.
3834 Build stuff for the bindings
3835 * dbus-sharp.pc.in: Added for pkgconfig
3837 2004-03-21 Havoc Pennington <hp@redhat.com>
3839 * test/test-service.c (main): remove debug spew
3841 2004-03-21 Olivier Andrieu <oliv__a@users.sourceforge.net>
3843 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): accept empty
3846 * dbus/dbus-message.h, bus/dbus-message.c (dbus_message_iter_init)
3847 (dbus_message_iter_init_array_iterator)
3848 (dbus_message_iter_init_dict_iterator): return a dbus_bool_t to
3849 indicate whether the iterator is empty
3851 * dbus/dbus-pending-call.c, dbus/dbus-server.c: silence compiler
3854 2004-03-19 Havoc Pennington <hp@redhat.com>
3856 * NEWS: 0.21 updates
3858 * configure.in: 0.21
3860 * doc/Makefile.am: add all XMLTO usage to DBUS_XML_DOCS_ENABLED
3862 * python/Makefile.am: change to avoid dist of dbus_bindings.c so
3863 you don't need pyrex to make dist
3865 * qt/Makefile.am (libdbus_qt_1_la_SOURCES): add integrator.h to
3868 2004-03-18 Richard Hult <richard@imendio.com>
3870 * dbus/dbus-message.c (dbus_message_get_auto_activation)
3871 (dbus_message_set_auto_activation): Add doxygen docs.
3873 2004-03-16 Richard Hult <richard@imendio.com>
3875 * bus/activation.c: (bus_activation_service_created),
3876 (bus_activation_send_pending_auto_activation_messages),
3877 (bus_activation_activate_service):
3879 * bus/dispatch.c: (bus_dispatch),
3880 (check_nonexistent_service_auto_activation),
3881 (check_service_auto_activated),
3882 (check_segfault_service_auto_activation),
3883 (check_existent_service_auto_activation), (bus_dispatch_test):
3884 * bus/driver.c: (bus_driver_handle_activate_service):
3885 * bus/services.c: (bus_registry_acquire_service):
3886 * dbus/dbus-message.c: (dbus_message_set_auto_activation),
3887 (dbus_message_get_auto_activation):
3888 * dbus/dbus-message.h:
3889 * dbus/dbus-protocol.h: Implement auto-activation.
3891 * doc/dbus-specification.xml: Add auto-activation to the spec.
3893 2004-03-12 Olivier Andrieu <oliv__a@users.sourceforge.net>
3895 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos):
3896 fix a bug with CUSTOM types.
3898 * dbus/dbus-message.c (message_iter_test, _dbus_message_test): add
3899 a unit test for this bug (used to fail).
3901 2004-03-12 Mikael Hallendal <micke@imendio.com>
3904 (babysitter_watch_callback): notify all pending activations waiting for
3905 the same exec that the activation failed.
3906 (bus_activation_activate_service): shortcut the activation if we
3907 already waiting for the same executable to start up.
3909 2004-03-12 Mikael Hallendal <micke@imendio.com>
3912 - Added service file reloading.
3913 Each service files directory is kept in an hash table in
3914 BusActivation and each BusActivationEntry knows what .service-file it
3915 was read from. So when you try to activate a service the bus will
3916 check if it's been updated, removed or if new .service-files has
3918 - Test code at the bottom for the service file reloading.
3919 * bus/test-main.c: (main):
3921 - added service reloading test.
3922 * dbus/dbus-sysdeps.c:
3923 * dbus/dbus-sysdeps.h: (_dbus_delete_directory): Added.
3925 2004-03-08 Michael Meeks <michael@ximian.com>
3927 * dbus/dbus-connection.c (_dbus_connection_block_for_reply):
3928 bail immediately if disconnected, to avoid busy loop.
3930 * dbus/dbus-message.c (dbus_message_iter_get_args_valist):
3931 cleanup cut/paste/inefficiency.
3933 2004-03-01 David Zeuthen <david@fubar.dk>
3935 * dbus/dbus-string.c (_dbus_string_append_printf_valist): Fix a
3936 bug where args were used twice. This bug resulted in a segfault
3937 on a Debian/PPC system when starting the messagebus daemon. Include
3938 dbus-sysdeps.h for DBUS_VA_COPY
3940 * dbus/dbus-sysdeps.h: Define DBUS_VA_COPY if neccessary. From GLib
3942 * configure.in: Check for va_copy; define DBUS_VA_COPY to the
3943 appropriate va_copy implementation. From GLib
3945 2004-02-24 Joe Shaw <joe@ximian.com>
3947 * bus/services.c (bus_registry_acquire_service): We need to pass
3948 in the service name to dbus_set_error() to prevent a crash.
3950 2003-12-26 Anders Carlsson <andersca@gnome.org>
3952 * AUTHORS: Reveal my True identity.
3954 2003-12-17 Mikael Hallendal <micke@imendio.com>
3956 * dbus/dbus-message.c: (dbus_message_append_args_valist):
3957 - Added case for DBUS_TYPE_BYTE, patch from Johan Hedberg.
3959 2003-12-13 Mikael Hallendal <micke@imendio.com>
3961 * doc/TODO: Added not about better error check of configuration files.
3963 2003-12-02 Richard Hult <richard@imendio.com>
3965 * Update AFL version to 2.0 throughout the source files to reflect
3966 the update that was done a while ago.
3968 2003-12-02 Richard Hult <richard@imendio.com>
3970 * dbus/dbus-message.c (dbus_message_iter_append_dict): Set
3971 wrote_dict_key to FALSE on the iter that the dict is appended to,
3972 just like when appending other types. Fixes a bug where a dict
3973 couldn't be put inside a dict.
3974 (dbus_message_iter_append_dict_key): Fix typo in warning message.
3975 (message_iter_test, _dbus_message_test): Add test case for dict
3978 2003-12-01 David Zeuthen <david@fubar.dk>
3980 * python/dbus.py: Add the actual message when calling the reciever
3981 of a signal such that parameters can be inspected. Add the method
3982 remove_signal_receiver
3984 2003-11-26 Mikael Hallendal <micke@imendio.com>
3988 * glib/*.[ch]: Made ref functions return the pointer
3990 2003-11-25 Zack Rusin <zack@kde.org>
3992 * qt/integrator.h, qt/integrator.cpp: Adding handling of DBusServer,
3994 * qt/server.h, qt/server.cpp, qt/Makefile.am: Adding DBusServer
3997 * qt/connection.h, qt/connection.cpp: Adjusting to changes in
3998 the Integrator and to better fit with the server,
4000 2003-11-24 Zack Rusin <zack@kde.org>
4002 * qt/connection.h, qt/connection.cpp: removing initDbus method since
4003 the integrator handles it now
4005 * qt/integrator.h, qt/integrator.cpp: reworking handling of timeouts,
4006 since QTimer wasn't really meant to be used the way DBusTimeout is
4008 2003-11-24 Zack Rusin <zack@kde.org>
4010 * qt/integrator.h, qt/integrator.cpp, Makefile.am: Adding
4011 Integrator class which integrates D-BUS with the Qt event loop,
4013 * qt/connection.h, qt/connection.cpp: Move all the code which
4014 was dealing with D-BUS integration to the Integrator class,
4015 and start using Integrator,
4017 2003-11-23 Zack Rusin <zack@kde.org>
4019 * qt/connection.h, qt/connection.cpp: Adding the DBusConnection
4022 * qt/message.h, qt/message.cpp: updating to the current D-BUS api,
4023 switching namespaces to DBusQt, reworking the class,
4025 * Makefile.cvs: switching dependencies so that it matches KDE
4028 * qt/Makefile.am: adding connection.{h,cpp} and message.{h,cpp} to
4031 2003-11-19 Havoc Pennington <hp@redhat.com>
4035 * configure.in: bump version to 0.20
4037 * configure.in (have_qt): add yet another place to look for qt
4038 (someone hand trolltech a .pc file...)
4040 2003-11-01 Havoc Pennington <hp@redhat.com>
4042 * doc/dbus-specification.xml: add state machine docs on the auth
4043 protocol; just a first draft, I'm sure it's wrong.
4045 2003-10-28 David Zeuthen <david@fubar.dk>
4047 * python/dbus_bindings.pyx.in: add get_dict to handle dictionaries
4048 return types. Fixup TYPE_* to reflect changes in dbus/dbus-protocol.h
4050 2003-10-28 Havoc Pennington <hp@redhat.com>
4052 * dbus/dbus-message.c (get_next_field): delete unused function
4054 2003-10-28 Havoc Pennington <hp@redhat.com>
4056 * bus/expirelist.c (do_expiration_with_current_time): detect
4057 failure of the expire_func due to OOM
4059 * bus/connection.c (bus_pending_reply_expired): return FALSE on OOM
4061 * bus/dispatch.c (check_send_exit_to_service): fix to handle the
4062 NoReply error that's now created by the bus when the service exits
4064 2003-10-28 Havoc Pennington <hp@redhat.com>
4066 * dbus/dbus-message.c (_dbus_message_test): enable and fix the
4067 tests for set_path, set_interface, set_member, etc.
4069 * dbus/dbus-string.c (_dbus_string_insert_bytes): allow 0 bytes
4071 * dbus/dbus-message.c (set_string_field): always just delete and
4072 re-append the field; accept NULL for deletion
4073 (re_align_fields_recurse): reimplement
4075 2003-10-26 Havoc Pennington <hp@redhat.com>
4077 * dbus/dbus-connection.c: fix docs to properly describe the
4078 disconnected message
4079 (_dbus_connection_notify_disconnected): remove this function;
4080 we can't synchronously add the disconnected message, we have to
4081 do it after we've queued any remaining real messages
4082 (_dbus_connection_get_dispatch_status_unlocked): queue the
4083 disconnect message only if the transport has finished queueing all
4084 its real messages and is disconnected.
4085 (dbus_connection_disconnect): update the dispatch status here
4087 2003-10-22 Havoc Pennington <hp@redhat.com>
4089 * bus/bus.c (bus_context_check_security_policy): fix up assertion
4091 * bus/connection.c (bus_transaction_send_from_driver): set the
4092 destination to the connection's base service
4094 2003-10-20 Havoc Pennington <hp@redhat.com>
4096 hmm, make check is currently not passing.
4098 * doc/dbus-specification.xml: add requirement that custom type
4099 names follow the same rules as interface names.
4101 * dbus/dbus-protocol.h: change some of the byte codes, to avoid
4102 duplication and allow 'c' to be 'custom'; dict is now 'm' for
4105 * doc/dbus-specification.xml: update type codes to match
4106 dbus-protocol.h, using the ASCII byte values. Rename type NAMED to
4107 CUSTOM. Add type OBJECT_PATH to the spec.
4109 2003-10-17 Havoc Pennington <hp@redhat.com>
4111 * bus/driver.c (create_unique_client_name): use "." as separator
4112 in base service names instead of '-'
4114 * dbus/dbus-string.c (_dbus_string_get_byte): allow getting nul
4115 byte at the end of the string
4117 * dbus/dbus-internals.h (_DBUS_LIKELY, _DBUS_UNLIKELY): add
4118 optimization macros since string validation seems to be a slow
4121 * doc/dbus-specification.xml: restrict valid
4122 service/interface/member/error names. Add test suite code for the
4125 * dbus/dbus-string.c: limit service/interface/member/error names
4128 * dbus/dbus-connection.c (dbus_connection_dispatch): add missing
4129 format arg to verbose spew
4131 * glib/dbus-gproxy.c (dbus_gproxy_call_no_reply): if not out of
4132 memory, return instead of g_error
4134 * test/test-service.c (path_message_func): support emitting a
4137 * dbus/dbus-bus.c (init_connections_unlocked): only fill in
4138 activation bus type if DBUS_BUS_ACTIVATION was set; default to
4139 assuming the activation bus was the session bus so that services
4140 started manually will still register.
4141 (init_connections_unlocked): fix so that in OOM situation we get
4142 the same semantics when retrying the function
4144 * test/test-service.c (main): change to use path registration, to
4145 test those codepaths; register with DBUS_BUS_ACTIVATION rather
4146 than DBUS_BUS_SESSION
4148 2003-10-16 Havoc Pennington <hp@redhat.com>
4150 * glib/dbus-gtest-main.c: bracket with #ifdef DBUS_BUILD_TESTS
4152 * Makefile.am (GCOV_DIRS): remove "test", we don't care about test
4153 coverage of the tests
4154 (coverage-report.txt): don't move the .da and .bbg files around
4156 2003-10-16 Havoc Pennington <hp@redhat.com>
4158 * bus/bus.c (struct BusContext): remove struct field I didn't mean
4161 2003-10-16 Havoc Pennington <hp@redhat.com>
4163 * bus/connection.c (bus_pending_reply_expired): either cancel or
4165 (bus_connections_check_reply): use unlink, not remove_link, as we
4166 don't want to free the link; fixes double free mess
4168 * dbus/dbus-pending-call.c (dbus_pending_call_block): fix in case
4169 where no reply was received
4171 * dbus/dbus-connection.c (_dbus_pending_call_complete_and_unlock):
4174 * bus/signals.c (match_rule_matches): add special cases for the
4175 bus driver, so you can match on sender/destination for it.
4177 * dbus/dbus-sysdeps.c (_dbus_abort): print backtrace if
4178 DBUS_PRINT_BACKTRACE is set
4180 * dbus/dbus-internals.c: add pid to assertion failure messages
4182 * dbus/dbus-connection.c: add message type code to the debug spew
4184 * glib/dbus-gproxy.c (gproxy_get_match_rule): match rules want
4185 sender=foo not service=foo
4187 * dbus/dbus-bus.c (dbus_bus_get): if the activation bus is the
4188 session bus but DBUS_SESSION_BUS_ADDRESS isn't set, use
4189 DBUS_ACTIVATION_ADDRESS instead
4191 * bus/activation.c: set DBUS_SESSION_BUS_ADDRESS,
4192 DBUS_SYSTEM_BUS_ADDRESS if appropriate
4194 * bus/bus.c (bus_context_new): handle OOM copying bus type into
4197 * dbus/dbus-message.c (dbus_message_iter_get_object_path): new function
4198 (dbus_message_iter_get_object_path_array): new function (half
4199 finished, disabled for the moment)
4201 * glib/dbus-gproxy.c (dbus_gproxy_end_call): properly handle
4202 DBUS_MESSAGE_TYPE_ERROR
4204 * tools/dbus-launch.c (babysit): support DBUS_DEBUG_OUTPUT to
4205 avoid redirecting stderr to /dev/null
4206 (babysit): close stdin if not doing the "exit_with_session" thing
4208 * dbus/dbus-sysdeps.c (_dbus_become_daemon): delete some leftover
4209 debug code; change DBUS_DEBUG_OUTPUT to only enable stderr, not
4210 stdout/stdin, so things don't get confused
4212 * bus/system.conf.in: fix to allow replies, I modified .conf
4213 instead of .conf.in again.
4215 2003-10-14 David Zeuthen <david@fubar.dk>
4217 * python/dbus_bindings.pyx.in (MessageIter.get): fixed typo in
4218 argtype to arg_type when raising unknown arg type exception.
4219 Changed type list to reflect the changes in dbus-protocol.h so
4220 the bindings actually work.
4222 2003-10-14 Havoc Pennington <hp@redhat.com>
4224 * test/decode-gcov.c: support gcc 3.3 also, though gcc 3.3 seems
4225 to have a bug keeping it from outputting the .da files sometimes
4226 (string_get_string): don't append garbage nul bytes to the string.
4228 2003-10-15 Seth Nickell <seth@gnome.org>
4230 * python/Makefile.am:
4232 Include dbus_h_wrapper.h in the dist tarball.
4234 2003-10-14 Havoc Pennington <hp@redhat.com>
4236 * bus/bus.c (bus_context_check_security_policy): revamp this to
4237 work more sanely with new policy-based requested reply setup
4239 * bus/connection.c (bus_transaction_send_from_driver): set bus
4240 driver messages as no reply
4242 * bus/policy.c (bus_client_policy_check_can_receive): handle a
4243 requested_reply attribute on allow/deny rules
4245 * bus/system.conf: add <allow requested_reply="true"/>
4247 * bus/driver.c (bus_driver_handle_message): fix check for replies
4248 sent to the bus driver, which was backward. How did this ever work
4249 at all though? I think I'm missing something.
4251 * dbus/dbus-message.c (decode_header_data): require error and
4252 method return messages to have a reply serial field to be valid
4253 (_dbus_message_loader_queue_messages): break up this function;
4254 validate that reply serial and plain serial are nonzero;
4255 clean up the OOM/error handling.
4256 (get_uint_field): don't return -1 from this
4257 (dbus_message_create_header): fix signed/unsigned bug
4259 * bus/connection.c (bus_connections_expect_reply): save serial of
4260 the incoming message, not reply serial
4262 2003-10-14 Havoc Pennington <hp@redhat.com>
4264 * bus/connection.c: implement pending reply tracking using
4267 * bus/bus.c (bus_context_check_security_policy): verify that a
4268 reply is pending in order to allow a reply to be sent. Deny
4269 messages of unknown type.
4271 * bus/dbus-daemon-1.1.in: update to mention new resource limits
4273 * bus/bus.c (bus_context_get_max_replies_per_connection): new
4274 (bus_context_get_reply_timeout): new
4276 2003-10-13 Seth Nickell <seth@gnome.org>
4278 * python/Makefile.am:
4280 Pass "make distcheck": remove a couple files from DIST_FILES
4281 that weren't included in the final version.
4283 2003-10-12 Havoc Pennington <hp@pobox.com>
4285 Added test code that 1) starts an actual bus daemon and 2) uses
4286 DBusGProxy; fixed bugs that were revealed by the test. Lots
4287 more testing possible, but this is the basic framework.
4289 * glib/dbus-gproxy.c (dbus_gproxy_manager_unregister): remove
4290 empty proxy lists from the proxy list hash
4292 * dbus/dbus-message.c (dbus_message_iter_get_args_valist): add a
4293 couple of return_if_fail checks
4295 * dbus/dbus-pending-call.c (_dbus_pending_call_new): use dbus_new0
4296 to allocate, so everything is cleared to NULL as it should be.
4298 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): pass
4299 source as data to dbus_connection_set_timeout_functions() as the
4300 timeout functions expected
4302 * test/glib/run-test.sh: add a little script to start up a message
4303 bus and run tests using it
4305 * tools/dbus-launch.1: updates
4307 * tools/dbus-launch.c (main): add --config-file option
4309 * tools/dbus-launch.c (main): remove confusing else if (runprog)
4310 that could never be reached.
4312 * dbus/dbus-message.c (dbus_message_new_method_return)
4313 (dbus_message_new_error, dbus_message_new_signal): set the
4314 no-reply-expected flag on all these. Redundant, but may
4315 as well be consistent.
4317 2003-10-11 Havoc Pennington <hp@pobox.com>
4319 * test/decode-gcov.c (function_solve_graph): make broken block
4320 graph a nonfatal error since it seems to be broken. Need to debug
4323 * dbus/dbus-marshal.c (_dbus_type_is_valid): new function since we
4324 can't just check type > INVALID < LAST anymore
4326 * dbus/dbus-message.c (dbus_message_get_signature): new function
4327 (dbus_message_has_signature): new function
4328 (struct DBusMessage): add signature field (right now it isn't sent
4329 over the wire, just generated on the fly)
4330 (dbus_message_copy): copy the signature, and init strings to
4331 proper length to avoid some reallocs
4332 (dbus_message_iter_init_array_iterator): return void, since it
4334 (dbus_message_iter_init_dict_iterator): return void since it can't fail
4335 (_dbus_message_loader_queue_messages): add silly temporary hack to
4336 fill in message->signature on load
4338 * dbus/dbus-protocol.h: change DBUS_TYPE_* values to be ASCII
4339 characters, so they are relatively human-readable.
4341 2003-10-11 Havoc Pennington <hp@pobox.com>
4343 * dbus/dbus-message.c (_dbus_message_test): add more test
4344 coverage, but #if 0 for now since they uncover a bug
4345 not fixed yet; I think in re_align_field_recurse()
4346 (re_align_field_recurse): add FIXME about broken assertion
4348 * dbus/dbus-sysdeps.c (_dbus_sysdeps_test): add more test coverage
4350 * bus/connection.c: share a couple code bits with expirelist.c
4352 * bus/expirelist.h, bus/expirelist.c: implement a generic
4353 expire-items-after-N-seconds facility, was going to share between
4354 expiring connections and replies, decided not to use for expiring
4355 connections for now.
4357 * COPYING: include AFL 2.0 (still need to change all the file headers)
4359 2003-10-09 Havoc Pennington <hp@redhat.com>
4361 * configure.in: define DBUS_HAVE_GCC33_GCOV if we have
4362 gcc 3.3. Not that we do anything about it yet.
4364 * bus/signals.c (bus_match_rule_parse): impose max length on the
4367 * dbus/dbus-protocol.h: add DBUS_MAXIMUM_MATCH_RULE_LENGTH
4369 2003-10-09 Havoc Pennington <hp@redhat.com>
4371 Make matching rules theoretically work (add parser).
4373 * bus/bus.c (bus_context_check_security_policy): fix up to handle
4374 the case where destination is explicitly specified as bus driver
4375 and someone else is eavesdropping.
4377 * bus/policy.c (bus_client_policy_check_can_receive): fix up
4378 definition of eavesdropping and assertion
4380 * tools/dbus-send.c (main): use dbus_message_type_from_string
4382 * bus/signals.c (bus_match_rule_parse): implement
4384 * dbus/dbus-message.c (dbus_message_type_from_string): new
4386 * dbus/dbus-errors.h (DBUS_ERROR_MATCH_RULE_INVALID): add
4388 2003-10-02 Havoc Pennington <hp@pobox.com>
4390 * glib/dbus-gproxy.c (dbus_gproxy_call_no_reply): rename from
4391 dbus_gproxy_oneway_call
4393 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main)
4394 (dbus_server_setup_with_g_main): fix to allow calling them more
4395 than once on the same args
4396 (dbus_bus_get_with_g_main): new function
4398 2003-10-02 Havoc Pennington <hp@redhat.com>
4400 * doc/dbus-tutorial.xml: write some stuff
4402 2003-09-29 Havoc Pennington <hp@pobox.com>
4404 * configure.in: split checks for Doxygen from XML docs, check for
4407 * doc/Makefile.am: XML-ify all the docs, and add a blank
4410 2003-09-29 Havoc Pennington <hp@pobox.com>
4412 * Merge dbus-object-names branch. To see the entire patch
4413 do cvs diff -r DBUS_OBJECT_NAMES_BRANCHPOINT -r dbus-object-names,
4414 it's huuuuge though.
4415 To revert, I tagged DBUS_BEFORE_OBJECT_NAMES_MERGE.
4417 2003-09-28 Havoc Pennington <hp@pobox.com>
4419 * HACKING: update to reflect new server
4421 2003-09-26 Seth Nickell <seth@gnome.org>
4424 * python/examples/example-signals.py:
4426 Start implementing some notions of signals. The API
4427 is really terrible, but they sort of work (with the
4428 exception of being able to filter by service, and to
4429 transmit signals *as* a particular service). Need to
4430 figure out how to make messages come from the service
4433 * python/dbus_bindings.pyx.in:
4435 Removed duplicate message_handler callbacks.
4437 2003-09-25 Havoc Pennington <hp@redhat.com>
4439 * bus/session.conf.in: fix my mess
4441 2003-09-25 Havoc Pennington <hp@pobox.com>
4443 * bus/session.conf.in: fix security policy, reported by Seth Nickell
4445 2003-09-25 Seth Nickell <seth@gnome.org>
4447 * python/examples/example-service.py:
4449 Johan notices complete wrong code in example-service, but
4450 completely wrong in a way that works exactly the same (!).
4451 Johan is confused, how could this possibly work? Example
4452 code fails to serve purpose of making things clear.
4455 2003-09-25 Mark McLoughlin <mark@skynet.ie>
4457 * doc/dbus-specification.sgml: don't require header fields
4458 to be 4-byte aligned and specify that fields should be
4459 distinguished from padding by the fact that zero is not
4462 * doc/TODO: remove re-alignment item and add item to doc
4463 the OBJECT_PATH type.
4465 * dbus/dbus-message.c:
4466 (HeaderField): rename the original member to value_offset
4467 and introduce a name_offset member to keep track of where
4468 the field actually begins.
4469 (adjust_field_offsets): remove.
4470 (append_int_field), (append_uint_field),
4471 (append_string_field): don't align the start of the header
4472 field to a 4-byte boundary.
4473 (get_next_field): impl finding the next marhsalled field
4474 after a given field.
4475 (re_align_field_recurse): impl re-aligning a number of
4476 already marshalled fields.
4477 (delete_field): impl deleting a field of any type and
4478 re-aligning any following fields.
4479 (delete_int_or_uint_field), (delete_string_field): remove.
4480 (set_int_field), (set_uint_field): no need to re-check
4481 that we have the correct type for the field.
4482 (set_string_field): ditto and impl re-aligning any
4484 (decode_header_data): update to take into account that
4485 the fields aren't 4-byte aligned any more and the new
4486 way to distinguish padding from header fields. Also,
4487 don't exit when there is too much header padding.
4488 (process_test_subdir): print the directory.
4489 (_dbus_message_test): add test to make sure a following
4490 field is re-aligned correctly after field deletion.
4492 * dbus/dbus-string.[ch]:
4493 (_dbus_string_insert_bytes): rename from insert_byte and
4494 allow the insert of multiple bytes.
4495 (_dbus_string_test): test inserting multiple bytes.
4497 * dbus/dbus-marshal.c: (_dbus_marshal_set_string): add
4498 warning note to docs about having to re-align any
4499 marshalled values following the string.
4501 * dbus/dbus-message-builder.c:
4502 (append_string_field), (_dbus_message_data_load):
4503 don't align the header field.
4505 * dbus/dbus-auth.c: (process_test_subdir): print the
4508 * test/break-loader.c: (randomly_add_one_byte): upd. for
4511 * test/data/invalid-messages/bad-header-field-alignment.message:
4514 * test/data/valid-messages/unknown-header-field.message: shove
4515 a dict in the unknown field.
4517 2003-09-25 Seth Nickell <seth@gnome.org>
4520 * python/dbus_bindings.pyx.in:
4522 Handle return values.
4524 * python/examples/example-client.py:
4525 * python/examples/example-service.py:
4527 Pass back return values from the service to the client.
4529 2003-09-24 Seth Nickell <seth@gnome.org>
4533 Connect Object methods (when you are sharing an object) up... pass
4534 in a list of methods to be shared. Sharing all the methods just
4535 worked out too weird. You can now create nice Services over the
4538 * python/dbus_bindings.pyx.in:
4540 Keep references to user_data tuples passed into C functions so
4541 Python doesn't garbage collect on us.
4543 Implement MethodReturn and Error subclasses of Message for creating
4544 DBusMessage's of those types.
4546 * python/examples/example-client.py:
4547 * python/examples/example-service.py:
4549 Simple example code showing both how create DBus services and objects,
4550 and how to use them.
4552 2003-09-23 Havoc Pennington <hp@pobox.com>
4554 * glib/dbus-gproxy.c (dbus_gproxy_manager_filter): implement
4556 2003-09-23 Havoc Pennington <hp@redhat.com>
4558 * glib/dbus-gproxy.c (dbus_gproxy_connect_signal): implement
4559 (dbus_gproxy_disconnect_signal): implement
4560 (dbus_gproxy_manager_remove_signal_match): implement
4561 (dbus_gproxy_manager_add_signal_match): implement
4562 (dbus_gproxy_oneway_call): implement
4564 2003-09-23 Havoc Pennington <hp@pobox.com>
4566 * glib/dbus-gproxy.c (struct DBusGProxy): convert to a GObject
4567 subclass. This means dropping the transparent thread safety of the
4568 proxy; you now need a separate proxy per-thread, or your own
4569 locking on the proxy. Probably right anyway.
4570 (dbus_gproxy_ref, dbus_gproxy_unref): nuke, just use g_object_ref
4572 2003-09-22 Havoc Pennington <hp@redhat.com>
4574 * glib/dbus-gproxy.c (dbus_gproxy_manager_get): implement
4576 2003-09-21 Seth Nickell <seth@gnome.org>
4578 First checkin of the Python bindings.
4580 * python/.cvsignore:
4581 * python/Makefile.am:
4582 * python/dbus_bindings.pyx.in:
4583 * python/dbus_h_wrapper.h:
4585 Pieces for Pyrex to operate on, building a dbus_bindings.so
4586 python module for low-level access to the DBus APIs.
4590 High-level Python module for accessing DBus objects.
4595 Build stuff for the python bindings.
4599 Extra macro needed for finding the Python C header files.
4601 2003-09-21 Havoc Pennington <hp@pobox.com>
4603 * glib/dbus-gproxy.c (dbus_gproxy_manager_new): start
4604 implementing the proxy manager, didn't get very far.
4606 * dbus/dbus-bus.c (dbus_bus_add_match): new
4607 (dbus_bus_remove_match): new
4609 * glib/dbus-gproxy.c (dbus_gproxy_new_for_service): add a
4610 path_name argument; adjust the other not-yet-implemented
4611 gproxy constructors to be what I think they should be.
4613 2003-09-21 Havoc Pennington <hp@pobox.com>
4615 * dbus/dbus-bus.c (dbus_bus_get): set exit_on_disconnect to TRUE
4616 by default for message bus connections.
4618 * dbus/dbus-connection.c (dbus_connection_dispatch): exit if
4619 exit_on_disconnect flag is set and we process the disconnected
4621 (dbus_connection_set_exit_on_disconnect): new function
4623 2003-09-21 Havoc Pennington <hp@pobox.com>
4625 Get matching rules mostly working in the bus; only actually
4626 parsing the rule text remains. However, the client side of
4627 "signal connections" hasn't been started, this patch is only the
4630 * dbus/dispatch.c: fix for the matching rules changes
4632 * bus/driver.c (bus_driver_handle_remove_match)
4633 (bus_driver_handle_add_match): send an ack reply from these
4636 * glib/dbus-gproxy.c (dbus_gproxy_begin_call): fix order of
4637 arguments, reported by Seth Nickell
4639 * bus/config-parser.c (append_rule_from_element): support
4640 eavesdrop=true|false attribute on policies so match rules
4641 can be prevented from snooping on the system bus.
4643 * bus/dbus-daemon-1.1.in: consistently use terminology "sender"
4644 and "destination" in attribute names; fix some docs bugs;
4645 add eavesdrop=true|false attribute
4647 * bus/driver.c (bus_driver_handle_add_match)
4648 (bus_driver_handle_remove_match): handle AddMatch, RemoveMatch
4651 * dbus/dbus-protocol.h (DBUS_SERVICE_ORG_FREEDESKTOP_BROADCAST): get
4652 rid of broadcast service concept, signals are just always broadcast
4654 * bus/signals.c, bus/dispatch.c, bus/connection.c, bus/bus.c:
4655 mostly implement matching rules stuff (currently only exposed as signal
4658 2003-09-21 Mark McLoughlin <mark@skynet.ie>
4660 * doc/dbus-specification.sgml: Change the header field name
4661 to be an enum and update the rest of the spec to reference
4662 the fields using the conventinal name.
4664 * dbus/dbus-protocol.h: update to reflect the spec.
4666 * doc/TODO: add item to remove the 4 byte alignment requirement.
4668 * dbus/dbus-message.c: Remove the code to generalise the
4669 header/body length and serial number header fields as named
4670 header fields so we can reference field names using the
4672 (append_int_field), (append_uint_field), (append_string_field):
4673 Append the field name as a byte rather than four chars.
4674 (delete_int_or_uint_field), (delete_string_field): reflect the
4675 fact that the field name and typecode now occupy 4 bytes instead
4677 (decode_string_field), (decode_header_data): update to reflect
4678 protocol changes and move the field specific encoding from
4679 decode_string_field() back into decode_header_data().
4681 * dbus/dbus-internals.[ch]: (_dbus_header_field_to_string):
4682 Add utility to aid debugging.
4684 * dbus/dbus-message-builder.c:
4685 (append_string_field), (_dbus_message_data_load): Update to
4686 reflect protocol changes; Change the FIELD_NAME directive
4687 to HEADER_FIELD and allow it to take the field's conventional
4688 name rather than the actual value.
4690 * test/data/*/*.message: Update to use HEADER_FIELD instead
4691 of FIELD_NAME; Always align the header on an 8 byte boundary
4692 *before* updating the header length.
4694 2003-09-15 Havoc Pennington <hp@pobox.com>
4696 * dbus/dbus-pending-call.c: add the get/set object data
4697 boilerplate as for DBusConnection, etc. Use generic object data
4698 for the notify callback.
4700 * glib/dbus-gparser.c (parse_node): parse child nodes
4702 * tools/dbus-viewer.c: more hacking on the dbus-viewer
4704 * glib/dbus-gutils.c (_dbus_gutils_split_path): add a file to
4705 contain functions shared between the convenience lib and the
4708 * glib/Makefile.am (libdbus_glib_1_la_LDFLAGS): add
4709 -export-symbols-regex to the GLib library
4711 * dbus/dbus-object-tree.c (_dbus_object_tree_dispatch_and_unlock):
4712 fix the locking in here, and add a default handler for
4713 Introspect() that just returns sub-nodes.
4715 2003-09-14 Havoc Pennington <hp@pobox.com>
4717 * glib/dbus-gthread.c (dbus_g_thread_init): rename to make g_foo
4718 rather than gfoo consistent
4720 * glib/dbus-gproxy.h: delete for now, move contents to
4721 dbus-glib.h, because the include files don't work right since we
4722 aren't in the dbus/ subdir.
4724 * glib/dbus-gproxy.c (dbus_gproxy_send): finish implementing
4725 (dbus_gproxy_end_call): finish
4726 (dbus_gproxy_begin_call): finish
4728 * glib/dbus-gmain.c (dbus_set_g_error): new
4730 * glib/dbus-gobject.c (handle_introspect): include information
4731 about child nodes in the introspection
4733 * dbus/dbus-connection.c (dbus_connection_list_registered): new
4734 function to help in implementation of introspection
4736 * dbus/dbus-object-tree.c
4737 (_dbus_object_tree_list_registered_and_unlock): new function
4739 2003-09-12 Havoc Pennington <hp@pobox.com>
4741 * glib/dbus-gidl.h: add common base class for all the foo_info
4744 * tools/dbus-viewer.c: add GTK-based introspection UI thingy
4747 * test/Makefile.am: try test srcdir -ef . in addition to test
4748 srcdir = ., one of them should work (yeah lame)
4750 * glib/Makefile.am: build the "idl" parser stuff as a convenience
4753 * glib/dbus-gparser.h: make description_load routines return
4754 NodeInfo* not Parser*
4756 * Makefile.am (SUBDIRS): build test dir after all library dirs
4758 * configure.in: add GTK+ detection
4760 2003-09-07 Havoc Pennington <hp@pobox.com>
4762 * Make Doxygen contented.
4764 2003-09-07 Havoc Pennington <hp@pobox.com>
4766 * doc/dbus-specification.sgml: more updates
4768 2003-09-06 Havoc Pennington <hp@pobox.com>
4770 * doc/dbus-specification.sgml: partial updates
4772 * bus/dbus-daemon-1.1.in: fix the config file docs for the
4773 zillionth time; hopefully I edited the right file this time.
4775 * bus/config-parser.c (append_rule_from_element): support
4776 send_type, send_path, receive_type, receive_path
4778 * bus/policy.c: add message type and path to the list of things
4779 that can be "firewalled"
4781 2003-09-06 Havoc Pennington <hp@pobox.com>
4783 * dbus/dbus-connection.c (dbus_connection_register_fallback): add this
4784 (dbus_connection_register_object_path): make this not handle
4785 messages to paths below the given path
4787 2003-09-03 Havoc Pennington <hp@pobox.com>
4789 * test/glib/Makefile.am: add this with random glib-linked test
4792 * glib/Makefile.am: remove the random test programs from here,
4793 leave only the unit tests
4795 * glib/dbus-gobject.c (_dbus_gobject_test): add test for
4796 uscore/javacaps conversion, and fix
4797 (get_object_property, set_object_property): change to .NET
4798 convention for mapping props to methods, set_FooBar/get_FooBar,
4799 since one language has such a convention we may as well copy it.
4800 Plus real methods in either getFooBar or get_foo_bar style won't
4801 collide with this convention.
4803 2003-09-01 Havoc Pennington <hp@pobox.com>
4805 * glib/dbus-gparser.c: implement
4807 * glib/dbus-gobject.c: start implementing skeletons support
4809 * configure.in: when disabling checks/assert, also define
4810 G_DISABLE_ASSERT and G_DISABLE_CHECKS
4812 2003-09-01 Havoc Pennington <hp@pobox.com>
4814 * glib/Makefile.am: rearrange a bunch of files and get "make
4815 check" framework set up
4817 2003-08-31 Havoc Pennington <hp@pobox.com>
4819 * fix build with --disable-tests
4821 2003-08-30 Havoc Pennington <hp@pobox.com>
4823 * dbus/dbus-connection.c: purge DBusMessageHandler
4825 * dbus/dbus-message-handler.c: remove DBusMessageHandler, just
4826 use callbacks everywhere
4828 2003-08-30 Havoc Pennington <hp@pobox.com>
4830 * test/data/valid-config-files/system.d/test.conf: change to
4831 root for the user so warnings don't get printed
4833 * dbus/dbus-message.c: add dbus_message_get_path,
4834 dbus_message_set_path
4836 * dbus/dbus-object-tree.c (do_test_dispatch): add test of
4837 dispatching to a path
4839 * dbus/dbus-string.c (_dbus_string_validate_path): add
4841 * dbus/dbus-marshal.c (_dbus_demarshal_object_path): implement
4842 (_dbus_marshal_object_path): implement
4844 * dbus/dbus-protocol.h (DBUS_HEADER_FIELD_PATH): new header field
4845 to contain the path to the target object
4846 (DBUS_HEADER_FIELD_SENDER_SERVICE): rename
4847 DBUS_HEADER_FIELD_SENDER to explicitly say it's the sender service
4849 2003-08-30 Havoc Pennington <hp@pobox.com>
4851 * dbus/dbus-object-tree.c: write tests and fix the discovered bugs
4853 2003-08-29 Havoc Pennington <hp@pobox.com>
4855 * dbus/dbus-object-tree.c: modify to allow overlapping paths to be
4857 (struct DBusObjectSubtree): shrink this
4858 a lot, since we may have a lot of them
4859 (_dbus_object_tree_free_all_unlocked): implement
4860 (_dbus_object_tree_dispatch_and_unlock): implement
4862 2003-08-29 Havoc Pennington <hp@pobox.com>
4864 * dbus/dbus-internals.h: fix _DBUS_N_GLOBAL_LOCKS
4866 2003-08-28 Havoc Pennington <hp@pobox.com>
4870 * dbus/dbus-connection.c: port to no ObjectID, create a
4871 DBusObjectTree, rename ObjectTree to ObjectPath in public API
4873 * dbus/dbus-connection.h (struct DBusObjectTreeVTable): delete
4874 everything except UnregisterFunction and MessageFunction
4876 * dbus/dbus-marshal.c: port away from DBusObjectID,
4877 add DBUS_TYPE_OBJECT_PATH
4879 * dbus/dbus-object-registry.[hc], dbus/dbus-object.[hc],
4880 dbus/dbus-objectid.[hc]: remove these, we are moving to
4881 path-based object IDs
4883 2003-08-25 Havoc Pennington <hp@pobox.com>
4885 Just noticed that dbus_message_test is hosed, I wonder when I
4886 broke that. I thought make check was passing earlier...
4888 * dbus/dbus-object-tree.c: add new "object tree" to match DCOP
4889 container tree, will replace most of dbus-object-registry
4891 * dbus/dbus-string.c (_dbus_string_append_printf_valist): fix C99
4894 2003-08-19 Havoc Pennington <hp@pobox.com>
4896 * dbus/dbus-message.c (decode_string_field): support FIELD_SENDER
4897 (dbus_message_is_error): fix this function
4899 * bus/dbus-daemon-1.1: clarify logic on when <deny>/<allow> rules
4902 * bus/policy.c (bus_client_policy_check_can_receive): fix code to
4903 reflect clarified man page
4904 (bus_client_policy_check_can_send): ditto
4906 * bus/session.conf.in: fixup
4908 * bus/system.conf.in: fixup
4910 2003-08-18 Havoc Pennington <hp@redhat.com>
4912 * dbus/dbus-hash.c (_dbus_hash_table_insert_two_strings): fix
4914 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
4915 dumb bug created earlier (wrong order of args to
4916 decode_header_data())
4918 * tools/dbus-send.c: port
4920 * tools/dbus-print-message.c (print_message): port
4922 * test/data/*messages: port all messages over
4924 * dbus/dbus-message-builder.c: support including
4927 * bus/driver.c: port over
4929 * bus/dispatch.c: port over to new stuff
4931 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
4932 rename disconnect signal to "Disconnected"
4934 2003-08-17 Havoc Pennington <hp@pobox.com>
4936 This doesn't compile yet, but syncing up so I can hack on it from
4937 work. What are branches for if not broken code? ;-)
4939 * dbus/dbus-protocol.h: remove DBUS_HEADER_FIELD_NAME, add
4940 DBUS_HEADER_FIELD_INTERFACE, DBUS_HEADER_FIELD_MEMBER,
4941 DBUS_HEADER_FIELD_ERROR_NAME
4943 * dbus/dbus-hash.c: Introduce DBUS_HASH_TWO_STRINGS as hack to use
4944 for the interface+member pairs
4945 (string_hash): change to use g_str_hash algorithm
4946 (find_direct_function, find_string_function): refactor these to
4949 * dbus/dbus-message.c: port all of this over to support
4950 interface/member fields instead of name field
4952 * dbus/dbus-object-registry.c: port over
4954 * dbus/dbus-string.c (_dbus_string_validate_interface): rename
4955 from _dbus_string_validate_name
4957 * bus/dbus-daemon-1.1: change file format for the
4958 <deny>/<allow> stuff to match new message naming scheme
4960 * bus/policy.c: port over
4962 * bus/config-parser.c: parse new format
4964 2003-08-16 Havoc Pennington <hp@pobox.com>
4966 * dbus/dbus-object-registry.c (add_and_remove_objects): remove
4969 * glib/dbus-gproxy.c: some hacking
4971 2003-08-15 Havoc Pennington <hp@redhat.com>
4973 * dbus/dbus-pending-call.c (dbus_pending_call_block): implement
4975 * dbus/dbus-connection.c
4976 (dbus_connection_send_with_reply_and_block): factor out internals;
4977 change to convert any error replies to DBusError instead of
4978 returning them as a message
4980 2003-08-15 Havoc Pennington <hp@pobox.com>
4982 * dbus/dbus-connection.c,
4983 dbus/dbus-pending-call.c: Finish the pending call stuff
4985 2003-08-14 Havoc Pennington <hp@redhat.com>
4987 * dbus/dbus-pending-call.c: start on new object that will replace
4988 DBusMessageHandler and ReplyHandlerData for tracking outstanding
4991 * dbus/dbus-gproxy.c: start on proxy object used to communicate
4992 with remote interfaces
4994 * dbus/dbus-gidl.c: do the boring boilerplate in here
4996 2003-08-12 Havoc Pennington <hp@pobox.com>
4998 * bus/dispatch.c (bus_dispatch): make this return proper
4999 DBusHandlerResult to avoid DBUS_ERROR_UNKNOWN_METHOD
5001 * dbus/dbus-errors.c (dbus_set_error): use
5002 _dbus_string_append_printf_valist
5004 * dbus/dbus-string.c (_dbus_string_append_printf_valist)
5005 (_dbus_string_append_printf): new
5007 * dbus/dbus-errors.h (DBUS_ERROR_UNKNOWN_MESSAGE): change to
5010 * dbus/dbus-connection.c (dbus_connection_dispatch): handle
5011 DBUS_HANDLER_RESULT_NEED_MEMORY; send default error reply if a
5012 message is unhandled.
5014 2003-08-11 Havoc Pennington <hp@pobox.com>
5016 * bus/test.c (client_disconnect_handler): change to return
5017 HANDLED (would have been REMOVE_MESSAGE)
5019 * dbus/dbus-object.h (enum DBusHandlerResult): rename to
5020 HANDLED/NOT_YET_HANDLED instead of
5021 REMOVE_MESSAGE/ALLOW_MORE_HANDLERS to make it clearer how it
5024 2003-08-10 Havoc Pennington <hp@pobox.com>
5026 * tools/dbus-send.c (main): add --type argument, for now
5027 supporting only method_call and signal types.
5029 * tools/dbus-print-message.c: print message type
5031 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
5032 init connection->objects
5034 * doc/dbus-specification.sgml: fix sgml
5036 * bus/*.c: port over to object-instance API changes
5038 * test/test-service.c: ditto
5040 * dbus/dbus-message.c (dbus_message_create_header): allow #NULL
5041 name, we will have to fix up the rest of the code to also handle
5043 (dbus_message_new): generic message-creation call
5044 (set_string_field): allow appending name field
5046 2003-08-06 Havoc Pennington <hp@pobox.com>
5048 * dbus/dbus-object-registry.c: implement signal connection
5051 * dbus/dbus-connection.c (_dbus_connection_unref_unlocked): new
5053 * dbus/dbus-internals.c (_dbus_memdup): new function
5055 2003-08-02 Havoc Pennington <hp@pobox.com>
5057 * dbus/dbus-message.c (dbus_message_get_no_reply)
5058 (dbus_message_set_no_reply): add these and remove
5059 set_is_error/get_is_error
5061 * dbus/dbus-protocol.h, doc/dbus-specification.sgml:
5062 remove the ERROR flag, since there's now an ERROR type
5064 2003-08-01 Havoc Pennington <hp@pobox.com>
5066 * dbus/dbus-object-registry.c (_dbus_object_registry_handle_and_unlock):
5069 * dbus/dbus-message.c (dbus_message_get_type): new function
5071 * doc/dbus-specification.sgml: add "type" byte to messages
5073 2003-08-01 Havoc Pennington <hp@pobox.com>
5075 * dbus/dbus-protocol.h (DBUS_MESSAGE_TYPE_*): introduce
5076 a message type enum to distinguish kinds of message
5077 (DBUS_HEADER_FLAG_NO_REPLY_EXPECTED): flag for a message
5078 that need not be replied to
5080 2003-08-01 Havoc Pennington <hp@pobox.com>
5082 * dbus/dbus-marshal.c: adapt to DBusObjectID changes
5083 (unpack_8_octets): fix no-64-bit-int bug
5085 * dbus/dbus-object-registry.c (validate_id): validate the
5086 connection ID bits, not just the instance ID.
5088 * dbus/dbus-connection.c (_dbus_connection_init_id): initialize
5089 the connection-global 33 bits of the object ID
5091 * dbus/dbus-object-registry.c (info_from_entry): fill in
5092 object ID in the new way
5094 * dbus/dbus-objectid.h: rather than high/low bits, specifically
5095 define server/client/instance bits.
5097 2003-07-30 Havoc Pennington <hp@pobox.com>
5099 * dbus/dbus-connection.c (dbus_connection_register_object): fix
5102 2003-07-13 Havoc Pennington <hp@pobox.com>
5104 * dbus/dbus-object.h (struct DBusObjectVTable): add padding
5105 fields to DBusObjectVTable and DBusObjectInfo
5107 2003-07-12 Havoc Pennington <hp@pobox.com>
5109 * dbus/dbus-object-registry.c: implement unit test,
5110 fix bugs discovered in process
5112 * dbus/dbus-connection.c: remove handler_table and
5113 register_handler(), add DBusObjectRegistry usage
5115 * dbus/dbus-objectid.c (dbus_object_id_is_null)
5116 (dbus_object_id_set_null): new functions
5118 2003-07-08 Havoc Pennington <hp@pobox.com>
5120 * dbus/dbus-object.c: implement some of this
5122 * dbus/dbus-object-registry.c
5123 (_dbus_object_registry_add_and_unlock): fill in the object_id out
5125 (_dbus_object_registry_new): handle OOM
5127 2003-07-08 Havoc Pennington <hp@pobox.com>
5129 * dbus/dbus-object.h: sketch out an API for registering objects
5130 with a connection, that allows us to use as little as 24 bytes
5131 per object and lets application code represent an object in
5132 any conceivable way.
5134 * dbus/dbus-object-registry.c: implement the hard bits of the
5135 DBusConnection aspect of object API. Not yet wired up.
5137 2003-07-06 Havoc Pennington <hp@pobox.com>
5139 * dbus/dbus-marshal.c (_dbus_marshal_set_object_id): new function
5140 (_dbus_marshal_object_id): new
5141 (_dbus_demarshal_object_id): new
5142 (_dbus_marshal_get_arg_end_pos): support object ID type, and
5143 consolidate identical switch cases. Don't conditionalize handling
5144 of DBUS_TYPE_UINT64, need to handle the type always.
5145 (_dbus_marshal_validate_arg): consolidate identical cases, and
5146 handle DBUS_TYPE_OBJECT_ID
5148 * dbus/dbus-objectid.c: new file with DBusObjectID data type.
5150 * dbus/dbus-protocol.h: add DBUS_TYPE_OBJECT_ID
5152 2003-09-28 Havoc Pennington <hp@pobox.com>
5156 2003-09-28 Havoc Pennington <hp@pobox.com>
5158 * doc/Makefile.am (dbus-specification.html): testing a funky hack
5159 to work with Debian db2html
5161 2003-09-28 Havoc Pennington <hp@pobox.com>
5163 * configure.in: 0.13
5165 * doc/Makefile.am (dbus-test-plan.html): accept nonexistence of
5166 stylesheet-images for benefit of Debian
5168 Change back to using filesystem-linked sockets for the system
5169 bus, so only root can create the default system bus address.
5171 * bus/system.conf.in: change to use
5172 DBUS_SYSTEM_BUS_DEFAULT_ADDRESS
5174 * dbus/Makefile.am (INCLUDES): remove DBUS_SYSTEM_BUS_PATH define
5177 * configure.in: define DBUS_SYSTEM_BUS_DEFAULT_ADDRESS
5178 here, and AC_DEFINE DBUS_SYSTEM_PATH
5180 2003-08-09 Anders Carlsson <andersca@codefactory.se>
5183 * doc/busconfig.dtd:
5186 2003-08-09 Anders Carlsson <andersca@codefactory.se>
5188 * doc/dbus-specification.sgml:
5189 Add activation reply values.
5191 2003-08-05 Havoc Pennington <hp@redhat.com>
5193 * configure.in: 0.12
5195 2003-08-05 Anders Carlsson <andersca@codefactory.se>
5197 * glib/dbus-gmain.c: (watch_fd_new), (watch_fd_ref),
5198 (watch_fd_unref), (dbus_gsource_check), (dbus_gsource_dispatch),
5199 (add_watch), (remove_watch), (create_source):
5200 Refcount fds, fixes some reentrancy issues.
5202 2003-07-30 Havoc Pennington <hp@redhat.com>
5204 * dbus/dbus-bus.c (init_connections_unlocked): fix default system
5205 bus address to be abstract if we have abstract sockets
5209 2003-07-28 Havoc Pennington <hp@redhat.com>
5211 * bus/messagebus.in: fix to avoid processname/servicename
5212 confusion, from Michael Kearey
5213 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=100965
5215 2003-07-23 Havoc Pennington <hp@pobox.com>
5217 * dbus/dbus-message.c (dbus_message_iter_get_named):
5218 fix from Andy Hanton to remove broken "+1"
5220 2003-07-16 Havoc Pennington <hp@pobox.com>
5222 * tools/dbus-launch.c (babysit): close stdout/stderr in the
5223 babysitter process, as suggested by Thomas Leonard, so
5224 an "eval `dbus-launch --exit-with-session`" will actually
5227 2003-07-16 Havoc Pennington <hp@pobox.com>
5229 * configure.in: print out EXPANDED_* variables in the summary at
5230 the end; clean up the code that computes EXPANDED_ variables and
5231 get the ones using exec_prefix right. Should make things work
5232 when you build without --prefix
5234 2003-06-29 Havoc Pennington <hp@pobox.com>
5236 * mono/Test.cs (class Test): fire up a main loop and run it
5238 * mono/DBus.cs (DBus): don't g_thread_init since it can only be
5239 done once, the app has to do it
5241 2003-06-26 Havoc Pennington <hp@pobox.com>
5243 * mono/Connection.cs: set up connection with the glib main loop
5245 2003-07-01 Havoc Pennington <hp@redhat.com>
5247 * doc/dbus-specification.sgml: clarify the format of a type code,
5248 change suggested by Jim Blandy
5250 2003-06-29 Miloslav Trmac <mitr@volny.cz>
5253 * tools/Makefile.am: Don't assume srcdir == builddir.
5255 * dbus/dbus-memory.c (dbus_realloc): Don't check guards after shrinking
5256 the allocated block.
5257 (_dbus_memory_test): New function.
5258 * dbus/dbus-test.h: Add _dbus_memory_test ().
5259 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): Call it.
5261 * dbus/dbus-message.c (decode_header_data): Use %.4s instead
5263 (dbus_message_new): Remove obsolete @todo.
5265 * dbus/dbus-marshal.c (_dbus_marshal_set_int64)
5266 (_dbus_marshal_set_uint64): Fix comment.
5268 * dbus/dbus-message.c (append_int_field, append_uint_field): Don't
5269 hardcode FIELD_REPLY_SERIAL.
5271 * dbus/dbus-mainloop.c (_dbus_loop_remove_watch)
5272 (_dbus_loop_remove_timeout): Cast function pointers to (void *) for %p
5274 * configure.in: Add -D_POSIX_C_SOURCE=199309L -DBSD_SOURCE to CFLAGS
5275 and disable DBUS_USE_ATOMIC_INT_486 when --enable-ansi is used
5277 2003-06-24 Havoc Pennington <hp@pobox.com>
5279 * mono/*.cs: Use IntPtr.Zero instead of ((IntPtr) 0)
5281 2003-06-23 Anders Carlsson <andersca@codefactory.se>
5287 * gcj/TestMessage.java: (TestMessage), (TestMessage.main):
5288 * gcj/org/.cvsignore:
5289 * gcj/org/Makefile.am:
5290 * gcj/org/freedesktop/.cvsignore:
5291 * gcj/org/freedesktop/Makefile.am:
5292 * gcj/org/freedesktop/dbus/.cvsignore:
5293 * gcj/org/freedesktop/dbus/Makefile.am:
5294 * gcj/org/freedesktop/dbus/Message.java: (Message),
5296 * gcj/org/freedesktop/dbus/natMessage.cc:
5297 Fix the build system.
5299 2003-06-22 Havoc Pennington <hp@pobox.com>
5301 * mono/Connection.cs: add more bindings
5303 * dbus/dbus-threads.c (dbus_threads_init): allow calling this
5306 2003-06-22 Havoc Pennington <hp@pobox.com>
5308 * mono/Connection.cs, mono/DBus.cs, mono/Error.cs:
5309 Start wrapping more stuff.
5311 2003-06-22 Havoc Pennington <hp@pobox.com>
5313 * mono/Message.cs: implement Message.Wrap() that ensures we only
5314 have a single C# wrapper per DBusMessage, assuming it works which
5315 it probably doesn't.
5317 * dbus/dbus-message.c (dbus_message_allocate_data_slot): new
5318 (dbus_message_free_data_slot): new
5319 (dbus_message_set_data): new
5320 (dbus_message_get_data): new
5322 2003-06-22 Havoc Pennington <hp@pobox.com>
5324 * dbus/dbus-dataslot.c (_dbus_data_slot_allocator_unref)
5325 (_dbus_data_slot_allocator_alloc): rework these to keep a
5326 reference count on each slot and automatically manage a global
5327 slot ID variable passed in by address
5329 * bus/bus.c: convert to new dataslot API
5331 * dbus/dbus-bus.c: convert to new dataslot API
5333 * dbus/dbus-connection.c: convert to new dataslot API
5335 * dbus/dbus-server.c: convert to new dataslot API
5337 * glib/dbus-gmain.c: ditto
5341 * bus/connection.c: ditto
5343 2003-06-22 Anders Carlsson <andersca@codefactory.se>
5345 * configure.in: Add AM_PROG_GCJ and move AM_PROG_LIBTOOL
5346 after the gcj checks so that the correct configuration tags
5347 will be added to libtool.
5349 * dbus-glib-1.pc.in: No need to specify any includes since
5350 dbus-1.pc.in has those.
5352 2003-06-22 Havoc Pennington <hp@pobox.com>
5354 * mono/*, gcj/*, configure.in, Makefile.am:
5355 Check in makefiles and subdirs for mono and gcj bindings.
5356 Neither binding actually exists, just trying to get through
5357 all the build and other boring bits.
5359 2003-06-21 Philip Blundell <philb@gnu.org>
5361 * tools/dbus-monitor.1: Updated.
5363 * tools/dbus-send.1: Likewise.
5365 2003-06-20 Anders Carlsson <andersca@codefactory.se>
5367 * dbus/dbus-transport-unix.c (unix_handle_watch): Check
5368 for hangup and error after checking read so we won't discard
5369 pending data if both hangup and read are set.
5371 2003-06-19 Philip Blundell <philb@gnu.org>
5373 * tools/dbus-print-message.c (print_message): Handle BOOLEAN.
5375 * tools/dbus-send.c: Accept both --system and --session.
5377 * tools/dbus-monitor.c: Same here.
5379 2003-06-19 Anders Carlsson <andersca@codefactory.se>
5381 * glib/dbus-glib.h: Fix so that dbus-glib.h can be used
5382 from C++ (Patch by Miloslav Trmac).
5384 2003-06-15 Joe Shaw <joe@assbarn.com>
5386 * configure.in: Check for socklen_t.
5388 * dbus/dbus-sysdeps.c: Define socklen_t if it's not defined.
5390 * test/test-segfault.c: Add #include <sys/time.h>
5392 * tools/Makefile.am: Add DBUS_X_CFLAGS to the INCLUDES since
5393 dbus-launch needs it.
5395 2003-06-09 Havoc Pennington <hp@redhat.com>
5397 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): don't use
5398 SUN_LEN, it breaks abstract socket usage
5400 * dbus/dbus-internals.c (_dbus_verbose_real): only print PID at
5403 2003-06-04 Havoc Pennington <hp@pobox.com>
5405 * dbus/dbus-server.c (dbus_server_listen): allow abstract sockets
5406 using unix:abstract=/foo, and when listening in a tmpdir
5407 i.e. unix:tmpdir=/tmp, always use abstract sockets if we can.
5409 * dbus/dbus-transport.c (_dbus_transport_open): support
5412 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
5413 support abstract sockets
5415 * dbus/dbus-transport-unix.c
5416 (_dbus_transport_new_for_domain_socket): support abstract sockets
5418 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket): add "abstract"
5419 toggle as an argument, implement abstract namespace support
5420 (_dbus_listen_unix_socket): ditto
5422 * configure.in: add --enable-abstract-sockets and implement
5423 a configure check for autodetection of the right value.
5425 2003-06-01 Havoc Pennington <hp@pobox.com>
5427 * tools/dbus-cleanup-sockets.c: add utility to clean up sockets
5428 in /tmp (though on Linux this will end up being useless,
5429 when we add abstract namespace support)
5431 * configure.in: define DBUS_SESSION_SOCKET_DIR in addition to
5434 2003-05-28 Colin Walters <walters@verbum.org>
5436 * tools/dbus-monitor.c (main): Fix silly typo (s/--session/--system/).
5438 2003-05-18 Anders Carlsson <andersca@codefactory.se>
5440 * dbus/dbus-message.c (dbus_message_new): Remove @todo.
5442 2003-05-17 Colin Walters <walters@gnu.org>
5444 * tools/dbus-send.c: Don't exit with an error code if --help was
5445 passed. Default to using the session bus instead of the system
5448 * tools/dbus-launch.c: Ditto.
5450 * tools/dbus-monitor.c: Ditto.
5452 * tools/dbus-send.1: Update with new arguments.
5454 * tools/dbus-launch.c: Emit code to export variables. New
5455 arguments -s and -c to specify shell syntax, and a bit of code to
5456 autodetect syntax. Also, allow specifying a program to run.
5458 * tools/dbus-launch.1: Update with new arguments.
5460 * tools/dbus-send.1: Ditto.
5462 * tools/dbus-monitor.1: Ditto.
5464 2003-05-17 Havoc Pennington <hp@pobox.com>
5466 * bus/config-parser.c (merge_included): merge in policies from
5467 child configuration file.
5469 * bus/policy.c (bus_policy_merge): function to merge two policies
5472 2003-05-16 Havoc Pennington <hp@redhat.com>
5474 * dbus/dbus-connection.c: disable verbose lock spew
5476 * tools/dbus-send.c: add --print-reply command line option
5478 * tools/dbus-print-message.h (print_message): new util function
5479 shared by dbus-send and dbus-monitor
5481 * tools/dbus-monitor.c (handler_func): exit on disconnect
5483 * dbus/dbus-transport-unix.c (do_reading): if the transport is
5484 disconnected, don't try to use the read_watch
5486 * dbus/dbus-watch.c (dbus_watch_get_enabled): assert watch != NULL
5487 so we can find this bug more easily
5489 2003-05-16 Havoc Pennington <hp@redhat.com>
5491 * bus/policy.c (free_rule_list_func): avoid a crash when passed
5492 NULL as DBusHashTable is annoyingly likely to do.
5494 2003-05-16 Colin Walters <walters@verbum.org>
5496 * tools/dbus-monitor.c: Add --session argument and usage()
5499 * tools/dbus-monitor.1: Update with new --session arg.
5501 * bus/Makefile.am (install-data-hook): Create
5502 $(libdir)/dbus-1.0/services so that the session bus is happy.
5504 2003-05-15 Havoc Pennington <hp@redhat.com>
5506 * dbus/dbus-sysdeps.c (_dbus_atomic_dec, _dbus_atomic_inc): work
5507 on non-x86. ifdef's are evil.
5509 2003-05-15 Havoc Pennington <hp@redhat.com>
5511 * configure.in: 0.11
5515 * bus/Makefile.am (initddir): apparently we are supposed to put
5516 init scripts in /etc/rc.d/init.d not /etc/init.d
5518 * bus/Makefile.am: remove the "you must --enable-tests to make
5519 check" as it broke distcheck
5521 * bus/Makefile.am (install-data-hook): create /etc/dbus-1/system.d
5523 2003-05-13 James Willcox <jwillcox@gnome.org>
5526 * bus/activation.c: (bus_activation_service_created),
5527 (bus_activation_activate_service):
5528 * bus/driver.c: (bus_driver_send_service_deleted),
5529 (bus_driver_send_service_created), (bus_driver_send_service_lost),
5530 (bus_driver_send_service_acquired),
5531 (bus_driver_send_welcome_message),
5532 (bus_driver_handle_list_services):
5533 * bus/session.conf.in:
5534 * dbus/dbus-bus.c: (dbus_bus_acquire_service),
5535 (dbus_bus_service_exists), (dbus_bus_activate_service):
5538 Add some convenience API which lets you activate a service, and did a
5539 bunch of s/0/DBUS_TYPE_INVALID/ in calls to dbus_message_append_args()
5540 and dbus_message_get_args()
5542 2003-05-11 Havoc Pennington <hp@pobox.com>
5544 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix to avoid
5545 calling _dbus_marshal_validate_arg() for every byte in a byte
5548 * dbus/dbus-message-handler.c: use atomic reference counting to
5549 reduce number of locks slightly; the global lock in here sucks
5551 * dbus/dbus-connection.c
5552 (_dbus_connection_update_dispatch_status_and_unlock): variant of
5553 update_dispatch_status that can be called with lock held; then use
5554 in a couple places to reduce locking/unlocking
5555 (dbus_connection_send): hold the lock over the whole function
5556 instead of acquiring it twice.
5558 * dbus/dbus-timeout.c (_dbus_timeout_new): handle OOM
5560 * bus/connection.c (bus_connections_setup_connection): fix access
5561 to already-freed memory.
5563 * dbus/dbus-connection.c: keep a little cache of linked list
5564 nodes, to avoid using the global linked list alloc lock in the
5565 normal send-message case. Instead we just use the connection lock
5566 that we already have to take.
5568 * dbus/dbus-list.c (_dbus_list_find_last): new function
5570 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec):
5571 change to use a struct for the atomic type; fix docs,
5572 they return value before increment, not after increment.
5574 * dbus/dbus-string.c (_dbus_string_append_4_aligned)
5575 (_dbus_string_append_8_aligned): new functions to try to
5576 microoptimize this operation.
5577 (reallocate_for_length): break this out of set_length(), to
5578 improve profile info, and also so we can consider inlining the
5581 * dbus/dbus-message.c (dbus_message_new_empty_header): init data
5582 strings with some preallocation, cuts down on our calls to realloc
5583 a fair bit. Though if we can get the "move entire string to empty
5584 string" optimization below to kick in here, it would be better.
5586 * dbus/dbus-string.c (_dbus_string_move): just call
5587 _dbus_string_move_len
5588 (_dbus_string_move_len): add a special case for moving
5589 an entire string into an empty string; we can just
5590 swap the string data instead of doing any reallocs.
5591 (_dbus_string_init_preallocated): new function
5593 2003-05-11 Havoc Pennington <hp@pobox.com>
5595 Write a "test-profile" that does echo client-server with threads;
5596 profile reveals lock contention, memcpy/realloc of buffers, and
5597 UTF-8 validation as hot spots. 20% of lock contention eliminated
5598 with dbus_atomic_inc/dec implementation on x86. Much remaining
5599 contention is global mempool locks for GList and DBusList.
5601 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec): add
5604 * dbus/dbus-connection.c (struct DBusConnection): use
5605 dbus_atomic_t for the reference count
5607 * dbus/dbus-message.c (struct DBusMessage): declare
5608 dbus_atomic_t values as volatile
5610 * configure.in: code to detect ability to use atomic integer
5611 operations in assembly, from GLib patch
5613 * dbus/dbus-internals.c (_dbus_verbose_real): call getpid every
5614 time, tired of it being wrong in threads and forked processes
5616 * glib/test-profile.c: a little program to bounce messages back
5617 and forth between threads and eat CPU
5619 * dbus/dbus-connection.c: add debug spew macros for debugging
5620 thread locks; include config.h at top; fix deadlock in
5621 dbus_connection_flush()
5623 2003-05-08 Havoc Pennington <hp@pobox.com>
5625 * dbus/dbus-spawn.c: s/_exit/exit/ because it was keeping gcov
5626 data from getting written, and there wasn't a good reason to
5629 * test/decode-gcov.c (mark_inside_dbus_build_tests): don't count
5630 dbus_verbose lines in test coverage
5631 (main): add list of functions sorted by # of untested blocks
5632 to the coverage report
5634 * dbus/dbus-mempool.c: put some test-only code in DBUS_BUILD_TESTS
5636 * dbus/dbus-marshal.c (_dbus_marshal_test): extend test coverage
5638 * dbus/dbus-message-handler.c (_dbus_message_handler_test):
5639 extend test coverage
5641 * test/data/auth/cancel.auth-script: test canceling an
5644 * dbus/Makefile.am: remove dbus-server-debug.[hc] for now, as they
5645 aren't used. in CVS history if we end up needing them.
5647 2003-05-04 Havoc Pennington <hp@pobox.com>
5649 * dbus/dbus-message-handler.c (_dbus_message_handler_test): add
5652 * dbus/dbus-marshal.c (_dbus_demarshal_string_array): fix this
5653 function, which assumed length was in # of strings, not bytes
5655 * dbus/dbus-message.c (_dbus_message_test): add tests for some
5658 * dbus/dbus-connection.c
5659 (_dbus_connection_queue_received_message): disable function for
5660 now, we are only using it in test mode
5662 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
5663 remove a mistaken FIXME
5665 2003-05-04 Havoc Pennington <hp@pobox.com>
5667 * dbus/dbus-connection.c (dbus_connection_preallocate_send):
5668 unlock mutex on successful return, patch from Anders Gustafsson
5670 2003-05-04 Havoc Pennington <hp@pobox.com>
5672 * dbus-glib-1.pc.in (Requires): fix dependencies, from
5675 2003-05-04 Havoc Pennington <hp@pobox.com>
5677 * tools/dbus-launch.c: implement
5679 * bus/main.c (main), bus/bus.c (bus_context_new):
5680 implement --print-pid and --fork
5682 2003-05-03 Havoc Pennington <hp@redhat.com>
5684 * dbus/dbus-address.c (dbus_parse_address): fix bug when a key in
5685 the address had no value, and add to test suite. Fix and
5686 regression test from Miloslav Trmac
5688 2003-05-03 Havoc Pennington <hp@pobox.com>
5690 * dbus/dbus-watch.c (dbus_watch_handle): warn and return if a
5691 watch is invalid when handled
5693 * tools/Makefile.am, tools/dbus-launch.c, tools/dbus-launch.1: add
5694 dbus-launch utility to launch the bus from a shell script. Didn't
5695 actually implement dbus-launch yet, it's just a placeholder still.
5697 2003-05-03 Havoc Pennington <hp@pobox.com>
5699 * bus/Makefile.am, bus/dbus-daemon-1.1.in: man page for the
5700 daemon; also documents daemon config file, so replaces
5701 doc/config-file.txt. Corrected some stuff from config-file.txt in
5702 the process of moving it.
5704 2003-05-03 Havoc Pennington <hp@pobox.com>
5706 * tools/Makefile.am, tools/dbus-send.1, tools/dbus-monitor.1:
5709 2003-05-03 Colin Walters <walters@verbum.org>
5711 * dbus/dbus-sysdeps.c (fill_user_info): Test against
5712 DBUS_UID_UNSET to determine whether to do a uid lookup or not.
5714 * Makefile.am: Update to use new .pc versioning scheme.
5716 2003-05-02 Havoc Pennington <hp@redhat.com>
5718 * bus/system.conf.in: allow send/receive to/from message bus
5721 2003-04-30 Havoc Pennington <hp@redhat.com>
5723 * configure.in: print a note when building with unit tests and
5726 2003-04-30 Havoc Pennington <hp@redhat.com>
5728 * Makefile.am: add a check-local that complains if you didn't
5729 configure with --enable-tests
5731 2003-04-29 Havoc Pennington <hp@redhat.com>
5733 * glib/dbus-gmain.c: docs cleanups
5735 * dbus/dbus-types.h: add docs on int64 types
5737 * dbus/dbus-memory.c: fix docs to avoid putting private API in
5738 public API docs section
5740 2003-04-29 Havoc Pennington <hp@redhat.com>
5742 * dbus-1.pc.in, dbus-glib-1.pc.in: rename these from
5743 dbus-1.0.pc.in, dbus-glib-1.0.pc.in. As these change with the
5744 parallel install API version, not with the D-BUS package version.
5746 * HACKING: move some of README over here
5748 * README: updates, and document API/ABI policy
5750 * configure.in: reindentation
5752 2003-04-29 Havoc Pennington <hp@redhat.com>
5754 * dbus/dbus.h: add "you have to define DBUS_API_SUBJECT_TO_CHANGE
5755 to use this library" to be sure people have the right
5758 2003-04-28 Havoc Pennington <hp@redhat.com>
5760 * configure.in: add --enable-docs which by default is auto yes if
5761 doxygen and db2html found, no otherwise; but can be forced on/off
5763 * doc/Makefile.am: conditionalize whether to build docs on
5766 2003-04-28 Havoc Pennington <hp@redhat.com>
5768 * configure.in: 0.10
5772 * bus/system.conf.in: add <includedir>system.d</includedir>
5774 * dbus/dbus-userdb.c (_dbus_user_database_lookup): fix bug when
5775 username was provided but not uid
5777 * bus/config-parser.c (struct BusConfigParser): keep track of
5778 whether the parser is toplevel or was included; change some
5779 of the error handling if it's included.
5781 2003-04-27 Havoc Pennington <hp@pobox.com>
5785 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
5786 report correct status if we finish processing authentication
5787 inside this function.
5789 * bus/activation.c (try_send_activation_failure): use
5790 bus_transaction_send_error_reply
5792 * bus/connection.c (bus_connection_get_groups): return an error
5793 explaining the problem
5795 * bus/bus.c (bus_context_check_security_policy): implement
5796 restriction here that inactive connections can only send the
5797 hello message. Also, allow bus driver to send anything to
5800 * bus/connection.c (bus_connection_complete): create the
5801 BusClientPolicy here instead of on-demand.
5802 (bus_connection_get_policy): don't return an error
5804 * dbus/dbus-message.c (dbus_message_new_error_reply): allow NULL
5805 sender field in message being replied to
5807 * bus/bus.c (bus_context_check_security_policy): fix silly typo
5808 causing it to return FALSE always
5810 * bus/policy.c (bus_client_policy_check_can_send): fix bug where
5811 we checked sender rather than destination
5813 2003-04-25 Havoc Pennington <hp@redhat.com>
5815 test suite is slightly hosed at the moment, will fix soon
5817 * bus/connection.c (bus_connections_expire_incomplete): fix to
5818 properly disable the timeout when required
5819 (bus_connection_set_name): check whether we can remove incomplete
5820 connections timeout after we complete each connection.
5822 * dbus/dbus-mainloop.c (check_timeout): fix this up a bit,
5823 probably still broken.
5825 * bus/services.c (bus_registry_acquire_service): implement max
5826 number of services owned, and honor allow/deny rules on which
5827 services a connection can own.
5829 * bus/connection.c (bus_connection_get_policy): report errors here
5831 * bus/activation.c: implement limit on number of pending
5834 2003-04-25 Havoc Pennington <hp@redhat.com>
5836 * dbus/dbus-transport.c (_dbus_transport_get_unix_user): fix bug
5837 where we used >= 0 instead of != DBUS_UID_UNSET.
5839 2003-04-25 Havoc Pennington <hp@redhat.com>
5841 * glib/dbus-gmain.c (remove_watch): fix for a crash when watches
5842 were toggled without add/remove, fix from Anders Gustafsson
5844 2003-04-24 Havoc Pennington <hp@redhat.com>
5846 * test/data/valid-config-files/basic.conf: add <limit> tags to
5849 * bus/config-parser.h, bus/config-parser.c, bus/bus.c: Implement
5850 <limit> tag in configuration file.
5852 2003-04-24 Havoc Pennington <hp@redhat.com>
5854 * bus/dispatch.c: somehow missed some name_is
5856 * dbus/dbus-timeout.c (_dbus_timeout_set_enabled)
5857 (_dbus_timeout_set_interval): new
5859 * bus/connection.c (bus_connections_setup_connection): record time
5860 when each connection is first set up, and expire them after the
5861 auth timeout passes.
5863 2003-04-24 Havoc Pennington <hp@redhat.com>
5865 * dbus/dbus-message.c (dbus_message_name_is): rename
5866 (dbus_message_service_is): rename
5867 (dbus_message_sender_is): rename
5868 (dbus_message_get_service): rename
5870 2003-04-24 Havoc Pennington <hp@redhat.com>
5872 * configure.in: add --enable-checks
5874 * dbus/dbus-message.c (dbus_message_new): reverse name/service arguments
5876 * dbus/dbus-connection.c (dbus_connection_preallocate_send): fix
5877 to use thread locks.
5878 (_dbus_connection_handler_destroyed_locked): move some private
5879 functions into proper docs group
5881 * dbus/dbus-internals.h: add _dbus_return_if_fail,
5882 _dbus_return_val_if_fail
5884 Throughout: use dbus_return_if_fail
5886 2003-04-23 James Willcox <jwillcox@gnome.org>
5889 * glib/dbus-gmain.c: (add_timeout), (wakeup_main), (create_source),
5890 (dbus_connection_setup_with_g_main),
5891 (dbus_server_setup_with_g_main):
5892 * glib/test-dbus-glib.c: (main):
5893 * glib/test-thread-client.c: (main):
5894 * glib/test-thread-server.c: (new_connection_callback), (main):
5895 * tools/dbus-monitor.c: (main):
5897 Added a GMainContext argument to dbus_connection_setup_with_g_main()
5898 and dbus_server_setup_with_g_main().
5900 2003-04-20 Havoc Pennington <hp@pobox.com>
5902 * doc/dbus-specification.sgml: document the restrictions on
5903 message and service names
5905 2003-04-22 Havoc Pennington <hp@redhat.com>
5907 * dbus/dbus-message.c, dbus/dbus-marshal.c: add 64-bit integer
5908 support, and do some code cleanups to share more code and
5909 speed up array marshal/demarshal.
5911 * dbus-1.0.pc.in (Cflags): put libdir include file in cflags
5913 * configure.in: generate dbus-arch-deps.h
5915 * dbus/dbus-protocol.h (DBUS_TYPE_INT64, DBUS_TYPE_UINT64): add
5918 2003-04-22 Havoc Pennington <hp@redhat.com>
5920 * test/data/valid-messages/opposite-endian.message: fix test
5921 to use proper type for rply field
5923 * test/data/invalid-messages: add tests for below validation
5925 * dbus/dbus-message.c (decode_header_data): validate field types,
5926 and validate that named fields are valid names
5927 (decode_name_field): consider messages in the
5928 org.freedesktop.Local. namespace to be invalid.
5930 * dbus/dbus-string.c (_dbus_string_validate_name): new
5932 2003-04-19 Havoc Pennington <hp@pobox.com>
5934 * bus/driver.c (bus_driver_handle_hello): check limits and
5935 return an error if they are exceeded.
5937 * bus/connection.c: maintain separate lists of active and inactive
5938 connections, and a count of each. Maintain count of completed
5939 connections per user. Implement code to check connection limits.
5941 * dbus/dbus-list.c (_dbus_list_unlink): export
5943 * bus/bus.c (bus_context_check_security_policy): enforce a maximum
5944 number of bytes in the message queue for a connection
5946 2003-04-18 Havoc Pennington <hp@pobox.com>
5948 * dbus/dbus-auth.c (record_mechanisms): memleak fixes
5950 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): fix some
5953 * dbus/dbus-keyring.c (add_new_key): fix a memleak, and
5954 on realloc be sure to update the pointer in the keyring
5956 * dbus/dbus-string.c (_dbus_string_zero): compensate for align
5957 offset to avoid writing to unallocated memory
5959 * dbus/dbus-auth.c (process_rejected): return FALSE if we fail to
5960 try the next mechanism, so we properly handle OOM
5962 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): fix double-free
5964 (_dbus_keyring_new): fix OOM bug
5965 (_dbus_keyring_new_homedir): always set error; impose a maximum
5966 number of keys we'll load from the file, mostly to speed up the
5967 test suite and make its OOM checks more useful, but also for
5970 * dbus/dbus-auth.c (process_error_server): reject authentication
5971 if we get an error from the client
5972 (process_cancel): on cancel, send REJECTED, per the spec
5973 (process_error_client): send CANCEL if we get an error from the
5976 2003-04-18 Havoc Pennington <hp@pobox.com>
5978 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix UMR in verbose
5981 * dbus/dbus-auth.c (handle_client_data_cookie_sha1_mech): fix OOM
5984 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): only whine
5985 about DBUS_TEST_HOMEDIR once
5987 * bus/Makefile.am (TESTS_ENVIRONMENT): put DBUS_TEST_HOMEDIR in
5990 * bus/dispatch.c (bus_dispatch_sha1_test): actually load sha1
5991 config file so we test the right thing
5993 Throughout: assorted docs improvements
5995 2003-04-18 Havoc Pennington <hp@pobox.com>
5997 * glib/dbus-gmain.c: adapt to watch changes
5999 * bus/bus.c, bus/activation.c, etc.: adjust to watch changes
6001 * dbus/dbus-server.h: remove dbus_server_handle_watch
6003 * dbus/dbus-connection.h: remove dbus_connection_handle_watch
6005 * dbus/dbus-watch.c (dbus_watch_handle): change DBusWatch to work
6006 like DBusTimeout, so we don't need dbus_connection_handle_watch
6009 2003-04-17 Havoc Pennington <hp@redhat.com>
6011 * dbus/dbus-userdb.c, dbus/dbus-sysdeps.c: redo all the passwd
6012 database usage so it all goes via the DBusUserDatabase cache.
6014 2003-04-17 Havoc Pennington <hp@redhat.com>
6016 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix logic so that if
6017 there was an OOM watch we skipped, we always return TRUE so we
6018 iterate again to have a look at it again. Fixes test suite hang.
6019 Code rearrangement also lets us lose some memset and only iterate
6020 over callbacks once.
6022 * bus/driver.c (bus_driver_handle_message): sense of test for
6025 2003-04-16 Havoc Pennington <hp@pobox.com>
6027 * doc/dbus-specification.sgml: make spec say serials are unsigned
6029 * dbus/dbus-message.h: change message serials to unsigned
6031 * dbus/dbus-connection.c: adapt to message serials being unsigned
6033 2003-04-15 Havoc Pennington <hp@pobox.com>
6035 * bus/bus.c: create and keep around a shared DBusUserDatabase
6038 * bus/connection.c (bus_connection_get_groups): don't cache
6039 groups for user in the connection object, since user database
6040 object now does that.
6042 2003-04-16 Havoc Pennington <hp@redhat.com>
6044 * dbus/dbus-message.c (_dbus_message_add_size_counter): keep a
6045 list of size counters
6046 (_dbus_message_loader_putback_message_link): put back a popped link
6048 * dbus/dbus-connection.c
6049 (dbus_connection_set_max_live_messages_size): rename
6051 (dbus_connection_get_outgoing_size): get size of outgoing
6053 (_dbus_connection_set_connection_counter): remove this cruft
6055 2003-04-14 Havoc Pennington <hp@redhat.com>
6057 * dbus/dbus-userdb.c: user database abstraction, mostly to get
6058 caching, but at some point we might want to be able to use a
6061 * bus/dispatch.c (bus_dispatch_sha1_test): add a test that uses
6062 SHA1 conf file to test the sha1 auth mechanism, since the regular
6063 test always uses EXTERNAL when available.
6066 test/data/valid-config-files/debug-allow-all-sha1.conf.in:
6067 add conf file that requires use of sha1 auth
6069 2003-04-13 Havoc Pennington <hp@pobox.com>
6071 * tools/dbus-send.c, tools/dbus-monitor.c: two utility programs
6072 from Philip Blundell to send messages and monitor them.
6074 2003-04-13 Havoc Pennington <hp@pobox.com>
6076 * dbus/dbus-mainloop.c: fix some reentrancy issues by refcounting
6079 * test/data/valid-config-files/debug-allow-all.conf.in: allow all
6082 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
6083 fix to only recover unused bytes if we're already authenticated
6084 (_dbus_transport_get_is_authenticated): fix to still mark us
6085 authenticated if there are unused bytes.
6087 * bus/dispatch.c: implement security policy checking
6089 * bus/connection.c (bus_transaction_send_from_driver): new
6091 * bus/bus.c (bus_context_check_security_policy): new
6093 * bus/dispatch.c (send_service_nonexistent_error): delete this,
6094 now we just set the DBusError and it gets converted to an error
6097 * bus/connection.c (allow_user_function): enable code using actual
6098 data from the config file
6100 * bus/policy.c (list_allows_user): handle wildcard rules for
6101 user/group connection perms
6103 2003-04-13 Havoc Pennington <hp@pobox.com>
6105 * bus/config-parser.c: Load up the BusPolicy and BusPolicyRules
6107 * dbus/dbus-sysdeps.c (_dbus_get_user_id): new function
6109 * bus/policy.c (bus_policy_append_mandatory_rule)
6110 (bus_policy_append_default_rule, bus_policy_append_user_rule)
6111 (bus_policy_append_group_rule): new functions
6113 2003-04-12 Havoc Pennington <hp@pobox.com>
6115 * bus/config-parser.c (bus_config_parser_new): fix a memleak
6117 * dbus/dbus-sysdeps.c: change DBusCredentials to use longs for
6118 the pid/gid/uid, just for paranoia.
6120 * test/break-loader.c (randomly_do_n_things): find a byte
6121 containing a type code, and randomly change it to a different
6124 2003-04-12 Havoc Pennington <hp@pobox.com>
6126 * bus/policy.h: change BusPolicy to be the thing from the config
6127 file, and rename old BusPolicy to BusClientPolicy
6129 * bus/bus.c, bus/connection.c, bus/config-parser.c: change to
6130 match change in how policy works
6132 * dbus/dbus-internals.h: mark assert_not_reached as
6133 __attribute((noreturn))__
6135 2003-04-11 Havoc Pennington <hp@redhat.com>
6137 * doc/dbus-specification.sgml: fix a spot with the wrong name for
6138 the broadcast service. Use boolean return for ServiceExists.
6140 2003-04-11 Havoc Pennington <hp@redhat.com>
6142 * configure.in: add another directory to look for qt in.
6144 2003-04-11 Havoc Pennington <hp@redhat.com>
6146 * AUTHORS: add Colin Walters
6148 2003-04-11 Havoc Pennington <hp@redhat.com>
6154 2003-04-11 Havoc Pennington <hp@redhat.com>
6156 * bus/messagebus.in: remove pid file when stopping the
6157 message bus, since the bus won't have privileges to remove it
6160 2003-04-11 Havoc Pennington <hp@redhat.com>
6162 * bus/bus.c (bus_context_new): move credentials change after
6165 2003-04-11 Havoc Pennington <hp@pobox.com>
6167 * test/decode-gcov.c: add "below average functions" to the
6168 coverage report, and change how some of the code works.
6170 * bus/test-main.c: bracket some stuff in DBUS_BUILD_TESTS so it's
6171 not in the coverage stats.
6173 * test/test-service.c (main): use _dbus_verbose not fprintf in a
6174 couple places so running the test suite doesn't result in megaspam.
6176 2003-04-11 Havoc Pennington <hp@pobox.com>
6178 * bus/dispatch.c (check_existent_service_activation): accept a no
6179 memory error in a place we didn't before
6181 * bus/test.c (bus_test_run_everything): remove hacky "do it twice
6182 in case the first one failed," since the test suite is less
6185 2003-04-10 Havoc Pennington <hp@pobox.com>
6187 * bus/dispatch.c (check_segfault_service_activation): add test
6188 for launching an executable that just crashes.
6190 * test/test-segfault.c (main): try setting coredumpsize to 0 so we
6191 don't leave a million cores. We'll see how portable this is.
6193 2003-04-10 Havoc Pennington <hp@pobox.com>
6195 * dbus/dbus-spawn.c (_dbus_spawn_async_with_babysitter): move all
6196 the possible parent failures before we fork, so that we don't
6197 fail to create a babysitter after creating the child.
6199 * bus/activation.c (bus_activation_activate_service): kill child
6200 if we don't successfully complete the activation.
6202 2003-04-10 Havoc Pennington <hp@redhat.com>
6204 * dbus/dbus-connection.c (dbus_connection_flush): don't spin on
6205 the connection if it's disconnected
6207 * bus/activation.c (bus_activation_service_created): use new
6208 transaction features to roll back removal of pending activation if
6209 we don't successfully create the service after all. Don't remove
6210 pending activation if the function fails.
6212 * dbus/dbus-list.c (_dbus_list_insert_before_link)
6213 (_dbus_list_insert_after_link): new code to facilitate
6216 * dbus/dbus-hash.c (_dbus_hash_table_insert_string_preallocated):
6217 new functionality, so we can preallocate the ability to insert
6220 * bus/connection.c (bus_transaction_add_cancel_hook): new function
6221 allowing us to put custom hooks in a transaction to be used for
6222 cancelling said transaction
6224 * doc/dbus-specification.sgml: add some discussion of secondary
6225 service owners, and disallow zero-length service names
6227 * bus/services.c (bus_registry_acquire_service): new function,
6228 splits out part of bus_driver_handle_acquire_service() and fixes
6229 a bug where we didn't remove the service doing the acquiring
6230 from the secondary queue if we failed to remove the current owner
6231 from the front of the queue.
6233 2003-04-10 Alexander Larsson <alexl@redhat.com>
6235 * doc/dbus-specification.sgml:
6236 s/org.freedesktop.Broadcast/org.freedesktop.DBus.Broadcast/
6238 2003-04-10 Alexander Larsson <alexl@redhat.com>
6243 Added files to cvsignore
6245 * dbus/dbus-message.h:
6246 * dbus/dbus-message.c: (dbus_message_iter_get_named):
6247 Make get_named() take two out argument and return a boolean.
6248 (dbus_message_iter_get_args_valist):
6249 Update usage of get_named().
6250 (dbus_message_iter_append_byte):
6252 (dbus_message_iter_append_named)
6254 (message_iter_test), (check_message_handling_type), (_dbus_message_test):
6257 2003-04-10 Alexander Larsson <alexl@redhat.com>
6259 * dbus/dbus-marshal.[ch]:
6260 Add array_type_pos argument to _dbus_marshal_validate_arg.
6261 Let you pass a NULL end_pos to _dbus_marshal_validate_type.
6263 * dbus/dbus-message.[ch]:
6264 Multi-dimensional arrays have full type specification in the
6265 outermost array. Iter code re-arranged to handle this.
6266 Added some more iter tests.
6268 * doc/dbus-specification.sgml:
6271 Update new array encoding description.
6272 Correct DBUS_SERVICE_FLAGS_REPLACE_EXISTING description.
6274 * test/data/invalid-messages/array-with-mixed-types.message:
6275 * test/data/valid-messages/array-of-array-of-uint32.message:
6276 Change to the new array format.
6278 * test/data/invalid-messages/too-short-dict.message:
6281 * test/data/valid-messages/recursive-types.message:
6282 Fix up and extend test.
6284 2003-04-10 Havoc Pennington <hp@pobox.com>
6286 * bus/dispatch.c: lots of fixes
6288 * dbus/dbus-mainloop.c (_dbus_loop_dispatch): export
6289 (_dbus_loop_iterate): remove old "quit if no callbacks" code,
6290 that was crack, broke the test service.
6292 * dbus/dbus-transport.c (_dbus_transport_open): fix error
6293 handling to avoid piling up errors if we get a failure on the
6296 * dbus/dbus-internals.c (_dbus_real_assert_not_reached): include
6297 pid in assertion failures.
6299 * dbus/dbus-mainloop.c (_dbus_loop_iterate): use static arrays up
6300 to some fixed size of file descriptor array. Don't return TRUE
6301 anytime a timeout exists, that led to lots of busy loop silliness
6304 2003-04-09 Havoc Pennington <hp@redhat.com>
6306 * dbus/dbus-mainloop.c (check_timeout): fix timeouts, I thought
6307 I'd checked this in earlier but hadn't.
6309 2003-04-09 Havoc Pennington <hp@redhat.com>
6311 * bus/dispatch.c (bus_dispatch_test): get a bit further through
6312 the activation test (man this is getting old!)
6314 2003-04-09 Havoc Pennington <hp@redhat.com>
6316 * test/test-utils.c: use dispatch status function to fix this up
6318 * bus/connection.c (connection_watch_callback): don't dispatch
6320 (connection_timeout_callback): don't dispatch from here
6321 (bus_connections_setup_connection): set the dispatch status function
6322 (bus_connection_disconnected): unset it
6324 * dbus/dbus-mainloop.c (_dbus_loop_queue_dispatch): new function
6325 used to add a connection to be dispatched
6326 (_dbus_loop_iterate): do the dispatching at the end of each
6329 * dbus/dbus-connection.c
6330 (dbus_connection_set_dispatch_status_function): new function
6331 allowing us to fix up main loop usage
6332 (_dbus_connection_last_unref): free all the various function
6334 (dbus_connection_dispatch): call the DispatchStatusFunction
6335 whenever this function returns
6336 (dbus_connection_handle_watch): call DispatchStatusFunction
6337 (dbus_connection_send_with_reply_and_block): call DispatchStatusFunction
6338 (reply_handler_timeout): call DispatchStatusFunction
6339 (dbus_connection_flush): call DispatchStatusFunction
6341 2003-04-09 Havoc Pennington <hp@redhat.com>
6343 * dbus/dbus-bus.c (dbus_bus_register): fix up error handling and
6346 * bus/dispatch.c (check_service_activated): fix bug in test
6348 * dbus/dbus-mainloop.c (check_timeout): fix this up
6350 * dbus/dbus-internals.c (_dbus_verbose_real): include PID in
6351 verbose output so we can sort out output from different processes,
6352 e.g. in the activation case.
6354 2003-04-08 Colin Walters <walters@gnu.org>
6356 * bus/bus.c (struct BusContext) [pidfile]: New member, to store
6358 (bus_context_new): Set it.
6359 (bus_context_unref): Use it to delete the pid file.
6361 2003-04-08 Havoc Pennington <hp@redhat.com>
6363 * test/data/invalid-messages/array-with-mixed-types.message:
6364 regression test that fails for the moment
6366 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): reorder
6367 tests for convenience
6369 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): don't allow
6370 array of nil, it broke things.
6372 * test/data/invalid-messages/array-of-nil.message: regression test
6374 * test/data/valid-messages/array-of-array-of-uint32.message:
6375 happened to write this so added it to suite
6377 2003-04-08 Havoc Pennington <hp@redhat.com>
6379 * bus/driver.c (bus_driver_handle_acquire_service): init
6380 retval/reply before checking name
6382 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add a
6383 recursion depth argument
6385 * dbus/dbus-message.h (struct DBusMessageIter): put some padding
6386 in the public struct for future extension
6388 * dbus/dbus-message-builder.c (_dbus_message_data_load): fix
6391 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix a verbose
6394 * doc/dbus-specification.sgml: fix typo
6396 2003-04-08 Alexander Larsson <alexl@redhat.com>
6398 Implemented recursive types, named types and new-style iters
6401 * glib/test-thread-client.c: (thread_func):
6402 * glib/test-thread-server.c: (handle_test_message):
6403 * test/test-service.c: (handle_echo):
6412 * dbus/dbus-internals.c: (_dbus_type_to_string):
6413 Update for new types.
6415 * dbus/dbus-marshal.[ch]:
6416 Implement recursive types and the new marshalling format.
6417 Remove hardcoded dict marshalling.
6418 Marshal named types.
6420 * dbus/dbus-message-builder.c:
6422 Remove references to old types
6424 * dbus/dbus-message.[ch]:
6425 New non-refcounted iter API that supports recursive iters.
6426 Use iters for appending, including support for recursive
6428 Add byte and named type support.
6429 Update everything to new marshalling formats.
6430 Add tests for new API.
6432 * dbus/dbus-protocol.h:
6433 Remove old array types.
6434 Add types: BYTE, ARRAY, DICT, NAMED
6436 * dbus/dbus-string.c:
6437 * dbus/dbus-sysdeps.c:
6438 Make parse_double locale safe.
6440 * dbus/dbus-test-main.c:
6446 * doc/dbus-specification.sgml:
6449 * test/data/incomplete-messages/missing-body.message:
6450 * test/data/invalid-messages/bad-boolean.message:
6451 * test/data/invalid-messages/bad-boolean-array.message:
6452 * test/data/invalid-messages/boolean-array-length-too-long.message-raw:
6453 * test/data/invalid-messages/boolean-has-no-value.message-raw:
6454 * test/data/invalid-messages/too-short-dict.message:
6455 * test/data/valid-messages/dict-simple.message:
6456 * test/data/valid-messages/dict.message:
6457 * test/data/valid-messages/emptiness.message:
6458 * test/data/valid-messages/lots-of-arguments.message:
6459 * test/data/valid-messages/no-padding.message:
6460 * test/data/valid-messages/recursive-types.message:
6461 Add missing NAME fields
6462 Fix up dicts & arrays
6464 * test/data/invalid-messages/dict-with-nil-value.message:
6465 Removed, this is not invalid anymore.
6467 * test/data/valid-messages/recursive-types.message:
6468 Add new test for deeply recursive types.
6470 2003-04-07 Havoc Pennington <hp@pobox.com>
6472 * bus/driver.c (bus_driver_handle_acquire_service): return an
6473 error if you try to acquire a service that starts with ':'
6475 2003-04-07 Havoc Pennington <hp@redhat.com>
6477 * doc/dbus-specification.sgml: require that base service names
6478 start with ':' and that the base service is created/deleted
6479 as first and last things a connection does on the bus
6481 * bus/dispatch.c (check_existent_service_activation): lots more
6482 work on the activation test; it doesn't fully pass yet...
6484 * test/test-service.c (main): fix so we don't memleak the
6485 connection to the message bus
6486 (filter_func): accept a message asking us to exit
6488 2003-04-06 Havoc Pennington <hp@pobox.com>
6490 * qt/Makefile.am (dbusinclude_HEADERS): install dbus-qt.h,
6493 * configure.in: fixes to Qt detection from Colin Walters
6495 * doc/Makefile.am: Only remove generated docbook dirs if they
6496 exist, from Colin Walters
6498 * dbus/dbus-bus.c: change how we set well-known connections to
6499 NULL, so that it works if a single connection is stored in
6500 two well-known array slots.
6502 * test/Makefile.am: remove a lot of stuff that isn't immediately
6503 useful, it's in CVS history if we want it.
6505 * test/test-service.c: use dbus-mainloop instead of that
6508 2003-04-06 Havoc Pennington <hp@pobox.com>
6510 * dbus/Makefile.am: split lists of sources into stuff that goes in
6511 the library, util functions that go in the lib and are also used
6512 elsewhere, and util functions that are used in tests/daemon but
6513 don't go in the lib.
6515 * dbus/dbus-mainloop.h, dbus/dbus-mainloop.c: move bus/loop.[hc]
6516 here so it can be used in test binaries also
6518 2003-04-06 Havoc Pennington <hp@pobox.com>
6520 * dbus/dbus-sysdeps.c (_dbus_become_daemon): write the pidfile
6521 here in the parent process, so we can return an error if it
6522 fails. Also, move some of the code into the child so the parent
6523 is less hosed if we fail midway through.
6525 * bus/bus.c (bus_context_new): move pidfile detection further up
6526 in the function, before we start overwriting sockets and such.
6528 * bus/messagebus.in: adjust this a bit, not sure if it will work.
6530 * configure.in: add --with-system-pid-file and --with-system-socket
6532 2003-04-06 Colin Walters <walters@verbum.org>
6534 * configure.in (DBUS_SYSTEM_PID_FILE): New variable.
6536 * bus/system.conf.in: Declare a pidfile.
6538 * bus/bus.c (bus_context_new): Test for an existing pid file, and
6539 create one (if appropriate).
6541 * bus/config-parser.c (enum ElementType) [ELEMENT_PIDFILE]: New.
6542 (struct BusConfigParser) [pidfile]: New.
6543 (element_type_to_name, merge_included, start_busconfig_child)
6544 (bus_config_parser_end_element, bus_config_parser_content): Handle it.
6545 (bus_config_parser_unref): Free it.
6546 (bus_config_parser_get_pidfile): New function.
6548 * bus/config-parser.h (_dbus_write_pid_file): Prototype.
6550 * dbus/dbus-errors.h (DBUS_ERROR_PIDFILE_EXISTS): New error.
6552 * dbus/dbus-sysdeps.c (_dbus_write_pid_file): New function.
6554 * dbus/dbus-sysdeps.h: Prototype it.
6556 2003-04-06 Havoc Pennington <hp@pobox.com>
6558 * bus/bus.c (bus_context_new): print the address in here, rather
6559 than in main(), because we need to do it before forking the daemon
6561 * bus/dispatch.c (send_service_nonexistent_error): set the sender
6562 on the service nonexistent error
6564 * bus/driver.c (bus_driver_handle_acquire_service): set the
6565 sender on the AcquireService reply
6567 * test/data/valid-config-files/debug-allow-all.conf.in: Make test
6568 server also listen on a UNIX socket so services can connect to it.
6570 2003-04-06 Havoc Pennington <hp@pobox.com>
6572 * dbus/dbus-threads.c: Redo how the fake debug mutexes are done
6573 so it detects deadlocks and also we actually init threads when
6576 2003-04-06 Havoc Pennington <hp@pobox.com>
6578 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
6579 save the domain socket name, and unlink it when we disconnect the
6580 server. Means that at least when we exit normally, we won't leave
6581 a bunch of junk in /tmp
6583 * dbus/dbus-transport-unix.c
6584 (_dbus_transport_new_for_domain_socket): code cleanup (nicer
6585 memory management). (I was making a real change here but then
6588 2003-04-06 Havoc Pennington <hp@pobox.com>
6590 * bus/bus.c (bus_context_new): fix wrong handling of
6591 server_data_slot_unref() in the error case.
6593 * dbus/dbus-internals.h (_dbus_assert): change so it passes
6594 "(condition) != 0" to _dbus_real_assert so that
6595 "_dbus_assert (pointer)" doesn't cause a warning
6597 * bus/main.c (main): accept --print-address option to print out
6598 the message bus address
6600 * dbus/dbus-sysdeps.c (_dbus_generate_random_ascii): export this
6602 * dbus/dbus-transport.c (_dbus_transport_open): special error for
6603 "tmpdir" option to unix: address on client side
6605 * dbus/dbus-server.c (dbus_server_listen): handle "tmpdir" option
6608 * configure.in (TEST_SOCKET_DIR): locate a temporary directory
6609 we can use to create sockets in the test suite.
6611 * bus/main.c (signal_handler): on SIGTERM, exit the daemon
6612 cleanly. To be used for testing.
6614 * dbus/dbus-spawn.c (babysit): use _dbus_set_signal_handler()
6616 * dbus/dbus-sysdeps.c (_dbus_set_signal_handler): new
6618 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
6619 handle trying to call this when there's no servers active
6621 2003-04-05 Havoc Pennington <hp@pobox.com>
6627 2003-04-05 Havoc Pennington <hp@pobox.com>
6629 * bus/bus.c (setup_server): fix this so dbus-daemon-1 doesn't
6630 crash on startup. Need to get "try starting the daemon"
6631 in the test suite I guess. ;-)
6633 * dbus/dbus-server.h, dbus/dbus-server.c: remove the stuff that
6634 tracked the number of open connections; it's better done in
6635 application-specific code as you want it to span all servers etc.
6637 2003-04-05 Havoc Pennington <hp@pobox.com>
6639 * bus/Makefile.am (install-data-hook): add missing DESTDIR,
6640 patch from Colin Walters
6642 2003-04-05 Havoc Pennington <hp@pobox.com>
6644 * doc/config-file.txt (Elements): fix docs of <auth> to reflect
6645 reality; in fact multiple mechanisms are allowed.
6647 * dbus/dbus-internals.c (_dbus_real_assert)
6648 (_dbus_real_assert_not_reached): move guts of _dbus_assert() and
6649 _dbus_assert_not_reached() into functions, so that they don't show
6650 up in basic block counts for test coverage, and don't use up as
6651 much disk space. Does mean slower execution speed though, so
6652 assumes --disable-asserts is the normal production case.
6654 2003-04-05 Havoc Pennington <hp@pobox.com>
6656 * test/Makefile.am (dist-hook): also dist *.in files
6662 2003-04-05 Havoc Pennington <hp@pobox.com>
6664 * dbus/dbus-string.c: docs warning
6666 * dbus/dbus-spawn.c: missing docs
6668 * dbus/dbus-memory.c (struct ShutdownClosure): missing docs
6670 2003-04-05 Havoc Pennington <hp@pobox.com>
6672 * bus/loop.c (bus_loop_iterate): fix the timeout code, using
6675 * dbus/dbus-spawn.c (_dbus_babysitter_unref): set sitter_pid
6676 to -1 once we've reaped the babysitter
6677 (_dbus_babysitter_handle_watch): do as much work as we can, not
6680 * bus/activation.c: add code using DBusBabysitter so that we
6681 handle it when a service fails to start up properly.
6682 (bus_activation_service_created): don't remove the activation
6683 entries as we go, just let them get removed when we free the pending
6684 activation. Unref reply messages after sending them.
6686 2003-04-05 Havoc Pennington <hp@pobox.com>
6688 * test/decode-gcov.c (main): print per-directory stats in the report
6690 * Makefile.am (coverage-report.txt): don't include test/* in gcov stats
6692 2003-04-05 Havoc Pennington <hp@pobox.com>
6694 * Makefile.am (coverage-report.txt): add target "coverage-report.txt"
6696 * test/decode-gcov.c: hack up a little program to suck data
6697 out of gcov files. Yes this is sort of silly.
6699 * configure.in: define something in config.h and do an
6700 AM_CONDITIONAL when gcov is enabled
6702 2003-04-04 Havoc Pennington <hp@redhat.com>
6704 * dbus/dbus-spawn.c, dbus/dbus-spawn.h: Change dbus_spawn to
6705 return a "babysitter" object that is used to monitor the status of
6706 the spawned process and reap it when required.
6708 * test/test-segfault.c, test/test-exit.c,
6709 test/test-sleep-forever.c: binaries that do various lame things,
6710 used in the test suite.
6712 * dbus/dbus-sysdeps.c: kill _dbus_errno_to_string()
6714 2003-04-03 Havoc Pennington <hp@pobox.com>
6716 * dbus/dbus-spawn.c: Move dbus-spawn into a separate file
6717 in preparation for modifying it, dbus-sysdeps is getting
6720 2003-04-03 Havoc Pennington <hp@redhat.com>
6722 * bus/loop.h, bus/loop.c: make the mainloop an object so we can
6725 * bus/*.[hc]: adapt to mainloop change
6727 2003-04-03 Havoc Pennington <hp@redhat.com>
6729 * bus/activation.c (load_directory): fix up memleaks
6730 (bus_activation_entry_free): free the entry
6732 * dbus/dbus-bus.c (dbus_bus_acquire_service): return an error if
6733 we get one from the message bus; fix memleaks.
6735 * dbus/dbus-message.c (dbus_set_error_from_message): new function
6737 2003-04-03 Havoc Pennington <hp@pobox.com>
6739 * bus/config-parser.c (bus_config_parser_unref): free
6740 list of mechanisms, bug discovered by test suite enhancements
6741 (putting system.conf and session.conf into suite)
6743 * test/Makefile.am, test/test-service.c: add placeholder for a
6744 test service that we'll activate as part of test suite. Doesn't
6747 * dbus/dbus-sysdeps.c (_dbus_setenv): support unsetenv by
6748 setting NULL value, and use system malloc not dbus_malloc()
6749 when we have unavoidable memleakage.
6751 * dbus/dbus-bus.c (dbus_bus_get): fix bug where bus type of 0
6752 didn't work, and support DBUS_BUS_ACTIVATION.
6754 * bus/activation.c (child_setup): pass our well-known bus type to
6757 * bus/config-parser.c: support <type> to specify well-known type
6759 * doc/dbus-specification.sgml: document the env variables to
6760 locate well-known buses and find service activator
6762 2003-04-02 Havoc Pennington <hp@redhat.com>
6764 * test/Makefile.am (all-local): add a rule to copy tests to
6765 builddir, so we can have generated tests. Use this to remove the
6766 silly hack for testing system.conf and session.conf. Will use this
6767 shortly to generate .service files pointing to test binaries.
6769 2003-04-02 Havoc Pennington <hp@redhat.com>
6771 * dbus/dbus-string.c (set_length): fix a bug - we allocated max of
6772 current alloc and needed new length, not max of the doubled
6773 allocation and needed new length. Also, when building tests,
6774 don't do the double-allocation stuff, just realloc every time.
6776 2003-04-02 Havoc Pennington <hp@redhat.com>
6778 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): include filenames
6780 (_dbus_string_get_dirname): new
6781 (_dbus_sysdeps_test): new
6782 (_dbus_directory_open): include dirnames in error messages
6784 * bus/config-parser.c: interpret <include> and <includedir> and
6785 <servicedir> relative to config file location if the given
6786 filename is not absolute.
6788 * dbus/dbus-string.c (_dbus_string_find_byte_backward): new
6790 2003-04-02 Havoc Pennington <hp@redhat.com>
6792 * bus/connection.c (bus_transaction_send_error_reply): set sender
6793 service for the error, and unref the reply on success
6795 * bus/activation.c: convert to use BusTransaction so OOM can be
6797 (bus_activation_service_created): set sender of the message
6799 2003-04-01 Havoc Pennington <hp@redhat.com>
6801 * bus/config-parser.c, bus/bus.c: implement <servicedir> and
6802 <includedir> (at least mostly)
6804 * dbus/dbus-sysdeps.c (_dbus_change_identity): set the group ID
6805 first, then the user ID
6807 2003-04-01 Havoc Pennington <hp@pobox.com>
6809 * dbus/dbus-server.c (dbus_server_set_auth_mechanisms): new
6812 * dbus/dbus-auth.c (_dbus_auth_set_mechanisms): new
6814 * dbus/dbus-internals.c (_dbus_dup_string_array): new function
6816 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): chmod the
6817 socket 0777, and unlink any existing socket.
6819 * bus/bus.c (bus_context_new): change our UID/GID and fork if
6820 the configuration file so specifies; set up auth mechanism
6823 * bus/config-parser.c (bus_config_parser_content): add support
6824 for <fork> option and fill in code for <auth>
6826 * bus/system.conf.in: add <fork/> to default configuration,
6827 and limit auth mechanisms to EXTERNAL
6829 * doc/config-file.txt (Elements): add <fork>
6831 * dbus/dbus-sysdeps.c (_dbus_become_daemon): new function
6832 (_dbus_change_identity): new function
6834 2003-03-31 Havoc Pennington <hp@redhat.com>
6836 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket)
6837 (_dbus_listen_unix_socket): fix off-by-one error in null
6838 termination spotted by Nalin
6840 2003-03-31 Havoc Pennington <hp@redhat.com>
6842 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): allow setting
6843 DBUS_TEST_HOMEDIR when tests are enabled, so we can test without
6844 having a real home directory available.
6846 2003-03-31 Havoc Pennington <hp@redhat.com>
6848 * bus/Makefile.am (install-data-hook): create /var/run/dbus
6850 * bus/messagebus.in: add init script for Red Hat /etc/init.d
6852 * configure.in: add support for specifying a style of init script
6855 2003-03-31 Havoc Pennington <hp@redhat.com>
6857 Fix some annoying DBusString API and fix all affected code.
6859 * dbus/dbus-string.c (_dbus_string_init): get rid of annoying
6861 (_dbus_string_get_data): change to return string instead of using
6863 (_dbus_string_get_const_data): ditto
6864 (_dbus_string_get_data_len): ditto
6865 (_dbus_string_get_const_data_len): ditto
6867 2003-03-31 Havoc Pennington <hp@redhat.com>
6869 * bus/main.c (main): fix up the command line arguments to be nicer
6871 2003-03-31 Havoc Pennington <hp@redhat.com>
6873 * dbus/Makefile.am (INCLUDES): use EXPANDED_LOCALSTATEDIR to
6874 define DBUS_SYSTEM_BUS_PATH as we want to compile in the same
6875 final location that lands in the config file
6877 * bus/config-loader-expat.c (bus_config_load): fix type of
6880 * doc/TODO: remove TODO item for dbus_bus_get()
6882 * dbus/dbus-bus.c (bus_data_free): add missing lock/unlock
6884 2003-03-31 Havoc Pennington <hp@pobox.com>
6886 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_domain_socket)
6887 (_dbus_transport_new_for_tcp_socket): these didn't need the "server"
6888 argument since they are always client side
6890 * dbus/dbus-server.c (dbus_server_get_address): new function
6892 * bus/main.c (main): take the configuration file as an argument.
6894 * test/data/valid-config-files/debug-allow-all.conf: new file to
6895 use with dispatch.c tests for example
6897 * bus/test-main.c (main): require test data dir
6899 * bus/bus.c (bus_context_new): change this to take a
6900 configuration file name as argument
6902 * doc/config-file.txt (Elements): add <servicedir>
6904 * bus/system.conf, bus/session.conf: new files
6906 * dbus/dbus-bus.c (dbus_bus_get): look for system bus on
6907 well-known socket if none set
6909 * configure.in: create system.conf and session.conf
6911 2003-03-30 Havoc Pennington <hp@pobox.com>
6913 * bus/config-parser.c: hacking
6915 * dbus/dbus-memory.c: don't use DBusList for the list of stuff
6916 to shut down, since it could cause weirdness with the DBusList
6919 * dbus/dbus-list.c (_dbus_list_test): add tests for the
6920 link-oriented stack routines
6921 (alloc_link): free the mempool if the first alloc from it fails
6923 * dbus/dbus-mempool.c (struct DBusMemBlock): fix alignment issue
6925 * dbus/dbus-string.c (UNICODE_VALID): sync new version of this
6927 (_dbus_string_skip_white): new
6929 * doc/config-file.txt (Elements): add <includedir>
6931 2003-03-28 Havoc Pennington <hp@pobox.com>
6933 * dbus/dbus-string.c (_dbus_string_copy_data_len)
6934 (_dbus_string_copy_data): new functions
6936 2003-03-28 Anders Carlsson <andersca@codefactory.se>
6938 * dbus/dbus-bus.c: (bus_data_free), (dbus_bus_get):
6942 * dbus/dbus-memory.c:
6945 2003-03-28 Havoc Pennington <hp@pobox.com>
6947 * bus/test.c (bus_test_flush_bus): remove the sleep from here,
6948 I think it may have just been superstition. Not sure.
6950 * dbus/dbus-string.c (_dbus_string_base64_decode): catch some OOM
6951 failures that were not being handled.
6953 * dbus/dbus-auth.c (process_auth): fix a memleak in OOM handling
6955 * dbus/dbus-memory.c: add ability to set number of mallocs in a
6956 row that will fail on out-of-memory.
6958 * dbus/dbus-internals.c (_dbus_test_oom_handling): convenience
6959 function for testing out-of-memory handling.
6961 * bus/config-loader-expat.c (memsuite): don't wrap the dbus
6962 allocation functions, they do map exactly to the expat ones.
6964 2003-03-27 Havoc Pennington <hp@redhat.com>
6966 * bus/config-loader-libxml.c (bus_config_load): add another error
6969 2003-03-26 Anders Carlsson <andersca@codefactory.se>
6972 Add note about automatic service activation.
6974 * doc/dbus-specification.sgml:
6975 Rename the specification and clarify a few things.
6977 2003-03-26 Anders Carlsson <andersca@codefactory.se>
6980 * dbus/dbus-address.c:
6982 * dbus/dbus-marshal.c:
6983 * dbus/dbus-server-debug-pipe.c:
6984 * dbus/dbus-transport-unix.c:
6985 Fix documentation warnings.
6987 2003-03-26 Havoc Pennington <hp@pobox.com>
6989 * bus/test-main.c, dbus/dbus-test.c (main): check memleaks
6990 after every test so it's quick and easy to see which leaked, and
6991 so we test multiple dbus_shutdown() calls
6993 * configure.in: change configure.in XML stuff to also support
6996 * config-loader-libxml.c: some hacking
6998 * config-loader-expat.c: some hacking
7000 * config-parser.c: some hacking, plus tests
7002 2003-03-25 Havoc Pennington <hp@redhat.com>
7004 * throughout - add more _DBUS_ASSERT_ERROR_IS_CLEAR
7006 * configure.in: add --with-xml option to specify XML library,
7007 right now only libxml is supported.
7009 * bus/config-loader-libxml.c, config-parser.c: sync some minor
7010 nonworking code between home and work, still just stubs
7012 2003-03-24 Havoc Pennington <hp@redhat.com>
7014 * dbus/dbus-sysdeps.c (_dbus_set_fd_nonblocking): move to this
7017 * dbus/dbus-errors.c (dbus_set_error, dbus_set_error_const): allow
7018 NULL argument for "message" if the error is a well-known one,
7019 fill in a generic message in this case.
7021 * dbus/dbus-errors.h (DBusResultCode): Kill DBusResultCode in
7024 * bus/test.c (bus_test_flush_bus): add
7026 * bus/policy.c (bus_policy_test): test code stub
7028 2003-03-24 Havoc Pennington <hp@pobox.com>
7030 * bus/connection.c (bus_connections_setup_connection): set up
7031 the "can this user connect" function, but it always returns
7032 TRUE until we have a config file parser so we can have a config
7033 file that allows connections.
7035 2003-03-23 Havoc Pennington <hp@pobox.com>
7037 * dbus/dbus-threads.c (dbus_mutex_new, dbus_condvar_new): with
7038 DBUS_BUILD_TESTS, actually alloc/free a block of memory for
7039 the mutex, so we can check for proper memory management
7042 * dbus/dbus-dataslot.c: remove the mutex from
7043 DBusDataSlotAllocator and lock it manually when using it,
7044 to simplify fitting it into the global slots framework.
7046 * dbus/dbus-threads.c (init_static_locks): rework how we're
7047 handling global locks so they are easily shut down.
7049 * bus/policy.c (bus_policy_append_rule): fix
7051 * bus/test-main.c (main): check for memleaks
7053 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): make
7054 test suite check for memleaks
7056 * dbus/dbus-memory.c: add support in test mode for tracking
7057 number of outstanding blocks
7059 2003-03-23 Havoc Pennington <hp@pobox.com>
7061 * bus/policy.c, bus/bus.c, bus/connection.c: implement allow/deny
7064 * dbus/dbus-hash.h: add ULONG hash keys
7066 * dbus/dbus-sysdeps.c (_dbus_get_groups): new
7067 (_dbus_get_group_id): new function
7069 2003-03-20 Havoc Pennington <hp@redhat.com>
7071 * dbus/dbus-connection.c (dbus_connection_set_unix_user_function):
7073 (dbus_connection_get_unix_user): new function
7075 2003-03-20 Havoc Pennington <hp@pobox.com>
7077 * bus/connection.c (bus_connection_send_oom_error): assert that
7078 message has a sender
7079 (connection_execute_transaction): ditto
7080 (bus_connection_preallocate_oom_error): fix to set the sender, and
7081 set recipient to the destination service, not the bus driver
7083 * bus/policy.c: hacking
7085 * dbus/dbus-message.c (dbus_message_service_is): new function
7086 (dbus_message_sender_is): new
7088 2003-03-19 Havoc Pennington <hp@redhat.com>
7090 * bus/policy.c: start sketching code for policy restrictions on
7091 what connections can do.
7093 2003-03-18 Havoc Pennington <hp@redhat.com>
7095 * doc/TODO: some notes on high-level todo items. Little nitpick
7096 stuff is all in @todo, so no need to add it here.
7098 * doc/config-file.txt: some notes on how config file might look
7100 2003-03-18 Anders Carlsson <andersca@codefactory.se>
7106 2003-03-17 Havoc Pennington <hp@redhat.com>
7108 * dbus/dbus-internals.h: add gcc attributes so that
7109 our printf-style functions warn on bad arguments to
7112 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): fix printf
7115 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
7118 2003-03-17 Havoc Pennington <hp@redhat.com>
7120 * bus/test-main.c (main): make it print something as it runs
7121 so make check doesn't look stuck
7123 * doc/negotiation.txt, doc/dbus-sasl-profile.txt: remove
7124 from CVS, now obsolete
7126 2003-03-17 Anders Carlsson <andersca@codefactory.se>
7128 * bus/dispatch.c: (bus_dispatch):
7129 Refetch the service name since it may have been reallocated
7130 when dbus_message_set_sender was called.
7132 * dbus/dbus-sysdeps.c: (_dbus_accept):
7133 Add address and address length variables and use them to stop
7134 valgrind from complaining.
7136 2003-03-17 Havoc Pennington <hp@pobox.com>
7138 All tests pass, no memleaks, no valgrind complaints.
7140 * bus/test.c: refcount handler_slot
7142 * bus/connection.c (bus_connections_new): refcount
7143 connection_data_slot
7145 * dbus/dbus-auth-script.c (_dbus_auth_script_run): delete unused
7146 bytes so that auth scripts pass.
7148 * bus/dispatch.c: init message_handler_slot so it gets allocated
7151 * bus/dispatch.c (message_handler_slot_ref): fix memleak
7153 * dbus/dbus-server-debug-pipe.c (_dbus_server_debug_pipe_new):
7154 dealloc server_pipe_hash when no longer used for benefit of
7157 * dbus/dbus-auth.c (process_command): memleak fix
7159 * bus/dispatch.c (check_hello_message): memleak fix
7161 2003-03-16 Havoc Pennington <hp@pobox.com>
7163 * dbus/dbus-bus.c (ensure_bus_data): fix double-unref of the data slot
7165 2003-03-17 Anders Carlsson <andersca@codefactory.se>
7167 * bus/activation.c (bus_activation_activate_service): Append
7168 the pending activation entry to the list of pending activations.
7170 2003-03-16 Havoc Pennington <hp@pobox.com>
7172 * bus/dispatch.c (bus_dispatch_test): remove double-unrefs of
7175 * dbus/dbus-address.c (create_entry): fix OOM handling when
7176 failing to alloc entry->method
7178 2003-03-16 Havoc Pennington <hp@pobox.com>
7180 * dbus/dbus-watch.c (_dbus_watch_new): handle failure to malloc
7183 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
7184 add some missing dbus_set_result
7186 * bus/dispatch.c (bus_dispatch_add_connection): handle failure to
7187 alloc the DBusMessageHandler
7189 * dbus/dbus-transport.c (_dbus_transport_disconnect): don't ref
7190 the transport here, since we call this from the finalizer; it
7191 resulted in a double-finalize.
7193 * dbus/dbus-transport.c (_dbus_transport_disconnect): fix a bug
7194 where we tried to use transport->connection that was NULL,
7195 happened when transport was disconnected early on due to OOM
7197 * bus/*.c: adapt to handle OOM for watches/timeouts
7199 * dbus/dbus-transport-unix.c: port to handle OOM during
7202 * dbus/dbus-auth.c (_dbus_auth_get_unused_bytes): return a
7203 reference to unused bytes instead of a copy
7205 * dbus/dbus-server.c (dbus_server_handle_watch): return FALSE for
7208 * dbus/dbus-connection.c (dbus_connection_handle_watch): return
7211 * dbus/dbus-timeout.c (dbus_timeout_handle): return FALSE for out
7214 2003-03-16 Anders Carlsson <andersca@codefactory.se>
7216 * doc/dbus-specification.sgml:
7217 Document reply message for ActivateService.
7219 2003-03-16 Anders Carlsson <andersca@codefactory.se>
7221 * bus/activation.c: (bus_pending_activation_entry_free),
7222 (bus_pending_activation_free), (bus_activation_new),
7223 (bus_activation_unref), (bus_activation_service_created),
7224 (bus_activation_activate_service):
7226 * bus/bus.c: (bus_context_new):
7227 * bus/desktop-file.c: (new_section):
7228 * bus/driver.c: (bus_driver_send_service_deleted),
7229 (bus_driver_handle_activate_service):
7230 * bus/services.c: (bus_registry_new), (bus_registry_ensure):
7232 * dbus/dbus-connection.c:
7233 (dbus_connection_send_with_reply_and_block):
7234 * dbus/dbus-message.c: (dbus_message_append_args_valist):
7235 * dbus/dbus-protocol.h:
7236 Make activation work better. Now pending activations will be queued
7237 and the daemon won't try to activate services that are already registered.
7239 2003-03-16 Havoc Pennington <hp@pobox.com>
7241 * dbus/dbus-bus.c (ensure_bus_data): handle failure to set
7244 * dbus/dbus-memory.c (_dbus_initialize_malloc_debug): support
7245 DBUS_MALLOC_BACKTRACES to print trace when failing an alloc
7247 2003-03-16 Havoc Pennington <hp@pobox.com>
7249 * dbus/dbus-string.c (_dbus_string_validate_utf8): oops, unbreak
7250 this. always run the test suite before commit...
7252 * bus/*: adapt to DBusConnection API changes
7254 * glib/dbus-gmain.c: adapt to DBusConnection API changes,
7255 requires renaming stuff to avoid dbus_connection_dispatch name
7258 * dbus/dbus-transport.c (_dbus_transport_queue_messages): new
7261 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
7262 separate from _dbus_message_loader_return_buffer()
7264 * dbus/dbus-connection.c (dbus_connection_get_n_messages): remove
7265 this, because it's now always broken to use; the number of
7266 messages in queue vs. the number still buffered by the message
7267 loader is undefined/meaningless. Should use
7268 dbus_connection_get_dispatch_state().
7269 (dbus_connection_dispatch): rename from
7270 dbus_connection_dispatch_message
7272 2003-03-16 Havoc Pennington <hp@pobox.com>
7274 * dbus/dbus-string.c (_dbus_string_validate_utf8): copy in a real
7277 2003-03-16 Anders Carlsson <andersca@codefactory.se>
7279 * dbus/dbus-connection.c:
7280 (dbus_connection_send_with_reply_and_block):
7281 Decrease connection->n_incoming when removing an entry
7283 * dbus/dbus-dict.c: (dbus_dict_entry_free),
7284 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
7285 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
7286 (dbus_dict_set_byte_array), (dbus_dict_set_string_array),
7287 (dbus_dict_get_boolean_array), (dbus_dict_get_double_array),
7288 (dbus_dict_get_byte_array):
7289 Handle NULL arrays and strings. Also add support for byte arrays.
7291 * dbus/dbus-marshal.c: (_dbus_marshal_byte_array),
7292 (_dbus_marshal_dict), (_dbus_demarshal_byte_array),
7293 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
7294 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
7295 (_dbus_demarshal_dict), (demarshal_and_validate_len),
7296 (_dbus_marshal_validate_arg), (_dbus_marshal_test):
7297 * dbus/dbus-marshal.h:
7298 Add support for marshalling and demarshalling empty arrays and strings.
7300 * dbus/dbus-message.c: (dbus_message_append_args_valist),
7301 (dbus_message_append_string_array),
7302 (dbus_message_iter_get_boolean),
7303 (dbus_message_iter_get_boolean_array),
7304 (dbus_message_iter_get_int32_array),
7305 (dbus_message_iter_get_uint32_array),
7306 (dbus_message_iter_get_double_array),
7307 (dbus_message_iter_get_byte_array),
7308 (dbus_message_iter_get_string_array), (dbus_message_iter_get_dict),
7309 (check_message_handling):
7310 Add support for getting empty arrays and dicts.
7312 * dbus/dbus-string.c: (_dbus_string_validate_utf8):
7313 Don't do any validation at all for now, that's better than just checking
7316 * test/data/valid-messages/emptiness.message:
7317 New test message with lots of empty arrays.
7319 2003-03-16 Havoc Pennington <hp@pobox.com>
7321 * dbus/dbus-connection.c
7322 (_dbus_connection_queue_received_message_link): new function that
7323 can't fail due to OOM
7325 * dbus/dbus-message.c (_dbus_message_loader_pop_message_link):
7326 new function pops a message together with a list link
7329 * dbus/dbus-transport-unix.c (queue_messages): use new link-based
7330 message queuing functions to avoid needing to alloc memory
7332 2003-03-16 Havoc Pennington <hp@pobox.com>
7334 Oops - test code was only testing failure of around 30 of the
7335 mallocs in the test path, but it turns out there are 500+
7336 mallocs. I believe this was due to misguided linking setup such
7337 that there was one copy of dbus_malloc etc. in the daemon and one
7338 in the shared lib, and only daemon mallocs were tested. In any
7339 case, the test case now tests all 500+ mallocs, and doesn't pass
7340 yet, though there are lots of fixes in this patch.
7342 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
7343 this so that it doesn't need to allocate memory, since it
7344 has no way of indicating failure due to OOM (and would be
7345 annoying if it did).
7347 * dbus/dbus-list.c (_dbus_list_pop_first_link): new function
7349 * bus/Makefile.am: rearrange to create two self-contained
7350 libraries, to avoid having libraries with overlapping symbols.
7351 that was resulting in weirdness, e.g. I'm pretty sure there
7352 were two copies of global static variables.
7354 * dbus/dbus-internals.c: move the malloc debug stuff to
7357 * dbus/dbus-list.c (free_link): free list mempool if it becomes
7360 * dbus/dbus-memory.c (_dbus_disable_mem_pools): new function
7362 * dbus/dbus-address.c (dbus_parse_address): free list nodes
7365 * bus/dispatch.c (bus_dispatch_add_connection): free
7366 message_handler_slot when no longer using it, so
7367 memory leak checkers are happy for the test suite.
7369 * dbus/dbus-server-debug-pipe.c (debug_finalize): free server name
7371 * bus/bus.c (new_connection_callback): disconnect in here if
7372 bus_connections_setup_connection fails.
7374 * bus/connection.c (bus_connections_unref): fix to free the
7376 (bus_connections_setup_connection): if this fails, don't
7377 disconnect the connection, just be sure there are no side
7380 * dbus/dbus-string.c (undo_alignment): unbreak this
7382 * dbus/dbus-auth.c (_dbus_auth_unref): free some stuff we were
7384 (_dbus_auth_new): fix the order in which we free strings
7387 * bus/connection.c (bus_connection_disconnected): fix to
7388 not send ServiceDeleted multiple times in case of memory
7391 * dbus/dbus-bus.c (dbus_bus_get_base_service): new function to
7392 get the base service name
7393 (dbus_bus_register_client): don't return base service name,
7394 instead store it on the DBusConnection and have an accessor
7396 (dbus_bus_register_client): rename dbus_bus_register()
7398 * bus/dispatch.c (check_hello_message): verify that other
7399 connections on the bus also got the correct results, not
7400 just the one sending hello
7402 2003-03-15 Havoc Pennington <hp@pobox.com>
7404 Make it pass the Hello handling test including all OOM codepaths.
7405 Now to do other messages...
7407 * bus/services.c (bus_service_remove_owner): fix crash when
7408 removing owner from an empty list of owners
7409 (bus_registry_ensure): don't leave service in the list of
7410 a connection's owned services if we fail to put the service
7413 * bus/connection.c (bus_connection_preallocate_oom_error): set
7414 error flag on the OOM error.
7416 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
7417 handle _dbus_transport_set_connection failure
7419 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd): modify
7420 to create watches up front and simply enable/disable them as
7422 (unix_connection_set): this can now fail on OOM
7424 * dbus/dbus-timeout.c, dbus/dbus-watch.c: add concept
7425 of enabling/disabling a watch or timeout.
7427 * bus/loop.c (bus_loop_iterate): don't touch disabled
7430 * glib/dbus-gmain.c: adapt to enable/disable watches and timeouts
7432 2003-03-15 Havoc Pennington <hp@pobox.com>
7434 * bus/dispatch.c (bus_dispatch_test): OK, now finally actually
7435 write useful test code, after all that futzing around ;-)
7437 Test does not yet pass because we can't handle OOM in
7438 _dbus_transport_messages_pending (basically,
7439 dbus_connection_preallocate_send() does not prealloc the write
7440 watch). To fix this, I think we need to add new stuff to
7441 set_watch_functions, namely a SetEnabled function so we can alloc
7442 the watch earlier, then enable it later.
7444 * dbus/Makefile.am (libdbus_convenience_la_SOURCES): move
7445 dbus-memory.c to the convenience lib
7447 * bus/test.c: rename some static functions to keep them clearly
7448 distinct from stuff in connection.c. Handle client disconnection.
7450 2003-03-14 Havoc Pennington <hp@pobox.com>
7452 * bus/dispatch.c (bus_dispatch_test): do test using debug-pipe
7453 transport, tests more of the real codepath. Set up clients
7454 with bus_setup_debug_client.
7456 * bus/test.c (bus_setup_debug_client): function to set up debug
7457 "clients" on the main loop
7459 * dbus/dbus-transport.c (_dbus_transport_open): add debug-pipe
7462 * dbus/dbus-server.c (dbus_server_listen): add debug-pipe
7465 * dbus/dbus-server-debug.c: support a debug server based on pipes
7467 * dbus/dbus-sysdeps.c (_dbus_full_duplex_pipe): new function
7468 (_dbus_close): new function
7470 * configure.in: check for socketpair
7472 2003-03-14 Havoc Pennington <hp@redhat.com>
7474 * dbus/dbus-memory.c: add a "detect buffer overwrites on free"
7477 * dbus/dbus-transport-debug.c: rework this a good bit to be
7478 less complicated. hopefully still works.
7480 * dbus/dbus-server-debug.c (handle_new_client): remove timeout
7483 * glib/dbus-gmain.c (timeout_handler): don't remove timeout
7486 * dbus/dbus-message.c (dbus_message_copy): rename from
7487 dbus_message_new_from_message, fix it up to copy
7488 all the message fields, add test case
7490 * bus/dispatch.c (bus_dispatch_test): add some more test code,
7491 not quite passing yet
7493 2003-03-14 Havoc Pennington <hp@pobox.com>
7495 * bus/loop.c (bus_loop_iterate): add this so we can "run loop
7496 until no work remains" in test code. (the large diff here
7497 is just code movement, no actual changes)
7499 * dbus/dbus-server-debug.c (DEFAULT_INTERVAL): change interval to
7500 1, no point waiting around for test code.
7501 (_dbus_server_debug_accept_transport): unref the timeout
7502 after adding it (right?)
7504 * dbus/dbus-transport-debug.c (DEFAULT_INTERVAL): ditto
7506 2003-03-13 Havoc Pennington <hp@redhat.com>
7508 * dbus/dbus-timeout.c (_dbus_timeout_list_set_functions): handle
7511 * dbus/dbus-watch.c (_dbus_watch_list_set_functions): handle out
7514 * dbus/dbus-connection.h: Make AddWatchFunction and
7515 AddTimeoutFunction return a bool so they can fail on out-of-memory
7517 * bus/bus.c (bus_context_new): set up timeout handlers
7519 * bus/connection.c (bus_connections_setup_connection): set up
7522 * glib/dbus-gmain.c: adapt to the fact that set_functions stuff
7525 * bus/bus.c (bus_context_new): adapt to changes
7527 * bus/connection.c: adapt to changes
7529 * test/watch.c: adapt to DBusWatch changes
7531 * bus/dispatch.c (bus_dispatch_test): started adding this but
7534 2003-03-14 Anders Carlsson <andersca@codefactory.se>
7536 * bus/dispatch.c (send_service_nonexistent_error): Fix typo.
7538 2003-03-13 Havoc Pennington <hp@pobox.com>
7540 * bus/test.c, bus/test.h, bus/Makefile.am, bus/test-main.c:
7541 set up a test framework as for the library
7543 2003-03-12 Havoc Pennington <hp@pobox.com>
7545 Throughout: purge global variables, introduce BusActivation,
7546 BusConnections, BusRegistry, etc. objects instead.
7548 * bus/bus.h, bus/bus.c: introduce BusContext as a global
7551 * test/Makefile.am (TEST_BINARIES): disable bus-test for now,
7552 going to redo this a bit differently I think
7554 2003-03-12 Havoc Pennington <hp@redhat.com>
7556 Mega-patch that gets the message bus daemon initially handling
7557 out-of-memory. Work still needed. Also lots of random
7558 moving stuff to DBusError instead of ResultCode.
7560 * dbus/dbus-list.c (_dbus_list_length_is_one): new function
7562 * dbus/dbus-connection.c
7563 (dbus_connection_send_with_reply_and_block): use DBusError
7565 * dbus/dbus-bus.c: adapt to API changes, make it use DBusError not
7568 * dbus/dbus-connection.c (dbus_connection_send): drop the result
7569 code here, as the only failure possible is OOM.
7571 * bus/connection.c (bus_connection_disconnect):
7572 rename bus_connection_disconnected as it's a notification only
7574 * bus/driver.c (bus_driver_handle_acquire_service): don't free
7575 "name" on get_args failure, should be done by get_args;
7576 don't disconnect client for bad args, just return an error.
7577 (bus_driver_handle_service_exists): ditto
7579 * bus/services.c (bus_services_list): NULL-terminate returned array
7581 * bus/driver.c (bus_driver_send_service_lost)
7582 (bus_driver_send_service_acquired): send messages from driver to a
7583 specific client to the client's unique name, not to the broadcast
7586 * dbus/dbus-message.c (decode_header_data): reject messages that
7587 contain no name field
7588 (_dbus_message_get_client_serial): rename to
7589 dbus_message_get_serial and make public
7590 (_dbus_message_set_serial): rename from set_client_serial
7591 (_dbus_message_set_reply_serial): make public
7592 (_dbus_message_get_reply_serial): make public
7594 * bus/connection.c (bus_connection_foreach): allow stopping
7595 iteration by returning FALSE from foreach function.
7597 * dbus/dbus-connection.c (dbus_connection_send_preallocated)
7598 (dbus_connection_free_preallocated_send)
7599 (dbus_connection_preallocate_send): new API for sending a message
7600 without possibility of malloc failure.
7601 (dbus_connection_send_message): rename to just
7602 dbus_connection_send (and same for whole function family)
7604 * dbus/dbus-errors.c (dbus_error_free): make this reinit the error
7606 * dbus/dbus-sysdeps.c (_dbus_exit): new function
7608 * bus/activation.c: handle/return errors
7610 * dbus/dbus-errors.h: add more DBUS_ERROR #define
7612 * dbus/dbus-sysdeps.c (_dbus_directory_open) (_dbus_file_get_contents)
7613 (_dbus_directory_get_next_file): use DBusError instead of DBusResultCode
7614 (_dbus_result_from_errno): move to this file
7616 2003-03-10 Anders Carlsson <andersca@codefactory.se>
7618 * dbus/dbus-marshal.c:
7619 (_dbus_marshal_set_string):
7620 Take a length argument so we can marshal the correct string
7623 (_dbus_marshal_dict), (_dbus_demarshal_dict),
7624 (_dbus_marshal_get_arg_end_pos), (_dbus_marshal_validate_arg),
7625 (_dbus_marshal_test):
7626 * dbus/dbus-marshal.h:
7627 Add support for marshalling and demarshalling dicts.
7629 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
7630 Add support for TYPE DICT.
7632 * dbus/dbus-message.c: (set_string_field):
7633 Adjust header padding.
7635 (dbus_message_append_args_valist), (dbus_message_append_dict),
7636 (dbus_message_get_args_valist), (dbus_message_iter_get_arg_type),
7637 (dbus_message_iter_get_dict), (_dbus_message_loader_return_buffer),
7638 (check_message_handling), (check_have_valid_message):
7639 * dbus/dbus-message.h:
7640 Add functions for setting and getting dicts.
7642 * dbus/dbus-protocol.h:
7648 * doc/dbus-specification.sgml:
7649 Add information about how dicts are marshalled.
7651 * test/data/invalid-messages/dict-with-nil-value.message:
7652 * test/data/invalid-messages/too-short-dict.message:
7653 * test/data/valid-messages/dict-simple.message:
7654 * test/data/valid-messages/dict.message:
7655 Add sample messages containing dicts.
7657 2003-03-08 Anders Carlsson <andersca@codefactory.se>
7659 * dbus/dbus-dict.h: Add DBUS_END_DECLS.
7661 2003-03-07 Anders Carlsson <andersca@codefactory.se>
7664 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
7665 (dbus_dict_get_keys), (insert_entry), (dbus_dict_set_boolean),
7666 (dbus_dict_set_int32), (dbus_dict_set_uint32),
7667 (dbus_dict_set_double), (dbus_dict_set_string),
7668 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
7669 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
7670 (dbus_dict_set_string_array), (_dbus_dict_test):
7672 Fix according to comments from Havoc.
7674 2003-03-06 Michael Meeks <michael@server.home>
7676 * configure.in: if we don't have kde-config, disable have_qt.
7678 2003-03-07 Anders Carlsson <andersca@codefactory.se>
7683 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
7684 (dbus_dict_ref), (dbus_dict_unref), (dbus_dict_contains),
7685 (dbus_dict_remove), (dbus_dict_get_value_type),
7686 (dbus_dict_get_keys), (dbus_dict_put_boolean),
7687 (dbus_dict_put_int32), (dbus_dict_put_uint32),
7688 (dbus_dict_put_double), (dbus_dict_put_string),
7689 (dbus_dict_put_boolean_array), (dbus_dict_put_int32_array),
7690 (dbus_dict_put_uint32_array), (dbus_dict_put_double_array),
7691 (dbus_dict_put_string_array), (dbus_dict_get_boolean),
7692 (dbus_dict_get_int32), (dbus_dict_get_uint32),
7693 (dbus_dict_get_double), (dbus_dict_get_string),
7694 (dbus_dict_get_boolean_array), (dbus_dict_get_int32_array),
7695 (dbus_dict_get_uint32_array), (dbus_dict_get_double_array),
7696 (dbus_dict_get_string_array), (_dbus_dict_test):
7698 Add DBusDict implementation
7700 * dbus/dbus-test.c: (dbus_internal_do_not_use_run_tests):
7704 2003-03-04 Havoc Pennington <hp@pobox.com>
7706 * test/data/auth/*: adapt to changes
7708 * dbus/dbus-auth-script.c (_dbus_auth_script_run): add
7709 USERID_BASE64 and change USERNAME_BASE64 to put in username not
7712 * dbus/dbus-keyring.c (_dbus_keyring_validate_context): prevent
7713 more stuff from being in a context name, to make the protocol
7714 simpler to deal with
7716 * dbus/dbus-errors.c (dbus_error_has_name): new function
7717 (dbus_error_is_set): new function
7719 * dbus/dbus-auth.c: replace DBUS_STUPID_TEST_MECH auth
7720 with DBUS_COOKIE_SHA1, implement DBUS_COOKIE_SHA1
7722 * dbus/dbus-connection.c (dbus_connection_flush): also read
7723 messages during a flush operation
7725 * dbus/Makefile.am: remove dbus-md5 since it isn't currently used.
7727 2003-03-05 Anders Carlsson <andersca@codefactory.se>
7729 * configure.in: Check for gethostbyname on Solaris.
7731 * dbus/dbus-transport.c: (_dbus_transport_open):
7732 Remove duplicate "tcp" entry.
7734 * doc/dbus-specification.sgml:
7735 Clarify some things.
7737 2003-03-05 Anders Carlsson <andersca@codefactory.se>
7739 * dbus/dbus-auth.c: (send_rejected), (process_test_subdir):
7740 * dbus/dbus-keyring.c: (_dbus_keyring_new_homedir),
7741 (_dbus_keyring_test):
7742 * dbus/dbus-md5.c: (_dbus_md5_compute):
7743 * dbus/dbus-sha.c: (_dbus_sha_compute):
7746 2003-03-05 Anders Carlsson <andersca@codefactory.se>
7748 * README: Add some things.
7750 2003-03-04 Anders Carlsson <andersca@codefactory.se>
7752 * dbus/dbus-message.c (dbus_message_append_args_valist): Add a break;
7753 after case DBUS_TYPE_BOOELAN.
7755 2003-03-02 Havoc Pennington <hp@pobox.com>
7757 * test/break-loader.c (randomly_set_extreme_ints): add test that
7758 sets really huge and small integers
7760 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add check
7761 that length of boolean array fits in the string, and that
7762 string has room for boolean value in single-bool case.
7764 * dbus/dbus-message-builder.c (_dbus_message_data_load): add
7765 optional value to "ALIGN" command which is what to fill the
7768 * test/data/valid-messages/no-padding.message: add regression
7769 test for the message padding problem
7771 2003-03-02 Havoc Pennington <hp@pobox.com>
7773 * dbus/dbus-message.c (decode_header_data): fix to always init
7774 message_padding, from Benjamin Dauvergne
7776 2003-03-02 Havoc Pennington <hp@pobox.com>
7782 2003-03-01 Joe Shaw <joe@assbarn.com>
7784 * configure.in: Check for "struct cmsgcred" and try to access its
7785 members for BSD-like unices.
7787 * dbus/dbus-sysdeps.c (read_credentials_byte): Fold this back into
7788 _dbus_read_credentials_unix_socket().
7789 (_dbus_read_credentials_unix_socket): Use recvmsg() instead of
7790 read() for reading the credential byte off the unix socket. Use
7791 struct cmsgcred on systems that support it.
7793 2003-02-27 Alexander Larsson <alexl@redhat.com>
7797 Make gthreads-2.0 dependency optional. Don't build thread test if
7800 2003-02-27 Havoc Pennington <hp@pobox.com>
7802 * dbus/dbus-connection.c
7803 (dbus_connection_send_message_with_reply_and_block): fix doh!
7804 doh! doh! bug that resulted in never removing a reply from the
7805 queue, no wonder we called get_reply_serial so much ;-)
7807 * dbus/dbus-message.c (struct DBusMessage): cache reply serial
7808 and client serial instead of demarshaling them every time
7810 2003-02-27 Havoc Pennington <hp@pobox.com>
7812 * dbus/dbus-marshal.c (_dbus_demarshal_int32): rewrite to be much
7813 more inlined, using dbus-string-private.h, speeds things up
7816 * dbus/dbus-string.c (_dbus_string_free): apply align offset
7817 when freeing the string
7818 (_dbus_string_steal_data): fix for align offset
7819 (undo_alignment): new function
7821 2003-02-26 Havoc Pennington <hp@redhat.com>
7823 All kinds of audit fixes from Owen, plus initial attempt to
7824 handle unaligned memory returned from malloc.
7826 * dbus/dbus-string.c (_dbus_string_init): clamp max length to
7827 leave room for align_offset and nul byte
7828 (fixup_alignment): function to track an align_offset and
7829 ensure real->str is aligned
7830 (DBUS_GENERIC_STRING_PREAMBLE): len must be less than allocated,
7831 to allow a nul byte plus align offset
7832 (_dbus_string_lock): fix overflow issue
7833 (_dbus_string_init_const_len): add assertions on sanity of len,
7834 assign allocated to be ALLOCATION_PADDING larger than len
7835 (set_length): fixup the overflow handling
7836 (_dbus_string_get_data_len): fix overflow in assertion
7837 (open_gap): detect overflow in size of gap to be opened
7838 (_dbus_string_lengthen): add overflow check
7839 (_dbus_string_align_length): fix overflow with _DBUS_ALIGN_VALUE
7840 (_dbus_string_append): add overflow check
7841 (_dbus_string_append_unichar): overflow
7842 (_dbus_string_delete): fix overflow in assertion
7843 (_dbus_string_copy_len): overflow in assertion
7844 (_dbus_string_replace_len): overflows in assertions
7845 (_dbus_string_find): change to implement in terms of
7846 _dbus_string_find_to
7847 (_dbus_string_find_to): assorted fixage
7848 (_dbus_string_equal_c_str): assert c_str != NULL,
7849 fix logic so the function works
7850 (_dbus_string_ends_with_c_str): fix overflow thingy
7851 (_dbus_string_base64_encode): overflow fix
7852 (_dbus_string_validate_ascii): overflow
7853 (_dbus_string_validate_nul): overflow
7855 2003-02-26 Havoc Pennington <hp@redhat.com>
7857 * dbus/dbus-marshal.c (_dbus_marshal_test): fix to work with DISABLE_ASSERTS
7859 2003-02-26 Alexander Larsson <alexl@redhat.com>
7862 Set DBUS_GLIB_THREADS_LIBS for apps using gthread-2.0
7864 * dbus/dbus-connection.c:
7865 * dbus/dbus-connection.h:
7866 Fix _dbus_connection_acquire_io_path and _dbus_connection_acquire_dispatch.
7867 Add dbus_connection_set_wakeup_main_function and use it when queueing
7868 incoming and outgoing messages.
7871 * dbus/dbus-dataslot.c:
7872 Threadsafe usage of DBusDataSlotAllocator
7874 * dbus/dbus-message.c: (dbus_message_get_args_iter):
7877 * dbus/dbus-server-unix.c:
7880 * glib/dbus-gmain.c:
7881 Implement the new wakeup functions for glib.
7884 * glib/test-thread-client.c:
7885 * glib/test-thread-server.c:
7886 * glib/test-thread.h:
7887 Initial cut at some thread test code. Not really done yet.
7889 2003-02-26 Havoc Pennington <hp@pobox.com>
7891 * dbus/dbus-connection.c
7892 (dbus_connection_send_message_with_reply_and_block): fix crash
7893 where we ref'd the outgoing message instead of the returned reply
7895 * dbus/dbus-transport-unix.c (do_authentication): check read watch
7896 at the end of this function, so if we didn't need to read for
7897 authentication, we reinstall it for receiving messages
7899 * dbus/dbus-message.c (dbus_message_new_reply): allow replies to
7900 a NULL sender for peer-to-peer case
7902 * dbus/dbus-transport-unix.c (check_read_watch): handle
7903 !authenticated case correctly
7905 * glib/dbus-gmain.c: add support for DBusServer
7907 * dbus/dbus-server.c: add data slot support
7909 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): check
7910 return values and handle errors
7912 * dbus/dbus-dataslot.c: factor out the data slot stuff from
7915 * Doxyfile.in (INPUT): add glib subdir
7917 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): rename
7918 setup_with_g_main instead of hookup_with_g_main; write docs
7920 2003-02-24 Anders Carlsson <andersca@codefactory.se>
7922 * dbus/dbus-marshal.c: (_dbus_marshal_validate_arg):
7923 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
7924 * dbus/dbus-message.c: (dbus_message_append_boolean),
7925 (dbus_message_append_boolean_array),
7926 (dbus_message_get_args_valist), (_dbus_message_test):
7927 * dbus/dbus-message.h:
7928 * doc/dbus-specification.sgml:
7929 Various fixes as pointed out by Havoc.
7931 * test/data/invalid-messages/bad-boolean-array.message:
7932 * test/data/invalid-messages/bad-boolean.message:
7933 Add invalid boolean value test cases.
7935 2003-02-24 Anders Carlsson <andersca@codefactory.se>
7937 * dbus/dbus-internals.c: (_dbus_type_to_string):
7938 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
7939 (_dbus_marshal_validate_arg):
7940 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
7941 * dbus/dbus-message.c: (dbus_message_append_args_valist),
7942 (dbus_message_append_boolean), (dbus_message_append_boolean_array),
7943 (dbus_message_get_args_valist), (dbus_message_iter_get_boolean),
7944 (dbus_message_iter_get_int32), (dbus_message_iter_get_uint32),
7945 (dbus_message_iter_get_double),
7946 (dbus_message_iter_get_boolean_array), (message_iter_test):
7947 * dbus/dbus-message.h:
7948 * dbus/dbus-protocol.h:
7949 * doc/dbus-specification.sgml:
7950 * test/data/valid-messages/lots-of-arguments.message:
7951 Add support for boolean and boolean array types.
7953 2003-02-23 Havoc Pennington <hp@pobox.com>
7955 * dbus/dbus-keyring.c: finish most of this implementation and
7958 * dbus/dbus-errors.c (dbus_set_error_const, dbus_set_error): make
7959 these barf if the error isn't cleared to NULL
7961 * dbus/dbus-sysdeps.c (_dbus_delete_file): set error on failure
7962 (_dbus_create_directory): new function
7964 * dbus/dbus-errors.c (dbus_set_error): fix warning
7966 * dbus/dbus-string.c (_dbus_string_hex_encode): new function
7967 (_dbus_string_hex_decode): new function
7968 (test_hex_roundtrip): test code
7970 * dbus/dbus-sha.c (_dbus_sha_compute): use dbus_string_hex_encode
7972 * dbus/dbus-md5.c (_dbus_md5_compute): use dbus_string_hex_encode
7974 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): make this use
7975 the save-to-temp/rename trick to atomically write the new file
7976 (_dbus_string_parse_uint): new function
7978 2003-02-22 Havoc Pennington <hp@pobox.com>
7980 * test/Makefile.am (dist-hook): fix dist for test/data/sha-1
7982 2003-02-22 Havoc Pennington <hp@pobox.com>
7984 * dbus/dbus-message.c (dbus_message_iter_get_string_array):
7985 (dbus_message_iter_get_byte_array): Fix up doxygen warnings
7987 * dbus/dbus-sha.c: add implementation of SHA-1 algorithm
7989 * dbus/test/data/sha-1: add US government test suite for SHA-1
7991 2003-02-21 Anders Carlsson <andersca@codefactory.se>
7993 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
7994 Make string arrays NULL-terminated.
7996 * dbus/dbus-memory.c: (dbus_free_string_array):
7997 * dbus/dbus-memory.h:
7998 New function for freeing NULL-terminated string arrays.
8000 * dbus/dbus-message-builder.c: (append_quoted_string),
8001 (_dbus_message_data_load):
8002 Add support for array types.
8004 * dbus/dbus-message.c: (check_message_handling):
8005 Add more types as test cases.
8007 * dbus/dbus-sysdeps.c: (_dbus_string_parse_int),
8008 (_dbus_string_parse_double):
8009 Add the start offset to the end offset.
8011 * test/data/valid-messages/lots-of-arguments.message:
8012 New test message with lots of arguments.
8014 2003-02-21 Anders Carlsson <andersca@codefactory.se>
8016 * dbus/dbus-message.c: (dbus_message_append_nil),
8017 (dbus_message_append_int32), (dbus_message_append_uint32),
8018 (dbus_message_append_double), (dbus_message_append_string),
8019 (dbus_message_append_int32_array),
8020 (dbus_message_append_uint32_array),
8021 (dbus_message_append_double_array),
8022 (dbus_message_append_byte_array),
8023 (dbus_message_append_string_array):
8024 Fix all out-of-memory handling in these functions.
8026 2003-02-21 Anders Carlsson <andersca@codefactory.se>
8028 * dbus/dbus-message.c: (dbus_message_append_nil):
8031 2003-02-21 Anders Carlsson <andersca@codefactory.se>
8033 * dbus/dbus-message.c: (dbus_message_append_args_valist),
8034 (dbus_message_append_nil), (dbus_message_append_int32_array),
8035 (dbus_message_append_uint32_array),
8036 (dbus_message_append_double_array),
8037 (dbus_message_append_byte_array),
8038 (dbus_message_append_string_array), (dbus_message_get_args_valist),
8039 (dbus_message_iter_get_int32_array),
8040 (dbus_message_iter_get_uint32_array),
8041 (dbus_message_iter_get_double_array),
8042 (dbus_message_iter_get_byte_array),
8043 (dbus_message_iter_get_string_array):
8045 * dbus/dbus-message.h:
8046 Add functions for appending and getting arrays.
8048 2003-02-21 Anders Carlsson <andersca@codefactory.se>
8050 * dbus/dbus-mempool.c (_dbus_mem_pool_new): Make the
8051 element size at least 8 bytes, fixes mempool tests on
8054 2003-02-20 Alexander Larsson <alexl@redhat.com>
8056 * dbus/dbus-transport-unix.c (unix_do_iteration):
8057 Unlock the connection mutex during a blocking select call.
8058 Add todo about how we need a way to wake up the select.
8060 * dbus/dbus-connection-internal.h:
8061 * dbus/dbus-connection.c:
8062 Add _dbus_connection_lock and _dbus_connection_unlock.
8064 2003-02-19 Havoc Pennington <hp@pobox.com>
8066 * Doxyfile.in (PREDEFINED): put DOXYGEN_SHOULD_SKIP_THIS in
8067 Doxyfile.in, not Doxyfile
8069 * dbus/dbus-keyring.c: do some hacking on this
8071 * dbus/dbus-sysdeps.c (_dbus_delete_file): new
8073 * dbus/dbus-errors.c (dbus_set_error_const): do not call
8075 (dbus_set_error): remove dbus_error_init, check for message ==
8076 NULL *before* we sprintf into it, and add @todo about including
8077 system headers in this file
8079 * dbus/dbus-sysdeps.c (_dbus_create_file_exclusively): new
8081 * dbus/dbus-errors.h (DBUS_ERROR_FAILED): add
8083 * dbus/dbus-sysdeps.c (get_user_info): break this function out to
8084 get various bits of user information based on either username
8086 (_dbus_homedir_from_username): new function
8088 2003-02-19 Anders Carlsson <andersca@codefactory.se>
8091 Add check for nonposix getpwnam_r
8093 * dbus/dbus-mempool.c: (_dbus_mem_pool_new):
8094 Align the pool element size to a sizeof (void *) boundary.
8096 * dbus/dbus-sysdeps.c: (_dbus_setenv), (_dbus_connect_unix_socket),
8097 (_dbus_listen_unix_socket), (_dbus_credentials_from_username):
8098 General Solaris fixes.
8100 * test/data/valid-messages/simplest-manual.message:
8101 Explicitly state that we want little-endian packing.
8103 2003-02-19 Mikael Hallendal <micke@codefactory.se>
8105 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
8107 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_tcp_socket):
8108 Added to create a transport connecting using a tcp/ip socket.
8110 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): Added to connect
8111 to a tcp socket at given host and port.
8112 (_dbus_listen_tcp_socket): added to listen on tcp socket for given
8115 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
8117 * dbus/dbus-server-unix.c (_dbus_server_new_for_tcp_socket):
8118 Added to create a server listening on a TCP/IP socket.
8120 2003-02-19 Havoc Pennington <hp@pobox.com>
8122 Throughout: mop up all the Doxygen warnings and undocumented
8125 * dbus/dbus-sysdeps.c (do_exec): do not use execvp, we don't want
8126 to search any paths.
8128 * dbus/dbus-threads.c: move global mutex initializers to
8129 dbus-internals.h, multiple prototypes was confusing doxygen
8130 besides being kind of ugly
8132 * Doxyfile (PREDEFINED): have Doxygen define
8133 DOXYGEN_SHOULD_SKIP_THIS so we can exclude things from
8134 docs with #ifndef DOXYGEN_SHOULD_SKIP_THIS
8135 (do not abuse the feature! it's for stuff like the autogenerated
8136 macros in dbus-md5.c, not just for things you don't feel like
8139 2003-02-18 Havoc Pennington <hp@pobox.com>
8141 * dbus/dbus-string.c (_dbus_string_zero): new function
8143 * dbus/dbus-md5.c: include MD5 implementation by L. Peter Deutsch,
8144 wrap it in some dbus-friendly API
8146 * dbus/dbus-types.h: add 16-bit types
8148 2003-02-18 Joe Shaw <joe@assbarn.com>
8150 * dbus/dbus-auth.c (handle_server_data_stupid_test_mech): Just get
8151 credentials from our currently running process.
8152 (get_word): Fix a buglet where we were copying the entire length
8153 instead of relative to our position.
8155 * dbus/dbus-hash.c (_dbus_hash_test): Don't try to allocate the
8156 keys on the stack... it's 640k of data.
8158 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): Always
8159 read the credentials byte off the socket, even if we don't have
8161 (_dbus_poll): Implement poll() using select() for systems which
8164 * glib/test-dbus-glib.c (main): Print out an error if no
8165 parameters are given.
8167 * test/data/auth/fallback.auth-script: Added. Tests that a client
8168 can fallback to a secondary auth mechanism if the first fails.
8170 2003-02-18 Havoc Pennington <hp@pobox.com>
8174 2003-02-17 Havoc Pennington <hp@pobox.com>
8176 * doc/dbus-specification.sgml: lots of cosmetic
8177 cleanups/rearrangement, add assorted FIXME, change DBUS_ADDRESS
8178 env variable to DBUS_BUS_ADDRESS, s/client/application/,
8179 s/server/bus/ (except in authentication section). Add a section
8180 "Message Bus Message Routing"
8182 2003-02-17 Anders Carlsson <andersca@codefactory.se.>
8188 2003-02-17 Anders Carlsson <andersca@codefactory.se>
8190 * doc/dbus-specification.sgml:
8191 Specification updates.
8193 2003-02-17 Anders Carlsson <andersca@codefactory.se>
8195 * bus/activation.c: (bus_activation_init), (child_setup),
8196 (bus_activation_activate_service):
8198 * bus/main.c: (main):
8199 Set DBUS_ADDRESS environment variable.
8201 * dbus/dbus-errors.c: (dbus_set_error):
8202 Don't use va_copy since that's a C99 feature.
8204 * dbus/dbus-sysdeps.c: (_dbus_setenv), (do_exec),
8205 (_dbus_spawn_async):
8206 * dbus/dbus-sysdeps.h:
8207 Add child_setup_func to _dbus_spawn_async.
8209 * doc/dbus-specification.sgml:
8210 Update specification.
8212 * test/spawn-test.c: (setup_func), (main):
8215 2003-02-17 Alexander Larsson <alexl@redhat.com>
8217 * dbus/dbus-connection.c (_dbus_connection_handler_destroyed_locked):
8220 2003-02-17 Anders Carlsson <andersca@codefactory.se>
8224 * doc/dbus-test-plan.sgml:
8225 Add test plan document.
8230 2003-02-17 Anders Carlsson <andersca@codefactory.se>
8232 * dbus/dbus-message.c: (decode_header_data),
8233 (_dbus_message_loader_return_buffer):
8234 Set the header padding amount when loading a message.
8236 2003-02-16 Anders Carlsson <andersca@codefactory.se>
8238 * bus/dispatch.c: (send_one_message):
8239 Only send broadcast messages to registered connections.
8241 * dbus/dbus-message.c: (dbus_message_name_is):
8242 * dbus/dbus-message.h:
8243 New convenience function.
8245 * dbus/dbus-transport-debug.c: (do_reading):
8246 Only dispatch one message per run.
8249 * test/bus-test.c: (new_connection_callback), (die),
8250 (test_hello_client1_handler), (test_hello_client2_handler),
8251 (test_hello_replies), (main):
8253 * test/bus-test-loop.[ch]:
8256 2003-02-16 Havoc Pennington <hp@pobox.com>
8258 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
8259 backward conditional
8261 2003-02-16 Alexander Larsson <alexl@redhat.com>
8263 * dbus/dbus-connection.c:
8264 Implement sent_message_with_reply. (with_reply_and block is still
8266 Made dispatch_message not lose message if OOM.
8268 * dbus/dbus-errors.h:
8269 Add NoReply error (for reply timeouts).
8271 2003-02-16 Alexander Larsson <alexl@redhat.com>
8273 * dbus/dbus-hash.c (_dbus_hash_table_unref):
8274 Actually free keys and values when destroying hashtable.
8276 2003-02-16 Anders Carlsson <andersca@codefactory.se>
8278 * dbus/dbus-auth.c: (client_try_next_mechanism):
8281 * dbus/dbus-threads.c: (dbus_condvar_wait_timeout):
8282 Return TRUE if there's no thread implementation around.
8284 * glib/dbus-gmain.c: (free_source),
8285 (dbus_connection_hookup_with_g_main):
8286 Make sure to remove the GSource when the connection is finalized.
8288 2003-02-16 Anders Carlsson <andersca@codefactory.se>
8290 * bus/dispatch.c: (bus_dispatch_message_handler):
8291 * dbus/dbus-errors.h:
8292 Return an error if someone tries to send a message to a service
8295 2003-02-16 Anders Carlsson <andersca@codefactory.se>
8297 * bus/activation.c: (load_directory), (bus_activation_init),
8298 (bus_activation_activate_service):
8301 (bus_driver_handle_activate_service), (bus_driver_handle_message):
8302 More work on the activation handling.
8304 * dbus/dbus-errors.h:
8305 Add some error messages
8307 * dbus/dbus-message.c: (dbus_message_new_error_reply):
8308 * dbus/dbus-message.h:
8309 New function that creates an error message.
8311 * dbus/dbus-protocol.h:
8312 Add ACTIVATE_SERVER message.
8314 * dbus/dbus-server-unix.c: (unix_handle_watch),
8315 (_dbus_server_new_for_domain_socket):
8316 Call _dbus_fd_set_close_on_exec.
8318 * dbus/dbus-sysdeps.c: (make_pipe), (do_exec),
8319 (_dbus_spawn_async), (_dbus_disable_sigpipe),
8320 (_dbus_fd_set_close_on_exec):
8321 * dbus/dbus-sysdeps.h:
8322 Add _dbus_fd_set_close_on exec function. Also add function that checks
8323 that all open fds are set to close-on-exec and warns otherwise.
8325 * dbus/dbus-transport-unix.c:
8326 (_dbus_transport_new_for_domain_socket):
8327 Call _dbus_fd_set_close_on_exec.
8329 2003-02-16 Havoc Pennington <hp@pobox.com>
8331 * dbus/dbus-connection.c (dbus_connection_set_change_sigpipe):
8332 allow people to avoid setting SIGPIPE to SIG_IGN
8333 (_dbus_connection_new_for_transport): disable SIGPIPE unless
8334 we've been asked not to
8336 2003-02-15 Anders Carlsson <andersca@codefactory.se>
8338 * dbus/dbus-list.c: (_dbus_list_append_link),
8339 (_dbus_list_prepend_link):
8340 * dbus/dbus-memory.c: (dbus_malloc), (dbus_malloc0),
8344 2003-02-15 Anders Carlsson <andersca@codefactory.se>
8347 * bus/activation.c: (bus_activation_entry_free),
8348 (add_desktop_file_entry), (load_directory), (bus_activation_init):
8350 * bus/main.c: (main):
8351 Add simple activation support, doesn't work yet though.
8353 2003-02-15 Zack Rusin <zack@kde.org>
8355 * qt/dbus-qthread.cpp: small casting fix
8357 2003-02-15 Anders Carlsson <andersca@codefactory.se>
8359 * dbus/dbus-errors.c: (dbus_set_error):
8360 * dbus/dbus-errors.h:
8361 Add a few errors and make dbus_set_error void.
8363 * dbus/dbus-sysdeps.c:
8364 (_dbus_errno_to_string), (close_and_invalidate), (make_pipe),
8365 (write_err_and_exit), (read_ints), (do_exec), (_dbus_spawn_async):
8366 * dbus/dbus-sysdeps.h:
8367 Add _dbus_spawn_async.
8369 * test/spawn-test.c: (main):
8370 Test for _dbus_spawn_async.
8372 2003-02-15 Anders Carlsson <andersca@codefactory.se>
8374 * dbus/dbus-internals.h:
8375 Fix build without tests.
8377 * dbus/dbus-list.c: (alloc_link):
8378 Fix a segfault when a malloc fails.
8380 * dbus/dbus-memory.c: (initialize_malloc_debug), (dbus_malloc),
8381 (dbus_malloc0), (dbus_realloc):
8382 Add support for malloc debugging.
8384 2003-02-15 Alexander Larsson <alexl@redhat.com>
8386 * dbus/dbus-threads.c:
8387 * dbus/dbus-threads.h:
8388 Add condvars. Remove static mutext from API.
8389 Implement static mutexes by initializing them from threads_init.
8391 * glib/dbus-gthread.c:
8392 * qt/dbus-qthread.cpp:
8393 Update with the thread api changes.
8398 Turn StaticMutex into normal mutex + init function.
8399 Export new functions _dbus_list_alloc_link, _dbus_list_free_link,
8400 _dbus_list_append_link, _dbus_list_prepend_link
8403 * dbus/dbus-sysdeps.c:
8404 * dbus/dbus-sysdeps.h:
8405 New type dbus_atomic_t, and new functions _dbus_atomic_inc,
8406 _dbus_atomic_dec. Only slow fallback implementation at the moment.
8408 * dbus/dbus-protocol.h:
8409 Add DBUS_MESSAGE_LOCAL_DISCONNECT define
8411 * dbus/dbus-message.c:
8412 Make ref/unref atomic.
8415 * dbus/dbus-connection-internal.h:
8416 * dbus/dbus-connection.c:
8417 * dbus/dbus-connection.h:
8419 Change _peek to _borrow,_return & _steal_borrowed.
8420 Change disconnect callback to event.
8421 Make dbus_connection_dispatch_messages reentrant.
8423 * dbus/dbus-transport.c:
8424 Don't ref the connection on calls to the transport
8427 * dbus/dbus-message-handler.c:
8430 * glib/dbus-gmain.c:
8431 Don't use peek_message anymore
8434 * test/debug-thread.c:
8435 * test/debug-thread.h:
8436 Simple thread implementation that asserts() on deadlocks in
8437 single-threaded code.
8440 (main) Call debug_threads_init.
8443 Use disconnect message instead of disconnect callback.
8447 Don't call dbus_connection_set_disconnect_function. Instead export
8448 bus_connection_disconnect.
8451 Call bus_connection_disconnect when we get a disconnected message.
8453 2003-02-15 Havoc Pennington <hp@pobox.com>
8455 * dbus/dbus-message.c (dbus_message_new): fool around with the
8458 2003-02-14 Havoc Pennington <hp@pobox.com>
8460 * dbus/dbus-mempool.c: fail if the debug functions so indicate
8462 * dbus/dbus-memory.c: fail if the debug functions indicate we
8465 * dbus/dbus-internals.c (_dbus_set_fail_alloc_counter)
8466 (_dbus_decrement_fail_alloc_counter): debug functions to
8467 simulate memory allocation failures
8469 2003-02-14 Havoc Pennington <hp@pobox.com>
8471 * dbus/dbus-errors.h (struct DBusError): add a word of padding
8474 2003-02-13 Anders Carlsson <andersca@codefactory.se>
8476 * bus/driver.c: (bus_driver_handle_hello):
8478 * bus/services.c: (bus_service_lookup):
8479 Reorder message sending so we get a more sane order.
8481 * test/bus-test.c: (message_handler):
8484 2003-02-13 Anders Carlsson <andersca@codefactory.se>
8486 * bus/driver.c: (bus_driver_send_service_deleted),
8487 (bus_driver_send_service_created), (bus_driver_send_service_lost),
8488 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
8489 (bus_driver_send_welcome_message),
8490 (bus_driver_handle_list_services),
8491 (bus_driver_handle_acquire_service),
8492 (bus_driver_handle_service_exists):
8493 * dbus/dbus-bus.c: (dbus_bus_register_client),
8494 (dbus_bus_acquire_service), (dbus_bus_service_exists):
8495 * dbus/dbus-errors.c: (dbus_result_to_string):
8496 * dbus/dbus-errors.h:
8497 * dbus/dbus-message.c: (dbus_message_append_args),
8498 (dbus_message_append_args_valist), (dbus_message_get_args),
8499 (dbus_message_get_args_valist), (dbus_message_get_args_iter),
8500 (dbus_message_iter_get_arg_type), (dbus_message_iter_get_string),
8501 (dbus_message_iter_get_byte_array),
8502 (dbus_message_iter_get_string_array), (message_iter_test),
8503 (check_message_handling), (_dbus_message_test):
8504 * dbus/dbus-message.h:
8505 * test/bus-test.c: (main):
8506 Change fields to arguments in messages, so that they won't be
8507 confused with header fields.
8509 * glib/test-dbus-glib.c: (main):
8510 Remove append_fields from hello message.
8512 2003-02-13 Anders Carlsson <andersca@codefactory.se>
8514 * dbus/dbus-errors.c:
8515 * dbus/dbus-message.c:
8516 * dbus/dbus-string.c:
8517 Documentation fixes.
8519 2003-02-13 Anders Carlsson <andersca@codefactory.se>
8521 * glib/dbus-gmain.c: (timeout_handler), (add_timeout),
8523 Implement support for timeouts in dbus-glib.
8525 2003-02-13 Anders Carlsson <andersca@codefactory.se>
8527 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
8528 * dbus/dbus-message.c: (process_test_subdir):
8529 * test/break-loader.c: (find_breaks_based_on):
8530 Plug some memory leaks.
8532 2003-02-13 Richard Hult <rhult@codefactory.se>
8534 * bus/main.c: Fix build.
8536 * dbus/dbus-errors.h:
8537 * dbus/dbus-errors.c: Fix copyright for Anders.
8539 2003-02-13 Anders Carlsson <andersca@codefactory.se>
8544 * bus/connection.c: (bus_connection_foreach):
8547 * bus/desktop-file.c: (grow_lines_in_section), (grow_sections),
8548 (unescape_string), (new_section), (parse_section_start),
8549 (parse_key_value), (report_error), (bus_desktop_file_load),
8550 (bus_desktop_file_get_string):
8551 * bus/desktop-file.h:
8552 Use DBusError for error reporting.
8554 * bus/dispatch.c: (send_one_message),
8555 (bus_dispatch_message_handler):
8556 * bus/driver.c: (bus_driver_send_service_deleted),
8557 (bus_driver_send_service_created), (bus_driver_send_service_lost),
8558 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
8559 (bus_driver_send_welcome_message),
8560 (bus_driver_handle_list_services),
8561 (bus_driver_handle_acquire_service),
8562 (bus_driver_handle_service_exists):
8563 * bus/loop.c: (bus_loop_run):
8565 Use BUS_HANDLE_OOM instead of _DBUS_HANDLE_OOM.
8567 * bus/utils.c: (bus_wait_for_memory):
8569 New files with general utility functions.
8571 * dbus/dbus-internals.h:
8572 Remove _DBUS_HANDLE_OOM.
8574 2003-02-13 Anders Carlsson <andersca@codefactory.se>
8576 * dbus/dbus-errors.c: (dbus_result_to_string), (dbus_error_init),
8577 (dbus_error_free), (dbus_set_error_const), (dbus_set_error):
8578 * dbus/dbus-errors.h:
8579 Add DBusError structure.
8581 2003-02-13 Anders Carlsson <andersca@codefactory.se>
8583 * test/data/valid-messages/standard-acquire-service.message:
8584 * test/data/valid-messages/standard-hello.message:
8585 * test/data/valid-messages/standard-list-services.message:
8586 * test/data/valid-messages/standard-service-exists.message:
8587 Add some standard messages.
8589 2003-02-13 Anders Carlsson <andersca@codefactory.se>
8591 * bus/driver.c: (bus_driver_send_welcome_message),
8592 (bus_driver_handle_list_services),
8593 (bus_driver_handle_acquire_service),
8594 (bus_driver_handle_service_exists), (bus_driver_handle_message):
8595 Update for API changes in libdbus.
8597 * dbus/dbus-message.c: (dbus_message_new_reply):
8598 * dbus/dbus-message.h:
8599 Remove the name argument. The spec states that replies shouldn't
8602 2003-02-13 Anders Carlsson <andersca@codefactory.se>
8604 * bus/desktop-file.c: (parse_section_start), (parse_key_value),
8605 (report_error), (bus_desktop_file_load), (lookup_section),
8606 (lookup_line), (bus_desktop_file_get_raw),
8607 (bus_desktop_file_get_string):
8608 * bus/desktop-file.h:
8609 Some fixes, and new functions for getting a key value from a section.
8611 2003-02-13 Havoc Pennington <hp@pobox.com>
8613 * test/data/auth/fail-after-n-attempts.auth-script: new test
8615 * dbus/dbus-auth.c (send_rejected): shutdown_mech() when we
8618 2003-02-13 Havoc Pennington <hp@pobox.com>
8620 * dbus/dbus-auth.c (handle_server_data_external_mech): args to
8621 dbus_credentials_match were backward
8623 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support
8624 NO_CREDENTIALS and ROOT_CREDENTIALS
8626 * dbus/dbus-auth.c (_dbus_auth_do_work): move get_state() routine
8627 into here. Never process more commands after we've reached an
8628 end state; store further data as unused bytes.
8630 * test/data/auth/*: add more auth tests
8632 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support EXPECT
8633 command to match exact string and EXPECT_UNUSED to match unused
8636 * test/Makefile.am (dist-hook): fix to dist all the test stuff
8638 2003-02-12 Havoc Pennington <hp@pobox.com>
8640 * dbus/dbus-string.c (_dbus_string_pop_line): fix to also strip
8641 \r off of popped lines
8643 * dbus/dbus-auth.c (_dbus_auth_test): write code to run auth
8646 * dbus/dbus-auth-script.c (_dbus_auth_script_run): when doing a
8649 2003-02-12 Havoc Pennington <hp@pobox.com>
8651 * dbus/Makefile.am: remove break-loader from the build, since it
8654 * configure.in: add --enable-gcov to turn on coverage profiling
8655 flags and disable optimization
8657 2003-02-10 Havoc Pennington <hp@pobox.com>
8659 * dbus/dbus-auth-script.c, dbus/dbus-auth-script.h: sync
8660 initial cut at test framework for DBusAuth from laptop.
8661 Doesn't quite work yet but it compiles and I need to get
8662 it off the 266mhz laptop. ;-)
8664 * dbus/dbus-server-debug.c (_dbus_server_debug_accept_transport):
8665 fix a memleak in error case
8667 2003-02-12 Anders Carlsson <andersca@codefactory.se>
8670 * bus/desktop-file.c:
8671 * bus/desktop-file.h:
8672 Add a desktop file parser.
8674 2003-02-11 Zack Rusin <zack@kde.org>
8676 * qt/message.[h|cpp]: sample implementation
8677 of the KDE wrapper for DBusMessage
8679 2003-02-09 Zack Rusin <zack@kde.org>
8681 * test/bus-test.c: make_it_compile
8682 * doc/dbus-specification.sgml: minimal semantic fix
8684 2003-02-06 Anders Carlsson <andersca@codefactory.se>
8690 2003-02-06 Anders Carlsson <andersca@codefactory.se>
8693 * dbus/dbus-break-loader.c:
8695 * test/break-loader.c:
8696 Move dbus-break-loader to test/ and rename it to break-loader.
8698 2003-02-02 Havoc Pennington <hp@pobox.com>
8700 * dbus/dbus-keyring.c, dbus/dbus-keyring.h: template files
8701 for code to manage cookies in your home directory
8703 * dbus/dbus-sysdeps.c (_dbus_generate_random_bytes): new function
8705 * dbus/dbus-auth.c (get_state): impose a maximum number of tries
8706 to authenticate, then disconnect the client.
8708 2003-02-03 Alexander Larsson <alexl@redhat.com>
8710 * dbus/dbus-message.c (dbus_message_append_fields):
8713 2003-02-02 Anders Carlsson <andersca@codefactory.se>
8715 * doc/dbus-specification.sgml:
8716 Update address format section.
8718 2003-02-02 Anders Carlsson <andersca@codefactory.se>
8721 * test/bus-test.c: (get_time), (add_timeout), (remove_timeout),
8722 (message_handler), (new_connection_callback), (loop_quit),
8726 2003-02-02 Anders Carlsson <andersca@codefactory.se>
8728 * bus/driver.c: (bus_driver_handle_service_exists):
8729 Simplify the code a bit.
8731 * dbus/dbus-bus.c: (dbus_bus_service_exists):
8734 2003-02-02 Anders Carlsson <andersca@codefactory.se>
8737 Add libdbus-daemon.la and link to it.
8739 2003-02-01 James Willcox <jwillcox@gnome.org>
8741 * bus/driver.c: (bus_driver_handle_own_service):
8742 Actually include the service reply code in the message.
8744 2003-02-02 Anders Carlsson <andersca@codefactory.se>
8746 * bus/driver.c: (bus_driver_handle_service_exists):
8747 Don't unref the incoming message.
8749 2003-02-02 Anders Carlsson <andersca@codefactory.se>
8751 * dbus/dbus.h: Add dbus-address.h and dbus-bus.h
8753 2003-02-02 Anders Carlsson <andersca@codefactory.se>
8755 * dbus/dbus-server.c: (dbus_server_listen):
8756 * dbus/dbus-transport.c: (_dbus_transport_open):
8757 ifdef out the calls to the debug transport and server.
8759 2003-02-02 Alexander Larsson <alexl@redhat.com>
8761 * dbus/dbus-watch.c (dbus_watch_get_flags):
8762 Add note in the docs that ERROR or HANGUP won't be returned
8763 and are assumed always on.
8765 * glib/dbus-gmain.c (add_watch):
8766 Always add IO_ERR | IO_HUP
8768 * dbus/dbus-message.h:
8769 Add semicolon after dbus_message_iter_get_string_array().
8770 Makes qt code build again
8772 2003-02-01 Anders Carlsson <andersca@codefactory.se>
8774 * bus/driver.c: (create_unique_client_name),
8775 (bus_driver_handle_hello):
8776 Don't take a name, just use a numeric id to identify
8780 * dbus/dbus-bus.c: (dbus_bus_register_client),
8781 (dbus_bus_acquire_service), (dbus_bus_service_exists):
8783 Add new convenience functions for communicating with the bus.
8785 * dbus/dbus-message.h:
8787 * dbus/dbus-protocol.h:
8790 2003-02-01 Alexander Larsson <alexl@redhat.com>
8792 * dbus/dbus-message.c (dbus_message_append_fields):
8793 Add some more doc comments.
8795 2003-02-01 Havoc Pennington <hp@pobox.com>
8797 * dbus/dbus-break-loader.c (randomly_modify_length): change
8798 a 4-byte value in the message as if it were a length
8800 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): don't set
8801 execute bit on saved files
8803 2003-02-01 Havoc Pennington <hp@pobox.com>
8805 * dbus/dbus-break-loader.c (main): new program to find messages
8806 that break the loader.
8808 * dbus/dbus-sysdeps.c (_dbus_string_append_uint): new function
8809 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): new function
8811 * dbus/dbus-string.c (_dbus_string_set_byte): new
8813 2003-01-31 Havoc Pennington <hp@pobox.com>
8815 * dbus/dbus-message.c: refactor the test code to be more general,
8816 in preparation for writing a "randomly permute test cases to
8817 try to break the loader" program.
8819 2003-01-31 Havoc Pennington <hp@pobox.com>
8821 * doc/dbus-specification.sgml: work on the specification
8823 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): check
8824 the protocol version of the message.
8826 * dbus/dbus-protocol.h: drop special _REPLY names, the spec
8827 no longer specifies that.
8828 (DBUS_SERVICE_REPLY_SERVICE_EXISTS): fix flags (1/2/4/8 not
8831 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos): add missing
8832 "break" for DBUS_TYPE_NIL, remove @todo
8834 2003-01-31 Havoc Pennington <hp@pobox.com>
8836 * dbus/dbus-message.c (dbus_message_set_is_error_reply): rename
8837 just set_is_error/get_is_error as this is a commonly-used
8838 function, and write docs.
8840 2003-01-31 Anders Carlsson <andersca@codefactory.se>
8842 * dbus/dbus-address.c: (dbus_address_entry_free):
8843 Free key and value lists.
8845 * dbus/dbus-internals.c: (_dbus_type_to_string):
8846 Add the types we didn't have.
8848 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
8849 (_dbus_marshal_validate_arg):
8852 * dbus/dbus-message.c: (dbus_message_set_sender):
8853 Remove todo about being able to set sender to NULL.
8855 (dbus_message_set_is_error_reply),
8856 (dbus_message_get_is_error_reply):
8857 * dbus/dbus-message.h:
8860 * dbus/dbus-protocol.h:
8861 Add error reply flag.
8863 * test/data/valid-messages/opposite-endian.message:
8864 Add NIL type to test.
8866 2003-01-31 Havoc Pennington <hp@pobox.com>
8868 * doc/dbus-specification.sgml: fully specify the header. Add
8869 flags and major protocol version, and change header/body len to
8872 * dbus/dbus-message-builder.c (append_saved_length): append length
8875 * dbus/dbus-message.c (dbus_message_create_header): change header
8876 length and body length to unsigned. Add the new fields from the
8878 (_dbus_message_loader_return_buffer): unsigned header/body len
8880 2003-01-30 Havoc Pennington <hp@pobox.com>
8882 * dbus/dbus-auth.c: rework to use only REJECTED, no
8885 * doc/dbus-sasl-profile.txt: drop MECHANISMS and just
8886 use REJECTED, suggested by Mark McLoughlin
8888 2003-01-30 Havoc Pennington <hp@pobox.com>
8890 * dbus/dbus-server.c (dbus_server_listen): @todo about how we need
8891 a better way to report errors here. e.g. "unix address lacks
8892 path" or something. also "no such file" when the path doesn't
8895 * dbus/dbus-address.c (dbus_address_entries_free): add @todo about
8897 (dbus_parse_address): add @todo about documenting address format,
8898 and allowing , and ; to be escaped
8900 2003-01-30 Anders Carlsson <andersca@codefactory.se>
8903 Add dbus-address.[ch]
8905 * dbus/dbus-address.c: (dbus_address_entry_free),
8906 (dbus_address_entries_free), (create_entry),
8907 (dbus_address_entry_get_method), (dbus_address_entry_get_value),
8908 (dbus_parse_address), (_dbus_address_test):
8909 * dbus/dbus-address.h:
8910 New files for dealing with address parsing.
8912 * dbus/dbus-connection.c:
8913 Document timeout functions.
8915 * dbus/dbus-message.c:
8916 Document dbus_message_new_from_message.
8918 * dbus/dbus-server-debug.c:
8921 * dbus/dbus-server.c: (dbus_server_listen):
8922 Parse address and use correct server implementation.
8924 * dbus/dbus-string.c: (_dbus_string_find_to), (_dbus_string_test):
8925 * dbus/dbus-string.h:
8926 New function with test.
8928 * dbus/dbus-test.c: (dbus_internal_symbol_do_not_use_run_tests):
8932 * dbus/dbus-transport-debug.c:
8935 * dbus/dbus-transport.c: (_dbus_transport_open):
8936 Parse address and use correct transport implementation.
8938 2003-01-30 Havoc Pennington <hp@pobox.com>
8940 * dbus/dbus-message.c: use message->byte_order instead of
8941 DBUS_COMPILER_BYTE_ORDER throughout.
8942 (dbus_message_create_header): pad header to align the
8943 start of the body of the message to 8-byte boundary
8945 * dbus/dbus-marshal.h: make all the demarshalers take const
8946 DBusString arguments.
8948 * dbus/dbus-message.c (_dbus_message_loader_return_buffer):
8949 validate message args here, so we don't have to do slow validation
8950 later, and so we catch bad messages as they are incoming. Also add
8951 better checks on header_len and body_len. Also fill in
8954 * dbus/dbus-string.c (_dbus_string_validate_utf8): new (not
8955 implemented properly)
8956 (_dbus_string_validate_nul): new function to check all-nul
8958 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): rename
8959 get_arg_end_pos and remove all validation
8960 (_dbus_marshal_validate_arg): actually do validation here.
8962 2003-01-29 Havoc Pennington <hp@pobox.com>
8964 * dbus/dbus-message.c (check_message_handling): fix assertion
8965 failure on set_client_serial
8967 2003-01-28 Havoc Pennington <hp@pobox.com>
8969 * dbus/dbus-server-debug.c: Add doc section comments
8971 * dbus/dbus-transport-debug.c: add doc section comments
8973 2003-01-28 Havoc Pennington <hp@redhat.com>
8975 * dbus/dbus-string.c (_dbus_string_base64_decode): append bytes in
8976 the reverse order from how I had it
8977 (_dbus_string_base64_encode): reverse encoding order. I was
8978 basically byteswapping everything during encoding.
8980 2003-01-28 Anders Carlsson <andersca@codefactory.se>
8982 * dbus/dbus-connection-internal.h:
8983 * dbus/dbus-connection.c: (_dbus_connection_add_timeout),
8984 (_dbus_connection_remove_timeout):
8985 Add functions for adding and removing timeouts.
8987 * dbus/dbus-message.c: (dbus_message_new_from_message):
8988 Add new function that takes a message and creates an exact
8989 copy of it, but with the refcount set to 1.
8990 (check_message_handling):
8993 * dbus/dbus-server-protected.h:
8994 * dbus/dbus-server.c: (_dbus_server_init_base),
8995 (_dbus_server_finalize_base), (_dbus_server_add_timeout),
8996 (dbus_server_set_timeout_functions):
8997 (_dbus_server_remove_timeout):
8998 New functions so that a server can add and remove timeouts.
9000 (dbus_server_listen):
9001 Add commented out call to dbus_server_debug_new.
9003 * dbus/dbus-timeout.c: (_dbus_timeout_new):
9004 Actually set the handler, doh.
9006 * dbus/dbus-transport.c: (_dbus_transport_open):
9007 Add commented out call to dbus_transport_debug_client_new.
9010 Add dbus-transport-debug.[ch] and dbus-server-debug.[ch]
9012 2003-01-28 Havoc Pennington <hp@pobox.com>
9014 * dbus/dbus-message.c (check_message_handling): function to check
9015 on the loaded message, iterates over it etc.
9017 2003-01-28 Havoc Pennington <hp@pobox.com>
9019 * test/Makefile.am (dist-hook): fix make distdir
9021 * dbus/Makefile.am (TESTS_ENVIRONMENT): fix make check
9023 2003-01-27 Havoc Pennington <hp@pobox.com>
9025 * dbus/dbus-mempool.c (time_for_size): replace printf with
9028 * dbus/dbus-message-builder.c (_dbus_message_data_load): allow
9029 empty lines; fix the SAVE_LENGTH stuff to be
9030 START_LENGTH/END_LENGTH so it actually works; couple other
9033 * test/Makefile.am (dist-hook): add dist-hook for .message files
9035 * dbus/dbus-string.c (DBUS_STRING_COPY_PREAMBLE): source of a copy
9036 can be constant or locked.
9037 (_dbus_string_free): allow freeing a const string as
9040 * dbus/dbus-sysdeps.c (_dbus_concat_dir_and_file): utility
9042 * dbus/dbus-test-main.c (main): take an argument which is the
9043 directory containing test data
9045 * dbus/dbus-message.c (_dbus_message_test): pass a test_data_dir
9046 argument to this and load all the messages in test/data/
9047 checking that they can be loaded or not loaded as appropriate.
9049 2003-01-27 Anders Carlsson <andersca@codefactory.se>
9051 * bus/dispatch.c: (bus_dispatch_message_handler):
9052 Dispatch messages sent to services.
9054 * bus/driver.c: (bus_driver_send_service_deleted),
9055 (bus_driver_send_service_created), (bus_driver_send_service_lost),
9056 (bus_driver_send_service_acquired):
9057 Add helper functions for sending service related messages.
9059 (bus_driver_send_welcome_message):
9060 Send HELLO_REPLY instead of WELCOME.
9062 (bus_driver_handle_list_services):
9063 Send LIST_SERVICES_REPLY instead of SERVICES.
9065 (bus_driver_handle_own_service),
9066 (bus_driver_handle_service_exists):
9067 New message handlers.
9069 (bus_driver_handle_message):
9070 Invoke new message handlers.
9072 (bus_driver_remove_connection):
9073 Don't remove any services here since that's done automatically
9074 by bus_service_remove_owner now.
9077 New function signatures.
9079 * bus/services.c: (bus_service_add_owner):
9080 Send ServiceAcquired message if we're the only primary owner.
9082 (bus_service_remove_owner):
9083 Send ServiceAcquired/ServiceLost messages.
9085 (bus_service_set_prohibit_replacement),
9086 (bus_service_get_prohibit_replacement):
9087 Functions for setting prohibit replacement.
9089 (bus_service_has_owner):
9090 New function that checks if a connection is in the owner queue of
9094 Add new function signatures.
9096 * dbus/dbus-list.c: (_dbus_list_test):
9097 Add tests for _dbus_list_remove_last and traversing the list backwards.
9100 Fix a typo in _dbus_list_get_prev_link, if we're at the first element we can't
9101 go any further, so return NULL then.
9103 * dbus/dbus-protocol.h:
9104 Add new messages, service flags and service replies.
9106 2003-01-26 Havoc Pennington <hp@pobox.com>
9108 * dbus/dbus-message-builder.c: implement, completely untested.
9110 * test/data/*: add data to be used in testing.
9111 ".message" files are our simple loadable text format.
9112 ".message-raw" will be binary dumps of messages.
9114 * dbus/dbus-string.c (_dbus_string_starts_with_c_str): new
9116 2003-01-26 Havoc Pennington <hp@pobox.com>
9118 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): new function
9120 * dbus/dbus-errors.c (dbus_result_to_string): add
9123 * dbus/dbus-message-builder.c: new file, will contain code to load
9124 up messages from files. Not implemented yet.
9126 2003-01-26 Havoc Pennington <hp@pobox.com>
9128 * dbus/dbus-message.c (dbus_message_set_sender): support deleting
9129 the sender by setting to NULL
9131 2003-01-26 Havoc Pennington <hp@pobox.com>
9133 The unit tests pass, but otherwise untested. If it breaks, the
9134 tests should have been better. ;-)
9136 * bus/driver.c (bus_driver_handle_hello): return if we disconnect
9139 * dbus/dbus-message.c: redo everything so we maintain
9140 message->header as the only copy of the various fields.
9141 This avoids the possibility of out-of-memory in some cases,
9142 for example dbus_message_lock() can't run out of memory anymore,
9143 and avoids extra copying. Figured I may as well go ahead and do
9144 this since it was busted for dbus_message_lock to not return
9145 failure on OOM, and dbus_message_write_header was totally
9146 unchecked for OOM. Also fixed some random other bugs.
9148 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): verify
9149 that strings are nul-terminated. Also, end_pos can be equal
9150 to string length just not greater than, I think.
9151 (_dbus_marshal_set_int32): new function
9152 (_dbus_marshal_set_uint32): new function
9153 (_dbus_marshal_set_string): new function
9155 * dbus/dbus-connection.c (_dbus_connection_new_for_transport): fix
9156 a warning, init timeout_list to NULL
9157 (dbus_connection_send_message): don't use uninitialized variable
9160 * dbus/dbus-string.c (_dbus_string_replace_len): new function
9162 2003-01-26 Anders Carlsson <andersca@codefactory.se>
9164 * bus/driver.c: (bus_driver_handle_hello),
9165 (bus_driver_send_welcome_message):
9168 2003-01-26 Anders Carlsson <andersca@codefactory.se>
9170 * dbus/dbus-auth.c: (process_auth), (_dbus_auth_unref):
9171 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
9172 (dbus_connection_unref):
9173 * dbus/dbus-marshal.c: (_dbus_marshal_test):
9174 * dbus/dbus-message.c: (dbus_message_unref),
9177 (dbus_message_get_fields):
9178 Remove debugging printout.
9180 (_dbus_message_loader_return_buffer):
9181 Don't store the header string.
9183 (_dbus_message_test):
9186 2003-01-26 Richard Hult <rhult@codefactory.se>
9188 * glib/dbus-gmain.c (dbus_connection_dispatch): Traverse a copy of
9189 the file descriptor list, since it can change under us.
9191 2003-01-25 Anders Carlsson <andersca@codefactory.se>
9193 * glib/dbus-gmain.c: (dbus_connection_prepare),
9194 (dbus_connection_check), (dbus_connection_dispatch), (add_watch),
9195 (remove_watch), (dbus_connection_hookup_with_g_main):
9196 Rewrite the glib handling to use its own GSource instead of a
9197 GIOChannel so we can catch messages put in the queue while waiting
9200 2003-01-25 Anders Carlsson <andersca@codefactory.se>
9203 * bus/connection.c: (connection_disconnect_handler),
9204 (connection_watch_callback), (bus_connection_setup):
9205 * bus/dispatch.c: (send_one_message),
9206 (bus_dispatch_broadcast_message), (bus_dispatch_message_handler),
9207 (bus_dispatch_add_connection), (bus_dispatch_remove_connection):
9209 * bus/driver.c: (bus_driver_send_service_deleted),
9210 (bus_driver_send_service_created), (bus_driver_handle_hello),
9211 (bus_driver_send_welcome_message),
9212 (bus_driver_handle_list_services), (bus_driver_remove_connection),
9213 (bus_driver_handle_message):
9215 Refactor code, put the message dispatching in its own file. Use
9216 _DBUS_HANDLE_OOM. Also send ServiceDeleted messages when a client
9219 2003-01-25 Anders Carlsson <andersca@codefactory.se>
9221 * dbus/dbus-internals.h:
9222 Add _DBUS_HANDLE_OOM macro, it doesn't do anything currently.
9224 * dbus/dbus-message.c: (dbus_message_get_sender):
9225 * dbus/dbus-message.h:
9226 Implement dbus_message_get_sender.
9228 * dbus/dbus-protocol.h:
9229 Add message and service defines.
9231 2003-01-25 Anders Carlsson <andersca@codefactory.se>
9233 * dbus/dbus-connection.c: (dbus_connection_send_message):
9234 * dbus/dbus-message-internal.h:
9235 * dbus/dbus-message.c: (_dbus_message_get_client_serial),
9236 (dbus_message_write_header):
9237 Remove _dbus_messag_unlock and don't set the client serial on a
9238 message if one already exists.
9240 2003-01-24 Havoc Pennington <hp@pobox.com>
9242 * dbus/dbus-list.c (alloc_link): put a thread lock on the global
9245 * bus/driver.c (bus_driver_handle_list_services): fix a leak
9248 2003-01-25 Anders Carlsson <andersca@codefactory.se>
9250 * dbus/dbus-list.c: (alloc_link), (free_link):
9251 Use a memory pool for the links.
9253 2003-01-25 Anders Carlsson <andersca@codefactory.se>
9255 * bus/connection.c: (bus_connection_foreach):
9257 Add new bus_connection_foreach function.
9259 * bus/driver.c: (send_one_message), (bus_driver_broadcast_message):
9260 Add function that broadcasts a message to all clients.
9262 (bus_driver_send_service_created), (bus_driver_handle_hello),
9263 (bus_driver_send_welcome_message),
9264 (bus_driver_handle_list_services), (bus_driver_message_handler):
9265 Implement functions that take care of listing services, and notifying
9266 clients when new services are created.
9268 * bus/services.c: (bus_services_list):
9270 Add new function that returns an array of strings with the currently
9271 registered services.
9274 * glib/dbus-gmain.c:
9275 Update copyright year.
9277 2003-01-25 Anders Carlsson <andersca@codefactory.se>
9279 * dbus/dbus-connection.c: (dbus_connection_send_message):
9280 Unlock the message in case it was sent earlier.
9282 (dbus_connection_send_message_with_reply_and_block):
9283 Remove the reply message from the list.
9285 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
9286 Set array_len and new_pos correctly.
9288 (_dbus_marshal_test):
9289 Remove debug output.
9291 * dbus/dbus-message-internal.h:
9292 * dbus/dbus-message.c: (_dbus_message_get_reply_serial):
9293 New function that returns the reply serial.
9295 (_dbus_message_unlock):
9296 New function that unlocks a message and resets its header.
9298 (dbus_message_append_string_array),
9299 (dbus_message_get_fields_valist),
9300 (dbus_message_iter_get_field_type),
9301 (dbus_message_iter_get_string_array),
9302 (dbus_message_get_fields),
9303 (dbus_message_append_fields_valist):
9304 Handle string arrays.
9306 (dbus_message_set_sender):
9307 Make this function public since the bus daemon needs it.
9309 (decode_header_data):
9310 Set the reply serial to -1 initially.
9312 * dbus/dbus-message.h:
9313 Add dbus_message_set_sender.
9315 2003-01-24 Havoc Pennington <hp@pobox.com>
9317 * doc/dbus-specification.sgml: add some stuff
9319 2003-01-22 Havoc Pennington <hp@pobox.com>
9321 * doc/dbus-specification.sgml: Start to document the protocol.
9323 2003-01-22 Havoc Pennington <hp@pobox.com>
9325 * dbus/dbus-connection.c
9326 (dbus_connection_send_message_with_reply_and_block): add some @todo
9328 * bus/driver.c (bus_driver_add_connection): add a FIXME about memleak
9330 2003-01-21 Havoc Pennington <hp@pobox.com>
9332 (patch untested because can't compile)
9334 * bus/driver.c (create_unique_client_name): make this function
9335 never recycle client names. Also, caller should initialize
9338 * dbus/dbus-sysdeps.c (_dbus_get_current_time): new function
9340 2003-01-21 Anders Carlsson <andersca@codefactory.se>
9342 * dbus/dbus-marshal.c: (_dbus_marshal_double),
9343 (_dbus_marshal_int32), (_dbus_marshal_uint32),
9344 (_dbus_marshal_int32_array), (_dbus_marshal_uint32_array),
9345 (_dbus_marshal_double_array), (_dbus_marshal_string_array),
9346 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
9347 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
9348 (_dbus_marshal_get_field_end_pos), (_dbus_marshal_test):
9349 * dbus/dbus-marshal.h:
9350 * dbus/dbus-protocol.h:
9351 Add support for marshalling and demarshalling integer, double
9354 2003-01-21 Anders Carlsson <andersca@codefactory.se>
9359 * bus/connection.c: (connection_disconnect_handler):
9360 Remove the connection from the bus driver's list.
9362 (connection_watch_callback): Dispatch messages.
9364 (free_connection_data): Free connection name.
9366 (bus_connection_setup): Add connection to the bus driver's list.
9367 (bus_connection_remove_owned_service):
9368 (bus_connection_set_name), (bus_connection_get_name):
9369 Add functions for setting and getting the connection's name.
9372 Add function headers.
9374 * bus/driver.c: (create_unique_client_name),
9375 (bus_driver_handle_hello_message),
9376 (bus_driver_send_welcome_message), (bus_driver_message_handler),
9377 (bus_driver_add_connection), (bus_driver_remove_connection):
9380 * bus/services.c: (bus_service_free):
9382 New file that handles communication and registreation with the bus
9385 2003-01-21 Anders Carlsson <andersca@codefactory.se>
9387 * dbus/dbus-connection.c: (dbus_connection_send_message):
9388 Add a new client_serial parameter.
9390 (dbus_connection_send_message_with_reply):
9391 Remove a @todo since we've implemented the blocking function.
9393 (dbus_connection_send_message_with_reply_and_block):
9394 New function that sends a message and waits for a reply and
9395 then returns the reply.
9397 * dbus/dbus-connection.h:
9400 * dbus/dbus-errors.c: (dbus_result_to_string):
9401 * dbus/dbus-errors.h:
9402 Add new DBUS_RESULT.
9404 * dbus/dbus-message-internal.h:
9405 * dbus/dbus-message.c: (_dbus_message_get_reply_serial),
9406 (_dbus_message_set_sender), (dbus_message_write_header),
9407 (dbus_message_new_reply), (decode_header_data),
9408 (_dbus_message_loader_return_buffer), (_dbus_message_test):
9409 * dbus/dbus-message.h:
9410 Add new functions that set the reply serial and sender.
9411 Also marshal and demarshal them correctly and add test.
9413 * dbus/dbus-protocol.h:
9414 Add new DBUS_MESSAGE_TYPE_SENDER.
9417 * glib/dbus-gmain.c: (watch_callback), (free_callback_data),
9418 (add_watch), (remove_watch), (add_timeout), (remove_timeout),
9419 (dbus_connection_hookup_with_g_main):
9420 * glib/test-dbus-glib.c: (main):
9421 Rewrite to use GIOChannel and remove the GSource crack.
9423 * test/echo-client.c: (main):
9424 * test/watch.c: (check_messages):
9425 Update for changed APIs
9427 2003-01-19 Anders Carlsson <andersca@codefactory.se>
9429 * dbus/Makefile.am: Add dbus-timeout.[cħ]
9431 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport):
9432 Create a DBusTimeoutList.
9433 (dbus_connection_set_timeout_functions): Add new function to
9434 set timeout callbacks
9436 * dbus/dbus-connection.h: Add public DBusTimeout API.
9438 * dbus/dbus-message.c: (dbus_message_get_service):
9439 * dbus/dbus-message.h: New function.
9441 * dbus/dbus-server.c: Fix small doc typo.
9443 * dbus/dbus-timeout.[ch]: New files for mainloop timeouts.
9445 2003-01-19 Anders Carlsson <andersca@codefactory.se>
9447 * dbus/dbus-string.c (_dbus_string_move_len): Don't delete all
9448 of the string, just as long as specified.
9450 2003-01-19 Havoc Pennington <hp@pobox.com>
9452 * dbus/dbus-connection.c (dbus_connection_get_is_authenticated):
9455 * dbus/dbus-server.c (dbus_server_set_max_connections)
9456 (dbus_server_get_max_connections, dbus_server_get_n_connections):
9457 keep track of current number of connections, and add API for
9458 setting a max (but haven't implemented enforcing the max yet)
9460 2003-01-18 Havoc Pennington <hp@pobox.com>
9462 * dbus/dbus-transport-unix.c (unix_do_iteration): only do the
9463 reading/writing if read_watch != NULL or write_watch != NULL.
9465 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): fix
9466 the message loader code to actually load message->header and
9467 message->body into the newly-created message.
9469 * dbus/dbus-transport-unix.c (check_write_watch): fix a mem leak
9472 * dbus/dbus-connection.c (dbus_connection_set_max_message_size)
9473 (dbus_connection_get_max_message_size)
9474 (dbus_connection_set_max_live_messages_size)
9475 (dbus_connection_get_max_live_messages_size): implement some
9476 resource limitation functions
9478 * dbus/dbus-resources.c: new file implementing some of the
9479 resource limits stuff
9481 * dbus/dbus-message.c (dbus_message_iter_get_byte_array): add
9482 missing docs, add @todo to handle OOM etc.
9484 * dbus/dbus-marshal.c (_dbus_demarshal_byte_array): add missing
9487 2003-01-18 Havoc Pennington <hp@pobox.com>
9489 * dbus/dbus-connection.c (dbus_connection_unref): disconnect the
9490 connection if it hasn't been already.
9492 * dbus/dbus-connection.h: kill off the idea of an ErrorFunction,
9493 replace with DisconnectFunction.
9495 2003-01-18 Havoc Pennington <hp@pobox.com>
9497 Building --disable-verbose-mode --disable-asserts --disable-tests
9498 cuts the library from 112K to 45K or so
9500 * configure.in: check for varargs macro support,
9501 add --enable-verbose-mode, --enable-asserts.
9503 * dbus/dbus-internals.h (_dbus_assert): support
9505 (_dbus_verbose): support DBUS_ENABLE_VERBOSE_MODE
9507 2003-01-18 Havoc Pennington <hp@pobox.com>
9509 * dbus/dbus-test.c: include config.h so that tests actually run
9511 * dbus/dbus-string.c: add assertions that stuff is 8-byte aligned,
9512 so the failure mode when that assumption fails will be plenty
9515 2003-01-18 Havoc Pennington <hp@pobox.com>
9517 * configure.in: default --enable-tests to $USE_MAINTAINER_MODE
9519 * dbus/Makefile.am: fix it up so dubs-test-main.c is included in
9522 * test/Makefile.am: don't use special variable "TESTS" for echo-*
9523 since we don't want to use those in make check
9525 2003-01-15 Havoc Pennington <hp@redhat.com>
9531 2003-01-15 Havoc Pennington <hp@redhat.com>
9533 * test/Makefile.am: fix so that test source code ends up in the
9534 distribution on make distcheck
9536 2003-01-15 Havoc Pennington <hp@redhat.com>
9542 2003-01-15 Havoc Pennington <hp@redhat.com>
9544 * dbus/dbus-test.c (dbus_internal_symbol_do_not_use_run_tests):
9545 fix build when --disable-tests
9547 * Makefile.am (EXTRA_DIST): put HACKING in here
9549 * HACKING: document procedure for making a tarball release.
9551 2003-01-14 Anders Carlsson <andersca@codefactory.se>
9553 * bus/connection.c: (connection_error_handler),
9554 (bus_connection_setup):
9555 * bus/main.c: (main):
9556 Make sure that the DBusConnectionData struct is NULLed
9557 out to prevent a segfault.
9559 * dbus/dbus-errors.c: (dbus_result_to_string):
9560 * dbus/dbus-errors.h:
9561 * dbus/dbus-message.c: (dbus_message_get_fields),
9562 (dbus_message_get_fields_valist), (_dbus_message_test):
9563 * dbus/dbus-message.h:
9564 Make dbus_message_get_fields return a result code so we can
9565 track invalid fields as well as oom.
9567 2003-01-11 Havoc Pennington <hp@pobox.com>
9569 * configure.in: change --enable-test/--enable-ansi action-if-given
9570 to enable_foo=$enableval instead of enable_foo=yes
9572 2003-01-08 Havoc Pennington <hp@pobox.com>
9574 * dbus/dbus-string.c (_dbus_string_align_length): new function
9576 * dbus/dbus-test-main.c: move main() for test app here
9578 (dbus_internal_symbol_do_not_use_run_tests): we have to export a
9579 symbol to run tests, because dbus-test isn't in the main
9582 Code review nitpicks.
9584 * dbus/dbus-message.c (dbus_message_write_header): add newlines
9585 for people with narrow emacs ;-). Assert client_serial was filled
9586 in. Assert message->name != NULL.
9587 (dbus_message_append_fields): have "first_field_type" arg separate
9588 from va list, needed for C++ binding that also uses varargs IIRC
9589 and helps with type safety
9590 (dbus_message_new): add @todo about using DBusString to store
9591 service/name internally
9592 (dbus_message_new): don't leak ->service and ->name on OOM later
9594 (dbus_message_unref): free the service name
9595 (dbus_message_get_fields): same change to varargs
9596 i.e. first_field_type
9597 (_dbus_message_loader_return_buffer): assert that the message data
9598 is aligned (if not it's a bug in our code). Put in verbose griping
9599 about why we set corrupted = TRUE.
9600 (decode_header_data): add FIXME that char* is evil. Was going to
9601 add FIXME about evil locale-specific string.h strncmp, but just
9602 switched to wacky string-as-uint32 optimization. Move check for
9603 "no room for field name" above get_const_data_len() to avoid
9604 assertion failure in get_const_data_len if we have trailing 2
9605 bytes or the like. Check for service and name fields being
9606 provided twice. Don't leak service/name on error. Require field
9607 names to be aligned to 4 bytes.
9609 * dbus/dbus-marshal.c: move byte swap stuff to header
9610 (_dbus_pack_int32): uscore-prefix
9611 (_dbus_unpack_int32): uscore-prefix
9612 (_dbus_unpack_uint32): export
9613 (_dbus_demarshal_string): add @todo complaining about use of
9615 (_dbus_marshal_get_field_end_pos): add @todo about bad error
9616 handling allowing corrupt data to go unchecked
9618 2003-01-08 Havoc Pennington <hp@redhat.com>
9620 * dbus/dbus-transport-unix.c (unix_do_iteration): add read/write
9621 to the select() as needed for authentication. (should be using
9622 _dbus_poll() not select, but for another day)
9624 * dbus/dbus.h: include dbus/dbus-protocol.h
9626 2003-01-08 Anders Carlsson <andersca@codefactory.se>
9628 * dbus/Makefile.am (dbusinclude_HEADERS): Install
9631 2003-01-08 Anders Carlsson <andersca@codefactory.se>
9633 * dbus/dbus-internals.c: (_dbus_type_to_string):
9634 New function that returns a string describing a type.
9636 * dbus/dbus-marshal.c: (_dbus_demarshal_byte_array):
9637 * dbus/dbus-marshal.h:
9638 * dbus/dbus-message.c: (dbus_message_get_fields_valist),
9639 (dbus_message_iter_get_field_type), (dbus_message_iter_get_double),
9640 (dbus_message_iter_get_byte_array):
9641 * dbus/dbus-message.h:
9642 Add new convenience functions for appending and getting message fields.
9643 Also add demarshalling routines for byte arrays.
9645 2003-01-07 Anders Carlsson <andersca@codefactory.se>
9647 * dbus/dbus-connection-internal.h:
9648 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
9649 (_dbus_connection_get_next_client_serial),
9650 (dbus_connection_send_message):
9651 * dbus/dbus-internals.h:
9652 * dbus/dbus-marshal.c: (unpack_uint32), (dbus_unpack_int32),
9653 (dbus_pack_int32), (_dbus_marshal_double), (_dbus_marshal_int32),
9654 (_dbus_marshal_uint32), (_dbus_demarshal_double),
9655 (_dbus_demarshal_int32), (_dbus_demarshal_uint32),
9656 (_dbus_demarshal_string), (_dbus_marshal_get_field_end_pos),
9657 (_dbus_verbose_bytes), (_dbus_marshal_test):
9658 * dbus/dbus-marshal.h:
9659 * dbus/dbus-message-internal.h:
9660 * dbus/dbus-message.c: (_dbus_message_set_client_serial),
9661 (dbus_message_write_header), (_dbus_message_lock),
9662 (dbus_message_new), (dbus_message_ref), (dbus_message_unref),
9663 (dbus_message_get_name), (dbus_message_append_int32),
9664 (dbus_message_append_uint32), (dbus_message_append_double),
9665 (dbus_message_append_string), (dbus_message_append_byte_array),
9666 (dbus_message_get_fields_iter), (dbus_message_iter_ref),
9667 (dbus_message_iter_unref), (dbus_message_iter_has_next),
9668 (dbus_message_iter_next), (dbus_message_iter_get_field_type),
9669 (dbus_message_iter_get_string), (dbus_message_iter_get_int32),
9670 (dbus_message_iter_get_uint32), (dbus_message_iter_get_double),
9671 (decode_header_data), (_dbus_message_loader_return_buffer),
9672 (message_iter_test), (_dbus_message_test):
9673 * dbus/dbus-message.h:
9674 * dbus/dbus-protocol.h:
9675 * dbus/dbus-test.c: (main):
9677 * glib/test-dbus-glib.c: (message_handler), (main):
9678 * test/echo-client.c: (main):
9679 * test/watch.c: (check_messages):
9680 Make messages sendable and receivable for real.
9682 2003-01-07 Anders Carlsson <andersca@codefactory.se>
9684 * dbus/dbus-marshal.c: (_dbus_marshal_double),
9685 (_dbus_marshal_string), (_dbus_marshal_byte_array):
9686 * dbus/dbus-message.c: (dbus_message_append_int32),
9687 (dbus_message_append_uint32), (dbus_message_append_double),
9688 (dbus_message_append_string), (dbus_message_append_byte_array):
9689 Handle OOM restoration.
9691 2003-01-07 Anders Carlsson <andersca@codefactory.se>
9693 * dbus/dbus-marshal.c: (_dbus_marshal_string),
9694 (_dbus_demarshal_string), (_dbus_marshal_test):
9695 * dbus/dbus-marshal.h:
9696 * dbus/dbus-message.c: (dbus_message_get_name),
9697 Document these functions.
9699 (dbus_message_append_int32), (dbus_message_append_uint32),
9700 (dbus_message_append_double), (dbus_message_append_string),
9701 (dbus_message_append_byte_array):
9702 * dbus/dbus-message.h:
9703 Add functions for adding message fields of different types.
9705 * dbus/dbus-protocol.h:
9706 Add the different types.
9708 2003-01-05 Havoc Pennington <hp@pobox.com>
9710 * bus/connection.c: implement routines for handling connections,
9711 first thing is keeping a list of owned services on each connection
9712 and setting up watches etc.
9714 * bus/services.c: implement a mapping from service names to lists
9717 * dbus/dbus-hash.c: add DBUS_HASH_POINTER
9719 * dbus/dbus-threads.c (dbus_static_mutex_lock): add functions
9720 to use static mutexes for global data
9722 * dbus/dbus-connection.c (dbus_connection_set_data): add new
9723 collection of functions to set/get application-specific data
9724 on the DBusConnection.
9726 2003-01-04 Havoc Pennington <hp@pobox.com>
9728 * dbus/dbus-sysdeps.c (_dbus_sleep_milliseconds): new function
9729 (_dbus_poll): new function
9731 * dbus/dbus-internals.h (_DBUS_STRUCT_OFFSET): new macro
9734 * bus/loop.c: initial code for the daemon main loop
9736 2003-01-04 Havoc Pennington <hp@pobox.com>
9738 * test/watch.c (error_handler): make it safe if the error handler
9739 is called multiple times (if we s/error handler/disconnect
9740 handler/ we should just guarantee it's called only once)
9742 * dbus/dbus-transport.c (_dbus_transport_disconnect): call the
9743 error handler on disconnect (it's quite possible we should
9744 just change the error handler to a "disconnect handler," I'm
9745 not sure we have any other meaningful errors)
9747 * configure.in: check for getpwnam_r
9749 * dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
9750 dbus/dbus-auth.c: add credentials support, add EXTERNAL auth
9751 mechanism as in SASL spec, using socket credentials
9753 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): new function
9754 (_dbus_send_credentials_unix_socket): new function
9756 * dbus/dbus-sysdeps.c (_dbus_accept_unix_socket): rename just
9758 (_dbus_write): only check errno if <0 returned
9759 (_dbus_write_two): ditto
9761 2003-01-02 Anders Carlsson <andersca@codefactory.se>
9763 * dbus/dbus-marshal.c: (_dbus_marshal_utf8_string),
9764 (_dbus_marshal_byte_array), (_dbus_demarshal_utf8_string),
9765 (_dbus_marshal_test):
9766 * dbus/dbus-marshal.h:
9767 Add _dbus_marshal_byte_array and rename _dbus_marshal_string
9768 to _dbus_marshal_utf8_string. Also fix some tests.
9770 2002-12-28 Harri Porten <porten@kde.org>
9772 * configure.in: added check for C++ compiler and a very cheesy
9773 check for the Qt integration
9775 * Makefile.am (SUBDIRS): compile qt subdir if support is enabled
9777 * qt/Makefile.am: added
9779 * qt/.cvsignore: added
9781 * qt/dbus-qthread.cc, qt/dbus-qthread.cpp: renamed former to
9782 latter, added #ifdef QT_THREAD_SUPPORT guard.
9784 * dbus/Makefile.am: added missing headers for make dist
9786 2002-12-28 Kristian Rietveld <kris@gtk.org>
9788 * dbus/Makefile.am: fixup export-symbols-regex.
9790 2002-12-27 Anders Carlsson <andersca@codefactory.se>
9792 * acinclude.m4: Add this file and put the
9793 PKG_CHECK_MODULE macro in it.
9795 2002-12-27 Anders Carlsson <andersca@codefactory.se>
9797 * dbus/dbus-marshal.c: (_dbus_marshal_string),
9798 (_dbus_demarshal_double), (_dbus_demarshal_int32),
9799 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
9800 (_dbus_marshal_test):
9801 Make the demarshalling routines align the pos argument.
9802 Add string marshalling tests and fix the obvious bugs
9805 2002-12-26 Havoc Pennington <hp@pobox.com>
9807 * dbus/dbus-auth.c: fixes fixes fixes
9809 * dbus/dbus-transport-unix.c: wire up support for
9810 encoding/decoding data on the wire
9812 * dbus/dbus-auth.c (_dbus_auth_encode_data)
9813 (_dbus_auth_decode_data): append to target string
9814 instead of nuking it.
9816 2002-12-26 Havoc Pennington <hp@pobox.com>
9818 * dbus/dbus-marshal.h (DBUS_COMPILER_BYTE_ORDER): #ifdef
9819 WORDS_BIGENDIAN then compiler byte order is DBUS_BIG_ENDIAN,
9822 * dbus/dbus-marshal.c: Add macros to do int swapping in-place and
9823 avoid swap_bytes() overhead (ignoring possible assembly stuff for
9824 now). Main point is because I wanted unpack_uint32 to implement
9826 (_dbus_verbose_bytes): new function
9828 * dbus/dbus-string.c (_dbus_string_validate_ascii): new function
9830 * dbus/dbus-message.c (_dbus_message_loader_get_is_corrupted): add
9831 mechanism to handle a corrupt message stream
9832 (_dbus_message_loader_new): fix preallocation to only prealloc,
9835 * dbus/dbus-string.c (_dbus_string_skip_blank): fix this function
9836 (_dbus_string_test): enhance tests for copy/move and fix the
9839 * dbus/dbus-transport-unix.c: Hold references in more places to
9840 avoid reentrancy problems
9842 * dbus/dbus-transport.c: ditto
9844 * dbus/dbus-connection.c (dbus_connection_dispatch_message): don't
9845 leak reference count in no-message case
9847 * test/watch.c (do_mainloop): handle adding/removing watches
9848 during iteration over the watches. Also, ref the connection/server
9849 stored on a watch, so we don't try to mangle a destroyed one.
9851 * dbus/dbus-transport-unix.c (do_authentication): perform
9854 * dbus/dbus-auth.c (get_state): add a state
9855 AUTHENTICATED_WITH_UNUSED_BYTES and return it if required
9856 (_dbus_auth_get_unused_bytes): append the unused bytes
9857 to the passed in string, rather than prepend
9859 * dbus/dbus-transport.c (_dbus_transport_init_base): create
9860 the auth conversation DBusAuth
9862 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd)
9863 (_dbus_transport_new_for_domain_socket): when creating a
9864 transport, pass in whether it's a client-side or server-side
9865 transport so we know which DBusAuth to create
9867 2002-12-03 Havoc Pennington <hp@pobox.com>
9869 * dbus/dbus-transport-unix.c (unix_finalize): finalize base
9870 _after_ finalizing the derived members
9871 (unix_connection_set): unref watch if we fail to add it
9873 * dbus/dbus-connection.c (dbus_connection_unref): delete the
9874 transport first, so that the connection owned by the
9875 transport will be valid as the transport finalizes.
9877 * dbus/dbus-transport-unix.c (unix_finalize): free the write_watch
9878 if necessary, and remove watches from the connection.
9880 * dbus/dbus-watch.c (_dbus_watch_list_free): improve a comment
9882 2002-12-26 Anders Carlsson <andersca@codefactory.se>
9884 * dbus/dbus-marshal.c: (_dbus_marshal_string),
9885 (_dbus_demarshal_double), (_dbus_demarshal_int32),
9886 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
9887 (_dbus_marshal_test):
9888 * dbus/dbus-marshal.h:
9889 Add string marshal functions and have the demarshal functions
9890 return the new position.
9892 2002-12-25 Havoc Pennington <hp@pobox.com>
9894 * doc/dbus-sasl-profile.txt: docs on the authentication protocol,
9895 it is a simple protocol that just maps directly to SASL.
9897 * dbus/dbus-auth.h, dbus/dbus-auth.c: authentication protocol
9898 initial implementation, not actually used yet.
9900 * dbus/dbus-string.c (_dbus_string_find): new function
9901 (_dbus_string_equal): new function
9902 (_dbus_string_base64_encode): new function
9903 (_dbus_string_base64_decode): new function
9905 2002-12-25 Anders Carlsson <andersca@codefactory.se>
9908 * dbus/dbus-marshal.c: (swap_bytes), (_dbus_marshal_double),
9909 (_dbus_marshal_int32), (_dbus_marshal_uint32),
9910 (_dbus_demarshal_double), (_dbus_demarshal_int32),
9911 (_dbus_demarshal_uint32), (_dbus_marshal_test):
9912 * dbus/dbus-marshal.h:
9913 * dbus/dbus-protocol.h:
9914 * dbus/dbus-test.c: (main):
9916 Add un-optimized marshalling/demarshalling routines.
9918 2002-12-25 Harri Porten <porten@kde.org>
9920 * qt/dbus-qt.h: adjusted ctor and getter to KDE/Qt conventions
9922 2002-12-24 Zack Rusin <zack@kde.org>
9924 * qt/dbus-qthread.cc: adding - integrates QMutex into Dbus
9925 * qt/dbus-qt.h: skeleton with two sample implemenatation of the
9928 2002-12-24 Havoc Pennington <hp@pobox.com>
9930 * glib/dbus-gthread.c: fix include
9932 * glib/dbus-glib.h: rename DBusMessageHandler for now.
9933 I think glib API needs to change, though, as you don't
9934 want to use DBusMessageFunction, you want to use the
9935 DBusMessageHandler object. Probably
9936 dbus_connection_open_with_g_main_loop()
9937 and dbus_connection_setup_g_main_loop() or something like that
9938 (but think of better names...) that just create a connection
9939 that has watch/timeout functions etc. already set up.
9941 * dbus/dbus-connection.c
9942 (dbus_connection_send_message_with_reply): new function just to
9943 show how the message handler helps us deal with replies.
9945 * dbus/dbus-list.c (_dbus_list_remove_last): new function
9947 * dbus/dbus-string.c (_dbus_string_test): free a string that
9950 * dbus/dbus-hash.c: use memory pools for the hash entries
9951 (rebuild_table): be more paranoid about overflow, and
9952 shrink table when we can
9953 (_dbus_hash_test): reduce number of sprintfs and write
9954 valid C89. Add tests for case where we grow and then
9955 shrink the hash table.
9957 * dbus/dbus-mempool.h, dbus/dbus-mempool.c: memory pools
9959 * dbus/dbus-connection.c (dbus_connection_register_handler)
9960 (dbus_connection_unregister_handler): new functions
9962 * dbus/dbus-message.c (dbus_message_get_name): new
9964 * dbus/dbus-list.c: fix docs typo
9966 * dbus/dbus-message-handler.h, dbus/dbus-message-handler.c:
9967 an object representing a handler for messages.
9969 2002-12-16 Anders Carlsson <andersca@codefactory.se>
9972 * glib/dbus-gthread.c: (dbus_gthread_init):
9973 Don't use the gdbus prefix for public functions.
9975 2002-12-16 Anders Carlsson <andersca@codefactory.se>
9979 Add GLib checks and fixup .pc files
9983 * glib/dbus-gmain.c: (gdbus_connection_prepare),
9984 (gdbus_connection_check), (gdbus_connection_dispatch),
9985 (gdbus_add_connection_watch), (gdbus_remove_connection_watch),
9986 (dbus_connection_gsource_new):
9987 * glib/dbus-gthread.c: (dbus_gmutex_new), (dbus_gmutex_free),
9988 (dbus_gmutex_lock), (dbus_gmutex_unlock), (dbus_gthread_init):
9989 * glib/test-dbus-glib.c: (message_handler), (main):
9992 2002-12-15 Harri Porten <porten@kde.org>
9994 * autogen.sh: check for libtoolize before attempting to use it
9996 * dbus/dbus-transport-unix.c: include <sys/time.h> for timeval
9999 * .cvsignore: ignore more stamp files
10001 * dbus/dbus-watch.c (_dbus_watch_list_new): fixed doc error
10003 * test/Makefile.am: added -I$(top_srcdir) to be able to compile
10004 without make install.
10006 2002-12-15 Havoc Pennington <hp@pobox.com>
10008 * dbus/dbus-threads.c: add thread stubs that a higher library
10009 layer can fill in. e.g. the GLib wrapper might fill them in with
10010 GThread stuff. We still need to use this thread API to
10011 thread-safe-ize the library.
10013 2002-12-12 Havoc Pennington <hp@pobox.com>
10015 * dbus/dbus-transport-unix.c, dbus/dbus-server-unix.c: use the
10016 below new interfaces and include fewer system headers.
10018 * dbus/dbus-sysdeps.c (_dbus_read): new function
10019 (_dbus_write): new function
10020 (_dbus_write_two): new function
10021 (_dbus_connect_unix_socket): new function
10022 (_dbus_listen_unix_socket): new function
10024 * dbus/dbus-message-internal.h: change interfaces to use
10027 2002-12-11 Havoc Pennington <hp@pobox.com>
10029 * dbus/dbus-types.h: add dbus_unichar
10031 * dbus/dbus-internals.c (_dbus_verbose): use _dbus_getenv
10033 * dbus/dbus-connection.c (dbus_connection_send_message): return
10036 * dbus/dbus-transport.c: include dbus-watch.h
10038 * dbus/dbus-connection.c: include dbus-message-internal.h
10040 * HACKING: add file with coding guidelines stuff.
10042 * dbus/dbus-string.h, dbus/dbus-string.c: Encapsulate all string
10043 handling here, for security purposes (as in vsftpd). Not actually
10044 using this class yet.
10046 * dbus/dbus-sysdeps.h, dbus/dbus-sysdeps.c: Encapsulate all
10047 system/libc usage here, as in vsftpd, for ease of auditing (and
10048 should also simplify portability). Haven't actually moved all the
10049 system/libc usage into here yet.
10051 2002-11-25 Havoc Pennington <hp@pobox.com>
10053 * dbus/dbus-internals.c (_dbus_verbose): fix to not
10054 always print the first verbose message.
10056 2002-11-24 Havoc Pennington <hp@pobox.com>
10058 * test/echo-client.c, test/echo-server.c: cheesy test
10061 * configure.in (AC_CHECK_FUNCS): check for writev
10063 * dbus/dbus-message.c (_dbus_message_get_network_data): new
10066 * dbus/dbus-list.c (_dbus_list_foreach): new function
10068 * dbus/dbus-internals.c (_dbus_verbose): new function
10070 * dbus/dbus-server.c, dbus/dbus-server.h: public object
10071 representing a server that listens for connections.
10073 * dbus/.cvsignore: create
10075 * dbus/dbus-errors.h, dbus/dbus-errors.c:
10076 public API for reporting errors
10078 * dbus/dbus-connection.h, dbus/dbus-connection.c:
10079 public object representing a connection that
10080 sends/receives messages. (Same object used for
10081 both client and server.)
10083 * dbus/dbus-transport.h, dbus/dbus-transport.c:
10084 Basic abstraction for different kinds of stream
10085 that we might read/write messages from.
10087 2002-11-23 Havoc Pennington <hp@pobox.com>
10089 * dbus/dbus-internals.h (_DBUS_INT_MAX): add _DBUS_INT_MIN
10092 * dbus/dbus-test.c (main): add list test, and include
10093 dbus-test.h as intended
10095 * dbus/dbus-hash.c (_dbus_hash_table_remove_string)
10096 (_dbus_hash_table_remove_int): return value indicates
10097 whether the entry existed to remove
10099 * dbus/dbus-list.c: add linked list utility class,
10100 with docs and tests
10102 * dbus/dbus-hash.c: add TODO item about shrinking the hash bucket
10105 2002-11-23 Havoc Pennington <hp@pobox.com>
10107 * Doxyfile.in (INCLUDE_FILE_PATTERNS): expand DBUS_BEGIN_DECLS/
10108 DBUS_END_DECLS to nothing, that should fix this once and for all
10110 * Doxyfile.in (JAVADOC_AUTOBRIEF): set to YES
10112 * dbus/dbus-message.c, dbus/dbus-hash.c:
10113 add some missing @brief
10115 2002-11-23 Havoc Pennington <hp@pobox.com>
10117 * dbus/dbus-message.h: put semicolons after DEBUG_BEGIN_DECLS
10118 to avoid confusing Doxygen
10120 * dbus/dbus-hash.c: @} not }@
10122 * dbus/dbus-message.c (struct DBusMessage): split out
10125 2002-11-23 Havoc Pennington <hp@pobox.com>
10127 * configure.in: pile on more warning flags if using gcc
10129 * Doxyfile.in (EXTRACT_STATIC): set to NO, so we don't have
10130 to document static functions
10132 * configure.in: add summary to end of configure so it
10133 looks nice and attractive
10135 * dbus/dbus-hash.c: finish implementation and write unit
10138 * configure.in: add --enable-tests to enable unit tests
10140 * dbus/dbus-test.c: test program to run unit tests
10141 for all files in dbus/*, initially runs a test for
10144 * dbus/dbus-internals.h: file to hold some internal utility stuff
10146 2002-11-22 Havoc Pennington <hp@redhat.com>
10148 * dbus/dbus-hash.c: copy in Tcl hash table, not yet
10149 "ported" away from Tcl
10151 * dbus/dbus-types.h: header for types such as dbus_bool_t
10153 2002-11-22 Havoc Pennington <hp@redhat.com>
10155 * dbus/dbus.h: fixups for doc warnings
10157 * Doxyfile.in (FILE_PATTERNS): we need to scan .h to pick up
10159 (QUIET): make it quiet so we can see warnings
10161 * dbus/dbus-memory.c: teach D-BUS to allocate and free memory
10163 2002-11-22 Havoc Pennington <hp@redhat.com>
10165 * Makefile.am: include "Doxyfile" target in all-local
10167 * configure.in: generate the Doxyfile
10169 * Doxyfile.in: move Doxyfile here, so we can use
10170 configure to generate a Doxyfile with the right
10171 version number etc.
10173 2002-11-22 Havoc Pennington <hp@redhat.com>
10175 * dbus/dbus-message.c: move inline docs into .c file
10177 * Doxyfile (OUTPUT_DIRECTORY): move output to doc/api
10178 so all docs are under doc/
10179 (MAN_EXTENSION): generate man pages. Use extension
10180 ".3dbus" which matches ".3qt" on my system,
10181 I guess this is OK, I don't know really.
10182 (FILE_PATTERNS): look for .c files not .h, makes sense
10183 for plain C I think
10185 2002-11-22 Havoc Pennington <hp@pobox.com>
10187 * Makefile.am (SUBDIRS): rename subdir "server" to "bus"
10188 because any app can be a server, and any app can be a client,
10189 the bus is a special kind of server.
10191 Thu Nov 21 23:35:31 2002 Zack Rusin <zack@kde.org>
10193 * Doxyfile : adding. Still needs Makefile rules to be generated
10194 automatically (just run "doxygen" in the toplevel dir for now to
10197 * dbus/dbus-message.h : Adding sample docs (javadoc since
10198 resembles gtk-doc a little more)
10200 * dbus/dbus.h : Adding sample docs
10202 2002-11-21 Havoc Pennington <hp@redhat.com>
10204 * dbus/Makefile.am (INCLUDES): define DBUS_COMPILATION
10205 so we can allow ourselves to include files directly,
10206 instead of having to use dbus.h
10208 * dbus/dbus.h: fill in
10210 * dbus/dbus-message.h: sketch out a sample header file.
10211 Include griping if you include it directly instead of
10214 * dbus/dbus-macros.h: new file with macros for extern "C",
10215 TRUE/FALSE, NULL, etc.
10217 * doc/file-boilerplate.c: put include guards in here
10219 2002-11-21 Havoc Pennington <hp@redhat.com>
10221 * doc/file-boilerplate.c: include both AFL and GPL boilerplate.
10223 * COPYING: include the GPL as well, and license code
10224 under both AFL and GPL.
10226 2002-11-21 Havoc Pennington <hp@redhat.com>
10228 * acconfig.h: get rid of this
10230 * autogen.sh (run_configure): add --no-configure option
10232 * configure.in: remove AC_ARG_PROGRAM to make
10233 autoconf complain less. add AC_PREREQ.
10234 add AC_DEFINE third arg.
10236 2002-11-21 Anders Carlsson <andersca@codefactory.se>
10239 Fix references so we can distcheck.
10241 2002-11-21 Havoc Pennington <hp@redhat.com>
10243 * Initial module creation