1 2006-06-27 Jim Meyering <jim@meyering.net>
3 * tests/misc/cat-proc: Try to avoid any spurious numeric
4 differences in frequently-changing /proc/cpuinfo.
5 Reported by Nelson Beebe.
7 2006-06-26 Jim Meyering <jim@meyering.net>
9 Attempt rmdir (actually, unlinkat-with-AT_REMOVEDIR) upon any
10 fd_to_subdirp failure, not just when errno == EACCES.
11 * src/remove.c (remove_dir): Use unlinkat-with-AT_REMOVEDIR, not
12 rmdir, here, even though rmdir may happen to be adequate.
14 * NEWS: rm no longer fails to remove an empty, unreadable directory
15 * src/remove.c (remove_cwd_entries): If we can't open a directory,
16 and the failure is not being ignored, try to remove the directory
17 with rmdir (aka unlinkat-with-AT_REMOVEDIR), in case it's empty.
18 Problem report and test case from Paul Eggert in
19 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7425>.
21 * tests/rm/empty-inacc: New test, for the above.
23 Avoid a segfault for wc --files0=- < /dev/null.
24 * src/wc.c (compute_number_width): Return right away if nfiles == 0.
26 2006-06-25 Jim Meyering <jim@meyering.net>
28 * NEWS: wc accepts a new option --files0-from=FILE, where FILE
29 contains a list of NUL-separated file names.
31 * src/wc.c: Include "readtokens.h".
32 (usage): Describe the new option, and adjust the `Usage':
33 with this option, no FILE may be specified on the command line.
34 (main): Handle the new option.
35 * tests/misc/wc-files0: New tests, for the above.
36 * tests/misc/wc-files0-from: Likewise.
37 * tests/misc/Makefile.am (TESTS): Add wc-files0.
39 2006-06-24 Jim Meyering <jim@meyering.net>
41 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
43 2006-06-22 Jim Meyering <jim@meyering.net>
45 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
46 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
48 2006-06-19 Jim Meyering <jim@meyering.net>
50 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
51 so this check is not run as part of "make distcheck".
53 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
55 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
57 2006-06-18 Jim Meyering <jim@meyering.net>
59 * tests/misc/pwd-long: Make error output a little clearer.
61 2006-06-17 Jim Meyering <jim@meyering.net>
63 * tests/rm/inaccessible: Skip this test on systems without openat
64 support. Reported by Bob Proulx.
66 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
68 * tests/misc/mknod: Improve permission checks to handle
69 running mkdir test in set-gid directories.
71 2006-06-14 Jim Meyering <jim@meyering.net>
73 * tests/du/basic: Revamp not to hard-code file system block sizes.
75 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
77 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
80 2006-06-11 Jim Meyering <jim@meyering.net>
82 * .gitignore: New file.
83 * Makefile.am (EXTRA_DIST): Add .gitignore.
85 Setting TIME_STYLE=long-iso in the environment would make the
86 cp/same-file test fail.
87 * tests/envvar-check (vars): Add TIME_STYLE to the list.
88 * tests/cp/same-file: Revert last change.
89 Source the envvar-check script, to ensure that TIME_STYLE
90 settings don't affect these tests.
92 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
94 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
95 uses POSIX time stamp formats. Problem reported by John Nixon in
96 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
98 2006-06-10 Jim Meyering <jim@meyering.net>
100 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
102 Require a "Version N.M" line at the top of the ChangeLog
103 file only when making the actual release, not when running
105 * Makefile.maint (maintainer-distcheck): Don't depend on
107 (alpha beta major): Depend on it here, instead.
109 2006-06-08 Jim Meyering <jim@meyering.net>
111 Ensure that cat works with any of the options, -A -v -e -E -T,
112 when applied to files in /proc and /sys, even when the FIONREAD
113 ioctl produces nonsensical results. Before this change, cat would
114 produce no output (or truncated output), for some linux kernels.
116 * src/cat.c (write_pending): New function, factored out of cat.
117 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
118 that there are bytes to read. Some versions of linux-2.6.16 do that.
119 Write any pending output before returning.
120 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
121 * NEWS: Mention this bug fix.
122 * tests/misc/cat-proc: New file. Test for the above.
123 * tests/misc/Makefile.am (TESTS): Add cat-proc.
125 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
127 * src/expr.c (eval4): Detect overflow properly when multiplying
130 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
132 * NEWS: The 'expr' command now detects and reports integer overflow.
133 (It would be better to use extended precision instead, but that
135 * src/expr.c (integer_overflow): New function.
136 (eval4, eval3): Check for integer overflow.
138 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
140 Fix problems when building with Solaris/SVR4/etc. make, which uses a
141 different and somewhat bogus implementation of VPATH. In the
142 directory tests/misc, rename tests whose names might appear in the
143 Automake-generated rules. For example, we can't use a test named
144 'test', since Automake generates a rule that contains the text
145 "if test -f ./$$tst; ...", and this might expand to something like
146 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
147 which executes the 'test' script rather than the 'test' command.
148 * tests/misc/false-status: Renamed from tests/misc/false.
149 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
150 * tests/misc/sort-merge: Renamed from tests/misc/sort.
151 ($prog): Set to 'sort' rather than to $PROG.
152 * tests/misc/test-diag: Renamed from tests/misc/test.
153 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
154 in case Solaris make has prepended the directory.
155 (TESTS): Adjust to above renamings.
156 * tests/misc/expand: Don't assign to PROG; no longer needed
157 now that Makefile.am sets PROG to the basename.
158 * tests/misc/fold: Likewise.
160 2006-06-03 Jim Meyering <jim@meyering.net>
162 Make `cp --link --no-dereference' work also on systems where the
163 link system call cannot create a hard link to a symbolic link.
164 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
165 the link syscall on a symlink when it would do the wrong thing.
166 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
167 * tests/cp/link-no-deref: New file/test for the above.
168 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
169 * NEWS: Mention the change (doesn't affect Linux).
171 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
173 Fix some porting problems in the test cases reported by
174 Ralf Wildenhues for HP-UX 11.23 in:
175 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
176 * tests/help-version: Don't assume that \< \> works in sed.
177 * tests/misc/close-stdout: Don't assume that >&- works.
178 Add a /dev/full test.
179 * tests/touch/no-create-missing: Don't assume that >&- works.
181 2006-05-30 Jim Meyering <jim@meyering.net>
183 * src/ls.c (usage): Add `v' to the list of sorting-related options.
186 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
188 * tests/cp/fail-perm: source lang-default.
189 * tests/rm/inaccessible: Likewise.
191 2006-05-28 Jim Meyering <jim@meyering.net>
193 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
194 Recognize it, too. Reported by Ralf Wildenhues, in
195 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
197 2006-05-27 Jim Meyering <jim@meyering.net>
199 * src/chgrp.c: Support new options: --preserve-root and
200 --no-preserve-root. Somehow this program was skipped when those
201 options were added to chown, chmod, and rm. Reported by
202 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
203 * NEWS: Mention this.
205 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
207 * NEWS: Remove mention of --seed. We'll replace it with something
208 better, and don't want to indicate that it is supported.
209 * src/sort.c (usage): Likewise.
211 2006-05-20 Jim Meyering <jim@meyering.net>
213 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
215 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
216 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
217 FTS_COMFOLLOW. Spotted by Justin Pryzby.
219 * gnupload: Merge changes from automake, retaining the ""--to...
220 kludge to placate overzealous `make distcheck' check.
222 2006-05-19 Jim Meyering <jim@meyering.net>
224 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
225 FTS_TIGHT_CYCLE_CHECK directory traversal option.
226 Reported by Justin Pryzby in http://bugs.debian.org/367691
228 2006-05-15 Jim Meyering <jim@meyering.net>
230 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
233 2006-05-13 Jim Meyering <jim@meyering.net>
235 * tests/mv/no-target-dir: Test two more cases.
237 2006-05-11 Jim Meyering <jim@meyering.net>
239 mv -T DIR EMPTY_DIR no longer fails unconditionally
240 * src/copy.c (copy_internal): Don't manually prohibit a move where
241 the destination is an existing directory. Sometimes doing that is
242 valid. Let the rename system call enforce the rules. That is
243 allowed only when the source is a directory and the destination
244 directory (to be replaced) is empty. Reported by Eric Blake.
245 * tests/mv/no-target-dir: New file/test for this.
246 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
247 * NEWS: Mention this.
249 * tests/mv/atomic: New file/test for yesterday's fix.
250 * tests/mv/Makefile.am (TESTS): Add atomic.
252 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
254 2006-05-10 Jim Meyering <jim@meyering.net>
256 * src/copy.c (copy_internal): Don't explicitly unlink the destination
257 when moving a symlink into the place of an existing non-directory.
258 Reported by Joshua Hudson.
259 * NEWS: mention this.
261 2006-05-07 Jim Meyering <jim@meyering.net>
263 * Makefile.maint (patch-check): Fail if patch generates any output,
264 even merely for changed offsets.
266 * src/c99-to-c89.diff: Adjust to reflect new offsets.
268 * NEWS: Mention changes affecting df, pwd, shred.
270 2006-05-06 Jim Meyering <jim@meyering.net>
272 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
273 system condition where dirent.d_ino != stat.st_ino.
274 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
276 2006-05-06 Eric Blake <ebb9@byu.net>
278 * tests/ls/inode: Expand to test inode from readdir case.
279 * tests/ls/follow-slink: Expand to test broken links encountered
280 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
282 2006-05-06 Eric Blake <ebb9@byu.net>
284 * tests/mv/leak-fd: Work even on case-insensitive file system.
286 2006-05-04 Jim Meyering <jim@meyering.net>
288 * NEWS: Mention the 2006-03-19 pwd-related change that makes
289 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
291 2006-05-03 Jim Meyering <jim@meyering.net>
293 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
294 Use better macro parameter names: s/basename/key_name/,
295 s/basefunc/key_cmp_func. Fix typo in comment.
297 2006-04-29 Eric Blake <ebb9@byu.net>
299 * src/ls.c (main): On systems with d_type, directories_first only
300 implies format_needs_type, not format_needs_stat.
302 2006-05-03 Jim Meyering <jim@meyering.net>
304 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
305 after comma in arg list, from Eric Blake.
307 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
309 * tests/misc/date (relative-3): New test, derived from a bug
310 report by John Thomas McDole.
312 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
314 New option for ls: --group-directories-first.
315 It makes ls list directories before files.
316 * NEWS [New features]: Mention it.
317 * src/ls.c (sort_type): Rearrange to use as an array index when
318 choosing sort function; added new sort_numtypes member for
320 (time_type): Add new time_numtypes member for compile-time check.
321 (directories_first): New global variable.
322 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
323 (long_options): Add --directories-first.
324 (main): Support new option.
325 (is_directory): New function.
326 (extract_dirs_from_files): Use it.
327 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
328 (LIST_SORTFUNCTION_VARIANTS): New macros.
329 (sort_functions): New global variable.
330 (sort_files): Use it.
331 (usage): Document new option.
333 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
335 * src/shred.c (fillrand): The assertion was way too weak, due to
336 what must be a typo. Strengthen it to its intended value.
337 (dopass): Don't use alloca; it's not worth the aggravation here,
338 since it's used only to get a page-aligned buffer, and page
339 alignment doesn't buy us much here. I'm suspicious that alloca
340 causes problems on some hosts, due to a recent bug report by Adam
341 Waltman: http://bugs.gentoo.org/130246.
343 2006-04-18 Jim Meyering <jim@meyering.net>
345 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
346 sha384sum, sha512sum.
348 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
350 * src/chmod.c (describe_change): Adjust to filemode changes.
351 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
352 (print_long_format): Use (new) filemodestring rather than
353 (old) mode_string, so that we get more file types right, at least
354 in theory. Adjust to filemode changes.
355 * src/stat.c (human_access): Likewise.
357 2006-04-18 Jim Meyering <jim@meyering.net>
359 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
360 ignore file. This has never been enabled. Reported by Eric Blake.
362 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
364 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
365 bug in Interix. Just call symlink or link directly. All uses changed.
366 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
367 * src/stat.c (USE_STATVFS): New macro.
368 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
369 (NAMEMAX_FORMAT): define a bit more clearly, now that the
370 statvfs-using code is a bit more regular.
371 * src/system.h (sync) [!HAVE_SYNC]: New macro.
373 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
375 * NEWS: csplit, nl, expr now conform to POSIX better, and are
376 more-compatible with traditional Unix, with respect to regular
378 * src/csplit.c (extract_regexp): Set re_syntax_options to a
379 value that is compatible with what POSIX requires.
380 * src/nl.c (build_type_arg): Likewise.
381 * src/expr.c (docolon): Likewise. Also, don't let anchors match
382 newline; this fixes an incompatibility with tradition and with POSIX.
383 Don't warn about leading ^. POSIX says it is unspecified whether
384 ^ is a special character, which means that implementations can
385 either treat it as special or not, but either way a warning is not
386 allowed (unless the regexp is otherwise invalid). Instead, anchor
387 the expression but treat ^ as an anchor; this is the traditional
388 behavior (e.g., Solaris 10).
389 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
390 and the like as invalid expressions (exit status 2), not as
391 failure of 'expr' (exit status 3). This is more consistent with
393 * tests/expr/basic (fail-a): Adjust exit status to match new expr
394 behavior, for status 2 versus 3.
396 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
397 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
398 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
399 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
400 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
401 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
402 (bre61, bre62): New tests.
403 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
407 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
408 "if !". Do not assume that 'sed' can handle long, newline-free input.
409 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
411 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
413 Adjust to new regex.h API (with new fastmap type), and clean
414 up the regex storage allocation a bit.
416 * src/csplit.c (struct control): Put re_compiled member at the
417 end, since it's large. Change regexpr member from char * to bool;
418 all uses changed. Add new member fastmap.
419 (extract_regexp): regexp arg is now char const *, not char *.
420 Don't bother duplicating the regular expression; it's not needed.
421 Set fastmap from new fastmap member. Don't bother allocating
422 a buffer, as the regexp code does a better job than we do.
423 * src/expr.c (docolon): Allocate and use a fastmap.
424 Don't bother allocating a buffer.
425 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
427 (build_type_arg): New fastmap arg. All uses changed.
428 Don't bother allocating a buffer, but set a fastmap.
429 * src/ptx.c (context_regex_string, word_regex_string): Remove.
430 (context_regex, word_regex): New vars, replacing the above.
432 (struct regex_data): New type.
433 (compile_regex): Renamed from alloc_and_compile_regex, since
434 we no longer allocate storage. Arg is now a struct regex_data *,
435 not a const char *. All uses changed. Don't allocate the fastmap;
436 instead, take it from the caller. Don't convert size_t to int,
437 to avoid arithmetic overflow problems. Don't bother freeing
438 storage afterwards; it's not worth the aggravation.
439 * src/tac.c (compiled_separator_fastmap): New ver.
440 (main): Use it. Don't bother allocating a buffer.
442 2006-03-30 Jim Meyering <jim@meyering.net>
444 * src/dd.c (iwrite): Remove assignment without effect.
445 Reported by Felix Rauch Valenti.
447 2006-03-22 Eric Blake <ebb9@byu.net>
449 * src/ptx.c (usage): Remove mention of --copyright/-C.
450 (main): Alias --copyright to --version plus a deprecation warning.
451 * NEWS: Mention this.
453 2006-03-27 Jim Meyering <jim@meyering.net>
455 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
456 use of strtod. Tiny patch from Nickolai Zeldovich.
458 2006-03-11 Eric Blake <ebb9@byu.net>
460 * tests/misc/dirname: New file.
461 * tests/basename/Makefile.am: Delete.
462 * tests/basename/basic: Move to...
463 * tests/misc/basename: ... this new file. Add some tests,
464 including fixed behavior for //.
465 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
466 * tests/Makefile.am (SUBDIRS): Remove basename.
467 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
469 Improvements to dirname/basename handling on platforms like
470 cygwin with distinct // and with drive letters.
471 * NEWS: Document new behavior.
472 * src/basename.c (main): Don't strip suffix from file system
474 * src/cp.c (target_directory_operand): Use new last_component.
475 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
476 traversing the string.
477 * src/dircolors.c (guess_shell_syntax): Use new last_component.
478 * src/install.c (target_directory_operand, install_file_in_dir):
480 * src/ln.c (target_directory_operand, main): Likewise.
481 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
482 * src/mv.c (target_directory_operand, movefile): Likewise.
483 * src/remove.c (rm_1): Likewise.
484 * src/shred.c (wipename): Likewise.
485 * src/split.c (next_file_name): Likewise.
486 * src/su.c (log_su, run_shell): Likewise.
488 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
490 * NEWS: nohup diagnostics are now more precise, and nohup now
491 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
492 * src/nohup.c (main): Implement this.
493 * tests/misc/nohup: Test the new behavior.
495 2006-03-12 Jim Meyering <jim@meyering.net>
497 * src/copy.c (set_author): Rename function, from preserve_author.
499 * src/remove.c (AD_pop_and_chdir): Use new macro,
500 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
502 * src/system.h (SAME_INODE): Remove definition.
503 Include "same-inode.h", instead.
505 2006-03-11 Eric Blake <ebb9@byu.net>
507 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
509 2006-03-10 Jim Meyering <jim@meyering.net>
511 Fix a bug whereby a user with write access to a directory being removed
512 could cause the removal of that directory to fail with an erroneous
513 diagnostic about a directory cycle. Reported by Vineet Chadha.
515 * NEWS: Mention this.
516 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
517 leave (and try to rmdir) is the one whose dev_ino is being used to
518 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
520 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
522 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
523 * src/dd.c (set_fd_flags): Handle file-creation flags on file
524 descriptors, rather than ignoring them.
525 * tests/dd/misc: Add test cases for append, nofollow, directory,
526 and nolinks flags. Simplify redirection to /dev/null in some cases.
528 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
529 noatime test never tested anything.
531 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
533 * src/dd.c (flags, usage): New flags directory, nolinks.
534 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
536 * src/ls.c (usage): Mention that -f disables --color.
537 Problem reported by Niels Möller.
539 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
541 * man/*.x: Add references to syscalls from utilities of the same name.
543 2006-03-05 Jim Meyering <jim@meyering.net>
545 * tests/help-version: Set SHELL, if not already set, in order to
546 avoid failure when `make check' is run through debuild; dircolors
547 would fail due to lack of $SHELL. Reported by Sven Joachim.
549 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
550 * src/base64.c (wrap_write, do_encode, main): Change type of
551 parameters and locals, wrap_column, form size_t to uintmax_t.
552 (main): Adjust to use xstrtoumax, accordingly.
554 2006-03-03 Jim Meyering <jim@meyering.net>
556 Don't fail when run from an environment with SHELL not a Bourne
557 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
558 * tests/dircolors/simple: Invoke each non-failing test with -b.
559 Reported by Michael Stone.
561 2006-02-27 Jim Meyering <jim@meyering.net>
563 * tests/misc/base64: Derive --decode-using tests from the
566 * tests/misc/base64: Factor out a long constant string.
567 Split lines to stay within 80 columns.
569 * tests/misc/Makefile.am (TESTS): Add base64.
570 * tests/misc/base64: Test base64. From Simon Josefsson.
572 * src/base64.c (do_decode): Use correct type for parameter,
573 ignore_garbage: s/size_t/bool/.
575 * src/base64.c: Don't include .h files already included by system.h:
576 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
577 Include "system.h" before the other lib/*.h header files.
578 Include <sys/types.h> before "system.h".
579 (wrap_write): Remove declaration of unused local, initial_column.
580 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
582 * README: Add base64 to the list.
584 2006-02-17 Simon Josefsson <jas@extundo.com>
587 * AUTHORS: Mention base64.
589 * man/Makefile.am: Build base64.1.
590 * man/base64.x: New file.
591 * src/Makefile.am (bin_PROGRAMS): Add base64.
592 * src/base64.c: New file.
594 2006-02-25 Eric Blake <ebb9@byu.net>
596 In ls, avoid calling stat for --inode (-i), when possible.
597 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
598 * src/system.h: ... here, for use in ...
599 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
601 (gobble_file): Add inode argument.
602 (print_dir): Pass inode if available.
603 (usage): Remove inaccuracy.
605 2006-02-23 Jim Meyering <jim@meyering.net>
607 * TODO: Update/correct some obsolete entries.
609 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
611 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
612 * src/join.c (usage): Likewise.
613 Documentation problem reported by Philip Kensche.
615 2006-02-20 Eric Blake <ebb9@byu.net>
617 * man/rm.x: Update documentation to match previous patch.
619 2006-02-18 Eric Blake <ebb9@byu.net>
621 New option for rm: --interactive=once (-I).
622 * NEWS: Document it, along with change to rm --interactive.
623 * TODO: Remove entry for implementing rm -I
624 * src/rm.c (INTERACTIVE_OPTION): New enum value.
625 (interactive_type): New enum.
626 (long_opts): Let interactive take an optional argument.
627 (interactive_args, interactive_types): New option arguments.
628 (usage): Document -I, --interactive=WHEN. Use program_name
629 instead of a basename.
630 (main): New -I option, new behavior to --interactive.
631 * tests/rm/interactive-once: New tests.
632 * tests/rm/interactive-always: Ditto.
633 * tests/rm/Makefile.am (TESTS): Run them.
635 2006-02-18 Jim Meyering <jim@meyering.net>
637 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
638 expression match more of the target lines, e.g., those that start with
639 `-S,' (short option followed by a comma) or that include `=[...]'.
640 Patch by Nicolas François.
641 Fix the four offenders thus exposed:
642 * src/join.c (usage): Use two spaces (not one) to separate the
643 --first-only option string from its description, so help2man formats
644 the derived man page properly.
645 * src/pr.c (usage): Likewise.
646 * src/uniq.c (usage): Likewise.
647 * src/install.c (usage): Likewise.
649 2006-02-15 Jim Meyering <jim@meyering.net>
651 * Makefile.maint (alpha beta major): For `make major', ensure that the
652 version string is of the form N.N[.N]*, where N is one or more digits.
654 2006-02-14 Jim Meyering <jim@meyering.net>
656 * INSTALL: Update from gnulib.
658 2006-02-13 Jim Meyering <jim@meyering.net>
660 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
662 2006-02-12 Jim Meyering <jim@meyering.net>
664 * Makefile.maint (patch-check): New target.
665 (local-checks-available): Add to the list.
667 2006-02-11 Jim Meyering <jim@meyering.net>
669 * src/c99-to-c89.diff: New file.
670 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
672 * .x-po-check: New file, with exclusions so that `make distcheck'
674 * Makefile.am (EXTRA_DIST): Add .x-po-check.
676 rm -r must remove an empty directory, even if it is inaccessible.
677 * src/remove.c (close_preserve_errno): New function.
678 (fd_to_subdirp): Don't print a diagnostic in this function.
679 Do it from the callers instead, unless rmdir succeeds.
680 (remove_cwd_entries, remove_dir): Adjust callers.
681 * tests/rm/empty-inacc: New test for the above.
682 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
683 * NEWS: Mention this bug fix.
684 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
685 a tiny bit less precise: cannot remove `a/1': ... instead of
686 cannot open directory `a/1': ...
688 * Makefile.maint (syntax-check-rules): Automatically derive this
689 list of sc_-prefixed rule names.
691 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
693 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
694 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
695 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
696 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
697 go away? was that an accident?)
698 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
699 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
700 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
701 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
702 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
703 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
704 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
705 (author_mark_check, makefile_path_separator_check):
706 Output line numbers, to simplify navigation of Emacs *compilation*
708 (sc_prohibit_atoi_atof, sc_file_system):
709 Rework slightly so that Makefile.maint doesn't get reported as a
710 violation of its own syntax rules.
711 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
712 it at run-time (which didn't work with Bison). Fix a makefile typo,
713 caught by Makefile.maint itself: spaces where a tab should be.
714 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
715 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
716 Ignore djgpp and man subdirectories, to avoid false matches with
717 Bison and coreutils, respectively. Use sort -u to remove the
718 resulting duplicates.
719 * gnupload: Rework slightly to avoid bogus warning from
720 sc_two_space_separator_in_usage.
722 2006-02-10 Jim Meyering <jim@meyering.net>
724 Use gzip's --rsyncable option only if it's available.
725 * Makefile.maint (gzip_rsyncable): New variable.
728 2006-02-08 Jim Meyering <jim@meyering.net>
730 * Makefile.maint (local-checks-available): Define in terms of
731 the expansion, $(syntax-check-rules), rather than the single,
732 top-level target `syntax-check', so that it's easier to exclude
733 individual rules (via $(local-checks-to-skip)).
734 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
736 2006-02-07 Jim Meyering <jim@meyering.net>
738 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
739 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
741 * tests/help-version (expected_failure_status_vdir):
742 Redirect an expected disk-full diagnostic to /dev/null.
744 2006-02-06 Jim Meyering <jim@meyering.net>
746 * src/unexpand.c (usage): Use two spaces (not one) to separate the
747 --first-only option string from its description, so help2man formats
748 the derived man page properly.
749 * src/rm.c (usage): Likewise for --no-preserve-root.
750 * src/chown.c (usage): Likewise.
751 * src/chgrp.c (usage): Likewise.
753 Add a rule to ensure that the above doesn't happen again.
754 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
755 (syntax-check-rules): Add it.
756 * .x-sc_two_space_separator_in_usage: New empty file.
757 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
759 2006-02-06 Jim Meyering <jim@meyering.net>
761 * src/cp.c (usage): Use two spaces (not one) to separate each
762 option string from its description, so help2man formats the
763 derived man page properly.
764 * src/mv.c (usage): Likewise.
765 Patch from Nicolas François in http://bugs.debian.org/351601.
767 2006-02-04 Jim Meyering <jim@meyering.net>
769 * src/copy.c (copy_internal): cp -RL would fail when encountering
770 the same directory more than once in the hierarchy beneath a single
771 command-line argument. That is legitimate, e.g. when there are
772 two or more symbolic links, each pointing to some directory that
773 would not otherwise be copied. Reported by Christophe LYON.
774 * tests/cp/cp-deref: New file. Test for today's fix.
775 * tests/cp/Makefile.am (TESTS): Add cp-deref.
776 * NEWS: Document this.
778 2006-02-03 Jim Meyering <jim@meyering.net>
780 * configure.ac: Require automake-1.9.6, not 1.8.3.
782 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
784 * src/od.c (usage): Mention that -t a ignores high order bit.
785 Documentation problem reported by Ed Avis.
787 2006-02-01 Jim Meyering <jim@meyering.net>
789 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
791 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
793 * src/head.c (main): Use a better diagnostic when someone uses a
794 trailing numeric option in an invalid way. Problem reported by
796 * src/tail.c (parse_options): Likewise.
798 2006-01-30 Jim Meyering <jim@meyering.net>
800 * man/wc.x: Include `count' keyword in man page synopsis,
801 per suggestion from http://bugs.debian.org/181585.
803 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
805 * src/df.c (show_dev): If the file system claims to have
806 more available than total blocks, report the number of used
807 blocks as being total - available (a negative number) rather
808 than as garbage. Problem reported by Toralf Foerster.
810 2006-01-24 Jim Meyering <jim@meyering.net>
812 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
813 to put a regular file in O_NONBLOCK mode fails with EPERM.
814 That happens on Linux (up to 2.6.15) when using tail -f on a file with
815 the append-only attribute. Reported by Dean Gaudet. For details,
816 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
817 * NEWS: Mention this fix.
818 * tests/tail-2/append-only: New file. Test for the above.
819 * tests/tail-2/Makefile.am (TESTS): Add append-only.
820 * tests/Makefile.am (check-root): Add tail-2/append-only
822 2006-01-21 Jim Meyering <jim@meyering.net>
824 * NEWS: Mention fts-related improvements and bug fixes.
826 2006-01-19 Jim Meyering <jim@meyering.net>
828 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
829 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
831 2006-01-18 Jim Meyering <jim@meyering.net>
833 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
835 2006-01-17 Jim Meyering <jim@meyering.net>
837 Now that fts no longer changes the current working directory, adjust
838 its clients accordingly -- note that du.c uses fts but doesn't need
839 any adjustment, since it doesn't operate on the actual files,
840 but rather just uses the stat buffers provided by fts.
842 * src/chown-core.c: Include "openat.h".
843 Don't include "lchown.h".
844 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
845 calling openat, lchownat, chownat, rather than open, lchown, chown.
847 * src/chmod.c: Include "openat.h".
848 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
850 * tests/du/long-from-unreadable: New test, to exercise one small
853 2006-01-13 Jim Meyering <jim@meyering.net>
855 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
856 addition of new directories under tests/.
858 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
861 2006-01-12 Jim Meyering <jim@meyering.net>
863 * tests/du/long-sloop: Adjust not to hard-code the expected
864 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
865 from that of GNU libc. Reported by Paul Eggert.
867 * tests/du/long-sloop: Create file at end of symlink chain.
869 * tests/misc/test: New file, with a test for one of the
870 bugs fixed by yesterday's test.c changes.
871 * tests/misc/Makefile.am (TESTS): Add test.
873 2006-01-11 Jim Meyering <jim@meyering.net>
875 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
876 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
877 a very long sequence of symbolic links (not necessarily a loop).
878 * tests/du/Makefile.am (TESTS): Add long-sloop.
880 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
882 * src/test.c (test_syntax_error): Append a newline. All callers
883 changed, except for the ones that didn't already append a newline.
884 Bug reported by Eric Blake.
886 2006-01-11 Jim Meyering <jim@meyering.net>
888 * src/system.h (X2NREALLOC): Now that verify_true is no longer
889 void, cast its result to void, to avoid gcc's warning that
890 ``left-hand operand of comma expression has no effect''.
891 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
893 2006-01-10 Jim Meyering <jim@meyering.net>
895 * tests/chmod/no-x: Add a test for today's fts.c fix.
897 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
899 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
900 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
902 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
904 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
905 Use verify_true instead of verify_expr, to sync with gnulib.
907 2006-01-08 Jim Meyering <jim@meyering.net>
909 * src/date.c (usage): Adjust the formatting of the entries for
910 %::z and %:::z (separate with two spaces, not one) so that help2man
911 formats them properly. Reported by Philip Rowlands.
913 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
915 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
917 2006-01-06 Jim Meyering <jim@meyering.net>
919 * Makefile.maint (copyright-check): Use date +%Y in place of
922 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
923 First off, the attribute should have been `volatile' (not static)
924 to avoid longjmp-related risk of clobber. Secondly, now there is
925 no longer any risk of a local variable being clobbered, so there's
926 no need for any attribute at all.
928 2006-01-05 Jim Meyering <jim@meyering.net>
930 * src/remove.c: Give a few functions the inline attribute.
931 (AD_pop_and_chdir): Use gotos to avoid some duplication.
932 (AD_push): Rewrite an assertion so that the entire computation
933 goes away when assertions are turned off.
935 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
936 It's already defined in "system.h".
937 * Makefile.maint: Add a FIXME comment.
939 2006-01-04 Jim Meyering <jim@meyering.net>
941 * ChangeLog: Remove entries from 2005-10-22 and earlier.
942 * ChangeLog-2005: New file, for entries up to version 5.92.
944 2006-01-03 Jim Meyering <jim@meyering.net>
946 * tests/du/no-x: Also allow a slightly different diagnostic -- the
947 one you get when using openat-enabled fts.c and du (coming soon).
948 * tests/chmod/no-x: Likewise.
949 * tests/chgrp/no-x: Likewise.
951 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
953 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
955 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
956 (restricted_chown): Return it, if the file cannot be accessed due
957 to EPERM, or if no uid or gid are required, or if the file is
958 neither a directory nor a regular file. Rewrite to avoid gotos.
959 (change_file_owner): Handle RC_do_ordinary_chown case.
960 Rewrite to avoid gotos.
961 * tests/chgrp/basic: Make sure we can change the group of
964 * src/date.c (usage): Explain %g, %G, and %V a bit better.
966 2006-01-02 Jim Meyering <jim@meyering.net>
968 * src/copy.c (set_owner): Correct a comment.
970 * src/tail.c (parse_options): Change warning to say that --retry
971 is useful `mainly' (not `only') when following by name.
972 Reported here: http://bugs.debian.org/273781
974 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
976 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
977 * src/copy.c: Include lchmod.h.
978 (copy_internal): Use lchmod rather than chmod.
979 * src/cp.c: Include lchmod.h.
980 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
981 * src/mkdir.c: Include lchmod.h.
982 (usage): Clarify -m's operation.
983 (main): Use lchmod rather than chmod. Don't use lchmod unless the
984 new mode contains bits outside the 777 range.
985 * src/mkfifo.c (usage): Clarify -m's operation.
986 (main): If -m is given, don't invoke chmod; use umask 0 instead.
987 Report an error if -m asks for bits outside the 777 range.
988 * src/mknod.c (usage, main): Likewise.
990 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
992 2005-12-27 Jim Meyering <jim@meyering.net>
994 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
995 (sc_prohibit_assert_without_use): New rule.
996 (syntax-check-rules): Add it to the list.
997 * .x-sc_prohibit_assert_without_use: New empty file.
998 * Makefile.am (EXTRA_DIST): Add it.
1000 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
1002 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
1003 Don't include <assert.h>; it wasn't used.
1005 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
1007 * src/chown-core.c (restricted_chown):
1008 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
1009 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
1010 | O_NOFOLLOW too, for consistency with other dir-openers.
1011 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
1012 (is_empty_dir): Likewise.
1013 * src/shred.c (wipename): Likewise. Don't bother trying to open
1014 dir for writing, since POSIX prohibits it.
1016 2005-12-22 Jim Meyering <jim@meyering.net>
1018 * tests/help-version: Redirect stderr to /dev/full, to suppress
1019 write error diagnostic.
1021 2005-12-19 Jim Meyering <jim@meyering.net>
1023 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
1024 Avoid a minor race condition when `-m MODE' is specified, by using
1025 open, fchown, and close rather than just chown. To do that reliably --
1026 even with an overly restrictive umask -- ensure that each mkdir,
1027 mknod and mkfifo call uses a mode including at least owner-read access.
1028 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
1029 the subsequent chown (or equivalent open,fchown,close) fails.
1030 * tests/misc/mknod: New tests.
1031 * tests/misc/Makefile.am (TESTS): Add mknod.
1033 2005-12-17 Jim Meyering <jim@meyering.net>
1035 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
1036 e.g., on a named pipe.
1037 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
1038 place of all uses, since it is guaranteed (system.h) to be defined.
1040 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
1042 Add POSIX ACL support
1043 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
1044 is no requirement for ACL support; particularly, it does not exist
1045 on systems that have POSIX ACLs.
1046 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1047 * src/cp.c (umask_kill): With default acls, the umask is not to be
1048 applied. Remove umask_kill, don't change the process umask, and let
1049 the kernel apply the umask where appropriate.
1050 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1051 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1053 (copy_reg, copy_internal): Use copy_acl and set_acl
1054 instead of fchown/chown. Fix the logic for POSIX ACLs.
1055 (chown_succeded): Remove; we now always copy acls and
1056 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1057 did a chown before or not.
1058 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1059 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1060 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1061 to link with it via $(LIB_ACL), for the utilities that need it.
1063 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1065 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1066 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1067 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1068 value is now signified by whether cwd_errno is null.
1069 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1070 pointer-to-bool to pointer-to-errno-value. All callers changed.
1071 (rm_1): Don't bother setting a local cwd failure flag and then
1072 ORing it into the caller's. Just set the caller's.
1073 (rm): Use cwd failure errno value to print a slightly-better
1076 2005-12-15 Jim Meyering <jim@meyering.net>
1078 * src/stat.c (print_it): Properly handle a backslash at the
1079 end of a --printf format string. Reported by Paul Eggert.
1080 * tests/misc/stat-printf (end-bs): Add a test for the above.
1082 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1084 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1085 Don't assume /etc/passwd contains user names; use 'id' instead.
1087 2005-12-15 Jim Meyering <jim@meyering.net>
1089 stat: revert behavior of --format=FMT (-c)
1090 stat: add new option: --printf=FMT
1091 * NEWS: Mention this.
1092 * src/stat.c (isodigit, octtobin, hextobin): Define.
1093 (PRINTF_OPTION): Define.
1094 (interpret_backslash_escapes, trailing_delim): New globals.
1095 (usage): Document them. Alphabetize on long option names.
1096 (print_esc_char): New function.
1097 (print_it): Rewrite, in order to handle backslash escapes.
1098 (main): Handle new option. Set globals for --format, too.
1100 * tests/misc/stat-printf: Test --printf and --format.
1101 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1103 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1105 * NEWS: sort now reports incompatible options.
1106 * src/sort.c (incompatible_options, check_ordering_compatibility):
1108 (main): Use them. Don't bother with a usage message for
1109 "sort -c a b", for consistency with other error diagnostics.
1110 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1113 * src/cat.c (main): Undo previous change. close_stdout already
1114 does the check, so the previous change wasn't necessary.
1116 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1118 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1120 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1122 Install a more-conservative approach for sort -R. It's the
1123 same basic idea as the existing code, except it uses the full ISAAC
1124 approach (called the "more kosher" approach in the existing comments).
1125 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1126 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1127 better to be conservative here at first, and review any performance
1128 improvements carefully.
1129 * .x-sc_require_config_h: Add src/rand-isaac.c.
1130 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1131 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1132 (shred_SOURCES, sort_SOURCES): Remove.
1133 (EXTRA_DIST): Add rand-isaac.c.
1134 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1135 changing it to allow for varying numbers of words in the state.
1136 Alter so that we include rand-isaac.c directly rather than
1137 compiling it and linking to it. Don't include config.h or
1138 system.h; that's the includer's responsibility.
1139 Omit functions that are specific to shred.
1140 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1141 (isaac_step, struct irand_state):
1142 Resurrect these, with the same defns that used to be in shred.c.
1143 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1144 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1146 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1147 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1148 (irand_init, irand32, irand_mod):
1149 Number of words is constant again.
1150 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1151 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1152 * src/sort.c: Likewise.
1153 * src/shred.c (fillrand, dopass, main): Undo previous change.
1154 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1156 * src/sort.c: Don't include md5.h; it wasn't needed.
1157 (struct keyfield): Rename random_hash to random, for consistency
1158 with the other member names. All uses changed.
1159 (usage): Tweak wording to mention STRING for --seed option.
1160 (short_options): Rorder for consistency with other programs.
1161 (rand_state): Now a struct, not a pointer to one. All uses changed.
1162 (HASH_WORDS, HASH_SIZE): Remove.
1163 (get_hash): Remove comments around resbuf size, since we can assume C89.
1164 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1165 (keycompare): Adjust to the new get_hash.
1167 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1168 (main): Don't set need_random simply because gkey has it set; that
1169 doesn't necessarily mean we'll need random numbers.
1170 Redo seeding to match new get_hash approach.
1172 2005-12-10 Jim Meyering <jim@meyering.net>
1174 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1176 Avoid shred segfault on 64-bit systems.
1177 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1178 local of type uint32_t. Make the local an `int' instead.
1180 * NEWS: Mention sort's new options.
1182 * src/rand-isaac.c (isaac_mix): Declare to be static.
1183 Mark all other functions as `extern' so the tight-scope
1184 part of `make distcheck' passes once again.
1185 * src/rand-isaac.h (isaac_mix): Remove declaration.
1187 * src/sort.c (get_hash): Change position of `*' in parameter
1188 type to conform with convention.
1189 (main): Split a long line so it fits in 80 columns.
1190 (keycompare): Remove stray SPACE before TAB that was
1191 causing `make distcheck' to fail.
1193 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1195 * tests/misc/sort-rand: New file: basic tests for the new options.
1196 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1198 2005-12-10 Frederik Eaton <frederik@ofb.net>
1200 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1201 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1202 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1203 Make state size runtime-configurable.
1204 (isaac_new, isaac_copy): New functions.
1205 * src/rand-isaac.h: New file.
1206 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1207 (fillrand, main): Adjust to the fact that the state size is now
1208 runtime-configurable.
1209 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1210 (usage): Add options --random-sort and --seed to implement a random
1212 Include md5.h and rand-isaac.h.
1213 (get_hash): New function.
1214 (rand_state): New var.
1215 (HASH_WORDS, HASH_SIZE): New macros.
1217 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1219 * tests/dd/misc: Add test for dd iflags=noatime.
1221 2005-12-09 Jim Meyering <jim@meyering.net>
1223 * src/sort.c (usage): Mention white space vs -b and -t options.
1226 2005-12-09 Eric Blake <ebb9@byu.net>
1228 * src/test.c (main): Fix misleading comment.
1230 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1232 * NEWS: Mention dd's new noatime flag.
1233 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1234 * src/dd.c (flags, usage): Add support for noatime flag.
1236 2005-12-07 Jim Meyering <jim@meyering.net>
1238 Distribute the cvsu script, used only by `make syntax-check'.
1239 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1240 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1241 distribute a copy of this script.
1242 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1244 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1245 to create a temporary directory on another partition.
1246 From Andreas Gruenbacher.
1248 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1250 * man/basename.x: Cross-reference to dirname and readlink.
1251 * man/dirname.x: Cross-reference to basename and readlink.
1253 2005-12-05 Andreas Gruenbacher
1255 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1256 (set_owner, preserve_author): New functions, factored out of copy_reg.
1257 (copy_reg): Use them.
1258 (copy_internal): Use them here, too.
1260 2005-12-04 Jim Meyering <jim@meyering.net>
1262 * src/sleep.c (usage): Say what happens with two or more arguments.
1263 Suggested by Justin Pryzby.
1265 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1268 2005-12-03 Jim Meyering <jim@meyering.net>
1270 * src/rm.c (long_opts): Change the name of each undocumented, for-
1271 testing-only option to start with `-', so that it cannot render
1272 ambiguous any prefix it happens to share with some other option name.
1273 Problem reported by Eric Blake.
1274 * src/head.c (long_options): Likewise.
1275 * src/tail.c (long_options): Likewise.
1277 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1278 testing-only --presume* options to start with `---'.
1279 * tests/rm/dangling-symlink: Likewise.
1280 * tests/rm/dir-no-w: Likewise.
1281 * tests/rm/isatty: Likewise.
1283 2005-11-30 Jim Meyering <jim@meyering.net>
1285 * Makefile.maint: Add a comment about cvsu.
1287 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1289 * NEWS: df updates for "none", "proc", inaccessible file systems.
1290 * src/df.c (show_point): Ignore inaccessible file systems.
1291 (usage): -a includes dummy file systems, not size-0 file systems.
1293 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1294 to avoid collision with POSIX name space. All uses changed.
1296 2005-11-24 Jim Meyering <jim@meyering.net>
1298 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1299 * tests/acl: Add `$0: ' prefix to diagnostics.
1301 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1303 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1305 * src/copy.c: Improve performance a bit by optimizing away
1306 unnecessary system calls and going to a block size of at least
1307 8192 (on normal hosts, anyway). This improved performance 5% on my
1308 Debian stable host (2.4.27 kernel, x86, copying from root
1309 ext3 file system to itself).
1310 Include "buffer-lcm.h".
1311 (copy_reg): Omit last argument. All callers changed.
1312 Use xmalloc to allocate rather than trusting alloca
1313 (which is unwise with large block sizes).
1314 Declare locals more locally, if possible.
1315 Use uintptr_t words instead of int words, for a bit more speed
1316 when looking for null blocks on 64-bit hosts.
1317 Optimize away reads of zero bytes on regular files.
1318 In the typical case, insist on 8 KiB buffers, at least.
1319 Avoid unnecessary extra call to fstat when checking for sparse files.
1320 Avoid now-unnecessary cast to off_t, and "0L".
1321 Avoid unnecessary test of *new_dst when checking for same owner
1324 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1326 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1328 2005-11-22 Jim Meyering <jim@meyering.net>
1330 * src/remove.c (AD_push): Remove debugging cruft.
1332 * tests/rm/unread2 (rm): Change expected diagnostic,
1333 `cannot open directory' to `cannot remove', to align with
1335 * tests/rm/rm2: Ensure that rm now continues removing entries
1336 even after certain types of failure.
1338 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1339 that provide openat (Solaris), and on systems like Linux+procfs
1340 where our openat emulation code is reentrant. This also fixes a
1341 few low-probability leaks and eliminates some code that could,
1342 in very unusual circumstances, cause rm() (via a callee) to exit.
1343 * NEWS: Mention this.
1345 * configure.ac: Put copyright dates all on one line so the
1346 emacs function that updates them works properly.
1348 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1350 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1351 Problem reported by Eric Blake.
1352 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1353 we get a standard-conforming compiler. This relies on the new
1354 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1355 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1356 m4/c.m4 can go away with Autoconf 2.60 comes out.
1358 2005-11-17 Jim Meyering <jim@meyering.net>
1360 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1361 (AD_mark_current_as_unremovable): Likewise, but for a local.
1364 * tests/mv/acl: Let traps handle removing temporary directories.
1366 Expect acl-related tests to fail, until the corresponding
1367 patches are committed.
1368 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1369 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1371 ACL tests, from Andreas Gruenbacher.
1372 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1373 * tests/mv/Makefile.am (TESTS): Add acl.
1374 * tests/cp/Makefile.am (TESTS): Add acl.
1376 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1378 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1380 * NEWS: Improve quality of ln's diagnostics.
1381 * src/ln.c (do_link, usage): Likewise.
1382 (do_link): Don't use alloca on a buffer of unbounded size.
1384 2005-11-16 Jim Meyering <jim@meyering.net>
1386 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1387 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1388 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1389 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1390 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1392 2005-11-14 Jim Meyering <jim@meyering.net>
1394 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1396 2005-11-13 Jim Meyering <jim@meyering.net>
1398 * announce-gen: Accept new option, --gpg-key-id=ID and
1399 emit a blurb telling how to use the .sig files.
1400 * Makefile.cfg (gpg_key_ID): Define.
1401 * Makefile.maint (announcement): Use new option and key.
1403 Require that most .c files include <config.h>.
1404 * Makefile.maint (sc_require_config_h): New rule.
1405 (syntax-check-rules): Add it.
1406 * .x-sc_require_config_h: New file listing exceptions to the
1407 above rule. Some are legit, others are simply grandfathered in.
1408 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1410 2005-11-12 Jim Meyering <jim@meyering.net>
1412 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1414 2005-11-11 Jim Meyering <jim@meyering.net>
1416 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1417 Mention new readlink options in 5.3.0's `New features' section.
1418 Spotted by Thomas Hood.
1420 2005-11-08 Jim Meyering <jim@meyering.net>
1422 * NEWS: Merge in changes from b5_9x branch.
1424 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1426 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1427 like --time-style='posix-long-iso' if the locale settings are messed up.
1428 * src/ls.c (decode_switches): Implement this.
1430 2005-11-08 Jim Meyering <jim@meyering.net>
1432 * tests/du/2g: s/expensive/very expensive/ in a comment.
1435 2005-10-17 Eric Blake <ebb9@byu.net>
1437 * src/ls.c (usage): Fix descriptions of --sort, --time.
1438 Reported by Vitaly A. Ostanin.
1440 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1442 * src/ln.c: Include filenamecat.c.
1443 (FILE_BASENAME_CONCAT): Remove.
1444 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1445 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1446 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1449 2005-11-04 Jim Meyering <jim@meyering.net>
1451 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1452 on systems with stat.st_blocks of a signed 32-bit type.
1453 This bug causes trouble on some AIX 5.1 systems.
1454 Report and trivial patch from Paul Townsend:
1455 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1456 * NEWS: Mention this.
1458 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1459 * tests/du/Makefile.am (TESTS): Add it here.
1460 * tests/very-expensive: New file.
1461 * tests/Makefile.am (EXTRA_DIST): Add it here.
1462 * tests/cp/perm: Mark this test as `very-expensive', too.
1464 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1466 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1468 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1470 * src/rm.c (usage): Don't mention rm -d.
1472 2005-11-02 Jim Meyering <jim@meyering.net>
1474 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1475 From Andreas Schwab.
1477 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1478 `M+N records in/out' lines don't pollute `make check' output.
1480 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1481 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1482 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1483 to indicate that the input file should be piped into the command
1484 under test (via `cat FILE | $prog ...').
1486 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1487 (without -r) fails to remove a directory on a non-Linux system.
1488 This change affects only newer Solaris systems (with priv_*
1489 functions like priv_allocset). Reported by Keith Thompson.
1491 * tests/rm/dir-nonrecur: New file/test for the above fix.
1492 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1494 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1496 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1497 POSIX 1002.1-2001 requires.
1498 * src/tail.c (parse_obsolete_option): Implement this.
1499 Problem reported by Vincent Lefevre.
1500 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1501 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1502 (test_vector): Add special cases for _POSIX2_VERSION, and
1503 regularize the old ones a bit.
1504 * tests/touch/obsolescent: Add y2000 test.
1506 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1508 * src/dd.c (skip): Fix off-by-one error reported by
1509 Theodoros V. Kalamatianos.
1511 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1513 * tests/mkdir/p-3: Require that the test be run as non-root.
1514 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1516 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1518 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1519 boundary between DEST and SOURCE in the result.
1521 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1523 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1524 back to text, to sync with documentation and for backwards
1527 2005-10-25 Jim Meyering <jim@meyering.net>
1529 * tests/dircolors/simple (other-wr): Add an explicit test for
1530 the dircolors bug (NULL-dereference) fixed yesterday.
1532 2005-10-24 Jim Meyering <jim@meyering.net>
1534 * src/tac.c (tac_file): When determining whether a file is seekable,
1535 also test whether it is a tty. Using only the lseek-based test would
1536 give a false positive on Solaris. Reported by Peter Fales.
1538 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1540 * tests/install/d-slashdot: New test, for "install -d" failure.
1541 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1542 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1543 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1545 2005-10-24 Jim Meyering <jim@meyering.net>
1547 * src/dircolors.c (ls_codes): Add missing comma.
1548 Anonymous report and patch from
1549 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1551 * src/dircolors.c: Add compile-time assertion that the slack_codes
1552 and ls_codes arrays have the same number of elements. This would
1553 have prevented the above-fixed bug.
1555 * src/expand.c (parse_tab_stops): Add a comment to make this function
1556 identical to the one in unexpand.c.
1557 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1558 identical to the one in expand.c.
1560 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1562 2005-10-23 Jim Meyering <jim@meyering.net>
1564 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1565 a dangerous pointer-value-to-`unsigned' cast.
1566 * NEWS: mention the new sha* programs.
1567 * AUTHORS: Add new sha* programs.
1569 2005-08-28 David Madore <david.madore@ens.fr>
1571 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1572 * README: Add their names to the list.
1573 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1574 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1575 Rules for compiling sha-2 utilities
1576 (noinst_HEADERS): Remove checksum.h.
1577 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1579 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1580 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1581 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1582 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1583 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1584 sha384sum, sha512sum test scripts here rather that each in its
1587 2005-08-28 David Madore <david.madore@ens.fr>
1589 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1590 of the FIPS test vectors).
1592 2005-10-23 Jim Meyering <jim@meyering.net>
1594 * configure.ac: Use 6.0-cvs as the version string.
1595 * NEWS: Adjust accordingly.