1 2006-08-08 Paul Eggert <eggert@cs.ucla.edu>
3 Add a command 'shuf', and modify shred and sort to use the new
4 random number generator library of 'shuf'.
8 * NEWS: Likewise. Mention new --random-source option for shred
9 and sort. Move "sort +1 -2" notice to the appropriate section,
10 and clarify its role with respect to POSIXLY_CORRECT.
11 * man/.cvsignore: Add shuf.1.
12 * man/Makefile.am (dist_man_MANS): Add shuf.1.
13 (shuf.1): New dependency.
14 * man/shuf.x: New file.
15 * src/Makefile.am (bin_PROGRAMS): Add shuf.
16 (EXTRA_DIST): Remove rand-isaac.c.
17 (shuf_LDADD): New macro.
18 * src/rand-isaac.c: Remove, moving most of its contents to
20 * src/shuf.c: New file.
21 * src/shred.c: Use new random-number interface rather than rand-isaac.c.
22 Don't include rand-isaac.c; include randint.h and randread.h instead.
23 (RANDOM_SOURCE_OPTION): New enum.
24 (long_opts, usage, main): New option --random-source.
25 * src/sort.c: Likewise.
26 * src/shred.c (struct irand_state, irand_init, irand32, irand_mod): Remove.
27 All callers changed to use randint interface.
28 (fillrand): Remove. All callers changed to use randread interface.
29 (dopass): Remove dependency on ISAAC buffer size.
30 (genpattern): Don't wipe the random state here.
31 (randint_source): New static var.
32 (clear_random_data): New function.
33 (main): Allocate random source, and arrange to wipe it on exit.
34 * src/sort.c: Include md5.h, randread.h, xmemxfrm.h.
35 (longopts, usage, main): Remove undocumented --seed option;
36 it's now replaced by --random-source.
37 (rand_state, get_hash): Remove.
38 (randread_source): New static var.
39 (random_state, cmp_hashes, compare_random): New functions; they guarantee
40 no collisions in the random hash function.
41 (keycompare): Use compare_random for -R; don't fall back on comparing
42 via memcoll, since compare_random does the right thing.
43 * tests/misc/Makefile.am (TESTS): Add shuf.
44 * tests/misc/shuf: New file.
46 2006-07-29 Paul Eggert <eggert@cs.ucla.edu>
48 * src/copy.c (set_author): Preserve the st_author field via the
49 file descriptor dest_desc.
51 2006-07-28 Paul Eggert <eggert@cs.ucla.edu>
53 * NEWS: chmod now preserves setuid and setgid bits on directories
54 if you use a numeric mode with them clear, e.g., "chmod 755 DIR".
56 Fix test case problems if working directory is setgid,
57 reported by Bob Proulx.
58 * tests/cp/fail-perm: Use symbolic mode so that we clear
59 setgid bit more reliably on directories.
60 * tests/mkdir/special-1 (set_mode_string): Likewise.
62 2006-07-27 Jim Meyering <jim@meyering.net>
64 * src/chgrp.c (usage): Use correct grammar in description of the
66 * src/chown.c (usage): Likewise.
68 2006-07-26 Thomas Schwinge <tschwinge@gnu.org> (tiny change)
70 * src/copy.c (set_author) [HAVE_STRUCT_STAT_ST_AUTHOR]:
71 Correctly access SRC_SB's element ST_AUTHOR.
73 2006-07-26 Jim Meyering <jim@meyering.net>
75 * tests/ls/stat-failed: Adapt to match new expected output.
78 * src/ls.c (print_color_indicator): Test for S_IFREG first, rather
79 than having the code test for all of the other types first.
80 Hoist the set-uid/gid-testing code "up" into this new block.
81 Classify any other type of file (e.g., S_TYPEISSHM, etc.) as
82 C_ORPHAN, not as C_FILE.
84 2006-07-26 Jim Meyering <jim@meyering.net>
86 Checking in a change from Paul.
88 2006-07-25 Paul Eggert <eggert@cs.ucla.edu>
90 * src/ls.c (DT_INIT): Remove. All uses removed.
91 (enum filetype): Use an ordinary enum rather than trying to keep
92 the values in sync with DT_FIFO etc. That way, we don't have
93 to make special assumptions about them. All uses changed.
94 (whiteout): New constant member of enum filetype.
95 (filetype_letter): New constant, for use with enum filetype.
96 (FILETYPE_INDICATORS): New initializer list.
97 (print_dir): Add case for DT_WHT.
98 (gobble_file): If stat fails, don't discard information from
99 readdir; instead, preserve it so it can be printed.
100 (print_long_format): Fall back on readdir result if stat info
101 is not available. Use "?" to denote each unknown mode char,
102 instead of an overall "?", since we now know some of the mode
104 (print_type_indicator): Now that MODE isn't necessarily
105 useful, guard all uses.
106 Now that two blocks in the type-checking tree can set "type = C_FILE",
107 move the suffix-handling code out and down.
109 2006-07-26 Jim Meyering <jim@meyering.net>
111 Prepare for the above change.
112 * src/ls.c [struct fileinfo] (stat_ok): Rename from stat_failed,
113 and adjust uses. From a patch by Paul Eggert.
115 2006-07-26 Jim Meyering <jim@meyering.net>
117 * src/ls.c: Correct indentation/formatting in a few places.
119 2006-07-25 Paul Eggert <eggert@cs.ucla.edu>
121 * tests/cp/fail-perm: Use "chmod 0500" rather than "chmod 500".
122 Problem report and fix from Bob Proulx.
123 * NEWS: Clarify the "chmod 0500" news, and correct the vague
124 statements about compatibility with BSD.
126 2006-07-25 Jim Meyering <jim@meyering.net>
128 * src/ls.c (gobble_file): When handling a stat-failed entry,
129 print the entry name not the absolute_name -- to be consistent
131 * tests/ls/stat-failed: Update accordingly.
133 * src/ls.c: Add parens around the new uses of ?: ternary operator.
135 * src/dircolors.hin: Mention that ORPHAN refers not just to dangling
138 Get --dired offsets right when handling stat-failed entries.
139 * src/ls.c (print_long_format): Be careful to increment P by the
140 appropriate amount, even when inode_number_width and nlink_width
142 * tests/ls/stat-failed: Test for the above.
144 * src/ls.c (gobble_file) [USE_ACL]: Don't use-uninitialized the
145 have_acl member. That would happen for a directory with both a
146 non-stat'able entry and one with an ACL.
148 * src/ls.c (gobble_file): Make it so failure to stat a
149 non-command-line file provokes an exit status of 1, not 0.
150 Say "cannot access" rather than "cannot stat".
151 * tests/ls/stat-failed: New file/test, for the above.
152 * tests/ls/Makefile.am (TESTS): Add stat-failed.
153 * tests/ls-2/tests (no-a-isdir-b): Update to reflect addition
154 of "cannot access " to diagnostic.
156 * src/ls.c: Declare stat_failed to be "bool", not "int" everywhere.
158 * src/ls.c [enum filetype] (command_line): Remove member. Not needed.
159 Replace all occurrences of "type == command_line" with the
160 equivalent, "command_line_arg".
162 * src/ls.c: Apply the stat-failed parts of Red Hat's
163 coreutils-selinux.patch. From Ulrich Drepper.
164 This makes it so files not mentioned on the command line (e.g.,
165 names read from a directory that *is* mentioned on the command
166 line) for which stat fails are still listed. With --color,
167 such files are colored just like ORPHANs (aka dangling symlinks).
169 * src/df.c (n_valid_args): Declare global to be static.
171 2006-07-24 Jim Meyering <jim@meyering.net>
173 * tests/ls/stat-dtype: Skip this test on reiserfs, since that file
174 system lacks d_type support.
176 2006-07-22 Paul Eggert <eggert@cs.ucla.edu>
178 * man/chmod.x: Update to reflect recent changes to coreutils.texi.
180 2006-07-21 Jim Meyering <jim@meyering.net>
182 * src/su.c (usage): Correct typo in --help output: s/commmand/command/
183 Reported by Tim Waugh.
184 Also remove the comment duplicating much of --help output.
186 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): Reposition this new
187 name so the list remains alphabetized.
189 Fix another bug: ls --indicator-style=file-type would call
190 stat for a symlink, even though it wasn't always needed.
191 In some cases, that unnecessary stat would cause ls to fail.
192 * src/ls.c (gobble_file): Don't treat symlinks specially (in
193 requiring a stat syscall). Remove the offending exclusion.
195 * NEWS: Mention the fix.
197 * tests/ls/stat-dtype: New file/test, for the above fix.
198 Also exercises the new df feature, below.
200 * src/df.c (main): Fail and don't print the headers if no
201 file system is processed. This makes it easy to test whether
202 a specified directory is on a file system of a given type or types.
203 Otherwise, applications would have had to parse df's output.
204 E.g., is "." either ext3 or reiserfs: df -t ext3 -t reiserfs .
206 Fix a bug: ls --file-type worked like --indicator-style=slash,
207 rather than like --indicator-style=file-type.
208 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): New enum member.
209 (long_options): Map "file-type" to FILE_TYPE_INDICATOR_OPTION,
211 (decode_switches): Handle new case: FILE_TYPE_INDICATOR_OPTION.
212 * NEWS: Mention the fix.
213 * tests/ls-2/tests (file-type): New test, for the above fix.
215 2006-07-19 Jim Meyering <jim@meyering.net>
217 * src/ls.c (print_dir): Give a better diagnostic for failed opendir.
219 * Makefile.am (EXTRA_DIST): Add build-aux/vc-list-files.
221 2006-07-16 Paul Eggert <eggert@cs.ucla.edu>
223 * NEWS: chmod, install, and mkdir now leave setgid and setuid bits
224 of directories alone unless you specify them explicitly.
225 install and mkdir now implement X correctly.
226 install now creates parent directories with mode 755, without
227 changing their owner or group.
228 * src/chmod.c (process_file): Adjust to mode_adjust API change.
229 * src/install.c: Include mkancesdirs.h.
230 (announce_mkdir, make_ancestor): New functions.
231 (DEFAULT_MODE): New macro, specifying initial value of 'mode'.
233 (dir_mode, dir_mode_bits): New vars.
234 (main): Set dir modes separately from nondir, so that the X
235 op of -m works correctly.
236 (main): Remove cwd_errno cruft, since make_dir_parents no longer
237 affects cwd. Adjust to new make_dir_parents API.
238 (install_file_in_file_parents): 2nd arg is now char *, not char
239 const *. Use mkancesdirs instead of rolling our own code.
240 (change_attributes): Don't worry about AFS, since that kludge
241 should not be needed any more.
242 * src/mkdir.c (struct mkdir_options): New struct.
243 (announce_mkdir, make_ancestor): New functions.
244 (main): Use them. Adjust to mode_adjust API change. Stick with
245 umask 0. Use make_dir_parents for all the work.
246 * src/mkfifo.c (main): Adjust to new mode_adjust API.
247 * src/mknod.c (main): Likewise.
248 * tests/chmod/setgid: Do the setgid test instead of bailing.
249 * tests/mkdir/p-3: Remove re_protect case that no longer applies.
250 GNU chmod now behaves like other versions of chmod.
251 * tests/mkdir/perm: Add a test for the X bug.
253 2006-07-14 Paul Eggert <eggert@cs.ucla.edu>
255 * src/base64.c (do_decode): Output to parameter OUT, not to stdout.
256 This doesn't fix any bugs, since OUT always equals stdout, but it
257 makes the code easier to understand.
259 2006-07-14 Jim Meyering <jim@meyering.net>
261 * Makefile.maint (CVS_LIST): Use new file, build-aux/vc-list-files,
262 rather than open-coding it. Now supports mercurial, too.
263 * .hgignore: New file.
264 * Makefile.am (EXTRA_DIST): Add .hgignore, which ignores nearly
265 all generated files, including ones like configure and po/*.po
266 that are currently version-controlled in cvs.
268 * Makefile.am (EXTRA_DIST): Add a few more .??* files.
269 They've been in CVS, just haven't been distributed before this.
270 Distribute ChangeLog-2005, too.
271 (MAINTAINERCLEANFILES): Add THANKS-to-translators.
273 2006-07-11 Paul Eggert <eggert@cs.ucla.edu>
275 * src/system.h: Assume <dirent.h> exists, since gnulib assumes
278 2006-07-09 Jim Meyering <jim@meyering.net>
280 * tests/mv/dir2dir: Adjust so failing with ENOTEMPTY is ok, too.
281 That happens with Linux/tmpfs.
282 * tests/mv/Makefile.am (TESTS): Add dir2dir.
284 2006-07-09 Paul Eggert <eggert@cs.ucla.edu>
286 Adjust to recent updates from gnulib.
287 * src/dd.c (apply_translations): Use toupper rather than
288 islower followed by toupper; it's simpler and typically
289 faster now that we assume at least C89 semantics. Similarly
291 * src/sort.c (inittables): Likewise.
292 * src/expand.c (expand): Don't assume that isprint etc. return
293 booleans (needed for pre-C99 hosts).
294 * src/fmt.c (check_punctuation): Likewise.
295 * src/ptx.c (initialize_regex, fix_output_parameters): Likewise.
296 * src/tr.c (is_char_class_member): Likewise.
297 * src/unexpand.c (unexpand): Likewise.
298 * src/join.c (is_blank): Remove; no longer needed. All uses
299 replaced by isblank (to_uchar (...)).
300 * src/pinky.c (create_fullname): Don't assume char is unsigned.
301 * src/printf.c (print_esc): Likewise.
302 * src/ptx.c (SKIP_NON_WHITE, SKIP_WHITE, SKIP_WHITE_BACKWARDS):
303 (copy_unescaped_string): Likewise.
304 * src/stat.c (print_it): Likewise.
305 * src/system.h (_D_EXACT_NAMELEN): Renamed from NLENGTH, for
306 convenience on GNU systems. All uses changed. Don't bother
307 looking for any dirent.h substitute other than ndir.h.
308 (D_INO): Remove unnecessary parentheses.
309 (IN_CTYPE_DOMAIN, ISGRAPH, ISPRINT, ISALNUM, ISALPHA):
310 (ISCNTRL, ISLOWER, ISPUNCT, ISSPACE, ISUPPER, ISXDIGIT):
311 (ISDIGIT_LOCALE, TOLOWER, TOUPPER): Remove. All uses changed
312 to ctype.h equivalents.
313 (isblank): Renamed from ISBLANK. Check for HAVE_DECL_ISBLANK too.
316 2006-07-08 Jim Meyering <jim@meyering.net>
318 * tests/mv/dir2dir: New file, test for 2006-07-05 fix in copy.c.
320 * Makefile.maint (sc_the_the): New rule.
322 * src/dd.c (skip): Remove one of two adjacent "the"s in a comment.
323 * tests/Coreutils.pm (run_tests): Remove one of two adjacent "then"s
326 2006-07-07 Jim Meyering <jim@meyering.net>
328 * NEWS: Mention that mv can now remove an empty destination directory,
329 and give an example. Prompted by a report from Florent Bayle.
331 2006-07-05 Jim Meyering <jim@meyering.net>
333 * src/ls.c (usage): Correct the description of -G: it is useful
334 only in a long listing. Reported by Martin Pool in
335 <https://launchpad.net/distros/ubuntu/+source/coreutils/+bug/51653>.
337 * man/chmod.x: Correct the description of the sticky bit. Reported
338 by Chris Moore via Ian Jackson in <http://bugs.debian.org/376745>.
340 * src/copy.c (copy_internal): Don't work around old NFS clients like
341 SunOS-4.1.4 and Irix 5.3 that set errno to values like EIO and
342 ENOTEMPTY upon failed rename. Otherwise, we risk misinterpreting
343 a banal failure as a recursive move-into-self failure.
344 Reported by Florent Bayle in <http://bugs.debian.org/376749>.
346 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
348 2006-07-03 Jim Meyering <jim@meyering.net>
350 Plug another unusual leak.
351 (AD_mark_helper): Free malloc'd filename if hash_insert says
352 that string is already in the hash table.
354 The dev/inode of the topmost directory in each hierarchy were not
356 * src/remove.c (remove_cwd_entries): Don't call cycle_check here.
357 (AD_push): Call it from here instead.
360 * src/remove.c (AD_stack_clear): New function.
362 (AD_pop_and_chdir): Free *prev_dir just before longjmp.
364 * tests/Makefile.am, tests/*/Makefile.am: (TESTS_ENVIRONMENT):
365 Add $VG_PATH_PREFIX as a prefix to $PATH
367 * tests/envvar-check (vars): Add CDPATH and POSIXLY_CORRECT.
368 * tests/Makefile.am (evar-check): Remove rule.
369 (EXTRA_DIST): Remove .env-warn.
370 * tests/.env-warn: Remove file. No longer used.
371 Suggestion from Eric Blake.
373 2006-07-02 Paul Eggert <eggert@cs.ucla.edu>
375 * src/system.h: Include <stdint.h> unconditionally, since we
376 now assume the stdint module.
378 2006-07-01 Paul Eggert <eggert@cs.ucla.edu>
380 * NEWS: With no operand, 'tail -f' now silently ignores the '-f'
381 only if standard input is a FIFO or pipe and POSIXLY_CORRECT is set.
382 * src/tail.c (main): Implement this.
383 * tests/tail/Test.pm (f-pipe-1): Renamed from f-1.
384 (test_vector): Set POSIXLY_CORRECT for the f-pipe-* tests.
386 2006-07-01 Jim Meyering <jim@meyering.net>
388 * src/ln.c (do_link): Use new, shorter URL, for ag-review link.
390 * .x-sc_require_config_h: Add ^lib/xstrtold\.c$, so make distcheck
393 2006-06-30 Paul Eggert <eggert@cs.ucla.edu>
395 * NEWS: seq now uses long double internally rather than double.
396 It now defaults to a minimal fixed point format if possible.
397 It lets you use %a, %A, %E, %F, %G.
398 * src/Makefile.am (seq_LDADD): Remove $(SEQ_LIBM); add $(POW_LIB).
399 * src/seq.c: Don't include <math.h> or <xstrtol.h>; no longer needed.
400 (isfinite) [!defined isfinite]: New macro.
401 (separator, terminator): Now points to const.
402 (first, step, last): Remove.
403 (usage): Update to match new behavior.
404 (struct operand, operand): New type.
405 (scan_arg): Renamed from scan_double_arg, since we no longer use double.
407 Compute and return a value of type operand, not double.
408 (long_double_format): Renamed from valid_format, and now returns a
409 new format with an "L" added if needed, if the original format was
410 valid. Allow %a, %A, %E, %F, and %G formats.
411 (print_numbers): Take numeric values as args rather than from globals.
412 Print long double, not double.
413 (get_width_format): Remove.
414 (get_default_format): New function.
415 (main): Implement new way of calculating default format.
416 Don't worry about locale's representation of the decimal point, since
417 the arguments are always processed in the C locale.
418 * tests/seq/basic (neg-2): Adjust to new default format.
419 (eq-wid-1, eq-wid-2): Resurrect these tests, since the new
420 implementation should do the right thing.
422 2006-06-30 Jim Meyering <jim@meyering.net>
424 * tests/stty/basic-1: Work around an intermittent test failure
425 on HP-UX 11.11. Report and analysis from Bob Proulx.
426 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7475
428 2006-06-28 Paul Eggert <eggert@cs.ucla.edu>
430 * NEWS: Support obsolete usages like "sort +1 -2" even when
431 conforming to POSIX 1003.1-2001, since this is a pure extension to
432 POSIX. Problem reported by Christian in:
433 http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00220.html
434 * src/sort.c (main): Implement this.
436 * src/system.h (CLOSEDIR): Remove. All uses changed to closedir.
437 Autoconf 2.60 says this stuff was obsolete.
439 2006-06-28 Jim Meyering <jim@meyering.net>
441 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
443 2006-06-28 Bob Proulx <bob@proulx.com> (tiny change)
445 * tests/mv/i-link-no: Work around HP-UX /bin/sh tracing problem
446 (set -x when VERBOSE=yes) when stderr is redirected before stdout
447 causing shell tracing of the stdout redirection to be written to
448 the stderr file. Avoid problem and test failure on HP-UX by
449 redirecting stderr last.
450 * tests/dd/unblock-sync: Order shell file redirections for
451 stderr and stdout in the common style.
454 2006-06-27 Jim Meyering <jim@meyering.net>
456 * tests/misc/cat-proc: Try to avoid any spurious numeric
457 differences in frequently-changing /proc/cpuinfo.
458 Reported by Nelson Beebe.
460 2006-06-26 Jim Meyering <jim@meyering.net>
462 Attempt rmdir (actually, unlinkat-with-AT_REMOVEDIR) upon any
463 fd_to_subdirp failure, not just when errno == EACCES.
464 * src/remove.c (remove_dir): Use unlinkat-with-AT_REMOVEDIR, not
465 rmdir, here, even though rmdir may happen to be adequate.
467 * NEWS: rm no longer fails to remove an empty, unreadable directory
468 * src/remove.c (remove_cwd_entries): If we can't open a directory,
469 and the failure is not being ignored, try to remove the directory
470 with rmdir (aka unlinkat-with-AT_REMOVEDIR), in case it's empty.
471 Problem report and test case from Paul Eggert in
472 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7425>.
474 * tests/rm/empty-inacc: New test, for the above.
476 Avoid a segfault for wc --files0=- < /dev/null.
477 * src/wc.c (compute_number_width): Return right away if nfiles == 0.
479 2006-06-25 Jim Meyering <jim@meyering.net>
481 * NEWS: wc accepts a new option --files0-from=FILE, where FILE
482 contains a list of NUL-separated file names.
484 * src/wc.c: Include "readtokens.h".
485 (usage): Describe the new option, and adjust the `Usage':
486 with this option, no FILE may be specified on the command line.
487 (main): Handle the new option.
488 * tests/misc/wc-files0: New tests, for the above.
489 * tests/misc/wc-files0-from: Likewise.
490 * tests/misc/Makefile.am (TESTS): Add wc-files0.
492 2006-06-24 Jim Meyering <jim@meyering.net>
494 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
496 2006-06-22 Jim Meyering <jim@meyering.net>
498 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
499 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
501 2006-06-19 Jim Meyering <jim@meyering.net>
503 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
504 so this check is not run as part of "make distcheck".
506 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
508 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
510 2006-06-18 Jim Meyering <jim@meyering.net>
512 * tests/misc/pwd-long: Make error output a little clearer.
514 2006-06-17 Jim Meyering <jim@meyering.net>
516 * tests/rm/inaccessible: Skip this test on systems without openat
517 support. Reported by Bob Proulx.
519 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
521 * tests/misc/mknod: Improve permission checks to handle
522 running mkdir test in set-gid directories.
524 2006-06-14 Jim Meyering <jim@meyering.net>
526 * tests/du/basic: Revamp not to hard-code file system block sizes.
528 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
530 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
533 2006-06-11 Jim Meyering <jim@meyering.net>
535 * .gitignore: New file.
536 * Makefile.am (EXTRA_DIST): Add .gitignore.
538 Setting TIME_STYLE=long-iso in the environment would make the
539 cp/same-file test fail.
540 * tests/envvar-check (vars): Add TIME_STYLE to the list.
541 * tests/cp/same-file: Revert last change.
542 Source the envvar-check script, to ensure that TIME_STYLE
543 settings don't affect these tests.
545 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
547 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
548 uses POSIX time stamp formats. Problem reported by John Nixon in
549 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
551 2006-06-10 Jim Meyering <jim@meyering.net>
553 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
555 Require a "Version N.M" line at the top of the ChangeLog
556 file only when making the actual release, not when running
558 * Makefile.maint (maintainer-distcheck): Don't depend on
560 (alpha beta major): Depend on it here, instead.
562 2006-06-08 Jim Meyering <jim@meyering.net>
564 Ensure that cat works with any of the options, -A -v -e -E -T,
565 when applied to files in /proc and /sys, even when the FIONREAD
566 ioctl produces nonsensical results. Before this change, cat would
567 produce no output (or truncated output), for some linux kernels.
569 * src/cat.c (write_pending): New function, factored out of cat.
570 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
571 that there are bytes to read. Some versions of linux-2.6.16 do that.
572 Write any pending output before returning.
573 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
574 * NEWS: Mention this bug fix.
575 * tests/misc/cat-proc: New file. Test for the above.
576 * tests/misc/Makefile.am (TESTS): Add cat-proc.
578 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
580 * src/expr.c (eval4): Detect overflow properly when multiplying
583 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
585 * NEWS: The 'expr' command now detects and reports integer overflow.
586 (It would be better to use extended precision instead, but that
588 * src/expr.c (integer_overflow): New function.
589 (eval4, eval3): Check for integer overflow.
591 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
593 Fix problems when building with Solaris/SVR4/etc. make, which uses a
594 different and somewhat bogus implementation of VPATH. In the
595 directory tests/misc, rename tests whose names might appear in the
596 Automake-generated rules. For example, we can't use a test named
597 'test', since Automake generates a rule that contains the text
598 "if test -f ./$$tst; ...", and this might expand to something like
599 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
600 which executes the 'test' script rather than the 'test' command.
601 * tests/misc/false-status: Renamed from tests/misc/false.
602 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
603 * tests/misc/sort-merge: Renamed from tests/misc/sort.
604 ($prog): Set to 'sort' rather than to $PROG.
605 * tests/misc/test-diag: Renamed from tests/misc/test.
606 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
607 in case Solaris make has prepended the directory.
608 (TESTS): Adjust to above renamings.
609 * tests/misc/expand: Don't assign to PROG; no longer needed
610 now that Makefile.am sets PROG to the basename.
611 * tests/misc/fold: Likewise.
613 2006-06-03 Jim Meyering <jim@meyering.net>
615 Make `cp --link --no-dereference' work also on systems where the
616 link system call cannot create a hard link to a symbolic link.
617 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
618 the link syscall on a symlink when it would do the wrong thing.
619 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
620 * tests/cp/link-no-deref: New file/test for the above.
621 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
622 * NEWS: Mention the change (doesn't affect Linux).
624 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
626 Fix some porting problems in the test cases reported by
627 Ralf Wildenhues for HP-UX 11.23 in:
628 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
629 * tests/help-version: Don't assume that \< \> works in sed.
630 * tests/misc/close-stdout: Don't assume that >&- works.
631 Add a /dev/full test.
632 * tests/touch/no-create-missing: Don't assume that >&- works.
634 2006-05-30 Jim Meyering <jim@meyering.net>
636 * src/ls.c (usage): Add `v' to the list of sorting-related options.
639 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
641 * tests/cp/fail-perm: source lang-default.
642 * tests/rm/inaccessible: Likewise.
644 2006-05-28 Jim Meyering <jim@meyering.net>
646 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
647 Recognize it, too. Reported by Ralf Wildenhues, in
648 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
650 2006-05-27 Jim Meyering <jim@meyering.net>
652 * src/chgrp.c: Support new options: --preserve-root and
653 --no-preserve-root. Somehow this program was skipped when those
654 options were added to chown, chmod, and rm. Reported by
655 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
656 * NEWS: Mention this.
658 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
660 * NEWS: Remove mention of --seed. We'll replace it with something
661 better, and don't want to indicate that it is supported.
662 * src/sort.c (usage): Likewise.
664 2006-05-20 Jim Meyering <jim@meyering.net>
666 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
668 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
669 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
670 FTS_COMFOLLOW. Spotted by Justin Pryzby.
672 * gnupload: Merge changes from automake, retaining the ""--to...
673 kludge to placate overzealous `make distcheck' check.
675 2006-05-19 Jim Meyering <jim@meyering.net>
677 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
678 FTS_TIGHT_CYCLE_CHECK directory traversal option.
679 Reported by Justin Pryzby in http://bugs.debian.org/367691
681 2006-05-15 Jim Meyering <jim@meyering.net>
683 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
686 2006-05-13 Jim Meyering <jim@meyering.net>
688 * tests/mv/no-target-dir: Test two more cases.
690 2006-05-11 Jim Meyering <jim@meyering.net>
692 mv -T DIR EMPTY_DIR no longer fails unconditionally
693 * src/copy.c (copy_internal): Don't manually prohibit a move where
694 the destination is an existing directory. Sometimes doing that is
695 valid. Let the rename system call enforce the rules. That is
696 allowed only when the source is a directory and the destination
697 directory (to be replaced) is empty. Reported by Eric Blake.
698 * tests/mv/no-target-dir: New file/test for this.
699 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
700 * NEWS: Mention this.
702 * tests/mv/atomic: New file/test for yesterday's fix.
703 * tests/mv/Makefile.am (TESTS): Add atomic.
705 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
707 2006-05-10 Jim Meyering <jim@meyering.net>
709 * src/copy.c (copy_internal): Don't explicitly unlink the destination
710 when moving a symlink into the place of an existing non-directory.
711 Reported by Joshua Hudson.
712 * NEWS: mention this.
714 2006-05-07 Jim Meyering <jim@meyering.net>
716 * Makefile.maint (patch-check): Fail if patch generates any output,
717 even merely for changed offsets.
719 * src/c99-to-c89.diff: Adjust to reflect new offsets.
721 * NEWS: Mention changes affecting df, pwd, shred.
723 2006-05-06 Jim Meyering <jim@meyering.net>
725 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
726 system condition where dirent.d_ino != stat.st_ino.
727 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
729 2006-05-06 Eric Blake <ebb9@byu.net>
731 * tests/ls/inode: Expand to test inode from readdir case.
732 * tests/ls/follow-slink: Expand to test broken links encountered
733 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
735 2006-05-06 Eric Blake <ebb9@byu.net>
737 * tests/mv/leak-fd: Work even on case-insensitive file system.
739 2006-05-04 Jim Meyering <jim@meyering.net>
741 * NEWS: Mention the 2006-03-19 pwd-related change that makes
742 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
744 2006-05-03 Jim Meyering <jim@meyering.net>
746 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
747 Use better macro parameter names: s/basename/key_name/,
748 s/basefunc/key_cmp_func. Fix typo in comment.
750 2006-04-29 Eric Blake <ebb9@byu.net>
752 * src/ls.c (main): On systems with d_type, directories_first only
753 implies format_needs_type, not format_needs_stat.
755 2006-05-03 Jim Meyering <jim@meyering.net>
757 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
758 after comma in arg list, from Eric Blake.
760 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
762 * tests/misc/date (relative-3): New test, derived from a bug
763 report by John Thomas McDole.
765 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
767 New option for ls: --group-directories-first.
768 It makes ls list directories before files.
769 * NEWS [New features]: Mention it.
770 * src/ls.c (sort_type): Rearrange to use as an array index when
771 choosing sort function; added new sort_numtypes member for
773 (time_type): Add new time_numtypes member for compile-time check.
774 (directories_first): New global variable.
775 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
776 (long_options): Add --directories-first.
777 (main): Support new option.
778 (is_directory): New function.
779 (extract_dirs_from_files): Use it.
780 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
781 (LIST_SORTFUNCTION_VARIANTS): New macros.
782 (sort_functions): New global variable.
783 (sort_files): Use it.
784 (usage): Document new option.
786 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
788 * src/shred.c (fillrand): The assertion was way too weak, due to
789 what must be a typo. Strengthen it to its intended value.
790 (dopass): Don't use alloca; it's not worth the aggravation here,
791 since it's used only to get a page-aligned buffer, and page
792 alignment doesn't buy us much here. I'm suspicious that alloca
793 causes problems on some hosts, due to a recent bug report by Adam
794 Waltman: http://bugs.gentoo.org/130246.
796 2006-04-18 Jim Meyering <jim@meyering.net>
798 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
799 sha384sum, sha512sum.
801 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
803 * src/chmod.c (describe_change): Adjust to filemode changes.
804 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
805 (print_long_format): Use (new) filemodestring rather than
806 (old) mode_string, so that we get more file types right, at least
807 in theory. Adjust to filemode changes.
808 * src/stat.c (human_access): Likewise.
810 2006-04-18 Jim Meyering <jim@meyering.net>
812 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
813 ignore file. This has never been enabled. Reported by Eric Blake.
815 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
817 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
818 bug in Interix. Just call symlink or link directly. All uses changed.
819 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
820 * src/stat.c (USE_STATVFS): New macro.
821 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
822 (NAMEMAX_FORMAT): define a bit more clearly, now that the
823 statvfs-using code is a bit more regular.
824 * src/system.h (sync) [!HAVE_SYNC]: New macro.
826 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
828 * NEWS: csplit, nl, expr now conform to POSIX better, and are
829 more-compatible with traditional Unix, with respect to regular
831 * src/csplit.c (extract_regexp): Set re_syntax_options to a
832 value that is compatible with what POSIX requires.
833 * src/nl.c (build_type_arg): Likewise.
834 * src/expr.c (docolon): Likewise. Also, don't let anchors match
835 newline; this fixes an incompatibility with tradition and with POSIX.
836 Don't warn about leading ^. POSIX says it is unspecified whether
837 ^ is a special character, which means that implementations can
838 either treat it as special or not, but either way a warning is not
839 allowed (unless the regexp is otherwise invalid). Instead, anchor
840 the expression but treat ^ as an anchor; this is the traditional
841 behavior (e.g., Solaris 10).
842 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
843 and the like as invalid expressions (exit status 2), not as
844 failure of 'expr' (exit status 3). This is more consistent with
846 * tests/expr/basic (fail-a): Adjust exit status to match new expr
847 behavior, for status 2 versus 3.
849 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
850 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
851 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
852 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
853 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
854 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
855 (bre61, bre62): New tests.
856 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
860 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
861 "if !". Do not assume that 'sed' can handle long, newline-free input.
862 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
864 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
866 Adjust to new regex.h API (with new fastmap type), and clean
867 up the regex storage allocation a bit.
869 * src/csplit.c (struct control): Put re_compiled member at the
870 end, since it's large. Change regexpr member from char * to bool;
871 all uses changed. Add new member fastmap.
872 (extract_regexp): regexp arg is now char const *, not char *.
873 Don't bother duplicating the regular expression; it's not needed.
874 Set fastmap from new fastmap member. Don't bother allocating
875 a buffer, as the regexp code does a better job than we do.
876 * src/expr.c (docolon): Allocate and use a fastmap.
877 Don't bother allocating a buffer.
878 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
880 (build_type_arg): New fastmap arg. All uses changed.
881 Don't bother allocating a buffer, but set a fastmap.
882 * src/ptx.c (context_regex_string, word_regex_string): Remove.
883 (context_regex, word_regex): New vars, replacing the above.
885 (struct regex_data): New type.
886 (compile_regex): Renamed from alloc_and_compile_regex, since
887 we no longer allocate storage. Arg is now a struct regex_data *,
888 not a const char *. All uses changed. Don't allocate the fastmap;
889 instead, take it from the caller. Don't convert size_t to int,
890 to avoid arithmetic overflow problems. Don't bother freeing
891 storage afterwards; it's not worth the aggravation.
892 * src/tac.c (compiled_separator_fastmap): New ver.
893 (main): Use it. Don't bother allocating a buffer.
895 2006-03-30 Jim Meyering <jim@meyering.net>
897 * src/dd.c (iwrite): Remove assignment without effect.
898 Reported by Felix Rauch Valenti.
900 2006-03-22 Eric Blake <ebb9@byu.net>
902 * src/ptx.c (usage): Remove mention of --copyright/-C.
903 (main): Alias --copyright to --version plus a deprecation warning.
904 * NEWS: Mention this.
906 2006-03-27 Jim Meyering <jim@meyering.net>
908 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
909 use of strtod. Tiny patch from Nickolai Zeldovich.
911 2006-03-11 Eric Blake <ebb9@byu.net>
913 * tests/misc/dirname: New file.
914 * tests/basename/Makefile.am: Delete.
915 * tests/basename/basic: Move to...
916 * tests/misc/basename: ... this new file. Add some tests,
917 including fixed behavior for //.
918 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
919 * tests/Makefile.am (SUBDIRS): Remove basename.
920 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
922 Improvements to dirname/basename handling on platforms like
923 cygwin with distinct // and with drive letters.
924 * NEWS: Document new behavior.
925 * src/basename.c (main): Don't strip suffix from file system
927 * src/cp.c (target_directory_operand): Use new last_component.
928 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
929 traversing the string.
930 * src/dircolors.c (guess_shell_syntax): Use new last_component.
931 * src/install.c (target_directory_operand, install_file_in_dir):
933 * src/ln.c (target_directory_operand, main): Likewise.
934 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
935 * src/mv.c (target_directory_operand, movefile): Likewise.
936 * src/remove.c (rm_1): Likewise.
937 * src/shred.c (wipename): Likewise.
938 * src/split.c (next_file_name): Likewise.
939 * src/su.c (log_su, run_shell): Likewise.
941 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
943 * NEWS: nohup diagnostics are now more precise, and nohup now
944 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
945 * src/nohup.c (main): Implement this.
946 * tests/misc/nohup: Test the new behavior.
948 2006-03-12 Jim Meyering <jim@meyering.net>
950 * src/copy.c (set_author): Rename function, from preserve_author.
952 * src/remove.c (AD_pop_and_chdir): Use new macro,
953 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
955 * src/system.h (SAME_INODE): Remove definition.
956 Include "same-inode.h", instead.
958 2006-03-11 Eric Blake <ebb9@byu.net>
960 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
962 2006-03-10 Jim Meyering <jim@meyering.net>
964 Fix a bug whereby a user with write access to a directory being removed
965 could cause the removal of that directory to fail with an erroneous
966 diagnostic about a directory cycle. Reported by Vineet Chadha.
968 * NEWS: Mention this.
969 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
970 leave (and try to rmdir) is the one whose dev_ino is being used to
971 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
973 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
975 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
976 * src/dd.c (set_fd_flags): Handle file-creation flags on file
977 descriptors, rather than ignoring them.
978 * tests/dd/misc: Add test cases for append, nofollow, directory,
979 and nolinks flags. Simplify redirection to /dev/null in some cases.
981 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
982 noatime test never tested anything.
984 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
986 * src/dd.c (flags, usage): New flags directory, nolinks.
987 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
989 * src/ls.c (usage): Mention that -f disables --color.
990 Problem reported by Niels Möller.
992 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
994 * man/*.x: Add references to syscalls from utilities of the same name.
996 2006-03-05 Jim Meyering <jim@meyering.net>
998 * tests/help-version: Set SHELL, if not already set, in order to
999 avoid failure when `make check' is run through debuild; dircolors
1000 would fail due to lack of $SHELL. Reported by Sven Joachim.
1002 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
1003 * src/base64.c (wrap_write, do_encode, main): Change type of
1004 parameters and locals, wrap_column, form size_t to uintmax_t.
1005 (main): Adjust to use xstrtoumax, accordingly.
1007 2006-03-03 Jim Meyering <jim@meyering.net>
1009 Don't fail when run from an environment with SHELL not a Bourne
1010 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
1011 * tests/dircolors/simple: Invoke each non-failing test with -b.
1012 Reported by Michael Stone.
1014 2006-02-27 Jim Meyering <jim@meyering.net>
1016 * tests/misc/base64: Derive --decode-using tests from the
1019 * tests/misc/base64: Factor out a long constant string.
1020 Split lines to stay within 80 columns.
1022 * tests/misc/Makefile.am (TESTS): Add base64.
1023 * tests/misc/base64: Test base64. From Simon Josefsson.
1025 * src/base64.c (do_decode): Use correct type for parameter,
1026 ignore_garbage: s/size_t/bool/.
1028 * src/base64.c: Don't include .h files already included by system.h:
1029 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
1030 Include "system.h" before the other lib/*.h header files.
1031 Include <sys/types.h> before "system.h".
1032 (wrap_write): Remove declaration of unused local, initial_column.
1033 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
1035 * README: Add base64 to the list.
1037 2006-02-17 Simon Josefsson <jas@extundo.com>
1039 New program: base64.
1040 * AUTHORS: Mention base64.
1042 * man/Makefile.am: Build base64.1.
1043 * man/base64.x: New file.
1044 * src/Makefile.am (bin_PROGRAMS): Add base64.
1045 * src/base64.c: New file.
1047 2006-02-25 Eric Blake <ebb9@byu.net>
1049 In ls, avoid calling stat for --inode (-i), when possible.
1050 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
1051 * src/system.h: ... here, for use in ...
1052 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
1054 (gobble_file): Add inode argument.
1055 (print_dir): Pass inode if available.
1056 (usage): Remove inaccuracy.
1058 2006-02-23 Jim Meyering <jim@meyering.net>
1060 * TODO: Update/correct some obsolete entries.
1062 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
1064 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
1065 * src/join.c (usage): Likewise.
1066 Documentation problem reported by Philip Kensche.
1068 2006-02-20 Eric Blake <ebb9@byu.net>
1070 * man/rm.x: Update documentation to match previous patch.
1072 2006-02-18 Eric Blake <ebb9@byu.net>
1074 New option for rm: --interactive=once (-I).
1075 * NEWS: Document it, along with change to rm --interactive.
1076 * TODO: Remove entry for implementing rm -I
1077 * src/rm.c (INTERACTIVE_OPTION): New enum value.
1078 (interactive_type): New enum.
1079 (long_opts): Let interactive take an optional argument.
1080 (interactive_args, interactive_types): New option arguments.
1081 (usage): Document -I, --interactive=WHEN. Use program_name
1082 instead of a basename.
1083 (main): New -I option, new behavior to --interactive.
1084 * tests/rm/interactive-once: New tests.
1085 * tests/rm/interactive-always: Ditto.
1086 * tests/rm/Makefile.am (TESTS): Run them.
1088 2006-02-18 Jim Meyering <jim@meyering.net>
1090 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
1091 expression match more of the target lines, e.g., those that start with
1092 `-S,' (short option followed by a comma) or that include `=[...]'.
1093 Patch by Nicolas François.
1094 Fix the four offenders thus exposed:
1095 * src/join.c (usage): Use two spaces (not one) to separate the
1096 --first-only option string from its description, so help2man formats
1097 the derived man page properly.
1098 * src/pr.c (usage): Likewise.
1099 * src/uniq.c (usage): Likewise.
1100 * src/install.c (usage): Likewise.
1102 2006-02-15 Jim Meyering <jim@meyering.net>
1104 * Makefile.maint (alpha beta major): For `make major', ensure that the
1105 version string is of the form N.N[.N]*, where N is one or more digits.
1107 2006-02-14 Jim Meyering <jim@meyering.net>
1109 * INSTALL: Update from gnulib.
1111 2006-02-13 Jim Meyering <jim@meyering.net>
1113 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
1115 2006-02-12 Jim Meyering <jim@meyering.net>
1117 * Makefile.maint (patch-check): New target.
1118 (local-checks-available): Add to the list.
1120 2006-02-11 Jim Meyering <jim@meyering.net>
1122 * src/c99-to-c89.diff: New file.
1123 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
1125 * .x-po-check: New file, with exclusions so that `make distcheck'
1127 * Makefile.am (EXTRA_DIST): Add .x-po-check.
1129 rm -r must remove an empty directory, even if it is inaccessible.
1130 * src/remove.c (close_preserve_errno): New function.
1131 (fd_to_subdirp): Don't print a diagnostic in this function.
1132 Do it from the callers instead, unless rmdir succeeds.
1133 (remove_cwd_entries, remove_dir): Adjust callers.
1134 * tests/rm/empty-inacc: New test for the above.
1135 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
1136 * NEWS: Mention this bug fix.
1137 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
1138 a tiny bit less precise: cannot remove `a/1': ... instead of
1139 cannot open directory `a/1': ...
1141 * Makefile.maint (syntax-check-rules): Automatically derive this
1142 list of sc_-prefixed rule names.
1144 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
1146 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
1147 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
1148 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
1149 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
1150 go away? was that an accident?)
1151 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
1152 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
1153 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
1154 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
1155 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
1156 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
1157 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
1158 (author_mark_check, makefile_path_separator_check):
1159 Output line numbers, to simplify navigation of Emacs *compilation*
1161 (sc_prohibit_atoi_atof, sc_file_system):
1162 Rework slightly so that Makefile.maint doesn't get reported as a
1163 violation of its own syntax rules.
1164 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
1165 it at run-time (which didn't work with Bison). Fix a makefile typo,
1166 caught by Makefile.maint itself: spaces where a tab should be.
1167 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
1168 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
1169 Ignore djgpp and man subdirectories, to avoid false matches with
1170 Bison and coreutils, respectively. Use sort -u to remove the
1171 resulting duplicates.
1172 * gnupload: Rework slightly to avoid bogus warning from
1173 sc_two_space_separator_in_usage.
1175 2006-02-10 Jim Meyering <jim@meyering.net>
1177 Use gzip's --rsyncable option only if it's available.
1178 * Makefile.maint (gzip_rsyncable): New variable.
1181 2006-02-08 Jim Meyering <jim@meyering.net>
1183 * Makefile.maint (local-checks-available): Define in terms of
1184 the expansion, $(syntax-check-rules), rather than the single,
1185 top-level target `syntax-check', so that it's easier to exclude
1186 individual rules (via $(local-checks-to-skip)).
1187 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
1189 2006-02-07 Jim Meyering <jim@meyering.net>
1191 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
1192 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
1194 * tests/help-version (expected_failure_status_vdir):
1195 Redirect an expected disk-full diagnostic to /dev/null.
1197 2006-02-06 Jim Meyering <jim@meyering.net>
1199 * src/unexpand.c (usage): Use two spaces (not one) to separate the
1200 --first-only option string from its description, so help2man formats
1201 the derived man page properly.
1202 * src/rm.c (usage): Likewise for --no-preserve-root.
1203 * src/chown.c (usage): Likewise.
1204 * src/chgrp.c (usage): Likewise.
1206 Add a rule to ensure that the above doesn't happen again.
1207 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
1208 (syntax-check-rules): Add it.
1209 * .x-sc_two_space_separator_in_usage: New empty file.
1210 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
1212 2006-02-06 Jim Meyering <jim@meyering.net>
1214 * src/cp.c (usage): Use two spaces (not one) to separate each
1215 option string from its description, so help2man formats the
1216 derived man page properly.
1217 * src/mv.c (usage): Likewise.
1218 Patch from Nicolas François in http://bugs.debian.org/351601.
1220 2006-02-04 Jim Meyering <jim@meyering.net>
1222 * src/copy.c (copy_internal): cp -RL would fail when encountering
1223 the same directory more than once in the hierarchy beneath a single
1224 command-line argument. That is legitimate, e.g. when there are
1225 two or more symbolic links, each pointing to some directory that
1226 would not otherwise be copied. Reported by Christophe LYON.
1227 * tests/cp/cp-deref: New file. Test for today's fix.
1228 * tests/cp/Makefile.am (TESTS): Add cp-deref.
1229 * NEWS: Document this.
1231 2006-02-03 Jim Meyering <jim@meyering.net>
1233 * configure.ac: Require automake-1.9.6, not 1.8.3.
1235 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
1237 * src/od.c (usage): Mention that -t a ignores high order bit.
1238 Documentation problem reported by Ed Avis.
1240 2006-02-01 Jim Meyering <jim@meyering.net>
1242 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
1244 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
1246 * src/head.c (main): Use a better diagnostic when someone uses a
1247 trailing numeric option in an invalid way. Problem reported by
1249 * src/tail.c (parse_options): Likewise.
1251 2006-01-30 Jim Meyering <jim@meyering.net>
1253 * man/wc.x: Include `count' keyword in man page synopsis,
1254 per suggestion from http://bugs.debian.org/181585.
1256 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
1258 * src/df.c (show_dev): If the file system claims to have
1259 more available than total blocks, report the number of used
1260 blocks as being total - available (a negative number) rather
1261 than as garbage. Problem reported by Toralf Foerster.
1263 2006-01-24 Jim Meyering <jim@meyering.net>
1265 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
1266 to put a regular file in O_NONBLOCK mode fails with EPERM.
1267 That happens on Linux (up to 2.6.15) when using tail -f on a file with
1268 the append-only attribute. Reported by Dean Gaudet. For details,
1269 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
1270 * NEWS: Mention this fix.
1271 * tests/tail-2/append-only: New file. Test for the above.
1272 * tests/tail-2/Makefile.am (TESTS): Add append-only.
1273 * tests/Makefile.am (check-root): Add tail-2/append-only
1275 2006-01-21 Jim Meyering <jim@meyering.net>
1277 * NEWS: Mention fts-related improvements and bug fixes.
1279 2006-01-19 Jim Meyering <jim@meyering.net>
1281 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
1282 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
1284 2006-01-18 Jim Meyering <jim@meyering.net>
1286 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
1288 2006-01-17 Jim Meyering <jim@meyering.net>
1290 Now that fts no longer changes the current working directory, adjust
1291 its clients accordingly -- note that du.c uses fts but doesn't need
1292 any adjustment, since it doesn't operate on the actual files,
1293 but rather just uses the stat buffers provided by fts.
1295 * src/chown-core.c: Include "openat.h".
1296 Don't include "lchown.h".
1297 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
1298 calling openat, lchownat, chownat, rather than open, lchown, chown.
1300 * src/chmod.c: Include "openat.h".
1301 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
1303 * tests/du/long-from-unreadable: New test, to exercise one small
1306 2006-01-13 Jim Meyering <jim@meyering.net>
1308 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
1309 addition of new directories under tests/.
1311 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
1314 2006-01-12 Jim Meyering <jim@meyering.net>
1316 * tests/du/long-sloop: Adjust not to hard-code the expected
1317 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
1318 from that of GNU libc. Reported by Paul Eggert.
1320 * tests/du/long-sloop: Create file at end of symlink chain.
1322 * tests/misc/test: New file, with a test for one of the
1323 bugs fixed by yesterday's test.c changes.
1324 * tests/misc/Makefile.am (TESTS): Add test.
1326 2006-01-11 Jim Meyering <jim@meyering.net>
1328 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
1329 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
1330 a very long sequence of symbolic links (not necessarily a loop).
1331 * tests/du/Makefile.am (TESTS): Add long-sloop.
1333 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
1335 * src/test.c (test_syntax_error): Append a newline. All callers
1336 changed, except for the ones that didn't already append a newline.
1337 Bug reported by Eric Blake.
1339 2006-01-11 Jim Meyering <jim@meyering.net>
1341 * src/system.h (X2NREALLOC): Now that verify_true is no longer
1342 void, cast its result to void, to avoid gcc's warning that
1343 ``left-hand operand of comma expression has no effect''.
1344 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
1346 2006-01-10 Jim Meyering <jim@meyering.net>
1348 * tests/chmod/no-x: Add a test for today's fts.c fix.
1350 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
1352 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
1353 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
1355 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
1357 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
1358 Use verify_true instead of verify_expr, to sync with gnulib.
1360 2006-01-08 Jim Meyering <jim@meyering.net>
1362 * src/date.c (usage): Adjust the formatting of the entries for
1363 %::z and %:::z (separate with two spaces, not one) so that help2man
1364 formats them properly. Reported by Philip Rowlands.
1366 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
1368 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
1370 2006-01-06 Jim Meyering <jim@meyering.net>
1372 * Makefile.maint (copyright-check): Use date +%Y in place of
1375 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
1376 First off, the attribute should have been `volatile' (not static)
1377 to avoid longjmp-related risk of clobber. Secondly, now there is
1378 no longer any risk of a local variable being clobbered, so there's
1379 no need for any attribute at all.
1381 2006-01-05 Jim Meyering <jim@meyering.net>
1383 * src/remove.c: Give a few functions the inline attribute.
1384 (AD_pop_and_chdir): Use gotos to avoid some duplication.
1385 (AD_push): Rewrite an assertion so that the entire computation
1386 goes away when assertions are turned off.
1388 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
1389 It's already defined in "system.h".
1390 * Makefile.maint: Add a FIXME comment.
1392 2006-01-04 Jim Meyering <jim@meyering.net>
1394 * ChangeLog: Remove entries from 2005-10-22 and earlier.
1395 * ChangeLog-2005: New file, for entries up to version 5.92.
1397 2006-01-03 Jim Meyering <jim@meyering.net>
1399 * tests/du/no-x: Also allow a slightly different diagnostic -- the
1400 one you get when using openat-enabled fts.c and du (coming soon).
1401 * tests/chmod/no-x: Likewise.
1402 * tests/chgrp/no-x: Likewise.
1404 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
1406 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
1408 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
1409 (restricted_chown): Return it, if the file cannot be accessed due
1410 to EPERM, or if no uid or gid are required, or if the file is
1411 neither a directory nor a regular file. Rewrite to avoid gotos.
1412 (change_file_owner): Handle RC_do_ordinary_chown case.
1413 Rewrite to avoid gotos.
1414 * tests/chgrp/basic: Make sure we can change the group of
1417 * src/date.c (usage): Explain %g, %G, and %V a bit better.
1419 2006-01-02 Jim Meyering <jim@meyering.net>
1421 * src/copy.c (set_owner): Correct a comment.
1423 * src/tail.c (parse_options): Change warning to say that --retry
1424 is useful `mainly' (not `only') when following by name.
1425 Reported here: http://bugs.debian.org/273781
1427 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
1429 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
1430 * src/copy.c: Include lchmod.h.
1431 (copy_internal): Use lchmod rather than chmod.
1432 * src/cp.c: Include lchmod.h.
1433 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
1434 * src/mkdir.c: Include lchmod.h.
1435 (usage): Clarify -m's operation.
1436 (main): Use lchmod rather than chmod. Don't use lchmod unless the
1437 new mode contains bits outside the 777 range.
1438 * src/mkfifo.c (usage): Clarify -m's operation.
1439 (main): If -m is given, don't invoke chmod; use umask 0 instead.
1440 Report an error if -m asks for bits outside the 777 range.
1441 * src/mknod.c (usage, main): Likewise.
1443 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
1445 2005-12-27 Jim Meyering <jim@meyering.net>
1447 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
1448 (sc_prohibit_assert_without_use): New rule.
1449 (syntax-check-rules): Add it to the list.
1450 * .x-sc_prohibit_assert_without_use: New empty file.
1451 * Makefile.am (EXTRA_DIST): Add it.
1453 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
1455 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
1456 Don't include <assert.h>; it wasn't used.
1458 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
1460 * src/chown-core.c (restricted_chown):
1461 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
1462 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
1463 | O_NOFOLLOW too, for consistency with other dir-openers.
1464 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
1465 (is_empty_dir): Likewise.
1466 * src/shred.c (wipename): Likewise. Don't bother trying to open
1467 dir for writing, since POSIX prohibits it.
1469 2005-12-22 Jim Meyering <jim@meyering.net>
1471 * tests/help-version: Redirect stderr to /dev/full, to suppress
1472 write error diagnostic.
1474 2005-12-19 Jim Meyering <jim@meyering.net>
1476 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
1477 Avoid a minor race condition when `-m MODE' is specified, by using
1478 open, fchown, and close rather than just chown. To do that reliably --
1479 even with an overly restrictive umask -- ensure that each mkdir,
1480 mknod and mkfifo call uses a mode including at least owner-read access.
1481 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
1482 the subsequent chown (or equivalent open,fchown,close) fails.
1483 * tests/misc/mknod: New tests.
1484 * tests/misc/Makefile.am (TESTS): Add mknod.
1486 2005-12-17 Jim Meyering <jim@meyering.net>
1488 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
1489 e.g., on a named pipe.
1490 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
1491 place of all uses, since it is guaranteed (system.h) to be defined.
1493 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
1495 Add POSIX ACL support
1496 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
1497 is no requirement for ACL support; particularly, it does not exist
1498 on systems that have POSIX ACLs.
1499 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1500 * src/cp.c (umask_kill): With default acls, the umask is not to be
1501 applied. Remove umask_kill, don't change the process umask, and let
1502 the kernel apply the umask where appropriate.
1503 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1504 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1506 (copy_reg, copy_internal): Use copy_acl and set_acl
1507 instead of fchown/chown. Fix the logic for POSIX ACLs.
1508 (chown_succeded): Remove; we now always copy acls and
1509 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1510 did a chown before or not.
1511 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1512 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1513 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1514 to link with it via $(LIB_ACL), for the utilities that need it.
1516 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1518 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1519 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1520 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1521 value is now signified by whether cwd_errno is null.
1522 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1523 pointer-to-bool to pointer-to-errno-value. All callers changed.
1524 (rm_1): Don't bother setting a local cwd failure flag and then
1525 ORing it into the caller's. Just set the caller's.
1526 (rm): Use cwd failure errno value to print a slightly-better
1529 2005-12-15 Jim Meyering <jim@meyering.net>
1531 * src/stat.c (print_it): Properly handle a backslash at the
1532 end of a --printf format string. Reported by Paul Eggert.
1533 * tests/misc/stat-printf (end-bs): Add a test for the above.
1535 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1537 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1538 Don't assume /etc/passwd contains user names; use 'id' instead.
1540 2005-12-15 Jim Meyering <jim@meyering.net>
1542 stat: revert behavior of --format=FMT (-c)
1543 stat: add new option: --printf=FMT
1544 * NEWS: Mention this.
1545 * src/stat.c (isodigit, octtobin, hextobin): Define.
1546 (PRINTF_OPTION): Define.
1547 (interpret_backslash_escapes, trailing_delim): New globals.
1548 (usage): Document them. Alphabetize on long option names.
1549 (print_esc_char): New function.
1550 (print_it): Rewrite, in order to handle backslash escapes.
1551 (main): Handle new option. Set globals for --format, too.
1553 * tests/misc/stat-printf: Test --printf and --format.
1554 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1556 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1558 * NEWS: sort now reports incompatible options.
1559 * src/sort.c (incompatible_options, check_ordering_compatibility):
1561 (main): Use them. Don't bother with a usage message for
1562 "sort -c a b", for consistency with other error diagnostics.
1563 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1566 * src/cat.c (main): Undo previous change. close_stdout already
1567 does the check, so the previous change wasn't necessary.
1569 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1571 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1573 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1575 Install a more-conservative approach for sort -R. It's the
1576 same basic idea as the existing code, except it uses the full ISAAC
1577 approach (called the "more kosher" approach in the existing comments).
1578 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1579 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1580 better to be conservative here at first, and review any performance
1581 improvements carefully.
1582 * .x-sc_require_config_h: Add src/rand-isaac.c.
1583 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1584 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1585 (shred_SOURCES, sort_SOURCES): Remove.
1586 (EXTRA_DIST): Add rand-isaac.c.
1587 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1588 changing it to allow for varying numbers of words in the state.
1589 Alter so that we include rand-isaac.c directly rather than
1590 compiling it and linking to it. Don't include config.h or
1591 system.h; that's the includer's responsibility.
1592 Omit functions that are specific to shred.
1593 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1594 (isaac_step, struct irand_state):
1595 Resurrect these, with the same defns that used to be in shred.c.
1596 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1597 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1599 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1600 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1601 (irand_init, irand32, irand_mod):
1602 Number of words is constant again.
1603 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1604 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1605 * src/sort.c: Likewise.
1606 * src/shred.c (fillrand, dopass, main): Undo previous change.
1607 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1609 * src/sort.c: Don't include md5.h; it wasn't needed.
1610 (struct keyfield): Rename random_hash to random, for consistency
1611 with the other member names. All uses changed.
1612 (usage): Tweak wording to mention STRING for --seed option.
1613 (short_options): Rorder for consistency with other programs.
1614 (rand_state): Now a struct, not a pointer to one. All uses changed.
1615 (HASH_WORDS, HASH_SIZE): Remove.
1616 (get_hash): Remove comments around resbuf size, since we can assume C89.
1617 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1618 (keycompare): Adjust to the new get_hash.
1620 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1621 (main): Don't set need_random simply because gkey has it set; that
1622 doesn't necessarily mean we'll need random numbers.
1623 Redo seeding to match new get_hash approach.
1625 2005-12-10 Jim Meyering <jim@meyering.net>
1627 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1629 Avoid shred segfault on 64-bit systems.
1630 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1631 local of type uint32_t. Make the local an `int' instead.
1633 * NEWS: Mention sort's new options.
1635 * src/rand-isaac.c (isaac_mix): Declare to be static.
1636 Mark all other functions as `extern' so the tight-scope
1637 part of `make distcheck' passes once again.
1638 * src/rand-isaac.h (isaac_mix): Remove declaration.
1640 * src/sort.c (get_hash): Change position of `*' in parameter
1641 type to conform with convention.
1642 (main): Split a long line so it fits in 80 columns.
1643 (keycompare): Remove stray SPACE before TAB that was
1644 causing `make distcheck' to fail.
1646 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1648 * tests/misc/sort-rand: New file: basic tests for the new options.
1649 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1651 2005-12-10 Frederik Eaton <frederik@ofb.net>
1653 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1654 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1655 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1656 Make state size runtime-configurable.
1657 (isaac_new, isaac_copy): New functions.
1658 * src/rand-isaac.h: New file.
1659 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1660 (fillrand, main): Adjust to the fact that the state size is now
1661 runtime-configurable.
1662 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1663 (usage): Add options --random-sort and --seed to implement a random
1665 Include md5.h and rand-isaac.h.
1666 (get_hash): New function.
1667 (rand_state): New var.
1668 (HASH_WORDS, HASH_SIZE): New macros.
1670 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1672 * tests/dd/misc: Add test for dd iflags=noatime.
1674 2005-12-09 Jim Meyering <jim@meyering.net>
1676 * src/sort.c (usage): Mention white space vs -b and -t options.
1679 2005-12-09 Eric Blake <ebb9@byu.net>
1681 * src/test.c (main): Fix misleading comment.
1683 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1685 * NEWS: Mention dd's new noatime flag.
1686 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1687 * src/dd.c (flags, usage): Add support for noatime flag.
1689 2005-12-07 Jim Meyering <jim@meyering.net>
1691 Distribute the cvsu script, used only by `make syntax-check'.
1692 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1693 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1694 distribute a copy of this script.
1695 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1697 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1698 to create a temporary directory on another partition.
1699 From Andreas Gruenbacher.
1701 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1703 * man/basename.x: Cross-reference to dirname and readlink.
1704 * man/dirname.x: Cross-reference to basename and readlink.
1706 2005-12-05 Andreas Gruenbacher
1708 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1709 (set_owner, preserve_author): New functions, factored out of copy_reg.
1710 (copy_reg): Use them.
1711 (copy_internal): Use them here, too.
1713 2005-12-04 Jim Meyering <jim@meyering.net>
1715 * src/sleep.c (usage): Say what happens with two or more arguments.
1716 Suggested by Justin Pryzby.
1718 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1721 2005-12-03 Jim Meyering <jim@meyering.net>
1723 * src/rm.c (long_opts): Change the name of each undocumented, for-
1724 testing-only option to start with `-', so that it cannot render
1725 ambiguous any prefix it happens to share with some other option name.
1726 Problem reported by Eric Blake.
1727 * src/head.c (long_options): Likewise.
1728 * src/tail.c (long_options): Likewise.
1730 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1731 testing-only --presume* options to start with `---'.
1732 * tests/rm/dangling-symlink: Likewise.
1733 * tests/rm/dir-no-w: Likewise.
1734 * tests/rm/isatty: Likewise.
1736 2005-11-30 Jim Meyering <jim@meyering.net>
1738 * Makefile.maint: Add a comment about cvsu.
1740 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1742 * NEWS: df updates for "none", "proc", inaccessible file systems.
1743 * src/df.c (show_point): Ignore inaccessible file systems.
1744 (usage): -a includes dummy file systems, not size-0 file systems.
1746 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1747 to avoid collision with POSIX name space. All uses changed.
1749 2005-11-24 Jim Meyering <jim@meyering.net>
1751 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1752 * tests/acl: Add `$0: ' prefix to diagnostics.
1754 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1756 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1758 * src/copy.c: Improve performance a bit by optimizing away
1759 unnecessary system calls and going to a block size of at least
1760 8192 (on normal hosts, anyway). This improved performance 5% on my
1761 Debian stable host (2.4.27 kernel, x86, copying from root
1762 ext3 file system to itself).
1763 Include "buffer-lcm.h".
1764 (copy_reg): Omit last argument. All callers changed.
1765 Use xmalloc to allocate rather than trusting alloca
1766 (which is unwise with large block sizes).
1767 Declare locals more locally, if possible.
1768 Use uintptr_t words instead of int words, for a bit more speed
1769 when looking for null blocks on 64-bit hosts.
1770 Optimize away reads of zero bytes on regular files.
1771 In the typical case, insist on 8 KiB buffers, at least.
1772 Avoid unnecessary extra call to fstat when checking for sparse files.
1773 Avoid now-unnecessary cast to off_t, and "0L".
1774 Avoid unnecessary test of *new_dst when checking for same owner
1777 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1779 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1781 2005-11-22 Jim Meyering <jim@meyering.net>
1783 * src/remove.c (AD_push): Remove debugging cruft.
1785 * tests/rm/unread2 (rm): Change expected diagnostic,
1786 `cannot open directory' to `cannot remove', to align with
1788 * tests/rm/rm2: Ensure that rm now continues removing entries
1789 even after certain types of failure.
1791 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1792 that provide openat (Solaris), and on systems like Linux+procfs
1793 where our openat emulation code is reentrant. This also fixes a
1794 few low-probability leaks and eliminates some code that could,
1795 in very unusual circumstances, cause rm() (via a callee) to exit.
1796 * NEWS: Mention this.
1798 * configure.ac: Put copyright dates all on one line so the
1799 emacs function that updates them works properly.
1801 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1803 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1804 Problem reported by Eric Blake.
1805 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1806 we get a standard-conforming compiler. This relies on the new
1807 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1808 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1809 m4/c.m4 can go away with Autoconf 2.60 comes out.
1811 2005-11-17 Jim Meyering <jim@meyering.net>
1813 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1814 (AD_mark_current_as_unremovable): Likewise, but for a local.
1817 * tests/mv/acl: Let traps handle removing temporary directories.
1819 Expect acl-related tests to fail, until the corresponding
1820 patches are committed.
1821 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1822 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1824 ACL tests, from Andreas Gruenbacher.
1825 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1826 * tests/mv/Makefile.am (TESTS): Add acl.
1827 * tests/cp/Makefile.am (TESTS): Add acl.
1829 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1831 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1833 * NEWS: Improve quality of ln's diagnostics.
1834 * src/ln.c (do_link, usage): Likewise.
1835 (do_link): Don't use alloca on a buffer of unbounded size.
1837 2005-11-16 Jim Meyering <jim@meyering.net>
1839 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1840 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1841 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1842 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1843 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1845 2005-11-14 Jim Meyering <jim@meyering.net>
1847 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1849 2005-11-13 Jim Meyering <jim@meyering.net>
1851 * announce-gen: Accept new option, --gpg-key-id=ID and
1852 emit a blurb telling how to use the .sig files.
1853 * Makefile.cfg (gpg_key_ID): Define.
1854 * Makefile.maint (announcement): Use new option and key.
1856 Require that most .c files include <config.h>.
1857 * Makefile.maint (sc_require_config_h): New rule.
1858 (syntax-check-rules): Add it.
1859 * .x-sc_require_config_h: New file listing exceptions to the
1860 above rule. Some are legit, others are simply grandfathered in.
1861 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1863 2005-11-12 Jim Meyering <jim@meyering.net>
1865 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1867 2005-11-11 Jim Meyering <jim@meyering.net>
1869 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1870 Mention new readlink options in 5.3.0's `New features' section.
1871 Spotted by Thomas Hood.
1873 2005-11-08 Jim Meyering <jim@meyering.net>
1875 * NEWS: Merge in changes from b5_9x branch.
1877 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1879 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1880 like --time-style='posix-long-iso' if the locale settings are messed up.
1881 * src/ls.c (decode_switches): Implement this.
1883 2005-11-08 Jim Meyering <jim@meyering.net>
1885 * tests/du/2g: s/expensive/very expensive/ in a comment.
1888 2005-10-17 Eric Blake <ebb9@byu.net>
1890 * src/ls.c (usage): Fix descriptions of --sort, --time.
1891 Reported by Vitaly A. Ostanin.
1893 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1895 * src/ln.c: Include filenamecat.c.
1896 (FILE_BASENAME_CONCAT): Remove.
1897 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1898 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1899 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1902 2005-11-04 Jim Meyering <jim@meyering.net>
1904 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1905 on systems with stat.st_blocks of a signed 32-bit type.
1906 This bug causes trouble on some AIX 5.1 systems.
1907 Report and trivial patch from Paul Townsend:
1908 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1909 * NEWS: Mention this.
1911 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1912 * tests/du/Makefile.am (TESTS): Add it here.
1913 * tests/very-expensive: New file.
1914 * tests/Makefile.am (EXTRA_DIST): Add it here.
1915 * tests/cp/perm: Mark this test as `very-expensive', too.
1917 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1919 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1921 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1923 * src/rm.c (usage): Don't mention rm -d.
1925 2005-11-02 Jim Meyering <jim@meyering.net>
1927 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1928 From Andreas Schwab.
1930 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1931 `M+N records in/out' lines don't pollute `make check' output.
1933 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1934 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1935 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1936 to indicate that the input file should be piped into the command
1937 under test (via `cat FILE | $prog ...').
1939 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1940 (without -r) fails to remove a directory on a non-Linux system.
1941 This change affects only newer Solaris systems (with priv_*
1942 functions like priv_allocset). Reported by Keith Thompson.
1944 * tests/rm/dir-nonrecur: New file/test for the above fix.
1945 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1947 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1949 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1950 POSIX 1002.1-2001 requires.
1951 * src/tail.c (parse_obsolete_option): Implement this.
1952 Problem reported by Vincent Lefevre.
1953 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1954 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1955 (test_vector): Add special cases for _POSIX2_VERSION, and
1956 regularize the old ones a bit.
1957 * tests/touch/obsolescent: Add y2000 test.
1959 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1961 * src/dd.c (skip): Fix off-by-one error reported by
1962 Theodoros V. Kalamatianos.
1964 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1966 * tests/mkdir/p-3: Require that the test be run as non-root.
1967 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1969 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1971 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1972 boundary between DEST and SOURCE in the result.
1974 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1976 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1977 back to text, to sync with documentation and for backwards
1980 2005-10-25 Jim Meyering <jim@meyering.net>
1982 * tests/dircolors/simple (other-wr): Add an explicit test for
1983 the dircolors bug (NULL-dereference) fixed yesterday.
1985 2005-10-24 Jim Meyering <jim@meyering.net>
1987 * src/tac.c (tac_file): When determining whether a file is seekable,
1988 also test whether it is a tty. Using only the lseek-based test would
1989 give a false positive on Solaris. Reported by Peter Fales.
1991 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1993 * tests/install/d-slashdot: New test, for "install -d" failure.
1994 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1995 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1996 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1998 2005-10-24 Jim Meyering <jim@meyering.net>
2000 * src/dircolors.c (ls_codes): Add missing comma.
2001 Anonymous report and patch from
2002 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
2004 * src/dircolors.c: Add compile-time assertion that the slack_codes
2005 and ls_codes arrays have the same number of elements. This would
2006 have prevented the above-fixed bug.
2008 * src/expand.c (parse_tab_stops): Add a comment to make this function
2009 identical to the one in unexpand.c.
2010 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
2011 identical to the one in expand.c.
2013 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
2015 2005-10-23 Jim Meyering <jim@meyering.net>
2017 * src/md5sum.c (digest_check, main): Use ptr_align rather than
2018 a dangerous pointer-value-to-`unsigned' cast.
2019 * NEWS: mention the new sha* programs.
2020 * AUTHORS: Add new sha* programs.
2022 2005-08-28 David Madore <david.madore@ens.fr>
2024 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
2025 * README: Add their names to the list.
2026 * src/md5sum.c: Provide framework for computing sha-2 hashes.
2027 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
2028 Rules for compiling sha-2 utilities
2029 (noinst_HEADERS): Remove checksum.h.
2030 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
2032 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
2033 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
2034 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
2035 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
2036 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
2037 sha384sum, sha512sum test scripts here rather that each in its
2040 2005-08-28 David Madore <david.madore@ens.fr>
2042 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
2043 of the FIPS test vectors).
2045 2005-10-23 Jim Meyering <jim@meyering.net>
2047 * configure.ac: Use 6.0-cvs as the version string.
2048 * NEWS: Adjust accordingly.