1 2006-06-10 Jim Meyering <jim@meyering.net>
3 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
5 Require a "Version N.M" line at the top of the ChangeLog
6 file only when making the actual release, not when running
8 * Makefile.maint (maintainer-distcheck): Don't depend on
10 (alpha beta major): Depend on it here, instead.
12 2006-06-08 Jim Meyering <jim@meyering.net>
14 Ensure that cat works with any of the options, -A -v -e -E -T,
15 when applied to files in /proc and /sys, even when the FIONREAD
16 ioctl produces nonsensical results. Before this change, cat would
17 produce no output (or truncated output), for some linux kernels.
19 * src/cat.c (write_pending): New function, factored out of cat.
20 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
21 that there are bytes to read. Some versions of linux-2.6.16 do that.
22 Write any pending output before returning.
23 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
24 * NEWS: Mention this bug fix.
25 * tests/misc/cat-proc: New file. Test for the above.
26 * tests/misc/Makefile.am (TESTS): Add cat-proc.
28 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
30 * src/expr.c (eval4): Detect overflow properly when multiplying
33 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
35 * NEWS: The 'expr' command now detects and reports integer overflow.
36 (It would be better to use extended precision instead, but that
38 * src/expr.c (integer_overflow): New function.
39 (eval4, eval3): Check for integer overflow.
41 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
43 Fix problems when building with Solaris/SVR4/etc. make, which uses a
44 different and somewhat bogus implementation of VPATH. In the
45 directory tests/misc, rename tests whose names might appear in the
46 Automake-generated rules. For example, we can't use a test named
47 'test', since Automake generates a rule that contains the text
48 "if test -f ./$$tst; ...", and this might expand to something like
49 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
50 which executes the 'test' script rather than the 'test' command.
51 * tests/misc/false-status: Renamed from tests/misc/false.
52 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
53 * tests/misc/sort-merge: Renamed from tests/misc/sort.
54 ($prog): Set to 'sort' rather than to $PROG.
55 * tests/misc/test-diag: Renamed from tests/misc/test.
56 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
57 in case Solaris make has prepended the directory.
58 (TESTS): Adjust to above renamings.
59 * tests/misc/expand: Don't assign to PROG; no longer needed
60 now that Makefile.am sets PROG to the basename.
61 * tests/misc/fold: Likewise.
63 2006-06-03 Jim Meyering <jim@meyering.net>
65 Make `cp --link --no-dereference' work also on systems where the
66 link system call cannot create a hard link to a symbolic link.
67 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
68 the link syscall on a symlink when it would do the wrong thing.
69 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
70 * tests/cp/link-no-deref: New file/test for the above.
71 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
72 * NEWS: Mention the change (doesn't affect Linux).
74 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
76 Fix some porting problems in the test cases reported by
77 Ralf Wildenhues for HP-UX 11.23 in:
78 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
79 * tests/help-version: Don't assume that \< \> works in sed.
80 * tests/misc/close-stdout: Don't assume that >&- works.
82 * tests/touch/no-create-missing: Don't assume that >&- works.
84 2006-05-30 Jim Meyering <jim@meyering.net>
86 * src/ls.c (usage): Add `v' to the list of sorting-related options.
89 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
91 * tests/cp/fail-perm: source lang-default.
92 * tests/rm/inaccessible: Likewise.
94 2006-05-28 Jim Meyering <jim@meyering.net>
96 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
97 Recognize it, too. Reported by Ralf Wildenhues, in
98 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
100 2006-05-27 Jim Meyering <jim@meyering.net>
102 * src/chgrp.c: Support new options: --preserve-root and
103 --no-preserve-root. Somehow this program was skipped when those
104 options were added to chown, chmod, and rm. Reported by
105 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
106 * NEWS: Mention this.
108 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
110 * NEWS: Remove mention of --seed. We'll replace it with something
111 better, and don't want to indicate that it is supported.
112 * src/sort.c (usage): Likewise.
114 2006-05-20 Jim Meyering <jim@meyering.net>
116 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
118 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
119 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
120 FTS_COMFOLLOW. Spotted by Justin Pryzby.
122 * gnupload: Merge changes from automake, retaining the ""--to...
123 kludge to placate overzealous `make distcheck' check.
125 2006-05-19 Jim Meyering <jim@meyering.net>
127 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
128 FTS_TIGHT_CYCLE_CHECK directory traversal option.
129 Reported by Justin Pryzby in http://bugs.debian.org/367691
131 2006-05-15 Jim Meyering <jim@meyering.net>
133 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
136 2006-05-13 Jim Meyering <jim@meyering.net>
138 * tests/mv/no-target-dir: Test two more cases.
140 2006-05-11 Jim Meyering <jim@meyering.net>
142 mv -T DIR EMPTY_DIR no longer fails unconditionally
143 * src/copy.c (copy_internal): Don't manually prohibit a move where
144 the destination is an existing directory. Sometimes doing that is
145 valid. Let the rename system call enforce the rules. That is
146 allowed only when the source is a directory and the destination
147 directory (to be replaced) is empty. Reported by Eric Blake.
148 * tests/mv/no-target-dir: New file/test for this.
149 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
150 * NEWS: Mention this.
152 * tests/mv/atomic: New file/test for yesterday's fix.
153 * tests/mv/Makefile.am (TESTS): Add atomic.
155 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
157 2006-05-10 Jim Meyering <jim@meyering.net>
159 * src/copy.c (copy_internal): Don't explicitly unlink the destination
160 when moving a symlink into the place of an existing non-directory.
161 Reported by Joshua Hudson.
162 * NEWS: mention this.
164 2006-05-07 Jim Meyering <jim@meyering.net>
166 * Makefile.maint (patch-check): Fail if patch generates any output,
167 even merely for changed offsets.
169 * src/c99-to-c89.diff: Adjust to reflect new offsets.
171 * NEWS: Mention changes affecting df, pwd, shred.
173 2006-05-06 Jim Meyering <jim@meyering.net>
175 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
176 system condition where dirent.d_ino != stat.st_ino.
177 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
179 2006-05-06 Eric Blake <ebb9@byu.net>
181 * tests/ls/inode: Expand to test inode from readdir case.
182 * tests/ls/follow-slink: Expand to test broken links encountered
183 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
185 2006-05-06 Eric Blake <ebb9@byu.net>
187 * tests/mv/leak-fd: Work even on case-insensitive file system.
189 2006-05-04 Jim Meyering <jim@meyering.net>
191 * NEWS: Mention the 2006-03-19 pwd-related change that makes
192 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
194 2006-05-03 Jim Meyering <jim@meyering.net>
196 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
197 Use better macro parameter names: s/basename/key_name/,
198 s/basefunc/key_cmp_func. Fix typo in comment.
200 2006-04-29 Eric Blake <ebb9@byu.net>
202 * src/ls.c (main): On systems with d_type, directories_first only
203 implies format_needs_type, not format_needs_stat.
205 2006-05-03 Jim Meyering <jim@meyering.net>
207 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
208 after comma in arg list, from Eric Blake.
210 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
212 * tests/misc/date (relative-3): New test, derived from a bug
213 report by John Thomas McDole.
215 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
217 New option for ls: --group-directories-first.
218 It makes ls list directories before files.
219 * NEWS [New features]: Mention it.
220 * src/ls.c (sort_type): Rearrange to use as an array index when
221 choosing sort function; added new sort_numtypes member for
223 (time_type): Add new time_numtypes member for compile-time check.
224 (directories_first): New global variable.
225 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
226 (long_options): Add --directories-first.
227 (main): Support new option.
228 (is_directory): New function.
229 (extract_dirs_from_files): Use it.
230 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
231 (LIST_SORTFUNCTION_VARIANTS): New macros.
232 (sort_functions): New global variable.
233 (sort_files): Use it.
234 (usage): Document new option.
236 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
238 * src/shred.c (fillrand): The assertion was way too weak, due to
239 what must be a typo. Strengthen it to its intended value.
240 (dopass): Don't use alloca; it's not worth the aggravation here,
241 since it's used only to get a page-aligned buffer, and page
242 alignment doesn't buy us much here. I'm suspicious that alloca
243 causes problems on some hosts, due to a recent bug report by Adam
244 Waltman: http://bugs.gentoo.org/130246.
246 2006-04-18 Jim Meyering <jim@meyering.net>
248 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
249 sha384sum, sha512sum.
251 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
253 * src/chmod.c (describe_change): Adjust to filemode changes.
254 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
255 (print_long_format): Use (new) filemodestring rather than
256 (old) mode_string, so that we get more file types right, at least
257 in theory. Adjust to filemode changes.
258 * src/stat.c (human_access): Likewise.
260 2006-04-18 Jim Meyering <jim@meyering.net>
262 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
263 ignore file. This has never been enabled. Reported by Eric Blake.
265 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
267 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
268 bug in Interix. Just call symlink or link directly. All uses changed.
269 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
270 * src/stat.c (USE_STATVFS): New macro.
271 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
272 (NAMEMAX_FORMAT): define a bit more clearly, now that the
273 statvfs-using code is a bit more regular.
274 * src/system.h (sync) [!HAVE_SYNC]: New macro.
276 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
278 * NEWS: csplit, nl, expr now conform to POSIX better, and are
279 more-compatible with traditional Unix, with respect to regular
281 * src/csplit.c (extract_regexp): Set re_syntax_options to a
282 value that is compatible with what POSIX requires.
283 * src/nl.c (build_type_arg): Likewise.
284 * src/expr.c (docolon): Likewise. Also, don't let anchors match
285 newline; this fixes an incompatibility with tradition and with POSIX.
286 Don't warn about leading ^. POSIX says it is unspecified whether
287 ^ is a special character, which means that implementations can
288 either treat it as special or not, but either way a warning is not
289 allowed (unless the regexp is otherwise invalid). Instead, anchor
290 the expression but treat ^ as an anchor; this is the traditional
291 behavior (e.g., Solaris 10).
292 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
293 and the like as invalid expressions (exit status 2), not as
294 failure of 'expr' (exit status 3). This is more consistent with
296 * tests/expr/basic (fail-a): Adjust exit status to match new expr
297 behavior, for status 2 versus 3.
299 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
300 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
301 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
302 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
303 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
304 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
305 (bre61, bre62): New tests.
306 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
310 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
311 "if !". Do not assume that 'sed' can handle long, newline-free input.
312 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
314 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
316 Adjust to new regex.h API (with new fastmap type), and clean
317 up the regex storage allocation a bit.
319 * src/csplit.c (struct control): Put re_compiled member at the
320 end, since it's large. Change regexpr member from char * to bool;
321 all uses changed. Add new member fastmap.
322 (extract_regexp): regexp arg is now char const *, not char *.
323 Don't bother duplicating the regular expression; it's not needed.
324 Set fastmap from new fastmap member. Don't bother allocating
325 a buffer, as the regexp code does a better job than we do.
326 * src/expr.c (docolon): Allocate and use a fastmap.
327 Don't bother allocating a buffer.
328 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
330 (build_type_arg): New fastmap arg. All uses changed.
331 Don't bother allocating a buffer, but set a fastmap.
332 * src/ptx.c (context_regex_string, word_regex_string): Remove.
333 (context_regex, word_regex): New vars, replacing the above.
335 (struct regex_data): New type.
336 (compile_regex): Renamed from alloc_and_compile_regex, since
337 we no longer allocate storage. Arg is now a struct regex_data *,
338 not a const char *. All uses changed. Don't allocate the fastmap;
339 instead, take it from the caller. Don't convert size_t to int,
340 to avoid arithmetic overflow problems. Don't bother freeing
341 storage afterwards; it's not worth the aggravation.
342 * src/tac.c (compiled_separator_fastmap): New ver.
343 (main): Use it. Don't bother allocating a buffer.
345 2006-03-30 Jim Meyering <jim@meyering.net>
347 * src/dd.c (iwrite): Remove assignment without effect.
348 Reported by Felix Rauch Valenti.
350 2006-03-22 Eric Blake <ebb9@byu.net>
352 * src/ptx.c (usage): Remove mention of --copyright/-C.
353 (main): Alias --copyright to --version plus a deprecation warning.
354 * NEWS: Mention this.
356 2006-03-27 Jim Meyering <jim@meyering.net>
358 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
359 use of strtod. Tiny patch from Nickolai Zeldovich.
361 2006-03-11 Eric Blake <ebb9@byu.net>
363 * tests/misc/dirname: New file.
364 * tests/basename/Makefile.am: Delete.
365 * tests/basename/basic: Move to...
366 * tests/misc/basename: ... this new file. Add some tests,
367 including fixed behavior for //.
368 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
369 * tests/Makefile.am (SUBDIRS): Remove basename.
370 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
372 Improvements to dirname/basename handling on platforms like
373 cygwin with distinct // and with drive letters.
374 * NEWS: Document new behavior.
375 * src/basename.c (main): Don't strip suffix from file system
377 * src/cp.c (target_directory_operand): Use new last_component.
378 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
379 traversing the string.
380 * src/dircolors.c (guess_shell_syntax): Use new last_component.
381 * src/install.c (target_directory_operand, install_file_in_dir):
383 * src/ln.c (target_directory_operand, main): Likewise.
384 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
385 * src/mv.c (target_directory_operand, movefile): Likewise.
386 * src/remove.c (rm_1): Likewise.
387 * src/shred.c (wipename): Likewise.
388 * src/split.c (next_file_name): Likewise.
389 * src/su.c (log_su, run_shell): Likewise.
391 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
393 * NEWS: nohup diagnostics are now more precise, and nohup now
394 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
395 * src/nohup.c (main): Implement this.
396 * tests/misc/nohup: Test the new behavior.
398 2006-03-12 Jim Meyering <jim@meyering.net>
400 * src/copy.c (set_author): Rename function, from preserve_author.
402 * src/remove.c (AD_pop_and_chdir): Use new macro,
403 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
405 * src/system.h (SAME_INODE): Remove definition.
406 Include "same-inode.h", instead.
408 2006-03-11 Eric Blake <ebb9@byu.net>
410 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
412 2006-03-10 Jim Meyering <jim@meyering.net>
414 Fix a bug whereby a user with write access to a directory being removed
415 could cause the removal of that directory to fail with an erroneous
416 diagnostic about a directory cycle. Reported by Vineet Chadha.
418 * NEWS: Mention this.
419 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
420 leave (and try to rmdir) is the one whose dev_ino is being used to
421 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
423 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
425 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
426 * src/dd.c (set_fd_flags): Handle file-creation flags on file
427 descriptors, rather than ignoring them.
428 * tests/dd/misc: Add test cases for append, nofollow, directory,
429 and nolinks flags. Simplify redirection to /dev/null in some cases.
431 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
432 noatime test never tested anything.
434 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
436 * src/dd.c (flags, usage): New flags directory, nolinks.
437 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
439 * src/ls.c (usage): Mention that -f disables --color.
440 Problem reported by Niels Möller.
442 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
444 * man/*.x: Add references to syscalls from utilities of the same name.
446 2006-03-05 Jim Meyering <jim@meyering.net>
448 * tests/help-version: Set SHELL, if not already set, in order to
449 avoid failure when `make check' is run through debuild; dircolors
450 would fail due to lack of $SHELL. Reported by Sven Joachim.
452 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
453 * src/base64.c (wrap_write, do_encode, main): Change type of
454 parameters and locals, wrap_column, form size_t to uintmax_t.
455 (main): Adjust to use xstrtoumax, accordingly.
457 2006-03-03 Jim Meyering <jim@meyering.net>
459 Don't fail when run from an environment with SHELL not a Bourne
460 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
461 * tests/dircolors/simple: Invoke each non-failing test with -b.
462 Reported by Michael Stone.
464 2006-02-27 Jim Meyering <jim@meyering.net>
466 * tests/misc/base64: Derive --decode-using tests from the
469 * tests/misc/base64: Factor out a long constant string.
470 Split lines to stay within 80 columns.
472 * tests/misc/Makefile.am (TESTS): Add base64.
473 * tests/misc/base64: Test base64. From Simon Josefsson.
475 * src/base64.c (do_decode): Use correct type for parameter,
476 ignore_garbage: s/size_t/bool/.
478 * src/base64.c: Don't include .h files already included by system.h:
479 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
480 Include "system.h" before the other lib/*.h header files.
481 Include <sys/types.h> before "system.h".
482 (wrap_write): Remove declaration of unused local, initial_column.
483 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
485 * README: Add base64 to the list.
487 2006-02-17 Simon Josefsson <jas@extundo.com>
490 * AUTHORS: Mention base64.
492 * man/Makefile.am: Build base64.1.
493 * man/base64.x: New file.
494 * src/Makefile.am (bin_PROGRAMS): Add base64.
495 * src/base64.c: New file.
497 2006-02-25 Eric Blake <ebb9@byu.net>
499 In ls, avoid calling stat for --inode (-i), when possible.
500 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
501 * src/system.h: ... here, for use in ...
502 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
504 (gobble_file): Add inode argument.
505 (print_dir): Pass inode if available.
506 (usage): Remove inaccuracy.
508 2006-02-23 Jim Meyering <jim@meyering.net>
510 * TODO: Update/correct some obsolete entries.
512 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
514 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
515 * src/join.c (usage): Likewise.
516 Documentation problem reported by Philip Kensche.
518 2006-02-20 Eric Blake <ebb9@byu.net>
520 * man/rm.x: Update documentation to match previous patch.
522 2006-02-18 Eric Blake <ebb9@byu.net>
524 New option for rm: --interactive=once (-I).
525 * NEWS: Document it, along with change to rm --interactive.
526 * TODO: Remove entry for implementing rm -I
527 * src/rm.c (INTERACTIVE_OPTION): New enum value.
528 (interactive_type): New enum.
529 (long_opts): Let interactive take an optional argument.
530 (interactive_args, interactive_types): New option arguments.
531 (usage): Document -I, --interactive=WHEN. Use program_name
532 instead of a basename.
533 (main): New -I option, new behavior to --interactive.
534 * tests/rm/interactive-once: New tests.
535 * tests/rm/interactive-always: Ditto.
536 * tests/rm/Makefile.am (TESTS): Run them.
538 2006-02-18 Jim Meyering <jim@meyering.net>
540 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
541 expression match more of the target lines, e.g., those that start with
542 `-S,' (short option followed by a comma) or that include `=[...]'.
543 Patch by Nicolas François.
544 Fix the four offenders thus exposed:
545 * src/join.c (usage): Use two spaces (not one) to separate the
546 --first-only option string from its description, so help2man formats
547 the derived man page properly.
548 * src/pr.c (usage): Likewise.
549 * src/uniq.c (usage): Likewise.
550 * src/install.c (usage): Likewise.
552 2006-02-15 Jim Meyering <jim@meyering.net>
554 * Makefile.maint (alpha beta major): For `make major', ensure that the
555 version string is of the form N.N[.N]*, where N is one or more digits.
557 2006-02-14 Jim Meyering <jim@meyering.net>
559 * INSTALL: Update from gnulib.
561 2006-02-13 Jim Meyering <jim@meyering.net>
563 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
565 2006-02-12 Jim Meyering <jim@meyering.net>
567 * Makefile.maint (patch-check): New target.
568 (local-checks-available): Add to the list.
570 2006-02-11 Jim Meyering <jim@meyering.net>
572 * src/c99-to-c89.diff: New file.
573 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
575 * .x-po-check: New file, with exclusions so that `make distcheck'
577 * Makefile.am (EXTRA_DIST): Add .x-po-check.
579 rm -r must remove an empty directory, even if it is inaccessible.
580 * src/remove.c (close_preserve_errno): New function.
581 (fd_to_subdirp): Don't print a diagnostic in this function.
582 Do it from the callers instead, unless rmdir succeeds.
583 (remove_cwd_entries, remove_dir): Adjust callers.
584 * tests/rm/empty-inacc: New test for the above.
585 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
586 * NEWS: Mention this bug fix.
587 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
588 a tiny bit less precise: cannot remove `a/1': ... instead of
589 cannot open directory `a/1': ...
591 * Makefile.maint (syntax-check-rules): Automatically derive this
592 list of sc_-prefixed rule names.
594 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
596 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
597 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
598 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
599 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
600 go away? was that an accident?)
601 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
602 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
603 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
604 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
605 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
606 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
607 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
608 (author_mark_check, makefile_path_separator_check):
609 Output line numbers, to simplify navigation of Emacs *compilation*
611 (sc_prohibit_atoi_atof, sc_file_system):
612 Rework slightly so that Makefile.maint doesn't get reported as a
613 violation of its own syntax rules.
614 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
615 it at run-time (which didn't work with Bison). Fix a makefile typo,
616 caught by Makefile.maint itself: spaces where a tab should be.
617 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
618 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
619 Ignore djgpp and man subdirectories, to avoid false matches with
620 Bison and coreutils, respectively. Use sort -u to remove the
621 resulting duplicates.
622 * gnupload: Rework slightly to avoid bogus warning from
623 sc_two_space_separator_in_usage.
625 2006-02-10 Jim Meyering <jim@meyering.net>
627 Use gzip's --rsyncable option only if it's available.
628 * Makefile.maint (gzip_rsyncable): New variable.
631 2006-02-08 Jim Meyering <jim@meyering.net>
633 * Makefile.maint (local-checks-available): Define in terms of
634 the expansion, $(syntax-check-rules), rather than the single,
635 top-level target `syntax-check', so that it's easier to exclude
636 individual rules (via $(local-checks-to-skip)).
637 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
639 2006-02-07 Jim Meyering <jim@meyering.net>
641 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
642 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
644 * tests/help-version (expected_failure_status_vdir):
645 Redirect an expected disk-full diagnostic to /dev/null.
647 2006-02-06 Jim Meyering <jim@meyering.net>
649 * src/unexpand.c (usage): Use two spaces (not one) to separate the
650 --first-only option string from its description, so help2man formats
651 the derived man page properly.
652 * src/rm.c (usage): Likewise for --no-preserve-root.
653 * src/chown.c (usage): Likewise.
654 * src/chgrp.c (usage): Likewise.
656 Add a rule to ensure that the above doesn't happen again.
657 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
658 (syntax-check-rules): Add it.
659 * .x-sc_two_space_separator_in_usage: New empty file.
660 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
662 2006-02-06 Jim Meyering <jim@meyering.net>
664 * src/cp.c (usage): Use two spaces (not one) to separate each
665 option string from its description, so help2man formats the
666 derived man page properly.
667 * src/mv.c (usage): Likewise.
668 Patch from Nicolas François in http://bugs.debian.org/351601.
670 2006-02-04 Jim Meyering <jim@meyering.net>
672 * src/copy.c (copy_internal): cp -RL would fail when encountering
673 the same directory more than once in the hierarchy beneath a single
674 command-line argument. That is legitimate, e.g. when there are
675 two or more symbolic links, each pointing to some directory that
676 would not otherwise be copied. Reported by Christophe LYON.
677 * tests/cp/cp-deref: New file. Test for today's fix.
678 * tests/cp/Makefile.am (TESTS): Add cp-deref.
679 * NEWS: Document this.
681 2006-02-03 Jim Meyering <jim@meyering.net>
683 * configure.ac: Require automake-1.9.6, not 1.8.3.
685 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
687 * src/od.c (usage): Mention that -t a ignores high order bit.
688 Documentation problem reported by Ed Avis.
690 2006-02-01 Jim Meyering <jim@meyering.net>
692 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
694 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
696 * src/head.c (main): Use a better diagnostic when someone uses a
697 trailing numeric option in an invalid way. Problem reported by
699 * src/tail.c (parse_options): Likewise.
701 2006-01-30 Jim Meyering <jim@meyering.net>
703 * man/wc.x: Include `count' keyword in man page synopsis,
704 per suggestion from http://bugs.debian.org/181585.
706 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
708 * src/df.c (show_dev): If the file system claims to have
709 more available than total blocks, report the number of used
710 blocks as being total - available (a negative number) rather
711 than as garbage. Problem reported by Toralf Foerster.
713 2006-01-24 Jim Meyering <jim@meyering.net>
715 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
716 to put a regular file in O_NONBLOCK mode fails with EPERM.
717 That happens on Linux (up to 2.6.15) when using tail -f on a file with
718 the append-only attribute. Reported by Dean Gaudet. For details,
719 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
720 * NEWS: Mention this fix.
721 * tests/tail-2/append-only: New file. Test for the above.
722 * tests/tail-2/Makefile.am (TESTS): Add append-only.
723 * tests/Makefile.am (check-root): Add tail-2/append-only
725 2006-01-21 Jim Meyering <jim@meyering.net>
727 * NEWS: Mention fts-related improvements and bug fixes.
729 2006-01-19 Jim Meyering <jim@meyering.net>
731 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
732 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
734 2006-01-18 Jim Meyering <jim@meyering.net>
736 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
738 2006-01-17 Jim Meyering <jim@meyering.net>
740 Now that fts no longer changes the current working directory, adjust
741 its clients accordingly -- note that du.c uses fts but doesn't need
742 any adjustment, since it doesn't operate on the actual files,
743 but rather just uses the stat buffers provided by fts.
745 * src/chown-core.c: Include "openat.h".
746 Don't include "lchown.h".
747 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
748 calling openat, lchownat, chownat, rather than open, lchown, chown.
750 * src/chmod.c: Include "openat.h".
751 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
753 * tests/du/long-from-unreadable: New test, to exercise one small
756 2006-01-13 Jim Meyering <jim@meyering.net>
758 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
759 addition of new directories under tests/.
761 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
764 2006-01-12 Jim Meyering <jim@meyering.net>
766 * tests/du/long-sloop: Adjust not to hard-code the expected
767 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
768 from that of GNU libc. Reported by Paul Eggert.
770 * tests/du/long-sloop: Create file at end of symlink chain.
772 * tests/misc/test: New file, with a test for one of the
773 bugs fixed by yesterday's test.c changes.
774 * tests/misc/Makefile.am (TESTS): Add test.
776 2006-01-11 Jim Meyering <jim@meyering.net>
778 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
779 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
780 a very long sequence of symbolic links (not necessarily a loop).
781 * tests/du/Makefile.am (TESTS): Add long-sloop.
783 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
785 * src/test.c (test_syntax_error): Append a newline. All callers
786 changed, except for the ones that didn't already append a newline.
787 Bug reported by Eric Blake.
789 2006-01-11 Jim Meyering <jim@meyering.net>
791 * src/system.h (X2NREALLOC): Now that verify_true is no longer
792 void, cast its result to void, to avoid gcc's warning that
793 ``left-hand operand of comma expression has no effect''.
794 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
796 2006-01-10 Jim Meyering <jim@meyering.net>
798 * tests/chmod/no-x: Add a test for today's fts.c fix.
800 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
802 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
803 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
805 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
807 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
808 Use verify_true instead of verify_expr, to sync with gnulib.
810 2006-01-08 Jim Meyering <jim@meyering.net>
812 * src/date.c (usage): Adjust the formatting of the entries for
813 %::z and %:::z (separate with two spaces, not one) so that help2man
814 formats them properly. Reported by Philip Rowlands.
816 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
818 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
820 2006-01-06 Jim Meyering <jim@meyering.net>
822 * Makefile.maint (copyright-check): Use date +%Y in place of
825 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
826 First off, the attribute should have been `volatile' (not static)
827 to avoid longjmp-related risk of clobber. Secondly, now there is
828 no longer any risk of a local variable being clobbered, so there's
829 no need for any attribute at all.
831 2006-01-05 Jim Meyering <jim@meyering.net>
833 * src/remove.c: Give a few functions the inline attribute.
834 (AD_pop_and_chdir): Use gotos to avoid some duplication.
835 (AD_push): Rewrite an assertion so that the entire computation
836 goes away when assertions are turned off.
838 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
839 It's already defined in "system.h".
840 * Makefile.maint: Add a FIXME comment.
842 2006-01-04 Jim Meyering <jim@meyering.net>
844 * ChangeLog: Remove entries from 2005-10-22 and earlier.
845 * ChangeLog-2005: New file, for entries up to version 5.92.
847 2006-01-03 Jim Meyering <jim@meyering.net>
849 * tests/du/no-x: Also allow a slightly different diagnostic -- the
850 one you get when using openat-enabled fts.c and du (coming soon).
851 * tests/chmod/no-x: Likewise.
852 * tests/chgrp/no-x: Likewise.
854 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
856 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
858 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
859 (restricted_chown): Return it, if the file cannot be accessed due
860 to EPERM, or if no uid or gid are required, or if the file is
861 neither a directory nor a regular file. Rewrite to avoid gotos.
862 (change_file_owner): Handle RC_do_ordinary_chown case.
863 Rewrite to avoid gotos.
864 * tests/chgrp/basic: Make sure we can change the group of
867 * src/date.c (usage): Explain %g, %G, and %V a bit better.
869 2006-01-02 Jim Meyering <jim@meyering.net>
871 * src/copy.c (set_owner): Correct a comment.
873 * src/tail.c (parse_options): Change warning to say that --retry
874 is useful `mainly' (not `only') when following by name.
875 Reported here: http://bugs.debian.org/273781
877 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
879 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
880 * src/copy.c: Include lchmod.h.
881 (copy_internal): Use lchmod rather than chmod.
882 * src/cp.c: Include lchmod.h.
883 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
884 * src/mkdir.c: Include lchmod.h.
885 (usage): Clarify -m's operation.
886 (main): Use lchmod rather than chmod. Don't use lchmod unless the
887 new mode contains bits outside the 777 range.
888 * src/mkfifo.c (usage): Clarify -m's operation.
889 (main): If -m is given, don't invoke chmod; use umask 0 instead.
890 Report an error if -m asks for bits outside the 777 range.
891 * src/mknod.c (usage, main): Likewise.
893 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
895 2005-12-27 Jim Meyering <jim@meyering.net>
897 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
898 (sc_prohibit_assert_without_use): New rule.
899 (syntax-check-rules): Add it to the list.
900 * .x-sc_prohibit_assert_without_use: New empty file.
901 * Makefile.am (EXTRA_DIST): Add it.
903 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
905 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
906 Don't include <assert.h>; it wasn't used.
908 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
910 * src/chown-core.c (restricted_chown):
911 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
912 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
913 | O_NOFOLLOW too, for consistency with other dir-openers.
914 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
915 (is_empty_dir): Likewise.
916 * src/shred.c (wipename): Likewise. Don't bother trying to open
917 dir for writing, since POSIX prohibits it.
919 2005-12-22 Jim Meyering <jim@meyering.net>
921 * tests/help-version: Redirect stderr to /dev/full, to suppress
922 write error diagnostic.
924 2005-12-19 Jim Meyering <jim@meyering.net>
926 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
927 Avoid a minor race condition when `-m MODE' is specified, by using
928 open, fchown, and close rather than just chown. To do that reliably --
929 even with an overly restrictive umask -- ensure that each mkdir,
930 mknod and mkfifo call uses a mode including at least owner-read access.
931 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
932 the subsequent chown (or equivalent open,fchown,close) fails.
933 * tests/misc/mknod: New tests.
934 * tests/misc/Makefile.am (TESTS): Add mknod.
936 2005-12-17 Jim Meyering <jim@meyering.net>
938 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
939 e.g., on a named pipe.
940 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
941 place of all uses, since it is guaranteed (system.h) to be defined.
943 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
945 Add POSIX ACL support
946 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
947 is no requirement for ACL support; particularly, it does not exist
948 on systems that have POSIX ACLs.
949 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
950 * src/cp.c (umask_kill): With default acls, the umask is not to be
951 applied. Remove umask_kill, don't change the process umask, and let
952 the kernel apply the umask where appropriate.
953 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
954 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
956 (copy_reg, copy_internal): Use copy_acl and set_acl
957 instead of fchown/chown. Fix the logic for POSIX ACLs.
958 (chown_succeded): Remove; we now always copy acls and
959 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
960 did a chown before or not.
961 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
962 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
963 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
964 to link with it via $(LIB_ACL), for the utilities that need it.
966 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
968 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
969 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
970 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
971 value is now signified by whether cwd_errno is null.
972 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
973 pointer-to-bool to pointer-to-errno-value. All callers changed.
974 (rm_1): Don't bother setting a local cwd failure flag and then
975 ORing it into the caller's. Just set the caller's.
976 (rm): Use cwd failure errno value to print a slightly-better
979 2005-12-15 Jim Meyering <jim@meyering.net>
981 * src/stat.c (print_it): Properly handle a backslash at the
982 end of a --printf format string. Reported by Paul Eggert.
983 * tests/misc/stat-printf (end-bs): Add a test for the above.
985 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
987 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
988 Don't assume /etc/passwd contains user names; use 'id' instead.
990 2005-12-15 Jim Meyering <jim@meyering.net>
992 stat: revert behavior of --format=FMT (-c)
993 stat: add new option: --printf=FMT
994 * NEWS: Mention this.
995 * src/stat.c (isodigit, octtobin, hextobin): Define.
996 (PRINTF_OPTION): Define.
997 (interpret_backslash_escapes, trailing_delim): New globals.
998 (usage): Document them. Alphabetize on long option names.
999 (print_esc_char): New function.
1000 (print_it): Rewrite, in order to handle backslash escapes.
1001 (main): Handle new option. Set globals for --format, too.
1003 * tests/misc/stat-printf: Test --printf and --format.
1004 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1006 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1008 * NEWS: sort now reports incompatible options.
1009 * src/sort.c (incompatible_options, check_ordering_compatibility):
1011 (main): Use them. Don't bother with a usage message for
1012 "sort -c a b", for consistency with other error diagnostics.
1013 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1016 * src/cat.c (main): Undo previous change. close_stdout already
1017 does the check, so the previous change wasn't necessary.
1019 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1021 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1023 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1025 Install a more-conservative approach for sort -R. It's the
1026 same basic idea as the existing code, except it uses the full ISAAC
1027 approach (called the "more kosher" approach in the existing comments).
1028 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1029 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1030 better to be conservative here at first, and review any performance
1031 improvements carefully.
1032 * .x-sc_require_config_h: Add src/rand-isaac.c.
1033 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1034 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1035 (shred_SOURCES, sort_SOURCES): Remove.
1036 (EXTRA_DIST): Add rand-isaac.c.
1037 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1038 changing it to allow for varying numbers of words in the state.
1039 Alter so that we include rand-isaac.c directly rather than
1040 compiling it and linking to it. Don't include config.h or
1041 system.h; that's the includer's responsibility.
1042 Omit functions that are specific to shred.
1043 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1044 (isaac_step, struct irand_state):
1045 Resurrect these, with the same defns that used to be in shred.c.
1046 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1047 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1049 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1050 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1051 (irand_init, irand32, irand_mod):
1052 Number of words is constant again.
1053 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1054 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1055 * src/sort.c: Likewise.
1056 * src/shred.c (fillrand, dopass, main): Undo previous change.
1057 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1059 * src/sort.c: Don't include md5.h; it wasn't needed.
1060 (struct keyfield): Rename random_hash to random, for consistency
1061 with the other member names. All uses changed.
1062 (usage): Tweak wording to mention STRING for --seed option.
1063 (short_options): Rorder for consistency with other programs.
1064 (rand_state): Now a struct, not a pointer to one. All uses changed.
1065 (HASH_WORDS, HASH_SIZE): Remove.
1066 (get_hash): Remove comments around resbuf size, since we can assume C89.
1067 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1068 (keycompare): Adjust to the new get_hash.
1070 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1071 (main): Don't set need_random simply because gkey has it set; that
1072 doesn't necessarily mean we'll need random numbers.
1073 Redo seeding to match new get_hash approach.
1075 2005-12-10 Jim Meyering <jim@meyering.net>
1077 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1079 Avoid shred segfault on 64-bit systems.
1080 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1081 local of type uint32_t. Make the local an `int' instead.
1083 * NEWS: Mention sort's new options.
1085 * src/rand-isaac.c (isaac_mix): Declare to be static.
1086 Mark all other functions as `extern' so the tight-scope
1087 part of `make distcheck' passes once again.
1088 * src/rand-isaac.h (isaac_mix): Remove declaration.
1090 * src/sort.c (get_hash): Change position of `*' in parameter
1091 type to conform with convention.
1092 (main): Split a long line so it fits in 80 columns.
1093 (keycompare): Remove stray SPACE before TAB that was
1094 causing `make distcheck' to fail.
1096 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1098 * tests/misc/sort-rand: New file: basic tests for the new options.
1099 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1101 2005-12-10 Frederik Eaton <frederik@ofb.net>
1103 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1104 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1105 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1106 Make state size runtime-configurable.
1107 (isaac_new, isaac_copy): New functions.
1108 * src/rand-isaac.h: New file.
1109 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1110 (fillrand, main): Adjust to the fact that the state size is now
1111 runtime-configurable.
1112 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1113 (usage): Add options --random-sort and --seed to implement a random
1115 Include md5.h and rand-isaac.h.
1116 (get_hash): New function.
1117 (rand_state): New var.
1118 (HASH_WORDS, HASH_SIZE): New macros.
1120 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1122 * tests/dd/misc: Add test for dd iflags=noatime.
1124 2005-12-09 Jim Meyering <jim@meyering.net>
1126 * src/sort.c (usage): Mention white space vs -b and -t options.
1129 2005-12-09 Eric Blake <ebb9@byu.net>
1131 * src/test.c (main): Fix misleading comment.
1133 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1135 * NEWS: Mention dd's new noatime flag.
1136 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1137 * src/dd.c (flags, usage): Add support for noatime flag.
1139 2005-12-07 Jim Meyering <jim@meyering.net>
1141 Distribute the cvsu script, used only by `make syntax-check'.
1142 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1143 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1144 distribute a copy of this script.
1145 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1147 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1148 to create a temporary directory on another partition.
1149 From Andreas Gruenbacher.
1151 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1153 * man/basename.x: Cross-reference to dirname and readlink.
1154 * man/dirname.x: Cross-reference to basename and readlink.
1156 2005-12-05 Andreas Gruenbacher
1158 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1159 (set_owner, preserve_author): New functions, factored out of copy_reg.
1160 (copy_reg): Use them.
1161 (copy_internal): Use them here, too.
1163 2005-12-04 Jim Meyering <jim@meyering.net>
1165 * src/sleep.c (usage): Say what happens with two or more arguments.
1166 Suggested by Justin Pryzby.
1168 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1171 2005-12-03 Jim Meyering <jim@meyering.net>
1173 * src/rm.c (long_opts): Change the name of each undocumented, for-
1174 testing-only option to start with `-', so that it cannot render
1175 ambiguous any prefix it happens to share with some other option name.
1176 Problem reported by Eric Blake.
1177 * src/head.c (long_options): Likewise.
1178 * src/tail.c (long_options): Likewise.
1180 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1181 testing-only --presume* options to start with `---'.
1182 * tests/rm/dangling-symlink: Likewise.
1183 * tests/rm/dir-no-w: Likewise.
1184 * tests/rm/isatty: Likewise.
1186 2005-11-30 Jim Meyering <jim@meyering.net>
1188 * Makefile.maint: Add a comment about cvsu.
1190 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1192 * NEWS: df updates for "none", "proc", inaccessible file systems.
1193 * src/df.c (show_point): Ignore inaccessible file systems.
1194 (usage): -a includes dummy file systems, not size-0 file systems.
1196 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1197 to avoid collision with POSIX name space. All uses changed.
1199 2005-11-24 Jim Meyering <jim@meyering.net>
1201 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1202 * tests/acl: Add `$0: ' prefix to diagnostics.
1204 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1206 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1208 * src/copy.c: Improve performance a bit by optimizing away
1209 unnecessary system calls and going to a block size of at least
1210 8192 (on normal hosts, anyway). This improved performance 5% on my
1211 Debian stable host (2.4.27 kernel, x86, copying from root
1212 ext3 file system to itself).
1213 Include "buffer-lcm.h".
1214 (copy_reg): Omit last argument. All callers changed.
1215 Use xmalloc to allocate rather than trusting alloca
1216 (which is unwise with large block sizes).
1217 Declare locals more locally, if possible.
1218 Use uintptr_t words instead of int words, for a bit more speed
1219 when looking for null blocks on 64-bit hosts.
1220 Optimize away reads of zero bytes on regular files.
1221 In the typical case, insist on 8 KiB buffers, at least.
1222 Avoid unnecessary extra call to fstat when checking for sparse files.
1223 Avoid now-unnecessary cast to off_t, and "0L".
1224 Avoid unnecessary test of *new_dst when checking for same owner
1227 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1229 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1231 2005-11-22 Jim Meyering <jim@meyering.net>
1233 * src/remove.c (AD_push): Remove debugging cruft.
1235 * tests/rm/unread2 (rm): Change expected diagnostic,
1236 `cannot open directory' to `cannot remove', to align with
1238 * tests/rm/rm2: Ensure that rm now continues removing entries
1239 even after certain types of failure.
1241 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1242 that provide openat (Solaris), and on systems like Linux+procfs
1243 where our openat emulation code is reentrant. This also fixes a
1244 few low-probability leaks and eliminates some code that could,
1245 in very unusual circumstances, cause rm() (via a callee) to exit.
1246 * NEWS: Mention this.
1248 * configure.ac: Put copyright dates all on one line so the
1249 emacs function that updates them works properly.
1251 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1253 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1254 Problem reported by Eric Blake.
1255 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1256 we get a standard-conforming compiler. This relies on the new
1257 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1258 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1259 m4/c.m4 can go away with Autoconf 2.60 comes out.
1261 2005-11-17 Jim Meyering <jim@meyering.net>
1263 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1264 (AD_mark_current_as_unremovable): Likewise, but for a local.
1267 * tests/mv/acl: Let traps handle removing temporary directories.
1269 Expect acl-related tests to fail, until the corresponding
1270 patches are committed.
1271 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1272 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1274 ACL tests, from Andreas Gruenbacher.
1275 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1276 * tests/mv/Makefile.am (TESTS): Add acl.
1277 * tests/cp/Makefile.am (TESTS): Add acl.
1279 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1281 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1283 * NEWS: Improve quality of ln's diagnostics.
1284 * src/ln.c (do_link, usage): Likewise.
1285 (do_link): Don't use alloca on a buffer of unbounded size.
1287 2005-11-16 Jim Meyering <jim@meyering.net>
1289 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1290 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1291 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1292 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1293 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1295 2005-11-14 Jim Meyering <jim@meyering.net>
1297 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1299 2005-11-13 Jim Meyering <jim@meyering.net>
1301 * announce-gen: Accept new option, --gpg-key-id=ID and
1302 emit a blurb telling how to use the .sig files.
1303 * Makefile.cfg (gpg_key_ID): Define.
1304 * Makefile.maint (announcement): Use new option and key.
1306 Require that most .c files include <config.h>.
1307 * Makefile.maint (sc_require_config_h): New rule.
1308 (syntax-check-rules): Add it.
1309 * .x-sc_require_config_h: New file listing exceptions to the
1310 above rule. Some are legit, others are simply grandfathered in.
1311 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1313 2005-11-12 Jim Meyering <jim@meyering.net>
1315 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1317 2005-11-11 Jim Meyering <jim@meyering.net>
1319 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1320 Mention new readlink options in 5.3.0's `New features' section.
1321 Spotted by Thomas Hood.
1323 2005-11-08 Jim Meyering <jim@meyering.net>
1325 * NEWS: Merge in changes from b5_9x branch.
1327 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1329 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1330 like --time-style='posix-long-iso' if the locale settings are messed up.
1331 * src/ls.c (decode_switches): Implement this.
1333 2005-11-08 Jim Meyering <jim@meyering.net>
1335 * tests/du/2g: s/expensive/very expensive/ in a comment.
1338 2005-10-17 Eric Blake <ebb9@byu.net>
1340 * src/ls.c (usage): Fix descriptions of --sort, --time.
1341 Reported by Vitaly A. Ostanin.
1343 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1345 * src/ln.c: Include filenamecat.c.
1346 (FILE_BASENAME_CONCAT): Remove.
1347 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1348 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1349 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1352 2005-11-04 Jim Meyering <jim@meyering.net>
1354 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1355 on systems with stat.st_blocks of a signed 32-bit type.
1356 This bug causes trouble on some AIX 5.1 systems.
1357 Report and trivial patch from Paul Townsend:
1358 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1359 * NEWS: Mention this.
1361 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1362 * tests/du/Makefile.am (TESTS): Add it here.
1363 * tests/very-expensive: New file.
1364 * tests/Makefile.am (EXTRA_DIST): Add it here.
1365 * tests/cp/perm: Mark this test as `very-expensive', too.
1367 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1369 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1371 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1373 * src/rm.c (usage): Don't mention rm -d.
1375 2005-11-02 Jim Meyering <jim@meyering.net>
1377 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1378 From Andreas Schwab.
1380 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1381 `M+N records in/out' lines don't pollute `make check' output.
1383 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1384 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1385 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1386 to indicate that the input file should be piped into the command
1387 under test (via `cat FILE | $prog ...').
1389 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1390 (without -r) fails to remove a directory on a non-Linux system.
1391 This change affects only newer Solaris systems (with priv_*
1392 functions like priv_allocset). Reported by Keith Thompson.
1394 * tests/rm/dir-nonrecur: New file/test for the above fix.
1395 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1397 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1399 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1400 POSIX 1002.1-2001 requires.
1401 * src/tail.c (parse_obsolete_option): Implement this.
1402 Problem reported by Vincent Lefevre.
1403 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1404 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1405 (test_vector): Add special cases for _POSIX2_VERSION, and
1406 regularize the old ones a bit.
1407 * tests/touch/obsolescent: Add y2000 test.
1409 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1411 * src/dd.c (skip): Fix off-by-one error reported by
1412 Theodoros V. Kalamatianos.
1414 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1416 * tests/mkdir/p-3: Require that the test be run as non-root.
1417 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1419 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1421 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1422 boundary between DEST and SOURCE in the result.
1424 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1426 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1427 back to text, to sync with documentation and for backwards
1430 2005-10-25 Jim Meyering <jim@meyering.net>
1432 * tests/dircolors/simple (other-wr): Add an explicit test for
1433 the dircolors bug (NULL-dereference) fixed yesterday.
1435 2005-10-24 Jim Meyering <jim@meyering.net>
1437 * src/tac.c (tac_file): When determining whether a file is seekable,
1438 also test whether it is a tty. Using only the lseek-based test would
1439 give a false positive on Solaris. Reported by Peter Fales.
1441 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1443 * tests/install/d-slashdot: New test, for "install -d" failure.
1444 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1445 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1446 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1448 2005-10-24 Jim Meyering <jim@meyering.net>
1450 * src/dircolors.c (ls_codes): Add missing comma.
1451 Anonymous report and patch from
1452 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1454 * src/dircolors.c: Add compile-time assertion that the slack_codes
1455 and ls_codes arrays have the same number of elements. This would
1456 have prevented the above-fixed bug.
1458 * src/expand.c (parse_tab_stops): Add a comment to make this function
1459 identical to the one in unexpand.c.
1460 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1461 identical to the one in expand.c.
1463 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1465 2005-10-23 Jim Meyering <jim@meyering.net>
1467 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1468 a dangerous pointer-value-to-`unsigned' cast.
1469 * NEWS: mention the new sha* programs.
1470 * AUTHORS: Add new sha* programs.
1472 2005-08-28 David Madore <david.madore@ens.fr>
1474 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1475 * README: Add their names to the list.
1476 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1477 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1478 Rules for compiling sha-2 utilities
1479 (noinst_HEADERS): Remove checksum.h.
1480 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1482 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1483 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1484 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1485 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1486 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1487 sha384sum, sha512sum test scripts here rather that each in its
1490 2005-08-28 David Madore <david.madore@ens.fr>
1492 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1493 of the FIPS test vectors).
1495 2005-10-23 Jim Meyering <jim@meyering.net>
1497 * configure.ac: Use 6.0-cvs as the version string.
1498 * NEWS: Adjust accordingly.