1 2005-06-14 William Brendling <wbrendling@gmail.com>
3 * src/du.c: Add --last-time and --time-style options.
5 2005-06-22 Paul Eggert <eggert@cs.ucla.edu>
9 * tests/umask-check: New file.
10 * tests/Makefile.am (EXTRA_DIST): Add umask-check.
11 * tests/mkdir/perm: Use umask-check.
12 * tests/cp/cp-parents: Likewise, instead of using chmod
13 as described below. Problem reported by Kevin Mudrick.
15 2005-06-22 Jim Meyering <jim@meyering.net>
17 Make rmdir produce diagnostics like this:
18 rmdir: /tmp: Permission denied
20 rmdir: `/tmp': Permission denied
22 * src/rmdir.c: Include "quotearg.h", not "quote.h".
23 (remove_parents, main): Use quotearg_colon, not quote.
25 2005-06-22 Paul Eggert <eggert@cs.ucla.edu>
27 * tests/cp/cp-parents: Use chmod to work around some hosts with
28 ACL problems. Problem reported by Kevin Mudrick.
30 2005-06-21 Jim Meyering <jim@meyering.net>
32 * tests/du/deref-args: Use --apparent-size to avoid the vagaries
33 of counting blocks. Kevin Mudrick reported that this test would
34 fail on an nfs-mounted directory where attribute-caching is
37 2005-06-19 Jim Meyering <jim@meyering.net>
39 * src/tac.c (tac_mem, tac_stdin_to_mem): Remove #if-0'd functions.
41 * src/shred.c (usage): Use `file system', not `filesystem'.
43 2005-06-18 Jim Meyering <jim@meyering.net>
45 * src/tr.c (unquote): Remove unnecessary `' quotes from a diagnostic.
47 2005-06-17 Jim Meyering <jim@meyering.net>
49 * src/shred.c (usage): Clarify that shred works on an ext3 file
50 system as long as it's not in data=journal mode.
51 Tiny change by Mark Melahn.
53 2005-06-16 Paul Eggert <eggert@cs.ucla.edu>
55 * src/hostid.c (main): Don't print fewer than 8 digits, or spurious
56 leading "f"s. "f" problem reported by Tim Waugh.
57 * NEWS: Document this.
59 2005-06-16 Jim Meyering <jim@meyering.net>
61 Don't embed `this'-style quotes in format strings.
62 * src/tr.c: Rather than this: error (..., "...`%s'...", arg);
63 do this: error (..., "...%s...", quote (arg));
64 * src/od.c, src/tr.c, src/csplit.c, src/date.c, src/hostname.c:
65 * src/join.c, src/ptx.c, src/seq.c, src/sort.c, src/split.c:
66 * src/split.c, src/tail.c: Likewise.
68 * src/sleep.c: Include "quote.h". Remove hard-coded quotes, as above.
69 * src/nice.c, src/printf.c, src/fold.c, src/pr.c: Likewise.
70 * src/factor.c, src/cat.c, src/expr.c, src/stty.c: Likewise.
72 * src/mv.c: Finally remove support for --version-control=S (-V).
73 It was deprecated nearly 6 years ago and has been warning
74 users to switch to --backup=S since fileutils-4.0j.
75 * src/cp.c, src/install.c, src/ln.c: Likewise.
77 2005-06-15 Jim Meyering <jim@meyering.net>
79 * src/install.c (main): Fix my typo: s/argv[optind]/file[i]/.
80 * tests/install/basic-1: Ensure that each `-d'-specified directory
81 is created. Ensure that rel-named dirs are not created when
84 * tests/mkdir/p-3: Add a test for just-fixed bug in mkdir-p.c.
86 2005-06-14 Paul Eggert <eggert@cs.ucla.edu>
88 Improve diagnostics for restore_cwd failure.
89 * src/install.c (main): Standardize on a diagnostic for
90 restore_cwd failure, and report errno.
91 (install_file_in_file_parents): Fail if restore_cwd fails and
92 one of the files is relative. This fixes a bug (albeit unlikely).
93 * src/mkdir.c (create_parents): Remove static var (now local to 'main').
94 (main): Standardize on a diagnostic for restore_cwd failure,
96 Don't bother to check cwd_errno unless create_parents.
97 Use mkdir rather than make_dir; it's simpler.
99 * src/install.c (main): Adjust to new make_dir_parents convention.
100 * src/mkdir.c (main): Likewise.
102 2005-06-14 Jim Meyering <jim@meyering.net>
104 * tests/mkdir/p-3: Ensure mkdir succeeds if the following argument
105 is an absolute directory name.
107 * Makefile.maint (my-distcheck): Add -Wall to the list of options that
108 are used with -Werror. This target is not intended for general use.
110 2005-06-13 Jim Meyering <jim@meyering.net>
112 * src/mkdir.c (main): Give a diagnostic for -- and skip -- each
113 relative directory name after make_dir_parents fails to restore
114 the working directory. Before, `mkdir -p' could create directories
115 in the wrong place in unusual circumstances.
116 * src/install.c (main): Likewise.
117 (install_file_in_file_parents): Update make_dir_parents caller.
118 * tests/mkdir/p-3: New test for today's mkdir.c/mkdir-p.c bug fixes.
119 * tests/mkdir/Makefile.am (TESTS): Add p-3.
121 2005-06-10 Paul Eggert <eggert@cs.ucla.edu>
123 Act on the Austin Group's response yesterday to XCU ERN 63; see
124 <http://www.opengroup.org/austin/docs/austin_260.txt>.
125 * NEWS: ls no longer outputs an extra space between mode and link count.
126 * doc/coreutils.texi: Remove the extra spaces in "ls -l" output.
127 * src/ls.c (any_has_acl): New var.
128 (clear_files): Clear it.
129 (gobble_file): Set it if a file has an ACL.
130 (print_long_format): Omit needless space unless some file has an ACL.
132 2005-06-10 Jim Meyering <jim@meyering.net>
134 * src/system.h (VERIFY_W_TYPEOF): Add parentheses.
136 2005-06-02 Jim Meyering <jim@meyering.net>
138 * src/sort.c (usage): Put `Ordering options:' line where it belongs.
140 2005-06-01 Paul Eggert <eggert@cs.ucla.edu>
142 Use "file name" when talking about file names, instead of "filename"
143 or "path", as per the GNU coding standards.
144 * src/basename.c: Don't use "path" or "filename".
145 * src/copy.c: Likewise.
146 * src/copy.h: Likewise.
147 * src/cp-hash.c: Likewise.
148 * src/cp.c: Likewise.
149 * src/df.c: Likewise.
150 * src/install.c: Likewise.
151 * src/ls.c: Likewise.
152 * src/pinky.c: Likewise.
153 * src/pr.c: Likewise.
154 * src/pwd.c: Likewise.
155 * src/remove.c: Likewise.
156 * src/rmdir.c: Likewise.
157 * src/sort.c: Likewise.
158 * src/system.h: Likewise.
159 * src/tty.c: Likewise.
160 * src/who.c: Likewise.
161 * src/cp.c (parents_option): Renamed from flag_path. All uses changed.
162 (make_dir_parents_private): Renamed from make_path_private.
164 * src/cp.c (usage): Don't use "path" to describe a file name.
165 * src/readlink.c (usage): Likewise.
166 * src/rmdir.c (usage): Likewise.
167 * src/df.c: Don't include "path-concat.h"; not needed.
168 * src/install.c (install_file_in_file_parents): Renamed from
169 install_file_to_path. All uses changed.
170 * src/ln.c (FILE_BASENAME_CONCAT): Renamed from PATH_BASENAME_CONCAT.
172 * src/ls.c (make_link_name): Renamed from make_link_path.
174 * src/pwd.c (struct file_name): Renamed from struct Path.
176 (file_name_free): Renamed from path_free. All uses changed.
177 (file_name_init): Renamed from path_init. All uses changed.
178 (file_name_prepend): Renamed from path_prepend. All uses changed.
179 * src/rmdir.c (remove_empty_parents): Renamed from empty_paths.
181 (longopts): Add comment that --path is deprecated.
183 2005-05-31 Jim Meyering <jim@meyering.net>
185 * src/copy.c (chown_privileges, chown_failure_ok): Mark as `extern'.
186 This is a crutch so that `make distcheck's sc_tight_scope rule
187 knows that they really are deliberately declared that way.
189 2005-05-30 Paul Eggert <eggert@cs.ucla.edu>
191 Port to Solaris 10's rules for whether programs can chown files.
192 * src/copy.c [HAVE_PRIV_H]: Include <priv.h>.
193 (DO_CHOWN): Remove. Replaced by chown_failure_ok. All callers
195 (copy_internal): If chown failed, don't worry about what happened
196 to the mode bits; they can't have changed.
197 (chown_privileges, chown_failure_ok): New functions.
198 * src/copy.h: Add copyright notice.
199 (struct cp_options): Remove myeuid member. Add chown_privileges
201 (chown_privileges, chown_failure_ok): New function decls.
202 * src/cp.c (re_protect): Remove unnecessary call to geteuid.
203 Use chown_failure_ok rather than our own code.
204 * src/cp.c (cp_options_init): Use chown_privileges rather than geteuid.
205 * src/install.c (cp_option_init): Likewise.
206 * src/mv.c (cp_option_init): Likewise.
208 2005-05-29 Paul Eggert <eggert@cs.ucla.edu>
210 * src/chgrp.c (getgrnam) [!defined _POSIX_VERSION]: Remove decl.
211 * src/chown-core.c (getgrnam, getgrgid) [!defined _POSIX_VERSION]:
213 * src/cp.c (geteuid) [!defined _POSIX_VERSION]: Remove decl.
214 * src/id.c (getpwuid, getgrgid, getuid, getgid, geteuid, getegid)
215 [!defined _POSIX_VERSION]: Remove decls.
216 * src/install.c (getpwnam, getgrnam): Remove decl.
217 (getuid, getgid) [!defined _POSIX_VERSION]: Remove decls.
218 * src/md5sum.c (OPENOPTS, TEXT1T01, TEXTCNVT): Remove.
219 (digest_file): Use O_BINARY-using expr instead of OPENOPTS.
220 * src/system.h: Don't bother mentioning _POSIX_VERSION in comment.
221 * src/test.c: Include sys/param.h if it exists, not if _POSIX_VERSION
223 Don't include <sys/file.h>; no longer needed.
224 (getegid, geteuid): Remove no-longer-necessary decls.
226 * src/pathchk.c (_POSIX_PATH_MAX) [!defined _POSIX_PATH_MAX]:
227 Define to 256, not 255, as per modern POSIX.
229 2005-05-27 Paul Eggert <eggert@cs.ucla.edu>
231 * NEWS: dd seek=N now conforms to POSIX if the output isn't seekable.
232 * src/dd.c (skip): Return the number of records that were not
233 skipped due to encountering EOF.
234 (dd_copy): If the file wasn't seekable and EOF was encountered,
235 write zeros past EOF until the desired offset is reached.
237 * NEWS: expr and test now correctly compare integers of unlimited size.
238 (Also, correct a comment that claimed that expr detects integer
239 overflow; it does so only when converting from strings.)
240 * src/expr.c: Include strnumcmp.h, xstrtol.h.
241 (looks_like_integer): New function.
242 (toarith): Use it. Also, use xstrtoimax rather than rolling our
244 (eval2): Don't look for trouble if !evaluate; this simplifies things.
245 Compare numbers using string comparison, so that overflow is
247 * src/sort.c: Refactor so that others can use large-integer
248 comparison functions.
249 Include "strnumcmp.h".
250 (NEGATION_SIGN, NUMERIC_ZERO, fraccompare):
251 Remove; moved to strnumcmp.
252 (decimal_point): Now int, to simplify converison overhead with
253 new API. All uses changed.
254 (thousands_sep): Now -1 if there isn't one, as per new API.
256 (numcompare): Move contents to strnumcmp module, except for
258 * src/test.c: Include inttostr.h, strnumcmp.h.
259 (whitespace, digit, digit_value, integer_expected_error): Remove.
260 (is_int): Remove; replaced by...
261 (find_int): New function.
262 (binary_operator): Don't let integers overflow in comparisons;
263 return the correct answer instead. Simplify the code.
264 (unary_operator): Convert the integer ourself, since find_int
266 * tests/expr/basic (bigcmp): New test.
267 * tests/test/Test.pm (eq-6, gt-5, lt-5): New tests.
269 2005-05-26 Paul Eggert <eggert@cs.ucla.edu>
271 * NEWS: nohup now redirects a tty stdin to an unreadable fd
272 instead of closing it.
273 * doc/coreutils.texi (nohup invocation): Document this.
274 * src/nohup.c (main): Implement this.
276 2005-05-26 Jim Meyering <jim@meyering.net>
278 * src/expr.c (toarith): Fix a sign error introduced on 2005-01-14.
279 Reported by David Alan Gilbert.
280 * tests/expr/basic: Add tests using arithmetic on negative integers.
282 2005-05-19 Jim Meyering <jim@meyering.net>
284 * src/remove.c (AD_mark_helper, AD_mark_current_as_unremovable):
285 Remove inaccurate-but-harmless `const' attributes.
287 * src/join.c (decode_field_spec): Add an abort after
288 `error (EXIT_FAILURE, ...' to avoid a gcc warning in caller,
289 about variables being used uninitialized.
291 2005-05-18 Paul Eggert <eggert@cs.ucla.edu>
293 * configure.ac: Add copyright notice. gl_LIB_CHECK -> cu_LIB_CHECK.
294 * src/Makefile.am: Add copyright notice.
295 (factor_LDADD): Remove, as factor no longer needs sqrt.
296 * src/hostname.c: Remove test for HAVE_LIMITS_H; we can assume
297 it's always true now.
299 2005-05-16 Paul Eggert <eggert@cs.ucla.edu>
301 Fix Cygwin porting problem reported by Eric Blake.
302 * src/remove.c (DT_IS_DIR): Remove.
303 (DT_IS_KNOWN, DT_MUST_BE): New macros.
304 (remove_entry): Use them.
306 2005-05-14 Paul Eggert <eggert@cs.ucla.edu>
308 * src/remove.c: Include unlinkdir.h.
309 (UNLINK_CAN_UNLINK_DIRS): Remove.
310 (remove_entry): Use cannot_unlink_dirs () rather than
311 UNLINK_CAN_UNLINK_DIRS.
313 2005-05-14 Jim Meyering <jim@meyering.net>
315 Update FSF postal mail address.
316 * Makefile.maint, Makefile.cfg, gnupload
317 * src/basename.c, src/cat.c, src/checksum.h, src/chgrp.c
318 * src/chmod.c, src/chown-core.c, src/chown-core.h, src/chown.c
319 * src/chroot.c, src/cksum.c, src/comm.c, src/copy.c, src/copy.h
320 * src/cp-hash.c, src/cp-hash.h, src/cp.c, src/csplit.c, src/cut.c
321 * src/date.c, src/dcgen, src/dd.c, src/df.c, src/dircolors.c
322 * src/dirname.c, src/du.c, src/echo.c, src/env.c, src/expand.c
323 * src/expr.c, src/factor.c, src/fmt.c, src/fold.c, src/fs.h
324 * src/groups.sh, src/head.c, src/hostid.c, src/hostname.c, src/id.c
325 * src/install.c, src/join.c, src/kill.c, src/lbracket.c, src/link.c
326 * src/ln.c, src/logname.c, src/ls-dir.c, src/ls-ls.c, src/ls-vdir.c
327 * src/ls.c, src/ls.h, src/md5.c, src/md5sum.c, src/mkdir.c
328 * src/mkfifo.c, src/mknod.c, src/mv.c, src/nice.c, src/nl.c
329 * src/nohup.c, src/od.c, src/paste.c, src/pathchk.c, src/pinky.c
330 * src/pr.c, src/printenv.c, src/printf.c, src/ptx.c, src/pwd.c
331 * src/readlink.c, src/remove.c, src/remove.h, src/rm.c, src/rmdir.c
332 * src/seq.c, src/setuidgid.c, src/sha1sum.c, src/shred.c
333 * src/sleep.c, src/sort.c, src/split.c, src/stat.c, src/stty.c
334 * src/su.c, src/sum.c, src/sync.c, src/system.h, src/tac-pipe.c
335 * src/tac.c, src/tail.c, src/tee.c, src/test.c, src/touch.c
336 * src/tr.c, src/true.c, src/tsort.c, src/tty.c, src/uname.c
337 * src/unexpand.c, src/uniq.c, src/unlink.c, src/uptime.c
338 * src/users.c, src/wc.c, src/who.c, src/whoami.c, src/yes.c
340 2005-05-13 Jim Meyering <jim@meyering.net>
342 * NEWS: `rm -r' now removes all of the files it should, even on
343 systems with a buggy readdir affecting file systems inaccessible
346 In some unusual circumstances `rm -r' would fail to remove --
347 or even consider -- all entries in a directory with more than 254
348 (SunOS) or 338 (Darwin) entries. This could cause trouble even on
349 other types of systems when using an affected file system via e.g.,
350 NFS. The underlying cause was a bug in readdir on those systems.
351 Coreutils-5.2.1 and earlier used a configure-time test designed
352 to detect precisely those problem systems, but it would detect
353 the problem and enable remove.c's work-around code only when its
354 configure-time test was run on a losing file system. Obviously,
355 it couldn't detect a problem if the offending file system wasn't
356 tested or even mounted at coreutils configure time. Now, rm itself
357 performs a minimal-cost run-time test to detect the problem.
359 * src/remove.c (CONSECUTIVE_READDIR_UNLINK_THRESHOLD): Define.
360 (remove_cwd_entries): When readdir returns NULL for a directory from
361 which we've removed more than CONSECUTIVE_READDIR_UNLINK_THRESHOLD
362 entries, call rewinddir and then resume the readdir/unlink loop.
363 (UNLINK_CAN_UNLINK_DIRS): Rename from ROOT_CAN_UNLINK_DIRS.
365 2005-05-12 Paul Eggert <eggert@cs.ucla.edu>
367 * NEWS: nohup now closes stdin if it is a terminal, unless
368 POSIXLY_CORRECT is set. This fixes a glitch noted by Wayne Pollock in
369 <https://www.opengroup.org/sophocles/show_mail.tpl?
370 source=L&listname=austin-group-l&id=8341>.
371 * doc/coreutils.texi (nohup invocation): Document this.
372 * src/nohup.c (main): Implement this.
374 2005-05-12 Jim Meyering <jim@meyering.net>
376 * src/date.c: Assume `free (NULL)' works.
377 * src/dd.c: Likewise.
379 * src/dircolors.c:Likewise.
380 * src/head.c: Likewise.
381 * src/ls.c: Likewise.
382 * src/md5sum.c: Likewise.
383 * src/pr.c: Likewise.
384 * src/sort.c: Likewise.
386 2005-05-10 Jim Meyering <jim@meyering.net>
388 * tests/touch/not-owner: Skip this test if the user running it
389 owns `/' or has write access to it.
391 * src/copy.c (abandon_move): Remove erroneous UNWRITABLE check.
392 This makes `mv -i --reply=no f1 f2' work as expected (in not
393 performing the move operation). But note that specifying `-i'
394 after `--reply=no' does *not* work.
395 Tiny patch from Vlada Macek.
397 * tests/mv/reply-no: New file. Test for the above fix.
398 * tests/mv/Makefile.am (TESTS): Add reply-no.
400 * tests/ls-2/tests: Don't print PATH to stderr.
402 2005-05-08 Paul Eggert <eggert@cs.ucla.edu>
404 * NEWS: cp, ln, mv, rm no longer discard white space when intepreting
407 2005-05-06 Paul Eggert <eggert@cs.ucla.edu>
409 * NEWS: dd has new iflag= and oflag= flags "binary" and "text".
410 * src/dd.c (flags, usage): Add support for "binary" and "text".
412 2005-05-04 Paul Eggert <eggert@cs.ucla.edu>
414 * NEWS: chmod -w now complains if it differs from chmod a-w.
415 * src/chmod.c: Include quotearg.h.
416 (diagnose_surprises): New var.
417 (process_file): Diagnose surprises. Simplify the logic a bit,
419 (main): Prepare to diagnose surprises. Remove useless code for
421 * tests/chmod/Makefile.am (TESTS): Add umask-x.
422 * tests/chmod/umask-x: New file.
424 2005-05-02 Paul Eggert <eggert@cs.ucla.edu>
426 * NEWS: ls --indicator-style=directory renamed to ls
427 --indicator-style=slash, to avoid confusion with ls --directory.
428 * src/ls.c (usage): Likewise.
429 (slash): Renamed from directory_only. All uses changed.
431 2005-05-01 Paul Eggert <eggert@cs.ucla.edu>
433 * NEWS: "chmod +1 foo" is now diagnosed.
435 2005-04-29 Paul Eggert <eggert@cs.ucla.edu>
437 * NEWS: ls -p now marks only directories. New option
438 --indicator-style=directory equivalent to -p.
439 * doc/coreutils.texi (ls invocation): Document this.
440 Also, mention ">" is for doors.
441 * src/ls.c (enum indicator_style): New constant directory_only,
443 (indicator_style_args, indicator_style_types): Set it appropriately.
444 (decode_switches, gobble_file, print_type_indicator):
445 (length_of_file_name_and_frills):
446 Implement the change described in NEWS.
447 (decode_switches): Quote ">", too.
448 (usage): Update to match the new behavior. Describe ">".
449 * tests/ls/file-type: Test for new behavior. Omit -1 option.
450 The "ls --color" test wasn't being checked; add a check for
451 "ls --color=auto" instead.
453 * tests/head/Test.pm: Don't set _POSIX2_VERSION; no longer needed.
454 * tests/misc/split-fail: Likewise.
455 * tests/pr/Test.pm: Likewise.
456 * tests/sort/Test.pm: Fix comment to match new behavior of "sort".
457 * tests/tail/Test.pm (tv): Rename tests from obs to obs-plus
458 if they use file names starting with +.
459 (test_vector): Don't set _POSIX2_VERSION if obs but not obs-plus.
460 * tests/uniq/Test.pm (tv, test_vector): Likewise.
462 The following was partly derived from a tiny change by Eric Blake:
463 * tests/misc/nice: Don't use 'set -'. It's not portable to strict
464 POSIX 1003.1-2001 hosts. Also, don't set _POSIX2_VERSION.
465 * tests/mkdir/perm: Don't use 'set -'. Simplify test construction.
466 Work even if the underyling system attaches ACLs to new dirs.
467 * tests/mv/part-hardlink: Don't use 'set -'.
468 * tests/stty/row-col-1: Don't use 'set -'.
470 2005-04-28 Paul Eggert <eggert@cs.ucla.edu>
472 * NEWS: Document fixes described below.
473 * src/chmod.c (change, umask_value): New static vars.
474 (reference_file): Move this static var to inside "main".
475 (process_file, process_files): Remove CHANGES arg; now taken from
476 static var. All uses changed.
477 (usage): Fix incorrect description of MODE operand.
478 (main): For invalid mode usages, output a brief usage message.
479 Adjust to new modechange API.
480 * install.c (main): Adjust to new modechange API.
481 Also, free the mode_change object when done.
482 * mkdir.c (main): Likewise.
483 * mkfifo.c (main): Likewise.
484 * mknod.c (main): Likewise.
485 * tests/chmod/equal-X: Check for =xX bug.
486 * tests/chmod/equals: Check for =u bug.
487 * tests/chmod/usage: Check for u+gr and ug,+x bugs.
489 2005-04-26 Paul Eggert <eggert@cs.ucla.edu>
491 Restore support for usages like "head -1" and "tail -1",
492 even when conforming to POSIX 1003.1-2001.
493 Fix bug with "POSIXLY_CORRECT=1 fold file -3".
494 join now supports a NUL field separator, e.g., "join -t '\0'".
495 join now detects and reports incompatible options, e.g.,
497 * NEWS: Document this.
498 * src/date.c: Remove posixver.h and its uses.
499 (COMMON_SHORT_OPTIONS): Remove.
500 (short_options): New constant.
501 (short_options, usage): -I now always takes an optional arg.
502 * src/expand.c: Remove posixver.h and its uses.
503 (shortopts): New constant. -DIGIT now always takes an optional arg.
504 (main): Revamp parsing of -DIGIT to let parse_tab_stops handle it.
505 Don't complain about -DIGIT.
506 * src/fold.c: Remove posixver.h and its uses.
507 (shortopts): New constant. -DIGIT now always takes an optional arg.
508 (main): Don't preprocess arg list; that was buggy. Use method
510 * src/head.c: Remove posixver.h and its uses.
511 (header_mode_option): Remove.
512 (main): Don't complain about obsolete -NUM args.
513 * src/join.c: Remove posixver.h and its uses.
514 (obsolete_usage): Remove.
515 (join_field_1, join_field_2): Initialize to SIZE_MAX to indicate
516 they haven't been set yet.
517 (tab): Now int, not char. Initialize to -1 to indicate white space
518 separates columns, so that we can use NUL as a separator.
520 (OBSOLETE_LONG_OPTIONS, get_option): Remove.
521 (string_to_join_field): Remove ERR_MSG_FMT arg; a single format
522 suffices. Use xstrtoul for sizes; it suffices.
523 (decode_field_spec): Report an error and exit on failure. Return void,
525 (add_field_list): Likewise.
526 (set_join_field): New function.
527 (enum operand_status): New enum.
528 (add_file_name): New args OPERAND_STATUS, JOPTION_COUNT,
529 PREV_OPTC_STATUS, OPTC_STATUS to handle the bewildering array of
530 possibilities with obsolete option parsing.
531 (main): Use it. Do not depend on POSIX version.
532 Check for conflicting options. Parse obsolete options -j1 and -j2
533 so that it is a pure extension to POSIX 1003.1-2001.
534 Allow '-t\0' to specify a NUL tab, stealing the code from 'sort'.
535 * src/nice.c: Remove posixver.h and its uses.
536 (main): Always support -NUM option.
537 * src/od.c: Remove posixver.h and its uses.
538 (short_options): New constant, which always supports -w[num].
539 (COMMON_SHORT_OPTIONS): Remove.
540 * src/pr.c: Remove posixver.h and its uses.
541 (short_options): New constant, which always supports -S[string].
542 (COMMON_SHORT_OPTIONS): Remove.
543 * src/sort.c: Remove posixver.h and its uses.
544 (short_options): New constant, which always supports -y arg.
545 (COMMON_SHORT_OPTIONS): Remove.
546 (main): Redo workaround for Solaris compatibility with -y.
547 This change isn't visible to the user; it just cleans up the
548 code so that we don't need posixver.h.
549 * src/split.c: Remove posixver.h and its uses.
550 (main): Don't complain about -NUM option.
551 * src/tail.c (parse_obsolete_option): Don't complain about -NUM.
552 * src/unexpand.c: Remove posixver.h and its uses.
553 (main): Don't complain about -TAB.
554 * src/uniq.c (main): Don't complain about -NUM.
556 2005-04-22 Paul Eggert <eggert@cs.ucla.edu>
558 * src/nohup.c (main): If getopt fails, exit with status 127,
559 not status 1. POSIX requires this.
560 * NEWS: Document this.
562 * src/nice.c (main): Report proper program name when getopt finds
563 trouble. Problem reported by Behdad Esfahbod.
565 * NEWS: Fix bug with "mkdir -m =+x dir"; the umask was being ignored
566 when the "+x" was being evaluated.
567 * mkdir.c (main): Compile mode with MODE_MASK_ALL and initial umask.
568 * mkfifo.c (main): Likewise.
569 * mknod.c (main): Likewise.
570 * tests/mkdir/perm: Test for the above bug.
572 2005-04-20 Paul Eggert <eggert@cs.ucla.edu>
574 Port test cases to Microsoft-Windows-related environments,
575 following suggestions from Eric Blake.
576 * tests/install/Makefile.am (TESTS_ENVIRONMENT): Add EXEEXT.
577 * tests/install/basic-1: Undo previous change.
578 (dd, dd2): New vars, which use $EXEEXT. All uses of dd and dd2 changed.
579 * tests/install/trap: Undo previous change.
580 (sig): New var. Use it insted of "trap '' CHLD".
581 Append $EXEEXT to executable name.
583 "fetish" -> "coreutils" in more places.
584 * tests/Coreutils.pm: Renamed from tests/Fetish.pm.
585 (package Coreutils): Renamed from package Fetish. All uses changed.
586 * tests/Makefile.am (EXTRA_DIST): Add Coreutils.pm and
589 2005-04-19 Paul Eggert <eggert@cs.ucla.edu>
591 * tests/mv/setup (dot_mount_point): Use stat -L, in case the
592 directory is actually a symbolic link. Problem reported by
595 * tests/mv/mv-special-1: Use test -p to test for fifos, rather
596 than the (incorrect) test -f and the (inadequate) ls. ls is
597 inadequate because on some hosts a buggy mv will create a file of
598 the wrong type (problem reported by Eric Blake). Skip this test
599 if test -p doesn't work.
601 * tests/chmod/setgid: Use numeric group ids, not symbolic group names,
602 since the latter can have shell metacharacters in them (e.g., spaces).
603 This follows up to the 2005-01-17 patch, which missed this occurrence.
605 2005-04-18 Paul Eggert <eggert@cs.ucla.edu>
607 "fetish" -> "coreutils" in several places.
608 * Makefile.cfg (ftp): Remove fetish.sf.net.
609 * Makefile.maint (emit_upload_commands): Likewise.
610 * src/Makefile.am (LDADD, $(PROGRAMS)): fetish -> coreutils.
611 * tests/group-names (COREUTILS_GROUPS): Renamed from FETISH_GROUPS.
612 * tests/chmod/setgid (FETISH_GROUP): Renamed from COREUTILS_GROUP.
614 * tests/install/basic-1: Use "cat", not "test", to test for
615 ../../src/dd. Problem reported by Eric Blake.
617 2005-04-18 Jim Meyering <jim@meyering.net>
619 * src/dd.c: Don't include stat-macros.h directly. system.h does that.
621 2005-04-17 Paul Eggert <eggert@cs.ucla.edu>
623 Work around a couple of "make check" failures reported for Cygwin
624 and ash by Eric Blake.
625 * tests/install/basic-1: Skip this test if ../../src/dd isn't readable.
626 * tests/install/trap: Skip this test if "trap '' CHLD" doesn't work.
628 2005-04-16 Jim Meyering <jim@meyering.net>
630 * src/dd.c (S_TYPEISSHM): Remove definition.
631 Get the definition by including "stat-macros.h", instead.
633 2005-04-14 Paul Eggert <eggert@cs.ucla.edu>
635 Fix test suite problems reported by Eric Blake on Cygwin.
636 * tests/mv/mv-special-1: Ignore chatter about when files are removed,
637 since POSIX doesn't require rename to fail across file systems.
638 * tests/mv/setup (dot_mount_point): Use stat rather than df, as
640 (other_partition_tmpdir): Remove df from name as that would be
643 2005-04-14 Jim Meyering <jim@meyering.net>
645 * src/chown-core.c: Correct typo, fchmod -> fchown, in a comment.
647 2005-04-12 Paul Eggert <eggert@cs.ucla.edu>
649 * src/ls.c (usage): "uid" -> "user ID".
651 2005-04-12 Jim Meyering <jim@meyering.net>
653 * src/tsort.c (tsort): Use "%s" as the format string,
654 rather than a diagnostic or a file name.
656 * src/comm.c (compare_files): Remove declaration of unused local.
658 * src/chown-core.c (chopt_free): Mark parameter as unused.
660 2005-04-11 Paul Eggert <eggert@cs.ucla.edu>
662 * man/chown.x: Reword to match user manual.
663 * man/id.x: Likewise.
664 * src/setuidgid.c (usage): Use "user ID", not "UID", and similarly
666 * src/whoami.c (usage, main): Likewise.
668 Add bulletproofing for cases where stdin, stdout, or stderr are closed.
669 * src/comm.c: Include stdio-safer.h.
670 (compare_files): Exit right away on I/O error rather than continuing
671 and producing confusing output and error messages.
672 Return void, not int; all callers changed.
673 Use fopen_safer to avoid confusion with file descriptors.
674 * src/copy.c: Include unistd-safer.h.
675 (copy_reg): Use fd_safer.
676 * src/csplit.c: Include stdio-safer.h.
677 (input_desc): Remove unnecessary static initialization.
678 (set_input_file): Use STDIN_FILENO, not 0.
679 (create_output_file): Use fopen_safer.
680 * src/dircolors.c (dc_parse_file): Don't assume fopen does not
682 * src/head.c (head_file): Don't assume open does not return 0.
683 * src/join.c: Include stdio-safer.h.
684 (main): Use fopen_safer. Simplify the resulting code.
685 * src/md5sum.c (digest_file, digest_check):
686 Don't assume that fopen does not return stdin.
687 * src/nohup.c: Include unistd-safer.h.
688 (main): Don't dup stderr to stdin or stdout by mistake.
689 * src/od.c (check_and_close): Don't assume fopen does not return stdin.
690 * src/paste.c (paste_serial): Likewise.
691 * src/pr.c: Include stdio-safer.h.
692 (open_file): Use fopen_safer.
693 (close_file): Don't assume fopen does not return stdin.
694 * src/ptx.c (main): Don't assume fopen returns stdout after closing
695 stdout. Use freopen instead.
696 * src/shred.c: Include unistd-safer.h.
697 (wipename): Use fd_safer on directory file descriptor.
698 (wipefile): Remove special case for /dev/fd/* on older hosts.
699 It didn't work in general, and wasn't documented.
701 * src/sort.c: Include unistd-safer.h.
702 (create_temp_file): Use fd_safer.
703 (xfclose): Don't assume fileno (stdin) == STDIN_FILENO, etc.
704 * src/split.c: Include unistd-safer.h.
705 (cwrite): Use fd_safer. Replace mystery constant 0666 with symbolic
706 version, as POSIX requires.
707 * src/sum.c (bsd_sum_file, sysv_sym_file):
708 Use same pattern as elsewhere for checking for stdin.
709 * src/tac.c: Include unistd-safer.h.
710 (copy_to_temp): Use fd_safer.
711 (tac_file): Don't assume fopen cannot return stdin.
712 * src/tail.c: Include unistd-safer.h rather than fcntl-safer.h.
713 (recheck, tail_file): Use fd_safer rather than open_safer.
714 * src/tee.c: Include stdio-safer.h.
715 (tee): Use fopen_safer.
716 * src/touch.c: Include unistd-safer.h.
717 (touch): Use fd_safer.
718 * src/tsort.c (have_read_stdin): Remove; no longer needed. All uses
720 (tsort): Do not assume fopen can't return stdin.
721 Close stdin before returning. All uses changed.
722 * src/unexpand.c (next_file): Don't assume fopen cannot return stdin.
723 * src/uniq.c: Include stdio_safer.h.
724 (check_file): Don't assume fopen cannot return stdin or stdout.
726 2005-04-09 Jim Meyering <jim@meyering.net>
728 * src/dd.c (quit): Define with ATTRIBUTE_NORETURN.
730 Now that close_stdout closes standard output unconditionally,
731 these workarounds for dd and cat are no longer necessary.
732 * src/dd.c (close_stdout_wrapper): Remove function.
733 (main): Call atexit with close_stdout, instead.
734 * src/cat.c (close_stdout_wrapper): Likewise.
735 Don't close STDOUT_FILENO explicitly; close_stdout does it.
737 * src/system.h (__attribute__): Readability nit:
739 # define __attribute__(x)
741 # define __attribute__(x) /* empty */
743 2005-04-09 Jim Meyering <jim@meyering.net>
745 * src/rm.c (usage): Mention that --recursive removes listed
746 directories too, not just their contents.
747 Say that by default, rm does not remove directories.
749 * src/pr.c: Don't include "timespec.h". system.h does that.
750 * Makefile.maint (sc_system_h_headers): Propagate exit status
753 2005-04-08 Paul Eggert <eggert@cs.ucla.edu>
755 * NEWS: Document that dd no longer treats QUIT or PIPE specially,
756 and when conforming to POSIX no longer treats USR1 specially.
757 Document that dd no longer dumps core when handling signals.
758 * src/system.h (RETSIGTYPE): Remove; no longer needed. All uses
760 * src/csplit.c (SA_NOCLDSTOP): Define to 0 if not defined.
762 (siginterrupt) [!HAVE_SIGINTERRUPT]: New macro.
763 (delete_all_files): New arg IN_SIGNAL_HANDLER, to avoid undefined
764 behavior when called from a signal handler. All uses changed.
765 (main) [!defined SA_NOCLDSTOP]:
766 Use siginterrupt to specify that system calls should be interrupted.
767 * src/dd.c: Do not include safe-read.h or full-write.h; no longer needed.
768 (process_signals): Add forward decl.
769 (SA_NOCLDSTOP, sigprocmask, sigset_t) [!defined SA_NOCLDSTOP]:
771 (siginterrupt) [! HAVE_SIGINTERRUPT]: New macro.
772 (SA_NODEFER) [!defined SA_NODEFER]: New macro.
773 (SA_RESETHAND) [!defined SA_RESETHAND]: New macro.
774 (caught_signals, interrupt_signal, info_signal_count, catch_siginfo):
776 (usage): Mention -USR1 versus -INFO.
777 (cleanup): Don't invoke print_stats; the caller must do it now.
779 (quit): Process signals just before exiting.
780 (interrupt_handler): Simply record the signal and return.
781 (siginfo_handler): Simply increment the signal counter and return.
782 (install_handler): Remove, replacing with:
783 (install_signal_handlers, process_signals, iread, iwrite):
784 New functions. All callers to safe_read and full_write replaced
785 by iread and iwrite. All callers to install_handler replaced by
787 * src/ls.c (SA_NOCLDSTOP): Define to 0 if not defined.
789 (siginterrupt) [! HAVE_SIGINTERRUPT]: New macro.
790 (main) [! SA_NOCLDSTOP]: Use it.
791 * src/shred.c: Remove all uses of signals; modern hosts have
792 /dev/random and don't need this gorp.
793 Do not include signal.h.
794 (env, sigill_handler, isaac_seed_machdep): Remove. All uses removed.
795 * src/sort.c (SA_NOCLDSTOP): Define to 0 if not defined.
797 (siginterrupt) [! HAVE_SIGINTERRUPT]: New macro.
798 (main) [! SA_NOCLDSTOP]: Use it.
800 * src/dd.c: Do not include inttostr.h, no longer needed.
801 (print_stats, main): Rewrite and simplify formats to use PRIuMAX
802 instead of umaxtostr.
803 (print_stats): Work even in languages that have special
804 forms for two of things, for r_truncate and w_bytes. We can't
805 fix delta_s in this way, since ngettext doesn't support floating-point.
806 (main): Rewrite to avoid casts.
808 2005-04-07 Jim Meyering <jim@meyering.net>
810 Placate gcc-4's -Wuninitialized.
811 * src/md5sum.c (digest_check) [lint]: Initialize hex_digest to NULL.
812 * src/test.c (binary_operator) [lint]: Initialize lt and rt to 0.
814 * src/test.c (is_int, age_of, binop): Declare `char *' parameters to
816 (binop): Move function definition to precede first use so we can...
817 (binop): ...remove prototype.
819 2005-04-05 Paul Eggert <eggert@cs.ucla.edu>
821 * man/Makefile.am (.x.1): Remove "COMMAND.td/" from examples.
822 * src/basename.c (usage): Add examples.
823 * src/cat.c (usage): Likewise.
824 * src/chgrp.c (usage): Likewise.
825 * src/chown.c (usage): Likewise.
826 * src/dirname.c (usage): Likewise.
828 2005-04-05 Jim Meyering <jim@meyering.net>
830 * src/nice.c (usage): Mention that some shells provide a
831 built-in function by the same name.
832 * src/nohup.c (usage): Likewise.
833 * src/printenv.c (usage):Likewise.
835 2005-04-04 Dmitry V. Levin <ldv@altlinux.org>
837 * src/tee.c (tee): When closing files, do not close stdout,
838 leave this job to close_stdout() instead.
839 * configure.ac (AC_CONFIG_FILES): Add tests/tee/Makefile.
840 * tests/Makefile.am (SUBDIRS): Add tee.
841 * tests/tee/Makefile.am: New file.
842 * tests/tee/.cvsignore: Likewise.
843 * tests/tee/{basic,dash}: New tee tests.
845 2005-04-04 Jim Meyering <jim@meyering.net>
847 * src/echo.c (usage): Mention that some shells provide a
848 built-in function by the same name.
849 * src/kill.c (usage): Likewise
850 * src/printf.c (usage): Likewise.
851 * src/pwd.c (usage): Likewise.
852 * src/stat.c (usage): Likewise.
853 * src/test.c (usage): Likewise.
854 * src/true.c (usage):
855 * src/system.h (USAGE_BUILTIN_WARNING): New macro.
857 * man/echo.x: Remove `DESCRIPTION' section, now that --help includes it.
858 * man/printf.x: Likewise.
859 * man/pwd.x: Likewise.
861 2005-04-03 Jim Meyering <jim@meyering.net>
863 * src/pr.c (main): Fix off-by-one error.
864 pr -$(perl -e 'print "0"x63 . 1') would write one byte beyond the
865 end of a malloc'd buffer.
867 2005-04-01 Jim Meyering <jim@meyering.net>
869 * src/pr.c (main): Free column_count_string when done with it.
871 Don't let pr treat +1:-1 like +1:18446744073709551615.
872 * src/pr.c (strtoumax): Remove declaration.
873 (first_last_page): Use xstrtoumax in place of strtoumax,
874 so we don't interpret a negative page number (e.g., in an option
875 like --pages=1:-1) as valid.
876 * tests/pr/Test.pm (neg-page): Add a test for this.
878 2005-03-30 Paul Eggert <eggert@cs.ucla.edu>
880 * src/pinky.c (short_pinky): Adjust to read_utmp signature change.
881 * src/uptime.c (uptime): New arg OPTIONS. All uses changed.
882 * src/users.c (users): Likewise.
883 * src/who.c (who): Likewise.
884 * src/uptime.c (main): Check PIDs when invoked with zero arguments.
885 * src/users.c (main): Likewise.
886 * src/who.c (main): Likewise. Also with two arguments.
887 Omit duplicate code in 2-arg case.
888 (UT_PID): Moved to ../lib/readutmp.h.
890 2005-03-29 Jim Meyering <jim@meyering.net>
892 * src/system.h (ptr_align): Declare `ptr' parameter to be a
893 `const' pointer, since this function never writes through it.
895 * src/uname.c: Indent cpp directives to reflect nesting.
897 2005-03-28 Jim Meyering <jim@meyering.net>
899 * src/seq.c (get_width_format) [HAVE_RINT && HAVE_MODF && HAVE_FLOOR]:
900 Add `void' to make this an ANSI-style function declaration.
901 * src/remove.c (ds_init): Likewise.
902 * src/pr.c (print_sep_string): Likewise.
904 * src/stty.c (speeds): Declare this array to be static.
905 * src/Makefile.am (sc_tight_scope): Adjust to catch any
906 new declarations like that of stty.c's `speeds'.
908 * src/system.h (GETOPT_HELP_OPTION_DECL): Use NULL, not `0'.
909 (GETOPT_VERSION_OPTION_DECL): Likewise.
910 * src/chown.c (long_options): Likewise.
911 * src/chgrp.c (long_options): Likewise.
912 * src/chmod.c (long_options): Likewise.
913 * src/cp.c (sparse_type_string, reply_args, decode_preserve_arg):
915 * src/chown-core.c (chopt_init): Likewise.
916 * src/comm.c (long_options): Likewise.
917 * src/copy.c (copy_reg): Likewise.
918 * src/csplit.c (extract_regexp): Likewise.
919 * src/cut.c (longopts): Likewise.
920 * src/date.c (time_spec_string): Likewise.
921 * src/df.c (find_mount_point, show_point): Likewise.
922 * src/expr.c (docolon): Likewise.
923 * src/fmt.c (long_options): Likewise.
924 * src/ls.c (time_style_args, indicator_style_args, long_options)
925 (format_args, sort_args, time_args, decode_switches)
926 (gobble_file): Likewise.
927 * src/md5sum.c (long_options): Likewise.
928 * src/mv.c (reply_args): Likewise.
929 * src/paste.c (longopts): Likewise.
930 * src/pinky.c (print_entry): Likewise.
931 * src/pr.c (long_options): Likewise.
932 * src/ptx.c (long_options, format_args): Likewise.
933 * src/readlink.c (longopts): Likewise.
934 * src/sort.c (long_options, mergefps): Likewise.
935 * src/stat.c (long_options): Likewise.
936 * src/tac.c (main): Likewise.
937 * src/tail.c (follow_mode_string): Likewise.
938 * src/touch.c (longopts, time_args): Likewise.
939 * src/uniq.c (delimit_method_string): Likewise.
940 * src/uptime.c (print_uptime): Likewise.
941 * src/who.c (print_user): Likewise.
943 2005-03-27 Jim Meyering <jim@meyering.net>
945 * src/dcgen: Simplify further, clean up.
946 Add a standard-output-closing global destructor.
948 * src/wheel-gen.pl: Use the same global destructor as dcgen.
950 2005-03-26 Paul Eggert <eggert@cs.ucla.edu>
952 * src/dcgen: Squeeze multiple blanks into one. Output a simple
953 array of adjacent strings rather than a more complicated data
954 structure; this saves space in the dircolors executable.
955 * src/dircolors.c (parse_line): Use char *, not unsigned char *.
957 (dc_parse_stream, main): Avoid casts.
958 Adjust to simpler data structure generated by new dcgen.
960 2005-03-25 Eric Blake <ebb9@byu.net> (tiny change)
962 * src/ls.c (usage): Document usage of LS_COLORS.
964 2005-03-25 Paul Eggert <eggert@cs.ucla.edu>
966 * src/dircolors.hin: Add "TERM cygwin".
968 2005-03-25 Jim Meyering <jim@meyering.net>
970 * src/system.h (DECIMAL_DIGIT_ACCUMULATE): Reverse the sense of
971 the return value, and update callers:
972 * src/cut.c (set_fields): Update use of DECIMAL_DIGIT_ACCUMULATE.
973 * src/expand.c (parse_tab_stops, main): Likewise.
974 * src/split.c (main): Likewise.
975 * src/unexpand.c (parse_tab_stops, main): Likewise.
976 * src/uniq.c (main): Likewise.
978 2005-03-22 Jim Meyering <jim@meyering.net>
980 * build-aux: New directory. Renamed from config.
981 * configure.ac: Reflect renaming: config -> build-aux.
982 * Makefile.am (dist-hook): Likewise.
983 * Makefile.maint: Likewise.
984 * Makefile.cfg (cvs_files): Likewise.
985 * .x-sc_sun_os_names: Likewise.
986 * .x-sc_trailing_blank: Likewise.
988 * src/ls.c (get_funky_string): Use '\a', rather than 7, for
989 portability to EBCDIC hosts.
991 2005-03-20 Jim Meyering <jim@meyering.net>
993 * src/pr.c (init_header): Add missing `%' in new format string.
994 (init_header): Use zero-filled `.%09d' format, not space-filled `.%9d'.
996 2005-03-19 Jim Meyering <jim@meyering.net>
998 * src/Makefile.am (pr_LDADD): Now that pr uses gettime, add
999 $(LIB_CLOCK_GETTIME) to get the required -lrt on newer Linux systems.
1001 2005-03-18 Paul Eggert <eggert@cs.ucla.edu>
1003 * NEWS: pr -D "FORMAT" now accepts the same formats that
1004 date +"FORMAT" does.
1005 * src/pr.c: Include strftime.h, timespec.h.
1006 (init_header): Obtain and format nanosecond part of time stamp.
1008 * NEWS: nohup now ignores the umask when creating nohup.out.
1009 nohup now closes stderr if it is a terminal and stdout is closed.
1010 * src/nohup.c (main): Likewise. Be a little more paranoid about
1011 return values; e.g., check for any negative return from open.
1012 Assume free (NULL) works.
1013 Close file descriptor leak when redirecting standard output to a file.
1015 2005-03-17 Jim Meyering <jim@meyering.net>
1017 * src/cut.c (set_fields): Use DECIMAL_DIGIT_ACCUMULATE macro,
1018 in place of functionally-equivalent code.
1019 * src/expand.c (parse_tab_stops, main): Likewise.
1020 * src/split.c (main): Likewise.
1021 * src/unexpand.c (parse_tab_stops, main): Likewise.
1022 * src/uniq.c (main): Likewise.
1023 * src/od.c: Use VERIFY macro in place of an equivalent open-coded
1025 * src/system.h (VERIFY, VERIFY_EXPR, DECIMAL_DIGIT_ACCUMULATE):
1028 Before, this command would make uniq skip 11 fields and print
1029 only the first line:
1030 $ _POSIX2_VERSION=1 ./uniq -f1 -1 <(seq --format='1 %g' 2)
1033 * src/uniq.c (main): Interpret `uniq -f1 -1' like `uniq -f1',
1034 not like `uniq -f11'.
1036 2005-03-15 Jim Meyering <jim@meyering.net>
1038 Both `pr -0' and e.g., `pr -03' would evoke `column count too large'.
1039 `pr -0' should give a better diagnostic and `pr -03' should be
1040 equivalent to `pr -3'.
1041 * src/pr.c (parse_column_count): Change return type to void.
1042 Call error (EXIT_FAILURE, ... for an invalid string.
1043 (main): Allocate space for column_count_string using malloc.
1044 Accumulate all old-style column-count digits before converting.
1045 When the number of columns is specified via both old-style,
1046 (e.g., -3), and a long option (--columns=5), ensure that only
1047 the last one specified takes effect.
1048 * tests/pr/Test.pm: Add tests for the above.
1050 2005-03-15 Corinna Vinschen <corinna@vinschen.de> (tiny change)
1052 * src/copy.c (copy_reg): Copy regular files in binary mode.
1054 2005-03-14 Paul Eggert <eggert@cs.ucla.edu>
1056 * NEWS: Restate why ls limits time stamp lengths.
1058 2005-03-12 Jim Meyering <jim@meyering.net>
1060 Add a little infrastructure to help prevent future bugs like the
1062 * src/stat.c (xstrcat): New function.
1063 (print_statfs, print_stat): Add buf_len parameter and convert all
1064 uses of strcat to xstrcat. Update callers.
1065 (print_it): Call print_func with buf_len parameter.
1067 Invoking stat -c FMT with a lone format directive of %s, %f, %h, %s,
1068 could cause a buffer overrun error.
1069 * src/stat.c (print_it): Allocate 2 more bytes, to accommodate our
1070 conversion of the stat %s format string to the longer printf %llu one.
1071 Patch from Guochun Shi.
1073 2005-03-11 Paul Eggert <eggert@cs.ucla.edu>
1075 * src/ls.c (TIME_STAMP_LEN_MAXIMUM): New constant.
1076 (long_time_expected_width, print_long_format): Use it, to avoid
1077 some possible denial-of-service attacks.
1078 * NEWS: Document this.
1080 2005-03-11 Jim Meyering <jim@meyering.net>
1082 Prompt once again for `mv -i A B' when A and B are hard links
1083 to the same file. This fixes a bug introduced by my 2003-04-04
1084 (coreutils-5.0.1) change. Reported by Thomas Wolff via Eric Blake.
1085 * src/copy.c (abandon_move): New function, factored out of
1086 copy_internal, now that this code is being used from two places.
1087 (copy_internal): Perform the same interactive-related test for
1088 whether it's alright to proceed and (usually) overwrite the
1090 * tests/mv/i-4: Add tests for the above.
1092 Don't segfault for a very long date format string, e.g.,
1093 ls -ld --time-style=+%99999999H .
1094 * src/ls.c (long_time_expected_width): Use x2nrealloc, not alloca,
1095 so format string abuse cannot provoke stack overflow.
1096 (print_long_format): Likewise.
1098 Don't segfault for a long header date string, e.g.,
1099 echo a|pr -D +%9999999A
1100 * src/pr.c (init_header): Use x2nrealloc, rather than alloca.
1101 Don't bother with fixed-sized initial buffer; always use x*alloc.
1103 * src/pr.c (init_header): Use slightly clearer INT_BUFSIZE_BOUND
1104 in place of equivalent INT_STRLEN_BOUND + 1.
1105 * src/expr.c (tostring, printv): Likewise.
1107 2005-03-09 Paul Eggert <eggert@cs.ucla.edu>
1109 * src/system.h: Include intprops.h.
1110 (TYPE_SIGNED, TYPE_MINIMUM, TYPE_MAXIMUM, INT_STRLEN_BOUND): Remove;
1111 they are now defined in intprops.h.
1113 2005-03-09 Jim Meyering <jim@meyering.net>
1115 * TODO: Remove entry about named pipes. It was fixed in 5.3.0.
1117 2005-03-08 Paul Eggert <eggert@cs.ucla.edu>
1119 * src/date.c (usage): Redo to match recent documentation changes.
1120 Don't bother documenting which usages are GNU extensions; the list
1121 wasn't correct, and is better left to the printed manual anyway.
1123 2005-03-06 Jim Meyering <jim@meyering.net>
1125 Factor out column-count processing.
1126 * src/pr.c: Include "inttostr.h".
1127 (parse_column_count): New function.
1128 (main): Use the new function for both old-style, -9, and long,
1129 --columns=-9, options.
1131 * src/cksum.c: Remove `register' keyword.
1132 * src/cut.c: Likewise.
1133 * src/dd.c: Likewise.
1134 * src/env.c: Likewise.
1135 * src/factor.c: Likewise.
1136 * src/fmt.c: Likewise.
1137 * src/fold.c: Likewise.
1138 * src/id.c: Likewise.
1139 * src/logname.c: Likewise.
1140 * src/ls.c: Likewise.
1141 * src/pr.c: Likewise.
1142 * src/printf.c: Likewise.
1143 * src/shred.c: Likewise.
1144 * src/sort.c: Likewise.
1145 * src/sum.c: Likewise.
1146 * src/test.c: Likewise.
1147 * src/tsort.c: Likewise.
1148 * src/uniq.c: Likewise.
1149 * src/wc.c: Likewise.
1150 * src/whoami.c: Likewise.
1152 2005-03-01 Paul Eggert <eggert@cs.ucla.edu>
1154 * src/Makefile.am (nanosec_libs): Remove $(LIB_XANOSLEEP); no
1157 2005-03-01 Jim Meyering <jim@meyering.net>
1159 * src/copy.c (copy_internal): Change test of source type from
1160 !S_ISREG to S_ISLNK. Reported by Paul Eggert in
1161 http://lists.gnu.org/archive/html/bug-coreutils/2004-10/msg00050.html.
1163 2005-02-28 Jim Meyering <jim@meyering.net>
1165 * NEWS: Mention that xnanosleep fixes sleep failure on linux-2.6.8.1.
1167 2005-02-21 Paul Eggert <eggert@cs.ucla.edu>
1169 * src/Makefile.am (dd_LDADD, shred_LDADD): Add $(LIB_GETHRXTIME).
1170 (nanosec_libs): Add $(LIB_XNANOSLEEP). Needed for newer GNU/Linux
1171 hosts with clock_gettime.
1173 2005-02-20 Paul Eggert <eggert@cs.ucla.edu>
1175 * NEWS: Describe user-visible change to dd.
1176 * src/Makefile.am (dd_LDADD, shred_LDADD, nanosec_libs):
1177 Remove $(LIB_CLOCK_GETTIME). These functions now use
1179 * src/dd.c: Include gethrxtime.h, xtime.h.
1180 (start_time): Now of type xtime_t, not struct timespec.
1181 (print_stats, main): Use gethrxtime rather than gettime.
1182 * src/ls.c (time): Remove obsolete decl.
1183 (get_current_time): gettimeofday always returns 0, so don't
1185 * src/shred.c: Include gethrxtime.h.
1186 (isaac_seed): Use gethrxtime rather than a mishmash.
1187 * src/touch.c (time): Remove obsolete decl.
1189 * tests/misc/split-fail: Don't assume that the current host
1190 supports integers wider than 32 bits. Fix comment typo.
1191 * tests/od/x8: Likewise.
1193 * src/chown-core.c (enum RCH_status): Remove trailing comma,
1194 as it's not valid in standard C89.
1196 2005-02-15 Jim Meyering <jim@meyering.net>
1198 * src/stat.c (human_fstype): Add case/definition for S_MAGIC_XFS
1199 so that file systems of type `xfs' are recognized as such.
1200 * src/fs.h: Regenerate.
1201 Reported by Bernd Eckenfels.
1202 * src/stat.c (human_fstype): Likewise for S_MAGIC_JFS/jfs.
1203 * src/fs.h: Regenerate.
1204 Reported by Andreas Schwab.
1206 * src/nice.c (NZERO) [NZERO == 0]: Undefine and define to 20,
1207 to work around the invalid definition from Darwin 7.7.0.
1208 Test failure reported by Sébastien Maret.
1210 2005-02-14 Paul Eggert <eggert@cs.ucla.edu>
1212 * src/sort.c (mergefps): Use binary search rather than linear one
1213 when comparing new line to lines already in main memory.
1214 Idea suggested by James Lemley.
1216 2005-02-09 Jim Meyering <jim@meyering.net>
1218 * src/copy.c (valid_options): Add an assertion that
1219 not both hard_link and symbolic_link are set.
1221 2005-02-08 Paul Eggert <eggert@cs.ucla.edu>
1223 * NEWS: Document stat -f -c %S, plus changes to default formats.
1224 * doc/coreutils.texi (stat invocation): Normalize terminology,
1225 capitalization, and sort order to match --help output. Mention %c
1226 for file systems. Add new -f -c format %S, and document %s versus %S;
1227 problem reported by Jeroen van Wolffelaar.
1228 * src/stat.c (usage): Likewise.
1229 (STATFS_FRSIZE): New macro.
1230 (print_statfs): Use it, for stat -f -c %S.
1231 (do_statfs): Change default formats to output %S.
1233 2005-02-03 Paul Eggert <eggert@cs.ucla.edu>
1235 * src/system.h: Include "memrchr.h".
1236 (memrchr) [!HAVE_DECL_MEMRCHR]: Remove decl.
1238 2005-02-02 Jim Meyering <jim@meyering.net>
1240 * tests/du/8gb: Also adjust the test (s/64/128/) to detect
1241 systems that don't support sparse files.
1242 Check for $2 -ge 128, rather than $2 = 128, in case
1243 there is a file system type that doesn't support sparse files,
1244 yet for which metadata takes up additional space.
1245 Both reported by Andreas Schwab.
1247 2005-02-01 Eric Blake <ebb9@byu.net> (tiny change)
1249 * tests/du/8gb: Create a larger test file, so we properly
1250 detect that sparse files can be created on NTFS under cygwin.
1252 2005-01-30 Jim Meyering <jim@meyering.net>
1254 * src/head.c (elide_tail_bytes_pipe): Correct wording in diagnostic.
1256 * src/stty.c: Remove unnecessary parentheses in all #if directives.
1258 2005-01-29 Eric Blake <ebb9@byu.net> (tiny change)
1260 * .cvsignore: Ignore config.cache and config.status.lineno.
1261 * src/stty.c [VSWTCH]: Some systems, like Cygwin, use VSWTC
1262 instead of VSWTCH, for use with CSWTCH.
1264 2005-01-29 Eric Blake <ebb9@byu.net> (tiny change)
1266 * tests/Makefile.am (.PHONY): Add check-root and root-hint.
1267 * tests/rwx-to-mode: Ignore ACL designation.
1268 * tests/setgid-check: Likewise.
1269 * tests/chown/separator: Quote user and group names.
1271 2005-01-24 Jim Meyering <jim@meyering.net>
1273 * src/cp.c (usage): Merge the descriptions of --no-dereference and -P.
1274 Suggestion from Johan Boule.
1276 2005-01-17 Eric Blake <ebb9@byu.net> (tiny change)
1278 * src/Makefile.am (all_programs.list): Strip $(EXEEXT) and remove
1280 * man/Makefile.am (all_programs): Revert previous patch; updated
1281 all_programs.list fixes this.
1282 (.x.1): No need to add $(EXEEXT).
1284 2005-01-03 Corinna Vinschen <corinna@vinschen.de> (tiny change)
1286 * src/system.h: Use S_BLKSIZE value for ST_NBLOCKSIZE where
1289 2005-01-22 Jim Meyering <jim@meyering.net>
1291 * Makefile.maint (v_etc_file): The version string has moved to
1292 version-etc-fsf.c, search that new file, not version-etc.c.
1294 2005-01-17 Paul Eggert <eggert@cs.ucla.edu>
1296 * tests/group-names: Use numeric group ids, not symbolic group names,
1297 since the latter can have shell metacharacters in them (e.g., spaces).
1298 Problem reported by Eric Blake.
1299 * tests/chgrp/basic: Assume groups are numeric, not symbolic.
1300 * tests/chgrp/deref: Likewise.
1301 * tests/chgrp/posix-H: Likewise.
1302 * tests/chgrp/recurse: Likewise.
1304 2005-01-15 Jim Meyering <jim@meyering.net>
1306 * src/shred.c (isaac_seed) [HAVE_GETHRTIME]: #if-0 this block,
1307 because just calling gethrtime evokes an `illegal instruction'
1308 failure when compiled with Sun's c89 on Solaris 8 and 9.
1309 Reported by Nelson Beebe.
1311 * src/shred.c (isaac_seed) [HAVE_GETHRTIME]: Don't call ISAAC_SEED
1312 twice with the same value of `t'.
1313 Replace nested #if-#else blocks with #if-#elif-#elif chain.
1315 2005-01-14 Jim Meyering <jim@meyering.net>
1317 The test, tests/tail/f-1, failed on powerpc-apple-darwin7.7.0.
1318 * src/tail.c (IS_TAILABLE_FILE_TYPE): Adjust definition also to include
1319 sockets, since that's what you get when reading from a command-line-
1320 supplied pipe on Darwin 7.7.
1321 (IS_PIPE_LIKE_FILE_TYPE): Define.
1322 (main): Use new IS_PIPE_LIKE_FILE_TYPE rather than simply S_ISFIFO.
1323 Reported by Nelson Beebe.
1324 This same change is also required on NetBSD/sparc-1.5.
1325 Reported by Adrian Bunk.
1327 * src/expr.c (toarith): Rewrite to detect/diagnose integer overflow,
1328 rather than suffering silently.
1329 Before, expr would silently overflow and wrap around:
1330 $ expr 9223372036854775808 = 0 # $(echo 2^63|bc)
1332 Now it detects the problem and exits nonzero:
1333 $ ./expr $(echo 2^63|bc) = 0
1334 ./expr: 9223372036854775808: integer is too large
1336 * tests/chown/separator (id_gn): Exit 77, not 1, for a test-framework
1337 failure, so that doesn't cause `make check' to stop. Nelson Beebe
1338 reported that this test would fail with the diagnostic,
1339 `cannot find name for group ID 10', on one of his systems.
1341 2005-01-13 Jim Meyering <jim@meyering.net>
1343 * src/test.c (is_int): Don't overflow when evaluating integer
1344 constants. Before, ./test $(echo 2^64|bc) -eq 0 && echo FAIL
1347 * tests/Fetish.pm (run_tests): Add code (if-0'd out) to detect
1348 names of temporary files that would clash on 8.3 file systems.
1349 * tests/mk-script (validate): Likewise.
1351 2005-01-12 Jim Meyering <jim@meyering.net>
1353 * tests/dd/skip-seek: Shorten test names to accommodate 8.3 systems.
1355 * tests/tr/Test.pm (repeat-xC): Change test name from
1356 `repeat-Compl', to avoid 8.3 conflict with `repeat-compl'.
1357 Reported by Eric Blake.
1358 (repeat-000): Rename to `repeat-zeros' for the same reason.
1360 2005-01-11 Jim Meyering <jim@meyering.net>
1362 * configure.ac: Update version to 5.3.1.
1364 2005-01-11 Eric Blake <ebb9@byu.net>
1366 * src/Makefile.am (check-README, check-AUTHORS): Account for $(EXEEXT).
1367 * man/Makefile.am (all_programs): Account for $(EXEEXT).
1369 2005-01-11 Jim Meyering <jim@meyering.net>
1371 * src/unexpand.c (add_tab_stop): Properly diagnose a tabstop list
1372 with decreasing values.
1374 * src/expand.c (main): Likewise.
1375 * src/unexpand.c (main): Check for overflow in tabstop values
1376 specified via the obsolete form. E.g., now this command fails:
1377 _POSIX2_VERSION=1 ./unexpand -$(echo '2^64+1'|bc)
1378 Before it would act like `_POSIX2_VERSION=1 ./unexpand -1'.
1379 * tests/unexpand/basic-1 (obs-ovflo): New test for this.
1381 2005-01-10 Paul Eggert <eggert@cs.ucla.edu>
1383 Respond to POSIX interpretations about pathchk -p dated 2005-01-06.
1384 * NEWS: Document the changes.
1385 * doc/coreutils.texi (pathchk invocation): Likewise.
1386 * src/pathchk.c (PORTABILITY_OPTION): New constant.
1387 (longopts, usage, main, validate_file_name):
1388 Add support for new -P option.
1389 Reject empty file names (unless -p is not specified and the
1390 current system allows empty file names).
1391 Change --portability so that is now equivalent to -p -P.
1392 Don't test whether file name is too long, if it is known to exist.
1393 (no_leading_hyphen): New function.
1394 * tests/misc/pathchk1: Add tests for empty file names and
1397 2005-01-08 Jim Meyering <jim@meyering.net>
1401 `pr --columns=N' was not equivalent to `pr -N' when also using
1404 * src/pr.c (main): Set `explicit_columns' for --columns=N,
1405 not just for -N. This bug has existed since the introduction
1406 of the --columns=N option on 1998-08-15.
1407 * NEWS: Document this.
1408 * tests/pr/Test.pm (test_vector): For each -N test, automatically
1409 create a new test vector using --columns=N.
1411 2005-01-07 Paul Eggert <eggert@twinsun.com>
1413 * src/pr.c (main): Check for column count overflow with
1414 usages like "pr -2147483648".
1416 2005-01-07 Jim Meyering <jim@meyering.net>
1418 * src/pr.c (init_fps): Use xnmalloc, rather than xmalloc.
1420 2005-01-06 Jim Meyering <jim@meyering.net>
1422 * README: List the precise HP-UX version numbers that are affected.
1423 Suggestion from Bob Proulx.
1425 * Makefile.maint (sc_changelog): Specify find's `-maxdepth 2'
1426 predicate before `-name ChangeLog' to avoid a harmless warning
1429 2005-01-05 Jim Meyering <jim@meyering.net>
1431 * tests/help-version: Punt on the uptime test, since it fails when
1432 it can't get boot time, and I don't want that to stop `make check'.
1434 * src/du.c (process_file): Evaluate exclusion rules against
1435 the entire file name, not just the last component.
1436 Reported by Robert Lindgren.
1437 * tests/du/exclude: Test for this.
1438 * NEWS: Document this.
1440 Ensure that tests/Makefile.am's check-root actions stay up to date.
1441 * Makefile.maint (sc_root_tests): New rule.
1442 (syntax-check-rules): Add it to the list.
1444 2005-01-04 Jim Meyering <jim@meyering.net>
1446 * man/shred.x: Change one-line summary to reflect that shred does
1447 not remove files by default. Suggestion from Helen Faulkner in
1448 http://bugs.debian.org/288552
1450 * README: Request VERBOSE=yes output when reporting test failures.
1451 Other minor changes.
1453 * tests/Makefile.am (check-root): Update.
1455 2005-01-03 Paul Eggert <eggert@cs.ucla.edu>
1457 * src/system.h: Undo previous change; we now use Autoconf.
1459 2005-01-03 Jim Meyering <jim@meyering.net>
1461 * tests/stty/row-col-1: Don't set rows or columns to zero, to avoid
1462 a bug in the TIOCGWINSZ ioctl on at least Solaris5.9 systems. Setting
1463 either (or both) to zero would succeed, but subsequent `stty size'
1464 would say `no size information for this device' due to the ioctl
1465 failing with EINVAL.
1467 * src/system.h: If PRIdMAX, PRIoMAX, PRIuMAX, and PRIxMAX are
1468 not all defined and either ULONG_MAX or ULLONG_MAX is not defined,
1469 then fail at compile-time rather than let tools like od produce
1470 invalid results at run time.
1472 2004-12-21 Jim Meyering <jim@meyering.net>
1474 * src/csplit.c (usage): Say the default names are `xx00, xx01, ...',
1475 not `xx01, xx02, ...'.
1476 Reported by Matt Kraai in http://bugs.debian.org/286605
1478 * tests/misc/split-fail: Avoid spurious failure on x86 Solaris5.9
1481 2004-12-20 Paul Eggert <eggert@cs.ucla.edu>
1483 * src/split.c (usage): Mention default size. Suggested by Dan Jacobson.
1485 2004-12-19 Paul Eggert <eggert@cs.ucla.edu>
1487 * NEWS: Mention that one should eval "`dircolors`" rather than
1490 2004-12-17 Jim Meyering <jim@meyering.net>
1492 * tests/mv/hard-link-1: Rearrange to use newer trap-handling code,
1493 so temporary directories aren't left behind upon e.g., interrupt.
1495 2004-12-16 Paul Eggert <eggert@cs.ucla.edu>
1497 * src/ls.c (print_dir): Use "%s: not listing already-listed
1498 directory", not "not listing already-listed directory: %s", to
1499 format already-listed directories, to be consistent with other
1500 diagnostics involving file names and colons.
1502 2004-12-15 Jim Meyering <jim@meyering.net>
1504 * src/Makefile.am (__LDADD): Define, so that building `[' on
1505 Solaris still uses the -lgen library that it requires in order
1506 to get a definition of eaccess.
1508 2004-12-14 Jim Meyering <jim@meyering.net>
1510 tac would exit immediately upon I/O or temp-file creation failure.
1511 Now it continues on, processing any remaining command line arguments.
1513 * src/tac.c: Include quotearg.h.
1514 Use quotearg_colon in most diagnostics.
1515 (copy_to_temp): Rewrite not to exit upon I/O or temp-file-creation
1516 failure. Before, this command (with /full/tmp being a full partition)
1517 TMPDIR=/full/tmp ./tac /proc/modules tac.c
1518 would exit immediately upon the write error while trying to copy
1519 non-seekable /proc/modules to the full partition. Now it still
1520 reports the failure but continues on with the remaining file.
1521 (tac_nonseekable): Return false also if copy_to_temp fails.
1522 [DONT_UNLINK_WHILE_OPEN]: Add a FIXME comment explaining that
1523 using atexit like this is wrong.
1524 * NEWS: Document this.
1525 * tests/misc/tac-continue: New test for this.
1526 * tests/misc/Makefile.am (TESTS): Add tac-continue.
1528 * tests/chown/basic: Add a few more tests.
1530 2004-12-13 Paul Eggert <eggert@cs.ucla.edu>
1532 * src/ls.c (gobble_file): Change arg name to be command_line_arg
1533 rather than explicit_arg, for consistency with copy.c.
1534 (extract_dirs_from_files): Remove ignore_dot_and_dot_dot arg, since
1535 it is deducible from dirname arg. All callers changed.
1536 (extract_dirs_from_files, print_dir, queue_directory):
1537 Add command_line_arg arg. All callers changed.
1538 (struct pending): Add command_line_arg member.
1539 (main): Use NULL rather than 0 when appropriate.
1540 (set_exit_status, file_failure): New functions.
1541 (queue_directory): Store command_line_arg into new structure.
1542 (print_dir, gobble_file, get_link_name):
1543 Use file_failure to report problems in accessing files,
1544 so that the exit status is set consistently.
1545 (print_dir): Simplify readdir failure code yet again.
1546 If closedir fails, report "closing directory" rather than "reading
1548 (xstrcoll): Use set_exit_status to set status on failure.
1549 * tests/ls-2/tests (no-a-isdir-b): This now exits with status 2,
1552 2004-12-11 Jim Meyering <jim@meyering.net>
1554 Avoid a race condition vulnerability in chown, when used with
1555 --from=O:G and without the (-h) --no-dereference option.
1556 * src/chown-core.c (restricted_chown): New function.
1557 (change_file_owner): Call it.
1558 Reported by Ulrich Drepper.
1559 * NEWS: Mention this.
1561 2004-12-09 Paul Eggert <eggert@cs.ucla.edu>
1563 * ls now exits with status 1 on minor problems, 2 if serious trouble.
1564 * NEWS: Document this.
1565 * src/ls.c (LS_MINOR_PROBLEM, LS_FAILURE): New constants.
1566 All uses of EXIT_FAILURE replaced with LS_FAILURE, unless
1568 (main): Initialize exit failure to LS_FAILURE.
1569 (print_dir, gobble_file, get_link_name, xstrcoll):
1570 Set exit status to LS_MINOR_PROBLEM if the failure is minor.
1571 (print_dir): Do not give up on entire directory merely because readdir
1573 (usage): Explain exit status.
1574 * tests/help-version: ls and variants now exit with status 2
1577 2004-12-08 Paul Eggert <eggert@cs.ucla.edu>
1579 * NEWS: Document new UTC+HH:MM date syntax, and put date changes
1582 2004-12-07 Paul Eggert <eggert@cs.ucla.edu>
1584 * src/factor.c (factor): Don't list 1 as a factor of 1.
1585 Problem reported by Thomas Folz-Donahue.
1587 2004-12-06 Jim Meyering <jim@meyering.net>
1589 * tests/du/files0-from: Sanitize environment.
1590 Otherwise, e.g., BLOCKSIZE=k would cause a failure, and that
1591 setting is the default (exported from /etc/profile) on at least one
1593 * tests/du/no-deref: Likewise.
1594 * tests/cp/symlink-slash: Likewise.
1595 * tests/ls/symlink-slash: Likewise
1597 2004-12-05 Jim Meyering <jim@meyering.net>
1599 * tests/tail/Test.pm (err-6) ["tail -c"]: Avoid test failure when
1600 _POSIX2_VERSION=199209 is in the environment, or when building on
1603 2004-12-04 Jim Meyering <jim@meyering.net>
1605 * NEWS: Mention cut's new --complement option.
1607 2004-10-01 Paolo Bonzini <bonzini@gnu.org>
1609 * cut.c (complement, COMPLEMENT_OPTION): New.
1610 (longopts): Add --complement.
1611 (usage): Say not that -b, -c, and -f `print' fields,
1612 but rather that they `select' fields for printing.
1613 Describe the new --complement option.
1614 (mark_range_start): Extracted from set_fields.
1615 (print_kth): Support --complement.
1616 (compare_ranges): New function.
1617 (set_fields): Rewrite the part that populates range_start_ht,
1618 merging it with the part that populates printable_field.
1619 (main): Handle --complement.
1621 2004-12-03 Paul Eggert <eggert@cs.ucla.edu>
1623 * src/tail.c (tail_file): Set errnum to -1 if the initial "tail"
1624 failed. This works around an assertion failure reported by
1626 http://lists.gnu.org/archive/html/bug-coreutils/2004-12/msg00012.html
1628 2004-12-02 Jim Meyering <jim@meyering.net>
1630 With using --color and with LS_COLORS saying not to color
1631 executables, don't stat every file.
1632 * src/ls.c (is_colored): New function.
1633 (gobble_file): Use it.
1634 (main): Use it here, in place of too-strict tests against NULL:
1635 if either ORPHAN or MISSING was set to 0 from LS_COLORS, the
1636 old test would fail.
1638 2004-12-01 Paul Eggert <eggert@cs.ucla.edu>
1640 * src/comm.c (compare_files): Assume setlocale exists.
1641 * src/join.c (keycmp): Likewise.
1642 * src/seq.c (decimal_point): Treat like sort. Now char.
1644 (main): Assume localeconv exists. Use same code as sort.
1645 * src/sort.c (C_DECIMAL_POINT): Remove. Use changed to '.'.
1646 Assume setlocale exists.
1647 (thousands_sep): Renamed from th_sep.
1648 (IS_THOUSANDS_SEP): Remove. All uses replaced by comparisons.
1649 (NONZERO): Parenthesize use of arg.
1650 (numcompare): Avoid duplicate loads. Use ISDIGIT as boolean, for
1651 consistency. Avoid unnecessary negation by reversing
1653 (main): Rewrite localeconv call to match seq.c.
1654 * src/system.h: Assume locale.h exists.
1655 (HAVE_SETLOCALE): Remove.
1656 * src/uniq.c (different): Assume setlocale exists.
1658 * src/ls.c (sort_files): Minor cleanup. Remove an unnecessary
1659 'volatile' on a local variable. Rewrite to avoid unnecessary
1660 double-assignment to 'func' in the usual case where strcoll does
1663 2004-11-30 Paul Eggert <eggert@cs.ucla.edu>
1665 * src/pinky.c (gethostname): Remove decl.
1666 (scan_entries): Use IS_USER_PROCESS instead of by-hand code.
1667 * src/uptime.c (print_uptime): Use IS_USER_PROCESS and
1668 UT_TYPE_BOOT_TIME instead of by-hand code.
1669 * src/users.c (list_entries_users): Use IS_USER_PROCESS
1670 instead of by-hand code.
1671 * src/who.c (USER_PROCESS, RUN_LVL, INIT_PROCESS, LOGIN_PROCESS,
1672 DEAD_PROCESS, BOOT_TIME, NEW_TIME, UT_TYPE_UNDEF, UT_TYPE): Remove.
1673 (IS_USER_PROCESS): Move to ../lib/readutmp.h.
1674 (UT_TYPE_RUN_LVL, UT_TYPE_INIT_PROCESS, UT_TYPE_LOGIN_PROCESS,
1675 UT_TYPE_DEAD_PROCESS, UT_TYPE_NEW_TIME): New macros.
1676 (gethostname): Remove decl.
1677 (list_entries_who, scan_entries): Use the new macros defined above,
1678 for consistency with pinky, uptime, and users.
1680 2004-11-25 Paul Eggert <eggert@cs.ucla.edu>
1682 Fix problem reported by Scott S. Tinsley for HP-UX 11.11 using
1683 HP's ANSI C compiler. Declaring int functions causes warnings on
1684 some modern systems and shouldn't be needed to compile on ancient
1686 * src/copy.h (stat, lstat, rename): Remove decls.
1687 * src/install.c (stat): Remove decl.
1688 * src/ln.c (link, symlink): Remove decls.
1690 2004-11-25 Jim Meyering <jim@meyering.net>
1692 * man/help2man: Import help2man-1.35.1.
1693 * man/Makefile.am (.x.1): Remove now-unnecessary use of
1694 locally-added --program-name=NAME option. Now, help2man gets
1695 the name from the [NAME] section (i.e. from our .x file).
1696 * man/install.x: Use `install', not `ginstall' in the one-line
1697 description. Reported by Brendan O'Dea.
1698 * man/sha1sum.x: Use `sha1sum', not `shasum'.
1700 2004-11-24 Jim Meyering <jim@meyering.net>
1702 Since the changes of 2004-05-22, the u.saved_cwd member at
1703 the bottom of the active-directory stack was no longer
1704 strictly necessary. This change removes that member and uses
1705 the newer cwd_state parameter for the final restore_cwd.
1707 * src/remove.c (struct AD_ent) [u]: Remove now-unnecessary union.
1708 [dev_ino]: Rename from `a'.
1709 (AD_pop_and_chdir): Add a parameter to play the role of just-removed
1710 bottom-of-stack cwd-state member.
1711 (AD_pop_and_chdir): No longer return boolean. Adjust caller.
1712 (AD_push_initial): Remove CWD parameter. Adjust caller.
1714 2004-11-23 Paul Eggert <eggert@cs.ucla.edu>
1716 Minor performance improvements and cleanups for "touch".
1717 * src/touch.c (posix_date): Remove; not needed as a static var.
1719 (touch): Use new futimens function to operate more efficiently
1720 in some cases. Don't stat/fstat existing file when
1721 (!amtime_now && change_times == (CH_ATIME | CH_MTIME)); the
1722 old time stamps aren't needed in that case.
1723 (main): change_times is int, not bool. Simplify test for
1726 2004-11-20 Paul Eggert <eggert@cs.ucla.edu>
1728 * src/install.c (usage): Avoid usage that runs afoul of Docbook
1729 translation. Problem reported by Eric S. Raymond.
1731 Restore dd's noctty flag, reverting the change of 2004-04-08.
1732 POSIX does not allow "dd" to use O_NOCTTY by default.
1733 * NEWS: Add noctty flag to dd.
1734 * doc/coreutils.texi (dd invocation): Likewise.
1735 * src/dd.c (flags, usage, main): Likewise.
1737 2004-11-19 Alfred M. Szmidt <ams@gnu.org>
1739 * src/ls.c (usage): Clarified description of --no-group (-G),
1740 --human-readable (-h), --inode (-i), --size (-s), --time,
1743 2004-11-19 Jim Meyering <jim@meyering.net>
1745 * src/ls.c (usage): Clarify description of --author.
1746 Tweak indentation so that help2man creates better nroff.
1747 Reported by Dan Jacobson.
1749 * src/uniq.c (check_file): Don't check stdout for errors here.
1751 * src/pwd.c (find_dir_entry): Update comment to match reality.
1753 2004-11-18 Jim Meyering <jim@meyering.net>
1755 * src/pwd.c (robust_getcwd): Correct the comment: this function
1756 constructs the directory name. The caller prints it.
1758 2004-11-16 Paul Eggert <eggert@cs.ucla.edu>
1760 * src/stat.c (STATFS): New macro, for portability to Solaris 9.
1761 (do_statfs): Use it.
1763 * src/basename.c, src/chroot.c, src/cksum.c, src/dd.c, src/dirname.c,
1764 src/factor.c, src/hostid.c, src/hostname.c, src/link.c, src/logname.c,
1765 src/nohup.c, src/printenv.c, src/pwd.c, src/setuidgid.c, src/sleep.c,
1766 src/sync.c, src/tsort.c, src/unlink.c, src/uptime.c, src/users.c,
1767 src/whoami.c, src/yes.c (main): Use getopt_long rather than getopt.
1768 * src/readlink.c (main): argv is not const.
1770 * src/cut.c (usage): Improve documentation along the lines suggested
1772 * src/echo.c (usage): Likewise.
1773 * src/expr.c (usage): Likewise.
1775 * src/dircolors.hin: Add putty, screen-bce.
1777 * src/pinky.c (print_entry): Fix memory leak.
1778 * src/who.c (print_user): Likewise.
1780 2004-11-15 Paul Eggert <eggert@cs.ucla.edu>
1782 * NEWS: New dd operand "status=noxfer".
1783 * src/dd.c (C_ASCII, C_EBCDIC, C_IBM, C_BLOCK, C_UNBLOCK,
1784 C_LCASE, C_UCASE, C_SWAB, C_NOERROR, C_NOTRUNC, C_SYNC, C_TWOBUFS,
1785 C_NOCREAT, C_EXCL, C_FDATASYNC, C_FSYNC): Now constants, not
1787 (STATUS_NOXFER, statuses): New constants.
1788 (usage, print_stats, scanargs): Add support for status=noxfer.
1789 (usage): Update status output to match new behavior.
1790 (print_stats): Always output complete byte count.
1791 Put space between numbers and units, as SI requires.
1792 Use ngettext so that i18n can use plurals for "byte" and "second".
1793 Don't multiply by 1e-9 (inexact); divide by 1e9 (which is exact).
1794 (iflag_error_msgid, oflag_error_msgid): Remove; replace uses by
1796 * tests/dd/skip-seek (@Tests): Use status=noxfer to avoid
1797 problems with regression testing.
1799 2004-11-14 Paul Eggert <eggert@cs.ucla.edu>
1801 * NEWS: dd now outputs total bytes, seconds, and bytes per second.
1802 * src/Makefile.am (dd_LDADD): Add $(LIB_CLOCK_GETTIME).
1803 * src/dd.c: Include "human.h".
1804 (w_bytes, start_time): New vars.
1805 (usage): Document new I/O statistics output
1806 (print_stats): Output new I/O statistics.
1807 (cleanup): Do statistics after closing stdin and stdout, so that
1808 the times are more accurate.
1809 (write_output, dd_copy): Count output bytes.
1810 (main): Get initial value of clock.
1812 2004-11-14 Jim Meyering <jim@meyering.net>
1814 Backslash-escape `-'s in email addresses, so that they are
1815 rendered properly in UTF-locales.
1816 * man/help2man (escape_hyphens): New function.
1817 (main): Call it on email addresses.
1819 * src/sort.c (zaptemp): Mark new diagnostic for translation.
1821 * tests/misc/close-stdout: New file. Test today's closeout.c change.
1822 * tests/misc/Makefile.am (TESTS): Add close-stdout.
1824 2004-11-13 Jim Meyering <jim@meyering.net>
1826 * src/test.c (usage): Put the description of `[-n] STRING'
1827 on two lines, one for `-n STRING' and one for `STRING' so that
1828 help2man properly escapes the `-'. Otherwise, the hyphen is
1829 rendered inappropriately in UTF-8 locales.
1830 Reported by Uwe Zeisberger in http://bugs.debian.org/281069.
1832 2004-11-12 Paul Eggert <eggert@cs.ucla.edu>
1834 * NEWS: Document the following changes.
1836 * src/sort.c: Avoid O(N**2) behavior when there are many temporary
1838 (temptail): New variable, so that we can easily append to list.
1839 (create_temp_file): Create new files at end of list, so that
1840 searching the list has O(N*NMERGE) behavior instead of O(N**2).
1841 (zaptemp): Update temptail if needed.
1842 (mergefps, merge): Accept new arg that counts temp files, and keep it
1843 up to date as we create and remove temporaries. This is for
1844 efficiency, so that we don't call zaptemp so often.
1845 All callers changed.
1846 (sort): Don't create array in reverse order, since the list of
1847 temporaries is now in the correct order.
1849 (zaptemp): Protect against race condition: if 'sort' is
1850 interrupted in the middle of zaptemp, it might unlink the
1851 temporary file twice, and the second time this happens the file
1852 might already have been created by some other process.
1854 (zaptemp): Warn if a temporary file is not removed.
1856 (create_temp_file): Use offsetof for clarity.
1857 (die): Move it up earlier, to clean up the code a bit.
1859 * src/pr.c (strtoumax): Declare if not declared.
1860 (skip_to_page, first_page_number, last_page_number, page_number,
1861 first_last_page, print_header):
1862 Use uintmax_t for page numbers.
1863 (first_last_page): Remove unnecessary forward declaration.
1864 Do not modify arg (it is now a const pointer).
1865 Return a true if successful, false (without print a diagnostic)
1867 (main): If +XXX does not specify a valid page range, treat it
1868 as a file name. This follows the response to Open Group XCU ERN 41
1869 <http://www.opengroup.org/sophocles/show_mail.tpl?source=L&listname=austin-group-l&id=7717>,
1870 which says the behavior is allowed.
1871 (skip_to_page): When starting page number exceeds page count,
1872 print both numbers in the diagnostic.
1873 (print_header): Detect page number overflow.
1875 2004-11-07 Jim Meyering <jim@meyering.net>
1877 * src/uname.c [__APPLE__]: Include <mach/machine.h> and <mach-o/arch.h>.
1878 (main) [__APPLE__]: Get the processor type via syscall rather than
1879 hard-coding "powerpc". From Toby Peterson.
1881 * src/sort.c (merge): Remove declarations of now-unused variables.
1883 2004-11-06 Paul Eggert <eggert@cs.ucla.edu>
1885 * src/sort.c (first_same_file): Remove. Move most of the code to....
1886 (avoid_trashing_input): New function.
1887 (merge): Avoid some silly merges, e.g., copying a single file to
1888 a temporary file when there are exactly 17 input files to merge.
1889 Take a count of temporary files rather than a max_merge arg.
1892 2004-11-06 Jim Meyering <jim@meyering.net>
1894 * src/sort.c (xfclose): Don't close stdout here (just flush it),
1895 since close_stdout now closes stdout unconditionally.
1897 2004-11-05 Paul Eggert <eggert@cs.ucla.edu>
1899 * src/sort.c (inittables, sort_buffer_size, getmonth, mergefps,
1900 first_same_file, merge, sort, main): Use size_t for indexes to arrays.
1901 This fixes some unlikely havoc-wreaking bugs (e.g., more than INT_MAX
1903 (getmonth, keycompare, compare): Rewrite to avoid need for alloca,
1904 thus avoiding unchecked stack overflow in some cases. As a side
1905 effect this improve the performance of "sort -M" by a factor of 4
1908 2004-11-03 Paul Eggert <eggert@cs.ucla.edu>
1910 * src/stty.c: Include "vasprintf.h" since we use vasprintf now.
1912 * src/Makefile.am (check-AUTHORS): Don't assume \? works in a sed
1913 expression; it's not portable. Problem reported by Albert Chin.
1914 Don't invoke a program more than once.
1915 * src/groups.sh (version): New variable, containing author info,
1916 for benefit of AUTHORS check. Use it when acting on --version option.
1917 * AUTHORS: Remove duplicate lines. Remove bogus "chroot:"
1920 * src/system.h: Don't #define and #undef getopt around <stdlib.h>,
1921 as this breaks the new regime that does "#define getopt rpl_getopt".
1922 Problem reported by Albert Chin for Solaris 9 with Sun cc in:
1923 http://lists.gnu.org/archive/html/bug-gnulib/2004-11/msg00019.html
1924 I suppose this may cause problems on ancient hosts with
1925 incompatible getopt declarations, but we'll cross that bridge if
1926 the problem gets reported to us by someone who can test the fix.
1928 2004-11-03 Jim Meyering <jim@meyering.net>
1930 * src/tac.c: quote(...) file names in diagnostics.
1932 2004-10-29 Paul Eggert <eggert@cs.ucla.edu>
1934 * NEWS: Document getdate changes.
1936 2004-10-29 Jim Meyering <jim@meyering.net>
1938 * src/tac.c (tac_file): Remove temporary prototype and move this
1939 function `down' so that it precedes definition of tac_nonseekable.
1941 `tac /proc/modules' would print nothing
1942 Reported by Harald Dunkel in http://bugs.debian.org/278604.
1944 * src/tac.c (copy_to_temp): Renamed from save_stdin, since
1945 now it copies a general file descriptor, not just stdin.
1946 (tac_nonseekable): Renamed/adapted from tac_stdin.
1947 (tac_file): Get fd via `open' directly rather than via fopen/fileno,
1948 since we never used the stream. Perform "-" to stdin mapping here
1949 rather than in main. Determine whether a file is seekable,
1950 by trying to `lseek' to its end, and dispatch to tac_seekable or
1951 tac_nonseekable accordingly.
1952 (main): Rewrite argument handling now that it uses only tac_file.
1953 * NEWS: Mention it here.
1955 2004-10-21 Jim Meyering <jim@meyering.net>
1957 * tests/mv/leak-fd: New file.
1958 * tests/mv/Makefile.am (TESTS): Add it.
1959 * tests/rm/dot-rel: New file.
1960 * tests/rm/Makefile.am (TESTS): Add it.
1962 Correct my patch of 2004-10-18.
1963 * src/remove.c (rm): Destroy the saved_cwd here (via cwd_state),
1964 if necessary, not in remove_dir. Otherwise, removing multiple
1965 `.'-relative nonempty directories no longer worked.
1967 2004-10-20 Paul Eggert <eggert@cs.ucla.edu>
1969 * src/fmt.c (usage): Improve description of --prefix.
1970 Problem reported by Edward Welbourne.
1972 * man/uniq.x: Change summary so that it doesn't imply that
1973 uniq writes to its input file. Problem reported by
1976 2004-10-18 Jim Meyering <jim@meyering.net>
1978 Plug a leak that would cause a cross-device mv to fail when
1979 operating on too many command-line-specified nonempty directories.
1980 * src/remove.c (remove_dir): Destroy the `struct saved_cwd' on the
1981 top of the stack before returning. This usually closes the file
1982 descriptor that was used to return to the original working directory.
1983 Reported by Cyril Bouthors in
1984 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/3048
1985 * NEWS: Mention it here.
1987 * src/pathchk.c (validate_file_name): Give a more descriptive
1988 diagnostic when pathconf fails. This also avoids an unwarranted
1989 warning from gcc-3.3.5 about a format not being a string literal.
1991 * src/sleep.c (main): Remove declaration of unused local, c.
1992 * src/printenv.c (main): Likewise.
1993 * src/logname.c (main): Likewise.
1994 * src/uptime.c (main): Likewise, for optc.
1995 * src/tsort.c (main): Likewise, for opt.
1997 2004-10-17 Paul Eggert <eggert@cs.ucla.edu>
1999 * AUTHORS: Add self to pathchk.
2000 * src/pathchk.c (AUTHORS): Add self.
2001 Change "path" to "file name" whenever possible.
2002 Remove usage comment, as it was a duplication of the code or doc.
2003 Include <wchar.h> if available.
2004 (mbrlen, mbstate_t) [! (HAVE_MBRLEN && HAVE_MBSTATE_T)]: Define.
2005 (NEED_PATHCONF_WRAPPER, PATH_MAX, PATH_MAX_FOR, NAME_MAX,
2006 pathconf_wrapper, portable_chars, dir_ok): Remove.
2007 (NAME_MAX_MINIMUM, PATH_MAX_MINIMUM): New macros.
2008 (pathconf, _PC_NAME_MAX, _PC_PATH_MAX): Define if nonexistent.
2009 (portable_chars_only): New arg FILELEN.
2010 Don't assume ASCII; we might be on an EBCDIC host.
2011 Don't assume unibyte locale in diagnostic.
2012 (component_start, component_len): New functions.
2013 (validate_file_name): Renamed from validate_path. All uses changed.
2014 Pretty much a complete rewrite.
2015 Don't make copy of file arg. Always append trailing slash to
2016 pathconf arg, just in case it's a symlink (this is pure paranoia;
2017 we don't know of any hosts where the trailing slash is required).
2018 Use size_t instead of long int when possible.
2019 Avoid need to call pathconf in most practical cases.
2020 Don't use euidaccess several times to test searchability;
2021 just use lstat once. Reword diagnostic to put the (often very long)
2024 2004-10-15 Paul Eggert <eggert@cs.ucla.edu>
2026 * src/printf.c (usage): Mention Unicode, and use H for hex digits.
2028 2004-10-13 Jim Meyering <jim@meyering.net>
2030 * NEWS: Mention today's fts.c fix.
2032 2004-10-13 Paul Eggert <eggert@cs.ucla.edu>
2034 * tests/stty/row-col-1: Set LC_ALL=C.
2036 2004-10-12 Jim Meyering <jim@meyering.net>
2038 * src/dircolors.hin: Add .flac and .mpc as audio suffixes.
2039 From Jesus Climent in http://bugs.debian.org/276149.
2041 2004-10-05 Paul Eggert <eggert@cs.ucla.edu>
2043 * src/ls.c (ignore_mode): Renamed from ignore, to avoid shadowing
2044 problems. All uses changed.
2046 2004-10-05 Jim Meyering <jim@meyering.net>
2048 * .x-sc_trailing_blank: Add an exclusion for config/texinfo.tex,
2049 since Karl says its trailing blanks are there to stay :-)
2051 2004-10-04 Paul Eggert <eggert@cs.ucla.edu>
2053 * src/expr.c (NEW, OLD): Remove, partly to avoid
2054 reference to obsolescent macro XMALLOC.
2055 All uses replaced by xmalloc and free.
2057 2004-09-28 Jim Meyering <jim@meyering.net>
2059 * src/tail.c (usage): Clarify: --retry works only with --follow=name.
2060 Reported by Nik A. Melchior in http://bugs.debian.org/273781.
2062 2004-09-27 Paul Eggert <eggert@cs.ucla.edu>
2064 * src/od.c (format_address_paren): c is optional, so don't output
2067 2004-09-26 Paul Eggert <eggert@cs.ucla.edu>
2069 Add support for ls --hide. Idea suggested by Bardur Arantsson.
2070 * NEWS: Document this.
2071 * src/ls.c (file_ignored): Renamed from file_interesting, with
2072 inverted return value. Accept the file name, not a struct dirent *.
2073 All uses changed. Avoid the expense of calling fnmatch if the
2074 file is ignorable due to leading '.'.
2075 (all_files, really_all_files): Removed; replaced by:
2076 (ignore): New variable. All uses changed.
2077 (IGNORE_DEFAULT, IGNORE_DOT_AND_DOTDOT, IGNORE_MINIMAL, HIDE_OPTION):
2079 (hide_patterns): New variable.
2080 (long_options, decode_switches, file_ignored, usage):
2081 Add support for --hide.
2082 (patterns_match): New function.
2083 (usage): Replace "hide" with "ignore" in explanation, to avoid
2086 2004-09-25 Paul Eggert <eggert@cs.ucla.edu>
2088 * src/ls.c (gobble_file, print_long_format): Don't assume that
2089 human-readable output has a byte count equal to its column width;
2090 this isn't always true in locales where the radix character is not
2092 (format_user_or_group): Revamp code to match the above fix;
2093 this avoids the (very faint) possibility of integer overflow.
2095 2004-09-24 Paul Eggert <eggert@cs.ucla.edu>
2097 * NEWS: Mention that "chmod -r -w x" now works as expected.
2098 * src/chmod.c (main): Revamp option processing to support this.
2099 * tests/chmod/Makefile.am (TESTS): Add 'usage'.
2100 * tests/chmod/usage: New set of tests for usage like that.
2102 2004-09-24 Jim Meyering <jim@meyering.net>
2104 * Makefile.maint (CVS_LIST): Use --types=AFGM option so that
2105 it lists only cvs-controlled regular files.
2107 * src/csplit.c (xalloc_die): Declare to be `extern', not `static'
2108 to avoid a warning from gcc-3.4.1. Reported by Paul Eggert.
2110 2004-09-23 Paul Eggert <eggert@cs.ucla.edu>
2112 * Makefile.maint (CVS_LIST): New macro.
2113 (sc_space_tab, sc_prohibit_atoi_atof, sc_file_system,
2114 sc_prohibit_jm_in_m4, sc_system_h_headers, sc_sun_os_names,
2115 sc_trailing_blank, po-check): Use it instead of the
2116 nonstandard "cvsu --list".
2118 * src/tail.c (parse_obsolete_option): Bring back support
2119 for obsolete option followed by non-obsolete, or by more
2120 than one file. When obsolete, conform to SUSv2 rather than
2121 original POSIX 1003.2-1992, as SUSv2 corrected the case of
2122 "tail -c". Add support for the SUSv2 "b" modifier.
2123 * NEWS: Mention the above.
2124 * tests/tail/Test.pm: New test case obs-b to check the above.
2125 err-[134] no longer need _POSIX2_VERSION=199209.
2126 Fix comments to match revised behavior.
2128 2004-09-22 Jim Meyering <jim@meyering.net>
2130 * Use automake-1.9.2. Regenerate dependent files.
2132 * src/remove.c (struct dirstack_state) [current_arg_jumpbuf]:
2133 Improve the comment.
2135 Clean up scoping etc. so that some make `distcheck' tests pass.
2136 * src/csplit.c (xalloc_die): Declare to be static.
2137 * src/chown-core.c (chown_files): Declare as `extern'.
2138 * src/cp-hash.c (remember_created): Likewise.
2139 * src/copy.c (copy): Likewise.
2140 * src/checksum.h (enum) [ALG_MD5]: Define to be 1, not 0.
2142 * src/id.c, src/nl.c, src/expand.c: Remove trailing blanks.
2143 * src/unexpand.c: Likewise.
2145 * src/Makefile.am (check-AUTHORS): New rule.
2146 (check): Depend on it.
2149 * Makefile.maint (syntax-check-rules): Remove duplicate sc_tight_scope.
2150 (sc_system_h_headers): Also exclude copy.h; it includes <stdbool.h>.
2152 2004-09-22 Paul Eggert <eggert@cs.ucla.edu>
2154 * src/ls.c (decode_switches): Don't compare a short value
2155 to SIZE_MAX: GCC sometimes complains.
2157 2004-09-21 Paul Eggert <eggert@cs.ucla.edu>
2159 * NEWS: The following commands now reject unknown options:
2160 basename dirname factor hostname link nohup sync unlink yes
2161 Also, pathchk no longer accepts trailing options.
2163 * src/basename.c: Include <getopt.h>.
2164 * src/chroot.c: Likewise.
2165 * src/dirname.c: Likewise.
2166 * src/factor.c: Likewise.
2167 * src/hostid.c: Likewise.
2168 * src/hostname.c: Likewise.
2169 * src/nohup.c: Likewise.
2170 * src/pwd.c: Likewise.
2171 * src/setuidgid.c: Likewise.
2172 * src/sync.c: Likewise.
2174 * src/basename.c (main): Reject unknown options.
2175 * src/dirname.c (main): Likewise.
2176 * src/factor.c (main): Likewise.
2177 * src/hostid.c (main): Likewise.
2178 * src/hostname.c (main): Likewise.
2179 * src/link.c (main): Likewise.
2180 * src/nohup.c (main): Likewise.
2181 * src/pwd.c (main): Likewise.
2182 * src/setuidgid.c (main): Likewise.
2183 * src/sync.c (main): Likewise.
2184 * src/unlink.c (main): Likewise.
2185 * src/yes.c (main): Likewise.
2187 * src/cat.c (main): Remove unused "case 0".
2188 * src/chgrp.c (main): Likewise.
2189 * src/chmod.c (main): Likewise.
2190 * src/chown.c (main): Likewise.
2191 * src/comm.c (main): Likewise.
2192 * src/cp.c (main): Likewise.
2193 * src/csplit.c (main): Likewise.
2194 * src/cut.c (main): Likewise.
2195 * src/date.c (main): Likewise.
2196 * src/df.c (main): Likewise.
2197 * src/du.c (main): Likewise.
2198 * src/env.c (main): Likewise.
2199 * src/expand.c (main): Likewise.
2200 * src/fold.c (main): Likewise.
2201 * src/head.c (main): Likewise.
2202 * src/id.c (main): Likewise.
2203 * src/install.c (main): Likewise.
2204 * src/join.c (main): Likewise.
2205 * src/ln.c (main): Likewise.
2206 * src/ls.c (decode_switches): Likewise.
2207 * src/mkdir.c (main): Likewise.
2208 * src/mkfifo.c (main): Likewise.
2209 * src/mknode.c (main): Likewise.
2210 * src/mv.c (main): Likewise.
2211 * src/nl.c (main): Likewise.
2212 * src/paste.c (main): Likewise.
2213 * src/pinky.c (main): Likewise.
2214 * src/pr.c (main): Likewise.
2215 * src/ptx.c (main): Likewise.
2216 * src/readlink.c (main): Likewise.
2217 * src/rm.c (main): Likewise.
2218 * src/rmdir.c (main): Likewise.
2219 * src/seq.c (main): Likewise.
2220 * src/shred.c (main): Likewise.
2221 * src/split.c (main): Likewise.
2222 * src/sum.c (main): Likewise.
2223 * src/tac.c (main): Likewise.
2224 * src/tail.c (main): Likewise.
2225 * src/tee.c (main): Likewise.
2226 * src/touch.c (main): Likewise.
2227 * src/tr.c (main): Likewise.
2228 * src/tty.c (main): Likewise.
2229 * src/uname.c (main): Likewise.
2230 * src/unexpand.c (main): Likewise.
2231 * src/wc.c (main): Likewise.
2232 * src/who.c (main): Likewise.
2234 * src/chroot.c (main): Use getopt where it suffices, not getopt_long.
2235 * src/cksum.c (main): Likewise.
2236 * src/dd.c (main): Likewise.
2237 * src/logname.c (main): Likewise.
2238 * src/printenv.c (main): Likewise.
2239 * src/sleep.c (main): Likewise.
2240 * src/tsort.c (main): Likewise.
2241 * src/uptime.c (main): Likewise.
2242 * src/users.c (main): Likewise.
2243 * src/whoami.c (main): Likewise.
2245 * src/du.c (long_options): Standardize on NULL vs 0.
2246 * src/rm.c (long_opts): Likewise.
2248 * src/logname.c (long_options): Remove.
2249 * src/printenv.c (long_options): Likewise.
2250 * src/sleep.c (long_options): Likewise.
2251 * src/tsort.c (long_options): Likewise.
2252 * src/uptime.c (longopts): Likewise.
2253 * src/users.c (longopts): Likewise.
2254 * src/whoami.c (long_options): Likewise.
2256 * src/pathchk.c (longopts): Add --help, --version.
2257 (main): Use longopts rather than parse_long_options.
2258 * src/stty.c (longpts, main): Likewise.
2260 * src/pathchk.c (main): Don't reorder arguments, so that
2261 we can check weird file names.
2263 * src/readlink.c: Don't include "long-options.h".
2264 * src/sort.c: Likewise.
2265 * src/stty.c: Likewise.
2267 * src/split.c (verbose): Now bool, not int.
2268 (VERBOSE_OPTION): New enum.
2269 (longopts, main): Use it.
2271 * tests/factor/basic: Adjust to new wording in diagnostic
2272 that results from the above changes.
2274 2004-09-21 Jim Meyering <jim@meyering.net>
2276 * man/rm.x: Say "the response is affirmative" rather than "the
2277 response begins with y or Y", so that the documentation is
2278 accurate in non-English locales. Problem reported by Munzir Taha.
2280 2004-09-19 Paul Eggert <eggert@cs.ucla.edu>
2282 * src/echo.c (main): Don't pass NULL to strcmp when
2283 POSIXLY_CORRECT and given no arguments.
2285 * src/md5sum.c (STRING_OPTION): Remove.
2286 (long_options, main): Remove support for undocumented and
2287 obsolete --string option, as suggested in the 1996-09-26 patch.
2288 * NEWS: Document this.
2290 * tests/rm/fail-eperm: Don't try to remove writeable files in a
2291 sticky /tmp directory, as SVR4-like systems (e.g., Solaris 9) let
2292 you remove such files. Problem reported by Bert Fischer in:
2293 http://lists.gnu.org/archive/html/bug-coreutils/2004-09/msg00074.html
2295 2004-09-18 Paul Eggert <eggert@cs.ucla.edu>
2297 * src/md5sum.c (STATUS_OPTION, STRING_OPTION): New enums.
2298 (long_options, main): Use them instead of magic numbers 2 and 1.
2299 For --string, optarg can't possibly be NULL.
2301 * src/dd.c (usage): Distinguish between options and operands.
2302 (scanargs): Don't mess with argc, argv; getopt_long handles this now.
2303 Say "operands" for operands, not "options".
2304 (main): Use getopt_long, so that "dd --" works as POSIX requires.
2305 * tests/dd/misc: Check for "dd --".
2307 * src/chroot.c (main): Reject unknown options instead of
2308 interpreting them as a directory to chroot to.
2310 * src/cksum.c: Remove obsolete comment about POSIX 1003.2/D11.2.
2311 The current standard (POSIX 1003.1-2004) is correct.
2312 (crc_remainder) [defined CRCTAB]: Renamed from "remainder" to avoid
2313 collision with builtin function.
2314 (main) [defined CRCTAB]: Output in lowercase hexadecimal, and
2315 output the first 0 as 8 digits, to make it easier to compare to
2316 the text of the standard. Output crctab to be a const array.
2317 (crctab): Use result of above changes.
2318 (long_options): Remove; not needed if empty.
2319 (main): getopt_long can't return 0 here, so simplify the code.
2321 2004-09-13 Jim Meyering <jim@meyering.net>
2323 * src/Makefile.am (localedir.h): Don't redirect directly to target.
2325 2004-09-13 Paul Eggert <eggert@cs.ucla.edu>
2327 * src/id.c (print_full_info): Don't exit with failure status simply
2328 because a user or group number can't be turned into a name.
2329 Problem reported by Felipe Kellermann in:
2330 http://lists.gnu.org/archive/html/bug-coreutils/2004-09/msg00081.html
2332 2004-09-12 Jim Meyering <jim@meyering.net>
2334 * Makefile.maint (my-distcheck): When building with -Werror, also
2337 2004-09-10 Paul Eggert <eggert@cs.ucla.edu>
2339 * NEWS: "tail" now handles obscure POSIX 1003.2-1992 cases better.
2340 * src/tail.c (parse_obsolete_option): Renamed from
2341 parse_obsolescent_option, since the options are obsolete now.
2342 Remove bool *arg; just exit if there's an error. Revamp to follow
2343 POSIX 1003.2-1992 more precisely, to handle cases like "tail -
2344 file" and "tail -10 -- file" correctly when we are conforming to
2346 (main): Adjust to this change.
2347 * tests/tail/Test.pm (test_vector): minus-* requires
2348 _POSIX2_VERSION=199209 now, to work correctly if there is
2349 an input file. err-1 and err-3 no longer errors if there
2352 2004-09-09 Paul Eggert <eggert@cs.ucla.edu>
2354 * src/test.c (usage): Document -r, -w, -x more carefully.
2356 2004-09-08 Paul Eggert <eggert@cs.ucla.edu>
2358 * src/test.c (usage): Document "test" (with no args) and "[ ]".
2359 Document that -h and -L don't dereference.
2361 * NEWS: Document that "tr xy -z" now works as per POSIX.
2362 Sort the descriptions.
2363 * src/tr.c (main): Don't reorder options.
2364 * tests/tr/Test.pm (fowler-1): New test case.
2366 2004-09-06 Paul Eggert <eggert@cs.ucla.edu>
2368 * src/touch.c (main): Fix POSIX-conformance bug: "touch --
2369 MMDDhhmm file" must be treated like "touch MMDDhhmm file" when
2370 conforming to pre-2001 POSIX.
2371 * NEWS: Document this.
2372 * tests/touch/obsolescent: Test for this bug. Also, set
2373 _POSIX2_VERSION=199209 and POSIXLY_CORRECT=1 so that it's
2374 a better test for obsolescent features.
2376 * src/sort.c (main): Emulate Solaris 8 and 9 "sort -y", so that
2377 "sort -y abc" is like "sort abc" whereas "sort -y 100" is like
2380 * src/od.c: Several changes for POSIX and FreeBSD compatibility.
2381 (COMMON_SHORT_OPTIONS): Add -B, -D, -e, -F, -H, -I, -L, -O, -s, -X.
2382 (long_options, main): --strings is now -S, not -s.
2383 (usage): Reflect the usage changes.
2384 (parse_old_offset): Do not issue a diagnostic on failure;
2385 callers now do this as necessary.
2386 (main): Support POSIX syntax. Remove unused case 0 from getopt_long.
2387 Add support for new short options (many undocumented) for
2388 compatibility with FreeBSD. Remove FIXME for -s; it's now
2389 POSIX-compatible. Default format is now oS, not o2.
2390 * NEWS: Describe the above.
2392 2004-09-05 Paul Eggert <eggert@cs.ucla.edu>
2394 * src/stty.c (valid_options): Remove.
2395 (main): Fix some bugs in handling invalid option-combinations
2397 (recover_mode): Arg is now char const *, not char *.
2398 (main): Use STDIN_FILENO, not 0.
2399 Simplify option-parsing code a tad.
2400 * tests/stty/basic-1: Check for the fixed bugs.
2402 2004-09-03 Paul Eggert <eggert@cs.ucla.edu>
2404 * src/stat.c (HAVE_STRUCT_STATXFS_F_TYPE): Fix typo that prevented
2405 it from ever being nonzero. Reported by Pozsar Balazs in:
2406 http://lists.gnu.org/archive/html/bug-coreutils/2004-08/msg00189.html
2407 (human_fstype): Add ramfs, squashfs, sysfs.
2408 Reported by Pozsar Balazs in:
2409 http://lists.gnu.org/archive/html/bug-coreutils/2004-08/msg00188.html
2410 (human_fstype): Return char const *, not char *.
2411 Simplify internals a bit, and avoid casts.
2413 * src/dd.c (usage): "alternated EBCDIC" -> "alternate EBCDIC".
2414 (bit_count): Remove. All uses changed to....
2415 (multiple_bits_set): New function.
2416 (scanargs): Use it, and check separately for each set of
2417 incompatible options, to improve diagnostics.
2419 (apply_translations): Move checks for incompatible options
2420 to scanargs, so that they're done consistently.
2422 2004-09-02 Paul Eggert <eggert@cs.ucla.edu>
2424 Output correct errno-related diagnostic on "paste" I/O errors.
2425 * src/paste.c (write_error, xputchar): New functions.
2426 (paste_parallel): Use correct errno value after input error.
2427 (paste_parallel, paste_serial): Report errno value after output error.
2429 Port to diet libc. Problem reported by Felix von Leitner in:
2430 http://lists.gnu.org/archive/html/bug-coreutils/2004-08/msg00171.html
2431 * src/paste.c (dummy_closed, CLOSED, dummy_endlist, ENDLIST): Remove;
2432 it's not portable C to assume FILE is a complete type.
2433 (paste_parallel): Use index test instead of ENDLIST, and NULL
2436 2004-08-24 Paul Eggert <eggert@cs.ucla.edu>
2438 POSIX-conformance fixes for "expand" and "unexpand".
2439 Also, consistently use "tab stop" rather than "tabstop".
2440 * NEWS: Document fixes.
2441 * src/expand.c: Revamp to resemble the new unexpand.c better.
2442 (usage): -i does not convert tabs after non-tabs.
2443 (add_tab_stop): Renamed from add_tabstop. All uses changed.
2444 (parse_tab_stop): Renamed from parse_tabstop. All uses changed.
2445 (validate_tab_stop): Renamed from validate_tabstop. All uses changed.
2446 (next_file, main): Check fclose against 0, not EOF.
2447 (expand): Remove unnecessary casts.
2448 Add another loop nesting level, for lines, so that per-line variables
2449 are initialized cleanly.
2450 Revamp tab checking. Check for write error immediately, rather
2451 than just once at the end of the program.
2452 * src/unexpand.c: Lkewise (for the expand.c changes).
2453 (TAB_STOP_SENTINEL): Remove.
2454 (tab_size): Now size_t, not uintmax_t, since we need to store
2455 the sequences of blanks.
2456 (max_column_width): New var.
2457 (usage): Say "blank" where POSIX requires this.
2458 (add_tab_stop): Calculate maximum column width.
2459 (unexpand): Store the pending blanks, instead of merely counting them.
2460 Follow POSIX's rules about -a requiring two blanks before a tab stop.
2461 Get rid of internal label and goto.
2462 * tests/unexpand/basic-1: Fix infloop-3 to match POSIX.
2463 Add blanks-1 through blanks-13.
2465 2004-08-19 Paul Eggert <eggert@cs.ucla.edu>
2467 * NEWS: "chown : file", "chown '' file", and "chgrp '' file" now
2468 succeed without changing the uid and gid, like FreeBSD.
2469 * src/chgrp.c (parse_group): Return gid_t rather than storing it
2470 through a pointer. Treat "chgrp '' file" as a no-op change,
2472 (main): Set chopt.group_name to NULL if the group is the empty
2474 * src/chown-core.c (describe_change): Describe changes to -1:-1
2475 without using "to OWNERSHIP" phrase.
2476 * src/chown.c (usage): "chown '' file" is now allowed.
2477 (main): Do not set user name to the empty string if the group
2479 * tests/chgrp/basic: Test "chgrp '' file".
2480 * tests/chown/Makefile.am (TESTS): Add separator.
2481 * tests/chown/separator: New file, partly taken from
2482 Dmitry V. Levin's suggestion in
2483 <http://lists.gnu.org/archive/html/bug-coreutils/2004-08/msg00102.html>
2485 2004-08-11 Paul Eggert <eggert@cs.ucla.edu>
2487 * tests/install/basic-1: Test for the -d regression.
2489 2004-08-11 Dmitry V. Levin <ldv@altlinux.org>
2491 * src/install.c (main): Fix -d regression introduced with
2492 --target-directory support at 2004-06-25.
2494 2004-08-11 Paul Eggert <eggert@cs.ucla.edu>
2496 * src/copy.c (copy_internal): When preserving links, unlink
2497 a destination with link count greater than one. This is so
2498 that commands like "cp -a" don't get confused when copying into
2499 a destination that already contains many hard links. Problem
2500 reported by Tim Waugh in:
2501 http://lists.gnu.org/archive/html/bug-coreutils/2004-08/msg00053.html
2503 2004-08-10 Paul Eggert <eggert@cs.ucla.edu>
2505 Convert all files to UTF-8.
2506 * tests/fmt/basic (8-bit-pfx): Use UTF-8, not Latin-1.
2507 * tests/sort/Test.pm (16a): Likewise.
2508 * tests/uniq/Test.pm (8): Likewise.
2509 * tests/misc/printf-hex: Use ASCII, not Latin-1.
2511 * NEWS: Document "sort -o -" and "tee -" POSIX-conformance fixes.
2512 * src/shred.c (usage): "-" is an operand, not an option.
2513 * src/sort.c (die, xfopen, mergefps, first_same_file, merge):
2514 A null file arg means standard output.
2515 (main): "-o -" means to write to a file named "-",
2516 not to standard output.
2517 * src/tee.c (usage, tee): "tee -" writes to standard output, not
2518 to a file named "-".
2520 2004-08-10 Dmitry V. Levin <ldv@altlinux.org>
2522 * src/install.c (change_timestamps): Fix int->bool conversion
2523 bugs introduced on 2004-07-29.
2525 2004-08-09 Paul Eggert <eggert@cs.ucla.edu>
2527 * src/shred.c (wipename): Work even if the directory is writeable
2528 and not readable. Prefer write access, since this should work
2529 better with fdatasync.
2531 * src/csplit.c (xalloc_die): New function.
2532 (main): Remove now-obsolete initialization of xalloc_fail_func.
2534 * src/md5sum.c: Adjust to sha->sha1 renaming.
2536 2004-08-08 Dmitry V. Levin <ldv@altlinux.org>
2539 * src/readlink.c (canonicalize_fname): Remove unneeded proxy function.
2540 (can_mode): Make variable local.
2542 2004-08-07 Paul Eggert <eggert@cs.ucla.edu>
2544 * src/system.h (O_BINARY) [!O_BINARY && defined O_BINARY]:
2545 Do not define, to avoid annoying compiler messages on QNX 6.3.
2546 Problem reported by Johan in:
2547 http://lists.gnu.org/archive/html/bug-coreutils/2004-08/msg00050.html
2549 2004-08-04 Paul Eggert <eggert@cs.ucla.edu>
2551 * src/system.h (PRIdMAX, PRIoMAX, PRIuMAX, PRIxMAX):
2552 Define to a concatenation of string literals, not to an expression;
2553 needed for concatenation contexts.
2554 (INTMAX_MAX, INTMAX_MIN): New macros.
2556 * src/stat.c (print_stat): Don't assume st_ino / st_dev fits in
2557 unsigned long; this isn't true for st_ino on Solaris 9.
2559 2004-08-03 Paul Eggert <eggert@cs.ucla.edu>
2561 * src/uname.c: Do not depend on HAVE_SYSCTL when deciding
2562 whether to include files. Include <sys/param.h> if
2563 HAVE_SYS_PARAM_H (not HAVE_SYSCTL).
2564 (main) [defined __POWERPC__]: Add a kludge to work around a
2565 Mac OS X bug, so that uname -p defaults to "powerpc" if
2566 sysctl ((int[]) {CTL_HW, HW_MACHINE_ARCH}, 2, buffer, &bufsize, 0, 0)
2567 fails. Problem reported by Petter Reinholdtsen in:
2568 http://lists.gnu.org/archive/html/bug-gnu-utils/2003-02/msg00201.html
2570 * src/uniq.c (hard_LC_COLLATE, ignore_case, different, check_file,
2571 main): Use bool for booleans.
2572 (writeline, check_file): Use uintmax_t for line counts.
2573 (check_file): Check for and report line number overflow,
2575 * src/wc.c (iswspace, wc): Use to_uchar rather than a cast.
2576 (print_lines, print_words, print_chars, print_bytes, print_linelength,
2577 have_read_stdin, wc, wc_file, main):
2578 Use bool for booleans.
2579 (exit_status): Remove.
2580 (wc, wc_file): Return bool status. All callers changed.
2581 * src/who.c (scan_entries): 0 -> STDIN_FILENO.
2582 * src/whoami.c (main): Print uids using unsigned long int, not
2585 * src/unexpand.c: Int cleanup and minor reorganization to be more
2587 Include quote.h, xstrndup.h.
2588 (TAB_STOP_SENTINEL): Increase from INT_MAX to INTMAX_MAX.
2589 (convert_entire_line, have_read_stdin, parse_tabstops, next_file,
2591 Use bool for booleans.
2592 (tab_size, tab_list, add_tabstop, validate_tabstops, unexpand):
2593 Use uintmax_t for column counts.
2594 (first_free_tab, validate_tabstops, unexpand): Use size_t for sizes.
2595 (add_tabstop, parse_tabstops, main): Don't reserve UINTMAX_MAX
2597 (parse_tabstops): Don't use ISBLANK on possibly-signed char.
2598 Detect overflow in tab stop string.
2599 (next_file, main): Use EXIT_FAILURE/EXIT_SUCCESS instead of 1/0.
2600 (unexpand): Concatenate input files the same way expand does.
2602 * src/touch.c (no_create, use_ref, posix_date, amtime_now,
2603 touch, main): Use bool for booleans.
2604 (main): Avoid integer overflow when given more than INT_MAX
2606 * src/tsort.c (struct item, n_strings): Use size_t for sizes.
2607 (have_read_stdin, count_items, scan_zeros, detect_loop,
2608 recurse_tree, walk_tree, tsort, main):
2609 Use bool for booleans.
2610 (exit_status): Remove.
2611 (tsort): Return a success flag instead of storing into a global.
2613 * src/tty.c (silent, main): Use bool for booleans.
2614 (main): 0 -> STDIN_FILENO.
2615 * src/uname.c (print_element): Use bool for booleans.
2617 * src/test.c (TRUE, FALSE, SHELL_BOOLEAN, TRUTH_OR, TRUTH_AND):
2618 Remove. All uses replaced by C99 boolean primitives.
2619 (TEST_TRUE, TEST_FALSE): New constants, for readability.
2620 (test_unop, binop, unary_operator, binary_operator, two_arguments,
2621 three_arguments, posixtest, expr, term, and, or, is_int, age_of,
2622 one_argument, main): Use bool for booleans.
2623 (advance, unary_advance): Now inline procedures rather than a macros.
2624 (is_int): Renamed from isint, to avoid namespace clash with ctype.h.
2625 (term, and, or): When it's easy, loop instead of recursing.
2626 (term): Avoid integer overflow if there are INT_MAX-3 args (!).
2627 (binary_operator, unary_operator): Simplify by systematically rewriting
2628 true==FOO to FOO (where FOO is a boolean).
2629 (unary_operator): Don't consider a file to be a regular file
2630 merely because its mode&S_IFMT is zero. Just use S_ISREG.
2631 Remove unnecessary casts. Remove ifdefs for things like
2632 S_ISSOCK that are no longer needed, since stat-macros.h always
2635 * src/tac-pipe.c (buf_init_from_stdin, find_bol, tac_mem):
2636 Use bool for booleans.
2637 (buf_init_from_stdin, buf_free, find_bol, print_line):
2638 Use size_t for sizes.
2639 * src/tac.c (separator_ends_record, tac_seekable, tac_file,
2640 tac_stdin, tac_stdin_to_mem, main): Use bool for booleans.
2641 (match_length, G_buffer_size, tac_seekable, main): Use size_t for sizes.
2642 (tac_seekable): Use ptrdiff_t for pointer subtraction.
2643 Report an error if the result is out of range.
2644 (tac_seekable, main): Check for integer overflow in buffer size
2646 (main): Remove unnecessary casts.
2648 * src/su.c (run_shell): Pass a new n_additional_args arg, so that
2649 the callee doesn't have to count 'em. All callers changed.
2650 Don't allocate more space for the arg vector than we'll need.
2651 Use memcpy to copy the args rather than rolling our own loop.
2652 Use size_t for sizes.
2653 (fast_startup, simulate_login, change_environment, log_su,
2654 correct_password, restricted_shell, main): Use bool for booleans.
2655 (longopts): Don't assume change_environment is an int.
2656 Use NULL, not 0, for pointers.
2657 (xsetenv): New function, replacing xputenv and concat.
2658 All callers changed.
2659 (elements): Remove; no longer needed.
2660 (log_su, correct_passwd, main): Prefer !x to x==NULL.
2661 (log_su): 2 -> STDERR_FILENO.
2662 (modify_environment, main): Don't assume that getenv's returned value
2663 has an indefinite lifetime.
2664 (modify_environment): Allocate a larger environ.
2665 (main): Remove an impossible 'case 0'; if it happens now, it'll
2666 get diagnosed. Don't assume getpwnam results outlive endpwent.
2667 Check for null or empty pw_name, pw_dir and for null pw_passwd.
2669 * src/stty.c (VA_START): Remove. All callers now use va_start.
2670 (_POSIX_VDISABLE): Remove unnecessary cast.
2671 (struct control_info, visible): Use cc_t for control chars.
2672 (struct control_info): Use size_t for sizes.
2673 (recover_mode, set_mode, display_speed, display_window_size,
2674 valid_options, main, display_changed):
2675 Use bool for booleans.
2676 (integer_arg): Return unsigned long int, not long int.
2677 Accept new max arg; all callers changed, to specify a maximum
2678 value for integer parameters instead of silently overflowing.
2679 (wrap): Do not overrun the stack buffer if the output contains
2680 more than 1024 bytes. Instead, malloc a buffer.
2681 (main): Remove a "what is this?!?" FIXME. Nobody knows what it is.
2682 Remove unnecessary casts.
2683 (set_control_char): Allow int values only up to cc_t range.
2684 (screen_columns): Don't reject INT_MAX.
2685 (display_changed, display_all, display_speed, recover_mode):
2686 Don't assume cc_t fits in int.
2688 * src/remove.h: Add copyright notice.
2689 (struct rm_options): Use bool for booleans.
2690 * src/rmdir.c (empty_paths, ignore_fail_on_non_empty, verbose,
2691 errno_rmdir_non_empty, remove_parents, main): Likewise.
2692 * src/sum.c (have_read_stdin, bsd_sum_file, sysv_sum_file,
2694 (main): Don't dump core if invoked with argv[0]==NULL.
2695 * src/tee.c (tee, append, ignore_interrupts, main, tee):
2696 Use bool for booleans.
2697 (tee): Use ssize_t for read returns.
2699 * src/ptx.c: Add a FIXME mentioning that there are many
2700 unchecked integer overflows in this file.
2701 (gnu_extensions, auto_reference, input_reference, right_reference,
2702 ignore_case, initialize_regex, fix_output_parameters,
2703 output_one_roff_line, output_one_text_line, output_one_dumb_line, main):
2704 Use bool for booleans.
2705 (SKIP_SOMETHING, compare_words, digest_break_file,
2706 find_occurs_in_text, fix_output_parameters):
2707 Use to_uchar instead of a caset.
2708 (print_field): Rewrite to avoid cast.
2710 * src/printf.c (posixly_correct): Use bool for booleans.
2711 (verify, main): Use EXIT_FAILURE/EXIT_SUCCESS instead of 1/0.
2712 (STRTOX): Rewrite to avoid casts.
2713 (print_esc_char): Arg is char, not int.
2714 * src/readlink.c (canonicalize): Remove. All uses now merely inspect
2716 (no_newline, verbose): Use bool for booleans.
2717 (can_mode): Now of type int; use -1 to denote otherwise-uninitialized.
2718 * src/shred.c (struct Options, main): Use bool for booleans.
2719 (isaac_seed_data, fillpattern, wipefile): Rewrite to avoid casts.
2720 * src/split.c (cwrite, bytes_split, lines_split, line_bytes_split):
2721 Use bool for booleans.
2722 * src/stat.c (G_fail): Remove.
2723 (print_statfs): Print various gotta-be-nonnegative values using
2724 unsigned long int, not long int or int.
2725 (do_statfs, do_stat): Return a boolean success flag.
2726 (do_stat, main): Use bool for booleans.
2728 * src/pr.c: Add a FIXME mentioning that there are many
2729 unchecked integer overflows in this file.
2730 (TRUE, FALSE): Remove. All uses replaced by true and false.
2731 (struct COLUMN, read_line, print_page, print_stored, open_file,
2732 skip_to_page, init_fps, parallel_files, align_empty_cols,
2733 empty_line, FF_only, explicit_columns, extremities, keep_FF,
2734 print_a_FF, print_a_header, use_form_feed, have_read_stdin,
2735 print_across_flag, storing_columns, balance_columns,
2736 truncate_lines, join_lines, untabify_input, failed_opens,
2737 numbered_lines, skip_count, use_esc_sequence, use_cntrl_prefix,
2738 double_space, ignore_failed_opens, use_col_separator,
2739 pad_vertically, last_line, main, init_parameters, skip_read,
2740 read_line, print_stored):
2741 Use bool for booleans.
2742 (struct COLUMN, char_to_clump, store_char, print_char):
2744 (clump_buff, print_clump): Use char[], not int[], for an array whose
2745 elements are always chars.
2746 (first_last_page, main, getoptarg, balance, add_line_number,
2747 char_to_uclump): Remove unnecessary casts.
2748 (init_parameters): Allocate chars, not ints, for clump_buff.
2749 (print_char): Use to_uchar before invoking ISPRINT.
2750 (char_to_clump): Convert to unsigned char before invoking ISPRINT.
2752 * src/nohup.c (main): Use bool for booleans.
2753 * src/paste.c (paste_parallel, paste_serial, main): Likewise.
2754 * src/pathchk.c (validate-path, main, portable_chars_only): Likewise.
2755 (portable_chars_only): Use to_uchar rather than a cast.
2756 * src/printenv.c (main): Use bool for booleans.
2757 Do not assume that the environ has at most one matching entry
2758 for each option (integer overflow was possible otherwise).
2760 * src/od.c (FMT_BYTES_ALLOCATED): Now an enum, not a decimal
2761 constant. Do not assume PRIdMAX etc. are strings of length 3 or
2763 (struct tspec): Use it. fmt_string is now an array, not
2764 a pointer, as there's little point to the indirection here.
2765 (struct tspec, flag_dump_strings,
2766 traditional, flag_pseudo_start, limit_bytes_to_format,
2767 abbreviate_duplicate_blocks, have_read_stdin, simple_strtoul,
2768 decode_one_format, open_next_file, check_and_close,
2769 decode_format_string, skip, write_block, read_char, read_block,
2770 parse_old_offset, dump, dump_strings, main):
2771 Use bool for booleans.
2772 (struct tspec): Use void *, not char *, for generic pointers.
2773 (bytes_to_oct_digits, bytes_to_signed_dec_digits,
2774 bytes_to_unsigned_dec_digits, bytes_to_hex_digits):
2775 Use char, not unsigned int, since char suffices.
2776 (print_s_char, print_char, print_s_short, print_short,
2777 print_int, print_long, print_long_long, print_float,
2778 print_double, print_long_double): Rewrite to avoid casts.
2779 These now take void * arguments, instead of char *.
2780 Use the same body for all functions, except for the choice
2781 of type. Assume C89 to simplify handling of signed char.
2782 (dump_hexl_mode_trailer, print_named_ascii, print_ascii):
2783 Rewrite to avoid casts.
2784 (print_named_ascii, print_ascii): Now takes void *, not char *.
2785 (decode_one_format): Use int for printf field widths, not
2786 unsigned int. Pass void * to subsidiary printers,
2787 not char *. Simplify handling of floating-point formats
2788 by factoring out common code dealing with precision and field width.
2789 (decode_format_string): Avoid need for temporary copy of
2790 each decoded struct tspec.
2791 (get_lcm): Remove unnecessary cast.
2792 (main): Fix bug where more than INT_MAX failed decodes were ignored.
2794 2004-08-02 Paul Eggert <eggert@cs.ucla.edu>
2796 * src/nl.c (TRUE, FALSE): Remove; all uses changed to true, false.
2797 (enum number_format): Remove.
2798 (FORMAT_RIGHT_NOLZ, FORMAT_RIGHT_LZ, FORMAT_LEFT): Now strings,
2800 (DEFAULT_SECTION_DELIMITERS): Now an array constant, not a macro.
2801 (section_del): Now const.
2802 (print_fmt): Remove.
2803 (starting_line_number, page_incr, blank_join, line_no,
2804 print_lineno, proc_text, main):
2805 Use intmax_t for line numbers.
2806 (reset_numbers, have_read_stdin, build_type_arg, nl_file, main):
2807 Use bool for booleans.
2808 (lineno_format): Now a string, not an enum value.
2809 (build_print_fmt): Remove. All calls removed. This work is
2810 now done within print_lineno.
2811 (build_type_arg): Use size_t for sizes.
2812 (print_lineno): Check for line number overflow.
2813 (proc_text, main): Remove unnecessary cast.
2815 * src/ln.c (symbolic_link, interactive, remove_existing_files,
2816 verbose, hard_dir_link, dereference_dest_dir_symlinks,
2817 do_link, main): Use bool for booleans.
2819 * src/ls.c (struct fileinfo, file_interesting,
2820 extract_dirs_from_files, color_symlink_as_referent,
2821 FILE_OR_LINK_MODE, sort_reverse, print_owner, print_group,
2822 numeric_ids, print_block_size, dired, print_with_color,
2823 check_symlink_color, print_inode, recursive, immediate_dirs,
2824 all_files, really_all_files, qmark_funny_chars,
2825 print_dir_name, format_needs_stat, format_needs_type, visit_dir,
2826 main, decode_switches, parse_ls_color, print_dir, file_interesting,
2827 gobble_file, make_link_path, basename_is_dot_or_dotdot,
2828 extract_dirs_from_files, print_long_format):
2829 Use bool for booleans.
2830 (dir_defaulted): Remove; no longer needed.
2831 (main): Use int to count files, since it suffices for argv.
2832 Rewrite to avoid need for dir_defaulted.
2833 (main, print_dir, gobble_file, get_link_name,
2835 Set exit status to EXIT_SUCCES/EXIT_FAILURE rather than 0/1.
2836 (decode_switches): Put back check for ws.ws_col <= SIZE_MAX.
2837 Remove unnecessary cast to int. Use int instead of unsigned
2838 int to count from 0 to 1.
2839 (get_funky_string, print_type_indicator): Use char for bytes, not int.
2840 (make_link_path): Use NULL for null pointers.
2841 (quote_name): Use to_uchar instead of cast.
2843 * src/id.c (use_name, main, print_user, xgetgroups, print_group_list,
2844 print_full_info): Use bool for booleans.
2845 (problems): Remove, replacing with....
2846 (ok): New var (inverted from old sense).
2847 (print_user, print_group, print_full_info):
2848 Print uids/gids with %lu, not %u.
2849 (xgetgroups): Don't run out of memory if getgroups or getugroups
2851 * src/setuidgid.c (main): Print uids/gids with %lu, not %ld.
2853 * src/factor.c (wheel_tab): Use unsigned char instead of unsigned
2854 int, since it suffices.
2855 (factor, print_factors): Use size_t for sizes.
2856 (print_factors, do_stdin, main): Use bool for booleans.
2857 * src/fold.c (TAB_WIDTH): New macro; use it instead of "8".
2858 (fold_file, main): Use bool for booleans.
2859 (fold_file, main): Use size_t for sizes.
2860 (main): Allow -w options up to SIZE_MAX - TAB_WIDTH - 1, instead
2861 of prohibiting widths greater than INT_MAX.
2862 * src/head.c (presume_input_pipe, print_headers, have_read_stdin,
2863 write_header, elide_tail_bytes_pipe, elide_tail_bytes_file,
2864 elide_tail_lines_pipe, elide_tail_lines_seekable,
2865 elide_tail_lines_file, head_bytes, head_lines, head, head_file,
2866 string_to_integer, main):
2867 Use bool for booleans.
2868 (main): Rewrite to avoid cast.
2870 * src/csplit.c (struct line): Use size_t for sizes.
2871 (main): Remove unnecessary cast.
2872 * src/cut.c (cut_fields): Use to_uchar rather than a cast.
2873 * src/cut.c (cut_file, main): Use bool for booleans.
2874 * src/date.c (show_date, rfc_format, batch_convert, main): Likewise.
2875 * src/env.c (main): Likewise.
2876 * src/expr.c (nextarg): Likewise.
2877 * src/env.c (main): Remove unused and nonstandard envp arg.
2879 * src/fmt.c (COST, MAXWORDS): Add a comment describing some of
2880 fmt's arbitrary limits.
2881 (TRUE, FALSE): Remove; all uses changed to (true, false).
2882 (main): Use bool for booleans.
2883 Limit maximum width to MAXCHARS / 2. Use xstrtoul, not xstrtol,
2885 (copy_rest): Remove unnecessary cast.
2886 (get_prefix): Rewrite to avoid cast.
2887 (check_punctuation): Use char *, not unsigned char *; C89 requires
2888 this. Avoid off-by-one buffer read overrun when line is empty.
2889 (flush_paragraph): Don't assume wptr-parabuf is <= INT_MAX.
2890 Remove unnecessary casts.
2891 * tests/fmt/basic (wide-1, wide-2, bad-suffix): Adjust to above
2894 * src/expand.c (convert_entire_line, have_read_stdin, parse_tabstops,
2895 next_file, expand, main):
2896 Use bool for booleans.
2897 (tab_size, tab_list, add_tabstop, parse_tabstops, validate_tabstops,
2899 Use uintmax_t for column counts.
2900 (add_tabstop): Don't reserve -1 (now UINTMAX_MAX) as a special value.
2901 All callers changed.
2902 (parse_tabstops): Don't pass a negative char to isblank.
2903 Avoid memory leak with large tab stops.
2904 (validate_tabstops, expand): Don't assume number of tab stops is
2906 (next_file, main): Use EXIT_SUCCESS/EXIT_FAILURE rather than 0/1 when
2907 storing values into exit_status.
2908 (expand): Use same pattern as unexpand for reading chars.
2909 Report an error when input line is too long, instead of silently
2910 screwing up. Do not mishandle tab stops when backspacing left
2913 * src/dircolors.c (have_read_stdin, append_quoted,
2914 dc_parse_stream, dc_parse_file, main): Use bool for booleans.
2915 (dc_parse_stream): Use enum for state, rather than int.
2916 Use ssize_t to store getline result.
2918 * src/dd.c (translation_needed, parse_integer, scanargs,
2919 apply_translations, char_is_saved, swab_buffer, skip_via_lseek):
2920 Use bool for booleans.
2921 (translate_buffer): Use to_uchar rather than a cast.
2922 (swab_buffer, copy_simple, copy_with_unblock):
2923 Use size_t for sizes.
2925 * src/seq.c (equal_width, valid_format, main): Use bool for booleans.
2926 * src/sleep.c (apply_suffix): Likewise.
2927 * src/tail.c (struct File_spec, reopen_inaccessible_files, count_lines,
2928 forever, from_start, print_headers, have_read_stdin, valid_file_spec,
2929 write_header, file_lines, pipe_lines, pipe_bytes, recheck,
2930 tail_forever, tail_bytes, tail_lines, tail, tail_file,
2931 parse_obsolescent_option, parse_options, main): Likewise.
2932 * src/sleep.c (apply_suffix): Invert sense of result.
2933 Use int (not unsigned int) for multiplier, as this generates better
2934 code with some compilers. Simplify code a bit.
2935 * src/tail.c (struct File_spec, max_n_unchanged_stats_between_opens,
2936 parse_options): Use uintmax_t, not unsigned int or unsigned long int,
2938 (tail_bytes, tail_lines): Redo test of return value (-1, 0, 1) to
2939 make it a bit clearer.
2941 * src/hostname.c: Include "xgethostname.h".
2942 (xgethostname): Remove decl; xgethostname.h has it.
2943 (sethostname) [!defined(HAVE_SETHOSTNAME) && defined(HAVE_SYSINFO)
2944 && defined (HAVE_SYS_SYSTEMINFO_H) && defined(HAVE_LIMITS_H)]: Use
2945 prototypes rather than K&R form. Assume any negative value from
2946 sysinfo denotes failure, not just -1.
2947 (main): Simplify use of sethostname.
2949 * src/pinky.c (include_idle, include_heading, include_fullname,
2950 include_project, include_plan, include_home_and_shell, do_short_format,
2951 include_where, main): Use bool for booleans.
2952 (count_ampersands, create_fullname, scan_entries, short_pinky):
2953 Use size_t for sizes.
2954 (create_fullname): Check for overflow in size calculations.
2955 (idle_string): Don't assume that the number of idle days
2956 is less than 10**8 and/or INT_MAX/(24*60*60).
2957 (main): No need to pass a non-NULL last arg to getopt_long.
2958 * src/uptime.c (print_uptime, uptime): Use size_t for sizes.
2959 (print_uptime): Remove unused local variable.
2960 (main): No need to pass a non-NULL last arg to getopt_long.
2961 * src/users.c (list_entries_users, users): Use size_t for sizes.
2962 (list_entries_users): Use char for bytes.
2963 (main): No need to pass a non-NULL last arg to getopt_long.
2964 * src/who.c (do_lookup, short_list, short_output, include_idle,
2965 include_heading, include_mesg, include_exit, need_boottime,
2966 need_deadprocs, need_login, need_initspawn, need_clockchange,
2967 need_runlevel, need_users, my_line_only, main): Use bool for booleans.
2968 (print_runlevel): Use unsigned char for bytes.
2969 (list_entries_who, scan_entries, who): Use size_t for sizes.
2970 (main): No need to pass a non-NULL last arg to getopt_long.
2972 * src/install.c (isdir): Remove decl.
2973 (install_file_to_path): Rely on make_path to fail if the destination
2974 is not a directory, by passing preserve_existing==true to it.
2975 Hence we no longer need to call isdir.
2976 Free dest_dir immediately when it's no longer needed, rather than
2977 waiting until the end of the function.
2978 (copy_file): Don't bother calling isdir, as copy will do the
2979 right thing if the destination is a directory.
2981 * src/du.c (fts_debug, opt_all, apparent_size, opt_count_all,
2982 print_grand_total, opt_separate_dirs, hash_ins, process_file, main):
2983 Use bool for booleans.
2984 (max_depth): Now size_t, not int, to avoid an arbitrary limit
2985 of INT_MAX on depth.
2986 (G_fail): Remove: no longer needed, now that the relevant
2987 functions return bool.
2988 (process_file): Use return value to signal success rather than
2989 setting a global. Remove first_call static var; not needed, since
2990 we can look at n_alloc. Use size_t for depths. Remove FIXME
2991 about size_t casts, as it's now fixed. Use xnrealloc rather
2992 than the obsolescent XREALLOC. Don't bother to check whether
2993 reallocation is needed unless level > prev_level.
2994 (du_files): Invert sense of result, for consistency with
2995 other coreutils code. All callers changed.
2996 (main): Allow --max-depth values up to SIZE_MAX.
2998 * src/df.c (inode_format, show_all_fs, show_local_fs,
2999 show_listed_fs, posix_format, require_sync, print_type,
3000 selected_fstype, excluded_fstype, show_dev, show_point, main):
3001 Use bool for booleans.
3002 (df_readable, show_dev): Use UINTMAX_MAX instead of -1.
3003 (show_dev, show_point, main):
3004 Use EXIT_SUCCESS/EXIT_FAILURE instead of 0/1.
3005 Don't assume disk name lengths are <= INT_MAX.
3006 Rewrite pct calculation to avoid cast.
3007 (show_point): Don't assume resolved length is <= SSIZE_MAX.
3009 * src/cut.c (hash_int) [!defined UINTPTR_MAX]: Use size_t
3010 instead of uintptr_t.
3011 * src/shred.c (UINT_MAX_32_BITS): Remove.
3012 (word32): Remove. All uses changed to uint32_t.
3013 (isaac_seed_data): Remove unnecessary cast.
3014 * src/system.h (ptr_align): Use size_t; in practice, this is just as
3015 good as uintptr_t in checking for alignments, and has fewer
3016 configuration hassles.
3018 * src/Makefile.am (localedir.h): Make it readonly; this
3019 undoes part of the 2004-07-27 patch.
3021 2004-07-30 Paul Eggert <eggert@cs.ucla.edu>
3023 * src/sort.c (UCHAR): Remove; all uses changed to to_uchar.
3024 (IS_THOUSANDS_SEP): Use bool when appropriate.
3025 (numcompare, main): Use char, not int, when the value is always a char.
3026 (numcompare): Remove "register"; compilers are smart enough these days.
3027 * src/system.h (errno, CHAR_BIT): Remove decls;
3028 no longer needed now we assume C89 or better.
3029 Include <inttypes.h> before <stdint.h>, as it's the
3030 Autoconf-recommended pattern.
3031 (to_uchar): New inline function, moved here from tr.c.
3032 Use full names for int types, e.g. "long int" rather than "long".
3033 * src/tr.c (to_uchar): Remove; now in system.h.
3034 (is_char_class_member): Use bool when appropriate.
3036 * src/mkdir.c (create_parents, main): Use bool when appropriate.
3037 (main): Use EXIT_SUCCESS/EXIT_FAILURE instead of 0/1.
3039 2004-07-29 Paul Eggert <eggert@cs.ucla.edu>
3041 * src/mkfifo.c (main): Use EXIT_SUCCESS and EXIT_FAILURE, not 0 and 1.
3043 * src/chmod.c (recurse, force_silent, process_file, process_files,
3044 main): Use bool when appropriate.
3045 * src/cksum.c (cksum, main): Likewise.
3046 * src/comm.c (hard_LC_COLLATE, only_file_1, only_file_2, both,
3047 compare_files, main): Likewise.
3049 * src/copy.h (struct cp_options): Likewise.
3050 * src/copy.c (copy_internal, is_ancestor, copy_dir, copy_reg,
3051 same_file_ok, seen_file, copy_internal, valid_options, copy): Likewise.
3052 * src/cp-hash.h (remember_created): Likewise.
3053 * src/cp-hash.c (remember_created): Likewise.
3054 * src/cp.c (struct dir_attr, flag_path, remove_trailing_slashes,
3055 re_protect, make_path_private, target_directory_operand, do_copy,
3056 cp_option_init, decode_preserve_arg, main): Likewise.
3057 * src/install.c (isdir, change_timestamps, change_attributes,
3058 copy_file, install_file_to_path, install_file_in_dir,
3059 install_file_in_file, strip_files, dir_arg, cp_option_init, main,
3060 change_attributes, change_timestamps): Likewise.
3061 * src/mv.c (remove_trailing_slashes, rm_option_init,
3062 cp_option_init, do_move, movefile, main): Likewise.
3063 * src/remove.c (right_justify), full_filename_, AD_pop_and_chdir,
3064 AD_push, prompt, remove_dir): Likewise.
3065 * src/rm.c (rm_option_init, main): Likewise.
3067 * src/remove.c (top_dir, pop_dir, full_filename_):
3068 Use size_t for sizes.
3069 * src/cp.c (target_directory_operand): Do not clear *NEW_DST if stat
3070 succeeds. It's not necessary in that case, as *NEW_DST is always
3072 (do_copy): Rewrite slightly to avoid need for "unreachable" comment.
3073 (main): Use EXIT_SUCCESS, EXIT_FAILURE instead of 0, 1.
3074 * src/rm.c (main): Likewise.
3076 md5sum, sha1sum integer cleanups.
3078 * src/checksum.h: Don't include config.h, sys/types.h, stdio.h:
3080 (ALG_UNSPECIFIED): Remove.
3081 (ALG_MDT): Don't make it equal to CHAR_MAX + 1; this isn't necessary.
3082 * src/md5.c: Don't include any files other than checksum.h.
3083 * src/sha1sum.c: Likewise.
3084 * src/md5sum.c (OPENOPTS, have_read_stdin, status_only, warn,
3085 bsd_split_3, split_3, hex_digits, digest_file, digest_check, main):
3086 Use bool when appropriate.
3087 (digest_check): Increase limit of number of input lines to
3088 UINTMAX_MAX from INT_MAX. Diagnose any overflows of this counter.
3089 Use ngettext instead of hard-to-i18nize hardcoded stuff for plurals.
3091 2004-07-28 Paul Eggert <eggert@cs.ucla.edu>
3093 * src/cat.c (exit_status): Remove. Now done by passing a boolean
3095 (simple_cat, cat): Return true if successful. All callers changed.
3096 (simple_cat, cat, main): Use bool for booleans.
3097 (simple_cat): Use size_t for sizes.
3098 (cat, main): Use the same names for parameters that we use for
3099 long options, to avoid confusion. This inverts the sense of the
3100 show_tabs (formerly output_tabs) and number_nonblank
3101 (formerly numbers_at_empty_lines) variables.
3102 (main): Don't mess up (due to integer overflow) if we are given
3103 INT_MAX - INT_MIN + 1 options.
3104 [O_BINARY]: Don't invoke isatty unless the other options require it.
3105 (main): When deciding whether to use simple_cat, don't worry
3106 about binary option; it's irrelevant.
3108 * src/dcgen: Remove comments, trailing white space, and empty
3109 lines from the output strings, to save space.
3110 Use a narrower type like 'unsigned char' for line lengths, if
3112 Make the output variables static, not extern.
3114 * src/chgrp.c (parse_group): Require base 10 when parsing
3116 (main): int -> bool when appropriate.
3117 * src/chown.c (main): Likewise.
3118 * src/chown-core.c: Include inttostr.h.
3119 (UINT_MAX_DECIMAL_DIGITS, uint_to_string): Remove.
3120 (gid_to_name, uid_to_name): Use imaxtostr/umaxtostr
3121 instead of uint_to_string).
3122 (describe_change): Instead of an int flag, use a char *
3123 auxiliary; this avoids the need for casts.
3124 Assume free (NULL) works.
3125 (change_file_owner): Return true/false, not 0/-1, since
3126 we don't set errno. All callers changed.
3127 Use bool when appropriate.
3128 (chown_files): Likewise.
3129 * src/chown-core.h (chown_files): Likewise.
3131 * tests/chown/basic: Test for proper handling of uids like
3132 "010", which must be parsed as decimal.
3134 * tests/misc/pwd: Don't assume that Perl's getpwd agrees with our
3135 pwd when there are multiple names for the working directory
3136 (which can happen with an automounter, sigh).
3138 * src/Makefile.am ($(SCRIPTS)): Don't depend on Makefile;
3139 this causes Solaris 8 'make' to refuse to build "groups".
3140 (localedir.h): Don't depend on Makefile: this causes Solaris
3141 8 'make' to build localedir.h unnecessarily. The dependence
3142 on Makefile is ineffective anyway, since $(localedir) might
3143 change even if Makefile hasn't.
3145 * src/remove.c (remove_dir): If we can't save the state of the
3146 working directory, pretend we started from "/", not ".".
3147 This avoids a bug on hosts like Solaris that don't let you
3148 remove the working directory.
3150 2004-07-27 Paul Eggert <eggert@cs.ucla.edu>
3152 * src/printf.c (strtiomax, strtoumax): Declare if not already
3153 declared: this fixes a portability bug with Solaris 8 + GCC.
3154 (STRTOX): Parenthesize use of macro arg as expression.
3155 (vstrtoimax, vstrtoumax, vstrtold): Remove now-unnecessary
3157 * configure.ac: Check for declaration of strtoumax, for
3160 * src/Makefile.am (cp_LDADD, ginstall_LDADD, mv_LDADD,
3161 pathchk_LDADD, rm_LDADD, test_LDADD): New vars, for eaccess.
3163 * tests/readlink/can-e: Don't assume that we can remove the
3164 working directory: this isn't possible under Solaris 8, say.
3165 * tests/readlink/can-f: Likewise.
3166 * tests/readlink/can-m: Likewise.
3168 * src/copy.c (copy_internal): find_backup_file_name no longer
3169 returns NULL, so don't bother to check for this.
3170 * src/cp.c (do_copy): Likewise.
3171 * src/ln.c (do_link): Likewise.
3173 2004-07-25 Paul Eggert <eggert@cs.ucla.edu>
3175 * src/nice.c (GET_NICE_VALUE): Renamed from GET_PRIORITY.
3177 (NZERO): New macro, if system doesn't define it already.
3178 (usage): Distinguish priorities from nice values.
3179 Don't assume NZERO is 20.
3180 (main): Use bool instead of int where appropriate.
3181 If user specifies an adjustment out of range, always truncate it
3182 to an inrange value instead of sometimes giving an error message
3184 Do not assume that -1 is an error return from "nice" or
3185 "getpriority", as it might be the current nice value minus NZERO.
3186 If nice/setpriority fails with errno == EPERM, go ahead and run
3187 the command anyway; POSIX requires this.
3189 * src/pathchk.c: Include euidaccess.h.
3190 (dir_ok): Use euidaccess, not access.
3191 * src/test.c (R_OK, W_OK, X_OK, FOK): Remove; system.h defines them.
3192 (eaccess): Remove. All users changed to use euidaccess instead.
3194 2004-07-24 Paul Eggert <eggert@cs.ucla.edu>
3196 * src/uptime.c (print_uptime) [defined BOOT_MSG]:
3197 Don't assume ut_line is null-terminated.
3198 * src/who.c (print_line): New arguments USERLEN and LINELEN,
3199 since USER and LINE might not be null terminated. All callers
3202 2004-07-23 Paul Eggert <eggert@cs.ucla.edu>
3204 Fix bug with "tail -f" reported by Rob Holland in
3205 <http://lists.gnu.org/archive/html/bug-coreutils/2004-07/msg00054.html>.
3206 Also, remove the undocumented and unsupported-since-2000
3207 --max-consecutive-size-changes options. Fix another related bug:
3208 "tail" got confused if stdin, stdout, or stderr were closed.
3209 Also, use output buffering even with "tail -f".
3211 * NEWS: Document this, plus yesterday's patch.
3212 * doc/coreutils.texi (tail invocation): "size has remained the same"
3213 -> "file has not changed", which is more accurate for fifos.
3214 * src/tail.c: Include fcntl-safer.h.
3215 (COPY_TO_EOF): Set to UINTMAX_MAX, not OFF_T_MAX (which was wrong).
3216 (COPY_A_BUFFER): New macro.
3217 (struct File_spec): New members mtime, mode, blocking.
3218 Remove member n_consecutive_size_changes.
3219 (DEFAULT_MAX_N_CONSECUTIVE_SIZE_CHANGES,
3220 max_n_consecutive_size_changes_between_opens,
3221 MAX_CONSECUTIVE_SIZE_CHANGES_OPTION): Remove.
3222 (long_options, tail_forever, parse_options):
3223 Remove (non-)support for --max-consecutive-size-changes.
3224 (record_open_fd): New function.
3225 (recheck, tail_file): Use it. Don't assume that stdin is open.
3226 (dump_remainder): Add support for new COPY_A_BUFFER special value.
3227 Treat errno==EAGAIN like EOF, since it might be a nonblocking read.
3228 (recheck): New arg BLOCKING, specifying whether to use blocking reads.
3230 (n_live_files): Remove, replacing with...
3231 (any_live_files): New function. All uses changed.
3232 (tail_forever): Use nonblocking I/O unless we know that blocking I/O
3233 is safe; this avoids some hangs when reading from a fifo.
3234 Avoid invoking fstat or sleep when using blocking I/O.
3235 Do not check for changes to size if the file is not a regular file,
3236 as the size is undefined in that case.
3237 Check for changes to mtime or mode, too; this works for non-regular
3239 (tail_forever, main): Redo fflush strategy to work even when input
3240 is nonblocking. Don't use unbuffered output; just flush when needed.
3242 2004-07-22 Paul Eggert <eggert@cs.ucla.edu>
3244 * src/tail.c (main): Ignore -f if no file operand is specified
3245 and standard input is a pipe.
3246 * doc/coreutils.texi (tail invocation): Do not ignore -f for
3247 all pipes, just for when standard input is a pipe and no
3248 file operand is specified.
3249 * tests/tail/Test.pm: Reinstate f-1 test, since we now pass.
3250 Add a new commented-out f-2 test, which we still fail.
3251 (test_vector): All f-* tests are special cases, not just f-1.
3253 2004-07-12 Paul Eggert <eggert@cs.ucla.edu>
3255 * src/uptime.c: Include c-strtod.h.
3256 (print_uptime): Use c_strtod instead of setlocale and sscanf.
3257 Use long int rather than int to count days (for 64-bit hosts),
3258 and check for arithmetic overflow when converting double to time_t.
3260 2004-07-11 Paul Eggert <eggert@cs.ucla.edu>
3262 * src/printf.c (vstrtold): Renamed from vstrtod.
3263 Now returns long double. All uses changed.
3264 (print_direc): Use "L" length modifier when printing floating point
3265 numbers, since we're now printing long double.
3267 2004-07-06 Paul Eggert <eggert@cs.ucla.edu>
3269 printf cleanup, to avoid undefined behavior, to add support for
3270 formats that Bash supports, and to support wide integers like
3273 * NEWS: Document this.
3274 * src/printf.c (UNSPECIFIED): Remove. All uses now replaced by
3275 booleans, so that we don't reserve any values for precision or
3277 (STRTOX): Use prototype, not K&R-style definition.
3278 (vstrtoimax): Renamed from xstrtol (to avoid confusion with xstrtol
3279 in ../lib), with type change to intmax_t.
3281 (vstrtoumax): Renamed from xstrtoul, with type change to uintmax_t.
3283 (vstrtod): Renamed from xstrtod. All uses changed.
3284 (print_direc): Use boolean arg instead of special value to indicate
3285 a missing precision or width. LENGTH no longer includes
3286 length modifiers or conversion character. New arg CONVERSION
3287 now specifies conversion character.
3288 Use intmax_t-width formatting for integers (like Bash).
3289 Add support for C99 %a, %A, %F (like Bash).
3290 Add support for field width with %c (POSIX requires this).
3291 Add a FIXME for lack of support for field width and precision
3293 Add support for '\'', '0' flags.
3294 Check for invalid combinations of flags, field width, precision,
3295 and conversion, to prevent use of undefined behavior.
3296 Allow multiple length modifiers, for formats like "%lld" (like Bash).
3297 Add support for C99 'j', 't', 'z' length modifiers (like Bash).
3298 In error message, output entire invalid conversion specification,
3299 instead of merely outputting % followed by the conversion char.
3300 * tests/misc/printf: Add tests for the above.
3302 2004-04-03 Dmitry V. Levin <ldv@altlinux.org>
3304 Change "readlink -f" to be more compatible with prior implementations.
3305 Add more canonicalize options, -e and -m.
3306 Add comprehensive tests for all readlink modes.
3308 * m4/canonicalize.m4 (AC_FUNC_CANONICALIZE_FILE_NAME):
3309 Do not add canonicalize.c here.
3311 * src/readlink.c (longopts): Add new options.
3312 (usage): Document them.
3313 (canonicalize_fname): New proxy function.
3314 (main): Handle new options.
3315 * doc/coreutils.texi (readlink invocation): Document new
3316 "readlink -f" behaviour and new canonicalize options, -e and -m.
3318 * configure.ac (AC_CONFIG_FILES): Add tests/readlink/Makefile.
3319 * tests/Makefile.am (SUBDIRS): Add readlink.
3320 * tests/readlink/Makefile.am: New file.
3321 * tests/readlink/{rl-1,can-e,can-f,can-m}: New readlink tests.
3322 * tests/misc/Makefile.am (TESTS): Remove basic readlink test.
3323 * tests/misc/readlink: Remove file.
3325 2004-07-04 Jim Meyering <jim@meyering.net>
3327 * src/copy.c (copy_internal): Add a FIXME comment.
3329 2004-07-02 Paul Eggert <eggert@cs.ucla.edu>
3331 * src/copy.c (copy_dir): Assume path_concat returns non-NULL.
3332 * src/cp.c (do_copy): Likewise.
3333 * src/mv.c (movefile): Likewise.
3335 * src/cp.c (make_path_private): 2nd arg is now size_t, not int,
3336 to avoid problem when path_concat dir name is longer than 2 GiB (!).
3338 * src/nohup.c (main): Don't pass NULL first argument to path_concat.
3339 This cleans up the semantics a bit, as we no longer try to open the
3342 2004-07-01 Paul Eggert <eggert@cs.ucla.edu>
3344 * NEWS: Add short names -t and -T for --target-directory
3345 and --no-target-directory options, respectively.
3347 * src/cp.c (NO_TARGET_DIRECTORY_OPTION, TARGET_DIRECTORY_OPTION):
3348 Remove. All uses changed to 'T' and 't', respectively.
3349 * src/install.c, src/ln.c, src/mv.c: Likewise.
3351 * src/cp.c (long_opts, usage, do_copy, main): Add -t and -T as
3352 aliases for --target-directory and --no-target-directory,
3354 * src/install.c (long_options, main, usage): Likewise.
3355 * src/ln.c, src/mv.c: Likewise.
3357 2004-07-01 Jim Meyering <jim@meyering.net>
3359 * Makefile.maint (sc_file_system): New target.
3360 (syntax-check-rules): Add it.
3361 .x-sc_file_system: New file.
3362 * Makefile.am (EXTRA_DIST): Add it.
3364 * man/sync.x: Use "file system" rather than "filesystem".
3365 * man/stat.x, man/df.x: Likewise.
3367 2004-06-30 Paul Eggert <eggert@cs.ucla.edu>
3369 * src/df.c (usage, main): Output "file system" rather than
3371 * src/du.c (usage): Likewise.
3372 * src/shred.c (usage): Likewise.
3373 * src/stat.c (usage): Likewise.
3374 * src/stat.c (long_options, usage): Rename "--filesystem" to
3375 "--file-system". But keep the old name around, for compatibility
3378 2004-06-29 Paul Eggert <eggert@cs.ucla.edu>
3380 Add support for --no-target-directory option.
3382 * NEWS: Document it.
3383 * doc/coreutils.texi (Common options, Target directory, cp
3384 invocation, install invocation, mv invocation, ln invocation):
3386 (link invocation): Explain how to rewrite link using ln now
3387 that we have --no-target-directory.
3388 (ln invocation): Explain that --no-target-directory subsumes
3390 (unlink invocation): Modify wording to match new wording in
3393 * src/cp.c (NO_TARGET_DIRECTORY_OPTION): New constant.
3394 (long_opts, usage, do_copy, main): Add support for
3395 --no-target-directory,
3396 * src/install.c (NO_TARGET_DIRECTORY_OPTION, long_options, main,
3398 * src/ln.c (NO_TARGET_DIRECTORY_OPTION, long_options, usage,
3400 * src/mv.c (NO_TARGET_DIRECTORY_OPTION, long_options, usage,
3402 * src/mv.c (enum): Sort values.
3404 2004-06-29 Jim Meyering <jim@meyering.net>
3406 Don't let verbose-mode output from a subshell obscure actual differences.
3407 * tests/rm/inaccessible: Turn off command-echoing just before
3408 invoking subshell, then turn it back on if VERBOSE=yes afterward.
3410 2004-06-25 Paul Eggert <eggert@cs.ucla.edu>
3412 Add support for 'install --target-directory', an option
3413 that has been documented for years but not implemented (!).
3414 * doc/coreutils.texi (install invocation): Document
3415 --target-directory in synopsis, too.
3416 * src/install.c (TARGET_DIRECTORY_OPTION): New var.
3417 (long_options, main, usage): Add --target-directory.
3418 (target_directory_operand): New function, stolen from mv.c.
3419 (main): Use it. Check for -d and --target-directory.
3420 Alter wording of diagnostics to match other programs.
3422 2004-06-28 Jim Meyering <jim@meyering.net>
3424 * src/cp.c (usage): Fix copy+paste error in description of
3425 --target-directory: s/move/copy/. From Paul Jarc.
3427 2004-06-27 Paul Eggert <eggert@cs.ucla.edu>
3429 Use more-consistent rules among cp, ln, and mv when dealing with
3430 last operands that are (or look like) directories.
3432 * src/cp.c (target_directory_operand): New, nearly-common function,
3433 It reports an error if the destination appears to be a directory
3434 (e.g., because it has a trailing slash) but is not.
3435 * src/ln.c, src/mv.c: Likewise.
3436 * src/cp.c (do_copy): Use it.
3437 * src/ln.c (main): Likewise.
3438 * src/mv.c (main): Likewise.
3440 * src/cp.c (do_copy): Don't assume argc is positive.
3441 Don't bother to lstat dest, since copy() will do that for us.
3442 Use "const" to avoid the need for cast.
3444 * src/cp.c (do_copy): Don't output a usage message because of file
3445 problems (e.g., an operand is not a directory). Use it only for
3446 syntax. Standardize on "target %s is not a directory" for the
3448 * src/ln.c (main): Likewise.
3449 * src/mv.c (main): Likewise.
3451 * src/cp.c (do_copy): Remove test for trailing slash, since
3452 target_directory_operand now does this.
3453 * src/ln.c (main): Likewise.
3454 * src/mv.c (movefile): Likewise.
3456 * src/cp.c (main): Reject multiple target directories.
3457 Check whether a specified target is a directory when parsing the
3458 options, using stat. This gives more-accurate diagnostics.
3459 * src/ln.c (main): Likewise.
3461 * src/ln.c (isdir): Remove decl; no longer needed.
3462 * src/mv.c (isdir, lstat): Likewise.
3464 * src/ln.c (do_link): New arg dest_is_dir. All uses changed.
3465 Don't check the destination ourself; rely on dest_is_dir.
3466 This way we can avoid lstatting the destination in the
3467 usual case, and in the worst case we lstat 1, not 3 times.
3468 Don't bother to unlink unless link failed; this saves a syscall.
3469 Remove unnecessary backup_succeeded flag;
3470 it was identical to "dest_backup != NULL".
3472 * src/ln.c (main): Use int to count to argc, not unsigned int.
3473 This handles negative operand counts.
3474 * src/mv.c (main): Likewise.
3476 * src/mv.c (do_move): Don't call hash_init; expect the caller to
3477 do it, for consistency with cp.c and ln.c. All callers changed.
3478 (movefile): dest_is_dir parameter is now bool, not int.
3479 (main): Standardize on "missing destination file operand after %s"
3480 for the diagnostic, for consistency with cp.c.
3482 * tests/mv/diag: Don't assume "mv --target=nonexistentdir"
3483 will complain about the arg count.
3484 Adjust to new (briefer) diagnostics.
3485 * tests/cp/fail-perm: Add a test to verify that we get the new
3486 diagnostic when failing to copy through a symlink-to-inaccessible-dir.
3488 2004-06-27 Paul Eggert <eggert@cs.ucla.edu>
3490 Fix a bug: formerly, if d/x was a directory and x a file, "ln x
3491 d/" incorrectly created a link d/x/x. It also saves some system
3494 * NEWS: Document the fix.
3496 * src/ln.c (main): Don't append basename to dest if this
3497 results in an existing directory name.
3498 * tests/ln/misc: See whether a trailing slash is followed too far.
3500 2004-06-26 Jim Meyering <jim@meyering.net>
3502 * src/printf.c (main): When given no arguments, print the standard
3503 "missing operand\nTry printf --help..." message -- to be consistent.
3505 2004-06-26 Jim Meyering <jim@meyering.net>
3507 * src/mknod.c (main): Add \n at the end of message output via fprintf.
3509 2004-06-25 Jim Meyering <jim@meyering.net>
3511 * tests/ln/misc: Add test for ln subscript error.
3513 2004-06-23 Paul Eggert <eggert@cs.ucla.edu>
3515 * src/ln.c (do_link): Remove unnecessary call to lstat.
3516 (main): Avoid subscript error when the destination is "".
3518 2004-06-23 Jim Meyering <jim@meyering.net>
3520 * tests/*: Replace all occurrences of `(exit N); exit' with
3521 `(exit N); exit N'. Otherwise, those many tests could exit with
3522 improper exit status when exiting via e.g., a trapped interrupt.
3523 Thanks to a report from Bob Proulx.
3525 2004-06-22 Paul Eggert <eggert@cs.ucla.edu>
3527 * src/who.c (idle_string, print_user): New arg boottime,
3528 specifying the most recent boot time. All uses changed.
3529 (idle_string) Consider a line to be "old" if it hasn't been used
3530 since the last boot time. Watch out for overflow when computing
3531 times, and for times in the future.
3532 (idle_string): Record latest boot time.
3534 2004-06-22 Jim Meyering <jim@meyering.net>
3536 * src/test.c (usage): Correct description of `-t FD'. The file
3537 descriptor, FD, is no longer optional. Reported by Ton Nijkes.
3539 2004-06-21 Paul Eggert <eggert@cs.ucla.edu>
3541 The 2004-06-19 fix for who and pinky was incomplete, as ctime
3542 has undefined behavior if the year precedes -999 or follows 9999.
3543 Since we have to stop using ctime anyway, we might as well use
3544 strftime and fix the FIXME, and support internationalized dates.
3546 * NEWS: Document the new behavior.
3547 * src/who.c: Include "hard-locale.h".
3548 (time_format, time_format_width): New vars.
3549 (time_string, print_line): Use them.
3551 (time_string): Use localtime + strftime instead of
3552 ctime, to avoid problems with years before -999 or after 9999.
3553 * src/pinky.c: Likewise.
3555 2004-06-21 Paul Eggert <eggert@cs.ucla.edu>
3557 Fix bug: GNU 'ls' didn't count columns correctly if user or group
3558 names contained multibyte characters where the column count
3559 differed from the byte count. This patch also corrects
3562 * src/ls.c (format_user_or_group): New function, which counts
3564 (format_user, format_group): Use it.
3565 (format_user_or_group_width): New function, which counts columns
3567 (format_user_width, format_group_width): Use it.
3569 2004-06-21 Jim Meyering <jim@meyering.net>
3571 * tests/priv-check: Quote "$PATH" in PATH=$PATH.
3572 Suggestion from Andreas Schwab.
3574 * tests/priv-check: When running as root, be sure to propagate
3575 PATH through to the process we exec as non-root.
3576 Reported by michael@aplatform.com.
3578 * src/mknod.c (main): Don't segfault when calculating the
3579 expected number of operands for `mknod NAME'.
3581 2004-06-20 Jim Meyering <jim@meyering.net>
3583 * src/dd.c (input_seek_errno): Declare file-scoped variable as static.
3585 2004-06-20 Paul Eggert <eggert@cs.ucla.edu>
3587 * src/basename.c (main):
3588 Standardize on the diagnostics given when someone gives
3589 too few operands ("missing operand after `xxx'") or
3590 too many operands ("extra operand `xxx'").
3591 Include "quote.h" and/or "error.h" if it wasn't already being included.
3592 * src/chgrp.c (main): Likewise.
3593 * src/chmod.c (main): Likewise.
3594 * src/chown.c (main): Likewise.
3595 * src/chroot.c (main): Likewise.
3596 * src/comm.c (main): Likewise.
3597 * src/cp.c (do_copy): Likewise.
3598 * src/csplit.c (main): Likewise.
3599 * src/date.c (main): Likewise.
3600 * src/dircolors.c (main): Likewise.
3601 * src/dirname.c (main): Likewise.
3602 * src/du.c (main): Likewise.
3603 * src/expr.c (main): Likewise.
3604 * src/hostid.c (main): Likewise.
3605 * src/hostname.c (main): Likewise.
3606 * src/id.c (main): Likewise.
3607 * src/install.c (main): Likewise.
3608 * src/join.c (add_file_name, main): Likewise.
3609 * src/link.c (main): Likewise.
3610 * src/ln.c (main): Likewise.
3611 * src/logname.c (main): Likewise.
3612 * src/md5sum.c (main): Likewise.
3613 * src/mkdir.c (main): Likewise.
3614 * src/mkfifo.c (main): Likewise.
3615 * src/mknod.c (main): Likewise.
3616 * src/mv.c (main): Likewise.
3617 * src/nohup.c (main): Likewise.
3618 * src/od.c (main): Likewise.
3619 * src/pathchk.c (main): Likewise.
3620 * src/ptx.c (main): Likewise.
3621 * src/readlink.c (main): Likewise.
3622 * src/rm.c (main): Likewise.
3623 * src/rmdir.c (main): Likewise.
3624 * src/seq.c (main): Likewise.
3625 * src/setuidgid.c (main): Likewise.
3626 * src/shred.c (main): Likewise.
3627 * src/sleep.c (main): Likewise.
3628 * src/sort.c (main): Likewise.
3629 * src/split.c (main): Likewise.
3630 * src/stat.c (main): Likewise.
3631 * src/test.c (beyond, main): Likewise.
3632 * src/touch.c (main): Likewise.
3633 * src/tr.c (main): Likewise.
3634 * src/tsort.c (main): Likewise.
3635 * src/tty.c (main): Likewise.
3636 * src/uname.c (main): Likewise.
3637 * src/uniq.c (main): Likewise.
3638 * src/unlink.c (main): Likewise.
3639 * src/uptime.c (main): Likewise.
3640 * src/users.c (main): Likewise.
3641 * src/who.c (main): Likewise.
3642 * src/whoami.c (main): Likewise.
3644 * tests/basename/basic: Adjust to new diagnostics.
3645 * tests/du/files0-from: Likewise.
3646 * tests/expr/basic: Likewise.
3647 * tests/mv/diag: Likewise.
3648 * tests/tsort/basic-1: Likewise.
3650 2004-06-20 Jim Meyering <jim@meyering.net>
3652 * src/ln.c: Remove declaration of yesno.
3653 Instead, include yesno.h.
3654 * src/copy.c: Likewise.
3656 * src/remove.c: Remove declaration of yesno.
3657 Instead, include yesno.h.
3658 (top_dir): Remove now-unnecessary cast of obstack_base.
3659 (pop_dir): Likewise.
3660 (full_filename_): Likewise.
3662 2004-06-19 Paul Eggert <eggert@cs.ucla.edu>
3664 Don't dump core if ctime returns NULL; this is possible on
3665 hosts with 64-bit time_t and 32-bit int.
3666 * src/who.c: Include "inttostr.h".
3667 (time_string): If ctime fails, print the raw time as an integer
3668 instead of dumping core.
3669 * src/pinky.c: Likewise, as follows:
3670 Include "inttostr.h".
3671 (time_string): New function, copied from who.c.
3672 (print_entry): Use it.
3674 2004-06-19 Paul Eggert <eggert@cs.ucla.edu>
3676 * src/who.c (print_line): Don't truncate user names at 8 bytes.
3677 Problem reported by Guido Leenders in:
3678 http://lists.gnu.org/archive/html/bug-coreutils/2004-06/msg00056.html
3679 * NEWS: document this.
3681 2004-06-19 Jim Meyering <jim@meyering.net>
3683 * src/system.h (case_GETOPT_VERSION_CHAR): Switch back to
3684 using GNU_PACKAGE (from PACKAGE) once again. This restores
3685 `GNU' to the parenthesized package name in --version output.
3686 Before, the first argument from AC_INIT, `GNU coreutils', would
3687 be propagated to the PACKAGE variable. Now, `GNU ' is trimmed.
3688 Reported by Richard Stallman.
3690 2004-06-17 Jim Meyering <jim@meyering.net>
3692 * src/tr.c (to_uchar): Rename function from `uchar'. The latter
3693 would clash with a typedef in Tru64's <sys/types.h>. From Albert Chin.
3695 2004-06-15 Paul Eggert <eggert@cs.ucla.edu>
3697 * NEWS: Remove more special cases for POSIXLY_CORRECT when POSIX
3698 allows the GNU behavior. "--" is now supported by chroot, hostid,
3699 hosname, pwd, sync, yes.
3700 * doc/coreutils.texi (yes invocation, false invocation,
3701 true invocation): Document this.
3702 * src/chroot.c (main): Handle "--".
3703 * src/hostid.c (main): Likewise.
3704 * src/hostname.c (main): Likewise.
3705 * src/pwd.c (main): Likewise.
3706 * src/sync.c (main): Likewise.
3707 * src/yes.c (main): Likewise.
3708 * src/true.c (main): Recognize --help and --version even if
3709 POSIXLY_CORRECT is set.
3710 * src/yes.c (main): Likewise.
3712 2004-06-09 Paul Eggert <eggert@cs.ucla.edu>
3714 * NEWS: Remove special cases for POSIXLY_CORRECT when POSIX allows
3716 * doc/coreutils.texi (pr invocation, unlink invocation): Document this.
3717 * src/ls.c (decode_switches): Pay attention to TABSIZE even if
3718 POSIXLY_CORRECT is set. POSIX reserves upper-case environment
3719 variables to the implementation, so it's OK for ls to depend on
3721 * src/pr.c: Include "hard-locale.h".
3722 (main): When in a non-POSIX locale, ignore POSIXLY_CORRECT, since
3723 POSIX specifies the behavior only in the POSIX locale.
3724 * src/printf.c (print_esc): Support \x, \u, \U even if POSIXLY_CORRECT,
3725 since POSIX says the behavior is unspecified here.
3726 * src/tail.c (parse_obsolescent_option): Support multiple file operands
3727 even if POSIXLY_CORRECT, since POSIX does not require a diagnostic.
3728 * src/printf.c (main): Recognize --help, --version even if
3729 POSIXLY_CORRECT. POSIX does not specify any options, but it
3730 does not prohibit options either, so "printf" is like "expr" here.
3731 * src/unlink.c (main): Likewise.
3732 * tests/misc/printf: Adjust to the new semantics for \x if
3735 2004-06-14 Jim Meyering <jim@meyering.net>
3737 * tests/misc/pwd: New test, for fix of 2004-04-19.
3738 * tests/misc/Makefile.am (TESTS): Add pwd.
3739 (BUILD_SRC_DIR): Define BUILD_SRC_DIR.
3741 * src/copy.c: Remove declaration of euidaccess.
3742 Instead, include "euidaccess.h".
3744 2004-06-13 Paul Eggert <eggert@cs.ucla.edu>
3746 * src/who.c (PIDSTR_DECL_AND_INIT): Don't assume pid_t fits in int.
3747 (UT_ID) [!HAVE_STRUCT_XTMP_UT_ID]: Remove bogus comment,
3748 as (sizeof "??") reliably returns 3.
3749 (print_line): Guard against idle and pid being too long
3750 (which is possible when printing headers).
3751 (print_user): Allocate enough bytes for idlestr. Use IDLESTR_LEN.
3752 Avoid unnecessary cast of sizeof to int.
3753 (make_id_equals_comment): Do not assume that UT_ID returns
3754 a string; it might return a non-null-terminated array.
3755 Use strncat instead. It's not very often where strncat is
3756 exactly what you want, but this is one of those rare cases.
3758 2004-06-11 Paul Eggert <eggert@cs.ucla.edu>
3760 * src/who.c (list_entries_who): Don't output a trailing space.
3762 2004-06-09 Jim Meyering <jim@meyering.net>
3764 * src/touch.c (usage): Improve wording in description of the
3765 --time=WORD option. Reported by Dan Jacobson.
3767 * src/chown-core.c (change_file_owner): Change names of parameters
3768 old_uid and old_gid to required_uid and required_gid respectively.
3770 * src/chmod.c (mode_changed): Return false, not 0, now that the
3771 function returns `bool'.
3773 2004-06-08 Paul Eggert <eggert@cs.ucla.edu>
3775 Adjust chmod and chown to be similar if -c or -v are given. In
3776 particular, a no-op chown is no longer reported as a change; this
3777 reverts to previous behavior. Also, fix both commands so that -v
3778 report failures even if the failure is not due to the chmod or
3781 * src/chmod.c (CH_NOT_APPLIED): New constant.
3782 (describe_change): Handle it.
3783 (process_file): Use it, if a symlink wasn't changed.
3784 (mode_changed): Return bool, not int. Accept new argument
3785 NEW_MODE; all callers changed. This lets us avoid statting the
3786 file unless the new mode has unusual bits.
3787 (process_file): Return -1 on error. With -v, report all errors
3788 verbosely, not just some.
3790 * src/chown-core.c (change_file_owner): Return -1 on error, not
3791 1 sometimes and -1 on others. Our caller ORs together our results,
3792 and (-1 | 1) == 0 on ones-complement hosts.
3793 With -v report all errors verbosely, not just some.
3794 Fix bug when chopt->root_dev_ino && !chopt->affect_symlink_referent:
3795 file_stats wasn't set properly in that case.
3797 * tests/chgrp/basic: Adjust to above changes.
3799 2004-05-20 Paul Eggert <eggert@cs.ucla.edu>
3801 * tests/chgrp/basic: Test that chgrp -h does not fail on
3802 symlinks, even on hosts where that's not supported.
3803 Test that if -R is specified without -H or L, -h is assumed.
3804 Test that chown() is not optimized away.
3806 2004-05-18 Paul Eggert <eggert@cs.ucla.edu>
3808 Several fixes to chgrp and chown for compatibility with POSIX and BSD:
3810 Check for incompatible options. When -R and --dereference are
3811 both used, then either -H or -L must also be used. When -R and -h
3812 are both used, then -P must be in effect.
3814 -H, -L, and -P have no effect unless -R is also specified.
3815 If -P and -R are both specified, -h is assumed.
3817 Do not optimize away the chown() system call when the file's owner
3818 and group already have the desired value. This optimization was
3819 incorrect, as it failed to updated the last-changed time and reset
3820 special permission bits, as POSIX requires.
3822 Do not report an error if the owner or group of a
3823 recursively-encountered symbolic link cannot be updated because
3824 the file system does not support it.
3826 * NEWS: Document the above.
3828 * src/chgrp.c (main): Check for incompatible options. -R --dereference
3829 requires either -H or -L, and -R -h requires -P. If -H, specify
3830 FTS_PHYSICAL as well as FTS_COMFOLLOW; this is faster. Make this
3831 file as much like chown.c as possible.
3832 * src/chown.c (main): Likewise.
3834 * src/chown-core.c (change_file_owner): Use ent->fts_statp only if
3835 needed. Chown a directory only after chowning its children; this
3836 avoids problems if the new directory ownership doesn't permit
3837 access to the children. Dereference symlinks before doing
3838 ROOT_DEV_INO_CHECK, not after, so that we catch symlinks to /.
3839 Do not optimize away the chown() system call when the file's owner
3840 and group already have the desired value. POSIX does not permit
3841 this optimization. Rely on chown and lchown to do the right
3842 thing with symlinks and/or -1 arguments, now that we have wrappers
3843 to do this. Use ENOTSUPP not ENOSYS, and ignore all ENOTSUPP
3844 errors, not just command-line errors.
3845 (chown_files): Pass FTS_NOSTAT to xfts_open if we don't need file status.
3847 * src/system.h (ENOTSUP): Remove.
3849 * tests/chgrp/basic: Use chown --from to discover whether the
3850 group changed, since chgrp now changes unconditionally. This
3851 complicates the sed script a bit. Do not specify --dereference,
3852 since it's the default (and we want to test this). Adjust output
3853 to match the fact that chgrp no longer optimizes the case of
3854 changing a file's group to the same value as before.
3855 * tests/chgrp/posix-H: Do not attempt to combine -h and -H; these
3856 options are incompatible, and their behavior is undefined with POSIX.
3857 (changed, not_changed): Adjust to match the fact that -h is no longer
3858 specified. Sort names.
3859 * tests/chown/deref: Adjust error-diagnostic spelling to match new
3862 2004-06-07 Paul Eggert <eggert@cs.ucla.edu>
3864 * src/uname.c (main): Fix typo introduced on 2003-05-10 that
3865 prevented a diagnostic of any operands.
3867 2004-06-08 Jim Meyering <jim@meyering.net>
3869 * src/shred.c (direct_mode): Turn it on/off with directio, too.
3871 2004-06-07 Jim Meyering <jim@meyering.net>
3873 Enable direct-mode I/O (bypassing the buffer cache), if possible.
3874 Prompted by a suggestion from Kalle Olavi Niemitalo
3875 in http://bugs.debian.org/207035.
3876 * src/shred.c (direct_mode): New function.
3877 (do_wipefd): Turn on direct-mode I/O.
3878 (dopass): If a file's first write fails with EINVAL,
3879 turn off direct-mode I/O and retry the write.
3881 2004-06-05 Paul Eggert <eggert@cs.ucla.edu>
3883 * src/tr.c (main): "tr -d a b" is now a fatal error even if
3884 POSIXLY_CORRECT is set. The POSIX SYNOPSIS does not allow this
3887 2004-06-04 Paul Eggert <eggert@cs.ucla.edu>
3889 * src/shred.c (dopass): Don't subtract 1 from the offset after
3890 a write error. Problem reported by Jon Peatfield in:
3891 http://lists.gnu.org/archive/html/bug-coreutils/2004-06/msg00020.html
3893 2004-06-02 Paul Eggert <eggert@cs.ucla.edu>
3895 Fix bug reported by Buciuman Adrian in
3896 <http://mail.gnu.org/archive/html/bug-coreutils/2003-08/msg00105.html>
3897 where 'dd' created a file that was too large. The bug was that dd
3898 assumed that the input file offset does not advance after a failed
3899 read; but POSIX says that the input file offset is undefined after
3902 * src/dd.c (MAX_BLOCKSIZE): New macro.
3903 (input_seekable, input_seek_errno, input_offset,
3904 input_offset_overflow): New vars.
3905 (scanargs): Reject block sizes greater than MAX_BLOCKSIZE.
3906 (advance_input_offset): New function.
3907 (skip_via_lseek): Set errno to zero when reporting our failure,
3908 so that we don't report based on garbage errno.
3909 (skip): If fdesc is standard input, advance the input offset.
3910 Do not quit if reading, and if noerror was specified;
3911 POSIX seems to require this.
3912 If read fails on output file, report the earlier lseek failure
3913 instead; this fixes a FIXME in dd_copy.
3914 (advance_input_after_read_error): New function.
3915 (dd_copy): Use it, instead of assuming that failed reads
3916 do not advance the file pointer. Advance input offset
3917 after nonfailed reads. Advance only a partial block if
3918 the previous read (before the failed read) succeeded, and
3919 do not generate an output block of zeros in this case.
3920 (main): Determine initial input offset, seekability of input,
3921 and error if it wasn't seekable.
3923 2004-06-02 Jim Meyering <jim@meyering.net>
3925 rm (without -f) could hang unnecessarily when attempting to
3926 remove a symlink to a file on an off-line NFS-mounted partition.
3927 Reported by David Howells in https://bugzilla.redhat.com/124699.
3928 * src/remove.c (write_protected_non_symlink): New function.
3929 Don't invoke euidaccess on symlinks.
3930 (prompt): Use write_protected_non_symlink rather than using
3931 euidaccess directly, being careful not to call lstat twice for a file.
3933 Fix a bug in how the --output-delimiter=D option works with
3934 abutting byte or character ranges. Reported by David Krider in
3935 http://lists.gnu.org/archive/html/bug-coreutils/2004-05/msg00132.html
3936 * src/cut.c (print_kth): Remove special case for open-ended range.
3937 (set_fields): Record the range start index for an interval even
3938 when it abuts another interval on its low side.
3939 Also record the range start index of the longest right-open-interval.
3940 * tests/cut/Test.pm: Add tests of --output-delimiter=S with
3941 abutting and overlapping byte ranges.
3943 2004-06-01 Paul Eggert <eggert@cs.ucla.edu>
3945 Some POSIX-conformance cleanups for tr.
3947 * src/tr.c (posix_pedantic): Remove; no longer needed since
3948 we need to test this in just one place now.
3949 (usage): Mention -C.
3950 (unquote): Note that \055, \n, etc are escaped.
3951 Do not worry about POSIXLY_CORRECT when warning about ambiguous
3953 \ at end of string stands for itself.
3954 Do not diagnose invalid backslash escapes: POSIX says the behavior
3955 is unspecified in this case, so we don't need to diagnose it.
3956 (main): Add support for -C (currently an alias for -c).
3957 Do not diagnose 'tr [:upper:] [:upper:], as POSIX does not require
3959 * tests/tr/Test.pm: New tests bs-055, bs-at-end, repeat-Compl.
3960 Fix comment for range-a-a.
3962 2004-05-25 Paul Eggert <eggert@cs.ucla.edu>
3964 Improve the efficiency (and in one case, correctness) of code
3965 that reads symlinks.
3967 * src/copy.c (copy_internal): Don't use alloca, as it can mess up
3968 royally if the link length is long (e.g., GNU/Hurd). Use
3969 xreadlink instead, it's safer. Don't bother to read the link if
3970 it's the wrong size. Add a FIXME because this area is a bit murky
3972 * src/ls.c (get_link_name): Update use of xreadlink.
3973 * src/readlink.c (main): Likewise.
3974 * src/stat.c (print_stat): Likewise.
3976 2004-06-01 Jim Meyering <jim@meyering.net>
3978 * src/env.c (main): Prefer the notation `STREQ (a, b)'
3979 over `!strcmp (a, b)'.
3980 * src/sort.c (main, sort_buffer_size): Prefer the notation
3981 `STREQ (a, b)' over `strcmp (a, b) == 0'.
3982 * src/date.c (batch_convert): Likewise.
3983 * src/expr.c (nextarg): Likewise.
3984 * src/su.c (correct_password, restricted_shell, main): Likewise.
3985 * src/ptx.c (swallow_file_in_memory, main): Likewise.
3986 * src/test.c (binary_operator, and, or, main): Likewise.
3988 2004-05-13 Paul Eggert <eggert@cs.ucla.edu>
3990 * NEWS: echo compatibility cleanup.
3991 * doc/coreutils.texi (echo invocation): Document the changes.
3992 * src/echo.c (V9_ECHO): Remove; always enabled.
3993 (DEFAULT_ECHO_TO_XPG): Renamed from V9_DEFAULT, so that
3994 we use the same naming convention as bash. Now an enum,
3996 (usage): Reword to mention -e/-E more accurately.
3997 Mention \0NNN (the POSIX syntax) rather than \NNN (nonstandard).
3998 (hextobin): New function.
3999 (main): Use bool rather than int for local vars when appropriate.
4000 Do not allow options if POSIXLY_CORRECT, unless we are using
4001 BSD semantics and the first argument is "-n".
4002 Don't pass unnecessary extra arg to parse_long_options.
4003 do_v9 now defaults to DEFAULT_ECHO_TO_XPG, not to allow_options.
4004 Do not look for options if !allow_options.
4005 Use size_t rather than int when appropriate.
4006 Open-code option test rather than using strrchr.
4007 Use faster test for "-".
4008 Avoid redundant argc test.
4009 Add support for \x, for Bash compatibility.
4010 Use e.g. '\a' rather than '\007', for portability to EBCDIC hosts.
4011 When '\c' is encountered, stop printing immediately, as POSIX
4013 Add support for \xhh syntax.
4014 Add support for \0ooo syntax; POSIX requires this.
4016 2004-06-01 Jim Meyering <jim@meyering.net>
4018 * Use automake-1.8b. Regenerate dependent files.
4020 2004-05-31 Jim Meyering <jim@meyering.net>
4022 * tests/Makefile.am.in (TESTS_ENVIRONMENT): Define PATH to include
4023 the build src/ directory -- at the front.
4024 ($(srcdir)/$x-tests): Depend on Makefile.am.
4025 Use $x as the program name, except when it would be `test' (test is
4026 the sole program tested via mk-script that is also a shell built-in).
4027 In that case, use the old ../../src/$x.
4029 2004-05-30 Jim Meyering <jim@meyering.net>
4031 Work around HPUX /bin/cc compiler bug that is exposed, now that
4032 sets are arrays of type `bool'. More details here:
4033 http://lists.gnu.org/archive/html/bug-gnulib/2004-05/msg00094.html
4034 FIXME: verify that the above URL points to the right message
4036 * src/tr.c (card_of_complement): Use cleaner `sizeof in_set'
4037 rather than `N_CHARS * sizeof(in_set[0])'. Using HPUX's /bin/cc
4038 (aC++/ANSI C B3910B A.05.55 [Dec 04 2003]) on an ia64-hp-hpux11.22
4039 system, those two expressions are not the same (256 vs. 1024).
4040 The effect of this problem was that `tr -c x y' would fail:
4041 tr: when not truncating set1, string2 must be non-empty
4042 (set_initialize): Remove unnecessary initialization of the `in_set'
4043 buffer; that initialization triggered the same compiler bug as above.
4045 2004-05-29 Paul Eggert <eggert@cs.ucla.edu>
4047 tr cleanup, mostly having to do with integer type ranges.
4050 * tests/tr/Test.pm: Add a few tests for the below. Alas, most of
4051 the test cases wouldn't be portable, or would take too much CPU
4054 * src/tr.c (N_CHARS, N_CHAR_CLASSES): Now an enum, not a macro.
4055 This is safe since the code already assumes N_CHARS fits in int.
4056 (Filter): Remove: we want to prototype everything.
4057 (ORD, CHR): Remove. All uses removed. Some replaced with:
4058 (uchar): New function. All places where a char must be converted
4059 to an unsigned char are now done this way, not by ad-hoc methods.
4060 (count): New type. Use it whenever counts or states are needed.
4061 (BEGIN_STATE): Increase from INT_MAX - 1 (which was bogus, anyway,
4062 since we used it in an unsigned int context) to UINTMAX_MAX - 1.
4063 (REPEAT_COUNT_MAXIMUM): New macro. Use it in place of BEGIN_STATE
4064 whenever appropriate.
4065 (NOT_A_CHAR): Remove global macro; now a local enum.
4066 (UL_LOWER, UL_UPPER, UL_NONE): No longer specify values, since
4067 the rest of the code no longer depends on them.
4068 (class_ok): Remove; all uses changed to use inline comparisons.
4069 (RE_NO_TYPE): Remove; wasn't used or needed.
4070 (struct List_element): normal_char and equiv_code are now unsigned
4072 first_char, last_char, and the_repeated_char are now unsigned char,
4073 not unsigned int. repeat_count is now count, not size_t.
4075 (struct Spec_list): state is now count, not unsigned int.
4076 lengthis now count, not size_t.
4077 n_indefinite_repeats is now size_t, not int.
4078 has_equiv_class, has_char_class, and has_restricted_char_class
4079 are now bool, not int. All uses changed.
4080 (struct E_string): s is now char *, not unsigned char *.
4081 escaped is now bool *, not int *. All uses changed.
4082 (ES_MATCH): Remove macro, replacing with:
4083 (es_match): New inline function. All uses changed.
4084 (squeeze_repeats, complement, posix_pedantic, truncate_set1,
4085 translating): Now bool, not int.
4086 (io_buf): Now char array, not unsigned char.
4087 (SET_TYPE): Remove. All uses replaced with bool.
4088 (is_equiv_class_member, unquote, append_range, append_char_class,
4089 append_equiv_class, find_closing_delim, star_digits_closebracket,
4090 build_spec_list, parse_str, homogeneous_spec_list):
4091 Now returns bool, not int. All uses changed.
4092 (is_equiv_class_member): Now inline.
4093 (is_equiv_class_member, is_char_class_member, make_printable_str,
4094 append_normal_char, append_range, append_repeated_char,
4096 Args are now of proper integer type.
4097 (unquote, look_up_char_class, make_printable_str,
4098 append_equiv_class, build_spec_list, squeeze_filter):
4099 Avoid unsigned char *p; gently convert *p to unsigned char instead.
4100 (unquote, get_spec_stats): Do not jump past declarations and then
4101 use them; C doesn't allow this in portable programs.
4102 (make_printable_str): Check for overflow in size calculations.
4103 (xmemdup): Remove. All uses rewritten.
4104 (find_bracketed_repeat): Args are now of proper pointer-to-integer
4105 type. Do not reject [c*0]. Use xstrtoumax, not xstrtoul.
4106 (find_bracketed_repeat, star_digits_closebracket): Check that the
4107 digits are not escaped.
4108 (build_spec_list): Don't bother to copy opnd_str; not needed.
4109 (build_spec_list, get_next): Simplify internal logic a bit.
4110 (card_of_complement): Fix bug due to char overflow.
4111 (get_spec_stats): Don't assume len fits into int.
4112 Check for integer overflow. Use abort() rather than assert(0).
4113 (string2_extend): Fix subscript error: is_char_class_member (..., 255)
4115 (squeeze_filter): READER is never null now; simplify code.
4116 READER arg now has a simpler type. Remove unnecessary casts.
4117 (squeeze_filter, main): Calls to fwrite improperly checked result
4118 against zero, rather than against requested size.
4119 (plain_read): New function.
4120 (read_and_delete, read_and_xlate):
4121 Remove unused filter arg, and don't worry about hit_eof.
4122 Simplify by using plain_read.
4123 (set_initialize): Args are bool and bool *, not int and SET_TYPE *.
4124 (main): Always pass a non-null procedure to squeeze_filter.
4125 Rewrite so that class_ok isn't needed.
4127 2004-05-29 Paul Eggert <eggert@cs.ucla.edu>
4129 * src/shred.c (dosync): Ignore EBADF errors, as IRIX 6.5
4130 fdatasync reports EBADF when syncing (unwritable) directories.
4131 Problem reported by Albert Chin-A-Young in:
4132 http://lists.gnu.org/archive/html/bug-coreutils/2004-05/msg00165.html
4134 2004-05-29 Jim Meyering <jim@meyering.net>
4136 * tests/chown/deref: Fix typo: use ls -ldo, not ls -ldg.
4137 Patch from Albert Chin.
4139 * src/ptx.c (text_buffer_maxend): Remove declaration of unused variable.
4141 * src/remove.c (push_dir): Merge declaration and adjacent assignment
4142 into a single statement.
4144 2004-05-28 Jim Meyering <jim@meyering.net>
4146 * src/remove.c (AD_mark_helper): Eliminate an unnecessary comparison.
4148 2004-05-22 Jim Meyering <jim@meyering.net>
4150 rm -r would get a failed assertion when run from an inaccessible
4151 directory and with two or more command line arguments including an
4152 absolute-named directory followed by a relative-named directory.
4154 * src/remove.h (struct rm_options) [require_restore_cwd]: New member.
4155 * src/remove.c (struct cwd_state): Define.
4156 (AD_pop_and_chdir): Redesign interface so that a restore_cwd failure
4157 can be detected by the caller. Instead of returning a malloc'd
4158 directory name, communicate it to caller via a new parameter, and
4159 return an indication of whether restore_cwd failed. Update caller.
4160 Eliminate an unnecessary call to AC_stack_top.
4161 (remove_dir): Change type of cwd_state parameter to `struct cwd_state'
4162 so we can now communicate to caller whether/how functions like
4163 restore_cwd have failed. Update caller.
4164 (rm_1): Fail if we've failed to restore the working directory
4165 and the name of the next file to remove is `.'-relative.
4166 (rm): Fail if the require_restore_cwd flag is true and we've
4167 failed to restore the working directory.
4168 * src/mv.c (rm_option_init): Initialize new member,
4169 x->require_restore_cwd.
4170 * src/rm.c (rm_option_init): Likewise.
4172 2004-05-21 Jim Meyering <jim@meyering.net>
4174 * tests/rm/inaccessible: New test for the above fix.
4175 * tests/rm/Makefile.am (TESTS): Add inaccessible.
4177 * src/remove.c (rm): Use free rather than XFREE.
4178 (remove_dir): Use xmalloc, not XMALLOC.
4179 (ds_init): Likewise.
4181 2004-05-20 Jim Meyering <jim@meyering.net>
4183 * Makefile.maint (sc_unmarked_diagnostics): Now that the unmarked
4184 diagnostics in shred.c have been fixed, don't exempt shred.c from
4187 * src/shred.c: Use translatable diagnostics, e.g.
4188 change "%s: remove" to _("%s: failed to remove") and
4189 change "%s: close" to _("%s: failed to close").
4191 2004-05-17 Paul Eggert <eggert@cs.ucla.edu>
4193 * src/shred.c (names): Bring back lower-case letters, "_", and
4194 ".". But continue to omit +, =, %, @, #, as they're either
4195 shell metacharacters (for some shells) or are not in some
4196 character sets, or (in the case of '%') must be a
4197 metacharacter somewhere.
4199 2004-05-16 Paul Eggert <eggert@cs.ucla.edu>
4201 * src/cut.c (cut_fields): Adjust to new signature of getndelim2.
4203 2004-05-17 Jim Meyering <jim@meyering.net>
4205 * src/shred.c (incname): Decrement `len' only once per loop iteration.
4207 chgrp and chown now dereference symlinks by default, per POSIX.
4208 Reported by Michal Politowski as http://bugs.debian.org/249177.
4210 * src/chown-core.c (chopt_init): Affect each symlink referent by default.
4211 * src/chown.c (usage): Update to reflect this.
4212 * src/chgrp.c (usage): Likewise.
4213 * NEWS: Describe the change.
4214 Adapt tests accordingly.
4215 * tests/chgrp/basic: Use -h where necessary to retain semantics.
4216 * tests/chgrp/deref: Likewise.
4217 * tests/chgrp/posix-H: Likewise.
4219 2004-05-15 Paul Eggert <eggert@cs.ucla.edu>
4221 In shred, check for errors from fdatasync more carefully. If
4222 fdatasync fails with errno==EINVAL, it means this implementation
4223 does not support synchronized I/O for this file. Do not report
4224 this as an error, as (for example) AIX 5.2 fdatasync reports it
4225 for raw disk devices. Problem reported by Albert Chin in
4226 <http://mail.gnu.org/archive/html/bug-gnu-utils/2004-05/msg00028.html>.
4228 Check for write errors, though: the old code ignored them.
4229 Improve error checking in a few other cases, too (e.g., close of a
4232 Also, change several 'int' values to 'bool', so that the error
4233 checking is a bit clearer. Similarly, change unsigned values
4234 to size_t where appropriate.
4236 * src/shred.c: Include "dirname.h".
4237 (datasync) [!HAVE_FDATASYNC]: Remove.
4238 (dosync): New function.
4239 (dopass): Use it. Return 1 on write error, -1 on other error.
4240 All callers changed. Report write error if dosync does.
4241 (do_wipefd, wipefd, wipename, wipefile): Return bool (true/false),
4242 not int (0/-1). All callers changed. Return false if there's a
4244 (incname): Return bool (true/false), not int (0/1). Accept
4245 size_t length, not unsigned. All callers changed. Do not
4246 bother checking for non-digits; it can't happen. Replace
4247 recursion with iteration.
4248 (wipename): Use dir_name, base_name, etc. instead of assuming
4249 Unix file names. Use size_t for length, not unsigned.
4250 Report error if unlink or close fails.
4251 (wipename, main): Use bool for booleans.
4253 (names): Use only digits and uppercase letters, for greater
4256 2004-05-16 Jim Meyering <jim@meyering.net>
4258 * tests/chown/deref: New test for the yesterday's change.
4259 * tests/chown/Makefile.am (TESTS): Add deref.
4261 2004-05-15 Jim Meyering <jim@meyering.net>
4263 chown --dereference did nothing when the owner/group of a
4264 symlink matched the desired owner/group. Reported by David Malone.
4265 Also reported in 1999 as http://bugs.debian.org/39642.
4267 * src/chown-core.c (change_file_owner): When --dereference has
4268 been specified, and when processing a symlink, stat it to get the
4269 owner and group of the referent.
4271 2004-05-14 Jim Meyering <jim@meyering.net>
4273 * man/pwd.x, man/echo.x, man/printf.x: Fix typo:
4274 s/supercede/supersede/ reported by Andrew Fabbro.
4276 2004-05-13 Paul Eggert <eggert@cs.ucla.edu>
4278 Improve performance of `sort -m' on large files, at the cost of
4279 making some contrived examples unsafe. POSIX allows this
4280 optimization. Performance problem reported by Jonathan Baker in
4281 <http://mail.gnu.org/archive/html/bug-coreutils/2004-05/msg00071.html>.
4283 * src/sort.c (first_same_file): Do not treat input pipes
4284 differently from other files.
4285 * doc/coreutils.texi (sort invocation): Document that "sort -m -o F"
4286 might write F before reading all the input.
4289 2004-05-12 Paul Eggert <eggert@cs.ucla.edu>
4291 * src/od.c (print_ascii, dump_strings): Use e.g. '\a' rather than
4292 '\007', for portability to EBCDIC hosts.
4293 * src/printf.c (print_esc_char): Likewise.
4294 * src/tr.c (unquote, make_printable_str): Likewise.
4296 2004-05-12 Jim Meyering <jim@meyering.net>
4298 * src/remove.c (AD_pop_and_chdir): Move lstat-`.' into if-block
4299 where the result is used. This avoids one unnecessary lstat call
4300 per command line argument.
4302 2004-05-12 Paul Eggert <eggert@cs.ucla.edu>
4304 Don't assume that "make -C" works; Solaris "make" doesn't have -C.
4306 * src/Makefile.am (all_programs.list): New rule, copied from
4307 man/Makefile.am and tests/Makefile.am, except that we use the
4308 system tr rather than ./tr and we don't use tr -s.
4309 * tests/Makefile.am (all_programs): Use it.
4310 * man/Makefile.am (all_programs): Likewise. Renamed from programs,
4311 for consistency. All uses changed.
4313 2004-05-11 Jim Meyering <jim@meyering.net>
4315 * tests/rm/unread3: New test, for the above fix and today's
4316 lib/save-cwd.c improvement.
4317 * tests/rm/Makefile.am (TESTS): Add unread3.
4319 * src/rm.c: Don't include "save-cwd.h". It's no longer used.
4321 2004-05-10 Jim Meyering <jim@meyering.net>
4323 * tests/install/trap: New file. Test for bug fix of 2004-04-18.
4324 * tests/install/Makefile.am (TESTS): Add trap.
4326 * src/remove.c (AD_push): Don't use errno in diagnostic about
4329 Remove these generated files from CVS.
4330 * tests/cut/cut-tests, tests/date/date-tests, tests/join/join-tests:
4331 * tests/ls/ls-tests, tests/pr/pr-tests, tests/tac/tac-tests:
4332 * tests/tail/tail-tests, tests/test/test-tests, tests/tr/range-tests:
4333 * tests/tr/tr-tests, tests/wc/wc-tests:
4335 2004-05-09 Jim Meyering <jim@meyering.net>
4337 * src/tr.c (unquote): Use xcalloc rather than xmalloc and
4338 a loop initializing the just-allocated memory to zero.
4340 2004-05-08 Jim Meyering <jim@meyering.net>
4342 * tests/rm/no-give-up: New file; check for today's fix.
4343 * tests/rm/Makefile.am (TESTS): Add no-give-up.
4345 2004-05-08 Paul Eggert <eggert@cs.ucla.edu>
4347 Fix bug where "rm" gave up too easily, reported by Dan Jacobsen in
4348 <http://mail.gnu.org/archive/html/bug-coreutils/2004-05/msg00013.html>.
4350 * src/remove.c (remove_entry): Check for errno values like ENOENT
4351 that show the file cannot be directory, instead of for errno
4352 values like EPERM that show the file might be a directory. This
4353 is necessary because, when a single unlink() call has multiple
4354 reasons to fail, it can set errno to any of those reasons; it's
4355 only the rare errno value like ENOENT that excludes all the other
4356 possible reasons to fail even when the file is a directory.
4357 (remove_cwd_entries): Don't attempt chdir if the file is known
4358 to not be a directory.
4359 (remove_dir): Use the same method that remove_cwd_entries uses
4360 (for some reason they differed). Don't assert that saved_errno
4361 must be EPERM; it might be just about anything.
4363 2004-05-06 Jim Meyering <jim@meyering.net>
4365 * src/id.c (xgetgroups): Use xnmalloc, rather than xmalloc.
4366 Don't add `1' to the buffer size (it was to protect against malloc
4367 implementations that fail to allocate a buffer of size zero).
4368 That is no longer necessary, since we use a malloc wrapper
4371 * src/wc.c (get_input_fstatus): Use xnmalloc, rather than xmalloc.
4372 * src/head.c (elide_tail_bytes_pipe): Likewise.
4373 * src/df.c (main): Likewise.
4374 * src/shred.c (do_wipefd): Likewise.
4375 * src/users.c (list_entries_users): Likewise.
4376 * src/tail.c (main): Likewise.
4377 * src/md5sum.c (main): Likewise.
4379 2004-04-29 Paul Eggert <eggert@cs.ucla.edu>
4381 * src/df.c (show_disk, show_point): If several filesystems are
4382 mounted on the same mount point, prefer the last one, not the first.
4383 Problem reported by Christian Jones in
4384 <http://mail.gnu.org/archive/html/bug-coreutils/2004-04/msg00200.html>.
4385 (show_disk): Remove unused statp arg. Return bool, not int.
4386 (show_point): Rewrite to avoid gotos. Use the same algorithm
4387 for lofs and dummies for each pass through the mount table,
4388 rather than subtly different algorithms (which are probably
4391 2004-05-03 Jim Meyering <jim@meyering.net>
4393 * Makefile.am (EXTRA_DIST): Add m4/ChangeLog, now that we no longer
4396 2004-05-01 Jim Meyering <jim@meyering.net>
4398 When chown or chgrp is modifying the referent of a symlink,
4399 use the chown(2) function, if possible.
4400 * src/chown-core.c (change_file_owner): Don't hard-code the
4401 open/fchown/close kludge here. Use `chown' instead.
4402 The chown function works just fine on conforming systems.
4403 Other systems now go through the new chown wrapper that
4404 resorts to the old kludge.
4406 * src/chown-core.c (change_file_owner): Add a comment.
4408 2004-04-27 Jim Meyering <jim@meyering.net>
4410 * src/ptx.c: Make over 40 global extern variables `static'.
4411 (syntax_table, re_syntax_table): Remove declarations of two unused
4412 variables (they were exposed by the above change).
4414 * src/du.c (G_fail, opt_nul_terminate_output): Declare `static'.
4415 * src/ln.c (backup_type): Likewise.
4417 * src/remove.c (rm): Add `extern' keyword.
4418 * src/cp-hash.c (forget_created, remember_created)
4419 (src_to_dest_lookup, remember_copied, hash_init, forget_all): Likewise.
4420 * src/copy.c (dest_info_init, src_info_init, copy): Likewise.
4421 * src/chown-core.c (chopt_init, chopt_free, gid_to_name)
4422 (uid_to_name, chown_files): Likewise.
4424 * src/Makefile.am (sc_tight_scope): New rule.
4425 * Makefile.maint (sc_tight_scope): New rule.
4426 (syntax-check-rules): Add it.
4428 2004-04-26 Jim Meyering <jim@meyering.net>
4430 * Use automake-1.8.4. Regenerate dependent files.
4432 * src/sort.c (limfield): Make a comment clearer.
4434 2004-04-25 Paul Eggert <eggert@twinsun.com>
4436 Fix POSIX-conformance bug: "sort -k 3,3.5b" is supposed to skip
4437 leading blanks when computing the location of the field end;
4438 it is not supposed to skip trailing blanks. Solaris 8 "sort"
4439 does conform to POSIX. Also fix the documentation to clarify
4440 this and related issues.
4442 * doc/coreutils.texi (sort invocation): Mention -k earlier, so
4443 that the options are in alphabetical order. Describe how -b works
4444 more-accurately; this involves fixing some examples, too. Mention
4445 what happens if the start field falls after an end field or after
4446 a line end. Warn about using -k without -b, -g, -M, -n, or -t.
4447 Add an example of how to sort IPv4 addresses and Apache Common
4448 Log Format dates. Remove a duplicate example.
4449 (Putting the tools together): Use separate options rather
4450 than agglomerating them.
4451 * src/sort.c (limfield): Use skipeblanks, not skipsblanks, to
4452 decode whether to skip leading blanks.
4453 (trailing_blanks): Remove.
4454 (fillbuf, getmonth, keycompare): Don't trim trailing blanks.
4456 * tests/pr/Test.pm: Fix typo in env_default comment.
4457 * tests/sort/Test.pm: Likewise.
4458 (18c, 18d): Reverse the order of output lines, so that the
4459 test cases conform to POSIX.
4461 2004-04-22 Paul Eggert <eggert@twinsun.com>
4463 More signal-handling cleanup for ls.c. Do not allow signals to
4464 happen between arbitrary output bytes, as the
4465 restore-default-color sequence can bollix up multibyte chars or
4466 color-change sequences in the ordinary output. Instead, process
4467 signals only between printing a file name and changing the color
4468 back to non_filename_text color. That way, if the signal handler
4469 changes the color (to the default), 'ls' will change it back when
4470 'ls' continues (after being suspended).
4472 Also, do not bother with signal-handling unless stdout is a
4473 controlling terminal; this lets stdio buffer better when "ls
4474 --color" is piped or sent to a file.
4476 * src/ls.c (sigprocmask, sigset_t) [!defined SA_NOCLDSTOP]: New macros.
4477 Do not include "full-write.h"; no longer needed.
4478 (tcgetpgrp) [! HAVE_TCGETPGRP]: New macro.
4479 (put_indicator_direct): Remove. All callers changed to use
4481 (caught_signals, interrupt_signal, stop_signal_count): New vars.
4482 (restore_default_color): Don't bother checking for put_indicator
4484 (sighandler): Don't handle SIGTSTP; that's another handler now.
4485 Simply set interrupt_signal to the signal, then exit.
4486 (stophandler, process_signals): New functions.
4487 (main): Don't output any color changes until _after_ the signal
4488 handlers are set up. This fixes a race condition where 'ls'
4489 could be interrupted while initializing colors, and leaving the
4490 terminal in an undesirable state.
4491 Don't mess with signal-handling if standard output is not a
4492 controlling terminal.
4493 When exiting, restore the default color, then restore the
4494 default signal handling, then act on any signals that weren't
4496 Do not print //DIRED// etc. in colors; this avoids the need
4497 to catch signals when printing them.
4498 (print_name_with_quoting): Process signals just before switching
4499 color back to non_filename_text.
4501 2004-04-23 Jim Meyering <jim@meyering.net>
4503 Avoid segfault on systems for which SIZE_MAX != (size_t) -1.
4504 * src/ls.c (quote_name): Use SIZE_MAX, not -1, in calls
4505 of quotearg_buffer. Patch by Mikulas Patocka.
4507 2004-04-18 Paul Eggert <eggert@twinsun.com>
4509 tee ignored SIGPIPE, but POSIX doesn't allow this.
4511 * src/tee.c (main): Do not ignore SIGPIPE, as POSIX 1003.1-2001
4512 does not allow this. This undoes the 1996-10-24 patch.
4514 2004-04-18 Paul Eggert <eggert@twinsun.com>
4516 Signal-handling cleanup for coreutils. Here are the highlights:
4518 - csplit sometimes failed to remove files when interrupted.
4519 - csplit didn't clean up if two signals arrived nearly simultaneously.
4520 - install -s would infloop on System V if SIGCHLD was ignored.
4521 - ls could incorrectly restore color if multiple signals
4522 arrived nearly simultaneously.
4524 * src/csplit.c (sigprocmask, sigset_t) [!defined SA_NOCLDSTOP]:
4526 (filename_space, prefix, suffix, digits, files_created, remove_files):
4528 (caught_signals): New var.
4529 (cleanup): Block signals while deleting all files.
4530 (cleanup_fatal, handle_line_error, regexp_error):
4531 Mark with ATTRIBUTE_NORETURN.
4532 (create_output_file, close_output_file, interrupt_handler):
4533 Block signals while changing the number of output files,
4534 to fix some race conditions.
4535 (delete_all_files): Do nothing if remove_files is zero.
4536 Clear files_created.
4537 (main): Don't mess with signals until after argument processing
4540 * src/csplit.c (main): Rewrite signal-catching code to make it
4541 similar to other coreutils programs. When processing signals,
4542 block all signals that we catch, but do not block signals that we
4543 don't catch. Avoid problems with unsigned int warnings.
4544 * src/ls.c (main): Likewise.
4545 * src/sort.c (main): Likewise.
4547 * src/csplit.c (interrupt_handler):
4548 Use void, not (obsolete) RETSIGTYPE.
4549 * src/shred.c (sigill_handler, isaac_seed_machdep): Likewise.
4551 * src/csplit.c (interrupt_handler) [defined SA_NOCLDSTOP]:
4552 Use simpler "signal (sig, SIG_DFL)" rather than sigaction equivalent.
4553 * src/ls.c (sighandler) [defined SA_NOCLDSTOP]: Likewise.
4554 * src/sort.c (sighandler) [defined SA_NOCLDSTOP]: Likewise.
4555 * src/nohup.c (main) [!defined _POSIX_SOURCE]: Likewise, except
4557 * src/tee.c (main) [!defined _POSIX_SOURCE]: Likewise.
4559 * src/install.c: Include <signal.h>.
4560 (main) [defined SIGCHLD]: Set SIGCHLD handler to the default, if -s is
4561 given, since System V fork+wait does not work if SIGCHLD is ignored.
4563 * src/ls.c (sighandler) [!defined SA_NOCLDSTOP]: Reset signal
4564 handler to self, not to SIG_IGN, since SIGTSTP can be received
4566 (main): Use SA_RESTART, as that is simpler than checking for EINTR
4567 failures all over the place.
4569 2004-04-20 Jim Meyering <jim@meyering.net>
4571 * src/remove.c (is_empty_dir): Clarify comment.
4573 * man/help2man: Accept new option: --program-name=NAME, so that we
4574 can override the one in --version output. This is needed solely
4575 so that test.1 doesn't refer to `[' as the program name.
4576 Reported by Benjamin Cutler as http://bugs.debian.org/205251.
4577 * man/Makefile.am (.x.1): Use help2man's new --program-name option.
4579 * src/pwd.c: Don't include pathmax.h; system.h already does it.
4581 * src/cut.c (cut_fields): Free buffer upon getndelim2 failure.
4583 2004-04-19 Jim Meyering <jim@meyering.net>
4585 * src/shred.c (isaac_seed_start) [AVOID_USED_UNINITIALIZED_WARNINGS]:
4586 Initialize a buffer to avoid warnings from tools like valgrind.
4588 * Makefile.maint (sc_trailing_blank): New rule.
4589 (syntax-check-rules): Add it.
4590 * .x-sc_trailing_blank: New file.
4592 Make pwd work even if the resulting name is so long that getcwd fails.
4593 * src/pwd.c: (path_free, path_init, path_prepend): New functions.
4594 (nth_parent, find_dir_entry, robust_getcwd): New functions.
4595 (main): First try getcwd, then, upon failure, robust_getcwd.
4597 2004-04-18 Jim Meyering <jim@meyering.net>
4599 * src/who.c (print_user): Use xrealloc here, rather than
4600 unchecked realloc. Remove anachronistic casts.
4602 * src/remove.c (full_filename_): Don't leak upon failed realloc.
4604 * src/system.h (readdir_ignoring_dot_and_dotdot): New inline function,
4606 * src/remove.c (readdir_ignoring_dotdirs): Move function to system.h,
4607 renaming it. Update uses.
4609 2004-04-17 Jim Meyering <jim@meyering.net>
4611 * configure.ac: Depend on automake-1.8.3.
4613 * src/join.c (add_file_name): Declare function to be `static'.
4614 (string_to_join_field): Likewise.
4615 * src/remove.c (ds_init, ds_free): Likewise.
4617 * Makefile.maint (sc_prohibit_jm_in_m4): New rule.
4618 (syntax-check-rules): Add to the list.
4620 2004-04-13 Paul Eggert <eggert@twinsun.com>
4622 Use page-aligned buffers whenever we bother to do I/O using buffer
4623 sizes that are tailored for the files.
4625 * src/cat.c: Include getpagesize.h.
4626 * src/copy.c: Likewise.
4627 * src/shred.c: Likewise.
4628 * src/split.c: Likewise.
4629 * src/cat.c (main): Align I/O buffers to page boundaries.
4630 * src/copy.c (copy_reg): Likewise.
4631 * src/shred.c (dopass): Likewise.
4632 * src/split.c (main): Likewise.
4633 * src/dd.c (ROUND_UP_OFFSET, PTR_ALIGN): Remove.
4634 All uses replaced by ptr_align.
4635 * src/od.c (gcd, lcm): Remove; now in system.h.
4636 * src/system.h (gcd, lcm, ptr_align): New functions, moved from od.c.
4638 2004-04-14 Jim Meyering <jim@meyering.net>
4640 Remove m4/Makefile.am: it's no longer needed, with newer automake
4641 * configure.ac (AC_CONFIG_FILES): Remove m4/Makefile.in from the list.
4642 * Makefile.am (SUBDIRS): Remove `m4' from the list.
4644 2004-04-13 Jim Meyering <jim@meyering.net>
4646 * configure.ac: Change `jm_' in AC_DEFINE'd names to `gl_'.
4648 2004-03-27 Paul Eggert <eggert@twinsun.com>
4650 * NEWS: cp -pu and mv -u (when copying) now take the destination
4651 file system time stamp resolution into account.
4652 * doc/coreutils.texi (mv invocation): Document this.
4653 (cp invocation): Document -u (it was missing!) with new behavior.
4655 * src/copy.c: Include "utimecmp.h".
4656 (copy_internal): Compare time stamps using utimecmp rather than
4659 2004-04-09 Jim Meyering <jim@meyering.net>
4661 * Makefile.maint (.re-list): New rule/file, to replace
4662 hard-coded list of header file names.
4663 (sc_system_h_headers): Use the new file.
4664 Don't look for sys2.h anymore.
4666 * src/system.h: Include new "stat-macros.h" rather than hard-coding
4667 all of its macro definitions -- the list was slightly out of date.
4668 Suggestion from Dmitry V. Levin.
4670 2004-04-08 Paul Eggert <eggert@cs.ucla.edu>
4672 * NEWS: Remove noctty flag from dd. Suggested by Philippe Troin.
4673 * doc/coreutils.texi (dd invocation): Likewise.
4674 * src/shred.c (O_NOCTTY): Remove redundant decl.
4675 * src/dd.c (flags, usage): Remove noctty flag.
4676 (main): Always use O_NOCTTY when opening files.
4678 2004-04-08 Jim Meyering <jim@meyering.net>
4680 * src/dd.c (dd_copy): Mark two diagnostics for translations.
4681 (set_fd_flags): Undo part of today's change: it's a little
4682 cleaner -- and more efficient in the common case -- to go
4683 ahead and OR in the -1 when fcntl fails.
4685 * Makefile.maint (sc_dd_max_sym_length): New target.
4686 (syntax-check-rules): Add it.
4688 * src/md5sum.c (PROGRAM_NAME) [algorithm == ALG_SHA1]:
4689 Correct spelling: s/shasum/sha1sum. Reported by Jesse Kornblum.
4691 * src/dd.c (set_fd_flags): Don't OR in -1 when fcntl fails.
4692 Rename parameter, flags, to avoid shadowing global.
4693 (LONGEST_SYMBOL): Tweak comment.
4695 2004-04-07 Paul Eggert <eggert@twinsun.com>
4697 * NEWS: New dd conv= symbols nocreat, excl, fdatasync, fsync,
4698 and new dd options iflag= and oflag=.
4699 * src/dd.c (usage): Likewise.
4700 * src/Makefile.am (dd_LDADD, shred_LDADD): Add fdatasync's lib.
4701 * src/dd.c (fdatasync) [!HAVE_FDATASYNC]: New macro.
4702 (C_NOCREAT, C_EXCL, C_FDATASYNC, C_FSYNC): New macros.
4703 (input_flags, output_flags): New vars.
4704 (LONGEST_SYMBOL): New macro.
4705 (struct symbol_value): Renamed from struct conversion. Members
4706 symbol and value renamed from convname and conversion. The
4707 symbol value is now an array instead of a pointer; this saves
4708 a bit of space and time in practice. All uses changed.
4709 (conversions): Add nocreat, excl, fdatasync, fsync. Now const.
4710 (flags): New constant array.
4711 (iflag_error_msgid, oflag_error_msgid): New constants.
4712 (parse_symbols): Renamed from parse_conversion and generalized
4713 to handle either conversion or flag symbols.
4714 (scanargs): Adjust uses of parse_symbols accodingly. Add
4715 support for iflag= and oflag=. Reject attempts to use
4716 both excl and nocreat.
4717 (set_fd_flags): New function.
4718 (dd_copy): Just return X rather than calling quit (X), since our
4719 caller invokes quit with the returned value. Add support for
4720 fdatasync and fsync.
4721 (main): Add support for iflag=, oflag=, and new conv= symbols.
4722 * src/system.h (O_DIRECT, O_DSYNC, O_NDELAY, O_NOFOLLOW,
4723 O_RSYNC, O_SYNC): Define to 0 if not already defined.
4725 * NEWS: Remove duplicate mention of BLOCKSIZE.
4727 2004-04-02 Andreas Schwab <schwab@suse.de>
4729 * src/stty.c: Add support for IUTF8 input flag.
4731 2004-04-06 Jim Meyering <jim@meyering.net>
4733 * src/system.h (makedev) [mkdev && !makedev]: Define in terms of mkdev.
4734 Interix spells it `mkdev'. Reported by Mark Funkenhauser.
4736 2004-04-04 Jim Meyering <jim@meyering.net>
4738 A specified format is no longer automatically newline terminated.
4739 If you want a newline at the end of your format, use `\n'.
4740 * src/stat.c (print_it): Don't print a newline at the end of
4742 (do_statfs): Add a newline at end of each default format string.
4744 2004-03-30 Paul Eggert <eggert@twinsun.com>
4746 * src/nohup.c (main): Adjust to new calling convention
4747 for set_cloexec_flag.
4749 2004-03-31 Jim Meyering <jim@meyering.net>
4751 * tests/Fetish.pm (run_tests): Remove `.orig' file.
4752 Remove debugging diagnostic.
4754 Specifying an invalid --width=N (-w) or --gap-size=N (-g)
4755 would not elicit an error.
4756 * src/ptx.c: Include "xstrtol.h" and "quotearg.h".
4757 (main): Don't use atoi. Use xstrtoul instead.
4759 2004-03-30 Jim Meyering <jim@meyering.net>
4761 * Makefile.maint (sc_prohibit_atoi_atof): New rule.
4762 (syntax-check-rules): Add it.
4763 * .x-sc_prohibit_atoi_atof: New file.
4765 2004-03-29 Jim Meyering <jim@meyering.net>
4767 * tests/du/files0-from: Use new OUT_SUBST directive, so that this
4768 test is not sensitive to system-dependent block size differences.
4769 Prompted by a report of Solaris 8 differences from Paul Eggert.
4771 * tests/Fetish.pm: Accept new directives: OUT_SUBST, ERR_SUBST.
4772 Rename `%tmp' to `%actual'. Reverse order of last two args to
4773 _compare_files (to $actual, $expected) so as to match declaration.
4775 2004-03-28 Paul Eggert <eggert@twinsun.com>
4777 Fix some gotchas encountered when porting to Solaris 8, using
4778 the Forte 6u2 compiler.
4780 * src/hostname.c [HAVE_SETHOSTNAME && !defined sethostname]:
4781 Declare sethostname, since no Solaris header does it.
4782 * src/who.c: Include "vasprintf.h", for asprintf.
4784 2004-03-28 Jim Meyering <jim@meyering.net>
4787 * src/du.c (process_file): Don't record dev/inode for directories.
4789 Under some circumstances, without -c, du would mistakenly count the
4790 space of hard-linked files, not just the first one it encountered.
4791 Reported by Anthony Thyssen.
4792 * src/du.c (du_files): Don't ever clear the set of `seen' dev/inodes.
4794 * src/du.c: Rename global `print_totals' to `print_grand_total'.
4796 * src/du.c (main): Rearrange filtering loop to be a tiny bit
4799 * src/chown-core.c: Don't include savedir.h -- no longer needed.
4800 * src/chmod.c: Likewise.
4802 2004-03-25 Jim Meyering <jim@meyering.net>
4804 * src/du.c (main): Remove now-unused declaration of `i'.
4806 2004-03-24 Paul Eggert <eggert@twinsun.com>
4808 * src/du.c (main): Filter out file names of length zero before
4809 invoking fts, so that they don't cause fatal errors.
4811 2004-03-25 Jim Meyering <jim@meyering.net>
4813 * tests/du/files0-from (zero-len): Add a test for the above.
4815 2004-02-25 Paul Eggert <eggert@twinsun.com>
4817 * NEWS: New environment var BLOCKSIZE.
4818 * lib/human.c (humblock): Support BLOCKSIZE as well as BLOCK_SIZE.
4819 * tests/envvar-check: Test for it. Factor the code to simplify it.
4821 2004-03-23 Paul Eggert <eggert@twinsun.com>
4823 * NEWS: Shorten the du --files0-from announcement, and say
4824 "NUL-terminated" rather than "NUL-separated".
4825 * src/du.c (EXPECTED_BYTES_PER_FILE_NAME, DEFAULT_PROJECTED_N_FILES):
4827 (usage): Say "NUL-terminated", not "NUL-separated".
4828 (main): Check for I/O error when istream is closed.
4829 Allow --files0-from=F even if F is empty; this specifies no files.
4830 (du_files): Now that we allow the list of files to be empty,
4832 * tests/du/files0-from: Adjust to above changes to src/du.c.
4834 2004-03-24 Jim Meyering <jim@meyering.net>
4836 * tests/tail-2/assert: Avoid race condition that could cause
4837 spurious failure. Based on a patch from Andreas Schwab.
4839 2004-03-23 Jim Meyering <jim@meyering.net>
4841 * src/du.c (main): Free the hash table, too.
4843 2004-03-22 Jim Meyering <jim@meyering.net>
4845 * man/Makefile.am (.x.1): Remove --info-page= option, reverting
4846 the change of 2004-01-22. I can no longer reproduce the problem
4847 that prompted that change, and `info coreutils pr' would display the
4848 `printing text' section of the manual, not the one on `pr invocation'.
4850 * tests/du/files0-from (nul-1, nul-2): Adjust expected diagnostics
4851 to match corrected output.
4853 * src/du.c: Include "readtokens0.h" rather than "readtokens.h".
4854 (main): Use readtoken0 functions rather than readtokens.
4855 Don't use errno when diagnosing readtokens0 failure.
4856 Fix off-by-one error in the token number reported in a diagnostic.
4857 (du_files): Return bool, rather than int.
4858 (main): Call readtokens0_free.
4860 2004-03-21 Jim Meyering <jim@meyering.net>
4862 * src/remove.c (ds_free): Plug a small leak.
4864 * tests/Fetish.pm: Fix typo in comment.
4866 2004-03-07 Jim Meyering <jim@meyering.net>
4868 * NEWS: du accepts a new option --files0-from=FILE, where FILE
4869 contains a list of NUL-separated file names.
4871 * src/du.c: Include "readtokens.h".
4872 (usage): Describe the new option, and adjust the `Usage':
4873 with this option, no FILE may be specified on the command line.
4874 (main): Handle the new option.
4876 * tests/du/files0-from: New tests, for the above.
4877 * tests/du/Makefile.am (TESTS): Add files0-from.
4879 * src/factor.c (do_stdin): Reflect changes in use of readtoken.
4880 * src/tsort.c (tsort): Likewise.
4882 2004-02-29 Paul Eggert <eggert@twinsun.com>
4884 * NEWS: Add support for a new notation @N to get_date to represent
4885 the time stamp with numeric value N. Improve support for
4886 fractional time stamps. date's -d and -f options now accept them.
4887 Likewise for touch -t. date has a new option --iso-8601=ns.
4889 * doc/coreutils.texi (touch invocation):
4890 Describe use of fractional seconds.
4891 (date invocation, Options for date): Likewise.
4892 * doc/getdate.texi (General date syntax, Time of day items): Likewise.
4893 * doc/coreutils.texi (date invocation): Mention effect of LC_TIME.
4894 (Options for date): Describe new --iso-8601=ns option.
4896 * doc/getdate.texi: Add copyright notice. Change getdate to
4897 get_date when talking about the function name.
4898 (Seconds since the Epoch): New section, containing the time_t
4899 info moved from Date input formats section, along with new
4900 info about the @ syntax. Mention negative time stamps,
4901 fractional time stamps, and leap seconds.
4902 (General date syntax): Modernize examples a bit to reflect new
4904 (General date syntax, Relative items in date strings):
4905 Use ' rather than " to quote formats.
4906 (Time of day items): Add an example with fractional seconds.
4907 Describe fractional-second syntax.
4909 * src/Makefile.am (touch_LDADD): New macro, since `touch' now
4910 needs clock_gettime.
4912 * src/date.c (enum Time_spec): New enum TIME_SPEC_NS.
4913 (time_spec_string, time_spec, show_date): Support it.
4914 (usage): Remove description of -ITIMESPEC, as it's obsolete and
4915 confusing. Mention --iso-8601=ns.
4916 (batch_convert): getline returns ssize_t, not int.
4918 * src/touch.c (newtime): Now an array of two timespecs, one
4919 for access and one for modification.
4920 (ref_stats): Remove.
4921 (get_reldate): Use get_date's parameter profile.
4922 (touch, main): Adjust to above changes.
4923 (main): Work even if tm_year == INT_MAX (so long as long int is wider).
4924 Use gettime instead of gettimeofday, for new get_date signature.
4926 * tests/date/Test.pm (test_vector): New tests epoch, ns-10, ns-max32,
4929 2004-03-15 Jim Meyering <jim@meyering.net>
4931 * Makefile.maint (alpha beta major): `Make' the emit_upload_commands
4932 target before updating $(prev_version_file).
4934 * tests/misc/date-sec: New file, to test for just-fixed bug in date.
4935 See today's change in lib/getdate.y.
4936 * tests/misc/Makefile.am (TESTS): Add date-sec.
4938 2004-03-14 Jim Meyering <jim@meyering.net>
4940 * announce-gen (print_changelog_deltas): Use `.sig' suffix for
4941 signature files, not `.asc'. Reported by angico@yahoo.com.
4943 2004-03-13 Jim Meyering <jim@meyering.net>
4945 * src/cp.c (do_copy): Tweak wording in a diagnostic.
4946 Suggestion from Karl Berry.
4947 Include "quoatearg.h".
4948 (do_copy): Use quotearg_colon (not quote) for diagnostics
4949 that begin with `"%s:'.
4951 * src/nl.c (usage): Specify that nl uses _basic_ regular expressions.
4952 Suggestion from Dan Jacobson.
4954 2004-03-12 Jim Meyering <jim@meyering.net>
4958 Sometimes, when source and destination partition are different,
4959 mv mistakenly fails to preserve a hard link. Reported by IIDA Yosiaki.
4961 * src/copy.c: When moving a set of N hard-linked files between
4962 partitions, via two or more command line arguments where the
4963 command line argument containing the Nth link contains no other
4964 link to that same file, mv would mistakenly copy the file, rather
4965 than hard-linking it to the other(s). That happens because when the
4966 final link is processed, its link count has been reduced to 1 since
4967 the other links have been `copied' to the destination partition
4968 and the source links have been removed.
4969 (copy_internal): When in move mode, use the source dev/inode
4970 pair to look up destination name even when st_nlink == 1.
4971 * src/cp-hash.c (src_to_dest_lookup): New function.
4972 * src/cp-hash.h (src_to_dest_lookup): Add prototype.
4973 * tests/mv/part-hardlink: New file. Test for the above fix.
4974 * tests/mv/Makefile.am (TESTS): Add part-hardlink.
4976 * announce-gen: Sync with autoconf.
4978 * tests/ls/time-1: Exit 77 (not 1) if we can't set up for the test.
4979 This was triggered on a Linux-2.2.19 system using a file system
4980 NFS-mounted from some sort of Sun.
4982 2004-03-11 Jim Meyering <jim@meyering.net>
4984 * Use automake-1.8.3. Regenerate dependent files.
4986 2004-03-10 Jim Meyering <jim@meyering.net>
4988 * tests/du/deref-args: Also convert sizes in the 70-79 kB range,
4989 so that this test works with SELinux-enabled systems.
4990 Based on a patch from Tim Waugh.
4992 `join -1 x' would give a misleading diagnostic
4993 * src/join.c (string_to_join_field): Report that a non-numeric field
4994 number is invalid, rather than `so large that it is not representable'.
4995 * tests/join/Test.pm (invalid-j): New partial test for the above fix.
4997 2004-03-06 Jim Meyering <jim@meyering.net>
4999 cp --sparse=always sparse-image-file.img /dev/hda1 could
5000 produce an invalid copy on the destination device.
5002 * src/copy.c (copy_reg): Even with --sparse=always, try to
5003 make `holes' only if the destination is a regular file.
5004 Reported by Szakacsits Szabolcs.
5006 2004-03-03 Paul Eggert <eggert@twinsun.com>
5008 * src/nohup.c (main): Don't invoke set_cloexec_flag with
5009 a file descriptor of -1.
5011 2004-03-02 Dmitry V. Levin <ldv@altlinux.org>
5013 * src/nohup.c: Include "cloexec.h".
5014 (main): Set the copy of stderr to close on exec.
5016 2004-03-01 Paul Eggert <eggert@twinsun.com>
5018 * configure.ac: Include <signal.h> when checking for strsignal,
5019 sys_siglist, and friends. Problem reported by Tony Leneis in
5020 <http://mail.gnu.org/archive/html/bug-coreutils/2004-02/msg00136.html>.
5022 2004-02-25 Paul Eggert <eggert@twinsun.com>
5024 * tests/du/deref-args, tests/du/exclude, tests/du/slash:
5025 * tests/du/trailing-slash: Run envvar-check in case BLOCK_SIZE
5028 2004-02-23 Paul Eggert <eggert@twinsun.com>
5030 * NEWS: Document how chown's USER.GROUP argument is now parsed.
5032 2004-02-23 Jim Meyering <jim@meyering.net>
5034 * src/seq.c (usage): Remove stray space after \n in --help output.
5036 2004-02-22 Jim Meyering <jim@meyering.net>
5038 * src/du.c (usage): Separate -H and --si. Say that the meaning
5039 of -H will soon change to that of --dereference-args (-D).
5041 2004-02-21 Jim Meyering <jim@meyering.net>
5043 * src/comm.c (usage): Tell what comm does when there are no options.
5044 Reword in terms of FILE1 and FILE2 rather than `left file' and
5045 `right file'. Suggestion from Dan Jacobson.
5047 2004-02-15 Paul Eggert <eggert@twinsun.com>
5049 Fix some POSIX-conformance bugs in expr.
5051 * NEWS: document the following changes to src/expr.c.
5052 * doc/coreutils.texi (expr invocation): Likewise.
5053 Document what forms integers may take, and say "integer"
5054 consistently instead of "number". Warn about operands
5055 that "expr" can misinterpret, and how to work around the
5057 * src/expr.c (eval, eval7, eval6, eval5, eval4, eval3, eval2, eval1):
5058 Accept a bool argument specifying whether to evaluate the
5059 expression. This is to allow short-circuit evaluation. All
5061 (null): Report that a string is zero even if it has
5062 a form like "-0" or "00".
5063 (eval1, eval): Use short-circuit evaluation for | and &.
5064 (eval): Return 0 if both arguments are null or zero, instead
5065 of returning the first argument.
5066 * tests/expr/basic: Add some tests for the above.
5068 2004-02-17 Jim Meyering <jim@meyering.net>
5072 `make check' from a build inside a chroot environment would fail
5073 * tests/help-version: Specify an argument (`/') for df, in the
5074 unusual event that there is no valid entry in /etc/mtab.
5075 Likewise for id: add the -u option, so we don't get spurious
5076 failures when there are no user or group names.
5079 * src/sort.c (usage) [-u]: Add punctuation so that the description in
5080 the help2man-generated (line-joined) man page is more readable.
5081 Reported by Tim Waugh.
5082 [-T]: Add a semicolon, for the same reason.
5084 2004-02-15 Jim Meyering <jim@meyering.net>
5086 * Makefile.am (dist-hook): Qualify target with $(srcdir)/ prefix.
5088 2004-02-11 Jim Meyering <jim@meyering.net>
5090 * tests/Makefile.am.in ($(srcdir)/Makefile.am): Use more portable
5091 $(srcdir)/../Makefile.am.in, rather than $<.
5092 Suggestion from Michael Elizabeth Chastain.
5094 2004-02-10 Jim Meyering <jim@meyering.net>
5096 * config/install-sh: Make this script executable.
5097 * Makefile.am (dist-hook): New target, to ensure that config/install-sh
5098 is executable. Otherwise, on systems that lack a suitable install
5099 binary, `make install' would fail, because of the way this script
5100 is invoked (without `$SHELL ' prefix).
5101 Reported by Bob Proulx.
5103 2004-02-08 Jim Meyering <jim@meyering.net>
5107 * tests/rm/rm5: Avoid triggering a bug in OSF/Tru64's sed
5108 that would cause an unwarranted test failure.
5109 * tests/rm/rm3: Likewise.
5111 2004-02-07 Jim Meyering <jim@meyering.net>
5113 Remove xstat function pointer member. The way it was used was not
5114 portable, since some systems (OSF V5.1, Solaris 2.5.1) provide static
5115 inline `stat' and `lstat' functions, thus making the tests of
5116 `xstat == lstat' in copy.c always fail.
5117 * src/copy.h (struct cp_options) [xstat]: Remove member.
5119 * src/copy.c (copy_dir): Set `.dereference' member, not .xstat.
5120 (copy_internal): Use `XSTAT (x, ...)' in place of `*(x->xstat) (...)'.
5121 Use `x->dereference == DEREF_NEVER' in place of `x->xstat == lstat'.
5122 (valid_options): Remove now-obsolete FIXME comments.
5124 * src/cp.c (re_protect): Use `XSTAT (x, ...)' in place of
5125 `*(x->xstat) (...)'.
5126 (do_copy): Declare/use local xstat rather than x->xstat.
5127 (main): Remove code that set x.xstat.
5128 * src/mv.c (cp_option_init): Don't initialize xstat member.
5129 * src/install.c (cp_option_init): Likewise.
5131 * Makefile.cfg (gnu_ftp_host-alpha, etc.): Un-factor .gnu.org suffix,
5132 so that emit_upload_commands can use these variables, too.
5134 2004-02-06 Jim Meyering <jim@meyering.net>
5136 * tests/rm/deep-1: Remove `du' stack space test.
5137 Apparently, `ulimit -s N' isn't portable enough.
5138 This test will be restored (with a guard against losing ulimit)
5139 in its own file later.
5141 * tests/rm/deep-1 (deep): Remove progress-style diagnostics,
5142 since this test doesn't take long enough to merit them.
5143 Run du on $tmp (the containing dir), not $deep, the full path to leaf.
5145 * Makefile.maint (signatures): Remove definition.
5146 Now, automake's gnupload handles this.
5147 (%.sig: %): Remove now-unused rule.
5148 (rel-files): Use automake's $(DIST_ARCHIVES), rather than
5149 `$(distdir).tar.bz2 $(distdir).tar.gz'.
5150 (emit-upload-commands): Adjust to use gnupload.
5152 2004-02-05 Jim Meyering <jim@meyering.net>
5154 * src/system.h (ST_TIME_CMP_NS, ST_TIME_CMP): Remove definitions.
5155 (ATIME_CMP, CTIME_CMP, MTIME_CMP, TIMESPEC_NS): Likewise.
5156 Now, those are all defined in timespec.h.
5159 * src/date.c: Don't include timespec.h, now that system.h does it.
5161 2004-02-02 Paul Eggert <eggert@twinsun.com>
5163 Don't dump core if localtime returns NULL (possible on
5164 hosts with 64-bit time_t and 32-bit int).
5165 * src/date.c: Include "inttostr.h".
5166 (batch_convert, main):
5167 If time conversion fails, exit with nonzero status.
5168 (show_date): Return int to report conversion failure.
5169 Print the time as an int if localtime fails.
5170 * src/uptime.c: Print "??" if the current clock can't
5171 be converted by localtime. This won't happen until the year
5172 2*31 + 1900, but we don't want to dump core even if the current
5173 clock has the wrong value.
5175 * src/stat.c: Include "inttostr.h".
5176 (human_time): Print the date/time as a number of seconds since the
5177 epoch if it can't be converted by localtime. This is better than
5178 just saying "invalid", and is consistent with what "ls" does.
5179 Don't dump core if the year has more than 48 digits; this isn't
5180 possible on any contemporary host, but we might as well do it right.
5182 2004-01-31 Paul Eggert <eggert@twinsun.com>
5184 * src/stat.c (human_time): Accept time rather than
5185 pointer-to-const-time parameter, for clarity. All callers changed.
5187 2004-02-02 Jim Meyering <jim@meyering.net>
5189 * src/stat.c (do_stat): Remove extra trailing newline from
5190 default formats. Reported by Nelson H. F. Beebe.
5192 Print actual fractional seconds in time stamps, not just `.00000000'.
5193 * src/stat.c (human_time): Add and use new parameter, t_ns.
5194 (print_stat): Update callers.
5195 * src/ls.c (TIMESPEC_NS): Remove definition.
5196 * src/system.h (TIMESPEC_NS): Define here, instead, now that stat.c
5197 also uses this macro.
5198 Nelson H. F. Beebe noticed that ls --full-time printed nonzero
5199 fractional seconds for files on an XFS file system, but that stat's
5200 fractional seconds were always zero.
5202 2004-01-28 Paul Eggert <eggert@twinsun.com>
5204 * src/seq.c (print_numbers): Use 'double' for loop index, not
5205 'int', to avoid problems with integer overflow. On almost all
5206 machines 'double' works in every case where 'int' works, and
5207 it works on other cases besides.
5209 2004-01-27 Jim Meyering <jim@meyering.net>
5211 * src/seq.c (usage): Mention that if INCREMENT is omitted,
5212 it defaults to 1, even when FIRST is larger than LAST.
5213 Reword so as not to exclude the possibility that INCREMENT be zero.
5215 2004-01-25 Jim Meyering <jim@meyering.net>
5219 * Makefile.maint (signatures): Comment out definition.
5221 2004-01-23 Jim Meyering <jim@meyering.net>
5223 * Makefile.maint (header_regexp): Add exitfail.
5225 * man/Makefile.am (EXTRA_DIST): Add help2man.
5226 Reported by Nelson H. F. Beebe.
5228 * man/Makefile.am (.x.1): Prefix help2man invocation with `$(PERL) --'
5229 so it works on systems with Perl installed somewhere other than in
5232 * src/paste.c (paste_parallel): Declare local, chr, to be of type
5233 `int', not `char', since it must hold EOF. This bug would make
5234 paste infloop on some systems. Test failures reported by
5235 Nelson H. F. Beebe and Christian Krackowizer.
5237 2004-01-22 Jim Meyering <jim@meyering.net>
5239 * tests/rmdir/fail-perm: New file. Test for just-fixed rmdir bug.
5240 * tests/rmdir/Makefile.am (TESTS): Add fail-perm.
5242 * man/help2man: Fix it so using --info-page='coreutils PROG' works.
5243 * man/Makefile.am (.x.1): Invoke our own (tweaked) copy of help2man.
5244 Use --info-page='coreutils PROG' option.
5245 Now, readlink.1 refers the user to `info coreutils readlink'
5246 rather than to `info readlink'. Reported by Matt Swift.
5248 2004-01-21 Paul Eggert <eggert@twinsun.com>
5250 Exit status cleanup.
5252 * src/basename.c (usage): Use EXIT_SUCCESS, not 0, for clarity.
5253 * src/cat.c, src/chgrp.c, src/chmod.c, src/chown.c, src/chroot.c,
5254 * src/cksum.c, src/comm.c, src/cp.c, src/csplit.c, src/cut.c,
5255 * src/date.c, src/dd.c, src/df.c, src/dircolors.c, src/dirname.c,
5256 * src/du.c, src/echo.c, src/env.c, src/expand.c, src/expr.c,
5257 * src/factor.c, src/fmt.c, src/fold.c, src/head.c, src/hostid.c,
5258 * src/hostname.c, src/id.c, src/install.c, src/join.c, src/kill.c,
5259 * src/link.c, src/ln.c, src/logname.c, src/ls.c, src/md5sum.c,
5260 * src/mkdir.c, src/mkfifo.c, src/mknod.c, src/mv.c, src/nice.c,
5261 * src/nl.c, src/nohup.c, src/od.c, src/paste.c, src/pathchk.c,
5262 * src/pinky.c, src/pr.c, src/printenv.c, src/printf.c, src/pwd.c,
5263 * src/rm.c, src/rmdir.c, src/seq.c, src/setuidgid.c, src/shred.c,
5264 * src/sleep.c, src/sort.c, src/split.c, src/stat.c, src/stty.c,
5265 * src/su.c, src/sum.c, src/sync.c, src/tac.c, src/tail.c, src/tee.c,
5266 * src/test.c, src/touch.c, src/tr.c, src/tsort.c, src/tty.c,
5267 * src/uname.c, src/unexpand.c, src/uniq.c, src/unlink.c, src/uptime.c,
5268 * src/users.c, src/wc.c, src/who.c, src/whoami.c, src/yes.c: Likewise.
5270 * src/cat.c (usage): Don't bother normalizing exit status
5271 since the arg is already the correct exit status now.
5272 * src/cksum.c, src/comm.c, src/csplit.c, src/cut.c,
5273 * src/dircolors.c, src/expand.c, src/fmt.c, src/fold.c, src/head.c,
5274 * src/join.c, src/md5sum.c, src/nl.c, src/od.c, src/paste.c,
5275 * src/pr.c, src/split.c, src/sum.c, src/tac.c, src/tail.c, src/tr.c,
5276 * src/tsort.c, unexpand.c, src/src/uniq.c, src/src/wc.c: Likewise.
5278 * src/chown.c (main): Removed unused local 'fail'.
5280 * src/chroot.c (CHROOT_FOUND_BUT_CANNOT_INVOKE, CHROOT_FAILURE):
5283 * src/chroot.c (main): Initialize exit_failure to EXIT_FAIL.
5284 * src/env.c, src/nice.c, src/su.c: Likewise.
5285 * src/nohup.c (main): Likewise, to NOHUP_FAILURE.
5286 * src/setuidgid.c (main): Likewise, to SETUIDGID_FAILURE.
5287 * src/expr.c (main): Use initialize_exit_failure rather than
5288 setting exit_failure directly; this optimizes away redundant
5290 * src/printenv.c, src/sort.c, src/test.c, src/tty.c: Likewise.
5292 * src/chroot.c (main): Exit with status 1 rather than 127
5293 if chroot itself fails, as per documentation.
5295 * src/chroot.c (main): Use EXIT_ENOENT and EXIT_CANNOT_INVOKE
5296 rather than roll-your-own symbols or integers.
5297 * src/env.c (main): Likewise.
5298 * src/nohup.c (main): Likewise.
5299 * src/su.c (run_shell): Likewise.
5301 * src/cp.c (exit_status): Remove static var....
5302 (main): Making it local here instead. Use =, not |=, to set it.
5304 * src/cut.c (FATAL_ERROR, main): Exit with status EXIT_FAILURE,
5306 * src/date.c (batch_convert, main): Likewise.
5307 * src/dd.c (dd_copy): Likewise.
5308 * src/pr.c (first_last_page, main, getoptarg): Likewise.
5309 * src/tr.c (main): Likewise.
5310 * src/date.c (main): Don't assume EXIT_FAILURE == 1, as
5311 POSIX doesn't require it.
5312 * src/dd.c (write_output, skip, dd_copy): Likewise.
5313 * src/df.c (main): Likewise.
5314 * src/id.c (main): Likewise.
5315 * src/install.c (main): Likewise.
5316 * src/ln.c (main): Likewise.
5317 * src/ls.c (main): Likewise.
5318 * src/mv.c (main): Likewise.
5319 * src/shred.c (main): Likewise.
5321 * src/env.c (main): Exit with status 1, not 2, on errors detected
5323 * src/hostname.c (main): Likewise.
5324 * src/nl.c (main): Likewise.
5325 * src/stty.c (main): Likewise.
5327 * src/expr.c (EXPR_FAILURE): Renamed from EXPR_ERROR, for
5328 consistency with the other programs' naming conventions.
5331 * src/factor.c (main): Do not report a usage error simply
5332 because stdin has bad numbers.
5334 * src/id.c (problems): Now a boolean int, not a counter,
5335 so that we don't have to worry about int overflow. All uses changed.
5336 * src/touch.c (err): Likewise.
5338 * src/md5sum.c (main): Use int, not size_t, to store boolean int.
5340 * src/mkfifo.c (main): Exit with status 1, not 4, if not implemented.
5341 * src/mknod.c: Likewise.
5343 * src/nice.c (main): Exit with status EXIT_FAIL, not EXIT_FAILURE,
5344 on error; this is in case EXIT_FAILURE is unusual.
5345 * src/su.c (main): Likewise.
5347 * src/nohup.c (NOHUP_FOUND_BUT_CANNOT_INVOKE): Remove; all uses
5348 changed to EXIT_CANNOT_INVOKE.
5350 * src/printenv.c (PRINTENV_FAILURE): New constant.
5351 (main): Exit with status PRINTENV_FAILURE, not EXIT_FAILURE, on
5352 command-line syntax problems.
5354 * src/rmdir.c (remove_parents): Don't set 'fail' to a negative number.
5355 (main): Avoid integer overflow when seeing whether errors occurred.
5357 * src/seq.c (print_numbers): Now returns void, not (zero) int.
5358 All callers changed.
5359 (main): Remove unused local variable 'errs'. Always exit successfully
5360 if we reach the end.
5362 * src/setuidgid.c (SETUIDGID_FAILURE): Renamed from FAIL_STATUS,
5363 for consistency with other programs here. All uses changed.
5364 (main): Use 'error' to exit rather than invoking 'exit' here.
5366 * src/sort.c: Don't include <assert.h>.
5367 (SORT_OUT_OF_ORDER, SORT_FAILURE): Now enums, not macros.
5368 (usage): Don't use 'assert'.
5369 (main): Remove redundant assignment to exit_failure.
5371 * src/system.h (EXIT_FAIL, EXIT_CANNOT_INVOKE, EXIT_ENOENT):
5373 (initialize_exit_failure): New inline function.
5374 Include exitfail.h here, since we refer to exit_failure.
5375 All callers changed to not include exitfail.h.
5377 * src/tty.c (TTY_FAILURE, TTY_WRITE_ERROR): New enum values;
5378 substitute them for the corresponding integer constants.
5380 * tests/help-version (expected_failure_status_date): Remove, as
5381 'date' is now normal.
5382 (expected_failure_status_nohup): New var.
5384 2004-01-21 Jim Meyering <jim@meyering.net>
5386 * tests/touch/relative: Remove `command' syntax.
5387 Thanks to Nelson H. F. Beebe and Paul Eggert.
5389 * tests/touch/relative: Test only year/month/day, not hours/min/sec,
5390 so as to avoid problems with systems using TAI clocks.
5391 Although it's no longer necessary, set TZ=UTC0 also for the
5392 initial touch command. Reported by Paul Jarc here:
5393 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/1504
5395 2004-01-20 Diego Biurrun <diego@biurrun.de>
5397 * src/dircolors.hin: Add .mov to the list of media files.
5399 2004-01-19 Paul Eggert <eggert@twinsun.com>
5401 * tests/touch/relative: Use TZ=UTC0, not TZ=utc (which isn't
5402 portable). Problem reported by Christian Krackowizer. Also, use
5403 +0000 rather than +0 to specify a time zone, as the documentation
5404 requires four digits.
5406 2004-01-19 Jim Meyering <jim@meyering.net>
5408 * tests/mv/hard-4: Run envvar-check in case SIMPLE_BACKUP_SUFFIX is set.
5409 * tests/mv/backup-is-src: Likewise.
5410 Problem reported by Peter Horst
5412 2004-01-17 Jim Meyering <jim@meyering.net>
5414 * announce-gen (print_changelog_deltas): Use .sig suffix, not .asc.
5418 2003-12-15 Paul Eggert <eggert@twinsun.com>
5420 * NEWS, doc/coreutils.texi: touch -r and -d can now both be specified,
5421 with -r specifying the origin for -d.
5422 * src/touch.c (flexible_date): Remove static var.
5423 (get_reldate): New function.
5424 (main): Use it, to implement this new behavior.
5426 2004-01-16 Jim Meyering <jim@meyering.net>
5428 * tests/touch/relative: New test for the above.
5429 * tests/touch/Makefile.am (TESTS): Add relative.
5431 2004-01-13 Jim Meyering <jim@meyering.net>
5433 * src/system.h: Include contents of sys2.h.
5434 * src/sys2.h: Remove file.
5435 * src/Makefile.am (noinst_HEADERS): Remove sys2.h.
5437 * Use automake-1.8.2. Regenerate dependent files.
5439 * Update to gettext-0.13.1.
5440 * configure.ac: Use gettext-0.13.1.
5441 * .x-sc_space_tab: Add m4/po.m4 to the list of exceptions.
5443 2004-01-12 Jim Meyering <jim@meyering.net>
5445 * Makefile.maint (%.sig): Use .sig suffix rather than .asc.
5447 * Makefile.maint (po-check): Ensure that cvsu works before using it.
5448 Reported by Alexandre Duret-Lutz.
5450 * src/tail.c (main): Warn about following stdin only when it's a tty.
5452 * configure.ac: Use gl_DEFAULT_POSIX2_VERSION.
5454 2004-01-10 Jim Meyering <jim@meyering.net>
5456 * tests/misc/stat-fmt: Use backticks, not `$()' notation.
5458 2004-01-09 Jim Meyering <jim@meyering.net>
5460 * configure.ac: Quote underquoted `jm_DUMMY_1' to avoid new warning.
5462 2004-01-08 Jim Meyering <jim@meyering.net>
5464 * src/stat.c (human_fstype): Use %lx, not %x format for `unsigned long'.
5465 From Andreas Schwab.
5467 * tests/Makefile.am (TESTS_ENVIRONMENT): Remove `/vg' (prerelease test
5468 remnant) from PATH component. That would cause tests in this directory
5469 not to run the just-built binaries, but rather whatever happened
5470 to be in one's PATH. Reported by Christian Krackowizer.
5472 2004-01-04 Jim Meyering <jim@meyering.net>
5474 * src/csplit.c (new_control_record): Use x2nrealloc
5475 rather than xrealloc.
5477 * src/cp.c (re_protect): Use ASSIGN_STRDUPA rather than
5479 (make_path_private): Likewise.
5481 2004-01-03 Jim Meyering <jim@meyering.net>
5483 * src/paste.c: Use `bool' (not int) as the type for a few
5485 (collapse_escapes): Rewrite to set globals rather than modifying
5487 Use size_t (not int) for all counters and related index variables.
5488 (paste_parallel): Remove needless complexity of
5489 using xrealloc in the loop; just allocate the buffers up front.
5490 Free the two temporary buffers.
5491 Move declarations of locals `down' into scope where used.
5492 (paste_serial): Remove `register' attributes.
5493 (main): Simplify delim-related code.
5494 Free `delims', now that it's malloc'd.
5496 2004-01-02 Jim Meyering <jim@meyering.net>
5498 * src/chroot.c: Include "quote.h".
5499 (CHROOT_FOUND_BUT_CANNOT_INVOKE, CHROOT_FAILURE): Define.
5500 (main): Exit with status of 127, not 1, for too-few-args,
5501 chroot failure, or chdir failure.
5502 Give a better diagnostic upon execvp failure.
5504 * src/du.c (usage): Mention that, with its current meaning,
5507 * src/tail.c (main): Warn about following stdin when it's a tty.
5508 Fail when following by name but no names are specified.
5510 2003-12-30 Jim Meyering <jim@meyering.net>
5512 * src/fold.c (main): Use memcpy, not strcpy.
5514 * src/copy.c (copy_internal): Use ASSIGN_STRDUPA rather than
5517 2003-12-28 Jim Meyering <jim@meyering.net>
5519 * src/unexpand.c (n_tabs_allocated): New global.
5520 (add_tabstop): Use x2nrealloc rather than xrealloc.
5521 * src/expand.c: Likewise.
5523 * tests/misc/expand: New file.
5524 * tests/misc/Makefile.am (TESTS): Add expand.
5526 * src/sort.c (add_temp_dir): Use x2nrealloc rather than xrealloc.
5527 (fillbuf): Use x2nrealloc rather than xrealloc.
5528 (sort): Use xnmalloc rather than xmalloc.
5531 2003-12-27 Jim Meyering <jim@meyering.net>
5533 * src/tee.c (tee): Use xnmalloc rather than xmalloc.
5535 2003-12-29 Paul Eggert <eggert@twinsun.com>
5537 * NEWS: Remove support for join -j1 FIELD, -j2 FIELD, and -o LIST1
5538 LIST2 in POSIX 1003.1-2001 hosts, as required by POSIX.
5540 * doc/coreutils.texi (join invocation): Remove documentation
5541 accordingly. Document that -t makes all separators significant.
5543 * src/join.c: Include posixver.h.
5544 (obsolete_usage): New var.
5545 (longopts): Put obsolete options first.
5546 (OBSOLETE_LONG_OPTIONS): New constant.
5547 (get_option, add_file_name): New functions.
5548 (main): Use them to support new behavior.
5549 (usage): Remove documentation for -j1 FIELD and -j2 FIELD.
5550 Do not mark -j FIELD as obsolescent; it is longstanding
5551 UNIX tradition and is a valid extension to POSIX.
5553 * tests/join/Test.pm (tv): Avoid obsolete -o usage.
5555 2003-12-28 Paul Eggert <eggert@twinsun.com>
5557 * src/join.c (add_field_list): Don't use alloca with unbounded
5558 size; just modify the argument, which is no longer const *.
5560 Various other minor cleanups, mostly to avoid the need for casts.
5562 (extract_field): Renamed from ADD_FIELD, as it's now a function.
5564 (struct field.beg): Now char *, not unsigned char const *. All
5565 uses changed. It shouldn't be const since xmemcoll writes on its
5567 (extract_field): Likewise, for 2nd arg.
5568 (keycmp): Remove now-unnecessary cast of xmemcoll args.
5570 (is_blank): New function, to avoid need to cast arg to unsigned char.
5571 (extract_field): Use it.
5573 (xfields): Rewrite pretty much from scratch.
5575 (hard_LC_COLLATE): Now bool, not int.
5576 (get_line, getseq, add_field_list): Now returns bool, not int.
5577 (decode_field_spec, add_field_list): Return true on success (not
5578 false), for consistency with the rest of the code. All uses changed.
5580 (tab): Now char, not unsigned char. This wasn't 100% necessary
5581 but is slightly cleaner.
5582 (prjoin): Hoist (tab ? tab : ' ') expression, to help the compiler.
5584 (empty_filler): Now const *.
5586 (make_blank): Remove; wasn't needed. Remove all calls.
5587 (main): Don't set uni_blank.nfields; zero is fine.
5589 2003-12-27 Jim Meyering <jim@meyering.net>
5591 * src/join.c: Include "quote.h".
5592 (min, max): Remove definitions.
5593 Make a few function parameters and corresponding
5594 locals `const'. Use bool for boolean variables.
5595 Use size_t (not int) for all counters and related index variables.
5596 (prjoin): Remove now-useless assertion.
5597 (string_to_join_field): New function.
5598 (main): Accept join fields as large as SIZE_MAX.
5599 (keycmp): Rename `min' to MIN and max to MAX.
5601 2003-12-26 Jim Meyering <jim@meyering.net>
5603 fold -s didn't work on e.g., alpha-based systems.
5604 * src/fold.c (fold_file): Adjust types (int->size_t) so that using
5605 x2nrealloc works properly on systems with differing sizes for int
5606 and size_t. Reported by Nelson Beebe.
5608 * src/fold.c: Use `bool' (not int) as the type for a few
5611 2003-12-23 Paul Eggert <eggert@twinsun.com>
5613 * src/ls.c (length_of_file_names_and_frills):
5614 Remove forward decl; not needed.
5615 (print_file_name_and_frills, length_of_file_name_and_frills):
5616 With -m, don't output spaces before inum or size.
5617 (print_with_commas): Don't output space just before newline.
5619 2003-12-24 Jim Meyering <jim@meyering.net>
5621 * tests/ls/Makefile.am (TESTS): Add m-option.
5622 * tests/ls/m-option: New file. Test for above fixes.
5624 2003-12-20 Jim Meyering <jim@meyering.net>
5628 * src/pr.c: Change type of global, buff_allocated, to size_t.
5630 * src/join.c [struct seq]: Change types of members count and alloc
5631 from `int' to `size_t'.
5633 * tests/Makefile.am (root-hint): Tweak wording.
5635 * src/du.c: Accept new option (-0, --null) that makes it so each
5636 output line is NUL-terminated rather than newline-terminated.
5638 * src/dd.c (apply_translations): Don't prohibit conv=unblock,sync.
5639 Reported by Volker Paul.
5640 * tests/dd/Makefile.am (TESTS): Add unblock-sync.
5641 * tests/dd/unblock-sync: New test for the above.
5643 2003-12-19 Jim Meyering <jim@meyering.net>
5645 * tests/misc/nohup: Double quote back-ticked expression,
5646 in case it ends up having an unexpected value.
5648 * tests/ls/no-arg: Use ls's -1 option in both runs.
5650 * src/du.c (fts_debug): New global.
5651 (FTS_CROSS_CHECK, DEBUG_OPT): Define.
5652 (main): Make fts use FTS_TIGHT_CYCLE_CHECK.
5653 (main) [DU_DEBUG]: Accept -d option.
5655 2003-12-18 Jim Meyering <jim@meyering.net>
5657 * src/ls.c (format_user): Increment dired_pos via two statements,
5658 `dired_pos += width; dired_pos++;' rather than one,
5659 `dired_pos += width + 1;' since the latter could conceivably overflow.
5660 (format_group): Likewise.
5663 * configure.ac: Require automake-1.8.
5665 2003-12-12 Jim Meyering <jim@meyering.net>
5667 * Use automake-1.8. Regenerate dependent files.
5669 2003-12-08 Jim Meyering <jim@meyering.net>
5671 * Makefile.maint (news-date-check): New rule.
5672 (alpha beta major): Depend on it.
5674 2003-12-03 Paul Eggert <eggert@twinsun.com>
5676 * NEWS: ls -l (and similar options) now adjust all columns to
5677 fit the data. Generalized from a suggestion by Leah Q for file sizes.
5678 * src/ls.c (INODE_DIGITS, LOGIN_NAME_MAX, ID_LENGTH_MAX): Remove.
5679 (format_user_width, format_group_width, unsigned_file_size,
5680 format_group): New functions.
5681 (block_size_width): Renamed from block_size_size.
5682 (inode_number_width, nlink_width, owner_width, group_width,
5683 author_width, major_device_number_width, minor_device_number_width,
5684 file_size_width): New vars.
5685 (clear_files): Initialize them.
5686 (gobble_file): Set them. Don't ceiling block_size_width to 7.
5687 (print_long_file): Use them.
5688 (gobble_file): Use a new local variable 'f' to make the code
5689 smaller and more consistent with other functions.
5690 (format_user): Output to stdout, not to a buffer, so that we
5691 don't have to worry about buffer overrun. Update dired_pos.
5692 (print_long_file): Don't put owner, group, author into buffer;
5693 just print them directly. Don't assume link counts and
5694 major and minor numbers fit into unsigned long int.
5695 * tests/cp/same-file, tests/mv/part-symlink: Don't assume that
5696 'ls' output is fixed-width.
5698 2003-12-02 Jim Meyering <jim@meyering.net>
5700 * src/md5sum.c: Include sha1.h (reflect renaming: sha.h -> sha1.h.
5702 2003-11-27 Jim Meyering <jim@meyering.net>
5704 * Use automake-1.7f. Regenerate dependent files.
5706 2003-11-24 Paul Eggert <eggert@twinsun.com>
5708 Parse floating-point operands and options in the C locale.
5709 POSIX requires this for printf, and we might as well be
5710 consistent elsewhere (tail, sleep, seq).
5712 * src/printf.c: Remove decls of strtod, strtol, strtoul; no longer
5713 needed now that we assume C89. Include "c-strtod.h".
5714 (xstrtod): Call c_strtod, not strtod.
5715 * src/sleep.c: Include "c-strtod.h".
5716 (main): Update xstrtod call to include new argument, c_strtod.
5717 * src/seq.c (scan_double_arg): Likewise.
5718 * src/tail.c (parse_options): Likewise.
5720 2003-11-24 Jim Meyering <jim@meyering.net>
5722 * tests/rm/fail-2eperm: Handle another errno variant (HPUX, EPERM).
5723 Reported by Mark Conty.
5725 2003-11-22 Jim Meyering <jim@meyering.net>
5727 * Makefile.maint (sc_xalloc_h_in_src): Remove rule. Subsumed by...
5728 (sc_system_h_headers): Do this test only if sys2.h exists.
5730 2003-11-20 Jim Meyering <jim@meyering.net>
5732 * tests/help-version: Ensure that the bug-reporting address is
5733 included in the --help output for every program.
5734 * tests/Makefile.am (TESTS_ENVIRONMENT): Add $PACKAGE_BUGREPORT.
5736 * src/ptx.c (usage): Output bug-reporting address.
5737 Reported by Dan Jacobson.
5739 2003-11-19 Jim Meyering <jim@meyering.net>
5741 * src/join.c (usage): Mention that FILE1 and FILE2 must be sorted
5742 on the join fields. Suggestion from Bruce Robertson.
5744 2003-11-18 Jim Meyering <jim@meyering.net>
5746 `od -c -w9999999' could segfault
5747 * src/od.c (dump): Use xnmalloc/free, not alloca.
5749 2003-11-16 Jim Meyering <jim@meyering.net>
5751 * Use autoconf-2.59. Regenerate dependent files.
5753 * tests/du/hard-link: Minor tweak: use mkdir -p.
5755 Fix read-from-free'd-buffer error detected by valgrind.
5756 * src/csplit.c (remove_line): Don't return a pointer to data in
5757 a freed buffer. Instead, arrange to free the buffer on the
5760 * tests/misc/csplit: New test for above fix.
5762 2003-11-11 Jim Meyering <jim@meyering.net>
5764 * src/ls.c (extract_dirs_from_files): Avoid useless copy operations.
5765 This avoids a warning from valgrind about memcpy with overlapping
5766 source and destination.
5768 * configure.ac: Require automake-1.7.8.
5770 2003-11-09 Jim Meyering <jim@meyering.net>
5772 * Use automake-1.7.9. Regenerate dependent files.
5774 * src/rm.c: Support new options: --preserve-root and --no-preserve-root.
5775 * src/chown.c: Likewise.
5777 * src/chown-core.c: Include "root-dev-ino.h".
5778 (chopt_init): Initialize new member.
5779 (change_file_owner): Support rm's new --preserve-root option.
5781 * src/remove.c: Include "root-dev-ino.h".
5782 (remove_cwd_entries): Remove now-obsolete FIXME comment.
5783 (remove_dir): Support rm's new --preserve-root option.
5785 * src/chown.c: Include "root-dev-ino.h".
5786 Add new options: --preserve-root and --no-preserve-root.
5788 * src/chmod.c: Include "root-dev-ino.h".
5789 (process_file): Use newly-factored-out ROOT_DEV_INO_CHECK and
5790 ROOT_DEV_INO_WARN macros.
5791 (get_root_dev_ino): Remove function definition, now that it's
5792 been moved to a separate file.
5793 (usage): Describe new options.
5795 * src/mv.c (rm_option_init): Initialized new member.
5797 * src/remove.h: Include "dev-ino.h".
5798 (struct rm_options): Add new member: root_dev_ino.
5799 * src/chown-core.h: Include "dev-ino.h".
5800 (struct Chown_option): Add new member: root_dev_ino.
5802 2003-11-06 Jim Meyering <jim@meyering.net>
5804 * src/paste.c (paste_parallel): Use `sizeof *var' rather than
5805 hard-coding `sizeof FILE*'.
5807 2003-11-05 Dennis Smit <ds@nerds-incorporated.org>
5809 * src/wc.c (main): Free `fstatus' so there is no confusion about
5810 whether it's leaked or not.
5811 * src/who.c (who): Likewise for `utmp_buf'.
5813 2003-11-05 Paul Eggert <eggert@twinsun.com>
5815 Fix 'cut' problems with size_t overflow and unsigned int.
5816 More generally, resize integer variables to fit use more precisely.
5817 * src/cut.c (ADD_RANGE_PAIR): Remove unnecessary parens.
5818 (struct range_pair): Make members to be of type size_t, not unsigned.
5819 (max_range_endpoint, eol_range_start): Now size_t, not unsigned.
5820 (suppress_non_delimited, output_delimiter_specified,
5821 have_read_stdin, print_kth, set_fields): Now bool, nt int.
5822 (delim): Now unsigned char, not int.
5823 (mark_printable_field, is_printable_field, is_range_start_index,
5824 set_fields, set_fields, cut_bytes, cut_fields):
5825 Use size_t, not unsigned, for field and byte counts.
5826 (hash_int): Use uintptr_t, not unsigned, for pointers converted
5827 to integers. This squeezes more info out of them.
5828 (set_fields, cut_bytes, cut_fields, main):
5829 Use bool, not int, for booleans.
5830 (set_fields): Allocate zeroed byte array with xzalloc, not xcalloc.
5832 2003-11-05 Paul Eggert <eggert@twinsun.com>
5834 * man/Makefile.am (check-programs-vs-x):
5835 Work even if $(programs) contains '$'.
5836 Work even if 'missing=1' in environment.
5837 Don't report an error simply because $(programs) outputs nothing.
5839 2003-11-05 Jim Meyering <jim@meyering.net>
5841 * Use autoconf-2.58. Regenerate dependent files.
5843 * src/tr.c (spec_init): Fix typo in last change.
5845 * src/sys2.h (case_GETOPT_VERSION_CHAR): Cast NULL to `(char *)' in
5846 call to variadic version_etc function, so that it works even on systems
5847 for which sizeof char* != sizeof int.
5848 * src/true.c (main): Likewise.
5849 * basename.c, chroot.c, cksum.c, dd.c, dirname.c, echo.c, expr.c:
5850 * factor.c, hostid.c, hostname.c, link.c, logname.c, nice.c, nohup.c:
5851 * pathchk.c, printenv.c, printf.c, pwd.c, setuidgid.c, sleep.c, stty.c:
5852 * sync.c, test.c, tsort.c, unlink.c, uptime.c, users.c, whoami.c, yes.c:
5853 Similarly, cast NULL to `(char *)' in call to variadic function,
5854 parse_long_options, so that it works even on systems for which
5855 sizeof char* != sizeof int.
5856 A similar problem was reported by Harti Brandt in
5857 http://mail.gnu.org/archive/html/bug-gnu-utils/2003-10/msg00320.html.
5859 * src/users.c (users): Free `utmp_buf' explicitly so that people
5860 don't mistake this for a real leak.
5861 Patch by Dennis Smit <ds@nerds-incorporated.org.
5863 2003-11-04 Paul Eggert <eggert@twinsun.com>
5865 * README: Document _POSIX2_VERSION.
5867 2003-11-04 Jim Meyering <jim@meyering.net>
5869 * src/tac.c (memrchr): Remove #if-0'd function.
5870 (tac_stdin_to_mem): Clean up #if-0'd code.
5872 * src/od.c (decode_format_string): Remove unnecessary casts.
5873 Use more maintainable `sizeof *var'.
5874 (main): Call decode_format_string rather than decode_one_format,
5875 now that `spec' may be NULL.
5877 * src/chmod.c (AUTHORS): Add my name.
5879 * src/split.c (next_file_name): Use `sizeof *var' rather than
5880 hard-coding `sizeof size_t'.
5882 * src/sort.c (new_key): Use xzalloc, not xcalloc (1, ...).
5884 * src/cut.c (ADD_RANGE_PAIR): Use x2nrealloc rather than xrealloc,
5885 to avoid potential overflow in pointer arithmetic.
5886 (set_fields): Use not `1', but rather `sizeof *printable_field' as
5887 second argument to xcalloc.
5888 * src/od.c (decode_format_string, dump_strings): Use x2nrealloc
5889 rather than xrealloc.
5890 * src/date.c (show_date): Likewise.
5891 * src/join.c (ADD_FIELD, initseq, getseq): Likewise.
5892 * src/pr.c (store_char): Likewise.
5893 * src/fold.c (fold_file): Likewise.
5895 * src/copy.c (triple_hash, triple_hash_no_name): Adjust to reflect
5896 type changes (unsigned int -> size_t) in hash.c.
5897 * src/cp-hash.c (src_to_dest_hash): Likewise.
5898 * src/du.c (entry_hash): Likewise.
5899 * src/ls.c (dev_ino_hash): Likewise.
5900 * src/cut.c (hash_int): Likewise. Declare function as static.
5902 2003-11-03 Jim Meyering <jim@meyering.net>
5904 * tests/misc/Makefile.am (TESTS_ENVIRONMENT): Define PACKAGE_VERSION.
5905 * tests/misc/fold: Fail the test immediately if we're not running
5906 the expected version of fold.
5908 2003-11-02 Jim Meyering <jim@meyering.net>
5910 * src/tr.c (append_normal_char, append_range, append_char_class)
5911 (append_repeated_char, append_equiv_class, spec_init): Use `sizeof *var'
5912 rather than `sizeof EXPLICIT_TYPE'. The former is more maintainable
5913 and usually shorter.
5914 * src/copy.c (copy_internal): Likewise.
5915 * src/join.c (initseq, add_field, make_blank): Likewise.
5916 * src/od.c (main): Likewise.
5917 * src/cp.c (make_path_private): Likewise.
5918 * src/tsort.c (new_item, record_relation): Likewise.
5920 * src/df.c (add_fs_type, add_excluded_fs_type, main): Likewise.
5921 (main): Also remove anachronistic cast of xmalloc return value.
5922 * src/ptx.c (alloc_and_compile_regex, main): Likewise.
5923 (main): Also remove anachronistic cast of xmalloc return value.
5924 * src/sort.c (inittables): Likewise.
5925 (sort): Also Split a long line.
5927 2003-10-25 Jim Meyering <jim@meyering.net>
5929 * src/copy.c (triple_hash, triple_hash_no_name): Adjust to reflect
5930 type changes (unsigned int -> size_t) in hash.c.
5931 * src/cp-hash.c (src_to_dest_hash): Likewise.
5932 * src/du.c (entry_hash): Likewise.
5933 * src/ls.c (dev_ino_hash): Likewise.
5934 * src/cut.c (hash_int): Likewise. Declare function as static.
5936 2003-10-21 Jim Meyering <jim@meyering.net>
5938 Don't fail when run with VERBOSE=yes.
5939 * tests/chgrp/basic: Do `set +x' before starting the subshell
5940 from which we invoke chgrp. Otherwise, the output from the
5941 VERBOSE=yes-induced `set -x' would result in spurious differences.
5942 Reported by Russel Coker via Michael Stone.
5944 2003-10-19 Jim Meyering <jim@meyering.net>
5946 chmod now uses fts to perform a directory traversal when -R is
5947 specified. Before, it operated on full path names, and as such
5948 would encounter the PATH_MAX (often 4096) limit.
5950 * src/chmod.c: Include "xfts.h".
5951 (process_file): Rename from change_file_mode.
5952 Adapt to be used with fts.
5953 (process_files): New function.
5955 2003-10-18 Jim Meyering <jim@meyering.net>
5957 * tests/du/deref-args: Ensure that du -D now dereferences all
5958 symlinks specified on the command line, not just those that
5959 reference directories.
5961 * basename.c, cat.c, chroot.c, cksum.c, comm.c, cp.c, csplit.c, cut.c:
5962 * dd.c, df.c, dirname.c, du.c, echo.c, env.c, expr.c, factor.c, head.c:
5963 * hostid.c, hostname.c, id.c, link.c, ln.c, logname.c, ls.c, md5sum.c:
5964 * mv.c, nice.c, nl.c, nohup.c, paste.c, pathchk.c, pinky.c, pr.c:
5965 * printenv.c, printf.c, pwd.c, rm.c, setuidgid.c, sleep.c, sort.c:
5966 * split.c, stty.c, sum.c, sync.c, tac.c, tail.c, tee.c, test.c:
5967 * touch.c, tsort.c, uniq.c, unlink.c, uptime.c, users.c, wc.c:
5968 * who.c, whoami.c, yes.c (AUTHORS): Revert the WRITTEN_BY/AUTHORS change
5969 of 2003-09-19. Now, AUTHORS is a comma-separated list of strings.
5970 Update the call to parse_long_options so that `AUTHORS, NULL' are the
5972 * src/true.c (main): Append NULL to version_etc argument list.
5973 * src/sys2.h (case_GETOPT_VERSION_CHAR): Likewise.
5975 2003-10-17 Andreas Schwab <schwab@suse.de>
5977 * tests/mk-script: Get $srcdir from first parameter instead of
5979 (main): Update usage.
5981 * tests/Makefile.am.in ($(srcdir)/$x-tests): Pass $(srcdir) as
5982 first argument of mk-script.
5983 ($(srcdir)/Makefile.am): Likewise. Prepend $(srcdir) to target.
5985 2003-10-17 Jim Meyering <jim@meyering.net>
5987 * src/mv.c (usage): Tweak descriptions of -i and -f so that the
5988 generated `man' page is more readable. Suggestion from Dan Jacobson.
5990 * src/chown-core.c (change_file_owner): Handle the cases in
5991 which fts_info indicates an error with the given entry.
5993 * src/du.c (main): Simply assign to bit_flags.
5994 Don't bother with bit arithmetic.
5996 * tests/chmod/no-x: New file.
5997 * tests/chgrp/no-x: New file.
5998 * tests/chmod/Makefile.am (TESTS): Add no-x.
5999 * tests/chgrp/Makefile.am (TESTS): Likewise.
6001 * src/du.c: Include "xfts.h".
6002 (du_files): Use xfts_open, rather than fts_open.
6003 * src/chown-core.c (chown_files): Likewise.
6005 2003-10-16 Jim Meyering <jim@meyering.net>
6007 * src/chgrp.c (main): Simply assign to bit_flags.
6008 Don't bother with bit arithmetic.
6009 * src/chown.c (main): Likewise.
6010 Rename a couple of local variables.
6011 Remove unnecessary casts.
6013 * src/tail.c (start_bytes): Rename local, remainder, to avoid
6014 gcc's warning about shadowing a global.
6016 2003-10-15 Jim Meyering <jim@meyering.net>
6018 chown and chgrp now accept POSIX-mandated -H, -L, -P options and
6019 use fts to perform a directory traversal when -R is specified.
6020 Before, they operated on full path names, and as such would
6021 encounter the PATH_MAX (often 4096) limit.
6022 They are more efficient. For example, before, chgrp -R would
6023 take almost 5 seconds to change about 2000 directories and fail
6024 (with `File name too long'), while now it succeeds on a hierarchy
6025 of depth 20,000 in 1/10 the time.
6027 * src/chown.c: Include "userspec.h" and "fts_.h".
6028 (WRITTEN_BY): Add my name.
6029 (getpwnam, getgrnam, getgrgid): Remove declarations.
6030 (endpwent): Remove definition.
6032 (main): Handle new options.
6033 Call new function, chown_files rather than change_file_owner.
6035 * src/chgrp.c: Include "fts_.h".
6036 (WRITTEN_BY): Add my name.
6037 (MAXUID, MAXGID): Remove definitions. Use GID_T_MAX instead of
6040 (main): Handle new options.
6041 Call new function, chown_files rather than change_file_owner.
6043 Rewrite to iterate through hierarchies using fts rather than
6044 via explicit recursion.
6045 * src/chown-core.c: Include "fts_.h"
6046 (change_file_owner): Rewrite to use FTS* and FTSENT* and to operate
6047 on a single file at a time.
6048 (chown_files): New function.
6049 * src/chown-core.h [enum Dereference_symlink]: Remove declaration.
6050 [struct Chown_option] (recurse, force_silent): Change type to `bool'.
6051 [struct Chown_option] (dereference): Remove member with ambiguous name.
6052 [struct Chown_option] (affect_symlink_referent): New member.
6053 (chown_files): New prototype.
6055 * tests/chgrp/recurse: Update tests accordingly.
6056 * tests/chgrp/posix-H: New tests for the above.
6057 * tests/chgrp/Makefile.am (TESTS): Add posix-H.
6059 * src/ln.c (usage): Clarify that --directory, -d, -F probably won't
6060 work even for superuser. Suggestion from Dan Jacobson.
6062 2003-10-14 Paul Eggert <eggert@twinsun.com>
6064 Fix some number-parsing bugs, e.g., "head -n 100k@" wasn't
6066 * lib/human.c, lib/xstrtoimax.c, lib/xstrtol.c, lib/xstrtol.h,
6067 lib/xstrtoul.c, lib/xstrtoumax.c: Sync with gnulib.
6068 * src/sort.c (parse_field_count): Handle the case where overflow
6069 and invalid suffix char are both reported.
6071 2003-10-14 Jim Meyering <jim@meyering.net>
6073 * src/ls.c (decode_switches) [TIOCGWINSZ]: Comment out the
6074 warning-inducing test, ws.ws_col <= SIZE_MAX, since it was always
6077 2003-10-13 Paul Eggert <eggert@twinsun.com>
6079 Fix to avoid a denial-of-service attack if the display width is
6080 enormous. Also, clean up the code a bit by removing duplicate code.
6082 * src/ls.c (init_column_info): Remove forward decl; no longer needed.
6083 (calculate_columns): New function, that contains code that used
6084 to be common to print_many_per_line and print_horizontal.
6085 (print_many_per_line, print_horizontal): Use it.
6086 (decode_switches): Set max_idx here, not in calculate_columns.
6087 (print_current_files): Don't call init_column_info; calculate_columns
6089 (init_column_info): Don't allocate a lot more space than is needed
6090 to represent the current set of files. Allocate all the new
6091 size_t cells in one call to xnmalloc, rather than a row at a time.
6093 2003-10-13 Jim Meyering <jim@meyering.net>
6095 * src/ls.c (init_column_info): Add another FIXME comment.
6097 2003-10-13 Paul Eggert <eggert@twinsun.com>
6099 Fix address-arithmetic bug in 'ls', reported by Georgi Guninski.
6100 Remove several arbitrary limits on hosts where int cannot represent
6103 * src/ls.c (struct bin_str.len, length_of_file_name_and_frills, indent,
6104 nfiles, files_index, tabsize, line_length, struct column_info.line_len,
6105 struct column_info.col_arr[0], max_idx):
6106 Now size_t, not int.
6107 (get_funky_string): Return bool indicating success, instead of
6108 a negative count to indicate failure. Store number of columns
6109 through new parameter OUTPUT_COUNT; that way, they can never
6110 go negative. Change equals_end from int to bool. All uses
6112 (struct column_info.valid_len): Now bool, not int. All uses changed.
6113 (dired_dump_obstack, get_funky_string, clear_files,
6114 extract_dirs_from_files, print_current_files,
6115 print_many_per_line, print_horizontal, init_column_info,
6116 put_indicator, length_of_file_name_and_frills,
6117 print_with_commas): Use size_t, not int, for local variables
6119 (decode_switches): Decode sizes using xstrtoul, not xstrtol.
6120 Check for TIOCGWINSZ returing negative values (or values greater
6122 (visit_dir, main, parse_ls_color, queue_directory, add_ignore_pattern,
6124 Use xmalloc and xnmalloc, not XMALLOC.
6125 (gobble_file): Use xnrealloc, not XREALLOC.
6126 (print_color_indicator): Remove now-unnecessary cast to size_t.
6128 2003-10-12 Paul Eggert <eggert@twinsun.com>
6130 * tests/du/no-x: Change wording of diagnostic to match latest du.c.
6131 * tests/sort/sort-tests: Remove from CVS; assume that people
6132 brave enough to check coreutils out from CVS can rebuild it.
6134 2003-10-12 Jim Meyering <jim@meyering.net>
6136 New options: --preserve-root and --no-preserve-root.
6137 * src/chmod.c (change_file_mode): Honor new option.
6138 (change_file_mode): Strip trailing slashes on directory
6139 argument passed to change_dir_mode.
6140 (get_root_dev_ino): New function.
6141 (main): Initialize global, root_dev_ino.
6143 * src/copy.c (copy_internal): Don't #ifdef-out simple uses of
6144 S_ISLNK or S_ISSOCK. The S_IS* macros are guaranteed to be defined
6146 * src/chmod.c (change_file_mode): Likewise.
6148 2003-10-08 Jim Meyering <jim@meyering.net>
6150 * src/csplit.c (main): Remove obsolete FIXME.
6152 2003-10-07 Jim Meyering <jim@meyering.net>
6154 * Use automake-1.7.8. Regenerate dependent files.
6156 2003-09-29 Paul Eggert <eggert@twinsun.com>
6160 * doc/coreutils.texi (csplit invocation):
6161 The regexp offset need not have a sign; POSIX requires support
6162 for signless offets.
6164 Be more careful about int widths. For example, remove some
6165 arbitrary limits by replacing 'unsigned' with 'size_t',
6166 'uintmax_t', etc. Use standard bool rather than a homegrown type.
6167 * lib/Makefile.am (libfetish_a_SOURCES): Add xstrtoimax.c.
6168 * src/csplit.c (FALSE, TRUE, boolean): Remove. All uses changed
6169 to <stdbool.h> usage.
6170 (struct control): offset is now intmax_t, not int.
6171 repeat_forever is now bool, not int.
6172 (struct cstring): len is now size_t, not unsigned int.
6173 (struct buffer_record): bytes_alloc, bytes_used, num_lines are now
6174 size_t, not unsigned. start_line, first_available are now
6175 uintmax_t, not unsigned.
6176 (hold_count, control_used): Now size_t, not unsigned.
6177 (last_line_number, current_line, bytes_written):
6178 Now uintmax_t, not unsigned.
6179 (save_to_hold_area, red_input, keep_new_line, record_line_starts,
6180 create_new_buffer, get_new_buffer, load_buffer, find_line,
6181 process_regexp, split_file, new_control_record, extract_regexp,
6182 get_format_width, get_format_prec, max_out):
6183 size args, locals, and returned values are now size_t, not unsigned
6185 (get_first_line_in_buffer, find_line, write_to_file,
6186 handle_line_error, process_line_count, regexp_error, process_regexp,
6188 File line, byte, and repetition counts are now uintmax_t, not unsigned.
6189 (check_for_offset): Don't require a sign before the offset.
6190 Use xstrtoimax to do the real work.
6191 (extract_regexp): Remove harmful cast of size to unsigned.
6192 256 -> 1<<CHAR_BIT, for clarity.
6193 (get_format_flags): Return at most 3, to avoid worries about overflow.
6195 (bytes_to_octal_digits): Remove.
6197 (cleanup): Don't check whether output_stream is NULL, since
6198 close_output_file does that for us.
6200 (new_line_control, create_new_buffer): Use "foo *p = xmalloc
6201 (sizeof *p);" instead of the more long-winded alternatives.
6203 (get_new_buffer): Use O(1) algorithm for resizing a buffer
6204 to a much larger size, instead of an O(N) algorithm.
6206 (process_regexp): Use plain NULL rather than casted 0.
6208 (make_filename): Use %u, not %d, to format unsigned file number.
6210 (new_control_record): Use xrealloc exclusively, since it handles
6213 (extract_regexp): Change misspelled word in diagnostic.
6215 (get_format_width): Even if a minimum field width is specified,
6216 allow room for enough octal digits to represent the value of
6217 the maximum representible integer. This fixes a potential
6218 buffer overrun. Calculate this room at compile-time, not
6219 at run-time; this removes the need for bytes_to_octal_digits.
6220 Check for overflow; this removes a FIXME.
6222 (get_format_prec): Don't allow precision to be signed; it's
6223 not ANSI. Check for overflow. Remove hardcoded "11" as
6224 default precision; this fixes a potential buffer overrun
6225 on hosts with wider size_t.
6227 (get_format_conv_type): Change local variable to be of type
6228 unsigned char, not int; this removes a potential subscript
6229 violation on hosts where char is signed.
6231 (max_out): Replace "for (;*p;)" with more-standard "while (*p)".
6232 Allow "%%" in format. Don't overflow when
6233 counting lots of percents.
6235 (usage): Default sprintf format is %02u, not %d.
6237 2003-10-05 Jim Meyering <jim@meyering.net>
6239 * src/chown-core.c (change_file_owner): Remove set-but-not-used local.
6241 * src/du.c (du_files): Mark diagnostic for translation.
6243 2003-10-04 Jim Meyering <jim@meyering.net>
6245 * src/du.c (du_files): Ignore any failure of fts_close.
6246 Give better diagnostics for failed fts_open.
6248 * src/du.c (MAX_N_DESCRIPTORS): Remove now-unused definition.
6250 Deprecate existing use of -H (aka --si).
6251 * src/du.c (enum) [HUMAN_SI_OPTION]: New member.
6252 [long_options]: Use HUMAN_SI_OPTION, not 'H'.
6253 (main): Warn that the meaning of -H will soon change to be
6256 2003-10-03 Jim Meyering <jim@meyering.net>
6258 * src/du.c: Accept --no-dereference (-P).
6260 2003-10-02 Jim Meyering <jim@meyering.net>
6262 * tests/du/trailing-slash: Adjust for slightly different output.
6264 Rewrite du.c to use fts.
6265 * src/du.c: Include "fts_.h", not ftw.h.
6266 (opt_dereference_arguments, arg_length, suffix_length): Remove globals.
6267 (IS_FTW_DIR_TYPE): Remove definition.
6268 (IS_DIR_TYPE): Define.
6269 (is_symlink_to_dir): Remove now-unnecessary function.
6270 (process_file, du_files): Rewrite to use fts.
6272 * tests/du/inaccessible-cwd: Ensure that even when run from an
6273 inaccessible directory, du can still operate on accessible
6274 directories elsewhere.
6275 * tests/du/Makefile.am (TESTS): Add inaccessible-cwd.
6277 * tests/rm/deep-1: Ensure that du can process a hierarchy
6278 of depth 400 while using no more than 50KB of stack space.
6280 2003-10-01 Akim Demaille <akim@epita.fr>
6282 * announce-gen (print_news_deltas): New function, extracted from main.
6283 (main): Make `news_file' an array.
6284 Use '...=s' => \@var for --news and --url-directory specs.
6285 Before there were a couple of portability problems.
6287 2003-09-28 Jim Meyering <jim@meyering.net>
6289 * Makefile.maint (sc_cast_of_alloca_return_value): New rule.
6290 (syntax-check-rules): Add it.
6292 * src/copy.c: Remove unnecessary cast of alloca, since now it's
6293 guaranteed to be (void *).
6294 * src/cp.c: Likewise.
6295 * src/join.c: Likewise.
6296 * src/ln.c: Likewise.
6297 * src/ls.c: Likewise.
6298 * src/od.c: Likewise.
6299 * src/sys2.h (ASSIGN_STRDUPA): Likewise.
6301 2003-09-27 Jim Meyering <jim@meyering.net>
6303 Don't exhaust virtual memory when processing large inputs.
6304 Fix this by removing csplit's internal free-list management;
6305 instead rely on malloc for that.
6307 * src/csplit.c (free_list): Remove global.
6308 (clear_all_line_control): Remove function.
6309 (get_new_buffer): Always use create_new_buffer to obtain a
6310 new buffer, rather than searching free_list.
6311 (free_buffer): Just call free.
6312 Reported by Nikola Milutinovic.
6314 2003-09-26 Jim Meyering <jim@meyering.net>
6316 * man/rm.x: Also list `chattr' in SEE ALSO section.
6317 Suggestion from Mark Hubbart.
6319 2003-09-25 Jim Meyering <jim@meyering.net>
6321 * configure.ac: Don't invoke AC_AIX or AC_MINIX explicitly, now
6322 that we use gl_USE_SYSTEM_EXTENSIONS, since it AC_REQUIREs them.
6324 * Use autoconf-2.57d. Regenerate dependent files.
6326 2003-09-24 Jim Meyering <jim@meyering.net>
6328 Minor efficiency tweak.
6329 * src/ln.c (PATH_BASENAME_CONCAT): Use memcpy rather than strcpy.
6330 (do_link): Likewise.
6332 2003-09-23 Jim Meyering <jim@meyering.net>
6334 * src/paste.c (paste_serial): Save errno after input error,
6335 to report proper errno value.
6336 Based on a patch from Paul Eggert.
6338 * src/tee.c (tee): Adjust fwrite arguments so that the return
6339 value is the number of bytes written.
6341 2003-09-16 Paul Eggert <eggert@twinsun.com>
6343 Don't assume ferror sets errno. Bug reported by Bruno Haible.
6345 * src/comm.c (compare_files): Save errno after input error,
6346 to report proper errno value.
6347 * src/fold.c (fold_file): Likewise.
6348 * src/od.c (check_and_close, skip, read_char, read_block): Likewise.
6349 * src/unexpand.c (unexpand): Likewise.
6351 * src/csplit.c (close_output_file): Don't report bogus errno value
6352 after ferror discovers an output error. We don't know the proper
6353 errno value, since it might have been caused by any of a whole
6354 bunch of calls, and it might have been trashed in the meantime.
6355 Fixing this problem will require much more extensive changes;
6356 in the meantime just say "write error".
6357 * src/od.c (check_and_close, dump, dump_strings): Likewise.
6358 * src/uniq.c (check_file): Likewise.
6360 * src/join.c (get_line): Report error right away if I/O fails,
6361 so that the proper errno value is used.
6362 * src/tac.c (tac_seekable, tac_file, save_stdin): Likewise.
6363 * src/tee.c (tee): Likewise.
6364 * src/uniq.c (check_file): Likewise.
6366 * src/od.c (skip): If a read fails, don't retry it later, so
6367 that we report the proper errno.
6369 * src/tac.c (tac_mem): Don't return a value; nobody uses it.
6371 * src/tee.c (tee): Once a write failure has occurred, don't bother
6372 writing anything more to that stream.
6374 * src/uniq.c (check_file): Check for ferror (stdout) even if
6377 * src/yes.c (UNROLL): Remove.
6378 (main): Exit immediately when write failure is detected.
6379 Simplify code by assigning to argv when argc == 1.
6381 2003-09-21 Paul Eggert <eggert@twinsun.com>
6383 * src/ptx.c: Switch encoding from Latin-1 to UTF-8.
6384 (WRITTEN_BY): Change "Franc,ois" (actually using
6385 c-with-cedilla in Latin-1) to "F.", so that it's ASCII, as
6388 2003-09-19 Jim Meyering <jim@meyering.net>
6390 `du -D symlink-to-dir' would mistakenly omit the slash in
6391 lines like this: 24 symlink-to-dir/subdir
6392 * src/du.c (process_file): Fix offset calculation.
6393 Reported by Jeff Sheinberg as Debian bug #211591;
6394 http://bugs.debian.org/205251
6396 * tests/du/deref-args: New file/test for the above.
6397 * tests/du/Makefile.am (TESTS): Add deref-args.
6399 * src/du.c (process_file): Remove useless disjunct.
6401 * src/sys2.h (case_GETOPT_VERSION_CHAR): Rename parameter, Authors,
6403 * nearly all src/*.c files (WRITTEN_BY): Rename from AUTHORS.
6404 Begin each WRITTEN_BY string with `Written by ' and end it with `.'.
6405 Mark each WRITTEN_BY string as translatable.
6407 * basename.c, cat.c, chroot.c, cksum.c, comm.c, cp.c, csplit.c, cut.c:
6408 * dd.c, df.c, dirname.c, du.c, echo.c, env.c, expr.c, factor.c, head.c:
6409 * hostid.c, hostname.c, id.c, link.c, ln.c, logname.c, ls.c, md5sum.c:
6410 * mv.c, nice.c, nl.c, nohup.c, paste.c, pathchk.c, pinky.c, pr.c:
6411 * printenv.c, printf.c, pwd.c, rm.c, setuidgid.c, sleep.c, sort.c:
6412 * split.c, stty.c, sum.c, sync.c, tac.c, tail.c, tee.c, test.c:
6413 * touch.c, tsort.c, uniq.c, unlink.c, uptime.c, users.c, wc.c:
6414 * who.c, whoami.c, yes.c: Revert yesterday's changes.
6415 Instead, a subsequent change will embed `Written by ' in
6416 each string along with the author names.
6418 * src/true.c: Revert yesterday's changes.
6419 * src/sys2.h: Likewise.
6421 2003-09-18 Jim Meyering <jim@meyering.net>
6423 * basename.c, cat.c, chroot.c, cksum.c, comm.c, cp.c, csplit.c, cut.c:
6424 * dd.c, df.c, dirname.c, du.c, echo.c, env.c, expr.c, factor.c, head.c:
6425 * hostid.c, hostname.c, id.c, link.c, ln.c, logname.c, ls.c, md5sum.c:
6426 * mv.c, nice.c, nl.c, nohup.c, paste.c, pathchk.c, pinky.c, pr.c:
6427 * printenv.c, printf.c, pwd.c, rm.c, setuidgid.c, sleep.c, sort.c:
6428 * split.c, stty.c, sum.c, sync.c, tac.c, tail.c, tee.c, test.c:
6429 * touch.c, tsort.c, uniq.c, unlink.c, uptime.c, users.c, wc.c:
6430 * who.c, whoami.c, yes.c: Update AUTHORS definition to be a
6431 comma-separated list of strings and/or update the call to
6432 parse_long_options so that `AUTHORS, NULL' are the last parameters.
6433 * src/true.c (main): Append NULL to version_etc argument list.
6434 * src/sys2.h (case_GETOPT_VERSION_CHAR): Likewise.
6436 * src/sort.c (numcompare): Rename local, logb, to log_b to avoid
6437 shadowing the math function name. Also rename loga to log_a.
6439 2003-09-14 Jim Meyering <jim@meyering.net>
6441 * src/factor.c (print_factors): Give a separate diagnostic
6442 for numbers that are too large, but otherwise valid.
6443 Reported by Dániel Varga.
6445 2003-09-10 Jim Meyering <jim@meyering.net>
6447 * Use automake-1.7.7. Regenerate dependent files.
6449 * tests/Makefile.am (all_programs): Use ../src/tr -s ' ' '\n' in place
6450 of `fmt -1'. Using the just-built tr is a little cleaner.
6451 Christian Krackowizer reported that HPUX 10.20 doesn't have fmt.
6452 * man/Makefile.am (programs, check-x-vs-1): Likewise.
6454 2003-09-09 Jim Meyering <jim@meyering.net>
6456 * src/copy.c: Alphabetize includes.
6457 Remove duplicate inclusion of "same.h".
6459 2003-09-08 Jim Meyering <jim@meyering.net>
6461 * Makefile.maint (GZIP_ENV): Remove --rsyncable.
6462 Didn't give enough of a benefit, mainly because it's not yet
6467 * man/Makefile.am (programs): Use ../src, not $(srcdir)/../src.
6468 (check-programs-vs-x): Fail if $(programs) is empty.
6470 * src/remove.c: Add a comment.
6472 2003-09-07 Jim Meyering <jim@meyering.net>
6474 * src/remove.c (D_INO, ENABLE_CYCLE_CHECK) [D_INO_IN_DIRENT]:
6475 Don't define. These symbols are no longer used.
6477 * tests/misc/tty-eof: Write ^D as \cD.
6478 Complete the change of 2003-08-02.
6480 * Makefile.maint (po-check): Use cvsu, so that a temporary source
6481 file in lib/ or src/ doesn't induce an unwarranted failure.
6482 Add a kludge to filter out the sole generated source file that
6483 also has translatable messages: src/false.c.
6485 2003-09-06 Jim Meyering <jim@meyering.net>
6487 * src/tail.c (enum): Add ALLOW_MISSING_OPTION.
6488 (parse_options): Give a diagnostic for (but still accept) the
6489 deprecated --allow-missing option.
6491 2003-09-04 Paul Eggert <eggert@twinsun.com>
6493 Don't ignore -S if input is a pipe. Bug report by Michael McFarland in
6494 <http://mail.gnu.org/archive/html/bug-coreutils/2003-09/msg00008.html>.
6496 * src/sort.c (sort_buffer_size): Omit SIZE_BOUND arg. Compute the
6497 size_bound ourselves. if an input file is a pipe and the user
6498 specified a size, use that size instead of trying to guess the
6499 pipe size. This has the beneficial side effect of avoiding the
6500 overhead of default_sort_size in that case. All callers changed.
6501 (sort): Remove static var size; now done by sort_buffer_size.
6503 2003-09-05 Jim Meyering <jim@meyering.net>
6505 * Use automake-1.7.6b and autoconf-2.57b. Regenerate dependent files.
6507 * tests/tail-2/tail-n0f: Wait .5 seconds for backgrounded process
6508 to start, rather than just .1. Upon failure, print unexpected state.
6510 2003-09-04 Paul Eggert <eggert@twinsun.com>
6512 * src/head.c (elide_tail_lines_pipe): Don't assign 0 or
6513 SAFE_READ_ERROR to tmp->nbytes.
6514 * src/tail.c (pipe_lines, pipe_bytes): Likewise.
6516 * src/head.c (struct linebuffer): Change nbytes and nlines
6517 from unsigned int to size_t. unsigned int is safe (after the
6518 2003-09-03 patch) but size_t is cleaner.
6519 * src/tail.c (struct linebuffer, struct charbuffer): Likewise.
6520 (pipe_bytes): Likewise for local variable 'i', which was 'int'.
6522 Standardize on BUFSIZ as opposed to other macro names and values.
6523 * src/head.c (BUFSIZE): Remove. All uses changed to BUFSIZ.
6524 * src/tail.c (BUFSIZ) [!defined BUFSIZ]: Remove.
6525 stdio.h has always defined it,
6526 and other code already assumes it's defined.
6527 * src/tr.c (BUFSIZ) [!defined BUFSIZ]: Likewise.
6528 (IO_BUF_SIZE): Remove; replace all uses with sizeof io_buf.
6529 (io_buf): IO_BUF_SIZE -> BUFSIZ.
6531 2003-09-04 Paul Eggert <eggert@twinsun.com>
6533 * src/seq.c (step): Default to 1.
6534 (print_numbers): Allow the output to be empty.
6535 (main): The default step is 1, even if LAST < FIRST;
6536 as per documentation.
6537 * tests/seq/basic (onearg-2): Output should be empty.
6539 2003-09-05 Jim Meyering <jim@meyering.net>
6541 * Makefile.cfg (wget_files): Temporarily disable, until master
6542 versions are restored to ftp.gnu.org.
6544 * configure.ac (AM_INIT_AUTOMAKE): Specify automake-1.7.6.
6546 Make seq's --width (-w) option work properly even when the
6547 endpoint requiring the larger width is negative and smaller than
6549 * src/seq.c (get_width_format): Include `-' in the set of bytes
6550 allowed in a `simple' number (no decimal point, no exponent).
6551 Reported by Patrick Mauritz.
6553 2003-09-02 Paul Eggert <eggert@twinsun.com>
6555 * NEWS: sort -t '\0' now uses a NUL tab.
6556 sort option order no longer matters, unless POSIX requires it.
6557 * src/sort.c (usage): Say "blanks" instead of "whitespace",
6558 Similar fixes for many comments.
6559 (TAB_DEFAULT): New constant, so that we can support NUL as
6560 the field separator.
6561 (tab): Now int, not char. Initialize to TAB_DEFAULT.
6562 (specify_sort_size): If multiple sizes are specified, use the largest.
6563 (begfield, limfield): Support NUL tab char.
6564 (set_ordering): Do not let -i override -d.
6565 (main): Report an error if incompatible -o or -t options are given.
6566 Report an error for "-t ''". Allow "-t '\0'" to specify a NUL tab.
6568 2003-09-05 Jim Meyering <jim@meyering.net>
6570 * tests/sort/Test.pm [o2, nul-tab]: New tests for the above.
6572 2003-09-03 Andreas Schwab <schwab@suse.de>
6574 Bug report and patch here:
6575 <http://mail.gnu.org/archive/html/bug-coreutils/2003-09/msg00009.html>
6576 * src/tail.c (pipe_lines): Don't truncate return value from safe_read.
6577 * src/head.c (elide_tail_lines_pipe): Likewise.
6579 2003-09-03 Jim Meyering <jim@meyering.net>
6581 * src/du.c (AUTHORS): Remove Larry McVoy's name, since the relatively
6582 small amount of code from him was first moved to lib/human.c, and was
6583 subsequently rewritten entirely.
6584 * src/df.c (AUTHORS): Likewise.
6586 2003-08-22 Lawrence Teo <lcteo@uncc.edu>
6588 * src/md5sum.c (split_3): Accept the BSD format for generic
6589 message digest modes. Currently works with BSD's MD5 and SHA1
6590 formats since these are the two algorithms presently used in
6591 coreutils. Updated comments to reflect this change.
6592 (bsd_split_3): Updated comments.
6594 * tests/md5sum/basic-1: New test to make sure that
6595 `md5sum --check' doesn't accept the BSD SHA1 format (adapted
6596 from `check-bsd' test in tests/sha1sum/basic-1).
6598 * tests/sha1sum/basic-1 (check-bsd2, check-bsd3): New tests for
6599 --check exit status and BSD SHA1 format (adapted from tests
6600 in tests/md5sum/basic-1).
6602 2003-08-30 Jim Meyering <jim@meyering.net>
6604 * src/ln.c (do_link): Use SAME_INODE rather than open-coding it.
6606 When source and destination arguments refer to the same file, reside
6607 on a partition (e.g. VFAT) on which distinct names may refer to the
6608 same directory entry (often due to variations in case), and when the
6609 link count for the file is 1, mv no longer unlinks the file. Instead,
6610 it gives the expected diagnostic that the source and destination are
6611 the same. WARNING: this is an incomplete fix. If the file happens
6612 to have a link count of 2 or greater, such an erroneous mv command
6613 will still unlink it.
6614 Although that is not possible on vfat or umsdos, it is possible on
6615 other file system types, e.g., ntfs, and hpfs.
6616 * src/copy.c (same_file_ok): Invoke same_name (which might still
6617 return false for names that refer to the same directory entry)
6618 only if the link count is 2 or more.
6619 * tests/mv/vfat: Show how to demonstrate the above problem.
6620 This test is not run.
6621 * tests/mv/Makefile.am (EXTRA_DIST): Add vfat.
6623 2003-08-27 Jim Meyering <jim@meyering.net>
6625 * src/who.c: Change meaning of -l from --lookup to --login, per POSIX.
6626 who's -l option has been eliciting an unconditional warning about
6627 this impending change since sh-utils-2.0.12 (April 2002).
6629 * src/paste.c (paste_parallel): Don't output `EOF' (aka -1) as a `char'.
6630 This would happen for nonempty files not ending with a newline.
6631 Reported by Dan Jacobson.
6632 * tests/misc/paste-no-nl: New file. Test for above-fixed bug.
6633 * tests/misc/Makefile.am (TESTS): Add paste-no-nl.
6635 * src/stat.c (print_it): Avoid buffer overrun that would
6636 occur when the user-specified format string ends with `%'.
6637 Patch by Tommi Kyntola.
6638 * tests/misc/stat-fmt: New file. Test for above-fixed bug.
6639 * tests/misc/Makefile.am (TESTS): Add stat-fmt.
6641 2003-08-26 Jim Meyering <jim@meyering.net>
6643 Apply changes from bison.
6644 * GNUmakefile (SHELL): Define to `sh', if necessary.
6646 * Makefile.maint (WGETFLAGS): Define to `-C off'.
6647 Update all uses of $(WGET).
6649 2003-08-22 Akim Demaille <akim@epita.fr>
6651 * Makefile.cfg (local-checks-to-skip): New.
6652 * Makefile.maint (local-check): Rename as...
6653 (local-checks-available): this.
6656 2003-08-26 Akim Demaille <akim@epita.fr>
6658 * announce-gen (print_changelog_deltas): Neutralize "<#" as
6659 "<\#" to avoid magic from Gnus when posting parts of this script.
6661 2003-08-25 Jim Meyering <jim@meyering.net>
6663 * src/stat.c (main): Warn about use of deprecated `-l' option.
6665 2003-08-22 Jim Meyering <jim@meyering.net>
6667 * src/stat.c (do_stat): For link count at end of line, use %h format,
6668 instead of %-5h. The latter would make stat emit trailing spaces.
6669 Reported by Dan Jacobson.
6671 2003-08-20 Jim Meyering <jim@meyering.net>
6673 * Makefile.am (EXTRA_DIST): Add .x-sc_space_tab .x-sc_sun_os_names
6675 2003-08-19 Jim Meyering <jim@meyering.net>
6677 * src/system.h: Include stdlib.h unconditionally,
6678 as we're now assuming that part of hosted C89.
6680 2003-08-18 Jim Meyering <jim@meyering.net>
6682 * src/sys2.h (textdomain, bindtextdomain) [! ENABLE_NLS]: Define away,
6683 to avoid warnings from gcc.
6685 2003-08-17 Jim Meyering <jim@meyering.net>
6687 Avoid unnecessary and sometimes time-consuming hostname lookups.
6688 * src/who.c (print_user): Use strchr, not strrchr.
6689 * src/pinky.c (print_entry): Likewise.
6690 Patch by Michael Stone.
6691 This fixes a typo I introduced in who-users.c on 1996-02-23.
6693 * Makefile.maint (makefile-check): Add 0-9 to the range of characters
6694 disallowed between `@...@'.
6696 2003-08-16 Paul Eggert <eggert@twinsun.com>
6698 * configure.ac (fu_cv_sys_truncating_statfs): Remove; now
6699 done by gnulib .m4 files.
6700 (jm_DUMMY_1): Require gl_READUTMP, not jm_PREREQ_READUTMP.
6701 * src/sys2.h (strtoull): Remove unused declaration.
6703 2003-08-16 Jim Meyering <jim@meyering.net>
6705 * man/Makefile.am (.x.1): Ensure that generated PROGRAM.1 files
6708 * src/tail.c (tail_lines): Fix a potential (but very hard to exercise)
6709 race condition bug. The bug would be triggered when tailing a file
6710 with file pointer not at beginning of file, and where the file was
6711 truncated to have a length of less than the initial offset at just
6712 the right moment (between the two lseek calls in this function).
6714 An invalid initial value for *read_pos would result in
6715 `tail -n0 -f FILE' and `tail -c0 -f FILE' doing what amounted to a
6716 busy-wait rather than sleeping between iterations. The bug manifests
6717 itself only when tailing regular files that are initially nonempty.
6718 * src/tail.c (tail_bytes): Set *read_pos to new file offset after
6720 (tail_lines): Likewise, after lseek calls.
6721 Reported by Nick Estes. See http://bugs.debian.org/205251 for details.
6722 * tests/tail-2/tail-n0f: New file. Test for above fix.
6723 * tests/tail-2/Makefile.am (TESTS): Add tail-n0f.
6725 2003-08-15 Jim Meyering <jim@meyering.net>
6727 * Makefile.maint (sc_space_tab): Use exclusion list in separate file.
6728 (sc_sun_os_names): Likewise.
6729 * .x-sc_space_tab, .x-sc_sun_os_names: New files.
6731 * man/help2man: Remove some SPACEs before TAB.
6733 2003-08-14 Paul Eggert <eggert@twinsun.com>
6735 * Makefile.maint (LC_ALL): Set to C.
6736 * man/Makefile.am (ASSORT): New var.
6737 (check-x-vs-1, programs): Use it.
6738 * src/Makefile.am (ASSORT, check-README, ../AUTHORS): Likewise.
6739 * tests/Makefile.am (ASSORT, all_programs): Likewise.
6741 2003-08-11 Jim Meyering <jim@meyering.net>
6743 fold -s -wN would infloop for N < 8 with TABs in the input.
6744 E.g., this would not terminate: printf 'a\tb' | fold -w2 -s
6745 * src/fold.c (fold_file): Move contents of `else'-block
6746 out of conditional so it's used also for --spaces (-s).
6747 * tests/misc/fold: Test for the above fix.
6748 * tests/misc/Makefile.am (TESTS): Add fold.
6750 2003-08-10 Jim Meyering <jim@meyering.net>
6752 * src/nice.c [!NICE_PRIORITY]: Include <sys/resource.h> after
6753 system.h so the types from time.h and sys/time.h are available.
6754 It appears that this is necessary for OpenBSD, NetBSD, and
6755 Darwin 6.5 (MacOS 10.2.5). Reported by Nelson Beebe.
6757 2003-08-06 Paul Eggert <eggert@twinsun.com>
6759 * NEWS: Add support for setting file timestamps to microsecond
6760 resolution, on hosts that support this.
6761 * src/copy.c, src/cp.c, src/install.c, src/touch.c: Include utimens.h.
6762 * src/copy.c (copy_internal):
6763 Set file timestamps with utimens, not utime.
6764 * src/cp.c (re_protect): Likewise.
6765 * src/install.c (change_timestamps): Likewise.
6766 * src/touch.c (newtime, touch, main): Likewise.
6768 2003-08-09 Jim Meyering <jim@meyering.net>
6770 * Makefile.maint (sc_sun_os_names): New rule based on a regexp
6772 (syntax-check-rules): Add it.
6774 * src/tail.c (main): Tweak Solaris OS version number in comment.
6775 * src/wc.c (wc): Likewise
6776 * tests/tail-2/fflush: Likewise.
6778 * src/tail.c: Add new undocumented option, --presume-input-pipe.
6779 (pipe_lines): Use memchr to skip lines, rather than an explicit loop.
6781 2003-08-08 Paul Eggert <eggert@twinsun.com>
6783 Use new gnulib 'extensions' module.
6784 * configure.ac: Invoke gl_USE_SYSTEM_EXTENSIONS instead of
6787 2003-08-08 Paul Eggert <eggert@twinsun.com>
6789 * tests/du/basic: Ensure that a/b/F has at least 65 bytes too.
6791 2003-08-09 Jim Meyering <jim@meyering.net>
6793 * tests/misc/split-fail: Reflect that `split -a 0' is now accepted.
6794 For tests of obsolete behavior, don't presume that unsetting
6795 _POSIX2_VERSION is equivalent to _POSIX2_VERSION=199209.
6797 2003-08-07 Paul Eggert <eggert@twinsun.com>
6799 * doc/coreutils.texi (split invocation):
6800 Add -d or --numeric-suffixes option to 'split'.
6801 From a suggestion by Jesse Kornblum.
6802 * src/split.c (suffix_alphabet): New var.
6803 (longopts, usage, next_file_name, main): Support -d.
6804 (next_file_name, main): Allow -a0, as POSIX requires.
6805 (next_file_name): Don't assume ASCII-like encoding;
6806 'a' through 'z' are not contiguous in EBCDIC.
6808 2003-08-05 Paul Eggert <eggert@twinsun.com>
6810 Merge getline from gnulib.
6811 * lib/getline.h, lib/getline.c, m4/getline.m4: Merge from gnulib.
6812 * lib/getndelim2.h, lib/getndelim2.c, m4/getndelim2.m4, m4/ssize_t.m4:
6813 New files, from gnulib.
6814 * lib/getdelim2.c, lib/getdelim2.h: Remove.
6815 * lib/Makefile.am (libfetish_a_SOURCES): Change getdelim2.c and
6816 getdelim2.h to getndelim2.c and getndelim2.h.
6817 * m4/jm-macros.m4 (jm_MACROS): Use gl_GETNDELIM2 rather than
6818 checking for getdelim.
6819 (jm_CHECK_ALL_TYPES): Use gt_TYPE_SSIZE_T for ssize_t rather
6820 than rolling our own.
6821 * src/cut.c: Include getndelim2.h rather than getdelim2.h.
6822 (cut_fields): Invoke getndelim2 rather than getdelim2.
6824 2003-08-04 Jim Meyering <jim@meyering.net>
6826 * src/sort.c (main): Use unsigned int instead of int for `nsigs'
6827 and for the indices to iterate through nsigs.
6829 2003-08-02 Paul Eggert <eggert@twinsun.com>
6831 * src/sort.c: Minor code cleanups, mostly to use more accurate
6832 types and to remove unnecessary casts.
6833 (min, max): Remove. All uses changed to MIN and MAX.
6834 (hard_lc_collate, hard_LC_TIME, struct buffer.eof, struct
6835 keyfield.skipsblanks, struct keyfield.skipeblanks, struct
6836 keyfield.numeric, struct keyfield.general_numeric, struct
6837 keyfield.month, struct keyfield.reverse, reverse, unique,
6838 have_read_stdin): Now bool, not int. All uses changed.
6839 (eolchar): Now char, not int.
6840 (struct keyfield.ignore): Now bool const *, not int *.
6841 (struct keyfield.translate): Now char const *, not char *.
6842 (struct month.name): Likewise.
6843 (blanks, nonprinting, nondictionary): Now bool[], not int[].
6844 (cleanup, inittables, keycompare, check, mergefps, first_same_file,
6845 check, sort, main): Use const * pointers when possible.
6846 (month_cmp): Rewrite to avoid casts.
6847 (inittables): Initialize tables unconditionally, to avoid branches.
6848 (fillbuf): Return bool, not int. All uses changed.
6849 (fillbuf, keycompare, new_key, main):
6850 Use SIZE_MAX rather than (size_t) -1.
6851 (trailing_blanks): Renamed from trim_trailing_blanks.
6852 Return the number of blanks to trim. All uses changed.
6853 (getmonth): Use trailing_blanks rather than open code.
6854 (keycompare): Do not cast char * to unsigned char *; not needed.
6855 CMP_WITH_IGNORE converts args to UCHAR, so no need to convert it
6857 (compare, main): Use | rather than || to avoid jumps.
6858 Replace "diff = NONZERO (alen)" with "diff = 1", since alen must
6860 (check, first_same_file, sort, main):
6861 Use bool instead of int local vars when possible.
6862 (check): Merge the old 'checkfp' and 'check' into a single function,
6863 that returns a boolean (true if the file was ordered).
6865 (main): Use int instead of unsigned for iterating through nsigs.
6866 Rename local var "posix_pedantic" to "posixly_correct".
6868 2003-08-02 Jim Meyering <jim@meyering.net>
6870 * src/nice.c [!NICE_PRIORITY]: Include <time.h> before <sys/resource.h>
6871 to avoid compilation error on Ultrix. Reported by Christian Krackowizer.
6873 * src/cut.c (cut_fields): Don't read again after encountering an
6874 initial EOF. E.g., `cut -f2' would do so.
6875 * tests/misc/tty-eof: Add a test for the above fix.
6877 * src/sort.c (sortlines): Add description and references.
6880 * tests/Makefile.am (TESTS_ENVIRONMENT): Set PATH so that
6881 the tests in help-version will use the just-built binaries.
6882 Reported by Christian Krackowizer.
6884 2003-07-31 Paul Eggert <eggert@twinsun.com>
6886 * NEWS: Add --rfc-2822 option to GNU date.
6887 * doc/coreutils.texi (Time directives, Options for date, Examples
6889 * src/date.c (long_options, usage, main): Likewise.
6890 * doc/getdate.texi (General date syntax): Likewise.
6891 * doc/coreutils.texi (Options for date): Fix a typo in format:
6892 it's now %d not %_d. Add URLs.
6894 2003-08-01 Jim Meyering <jim@meyering.net>
6896 * tests/shred/remove: Ensure that $? is 0 for the final `exit 0'.
6897 Otherwise, with at least the /bin/sh from HPUX 10.20,
6898 the trap code would end up converting that to exit 1 and thus an
6899 unexpected test failure. Reported by Christian Krackowizer.
6901 2003-07-31 Paul Eggert <eggert@twinsun.com>
6903 * src/ptx.c: Do not include bumpalloc.h.
6904 (WORD_TABLE): New member alloc.
6905 (ALLOC_NEW_WORD): Remove.
6906 (occurs_alloc): New var.
6907 (digest_word_file, find_occurs_in_text): Check for arithmetic
6908 overflow when computing table size. Use xrealloc rather than
6909 bumpalloc primitives.
6911 2003-07-29 Jim Meyering <jim@meyering.net>
6915 * README: When running tests as root, suggest using
6916 sudo with NON_ROOT_USERNAME=$USER.
6918 * tests/Makefile.am (all_programs): Makefile is in ../src, not
6921 2003-07-28 Jim Meyering <jim@meyering.net>
6923 * Makefile.maint (GZIP_ENV): Try Debian/gzip's new --rsyncable option.
6925 2003-07-28 Paul Eggert <eggert@twinsun.com>
6927 * lib/stdbool.hin (_Bool): Make it signed char, instead of
6928 an enum type, so that it's guaranteed to promote to int.
6929 * src/sort.c (sortlines_temp): Undo previous change.
6931 2003-07-28 Jim Meyering <jim@meyering.net>
6933 * src/sort.c (sortlines_temp): Declare local `swap' to be `int', not
6934 `bool'. Otherwise, at least one buggy compiler (alpha gcc-2.95.4)
6935 would cause lines[-1 - swap] (with swap = false) to evaluate to
6938 2003-07-27 Jim Meyering <jim@meyering.net>
6940 * tests/priv-check (my_uid): Use `!', not `^' in case pattern `[!0-9]',
6941 since /bin/sh of at least NetBSD 1.6 and OpenBSD 3.2 don't accept `^'.
6943 * src/remove.c (prompt) [! recursive]: Don't prompt about unwritable
6944 directories, as required by POSIX. Reported by Karl Berry.
6945 * tests/rm/dir-no-w: New file. Test for the above fix.
6946 * tests/rm/Makefile.am (TESTS): Add dir-no-w.
6948 * tests/mk-script: Emit `$xx', not its expansion.
6950 2003-07-27 Paul Eggert <eggert@twinsun.com>
6952 This change was inspired by a similar proposal by Stepan Kasal.
6953 * src/sort.c (mergelines, sortlines_temp): New functions.
6954 (sortlines): Use them, to reduce the number of times that
6955 we need to copy 'struct line' values. This improved CPU
6956 performance by about 30% on one 18 MB test.
6957 (sort): Don't invoke sortlines unless we have 2 or more lines.
6959 2003-07-26 Stepan Kasal <kasal@ucw.cz>
6961 * src/sort.c (sort): Don't require two `struct line's per text line,
6962 the new sort algorithm requires just 1.5.
6964 2003-07-27 Jim Meyering <jim@meyering.net>
6966 * src/pathchk.c (validate_path): Use %lu, not %ld.
6968 * src/cut.c (is_printable_field): Simplify bit arithmetic.
6970 * src/ls.c (sort_files): Put `volatile' in the right place.
6973 2003-07-26 Jim Meyering <jim@meyering.net>
6975 Use only one bit per field/offset in array, not one `int'.
6976 * src/cut.c (printable_field): Change type to `unsigned char'.
6977 (mark_printable_field, is_printable_field): New functions.
6978 Use them in place of all direct accesses of `printable_field'.
6980 * src/expand.c (parse_tabstops): Detect overflow properly.
6981 * src/cut.c (set_fields): Likewise.
6983 * src/rm.c: Include "dirname.h".
6984 (usage): Use base_name (program_name) in body of --help output.
6986 * man/Makefile.am (.x.1): ...back out the kludge of 2003-07-22.
6987 Idea from Brendan O'Dea, who suggested using
6988 `program_name = basename (argv[0]);' everywhere --
6989 can't do that, but using base_name works just fine here.
6991 * src/Makefile.am (AM_INSTALLCHECK_STD_OPTIONS_EXEMPT): Exempt test.
6993 2003-07-24 Paul Eggert <eggert@twinsun.com>
6995 Fix some POSIX-compliance problems with 'test'. This makes
6996 'test' more compatible with Bash.
6998 * NEWS, doc/coreutils.texi: Document the following.
6999 * src/test.c: Include exitfail.h.
7000 (TEST_FAILURE): New constant, used for exit status if 'test' fails.
7001 (test-syntax_error): Use it.
7002 (binary_operator): Now takes bool arg specifying whether left operand
7003 is -l ARG, so that caller determines this rather than us.
7005 (term): Use posixtest to evaluate parenthesized subexpressions.
7006 (unary_operator, one_argument): Remove support for -t without operand.
7007 (one_argument): Take argument from argv[pos].
7008 (one_argument, two_arguments, three_arguments): Advance pos.
7009 All callers changed.
7010 (three_arguments): Look for binary ops before "!". Then look
7011 for parenthesized one_argument expressions, instead of trusting
7012 expr () to do the right thing.
7013 (posixtest): Now takes number of args. All callers changed.
7014 Treat "( A B )" like "A B".
7015 (main): Set exit_failure to TEST_FAILURE. Don't depend on
7016 POSIXLY_CORRECT, as we now conform to POSIX by default.
7017 (main) [!LBRACKET]: Do not recognize "--help" or "--verbose" unless.
7018 * tests/test/Test.pm (test_vector): Add several tests to check
7019 the above. Syntax errors now exit with status 2, not 1.
7020 * man/Makefile.am (mapped_name): Use `../src/[' binary to create test.1.
7022 2003-07-26 Jim Meyering <jim@meyering.net>
7024 * tests/help-version: Adjust for above change in test behavior:
7025 `[' exits with 2, not 1, and test doesn't accept --help or --version.
7027 * Makefile.maint (ME): Don't use trick suggested in Make manual.
7028 It doesn't work for make-3.79.1. Reported by Christian Krackowizer.
7030 * Makefile.maint (sc_system_h_headers): Another syntax check.
7031 (syntax-check-rules): Add it to the list.
7033 * src/pathchk.c (validate_path): Cast strlen value to `unsigned long'
7034 so it matches `%ld' format even on 32-bit systems.
7036 * src/fmt.c (flush_paragraph): Cast field width to `int' to
7037 avoid warning on 64-bit systems.
7039 * src/ls.c (sort_files): Make `func' volatile, so it can't be
7040 clobbered by a `longjmp' into this function.
7042 2003-07-25 Jim Meyering <jim@meyering.net>
7044 * src/pathchk.c (validate_path): Use %ld format (not %d) for size_t
7047 * tests/misc/split-fail: Disable the --line-bytes=$_4gb test,
7048 because it'd evoke spurious failure on 64-bit systems.
7050 2003-07-24 Jim Meyering <jim@meyering.net>
7052 * src/dd.c (usage): Document the fact that SIGUSR1 makes dd
7053 output its current record counts. Reported by Jurriaan.
7055 * tests/wc/Test.pm (test_vector): Disable the `PIPE' tests when running
7056 `wc' with no options. This goes along with the change of 2003-07-20.
7058 2003-07-23 Jim Meyering <jim@meyering.net>
7060 Don't include headers already included by system.h:
7061 * src/tr.c: Don't include errno.h.
7062 * src/true.c: Don't include version-etc.h.
7063 * src/test.c: Don't include limits.h or error.h.
7064 * src/stat.c: Don't include unistd.h or time.h.
7065 * src/readlink.c: Don't include stdlib.h, unistd.h, or limits.h.
7066 * src/pr.c: Don't include time.h.
7067 * src/pathchk.c: Don't include errno.h.
7068 * src/nice.c: Don't include sys/time.h.
7069 * src/ls.c: Don't include stdlib.h.
7071 * basename.c, cat.c, chroot.c, cksum.c, comm.c, csplit.c, cut.c, date.c:
7072 * dd.c, dirname.c, echo.c, env.c, expand.c, expr.c, factor.c, fmt.c:
7073 * fold.c, head.c, hostid.c, hostname.c, id.c, join.c, kill.c, logname.c:
7074 * md5sum.c, nice.c, nl.c, nohup.c, od.c, paste.c, pathchk.c, pinky.c:
7075 * pr.c, printenv.c, printf.c, ptx.c, pwd.c, seq.c, setuidgid.c, shred.c:
7076 * sleep.c, sort.c, split.c, stat.c, stty.c, su.c, sum.c, tac.c, tail.c:
7077 * tee.c, test.c, tr.c, true.c, tsort.c, tty.c, uname.c, unexpand.c:
7078 * uniq.c, uptime.c, users.c, wc.c, who.c, whoami.c, yes.c:
7079 Don't include closeout.h.
7081 * tests/rm/fail-2eperm: Add a check for whether $NON_ROOT_USERNAME
7082 can access the required version of rm.
7083 * tests/rm/Makefile.am (TESTS_ENVIRONMENT): Define PACKAGE_VERSION.
7085 * tests/cut/Test.pm (out-delim3a): New test.
7087 * man/help2man: Update to version 1.33.
7089 * src/expand.c (parse_tabstops): Detect overflow in tabstop sizes.
7091 * src/dircolors.c: Include xstrndup.h.
7092 (xstrndup): Remove function, now that it's been factored out into
7095 2003-07-22 Paul Eggert <eggert@twinsun.com>
7097 * src/wc.c (wc): Fix typo in computation of file from file_x,
7098 which caused the former to be used uninitialized if file_x was
7101 2003-07-22 Jim Meyering <jim@meyering.net>
7103 * src/cut.c (set_fields): Use xcalloc in place of xmalloc+memset.
7105 * man/Makefile.am (.x.1): Substitute 's,$t/$*,$*,' on output of
7106 help2man, to avoid having `rm.td/rm' appear in rm.1. Reported by
7107 Thomas Luzat. See http://bugs.debian.org/202413 for details.
7109 * src/cut.c (main) [lint]: Initialize spec_list_string to avoid warning.
7111 * src/hostid.c: Don't include <unistd.h>. system.h already does that.
7113 * src/cut.c (set_fields): Mark all selected indices before trying to
7114 determine range endpoints.
7115 * tests/cut/Test.pm: New test for the above fix.
7117 Begin to address this comment: What if someone wants to
7118 extract the 1,000,000-th field of some huge input file?
7119 The first step is to rearrange things so that the values
7120 in the printable_field array are all 0/1 rather than 0/1/2.
7121 * src/cut.c (RANGE_START_SENTINEL): Remove.
7122 Store range-start indices in a hash table, rather than
7123 overloading the `printable_field' array.
7124 (range_start_ht): New global.
7125 (hash_int, hash_compare_ints, is_range_start_index): New functions.
7126 (print_kth): Use is_range_start_index; don't test printable_field.
7127 (set_fields): Detect overflow.
7128 (set_fields): Insert each range-start index into range_start_ht.
7129 (main): Call set_fields only once, and only after
7130 output_delimiter_specified and (if required) range_start_ht have
7133 2003-07-20 Paul Eggert <eggert@twinsun.com>
7135 * src/wc.c (get_input_fstatus): Fix typo: `stat' was being
7136 invoked with a null pointer when there were no file arguments.
7138 2003-07-20 Jim Meyering <jim@meyering.net>
7140 * Makefile.maint (sc_changelog): Add another nit-picky check.
7142 * src/wc.c (write_counts): Add a comment.
7143 (wc): Rename `file' parameter.
7144 Set new local, `file', to be the file name, or (when it's NULL)
7145 _("standard output") so that all uses of `file' use the proper value.
7146 Use STREQ, not strcmp.
7148 2003-07-20 Paul Eggert <eggert@twinsun.com>
7150 wc count field widths now are heuristically adjusted depending
7151 on the input size, if known. If only one count is printed, it
7152 is guaranteed to be printed without leading spaces.
7154 Previously, wc did not align the count fields if
7155 POSIXLY_CORRECT was set, but POSIX did not actually require
7156 this undesirable behavior, so it has been removed.
7158 * NEWS: Document this.
7159 * doc/coreutils.texi (wc invocation): Likewise.
7161 * src/wc.c (number_width): New var.
7162 (posixly_correct): Remove.
7163 (struct fstatus): New struct.
7164 (write_counts): Output fields of width number_width.
7165 Do not worry about POSIXLY_CORRECT.
7166 Use null file, not empty-string file, to denote stdin,
7167 since "" is a valid file name on some hosts.
7168 (wc, wc_file): New arg fstatus. Use it to avoid invoking fstat
7170 (wc): Avoid problems if end_pos - current_pos overflows.
7171 Do not print odd message if stdin has a read error.
7172 (get_input_fstatus, compute_number_width): New functions.
7173 (main): Use them to implement the new behavior.
7174 Ignore POSIXLY_CORRECT.
7176 * tests/wc/Test.pm: Adjust to the new output widths.
7178 2003-07-19 Jim Meyering <jim@meyering.net>
7180 * tests/rm/fail-eperm: Don't create temporary directory --
7183 * tests/shred/remove: Don't open-code test for UID != 0.
7184 Use priv-check's require-non-root instead.
7185 Update to use newer framework.
7187 * tests/help-version (expected_failure_status_expr): Record that
7188 expr exits with status of 3 for e.g., a write error.
7190 * tests/priv-check: Use `id -u' to see if we're running as root,
7191 rather than trying go write to an write-protected file.
7192 When running as root, ensure $NON_ROOT_USERNAME is valid.
7193 When running as root with `require-non-root', ensure that `.'
7194 is writable by $NON_ROOT_USERNAME, then reinvoke $0 set-user-ID
7195 to $NON_ROOT_USERNAME. If `.' is not writable, then skip the test.
7197 * src/printenv.c: Include "exitfail.h".
7198 (main): Set exit_failure rather than calling close_stdout_set_status.
7199 * src/date.c: Likewise.
7200 * src/sort.c: Likewise.
7201 * src/tty.c: Likewise.
7203 2003-07-18 Jim Meyering <jim@meyering.net>
7205 * tests/touch/not-owner: Update to use newer framework.
7207 * tests/rm/fail-eperm: Use $srcdir/../priv-check, create a temporary
7208 directory, and remove Perl-coded `you may not run as root' test.
7209 * tests/cp/fail-perm: Use $srcdir/../priv-check, rather than
7210 hard-coding something not quite equivalent.
7211 Paul Jarc reported the inconsistent diagnostics.
7213 * src/sort.c (main): Use close_stdout via atexit.
7214 Now `sort --version' and `sort --help' fail, as they should
7215 when their output is redirected to /dev/full.
7217 * src/su.c (usage): Don't call close_stdout here.
7218 (main): Use close_stdout via atexit.
7219 Now `su --version > /dev/full' fails, as it should.
7220 Somehow, the change of 2000-05-07 that purports to fix this
7223 * tests/help-version (--help/--version vs. /dev/full): Special-case
7224 `[' to protect it from expected_failure_status-`eval'.
7226 * src/uniq.c (writeline): Use a SPACE, not a TAB between the
7227 count and the corresponding line, as required by POSIX.
7228 Reported by Clement Wang.
7229 * tests/uniq/Test.pm (101, 102): Update tests of -c accordingly.
7231 * tests/expr/basic: Add tests for when exit status is 2.
7233 * src/nohup.c (NOHUP_FOUND_BUT_CANNOT_INVOKE, NOHUP_FAILURE):
7234 Use an anonymous `enum', rather than #define.
7236 2003-07-17 Paul Eggert <eggert@twinsun.com>
7238 * src/expr.c: Include "exitfail.h", "quotearg.h".
7239 (EXPR_INVALID, EXPR_ERROR): New constants.
7240 (nomoreargs, null, toarith, nextarg): Return bool, not int.
7241 (syntax_error): New function, exiting with status 2. Use it
7242 insteading of printing "syntax error" ourselves.
7243 (main): Initialize exit_failure to EXPR_ERROR.
7244 Exit with EXPR_INVALID on syntax error (too few arguments).
7245 (nextarg): Use strcmp, not strcoll; strcoll might return
7246 an undesirable 0, or might fail.
7247 (docolon, eval4, eval3): Exit with status 3 on invalid argument type
7248 or other such error.
7249 (eval2): Report an error if strcoll fails in a string comparison.
7250 * src/sort.c: Include "exitfail.h".
7251 (main): Set exit_failure, not xalloc_exit_failure and
7252 xmemcoll_exit_failure.
7253 * tests/expr/basic: Invalid value exits with status 3, not 2.
7255 2003-07-16 Jim Meyering <jim@meyering.net>
7257 * configure.ac (AC_INIT): Use 5.0.90 as the version, rather than 5.0.2,
7258 per GNU maintainer guidelines. The next non-beta release will be 5.1.
7260 This script would have caught at least two recent bugs:
7261 those in [ and kill.
7262 * tests/help-version: Revive this script.
7263 It wasn't doing anything useful, since $all_programs wasn't being
7264 defined by the invoking Makefile.am.
7265 Reflect that nohup is no longer a script, so don't exclude it.
7266 Add framework to handle the programs added since it was last run:
7267 kill, stat, unlink, [, link, readlink.
7268 Fix path-related problems deriving from the move of this script
7269 from src/ to its present location.
7270 * tests/Makefile.am (all_programs): Define.
7271 (TESTS_ENVIRONMENT): Use it.
7273 * src/kill.c (main): Fix bug introduced on 2003-05-10 (for 5.0.1)
7274 whereby kill would always attempt to operate on argv[0] and fail.
7276 * src/test.c (integer_expected_error): Improve diagnostic -- now,
7277 it also matches the one from bash's builtin test.
7278 (binary_operator): Add \n at end of diagnostic.
7280 * tests/rm/fail-2eperm: Remove setuidgid-related code. Move it to ...
7281 * tests/priv-check: Move setuidgid-related and
7282 NON_ROOT_USERNAME-checking code to this file.
7284 * README: Update section on testing as `root'.
7285 Suggestion from Paul Jarc.
7287 * src/test.c (AUTHORS): Replace 3-letter usernames with the actual
7288 names of authors that I just found in bash's builtins/test.def.
7290 Running `[' with no arguments would evoke a segfault.
7291 * src/test.c (main) [LBRACKET]: Move initialization of argv to
7292 precede potential use via test_syntax_error.
7294 * src/Makefile.am (AM_CPPFLAGS): Rename from `INCLUDES', to avoid
7295 warning from automake -Wall.
7297 2003-07-15 Jim Meyering <jim@meyering.net>
7301 * Makefile.maint (%.asc): Remove target first, so gpg doesn't
7304 * announce-gen (print_changelog_deltas): Relax tests for matching
7305 version-number line in NEWS.
7306 Change the .sig suffix to .asc here, too.
7308 2003-07-14 Jim Meyering <jim@meyering.net>
7310 * Makefile.maint (%.asc): Renamed from %.sig.
7311 Generate and use ascii-armored signatures.
7312 Use gpg's -o option.
7314 2003-07-13 Jim Meyering <jim@meyering.net>
7316 * src/nohup.c (NOHUP_FAILURE, NOHUP_FOUND_BUT_CANNOT_INVOKE): Define.
7319 * Makefile.maint (syntax-check): Move each individual check into
7321 (syntax-check-rules): This is the list of syntax-check targets.
7322 (sc_unmarked_diagnostics, sc_cast_of_argument_to_free):
7323 (sc_cast_of_x_alloc_return_value, sc_space_tab):
7324 (sc_error_exit_success, sc_xalloc_h_in_src): New targets.
7326 2003-07-12 Jim Meyering <jim@meyering.net>
7328 * configure.ac: Remove uses of OPTIONAL_BIN_ZCRIPTS and last
7329 traces of the nohup script.
7331 * src/Makefile.am (bin_SCRIPTS): Remove use of just-removed
7332 $(OPTIONAL_BIN_ZCRIPTS).
7334 * src/Makefile.am (localedir.h): Put the `2>&1' after the redirect
7335 target, not before the `>'.
7337 * src/remove.c (remove_dir): Give a diagnostic upon failed save_cwd,
7338 now that that function no longer calls `error'.
7340 * src/df.c (find_mount_point): Emit a diagnostic for each
7341 failed syscall, rather than relying on caller to do that.
7342 The caller couldn't do a good job, anyhow -- too many different
7343 ways to fail (each with a different referent).
7344 Give a diagnostic upon failed save_cwd, now that that function
7345 no longer calls `error'.
7346 (show_point): Don't diagnose find_mount_point's errors, now that
7347 it handles them itself.
7349 * src/df.c (find_mount_point): Don't let free clobber errno upon
7352 * src/sys2.h: Remove alloca-related block.
7353 * src/system.h: Include <alloca.h> here, instead.
7355 It appears that the `#pragma alloca' included via "system.h" is
7356 adequate, since join.c uses alloca, yet lacked an in-file #pragma.
7357 * src/copy.c, src/cp.c, src/df.c, src/install.c, src/ln.c:
7358 * src/ls.c, src/mv.c, src/remove.c: Remove `#pragma alloca'.
7360 * src/chown-core.c (change_file_owner): Do not restore any special
7361 permission bits (e.g., set-user-ID, set-group-ID) that are reset
7362 by chown(2) on some systems. Suggestion and insistence :-) from
7365 * tests/input-tty: Also check `test -t 1'.
7366 This is necessary on linux-2.4.21. Otherwise, the stty/basic-1
7367 test would block when run in the background.
7369 2003-07-11 Jim Meyering <jim@meyering.net>
7371 * tests/sample-test: Also fail if cat-to-create-expected-output
7372 fails. Otherwise, if both `exp' and `out' were to end up empty
7373 because of e.g., a full disk, they would mistakenly compare equal.
7375 * src/nohup.c: New file. Rewrite of nohup.sh in C.
7376 This solves a portability problem: on at least Solaris systems,
7377 when nohup.sh used the vendor /bin/sh, it would exit with status
7378 of `1' rather than the required 126 or 127 upon failure to exec
7379 the specified program.
7381 * src/Makefile.am (EXTRA_SCRIPTS): Remove definition.
7382 (bin_PROGRAMS): Add nohup.
7383 (EXTRA_DIST): Remove nohup.sh.
7384 (all_programs): Remove use of $(EXTRA_SCRIPTS).
7385 * src/nohup.sh: Remove file.
7386 * man/Makefile.am (nohup.1): Depend on nohup.c, rather than nohup.sh.
7388 * tests/misc/nohup: Tests for the above.
7389 * tests/misc/Makefile.am (TESTS): Add nohup.
7391 * src/head.c (diagnose_copy_fd_failure): New function, renamed from
7392 the macro, COPY_FD_DIAGNOSE.
7393 (diagnose_copy_fd_failure): Enclose diagnostic in _(...).
7394 (head_file): Likewise.
7396 * src/date.c: Include "quote.h".
7397 (batch_convert): Use the quote function rather than using literal `...'
7400 * src/setuidgid.c (main): Enclose diagnostic in _(...).
7401 * src/fmt.c (main): Likewise.
7402 * src/mknod.c (main): Likewise.
7403 * src/tac.c (tac_seekable): Likewise.
7404 * src/yes.c (main): Likewise.
7405 * src/od.c (main): Likewise.
7406 * src/install.c (change_attributes): Likewise.
7408 2003-07-10 Jim Meyering <jim@meyering.net>
7410 * src/head.c (usage): Use 1024*1024 in place of 1048576.
7411 * src/tail.c (usage): Likewise.
7413 * tests/rm/fail-2eperm: Now that we have setuidgid, use it in
7414 place of the kludge in this test. Suggestion from Paul Jarc.
7416 * src/Makefile.am (noinst_PROGRAMS): Define to setuidgid.
7417 * src/setuidgid.c: New program, solely for testing (not installed).
7419 * src/chown-core.c (change_file_owner): Don't leak file descriptors
7420 when dereferencing symlinks.
7422 2003-07-09 Jim Meyering <jim@meyering.net>
7424 * tests/du/slash: New file/test for today's lib/ftw.c fix.
7425 * tests/du/Makefile.am (TESTS): Add slash
7427 * src/tail.c (xlseek): Avoid warning about ``return without value
7428 from function returning non-void''.
7430 2003-07-08 Jim Meyering <jim@meyering.net>
7432 * man/help2man: Update to version 1.29.
7434 * man/help2man: Add END handler to close STDOUT and check for errors.
7436 2003-06-30 Paul Eggert <eggert@twinsun.com>
7438 Add support for a "[" that conforms to the GNU coding standards,
7439 i.e., that does not depend on its name.
7440 * src/lbracket.c: New file.
7442 * man/Makefile.am (programs): Ignore "[", since it doesn't have
7443 a separate man page.
7444 * src/Makefile.am (bin_PROGRAMS): Add "[".
7445 (__SOURCES): New var.
7446 * src/test.c (LBRACKET): Define to 0 if not defined.
7447 (main): Use LBRACKET rather than argv[0].
7449 * src/test.c (one_argument): Do not check for -t if POSIXLY_CORRECT.
7450 Reported by Paul Jarc and Dan Jacobson.
7452 * src/test.c (main): Do not recognize --help or --version if
7453 POSIXLY_CORRECT, when invoked as "test". Handle "[ ]" correctly.
7454 Do not bother testing that margv[margc] is non-null.
7456 2003-07-04 Jim Meyering <jim@meyering.net>
7458 * src/who.c (print_line): Rewrite to use asprintf, in order to be
7459 able to avoid emitting trailing spaces. Reported by Dan Jacobson.
7461 * tests/misc/head-elide-tail: Add tests of head's new --lines=-N
7462 option, and perform the +1600 invocations of head IFF the envvar
7463 RUN_EXPENSIVE_TESTS is set.
7465 2003-07-03 Jim Meyering <jim@meyering.net>
7467 * src/cp.c (do_copy): Give a better diagnostic when failing due
7468 to nonexistent destination directory. Reported by Dmitry Rutsky.
7469 See http://bugs.debian.org/199730 for details.
7471 2003-06-27 Jim Meyering <jim@meyering.net>
7473 split's --verbose option did nothing [broken in 4.5.10 and 5.0]
7474 * src/split.c (longopts): Use `1', not `0' as the value for
7475 for &verbose. Reported by Keith Thompson.
7477 Test for the above fix.
7478 * tests/misc/split-a: Also use --verbose and compare stderr
7479 output with what we'd expect.
7481 2003-06-20 Jim Meyering <jim@meyering.net>
7483 * src/copy.c (copy_internal) [HAVE_STRUCT_STAT_ST_AUTHOR]:
7484 Use `error_t' (rather than int) as type for local `err'.
7485 From Alfred M. Szmidt.
7487 2003-06-19 Marcus Brinkmann <marcus@gnu.org>
7489 * src/copy.c (copy_internal) [HAVE_STRUCT_STAT_ST_AUTHOR]:
7490 Fix author preservation code.
7492 2003-06-19 Jim Meyering <jim@meyering.net>
7494 * src/ln.c (ENABLE_HARD_LINK_TO_SYMLINK_WARNING): Define to 0.
7495 (do_link): Don't warn about hard link to symlink.
7497 2003-06-18 Jim Meyering <jim@meyering.net>
7499 * src/cut.c: Include "getdelim2.h", not "getstr.h".
7500 Reflect renaming: getstr -> getdelim2.
7502 * src/comm.c, src/join.c, src/nl.c, src/uniq.c: Reflect renaming:
7503 readline -> readlinebuffer.
7505 2003-06-09 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
7507 * src/readlink.c: Include <sys/types.h> before system.h (because
7508 the latter includes <sys/stat.h>). Required on Ultrix 4.3.
7510 2003-06-17 Jim Meyering <jim@meyering.net>
7512 * src/system.h (initialize_main): Define.
7513 Use it in every `main'. Applied via this:
7514 p='initialize_main (&argc, &argv);'
7515 perl -ni -e '/program_name.=.argv.0/ and print " '"$p"'\n"; print' \
7516 $(grep -l program_name.=.argv.0 *.c)
7517 test.c uses margc/margv, so I made the change manually for that file.
7518 Based on a patch from Bernard Giroud.
7520 2003-06-09 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
7522 Fix for build failure on Ultrix 4.3.
7523 * src/stat.c: Include sys/statvfs.h in preference to sys/vfs.h.
7524 Include sys/param.h and sys/mount.h on ultrix.
7526 2003-06-16 Jim Meyering <jim@meyering.net>
7528 * src/touch.c (O_NDELAY, O_NONBLOCK, O_NOCTTY, EISDIR): Remove
7530 * src/system.h (O_NDELAY, O_NONBLOCK, O_NOCTTY, EISDIR): Define
7531 them here instead, but with one change: define EISDIR to -1, not 0.
7533 * src/cat.c (cat): Remove `#ifndef ENOSYS', now that it's
7534 guaranteed to be defined.
7535 * src/system.h (ENOSYS, ENOTSUP): Define to -1 if not defined.
7537 * README: Mention the CVS repository.
7538 Encourage addition of test cases.
7540 2003-06-12 Jim Meyering <jim@meyering.net>
7542 * src/touch.c (touch): Call close only if necessary.
7545 * src/wc.c (usage): Correct wording: wc prints counts in the order
7546 `newline, word, byte'. Reported by Keith M. Briggs.
7547 * man/wc.x: Fix it here, too. And change `lines' to `newlines'.
7549 2003-06-10 Jim Meyering <jim@meyering.net>
7551 * tests/date/Test.pm: Add a test for the new format, e.g., May-23-2003.
7553 2003-06-07 Jim Meyering <jim@meyering.net>
7555 * Makefile.maint (syntax-check): Add commented-out (over-aggressive)
7558 2003-06-06 Jim Meyering <jim@meyering.net>
7560 * src/extract-magic (main): Avoid newer 3-arg form of open,
7561 so this script works also with e.g., perl5.005_03.
7562 Patch by John David Anglin.
7564 2003-06-04 Paul Eggert <eggert@twinsun.com>
7566 * src/system.h: Include <stdbool.h> unconditionally.
7568 2003-06-04 Jim Meyering <jim@meyering.net>
7570 * man/Makefile.am (check-programs-vs-x): Rename target
7571 from check-programs-vs-1. Adjust rule to check for the
7572 primary (.x) file, not the generated one (.1).
7574 2003-06-03 Tim Mooney <mooney@dogbert.cc.ndsu.NoDak.edu>
7576 * man/kill.x: New file.
7577 * man/Makefile.am (dist_man_MANS): Add kill.1.
7580 2003-06-04 Jim Meyering <jim@meyering.net>
7582 Ensure that the .x file for a new program is never forgotten again.
7583 * man/Makefile.am (programs): Define.
7584 (check-programs-vs-1): New phony target.
7585 (check-local): Depend on it.
7587 2003-06-03 Jim Meyering <jim@meyering.net>
7589 Avoid unnecessary copying of environment.
7590 * src/env.c (main): Rather than clearing the environment and --
7591 unless told to ignore environment -- copying all settings from
7592 the saved, original environment, clear the environment only when
7593 that is requested. Suggested by Jens Elkner.
7595 2003-06-02 Jim Meyering <jim@meyering.net>
7597 * src/system.h: Always include <string.h>, since we assume C89.
7598 Include <limits.h> without checking for HAVE_LIMITS_H.
7600 * src/test.c [!TEST_STANDALONE]: Remove #if-0'd block.
7601 (STREQ, S_IXUGO): Remove redundant (in system.h) definitions.
7603 2003-06-01 Jim Meyering <jim@meyering.net>
7605 Avoid a race condition in `tail -f' described by Ken Raeburn in
7606 http://mail.gnu.org/archive/html/bug-textutils/2003-05/msg00007.html
7607 * src/tail.c (file_lines): Add new parameter, *read_pos, and set it.
7608 (pipe_lines, pipe_bytes, start_bytes, start_lines): Likewise.
7609 (tail_bytes, tail_lines, tail): Likewise.
7610 (tail_file): Use the new `read_pos' value as the size,
7611 rather than stats.st_size from the fstat call.
7613 2003-05-28 Jim Meyering <jim@meyering.net>
7615 * src/extract-magic: Allow expansion of `$file' in the here-
7616 document corresponding to the comment at the top of fs.h.
7618 2003-05-26 Jim Meyering <jim@meyering.net>
7620 * src/stat.c: Fix portability problem on FreeBSD5.0: don't include
7621 <sys/statvfs.h> on systems without HAVE_STRUCT_STATVFS_F_BASETYPE.
7622 Use #if/#elif/... cascade so we get only one set of include files.
7623 Reported by Nelson Beebe.
7625 2003-05-24 Jim Meyering <jim@meyering.net>
7627 * src/md5sum.c (split_3): Accept the BSD format only when in MD5 mode.
7628 * tests/sha1sum/basic-1: Make sure `sha1sum --check' doesn't
7629 accept the BSD format.
7631 2003-03-28 Joe Orton <jorton@redhat.com>
7633 * src/md5sum.c (bsd_split_3): New function.
7634 (split_3): Detect checksums from BSD 'md5' command and handle them
7637 * tests/md5sum/basic-1: New tests for --check exit status, and for
7638 BSD-style checksum files.
7640 2003-05-21 Jim Meyering <jim@meyering.net>
7642 * src/head.c (elide_tail_lines_pipe): Fix a thinko.
7643 This sort of thing is why it'd be *Really Good* to factor
7644 out the common code used here and in tail.c.
7646 2003-05-14 Jim Meyering <jim@meyering.net>
7648 * src/head.c (usage): Document new feature: --bytes=-N and --lines=-N.
7650 * tests/du/slink: Skip this test if `.' is on an XFS file system.
7652 * tests/du/fd-leak: New file. Test for the bug in du that
7653 was fixed by the 2003-05-12 change to lib/ftw.c.
7654 * tests/du/Makefile.am (TESTS): Add fd-leak.
7656 * src/head.c (AUTHORS): Enclose string in N_(...), now that it
7657 includes a translatable word, `and'.
7659 * src/dd.c (usage): Don't use `,' as the thousands separator
7660 in e.g. 1,000,000 and 1,048,576. Instead, do this:
7661 `SIZE may be ..., MB 1000*1000, M 1024*1024 and so on...'
7662 * src/df.c (usage): Likewise.
7663 * src/du.c (usage): Likewise.
7664 * src/ls.c (usage): Likewise.
7666 * Makefile.maint (syntax-check): Add another check.
7668 2003-05-13 Paul Eggert <eggert@twinsun.com>
7670 Fix uniq to conform to POSIX, which requires that "uniq -d -u"
7671 must output nothing. Problem reported by Josh Hyman.
7673 * src/uniq.c (enum output_mode, mode): Remove, replacing with:
7674 (output_unique, output_first_repeated, output_later_repeated):
7675 New vars. All uses of "mode" changed to use these variables,
7676 which are not mutually exclusive as "mode" was.
7677 (writeline): New arg "match", used to control whether to
7678 obey output_first_repeated or output_later_repeated.
7679 All callers changed.
7680 (check_file, main): Adjust to above changes.
7682 * tests/uniq/Test.pm: Test that 'uniq -d -u' outputs nothing.
7684 2003-05-14 Jim Meyering <jim@meyering.net>
7686 * tests/rm/rm3: Use tr's \n notation rather than \012.
7687 This package can afford to do that, since its tests are guaranteed use
7688 GNU tr, which has accepted the more modern notation for 10 years.
7689 * tests/rm/rm5: Likewise.
7690 * tests/cp/same-file: Likewise.
7691 * tests/stty/row-col-1: Likewise.
7692 * tests/stty/basic-1: Likewise.
7693 * tests/rm/deep-1: Likewise.
7694 * tests/mv/part-symlink: Likewise.
7695 * tests/mkdir/perm: Likewise.
7696 * tests/misc/nice: Likewise.
7698 2003-05-13 Jim Meyering <jim@meyering.net>
7700 * src/copy.c (struct F_triple) [name]: Remove const attribute.
7701 (triple_free): Don't apply cast to argument of free.
7702 (seen_file): Add cast here instead.
7704 * src/cp-hash.c (struct Src_to_dest) [name]: Remove const attribute.
7705 (src_to_dest_free): Don't apply cast to argument of free.
7707 * src/sort.c (zaptemp): Don't apply cast to argument of free.
7708 * src/pr.c (init_fps, init_store_cols): Likewise.
7709 * src/join.c (delseq, freeline): Likewise.
7710 * src/expr.c (OLD): Likewise.
7711 * src/sort.c (sort): Likewise.
7712 * src/head.c (elide_tail_lines_pipe): Likewise.
7714 * src/tail.c: Include "quote.h".
7715 Use quote in diagnostics. Change many error format strings
7716 from just `%s' to e.g., `error reading %s'.
7717 (pipe_lines): Change type of parameter, n_lines, to uintmax_t.
7718 Rewrite newline-counting loop to use memchr.
7720 * src/head.c (elide_tail_lines_pipe): Use `if', not assert.
7721 Now that assert is no longer used, don't include <assert.h>.
7723 2003-05-12 Jim Meyering <jim@meyering.net>
7725 * src/head.c: Include <assert.h>.
7726 (AUTHORS): Add my name.
7727 (elide_tail_lines_pipe): New function.
7729 2003-05-10 Jim Meyering <jim@meyering.net>
7731 * Makefile.maint (syntax-check): Check for `error (EXIT_SUCCESS,'.
7733 * src/readlink.c (main): Set program_name before first use.
7734 Remove that (redundant) first use.
7735 Don't exit successfully just because --verbose was specified.
7736 Pass 0, not EXIT_SUCCESS, as first argument to error; when that
7737 parameter is 0, error does not exit.
7739 * src/uname.c (main): When failing due to too many arguments, also say
7740 that, rather than just "Try `uname --help' for more information.".
7741 * src/comm.c (main): Likewise, but for too few arguments.
7742 * src/logname.c: Include error.h.
7743 (main): Say why we're failing.
7745 * src/uniq.c (main): Don't segfault when argc < optind.
7746 * src/who.c (main): Handle argc < optind.
7747 * src/df.c (main): Likewise.
7748 * src/install.c (main): Likewise.
7749 * src/mv.c (main): Likewise.
7750 * src/pwd.c (main): Likewise.
7751 * src/tty.c (main): Likewise.
7752 * src/chroot.c (main): Likewise.
7753 * src/hostname.c: Likewise.
7754 * src/du.c (main): Likewise.
7755 * src/expand.c (main): Likewise.
7756 * src/env.c (main): Likewise.
7757 * src/unexpand.c (main): Likewise.
7758 * src/printenv.c (main): Likewise.
7759 * src/sync.c (main): Handle argc == 0.
7760 * src/expr.c (main): Likewise.
7761 * src/printf.c (main): Likewise.
7762 * src/basename.c (main): Likewise.
7763 * src/ln.c (main): Test for `missing argument' before computing n_files.
7764 * src/tail.c (main): Test for the case of no arguments before
7767 * src/kill.c (send_signals): Don't check command line arguments here.
7768 (main): Check them here instead. Handle argc < optind.
7770 * src/logname.c (main): Use error, rather than fprintf, for the sake
7773 * src/rm.c (main): Don't overrun array bound if argc is 0.
7775 2003-05-09 Jim Meyering <jim@meyering.net>
7777 * src/sort.c (main): Don't overrun array bound if argc is 0.
7778 That would happen when invoked via: execl ("/usr/bin/sort", NULL);
7779 Reported by Wartan Hachaturow.
7781 2003-05-07 Jim Meyering <jim@meyering.net>
7783 Implement support so that `head --lines=-N' works on seekable files.
7784 * src/head.c (enum Copy_fd_status): Define.
7785 (COPY_FD_DIAGNOSE): New macro.
7786 (elide_tail_lines_seekable): New funtion.
7787 (elide_tail_lines_file): Call it here.
7789 2003-05-06 Jim Meyering <jim@meyering.net>
7791 * src/sys2.h (CHAR_BIT): Remove duplicate definition.
7793 2003-05-04 Jim Meyering <jim@meyering.net>
7795 * tests/head/Test.pm: Remove tests of --bytes=-N; using that framework
7796 caused the addition of thousands of small files to the tar archive.
7797 * tests/misc/head-elide-tail: New file. Add them here instead.
7798 * tests/misc/Makefile.am (TESTS): Add head-elide-tail.
7800 2003-05-04 Paul Eggert <eggert@twinsun.com>
7802 * src/remove.c (HAVE_WORKING_READDIR): Define to 0 if not defined.
7803 (IF_READDIR_NEEDS_REWINDDIR): Remove.
7804 (remove_cwd_entries): Rewrite to avoid IF_READDIR_NEEDS_REWINDDIR,
7805 which was a bit weird because it couldn't be emulated by a function.
7807 2003-05-03 Jim Meyering <jim@meyering.net>
7809 Extend head to accept --lines=-N (--bytes=-N) and to print all
7810 but the N lines (bytes) at the end of the file.
7811 * src/head.c: Include full-write.h, full-read.h, inttostr.h, quote.h.
7812 Use quote() in diagnostics, rather than literal `' marks.
7813 (copy_fd, elide_tail_bytes_pipe, elide_tail_bytes_file):
7815 (elide_tail_lines_pipe, elide_tail_lines_file): New functions.
7816 (head_file): Reorganize so as to call head from only one place.
7817 (main): Likewise, for head_file.
7818 Handle new, undocumented option, --presume-input-pipe.
7819 Handle negative line and byte counts.
7820 * tests/head/Test.pm: Add lots of tests to exercise --bytes=-N.
7822 * tests/du/8gb: Skip test if the file system of `.' doesn't support
7823 sparse files -- otherwise it'd create a file of size 8GB.
7825 2003-05-02 Jim Meyering <jim@meyering.net>
7827 * src/fmt.c (usage): Don't mention obsolescent -WIDTH option.
7828 Instead explain about `-' and standard input.
7829 (main): Give a proper diagnostic for e.g., `fmt -c -72'.
7830 Reported by Keith Thompson.
7831 * tests/fmt/basic: Add test for the above fix.
7833 * src/fmt.c: Include "quote.h".
7834 Use quote() in diagnostics, rather than literal `' marks.
7835 (main): Exit nonzero when unable to open an input file.
7836 * tests/fmt/basic: Add test for the above fix.
7838 * src/fmt.c (main): Diagnose invalid suffix on obsolescent width
7839 specifications like `-72x'.
7840 * tests/fmt/basic: Add test for the above fix.
7842 Work around nasty readdir bug on Darwin6.5.
7843 * src/remove.c (IF_READDIR_NEEDS_REWINDDIR): Define.
7844 [! HAVE_WORKING_READDIR] (remove_cwd_entries): If readdir has just
7845 returned NULL and there has been at least one successful unlink or
7846 rmdir call since the opendir or previous rewinddir, then call
7847 rewinddir and reiterate the loop.
7849 Factor out common code.
7850 * src/remove.c (readdir_ignoring_dotdirs): New function.
7851 (is_empty_dir): Use it here.
7852 (remove_cwd_entries): Use it here.
7854 2003-05-01 Jim Meyering <jim@meyering.net>
7856 * tests/rm/r-3: Create 500 rather than just 300 files.
7857 There's a bug in Darwin6.5's readdir that shows up only with
7859 Fix a bug in this test: `cd $pwd' (not to `..'), now that $tmp
7863 Change type of n_units, n_bytes, n_lines to be `uintmax_t'.
7864 (dump_remainder): Move two declarations `down' into the scope
7865 where they are used.
7866 (xlseek): Return the resulting offset.
7867 (file_lines): Rename parameter, file_length, to end_pos.
7868 (pipe_lines): Don't coerce safe_read return value to `int'.
7869 Adapt tests accordingly.
7870 (pipe_bytes) [struct charbuffer] (nbytes): Change type from `int'
7872 Change type of `total_bytes' from `int' to `size_t',
7873 since the former wouldn't always be wide enough.
7874 Don't coerce safe_read return value to `int',
7875 and adapt tests accordingly.
7876 Now that testing for a read error no longer involves
7877 using `tmp', handle that case *after* freeing `tmp'.
7878 (start_bytes): Clean up.
7879 (tail_bytes): Now that `n_bytes' may be larger than
7880 OFF_T_MAX, test for that condition and, if it's true, don't
7881 use lseek optimizations.
7882 (parse_options): Don't fail just because N_UNITS is larger than
7883 the maximum size of a file -- tail may be applied to an input
7884 stream (e.g., a pipe) with more data than that.
7886 * Makefile.maint (syntax-check): Rename from alloc-check.
7887 Also check for SPACE-TAB sequences.
7888 Also check for malloc/calloc/realloc casts.
7890 2003-05-01 Jim Meyering <jim@meyering.net>
7892 * src/tail.c (start_lines): Rewrite to use memchr. Clean up.
7894 2003-04-28 Jim Meyering <jim@meyering.net>
7896 * tests/misc/tty-eof: Send two tokens, not just one, so we don't
7897 make the now-more-picky tsort fail.
7899 2003-04-24 Jim Meyering <jim@meyering.net>
7901 * src/tsort.c (tsort): Remove unnecessary test of have_read_stdin.
7902 (main): Minor syntactic clean-up.
7904 * src/tsort.c (tsort): Fail if the input contains an odd number of
7905 tokens. Reported by junkio@cox.net.
7907 * tests/tsort/basic-1: Test for the above fix.
7909 2003-04-21 Jim Meyering <jim@meyering.net>
7911 * tests/misc/printf: Add tests for the printf fixes below.
7913 * Makefile.cfg (cvs_files): Add $(srcdir)/config/depcomp to the list.
7915 2003-04-20 Paul Eggert <eggert@twinsun.com>
7917 Fix printf POSIX compatibility bug reported by Ben Harris in
7918 <http://mail.gnu.org/archive/html/bug-coreutils/2003-04/msg00070.html>.
7919 * doc/coreutils.texi (printf invocation): It's \NNN in the format,
7920 \0NNN in the %b operand.
7921 * src/printf.c (usage): Likewise.
7922 (print_esc): New arg OCTAL0 to specify whether \0NNN or \NNN
7923 is desired. All uses changed. Behave like Bash printf if %b
7924 operand uses \NNN where the initial N is not 0.
7926 2003-04-17 Jim Meyering <jim@meyering.net>
7928 * src/stty.c: Remove uses of PROTOTYPE macro.
7930 2003-04-15 Jim Meyering <jim@meyering.net>
7932 * Makefile.maint: Remove (or replace-with-TAB(s) to retain alignment)
7933 each sequence of spaces before a TAB character.
7935 2003-04-13 Jim Meyering <jim@meyering.net>
7937 * src/remove.c (is_empty_dir): Don't closedir (NULL).
7939 2003-04-12 Jim Meyering <jim@meyering.net>
7941 Giving nl an invalid STYLE argument (in --header-numbering=STYLE (-h),
7942 --body-numbering=STYLE (-b), or --footer-numbering=STYLE (-f)) or
7943 FORMAT (--number-format=FORMAT (-n)) would not give a useful diagnostic.
7944 * src/nl.c (main): Fix those problems and remove literal quote marks
7945 (e.g., "`%s'") from format string; instead use "%s" in each format
7946 string and `quote (optarg)' as the corresponding argument.
7947 Also, diagnose all invalid command line options before failing.
7949 * src/nl.c (proc_text): Fix a bug that would make nl output extra
7950 newlines in some cases. Details here: http://bugs.debian.org/177256.
7951 This bug was introduced on 2001-11-10 for textutils-2.0.17.
7952 * tests/misc/nl: Add test for the above-fixed bug.
7954 * tests/misc/readlink: New file. Test the --canonicalize option.
7955 * tests/misc/Makefile.am (TESTS): Add readlink.
7957 2003-04-11 Jim Meyering <jim@meyering.net>
7960 * src/chown.c, src/cp.c, src/dircolors.hin, src/du.c, src/ln.c:
7961 * src/mkfifo.c, src/ptx.c, src/spline.c, src/stty.c, src/tail.c:
7962 * src/test.c, src/unexpand.c: Remove (or replace-with-TAB(s) to
7963 retain alignment) each sequence of spaces before a TAB character.
7965 * src/ls.c: Include <stdlib.h> unconditionally.
7967 * Makefile.maint (xalloc-check): Rename from header-check.
7969 * src/yes.c: Include error.h after system.h, not before.
7972 * src/copy.c, src/cp-hash.c, src/cp.c, src/csplit.c, src/cut.c:
7973 * src/date.c, src/df.c, src/du.c, src/expand.c, src/expr.c, src/id.c:
7974 * src/join.c, src/md5sum.c, src/nl.c, src/od.c, src/paste.c, src/pr.c:
7975 * src/ptx.c, src/sort.c, src/split.c, src/su.c, src/tail.c, src/tee.c:
7976 * src/tr.c: * src/unexpand.c, src/users.c:
7977 Remove anachronistic casts of xmalloc, xrealloc, and xcalloc
7978 return values and of xrealloc's first argument.
7979 Fix the former with this:
7980 perl -pi -e 's/\([^(]*?\*\) *(x(m|c|re)alloc)\b/$1/'
7982 2003-04-10 Jim Meyering <jim@meyering.net>
7984 * src/stty.c (wrapf): Declare with format attribute.
7986 The S_MAGIC_... names shouldn't be maintained in two places (prior
7987 to this change, one would have to keep stat.c and fs.h in sync).
7988 This change makes it so those names and the corresponding
7989 hexadecimal constants all reside in stat.c. fs.h is now generated.
7990 * src/Makefile.am (fs.h): New rule to generate fs.h from stat.c.
7991 (BUILT_SOURCES): Add fs.h, now that it's generated.
7992 (EXTRA_DIST): Add extract-magic.
7993 * src/extract-magic: New script to extract fs.h definitions from stat.c.
7994 * src/stat.c (human_fstype) [__linux__]: Append each hex constant from
7995 fs.h in a comment after the corresponding `case S_MAGIC_...:' statement.
7997 * tests/tail-2/big-4gb: Skip this test (don't fail) if creating a
7998 file with nominal length > 4GB fails. Reported by Michael Deutschmann.
8000 * man/unexpand.x: Add `SEE ALSO' reference to expand.
8001 * man/expand.x: Add `SEE ALSO' reference to unexpand.
8002 Suggestion from Dan Jacobson.
8004 2003-04-10 Maciej W. Rozycki <macro@ds2.pg.gda.pl>
8006 * src/fs.h (S_MAGIC_DEVPTS): New magic for Linux's devpts.
8007 * src/stat.c (human_fstype): Handle Linux's devpts.
8009 2003-04-09 Paul Eggert <eggert@twinsun.com>
8011 * src/split.c (line_bytes_split): Arg is of type size_t, since
8012 that's all that is supported for now.
8013 (main): Check for overflow in obsolescent line count option.
8015 2003-04-09 Jim Meyering <jim@meyering.net>
8017 * tests/misc/split-fail: Add a new test for the above fix.
8019 * src/split.c (bytes_split): Use size_t temporary (rather than
8020 uintmax_t original) in remaining computations. From Paul Eggert.
8022 Handle command line option arguments larger than 2^31.
8023 This allows e.g., splitting into files of size 2GB and larger,
8024 and running split --lines=N with N=2^31 or more.
8025 But for --line-bytes=N, the restriction that N <= SIZE_MAX
8026 remains (for now), due to the way it is implemented.
8028 * src/split.c: Include "inttostr.h".
8029 (bytes_split, lines_split, line_bytes_split, main):
8030 Use uintmax_t, not size_t, for file sizes.
8031 (main): Give a better diagnostic for option arguments == 0.
8032 Use umaxtostr to print file sizes.
8033 Reported by Luke Hassell.
8035 2003-04-08 Jim Meyering <jim@meyering.net>
8037 * src/rm.c (usage): Mention that --directory (-d) works only
8038 on some systems. Suggestion from Samuel Tardieu.
8040 * tests/basename/basic: Run $PERL to see if it is available,
8041 rather than testing its value.
8042 * tests/sum/sysv, tests/tsort/basic-1, tests/unexpand/basic-1:
8043 * tests/basename/basic, tests/dd/skip-seek, tests/dircolors/simple:
8044 * tests/expr/basic, tests/factor/basic, tests/fmt/basic:
8045 * tests/ls-2/tests, tests/md5sum/basic-1, tests/md5sum/newline-1:
8046 * tests/misc/sort, tests/misc/tty-eof, tests/mv/i-1:
8047 * tests/rm/empty-name, tests/rm/fail-eperm, tests/rm/unreadable:
8048 * tests/seq/basic, tests/sha1sum/basic-1, tests/sha1sum/sample-vec:
8049 * tests/sum/basic-1, tests/seq/basic: Likewise.
8051 * tests/misc/Makefile.am (TESTS): Add split-fail.
8052 * tests/misc/split-fail: New file.
8054 * src/split.c: Rename local variables: nchars -> n_bytes.
8055 (lines_split): Rename local, nlines -> n_lines.
8056 (main): Rename local variable: s/accum/n_units/.
8057 (main): Use STDIN_FILENO, not literal `0'.
8059 2003-04-07 Jim Meyering <jim@meyering.net>
8061 * src/stat.c: Add #include directives for Ultrix 4.4.
8062 Based on a suggested change from Bert Deknuydt.
8064 2003-04-06 Jim Meyering <jim@meyering.net>
8066 * Makefile.maint (makefile-check): New rule.
8067 (local-check): Add it.
8069 2003-04-05 Jim Meyering <jim@meyering.net>
8071 * Makefile.am (nearly all of them):
8072 Use $(VAR) rather than @VAR@, now that we can rely on automake to
8073 emit a definition for each substituted variable.
8074 * tests/Makefile.am.in: Likewise.
8076 * tests/rm/rm5: Add a comment explaining why this test fails when
8077 using Tru64's broken sed.
8078 * tests/rm/rm3: Likewise.
8080 Make `kill -t' output signal descriptions (not `?') on Tru64.
8081 * src/kill.c (sys_siglist): Also check for __sys_siglist.
8082 Patch by Tony Leneis.
8083 * configure.ac: Also check for declaration of __sys_siglist.
8084 Required for Tru64 4.0D, 4.0F, and 5.1.
8085 Reported by Tony Leneis.
8087 2003-04-04 Jim Meyering <jim@meyering.net>
8089 * src/Makefile.am (PERL): Remove unnecessary definition.
8091 Because of inappropriate (but POSIX-mandated) behavior of rename,
8092 `mv a b' would not remove `a' in some unusual cases. Work around
8093 this by unlinking `a' when necessary.
8095 * src/copy.c (same_file_ok): Add an output parameter.
8096 Set it in the offending case.
8097 (copy_internal): When necessary, unlink SRC_PATH and inform caller.
8098 Reported by Ed Avis.
8099 * tests/mv/hard-4: New test for the above.
8100 * tests/mv/Makefile.am (TESTS): Add hard-4.
8102 Clean up rules for automatically generated sources:
8103 * src/Makefile.am (dircolors.h, wheel-size.h, wheel.h, false.c):
8104 Make each generated file be read-only.
8105 Add each file name to BUILT_SOURCES separately.
8106 (MAINTAINERCLEANFILES): Set to $(BUILT_SOURCES).
8108 Put LOCALEDIR macro definition in new file: localedir.h.
8109 * src/Makefile.am (DEFS): Remove definition.
8110 (localedir.h): New rule.
8111 (BUILT_SOURCES, DISTCLEANFILES): Add localedir.h.
8112 * src/system.h: Include "localedir.h".
8114 2003-04-02 Jim Meyering <jim@meyering.net>
8118 * tests/misc/Makefile.am (TESTS): Add false.
8120 * Makefile.maint (TMPDIR): Make sure it's defined.
8121 (my-distcheck): Build in $(TMPDIR), not `.'.
8123 * src/Makefile.am (false.c): Change all occurrences of
8124 `(EXIT_SUCCESS)' to `(EXIT_FAILURE)' so that false exits
8125 unsuccessfully also with --help. Reported by Paul Jarc,
8126 * tests/misc/false: New test for the above.
8128 2003-03-30 Jim Meyering <jim@meyering.net>
8130 * NEWS: Note the location of older NEWS files.
8132 * src/remove.c (is_empty_dir): Don't let a failing closedir
8133 clobber errno. Spotted by Arnold Robbins.
8135 * src/env.c: Fix typo in comment. From Arnold Robbins.
8137 2003-03-29 Jim Meyering <jim@meyering.net>
8141 * README: Note to expect build problems for stat.c on Ultrix 4.3.
8142 Note that there are some harmless test failures when running
8143 `make check' as root on some systems.
8145 2003-03-28 Jim Meyering <jim@meyering.net>
8147 * tests/stty/row-col-1: Skip this test if stty can't get window size.
8148 This happens when connecting to sparc-solaris5.7 via ssh from within
8149 emacs. Reported by Karl Berry.
8151 * tests/du/basic: Use seq, not `yes' to generate 4KB of data.
8152 Otherwise, on systems (DJGPP) that emulate pipes using files,
8153 this test would never complete, waiting for `yes' to terminate.
8154 * tests/du/slink: As above, use seq, not `yes' to generate link target.
8155 * tests/rm/hash: As above, use seq, not `yes' to generate dir name.
8156 Reported by Rich Dawe.
8158 2003-03-27 Jim Meyering <jim@meyering.net>
8160 * src/id.c: Remove Arnold Robbins' obsolete e-mail address
8161 from `written by...' comment, at his request.
8163 2003-03-24 Paul Eggert <eggert@twinsun.com>
8165 Fix buffer overrun problem reported by TAKAI Kousuke, along
8166 with some other POSIX incompatibilities.
8168 * src/printf.c (print_esc): Do not treat \x specially if
8169 POSIXLY_CORRECT. Avoid buffer overrun if the format ends
8170 in backslash. Treat incomplete escape sequences as strings
8171 of characters, as POSIX requires.
8172 (print_formatted): Allow multiple flags. Avoid buffer overrun
8173 if the format is incomplete.
8175 2003-03-24 Jim Meyering <jim@meyering.net>
8177 * tests/misc/printf: Add tests for the above fixes and changes.
8179 2003-03-26 Jim Meyering <jim@meyering.net>
8181 * src/copy.h (struct cp_options): Add a comment.
8183 2003-03-23 Jim Meyering <jim@meyering.net>
8185 * README: Describe problem with 64-bit mode on HPUX 11.x,
8186 with patch for /usr/include/inttypes.h.
8187 * TODO: Plan to add an autoconf test to work around the bug.
8189 2003-03-22 Jim Meyering <jim@meyering.net>
8191 * src/stat.c: Don't include <sys/sysmacros.h>.
8192 That is already done via system.h. Otherwise, the multiple
8193 inclusion would evoke redefinition warnings from Cray's /bin/cc,
8194 aka Cray Standard C Version 4.0.3 (057126) Mar 22 2003 22:02:28.
8195 (human_fstype): Factor some directives `up', out of this function.
8196 Cast away `const' to avoid error from Cray's /bin/cc.
8198 2003-03-20 Jim Meyering <jim@meyering.net>
8200 * announce-gen (print_changelog_deltas): Ensure that a newline
8201 precedes each row of `*'s.
8203 2003-03-20 Jim Meyering <jim@meyering.net>
8207 * src/seq.c (valid_format): Also accept ` ' and `'' as valid
8208 format flag characters.
8209 Do not require that a field width be specified.
8210 Do not fail when given a field width of `0'.
8211 Reported by Dan Jacobson.
8212 * tests/seq/basic: Add new tests for the above-fixed bug.
8214 * src/Makefile.am (all-local): Append $(EXEEXT) to use of `su'
8215 (install-root): Likewise.
8216 (install-exec-local): Likewise.
8217 Based on a patch from Richard Dawe.
8219 2003-03-19 Jim Meyering <jim@meyering.net>
8221 * man/Makefile.am (.x.1): Use $(LN_S) instead of 'ln -s',
8222 because the DJGPP 2.03 port of 'ln -s' doesn't work.
8223 Include $(EXEEXT) in program names.
8224 Since $(LN_S) may degenerate to `cp -p', be careful
8225 to invoke it from the destination directory.
8226 Mostly from Richard Dawe.
8227 * configure.ac: Use AC_PROG_LN_S.
8229 * tests/mv/part-symlink: Unset CDPATH. Otherwise, having the
8230 CDPATH shell variable set could cause this test to fail.
8231 Reported by Karl Berry.
8233 2003-03-18 Jim Meyering <jim@meyering.net>
8235 * src/fmt.c [struct Word] (paren, period, punct, final): Change the
8236 type of each member from bool <MEMBER>:1 to unsigned int <MEMBER>:1.
8237 AIX 5.1's xlc could not compile the former.
8238 Patch by Petter Reinholdtsen. Also reported by Mike Jetzer.
8240 2003-03-17 Richard Dawe <rich@phekda.freeserve.co.uk>
8242 * configure.ac: Include $(EXEEXT) in OPTIONAL_BIN_PROGS'
8243 program names, since automake only adds $(EXEEXT) to programs
8246 2003-03-16 Jim Meyering <jim@meyering.net>
8248 * src/remove.c (rm): Put two local variables in static storage,
8249 so they can't be clobbered by the potential longjmp.
8251 2003-03-15 Jim Meyering <jim@meyering.net>
8253 * Makefile.cfg (gnu_rel_host): Fix code to match the comment
8254 so that a version number with a two-digit component can still count
8255 as an alpha release. Reported by Richard A Downing.
8256 (gnu_rel_host): Define in terms of $(RELEASE_TYPE) instead.
8258 2003-03-14 Jim Meyering <jim@meyering.net>
8260 * src/ansi2knr.c: Remove no-longer-used file.
8261 * src/ansi2knr.1: Likewise.
8263 * Makefile.maint (prev_version_file): Don't use ?= for this particular
8264 assignment, since it causes trouble with old versions of GNU make
8265 (e.g. 3.76.1). The other uses of `?=' are inoffensive. Details here.
8266 http://mail.gnu.org/archive/html/bug-coreutils/2003-03/msg00028.html
8267 Patch from Alexandre Duret-Lutz.
8269 * Use patched automake-1.7.3. Regenerate Makefile.in files in
8270 subdirectories so that each includes a definition of ACLOCAL_M4.
8272 * announce-gen (main): Label the compressed source URLs.
8276 * tests/du/slink: Relax the test for the `local'ness of a file system,
8277 so that now it works also for tmpfs.
8279 * tests/du/hard-link: Transform output from first du, so that this
8280 test doesn't fail on file systems like tmpfs that order directory
8281 entries differently.
8283 2003-03-13 Jim Meyering <jim@meyering.net>
8285 * tests/du/8gb: Work around what appears to be an NFS failure that
8286 would make this test fail on some systems.
8288 2003-03-11 Jim Meyering <jim@meyering.net>
8290 * tests/du/basic: Make the test file exactly 4k bytes long.
8292 * src/split.c (longopts): Don't hard-code `2' here.
8293 Instead, just specify `&verbose', and ...
8294 (main): ... remove the `case 2:' block for --verbose.
8296 * tests/du/basic: Make the test file larger than 64 bytes, so that
8297 we don't immediately disqualify file systems (e.g., NetApp) on which
8298 smaller files take up zero disk blocks. Reported by Vin Shelton.
8300 2003-03-10 Jim Meyering <jim@meyering.net>
8302 Don't segfault for a negative field width or precision in format string.
8303 Note that this is just a stopgap fix. The longer term solution may
8304 involve adapting bash's builtins/printf.def.
8306 * src/printf.c: (UNSPECIFIED): Define.
8307 (print_direc): Use the special value, UNSPECIFIED, to indicate
8308 that field_width or precision has not been specified.
8309 (print_formatted): Fail if field_width or precision is the
8310 special value, UNSPECIFIED.
8311 Reported by Oliver Kiddle <okiddle@yahoo.co.uk>
8313 * src/sys2.h (INT_MIN): Define, if necessary.
8314 * tests/misc/printf: Add a test for the above-fixed bug.
8316 2003-03-09 Jim Meyering <jim@meyering.net>
8318 * src/remove.c (AD_stack_pop): Cast sizeof... to int before
8319 changing its sign. This avoids a warning from gcc on 64-bit systems.
8320 Reported by Bob Proulx.
8321 (pop_dir): Reverse order of sign change and cast, to be consistent
8324 2003-03-08 Jim Meyering <jim@meyering.net>
8326 * tests/Makefile.am (evar-check): Check for POSIXLY_CORRECT not as a
8327 shell variable, but only in the environment. With /bin/sh->bash, the
8328 shell variable is set to `y', and that would cause a spurious warning.
8329 Reported by Bob Proulx.
8331 * tests/Makefile.am (check-root): Remove touch/fifo.
8332 It doesn't appear to have to be run as root.
8334 * tests/rm/fail-2eperm: Rather than simply using the first non-root
8335 user name, make sure that the selected user name has a usable shell.
8336 Reported by Paul Jarc.
8338 Before, when using shred on a device, one had to specify --exact,
8339 or be careful to choose a size that would not be rounded up and
8340 exceed the maximum value; that could result in a failure of
8342 * src/shred.c (do_wipefd): --exact is now the default for non-regular
8343 files. Suggestion from Ben Elliston.
8346 * tests/misc/tty-eof: Require at least version 1.11 of Expect.pm.
8347 Old versions of Expect.pm (e.g., 1.07) lack the log_user function.
8348 Patch by Bob Proulx.
8350 * src/Makefile.am (check-misc): Check for use of `defined' in
8352 Change to $(srcdir) before running grep.
8354 * src/sleep.c: Remove now-unused #include and #define directives.
8356 * src/du.c (process_file): If a file's size is not being counted
8357 e.g., because it's a hard link to a file we've already counted,
8358 then don't print a line for it.
8360 * tests/du/hard-link: New test for the above-fixed bug.
8361 * tests/du/Makefile.am (TESTS): Add hard-link.
8364 * src/du.c: Revert most of the `reorganization' change of 2003-02-20,
8365 and make the two-array approach work.
8367 * tests/du/basic: Correct/add tests for the above fix.
8368 Set LC_ALL, etc., now that we use sort.
8369 Check the block/size of a small file, too.
8370 Correct expected results for simple dir1/dir2/file case.
8371 Add another test of du -S.
8373 2003-03-07 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
8375 Avoid build failure with gcc on hppa1.1-hp-hpux10.20 (see GCC PR
8376 middle-end/9986). As one of GCC's optimizations, it transforms a
8377 fputs_unlocked call to a fputc_unlocked call when the string is
8378 one character long. However, hpux doesn't have fputc_unlocked.
8380 * expr.c (usage): Use putchar, not fputs, to output a single character.
8381 * ls.c (dired_dump_obstack): Likewise.
8382 * ptx.c (output_one_tex_line, output_one_dumb_line): Likewise.
8383 * stat.c (print_it): Likewise.
8385 2003-03-07 Jim Meyering <jim@meyering.net>
8387 * src/cp.c: Remove everything associated with mmap-stack.c.
8388 This reverts the two changes of 2003-02-21.
8389 * src/du.c: Remove everything associated with mmap-stack.c.
8390 This reverts the change of 2003-02-19.
8392 2003-03-06 Jim Meyering <jim@meyering.net>
8394 * tests/cp/same-file: Unset CDPATH. Otherwise, having the
8395 CDPATH shell variable set could cause this test to fail.
8396 Reported by Karl Berry.
8398 2003-03-05 Jim Meyering <jim@meyering.net>
8402 * src/printf.c (print_esc): Remove pointless comparison of unsigned
8403 integer with zero, to avoid a warning from Intel's ecc.
8404 Reported by Nelson Beebe.
8406 * src/du.c (process_file): Sizes must all be of type uintmax_t.
8407 Otherwise, for files or totals that are too big, numbers would
8408 be truncated. Patch mostly by Michael Stone.
8409 Reported by Ingo Saitz as Debian bug #183210.
8411 * tests/du/8gb: New test for the above-fixed bug.
8412 * tests/du/Makefile.am (TESTS): Add 8gb.
8414 * src/du.c (MAX_N_DESCRIPTORS): Use 3 * UTILS_OPEN_MAX / 4
8415 rather than UTILS_OPEN_MAX - 10.
8417 2003-03-04 Jim Meyering <jim@meyering.net>
8419 * README: Refer new feature discussion to bug-coreutils@gnu.org,
8420 rather than bug-gnu-utils, now that the former is better known.
8421 Suggestion from Göran Uddeborg.
8423 * src/stat.c (usage): Capitalize consistently.
8424 Reported by Göran Uddeborg.
8426 * Makefile.maint (rel-files): Include $(signatures), so that
8427 those files are also copied into $(release_archive_dir).
8429 * src/df.c (find_mount_point): Call error here, now that restore_cwd
8431 * src/remove.c (AD_pop_and_chdir): Likewise.
8433 * tests/Makefile.am (check-root): Add fail-2eperm.
8435 2003-03-03 Jim Meyering <jim@meyering.net>
8437 * src/remove.c (remove_cwd_entries): Include the full filename of
8438 the offending file, not just the basename.
8440 * tests/misc/tty-eof: Set $ME properly.
8442 * Makefile.maint (THIS_VERSION_REGEXP, PREV_VERSION_REGEXP):
8443 Remove now-unused variables.
8444 (tag-prev-version, prev-cvs-tag): Likewise.
8446 * src/remove.c (remove_cwd_entries) [!ROOT_CAN_UNLINK_DIRS]: Give an
8447 accurate diagnostic when failing to remove a file owned by some other
8448 user. Reported by Ivo Timmermans via Michael Stone.
8449 This fixes Debian bug# 178471.
8451 * tests/rm/Makefile.am (TESTS): Add fail-2eperm.
8452 * tests/rm/fail-2eperm: New test, for the above-fixed bug.
8453 Based on a report from Ivo Timmermans.
8455 2003-03-02 Jim Meyering <jim@meyering.net>
8457 * src/copy.c (copy_internal) [un_backup]: When recovering from a
8458 failure to create a hard link, do not remove the entry associating
8459 the source dev/ino with the destination file name.
8460 * tests/mv/Makefile.am (TESTS): Add hard-3.
8461 * tests/mv/hard-3: New test, for the above-fixed bug.
8462 Inspired by a report from Iida Yosiaki.
8464 2003-03-01 Jim Meyering <jim@meyering.net>
8466 * src/df.c (print_header): Don't embed spaces in a separate `Type'
8467 header string. Instead, put `Filesystem' and `Type' headers in the
8468 same string, so translators can use horizontal space as needed.
8469 Reported by Jean Charles Delepine.
8471 2003-02-28 Jim Meyering <jim@meyering.net>
8473 * src/copy.c (copy_internal): When link fails because of an
8474 existing destination file, unlink that file and try again.
8475 Reported by Iida Yosiaki.
8477 * tests/mv/Makefile.am (TESTS): Add hard-2.
8478 * tests/mv/hard-2: New test for the above-fixed bug.
8479 Based on a test case from Iida Yosiaki.
8481 2003-02-26 Jim Meyering <jim@meyering.net>
8483 * tests/du/basic: Don't test du's -b option here. Directory byte
8484 counts are smaller (512 rather than 4096) on at least OSF/1 5.1
8485 and IBM AIX 4.2. Reported by Nelson Beebe.
8487 2003-02-25 Jim Meyering <jim@meyering.net>
8489 * Makefile.maint (announcement): Now that ChangeLog entries
8490 are output by announce-gen, don't do it here.
8491 * announce-gen (print_changelog_deltas): New function.
8494 2003-02-22 Jim Meyering <jim@meyering.net>
8496 * announce-gen: New option: --release-type=TYPE
8497 * Makefile.maint (beta, major): New targets. Remove `release'.
8498 Put them all together on a line.
8499 Pass the release type (via RELEASE_TYPE envvar) to the MAKE
8500 invocation of `announcement'.
8501 (announcement): Invoke announce-gen with --release-type=$RELEASE_TYPE.
8503 * announce-gen: New option: --news=NEWS_FILE.
8504 Extract NEWS entries here, not via rules in Makefile.maint.
8505 * Makefile.maint (announcement): Now that NEWS entries are
8506 extracted by announce-gen, don't do it here.
8507 (news-r1, news-r2): Remove now-unused definitions.
8509 2003-02-21 Jim Meyering <jim@meyering.net>
8513 Merge in changes from autoconf's version of this file.
8514 * Makefile.maint (www-gnu): Define.
8515 (standards.texi-url_prefix): Use $(www-gnu).
8516 (make-stds.texi-url_prefix): Likewise.
8518 * src/cp.c: Include "mmap-stack.h".
8519 (main): Invoke `run' through a macro that (when possible) runs it
8520 with a large, mmap'd stack.
8522 * src/cp.c (run): New function, preparing for the above.
8523 Exit from this function, not from main
8526 * src/du.c: New option: --apparent-size.
8527 (enum) [APPARENT_SIZE_OPTION]: New member.
8528 (long_options): Add it.
8529 (usage): Describe it.
8531 ['b']: Set apparent_size.
8532 David Eisner reported that the behavior of --bytes had changed.
8533 Paul Eggert proposed the use of a new option, --apparent-size.
8535 * src/du.c (apparent_size): New global.
8536 (print_only_size): Reflect the fact that we're printing byte counts,
8537 not ST_NBLOCKSIZE-byte-block counts.
8538 (print_size): Call print_only_size rather than duplicating its code.
8539 (process_file): Accumulate byte counts, rather than block counts.
8541 * src/du.c (process_file): Always reset size_to_propagate_to_parent
8542 for --separate-dirs (-S).
8544 2003-02-20 Jim Meyering <jim@meyering.net>
8546 * Use automake-1.7.3. Regenerate dependent files.
8548 * src/stat.c (print_stat): New format: %B (to print ST_NBLOCKSIZE).
8549 This makes %b (number of ST_NBLOCKSIZE-byte blocks) more useful.
8550 (usage) [%B]: Describe it.
8553 * src/du.c (process_file): Reorganize the code to use only
8554 one `sum' array, and change how -S works back to the way it was
8555 before 2003-01-31. Patch by Bruno Haible.
8557 * tests/du/basic: New test.
8558 * tests/du/Makefile.am (TESTS): Add basic.
8560 * tests/envvar-check: Add checks for the following:
8561 BLOCK_SIZE, DU_BLOCK_SIZE, DF_BLOCK_SIZE, LS_BLOCK_SIZE.
8563 * tests/Makefile.am: Rename phony target envvar-check to evar-check
8564 so as not to conflict with the distributed file by the same name.
8566 * src/du.c (process_file): Set info->skip before any possible return.
8568 Report correct usage for directories, not 0.
8569 * src/du.c (process_file): Return for `file_type == FTW_DPRE'
8570 _before_ recording the dev/ino of a directory.
8571 Reported by Bruno Haible.
8573 Now, df always displays the device file name corresponding to the
8574 listed mount point under `Filesystem'. Before, for an unmounted
8575 block- or character-special file argument, it would display the
8576 command-line argument instead.
8577 * src/df.c (show_disk): Return a value indicating whether
8578 there was a match. Don't try to find a mount point here.
8579 (show_entry): If show_disk doesn't find a match, call show_point.
8581 2003-02-19 Jim Meyering <jim@meyering.net>
8583 * src/du.c: Include "mmap-stack.h".
8584 (du_files): Add prototype with ATTRIBUTE_NORETURN.
8585 Exit from this function, not from...
8587 Instead, if possible, invoke du_files through a macro that
8588 runs it with a large, mmap'd stack.
8590 * src/join.c (usage): Change wording in --help output:
8591 use FILENUM instead of `SIDE' and say what FILENUM means.
8592 Reported by Bernhard Gabler.
8594 * src/df.c (print_header): Rather than using a hard-coded literal
8595 string of spaces matching the length of the English `...Type' header,
8596 output the right number of spaces to match the selected translation.
8597 Reported by Yann Dirson and Jean Charles Delepine as Debian bug 131113.
8599 * src/split.c (bytes_split): Remove unnecessary `else' after break.
8600 (lines_split): Likewise. and correct misleading indentation.
8602 * src/split.c: Include "full-read.h".
8603 (bytes_split, lines_split, line_bytes_split): Use full_read,
8604 not safe_read. The way split was using the latter, a short read
8605 could cause split to terminate before EOF.
8607 * tests/misc/tty-eof: Test all programs that can read stdin,
8608 requiring no arguments and that write to standard output.
8610 * tests/misc/tty-eof: New file. Renamed from ...
8611 * tests/misc/cat-tty-eof: Remove file. Rename to tty-eof.
8612 * tests/misc/Makefile.am (TESTS): Reflect renaming.
8614 2003-02-18 Jim Meyering <jim@meyering.net>
8616 cksum would perform an extra read after encountering EOF
8617 * src/cksum.c (cksum): Exit the loop upon EOF, too.
8618 Patch by Michael Bacarella.
8620 Test for the bug fixed today in cksum, md5sum, and sha1sum.
8621 * tests/misc/cat-tty-eof: Generalize, clean-up, and test for
8622 cat, cksum, md5sum, and sha1sum all in the same loop.
8624 2003-02-14 Jim Meyering <jim@meyering.net>
8626 * src/remove.c: Include "euidaccess.h".
8627 Remove declaration of euidaccess.
8629 2003-02-12 Jim Meyering <jim@meyering.net>
8631 * src/pathchk.c (portable_chars_only): Remove unnecessary `const'
8632 in cast to avoid warning from icc. Reported by Alexandre Duret-Lutz.
8634 2003-02-10 Jim Meyering <jim@meyering.net>
8636 * src/test.c: Don't include group-member.h.
8637 Include euidaccess.h.
8638 (eaccess): Rewrite function to set the real uid and gid temporarily
8639 to the effective uid and gid, then invoke 'access', and then set the
8640 real uid and gid back. On systems that lack setreuid or setregid,
8641 fall back on the kludges in euidaccess. Before, it would not work
8642 for e.g., files with ACLs, files that were marked immutable,
8643 or on file systems mounted read-only. Nelson Beebe raised the issue.
8644 Paul Eggert suggested the new implementation.
8646 2003-02-09 Jim Meyering <jim@meyering.net>
8648 * src/test.c (test_stat): Remove function. It's job is done (only
8649 when necessary) by the wrapper in lib/stat.c. Adjust all uses.
8651 2003-02-08 Jim Meyering <jim@meyering.net>
8655 * tests/mv/part-symlink: Don't assume that the file owner username
8656 length is less than 9 in ls output: instead, omit that field
8657 altogether. Reported by, and suggested fix from, Ferdinand.
8659 * tests/du/restore-wd: New test for just-fixed bug in ftw.c.
8660 * tests/du/Makefile.am (TESTS): Add restore-wd.
8662 * src/rm.c: Correct now-invalid comment about cycle-detection.
8664 2003-02-06 Jim Meyering <jim@meyering.net>
8666 * NEWS: Add entries from old/*/NEWS
8667 from fileutils-4.1 through 4.1.11 and
8668 from sh-utils-2.0 through 2.0.15. Suggestion from Karl Berry.
8672 * src/du.c (process_file): Don't return early for excluded files
8673 or for files whose dev/inode we've already seen.
8675 2003-02-05 Jim Meyering <jim@meyering.net>
8677 * tests/du/exclude: New file.
8678 * tests/du/Makefile.am (TESTS): Add exclude.
8680 2003-02-04 Dmitry V. Levin <ldv@altlinux.org>
8682 * src/who.c (print_boottime, print_deadprocs, print_runlevel):
8683 Fix memory allocation arithmetic.
8685 2003-02-04 Jim Meyering <jim@meyering.net>
8687 `df /dev/block-or-char-device-file--not-mounted' now reports
8688 the name of the file system on which the file resides, usually `/'.
8689 Before, it would leave the `Mounted on' field blank.
8690 * src/df.c (show_disk): Move function to precede find_mount_point.
8691 (show_disk): Add parameter: STATP.
8692 If we don't find a matching device name, then resort to calling
8693 find_mount_point. Reported by Bob Proulx.
8695 2003-02-03 Andreas Schwab <schwab@suse.de>
8697 * tests/rm/cycle: Require non-root.
8698 * tests/rm/isatty: Likewise.
8700 2003-02-02 Jim Meyering <jim@meyering.net>
8704 * man/Makefile.am (check-x-vs-1): Use @PATH_SEPARATOR@, not `:'.
8706 Ensure that there are no offending uses of `:'.
8707 * Makefile.maint (makefile_path_separator_check): New rule.
8708 (local-check): Add it to the list.
8710 2003-02-01 Jim Meyering <jim@meyering.net>
8712 * src/du.c (MAX_N_DESCRIPTORS): Define.
8714 * src/stat.c (G_fail): New global.
8715 (human_time): Diagnose failed localtime, not failed nstrftime.
8716 (main): Fail if G_fail is set.
8718 2003-01-31 Richard Dawe <rich@phekda.freeserve.co.uk>
8720 * tests/basename/Makefile.am: Use @PATH_SEPARATOR@ instead of
8721 hard-coding the path-separator. Also double-quote the new PATH,
8722 to avoid problems when the path-separator is a semi-colon or when
8723 `pwd` contains e.g. a space.
8724 * tests/chgrp/Makefile.am: Likewise.
8725 * tests/chmod/Makefile.am: Likewise.
8726 * tests/chown/Makefile.am: Likewise.
8727 * tests/cp/Makefile.am: Likewise.
8728 * tests/dd/Makefile.am: Likewise.
8729 * tests/dircolors/Makefile.am: Likewise.
8730 * tests/du/Makefile.am: Likewise.
8731 * tests/expr/Makefile.am: Likewise.
8732 * tests/factor/Makefile.am: Likewise.
8733 * tests/fmt/Makefile.am: Likewise.
8734 * tests/install/Makefile.am: Likewise.
8735 * tests/ln/Makefile.am: Likewise.
8736 * tests/ls/Makefile.am: Likewise.
8737 * tests/ls-2/Makefile.am: Likewise.
8738 * tests/md5sum/Makefile.am: Likewise.
8739 * tests/misc/Makefile.am: Likewise.
8740 * tests/mkdir/Makefile.am: Likewise.
8741 * tests/mv/Makefile.am: Likewise.
8742 * tests/od/Makefile.am: Likewise.
8743 * tests/rm/Makefile.am: Likewise.
8744 * tests/rmdir/Makefile.am: Likewise.
8745 * tests/seq/Makefile.am: Likewise.
8746 * tests/sha1sum/Makefile.am: Likewise.
8747 * tests/shred/Makefile.am: Likewise.
8748 * tests/stty/Makefile.am: Likewise.
8749 * tests/sum/Makefile.am: Likewise.
8750 * tests/tail-2/Makefile.am: Likewise.
8751 * tests/touch/Makefile.am: Likewise.
8752 * tests/tsort/Makefile.am: Likewise.
8753 * tests/unexpand/Makefile.am: Likewise.
8755 2003-01-31 Jim Meyering <jim@meyering.net>
8757 * src/stat.c: Include "file-type.h"
8758 (print_human_type): Remove function.
8759 (human_access): Rename from print_human_access. Return a string.
8760 (human_time): Rename from print_human_time. Return a string.
8761 (print_stat): Arrange so that field width and an alignment specifier
8762 are honored for the %A, %F, %x, %y, and %z formats.
8763 [%F]: Use file_type; this gives slightly different file type strings,
8764 e.g., `directory' instead of `Directory' and `regular file' or
8765 `regular empty file' instead of `Regular file'.
8766 Prompted by a report from Richard Dawe that the uses of
8767 S_IFSOCK and S_IFIFO in print_human_time were not portable
8768 to systems using e.g., DJGPP.
8770 2003-01-31 Richard Dawe <rich@phekda.freeserve.co.uk>
8772 * src/stat.c (print_stat): Use S_ISLNK rather than an explicit
8773 test using S_IFMT and S_IFLNK. S_IFLNK may not be defined.
8775 2003-01-31 Jim Meyering <jim@meyering.net>
8777 * src/du.c (main): Upon processing an invalid option or an invalid
8778 --exclude-from or --max-depth option argument, don't exit right away,
8779 in case there are others. Rather record the failure and exit after
8780 processing other options.
8782 * GNUmakefile (TAR_OPTIONS): Set and export, in order to make
8783 tar archive easier to reproduce.
8785 Rewrite to perform directory traversal using nftw.
8787 * src/du.c: Include "dirname.h", "ftw.h", and "quotearg.h".
8788 (AUTHORS): Add self.
8789 (opt_one_file_system): Move global into `main'.
8790 (path, xstat, exit_status): Remove declarations.
8791 (arg_length, suffix_length): New globals.
8792 (G_fail): New global, sort of like the old `exit_status'.
8793 (IS_FTW_DIR_TYPE): Define.
8794 (print_only_size): New function.
8795 (process_file): New function.
8796 (str_init, ensure_space, str_copyc, str_concatc): Remove functions.
8797 (str_trunc, pop_dir, count_entry): Likewise.
8798 (du_files): Rewrite to use nftw.
8800 2003-01-30 Jim Meyering <jim@meyering.net>
8802 * tests/du/trailing-slash: Ensure that du/ftw follows a command-line
8803 symlink-to-directory with -L, even without the trailing slash.
8805 2003-01-27 Jim Meyering <jim@meyering.net>
8807 * src/Makefile.am (check-misc): Check for st_blocks, too.
8809 * src/stat.c (print_stat): Use ST_NBLOCKS rather than `->st_blocks'.
8810 Reported by Richard Dawe.
8812 2003-01-27 Andreas Schwab <schwab@suse.de>
8814 * src/ls.c (quote_name): Add fourth parameter, width, into which to
8815 store the screen columns, and return the number of bytes instead.
8816 (print_dir): Pass NULL as fourth parameter of quote_name.
8817 (print_name_with_quoting): Likewise.
8818 (length_of_file_name_and_frills): Get the width from the fourth
8819 parameter of quote_name instead of return value.
8821 2003-01-27 Jim Meyering <jim@meyering.net>
8823 * src/ls.c (decode_switches): If `dired' is set without
8824 `format == long_format', then silently reset dired. This doesn't
8825 change the behavior of ls (all prior uses of dired were protected
8826 by `&& format == long_format'), and lets us...
8827 (DIRED_INDENT): ... remove the `format == long_format' conjunct.
8828 (PUSH_CURRENT_DIRED_POS): Likewise.
8831 2003-01-22 Jim Meyering <jim@meyering.net>
8833 * tests/du/no-x: New test, for functionality added to lib/ftw.c.
8834 * tests/du/Makefile.am (TESTS): Add no-x.
8836 2003-01-21 Jim Meyering <jim@meyering.net>
8838 * src/remove.c (remove_entry) [ROOT_CAN_UNLINK_DIRS
8839 && HAVE_STRUCT_DIRENT_D_TYPE]: If a file has d_type == DT_UNKNOWN
8840 it may still be a directory -- or not (e.g., with FreeBSD on an
8841 NFS-mounted file system), so resort to calling lstat to find out.
8842 Based on a patch by Michael van Elst.
8844 * tests/cp/same-file: Don't assume that the file owner username
8845 length is less than 9 in ls output: instead, omit that field
8846 altogether. Reported by, and suggested fix from, Ferdinand.
8848 2003-01-20 Jim Meyering <jim@meyering.net>
8850 * tests/date/Test.pm (wide-fmt): New test to demonstrate that
8851 large format widths no longer cause strftime to infloop.
8853 * Makefile.maint (mail_gpg_sign_cookie): Remove now-unused definition.
8855 2003-01-19 Jim Meyering <jim@meyering.net>
8857 * src/readlink.c: Include "canonicalize.h".
8859 2003-01-18 Jim Meyering <jim@meyering.net>
8861 * src/ls.c (Dereference_symlink) [DEREF_COMMAND_LINE_SYMLINK_TO_DIR]:
8863 (enum) [DEREFERENCE_COMMAND_LINE_SYMLINK_TO_DIR_OPTION]: New member.
8864 (long_options): Add option --dereference-command-line-symlink-to-dir.
8865 (main): Make DEREF_COMMAND_LINE_SYMLINK_TO_DIR be the default,
8866 rather than DEREF_COMMAND_LINE_ARGUMENTS, when none of the
8867 -d, -F, -l options is specified.
8868 (decode_switches): Handle --dereference-command-line-symlink-to-dir.
8869 (gobble_file): Honor DEREF_COMMAND_LINE_SYMLINK_TO_DIR.
8870 Change --dereference-command-line (-H) to dereference *all*
8871 command line arguments, including broken symlinks.
8873 2003-01-15 Paul Eggert <eggert@twinsun.com>
8875 Change ls -H back to the way it was yesterday, since this is
8876 compatible with FreeBSD and the POSIX spec is confusing
8877 and somewhat contradictory.
8879 * src/ls.c (DEREF_COMMAND_LINE_ARGUMENTS): Change name back
8880 from DEREF_COMMAND_LINE_SYMLINK_TO_DIR, updating all uses.
8881 (long_options): Change the long option name back.
8882 (usage): Change the usage back.
8883 (gobble_file): When -H is specified, dereference a top-level
8884 arg even if it points to a non-directory.
8886 2003-01-15 Jim Meyering <jim@meyering.net>
8888 * src/ls.c (gobble_file): Fall back on using lstat when required:
8889 when --dereference (-L) is not specified, and
8890 - when operating on a dangling symlink
8891 - when operating on command-line-symlink-to-directories
8892 This fixes numerous problems. Here are examples:
8893 - `ls dangling-symlink' would fail with `no such file...'
8894 Now it prints `dangling-symlink'.
8895 - `ls -i symlink' would mistakenly print the inode of the referent.
8896 Now it prints the inode of the symlink. Likewise for --size (-s).
8897 Based on a patch from Michael Stone.
8898 Reported by Deepak Goel as Debian bug #173793.
8900 Rename ls's --dereference-command-line (-H)
8901 option to --dereference-command-line-symlink-to-dir.
8902 * src/ls.c [enum Dereference_symlink]
8903 (DEREF_COMMAND_LINE_SYMLINK_TO_DIR): Rename from
8904 DEREF_COMMAND_LINE_ARGUMENTS. Update all uses.
8905 (long_options): Rename the long option.
8906 (usage): Say that --dereference-... changes how ls treats
8907 only symlinks to directories specified on the command line.
8909 2003-01-14 Jim Meyering <jim@meyering.net>
8911 * tests/ls/dangle: New file/test, for the above fix.
8912 * tests/ls/inode: Another new file/test, for the above fix.
8913 * tests/ls/Makefile.am (TESTS): Add dangle and inode.
8915 * src/ls.c (gobble_file): Fix a bug introduced in 4.5.4 that made it
8916 so that ls --color would no longer highlight the names of files with
8917 the execute bit set when not specified on the command line.
8918 Patch by Michael Stone. Reported by Stephen Depooter as
8921 * tests/ls-2/tests (color-exe): New test, for the above fix.
8923 2003-01-13 Jim Meyering <jim@meyering.net>
8925 * tests/shred/exact: Also test for just fixed bug with --zero.
8927 * src/shred.c (long_opts): --zero does not require an argument.
8928 Patch by Michael Stone. Reported by Roland Turner as Debian bug 172019.
8930 2003-01-12 Jim Meyering <jim@meyering.net>
8932 * Makefile.maint (cvs-update): Skip any file with local modifications.
8934 * src/unexpand.c (usage): Document --first-only and mention that
8935 --tabs=N (-t) enables --all (-a). Reported by wiregauze@yahoo.com.
8937 2002-12-01 Dmitry V. Levin <ldv@altlinux.org>
8939 * src/df.c: Include "canonicalize.h".
8940 Use canonicalize_file_name unconditionally.
8942 2003-01-09 Jim Meyering <jim@meyering.net>
8944 * README: Add readlink.
8946 2002-11-30 Dmitry V. Levin <ldv@altlinux.org>
8948 * src/df.c: Include "xgetcwd.h".
8949 * src/pwd.c: Likewise.
8951 2002-11-30 Dmitry V. Levin <ldv@altlinux.org>
8953 * src/shred.c: Remove declaration of xstrdup.
8954 We already get it via xalloc.h which is included via system.h.
8956 2002-08-27 Dmitry V. Levin <ldv@altlinux.org>
8958 New program: readlink.
8960 * src/Makefile.am (bin_PROGRAMS): Add readlink.
8961 * src/readlink.c: New file.
8963 * man/readlink.x: New file.
8964 * man/Makefile.am (dist_man_MANS): Add readlink.1.
8965 (readlink.1): New rule.
8967 2003-01-09 Jim Meyering <jim@meyering.net>
8969 When selecting ranges of byte offsets (as opposed to ranges of fields)
8970 and when --output-delimiter=STRING is specified, output STRING between
8971 ranges of selected bytes.
8972 * src/cut.c (RANGE_START_SENTINEL): Define.
8973 (output_delimiter_specified): New global.
8974 (print_kth): Add parameter. Adjust all callers.
8975 (set_fields): Mark each range-start index with RANGE_START_SENTINEL.
8976 (cut_bytes): When requested, output STRING between ranges of
8978 (main): Make a diagnostic a little clearer.
8979 Based on a patch from Jan Nieuwenhuizen.
8981 * tests/cut/Test.pm: New tests for the above.
8983 * src/cut.c (set_fields): Make code agree with comment:
8984 Don't merge abutting ranges like 4- and 2-3. This makes no
8985 difference currently, but is required to support an upcoming change.
8987 2003-01-07 Jim Meyering <jim@meyering.net>
8989 * src/cut.c (set_fields): Fix typo in comment.
8991 * tests/touch/not-owner: New test, mostly extracted from fail-diag.
8992 * tests/touch/Makefile.am (TESTS): Add not-owner.
8993 * tests/touch/fail-diag: Remove the test for non-owner diagnostic.
8994 Now, this tests only the nonexistent-directory diagnostic.
8995 Suggestion from Michael Stone.
8997 * tests/touch/fail-diag: Fix typo: s/ld/ls/.
8999 2003-01-04 Jim Meyering <jim@meyering.net>
9001 * src/copy.h: Remove use of PARAMS.
9002 * src/remove.h: Likewise.
9003 * src/chown-core.h: Likewise.
9005 rm could be tricked into mistakenly reporting a cycle.
9006 * src/remove.c: [cycle_check_state]: New global.
9007 (remove_cwd_entries): Adapt to new semantics of cycle_check.
9008 (rm): Call cycle_check_init and cycle_check_free for each file.
9009 * tests/rm/cycle (rm): New test, for the above fix.
9010 * tests/rm/Makefile.am (TESTS): Add cycle.
9012 When rm detects a cycle, don't abort the entire command,
9013 but rather just the affected command line argument.
9014 * src/remove.c: Include <setjmp.h>
9015 (struct dirstack_state) [current_arg_jumpbuf]: New member.
9016 (remove_cwd_entries): Call longjmp if we detect a cycle.
9017 (rm): Call setjmp here.
9019 * src/remove.c (cycle_check, is_power_of_two): Remove functions.
9020 Instead, include cycle-check.h and use it.
9022 * src/remove.h (struct dev_ino): Remove declaration.
9024 * src/remove.c (remove_cwd_entries): Fix typos in comment.
9026 Don't include trailing /. in diagnostics about directories.
9027 * src/remove.c (full_filename_): When FILENAME is just `.'
9028 and there is a nonempty directory-name part, don't append `/.'.
9029 * tests/rm/unread2: Remove trailing /. from diagnostic.
9030 * tests/rm/rm2: Likewise.
9032 * src/remove.c (struct dirstack_state): Define.
9033 To be used in place of these file-scoped globals ...
9034 (dir_stack, len_stack, Active_dir): Remove globals.
9035 (ds_init, ds_free): New functions.
9036 (full_filename): Define.
9037 (full_filename_): Rename from full_filename.
9039 Begin to make AD_* functions more generic.
9040 * src/remove.c (AD_push_initial): Don't set status to RM_OK here.
9041 (AD_push): Likewise.
9042 (AD_INIT_OTHER_MEMBERS): Define.
9043 (remove_dir): Define the `status' member manually after each
9044 call to AD_push or AD_push_initial.
9046 * src/Makefile.am (check-misc): New rule, to ensure that no more
9047 S_IS* macro definitions sneak into the code.
9048 (check): Depend on check-misc.
9050 * src/remove.c [S_ISLNK]: Don't define. It's already defined in sys2.h.
9051 * src/du.c (count_entry) [S_ISLNK]: Don't define.
9052 * src/shred.c [S_ISLNK, S_ISFIFO, S_ISSOCK]: Don't define.
9054 2003-01-03 Jim Meyering <jim@meyering.net>
9056 * src/true.c: Add copyright.
9057 (AUTHORS): I suppose I've written it.
9059 * src/Makefile.am (false.c): Make the generated file be read-only.
9061 2003-01-04 Jim Meyering <jim@meyering.net>
9063 * src/ls.c: Include "dev-ino.h".
9064 [struct dev_ino]: Remove declaration.
9066 2003-01-02 Jim Meyering <jim@meyering.net>
9068 * src/cp.c (do_copy): Tweak diagnostic to be consistent with the one
9069 from mv: s/missing file arguments/missing file argument/.
9070 With --target-directory=DIR, cp and mv work with a single file argument.
9071 Reported by Karl Berry.
9073 * tests/rm/isatty: Enable this test.
9075 2002-12-31 Jim Meyering <jim@meyering.net>
9077 * src/remove.c (AD_push_initial): Don't set status to RM_OK here.
9078 (AD_push): Likewise.
9079 (AD_INIT_OTHER_MEMBERS): Define.
9080 (remove_dir): Define the `status' member manually after each
9081 call to AD_push or AD_push_initial.
9083 * src/ls.c [struct dev_ino]: Remove definition.
9084 Include "dev-ino.h" instead.
9086 2002-12-28 Jim Meyering <jim@meyering.net>
9088 * tests/du/Makefile.am (TESTS): Add no-deref.
9089 * tests/du/no-deref: New script.
9091 2002-12-23 Jim Meyering <jim@meyering.net>
9093 * src/remove.c (remove_cwd_entries): Fix typo in comment.
9095 2002-12-21 Jim Meyering <jim@meyering.net>
9097 * announce-gen: Generate MML-formatted announcement.
9098 This makes it a *lot* harder to send stale MD5/SHA1 signatures.
9100 2002-12-20 Jim Meyering <jim@meyering.net>
9102 * src/touch.c (touch): Change the wording of a diagnostic so
9103 that it makes sense both when the file exists and when it doesn't.
9104 Suggestion from Michael Stone.
9106 2002-12-18 Jim Meyering <jim@meyering.net>
9108 * src/stty.c (valid_options): Declare to be static.
9110 2002-12-15 Jim Meyering <jim@meyering.net>
9112 * Makefile.cfg: Remove rules related to generating m4/jm-glibc-io.m4.
9114 * src/chmod.c, src/copy.c, src/copy.h, src/cp-hash.h, src/csplit.c:
9115 * src/date.c, src/expr.c, src/fmt.c, src/id.c, src/install.c:
9116 * src/ls.c, src/od.c, src/pathchk.c, src/pr.c, src/remove.c:
9117 * src/shred.c, src/sort.c, src/stat.c, src/stty.c, src/sum.c:
9118 * src/tee.c, src/test.c: Remove all uses of `PARAMS'.
9120 * src/remove.c (PARAMS): Remove definition.
9121 * src/sys2.h: Likewise.
9123 * src/ls.c, src/stat.c, src/date.c: Remove declaration of nstrftime.
9124 Include strftime.h instead.
9126 2002-12-14 Jim Meyering <jim@meyering.net>
9128 * Makefile.cfg ($(url_dir_list)): Use .../coreutils, not .../fetish.
9130 * src/system.h [! HAVE_DECL_MEMRCHR]: Declare memrchr.
9131 This is necessary at least for Irix6.5 when using c89.
9132 Reported by Nelson Beebe.
9134 * tests/misc/Makefile.am (TESTS): Add cat-tty-eof.
9136 * tests/misc/cat-tty-eof: New test.
9138 * src/mknod.c (usage): Specify how major and minor mode numbers
9139 are interpreted. Report forwarded by Kristin E Thomas.
9140 * src/mknod.c: Remove now-redundant usage-specifying comment.
9142 2002-12-13 Jim Meyering <jim@meyering.net>
9146 * tests/du/trailing-slash: Allow for a directory of size `0'.
9147 That happens at least on file systems of type tmpfs on linux-2.4.18.
9149 * announce-gen: New script to begin replacing the commands
9150 associated with the rule here...
9151 * Makefile.maint (announcement): Invoke announce-gen.
9152 * Makefile.am (EXTRA_DIST): Add announce-gen.
9154 * tests/cp/preserve-2: New file/test, for latest fix.
9155 * tests/cp/Makefile.am (TESTS): Add preserve-2.
9157 2002-12-11 TAKAI Kousuke <takai@vlsi.kuee.kyoto-u.ac.jp>
9159 Fix a bug whereby cp would fail to parse an option like
9160 --preserve=mode,ownership.
9161 * src/cp.c (decode_preserve_arg): Advance `comma' to
9162 point the character following the comma.
9164 2002-12-11 Jim Meyering <jim@meyering.net>
9166 * src/pathchk.c (NEED_PATHCONF_WRAPPER): Undefine before defining,
9167 in case it's already defined.
9169 2002-12-09 Jim Meyering <jim@meyering.net>
9171 * tests/touch/fail-diag: Don't get a test failure if /no exists.
9172 Instead, evoke a framework failure if /no-$$ exists.
9173 Reported by Michael Stone.
9175 2002-12-08 Jim Meyering <jim@meyering.net>
9177 * src/du.c (lstat) [! LSTAT_FOLLOWS_SLASHED_SYMLINK]:
9178 Define to rpl_lstat, so that even on systems like Solaris 5.8,
9179 du honors (per POSIX) the trailing slash on an argument referring
9180 to a symlink-to-directory.
9182 2002-12-06 Jim Meyering <jim@meyering.net>
9184 * Use autoconf-2.57. Regenerate dependent files.
9185 * Use automake-1.7.2. Regenerate dependent files.
9187 * src/ls.c (gobble_file): Also stat the file if it's a
9188 regular file and --indicator-style=classify (aka -F).
9189 Thanks to Ed Santiago for opening my eyes.
9191 * tests/ls/file-type: New file. Test for the above.
9192 A test to contrast ls -F and ls --indicator-style=file-type.
9193 * tests/ls/Makefile.am (TESTS): Add file-type.
9195 2002-12-04 Jim Meyering <jim@meyering.net>
9197 * tests/ls/follow-slink: Make sure the symlink was created.
9198 Richard Dawe reported that `ln -s link link' succeeds, but creates
9199 no file on systems running some version of the DJGPP libc.
9201 2002-12-03 Jim Meyering <jim@meyering.net>
9203 * src/Makefile.am (AUTOMAKE_OPTIONS): Remove definition (to ansi2knr)
9204 since this package no longer panders to K&R compilers.
9206 2002-12-02 Jim Meyering <jim@meyering.net>
9208 * tests/du/slink: Skip this test if `.' is on a non-local file system.
9210 * tests/Fetish.pm (_at_replace): Do the substitution only if there's
9211 something to replace.
9213 2002-12-01 Jim Meyering <jim@meyering.net>
9215 * src/stat.c: Don't include <string.h> or <ctype.h>.
9216 That's already done via system.h.
9217 * src/dircolors.c: Don't include <ctype.h>.
9219 2002-11-30 Jim Meyering <jim@meyering.net>
9221 * ls.c (gobble_file): Remove the block of code that caused
9222 `ls --color -F symlink-to-dir' to list the files in
9223 `symlink-to-dir/.'. Now, it prints `symlink-to-dir@', (just
9224 like `ls -F symlink-to-dir') but with the addition of highlighting.
9225 Similarly, `ls --color -dF symlink-to-dir' would print
9226 `symlink-to-dir/'; now it prints `symlink-to-dir@'.
9227 Reported by Jeff Sheinberg as Debian bug #168203.
9228 * tests/ls-2/tests (sl-F-color, sl-dF-color): New tests for the above.
9230 ls is now more efficient: with certain options, it no longer needs
9231 to stat each directory entry on systems with valid dirent.d_type.
9232 * src/ls.c (print_dir): Add DT_LNK and DT_REG.
9233 (main): Make --recursive set format_needs_type, not format_needs_stat.
9234 (gobble_file): Remove a FIXME comment, now that it's fixed.
9236 2002-11-24 Jim Meyering <jim@meyering.net>
9238 * src/du.c (du_files): Don't strip any trailing slash.
9239 Rewrite so that `/' is no longer represented internally as
9241 (count_entry): When appending a file name component,
9242 account for the fact that the current path may end in `/'.
9243 François Pinard reported that `du symlink-to-dir/' was not
9244 equivalent to `du symlink-to-dir/.'. Now it is.
9245 * tests/du/trailing-slash: New file/test, for the above fix.
9246 * tests/du/Makefile.am (TESTS): Add trailing-slash.
9248 2002-11-23 Jim Meyering <jim@meyering.net>
9250 * src/tac.c (output): Declare some local variables to be of type size_t,
9251 rather than `int' to avoid warnings from gcc.
9253 2002-11-21 Paul Eggert <eggert@twinsun.com>
9255 * src/ls.c (decode_switches): Use case-sensitive matching to
9256 decode the QUOTING_STYLE environment variable. This is more
9257 consistent with the documentation, and with --quoting-style.
9259 2002-11-21 Martin Buck <martin.buck@ascom.ch
9261 * src/stty.c (struct speeds): Add support for all baud rates defined
9264 2002-11-19 Jim Meyering <jim@meyering.net>
9266 * tests/sum/sysv: Export LC_ALL=C, to avoid failure when
9267 run in a UTF locale. Report and suggested fix by Bruno Haible.
9268 * tests/fmt/basic: Likewise.
9270 2002-11-17 Jim Meyering <jim@meyering.net>
9272 * configure.ac: Update via autoupdate.
9273 Add `AM_GNU_GETTEXT_VERSION(0.11.5)'.
9275 * src/mv.c (movefile): Don't remove trailing slashes from SOURCE.
9276 Reported by Hans Ginzel.
9278 2002-11-15 Jim Meyering <jim@meyering.net>
9280 * Makefile.cfg (gnu_rel_host): Define.
9281 (url_dir_list): Choose from (alpha|ftp).gnu.org depending
9282 on whether $(VERSION) looks like a major release number.
9284 * Makefile.maint (mail_gpg_sign_cookie): Backslash-escape `#'.
9285 (release): Rename from `alpha'.
9286 (alpha): Depend on release.
9288 * Makefile.maint (signatures): Define with ?=, so it's easy to override.
9290 2002-11-14 Jim Meyering <jim@meyering.net>
9292 * Makefile.maint (mail_gpg_sign_cookie): Make optional.
9293 (announcement): Use the new variable.
9295 * Makefile.maint: Sync with Bison, i.e.:
9296 (po-check): Scan .l and .y files instead of the
9297 .c and the .h files that they generate. This fixes the bug
9298 reported by Tim Van Holder in:
9299 <http://mail.gnu.org/pipermail/bison-patches/2002-November/001352.html>
9300 Look for N_ as well as for _. Try to avoid matching #define for
9304 2002-11-12 Jim Meyering <jim@meyering.net>
9306 * src/ls.c (HAVE_SYMLINKS): Remove unnecessary macro definition.
9307 Replace sole use with equivalent `#ifdef S_ISLNK'.
9308 Inconsistency reported by Dmitry V. Levin.
9310 2002-11-11 Jim Meyering <jim@meyering.net>
9312 * src/stat.c (usage): Transform --help items output via s/ - / /,
9313 so that help2man produces properly formatted man pages.
9314 Reported by Herbert Xu as Debian bug #168400.
9316 2002-11-10 Jim Meyering <jim@meyering.net>
9318 * src/ls.c (sighandler): Handle SIGTSTP specially.
9319 Based on suggestions from Solar Designer and Dmitry V. Levin.
9322 * Makefile.cfg (cvs_files): Define. From autoconf.
9323 (local_updates): Likewise.
9325 * src/ls.c (restore_default_color_handler, sigtstp_handler):
9327 (sighandler): New function, based on the one in sort.c.
9328 (main): Use sigaction, if possible; otherwise signal.
9329 Handle these signals:
9330 SIGHUP, SIGINT, SIGPIPE, SIGQUIT, SIGTERM, SIGTSTP.
9331 Don't register our handler if the signal is already being ignored.
9333 * src/dd.c (interrupt_handler): Use raise, rather than kill+getpid.
9334 * src/csplit.c (interrupt_handler): Likewise.
9335 * src/sort.c (sighandler): Likewise.
9336 (main): Declare `i' and `nsigs' to be unsigned, not int.
9338 2002-11-09 Jim Meyering <jim@meyering.net>
9340 ls --color: restore terminal text color upon signal.
9341 * src/ls.c: Include "full-write.h" and <signal.h>.
9342 (restore_default_color, restore_default_color_handler): New functions.
9343 (sigtstp_handler, put_indicator_direct): New functions.
9344 (main) [print_with_color]: Register signal handlers.
9345 Patch mostly by Solar Designer and Stanislav Ievlev.
9347 Update from autoconf.
9348 * Makefile.maint (AMTAR): Remove definition.
9349 (update, cvs-update, po-update, do-po-update): New rules.
9350 (wget-update): Update (thus renaming to cvs-update).
9351 (automake_repo): Use anoncvs@sources.redhat.com.
9353 2002-11-06 Jim Meyering <jim@meyering.net>
9355 * tests/misc/Makefile.am (TESTS): Add printf-hex.
9357 * tests/misc/printf: Be careful to test the code in this package,
9358 not the shell built-in function.
9360 * src/printf.c (print_esc): A hexadecimal escape sequence has
9361 at most two hex. digits, not three. Reported by Padraig Brady.
9362 (usage): Update description.
9363 * tests/misc/printf-hex: New file/test, for the above fix.
9365 2002-10-07 Paul Eggert <eggert@twinsun.com>
9367 Add support for locale-specific size indications (e.g.,
9368 thousands-separators) and for explicit size suffixes on output.
9370 * doc/coreutils.texi (Block size): Say that:
9371 This affects display format as well as block size.
9372 Fractional block counts are rounded up.
9373 ls file size blocksize defaults to 1.
9374 A block size spec preceded by ' generates thousands separators.
9375 A suffix without a preceding integer generates suffixes.
9376 (tail invocation): 32k -> 32 KiB.
9377 (What information is listed): ls -h is now equivalent to
9378 ls --block-size=human, and ls -H is now equivalent to
9379 ls --block-size=si. Displayed file size is now always affected by
9382 * lib/inttostr.c, lib/inttostr.h, lib/imaxtostr.c, lib/offtostr.c,
9383 lib/umaxtostr.c: New files, taken from GNU tar.
9385 * lib/Makefile.am (libfetish_a_SOURCES): Add imaxtostr.c, offtostr.c,
9387 (EXTRA_DIST): Add inttostr.c.
9389 * lib/human.c, lib/human.h: Rewrite to support locale-specific
9390 notations like thousands separators.
9391 Specify what includer of include.h must include beforehand.
9392 (human_group_digits, human_suppress_point_zero, human_autoscale,
9393 human_base_1024, human_SI, human_B): New enum values.
9394 (human_readable): Rename from human_readable_inexact; put the
9395 options before the sizes. All uses changed. The old human_readable
9396 function has been removed; use inttostr.h instead.
9397 (human_options): Renamed from human_block_size, with new signature
9398 that allows block sizes up to UINTMAX_MAX. All callers changed.
9400 * m4/prereq.m4 (jm_PREREQ_HUMAN): Check for locale.h, localeconv,
9401 AC_HEADER_STDBOOL. No need to check for limits.h since it's in
9402 freestanding C89. No need to check for stdlib.h or string.h since
9403 autoconf does this now.
9405 * src/cksum.c (cksum): Use primitives from inttostr.h, not
9406 human.h, to print large numbers simply.
9407 * src/csplit.c (handle_line_error, parse_patterns): Likewise.
9408 * src/dd.c (print_stats, main): Likewise.
9409 * src/df.c (print_header): Likewise.
9410 * src/factor.c (print_factors): Likewise.
9411 * src/ls.c (print_long_format, print_file_name_and_frills): Likewise.
9412 * src/shred.c (dopass): Likewise.
9413 * src/sort.c (checkfp): Likewise.
9414 * src/sum.c (bsd_sum_file, sysv_sym_file): Likewise.
9415 * src/tail.c (xlseek): Likewise.
9416 * src/wc.c (write_counts, wc): Likewise.
9418 * src/df.c (human_output_opts): New var.
9419 (output_block_size): Now uintmax_t, not int, to handle larger
9420 block sizes. All uses changed.
9421 * src/du.c: Likewise.
9422 * src/ls.c: Likewise.
9424 * src/df.c (print_header): In the header line, prefer SI to human
9425 representation if it's shorter; if neither is shorter, try to
9426 intuit what the user would prefer.
9428 * src/expr.c (inttostr): Remove; use new imaxtostr library
9431 * src/ls.c (file_output_block_size): New var, to distinguish
9432 file sizes from other sizes.
9433 (decode_switches): Set it.
9435 * src/shred.c (OUTPUT_BLOCK_SIZE): remove.
9436 (dopass): When printing progress, use floor for what has been done
9437 so far (since we should be conservative there), and ceiling for
9438 what needs to be done (since that's what other programs use).
9440 2002-10-19 Jim Meyering <jim@meyering.net>
9442 * src/pinky.c (print_heading): Align TTY and Name headings.
9443 Reported by Karl Eichwalder.
9445 2002-10-18 Jim Meyering <jim@meyering.net>
9447 * src/split.c (cwrite): Change type of `bytes' parameter to size_t
9448 Remove now-useless cast.
9449 (stdread): Remove function.
9450 (bytes_split): Use size_t instead of int.
9451 Use safe_read, not stdread.
9452 (lines_split): Likewise.
9453 Use memchr rather than a `while' loop.
9454 (line_bytes_split): Use size_t instead of int.
9455 Use safe_read, not stdread.
9456 (main): Add some FIXME comments to remind me to remove casts.
9458 * src/system.h (ST_BLKSIZE): Correct comment describing how to
9459 reproduce HPUX-11 cat failure. From Petter Reinholdtsen.
9461 2002-10-17 Jim Meyering <jim@meyering.net>
9463 Fix a problem that could make e.g., `cat' misbehave on systems which
9464 give invalid (unreasonably large) values for stat.st_blksize.
9465 * src/system.h (ST_BLKSIZE): Ensure that the result is in [1..4MB].
9466 Reported by Petter Reinholdtsen.
9468 2002-10-14 Jim Meyering <jim@meyering.net>
9470 Specifying a printf conversion specifer as nl's separator string
9471 could cause nl to segfault.
9472 * src/nl.c (build_print_fmt): Don't include separator string
9473 in the printf format; it might contain `%'.
9474 Use a better bound on the length of the print_fmt buffer.
9475 (print_lineno): Print the separator here instead.
9476 Reported by Doug Coleman.
9478 * tests/misc/nl: New file/tests, including a test for the above.
9479 * tests/misc/Makefile.am (TESTS): Add nl.
9481 * tests/misc/split-l: New test, to make sure `split --lines=N' works.
9482 * tests/misc/Makefile.am (TESTS): Add split-l.
9484 2002-10-13 Jim Meyering <jim@meyering.net>
9488 * src/du.c (usage): Tweak description of --dereference-args/-D.
9490 * src/du.c (count_entry): Also save cwd when dereferencing (via
9491 --dereference-args, -D) a command-line argument.
9492 Reported by Michal Svec. Based on a patch by Andreas Schwab.
9494 * src/Makefile.am (../AUTHORS): New target/rule.
9496 2002-10-12 Jim Meyering <jim@meyering.net>
9498 * src/paste.c (paste_parallel): Declare local, `delims_saved', to be
9499 of type size_t, since that's the way it's used and avoids a warning.
9501 * src/csplit.c (struct cstring) [len]: Declare to be unsigned int,
9502 since that's how it's always used and avoids a new warning from gcc.
9503 (read_input): Adapt to new safe_read ABI.
9505 * src/cut.c (cut_fields): Add a temporary size_t variable, n_bytes,
9508 * src/pinky.c (print_long_entry): fread returns size_t.
9509 Declare local `bytes' accordingly, to avoid warning.
9511 tail -c +N would perform an extra read after encountering EOF
9512 [this change is analogous (bytes vs. lines) to the one of 2002-01-27]
9513 * src/tail.c (start_bytes): Detect EOF, inform caller.
9514 (tail_bytes): Upon EOF in start_bytes, return immediately.
9515 (file_lines): Reorganize to use memrchr rather than an explicit loop.
9516 Adapt to new safe_read ABI.
9518 2002-10-11 Jim Meyering <jim@meyering.net>
9520 * tests/du/deref: New file/test, for the above fix.
9521 * tests/du/Makefile.am (TESTS): Add deref.
9523 2002-10-10 Jim Meyering <jim@meyering.net>
9525 * tests/ln/Makefile.am (TESTS): Add target-1.
9526 * tests/ln/target-1: New file/test, for the fix on 2002-10-08.
9528 2002-10-09 Jim Meyering <jim@meyering.net>
9530 * tests/cp/backup-is-src: Ensure that certain environment variables
9531 are not set (e.g., SIMPLE_BACKUP_SUFFIX). Reported by Duncan Roe.
9533 * tests/tail-2/big-4gb: Mark this as an expensive test; it would
9534 consume 4GB of disk space on systems without support for sparse files.
9535 Fix a logic error that'd make it `cat err' even though dd didn't fail.
9537 * src/dircolors.hin (.jar): Fix typo: s/;3$/;31/.
9538 Patch by steven@magelico.net, forwarded by Michael Stone.
9540 * tests/ls/dired: Ensure that ls produces English messages.
9541 Patch by Alexey Vyskubov, forwarded by Michael Stone.
9543 2002-10-08 Dmitry V. Levin <ldv@altlinux.org>
9545 * src/ln.c (main): Fix target_directory parsing when n_files == 1.
9547 2002-10-08 Jim Meyering <jim@meyering.net>
9549 * tests/tail-2/big-4gb: Use double quotes around diagnostic.
9550 Fix syntax in test: use =, not ==.
9551 Reported by Bob Proulx.
9552 Change all the rest like this: grep -lR "testing framework'" .\
9553 |xargs perl -pi -e 's/'\''(\$0: failure in testing framework)'\''/"$1"/'
9555 * src/sum.c (sysv_sum_file): Adapt to new safe_read ABI.
9556 * src/tr.c (squeeze_filter, read_and_delete, read_and_xlate): Likewise.
9557 * src/tac.c (save_stdin, tac_stdin_to_mem): Likewise.
9558 * src/wc.c (wc): Likewise.
9560 2002-10-07 Paul Eggert <eggert@twinsun.com>
9563 Don't advance the write pointer past the end of the write buffer.
9564 * src/sort.c (begfield, limfield): Likewise.
9566 2002-10-07 Jim Meyering <jim@meyering.net>
9568 * src/cat.c (simple_cat, cat): Adapt to new safe_read ABI.
9569 * src/head.c (head_bytes, head_lines): Likewise.
9571 2002-10-06 Jim Meyering <jim@meyering.net>
9573 * src/dd.c (scanargs): Ensure that specified block sizes (specified
9574 via ibs=N, obs=N, and bs=N) are no larger than SSIZE_MAX.
9575 (skip, dd_copy): Adapt to new safe_read ABI.
9577 * Makefile.maint (signatures): Define.
9579 (announcement): Depend on $(signatures).
9581 * Makefile.maint (announcement): Output all URLs for detached
9582 signatures, not just the last one from the previous loop.
9584 2002-10-05 Jim Meyering <jim@meyering.net>
9588 * src/remove.c (remove_entry) [ROOT_CAN_UNLINK_DIRS]: With `rm -i DIR',
9589 don't recurse into directory, DIR. Prompted by a report from
9592 * tests/rm/i-no-r: New file/test, for the above fix.
9593 * tests/rm/Makefile.am (TESTS): Add i-no-r.
9595 * tests/tail-2/big-4gb: New file/test, for the fix of 2002-09-27.
9596 * tests/tail-2/Makefile.am (TESTS): Add big-4gb.
9598 2002-10-03 Jim Meyering <jim@meyering.net>
9600 * src/rm.c (AUTHORS): Mark translatable string with `N_ (...)'.
9601 * src/df.c (AUTHORS): Likewise.
9602 * src/du.c (AUTHORS): Likewise.
9603 * src/tail.c (AUTHORS): Likewise.
9604 * src/touch.c (AUTHORS): Likewise.
9606 2002-10-02 Jim Meyering <jim@meyering.net>
9608 * Makefile.am (SUBDIRS): Remove `old'.
9609 (EXTRA_DIST): List the files in old/.
9610 * configure.ac (AC_CONFIG_FILES): Remove old/* names.
9611 Suggestion from Akim Demaille.
9613 2002-10-01 Jim Meyering <jim@meyering.net>
9615 * src/sys2.h (SSIZE_MAX): Define.
9617 2002-09-30 Jim Meyering <jim@meyering.net>
9619 * src/csplit.c: Don't include stdlib.h here. It's already included
9622 2002-09-29 Jim Meyering <jim@meyering.net>
9624 * src/tr.c (find_bracketed_repeat): Rearrange pointer/integer
9625 expression to avoid bogus warning from gcc.
9627 * src/cat.c (simple_cat): Use a temporary to avoid bogus warnings.
9628 (cat): Declare insize and outsize to be of type size_t, not int.
9629 Rearrange pointer/integer expressions to avoid bogus warnings.
9630 (main): Declare insize and outsize to be of type size_t, not int.
9632 * src/tail.c (parse_options): Give a sensible diagnostic for
9633 an invalid byte or line count. Reported by Mikko Tuumanen.
9635 * src/touch.c (main): Split a long line.
9637 * tests/du/Makefile.am (TESTS): Add slink.
9638 * tests/du/slink: New test for system.h change of 2002-08-31.
9640 In move mode, always first try to rename. Before, upon failure to
9641 rename a directory, this code would never attempt to rename any
9642 other file in that directory, but would thenceforth always copy.
9643 On some systems (e.g., NetApp's OnTap-6.4), renaming a directory
9644 may fail with EXDEV, yet renaming files within that directory to
9645 a newly-created destination directory succeeds.
9646 * src/copy.c (copy_internal): Remove local, move_mode;
9647 use x->move_mode instead. Based on a patch from Tom Haynes.
9649 2002-09-28 Jim Meyering <jim@meyering.net>
9651 * src/split.c (FAIL_ONLY_ONE_WAY): New macro.
9652 Factor out some duplication.
9654 [case 'a']: Use strtoul rather than strtol to avoid compiler warnings.
9656 * src/sort.c (begfield, limfield): Rearrange comparisons to avoid
9658 (fillbuf, keycompare): Cast literal `-1' to size_t in comparisons,
9659 to avoid compiler warnings.
9661 * src/shred.c (dopass): Use a uintmax_t temporary to avoid bogus
9664 Fix things so `mkdir -p' can create very deep directories, e.g.,
9665 mkdir -p $(perl -e 'print "a/" x 40000') now works.
9666 * src/mkdir.c (main): For --parents (-p), call make_path with the
9667 entire directory name, so we don't ever require that file operations
9668 like stat or chmod be performed on the entire command line argument.
9669 * makepath.c (make_path): Restore umask *before* creating the final
9672 2002-09-27 Andreas Schwab <schwab@suse.de>
9674 * src/tail.c (tail_bytes): Change type of bytes_remaining to off_t
9675 to avoid overflow. Reported by Hans Lermen.
9677 2002-09-26 Jim Meyering <jim@meyering.net>
9679 * src/install.c (get_ids): Use strtoul, not strtol. Remove some casts.
9681 2002-09-25 Jim Meyering <jim@meyering.net>
9683 * src/test.c (eaccess): Change type of local `euid' from int to uid_t
9684 and add a cast, to avoid a warning about `signed and unsigned type in
9685 conditional expression'.
9687 2002-09-22 Jim Meyering <jim@meyering.net>
9689 * src/rmdir.c: Include "dirname.h", for declaration of
9690 strip_trailing_slashes.
9692 * src/stat.c (PRIdMAX, PRIuMAX): Remove definitions.
9693 Now they're defined through system.h.
9695 * src/cp-hash.c, src/dd.c, src/df.c, src/du.c, src/ls.c,
9696 * src/stat.c, src/wc.c: Remove all inclusions of inttypes.h,
9697 since it's already included from sys2.h via system.h.
9699 * Use automake-1.6f. Regenerate dependent files.
9701 * src/Makefile.am (PERL): Remove duplicate definition.
9703 fmt's -s, -t, -c options didn't work properly for long lines.
9704 Since get_line may end up calling put_paragraph (for long lines),
9705 be sure to set global, `other_indent', before it is used there.
9707 * src/fmt.c (set_other_indent): New function, factored out of...
9708 (get_paragraph): ... here. Call it.
9709 (get_line): Call set_other_indent before calling flush_paragraph,
9710 which calls fmt_paragraph, which in turn calls put_paragraph,
9711 which uses other_indent.
9713 * tests/fmt/Makefile.am (TESTS): Add long-line.
9714 * tests/fmt/long-line: New file/test, for the above fix.
9716 2002-09-21 Jim Meyering <jim@meyering.net>
9718 * src/od.c: No longer include deprecated <values.h>.
9719 It was required solely for now-removed reference to BITSPERBYTE.
9720 * src/install.c: Likewise.
9721 Suggestion from Bruno Haible.
9723 2002-09-06 Andreas Schwab <schwab@suse.de>
9725 `rmdir -p dir-specified-with-trailing-slash/' would fail.
9726 * src/rmdir.c (remove_parents): Strip trailing slashes.
9728 2002-09-20 Jim Meyering <jim@meyering.net>
9730 * tests/rmdir/t-slash: New file/test, for the above fix.
9731 * tests/rmdir/Makefile.am (TESTS): Add t-slash.
9733 * Makefile.maint (announcement): Arrange to gpg-sign the message.
9734 Add a URL for each detached signature file.
9736 2002-09-07 Bruno Haible <bruno@clisp.org>
9738 * configure.ac: Add need-ngettext to AM_GNU_GETTEXT invocation.
9740 2002-09-18 Jim Meyering <jim@meyering.net>
9742 `od -t x8' used the wrong (`l'-prefixed) printf format.
9743 Likewise for the o8 and u8 formats.
9744 * src/od.c (ISPEC_TO_FORMAT): Define macro.
9745 (decode_one_format): Use PRIdMAX, PRIoMAX, etc. for LONG_LONG.
9746 Reported by Arun Sharma.
9748 2002-09-17 Jim Meyering <jim@meyering.net>
9750 * src/sys2.h (PRIdMAX, PRIoMAX, PRIuMAX, PRIxMAX): Define if necessary.
9751 From gettext's intl/loadmsgcat.c.
9753 * tests/od/x8: New file/test, for the above fix.
9754 * tests/od/Makefile.am (TESTS): Add x8.
9756 2002-09-15 Jim Meyering <jim@meyering.net>
9758 * Use autoconf-2.54. Regenerate dependent files.
9760 * src/csplit.c (get_format_width): Add cast to avoid
9761 warning about `signed and unsigned type in conditional expression'.
9763 2002-09-14 Jim Meyering <jim@meyering.net>
9765 * src/who.c (print_user): Change type of local to size_t
9766 to avoid warnings about `comparison between signed and unsigned'.
9767 * src/ptx.c (generate_all_output): Likewise.
9769 * src/dd.c (main, skip): Add casts to avoid warnings about
9770 `comparison between signed and unsigned'.
9772 * src/id.c (print_full_info, print_group_list): Add casts to avoid
9773 warnings about `signed and unsigned type in conditional expression'.
9775 * src/md5sum.c: Change type of global, digest_hex_bytes, to size_t
9776 to avoid warnings about `comparison between signed and unsigned'.
9777 (split_3): Change parameter names to be readable and add comment.
9778 Clean up the test for whether a line may be ignored.
9780 2002-09-13 Jim Meyering <jim@meyering.net>
9782 * src/printf.c (main): Handle leading command line argument of `--'.
9783 Reported by Raul: DervishD <raul@pleyades.net>
9784 * tests/misc/printf: New file: test for the above.
9785 * tests/misc/Makefile.am (TESTS): Add printf.
9787 * src/date.c (usage): Explain that %S's range of [0..60] is required --
9788 rather than 0..59 -- to accommodate the occasional positive leap second.
9789 Reported by Richard Neill.
9791 2002-09-12 Jim Meyering <jim@meyering.net>
9793 * src/Makefile.am (nanosec_libs): Define.
9794 (sleep_LDADD, tail_LDADD): Use it here.
9796 Factor nanosleep-related code into ../lib/xnanosleep.c.
9797 * src/sleep.c: Include xnanosleep.h.
9798 Factor out fenv.h-related code.
9799 (timespec_subtract): Remove function.
9800 (main): Remove code that deals with computing start and stop times
9801 as well as the loop around nanosleep. Now that's in xnanosleep.c.
9803 Allow S (in --sleep-interval=S) to be a floating point value.
9804 * src/tail.c: Include xnanosleep.h and xstrtod.h.
9805 Move declaration of global variable, sleep_interval, to ...
9807 (usage): Update description of --sleep-interval option.
9808 (tail_forever): New parameter, sleep_interval. Update caller.
9809 Use xnanosleep, rather than sleep.
9810 (parse_options): New parameter, sleep_interval. Update caller.
9811 Use xstrtod, now that we accept floating point values.
9812 Prompted by a patch from Augey Mikus.
9814 2002-09-06 Jim Meyering <jim@meyering.net>
9816 * src/remove.c (prompt): Change comment to give a better note to
9817 translators. From Michael Piefel.
9819 2002-09-02 Jim Meyering <jim@meyering.net>
9821 * README: A good problem report/patch includes diffs against
9822 the most recent test release.
9824 * src/pathchk.c (NEED_PATHCONF_WRAPPER): Define.
9825 (pathconf_wrapper): Define only if NEED_PATHCONF_WRAPPER is set.
9827 * src/kill.c (print_table_row): Use an unsigned type for widths
9828 to avoid warning about comparison between signed and unsigned.
9829 (list_signals): Likewise.
9831 * src/od.c (skip): Add a cast to avoid warning about comparison
9832 between signed and unsigned.
9833 * src/install.c (get_ids): Likewise. Also rearrange range-checking
9834 comparisons to make them more readable.
9836 2002-09-01 Jim Meyering <jim@meyering.net>
9840 2002-08-31 Jim Meyering <jim@meyering.net>
9842 Symlinks were always reported as using 0 blocks.
9843 * src/system.h (ST_NBLOCKS): Don't depend on file type.
9844 This reverts the change of 2000-01-30.
9845 Based on a report and patch from Neil Brown via Michael Stone.
9846 This fixes Debian Bug#156358.
9848 * Most files: Change `exit (0)' to `exit (EXIT_SUCCESS)',
9849 `exit (1)' to `exit (EXIT_FAILURE)', and
9850 `usage (1)' to `usage (EXIT_FAILURE)'.
9852 * chgrp.c, chmod.c, chown.c, chroot.c, cp.c, date.c, dd.c, du.c,
9853 * hostname.c, id.c, install.c, ln.c, mkdir.c, mkfifo.c, mknod.c,
9854 * nice.c, pinky.c, printf.c, pwd.c, shred.c, sleep.c, stty.c,
9855 * su.c, tac-pipe.c, tail.c, tee.c, touch.c, uname.c, uptime.c,
9856 * users.c, who.c: Change `error (1, ...' to `error (EXIT_FAILURE, ...'.
9857 But don't change `error (0, ...' to `error (EXIT_SUCCESS, ...', since
9858 error never exits successfully.
9860 2002-08-29 Jim Meyering <jim@meyering.net>
9862 * src/remove.c (remove_cwd_entries): Use closedir (not CLOSEDIR)
9863 when ignoring any return value.
9865 * src/remove.c (remove_cwd_entries): Detect and diagnose readdir
9866 failures. On some systems (at least EMC Celerra and Solaris5.8),
9867 this appears to be necessary.
9868 (is_empty_dir): Likewise. Also, always close directory handle.
9869 * src/ls.c (print_dir): Likewise.
9870 (print_dir): Rename local variable: reading -> dirp.
9871 Reported by Mike Coleman.
9873 2002-08-28 Jim Meyering <jim@meyering.net>
9875 * src/remove.c (remove_cwd_entries): Use CLOSEDIR, not closedir.
9876 Give a diagnostic and fail if closedir fails.
9878 2002-08-26 Jim Meyering <jim@meyering.net>
9880 * Makefile.am (THANKS-to-translators): New rule.
9881 (EXTRA_DIST): Add both THANKS-to-translators and THANKStt.in.
9882 * THANKStt.in: New file.
9884 * src/cat.c (close_stdout_wrapper): New, kludgey, function and
9886 (main): Register it with atexit.
9887 Close STDOUT_FILENO, to avoid a problem when writing to
9888 /dev/audio on at least Solaris 5.7 and 5.8 systems.
9889 Reported by Shing-Shong Shei.
9891 2002-08-25 Jim Meyering <jim@meyering.net>
9893 * src/cat.c (main): Close STDIN_FILENO rather than a literal `0'.
9894 * src/tac.c (main): Likewise.
9895 * src/tail.c (main): Likewise.
9896 * src/tee.c (main): Likewise.
9897 * src/tr.c (main): Likewise.
9898 * src/wc.c (main): Likewise.
9900 2002-08-20 Jim Meyering <jim@meyering.net>
9902 * tests/mv/setup: Rewrite not to use `: ${VAR=not_set}' paradigm.
9904 2002-08-10 Paul Eggert <eggert@twinsun.com>
9906 * src/nohup.sh: Don't use "exec --"; it's not portable and
9907 shouldn't be needed.
9909 2002-08-09 Jim Meyering <jim@meyering.net>
9911 * src/pr.c (main): Don't ignore -COLUMN if it's the last option.
9912 (usage): Clarify help text for the -COLUMN option.
9913 Patch by Padraig Brady.
9914 * tests/pr/Test.pm [col-last]: New test for the above.
9916 * configure.ac: Start with version 4.5.1, chosen so that it's larger
9917 than the latest version numbers of the component packages.
9919 * man/Makefile.am (check-x-vs-1): Set and export PATH so we use
9922 2002-08-08 Jim Meyering <jim@meyering.net>
9924 * src/date.c: Guard inclusion of <langinfo.h> with
9925 `#if HAVE_LANGINFO_CODESET', not `#if HAVE_LANGINFO_H'.
9926 * src/sort.c: Likewise.
9927 Patch by GOTO Masanori.
9929 2002-08-05 Paul Eggert <eggert@twinsun.com>
9931 Fix some minor time-related bugs with POSIX time arguments.
9932 Some valid time stamps were being rejected (notably -1, and
9933 time stamps before 1900 on 64-bit hosts). And some invalid
9934 time stamps were being accepted, e.g. September 31.
9936 * src/date.c (main): Adjust to posixtime signature change.
9937 * src/touch.c (main): Likewise. Remove unnecessary initialization.
9938 Use localtime, not posixtm, to warn about obsolete "touch".
9940 2002-08-05 Jim Meyering <jim@meyering.net>
9942 * tests/misc/Makefile.am (TESTS): Add nice and pathchk1.
9944 2002-08-04 Jim Meyering <jim@meyering.net>
9946 * src/Makefile.am (check-README): New target/rule.
9947 (check): Depend on it.
9949 * configure.ac (AC_CONFIG_FILES): Add old/Makefile and old/*/Makefile.
9951 2002-08-03 Jim Meyering <jim@meyering.net>
9953 * Makefile.am (SUBDIRS): Add old.
9954 * old/: New directory, containing legacy ChangeLog* and NEWS files
9955 from the fileutils, sh-utils, and textutils packages.
9957 * src/Makefile.am (AM_INSTALLCHECK_STD_OPTIONS_EXEMPT): Set to false.
9959 2002-08-02 Paul Eggert <eggert@twinsun.com>
9961 * NEWS, doc/coreutils.texi: uniq now obeys LC_COLLATE.
9963 * src/uniq.c: Include hard-locale.h, xmemcoll.h.
9964 (hard_LC_COLLATE): New var.
9965 (different): Args are now char *, not const char *.
9966 Use xmemcoll instead of memcmp to compare lines, so that
9967 LC_COLLATE has effect. However, use memcmp if it is an
9969 (check_file): Do not include newline in comparison, so that
9970 xmemcoll has a byte to stomp on temporarily.
9971 (main): Set hard_LC_COLLATE.
9973 2002-07-29 Jim Meyering <jim@meyering.net>
9975 * Makefile.am (SUBDIRS): Remove djgpp, for now.
9977 2002-07-20 Jim Meyering <jim@meyering.net>
9979 * Makefile.am (false.c): Convert only the final EXIT_SUCCESS
9980 into EXIT_FAILURE. Otherwise, false --help and false --version
9983 2002-07-08 Jim Meyering <jim@meyering.net>
9985 * src/Makefile.am (uninstall-local): Search for @GNU_PACKAGE@,
9986 rather than the hard-coded `sh-utils'.
9988 2002-07-01 Jim Meyering <jim@meyering.net>
9990 * configure.ac: Merge the three files from fileutils,
9991 textutils, and sh-utils.
9992 * Makefile.am: Likewise.
9993 * src/Makefile.am: Likewise.