1 2006-07-26 Jim Meyering <jim@meyering.net>
3 * src/ls.c (print_color_indicator): Test for S_IFREG first, rather
4 than having the code test for all of the other types first.
5 Hoist the set-uid/gid-testing code "up" into this new block.
6 Classify any other type of file (e.g., S_TYPEISSHM, etc.) as
7 C_ORPHAN, not as C_FILE.
9 2006-07-26 Jim Meyering <jim@meyering.net>
11 Checking in a change from Paul.
13 2006-07-25 Paul Eggert <eggert@cs.ucla.edu>
15 * src/ls.c (DT_INIT): Remove. All uses removed.
16 (enum filetype): Use an ordinary enum rather than trying to keep
17 the values in sync with DT_FIFO etc. That way, we don't have
18 to make special assumptions about them. All uses changed.
19 (whiteout): New constant member of enum filetype.
20 (filetype_letter): New constant, for use with enum filetype.
21 (FILETYPE_INDICATORS): New initializer list.
22 (print_dir): Add case for DT_WHT.
23 (gobble_file): If stat fails, don't discard information from
24 readdir; instead, preserve it so it can be printed.
25 (print_long_format): Fall back on readdir result if stat info
26 is not available. Use "?" to denote each unknown mode char,
27 instead of an overall "?", since we now know some of the mode
29 (print_type_indicator): Now that MODE isn't necessarily
30 useful, guard all uses.
31 Now that two blocks in the type-checking tree can set "type = C_FILE",
32 move the suffix-handling code out and down.
34 2006-07-26 Jim Meyering <jim@meyering.net>
36 Prepare for the above change.
37 * src/ls.c [struct fileinfo] (stat_ok): Rename from stat_failed,
38 and adjust uses. From a patch by Paul Eggert.
40 2006-07-26 Jim Meyering <jim@meyering.net>
42 * src/ls.c: Correct indentation/formatting in a few places.
44 2006-07-25 Paul Eggert <eggert@cs.ucla.edu>
46 * tests/cp/fail-perm: Use "chmod 0500" rather than "chmod 500".
47 Problem report and fix from Bob Proulx.
48 * NEWS: Clarify the "chmod 0500" news, and correct the vague
49 statements about compatibility with BSD.
51 2006-07-25 Jim Meyering <jim@meyering.net>
53 * src/ls.c (gobble_file): When handling a stat-failed entry,
54 print the entry name not the absolute_name -- to be consistent
56 * tests/ls/stat-failed: Update accordingly.
58 * src/ls.c: Add parens around the new uses of ?: ternary operator.
60 * src/dircolors.hin: Mention that ORPHAN refers not just to dangling
63 Get --dired offsets right when handling stat-failed entries.
64 * src/ls.c (print_long_format): Be careful to increment P by the
65 appropriate amount, even when inode_number_width and nlink_width
67 * tests/ls/stat-failed: Test for the above.
69 * src/ls.c (gobble_file) [USE_ACL]: Don't use-uninitialized the
70 have_acl member. That would happen for a directory with both a
71 non-stat'able entry and one with an ACL.
73 * src/ls.c (gobble_file): Make it so failure to stat a
74 non-command-line file provokes an exit status of 1, not 0.
75 Say "cannot access" rather than "cannot stat".
76 * tests/ls/stat-failed: New file/test, for the above.
77 * tests/ls/Makefile.am (TESTS): Add stat-failed.
78 * tests/ls-2/tests (no-a-isdir-b): Update to reflect addition
79 of "cannot access " to diagnostic.
81 * src/ls.c: Declare stat_failed to be "bool", not "int" everywhere.
83 * src/ls.c [enum filetype] (command_line): Remove member. Not needed.
84 Replace all occurrences of "type == command_line" with the
85 equivalent, "command_line_arg".
87 * src/ls.c: Apply the stat-failed parts of Red Hat's
88 coreutils-selinux.patch. From Ulrich Drepper.
89 This makes it so files not mentioned on the command line (e.g.,
90 names read from a directory that *is* mentioned on the command
91 line) for which stat fails are still listed. With --color,
92 such files are colored just like ORPHANs (aka dangling symlinks).
94 * src/df.c (n_valid_args): Declare global to be static.
96 2006-07-24 Jim Meyering <jim@meyering.net>
98 * tests/ls/stat-dtype: Skip this test on reiserfs, since that file
99 system lacks d_type support.
101 2006-07-22 Paul Eggert <eggert@cs.ucla.edu>
103 * man/chmod.x: Update to reflect recent changes to coreutils.texi.
105 2006-07-21 Jim Meyering <jim@meyering.net>
107 * src/su.c (usage): Correct typo in --help output: s/commmand/command/
108 Reported by Tim Waugh.
109 Also remove the comment duplicating much of --help output.
111 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): Reposition this new
112 name so the list remains alphabetized.
114 Fix another bug: ls --indicator-style=file-type would call
115 stat for a symlink, even though it wasn't always needed.
116 In some cases, that unnecessary stat would cause ls to fail.
117 * src/ls.c (gobble_file): Don't treat symlinks specially (in
118 requiring a stat syscall). Remove the offending exclusion.
120 * NEWS: Mention the fix.
122 * tests/ls/stat-dtype: New file/test, for the above fix.
123 Also exercises the new df feature, below.
125 * src/df.c (main): Fail and don't print the headers if no
126 file system is processed. This makes it easy to test whether
127 a specified directory is on a file system of a given type or types.
128 Otherwise, applications would have had to parse df's output.
129 E.g., is "." either ext3 or reiserfs: df -t ext3 -t reiserfs .
131 Fix a bug: ls --file-type worked like --indicator-style=slash,
132 rather than like --indicator-style=file-type.
133 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): New enum member.
134 (long_options): Map "file-type" to FILE_TYPE_INDICATOR_OPTION,
136 (decode_switches): Handle new case: FILE_TYPE_INDICATOR_OPTION.
137 * NEWS: Mention the fix.
138 * tests/ls-2/tests (file-type): New test, for the above fix.
140 2006-07-19 Jim Meyering <jim@meyering.net>
142 * src/ls.c (print_dir): Give a better diagnostic for failed opendir.
144 * Makefile.am (EXTRA_DIST): Add build-aux/vc-list-files.
146 2006-07-16 Paul Eggert <eggert@cs.ucla.edu>
148 * NEWS: chmod, install, and mkdir now leave setgid and setuid bits
149 of directories alone unless you specify them explicitly.
150 install and mkdir now implement X correctly.
151 install now creates parent directories with mode 755, without
152 changing their owner or group.
153 * src/chmod.c (process_file): Adjust to mode_adjust API change.
154 * src/install.c: Include mkancesdirs.h.
155 (announce_mkdir, make_ancestor): New functions.
156 (DEFAULT_MODE): New macro, specifying initial value of 'mode'.
158 (dir_mode, dir_mode_bits): New vars.
159 (main): Set dir modes separately from nondir, so that the X
160 op of -m works correctly.
161 (main): Remove cwd_errno cruft, since make_dir_parents no longer
162 affects cwd. Adjust to new make_dir_parents API.
163 (install_file_in_file_parents): 2nd arg is now char *, not char
164 const *. Use mkancesdirs instead of rolling our own code.
165 (change_attributes): Don't worry about AFS, since that kludge
166 should not be needed any more.
167 * src/mkdir.c (struct mkdir_options): New struct.
168 (announce_mkdir, make_ancestor): New functions.
169 (main): Use them. Adjust to mode_adjust API change. Stick with
170 umask 0. Use make_dir_parents for all the work.
171 * src/mkfifo.c (main): Adjust to new mode_adjust API.
172 * src/mknod.c (main): Likewise.
173 * tests/chmod/setgid: Do the setgid test instead of bailing.
174 * tests/mkdir/p-3: Remove re_protect case that no longer applies.
175 GNU chmod now behaves like other versions of chmod.
176 * tests/mkdir/perm: Add a test for the X bug.
178 2006-07-14 Paul Eggert <eggert@cs.ucla.edu>
180 * src/base64.c (do_decode): Output to parameter OUT, not to stdout.
181 This doesn't fix any bugs, since OUT always equals stdout, but it
182 makes the code easier to understand.
184 2006-07-14 Jim Meyering <jim@meyering.net>
186 * Makefile.maint (CVS_LIST): Use new file, build-aux/vc-list-files,
187 rather than open-coding it. Now supports mercurial, too.
188 * .hgignore: New file.
189 * Makefile.am (EXTRA_DIST): Add .hgignore, which ignores nearly
190 all generated files, including ones like configure and po/*.po
191 that are currently version-controlled in cvs.
193 * Makefile.am (EXTRA_DIST): Add a few more .??* files.
194 They've been in CVS, just haven't been distributed before this.
195 Distribute ChangeLog-2005, too.
196 (MAINTAINERCLEANFILES): Add THANKS-to-translators.
198 2006-07-11 Paul Eggert <eggert@cs.ucla.edu>
200 * src/system.h: Assume <dirent.h> exists, since gnulib assumes
203 2006-07-09 Jim Meyering <jim@meyering.net>
205 * tests/mv/dir2dir: Adjust so failing with ENOTEMPTY is ok, too.
206 That happens with Linux/tmpfs.
207 * tests/mv/Makefile.am (TESTS): Add dir2dir.
209 2006-07-09 Paul Eggert <eggert@cs.ucla.edu>
211 Adjust to recent updates from gnulib.
212 * src/dd.c (apply_translations): Use toupper rather than
213 islower followed by toupper; it's simpler and typically
214 faster now that we assume at least C89 semantics. Similarly
216 * src/sort.c (inittables): Likewise.
217 * src/expand.c (expand): Don't assume that isprint etc. return
218 booleans (needed for pre-C99 hosts).
219 * src/fmt.c (check_punctuation): Likewise.
220 * src/ptx.c (initialize_regex, fix_output_parameters): Likewise.
221 * src/tr.c (is_char_class_member): Likewise.
222 * src/unexpand.c (unexpand): Likewise.
223 * src/join.c (is_blank): Remove; no longer needed. All uses
224 replaced by isblank (to_uchar (...)).
225 * src/pinky.c (create_fullname): Don't assume char is unsigned.
226 * src/printf.c (print_esc): Likewise.
227 * src/ptx.c (SKIP_NON_WHITE, SKIP_WHITE, SKIP_WHITE_BACKWARDS):
228 (copy_unescaped_string): Likewise.
229 * src/stat.c (print_it): Likewise.
230 * src/system.h (_D_EXACT_NAMELEN): Renamed from NLENGTH, for
231 convenience on GNU systems. All uses changed. Don't bother
232 looking for any dirent.h substitute other than ndir.h.
233 (D_INO): Remove unnecessary parentheses.
234 (IN_CTYPE_DOMAIN, ISGRAPH, ISPRINT, ISALNUM, ISALPHA):
235 (ISCNTRL, ISLOWER, ISPUNCT, ISSPACE, ISUPPER, ISXDIGIT):
236 (ISDIGIT_LOCALE, TOLOWER, TOUPPER): Remove. All uses changed
237 to ctype.h equivalents.
238 (isblank): Renamed from ISBLANK. Check for HAVE_DECL_ISBLANK too.
241 2006-07-08 Jim Meyering <jim@meyering.net>
243 * tests/mv/dir2dir: New file, test for 2006-07-05 fix in copy.c.
245 * Makefile.maint (sc_the_the): New rule.
247 * src/dd.c (skip): Remove one of two adjacent "the"s in a comment.
248 * tests/Coreutils.pm (run_tests): Remove one of two adjacent "then"s
251 2006-07-07 Jim Meyering <jim@meyering.net>
253 * NEWS: Mention that mv can now remove an empty destination directory,
254 and give an example. Prompted by a report from Florent Bayle.
256 2006-07-05 Jim Meyering <jim@meyering.net>
258 * src/ls.c (usage): Correct the description of -G: it is useful
259 only in a long listing. Reported by Martin Pool in
260 <https://launchpad.net/distros/ubuntu/+source/coreutils/+bug/51653>.
262 * man/chmod.x: Correct the description of the sticky bit. Reported
263 by Chris Moore via Ian Jackson in <http://bugs.debian.org/376745>.
265 * src/copy.c (copy_internal): Don't work around old NFS clients like
266 SunOS-4.1.4 and Irix 5.3 that set errno to values like EIO and
267 ENOTEMPTY upon failed rename. Otherwise, we risk misinterpreting
268 a banal failure as a recursive move-into-self failure.
269 Reported by Florent Bayle in <http://bugs.debian.org/376749>.
271 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
273 2006-07-03 Jim Meyering <jim@meyering.net>
275 Plug another unusual leak.
276 (AD_mark_helper): Free malloc'd filename if hash_insert says
277 that string is already in the hash table.
279 The dev/inode of the topmost directory in each hierarchy were not
281 * src/remove.c (remove_cwd_entries): Don't call cycle_check here.
282 (AD_push): Call it from here instead.
285 * src/remove.c (AD_stack_clear): New function.
287 (AD_pop_and_chdir): Free *prev_dir just before longjmp.
289 * tests/Makefile.am, tests/*/Makefile.am: (TESTS_ENVIRONMENT):
290 Add $VG_PATH_PREFIX as a prefix to $PATH
292 * tests/envvar-check (vars): Add CDPATH and POSIXLY_CORRECT.
293 * tests/Makefile.am (evar-check): Remove rule.
294 (EXTRA_DIST): Remove .env-warn.
295 * tests/.env-warn: Remove file. No longer used.
296 Suggestion from Eric Blake.
298 2006-07-02 Paul Eggert <eggert@cs.ucla.edu>
300 * src/system.h: Include <stdint.h> unconditionally, since we
301 now assume the stdint module.
303 2006-07-01 Paul Eggert <eggert@cs.ucla.edu>
305 * NEWS: With no operand, 'tail -f' now silently ignores the '-f'
306 only if standard input is a FIFO or pipe and POSIXLY_CORRECT is set.
307 * src/tail.c (main): Implement this.
308 * tests/tail/Test.pm (f-pipe-1): Renamed from f-1.
309 (test_vector): Set POSIXLY_CORRECT for the f-pipe-* tests.
311 2006-07-01 Jim Meyering <jim@meyering.net>
313 * src/ln.c (do_link): Use new, shorter URL, for ag-review link.
315 * .x-sc_require_config_h: Add ^lib/xstrtold\.c$, so make distcheck
318 2006-06-30 Paul Eggert <eggert@cs.ucla.edu>
320 * NEWS: seq now uses long double internally rather than double.
321 It now defaults to a minimal fixed point format if possible.
322 It lets you use %a, %A, %E, %F, %G.
323 * src/Makefile.am (seq_LDADD): Remove $(SEQ_LIBM); add $(POW_LIB).
324 * src/seq.c: Don't include <math.h> or <xstrtol.h>; no longer needed.
325 (isfinite) [!defined isfinite]: New macro.
326 (separator, terminator): Now points to const.
327 (first, step, last): Remove.
328 (usage): Update to match new behavior.
329 (struct operand, operand): New type.
330 (scan_arg): Renamed from scan_double_arg, since we no longer use double.
332 Compute and return a value of type operand, not double.
333 (long_double_format): Renamed from valid_format, and now returns a
334 new format with an "L" added if needed, if the original format was
335 valid. Allow %a, %A, %E, %F, and %G formats.
336 (print_numbers): Take numeric values as args rather than from globals.
337 Print long double, not double.
338 (get_width_format): Remove.
339 (get_default_format): New function.
340 (main): Implement new way of calculating default format.
341 Don't worry about locale's representation of the decimal point, since
342 the arguments are always processed in the C locale.
343 * tests/seq/basic (neg-2): Adjust to new default format.
344 (eq-wid-1, eq-wid-2): Resurrect these tests, since the new
345 implementation should do the right thing.
347 2006-06-30 Jim Meyering <jim@meyering.net>
349 * tests/stty/basic-1: Work around an intermittent test failure
350 on HP-UX 11.11. Report and analysis from Bob Proulx.
351 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7475
353 2006-06-28 Paul Eggert <eggert@cs.ucla.edu>
355 * NEWS: Support obsolete usages like "sort +1 -2" even when
356 conforming to POSIX 1003.1-2001, since this is a pure extension to
357 POSIX. Problem reported by Christian in:
358 http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00220.html
359 * src/sort.c (main): Implement this.
361 * src/system.h (CLOSEDIR): Remove. All uses changed to closedir.
362 Autoconf 2.60 says this stuff was obsolete.
364 2006-06-28 Jim Meyering <jim@meyering.net>
366 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
368 2006-06-28 Bob Proulx <bob@proulx.com> (tiny change)
370 * tests/mv/i-link-no: Work around HP-UX /bin/sh tracing problem
371 (set -x when VERBOSE=yes) when stderr is redirected before stdout
372 causing shell tracing of the stdout redirection to be written to
373 the stderr file. Avoid problem and test failure on HP-UX by
374 redirecting stderr last.
375 * tests/dd/unblock-sync: Order shell file redirections for
376 stderr and stdout in the common style.
379 2006-06-27 Jim Meyering <jim@meyering.net>
381 * tests/misc/cat-proc: Try to avoid any spurious numeric
382 differences in frequently-changing /proc/cpuinfo.
383 Reported by Nelson Beebe.
385 2006-06-26 Jim Meyering <jim@meyering.net>
387 Attempt rmdir (actually, unlinkat-with-AT_REMOVEDIR) upon any
388 fd_to_subdirp failure, not just when errno == EACCES.
389 * src/remove.c (remove_dir): Use unlinkat-with-AT_REMOVEDIR, not
390 rmdir, here, even though rmdir may happen to be adequate.
392 * NEWS: rm no longer fails to remove an empty, unreadable directory
393 * src/remove.c (remove_cwd_entries): If we can't open a directory,
394 and the failure is not being ignored, try to remove the directory
395 with rmdir (aka unlinkat-with-AT_REMOVEDIR), in case it's empty.
396 Problem report and test case from Paul Eggert in
397 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7425>.
399 * tests/rm/empty-inacc: New test, for the above.
401 Avoid a segfault for wc --files0=- < /dev/null.
402 * src/wc.c (compute_number_width): Return right away if nfiles == 0.
404 2006-06-25 Jim Meyering <jim@meyering.net>
406 * NEWS: wc accepts a new option --files0-from=FILE, where FILE
407 contains a list of NUL-separated file names.
409 * src/wc.c: Include "readtokens.h".
410 (usage): Describe the new option, and adjust the `Usage':
411 with this option, no FILE may be specified on the command line.
412 (main): Handle the new option.
413 * tests/misc/wc-files0: New tests, for the above.
414 * tests/misc/wc-files0-from: Likewise.
415 * tests/misc/Makefile.am (TESTS): Add wc-files0.
417 2006-06-24 Jim Meyering <jim@meyering.net>
419 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
421 2006-06-22 Jim Meyering <jim@meyering.net>
423 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
424 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
426 2006-06-19 Jim Meyering <jim@meyering.net>
428 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
429 so this check is not run as part of "make distcheck".
431 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
433 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
435 2006-06-18 Jim Meyering <jim@meyering.net>
437 * tests/misc/pwd-long: Make error output a little clearer.
439 2006-06-17 Jim Meyering <jim@meyering.net>
441 * tests/rm/inaccessible: Skip this test on systems without openat
442 support. Reported by Bob Proulx.
444 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
446 * tests/misc/mknod: Improve permission checks to handle
447 running mkdir test in set-gid directories.
449 2006-06-14 Jim Meyering <jim@meyering.net>
451 * tests/du/basic: Revamp not to hard-code file system block sizes.
453 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
455 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
458 2006-06-11 Jim Meyering <jim@meyering.net>
460 * .gitignore: New file.
461 * Makefile.am (EXTRA_DIST): Add .gitignore.
463 Setting TIME_STYLE=long-iso in the environment would make the
464 cp/same-file test fail.
465 * tests/envvar-check (vars): Add TIME_STYLE to the list.
466 * tests/cp/same-file: Revert last change.
467 Source the envvar-check script, to ensure that TIME_STYLE
468 settings don't affect these tests.
470 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
472 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
473 uses POSIX time stamp formats. Problem reported by John Nixon in
474 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
476 2006-06-10 Jim Meyering <jim@meyering.net>
478 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
480 Require a "Version N.M" line at the top of the ChangeLog
481 file only when making the actual release, not when running
483 * Makefile.maint (maintainer-distcheck): Don't depend on
485 (alpha beta major): Depend on it here, instead.
487 2006-06-08 Jim Meyering <jim@meyering.net>
489 Ensure that cat works with any of the options, -A -v -e -E -T,
490 when applied to files in /proc and /sys, even when the FIONREAD
491 ioctl produces nonsensical results. Before this change, cat would
492 produce no output (or truncated output), for some linux kernels.
494 * src/cat.c (write_pending): New function, factored out of cat.
495 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
496 that there are bytes to read. Some versions of linux-2.6.16 do that.
497 Write any pending output before returning.
498 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
499 * NEWS: Mention this bug fix.
500 * tests/misc/cat-proc: New file. Test for the above.
501 * tests/misc/Makefile.am (TESTS): Add cat-proc.
503 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
505 * src/expr.c (eval4): Detect overflow properly when multiplying
508 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
510 * NEWS: The 'expr' command now detects and reports integer overflow.
511 (It would be better to use extended precision instead, but that
513 * src/expr.c (integer_overflow): New function.
514 (eval4, eval3): Check for integer overflow.
516 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
518 Fix problems when building with Solaris/SVR4/etc. make, which uses a
519 different and somewhat bogus implementation of VPATH. In the
520 directory tests/misc, rename tests whose names might appear in the
521 Automake-generated rules. For example, we can't use a test named
522 'test', since Automake generates a rule that contains the text
523 "if test -f ./$$tst; ...", and this might expand to something like
524 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
525 which executes the 'test' script rather than the 'test' command.
526 * tests/misc/false-status: Renamed from tests/misc/false.
527 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
528 * tests/misc/sort-merge: Renamed from tests/misc/sort.
529 ($prog): Set to 'sort' rather than to $PROG.
530 * tests/misc/test-diag: Renamed from tests/misc/test.
531 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
532 in case Solaris make has prepended the directory.
533 (TESTS): Adjust to above renamings.
534 * tests/misc/expand: Don't assign to PROG; no longer needed
535 now that Makefile.am sets PROG to the basename.
536 * tests/misc/fold: Likewise.
538 2006-06-03 Jim Meyering <jim@meyering.net>
540 Make `cp --link --no-dereference' work also on systems where the
541 link system call cannot create a hard link to a symbolic link.
542 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
543 the link syscall on a symlink when it would do the wrong thing.
544 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
545 * tests/cp/link-no-deref: New file/test for the above.
546 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
547 * NEWS: Mention the change (doesn't affect Linux).
549 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
551 Fix some porting problems in the test cases reported by
552 Ralf Wildenhues for HP-UX 11.23 in:
553 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
554 * tests/help-version: Don't assume that \< \> works in sed.
555 * tests/misc/close-stdout: Don't assume that >&- works.
556 Add a /dev/full test.
557 * tests/touch/no-create-missing: Don't assume that >&- works.
559 2006-05-30 Jim Meyering <jim@meyering.net>
561 * src/ls.c (usage): Add `v' to the list of sorting-related options.
564 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
566 * tests/cp/fail-perm: source lang-default.
567 * tests/rm/inaccessible: Likewise.
569 2006-05-28 Jim Meyering <jim@meyering.net>
571 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
572 Recognize it, too. Reported by Ralf Wildenhues, in
573 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
575 2006-05-27 Jim Meyering <jim@meyering.net>
577 * src/chgrp.c: Support new options: --preserve-root and
578 --no-preserve-root. Somehow this program was skipped when those
579 options were added to chown, chmod, and rm. Reported by
580 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
581 * NEWS: Mention this.
583 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
585 * NEWS: Remove mention of --seed. We'll replace it with something
586 better, and don't want to indicate that it is supported.
587 * src/sort.c (usage): Likewise.
589 2006-05-20 Jim Meyering <jim@meyering.net>
591 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
593 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
594 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
595 FTS_COMFOLLOW. Spotted by Justin Pryzby.
597 * gnupload: Merge changes from automake, retaining the ""--to...
598 kludge to placate overzealous `make distcheck' check.
600 2006-05-19 Jim Meyering <jim@meyering.net>
602 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
603 FTS_TIGHT_CYCLE_CHECK directory traversal option.
604 Reported by Justin Pryzby in http://bugs.debian.org/367691
606 2006-05-15 Jim Meyering <jim@meyering.net>
608 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
611 2006-05-13 Jim Meyering <jim@meyering.net>
613 * tests/mv/no-target-dir: Test two more cases.
615 2006-05-11 Jim Meyering <jim@meyering.net>
617 mv -T DIR EMPTY_DIR no longer fails unconditionally
618 * src/copy.c (copy_internal): Don't manually prohibit a move where
619 the destination is an existing directory. Sometimes doing that is
620 valid. Let the rename system call enforce the rules. That is
621 allowed only when the source is a directory and the destination
622 directory (to be replaced) is empty. Reported by Eric Blake.
623 * tests/mv/no-target-dir: New file/test for this.
624 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
625 * NEWS: Mention this.
627 * tests/mv/atomic: New file/test for yesterday's fix.
628 * tests/mv/Makefile.am (TESTS): Add atomic.
630 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
632 2006-05-10 Jim Meyering <jim@meyering.net>
634 * src/copy.c (copy_internal): Don't explicitly unlink the destination
635 when moving a symlink into the place of an existing non-directory.
636 Reported by Joshua Hudson.
637 * NEWS: mention this.
639 2006-05-07 Jim Meyering <jim@meyering.net>
641 * Makefile.maint (patch-check): Fail if patch generates any output,
642 even merely for changed offsets.
644 * src/c99-to-c89.diff: Adjust to reflect new offsets.
646 * NEWS: Mention changes affecting df, pwd, shred.
648 2006-05-06 Jim Meyering <jim@meyering.net>
650 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
651 system condition where dirent.d_ino != stat.st_ino.
652 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
654 2006-05-06 Eric Blake <ebb9@byu.net>
656 * tests/ls/inode: Expand to test inode from readdir case.
657 * tests/ls/follow-slink: Expand to test broken links encountered
658 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
660 2006-05-06 Eric Blake <ebb9@byu.net>
662 * tests/mv/leak-fd: Work even on case-insensitive file system.
664 2006-05-04 Jim Meyering <jim@meyering.net>
666 * NEWS: Mention the 2006-03-19 pwd-related change that makes
667 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
669 2006-05-03 Jim Meyering <jim@meyering.net>
671 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
672 Use better macro parameter names: s/basename/key_name/,
673 s/basefunc/key_cmp_func. Fix typo in comment.
675 2006-04-29 Eric Blake <ebb9@byu.net>
677 * src/ls.c (main): On systems with d_type, directories_first only
678 implies format_needs_type, not format_needs_stat.
680 2006-05-03 Jim Meyering <jim@meyering.net>
682 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
683 after comma in arg list, from Eric Blake.
685 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
687 * tests/misc/date (relative-3): New test, derived from a bug
688 report by John Thomas McDole.
690 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
692 New option for ls: --group-directories-first.
693 It makes ls list directories before files.
694 * NEWS [New features]: Mention it.
695 * src/ls.c (sort_type): Rearrange to use as an array index when
696 choosing sort function; added new sort_numtypes member for
698 (time_type): Add new time_numtypes member for compile-time check.
699 (directories_first): New global variable.
700 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
701 (long_options): Add --directories-first.
702 (main): Support new option.
703 (is_directory): New function.
704 (extract_dirs_from_files): Use it.
705 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
706 (LIST_SORTFUNCTION_VARIANTS): New macros.
707 (sort_functions): New global variable.
708 (sort_files): Use it.
709 (usage): Document new option.
711 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
713 * src/shred.c (fillrand): The assertion was way too weak, due to
714 what must be a typo. Strengthen it to its intended value.
715 (dopass): Don't use alloca; it's not worth the aggravation here,
716 since it's used only to get a page-aligned buffer, and page
717 alignment doesn't buy us much here. I'm suspicious that alloca
718 causes problems on some hosts, due to a recent bug report by Adam
719 Waltman: http://bugs.gentoo.org/130246.
721 2006-04-18 Jim Meyering <jim@meyering.net>
723 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
724 sha384sum, sha512sum.
726 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
728 * src/chmod.c (describe_change): Adjust to filemode changes.
729 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
730 (print_long_format): Use (new) filemodestring rather than
731 (old) mode_string, so that we get more file types right, at least
732 in theory. Adjust to filemode changes.
733 * src/stat.c (human_access): Likewise.
735 2006-04-18 Jim Meyering <jim@meyering.net>
737 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
738 ignore file. This has never been enabled. Reported by Eric Blake.
740 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
742 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
743 bug in Interix. Just call symlink or link directly. All uses changed.
744 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
745 * src/stat.c (USE_STATVFS): New macro.
746 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
747 (NAMEMAX_FORMAT): define a bit more clearly, now that the
748 statvfs-using code is a bit more regular.
749 * src/system.h (sync) [!HAVE_SYNC]: New macro.
751 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
753 * NEWS: csplit, nl, expr now conform to POSIX better, and are
754 more-compatible with traditional Unix, with respect to regular
756 * src/csplit.c (extract_regexp): Set re_syntax_options to a
757 value that is compatible with what POSIX requires.
758 * src/nl.c (build_type_arg): Likewise.
759 * src/expr.c (docolon): Likewise. Also, don't let anchors match
760 newline; this fixes an incompatibility with tradition and with POSIX.
761 Don't warn about leading ^. POSIX says it is unspecified whether
762 ^ is a special character, which means that implementations can
763 either treat it as special or not, but either way a warning is not
764 allowed (unless the regexp is otherwise invalid). Instead, anchor
765 the expression but treat ^ as an anchor; this is the traditional
766 behavior (e.g., Solaris 10).
767 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
768 and the like as invalid expressions (exit status 2), not as
769 failure of 'expr' (exit status 3). This is more consistent with
771 * tests/expr/basic (fail-a): Adjust exit status to match new expr
772 behavior, for status 2 versus 3.
774 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
775 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
776 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
777 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
778 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
779 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
780 (bre61, bre62): New tests.
781 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
785 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
786 "if !". Do not assume that 'sed' can handle long, newline-free input.
787 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
789 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
791 Adjust to new regex.h API (with new fastmap type), and clean
792 up the regex storage allocation a bit.
794 * src/csplit.c (struct control): Put re_compiled member at the
795 end, since it's large. Change regexpr member from char * to bool;
796 all uses changed. Add new member fastmap.
797 (extract_regexp): regexp arg is now char const *, not char *.
798 Don't bother duplicating the regular expression; it's not needed.
799 Set fastmap from new fastmap member. Don't bother allocating
800 a buffer, as the regexp code does a better job than we do.
801 * src/expr.c (docolon): Allocate and use a fastmap.
802 Don't bother allocating a buffer.
803 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
805 (build_type_arg): New fastmap arg. All uses changed.
806 Don't bother allocating a buffer, but set a fastmap.
807 * src/ptx.c (context_regex_string, word_regex_string): Remove.
808 (context_regex, word_regex): New vars, replacing the above.
810 (struct regex_data): New type.
811 (compile_regex): Renamed from alloc_and_compile_regex, since
812 we no longer allocate storage. Arg is now a struct regex_data *,
813 not a const char *. All uses changed. Don't allocate the fastmap;
814 instead, take it from the caller. Don't convert size_t to int,
815 to avoid arithmetic overflow problems. Don't bother freeing
816 storage afterwards; it's not worth the aggravation.
817 * src/tac.c (compiled_separator_fastmap): New ver.
818 (main): Use it. Don't bother allocating a buffer.
820 2006-03-30 Jim Meyering <jim@meyering.net>
822 * src/dd.c (iwrite): Remove assignment without effect.
823 Reported by Felix Rauch Valenti.
825 2006-03-22 Eric Blake <ebb9@byu.net>
827 * src/ptx.c (usage): Remove mention of --copyright/-C.
828 (main): Alias --copyright to --version plus a deprecation warning.
829 * NEWS: Mention this.
831 2006-03-27 Jim Meyering <jim@meyering.net>
833 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
834 use of strtod. Tiny patch from Nickolai Zeldovich.
836 2006-03-11 Eric Blake <ebb9@byu.net>
838 * tests/misc/dirname: New file.
839 * tests/basename/Makefile.am: Delete.
840 * tests/basename/basic: Move to...
841 * tests/misc/basename: ... this new file. Add some tests,
842 including fixed behavior for //.
843 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
844 * tests/Makefile.am (SUBDIRS): Remove basename.
845 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
847 Improvements to dirname/basename handling on platforms like
848 cygwin with distinct // and with drive letters.
849 * NEWS: Document new behavior.
850 * src/basename.c (main): Don't strip suffix from file system
852 * src/cp.c (target_directory_operand): Use new last_component.
853 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
854 traversing the string.
855 * src/dircolors.c (guess_shell_syntax): Use new last_component.
856 * src/install.c (target_directory_operand, install_file_in_dir):
858 * src/ln.c (target_directory_operand, main): Likewise.
859 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
860 * src/mv.c (target_directory_operand, movefile): Likewise.
861 * src/remove.c (rm_1): Likewise.
862 * src/shred.c (wipename): Likewise.
863 * src/split.c (next_file_name): Likewise.
864 * src/su.c (log_su, run_shell): Likewise.
866 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
868 * NEWS: nohup diagnostics are now more precise, and nohup now
869 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
870 * src/nohup.c (main): Implement this.
871 * tests/misc/nohup: Test the new behavior.
873 2006-03-12 Jim Meyering <jim@meyering.net>
875 * src/copy.c (set_author): Rename function, from preserve_author.
877 * src/remove.c (AD_pop_and_chdir): Use new macro,
878 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
880 * src/system.h (SAME_INODE): Remove definition.
881 Include "same-inode.h", instead.
883 2006-03-11 Eric Blake <ebb9@byu.net>
885 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
887 2006-03-10 Jim Meyering <jim@meyering.net>
889 Fix a bug whereby a user with write access to a directory being removed
890 could cause the removal of that directory to fail with an erroneous
891 diagnostic about a directory cycle. Reported by Vineet Chadha.
893 * NEWS: Mention this.
894 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
895 leave (and try to rmdir) is the one whose dev_ino is being used to
896 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
898 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
900 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
901 * src/dd.c (set_fd_flags): Handle file-creation flags on file
902 descriptors, rather than ignoring them.
903 * tests/dd/misc: Add test cases for append, nofollow, directory,
904 and nolinks flags. Simplify redirection to /dev/null in some cases.
906 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
907 noatime test never tested anything.
909 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
911 * src/dd.c (flags, usage): New flags directory, nolinks.
912 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
914 * src/ls.c (usage): Mention that -f disables --color.
915 Problem reported by Niels Möller.
917 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
919 * man/*.x: Add references to syscalls from utilities of the same name.
921 2006-03-05 Jim Meyering <jim@meyering.net>
923 * tests/help-version: Set SHELL, if not already set, in order to
924 avoid failure when `make check' is run through debuild; dircolors
925 would fail due to lack of $SHELL. Reported by Sven Joachim.
927 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
928 * src/base64.c (wrap_write, do_encode, main): Change type of
929 parameters and locals, wrap_column, form size_t to uintmax_t.
930 (main): Adjust to use xstrtoumax, accordingly.
932 2006-03-03 Jim Meyering <jim@meyering.net>
934 Don't fail when run from an environment with SHELL not a Bourne
935 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
936 * tests/dircolors/simple: Invoke each non-failing test with -b.
937 Reported by Michael Stone.
939 2006-02-27 Jim Meyering <jim@meyering.net>
941 * tests/misc/base64: Derive --decode-using tests from the
944 * tests/misc/base64: Factor out a long constant string.
945 Split lines to stay within 80 columns.
947 * tests/misc/Makefile.am (TESTS): Add base64.
948 * tests/misc/base64: Test base64. From Simon Josefsson.
950 * src/base64.c (do_decode): Use correct type for parameter,
951 ignore_garbage: s/size_t/bool/.
953 * src/base64.c: Don't include .h files already included by system.h:
954 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
955 Include "system.h" before the other lib/*.h header files.
956 Include <sys/types.h> before "system.h".
957 (wrap_write): Remove declaration of unused local, initial_column.
958 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
960 * README: Add base64 to the list.
962 2006-02-17 Simon Josefsson <jas@extundo.com>
965 * AUTHORS: Mention base64.
967 * man/Makefile.am: Build base64.1.
968 * man/base64.x: New file.
969 * src/Makefile.am (bin_PROGRAMS): Add base64.
970 * src/base64.c: New file.
972 2006-02-25 Eric Blake <ebb9@byu.net>
974 In ls, avoid calling stat for --inode (-i), when possible.
975 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
976 * src/system.h: ... here, for use in ...
977 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
979 (gobble_file): Add inode argument.
980 (print_dir): Pass inode if available.
981 (usage): Remove inaccuracy.
983 2006-02-23 Jim Meyering <jim@meyering.net>
985 * TODO: Update/correct some obsolete entries.
987 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
989 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
990 * src/join.c (usage): Likewise.
991 Documentation problem reported by Philip Kensche.
993 2006-02-20 Eric Blake <ebb9@byu.net>
995 * man/rm.x: Update documentation to match previous patch.
997 2006-02-18 Eric Blake <ebb9@byu.net>
999 New option for rm: --interactive=once (-I).
1000 * NEWS: Document it, along with change to rm --interactive.
1001 * TODO: Remove entry for implementing rm -I
1002 * src/rm.c (INTERACTIVE_OPTION): New enum value.
1003 (interactive_type): New enum.
1004 (long_opts): Let interactive take an optional argument.
1005 (interactive_args, interactive_types): New option arguments.
1006 (usage): Document -I, --interactive=WHEN. Use program_name
1007 instead of a basename.
1008 (main): New -I option, new behavior to --interactive.
1009 * tests/rm/interactive-once: New tests.
1010 * tests/rm/interactive-always: Ditto.
1011 * tests/rm/Makefile.am (TESTS): Run them.
1013 2006-02-18 Jim Meyering <jim@meyering.net>
1015 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
1016 expression match more of the target lines, e.g., those that start with
1017 `-S,' (short option followed by a comma) or that include `=[...]'.
1018 Patch by Nicolas François.
1019 Fix the four offenders thus exposed:
1020 * src/join.c (usage): Use two spaces (not one) to separate the
1021 --first-only option string from its description, so help2man formats
1022 the derived man page properly.
1023 * src/pr.c (usage): Likewise.
1024 * src/uniq.c (usage): Likewise.
1025 * src/install.c (usage): Likewise.
1027 2006-02-15 Jim Meyering <jim@meyering.net>
1029 * Makefile.maint (alpha beta major): For `make major', ensure that the
1030 version string is of the form N.N[.N]*, where N is one or more digits.
1032 2006-02-14 Jim Meyering <jim@meyering.net>
1034 * INSTALL: Update from gnulib.
1036 2006-02-13 Jim Meyering <jim@meyering.net>
1038 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
1040 2006-02-12 Jim Meyering <jim@meyering.net>
1042 * Makefile.maint (patch-check): New target.
1043 (local-checks-available): Add to the list.
1045 2006-02-11 Jim Meyering <jim@meyering.net>
1047 * src/c99-to-c89.diff: New file.
1048 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
1050 * .x-po-check: New file, with exclusions so that `make distcheck'
1052 * Makefile.am (EXTRA_DIST): Add .x-po-check.
1054 rm -r must remove an empty directory, even if it is inaccessible.
1055 * src/remove.c (close_preserve_errno): New function.
1056 (fd_to_subdirp): Don't print a diagnostic in this function.
1057 Do it from the callers instead, unless rmdir succeeds.
1058 (remove_cwd_entries, remove_dir): Adjust callers.
1059 * tests/rm/empty-inacc: New test for the above.
1060 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
1061 * NEWS: Mention this bug fix.
1062 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
1063 a tiny bit less precise: cannot remove `a/1': ... instead of
1064 cannot open directory `a/1': ...
1066 * Makefile.maint (syntax-check-rules): Automatically derive this
1067 list of sc_-prefixed rule names.
1069 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
1071 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
1072 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
1073 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
1074 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
1075 go away? was that an accident?)
1076 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
1077 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
1078 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
1079 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
1080 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
1081 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
1082 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
1083 (author_mark_check, makefile_path_separator_check):
1084 Output line numbers, to simplify navigation of Emacs *compilation*
1086 (sc_prohibit_atoi_atof, sc_file_system):
1087 Rework slightly so that Makefile.maint doesn't get reported as a
1088 violation of its own syntax rules.
1089 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
1090 it at run-time (which didn't work with Bison). Fix a makefile typo,
1091 caught by Makefile.maint itself: spaces where a tab should be.
1092 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
1093 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
1094 Ignore djgpp and man subdirectories, to avoid false matches with
1095 Bison and coreutils, respectively. Use sort -u to remove the
1096 resulting duplicates.
1097 * gnupload: Rework slightly to avoid bogus warning from
1098 sc_two_space_separator_in_usage.
1100 2006-02-10 Jim Meyering <jim@meyering.net>
1102 Use gzip's --rsyncable option only if it's available.
1103 * Makefile.maint (gzip_rsyncable): New variable.
1106 2006-02-08 Jim Meyering <jim@meyering.net>
1108 * Makefile.maint (local-checks-available): Define in terms of
1109 the expansion, $(syntax-check-rules), rather than the single,
1110 top-level target `syntax-check', so that it's easier to exclude
1111 individual rules (via $(local-checks-to-skip)).
1112 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
1114 2006-02-07 Jim Meyering <jim@meyering.net>
1116 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
1117 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
1119 * tests/help-version (expected_failure_status_vdir):
1120 Redirect an expected disk-full diagnostic to /dev/null.
1122 2006-02-06 Jim Meyering <jim@meyering.net>
1124 * src/unexpand.c (usage): Use two spaces (not one) to separate the
1125 --first-only option string from its description, so help2man formats
1126 the derived man page properly.
1127 * src/rm.c (usage): Likewise for --no-preserve-root.
1128 * src/chown.c (usage): Likewise.
1129 * src/chgrp.c (usage): Likewise.
1131 Add a rule to ensure that the above doesn't happen again.
1132 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
1133 (syntax-check-rules): Add it.
1134 * .x-sc_two_space_separator_in_usage: New empty file.
1135 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
1137 2006-02-06 Jim Meyering <jim@meyering.net>
1139 * src/cp.c (usage): Use two spaces (not one) to separate each
1140 option string from its description, so help2man formats the
1141 derived man page properly.
1142 * src/mv.c (usage): Likewise.
1143 Patch from Nicolas François in http://bugs.debian.org/351601.
1145 2006-02-04 Jim Meyering <jim@meyering.net>
1147 * src/copy.c (copy_internal): cp -RL would fail when encountering
1148 the same directory more than once in the hierarchy beneath a single
1149 command-line argument. That is legitimate, e.g. when there are
1150 two or more symbolic links, each pointing to some directory that
1151 would not otherwise be copied. Reported by Christophe LYON.
1152 * tests/cp/cp-deref: New file. Test for today's fix.
1153 * tests/cp/Makefile.am (TESTS): Add cp-deref.
1154 * NEWS: Document this.
1156 2006-02-03 Jim Meyering <jim@meyering.net>
1158 * configure.ac: Require automake-1.9.6, not 1.8.3.
1160 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
1162 * src/od.c (usage): Mention that -t a ignores high order bit.
1163 Documentation problem reported by Ed Avis.
1165 2006-02-01 Jim Meyering <jim@meyering.net>
1167 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
1169 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
1171 * src/head.c (main): Use a better diagnostic when someone uses a
1172 trailing numeric option in an invalid way. Problem reported by
1174 * src/tail.c (parse_options): Likewise.
1176 2006-01-30 Jim Meyering <jim@meyering.net>
1178 * man/wc.x: Include `count' keyword in man page synopsis,
1179 per suggestion from http://bugs.debian.org/181585.
1181 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
1183 * src/df.c (show_dev): If the file system claims to have
1184 more available than total blocks, report the number of used
1185 blocks as being total - available (a negative number) rather
1186 than as garbage. Problem reported by Toralf Foerster.
1188 2006-01-24 Jim Meyering <jim@meyering.net>
1190 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
1191 to put a regular file in O_NONBLOCK mode fails with EPERM.
1192 That happens on Linux (up to 2.6.15) when using tail -f on a file with
1193 the append-only attribute. Reported by Dean Gaudet. For details,
1194 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
1195 * NEWS: Mention this fix.
1196 * tests/tail-2/append-only: New file. Test for the above.
1197 * tests/tail-2/Makefile.am (TESTS): Add append-only.
1198 * tests/Makefile.am (check-root): Add tail-2/append-only
1200 2006-01-21 Jim Meyering <jim@meyering.net>
1202 * NEWS: Mention fts-related improvements and bug fixes.
1204 2006-01-19 Jim Meyering <jim@meyering.net>
1206 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
1207 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
1209 2006-01-18 Jim Meyering <jim@meyering.net>
1211 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
1213 2006-01-17 Jim Meyering <jim@meyering.net>
1215 Now that fts no longer changes the current working directory, adjust
1216 its clients accordingly -- note that du.c uses fts but doesn't need
1217 any adjustment, since it doesn't operate on the actual files,
1218 but rather just uses the stat buffers provided by fts.
1220 * src/chown-core.c: Include "openat.h".
1221 Don't include "lchown.h".
1222 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
1223 calling openat, lchownat, chownat, rather than open, lchown, chown.
1225 * src/chmod.c: Include "openat.h".
1226 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
1228 * tests/du/long-from-unreadable: New test, to exercise one small
1231 2006-01-13 Jim Meyering <jim@meyering.net>
1233 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
1234 addition of new directories under tests/.
1236 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
1239 2006-01-12 Jim Meyering <jim@meyering.net>
1241 * tests/du/long-sloop: Adjust not to hard-code the expected
1242 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
1243 from that of GNU libc. Reported by Paul Eggert.
1245 * tests/du/long-sloop: Create file at end of symlink chain.
1247 * tests/misc/test: New file, with a test for one of the
1248 bugs fixed by yesterday's test.c changes.
1249 * tests/misc/Makefile.am (TESTS): Add test.
1251 2006-01-11 Jim Meyering <jim@meyering.net>
1253 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
1254 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
1255 a very long sequence of symbolic links (not necessarily a loop).
1256 * tests/du/Makefile.am (TESTS): Add long-sloop.
1258 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
1260 * src/test.c (test_syntax_error): Append a newline. All callers
1261 changed, except for the ones that didn't already append a newline.
1262 Bug reported by Eric Blake.
1264 2006-01-11 Jim Meyering <jim@meyering.net>
1266 * src/system.h (X2NREALLOC): Now that verify_true is no longer
1267 void, cast its result to void, to avoid gcc's warning that
1268 ``left-hand operand of comma expression has no effect''.
1269 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
1271 2006-01-10 Jim Meyering <jim@meyering.net>
1273 * tests/chmod/no-x: Add a test for today's fts.c fix.
1275 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
1277 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
1278 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
1280 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
1282 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
1283 Use verify_true instead of verify_expr, to sync with gnulib.
1285 2006-01-08 Jim Meyering <jim@meyering.net>
1287 * src/date.c (usage): Adjust the formatting of the entries for
1288 %::z and %:::z (separate with two spaces, not one) so that help2man
1289 formats them properly. Reported by Philip Rowlands.
1291 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
1293 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
1295 2006-01-06 Jim Meyering <jim@meyering.net>
1297 * Makefile.maint (copyright-check): Use date +%Y in place of
1300 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
1301 First off, the attribute should have been `volatile' (not static)
1302 to avoid longjmp-related risk of clobber. Secondly, now there is
1303 no longer any risk of a local variable being clobbered, so there's
1304 no need for any attribute at all.
1306 2006-01-05 Jim Meyering <jim@meyering.net>
1308 * src/remove.c: Give a few functions the inline attribute.
1309 (AD_pop_and_chdir): Use gotos to avoid some duplication.
1310 (AD_push): Rewrite an assertion so that the entire computation
1311 goes away when assertions are turned off.
1313 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
1314 It's already defined in "system.h".
1315 * Makefile.maint: Add a FIXME comment.
1317 2006-01-04 Jim Meyering <jim@meyering.net>
1319 * ChangeLog: Remove entries from 2005-10-22 and earlier.
1320 * ChangeLog-2005: New file, for entries up to version 5.92.
1322 2006-01-03 Jim Meyering <jim@meyering.net>
1324 * tests/du/no-x: Also allow a slightly different diagnostic -- the
1325 one you get when using openat-enabled fts.c and du (coming soon).
1326 * tests/chmod/no-x: Likewise.
1327 * tests/chgrp/no-x: Likewise.
1329 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
1331 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
1333 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
1334 (restricted_chown): Return it, if the file cannot be accessed due
1335 to EPERM, or if no uid or gid are required, or if the file is
1336 neither a directory nor a regular file. Rewrite to avoid gotos.
1337 (change_file_owner): Handle RC_do_ordinary_chown case.
1338 Rewrite to avoid gotos.
1339 * tests/chgrp/basic: Make sure we can change the group of
1342 * src/date.c (usage): Explain %g, %G, and %V a bit better.
1344 2006-01-02 Jim Meyering <jim@meyering.net>
1346 * src/copy.c (set_owner): Correct a comment.
1348 * src/tail.c (parse_options): Change warning to say that --retry
1349 is useful `mainly' (not `only') when following by name.
1350 Reported here: http://bugs.debian.org/273781
1352 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
1354 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
1355 * src/copy.c: Include lchmod.h.
1356 (copy_internal): Use lchmod rather than chmod.
1357 * src/cp.c: Include lchmod.h.
1358 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
1359 * src/mkdir.c: Include lchmod.h.
1360 (usage): Clarify -m's operation.
1361 (main): Use lchmod rather than chmod. Don't use lchmod unless the
1362 new mode contains bits outside the 777 range.
1363 * src/mkfifo.c (usage): Clarify -m's operation.
1364 (main): If -m is given, don't invoke chmod; use umask 0 instead.
1365 Report an error if -m asks for bits outside the 777 range.
1366 * src/mknod.c (usage, main): Likewise.
1368 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
1370 2005-12-27 Jim Meyering <jim@meyering.net>
1372 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
1373 (sc_prohibit_assert_without_use): New rule.
1374 (syntax-check-rules): Add it to the list.
1375 * .x-sc_prohibit_assert_without_use: New empty file.
1376 * Makefile.am (EXTRA_DIST): Add it.
1378 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
1380 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
1381 Don't include <assert.h>; it wasn't used.
1383 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
1385 * src/chown-core.c (restricted_chown):
1386 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
1387 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
1388 | O_NOFOLLOW too, for consistency with other dir-openers.
1389 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
1390 (is_empty_dir): Likewise.
1391 * src/shred.c (wipename): Likewise. Don't bother trying to open
1392 dir for writing, since POSIX prohibits it.
1394 2005-12-22 Jim Meyering <jim@meyering.net>
1396 * tests/help-version: Redirect stderr to /dev/full, to suppress
1397 write error diagnostic.
1399 2005-12-19 Jim Meyering <jim@meyering.net>
1401 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
1402 Avoid a minor race condition when `-m MODE' is specified, by using
1403 open, fchown, and close rather than just chown. To do that reliably --
1404 even with an overly restrictive umask -- ensure that each mkdir,
1405 mknod and mkfifo call uses a mode including at least owner-read access.
1406 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
1407 the subsequent chown (or equivalent open,fchown,close) fails.
1408 * tests/misc/mknod: New tests.
1409 * tests/misc/Makefile.am (TESTS): Add mknod.
1411 2005-12-17 Jim Meyering <jim@meyering.net>
1413 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
1414 e.g., on a named pipe.
1415 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
1416 place of all uses, since it is guaranteed (system.h) to be defined.
1418 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
1420 Add POSIX ACL support
1421 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
1422 is no requirement for ACL support; particularly, it does not exist
1423 on systems that have POSIX ACLs.
1424 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1425 * src/cp.c (umask_kill): With default acls, the umask is not to be
1426 applied. Remove umask_kill, don't change the process umask, and let
1427 the kernel apply the umask where appropriate.
1428 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1429 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1431 (copy_reg, copy_internal): Use copy_acl and set_acl
1432 instead of fchown/chown. Fix the logic for POSIX ACLs.
1433 (chown_succeded): Remove; we now always copy acls and
1434 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1435 did a chown before or not.
1436 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1437 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1438 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1439 to link with it via $(LIB_ACL), for the utilities that need it.
1441 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1443 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1444 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1445 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1446 value is now signified by whether cwd_errno is null.
1447 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1448 pointer-to-bool to pointer-to-errno-value. All callers changed.
1449 (rm_1): Don't bother setting a local cwd failure flag and then
1450 ORing it into the caller's. Just set the caller's.
1451 (rm): Use cwd failure errno value to print a slightly-better
1454 2005-12-15 Jim Meyering <jim@meyering.net>
1456 * src/stat.c (print_it): Properly handle a backslash at the
1457 end of a --printf format string. Reported by Paul Eggert.
1458 * tests/misc/stat-printf (end-bs): Add a test for the above.
1460 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1462 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1463 Don't assume /etc/passwd contains user names; use 'id' instead.
1465 2005-12-15 Jim Meyering <jim@meyering.net>
1467 stat: revert behavior of --format=FMT (-c)
1468 stat: add new option: --printf=FMT
1469 * NEWS: Mention this.
1470 * src/stat.c (isodigit, octtobin, hextobin): Define.
1471 (PRINTF_OPTION): Define.
1472 (interpret_backslash_escapes, trailing_delim): New globals.
1473 (usage): Document them. Alphabetize on long option names.
1474 (print_esc_char): New function.
1475 (print_it): Rewrite, in order to handle backslash escapes.
1476 (main): Handle new option. Set globals for --format, too.
1478 * tests/misc/stat-printf: Test --printf and --format.
1479 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1481 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1483 * NEWS: sort now reports incompatible options.
1484 * src/sort.c (incompatible_options, check_ordering_compatibility):
1486 (main): Use them. Don't bother with a usage message for
1487 "sort -c a b", for consistency with other error diagnostics.
1488 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1491 * src/cat.c (main): Undo previous change. close_stdout already
1492 does the check, so the previous change wasn't necessary.
1494 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1496 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1498 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1500 Install a more-conservative approach for sort -R. It's the
1501 same basic idea as the existing code, except it uses the full ISAAC
1502 approach (called the "more kosher" approach in the existing comments).
1503 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1504 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1505 better to be conservative here at first, and review any performance
1506 improvements carefully.
1507 * .x-sc_require_config_h: Add src/rand-isaac.c.
1508 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1509 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1510 (shred_SOURCES, sort_SOURCES): Remove.
1511 (EXTRA_DIST): Add rand-isaac.c.
1512 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1513 changing it to allow for varying numbers of words in the state.
1514 Alter so that we include rand-isaac.c directly rather than
1515 compiling it and linking to it. Don't include config.h or
1516 system.h; that's the includer's responsibility.
1517 Omit functions that are specific to shred.
1518 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1519 (isaac_step, struct irand_state):
1520 Resurrect these, with the same defns that used to be in shred.c.
1521 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1522 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1524 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1525 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1526 (irand_init, irand32, irand_mod):
1527 Number of words is constant again.
1528 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1529 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1530 * src/sort.c: Likewise.
1531 * src/shred.c (fillrand, dopass, main): Undo previous change.
1532 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1534 * src/sort.c: Don't include md5.h; it wasn't needed.
1535 (struct keyfield): Rename random_hash to random, for consistency
1536 with the other member names. All uses changed.
1537 (usage): Tweak wording to mention STRING for --seed option.
1538 (short_options): Rorder for consistency with other programs.
1539 (rand_state): Now a struct, not a pointer to one. All uses changed.
1540 (HASH_WORDS, HASH_SIZE): Remove.
1541 (get_hash): Remove comments around resbuf size, since we can assume C89.
1542 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1543 (keycompare): Adjust to the new get_hash.
1545 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1546 (main): Don't set need_random simply because gkey has it set; that
1547 doesn't necessarily mean we'll need random numbers.
1548 Redo seeding to match new get_hash approach.
1550 2005-12-10 Jim Meyering <jim@meyering.net>
1552 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1554 Avoid shred segfault on 64-bit systems.
1555 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1556 local of type uint32_t. Make the local an `int' instead.
1558 * NEWS: Mention sort's new options.
1560 * src/rand-isaac.c (isaac_mix): Declare to be static.
1561 Mark all other functions as `extern' so the tight-scope
1562 part of `make distcheck' passes once again.
1563 * src/rand-isaac.h (isaac_mix): Remove declaration.
1565 * src/sort.c (get_hash): Change position of `*' in parameter
1566 type to conform with convention.
1567 (main): Split a long line so it fits in 80 columns.
1568 (keycompare): Remove stray SPACE before TAB that was
1569 causing `make distcheck' to fail.
1571 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1573 * tests/misc/sort-rand: New file: basic tests for the new options.
1574 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1576 2005-12-10 Frederik Eaton <frederik@ofb.net>
1578 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1579 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1580 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1581 Make state size runtime-configurable.
1582 (isaac_new, isaac_copy): New functions.
1583 * src/rand-isaac.h: New file.
1584 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1585 (fillrand, main): Adjust to the fact that the state size is now
1586 runtime-configurable.
1587 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1588 (usage): Add options --random-sort and --seed to implement a random
1590 Include md5.h and rand-isaac.h.
1591 (get_hash): New function.
1592 (rand_state): New var.
1593 (HASH_WORDS, HASH_SIZE): New macros.
1595 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1597 * tests/dd/misc: Add test for dd iflags=noatime.
1599 2005-12-09 Jim Meyering <jim@meyering.net>
1601 * src/sort.c (usage): Mention white space vs -b and -t options.
1604 2005-12-09 Eric Blake <ebb9@byu.net>
1606 * src/test.c (main): Fix misleading comment.
1608 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1610 * NEWS: Mention dd's new noatime flag.
1611 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1612 * src/dd.c (flags, usage): Add support for noatime flag.
1614 2005-12-07 Jim Meyering <jim@meyering.net>
1616 Distribute the cvsu script, used only by `make syntax-check'.
1617 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1618 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1619 distribute a copy of this script.
1620 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1622 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1623 to create a temporary directory on another partition.
1624 From Andreas Gruenbacher.
1626 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1628 * man/basename.x: Cross-reference to dirname and readlink.
1629 * man/dirname.x: Cross-reference to basename and readlink.
1631 2005-12-05 Andreas Gruenbacher
1633 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1634 (set_owner, preserve_author): New functions, factored out of copy_reg.
1635 (copy_reg): Use them.
1636 (copy_internal): Use them here, too.
1638 2005-12-04 Jim Meyering <jim@meyering.net>
1640 * src/sleep.c (usage): Say what happens with two or more arguments.
1641 Suggested by Justin Pryzby.
1643 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1646 2005-12-03 Jim Meyering <jim@meyering.net>
1648 * src/rm.c (long_opts): Change the name of each undocumented, for-
1649 testing-only option to start with `-', so that it cannot render
1650 ambiguous any prefix it happens to share with some other option name.
1651 Problem reported by Eric Blake.
1652 * src/head.c (long_options): Likewise.
1653 * src/tail.c (long_options): Likewise.
1655 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1656 testing-only --presume* options to start with `---'.
1657 * tests/rm/dangling-symlink: Likewise.
1658 * tests/rm/dir-no-w: Likewise.
1659 * tests/rm/isatty: Likewise.
1661 2005-11-30 Jim Meyering <jim@meyering.net>
1663 * Makefile.maint: Add a comment about cvsu.
1665 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1667 * NEWS: df updates for "none", "proc", inaccessible file systems.
1668 * src/df.c (show_point): Ignore inaccessible file systems.
1669 (usage): -a includes dummy file systems, not size-0 file systems.
1671 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1672 to avoid collision with POSIX name space. All uses changed.
1674 2005-11-24 Jim Meyering <jim@meyering.net>
1676 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1677 * tests/acl: Add `$0: ' prefix to diagnostics.
1679 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1681 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1683 * src/copy.c: Improve performance a bit by optimizing away
1684 unnecessary system calls and going to a block size of at least
1685 8192 (on normal hosts, anyway). This improved performance 5% on my
1686 Debian stable host (2.4.27 kernel, x86, copying from root
1687 ext3 file system to itself).
1688 Include "buffer-lcm.h".
1689 (copy_reg): Omit last argument. All callers changed.
1690 Use xmalloc to allocate rather than trusting alloca
1691 (which is unwise with large block sizes).
1692 Declare locals more locally, if possible.
1693 Use uintptr_t words instead of int words, for a bit more speed
1694 when looking for null blocks on 64-bit hosts.
1695 Optimize away reads of zero bytes on regular files.
1696 In the typical case, insist on 8 KiB buffers, at least.
1697 Avoid unnecessary extra call to fstat when checking for sparse files.
1698 Avoid now-unnecessary cast to off_t, and "0L".
1699 Avoid unnecessary test of *new_dst when checking for same owner
1702 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1704 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1706 2005-11-22 Jim Meyering <jim@meyering.net>
1708 * src/remove.c (AD_push): Remove debugging cruft.
1710 * tests/rm/unread2 (rm): Change expected diagnostic,
1711 `cannot open directory' to `cannot remove', to align with
1713 * tests/rm/rm2: Ensure that rm now continues removing entries
1714 even after certain types of failure.
1716 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1717 that provide openat (Solaris), and on systems like Linux+procfs
1718 where our openat emulation code is reentrant. This also fixes a
1719 few low-probability leaks and eliminates some code that could,
1720 in very unusual circumstances, cause rm() (via a callee) to exit.
1721 * NEWS: Mention this.
1723 * configure.ac: Put copyright dates all on one line so the
1724 emacs function that updates them works properly.
1726 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1728 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1729 Problem reported by Eric Blake.
1730 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1731 we get a standard-conforming compiler. This relies on the new
1732 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1733 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1734 m4/c.m4 can go away with Autoconf 2.60 comes out.
1736 2005-11-17 Jim Meyering <jim@meyering.net>
1738 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1739 (AD_mark_current_as_unremovable): Likewise, but for a local.
1742 * tests/mv/acl: Let traps handle removing temporary directories.
1744 Expect acl-related tests to fail, until the corresponding
1745 patches are committed.
1746 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1747 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1749 ACL tests, from Andreas Gruenbacher.
1750 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1751 * tests/mv/Makefile.am (TESTS): Add acl.
1752 * tests/cp/Makefile.am (TESTS): Add acl.
1754 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1756 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1758 * NEWS: Improve quality of ln's diagnostics.
1759 * src/ln.c (do_link, usage): Likewise.
1760 (do_link): Don't use alloca on a buffer of unbounded size.
1762 2005-11-16 Jim Meyering <jim@meyering.net>
1764 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1765 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1766 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1767 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1768 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1770 2005-11-14 Jim Meyering <jim@meyering.net>
1772 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1774 2005-11-13 Jim Meyering <jim@meyering.net>
1776 * announce-gen: Accept new option, --gpg-key-id=ID and
1777 emit a blurb telling how to use the .sig files.
1778 * Makefile.cfg (gpg_key_ID): Define.
1779 * Makefile.maint (announcement): Use new option and key.
1781 Require that most .c files include <config.h>.
1782 * Makefile.maint (sc_require_config_h): New rule.
1783 (syntax-check-rules): Add it.
1784 * .x-sc_require_config_h: New file listing exceptions to the
1785 above rule. Some are legit, others are simply grandfathered in.
1786 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1788 2005-11-12 Jim Meyering <jim@meyering.net>
1790 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1792 2005-11-11 Jim Meyering <jim@meyering.net>
1794 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1795 Mention new readlink options in 5.3.0's `New features' section.
1796 Spotted by Thomas Hood.
1798 2005-11-08 Jim Meyering <jim@meyering.net>
1800 * NEWS: Merge in changes from b5_9x branch.
1802 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1804 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1805 like --time-style='posix-long-iso' if the locale settings are messed up.
1806 * src/ls.c (decode_switches): Implement this.
1808 2005-11-08 Jim Meyering <jim@meyering.net>
1810 * tests/du/2g: s/expensive/very expensive/ in a comment.
1813 2005-10-17 Eric Blake <ebb9@byu.net>
1815 * src/ls.c (usage): Fix descriptions of --sort, --time.
1816 Reported by Vitaly A. Ostanin.
1818 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1820 * src/ln.c: Include filenamecat.c.
1821 (FILE_BASENAME_CONCAT): Remove.
1822 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1823 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1824 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1827 2005-11-04 Jim Meyering <jim@meyering.net>
1829 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1830 on systems with stat.st_blocks of a signed 32-bit type.
1831 This bug causes trouble on some AIX 5.1 systems.
1832 Report and trivial patch from Paul Townsend:
1833 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1834 * NEWS: Mention this.
1836 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1837 * tests/du/Makefile.am (TESTS): Add it here.
1838 * tests/very-expensive: New file.
1839 * tests/Makefile.am (EXTRA_DIST): Add it here.
1840 * tests/cp/perm: Mark this test as `very-expensive', too.
1842 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1844 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1846 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1848 * src/rm.c (usage): Don't mention rm -d.
1850 2005-11-02 Jim Meyering <jim@meyering.net>
1852 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1853 From Andreas Schwab.
1855 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1856 `M+N records in/out' lines don't pollute `make check' output.
1858 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1859 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1860 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1861 to indicate that the input file should be piped into the command
1862 under test (via `cat FILE | $prog ...').
1864 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1865 (without -r) fails to remove a directory on a non-Linux system.
1866 This change affects only newer Solaris systems (with priv_*
1867 functions like priv_allocset). Reported by Keith Thompson.
1869 * tests/rm/dir-nonrecur: New file/test for the above fix.
1870 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1872 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1874 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1875 POSIX 1002.1-2001 requires.
1876 * src/tail.c (parse_obsolete_option): Implement this.
1877 Problem reported by Vincent Lefevre.
1878 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1879 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1880 (test_vector): Add special cases for _POSIX2_VERSION, and
1881 regularize the old ones a bit.
1882 * tests/touch/obsolescent: Add y2000 test.
1884 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1886 * src/dd.c (skip): Fix off-by-one error reported by
1887 Theodoros V. Kalamatianos.
1889 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1891 * tests/mkdir/p-3: Require that the test be run as non-root.
1892 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1894 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1896 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1897 boundary between DEST and SOURCE in the result.
1899 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1901 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1902 back to text, to sync with documentation and for backwards
1905 2005-10-25 Jim Meyering <jim@meyering.net>
1907 * tests/dircolors/simple (other-wr): Add an explicit test for
1908 the dircolors bug (NULL-dereference) fixed yesterday.
1910 2005-10-24 Jim Meyering <jim@meyering.net>
1912 * src/tac.c (tac_file): When determining whether a file is seekable,
1913 also test whether it is a tty. Using only the lseek-based test would
1914 give a false positive on Solaris. Reported by Peter Fales.
1916 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1918 * tests/install/d-slashdot: New test, for "install -d" failure.
1919 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1920 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1921 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1923 2005-10-24 Jim Meyering <jim@meyering.net>
1925 * src/dircolors.c (ls_codes): Add missing comma.
1926 Anonymous report and patch from
1927 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1929 * src/dircolors.c: Add compile-time assertion that the slack_codes
1930 and ls_codes arrays have the same number of elements. This would
1931 have prevented the above-fixed bug.
1933 * src/expand.c (parse_tab_stops): Add a comment to make this function
1934 identical to the one in unexpand.c.
1935 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1936 identical to the one in expand.c.
1938 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1940 2005-10-23 Jim Meyering <jim@meyering.net>
1942 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1943 a dangerous pointer-value-to-`unsigned' cast.
1944 * NEWS: mention the new sha* programs.
1945 * AUTHORS: Add new sha* programs.
1947 2005-08-28 David Madore <david.madore@ens.fr>
1949 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1950 * README: Add their names to the list.
1951 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1952 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1953 Rules for compiling sha-2 utilities
1954 (noinst_HEADERS): Remove checksum.h.
1955 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1957 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1958 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1959 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1960 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1961 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1962 sha384sum, sha512sum test scripts here rather that each in its
1965 2005-08-28 David Madore <david.madore@ens.fr>
1967 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1968 of the FIPS test vectors).
1970 2005-10-23 Jim Meyering <jim@meyering.net>
1972 * configure.ac: Use 6.0-cvs as the version string.
1973 * NEWS: Adjust accordingly.