1 2006-08-09 Paul Eggert <eggert@cs.ucla.edu>
3 * src/dd.c (usage): Warn about oflag=append without conv=notrunc.
6 * src/dircolors.hin: Add mlterm, rxvt-unicode; this fixes Debian
9 * src/.cvsignore: Add shuf.
11 * Makefile.maint: Remove the po-update procedure; it doesn't
12 work with the new repository on http://www.iro.umontreal.ca/.
13 For now I guess we'll have to fix things by hand.
14 (do-po-update, po-update): Remove. All references removed.
16 * src/shuf.c (next_line): New function.
17 (read_input): Use it, to avoid relying on GCC-specific behavior
18 with void * arithmetic. Problem reported by Bob Proulx.
19 * Makefile.maint (my-distcheck): Compile with -Wpointer-arith
20 to detect this sort of problem automatically in the future.
22 2006-08-09 Jim Meyering <jim@meyering.net>
24 * src/ls.c: Add a compile-time check to ensure that filetype
25 and filetype_letter have the same number of elements.
27 * tests/misc/sort-rand: Remove use of --seed=S.
29 2006-08-08 Paul Eggert <eggert@cs.ucla.edu>
31 Add a command 'shuf', and modify shred and sort to use the new
32 random number generator library of 'shuf'.
36 * NEWS: Likewise. Mention new --random-source option for shred
37 and sort. Move "sort +1 -2" notice to the appropriate section,
38 and clarify its role with respect to POSIXLY_CORRECT.
39 * man/.cvsignore: Add shuf.1.
40 * man/Makefile.am (dist_man_MANS): Add shuf.1.
41 (shuf.1): New dependency.
42 * man/shuf.x: New file.
43 * src/Makefile.am (bin_PROGRAMS): Add shuf.
44 (EXTRA_DIST): Remove rand-isaac.c.
45 (shuf_LDADD): New macro.
46 * src/rand-isaac.c: Remove, moving most of its contents to
48 * src/shuf.c: New file.
49 * src/shred.c: Use new random-number interface rather than rand-isaac.c.
50 Don't include rand-isaac.c; include randint.h and randread.h instead.
51 (RANDOM_SOURCE_OPTION): New enum.
52 (long_opts, usage, main): New option --random-source.
53 * src/sort.c: Likewise.
54 * src/shred.c (struct irand_state, irand_init, irand32, irand_mod): Remove.
55 All callers changed to use randint interface.
56 (fillrand): Remove. All callers changed to use randread interface.
57 (dopass): Remove dependency on ISAAC buffer size.
58 (genpattern): Don't wipe the random state here.
59 (randint_source): New static var.
60 (clear_random_data): New function.
61 (main): Allocate random source, and arrange to wipe it on exit.
62 * src/sort.c: Include md5.h, randread.h, xmemxfrm.h.
63 (longopts, usage, main): Remove undocumented --seed option;
64 it's now replaced by --random-source.
65 (rand_state, get_hash): Remove.
66 (randread_source): New static var.
67 (random_state, cmp_hashes, compare_random): New functions; they guarantee
68 no collisions in the random hash function.
69 (keycompare): Use compare_random for -R; don't fall back on comparing
70 via memcoll, since compare_random does the right thing.
71 * tests/misc/Makefile.am (TESTS): Add shuf.
72 * tests/misc/shuf: New file.
74 2006-07-29 Paul Eggert <eggert@cs.ucla.edu>
76 * src/copy.c (set_author): Preserve the st_author field via the
77 file descriptor dest_desc.
79 2006-07-28 Paul Eggert <eggert@cs.ucla.edu>
81 * NEWS: chmod now preserves setuid and setgid bits on directories
82 if you use a numeric mode with them clear, e.g., "chmod 755 DIR".
84 Fix test case problems if working directory is setgid,
85 reported by Bob Proulx.
86 * tests/cp/fail-perm: Use symbolic mode so that we clear
87 setgid bit more reliably on directories.
88 * tests/mkdir/special-1 (set_mode_string): Likewise.
90 2006-07-27 Jim Meyering <jim@meyering.net>
92 * src/chgrp.c (usage): Use correct grammar in description of the
94 * src/chown.c (usage): Likewise.
96 2006-07-26 Thomas Schwinge <tschwinge@gnu.org> (tiny change)
98 * src/copy.c (set_author) [HAVE_STRUCT_STAT_ST_AUTHOR]:
99 Correctly access SRC_SB's element ST_AUTHOR.
101 2006-07-26 Jim Meyering <jim@meyering.net>
103 * tests/ls/stat-failed: Adapt to match new expected output.
106 * src/ls.c (print_color_indicator): Test for S_IFREG first, rather
107 than having the code test for all of the other types first.
108 Hoist the set-uid/gid-testing code "up" into this new block.
109 Classify any other type of file (e.g., S_TYPEISSHM, etc.) as
110 C_ORPHAN, not as C_FILE.
112 2006-07-26 Jim Meyering <jim@meyering.net>
114 Checking in a change from Paul.
116 2006-07-25 Paul Eggert <eggert@cs.ucla.edu>
118 * src/ls.c (DT_INIT): Remove. All uses removed.
119 (enum filetype): Use an ordinary enum rather than trying to keep
120 the values in sync with DT_FIFO etc. That way, we don't have
121 to make special assumptions about them. All uses changed.
122 (whiteout): New constant member of enum filetype.
123 (filetype_letter): New constant, for use with enum filetype.
124 (FILETYPE_INDICATORS): New initializer list.
125 (print_dir): Add case for DT_WHT.
126 (gobble_file): If stat fails, don't discard information from
127 readdir; instead, preserve it so it can be printed.
128 (print_long_format): Fall back on readdir result if stat info
129 is not available. Use "?" to denote each unknown mode char,
130 instead of an overall "?", since we now know some of the mode
132 (print_type_indicator): Now that MODE isn't necessarily
133 useful, guard all uses.
134 Now that two blocks in the type-checking tree can set "type = C_FILE",
135 move the suffix-handling code out and down.
137 2006-07-26 Jim Meyering <jim@meyering.net>
139 Prepare for the above change.
140 * src/ls.c [struct fileinfo] (stat_ok): Rename from stat_failed,
141 and adjust uses. From a patch by Paul Eggert.
143 2006-07-26 Jim Meyering <jim@meyering.net>
145 * src/ls.c: Correct indentation/formatting in a few places.
147 2006-07-25 Paul Eggert <eggert@cs.ucla.edu>
149 * tests/cp/fail-perm: Use "chmod 0500" rather than "chmod 500".
150 Problem report and fix from Bob Proulx.
151 * NEWS: Clarify the "chmod 0500" news, and correct the vague
152 statements about compatibility with BSD.
154 2006-07-25 Jim Meyering <jim@meyering.net>
156 * src/ls.c (gobble_file): When handling a stat-failed entry,
157 print the entry name not the absolute_name -- to be consistent
159 * tests/ls/stat-failed: Update accordingly.
161 * src/ls.c: Add parens around the new uses of ?: ternary operator.
163 * src/dircolors.hin: Mention that ORPHAN refers not just to dangling
166 Get --dired offsets right when handling stat-failed entries.
167 * src/ls.c (print_long_format): Be careful to increment P by the
168 appropriate amount, even when inode_number_width and nlink_width
170 * tests/ls/stat-failed: Test for the above.
172 * src/ls.c (gobble_file) [USE_ACL]: Don't use-uninitialized the
173 have_acl member. That would happen for a directory with both a
174 non-stat'able entry and one with an ACL.
176 * src/ls.c (gobble_file): Make it so failure to stat a
177 non-command-line file provokes an exit status of 1, not 0.
178 Say "cannot access" rather than "cannot stat".
179 * tests/ls/stat-failed: New file/test, for the above.
180 * tests/ls/Makefile.am (TESTS): Add stat-failed.
181 * tests/ls-2/tests (no-a-isdir-b): Update to reflect addition
182 of "cannot access " to diagnostic.
184 * src/ls.c: Declare stat_failed to be "bool", not "int" everywhere.
186 * src/ls.c [enum filetype] (command_line): Remove member. Not needed.
187 Replace all occurrences of "type == command_line" with the
188 equivalent, "command_line_arg".
190 * src/ls.c: Apply the stat-failed parts of Red Hat's
191 coreutils-selinux.patch. From Ulrich Drepper.
192 This makes it so files not mentioned on the command line (e.g.,
193 names read from a directory that *is* mentioned on the command
194 line) for which stat fails are still listed. With --color,
195 such files are colored just like ORPHANs (aka dangling symlinks).
197 * src/df.c (n_valid_args): Declare global to be static.
199 2006-07-24 Jim Meyering <jim@meyering.net>
201 * tests/ls/stat-dtype: Skip this test on reiserfs, since that file
202 system lacks d_type support.
204 2006-07-22 Paul Eggert <eggert@cs.ucla.edu>
206 * man/chmod.x: Update to reflect recent changes to coreutils.texi.
208 2006-07-21 Jim Meyering <jim@meyering.net>
210 * src/su.c (usage): Correct typo in --help output: s/commmand/command/
211 Reported by Tim Waugh.
212 Also remove the comment duplicating much of --help output.
214 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): Reposition this new
215 name so the list remains alphabetized.
217 Fix another bug: ls --indicator-style=file-type would call
218 stat for a symlink, even though it wasn't always needed.
219 In some cases, that unnecessary stat would cause ls to fail.
220 * src/ls.c (gobble_file): Don't treat symlinks specially (in
221 requiring a stat syscall). Remove the offending exclusion.
223 * NEWS: Mention the fix.
225 * tests/ls/stat-dtype: New file/test, for the above fix.
226 Also exercises the new df feature, below.
228 * src/df.c (main): Fail and don't print the headers if no
229 file system is processed. This makes it easy to test whether
230 a specified directory is on a file system of a given type or types.
231 Otherwise, applications would have had to parse df's output.
232 E.g., is "." either ext3 or reiserfs: df -t ext3 -t reiserfs .
234 Fix a bug: ls --file-type worked like --indicator-style=slash,
235 rather than like --indicator-style=file-type.
236 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): New enum member.
237 (long_options): Map "file-type" to FILE_TYPE_INDICATOR_OPTION,
239 (decode_switches): Handle new case: FILE_TYPE_INDICATOR_OPTION.
240 * NEWS: Mention the fix.
241 * tests/ls-2/tests (file-type): New test, for the above fix.
243 2006-07-19 Jim Meyering <jim@meyering.net>
245 * src/ls.c (print_dir): Give a better diagnostic for failed opendir.
247 * Makefile.am (EXTRA_DIST): Add build-aux/vc-list-files.
249 2006-07-16 Paul Eggert <eggert@cs.ucla.edu>
251 * NEWS: chmod, install, and mkdir now leave setgid and setuid bits
252 of directories alone unless you specify them explicitly.
253 install and mkdir now implement X correctly.
254 install now creates parent directories with mode 755, without
255 changing their owner or group.
256 * src/chmod.c (process_file): Adjust to mode_adjust API change.
257 * src/install.c: Include mkancesdirs.h.
258 (announce_mkdir, make_ancestor): New functions.
259 (DEFAULT_MODE): New macro, specifying initial value of 'mode'.
261 (dir_mode, dir_mode_bits): New vars.
262 (main): Set dir modes separately from nondir, so that the X
263 op of -m works correctly.
264 (main): Remove cwd_errno cruft, since make_dir_parents no longer
265 affects cwd. Adjust to new make_dir_parents API.
266 (install_file_in_file_parents): 2nd arg is now char *, not char
267 const *. Use mkancesdirs instead of rolling our own code.
268 (change_attributes): Don't worry about AFS, since that kludge
269 should not be needed any more.
270 * src/mkdir.c (struct mkdir_options): New struct.
271 (announce_mkdir, make_ancestor): New functions.
272 (main): Use them. Adjust to mode_adjust API change. Stick with
273 umask 0. Use make_dir_parents for all the work.
274 * src/mkfifo.c (main): Adjust to new mode_adjust API.
275 * src/mknod.c (main): Likewise.
276 * tests/chmod/setgid: Do the setgid test instead of bailing.
277 * tests/mkdir/p-3: Remove re_protect case that no longer applies.
278 GNU chmod now behaves like other versions of chmod.
279 * tests/mkdir/perm: Add a test for the X bug.
281 2006-07-14 Paul Eggert <eggert@cs.ucla.edu>
283 * src/base64.c (do_decode): Output to parameter OUT, not to stdout.
284 This doesn't fix any bugs, since OUT always equals stdout, but it
285 makes the code easier to understand.
287 2006-07-14 Jim Meyering <jim@meyering.net>
289 * Makefile.maint (CVS_LIST): Use new file, build-aux/vc-list-files,
290 rather than open-coding it. Now supports mercurial, too.
291 * .hgignore: New file.
292 * Makefile.am (EXTRA_DIST): Add .hgignore, which ignores nearly
293 all generated files, including ones like configure and po/*.po
294 that are currently version-controlled in cvs.
296 * Makefile.am (EXTRA_DIST): Add a few more .??* files.
297 They've been in CVS, just haven't been distributed before this.
298 Distribute ChangeLog-2005, too.
299 (MAINTAINERCLEANFILES): Add THANKS-to-translators.
301 2006-07-11 Paul Eggert <eggert@cs.ucla.edu>
303 * src/system.h: Assume <dirent.h> exists, since gnulib assumes
306 2006-07-09 Jim Meyering <jim@meyering.net>
308 * tests/mv/dir2dir: Adjust so failing with ENOTEMPTY is ok, too.
309 That happens with Linux/tmpfs.
310 * tests/mv/Makefile.am (TESTS): Add dir2dir.
312 2006-07-09 Paul Eggert <eggert@cs.ucla.edu>
314 Adjust to recent updates from gnulib.
315 * src/dd.c (apply_translations): Use toupper rather than
316 islower followed by toupper; it's simpler and typically
317 faster now that we assume at least C89 semantics. Similarly
319 * src/sort.c (inittables): Likewise.
320 * src/expand.c (expand): Don't assume that isprint etc. return
321 booleans (needed for pre-C99 hosts).
322 * src/fmt.c (check_punctuation): Likewise.
323 * src/ptx.c (initialize_regex, fix_output_parameters): Likewise.
324 * src/tr.c (is_char_class_member): Likewise.
325 * src/unexpand.c (unexpand): Likewise.
326 * src/join.c (is_blank): Remove; no longer needed. All uses
327 replaced by isblank (to_uchar (...)).
328 * src/pinky.c (create_fullname): Don't assume char is unsigned.
329 * src/printf.c (print_esc): Likewise.
330 * src/ptx.c (SKIP_NON_WHITE, SKIP_WHITE, SKIP_WHITE_BACKWARDS):
331 (copy_unescaped_string): Likewise.
332 * src/stat.c (print_it): Likewise.
333 * src/system.h (_D_EXACT_NAMELEN): Renamed from NLENGTH, for
334 convenience on GNU systems. All uses changed. Don't bother
335 looking for any dirent.h substitute other than ndir.h.
336 (D_INO): Remove unnecessary parentheses.
337 (IN_CTYPE_DOMAIN, ISGRAPH, ISPRINT, ISALNUM, ISALPHA):
338 (ISCNTRL, ISLOWER, ISPUNCT, ISSPACE, ISUPPER, ISXDIGIT):
339 (ISDIGIT_LOCALE, TOLOWER, TOUPPER): Remove. All uses changed
340 to ctype.h equivalents.
341 (isblank): Renamed from ISBLANK. Check for HAVE_DECL_ISBLANK too.
344 2006-07-08 Jim Meyering <jim@meyering.net>
346 * tests/mv/dir2dir: New file, test for 2006-07-05 fix in copy.c.
348 * Makefile.maint (sc_the_the): New rule.
350 * src/dd.c (skip): Remove one of two adjacent "the"s in a comment.
351 * tests/Coreutils.pm (run_tests): Remove one of two adjacent "then"s
354 2006-07-07 Jim Meyering <jim@meyering.net>
356 * NEWS: Mention that mv can now remove an empty destination directory,
357 and give an example. Prompted by a report from Florent Bayle.
359 2006-07-05 Jim Meyering <jim@meyering.net>
361 * src/ls.c (usage): Correct the description of -G: it is useful
362 only in a long listing. Reported by Martin Pool in
363 <https://launchpad.net/distros/ubuntu/+source/coreutils/+bug/51653>.
365 * man/chmod.x: Correct the description of the sticky bit. Reported
366 by Chris Moore via Ian Jackson in <http://bugs.debian.org/376745>.
368 * src/copy.c (copy_internal): Don't work around old NFS clients like
369 SunOS-4.1.4 and Irix 5.3 that set errno to values like EIO and
370 ENOTEMPTY upon failed rename. Otherwise, we risk misinterpreting
371 a banal failure as a recursive move-into-self failure.
372 Reported by Florent Bayle in <http://bugs.debian.org/376749>.
374 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
376 2006-07-03 Jim Meyering <jim@meyering.net>
378 Plug another unusual leak.
379 (AD_mark_helper): Free malloc'd filename if hash_insert says
380 that string is already in the hash table.
382 The dev/inode of the topmost directory in each hierarchy were not
384 * src/remove.c (remove_cwd_entries): Don't call cycle_check here.
385 (AD_push): Call it from here instead.
388 * src/remove.c (AD_stack_clear): New function.
390 (AD_pop_and_chdir): Free *prev_dir just before longjmp.
392 * tests/Makefile.am, tests/*/Makefile.am: (TESTS_ENVIRONMENT):
393 Add $VG_PATH_PREFIX as a prefix to $PATH
395 * tests/envvar-check (vars): Add CDPATH and POSIXLY_CORRECT.
396 * tests/Makefile.am (evar-check): Remove rule.
397 (EXTRA_DIST): Remove .env-warn.
398 * tests/.env-warn: Remove file. No longer used.
399 Suggestion from Eric Blake.
401 2006-07-02 Paul Eggert <eggert@cs.ucla.edu>
403 * src/system.h: Include <stdint.h> unconditionally, since we
404 now assume the stdint module.
406 2006-07-01 Paul Eggert <eggert@cs.ucla.edu>
408 * NEWS: With no operand, 'tail -f' now silently ignores the '-f'
409 only if standard input is a FIFO or pipe and POSIXLY_CORRECT is set.
410 * src/tail.c (main): Implement this.
411 * tests/tail/Test.pm (f-pipe-1): Renamed from f-1.
412 (test_vector): Set POSIXLY_CORRECT for the f-pipe-* tests.
414 2006-07-01 Jim Meyering <jim@meyering.net>
416 * src/ln.c (do_link): Use new, shorter URL, for ag-review link.
418 * .x-sc_require_config_h: Add ^lib/xstrtold\.c$, so make distcheck
421 2006-06-30 Paul Eggert <eggert@cs.ucla.edu>
423 * NEWS: seq now uses long double internally rather than double.
424 It now defaults to a minimal fixed point format if possible.
425 It lets you use %a, %A, %E, %F, %G.
426 * src/Makefile.am (seq_LDADD): Remove $(SEQ_LIBM); add $(POW_LIB).
427 * src/seq.c: Don't include <math.h> or <xstrtol.h>; no longer needed.
428 (isfinite) [!defined isfinite]: New macro.
429 (separator, terminator): Now points to const.
430 (first, step, last): Remove.
431 (usage): Update to match new behavior.
432 (struct operand, operand): New type.
433 (scan_arg): Renamed from scan_double_arg, since we no longer use double.
435 Compute and return a value of type operand, not double.
436 (long_double_format): Renamed from valid_format, and now returns a
437 new format with an "L" added if needed, if the original format was
438 valid. Allow %a, %A, %E, %F, and %G formats.
439 (print_numbers): Take numeric values as args rather than from globals.
440 Print long double, not double.
441 (get_width_format): Remove.
442 (get_default_format): New function.
443 (main): Implement new way of calculating default format.
444 Don't worry about locale's representation of the decimal point, since
445 the arguments are always processed in the C locale.
446 * tests/seq/basic (neg-2): Adjust to new default format.
447 (eq-wid-1, eq-wid-2): Resurrect these tests, since the new
448 implementation should do the right thing.
450 2006-06-30 Jim Meyering <jim@meyering.net>
452 * tests/stty/basic-1: Work around an intermittent test failure
453 on HP-UX 11.11. Report and analysis from Bob Proulx.
454 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7475
456 2006-06-28 Paul Eggert <eggert@cs.ucla.edu>
458 * NEWS: Support obsolete usages like "sort +1 -2" even when
459 conforming to POSIX 1003.1-2001, since this is a pure extension to
460 POSIX. Problem reported by Christian in:
461 http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00220.html
462 * src/sort.c (main): Implement this.
464 * src/system.h (CLOSEDIR): Remove. All uses changed to closedir.
465 Autoconf 2.60 says this stuff was obsolete.
467 2006-06-28 Jim Meyering <jim@meyering.net>
469 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
471 2006-06-28 Bob Proulx <bob@proulx.com> (tiny change)
473 * tests/mv/i-link-no: Work around HP-UX /bin/sh tracing problem
474 (set -x when VERBOSE=yes) when stderr is redirected before stdout
475 causing shell tracing of the stdout redirection to be written to
476 the stderr file. Avoid problem and test failure on HP-UX by
477 redirecting stderr last.
478 * tests/dd/unblock-sync: Order shell file redirections for
479 stderr and stdout in the common style.
482 2006-06-27 Jim Meyering <jim@meyering.net>
484 * tests/misc/cat-proc: Try to avoid any spurious numeric
485 differences in frequently-changing /proc/cpuinfo.
486 Reported by Nelson Beebe.
488 2006-06-26 Jim Meyering <jim@meyering.net>
490 Attempt rmdir (actually, unlinkat-with-AT_REMOVEDIR) upon any
491 fd_to_subdirp failure, not just when errno == EACCES.
492 * src/remove.c (remove_dir): Use unlinkat-with-AT_REMOVEDIR, not
493 rmdir, here, even though rmdir may happen to be adequate.
495 * NEWS: rm no longer fails to remove an empty, unreadable directory
496 * src/remove.c (remove_cwd_entries): If we can't open a directory,
497 and the failure is not being ignored, try to remove the directory
498 with rmdir (aka unlinkat-with-AT_REMOVEDIR), in case it's empty.
499 Problem report and test case from Paul Eggert in
500 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7425>.
502 * tests/rm/empty-inacc: New test, for the above.
504 Avoid a segfault for wc --files0=- < /dev/null.
505 * src/wc.c (compute_number_width): Return right away if nfiles == 0.
507 2006-06-25 Jim Meyering <jim@meyering.net>
509 * NEWS: wc accepts a new option --files0-from=FILE, where FILE
510 contains a list of NUL-separated file names.
512 * src/wc.c: Include "readtokens.h".
513 (usage): Describe the new option, and adjust the `Usage':
514 with this option, no FILE may be specified on the command line.
515 (main): Handle the new option.
516 * tests/misc/wc-files0: New tests, for the above.
517 * tests/misc/wc-files0-from: Likewise.
518 * tests/misc/Makefile.am (TESTS): Add wc-files0.
520 2006-06-24 Jim Meyering <jim@meyering.net>
522 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
524 2006-06-22 Jim Meyering <jim@meyering.net>
526 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
527 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
529 2006-06-19 Jim Meyering <jim@meyering.net>
531 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
532 so this check is not run as part of "make distcheck".
534 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
536 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
538 2006-06-18 Jim Meyering <jim@meyering.net>
540 * tests/misc/pwd-long: Make error output a little clearer.
542 2006-06-17 Jim Meyering <jim@meyering.net>
544 * tests/rm/inaccessible: Skip this test on systems without openat
545 support. Reported by Bob Proulx.
547 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
549 * tests/misc/mknod: Improve permission checks to handle
550 running mkdir test in set-gid directories.
552 2006-06-14 Jim Meyering <jim@meyering.net>
554 * tests/du/basic: Revamp not to hard-code file system block sizes.
556 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
558 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
561 2006-06-11 Jim Meyering <jim@meyering.net>
563 * .gitignore: New file.
564 * Makefile.am (EXTRA_DIST): Add .gitignore.
566 Setting TIME_STYLE=long-iso in the environment would make the
567 cp/same-file test fail.
568 * tests/envvar-check (vars): Add TIME_STYLE to the list.
569 * tests/cp/same-file: Revert last change.
570 Source the envvar-check script, to ensure that TIME_STYLE
571 settings don't affect these tests.
573 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
575 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
576 uses POSIX time stamp formats. Problem reported by John Nixon in
577 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
579 2006-06-10 Jim Meyering <jim@meyering.net>
581 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
583 Require a "Version N.M" line at the top of the ChangeLog
584 file only when making the actual release, not when running
586 * Makefile.maint (maintainer-distcheck): Don't depend on
588 (alpha beta major): Depend on it here, instead.
590 2006-06-08 Jim Meyering <jim@meyering.net>
592 Ensure that cat works with any of the options, -A -v -e -E -T,
593 when applied to files in /proc and /sys, even when the FIONREAD
594 ioctl produces nonsensical results. Before this change, cat would
595 produce no output (or truncated output), for some linux kernels.
597 * src/cat.c (write_pending): New function, factored out of cat.
598 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
599 that there are bytes to read. Some versions of linux-2.6.16 do that.
600 Write any pending output before returning.
601 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
602 * NEWS: Mention this bug fix.
603 * tests/misc/cat-proc: New file. Test for the above.
604 * tests/misc/Makefile.am (TESTS): Add cat-proc.
606 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
608 * src/expr.c (eval4): Detect overflow properly when multiplying
611 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
613 * NEWS: The 'expr' command now detects and reports integer overflow.
614 (It would be better to use extended precision instead, but that
616 * src/expr.c (integer_overflow): New function.
617 (eval4, eval3): Check for integer overflow.
619 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
621 Fix problems when building with Solaris/SVR4/etc. make, which uses a
622 different and somewhat bogus implementation of VPATH. In the
623 directory tests/misc, rename tests whose names might appear in the
624 Automake-generated rules. For example, we can't use a test named
625 'test', since Automake generates a rule that contains the text
626 "if test -f ./$$tst; ...", and this might expand to something like
627 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
628 which executes the 'test' script rather than the 'test' command.
629 * tests/misc/false-status: Renamed from tests/misc/false.
630 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
631 * tests/misc/sort-merge: Renamed from tests/misc/sort.
632 ($prog): Set to 'sort' rather than to $PROG.
633 * tests/misc/test-diag: Renamed from tests/misc/test.
634 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
635 in case Solaris make has prepended the directory.
636 (TESTS): Adjust to above renamings.
637 * tests/misc/expand: Don't assign to PROG; no longer needed
638 now that Makefile.am sets PROG to the basename.
639 * tests/misc/fold: Likewise.
641 2006-06-03 Jim Meyering <jim@meyering.net>
643 Make `cp --link --no-dereference' work also on systems where the
644 link system call cannot create a hard link to a symbolic link.
645 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
646 the link syscall on a symlink when it would do the wrong thing.
647 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
648 * tests/cp/link-no-deref: New file/test for the above.
649 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
650 * NEWS: Mention the change (doesn't affect Linux).
652 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
654 Fix some porting problems in the test cases reported by
655 Ralf Wildenhues for HP-UX 11.23 in:
656 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
657 * tests/help-version: Don't assume that \< \> works in sed.
658 * tests/misc/close-stdout: Don't assume that >&- works.
659 Add a /dev/full test.
660 * tests/touch/no-create-missing: Don't assume that >&- works.
662 2006-05-30 Jim Meyering <jim@meyering.net>
664 * src/ls.c (usage): Add `v' to the list of sorting-related options.
667 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
669 * tests/cp/fail-perm: source lang-default.
670 * tests/rm/inaccessible: Likewise.
672 2006-05-28 Jim Meyering <jim@meyering.net>
674 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
675 Recognize it, too. Reported by Ralf Wildenhues, in
676 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
678 2006-05-27 Jim Meyering <jim@meyering.net>
680 * src/chgrp.c: Support new options: --preserve-root and
681 --no-preserve-root. Somehow this program was skipped when those
682 options were added to chown, chmod, and rm. Reported by
683 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
684 * NEWS: Mention this.
686 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
688 * NEWS: Remove mention of --seed. We'll replace it with something
689 better, and don't want to indicate that it is supported.
690 * src/sort.c (usage): Likewise.
692 2006-05-20 Jim Meyering <jim@meyering.net>
694 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
696 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
697 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
698 FTS_COMFOLLOW. Spotted by Justin Pryzby.
700 * gnupload: Merge changes from automake, retaining the ""--to...
701 kludge to placate overzealous `make distcheck' check.
703 2006-05-19 Jim Meyering <jim@meyering.net>
705 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
706 FTS_TIGHT_CYCLE_CHECK directory traversal option.
707 Reported by Justin Pryzby in http://bugs.debian.org/367691
709 2006-05-15 Jim Meyering <jim@meyering.net>
711 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
714 2006-05-13 Jim Meyering <jim@meyering.net>
716 * tests/mv/no-target-dir: Test two more cases.
718 2006-05-11 Jim Meyering <jim@meyering.net>
720 mv -T DIR EMPTY_DIR no longer fails unconditionally
721 * src/copy.c (copy_internal): Don't manually prohibit a move where
722 the destination is an existing directory. Sometimes doing that is
723 valid. Let the rename system call enforce the rules. That is
724 allowed only when the source is a directory and the destination
725 directory (to be replaced) is empty. Reported by Eric Blake.
726 * tests/mv/no-target-dir: New file/test for this.
727 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
728 * NEWS: Mention this.
730 * tests/mv/atomic: New file/test for yesterday's fix.
731 * tests/mv/Makefile.am (TESTS): Add atomic.
733 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
735 2006-05-10 Jim Meyering <jim@meyering.net>
737 * src/copy.c (copy_internal): Don't explicitly unlink the destination
738 when moving a symlink into the place of an existing non-directory.
739 Reported by Joshua Hudson.
740 * NEWS: mention this.
742 2006-05-07 Jim Meyering <jim@meyering.net>
744 * Makefile.maint (patch-check): Fail if patch generates any output,
745 even merely for changed offsets.
747 * src/c99-to-c89.diff: Adjust to reflect new offsets.
749 * NEWS: Mention changes affecting df, pwd, shred.
751 2006-05-06 Jim Meyering <jim@meyering.net>
753 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
754 system condition where dirent.d_ino != stat.st_ino.
755 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
757 2006-05-06 Eric Blake <ebb9@byu.net>
759 * tests/ls/inode: Expand to test inode from readdir case.
760 * tests/ls/follow-slink: Expand to test broken links encountered
761 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
763 2006-05-06 Eric Blake <ebb9@byu.net>
765 * tests/mv/leak-fd: Work even on case-insensitive file system.
767 2006-05-04 Jim Meyering <jim@meyering.net>
769 * NEWS: Mention the 2006-03-19 pwd-related change that makes
770 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
772 2006-05-03 Jim Meyering <jim@meyering.net>
774 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
775 Use better macro parameter names: s/basename/key_name/,
776 s/basefunc/key_cmp_func. Fix typo in comment.
778 2006-04-29 Eric Blake <ebb9@byu.net>
780 * src/ls.c (main): On systems with d_type, directories_first only
781 implies format_needs_type, not format_needs_stat.
783 2006-05-03 Jim Meyering <jim@meyering.net>
785 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
786 after comma in arg list, from Eric Blake.
788 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
790 * tests/misc/date (relative-3): New test, derived from a bug
791 report by John Thomas McDole.
793 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
795 New option for ls: --group-directories-first.
796 It makes ls list directories before files.
797 * NEWS [New features]: Mention it.
798 * src/ls.c (sort_type): Rearrange to use as an array index when
799 choosing sort function; added new sort_numtypes member for
801 (time_type): Add new time_numtypes member for compile-time check.
802 (directories_first): New global variable.
803 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
804 (long_options): Add --directories-first.
805 (main): Support new option.
806 (is_directory): New function.
807 (extract_dirs_from_files): Use it.
808 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
809 (LIST_SORTFUNCTION_VARIANTS): New macros.
810 (sort_functions): New global variable.
811 (sort_files): Use it.
812 (usage): Document new option.
814 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
816 * src/shred.c (fillrand): The assertion was way too weak, due to
817 what must be a typo. Strengthen it to its intended value.
818 (dopass): Don't use alloca; it's not worth the aggravation here,
819 since it's used only to get a page-aligned buffer, and page
820 alignment doesn't buy us much here. I'm suspicious that alloca
821 causes problems on some hosts, due to a recent bug report by Adam
822 Waltman: http://bugs.gentoo.org/130246.
824 2006-04-18 Jim Meyering <jim@meyering.net>
826 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
827 sha384sum, sha512sum.
829 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
831 * src/chmod.c (describe_change): Adjust to filemode changes.
832 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
833 (print_long_format): Use (new) filemodestring rather than
834 (old) mode_string, so that we get more file types right, at least
835 in theory. Adjust to filemode changes.
836 * src/stat.c (human_access): Likewise.
838 2006-04-18 Jim Meyering <jim@meyering.net>
840 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
841 ignore file. This has never been enabled. Reported by Eric Blake.
843 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
845 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
846 bug in Interix. Just call symlink or link directly. All uses changed.
847 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
848 * src/stat.c (USE_STATVFS): New macro.
849 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
850 (NAMEMAX_FORMAT): define a bit more clearly, now that the
851 statvfs-using code is a bit more regular.
852 * src/system.h (sync) [!HAVE_SYNC]: New macro.
854 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
856 * NEWS: csplit, nl, expr now conform to POSIX better, and are
857 more-compatible with traditional Unix, with respect to regular
859 * src/csplit.c (extract_regexp): Set re_syntax_options to a
860 value that is compatible with what POSIX requires.
861 * src/nl.c (build_type_arg): Likewise.
862 * src/expr.c (docolon): Likewise. Also, don't let anchors match
863 newline; this fixes an incompatibility with tradition and with POSIX.
864 Don't warn about leading ^. POSIX says it is unspecified whether
865 ^ is a special character, which means that implementations can
866 either treat it as special or not, but either way a warning is not
867 allowed (unless the regexp is otherwise invalid). Instead, anchor
868 the expression but treat ^ as an anchor; this is the traditional
869 behavior (e.g., Solaris 10).
870 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
871 and the like as invalid expressions (exit status 2), not as
872 failure of 'expr' (exit status 3). This is more consistent with
874 * tests/expr/basic (fail-a): Adjust exit status to match new expr
875 behavior, for status 2 versus 3.
877 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
878 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
879 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
880 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
881 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
882 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
883 (bre61, bre62): New tests.
884 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
888 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
889 "if !". Do not assume that 'sed' can handle long, newline-free input.
890 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
892 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
894 Adjust to new regex.h API (with new fastmap type), and clean
895 up the regex storage allocation a bit.
897 * src/csplit.c (struct control): Put re_compiled member at the
898 end, since it's large. Change regexpr member from char * to bool;
899 all uses changed. Add new member fastmap.
900 (extract_regexp): regexp arg is now char const *, not char *.
901 Don't bother duplicating the regular expression; it's not needed.
902 Set fastmap from new fastmap member. Don't bother allocating
903 a buffer, as the regexp code does a better job than we do.
904 * src/expr.c (docolon): Allocate and use a fastmap.
905 Don't bother allocating a buffer.
906 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
908 (build_type_arg): New fastmap arg. All uses changed.
909 Don't bother allocating a buffer, but set a fastmap.
910 * src/ptx.c (context_regex_string, word_regex_string): Remove.
911 (context_regex, word_regex): New vars, replacing the above.
913 (struct regex_data): New type.
914 (compile_regex): Renamed from alloc_and_compile_regex, since
915 we no longer allocate storage. Arg is now a struct regex_data *,
916 not a const char *. All uses changed. Don't allocate the fastmap;
917 instead, take it from the caller. Don't convert size_t to int,
918 to avoid arithmetic overflow problems. Don't bother freeing
919 storage afterwards; it's not worth the aggravation.
920 * src/tac.c (compiled_separator_fastmap): New ver.
921 (main): Use it. Don't bother allocating a buffer.
923 2006-03-30 Jim Meyering <jim@meyering.net>
925 * src/dd.c (iwrite): Remove assignment without effect.
926 Reported by Felix Rauch Valenti.
928 2006-03-22 Eric Blake <ebb9@byu.net>
930 * src/ptx.c (usage): Remove mention of --copyright/-C.
931 (main): Alias --copyright to --version plus a deprecation warning.
932 * NEWS: Mention this.
934 2006-03-27 Jim Meyering <jim@meyering.net>
936 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
937 use of strtod. Tiny patch from Nickolai Zeldovich.
939 2006-03-11 Eric Blake <ebb9@byu.net>
941 * tests/misc/dirname: New file.
942 * tests/basename/Makefile.am: Delete.
943 * tests/basename/basic: Move to...
944 * tests/misc/basename: ... this new file. Add some tests,
945 including fixed behavior for //.
946 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
947 * tests/Makefile.am (SUBDIRS): Remove basename.
948 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
950 Improvements to dirname/basename handling on platforms like
951 cygwin with distinct // and with drive letters.
952 * NEWS: Document new behavior.
953 * src/basename.c (main): Don't strip suffix from file system
955 * src/cp.c (target_directory_operand): Use new last_component.
956 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
957 traversing the string.
958 * src/dircolors.c (guess_shell_syntax): Use new last_component.
959 * src/install.c (target_directory_operand, install_file_in_dir):
961 * src/ln.c (target_directory_operand, main): Likewise.
962 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
963 * src/mv.c (target_directory_operand, movefile): Likewise.
964 * src/remove.c (rm_1): Likewise.
965 * src/shred.c (wipename): Likewise.
966 * src/split.c (next_file_name): Likewise.
967 * src/su.c (log_su, run_shell): Likewise.
969 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
971 * NEWS: nohup diagnostics are now more precise, and nohup now
972 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
973 * src/nohup.c (main): Implement this.
974 * tests/misc/nohup: Test the new behavior.
976 2006-03-12 Jim Meyering <jim@meyering.net>
978 * src/copy.c (set_author): Rename function, from preserve_author.
980 * src/remove.c (AD_pop_and_chdir): Use new macro,
981 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
983 * src/system.h (SAME_INODE): Remove definition.
984 Include "same-inode.h", instead.
986 2006-03-11 Eric Blake <ebb9@byu.net>
988 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
990 2006-03-10 Jim Meyering <jim@meyering.net>
992 Fix a bug whereby a user with write access to a directory being removed
993 could cause the removal of that directory to fail with an erroneous
994 diagnostic about a directory cycle. Reported by Vineet Chadha.
996 * NEWS: Mention this.
997 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
998 leave (and try to rmdir) is the one whose dev_ino is being used to
999 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
1001 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
1003 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
1004 * src/dd.c (set_fd_flags): Handle file-creation flags on file
1005 descriptors, rather than ignoring them.
1006 * tests/dd/misc: Add test cases for append, nofollow, directory,
1007 and nolinks flags. Simplify redirection to /dev/null in some cases.
1009 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
1010 noatime test never tested anything.
1012 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
1014 * src/dd.c (flags, usage): New flags directory, nolinks.
1015 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
1017 * src/ls.c (usage): Mention that -f disables --color.
1018 Problem reported by Niels Möller.
1020 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
1022 * man/*.x: Add references to syscalls from utilities of the same name.
1024 2006-03-05 Jim Meyering <jim@meyering.net>
1026 * tests/help-version: Set SHELL, if not already set, in order to
1027 avoid failure when `make check' is run through debuild; dircolors
1028 would fail due to lack of $SHELL. Reported by Sven Joachim.
1030 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
1031 * src/base64.c (wrap_write, do_encode, main): Change type of
1032 parameters and locals, wrap_column, form size_t to uintmax_t.
1033 (main): Adjust to use xstrtoumax, accordingly.
1035 2006-03-03 Jim Meyering <jim@meyering.net>
1037 Don't fail when run from an environment with SHELL not a Bourne
1038 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
1039 * tests/dircolors/simple: Invoke each non-failing test with -b.
1040 Reported by Michael Stone.
1042 2006-02-27 Jim Meyering <jim@meyering.net>
1044 * tests/misc/base64: Derive --decode-using tests from the
1047 * tests/misc/base64: Factor out a long constant string.
1048 Split lines to stay within 80 columns.
1050 * tests/misc/Makefile.am (TESTS): Add base64.
1051 * tests/misc/base64: Test base64. From Simon Josefsson.
1053 * src/base64.c (do_decode): Use correct type for parameter,
1054 ignore_garbage: s/size_t/bool/.
1056 * src/base64.c: Don't include .h files already included by system.h:
1057 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
1058 Include "system.h" before the other lib/*.h header files.
1059 Include <sys/types.h> before "system.h".
1060 (wrap_write): Remove declaration of unused local, initial_column.
1061 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
1063 * README: Add base64 to the list.
1065 2006-02-17 Simon Josefsson <jas@extundo.com>
1067 New program: base64.
1068 * AUTHORS: Mention base64.
1070 * man/Makefile.am: Build base64.1.
1071 * man/base64.x: New file.
1072 * src/Makefile.am (bin_PROGRAMS): Add base64.
1073 * src/base64.c: New file.
1075 2006-02-25 Eric Blake <ebb9@byu.net>
1077 In ls, avoid calling stat for --inode (-i), when possible.
1078 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
1079 * src/system.h: ... here, for use in ...
1080 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
1082 (gobble_file): Add inode argument.
1083 (print_dir): Pass inode if available.
1084 (usage): Remove inaccuracy.
1086 2006-02-23 Jim Meyering <jim@meyering.net>
1088 * TODO: Update/correct some obsolete entries.
1090 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
1092 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
1093 * src/join.c (usage): Likewise.
1094 Documentation problem reported by Philip Kensche.
1096 2006-02-20 Eric Blake <ebb9@byu.net>
1098 * man/rm.x: Update documentation to match previous patch.
1100 2006-02-18 Eric Blake <ebb9@byu.net>
1102 New option for rm: --interactive=once (-I).
1103 * NEWS: Document it, along with change to rm --interactive.
1104 * TODO: Remove entry for implementing rm -I
1105 * src/rm.c (INTERACTIVE_OPTION): New enum value.
1106 (interactive_type): New enum.
1107 (long_opts): Let interactive take an optional argument.
1108 (interactive_args, interactive_types): New option arguments.
1109 (usage): Document -I, --interactive=WHEN. Use program_name
1110 instead of a basename.
1111 (main): New -I option, new behavior to --interactive.
1112 * tests/rm/interactive-once: New tests.
1113 * tests/rm/interactive-always: Ditto.
1114 * tests/rm/Makefile.am (TESTS): Run them.
1116 2006-02-18 Jim Meyering <jim@meyering.net>
1118 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
1119 expression match more of the target lines, e.g., those that start with
1120 `-S,' (short option followed by a comma) or that include `=[...]'.
1121 Patch by Nicolas François.
1122 Fix the four offenders thus exposed:
1123 * src/join.c (usage): Use two spaces (not one) to separate the
1124 --first-only option string from its description, so help2man formats
1125 the derived man page properly.
1126 * src/pr.c (usage): Likewise.
1127 * src/uniq.c (usage): Likewise.
1128 * src/install.c (usage): Likewise.
1130 2006-02-15 Jim Meyering <jim@meyering.net>
1132 * Makefile.maint (alpha beta major): For `make major', ensure that the
1133 version string is of the form N.N[.N]*, where N is one or more digits.
1135 2006-02-14 Jim Meyering <jim@meyering.net>
1137 * INSTALL: Update from gnulib.
1139 2006-02-13 Jim Meyering <jim@meyering.net>
1141 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
1143 2006-02-12 Jim Meyering <jim@meyering.net>
1145 * Makefile.maint (patch-check): New target.
1146 (local-checks-available): Add to the list.
1148 2006-02-11 Jim Meyering <jim@meyering.net>
1150 * src/c99-to-c89.diff: New file.
1151 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
1153 * .x-po-check: New file, with exclusions so that `make distcheck'
1155 * Makefile.am (EXTRA_DIST): Add .x-po-check.
1157 rm -r must remove an empty directory, even if it is inaccessible.
1158 * src/remove.c (close_preserve_errno): New function.
1159 (fd_to_subdirp): Don't print a diagnostic in this function.
1160 Do it from the callers instead, unless rmdir succeeds.
1161 (remove_cwd_entries, remove_dir): Adjust callers.
1162 * tests/rm/empty-inacc: New test for the above.
1163 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
1164 * NEWS: Mention this bug fix.
1165 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
1166 a tiny bit less precise: cannot remove `a/1': ... instead of
1167 cannot open directory `a/1': ...
1169 * Makefile.maint (syntax-check-rules): Automatically derive this
1170 list of sc_-prefixed rule names.
1172 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
1174 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
1175 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
1176 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
1177 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
1178 go away? was that an accident?)
1179 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
1180 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
1181 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
1182 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
1183 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
1184 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
1185 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
1186 (author_mark_check, makefile_path_separator_check):
1187 Output line numbers, to simplify navigation of Emacs *compilation*
1189 (sc_prohibit_atoi_atof, sc_file_system):
1190 Rework slightly so that Makefile.maint doesn't get reported as a
1191 violation of its own syntax rules.
1192 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
1193 it at run-time (which didn't work with Bison). Fix a makefile typo,
1194 caught by Makefile.maint itself: spaces where a tab should be.
1195 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
1196 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
1197 Ignore djgpp and man subdirectories, to avoid false matches with
1198 Bison and coreutils, respectively. Use sort -u to remove the
1199 resulting duplicates.
1200 * gnupload: Rework slightly to avoid bogus warning from
1201 sc_two_space_separator_in_usage.
1203 2006-02-10 Jim Meyering <jim@meyering.net>
1205 Use gzip's --rsyncable option only if it's available.
1206 * Makefile.maint (gzip_rsyncable): New variable.
1209 2006-02-08 Jim Meyering <jim@meyering.net>
1211 * Makefile.maint (local-checks-available): Define in terms of
1212 the expansion, $(syntax-check-rules), rather than the single,
1213 top-level target `syntax-check', so that it's easier to exclude
1214 individual rules (via $(local-checks-to-skip)).
1215 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
1217 2006-02-07 Jim Meyering <jim@meyering.net>
1219 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
1220 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
1222 * tests/help-version (expected_failure_status_vdir):
1223 Redirect an expected disk-full diagnostic to /dev/null.
1225 2006-02-06 Jim Meyering <jim@meyering.net>
1227 * src/unexpand.c (usage): Use two spaces (not one) to separate the
1228 --first-only option string from its description, so help2man formats
1229 the derived man page properly.
1230 * src/rm.c (usage): Likewise for --no-preserve-root.
1231 * src/chown.c (usage): Likewise.
1232 * src/chgrp.c (usage): Likewise.
1234 Add a rule to ensure that the above doesn't happen again.
1235 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
1236 (syntax-check-rules): Add it.
1237 * .x-sc_two_space_separator_in_usage: New empty file.
1238 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
1240 2006-02-06 Jim Meyering <jim@meyering.net>
1242 * src/cp.c (usage): Use two spaces (not one) to separate each
1243 option string from its description, so help2man formats the
1244 derived man page properly.
1245 * src/mv.c (usage): Likewise.
1246 Patch from Nicolas François in http://bugs.debian.org/351601.
1248 2006-02-04 Jim Meyering <jim@meyering.net>
1250 * src/copy.c (copy_internal): cp -RL would fail when encountering
1251 the same directory more than once in the hierarchy beneath a single
1252 command-line argument. That is legitimate, e.g. when there are
1253 two or more symbolic links, each pointing to some directory that
1254 would not otherwise be copied. Reported by Christophe LYON.
1255 * tests/cp/cp-deref: New file. Test for today's fix.
1256 * tests/cp/Makefile.am (TESTS): Add cp-deref.
1257 * NEWS: Document this.
1259 2006-02-03 Jim Meyering <jim@meyering.net>
1261 * configure.ac: Require automake-1.9.6, not 1.8.3.
1263 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
1265 * src/od.c (usage): Mention that -t a ignores high order bit.
1266 Documentation problem reported by Ed Avis.
1268 2006-02-01 Jim Meyering <jim@meyering.net>
1270 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
1272 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
1274 * src/head.c (main): Use a better diagnostic when someone uses a
1275 trailing numeric option in an invalid way. Problem reported by
1277 * src/tail.c (parse_options): Likewise.
1279 2006-01-30 Jim Meyering <jim@meyering.net>
1281 * man/wc.x: Include `count' keyword in man page synopsis,
1282 per suggestion from http://bugs.debian.org/181585.
1284 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
1286 * src/df.c (show_dev): If the file system claims to have
1287 more available than total blocks, report the number of used
1288 blocks as being total - available (a negative number) rather
1289 than as garbage. Problem reported by Toralf Foerster.
1291 2006-01-24 Jim Meyering <jim@meyering.net>
1293 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
1294 to put a regular file in O_NONBLOCK mode fails with EPERM.
1295 That happens on Linux (up to 2.6.15) when using tail -f on a file with
1296 the append-only attribute. Reported by Dean Gaudet. For details,
1297 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
1298 * NEWS: Mention this fix.
1299 * tests/tail-2/append-only: New file. Test for the above.
1300 * tests/tail-2/Makefile.am (TESTS): Add append-only.
1301 * tests/Makefile.am (check-root): Add tail-2/append-only
1303 2006-01-21 Jim Meyering <jim@meyering.net>
1305 * NEWS: Mention fts-related improvements and bug fixes.
1307 2006-01-19 Jim Meyering <jim@meyering.net>
1309 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
1310 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
1312 2006-01-18 Jim Meyering <jim@meyering.net>
1314 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
1316 2006-01-17 Jim Meyering <jim@meyering.net>
1318 Now that fts no longer changes the current working directory, adjust
1319 its clients accordingly -- note that du.c uses fts but doesn't need
1320 any adjustment, since it doesn't operate on the actual files,
1321 but rather just uses the stat buffers provided by fts.
1323 * src/chown-core.c: Include "openat.h".
1324 Don't include "lchown.h".
1325 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
1326 calling openat, lchownat, chownat, rather than open, lchown, chown.
1328 * src/chmod.c: Include "openat.h".
1329 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
1331 * tests/du/long-from-unreadable: New test, to exercise one small
1334 2006-01-13 Jim Meyering <jim@meyering.net>
1336 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
1337 addition of new directories under tests/.
1339 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
1342 2006-01-12 Jim Meyering <jim@meyering.net>
1344 * tests/du/long-sloop: Adjust not to hard-code the expected
1345 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
1346 from that of GNU libc. Reported by Paul Eggert.
1348 * tests/du/long-sloop: Create file at end of symlink chain.
1350 * tests/misc/test: New file, with a test for one of the
1351 bugs fixed by yesterday's test.c changes.
1352 * tests/misc/Makefile.am (TESTS): Add test.
1354 2006-01-11 Jim Meyering <jim@meyering.net>
1356 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
1357 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
1358 a very long sequence of symbolic links (not necessarily a loop).
1359 * tests/du/Makefile.am (TESTS): Add long-sloop.
1361 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
1363 * src/test.c (test_syntax_error): Append a newline. All callers
1364 changed, except for the ones that didn't already append a newline.
1365 Bug reported by Eric Blake.
1367 2006-01-11 Jim Meyering <jim@meyering.net>
1369 * src/system.h (X2NREALLOC): Now that verify_true is no longer
1370 void, cast its result to void, to avoid gcc's warning that
1371 ``left-hand operand of comma expression has no effect''.
1372 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
1374 2006-01-10 Jim Meyering <jim@meyering.net>
1376 * tests/chmod/no-x: Add a test for today's fts.c fix.
1378 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
1380 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
1381 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
1383 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
1385 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
1386 Use verify_true instead of verify_expr, to sync with gnulib.
1388 2006-01-08 Jim Meyering <jim@meyering.net>
1390 * src/date.c (usage): Adjust the formatting of the entries for
1391 %::z and %:::z (separate with two spaces, not one) so that help2man
1392 formats them properly. Reported by Philip Rowlands.
1394 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
1396 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
1398 2006-01-06 Jim Meyering <jim@meyering.net>
1400 * Makefile.maint (copyright-check): Use date +%Y in place of
1403 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
1404 First off, the attribute should have been `volatile' (not static)
1405 to avoid longjmp-related risk of clobber. Secondly, now there is
1406 no longer any risk of a local variable being clobbered, so there's
1407 no need for any attribute at all.
1409 2006-01-05 Jim Meyering <jim@meyering.net>
1411 * src/remove.c: Give a few functions the inline attribute.
1412 (AD_pop_and_chdir): Use gotos to avoid some duplication.
1413 (AD_push): Rewrite an assertion so that the entire computation
1414 goes away when assertions are turned off.
1416 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
1417 It's already defined in "system.h".
1418 * Makefile.maint: Add a FIXME comment.
1420 2006-01-04 Jim Meyering <jim@meyering.net>
1422 * ChangeLog: Remove entries from 2005-10-22 and earlier.
1423 * ChangeLog-2005: New file, for entries up to version 5.92.
1425 2006-01-03 Jim Meyering <jim@meyering.net>
1427 * tests/du/no-x: Also allow a slightly different diagnostic -- the
1428 one you get when using openat-enabled fts.c and du (coming soon).
1429 * tests/chmod/no-x: Likewise.
1430 * tests/chgrp/no-x: Likewise.
1432 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
1434 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
1436 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
1437 (restricted_chown): Return it, if the file cannot be accessed due
1438 to EPERM, or if no uid or gid are required, or if the file is
1439 neither a directory nor a regular file. Rewrite to avoid gotos.
1440 (change_file_owner): Handle RC_do_ordinary_chown case.
1441 Rewrite to avoid gotos.
1442 * tests/chgrp/basic: Make sure we can change the group of
1445 * src/date.c (usage): Explain %g, %G, and %V a bit better.
1447 2006-01-02 Jim Meyering <jim@meyering.net>
1449 * src/copy.c (set_owner): Correct a comment.
1451 * src/tail.c (parse_options): Change warning to say that --retry
1452 is useful `mainly' (not `only') when following by name.
1453 Reported here: http://bugs.debian.org/273781
1455 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
1457 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
1458 * src/copy.c: Include lchmod.h.
1459 (copy_internal): Use lchmod rather than chmod.
1460 * src/cp.c: Include lchmod.h.
1461 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
1462 * src/mkdir.c: Include lchmod.h.
1463 (usage): Clarify -m's operation.
1464 (main): Use lchmod rather than chmod. Don't use lchmod unless the
1465 new mode contains bits outside the 777 range.
1466 * src/mkfifo.c (usage): Clarify -m's operation.
1467 (main): If -m is given, don't invoke chmod; use umask 0 instead.
1468 Report an error if -m asks for bits outside the 777 range.
1469 * src/mknod.c (usage, main): Likewise.
1471 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
1473 2005-12-27 Jim Meyering <jim@meyering.net>
1475 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
1476 (sc_prohibit_assert_without_use): New rule.
1477 (syntax-check-rules): Add it to the list.
1478 * .x-sc_prohibit_assert_without_use: New empty file.
1479 * Makefile.am (EXTRA_DIST): Add it.
1481 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
1483 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
1484 Don't include <assert.h>; it wasn't used.
1486 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
1488 * src/chown-core.c (restricted_chown):
1489 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
1490 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
1491 | O_NOFOLLOW too, for consistency with other dir-openers.
1492 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
1493 (is_empty_dir): Likewise.
1494 * src/shred.c (wipename): Likewise. Don't bother trying to open
1495 dir for writing, since POSIX prohibits it.
1497 2005-12-22 Jim Meyering <jim@meyering.net>
1499 * tests/help-version: Redirect stderr to /dev/full, to suppress
1500 write error diagnostic.
1502 2005-12-19 Jim Meyering <jim@meyering.net>
1504 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
1505 Avoid a minor race condition when `-m MODE' is specified, by using
1506 open, fchown, and close rather than just chown. To do that reliably --
1507 even with an overly restrictive umask -- ensure that each mkdir,
1508 mknod and mkfifo call uses a mode including at least owner-read access.
1509 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
1510 the subsequent chown (or equivalent open,fchown,close) fails.
1511 * tests/misc/mknod: New tests.
1512 * tests/misc/Makefile.am (TESTS): Add mknod.
1514 2005-12-17 Jim Meyering <jim@meyering.net>
1516 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
1517 e.g., on a named pipe.
1518 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
1519 place of all uses, since it is guaranteed (system.h) to be defined.
1521 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
1523 Add POSIX ACL support
1524 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
1525 is no requirement for ACL support; particularly, it does not exist
1526 on systems that have POSIX ACLs.
1527 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1528 * src/cp.c (umask_kill): With default acls, the umask is not to be
1529 applied. Remove umask_kill, don't change the process umask, and let
1530 the kernel apply the umask where appropriate.
1531 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1532 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1534 (copy_reg, copy_internal): Use copy_acl and set_acl
1535 instead of fchown/chown. Fix the logic for POSIX ACLs.
1536 (chown_succeded): Remove; we now always copy acls and
1537 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1538 did a chown before or not.
1539 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1540 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1541 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1542 to link with it via $(LIB_ACL), for the utilities that need it.
1544 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1546 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1547 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1548 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1549 value is now signified by whether cwd_errno is null.
1550 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1551 pointer-to-bool to pointer-to-errno-value. All callers changed.
1552 (rm_1): Don't bother setting a local cwd failure flag and then
1553 ORing it into the caller's. Just set the caller's.
1554 (rm): Use cwd failure errno value to print a slightly-better
1557 2005-12-15 Jim Meyering <jim@meyering.net>
1559 * src/stat.c (print_it): Properly handle a backslash at the
1560 end of a --printf format string. Reported by Paul Eggert.
1561 * tests/misc/stat-printf (end-bs): Add a test for the above.
1563 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1565 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1566 Don't assume /etc/passwd contains user names; use 'id' instead.
1568 2005-12-15 Jim Meyering <jim@meyering.net>
1570 stat: revert behavior of --format=FMT (-c)
1571 stat: add new option: --printf=FMT
1572 * NEWS: Mention this.
1573 * src/stat.c (isodigit, octtobin, hextobin): Define.
1574 (PRINTF_OPTION): Define.
1575 (interpret_backslash_escapes, trailing_delim): New globals.
1576 (usage): Document them. Alphabetize on long option names.
1577 (print_esc_char): New function.
1578 (print_it): Rewrite, in order to handle backslash escapes.
1579 (main): Handle new option. Set globals for --format, too.
1581 * tests/misc/stat-printf: Test --printf and --format.
1582 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1584 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1586 * NEWS: sort now reports incompatible options.
1587 * src/sort.c (incompatible_options, check_ordering_compatibility):
1589 (main): Use them. Don't bother with a usage message for
1590 "sort -c a b", for consistency with other error diagnostics.
1591 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1594 * src/cat.c (main): Undo previous change. close_stdout already
1595 does the check, so the previous change wasn't necessary.
1597 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1599 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1601 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1603 Install a more-conservative approach for sort -R. It's the
1604 same basic idea as the existing code, except it uses the full ISAAC
1605 approach (called the "more kosher" approach in the existing comments).
1606 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1607 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1608 better to be conservative here at first, and review any performance
1609 improvements carefully.
1610 * .x-sc_require_config_h: Add src/rand-isaac.c.
1611 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1612 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1613 (shred_SOURCES, sort_SOURCES): Remove.
1614 (EXTRA_DIST): Add rand-isaac.c.
1615 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1616 changing it to allow for varying numbers of words in the state.
1617 Alter so that we include rand-isaac.c directly rather than
1618 compiling it and linking to it. Don't include config.h or
1619 system.h; that's the includer's responsibility.
1620 Omit functions that are specific to shred.
1621 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1622 (isaac_step, struct irand_state):
1623 Resurrect these, with the same defns that used to be in shred.c.
1624 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1625 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1627 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1628 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1629 (irand_init, irand32, irand_mod):
1630 Number of words is constant again.
1631 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1632 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1633 * src/sort.c: Likewise.
1634 * src/shred.c (fillrand, dopass, main): Undo previous change.
1635 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1637 * src/sort.c: Don't include md5.h; it wasn't needed.
1638 (struct keyfield): Rename random_hash to random, for consistency
1639 with the other member names. All uses changed.
1640 (usage): Tweak wording to mention STRING for --seed option.
1641 (short_options): Rorder for consistency with other programs.
1642 (rand_state): Now a struct, not a pointer to one. All uses changed.
1643 (HASH_WORDS, HASH_SIZE): Remove.
1644 (get_hash): Remove comments around resbuf size, since we can assume C89.
1645 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1646 (keycompare): Adjust to the new get_hash.
1648 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1649 (main): Don't set need_random simply because gkey has it set; that
1650 doesn't necessarily mean we'll need random numbers.
1651 Redo seeding to match new get_hash approach.
1653 2005-12-10 Jim Meyering <jim@meyering.net>
1655 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1657 Avoid shred segfault on 64-bit systems.
1658 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1659 local of type uint32_t. Make the local an `int' instead.
1661 * NEWS: Mention sort's new options.
1663 * src/rand-isaac.c (isaac_mix): Declare to be static.
1664 Mark all other functions as `extern' so the tight-scope
1665 part of `make distcheck' passes once again.
1666 * src/rand-isaac.h (isaac_mix): Remove declaration.
1668 * src/sort.c (get_hash): Change position of `*' in parameter
1669 type to conform with convention.
1670 (main): Split a long line so it fits in 80 columns.
1671 (keycompare): Remove stray SPACE before TAB that was
1672 causing `make distcheck' to fail.
1674 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1676 * tests/misc/sort-rand: New file: basic tests for the new options.
1677 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1679 2005-12-10 Frederik Eaton <frederik@ofb.net>
1681 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1682 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1683 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1684 Make state size runtime-configurable.
1685 (isaac_new, isaac_copy): New functions.
1686 * src/rand-isaac.h: New file.
1687 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1688 (fillrand, main): Adjust to the fact that the state size is now
1689 runtime-configurable.
1690 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1691 (usage): Add options --random-sort and --seed to implement a random
1693 Include md5.h and rand-isaac.h.
1694 (get_hash): New function.
1695 (rand_state): New var.
1696 (HASH_WORDS, HASH_SIZE): New macros.
1698 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1700 * tests/dd/misc: Add test for dd iflags=noatime.
1702 2005-12-09 Jim Meyering <jim@meyering.net>
1704 * src/sort.c (usage): Mention white space vs -b and -t options.
1707 2005-12-09 Eric Blake <ebb9@byu.net>
1709 * src/test.c (main): Fix misleading comment.
1711 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1713 * NEWS: Mention dd's new noatime flag.
1714 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1715 * src/dd.c (flags, usage): Add support for noatime flag.
1717 2005-12-07 Jim Meyering <jim@meyering.net>
1719 Distribute the cvsu script, used only by `make syntax-check'.
1720 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1721 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1722 distribute a copy of this script.
1723 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1725 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1726 to create a temporary directory on another partition.
1727 From Andreas Gruenbacher.
1729 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1731 * man/basename.x: Cross-reference to dirname and readlink.
1732 * man/dirname.x: Cross-reference to basename and readlink.
1734 2005-12-05 Andreas Gruenbacher
1736 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1737 (set_owner, preserve_author): New functions, factored out of copy_reg.
1738 (copy_reg): Use them.
1739 (copy_internal): Use them here, too.
1741 2005-12-04 Jim Meyering <jim@meyering.net>
1743 * src/sleep.c (usage): Say what happens with two or more arguments.
1744 Suggested by Justin Pryzby.
1746 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1749 2005-12-03 Jim Meyering <jim@meyering.net>
1751 * src/rm.c (long_opts): Change the name of each undocumented, for-
1752 testing-only option to start with `-', so that it cannot render
1753 ambiguous any prefix it happens to share with some other option name.
1754 Problem reported by Eric Blake.
1755 * src/head.c (long_options): Likewise.
1756 * src/tail.c (long_options): Likewise.
1758 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1759 testing-only --presume* options to start with `---'.
1760 * tests/rm/dangling-symlink: Likewise.
1761 * tests/rm/dir-no-w: Likewise.
1762 * tests/rm/isatty: Likewise.
1764 2005-11-30 Jim Meyering <jim@meyering.net>
1766 * Makefile.maint: Add a comment about cvsu.
1768 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1770 * NEWS: df updates for "none", "proc", inaccessible file systems.
1771 * src/df.c (show_point): Ignore inaccessible file systems.
1772 (usage): -a includes dummy file systems, not size-0 file systems.
1774 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1775 to avoid collision with POSIX name space. All uses changed.
1777 2005-11-24 Jim Meyering <jim@meyering.net>
1779 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1780 * tests/acl: Add `$0: ' prefix to diagnostics.
1782 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1784 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1786 * src/copy.c: Improve performance a bit by optimizing away
1787 unnecessary system calls and going to a block size of at least
1788 8192 (on normal hosts, anyway). This improved performance 5% on my
1789 Debian stable host (2.4.27 kernel, x86, copying from root
1790 ext3 file system to itself).
1791 Include "buffer-lcm.h".
1792 (copy_reg): Omit last argument. All callers changed.
1793 Use xmalloc to allocate rather than trusting alloca
1794 (which is unwise with large block sizes).
1795 Declare locals more locally, if possible.
1796 Use uintptr_t words instead of int words, for a bit more speed
1797 when looking for null blocks on 64-bit hosts.
1798 Optimize away reads of zero bytes on regular files.
1799 In the typical case, insist on 8 KiB buffers, at least.
1800 Avoid unnecessary extra call to fstat when checking for sparse files.
1801 Avoid now-unnecessary cast to off_t, and "0L".
1802 Avoid unnecessary test of *new_dst when checking for same owner
1805 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1807 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1809 2005-11-22 Jim Meyering <jim@meyering.net>
1811 * src/remove.c (AD_push): Remove debugging cruft.
1813 * tests/rm/unread2 (rm): Change expected diagnostic,
1814 `cannot open directory' to `cannot remove', to align with
1816 * tests/rm/rm2: Ensure that rm now continues removing entries
1817 even after certain types of failure.
1819 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1820 that provide openat (Solaris), and on systems like Linux+procfs
1821 where our openat emulation code is reentrant. This also fixes a
1822 few low-probability leaks and eliminates some code that could,
1823 in very unusual circumstances, cause rm() (via a callee) to exit.
1824 * NEWS: Mention this.
1826 * configure.ac: Put copyright dates all on one line so the
1827 emacs function that updates them works properly.
1829 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1831 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1832 Problem reported by Eric Blake.
1833 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1834 we get a standard-conforming compiler. This relies on the new
1835 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1836 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1837 m4/c.m4 can go away with Autoconf 2.60 comes out.
1839 2005-11-17 Jim Meyering <jim@meyering.net>
1841 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1842 (AD_mark_current_as_unremovable): Likewise, but for a local.
1845 * tests/mv/acl: Let traps handle removing temporary directories.
1847 Expect acl-related tests to fail, until the corresponding
1848 patches are committed.
1849 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1850 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1852 ACL tests, from Andreas Gruenbacher.
1853 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1854 * tests/mv/Makefile.am (TESTS): Add acl.
1855 * tests/cp/Makefile.am (TESTS): Add acl.
1857 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1859 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1861 * NEWS: Improve quality of ln's diagnostics.
1862 * src/ln.c (do_link, usage): Likewise.
1863 (do_link): Don't use alloca on a buffer of unbounded size.
1865 2005-11-16 Jim Meyering <jim@meyering.net>
1867 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1868 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1869 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1870 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1871 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1873 2005-11-14 Jim Meyering <jim@meyering.net>
1875 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1877 2005-11-13 Jim Meyering <jim@meyering.net>
1879 * announce-gen: Accept new option, --gpg-key-id=ID and
1880 emit a blurb telling how to use the .sig files.
1881 * Makefile.cfg (gpg_key_ID): Define.
1882 * Makefile.maint (announcement): Use new option and key.
1884 Require that most .c files include <config.h>.
1885 * Makefile.maint (sc_require_config_h): New rule.
1886 (syntax-check-rules): Add it.
1887 * .x-sc_require_config_h: New file listing exceptions to the
1888 above rule. Some are legit, others are simply grandfathered in.
1889 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1891 2005-11-12 Jim Meyering <jim@meyering.net>
1893 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1895 2005-11-11 Jim Meyering <jim@meyering.net>
1897 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1898 Mention new readlink options in 5.3.0's `New features' section.
1899 Spotted by Thomas Hood.
1901 2005-11-08 Jim Meyering <jim@meyering.net>
1903 * NEWS: Merge in changes from b5_9x branch.
1905 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1907 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1908 like --time-style='posix-long-iso' if the locale settings are messed up.
1909 * src/ls.c (decode_switches): Implement this.
1911 2005-11-08 Jim Meyering <jim@meyering.net>
1913 * tests/du/2g: s/expensive/very expensive/ in a comment.
1916 2005-10-17 Eric Blake <ebb9@byu.net>
1918 * src/ls.c (usage): Fix descriptions of --sort, --time.
1919 Reported by Vitaly A. Ostanin.
1921 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1923 * src/ln.c: Include filenamecat.c.
1924 (FILE_BASENAME_CONCAT): Remove.
1925 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1926 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1927 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1930 2005-11-04 Jim Meyering <jim@meyering.net>
1932 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1933 on systems with stat.st_blocks of a signed 32-bit type.
1934 This bug causes trouble on some AIX 5.1 systems.
1935 Report and trivial patch from Paul Townsend:
1936 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1937 * NEWS: Mention this.
1939 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1940 * tests/du/Makefile.am (TESTS): Add it here.
1941 * tests/very-expensive: New file.
1942 * tests/Makefile.am (EXTRA_DIST): Add it here.
1943 * tests/cp/perm: Mark this test as `very-expensive', too.
1945 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1947 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1949 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1951 * src/rm.c (usage): Don't mention rm -d.
1953 2005-11-02 Jim Meyering <jim@meyering.net>
1955 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1956 From Andreas Schwab.
1958 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1959 `M+N records in/out' lines don't pollute `make check' output.
1961 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1962 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1963 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1964 to indicate that the input file should be piped into the command
1965 under test (via `cat FILE | $prog ...').
1967 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1968 (without -r) fails to remove a directory on a non-Linux system.
1969 This change affects only newer Solaris systems (with priv_*
1970 functions like priv_allocset). Reported by Keith Thompson.
1972 * tests/rm/dir-nonrecur: New file/test for the above fix.
1973 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1975 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1977 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1978 POSIX 1002.1-2001 requires.
1979 * src/tail.c (parse_obsolete_option): Implement this.
1980 Problem reported by Vincent Lefevre.
1981 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1982 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1983 (test_vector): Add special cases for _POSIX2_VERSION, and
1984 regularize the old ones a bit.
1985 * tests/touch/obsolescent: Add y2000 test.
1987 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1989 * src/dd.c (skip): Fix off-by-one error reported by
1990 Theodoros V. Kalamatianos.
1992 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1994 * tests/mkdir/p-3: Require that the test be run as non-root.
1995 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1997 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1999 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
2000 boundary between DEST and SOURCE in the result.
2002 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
2004 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
2005 back to text, to sync with documentation and for backwards
2008 2005-10-25 Jim Meyering <jim@meyering.net>
2010 * tests/dircolors/simple (other-wr): Add an explicit test for
2011 the dircolors bug (NULL-dereference) fixed yesterday.
2013 2005-10-24 Jim Meyering <jim@meyering.net>
2015 * src/tac.c (tac_file): When determining whether a file is seekable,
2016 also test whether it is a tty. Using only the lseek-based test would
2017 give a false positive on Solaris. Reported by Peter Fales.
2019 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
2021 * tests/install/d-slashdot: New test, for "install -d" failure.
2022 * tests/install/Makefile.am (TESTS): Add d-slashdot.
2023 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
2024 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
2026 2005-10-24 Jim Meyering <jim@meyering.net>
2028 * src/dircolors.c (ls_codes): Add missing comma.
2029 Anonymous report and patch from
2030 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
2032 * src/dircolors.c: Add compile-time assertion that the slack_codes
2033 and ls_codes arrays have the same number of elements. This would
2034 have prevented the above-fixed bug.
2036 * src/expand.c (parse_tab_stops): Add a comment to make this function
2037 identical to the one in unexpand.c.
2038 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
2039 identical to the one in expand.c.
2041 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
2043 2005-10-23 Jim Meyering <jim@meyering.net>
2045 * src/md5sum.c (digest_check, main): Use ptr_align rather than
2046 a dangerous pointer-value-to-`unsigned' cast.
2047 * NEWS: mention the new sha* programs.
2048 * AUTHORS: Add new sha* programs.
2050 2005-08-28 David Madore <david.madore@ens.fr>
2052 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
2053 * README: Add their names to the list.
2054 * src/md5sum.c: Provide framework for computing sha-2 hashes.
2055 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
2056 Rules for compiling sha-2 utilities
2057 (noinst_HEADERS): Remove checksum.h.
2058 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
2060 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
2061 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
2062 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
2063 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
2064 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
2065 sha384sum, sha512sum test scripts here rather that each in its
2068 2005-08-28 David Madore <david.madore@ens.fr>
2070 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
2071 of the FIPS test vectors).
2073 2005-10-23 Jim Meyering <jim@meyering.net>
2075 * configure.ac: Use 6.0-cvs as the version string.
2076 * NEWS: Adjust accordingly.