1 2005-01-21 Havoc Pennington <hp@redhat.com>
3 * glib/dbus-gmain.c: don't put the GLib bindings in the same
4 toplevel doxygen group as the low-level API stuff
6 * dbus/dbus.h: note that libdbus is the low-level API
8 2005-01-20 Havoc Pennington <hp@redhat.com>
10 * update-dbus-docs.sh: script to update docs on the web site, only
11 works for me though. neener.
13 2005-01-20 Havoc Pennington <hp@redhat.com>
15 * dbus/dbus-sysdeps.c (_dbus_poll): amazingly, trying to compile
16 code can reveal bugs in it
18 2005-01-20 Havoc Pennington <hp@redhat.com>
20 * dbus/dbus-sysdeps.c (_dbus_poll): fix several bugs in the
21 select() version, patches from Tor Lillqvist
23 2005-01-20 Havoc Pennington <hp@redhat.com>
25 * doc/dbus-tutorial.xml: replace > with >
27 * bus/services.c (bus_registry_acquire_service): validate the name
28 and return a better error if it's no good.
30 * doc/dbus-specification.xml: note NO_AUTO_START change
32 * dbus/dbus-protocol.h (DBUS_HEADER_FLAG_NO_AUTO_START): change
33 from AUTO_START, we're toggling the default
35 * bus/dispatch.c: adapt the tests to change of auto-start default
37 2005-01-18 Havoc Pennington <hp@redhat.com>
39 * rename dbus-daemon-1 to dbus-daemon throughout
41 2005-01-18 Havoc Pennington <hp@redhat.com>
43 * Throughout, grand renaming to strip out the use of "service",
44 just say "name" instead (or "bus name" when ambiguous). Did not
45 change the internal code of the message bus itself, only the
46 programmer-facing API and messages.
48 * doc/dbus-specification.xml: further update the message bus section
50 * bus/config-parser.c (all_are_equiv): fix bug using freed string
53 2005-01-17 Havoc Pennington <hp@redhat.com>
55 * dbus/dbus-types.h: remove 16-bit types since we don't use them
58 * dbus/dbus-marshal-validate.c (_dbus_validate_path): disallow any
59 "invalid name character" not only non-ASCII
61 * doc/dbus-specification.xml: further update spec, message bus
62 parts are still out-of-date but the marshaling etc. stuff is now
65 2005-01-17 Havoc Pennington <hp@redhat.com>
67 * doc/dbus-specification.xml: partially update spec
69 2005-01-17 Havoc Pennington <hp@redhat.com>
71 * Throughout, align variant bodies according to the contained
72 type, rather than always to 8. Should save a fair bit of space in
75 * dbus/dbus-marshal-validate.c (_dbus_validate_body_with_reason):
76 fix handling of case where p == end
78 * doc/TODO: remove the dbus_bool_t item and variant alignment items
80 2005-01-17 Havoc Pennington <hp@redhat.com>
82 * dbus/dbus-types.h: hardcode dbus_bool_t to 32 bits
84 * Throughout: modify DBUS_TYPE_BOOLEAN to be a 32-bit type instead
85 of an 8-bit type. Now dbus_bool_t is the type to use whenever you
86 are marshaling/unmarshaling a boolean.
88 2005-01-16 Havoc Pennington <hp@redhat.com>
90 This is about it on what can be disabled/deleted from libdbus
91 easily, back below 150K anyhow. Deeper cuts are more work than
92 just turning the code off as I've done here.
94 * dbus/dbus-marshal-basic.c (_dbus_pack_int32): we don't need the
95 signed int convenience funcs
97 * dbus/dbus-internals.c (_dbus_verbose_real): omit when not in
100 * dbus/dbus-string-util.c, dbus/dbus-string.c: more breaking
101 things out of libdbus
103 * dbus/dbus-sysdeps.c, dbus/dbus-sysdeps-util.c: same
105 * dbus/dbus-hash.c: purge the TWO_STRINGS crap (well, make it
106 tests-enabled-only, though it should probably be deleted)
108 * dbus/dbus-message-util.c: same stuff
110 * dbus/dbus-auth-util.c: same stuff
112 2005-01-16 Havoc Pennington <hp@redhat.com>
114 * dbus/dbus-userdb-util.c: split out part of dbus-userdb.c
116 * dbus/dbus-sysdeps.c (_dbus_uid_from_string): move here to pave
117 way for stripping down dbus-userdb.c stuff included in libdbus.
118 Rename _dbus_parse_uid for consistency.
120 2005-01-16 Havoc Pennington <hp@redhat.com>
122 * dbus/dbus-internals.c (_dbus_real_assert): print the function
123 name the assertion failed in
125 * dbus/dbus-internals.h (_dbus_return_if_fail)
126 (_dbus_return_val_if_fail): assert that the name of the function
127 containing the check doesn't start with '_', since we only want to
128 use checks on public functions
130 * dbus/dbus-connection.c (_dbus_connection_ref_unlocked): change
133 * dbus/dbus-marshal-header.c (_dbus_header_set_field_basic):
134 change checks to asserts for private function
136 * dbus/dbus-message.c (_dbus_message_set_serial): checks
137 to asserts for private function
139 * dbus/dbus-marshal-recursive.c (skip_one_complete_type): remove
140 broken assertion that was breaking make check
141 (_dbus_type_reader_array_is_empty): remove this rather than fix
142 it, was only used in assertions
144 2005-01-16 Havoc Pennington <hp@redhat.com>
146 * test/unused-code-gc.py: hacky script to find code that's used
147 only by the bus (not libdbus) or used only by tests or not used at
148 all. It has some false alarms, but looks like we can clean up a
149 lot of size from libdbus.
151 * dbus/dbus-sysdeps.c, dbus/dbus-sysdeps-utils.c,
152 dbus/Makefile.am: initially move 10K of binary size out of libdbus
154 2005-01-16 Havoc Pennington <hp@redhat.com>
156 * Add and fix docs according to Doxygen warnings throughout
159 * dbus/dbus-marshal-recursive.c
160 (_dbus_type_reader_array_is_empty): change this to just call
161 array_reader_get_array_len() and make it static
163 * dbus/dbus-message.c (dbus_message_iter_get_element_type): rename
165 (dbus_message_iter_init_append): rename from append_iter_init
167 * dbus/dbus-marshal-recursive.c
168 (_dbus_type_reader_get_element_type): rename from
169 _dbus_type_reader_get_array_type
171 2005-01-15 Havoc Pennington <hp@redhat.com>
173 * test/glib/test-profile.c (with_bus_server_filter): fix crash
175 * dbus/dbus-marshal-basic.c (_dbus_unpack_uint32): inline as macro
176 when DBUS_DISABLE_ASSERT
177 (_dbus_marshal_set_basic): be sure we align for the string length
179 * dbus/dbus-marshal-recursive.c (skip_one_complete_type): make
182 * dbus/dbus-string.c (_dbus_string_get_const_data_len): add an
184 (_dbus_string_set_byte): provide inline macro version
186 2005-01-15 Havoc Pennington <hp@redhat.com>
188 * Land the new message args API and type system.
190 This patch is huge, but the public API change is not
191 really large. The set of D-BUS types has changed somewhat,
192 and the arg "getters" are more geared toward language bindings;
193 they don't make a copy, etc.
195 There are also some known issues. See these emails for details
197 http://lists.freedesktop.org/archives/dbus/2004-December/001836.html
198 http://lists.freedesktop.org/archives/dbus/2005-January/001922.html
200 * dbus/dbus-marshal-*: all the new stuff
202 * dbus/dbus-message.c: basically rewritten
204 * dbus/dbus-memory.c (check_guards): with "guards" enabled, init
205 freed blocks to be all non-nul bytes so using freed memory is less
208 * dbus/dbus-internals.c (_dbus_test_oom_handling): add
209 DBUS_FAIL_MALLOC=N environment variable, so you can do
210 DBUS_FAIL_MALLOC=0 to skip the out-of-memory checking, or
211 DBUS_FAIL_MALLOC=10 to make it really, really, really slow and
214 * qt/message.cpp: port to the new message args API
215 (operator<<): use str.utf8() rather than str.unicode()
216 (pretty sure this is right from the Qt docs?)
218 * glib/dbus-gvalue.c: port to the new message args API
220 * bus/dispatch.c, bus/driver.c: port to the new message args API
222 * dbus/dbus-string.c (_dbus_string_init_const_len): initialize the
223 "locked" flag to TRUE and align_offset to 0; I guess we never
224 looked at these anyhow, but seems cleaner.
226 * dbus/dbus-string.h (_DBUS_STRING_ALLOCATION_PADDING):
227 move allocation padding macro to this header; use it to implement
228 (_DBUS_STRING_STATIC): ability to declare a static string.
230 * dbus/dbus-message.c (_dbus_message_has_type_interface_member):
231 change to return TRUE if the interface is not set.
233 * dbus/dbus-string.[hc]: move the D-BUS specific validation stuff
234 to dbus-marshal-validate.[hc]
236 * dbus/dbus-marshal-basic.c (_dbus_type_to_string): move here from
239 * dbus/Makefile.am: cut over from dbus-marshal.[hc]
240 to dbus-marshal-*.[hc]
242 * dbus/dbus-object-tree.c (_dbus_decompose_path): move this
243 function here from dbus-marshal.c
245 2005-01-12 Joe Shaw <joeshaw@novell.com>
247 * NEWS: Update for 0.23.
249 * configure.in: Release 0.23.
251 2005-01-12 Joe Shaw <joeshaw@novell.com>
253 * mono/Makefile.am, mono/example/Makefile.am: Always build the
254 dbus DLL with --debug. Clean up after the .mdb files this leaves
257 * mono/doc/Makefile.am: Need to uninstall the docs on "make
260 * mono/Arguments.cs (GetDBusTypeConstructor): If the type
261 is an enum, get the enum's underlying type. Another mono
264 2005-01-11 Joe Shaw <joeshaw@novell.com>
266 Patch from Sjoerd Simons <sjoerd@luon.net>
268 * mono/Makefile.am, mono/example/Makefile.am: Don't redefine
269 DESTDIR. It breaks stuff.
271 2005-01-11 Joe Shaw <joeshaw@novell.com>
273 Patch from Tambet Ingo <tambet@ximian.com>
275 * mono/DBusType/Array.cs (Get): Get the underlying element type by
276 calling type.GetElementType(). The code previously depended on
277 broken Mono behavior, which was fixed in Mono 1.1.3.
279 * mono/DBusType/Dict.cs (constructor): Fix the parameters for
280 Activator.CreateInstance() so that the class's constructor is
281 called with the right parameters.
283 2005-01-11 Joe Shaw <joeshaw@novell.com>
285 Patch from Timo Teräs <ext-timo.teras@nokia.com>
287 * dbus/dbus-connection.c
288 (_dbus_connection_queue_received_message_link): Call
289 _dbus_connection_remove_timeout() instead of the _locked()
290 variant, since it's always called from
291 _dbus_connection_handle_watch(), which handles the locking.
292 Removed the _locked() variant since it's no longer used.
294 2005-01-03 Havoc Pennington <hp@redhat.com>
296 * dbus/dbus-internals.h: I'm an idiot, _dbus_assert certainly can
299 2004-12-26 Havoc Pennington <hp@redhat.com>
301 * dbus/dbus-internals.h: add _DBUS_GNUC_NORETURN to _dbus_assert
303 2005-01-03 Havoc Pennington <hp@redhat.com>
305 * dbus/dbus-sysdeps.c (_dbus_sysdeps_test): fix using == on
308 * dbus/dbus-string.c (_dbus_string_insert_alignment): new function
310 2005-01-02 Havoc Pennington <hp@redhat.com>
312 * dbus/dbus-internals.h (_DBUS_ALIGN_OFFSET): new macro
314 2005-01-01 Havoc Pennington <hp@redhat.com>
316 * configure.in: add -Wfloat-equal
318 2005-01-01 Havoc Pennington <hp@redhat.com>
320 * dbus/dbus-sysdeps.h: add _DBUS_DOUBLES_BITWISE_EQUAL macro,
321 for a variety of reasons '==' doesn't do this.
323 2004-12-31 Havoc Pennington <hp@redhat.com>
325 * dbus/dbus-string.c (_dbus_string_equal_substrings): new function
328 2004-12-30 John (J5) Palmieri <johnp@redhat.com>
330 * python/dbus.py: s/ACTIVATION_REPLY_ACTIVE/ACTIVATION_REPLY_ACTIVATED
332 2004-12-30 John (J5) Palmieri <johnp@redhat.com>
334 * python/dbus_bindings.pyx.in: Change DBUS_ACTIVATION_REPLY_ACTIVATED
335 and DBUS_ACTIVATION_REPLY_ALREADY_ACTIVE to match the values in
336 dbus-protocol.h. Because they are defines and not enums they are not
339 2004-12-26 John (J5) Palmieri <johnp@redhat.com>
341 * python/dbus_bindings.pyx.in (bus_activate_service): Bind
342 dbus_bus_activate_service
344 * python/dbus.py (Bus.activate_service): activate a service on the
347 2004-12-24 Havoc Pennington <hp@redhat.com>
349 * test/decode-gcov.c: change to use .gcno and .gcda files, but the
350 file format has also changed and I haven't adapted to that yet
352 * Makefile.am: load .gcno files from latest gcc
354 2004-12-23 John (J5) Palmieri <johnp@redhat.com>
355 * Patch from Rob Taylor <robtaylor@fastmail.fm>
357 * python/dbus_bindings.pyx.in (bus_get_unix_user): New
360 * python/dbus.py (get_unix_user): Added binding to
361 call dbus_bindings.bus_get_unix_user
363 * python/extract.py: Modified the proto_pat regex to
366 2004-12-21 Olivier Andrieu <oliv__a@users.sourceforge.net>
368 * dbus/make-dbus-glib-error-enum.sh: omit the function keyword for
369 better POSIX compliance.
371 2004-12-19 Havoc Pennington <hp@redhat.com>
373 * dbus/dbus-string.c (_dbus_string_insert_4_aligned)
374 (_dbus_string_insert_8_aligned): new functions
376 * dbus/dbus-string.c (_dbus_string_alloc_space): new function
378 2004-12-18 Havoc Pennington <hp@redhat.com>
380 * dbus/dbus-string.c (_dbus_string_validate_ascii): use ISASCII
383 * dbus/dbus-message.c: fix a comment, and add a still-unused
384 not-implemented function
386 * dbus/dbus-marshal.h: fix comment
388 * dbus/dbus-internals.h (_DBUS_ISASCII): new macro
390 2004-12-17 Joe Shaw <joeshaw@novell.com>
392 * mono/DBusType/Byte.cs, mono/DBusType/Int32.cs,
393 mono/DBusType/Int64.cs, mono/DBusType/UInt32.cs,
394 mono/DBusType/UInt64.cs: Use Enum.GetUnderlyingType() instead of
395 Type.UnderlyingSystemType to get the actual system type
396 underneath. This code previously depended on the broken Mono
397 behavior, which was fixed in 1.1.3.
399 2004-11-27 Havoc Pennington <hp@redhat.com>
401 * dbus/dbus-string.h (_dbus_string_get_byte): inline when asserts
403 (_dbus_string_get_const_data): inline when asserts are disabled
405 * dbus/dbus-message.c: record the _dbus_current_generation of
406 creation so we can complain if dbus_shutdown() is used improperly.
407 Do this only if checks are enabled.
409 * dbus/dbus-connection.c: ditto
411 2004-11-26 Havoc Pennington <hp@redhat.com>
413 * test/glib/test-profile.c: add with_bus mode to profile echoes
414 that go through the bus.
416 * test/glib/run-test.sh: add ability to run test-profile
418 * bus/dbus-daemon-1.1.in: fix to say that SIGHUP causes partial
421 2004-11-26 Havoc Pennington <hp@redhat.com>
423 * test/glib/test-profile.c: clean up how the fake_malloc_overhead
424 thing was implemented
426 2004-11-26 Havoc Pennington <hp@redhat.com>
428 * test/glib/test-profile.c: tweak a bit, add support for some
429 made-up minimal malloc overhead with plain sockets, since in
430 real life some sort of buffers are unavoidable thus we could
431 count them in the theoretical best case
433 2004-11-26 Havoc Pennington <hp@redhat.com>
435 * dbus/dbus-message.c (dbus_message_cache_or_finalize): fix bug
436 where I was trying to cache one too many messages
438 2004-11-26 Havoc Pennington <hp@redhat.com>
440 * dbus/dbus-message.c: reimplement message cache as an array which
441 makes the cache about twice as fast and saves maybe 1.5% overall
443 2004-11-26 Havoc Pennington <hp@redhat.com>
445 * dbus/dbus-threads.c (init_global_locks): forgot to put the
446 message cache lock here
448 2004-11-26 Havoc Pennington <hp@redhat.com>
450 * dbus/dbus-message.c (struct DBusMessage): put the locked bit and
451 the "char byte_order" next to each other to save 4 bytes
452 (dbus_message_new_empty_header): reduce preallocation, since the
453 message cache should achieve a similar effect
454 (dbus_message_cache_or_finalize, dbus_message_get_cached): add a
455 message cache that keeps a few DBusMessage around in a pool,
456 another 8% speedup or so.
458 * dbus/dbus-dataslot.c (_dbus_data_slot_list_clear): new function
460 2004-11-25 Havoc Pennington <hp@redhat.com>
462 * dbus/dbus-transport-unix.c (unix_do_iteration): if we're going
463 to write, without reading or blocking, try it before the poll()
464 and skip the poll() if nothing remains to write. This is about a
465 3% speedup in the echo client/server
467 2004-11-25 Havoc Pennington <hp@redhat.com>
469 The primary change here is to always write() once before adding
470 the write watch, which gives us about a 10% performance increase.
472 * dbus/dbus-transport-unix.c: a number of modifications to cope
473 with removing messages_pending
474 (check_write_watch): properly handle
475 DBUS_AUTH_STATE_WAITING_FOR_MEMORY; adapt to removal of
476 messages_pending stuff
477 (check_read_watch): properly handle WAITING_FOR_MEMORY and
479 (unix_handle_watch): after writing, see if the write watch can be
481 (unix_do_iteration): assert that write_watch/read_watch are
482 non-NULL rather than testing that they aren't, since they
483 aren't allowed to be NULL. check_write_watch() at the end so
484 we add the watch if we did not finish writing (e.g. got EAGAIN)
486 * dbus/dbus-transport-protected.h: remove messages_pending call,
487 since it resulted in too much inefficient watch adding/removing;
488 instead we now require that the transport user does an iteration
489 after queueing outgoing messages, and after trying the first
490 write() we add a write watch if we got EAGAIN or exceeded our
491 max bytes to write per iteration setting
493 * dbus/dbus-string.c (_dbus_string_validate_signature): add this
496 * dbus/dbus-server-unix.c (unix_finalize): the socket name was
497 freed and then accessed, valgrind flagged this bug, fix it
499 * dbus/dbus-message.c: fix several bugs where HEADER_FIELD_LAST was taken
500 as the last valid field plus 1, where really it is equal to the
501 last valid field. Corrects some message corruption issues.
503 * dbus/dbus-mainloop.c: verbosity changes
505 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): handle OOM
506 instead of aborting in one of the test codepaths
508 * dbus/dbus-internals.c (_dbus_verbose_real): fix a bug that
509 caused not printing the pid ever again if a verbose was missing
510 the newline at the end
511 (_dbus_header_field_to_string): add HEADER_FIELD_SIGNATURE
513 * dbus/dbus-connection.c: verbosity changes;
514 (dbus_connection_has_messages_to_send): new function
515 (_dbus_connection_message_sent): no longer call transport->messages_pending
516 (_dbus_connection_send_preallocated_unlocked): do one iteration to
517 try to write() immediately, so we can avoid the write watch. This
518 is the core purpose of this patchset
519 (_dbus_connection_get_dispatch_status_unlocked): if disconnected,
520 dump the outgoing message queue, so nobody will get confused
521 trying to send them or thinking stuff is pending to be sent
523 * bus/test.c: verbosity changes
525 * bus/driver.c: verbosity/assertion changes
527 * bus/dispatch.c: a bunch of little tweaks to get it working again
528 because this patchset changes when/where you need to block.
530 2004-11-23 Havoc Pennington <hp@redhat.com>
532 * test/glib/test-profile.c: modify to accept a plain_sockets
533 argument in which case it will bench plain sockets instead of
534 libdbus, for comparison purposes.
536 2004-11-22 Havoc Pennington <hp@redhat.com>
538 * test/glib/test-profile.c (N_CLIENT_THREADS): run multiple
539 threads for more time, so sysprof can get a grip on it.
541 * dbus/dbus-string.c (_dbus_string_validate_utf8): remove
544 2004-11-13 Havoc Pennington <hp@redhat.com>
546 * test/glib/test-profile.c: fix this thing up a bit
548 * dbus/dbus-message.c (dbus_message_new_empty_header): increase
549 preallocation sizes by a fair bit; not sure if this will be an
550 overall performance win or not, but it does reduce reallocs.
552 * dbus/dbus-string.c (set_length, reallocate_for_length): ignore
553 the test hack that forced constant realloc if asserts are
554 disabled, so we can profile sanely. Sprinkle in some
555 _DBUS_UNLIKELY() which are probably pointless, but before I
556 noticed the real performance problem I put them in.
557 (_dbus_string_validate_utf8): micro-optimize this thing a little
558 bit, though callgrind says it didn't help; then special-case
559 ascii, which did help a lot; then be sure we detect nul bytes as
560 invalid, which is a bugfix.
561 (align_length_then_lengthen): add some more _DBUS_UNLIKELY
562 superstition; use memset to nul the padding instead of a manual
564 (_dbus_string_get_length): inline this as a
565 macro; it showed up in the profile because it's used for loop
568 2004-11-10 Colin Walters <walters@verbum.org>
570 * dbus/dbus-spawn.c (check_babysit_events): Handle EINTR,
573 2004-11-09 Colin Walters <walters@verbum.org>
575 * dbus/dbus-string.c (_dbus_string_get_length): New
576 function, writes DBusString to C buffer.
578 * dbus/dbus-string.h: Prototype it.
580 * dbus/dbus-message.c (dbus_message_type_to_string): New
581 function, converts message type into C string.
583 * dbus/dbus-message.h: Prototype it.
585 * bus/selinux.c (bus_selinux_check): Take source pid,
586 target pid, and audit data. Pass audit data to
588 (log_audit_callback): New function, appends extra
590 (bus_selinux_allows_acquire_service): Also take
591 service name, add it to audit data.
592 (bus_selinux_allows_send): Also take message
593 type, interface, method member, error name,
594 and destination, and add them to audit data.
595 (log_cb): Initialize func_audit.
597 * bus/selinux.h (bus_selinux_allows_acquire_service)
598 (bus_selinux_allows_send): Update prototypes
600 * bus/services.c (bus_registry_acquire_service): Pass
601 service name to bus_selinux_allows_acquire_service.
603 * bus/bus.c (bus_context_check_security_policy): Pass
604 additional audit data. Move assignment of dest
607 2004-11-07 Colin Walters <walters@verbum.org>
609 * dbus/dbus-transport-unix.c (do_authentication): Always
610 initialize auth_completed.
612 2004-11-07 Colin Walters <walters@verbum.org>
614 * bus/bus.c (load_config): Break into three
615 separate functions: process_config_first_time_only,
616 process_config_every_time, and process_config_postinit.
617 (process_config_every_time): Move call of
618 bus_registry_set_service_context_table into
619 process_config_postinit.
620 (process_config_postinit): New function, does
621 any processing that needs to happen late
622 in initialization (and also on reload).
623 (bus_context_new): Instead of calling load_config,
624 open config parser here and call process_config_first_time_only
625 and process_config_every_time directly. Later, after
626 we have forked but before changing UID,
627 invoke bus_selinux_full_init, and then call
628 process_config_postinit.
629 (bus_context_reload_config): As in bus_context_new,
630 load parse file inside here, and call process_config_every_time
631 and process_config_postinit.
633 * bus/services.h, bus/services.c
634 (bus_registry_set_service_context_table): Rename
635 from bus_registry_set_sid_table. Take string hash from config
636 parser, and convert them here into SIDs.
638 * bus/config-parser.c (struct BusConfigParser): Have
639 config parser only store a mapping of service->context
641 (merge_service_context_hash): New function.
642 (merge_included): Merge context string hashes instead
643 of using bus_selinux_id_table_union.
644 (bus_config_parser_new): Don't use bus_selinux_id_table_new;
645 simply create a new string hash.
646 (bus_config_parser_unref): Unref it.
647 (start_selinux_child): Simply insert strings into hash,
648 don't call bus_selinux_id_table_copy_over.
650 * bus/selinux.h, bus/selinux.c (bus_selinux_id_table_union)
651 (bus_selinux_id_table_copy_over): Delete.
653 2004-11-03 Colin Walters <walters@verbum.org>
655 * bus/selinux.c (bus_selinux_pre_init): Kill some unused
658 2004-11-03 Colin Walters <walters@verbum.org>
660 * bus/test-main.c (test_pre_hook): Fix test logic,
661 thanks Joerg Barfurth <Joerg.Barfurth@Sun.COM>.
663 2004-11-02 Colin Walters <walters@redhat.com>
665 * bus/selinux.c (bus_selinux_init): Split into two functions,
666 bus_selinux_pre_init and bus_selinux_post_init.
667 (bus_selinux_pre_init): Just determine whether SELinux is
669 (bus_selinux_post_init): Do everything else.
671 * bus/main.c (main): Call bus_selinux_pre_init before parsing
672 config file, and bus_selinux_post_init after. This ensures that
673 we don't lose the policyreload notification thread that
674 bus_selinux_init created before forking previously.
676 * bus/test-main.c (test_pre_hook): Update for split.
678 2004-10-31 Owen Fraser-Green <owen@discobabe.net>
680 Patch from Johan Fischer <linux@fischaz.com>
682 * mono/doc/Makefile.am (install-data-local): Added directory
685 2004-10-29 Colin Walters <walters@redhat.com>
687 * dbus/dbus-sysdeps.h (_dbus_become_daemon): Also take
688 parameter for fd to write pid to.
690 * dbus/dbus-sysdeps.c (_dbus_become_daemon): Implement it.
692 * bus/bus.c (bus_context_new): Pass print_pid_fd
693 to _dbus_become_daemon (bug #1720)
695 2004-10-29 Colin Walters <walters@redhat.com>
697 Patch from Ed Catmur <ed@catmur.co.uk>
699 * mono/doc/Makefile.am (install-data-local): Handle
702 2004-10-29 Colin Walters <walters@redhat.com>
704 * bus/.cvsignore, qt/.cvsignore: Update.
706 2004-10-29 Colin Walters <walters@redhat.com>
708 Patch from Kristof Vansant <de_lupus@pandora.be>
710 * configure.in: Detect Slackware.
711 * bus/Makefile.am (SCRIPT_IN_FILES): Add rc.messagebus.in.
712 * bus/rc.messagebus.in: New file.
714 2004-10-29 Colin Walters <walters@redhat.com>
716 * tools/dbus-monitor.c (filter_func): Return
717 DBUS_HANDLER_RESULT_HANDLED in filter function
719 http://freedesktop.org/pipermail/dbus/2004-August/001433.html
721 2004-10-29 Colin Walters <walters@redhat.com>
723 Patch from Matthew Rickard <mjricka@epoch.ncsc.mil>
725 * bus/services.c (bus_registry_acquire_service):
726 Correctly retrieve service name from DBusString
729 2004-10-29 Colin Walters <walters@redhat.com>
731 * dbus/dbus-glib.h: Update documentation to not
732 refer to internal APIs.
734 2004-10-27 Joe Shaw <joeshaw@novell.com>
736 * mono/Arguments.cs (GetDBusTypeConstructor):
737 type.UnderlyingSystemType will return "System.Byte" if you do it
738 on "byte[]", which is not what we want. So check the type.IsArray
739 property and use System.Array instead.
741 2004-10-25 John (J5) Palmieri <johnp@redhat.com>
743 * dbus/dbus-sysdeps.c (fill_user_info): On errors do not free
744 the DBusUserInfo structure since this is passed into the function.
745 This would cause a double free when the function that allocated
746 the structure would try to free it when an error occured.
748 * (bus/session.conf.in, bus/Makefile.am, dbus/configure.in):
749 use /usr/share/dbus-1/services instead of /usr/lib/dbus-1.0/services
750 for service activation to avoid 32bit/64bit parallel install issues
752 2004-10-21 Colin Walters <walters@verbum.org>
754 * AUTHORS: Fix my email address, the @gnu.org one
755 has been bouncing for some time. Also add J5.
757 2004-10-21 Colin Walters <walters@verbum.org>
759 * dbus/dbus-transport-unix.c (do_authentication): Return
760 authentication status to callers.
761 (unix_handle_watch): If we completed authentication this round,
762 don't do another read. Instead wait until the next iteration,
763 after we've read any pending data in the auth buffer.
764 (unix_do_iteration): Ditto.
765 (unix_handle_watch): Updated for new do_authentication prototype.
767 2004-10-18 Colin Walters <walters@verbum.org>
769 * bus/selinux.c (bus_selinux_enabled): Handle
770 --disable-selinux case.
772 2004-10-18 Colin Walters <walters@verbum.org>
774 * bus/selinux.h: Add bus_selinux_enabled.
776 * bus/selinux.c (bus_selinux_enabled): Implement it.
778 * bus/config-parser.c (struct include): Add
779 if_selinux_enabled member.
780 (start_busconfig_child): Parse if_selinux_enabled
781 attribute for include.
782 (bus_config_parser_content): Handle it.
784 * bus/session.conf.in, bus/system.conf.in: Add
785 inclusion of context mapping to default config files;
786 conditional on SELinux being enabled.
788 * doc/busconfig.dtd: Add to if_selinux_enabled to default DTD.
790 * test/data/invalid-config-files/badselinux-1.conf,
791 test/data/invalid-config-files/badselinux-2.conf:
792 Test files for bad syntax.
794 2004-10-17 Colin Walters <walters@verbum.org>
796 * dbus/dbus-memory.c (_dbus_initialize_malloc_debug, check_guards)
797 (dbus_malloc, dbus_malloc0, dbus_realloc): Fix up printf
798 format specifier mismatches.
800 2004-10-07 Olivier Andrieu <oliv__a@users.sourceforge.net>
802 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): fix an incorrect
805 * glib/dbus-dbus-gmain.c (dbus_g_bus_get): do not mangle NULL
806 pointer (bug #1540, Leonardo Boiko).
808 2004-09-28 Jon Trowbridge <trow@ximian.com>
810 * mono/BusDriver.cs: Changed BusDriver struct to remove
811 the ServiceCreated and ServiceDeleted events and replace them
812 with the new ServiceOwnerChanged event.
814 * mono/example/BusListener.cs: Added a new example program,
815 which listens for and reports any ServiceOwnerChanged events
818 * mono/example/Makefile.am (DESTDIR): Build changes for the
819 new BusListener.cs example.
821 2004-09-27 Olivier Andrieu <oliv__a@users.sourceforge.net>
823 * bus/signals.c (bus_match_rule_parse): validate the components of
824 match rules (bug #1439).
826 * dbus/dbus-bus.c (dbus_bus_add_match): add a missing OOM test.
828 2004-09-24 Olivier Andrieu <oliv__a@users.sourceforge.net>
830 * doc/dbus-specification.xml: document ServiceOwnerChanged
833 * bus/driver.c, bus/driver.h, bus/services.c: Use
834 ServiceOwnerChanged signal instead of ServiceCreated and
837 * bus/dispatch.c: update testcase for the new signal.
839 2004-09-20 Jon Trowbridge <trow@ximian.com>
841 Patch from Nat Friedman <nat@novell.com>
843 * mono/Makefile.am: A number of small build fixes to allow "make
844 distcheck" to succeed.
846 * mono/example/Makefile.am: "make distcheck" fixes.
848 * mono/AssemblyInfo.cs.in: When signing the assembly, look for the
851 * test/Makefile.am: "make distcheck" fixes.
853 2004-09-17 Olivier Andrieu <oliv__a@users.sourceforge.net>
855 * dbus/dbus-sysdeps.c (_dbus_user_at_console): fix memleak in OOM.
857 * doc/busconfig.dtd: update the DTD for the at_console attribute.
859 * bus/driver.c (bus_driver_handle_hello): correctly handle Hello
860 messages after the first one (bug #1389).
862 * bus/dispatch.c (check_double_hello_message): add a test case for
863 the double hello message bug.
864 (check_existent_service_activation): fix check of spawning error.
866 2004-09-16 David Zeuthen <david@fubar.dk>
868 * python/dbus_bindings.pyx.in: Add support for int64 and uint64
870 2004-09-12 David Zeuthen <david@fubar.dk>
872 Patch from Kay Sievers <kay.sievers@vrfy.org>
874 * bus/bus.c (bus_context_new):
878 Add commandline option --nofork to override configuration file
881 2004-09-09 Olivier Andrieu <oliv__a@users.sourceforge.net>
883 * dbus/dbus-*.h: remove the ; after DBUS_(BEGIN|END)_DECLS. Some C
884 compilers don't like it (bug #974).
886 2004-09-04 Harald Fernengel <harry@kdevelop.org>
888 * qt/connection.*: Applied patch by Jérôme Lodewyck
889 <lodewyck@clipper.ens.fr> to integrate an existing
890 connection into the Qt eventloop
892 2004-08-30 Jon Trowbridge <trow@ximian.com>
894 * mono/BusDriver.cs: Added. This is a class for interacting with
895 the org.freedesktop.DBus service.
897 * mono/Message.cs: Added a mechanism to expose the message that is
898 currently being dispatched via the static Message.Current
899 property. Added Message.Sender and Message.Destination
902 * mono/Handler.cs: Expose the dispatched message via
903 Message.Current when handling method calls.
905 * mono/Service.cs: Expose the dispatched message via
906 Message.Current when handling signal emissions.
908 * mono/Connection.cs: Bind dbus_bus_get_base_service via the
909 Connection.BaseService property.
911 2004-08-28 Havoc Pennington <hp@redhat.com>
913 * dbus/dbus-userdb.c (_dbus_is_console_user): remove unused variable
915 More fixes from Steve Grubb
917 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): fix fd leak
918 (_dbus_listen_tcp_socket): fix fd leak
920 * dbus/dbus-spawn.c (read_pid, read_ints): move the "again:" for
921 EINTR to a bit lower in the code
923 2004-08-26 Jon Trowbridge <trow@ximian.com>
925 * bus/driver.c (bus_driver_handle_service_exists): Respond with
926 TRUE if we are inquiring about the existence of the built-in
927 org.freedesktop.DBus service.
929 2004-08-25 John Palmieri <johnp@redhat.com>
930 * bus/config-parser.c:
931 (struct PolicyType): Add POLICY_CONSOLE
932 (struct Element.d.policy): s/gid_or_uid/gid_uid_or_at_console
933 (start_busconfig_child): Sets up console element when
934 <policy at_console=""> is encountered in a policy file
935 (append_rule_from_element): Convert console elements to console
939 (bus_policy_create_client_policy): Add console rules to the client
940 policy based on if the client is at the console
941 (bus_policy_append_console_rule): New function for adding a
942 console rule to a policy
943 (bus_policy_merge): Handle console rule merging
945 * dbus/dbus-sysdeps.h: Added the DBUS_CONSOLE_DIR constant
946 where we check for console user files
948 * dbus/dbus-sysdeps.c:
949 (_dbus_file_exists): New function which checks if the given
951 (_dbus_user_at_console): New function which does the system
952 specific process of checking if the user is at the console
954 * dbus/dbus-userdb.c:
955 (_dbus_is_console_user): New function converts a UID to user name
956 and then calls the system specific _dbus_user_at_console to
957 see if the user is at the console and therefor a console user
959 2004-08-25 Olivier Andrieu <oliv__a@users.sourceforge.net>
961 * bus/config-parser.c (set_limit):
962 * bus/dbus-daemon-1.1.in:
963 * test/data/valid-config-files/many-rules.conf: set the
964 max_match_rules_per_connection limt from the config file.
966 * doc/busconfig.dtd: update the DTD.
968 * bus/driver.c: remove some unused variables.
970 2004-08-24 Mikael Hallendal <micke@imendio.com>
972 * dbus/dbus-glib-lowlevel.h: Removed dbus_bus_get_with_g_main since
973 it's been replaced by dbus_g_bus_get
975 2004-08-23 Colin Walters <walters@redhat.com>
977 Updated SELinux support from Matthew Rickard <mjricka@epoch.ncsc.mil>
979 * bus/selinux.h: Prototype bus_selinux_get_policy_root.
981 * bus/selinux.c: Create a thread for policy reload notification.
982 (bus_selinux_get_policy_root): Implement.
984 * bus/config-parser.c (start_busconfig_child)
985 (bus_config_parser_content): Support SELinux-root relative
988 * configure.in <HAVE_SELINUX>: Add -lpthread.
990 * bus/test-main.c (test_pre_hook, test_post_hook): New.
991 (test_post_hook): Move memory checking into here.
992 (test_pre_hook, test_post_hook): Move SELinux checks in
993 here, but conditional on a DBUS_TEST_SELINUX environment
994 variable. Unfortunately we can't run the SELinux checks
995 as a normal user, since they won't have any permissions
996 for /selinux. So this will have to be tested manually
997 for now, until we have virtualization for most of
1000 2004-08-23 Havoc Pennington <hp@redhat.com>
1002 * dbus/dbus-sysdeps.c (_dbus_change_identity): add setgroups() to
1003 drop supplementary groups, suggested by Steve Grubb
1005 2004-08-20 Colin Walters <walters@redhat.com>
1007 * bus/config-parser.c (start_busconfig_child): Remove some unused
1010 * bus/selinux.c (bus_selinux_id_table_insert): Avoid compiler
1013 2004-08-17 Joe Shaw <joeshaw@novell.com>
1015 * configure.in: If --enable-mono is passed in, if we can't find
1018 * mono/Makefile.am: Use /gacutil to install assemblies into the
1021 2004-08-12 Havoc Pennington <hp@redhat.com>
1023 * NEWS: update for 0.22
1025 * configure.in: release 0.22
1027 2004-08-11 Colin Walters <walters@redhat.com>
1029 * tools/dbus-send.c (main, usage): Add --reply-timeout
1032 2004-08-10 Olivier Andrieu <oliv__a@users.sourceforge.net>
1034 * bus/bus.c (process_config_first_time_only): get rid of an unused
1035 DBusError that was causing a memoy leak (bug #989).
1037 * dbus/dbus-keyring.c, dbus/dbus-message.c:
1038 fix compilation on Solaris/Forte C (bug #974)
1040 * bus/main.c (main): plug two minuscule memleaks.
1042 2004-08-10 Havoc Pennington <hp@redhat.com>
1044 * doc/dbus-tutorial.xml: add some more info on GLib bindings
1046 2004-08-09 Havoc Pennington <hp@redhat.com>
1048 * COPYING: switch to Academic Free License version 2.1 instead of
1049 2.0, to resolve complaints about patent termination clause.
1051 2004-07-31 John (J5) Palmieri <johnp@redhat.com>
1053 * README: added documentation for the --enable-python
1056 2004-07-31 Olivier Andrieu <oliv__a@users.sourceforge.net>
1058 * bus/config-parser.c (bus_config_parser_new): fix an invalid
1059 _unref in the SELinux support.
1061 * doc/busconfig.dtd: update DTD for SELinux support.
1063 * bus/config-loader-libxml.c: fix error handler and parser
1064 initialisation/cleanup. OOM test now works with libxml2 HEAD.
1066 * configure.in: remove the warning about libxml2.
1068 * dbus/dbus-bus.c: silence doxygen warning.
1070 2004-07-31 Colin Walters <walters@redhat.com>
1072 * configure.in: Move #error in SELinux check to its own line.
1074 2004-07-31 Olivier Andrieu <oliv__a@users.sourceforge.net>
1076 * dbus/dbus-internals.h (_DBUS_SET_OOM):
1077 * bus/utils.h (BUS_SET_OOM): use dbus_error_set_const instead of
1080 * bus/dispatch.c (check_send_exit_to_service): fix the test case,
1081 broken by the change in the _SET_OOM macros.
1083 2004-07-31 Colin Walters <walters@redhat.com>
1085 * bus/selinux.c <HAVE_SELINUX>: Include utils.h to get
1088 2004-07-31 Colin Walters <walters@redhat.com>
1090 * configure.in: Use AC_TRY_COMPILE instead of AC_EGREP_HEADER
1091 to correctly detect DBUS__ACQUIRE_SVC. Also add an
1094 2004-07-24 Havoc Pennington <hp@redhat.com>
1096 SELinux support from Matthew Rickard <mjricka@epoch.ncsc.mil>
1098 * bus/selinux.c, bus/selinux.h: new file encapsulating selinux
1101 * configure.in: add --enable-selinux
1103 * bus/policy.c (bus_policy_merge): add FIXME to a comment
1105 * bus/main.c (main): initialize and shut down selinux
1107 * bus/connection.c: store SELinux ID on each connection, to avoid
1108 repeated getting of the string context and converting it into
1111 * bus/bus.c (bus_context_get_policy): new accessor, though it
1113 (bus_context_check_security_policy): check whether the security
1114 context of sender connection can send to the security context of
1115 recipient connection
1117 * bus/config-parser.c: add parsing for <selinux> and <associate>
1119 * dbus/dbus-transport.c (_dbus_transport_get_unix_fd): to
1120 implement dbus_connection_get_unix_fd()
1122 * dbus/dbus-connection.c (dbus_connection_get_unix_fd): new
1123 function, used by the selinux stuff
1125 2004-07-29 Olivier Andrieu <oliv__a@users.sourceforge.net>
1127 * bus/config-loader-libxml.c: complete the implementation of
1128 libxml backend for config file loader. Doesn't work with full OOM
1131 * configure.in: change error when selecting libxml into a warning.
1133 * test/data/invalid-config-files: add two non-well-formed XML
1136 * glib/Makefile.am: libdbus_gtool always uses expat, not libxml.
1138 * dbus/dbus-transport-unix.c (unix_handle_watch): do not
1139 disconnect in case of DBUS_WATCH_HANGUP, several do_reading() may
1140 be necessary to read all the buffer. (bug #894)
1142 * bus/activation.c (bus_activation_activate_service): fix a
1143 potential assertion failure (bug #896). Small optimization in the
1144 case of auto-activation messages.
1146 * dbus/dbus-message.c (verify_test_message, _dbus_message_test):
1147 add test case for byte-through-vararg bug (#901). patch by Kimmo
1150 2004-07-28 Anders Carlsson <andersca@gnome.org>
1153 * python/dbus_bindings.pyx.in:
1154 Add dbus.init_gthreads (), allow emit_signal to pass
1155 arguments to the signal.
1157 2004-07-24 Havoc Pennington <hp@redhat.com>
1159 * AUTHORS: add some people, not really comprehensively, let me
1160 know if I missed you
1162 2004-07-24 Havoc Pennington <hp@redhat.com>
1164 * Makefile.am (DIST_SUBDIRS): add DIST_SUBDIRS, problem solved by
1167 * test/Makefile.am (DIST_SUBDIRS): here also
1169 2004-07-22 Olivier Andrieu <oliv__a@users.sourceforge.net>
1171 * dbus/dbus-sysdeps.c (fill_user_info): fix inexistent label name,
1172 breaking build on Solaris, reported by Farhad Saberi on the ML.
1174 * dbus/dbus-message.c (dbus_message_append_args_valist): fix the
1175 va_arg invocation to account for integer promotion in the case of
1176 DBUS_TYPE_BYTE (unsigned char is promoted to int). (bug #901)
1178 * bus/services.c (bus_service_remove_owner): fix bug #902, use
1179 _dbus_list_get_first_link, not _dbus_list_get_first.
1181 * dbus/dbus-bus.c (dbus_bus_service_exists): plug a memory leak.
1183 * dbus/dbus-object-tree.c (free_subtree_recurse): always null
1184 handler functions so that the asserts in _dbus_object_subtree_unref
1187 * dbus/dbus-transport-unix.c (do_reading):
1188 _dbus_transport_queue_messages return value is of type
1189 dbus_bool_t, not DBusDispatchStatus.
1191 2004-07-19 David Zeuthen <david@fubar.dk>
1193 * dbus/dbus-protocol.h: Add DBUS_ERROR_UNIX_PROCESS_ID_UNKNOWN
1196 (check_get_connection_unix_user): Debug says GetProperty; but the
1197 method is called GetConnectionUnixUser
1198 (check_get_connection_unix_process_id): New function
1199 (bus_dispatch_test): Actually call check_get_connection_unix_user();
1200 also call check_get_connection_unix_process_id()
1203 (bus_driver_handle_get_connection_unix_process_id): New function,
1204 handles GetConnectionUnixProcessID on the org.freedesktop.DBus
1208 (handle_server_data_external_mech): Set pid from the credentials
1209 obtained from the socket
1211 * dbus/dbus-connection.c:
1212 (dbus_connection_get_unix_process_id): New function
1214 * dbus/dbus-connection.h:
1215 Add prototype for dbus_connection_get_unix_process_id
1217 * dbus/dbus-transport.c:
1218 (_dbus_transport_get_unix_process_id): New function
1220 * dbus/dbus-transport.h:
1221 Add prototype for _dbus_transport_get_unix_process_id
1223 2004-07-19 Olivier Andrieu <oliv__a@users.sourceforge.net>
1225 * dbus/dbus-message.c: Message counter fix, patch by Christian
1226 Hammond <chipx86@gnupdate.org>
1228 2004-07-18 Seth Nickell <seth@gnome.org>
1231 * python/dbus_bindings.pyx.in:
1232 * python/tests/test-client.py:
1234 Add dbus.ByteArray and dbus_bindings.ByteArray
1235 types so that byte streams can be passed back.
1237 Give jdahlin the heaps of credit that are so
1240 2004-07-12 Seth Nickell <seth@gnome.org>
1244 Add message argument to the default object_method_handler
1247 * python/dbus_bindings.pyx.in:
1249 Automatically return NIL when passed an empty list
1250 (we can't pass back a list since lists are typed
1251 and we don't have any idea what type the the client
1252 intended the list to be... :-( )
1254 2004-07-10 Seth Nickell <seth@gnome.org>
1256 * python/examples/Makefile.am:
1258 Fix distcheck breakage caused by new examples.
1260 2004-07-10 Seth Nickell <seth@gnome.org>
1264 Add "message" argument to service-side dbus.Object
1265 methods. This will break existing services written
1266 using the python bindings, but will allow extraction
1267 of all the message information (e.g. who its from).
1269 Add improved "object oriented" signal handling/emission.
1271 * python/examples/example-service.py:
1275 * python/examples/example-signal-emitter.py:
1276 * python/examples/example-signal-recipient.py:
1278 Two new examples that show how to emit and receive
1279 signals using the new APIs.
1281 * python/examples/example-signals.py:
1282 * python/examples/gconf-proxy-service.py:
1283 * python/examples/gconf-proxy-service2.py:
1285 Add "message" argument to service methods.
1287 2004-06-28 Kay Sievers <kay.sievers@vrfy.org>
1289 * bus/driver.c (bus_driver_handle_get_connection_unix_user)
1290 * dbus/bus.c (dbus_bus_get_unix_user)
1291 * doc/dbus-specification.xml: implement GetConnectionUnixUser
1292 method of org.freedesktop.DBus interface.
1294 * bus/dispatch.c: test case
1296 2004-06-23 John (J5) Palmieri <johnp@redhat.com>
1298 * python/Makefile.am: switched include directory from glib/ to dbus/
1299 since dbus-glib.h moved
1301 2004-06-22 Olivier Andrieu <oliv__a@users.sourceforge.net>
1303 * configure.in: prevent building the gcj stuff and libxml loader
1304 since they are broken.
1306 2004-06-20 Havoc Pennington <hp@redhat.com>
1308 * dbus/dbus-glib-error-enum.h: autogenerate the GError enum
1309 codes from the dbus error names
1311 * glib/dbus-glib.h: move to subdir dbus/ since it's included
1312 as dbus/dbus-glib.h and that breakage is now visible due to
1313 including dbus/dbus-glib.h in dbus-glib-lowlevel.h
1315 * glib/dbus-glib.h: s/gproxy/g_proxy/
1317 * dbus/dbus-shared.h: new header to hold stuff shared with
1320 * dbus/dbus-protocol.h (DBUS_ERROR_*): move errors here rather
1323 * glib/dbus-glib.h (dbus_set_g_error): move to
1324 dbus-glib-lowlevel.h
1326 * glib/dbus-glib.h: remove dbus/dbus.h from here; change a bunch
1327 of stuff to enable this
1329 * dbus/dbus-glib-lowlevel.h: put dbus/dbus.h here
1331 * a bunch of other changes with the same basic "separate glib
1332 bindings from dbus.h" theme
1334 2004-06-10 Owen Fraser-Green <owen@discobabe.net>
1336 * dbus-sharp.pc.in: Removed glib-sharp inclusion in Libs.
1338 * python/examples/Makefile.am: Fixed typo in EXTRA_DIST.
1340 2004-06-09 Olivier Andrieu <oliv__a@users.sourceforge.net>
1342 * bus/driver.c, dbus/dbus-bus.c: use BOOLEAN instead of UINT32 for
1343 the reply value of the ServiceExists message.
1345 2004-06-07 John (J5) Palmieri <johnp@redhat.com>
1347 * python/dbus_bindings.pyx.in: No longer need to parse path
1348 elements and pass them as arrays of strings. The C API now
1349 accepts plain path strings.
1350 (_build_parsed_path): removed
1352 2004-06-07 Havoc Pennington <hp@redhat.com>
1354 * doc/TODO: remove auto-activation item since it's done; sort
1355 items by importance/milestone
1357 2004-06-07 Havoc Pennington <hp@redhat.com>
1359 * dbus/dbus-message-builder.c (_dbus_message_data_load): append
1360 random signature when using REQUIRED_FIELDS (this hack won't work
1363 * dbus/dbus-message.c: change the signature to be a header field,
1364 instead of message->signature special-case string. Incremental
1365 step forward. Then we can fix up code to send the signature in the
1366 message, then fix up code to validate said signature, then fix up
1367 code to not put the typecodes inline, etc.
1368 (load_one_message): don't make up the signature after the fact
1369 (decode_header_data): require signature field for the known
1372 * dbus/dbus-marshal.c (_dbus_marshal_string_len): new
1374 * dbus/dbus-protocol.h: add DBUS_HEADER_FIELD_SIGNATURE
1376 2004-06-07 Owen Fraser-Green <owen@discobabe.net>
1378 * mono/DBusType/ObjectPath.cs: Renamed PathName argument to Path
1380 * mono/Handler.cs: Updated to follow new path argument for
1381 (un-)registering objects.
1383 * mono/example/Makefile.am:
1385 * configure.in: Bumped required version for mono and use new -pkg
1388 2004-06-05 Olivier Andrieu <oliv__a@users.sourceforge.net>
1390 * dbus/dbus-connection.h, dbus/dbus-connection.c: have object path
1391 registration functions take the path argument as char* instead of
1394 * dbus/dbus-marshal.h, dbus/dbus-marshal.c (_dbus_decompose_path):
1395 split off the path decompostion part of
1396 _dbus_demarshal_object_path. Some misc. fixes to silence compiler
1399 * glib/dbus-gobject.c, test/test-service.c: update accordingly.
1401 2004-06-02 Kristian Høgsberg <krh@redhat.com>
1403 * dbus/dbus-auth.c: Rewrite auth protocol handling to use a state
1404 machine approach. A state is implemented as a function that
1405 handles incoming events as specified for that state.
1407 * doc/dbus-specification.xml: Update auth protocol state machine
1408 specification to match implementation. Remove some leftover
1411 2004-06-02 Kristian Høgsberg <krh@redhat.com>
1413 * glib/dbus-gproxy.c, glib/dbus-gmain.c, dbus/dbus-string.c,
1414 dbus/dbus-object-tree.c, dbus/dbus-message.c: add comments to
1417 * Doxyfile.in: remove deprecated options.
1419 * dbus/dbus-message-handler.c, dbus/dbus-message-handler.h,
1420 glib/test-thread.h, glib/test-thread-client.c,
1421 glib/test-thread-server.c, glib/test-profile.c,
1422 glib/test-dbus-glib.c: remove these unused files.
1424 2004-06-01 Olivier Andrieu <oliv__a@users.sourceforge.net>
1426 * dbus/dbus-object-tree.c
1427 (_dbus_object_tree_dispatch_and_unlock): fix dispatch for
1428 non-fallback handlers (bug #684).
1429 (_dbus_object_subtree_new): initialize invoke_as_fallback field.
1430 (find_subtree_recurse): report wether the returned subtree is an
1431 exact match or a "fallback" match higher up in the tree.
1432 (object_tree_test_iteration): update test case.
1434 2004-06-01 Seth Nickell <seth@gnome.org>
1436 * python/dbus_bindings.pyx.in:
1437 * python/tests/test-client.py:
1439 Round off basic type support. Add dicts (yay!), and
1440 remaining array types.
1442 Make MessageIter more general so it works for dicts too.
1444 Mark all loop variables as C integers.
1446 2004-05-31 Havoc Pennington <hp@redhat.com>
1448 * glib/dbus-gidl.c (method_info_add_arg): keep args sorted with
1451 * glib/dbus-gobject.c (dbus_type_to_string): move to dbus-gutils.c
1453 * glib/dbus-glib-tool.c (main): set up to have a --self-test
1454 option that runs the tests, and start filling in some code
1455 including for starters just dumping the interfaces to stdout
1457 * glib/Makefile.am (INCLUDES): define DBUS_LOCALEDIR
1459 * test/data/valid-introspection-files/lots-of-types.xml: test of
1460 an example introspection file
1462 * glib/dbus-gparser.c (parser_check_doctype): doctype should be
1465 2004-05-31 Seth Nickell <seth@gnome.org>
1467 * python/dbus_bindings.pyx.in:
1468 * python/tests/test-client.py:
1473 Fix string array memory trashing bug... oops...
1475 2004-05-30 Seth Nickell <seth@gnome.org>
1479 Add a nicer-but-less-flexible alternate API for handling
1480 calls to virtual objects in dbus.ObjectTree.
1482 Screw up the argument order to the dbus.Object constructor
1483 for consistency with dbus.ObjectTree (and to make dbus_methods
1484 optional for future extension)
1486 * python/examples/Makefile.am:
1487 * python/examples/gconf-proxy-service.py:
1488 * python/examples/gconf-proxy-service2.py:
1490 Alternate implementation of gconf-proxy-service using the
1491 nicer dbus.ObjectTree API.
1493 * python/examples/example-service.py:
1494 * python/tests/test-server.py
1496 Reverse the argument order to deal with dbus.Object constructor
1499 2004-05-30 Seth Nickell <seth@gnome.org>
1501 * python/examples/example-client.py:
1502 * python/examples/example-service.py:
1504 Take it back. Lists seem to work but they're broken
1505 in the test suite. Make the base examples use
1508 2004-05-30 Seth Nickell <seth@gnome.org>
1510 * python/dbus_bindings.pyx.in:
1511 * python/tests/test-client.py:
1513 Add some more tests and fix errors that crop up.
1514 Unfortunately, currently it seems like marshalling
1515 and unmarshalling of lists is completely broken :-(
1517 2004-05-30 Seth Nickell <seth@gnome.org>
1519 * python/dbus_bindings.pyx.in:
1521 Add support for ObjectPath type.
1525 Refactor message handling code to a common function.
1527 * python/tests/test-client.py:
1528 * python/tests/test-server.py:
1530 Add tests that check to make sure values of all types
1531 can be echoed from a service w/o mangling.
1533 2004-05-29 Seth Nickell <seth@gnome.org>
1537 Add ObjectTree class which allows implementation
1538 of trees of "virtual" objects. Basically the python
1539 wrapper for "register_fallback".
1541 * python/examples/Makefile.am
1542 * python/examples/gconf-proxy-client.py:
1543 * python/examples/gconf-proxy-service.py:
1545 Implement a simple GConf proxy service that supports
1546 get/set on string and int GConf keys using the ObjectTree.
1548 2004-05-29 Seth Nickell <seth@gnome.org>
1551 * python/examples/example-client.py:
1552 * python/examples/example-service.py:
1553 * python/examples/list-system-services.py:
1555 Add SessionBus, SystemBus and ActivationBus classes
1556 so you don't need to know the special little BUS_TYPE
1559 2004-05-29 Havoc Pennington <hp@redhat.com>
1561 * bus/config-parser.c (process_test_valid_subdir): temporarily
1562 stop testing config parser OOM handling, since expat has issues
1563 http://freedesktop.org/pipermail/dbus/2004-May/001153.html
1565 * bus/dbus-daemon-1.1.in: change requested_reply to
1566 send_requested_reply/receive_requested_reply so we can send the
1567 replies, not just receive them.
1569 * bus/config-parser.c: parse the new
1570 send_requested_reply/receive_requested_reply
1572 * bus/policy.c (bus_client_policy_check_can_send): add
1573 requested_reply argument and use it
1575 * bus/bus.c (bus_context_check_security_policy): pass through
1576 requested_reply status to message send check
1578 * bus/system.conf.in: adapt to requested_reply change
1580 2004-05-28 Havoc Pennington <hp@redhat.com>
1582 * test/glib/test-service-glib.c (main): remove unused variable
1584 * glib/dbus-gidl.c (base_info_ref): fix a silly compiler warning
1586 * dbus/dbus-auth.h (enum): remove AUTHENTICATED_WITH_UNUSED_BYTES
1587 from the enum, no longer in use.
1589 * dbus/dbus-sysdeps.h: include config.h so DBUS_VA_COPY actually
1592 * dbus/dbus-message.c: add various _dbus_return_val_if_fail for
1593 whether error_name passed in is a valid error name.
1595 2004-05-28 John (J5) Palmieri <johnp@redhat.com>
1597 * dbus/dbus-message.c (dbus_message_get_args): Added support for
1598 OBJECT_PATH and OBJECT_PATH_ARRAY
1600 2004-05-28 Seth Nickell <seth@gnome.org>
1602 * python/examples/Makefile.am:
1604 Forget to add Makefile.am. Do not pass go.
1606 2004-05-28 Michael Meeks <michael@ximian.com>
1608 * glib/dbus-gvalue.c (dbus_gvalue_marshal, dbus_gvalue_demarshal):
1611 * dbus/dbus-string.c (_dbus_string_parse_basic_type): impl.
1613 * dbus/dbus-message.c (_dbus_message_iter_get_basic_type),
1614 (_dbus_message_iter_get_basic_type_array): impl.
1615 drastically simplify ~all relevant _get methods to use these.
1616 (_dbus_message_iter_append_basic_array),
1617 (dbus_message_iter_append_basic): impl
1618 drastically simplify ~all relevant _append methods to use these.
1620 * dbus/dbus-message-builder.c (parse_basic_type)
1621 (parse_basic_array, lookup_basic_type): impl.
1622 (_dbus_message_data_load): prune scads of duplicate /
1625 * dbus/dbus-marshal.c (_dbus_demarshal_basic_type_array)
1626 (_dbus_demarshal_basic_type): implement,
1627 (demarshal_and_validate_len/arg): beef up debug.
1628 (_dbus_marshal_basic_type, _dbus_marshal_basic_type_array): impl.
1630 2004-05-27 Seth Nickell <seth@gnome.org>
1633 * python/Makefile.am:
1635 Include the example python apps in the tarball.
1637 * python/examples/list-system-services.py
1639 Add a python new example that fetches the list of services
1640 from the system bus.
1642 2004-05-27 Seth Nickell <seth@gnome.org>
1645 * python/dbus_bindings.pyx.in:
1647 Fix failure to notify that a signal was not handled,
1648 resulted in hung functions.
1650 2004-05-25 Colin Walters <walters@redhat.com>
1652 * tools/dbus-monitor.c (main): Monitor all types of messages.
1654 2004-05-23 Owen Fraser-Green <owen@discobabe.net>
1656 * mono/Handler.cs, mono/Service.cs: Added UnregisterObject method
1657 which unregisters the object path and disposes the handler.
1659 2004-05-23 Kristian Høgsberg <krh@redhat.com>
1661 Patch from Timo Teräs <ext-timo.teras@nokia.com> (#614):
1663 * dbus/dbus-message.c (dbus_message_iter_get_args_valist): Swap
1664 operands to && so we call dbus_message_iter_next () for the last
1667 2004-05-21 Olivier Andrieu <oliv__a@users.sourceforge.net>
1669 * dbus/dbus-object-tree.c
1670 (_dbus_object_tree_list_registered_unlock, lookup_subtree): return
1671 children even if the requested path isn't registered.
1672 (object_tree_test_iteration): test object_tree_list_registered.
1674 * configure.in: undefine HAVE_ABSTRACT_SOCKETS instead of defining
1677 2004-05-20 Kristian Høgsberg <krh@redhat.com>
1679 * doc/TODO: Remove resolved items.
1681 * bus/expirelist.h (struct BusExpireList): remove unused n_items
1684 * bus/connection.c (bus_connections_expect_reply): Enforce the
1685 per-connection limit on pending replies.
1687 Patch from Jon Trowbridge <trow@ximian.com>:
1689 * bus/main.c (setup_reload_pipe): Added. Creates a pipe and sets
1690 up a watch that triggers a config reload when one end of the pipe
1692 (signal_handler): Instead of doing the config reload in our SIGHUP
1693 handler, just write to the reload pipe and let the associated
1694 watch handle the reload when control returns to the main loop.
1696 * bus/driver.c (bus_driver_handle_reload_config): Added.
1697 Implements a ReloadConfig method for requesting a configuration
1698 file reload via the bus driver.
1700 2004-05-19 Owen Fraser-Green <owen@discobabe.net>
1702 * HACKING: Updated release instructions concerning the wiki page.
1704 2004-05-18 Kristian Høgsberg <krh@redhat.com>
1706 * dbus/dbus-auth.c (client_try_next_mechanism): Remove logic to
1707 filter against auth->allowed_mechs; we only add allowed mechs in
1708 record_mechanisms().
1710 * dbus/dbus-auth-script.c (_dbus_auth_script_run): Add an
1711 ALLOWED_MECHS to auth-script format so we can set the list of
1714 * data/auth/client-out-of-mechanisms.auth-script: New test to
1715 check client disconnects when it is out of mechanisms to try.
1717 * dbus/dbus-auth.c (process_command): Remove check for lines
1718 longer that 1 MB; we only buffer up maximum 16 kB.
1720 * dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
1721 dbus/dbus-auth-script.c, dbus/dbus-auth.c, dbus/dbus-auth.h:
1722 Remove auth state AUTHENTICATED_WITH_UNUSED_BYTES, instead always
1723 assume there might be unused bytes.
1725 * dbus/dbus-auth.c (_dbus_auth_do_work): Remove check for
1726 client-out-of-mechs, it is handled in process_reject(). Move check
1727 for max failures to send_rejected(), as it's a server-only thing.
1729 * dbus/dbus-auth.c: Factor out protocol reply code into functions
1730 send_auth(), send_data(), send_rejected(), send_error(),
1731 send_ok(), send_begin() and send_cancel().
1733 2004-05-17 Kristian Høgsberg <krh@redhat.com>
1735 Remove base64 encoding, replace with hex encoding. Original patch
1736 from trow@ximian.com, added error handling.
1738 * dbus/dbus-string.c (_dbus_string_base64_encode)
1739 (_dbus_string_base64_decode): Remove.
1740 (_dbus_string_hex_decode): Add end_return argument so we can
1741 distinguish between OOM and invalid hex encoding.
1742 (_dbus_string_test): Remove base64 tests and add test case for
1745 * dbus/dbus-keyring.c, dbus/dbus-auth-script.c, dbus/dbus-auth.c:
1746 Replace base64 with hex.
1748 * test/data/auth/invalid-hex-encoding.auth-script: New test case
1749 for invalid hex encoded data in auth protocol.
1751 2004-05-17 Olivier Andrieu <oliv__a@users.sourceforge.net>
1753 * dbus/dbus-connection.c (check_for_reply_unlocked): plug a memory
1756 2004-05-15 Owen Fraser-Green <owen@discobabe.net>
1758 * mono/dbus-sharp.dll.config.in: Added for GAC
1759 * mono/dbus-sharp.snk: Added for GAC
1760 * mono/Assembly.cs.in: Added for GAC
1761 * mono/Makefile.am: Changes for GAC installation
1762 * configure.in: Added refs for dbus-sharp.dll.config.in and
1763 Assembly.cs.in. More fixes for mono testing
1764 * mono/example/Makefile.am: Changed var to CSC
1765 * Makefile.am: Changed flag name to DBUS_USE_CSC
1767 2004-05-15 Owen Fraser-Green <owen@discobabe.net>
1769 * mono/Makefile.am: Added SUBDIRS for docs. Changed SUBDIRS order
1770 * mono/doc/*: Added documentation framework
1771 * configure.in: Added monodoc check
1772 * README: Added description of mono configure flags
1774 2004-05-11 John (J5) Palmieri <johnp@redhat.com>:
1776 * doc/dbus-specification.xml: Added a "Required" column to the
1777 header fields table and changed the "zero or more" verbage in
1778 the above paragraph to read "The header must contain the required
1779 named header fields and zero or more of the optional named header
1781 * test/data/invalid-messages/*.message: Added the required PATH
1782 named header field to the tests so that they don't fail on
1783 'Missing path field'
1785 2004-05-07 John (J5) Palmieri <johnp@redhat.com>
1787 * python/dbus-bindings.pyx.in: Stopped the bindings from trashing
1788 the stack by implicitly defining variable and parameter types and
1789 removing the hack of defining C pointers as python objects and later
1792 2004-05-02 Owen Fraser-Green <owen@discobabe.net>
1794 * mono/Makefile.am: Removed test-dbus-sharp.exe from all target
1796 2004-05-01 Owen Fraser-Green <owen@discobabe.net>
1798 * mono/DBusType/Dict.cs: Handle empty dicts
1799 * mono/DBusType/Array.cs: Handle empty arrays
1800 * mono/Arguments.cs: Handle empty arguments
1802 2004-04-30 Owen Fraser-Green <owen@discobabe.net>
1804 * dbus-sharp.pc.in: Modified to include include Libs and Requires
1807 2004-04-25 Kristian Høgsberg <krh@redhat.com>
1809 * test/data/valid-messages/standard-*.message: Update message
1810 test scripts to new header field names.
1812 2004-04-22 John (J5) Palmieri <johnp@redhat.com>
1814 * test/break-loader.c (randomly_do_n_things): tracked down buffer
1815 overflow to times_we_did_each_thing array which would chop off the
1816 first character of the failure_dir string. Increased the size of
1817 the array to 7 to reflect the number of random mutation functions
1820 2004-04-21 Kristian Høgsberg <krh@redhat.com>
1822 * dbus/dbus-server-unix.c (unix_finalize): Don't unref
1823 unix_server->watch here, it is unreffed in disconnect.
1824 (_dbus_server_new_for_tcp_socket): convert NULL host to
1825 "localhost" here so we don't append NULL to address.
1827 * dbus/dbus-server.c (_dbus_server_test): Add test case for
1828 various addresses, including tcp with no explicit host.
1830 2004-04-21 Olivier Andrieu <oliv__a@users.sourceforge.net>
1832 * dbus/dbus-message.c (decode_header_data, decode_string_field):
1833 fix incorrect setting of .name_offset in the HeaderField (it was
1834 off by two bytes, positioned right after the name and typecode)
1836 * bus/bus.c (bus_context_new, bus_context_unref): test before
1837 calling dbus_server_free_data_slot and _dbus_user_database_unref
1838 in case of an error.
1840 * tools/Makefile.am: add $(DBUS_GLIB_TOOL_LIBS), xml libs needed
1843 2004-04-19 Kristian Høgsberg <krh@redhat.com>
1845 * dbus/dbus-transport-unix.c (unix_do_iteration): Rewrite to use
1846 _dbus_poll() instead of select().
1848 2004-04-15 Jon Trowbridge <trow@ximian.com>
1850 * bus/main.c (signal_handler): Reload the configuration files
1852 (main): Set up our SIGHUP handler.
1854 * bus/bus.c (struct BusContext): Store the config file, user and
1855 fork flag in the BusContext.
1856 (process_config_first_time_only): Added. Contains the code
1857 (previously in bus_context_new) for setting up the BusContext from
1858 the BusConfigParser that should only be run the first time the
1859 config files are read.
1860 (process_config_every_time): Added. Contains the code (previously
1861 in bus_context_new) for setting up the BusContext from the
1862 BusConfigParser that should be run every time the config files are
1864 (load_config): Added. Builds a BusConfigParser from the config
1865 files and passes the resulting structure off to
1866 process_config_first_time_only (assuming this is the first time)
1867 and process_config_every_time.
1868 (bus_context_new): All of the config-related code has been moved
1869 to process_config_first_time_only and process_config_every_time.
1870 Now this function just does the non-config-related initializations
1871 and calls load_config.
1872 (bus_context_reload_config): Added.
1874 2004-04-15 Olivier Andrieu <oliv__a@users.sourceforge.net>
1876 * bus/driver.c (bus_driver_handle_get_service_owner):
1877 implement a GetServiceOwner method.
1878 * doc/dbus-specification.xml: document it.
1879 * dbus/dbus-errors.h: add a 'ServiceHasNoOwner' error.
1881 * glib/dbus-gproxy.c (dbus_gproxy_new_for_service_owner):
1882 implement, using the bus GetServiceOwner method.
1884 * test/glib/test-dbus-glib.c:
1885 use dbus_gproxy_new_for_service_owner so that we can receive the
1888 2004-04-15 John (J5) Palmieri <johnp@redhat.com>
1890 * dbus/dbus-internals.c, dbus/dbus-message-builder.c,
1891 dbus/dbus-message.c, dbus/dbus-protocol.h
1892 (DBUS_HEADER_FIELD_SERVICE): renamed DBUS_HEADER_FIELD_DESTINATION
1894 * dbus/dbus-internals.c, dbus/dbus-message-builder.c,
1895 dbus/dbus-message.c, dbus/dbus-protocol.h
1896 (DBUS_HEADER_FIELD_SENDER_SERVICE): renamed DBUS_HEADER_FIELD_SENDER
1898 * dbus/dbus-internals.c (_dbus_header_field_to_string):
1899 DBUS_HEADER_FIELD_DESTINATION resolves to "destination"
1900 DBUS_HEADER_FIELD_SENDER resolves to "sender"
1902 * doc/dbus-specification.xml (Header Fields Table):
1903 s/SERVICE/DESTINATION
1904 s/SENDER_SERVICE/SENDER
1907 2004-04-14 Olivier Andrieu <oliv__a@users.sourceforge.net>
1909 * test/glib/test-dbus-glib.c (timed_exit): fail the test after
1912 2004-04-13 Michael Meeks <michael@ximian.com>
1914 * glib/dbus-gobject.c (handle_introspect): split out
1915 (introspect_properties): this.
1916 (handle_introspect): implement this.
1918 * test/glib/Makefile.am: use the absolute path so the bus
1919 daemon's chdir ("/") doesn't kill us dead.
1921 * configure.in: subst ABSOLUTE_TOP_BUILDDIR
1923 2004-04-12 Jon Trowbridge <trow@ximian.com>
1925 * bus/config-parser.c (struct BusConfigParser): Added
1926 included_files field.
1927 (seen_include): Added. Checks whether or not a file has already
1928 been included by any parent BusConfigParser.
1929 (bus_config_parser_new): Copy the parent's included_files.
1930 (include_file): Track which files have been included, and fail on
1931 circular inclusions.
1932 (process_test_valid_subdir): Changed printf to report if we are
1933 testing valid or invalid conf files.
1934 (all_are_equiv): Changed printf to be a bit clearer about
1935 what we are actually doing.
1936 (bus_config_parser_test): Test invalid configuration files.
1938 2004-04-09 Jon Trowbridge <trow@ximian.com>
1940 * bus/config-parser.c (bus_config_parser_new): Added a 'parent'
1941 argument. If non-null, the newly-constructed BusConfigParser will
1942 be initialized with the parent's BusLimits instead of the default
1944 (include_file): When including a config file, pass in
1945 the current parser as the parent and then copy the BusLimits
1946 from the included BusConfigParser pack to the current parser.
1947 (process_test_valid_subdir): Renamed from process_test_subdir.
1948 (process_test_equiv_subdir): Added. Walks through a directory,
1949 descending into each subdirectory and loading the config files
1950 it finds there. If any subdirectory contains two config files
1951 that don't produce identical BusConfigParser structs, fail.
1952 For now, the BusConfigParser's BusPolicies are not compared.
1953 (bus_config_parser_test): Call both process_test_valid_subdir and
1954 process_test_equiv_subdir.
1956 * bus/config-loader-libxml.c (bus_config_load): Take a parent
1957 argument and pass it along to the call to bus_config_parser_new.
1958 Also made a few small changes to allow this code to compile.
1960 * bus/config-loader-expat.c (bus_config_load): Take a parent
1961 argument and pass it along to the call to bus_config_parser_new.
1963 * bus/bus.c (bus_context_new): Load the config file
1964 with a NULL parent argument.
1966 2004-03-29 Michael Meeks <michael@ximian.com>
1968 * glib/dbus-gobject.c (introspect_properties): split
1969 out, fix mangled 'while' flow control.
1970 (introspect_signals): implement.
1971 (handle_introspect): update.
1973 2004-03-29 Michael Meeks <michael@ximian.com>
1975 * glib/dbus-gobject.c (set_object_property): split out /
1976 re-work, use the property type, and not the message type(!)
1977 (get_object_property): ditto.
1979 * glib/dbus-gvalue.c (dbus_gvalue_demarshal),
1980 (dbus_gvalue_marshal): make this code re-usable, needed
1981 for signals too, also on both proxy and server side.
1982 Re-write for more efficiency / readability.
1984 2004-03-29 Michael Meeks <michael@ximian.com>
1986 * dbus/dbus-message.c
1987 (dbus_message_new_error_printf): impl.
1989 * dbus/dbus-connection.c
1990 (dbus_connection_unregister_object_path): fix warning.
1992 * configure.in: fix no-mono-installed situation.
1994 2004-03-27 Havoc Pennington <hp@redhat.com>
1996 Patch from Timo Teräs:
1998 * tools/dbus-send.c (main): if --print-reply, assume type is
1999 method call; support boolean type args
2001 * dbus/dbus-connection.c (dbus_connection_send_with_reply): fix a
2002 bunch of memleak and logic bugs
2004 2004-03-23 Owen Fraser-Green <owen@discobabe.net>
2006 * mono/Arguments.cs:
2007 * mono/Introspector.cs:
2009 * mono/InterfaceProxy.cs:
2011 * mono/ProxyBuilder.cs:
2013 Added InterfaceProxy class to avoid building proxies for every
2017 * dbus-message.c (dbus_message_append_args_valist)
2018 (dbus_message_iter_get_object_path)
2019 (dbus_message_iter_get_object_path_array)
2020 (dbus_message_iter_append_object_path)
2021 (dbus_message_iter_append_object_path_array):
2022 Added object_path iter functions to handle OBJECT_PATH arguments
2024 2004-03-23 Owen Fraser-Green <owen@discobabe.net>
2026 First checkin of mono bindings.
2029 Build stuff for the bindings
2030 * dbus-sharp.pc.in: Added for pkgconfig
2032 2004-03-21 Havoc Pennington <hp@redhat.com>
2034 * test/test-service.c (main): remove debug spew
2036 2004-03-21 Olivier Andrieu <oliv__a@users.sourceforge.net>
2038 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): accept empty
2041 * dbus/dbus-message.h, bus/dbus-message.c (dbus_message_iter_init)
2042 (dbus_message_iter_init_array_iterator)
2043 (dbus_message_iter_init_dict_iterator): return a dbus_bool_t to
2044 indicate whether the iterator is empty
2046 * dbus/dbus-pending-call.c, dbus/dbus-server.c: silence compiler
2049 2004-03-19 Havoc Pennington <hp@redhat.com>
2051 * NEWS: 0.21 updates
2053 * configure.in: 0.21
2055 * doc/Makefile.am: add all XMLTO usage to DBUS_XML_DOCS_ENABLED
2057 * python/Makefile.am: change to avoid dist of dbus_bindings.c so
2058 you don't need pyrex to make dist
2060 * qt/Makefile.am (libdbus_qt_1_la_SOURCES): add integrator.h to
2063 2004-03-18 Richard Hult <richard@imendio.com>
2065 * dbus/dbus-message.c (dbus_message_get_auto_activation)
2066 (dbus_message_set_auto_activation): Add doxygen docs.
2068 2004-03-16 Richard Hult <richard@imendio.com>
2070 * bus/activation.c: (bus_activation_service_created),
2071 (bus_activation_send_pending_auto_activation_messages),
2072 (bus_activation_activate_service):
2074 * bus/dispatch.c: (bus_dispatch),
2075 (check_nonexistent_service_auto_activation),
2076 (check_service_auto_activated),
2077 (check_segfault_service_auto_activation),
2078 (check_existent_service_auto_activation), (bus_dispatch_test):
2079 * bus/driver.c: (bus_driver_handle_activate_service):
2080 * bus/services.c: (bus_registry_acquire_service):
2081 * dbus/dbus-message.c: (dbus_message_set_auto_activation),
2082 (dbus_message_get_auto_activation):
2083 * dbus/dbus-message.h:
2084 * dbus/dbus-protocol.h: Implement auto-activation.
2086 * doc/dbus-specification.xml: Add auto-activation to the spec.
2088 2004-03-12 Olivier Andrieu <oliv__a@users.sourceforge.net>
2090 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos):
2091 fix a bug with CUSTOM types.
2093 * dbus/dbus-message.c (message_iter_test, _dbus_message_test): add
2094 a unit test for this bug (used to fail).
2096 2004-03-12 Mikael Hallendal <micke@imendio.com>
2099 (babysitter_watch_callback): notify all pending activations waiting for
2100 the same exec that the activation failed.
2101 (bus_activation_activate_service): shortcut the activation if we
2102 already waiting for the same executable to start up.
2104 2004-03-12 Mikael Hallendal <micke@imendio.com>
2107 - Added service file reloading.
2108 Each service files directory is kept in an hash table in
2109 BusActivation and each BusActivationEntry knows what .service-file it
2110 was read from. So when you try to activate a service the bus will
2111 check if it's been updated, removed or if new .service-files has
2113 - Test code at the bottom for the service file reloading.
2114 * bus/test-main.c: (main):
2116 - added service reloading test.
2117 * dbus/dbus-sysdeps.c:
2118 * dbus/dbus-sysdeps.h: (_dbus_delete_directory): Added.
2120 2004-03-08 Michael Meeks <michael@ximian.com>
2122 * dbus/dbus-connection.c (_dbus_connection_block_for_reply):
2123 bail immediately if disconnected, to avoid busy loop.
2125 * dbus/dbus-message.c (dbus_message_iter_get_args_valist):
2126 cleanup cut/paste/inefficiency.
2128 2004-03-01 David Zeuthen <david@fubar.dk>
2130 * dbus/dbus-string.c (_dbus_string_append_printf_valist): Fix a
2131 bug where args were used twice. This bug resulted in a segfault
2132 on a Debian/PPC system when starting the messagebus daemon. Include
2133 dbus-sysdeps.h for DBUS_VA_COPY
2135 * dbus/dbus-sysdeps.h: Define DBUS_VA_COPY if neccessary. From GLib
2137 * configure.in: Check for va_copy; define DBUS_VA_COPY to the
2138 appropriate va_copy implementation. From GLib
2140 2004-02-24 Joe Shaw <joe@ximian.com>
2142 * bus/services.c (bus_registry_acquire_service): We need to pass
2143 in the service name to dbus_set_error() to prevent a crash.
2145 2003-12-26 Anders Carlsson <andersca@gnome.org>
2147 * AUTHORS: Reveal my True identity.
2149 2003-12-17 Mikael Hallendal <micke@imendio.com>
2151 * dbus/dbus-message.c: (dbus_message_append_args_valist):
2152 - Added case for DBUS_TYPE_BYTE, patch from Johan Hedberg.
2154 2003-12-13 Mikael Hallendal <micke@imendio.com>
2156 * doc/TODO: Added not about better error check of configuration files.
2158 2003-12-02 Richard Hult <richard@imendio.com>
2160 * Update AFL version to 2.0 throughout the source files to reflect
2161 the update that was done a while ago.
2163 2003-12-02 Richard Hult <richard@imendio.com>
2165 * dbus/dbus-message.c (dbus_message_iter_append_dict): Set
2166 wrote_dict_key to FALSE on the iter that the dict is appended to,
2167 just like when appending other types. Fixes a bug where a dict
2168 couldn't be put inside a dict.
2169 (dbus_message_iter_append_dict_key): Fix typo in warning message.
2170 (message_iter_test, _dbus_message_test): Add test case for dict
2173 2003-12-01 David Zeuthen <david@fubar.dk>
2175 * python/dbus.py: Add the actual message when calling the reciever
2176 of a signal such that parameters can be inspected. Add the method
2177 remove_signal_receiver
2179 2003-11-26 Mikael Hallendal <micke@imendio.com>
2183 * glib/*.[ch]: Made ref functions return the pointer
2185 2003-11-25 Zack Rusin <zack@kde.org>
2187 * qt/integrator.h, qt/integrator.cpp: Adding handling of DBusServer,
2189 * qt/server.h, qt/server.cpp, qt/Makefile.am: Adding DBusServer
2192 * qt/connection.h, qt/connection.cpp: Adjusting to changes in
2193 the Integrator and to better fit with the server,
2195 2003-11-24 Zack Rusin <zack@kde.org>
2197 * qt/connection.h, qt/connection.cpp: removing initDbus method since
2198 the integrator handles it now
2200 * qt/integrator.h, qt/integrator.cpp: reworking handling of timeouts,
2201 since QTimer wasn't really meant to be used the way DBusTimeout is
2203 2003-11-24 Zack Rusin <zack@kde.org>
2205 * qt/integrator.h, qt/integrator.cpp, Makefile.am: Adding
2206 Integrator class which integrates D-BUS with the Qt event loop,
2208 * qt/connection.h, qt/connection.cpp: Move all the code which
2209 was dealing with D-BUS integration to the Integrator class,
2210 and start using Integrator,
2212 2003-11-23 Zack Rusin <zack@kde.org>
2214 * qt/connection.h, qt/connection.cpp: Adding the DBusConnection
2217 * qt/message.h, qt/message.cpp: updating to the current D-BUS api,
2218 switching namespaces to DBusQt, reworking the class,
2220 * Makefile.cvs: switching dependencies so that it matches KDE
2223 * qt/Makefile.am: adding connection.{h,cpp} and message.{h,cpp} to
2226 2003-11-19 Havoc Pennington <hp@redhat.com>
2230 * configure.in: bump version to 0.20
2232 * configure.in (have_qt): add yet another place to look for qt
2233 (someone hand trolltech a .pc file...)
2235 2003-11-01 Havoc Pennington <hp@redhat.com>
2237 * doc/dbus-specification.xml: add state machine docs on the auth
2238 protocol; just a first draft, I'm sure it's wrong.
2240 2003-10-28 David Zeuthen <david@fubar.dk>
2242 * python/dbus_bindings.pyx.in: add get_dict to handle dictionaries
2243 return types. Fixup TYPE_* to reflect changes in dbus/dbus-protocol.h
2245 2003-10-28 Havoc Pennington <hp@redhat.com>
2247 * dbus/dbus-message.c (get_next_field): delete unused function
2249 2003-10-28 Havoc Pennington <hp@redhat.com>
2251 * bus/expirelist.c (do_expiration_with_current_time): detect
2252 failure of the expire_func due to OOM
2254 * bus/connection.c (bus_pending_reply_expired): return FALSE on OOM
2256 * bus/dispatch.c (check_send_exit_to_service): fix to handle the
2257 NoReply error that's now created by the bus when the service exits
2259 2003-10-28 Havoc Pennington <hp@redhat.com>
2261 * dbus/dbus-message.c (_dbus_message_test): enable and fix the
2262 tests for set_path, set_interface, set_member, etc.
2264 * dbus/dbus-string.c (_dbus_string_insert_bytes): allow 0 bytes
2266 * dbus/dbus-message.c (set_string_field): always just delete and
2267 re-append the field; accept NULL for deletion
2268 (re_align_fields_recurse): reimplement
2270 2003-10-26 Havoc Pennington <hp@redhat.com>
2272 * dbus/dbus-connection.c: fix docs to properly describe the
2273 disconnected message
2274 (_dbus_connection_notify_disconnected): remove this function;
2275 we can't synchronously add the disconnected message, we have to
2276 do it after we've queued any remaining real messages
2277 (_dbus_connection_get_dispatch_status_unlocked): queue the
2278 disconnect message only if the transport has finished queueing all
2279 its real messages and is disconnected.
2280 (dbus_connection_disconnect): update the dispatch status here
2282 2003-10-22 Havoc Pennington <hp@redhat.com>
2284 * bus/bus.c (bus_context_check_security_policy): fix up assertion
2286 * bus/connection.c (bus_transaction_send_from_driver): set the
2287 destination to the connection's base service
2289 2003-10-20 Havoc Pennington <hp@redhat.com>
2291 hmm, make check is currently not passing.
2293 * doc/dbus-specification.xml: add requirement that custom type
2294 names follow the same rules as interface names.
2296 * dbus/dbus-protocol.h: change some of the byte codes, to avoid
2297 duplication and allow 'c' to be 'custom'; dict is now 'm' for
2300 * doc/dbus-specification.xml: update type codes to match
2301 dbus-protocol.h, using the ASCII byte values. Rename type NAMED to
2302 CUSTOM. Add type OBJECT_PATH to the spec.
2304 2003-10-17 Havoc Pennington <hp@redhat.com>
2306 * bus/driver.c (create_unique_client_name): use "." as separator
2307 in base service names instead of '-'
2309 * dbus/dbus-string.c (_dbus_string_get_byte): allow getting nul
2310 byte at the end of the string
2312 * dbus/dbus-internals.h (_DBUS_LIKELY, _DBUS_UNLIKELY): add
2313 optimization macros since string validation seems to be a slow
2316 * doc/dbus-specification.xml: restrict valid
2317 service/interface/member/error names. Add test suite code for the
2320 * dbus/dbus-string.c: limit service/interface/member/error names
2323 * dbus/dbus-connection.c (dbus_connection_dispatch): add missing
2324 format arg to verbose spew
2326 * glib/dbus-gproxy.c (dbus_gproxy_call_no_reply): if not out of
2327 memory, return instead of g_error
2329 * test/test-service.c (path_message_func): support emitting a
2332 * dbus/dbus-bus.c (init_connections_unlocked): only fill in
2333 activation bus type if DBUS_BUS_ACTIVATION was set; default to
2334 assuming the activation bus was the session bus so that services
2335 started manually will still register.
2336 (init_connections_unlocked): fix so that in OOM situation we get
2337 the same semantics when retrying the function
2339 * test/test-service.c (main): change to use path registration, to
2340 test those codepaths; register with DBUS_BUS_ACTIVATION rather
2341 than DBUS_BUS_SESSION
2343 2003-10-16 Havoc Pennington <hp@redhat.com>
2345 * glib/dbus-gtest-main.c: bracket with #ifdef DBUS_BUILD_TESTS
2347 * Makefile.am (GCOV_DIRS): remove "test", we don't care about test
2348 coverage of the tests
2349 (coverage-report.txt): don't move the .da and .bbg files around
2351 2003-10-16 Havoc Pennington <hp@redhat.com>
2353 * bus/bus.c (struct BusContext): remove struct field I didn't mean
2356 2003-10-16 Havoc Pennington <hp@redhat.com>
2358 * bus/connection.c (bus_pending_reply_expired): either cancel or
2360 (bus_connections_check_reply): use unlink, not remove_link, as we
2361 don't want to free the link; fixes double free mess
2363 * dbus/dbus-pending-call.c (dbus_pending_call_block): fix in case
2364 where no reply was received
2366 * dbus/dbus-connection.c (_dbus_pending_call_complete_and_unlock):
2369 * bus/signals.c (match_rule_matches): add special cases for the
2370 bus driver, so you can match on sender/destination for it.
2372 * dbus/dbus-sysdeps.c (_dbus_abort): print backtrace if
2373 DBUS_PRINT_BACKTRACE is set
2375 * dbus/dbus-internals.c: add pid to assertion failure messages
2377 * dbus/dbus-connection.c: add message type code to the debug spew
2379 * glib/dbus-gproxy.c (gproxy_get_match_rule): match rules want
2380 sender=foo not service=foo
2382 * dbus/dbus-bus.c (dbus_bus_get): if the activation bus is the
2383 session bus but DBUS_SESSION_BUS_ADDRESS isn't set, use
2384 DBUS_ACTIVATION_ADDRESS instead
2386 * bus/activation.c: set DBUS_SESSION_BUS_ADDRESS,
2387 DBUS_SYSTEM_BUS_ADDRESS if appropriate
2389 * bus/bus.c (bus_context_new): handle OOM copying bus type into
2392 * dbus/dbus-message.c (dbus_message_iter_get_object_path): new function
2393 (dbus_message_iter_get_object_path_array): new function (half
2394 finished, disabled for the moment)
2396 * glib/dbus-gproxy.c (dbus_gproxy_end_call): properly handle
2397 DBUS_MESSAGE_TYPE_ERROR
2399 * tools/dbus-launch.c (babysit): support DBUS_DEBUG_OUTPUT to
2400 avoid redirecting stderr to /dev/null
2401 (babysit): close stdin if not doing the "exit_with_session" thing
2403 * dbus/dbus-sysdeps.c (_dbus_become_daemon): delete some leftover
2404 debug code; change DBUS_DEBUG_OUTPUT to only enable stderr, not
2405 stdout/stdin, so things don't get confused
2407 * bus/system.conf.in: fix to allow replies, I modified .conf
2408 instead of .conf.in again.
2410 2003-10-14 David Zeuthen <david@fubar.dk>
2412 * python/dbus_bindings.pyx.in (MessageIter.get): fixed typo in
2413 argtype to arg_type when raising unknown arg type exception.
2414 Changed type list to reflect the changes in dbus-protocol.h so
2415 the bindings actually work.
2417 2003-10-14 Havoc Pennington <hp@redhat.com>
2419 * test/decode-gcov.c: support gcc 3.3 also, though gcc 3.3 seems
2420 to have a bug keeping it from outputting the .da files sometimes
2421 (string_get_string): don't append garbage nul bytes to the string.
2423 2003-10-15 Seth Nickell <seth@gnome.org>
2425 * python/Makefile.am:
2427 Include dbus_h_wrapper.h in the dist tarball.
2429 2003-10-14 Havoc Pennington <hp@redhat.com>
2431 * bus/bus.c (bus_context_check_security_policy): revamp this to
2432 work more sanely with new policy-based requested reply setup
2434 * bus/connection.c (bus_transaction_send_from_driver): set bus
2435 driver messages as no reply
2437 * bus/policy.c (bus_client_policy_check_can_receive): handle a
2438 requested_reply attribute on allow/deny rules
2440 * bus/system.conf: add <allow requested_reply="true"/>
2442 * bus/driver.c (bus_driver_handle_message): fix check for replies
2443 sent to the bus driver, which was backward. How did this ever work
2444 at all though? I think I'm missing something.
2446 * dbus/dbus-message.c (decode_header_data): require error and
2447 method return messages to have a reply serial field to be valid
2448 (_dbus_message_loader_queue_messages): break up this function;
2449 validate that reply serial and plain serial are nonzero;
2450 clean up the OOM/error handling.
2451 (get_uint_field): don't return -1 from this
2452 (dbus_message_create_header): fix signed/unsigned bug
2454 * bus/connection.c (bus_connections_expect_reply): save serial of
2455 the incoming message, not reply serial
2457 2003-10-14 Havoc Pennington <hp@redhat.com>
2459 * bus/connection.c: implement pending reply tracking using
2462 * bus/bus.c (bus_context_check_security_policy): verify that a
2463 reply is pending in order to allow a reply to be sent. Deny
2464 messages of unknown type.
2466 * bus/dbus-daemon-1.1.in: update to mention new resource limits
2468 * bus/bus.c (bus_context_get_max_replies_per_connection): new
2469 (bus_context_get_reply_timeout): new
2471 2003-10-13 Seth Nickell <seth@gnome.org>
2473 * python/Makefile.am:
2475 Pass "make distcheck": remove a couple files from DIST_FILES
2476 that weren't included in the final version.
2478 2003-10-12 Havoc Pennington <hp@pobox.com>
2480 Added test code that 1) starts an actual bus daemon and 2) uses
2481 DBusGProxy; fixed bugs that were revealed by the test. Lots
2482 more testing possible, but this is the basic framework.
2484 * glib/dbus-gproxy.c (dbus_gproxy_manager_unregister): remove
2485 empty proxy lists from the proxy list hash
2487 * dbus/dbus-message.c (dbus_message_iter_get_args_valist): add a
2488 couple of return_if_fail checks
2490 * dbus/dbus-pending-call.c (_dbus_pending_call_new): use dbus_new0
2491 to allocate, so everything is cleared to NULL as it should be.
2493 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): pass
2494 source as data to dbus_connection_set_timeout_functions() as the
2495 timeout functions expected
2497 * test/glib/run-test.sh: add a little script to start up a message
2498 bus and run tests using it
2500 * tools/dbus-launch.1: updates
2502 * tools/dbus-launch.c (main): add --config-file option
2504 * tools/dbus-launch.c (main): remove confusing else if (runprog)
2505 that could never be reached.
2507 * dbus/dbus-message.c (dbus_message_new_method_return)
2508 (dbus_message_new_error, dbus_message_new_signal): set the
2509 no-reply-expected flag on all these. Redundant, but may
2510 as well be consistent.
2512 2003-10-11 Havoc Pennington <hp@pobox.com>
2514 * test/decode-gcov.c (function_solve_graph): make broken block
2515 graph a nonfatal error since it seems to be broken. Need to debug
2518 * dbus/dbus-marshal.c (_dbus_type_is_valid): new function since we
2519 can't just check type > INVALID < LAST anymore
2521 * dbus/dbus-message.c (dbus_message_get_signature): new function
2522 (dbus_message_has_signature): new function
2523 (struct DBusMessage): add signature field (right now it isn't sent
2524 over the wire, just generated on the fly)
2525 (dbus_message_copy): copy the signature, and init strings to
2526 proper length to avoid some reallocs
2527 (dbus_message_iter_init_array_iterator): return void, since it
2529 (dbus_message_iter_init_dict_iterator): return void since it can't fail
2530 (_dbus_message_loader_queue_messages): add silly temporary hack to
2531 fill in message->signature on load
2533 * dbus/dbus-protocol.h: change DBUS_TYPE_* values to be ASCII
2534 characters, so they are relatively human-readable.
2536 2003-10-11 Havoc Pennington <hp@pobox.com>
2538 * dbus/dbus-message.c (_dbus_message_test): add more test
2539 coverage, but #if 0 for now since they uncover a bug
2540 not fixed yet; I think in re_align_field_recurse()
2541 (re_align_field_recurse): add FIXME about broken assertion
2543 * dbus/dbus-sysdeps.c (_dbus_sysdeps_test): add more test coverage
2545 * bus/connection.c: share a couple code bits with expirelist.c
2547 * bus/expirelist.h, bus/expirelist.c: implement a generic
2548 expire-items-after-N-seconds facility, was going to share between
2549 expiring connections and replies, decided not to use for expiring
2550 connections for now.
2552 * COPYING: include AFL 2.0 (still need to change all the file headers)
2554 2003-10-09 Havoc Pennington <hp@redhat.com>
2556 * configure.in: define DBUS_HAVE_GCC33_GCOV if we have
2557 gcc 3.3. Not that we do anything about it yet.
2559 * bus/signals.c (bus_match_rule_parse): impose max length on the
2562 * dbus/dbus-protocol.h: add DBUS_MAXIMUM_MATCH_RULE_LENGTH
2564 2003-10-09 Havoc Pennington <hp@redhat.com>
2566 Make matching rules theoretically work (add parser).
2568 * bus/bus.c (bus_context_check_security_policy): fix up to handle
2569 the case where destination is explicitly specified as bus driver
2570 and someone else is eavesdropping.
2572 * bus/policy.c (bus_client_policy_check_can_receive): fix up
2573 definition of eavesdropping and assertion
2575 * tools/dbus-send.c (main): use dbus_message_type_from_string
2577 * bus/signals.c (bus_match_rule_parse): implement
2579 * dbus/dbus-message.c (dbus_message_type_from_string): new
2581 * dbus/dbus-errors.h (DBUS_ERROR_MATCH_RULE_INVALID): add
2583 2003-10-02 Havoc Pennington <hp@pobox.com>
2585 * glib/dbus-gproxy.c (dbus_gproxy_call_no_reply): rename from
2586 dbus_gproxy_oneway_call
2588 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main)
2589 (dbus_server_setup_with_g_main): fix to allow calling them more
2590 than once on the same args
2591 (dbus_bus_get_with_g_main): new function
2593 2003-10-02 Havoc Pennington <hp@redhat.com>
2595 * doc/dbus-tutorial.xml: write some stuff
2597 2003-09-29 Havoc Pennington <hp@pobox.com>
2599 * configure.in: split checks for Doxygen from XML docs, check for
2602 * doc/Makefile.am: XML-ify all the docs, and add a blank
2605 2003-09-29 Havoc Pennington <hp@pobox.com>
2607 * Merge dbus-object-names branch. To see the entire patch
2608 do cvs diff -r DBUS_OBJECT_NAMES_BRANCHPOINT -r dbus-object-names,
2609 it's huuuuge though.
2610 To revert, I tagged DBUS_BEFORE_OBJECT_NAMES_MERGE.
2612 2003-09-28 Havoc Pennington <hp@pobox.com>
2614 * HACKING: update to reflect new server
2616 2003-09-26 Seth Nickell <seth@gnome.org>
2619 * python/examples/example-signals.py:
2621 Start implementing some notions of signals. The API
2622 is really terrible, but they sort of work (with the
2623 exception of being able to filter by service, and to
2624 transmit signals *as* a particular service). Need to
2625 figure out how to make messages come from the service
2628 * python/dbus_bindings.pyx.in:
2630 Removed duplicate message_handler callbacks.
2632 2003-09-25 Havoc Pennington <hp@redhat.com>
2634 * bus/session.conf.in: fix my mess
2636 2003-09-25 Havoc Pennington <hp@pobox.com>
2638 * bus/session.conf.in: fix security policy, reported by Seth Nickell
2640 2003-09-25 Seth Nickell <seth@gnome.org>
2642 * python/examples/example-service.py:
2644 Johan notices complete wrong code in example-service, but
2645 completely wrong in a way that works exactly the same (!).
2646 Johan is confused, how could this possibly work? Example
2647 code fails to serve purpose of making things clear.
2650 2003-09-25 Mark McLoughlin <mark@skynet.ie>
2652 * doc/dbus-specification.sgml: don't require header fields
2653 to be 4-byte aligned and specify that fields should be
2654 distinguished from padding by the fact that zero is not
2657 * doc/TODO: remove re-alignment item and add item to doc
2658 the OBJECT_PATH type.
2660 * dbus/dbus-message.c:
2661 (HeaderField): rename the original member to value_offset
2662 and introduce a name_offset member to keep track of where
2663 the field actually begins.
2664 (adjust_field_offsets): remove.
2665 (append_int_field), (append_uint_field),
2666 (append_string_field): don't align the start of the header
2667 field to a 4-byte boundary.
2668 (get_next_field): impl finding the next marhsalled field
2669 after a given field.
2670 (re_align_field_recurse): impl re-aligning a number of
2671 already marshalled fields.
2672 (delete_field): impl deleting a field of any type and
2673 re-aligning any following fields.
2674 (delete_int_or_uint_field), (delete_string_field): remove.
2675 (set_int_field), (set_uint_field): no need to re-check
2676 that we have the correct type for the field.
2677 (set_string_field): ditto and impl re-aligning any
2679 (decode_header_data): update to take into account that
2680 the fields aren't 4-byte aligned any more and the new
2681 way to distinguish padding from header fields. Also,
2682 don't exit when there is too much header padding.
2683 (process_test_subdir): print the directory.
2684 (_dbus_message_test): add test to make sure a following
2685 field is re-aligned correctly after field deletion.
2687 * dbus/dbus-string.[ch]:
2688 (_dbus_string_insert_bytes): rename from insert_byte and
2689 allow the insert of multiple bytes.
2690 (_dbus_string_test): test inserting multiple bytes.
2692 * dbus/dbus-marshal.c: (_dbus_marshal_set_string): add
2693 warning note to docs about having to re-align any
2694 marshalled values following the string.
2696 * dbus/dbus-message-builder.c:
2697 (append_string_field), (_dbus_message_data_load):
2698 don't align the header field.
2700 * dbus/dbus-auth.c: (process_test_subdir): print the
2703 * test/break-loader.c: (randomly_add_one_byte): upd. for
2706 * test/data/invalid-messages/bad-header-field-alignment.message:
2709 * test/data/valid-messages/unknown-header-field.message: shove
2710 a dict in the unknown field.
2712 2003-09-25 Seth Nickell <seth@gnome.org>
2715 * python/dbus_bindings.pyx.in:
2717 Handle return values.
2719 * python/examples/example-client.py:
2720 * python/examples/example-service.py:
2722 Pass back return values from the service to the client.
2724 2003-09-24 Seth Nickell <seth@gnome.org>
2728 Connect Object methods (when you are sharing an object) up... pass
2729 in a list of methods to be shared. Sharing all the methods just
2730 worked out too weird. You can now create nice Services over the
2733 * python/dbus_bindings.pyx.in:
2735 Keep references to user_data tuples passed into C functions so
2736 Python doesn't garbage collect on us.
2738 Implement MethodReturn and Error subclasses of Message for creating
2739 DBusMessage's of those types.
2741 * python/examples/example-client.py:
2742 * python/examples/example-service.py:
2744 Simple example code showing both how create DBus services and objects,
2745 and how to use them.
2747 2003-09-23 Havoc Pennington <hp@pobox.com>
2749 * glib/dbus-gproxy.c (dbus_gproxy_manager_filter): implement
2751 2003-09-23 Havoc Pennington <hp@redhat.com>
2753 * glib/dbus-gproxy.c (dbus_gproxy_connect_signal): implement
2754 (dbus_gproxy_disconnect_signal): implement
2755 (dbus_gproxy_manager_remove_signal_match): implement
2756 (dbus_gproxy_manager_add_signal_match): implement
2757 (dbus_gproxy_oneway_call): implement
2759 2003-09-23 Havoc Pennington <hp@pobox.com>
2761 * glib/dbus-gproxy.c (struct DBusGProxy): convert to a GObject
2762 subclass. This means dropping the transparent thread safety of the
2763 proxy; you now need a separate proxy per-thread, or your own
2764 locking on the proxy. Probably right anyway.
2765 (dbus_gproxy_ref, dbus_gproxy_unref): nuke, just use g_object_ref
2767 2003-09-22 Havoc Pennington <hp@redhat.com>
2769 * glib/dbus-gproxy.c (dbus_gproxy_manager_get): implement
2771 2003-09-21 Seth Nickell <seth@gnome.org>
2773 First checkin of the Python bindings.
2775 * python/.cvsignore:
2776 * python/Makefile.am:
2777 * python/dbus_bindings.pyx.in:
2778 * python/dbus_h_wrapper.h:
2780 Pieces for Pyrex to operate on, building a dbus_bindings.so
2781 python module for low-level access to the DBus APIs.
2785 High-level Python module for accessing DBus objects.
2790 Build stuff for the python bindings.
2794 Extra macro needed for finding the Python C header files.
2796 2003-09-21 Havoc Pennington <hp@pobox.com>
2798 * glib/dbus-gproxy.c (dbus_gproxy_manager_new): start
2799 implementing the proxy manager, didn't get very far.
2801 * dbus/dbus-bus.c (dbus_bus_add_match): new
2802 (dbus_bus_remove_match): new
2804 * glib/dbus-gproxy.c (dbus_gproxy_new_for_service): add a
2805 path_name argument; adjust the other not-yet-implemented
2806 gproxy constructors to be what I think they should be.
2808 2003-09-21 Havoc Pennington <hp@pobox.com>
2810 * dbus/dbus-bus.c (dbus_bus_get): set exit_on_disconnect to TRUE
2811 by default for message bus connections.
2813 * dbus/dbus-connection.c (dbus_connection_dispatch): exit if
2814 exit_on_disconnect flag is set and we process the disconnected
2816 (dbus_connection_set_exit_on_disconnect): new function
2818 2003-09-21 Havoc Pennington <hp@pobox.com>
2820 Get matching rules mostly working in the bus; only actually
2821 parsing the rule text remains. However, the client side of
2822 "signal connections" hasn't been started, this patch is only the
2825 * dbus/dispatch.c: fix for the matching rules changes
2827 * bus/driver.c (bus_driver_handle_remove_match)
2828 (bus_driver_handle_add_match): send an ack reply from these
2831 * glib/dbus-gproxy.c (dbus_gproxy_begin_call): fix order of
2832 arguments, reported by Seth Nickell
2834 * bus/config-parser.c (append_rule_from_element): support
2835 eavesdrop=true|false attribute on policies so match rules
2836 can be prevented from snooping on the system bus.
2838 * bus/dbus-daemon-1.1.in: consistently use terminology "sender"
2839 and "destination" in attribute names; fix some docs bugs;
2840 add eavesdrop=true|false attribute
2842 * bus/driver.c (bus_driver_handle_add_match)
2843 (bus_driver_handle_remove_match): handle AddMatch, RemoveMatch
2846 * dbus/dbus-protocol.h (DBUS_SERVICE_ORG_FREEDESKTOP_BROADCAST): get
2847 rid of broadcast service concept, signals are just always broadcast
2849 * bus/signals.c, bus/dispatch.c, bus/connection.c, bus/bus.c:
2850 mostly implement matching rules stuff (currently only exposed as signal
2853 2003-09-21 Mark McLoughlin <mark@skynet.ie>
2855 * doc/dbus-specification.sgml: Change the header field name
2856 to be an enum and update the rest of the spec to reference
2857 the fields using the conventinal name.
2859 * dbus/dbus-protocol.h: update to reflect the spec.
2861 * doc/TODO: add item to remove the 4 byte alignment requirement.
2863 * dbus/dbus-message.c: Remove the code to generalise the
2864 header/body length and serial number header fields as named
2865 header fields so we can reference field names using the
2867 (append_int_field), (append_uint_field), (append_string_field):
2868 Append the field name as a byte rather than four chars.
2869 (delete_int_or_uint_field), (delete_string_field): reflect the
2870 fact that the field name and typecode now occupy 4 bytes instead
2872 (decode_string_field), (decode_header_data): update to reflect
2873 protocol changes and move the field specific encoding from
2874 decode_string_field() back into decode_header_data().
2876 * dbus/dbus-internals.[ch]: (_dbus_header_field_to_string):
2877 Add utility to aid debugging.
2879 * dbus/dbus-message-builder.c:
2880 (append_string_field), (_dbus_message_data_load): Update to
2881 reflect protocol changes; Change the FIELD_NAME directive
2882 to HEADER_FIELD and allow it to take the field's conventional
2883 name rather than the actual value.
2885 * test/data/*/*.message: Update to use HEADER_FIELD instead
2886 of FIELD_NAME; Always align the header on an 8 byte boundary
2887 *before* updating the header length.
2889 2003-09-15 Havoc Pennington <hp@pobox.com>
2891 * dbus/dbus-pending-call.c: add the get/set object data
2892 boilerplate as for DBusConnection, etc. Use generic object data
2893 for the notify callback.
2895 * glib/dbus-gparser.c (parse_node): parse child nodes
2897 * tools/dbus-viewer.c: more hacking on the dbus-viewer
2899 * glib/dbus-gutils.c (_dbus_gutils_split_path): add a file to
2900 contain functions shared between the convenience lib and the
2903 * glib/Makefile.am (libdbus_glib_1_la_LDFLAGS): add
2904 -export-symbols-regex to the GLib library
2906 * dbus/dbus-object-tree.c (_dbus_object_tree_dispatch_and_unlock):
2907 fix the locking in here, and add a default handler for
2908 Introspect() that just returns sub-nodes.
2910 2003-09-14 Havoc Pennington <hp@pobox.com>
2912 * glib/dbus-gthread.c (dbus_g_thread_init): rename to make g_foo
2913 rather than gfoo consistent
2915 * glib/dbus-gproxy.h: delete for now, move contents to
2916 dbus-glib.h, because the include files don't work right since we
2917 aren't in the dbus/ subdir.
2919 * glib/dbus-gproxy.c (dbus_gproxy_send): finish implementing
2920 (dbus_gproxy_end_call): finish
2921 (dbus_gproxy_begin_call): finish
2923 * glib/dbus-gmain.c (dbus_set_g_error): new
2925 * glib/dbus-gobject.c (handle_introspect): include information
2926 about child nodes in the introspection
2928 * dbus/dbus-connection.c (dbus_connection_list_registered): new
2929 function to help in implementation of introspection
2931 * dbus/dbus-object-tree.c
2932 (_dbus_object_tree_list_registered_and_unlock): new function
2934 2003-09-12 Havoc Pennington <hp@pobox.com>
2936 * glib/dbus-gidl.h: add common base class for all the foo_info
2939 * tools/dbus-viewer.c: add GTK-based introspection UI thingy
2942 * test/Makefile.am: try test srcdir -ef . in addition to test
2943 srcdir = ., one of them should work (yeah lame)
2945 * glib/Makefile.am: build the "idl" parser stuff as a convenience
2948 * glib/dbus-gparser.h: make description_load routines return
2949 NodeInfo* not Parser*
2951 * Makefile.am (SUBDIRS): build test dir after all library dirs
2953 * configure.in: add GTK+ detection
2955 2003-09-07 Havoc Pennington <hp@pobox.com>
2957 * Make Doxygen contented.
2959 2003-09-07 Havoc Pennington <hp@pobox.com>
2961 * doc/dbus-specification.sgml: more updates
2963 2003-09-06 Havoc Pennington <hp@pobox.com>
2965 * doc/dbus-specification.sgml: partial updates
2967 * bus/dbus-daemon-1.1.in: fix the config file docs for the
2968 zillionth time; hopefully I edited the right file this time.
2970 * bus/config-parser.c (append_rule_from_element): support
2971 send_type, send_path, receive_type, receive_path
2973 * bus/policy.c: add message type and path to the list of things
2974 that can be "firewalled"
2976 2003-09-06 Havoc Pennington <hp@pobox.com>
2978 * dbus/dbus-connection.c (dbus_connection_register_fallback): add this
2979 (dbus_connection_register_object_path): make this not handle
2980 messages to paths below the given path
2982 2003-09-03 Havoc Pennington <hp@pobox.com>
2984 * test/glib/Makefile.am: add this with random glib-linked test
2987 * glib/Makefile.am: remove the random test programs from here,
2988 leave only the unit tests
2990 * glib/dbus-gobject.c (_dbus_gobject_test): add test for
2991 uscore/javacaps conversion, and fix
2992 (get_object_property, set_object_property): change to .NET
2993 convention for mapping props to methods, set_FooBar/get_FooBar,
2994 since one language has such a convention we may as well copy it.
2995 Plus real methods in either getFooBar or get_foo_bar style won't
2996 collide with this convention.
2998 2003-09-01 Havoc Pennington <hp@pobox.com>
3000 * glib/dbus-gparser.c: implement
3002 * glib/dbus-gobject.c: start implementing skeletons support
3004 * configure.in: when disabling checks/assert, also define
3005 G_DISABLE_ASSERT and G_DISABLE_CHECKS
3007 2003-09-01 Havoc Pennington <hp@pobox.com>
3009 * glib/Makefile.am: rearrange a bunch of files and get "make
3010 check" framework set up
3012 2003-08-31 Havoc Pennington <hp@pobox.com>
3014 * fix build with --disable-tests
3016 2003-08-30 Havoc Pennington <hp@pobox.com>
3018 * dbus/dbus-connection.c: purge DBusMessageHandler
3020 * dbus/dbus-message-handler.c: remove DBusMessageHandler, just
3021 use callbacks everywhere
3023 2003-08-30 Havoc Pennington <hp@pobox.com>
3025 * test/data/valid-config-files/system.d/test.conf: change to
3026 root for the user so warnings don't get printed
3028 * dbus/dbus-message.c: add dbus_message_get_path,
3029 dbus_message_set_path
3031 * dbus/dbus-object-tree.c (do_test_dispatch): add test of
3032 dispatching to a path
3034 * dbus/dbus-string.c (_dbus_string_validate_path): add
3036 * dbus/dbus-marshal.c (_dbus_demarshal_object_path): implement
3037 (_dbus_marshal_object_path): implement
3039 * dbus/dbus-protocol.h (DBUS_HEADER_FIELD_PATH): new header field
3040 to contain the path to the target object
3041 (DBUS_HEADER_FIELD_SENDER_SERVICE): rename
3042 DBUS_HEADER_FIELD_SENDER to explicitly say it's the sender service
3044 2003-08-30 Havoc Pennington <hp@pobox.com>
3046 * dbus/dbus-object-tree.c: write tests and fix the discovered bugs
3048 2003-08-29 Havoc Pennington <hp@pobox.com>
3050 * dbus/dbus-object-tree.c: modify to allow overlapping paths to be
3052 (struct DBusObjectSubtree): shrink this
3053 a lot, since we may have a lot of them
3054 (_dbus_object_tree_free_all_unlocked): implement
3055 (_dbus_object_tree_dispatch_and_unlock): implement
3057 2003-08-29 Havoc Pennington <hp@pobox.com>
3059 * dbus/dbus-internals.h: fix _DBUS_N_GLOBAL_LOCKS
3061 2003-08-28 Havoc Pennington <hp@pobox.com>
3065 * dbus/dbus-connection.c: port to no ObjectID, create a
3066 DBusObjectTree, rename ObjectTree to ObjectPath in public API
3068 * dbus/dbus-connection.h (struct DBusObjectTreeVTable): delete
3069 everything except UnregisterFunction and MessageFunction
3071 * dbus/dbus-marshal.c: port away from DBusObjectID,
3072 add DBUS_TYPE_OBJECT_PATH
3074 * dbus/dbus-object-registry.[hc], dbus/dbus-object.[hc],
3075 dbus/dbus-objectid.[hc]: remove these, we are moving to
3076 path-based object IDs
3078 2003-08-25 Havoc Pennington <hp@pobox.com>
3080 Just noticed that dbus_message_test is hosed, I wonder when I
3081 broke that. I thought make check was passing earlier...
3083 * dbus/dbus-object-tree.c: add new "object tree" to match DCOP
3084 container tree, will replace most of dbus-object-registry
3086 * dbus/dbus-string.c (_dbus_string_append_printf_valist): fix C99
3089 2003-08-19 Havoc Pennington <hp@pobox.com>
3091 * dbus/dbus-message.c (decode_string_field): support FIELD_SENDER
3092 (dbus_message_is_error): fix this function
3094 * bus/dbus-daemon-1.1: clarify logic on when <deny>/<allow> rules
3097 * bus/policy.c (bus_client_policy_check_can_receive): fix code to
3098 reflect clarified man page
3099 (bus_client_policy_check_can_send): ditto
3101 * bus/session.conf.in: fixup
3103 * bus/system.conf.in: fixup
3105 2003-08-18 Havoc Pennington <hp@redhat.com>
3107 * dbus/dbus-hash.c (_dbus_hash_table_insert_two_strings): fix
3109 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
3110 dumb bug created earlier (wrong order of args to
3111 decode_header_data())
3113 * tools/dbus-send.c: port
3115 * tools/dbus-print-message.c (print_message): port
3117 * test/data/*messages: port all messages over
3119 * dbus/dbus-message-builder.c: support including
3122 * bus/driver.c: port over
3124 * bus/dispatch.c: port over to new stuff
3126 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
3127 rename disconnect signal to "Disconnected"
3129 2003-08-17 Havoc Pennington <hp@pobox.com>
3131 This doesn't compile yet, but syncing up so I can hack on it from
3132 work. What are branches for if not broken code? ;-)
3134 * dbus/dbus-protocol.h: remove DBUS_HEADER_FIELD_NAME, add
3135 DBUS_HEADER_FIELD_INTERFACE, DBUS_HEADER_FIELD_MEMBER,
3136 DBUS_HEADER_FIELD_ERROR_NAME
3138 * dbus/dbus-hash.c: Introduce DBUS_HASH_TWO_STRINGS as hack to use
3139 for the interface+member pairs
3140 (string_hash): change to use g_str_hash algorithm
3141 (find_direct_function, find_string_function): refactor these to
3144 * dbus/dbus-message.c: port all of this over to support
3145 interface/member fields instead of name field
3147 * dbus/dbus-object-registry.c: port over
3149 * dbus/dbus-string.c (_dbus_string_validate_interface): rename
3150 from _dbus_string_validate_name
3152 * bus/dbus-daemon-1.1: change file format for the
3153 <deny>/<allow> stuff to match new message naming scheme
3155 * bus/policy.c: port over
3157 * bus/config-parser.c: parse new format
3159 2003-08-16 Havoc Pennington <hp@pobox.com>
3161 * dbus/dbus-object-registry.c (add_and_remove_objects): remove
3164 * glib/dbus-gproxy.c: some hacking
3166 2003-08-15 Havoc Pennington <hp@redhat.com>
3168 * dbus/dbus-pending-call.c (dbus_pending_call_block): implement
3170 * dbus/dbus-connection.c
3171 (dbus_connection_send_with_reply_and_block): factor out internals;
3172 change to convert any error replies to DBusError instead of
3173 returning them as a message
3175 2003-08-15 Havoc Pennington <hp@pobox.com>
3177 * dbus/dbus-connection.c,
3178 dbus/dbus-pending-call.c: Finish the pending call stuff
3180 2003-08-14 Havoc Pennington <hp@redhat.com>
3182 * dbus/dbus-pending-call.c: start on new object that will replace
3183 DBusMessageHandler and ReplyHandlerData for tracking outstanding
3186 * dbus/dbus-gproxy.c: start on proxy object used to communicate
3187 with remote interfaces
3189 * dbus/dbus-gidl.c: do the boring boilerplate in here
3191 2003-08-12 Havoc Pennington <hp@pobox.com>
3193 * bus/dispatch.c (bus_dispatch): make this return proper
3194 DBusHandlerResult to avoid DBUS_ERROR_UNKNOWN_METHOD
3196 * dbus/dbus-errors.c (dbus_set_error): use
3197 _dbus_string_append_printf_valist
3199 * dbus/dbus-string.c (_dbus_string_append_printf_valist)
3200 (_dbus_string_append_printf): new
3202 * dbus/dbus-errors.h (DBUS_ERROR_UNKNOWN_MESSAGE): change to
3205 * dbus/dbus-connection.c (dbus_connection_dispatch): handle
3206 DBUS_HANDLER_RESULT_NEED_MEMORY; send default error reply if a
3207 message is unhandled.
3209 2003-08-11 Havoc Pennington <hp@pobox.com>
3211 * bus/test.c (client_disconnect_handler): change to return
3212 HANDLED (would have been REMOVE_MESSAGE)
3214 * dbus/dbus-object.h (enum DBusHandlerResult): rename to
3215 HANDLED/NOT_YET_HANDLED instead of
3216 REMOVE_MESSAGE/ALLOW_MORE_HANDLERS to make it clearer how it
3219 2003-08-10 Havoc Pennington <hp@pobox.com>
3221 * tools/dbus-send.c (main): add --type argument, for now
3222 supporting only method_call and signal types.
3224 * tools/dbus-print-message.c: print message type
3226 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
3227 init connection->objects
3229 * doc/dbus-specification.sgml: fix sgml
3231 * bus/*.c: port over to object-instance API changes
3233 * test/test-service.c: ditto
3235 * dbus/dbus-message.c (dbus_message_create_header): allow #NULL
3236 name, we will have to fix up the rest of the code to also handle
3238 (dbus_message_new): generic message-creation call
3239 (set_string_field): allow appending name field
3241 2003-08-06 Havoc Pennington <hp@pobox.com>
3243 * dbus/dbus-object-registry.c: implement signal connection
3246 * dbus/dbus-connection.c (_dbus_connection_unref_unlocked): new
3248 * dbus/dbus-internals.c (_dbus_memdup): new function
3250 2003-08-02 Havoc Pennington <hp@pobox.com>
3252 * dbus/dbus-message.c (dbus_message_get_no_reply)
3253 (dbus_message_set_no_reply): add these and remove
3254 set_is_error/get_is_error
3256 * dbus/dbus-protocol.h, doc/dbus-specification.sgml:
3257 remove the ERROR flag, since there's now an ERROR type
3259 2003-08-01 Havoc Pennington <hp@pobox.com>
3261 * dbus/dbus-object-registry.c (_dbus_object_registry_handle_and_unlock):
3264 * dbus/dbus-message.c (dbus_message_get_type): new function
3266 * doc/dbus-specification.sgml: add "type" byte to messages
3268 2003-08-01 Havoc Pennington <hp@pobox.com>
3270 * dbus/dbus-protocol.h (DBUS_MESSAGE_TYPE_*): introduce
3271 a message type enum to distinguish kinds of message
3272 (DBUS_HEADER_FLAG_NO_REPLY_EXPECTED): flag for a message
3273 that need not be replied to
3275 2003-08-01 Havoc Pennington <hp@pobox.com>
3277 * dbus/dbus-marshal.c: adapt to DBusObjectID changes
3278 (unpack_8_octets): fix no-64-bit-int bug
3280 * dbus/dbus-object-registry.c (validate_id): validate the
3281 connection ID bits, not just the instance ID.
3283 * dbus/dbus-connection.c (_dbus_connection_init_id): initialize
3284 the connection-global 33 bits of the object ID
3286 * dbus/dbus-object-registry.c (info_from_entry): fill in
3287 object ID in the new way
3289 * dbus/dbus-objectid.h: rather than high/low bits, specifically
3290 define server/client/instance bits.
3292 2003-07-30 Havoc Pennington <hp@pobox.com>
3294 * dbus/dbus-connection.c (dbus_connection_register_object): fix
3297 2003-07-13 Havoc Pennington <hp@pobox.com>
3299 * dbus/dbus-object.h (struct DBusObjectVTable): add padding
3300 fields to DBusObjectVTable and DBusObjectInfo
3302 2003-07-12 Havoc Pennington <hp@pobox.com>
3304 * dbus/dbus-object-registry.c: implement unit test,
3305 fix bugs discovered in process
3307 * dbus/dbus-connection.c: remove handler_table and
3308 register_handler(), add DBusObjectRegistry usage
3310 * dbus/dbus-objectid.c (dbus_object_id_is_null)
3311 (dbus_object_id_set_null): new functions
3313 2003-07-08 Havoc Pennington <hp@pobox.com>
3315 * dbus/dbus-object.c: implement some of this
3317 * dbus/dbus-object-registry.c
3318 (_dbus_object_registry_add_and_unlock): fill in the object_id out
3320 (_dbus_object_registry_new): handle OOM
3322 2003-07-08 Havoc Pennington <hp@pobox.com>
3324 * dbus/dbus-object.h: sketch out an API for registering objects
3325 with a connection, that allows us to use as little as 24 bytes
3326 per object and lets application code represent an object in
3327 any conceivable way.
3329 * dbus/dbus-object-registry.c: implement the hard bits of the
3330 DBusConnection aspect of object API. Not yet wired up.
3332 2003-07-06 Havoc Pennington <hp@pobox.com>
3334 * dbus/dbus-marshal.c (_dbus_marshal_set_object_id): new function
3335 (_dbus_marshal_object_id): new
3336 (_dbus_demarshal_object_id): new
3337 (_dbus_marshal_get_arg_end_pos): support object ID type, and
3338 consolidate identical switch cases. Don't conditionalize handling
3339 of DBUS_TYPE_UINT64, need to handle the type always.
3340 (_dbus_marshal_validate_arg): consolidate identical cases, and
3341 handle DBUS_TYPE_OBJECT_ID
3343 * dbus/dbus-objectid.c: new file with DBusObjectID data type.
3345 * dbus/dbus-protocol.h: add DBUS_TYPE_OBJECT_ID
3347 2003-09-28 Havoc Pennington <hp@pobox.com>
3351 2003-09-28 Havoc Pennington <hp@pobox.com>
3353 * doc/Makefile.am (dbus-specification.html): testing a funky hack
3354 to work with Debian db2html
3356 2003-09-28 Havoc Pennington <hp@pobox.com>
3358 * configure.in: 0.13
3360 * doc/Makefile.am (dbus-test-plan.html): accept nonexistence of
3361 stylesheet-images for benefit of Debian
3363 Change back to using filesystem-linked sockets for the system
3364 bus, so only root can create the default system bus address.
3366 * bus/system.conf.in: change to use
3367 DBUS_SYSTEM_BUS_DEFAULT_ADDRESS
3369 * dbus/Makefile.am (INCLUDES): remove DBUS_SYSTEM_BUS_PATH define
3372 * configure.in: define DBUS_SYSTEM_BUS_DEFAULT_ADDRESS
3373 here, and AC_DEFINE DBUS_SYSTEM_PATH
3375 2003-08-09 Anders Carlsson <andersca@codefactory.se>
3378 * doc/busconfig.dtd:
3381 2003-08-09 Anders Carlsson <andersca@codefactory.se>
3383 * doc/dbus-specification.sgml:
3384 Add activation reply values.
3386 2003-08-05 Havoc Pennington <hp@redhat.com>
3388 * configure.in: 0.12
3390 2003-08-05 Anders Carlsson <andersca@codefactory.se>
3392 * glib/dbus-gmain.c: (watch_fd_new), (watch_fd_ref),
3393 (watch_fd_unref), (dbus_gsource_check), (dbus_gsource_dispatch),
3394 (add_watch), (remove_watch), (create_source):
3395 Refcount fds, fixes some reentrancy issues.
3397 2003-07-30 Havoc Pennington <hp@redhat.com>
3399 * dbus/dbus-bus.c (init_connections_unlocked): fix default system
3400 bus address to be abstract if we have abstract sockets
3404 2003-07-28 Havoc Pennington <hp@redhat.com>
3406 * bus/messagebus.in: fix to avoid processname/servicename
3407 confusion, from Michael Kearey
3408 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=100965
3410 2003-07-23 Havoc Pennington <hp@pobox.com>
3412 * dbus/dbus-message.c (dbus_message_iter_get_named):
3413 fix from Andy Hanton to remove broken "+1"
3415 2003-07-16 Havoc Pennington <hp@pobox.com>
3417 * tools/dbus-launch.c (babysit): close stdout/stderr in the
3418 babysitter process, as suggested by Thomas Leonard, so
3419 an "eval `dbus-launch --exit-with-session`" will actually
3422 2003-07-16 Havoc Pennington <hp@pobox.com>
3424 * configure.in: print out EXPANDED_* variables in the summary at
3425 the end; clean up the code that computes EXPANDED_ variables and
3426 get the ones using exec_prefix right. Should make things work
3427 when you build without --prefix
3429 2003-06-29 Havoc Pennington <hp@pobox.com>
3431 * mono/Test.cs (class Test): fire up a main loop and run it
3433 * mono/DBus.cs (DBus): don't g_thread_init since it can only be
3434 done once, the app has to do it
3436 2003-06-26 Havoc Pennington <hp@pobox.com>
3438 * mono/Connection.cs: set up connection with the glib main loop
3440 2003-07-01 Havoc Pennington <hp@redhat.com>
3442 * doc/dbus-specification.sgml: clarify the format of a type code,
3443 change suggested by Jim Blandy
3445 2003-06-29 Miloslav Trmac <mitr@volny.cz>
3448 * tools/Makefile.am: Don't assume srcdir == builddir.
3450 * dbus/dbus-memory.c (dbus_realloc): Don't check guards after shrinking
3451 the allocated block.
3452 (_dbus_memory_test): New function.
3453 * dbus/dbus-test.h: Add _dbus_memory_test ().
3454 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): Call it.
3456 * dbus/dbus-message.c (decode_header_data): Use %.4s instead
3458 (dbus_message_new): Remove obsolete @todo.
3460 * dbus/dbus-marshal.c (_dbus_marshal_set_int64)
3461 (_dbus_marshal_set_uint64): Fix comment.
3463 * dbus/dbus-message.c (append_int_field, append_uint_field): Don't
3464 hardcode FIELD_REPLY_SERIAL.
3466 * dbus/dbus-mainloop.c (_dbus_loop_remove_watch)
3467 (_dbus_loop_remove_timeout): Cast function pointers to (void *) for %p
3469 * configure.in: Add -D_POSIX_C_SOURCE=199309L -DBSD_SOURCE to CFLAGS
3470 and disable DBUS_USE_ATOMIC_INT_486 when --enable-ansi is used
3472 2003-06-24 Havoc Pennington <hp@pobox.com>
3474 * mono/*.cs: Use IntPtr.Zero instead of ((IntPtr) 0)
3476 2003-06-23 Anders Carlsson <andersca@codefactory.se>
3482 * gcj/TestMessage.java: (TestMessage), (TestMessage.main):
3483 * gcj/org/.cvsignore:
3484 * gcj/org/Makefile.am:
3485 * gcj/org/freedesktop/.cvsignore:
3486 * gcj/org/freedesktop/Makefile.am:
3487 * gcj/org/freedesktop/dbus/.cvsignore:
3488 * gcj/org/freedesktop/dbus/Makefile.am:
3489 * gcj/org/freedesktop/dbus/Message.java: (Message),
3491 * gcj/org/freedesktop/dbus/natMessage.cc:
3492 Fix the build system.
3494 2003-06-22 Havoc Pennington <hp@pobox.com>
3496 * mono/Connection.cs: add more bindings
3498 * dbus/dbus-threads.c (dbus_threads_init): allow calling this
3501 2003-06-22 Havoc Pennington <hp@pobox.com>
3503 * mono/Connection.cs, mono/DBus.cs, mono/Error.cs:
3504 Start wrapping more stuff.
3506 2003-06-22 Havoc Pennington <hp@pobox.com>
3508 * mono/Message.cs: implement Message.Wrap() that ensures we only
3509 have a single C# wrapper per DBusMessage, assuming it works which
3510 it probably doesn't.
3512 * dbus/dbus-message.c (dbus_message_allocate_data_slot): new
3513 (dbus_message_free_data_slot): new
3514 (dbus_message_set_data): new
3515 (dbus_message_get_data): new
3517 2003-06-22 Havoc Pennington <hp@pobox.com>
3519 * dbus/dbus-dataslot.c (_dbus_data_slot_allocator_unref)
3520 (_dbus_data_slot_allocator_alloc): rework these to keep a
3521 reference count on each slot and automatically manage a global
3522 slot ID variable passed in by address
3524 * bus/bus.c: convert to new dataslot API
3526 * dbus/dbus-bus.c: convert to new dataslot API
3528 * dbus/dbus-connection.c: convert to new dataslot API
3530 * dbus/dbus-server.c: convert to new dataslot API
3532 * glib/dbus-gmain.c: ditto
3536 * bus/connection.c: ditto
3538 2003-06-22 Anders Carlsson <andersca@codefactory.se>
3540 * configure.in: Add AM_PROG_GCJ and move AM_PROG_LIBTOOL
3541 after the gcj checks so that the correct configuration tags
3542 will be added to libtool.
3544 * dbus-glib-1.pc.in: No need to specify any includes since
3545 dbus-1.pc.in has those.
3547 2003-06-22 Havoc Pennington <hp@pobox.com>
3549 * mono/*, gcj/*, configure.in, Makefile.am:
3550 Check in makefiles and subdirs for mono and gcj bindings.
3551 Neither binding actually exists, just trying to get through
3552 all the build and other boring bits.
3554 2003-06-21 Philip Blundell <philb@gnu.org>
3556 * tools/dbus-monitor.1: Updated.
3558 * tools/dbus-send.1: Likewise.
3560 2003-06-20 Anders Carlsson <andersca@codefactory.se>
3562 * dbus/dbus-transport-unix.c (unix_handle_watch): Check
3563 for hangup and error after checking read so we won't discard
3564 pending data if both hangup and read are set.
3566 2003-06-19 Philip Blundell <philb@gnu.org>
3568 * tools/dbus-print-message.c (print_message): Handle BOOLEAN.
3570 * tools/dbus-send.c: Accept both --system and --session.
3572 * tools/dbus-monitor.c: Same here.
3574 2003-06-19 Anders Carlsson <andersca@codefactory.se>
3576 * glib/dbus-glib.h: Fix so that dbus-glib.h can be used
3577 from C++ (Patch by Miloslav Trmac).
3579 2003-06-15 Joe Shaw <joe@assbarn.com>
3581 * configure.in: Check for socklen_t.
3583 * dbus/dbus-sysdeps.c: Define socklen_t if it's not defined.
3585 * test/test-segfault.c: Add #include <sys/time.h>
3587 * tools/Makefile.am: Add DBUS_X_CFLAGS to the INCLUDES since
3588 dbus-launch needs it.
3590 2003-06-09 Havoc Pennington <hp@redhat.com>
3592 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): don't use
3593 SUN_LEN, it breaks abstract socket usage
3595 * dbus/dbus-internals.c (_dbus_verbose_real): only print PID at
3598 2003-06-04 Havoc Pennington <hp@pobox.com>
3600 * dbus/dbus-server.c (dbus_server_listen): allow abstract sockets
3601 using unix:abstract=/foo, and when listening in a tmpdir
3602 i.e. unix:tmpdir=/tmp, always use abstract sockets if we can.
3604 * dbus/dbus-transport.c (_dbus_transport_open): support
3607 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
3608 support abstract sockets
3610 * dbus/dbus-transport-unix.c
3611 (_dbus_transport_new_for_domain_socket): support abstract sockets
3613 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket): add "abstract"
3614 toggle as an argument, implement abstract namespace support
3615 (_dbus_listen_unix_socket): ditto
3617 * configure.in: add --enable-abstract-sockets and implement
3618 a configure check for autodetection of the right value.
3620 2003-06-01 Havoc Pennington <hp@pobox.com>
3622 * tools/dbus-cleanup-sockets.c: add utility to clean up sockets
3623 in /tmp (though on Linux this will end up being useless,
3624 when we add abstract namespace support)
3626 * configure.in: define DBUS_SESSION_SOCKET_DIR in addition to
3629 2003-05-28 Colin Walters <walters@verbum.org>
3631 * tools/dbus-monitor.c (main): Fix silly typo (s/--session/--system/).
3633 2003-05-18 Anders Carlsson <andersca@codefactory.se>
3635 * dbus/dbus-message.c (dbus_message_new): Remove @todo.
3637 2003-05-17 Colin Walters <walters@gnu.org>
3639 * tools/dbus-send.c: Don't exit with an error code if --help was
3640 passed. Default to using the session bus instead of the system
3643 * tools/dbus-launch.c: Ditto.
3645 * tools/dbus-monitor.c: Ditto.
3647 * tools/dbus-send.1: Update with new arguments.
3649 * tools/dbus-launch.c: Emit code to export variables. New
3650 arguments -s and -c to specify shell syntax, and a bit of code to
3651 autodetect syntax. Also, allow specifying a program to run.
3653 * tools/dbus-launch.1: Update with new arguments.
3655 * tools/dbus-send.1: Ditto.
3657 * tools/dbus-monitor.1: Ditto.
3659 2003-05-17 Havoc Pennington <hp@pobox.com>
3661 * bus/config-parser.c (merge_included): merge in policies from
3662 child configuration file.
3664 * bus/policy.c (bus_policy_merge): function to merge two policies
3667 2003-05-16 Havoc Pennington <hp@redhat.com>
3669 * dbus/dbus-connection.c: disable verbose lock spew
3671 * tools/dbus-send.c: add --print-reply command line option
3673 * tools/dbus-print-message.h (print_message): new util function
3674 shared by dbus-send and dbus-monitor
3676 * tools/dbus-monitor.c (handler_func): exit on disconnect
3678 * dbus/dbus-transport-unix.c (do_reading): if the transport is
3679 disconnected, don't try to use the read_watch
3681 * dbus/dbus-watch.c (dbus_watch_get_enabled): assert watch != NULL
3682 so we can find this bug more easily
3684 2003-05-16 Havoc Pennington <hp@redhat.com>
3686 * bus/policy.c (free_rule_list_func): avoid a crash when passed
3687 NULL as DBusHashTable is annoyingly likely to do.
3689 2003-05-16 Colin Walters <walters@verbum.org>
3691 * tools/dbus-monitor.c: Add --session argument and usage()
3694 * tools/dbus-monitor.1: Update with new --session arg.
3696 * bus/Makefile.am (install-data-hook): Create
3697 $(libdir)/dbus-1.0/services so that the session bus is happy.
3699 2003-05-15 Havoc Pennington <hp@redhat.com>
3701 * dbus/dbus-sysdeps.c (_dbus_atomic_dec, _dbus_atomic_inc): work
3702 on non-x86. ifdef's are evil.
3704 2003-05-15 Havoc Pennington <hp@redhat.com>
3706 * configure.in: 0.11
3710 * bus/Makefile.am (initddir): apparently we are supposed to put
3711 init scripts in /etc/rc.d/init.d not /etc/init.d
3713 * bus/Makefile.am: remove the "you must --enable-tests to make
3714 check" as it broke distcheck
3716 * bus/Makefile.am (install-data-hook): create /etc/dbus-1/system.d
3718 2003-05-13 James Willcox <jwillcox@gnome.org>
3721 * bus/activation.c: (bus_activation_service_created),
3722 (bus_activation_activate_service):
3723 * bus/driver.c: (bus_driver_send_service_deleted),
3724 (bus_driver_send_service_created), (bus_driver_send_service_lost),
3725 (bus_driver_send_service_acquired),
3726 (bus_driver_send_welcome_message),
3727 (bus_driver_handle_list_services):
3728 * bus/session.conf.in:
3729 * dbus/dbus-bus.c: (dbus_bus_acquire_service),
3730 (dbus_bus_service_exists), (dbus_bus_activate_service):
3733 Add some convenience API which lets you activate a service, and did a
3734 bunch of s/0/DBUS_TYPE_INVALID/ in calls to dbus_message_append_args()
3735 and dbus_message_get_args()
3737 2003-05-11 Havoc Pennington <hp@pobox.com>
3739 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix to avoid
3740 calling _dbus_marshal_validate_arg() for every byte in a byte
3743 * dbus/dbus-message-handler.c: use atomic reference counting to
3744 reduce number of locks slightly; the global lock in here sucks
3746 * dbus/dbus-connection.c
3747 (_dbus_connection_update_dispatch_status_and_unlock): variant of
3748 update_dispatch_status that can be called with lock held; then use
3749 in a couple places to reduce locking/unlocking
3750 (dbus_connection_send): hold the lock over the whole function
3751 instead of acquiring it twice.
3753 * dbus/dbus-timeout.c (_dbus_timeout_new): handle OOM
3755 * bus/connection.c (bus_connections_setup_connection): fix access
3756 to already-freed memory.
3758 * dbus/dbus-connection.c: keep a little cache of linked list
3759 nodes, to avoid using the global linked list alloc lock in the
3760 normal send-message case. Instead we just use the connection lock
3761 that we already have to take.
3763 * dbus/dbus-list.c (_dbus_list_find_last): new function
3765 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec):
3766 change to use a struct for the atomic type; fix docs,
3767 they return value before increment, not after increment.
3769 * dbus/dbus-string.c (_dbus_string_append_4_aligned)
3770 (_dbus_string_append_8_aligned): new functions to try to
3771 microoptimize this operation.
3772 (reallocate_for_length): break this out of set_length(), to
3773 improve profile info, and also so we can consider inlining the
3776 * dbus/dbus-message.c (dbus_message_new_empty_header): init data
3777 strings with some preallocation, cuts down on our calls to realloc
3778 a fair bit. Though if we can get the "move entire string to empty
3779 string" optimization below to kick in here, it would be better.
3781 * dbus/dbus-string.c (_dbus_string_move): just call
3782 _dbus_string_move_len
3783 (_dbus_string_move_len): add a special case for moving
3784 an entire string into an empty string; we can just
3785 swap the string data instead of doing any reallocs.
3786 (_dbus_string_init_preallocated): new function
3788 2003-05-11 Havoc Pennington <hp@pobox.com>
3790 Write a "test-profile" that does echo client-server with threads;
3791 profile reveals lock contention, memcpy/realloc of buffers, and
3792 UTF-8 validation as hot spots. 20% of lock contention eliminated
3793 with dbus_atomic_inc/dec implementation on x86. Much remaining
3794 contention is global mempool locks for GList and DBusList.
3796 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec): add
3799 * dbus/dbus-connection.c (struct DBusConnection): use
3800 dbus_atomic_t for the reference count
3802 * dbus/dbus-message.c (struct DBusMessage): declare
3803 dbus_atomic_t values as volatile
3805 * configure.in: code to detect ability to use atomic integer
3806 operations in assembly, from GLib patch
3808 * dbus/dbus-internals.c (_dbus_verbose_real): call getpid every
3809 time, tired of it being wrong in threads and forked processes
3811 * glib/test-profile.c: a little program to bounce messages back
3812 and forth between threads and eat CPU
3814 * dbus/dbus-connection.c: add debug spew macros for debugging
3815 thread locks; include config.h at top; fix deadlock in
3816 dbus_connection_flush()
3818 2003-05-08 Havoc Pennington <hp@pobox.com>
3820 * dbus/dbus-spawn.c: s/_exit/exit/ because it was keeping gcov
3821 data from getting written, and there wasn't a good reason to
3824 * test/decode-gcov.c (mark_inside_dbus_build_tests): don't count
3825 dbus_verbose lines in test coverage
3826 (main): add list of functions sorted by # of untested blocks
3827 to the coverage report
3829 * dbus/dbus-mempool.c: put some test-only code in DBUS_BUILD_TESTS
3831 * dbus/dbus-marshal.c (_dbus_marshal_test): extend test coverage
3833 * dbus/dbus-message-handler.c (_dbus_message_handler_test):
3834 extend test coverage
3836 * test/data/auth/cancel.auth-script: test canceling an
3839 * dbus/Makefile.am: remove dbus-server-debug.[hc] for now, as they
3840 aren't used. in CVS history if we end up needing them.
3842 2003-05-04 Havoc Pennington <hp@pobox.com>
3844 * dbus/dbus-message-handler.c (_dbus_message_handler_test): add
3847 * dbus/dbus-marshal.c (_dbus_demarshal_string_array): fix this
3848 function, which assumed length was in # of strings, not bytes
3850 * dbus/dbus-message.c (_dbus_message_test): add tests for some
3853 * dbus/dbus-connection.c
3854 (_dbus_connection_queue_received_message): disable function for
3855 now, we are only using it in test mode
3857 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
3858 remove a mistaken FIXME
3860 2003-05-04 Havoc Pennington <hp@pobox.com>
3862 * dbus/dbus-connection.c (dbus_connection_preallocate_send):
3863 unlock mutex on successful return, patch from Anders Gustafsson
3865 2003-05-04 Havoc Pennington <hp@pobox.com>
3867 * dbus-glib-1.pc.in (Requires): fix dependencies, from
3870 2003-05-04 Havoc Pennington <hp@pobox.com>
3872 * tools/dbus-launch.c: implement
3874 * bus/main.c (main), bus/bus.c (bus_context_new):
3875 implement --print-pid and --fork
3877 2003-05-03 Havoc Pennington <hp@redhat.com>
3879 * dbus/dbus-address.c (dbus_parse_address): fix bug when a key in
3880 the address had no value, and add to test suite. Fix and
3881 regression test from Miloslav Trmac
3883 2003-05-03 Havoc Pennington <hp@pobox.com>
3885 * dbus/dbus-watch.c (dbus_watch_handle): warn and return if a
3886 watch is invalid when handled
3888 * tools/Makefile.am, tools/dbus-launch.c, tools/dbus-launch.1: add
3889 dbus-launch utility to launch the bus from a shell script. Didn't
3890 actually implement dbus-launch yet, it's just a placeholder still.
3892 2003-05-03 Havoc Pennington <hp@pobox.com>
3894 * bus/Makefile.am, bus/dbus-daemon-1.1.in: man page for the
3895 daemon; also documents daemon config file, so replaces
3896 doc/config-file.txt. Corrected some stuff from config-file.txt in
3897 the process of moving it.
3899 2003-05-03 Havoc Pennington <hp@pobox.com>
3901 * tools/Makefile.am, tools/dbus-send.1, tools/dbus-monitor.1:
3904 2003-05-03 Colin Walters <walters@verbum.org>
3906 * dbus/dbus-sysdeps.c (fill_user_info): Test against
3907 DBUS_UID_UNSET to determine whether to do a uid lookup or not.
3909 * Makefile.am: Update to use new .pc versioning scheme.
3911 2003-05-02 Havoc Pennington <hp@redhat.com>
3913 * bus/system.conf.in: allow send/receive to/from message bus
3916 2003-04-30 Havoc Pennington <hp@redhat.com>
3918 * configure.in: print a note when building with unit tests and
3921 2003-04-30 Havoc Pennington <hp@redhat.com>
3923 * Makefile.am: add a check-local that complains if you didn't
3924 configure with --enable-tests
3926 2003-04-29 Havoc Pennington <hp@redhat.com>
3928 * glib/dbus-gmain.c: docs cleanups
3930 * dbus/dbus-types.h: add docs on int64 types
3932 * dbus/dbus-memory.c: fix docs to avoid putting private API in
3933 public API docs section
3935 2003-04-29 Havoc Pennington <hp@redhat.com>
3937 * dbus-1.pc.in, dbus-glib-1.pc.in: rename these from
3938 dbus-1.0.pc.in, dbus-glib-1.0.pc.in. As these change with the
3939 parallel install API version, not with the D-BUS package version.
3941 * HACKING: move some of README over here
3943 * README: updates, and document API/ABI policy
3945 * configure.in: reindentation
3947 2003-04-29 Havoc Pennington <hp@redhat.com>
3949 * dbus/dbus.h: add "you have to define DBUS_API_SUBJECT_TO_CHANGE
3950 to use this library" to be sure people have the right
3953 2003-04-28 Havoc Pennington <hp@redhat.com>
3955 * configure.in: add --enable-docs which by default is auto yes if
3956 doxygen and db2html found, no otherwise; but can be forced on/off
3958 * doc/Makefile.am: conditionalize whether to build docs on
3961 2003-04-28 Havoc Pennington <hp@redhat.com>
3963 * configure.in: 0.10
3967 * bus/system.conf.in: add <includedir>system.d</includedir>
3969 * dbus/dbus-userdb.c (_dbus_user_database_lookup): fix bug when
3970 username was provided but not uid
3972 * bus/config-parser.c (struct BusConfigParser): keep track of
3973 whether the parser is toplevel or was included; change some
3974 of the error handling if it's included.
3976 2003-04-27 Havoc Pennington <hp@pobox.com>
3980 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
3981 report correct status if we finish processing authentication
3982 inside this function.
3984 * bus/activation.c (try_send_activation_failure): use
3985 bus_transaction_send_error_reply
3987 * bus/connection.c (bus_connection_get_groups): return an error
3988 explaining the problem
3990 * bus/bus.c (bus_context_check_security_policy): implement
3991 restriction here that inactive connections can only send the
3992 hello message. Also, allow bus driver to send anything to
3995 * bus/connection.c (bus_connection_complete): create the
3996 BusClientPolicy here instead of on-demand.
3997 (bus_connection_get_policy): don't return an error
3999 * dbus/dbus-message.c (dbus_message_new_error_reply): allow NULL
4000 sender field in message being replied to
4002 * bus/bus.c (bus_context_check_security_policy): fix silly typo
4003 causing it to return FALSE always
4005 * bus/policy.c (bus_client_policy_check_can_send): fix bug where
4006 we checked sender rather than destination
4008 2003-04-25 Havoc Pennington <hp@redhat.com>
4010 test suite is slightly hosed at the moment, will fix soon
4012 * bus/connection.c (bus_connections_expire_incomplete): fix to
4013 properly disable the timeout when required
4014 (bus_connection_set_name): check whether we can remove incomplete
4015 connections timeout after we complete each connection.
4017 * dbus/dbus-mainloop.c (check_timeout): fix this up a bit,
4018 probably still broken.
4020 * bus/services.c (bus_registry_acquire_service): implement max
4021 number of services owned, and honor allow/deny rules on which
4022 services a connection can own.
4024 * bus/connection.c (bus_connection_get_policy): report errors here
4026 * bus/activation.c: implement limit on number of pending
4029 2003-04-25 Havoc Pennington <hp@redhat.com>
4031 * dbus/dbus-transport.c (_dbus_transport_get_unix_user): fix bug
4032 where we used >= 0 instead of != DBUS_UID_UNSET.
4034 2003-04-25 Havoc Pennington <hp@redhat.com>
4036 * glib/dbus-gmain.c (remove_watch): fix for a crash when watches
4037 were toggled without add/remove, fix from Anders Gustafsson
4039 2003-04-24 Havoc Pennington <hp@redhat.com>
4041 * test/data/valid-config-files/basic.conf: add <limit> tags to
4044 * bus/config-parser.h, bus/config-parser.c, bus/bus.c: Implement
4045 <limit> tag in configuration file.
4047 2003-04-24 Havoc Pennington <hp@redhat.com>
4049 * bus/dispatch.c: somehow missed some name_is
4051 * dbus/dbus-timeout.c (_dbus_timeout_set_enabled)
4052 (_dbus_timeout_set_interval): new
4054 * bus/connection.c (bus_connections_setup_connection): record time
4055 when each connection is first set up, and expire them after the
4056 auth timeout passes.
4058 2003-04-24 Havoc Pennington <hp@redhat.com>
4060 * dbus/dbus-message.c (dbus_message_name_is): rename
4061 (dbus_message_service_is): rename
4062 (dbus_message_sender_is): rename
4063 (dbus_message_get_service): rename
4065 2003-04-24 Havoc Pennington <hp@redhat.com>
4067 * configure.in: add --enable-checks
4069 * dbus/dbus-message.c (dbus_message_new): reverse name/service arguments
4071 * dbus/dbus-connection.c (dbus_connection_preallocate_send): fix
4072 to use thread locks.
4073 (_dbus_connection_handler_destroyed_locked): move some private
4074 functions into proper docs group
4076 * dbus/dbus-internals.h: add _dbus_return_if_fail,
4077 _dbus_return_val_if_fail
4079 Throughout: use dbus_return_if_fail
4081 2003-04-23 James Willcox <jwillcox@gnome.org>
4084 * glib/dbus-gmain.c: (add_timeout), (wakeup_main), (create_source),
4085 (dbus_connection_setup_with_g_main),
4086 (dbus_server_setup_with_g_main):
4087 * glib/test-dbus-glib.c: (main):
4088 * glib/test-thread-client.c: (main):
4089 * glib/test-thread-server.c: (new_connection_callback), (main):
4090 * tools/dbus-monitor.c: (main):
4092 Added a GMainContext argument to dbus_connection_setup_with_g_main()
4093 and dbus_server_setup_with_g_main().
4095 2003-04-20 Havoc Pennington <hp@pobox.com>
4097 * doc/dbus-specification.sgml: document the restrictions on
4098 message and service names
4100 2003-04-22 Havoc Pennington <hp@redhat.com>
4102 * dbus/dbus-message.c, dbus/dbus-marshal.c: add 64-bit integer
4103 support, and do some code cleanups to share more code and
4104 speed up array marshal/demarshal.
4106 * dbus-1.0.pc.in (Cflags): put libdir include file in cflags
4108 * configure.in: generate dbus-arch-deps.h
4110 * dbus/dbus-protocol.h (DBUS_TYPE_INT64, DBUS_TYPE_UINT64): add
4113 2003-04-22 Havoc Pennington <hp@redhat.com>
4115 * test/data/valid-messages/opposite-endian.message: fix test
4116 to use proper type for rply field
4118 * test/data/invalid-messages: add tests for below validation
4120 * dbus/dbus-message.c (decode_header_data): validate field types,
4121 and validate that named fields are valid names
4122 (decode_name_field): consider messages in the
4123 org.freedesktop.Local. namespace to be invalid.
4125 * dbus/dbus-string.c (_dbus_string_validate_name): new
4127 2003-04-19 Havoc Pennington <hp@pobox.com>
4129 * bus/driver.c (bus_driver_handle_hello): check limits and
4130 return an error if they are exceeded.
4132 * bus/connection.c: maintain separate lists of active and inactive
4133 connections, and a count of each. Maintain count of completed
4134 connections per user. Implement code to check connection limits.
4136 * dbus/dbus-list.c (_dbus_list_unlink): export
4138 * bus/bus.c (bus_context_check_security_policy): enforce a maximum
4139 number of bytes in the message queue for a connection
4141 2003-04-18 Havoc Pennington <hp@pobox.com>
4143 * dbus/dbus-auth.c (record_mechanisms): memleak fixes
4145 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): fix some
4148 * dbus/dbus-keyring.c (add_new_key): fix a memleak, and
4149 on realloc be sure to update the pointer in the keyring
4151 * dbus/dbus-string.c (_dbus_string_zero): compensate for align
4152 offset to avoid writing to unallocated memory
4154 * dbus/dbus-auth.c (process_rejected): return FALSE if we fail to
4155 try the next mechanism, so we properly handle OOM
4157 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): fix double-free
4159 (_dbus_keyring_new): fix OOM bug
4160 (_dbus_keyring_new_homedir): always set error; impose a maximum
4161 number of keys we'll load from the file, mostly to speed up the
4162 test suite and make its OOM checks more useful, but also for
4165 * dbus/dbus-auth.c (process_error_server): reject authentication
4166 if we get an error from the client
4167 (process_cancel): on cancel, send REJECTED, per the spec
4168 (process_error_client): send CANCEL if we get an error from the
4171 2003-04-18 Havoc Pennington <hp@pobox.com>
4173 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix UMR in verbose
4176 * dbus/dbus-auth.c (handle_client_data_cookie_sha1_mech): fix OOM
4179 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): only whine
4180 about DBUS_TEST_HOMEDIR once
4182 * bus/Makefile.am (TESTS_ENVIRONMENT): put DBUS_TEST_HOMEDIR in
4185 * bus/dispatch.c (bus_dispatch_sha1_test): actually load sha1
4186 config file so we test the right thing
4188 Throughout: assorted docs improvements
4190 2003-04-18 Havoc Pennington <hp@pobox.com>
4192 * glib/dbus-gmain.c: adapt to watch changes
4194 * bus/bus.c, bus/activation.c, etc.: adjust to watch changes
4196 * dbus/dbus-server.h: remove dbus_server_handle_watch
4198 * dbus/dbus-connection.h: remove dbus_connection_handle_watch
4200 * dbus/dbus-watch.c (dbus_watch_handle): change DBusWatch to work
4201 like DBusTimeout, so we don't need dbus_connection_handle_watch
4204 2003-04-17 Havoc Pennington <hp@redhat.com>
4206 * dbus/dbus-userdb.c, dbus/dbus-sysdeps.c: redo all the passwd
4207 database usage so it all goes via the DBusUserDatabase cache.
4209 2003-04-17 Havoc Pennington <hp@redhat.com>
4211 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix logic so that if
4212 there was an OOM watch we skipped, we always return TRUE so we
4213 iterate again to have a look at it again. Fixes test suite hang.
4214 Code rearrangement also lets us lose some memset and only iterate
4215 over callbacks once.
4217 * bus/driver.c (bus_driver_handle_message): sense of test for
4220 2003-04-16 Havoc Pennington <hp@pobox.com>
4222 * doc/dbus-specification.sgml: make spec say serials are unsigned
4224 * dbus/dbus-message.h: change message serials to unsigned
4226 * dbus/dbus-connection.c: adapt to message serials being unsigned
4228 2003-04-15 Havoc Pennington <hp@pobox.com>
4230 * bus/bus.c: create and keep around a shared DBusUserDatabase
4233 * bus/connection.c (bus_connection_get_groups): don't cache
4234 groups for user in the connection object, since user database
4235 object now does that.
4237 2003-04-16 Havoc Pennington <hp@redhat.com>
4239 * dbus/dbus-message.c (_dbus_message_add_size_counter): keep a
4240 list of size counters
4241 (_dbus_message_loader_putback_message_link): put back a popped link
4243 * dbus/dbus-connection.c
4244 (dbus_connection_set_max_live_messages_size): rename
4246 (dbus_connection_get_outgoing_size): get size of outgoing
4248 (_dbus_connection_set_connection_counter): remove this cruft
4250 2003-04-14 Havoc Pennington <hp@redhat.com>
4252 * dbus/dbus-userdb.c: user database abstraction, mostly to get
4253 caching, but at some point we might want to be able to use a
4256 * bus/dispatch.c (bus_dispatch_sha1_test): add a test that uses
4257 SHA1 conf file to test the sha1 auth mechanism, since the regular
4258 test always uses EXTERNAL when available.
4261 test/data/valid-config-files/debug-allow-all-sha1.conf.in:
4262 add conf file that requires use of sha1 auth
4264 2003-04-13 Havoc Pennington <hp@pobox.com>
4266 * tools/dbus-send.c, tools/dbus-monitor.c: two utility programs
4267 from Philip Blundell to send messages and monitor them.
4269 2003-04-13 Havoc Pennington <hp@pobox.com>
4271 * dbus/dbus-mainloop.c: fix some reentrancy issues by refcounting
4274 * test/data/valid-config-files/debug-allow-all.conf.in: allow all
4277 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
4278 fix to only recover unused bytes if we're already authenticated
4279 (_dbus_transport_get_is_authenticated): fix to still mark us
4280 authenticated if there are unused bytes.
4282 * bus/dispatch.c: implement security policy checking
4284 * bus/connection.c (bus_transaction_send_from_driver): new
4286 * bus/bus.c (bus_context_check_security_policy): new
4288 * bus/dispatch.c (send_service_nonexistent_error): delete this,
4289 now we just set the DBusError and it gets converted to an error
4292 * bus/connection.c (allow_user_function): enable code using actual
4293 data from the config file
4295 * bus/policy.c (list_allows_user): handle wildcard rules for
4296 user/group connection perms
4298 2003-04-13 Havoc Pennington <hp@pobox.com>
4300 * bus/config-parser.c: Load up the BusPolicy and BusPolicyRules
4302 * dbus/dbus-sysdeps.c (_dbus_get_user_id): new function
4304 * bus/policy.c (bus_policy_append_mandatory_rule)
4305 (bus_policy_append_default_rule, bus_policy_append_user_rule)
4306 (bus_policy_append_group_rule): new functions
4308 2003-04-12 Havoc Pennington <hp@pobox.com>
4310 * bus/config-parser.c (bus_config_parser_new): fix a memleak
4312 * dbus/dbus-sysdeps.c: change DBusCredentials to use longs for
4313 the pid/gid/uid, just for paranoia.
4315 * test/break-loader.c (randomly_do_n_things): find a byte
4316 containing a type code, and randomly change it to a different
4319 2003-04-12 Havoc Pennington <hp@pobox.com>
4321 * bus/policy.h: change BusPolicy to be the thing from the config
4322 file, and rename old BusPolicy to BusClientPolicy
4324 * bus/bus.c, bus/connection.c, bus/config-parser.c: change to
4325 match change in how policy works
4327 * dbus/dbus-internals.h: mark assert_not_reached as
4328 __attribute((noreturn))__
4330 2003-04-11 Havoc Pennington <hp@redhat.com>
4332 * doc/dbus-specification.sgml: fix a spot with the wrong name for
4333 the broadcast service. Use boolean return for ServiceExists.
4335 2003-04-11 Havoc Pennington <hp@redhat.com>
4337 * configure.in: add another directory to look for qt in.
4339 2003-04-11 Havoc Pennington <hp@redhat.com>
4341 * AUTHORS: add Colin Walters
4343 2003-04-11 Havoc Pennington <hp@redhat.com>
4349 2003-04-11 Havoc Pennington <hp@redhat.com>
4351 * bus/messagebus.in: remove pid file when stopping the
4352 message bus, since the bus won't have privileges to remove it
4355 2003-04-11 Havoc Pennington <hp@redhat.com>
4357 * bus/bus.c (bus_context_new): move credentials change after
4360 2003-04-11 Havoc Pennington <hp@pobox.com>
4362 * test/decode-gcov.c: add "below average functions" to the
4363 coverage report, and change how some of the code works.
4365 * bus/test-main.c: bracket some stuff in DBUS_BUILD_TESTS so it's
4366 not in the coverage stats.
4368 * test/test-service.c (main): use _dbus_verbose not fprintf in a
4369 couple places so running the test suite doesn't result in megaspam.
4371 2003-04-11 Havoc Pennington <hp@pobox.com>
4373 * bus/dispatch.c (check_existent_service_activation): accept a no
4374 memory error in a place we didn't before
4376 * bus/test.c (bus_test_run_everything): remove hacky "do it twice
4377 in case the first one failed," since the test suite is less
4380 2003-04-10 Havoc Pennington <hp@pobox.com>
4382 * bus/dispatch.c (check_segfault_service_activation): add test
4383 for launching an executable that just crashes.
4385 * test/test-segfault.c (main): try setting coredumpsize to 0 so we
4386 don't leave a million cores. We'll see how portable this is.
4388 2003-04-10 Havoc Pennington <hp@pobox.com>
4390 * dbus/dbus-spawn.c (_dbus_spawn_async_with_babysitter): move all
4391 the possible parent failures before we fork, so that we don't
4392 fail to create a babysitter after creating the child.
4394 * bus/activation.c (bus_activation_activate_service): kill child
4395 if we don't successfully complete the activation.
4397 2003-04-10 Havoc Pennington <hp@redhat.com>
4399 * dbus/dbus-connection.c (dbus_connection_flush): don't spin on
4400 the connection if it's disconnected
4402 * bus/activation.c (bus_activation_service_created): use new
4403 transaction features to roll back removal of pending activation if
4404 we don't successfully create the service after all. Don't remove
4405 pending activation if the function fails.
4407 * dbus/dbus-list.c (_dbus_list_insert_before_link)
4408 (_dbus_list_insert_after_link): new code to facilitate
4411 * dbus/dbus-hash.c (_dbus_hash_table_insert_string_preallocated):
4412 new functionality, so we can preallocate the ability to insert
4415 * bus/connection.c (bus_transaction_add_cancel_hook): new function
4416 allowing us to put custom hooks in a transaction to be used for
4417 cancelling said transaction
4419 * doc/dbus-specification.sgml: add some discussion of secondary
4420 service owners, and disallow zero-length service names
4422 * bus/services.c (bus_registry_acquire_service): new function,
4423 splits out part of bus_driver_handle_acquire_service() and fixes
4424 a bug where we didn't remove the service doing the acquiring
4425 from the secondary queue if we failed to remove the current owner
4426 from the front of the queue.
4428 2003-04-10 Alexander Larsson <alexl@redhat.com>
4430 * doc/dbus-specification.sgml:
4431 s/org.freedesktop.Broadcast/org.freedesktop.DBus.Broadcast/
4433 2003-04-10 Alexander Larsson <alexl@redhat.com>
4438 Added files to cvsignore
4440 * dbus/dbus-message.h:
4441 * dbus/dbus-message.c: (dbus_message_iter_get_named):
4442 Make get_named() take two out argument and return a boolean.
4443 (dbus_message_iter_get_args_valist):
4444 Update usage of get_named().
4445 (dbus_message_iter_append_byte):
4447 (dbus_message_iter_append_named)
4449 (message_iter_test), (check_message_handling_type), (_dbus_message_test):
4452 2003-04-10 Alexander Larsson <alexl@redhat.com>
4454 * dbus/dbus-marshal.[ch]:
4455 Add array_type_pos argument to _dbus_marshal_validate_arg.
4456 Let you pass a NULL end_pos to _dbus_marshal_validate_type.
4458 * dbus/dbus-message.[ch]:
4459 Multi-dimensional arrays have full type specification in the
4460 outermost array. Iter code re-arranged to handle this.
4461 Added some more iter tests.
4463 * doc/dbus-specification.sgml:
4466 Update new array encoding description.
4467 Correct DBUS_SERVICE_FLAGS_REPLACE_EXISTING description.
4469 * test/data/invalid-messages/array-with-mixed-types.message:
4470 * test/data/valid-messages/array-of-array-of-uint32.message:
4471 Change to the new array format.
4473 * test/data/invalid-messages/too-short-dict.message:
4476 * test/data/valid-messages/recursive-types.message:
4477 Fix up and extend test.
4479 2003-04-10 Havoc Pennington <hp@pobox.com>
4481 * bus/dispatch.c: lots of fixes
4483 * dbus/dbus-mainloop.c (_dbus_loop_dispatch): export
4484 (_dbus_loop_iterate): remove old "quit if no callbacks" code,
4485 that was crack, broke the test service.
4487 * dbus/dbus-transport.c (_dbus_transport_open): fix error
4488 handling to avoid piling up errors if we get a failure on the
4491 * dbus/dbus-internals.c (_dbus_real_assert_not_reached): include
4492 pid in assertion failures.
4494 * dbus/dbus-mainloop.c (_dbus_loop_iterate): use static arrays up
4495 to some fixed size of file descriptor array. Don't return TRUE
4496 anytime a timeout exists, that led to lots of busy loop silliness
4499 2003-04-09 Havoc Pennington <hp@redhat.com>
4501 * dbus/dbus-mainloop.c (check_timeout): fix timeouts, I thought
4502 I'd checked this in earlier but hadn't.
4504 2003-04-09 Havoc Pennington <hp@redhat.com>
4506 * bus/dispatch.c (bus_dispatch_test): get a bit further through
4507 the activation test (man this is getting old!)
4509 2003-04-09 Havoc Pennington <hp@redhat.com>
4511 * test/test-utils.c: use dispatch status function to fix this up
4513 * bus/connection.c (connection_watch_callback): don't dispatch
4515 (connection_timeout_callback): don't dispatch from here
4516 (bus_connections_setup_connection): set the dispatch status function
4517 (bus_connection_disconnected): unset it
4519 * dbus/dbus-mainloop.c (_dbus_loop_queue_dispatch): new function
4520 used to add a connection to be dispatched
4521 (_dbus_loop_iterate): do the dispatching at the end of each
4524 * dbus/dbus-connection.c
4525 (dbus_connection_set_dispatch_status_function): new function
4526 allowing us to fix up main loop usage
4527 (_dbus_connection_last_unref): free all the various function
4529 (dbus_connection_dispatch): call the DispatchStatusFunction
4530 whenever this function returns
4531 (dbus_connection_handle_watch): call DispatchStatusFunction
4532 (dbus_connection_send_with_reply_and_block): call DispatchStatusFunction
4533 (reply_handler_timeout): call DispatchStatusFunction
4534 (dbus_connection_flush): call DispatchStatusFunction
4536 2003-04-09 Havoc Pennington <hp@redhat.com>
4538 * dbus/dbus-bus.c (dbus_bus_register): fix up error handling and
4541 * bus/dispatch.c (check_service_activated): fix bug in test
4543 * dbus/dbus-mainloop.c (check_timeout): fix this up
4545 * dbus/dbus-internals.c (_dbus_verbose_real): include PID in
4546 verbose output so we can sort out output from different processes,
4547 e.g. in the activation case.
4549 2003-04-08 Colin Walters <walters@gnu.org>
4551 * bus/bus.c (struct BusContext) [pidfile]: New member, to store
4553 (bus_context_new): Set it.
4554 (bus_context_unref): Use it to delete the pid file.
4556 2003-04-08 Havoc Pennington <hp@redhat.com>
4558 * test/data/invalid-messages/array-with-mixed-types.message:
4559 regression test that fails for the moment
4561 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): reorder
4562 tests for convenience
4564 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): don't allow
4565 array of nil, it broke things.
4567 * test/data/invalid-messages/array-of-nil.message: regression test
4569 * test/data/valid-messages/array-of-array-of-uint32.message:
4570 happened to write this so added it to suite
4572 2003-04-08 Havoc Pennington <hp@redhat.com>
4574 * bus/driver.c (bus_driver_handle_acquire_service): init
4575 retval/reply before checking name
4577 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add a
4578 recursion depth argument
4580 * dbus/dbus-message.h (struct DBusMessageIter): put some padding
4581 in the public struct for future extension
4583 * dbus/dbus-message-builder.c (_dbus_message_data_load): fix
4586 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix a verbose
4589 * doc/dbus-specification.sgml: fix typo
4591 2003-04-08 Alexander Larsson <alexl@redhat.com>
4593 Implemented recursive types, named types and new-style iters
4596 * glib/test-thread-client.c: (thread_func):
4597 * glib/test-thread-server.c: (handle_test_message):
4598 * test/test-service.c: (handle_echo):
4607 * dbus/dbus-internals.c: (_dbus_type_to_string):
4608 Update for new types.
4610 * dbus/dbus-marshal.[ch]:
4611 Implement recursive types and the new marshalling format.
4612 Remove hardcoded dict marshalling.
4613 Marshal named types.
4615 * dbus/dbus-message-builder.c:
4617 Remove references to old types
4619 * dbus/dbus-message.[ch]:
4620 New non-refcounted iter API that supports recursive iters.
4621 Use iters for appending, including support for recursive
4623 Add byte and named type support.
4624 Update everything to new marshalling formats.
4625 Add tests for new API.
4627 * dbus/dbus-protocol.h:
4628 Remove old array types.
4629 Add types: BYTE, ARRAY, DICT, NAMED
4631 * dbus/dbus-string.c:
4632 * dbus/dbus-sysdeps.c:
4633 Make parse_double locale safe.
4635 * dbus/dbus-test-main.c:
4641 * doc/dbus-specification.sgml:
4644 * test/data/incomplete-messages/missing-body.message:
4645 * test/data/invalid-messages/bad-boolean.message:
4646 * test/data/invalid-messages/bad-boolean-array.message:
4647 * test/data/invalid-messages/boolean-array-length-too-long.message-raw:
4648 * test/data/invalid-messages/boolean-has-no-value.message-raw:
4649 * test/data/invalid-messages/too-short-dict.message:
4650 * test/data/valid-messages/dict-simple.message:
4651 * test/data/valid-messages/dict.message:
4652 * test/data/valid-messages/emptiness.message:
4653 * test/data/valid-messages/lots-of-arguments.message:
4654 * test/data/valid-messages/no-padding.message:
4655 * test/data/valid-messages/recursive-types.message:
4656 Add missing NAME fields
4657 Fix up dicts & arrays
4659 * test/data/invalid-messages/dict-with-nil-value.message:
4660 Removed, this is not invalid anymore.
4662 * test/data/valid-messages/recursive-types.message:
4663 Add new test for deeply recursive types.
4665 2003-04-07 Havoc Pennington <hp@pobox.com>
4667 * bus/driver.c (bus_driver_handle_acquire_service): return an
4668 error if you try to acquire a service that starts with ':'
4670 2003-04-07 Havoc Pennington <hp@redhat.com>
4672 * doc/dbus-specification.sgml: require that base service names
4673 start with ':' and that the base service is created/deleted
4674 as first and last things a connection does on the bus
4676 * bus/dispatch.c (check_existent_service_activation): lots more
4677 work on the activation test; it doesn't fully pass yet...
4679 * test/test-service.c (main): fix so we don't memleak the
4680 connection to the message bus
4681 (filter_func): accept a message asking us to exit
4683 2003-04-06 Havoc Pennington <hp@pobox.com>
4685 * qt/Makefile.am (dbusinclude_HEADERS): install dbus-qt.h,
4688 * configure.in: fixes to Qt detection from Colin Walters
4690 * doc/Makefile.am: Only remove generated docbook dirs if they
4691 exist, from Colin Walters
4693 * dbus/dbus-bus.c: change how we set well-known connections to
4694 NULL, so that it works if a single connection is stored in
4695 two well-known array slots.
4697 * test/Makefile.am: remove a lot of stuff that isn't immediately
4698 useful, it's in CVS history if we want it.
4700 * test/test-service.c: use dbus-mainloop instead of that
4703 2003-04-06 Havoc Pennington <hp@pobox.com>
4705 * dbus/Makefile.am: split lists of sources into stuff that goes in
4706 the library, util functions that go in the lib and are also used
4707 elsewhere, and util functions that are used in tests/daemon but
4708 don't go in the lib.
4710 * dbus/dbus-mainloop.h, dbus/dbus-mainloop.c: move bus/loop.[hc]
4711 here so it can be used in test binaries also
4713 2003-04-06 Havoc Pennington <hp@pobox.com>
4715 * dbus/dbus-sysdeps.c (_dbus_become_daemon): write the pidfile
4716 here in the parent process, so we can return an error if it
4717 fails. Also, move some of the code into the child so the parent
4718 is less hosed if we fail midway through.
4720 * bus/bus.c (bus_context_new): move pidfile detection further up
4721 in the function, before we start overwriting sockets and such.
4723 * bus/messagebus.in: adjust this a bit, not sure if it will work.
4725 * configure.in: add --with-system-pid-file and --with-system-socket
4727 2003-04-06 Colin Walters <walters@verbum.org>
4729 * configure.in (DBUS_SYSTEM_PID_FILE): New variable.
4731 * bus/system.conf.in: Declare a pidfile.
4733 * bus/bus.c (bus_context_new): Test for an existing pid file, and
4734 create one (if appropriate).
4736 * bus/config-parser.c (enum ElementType) [ELEMENT_PIDFILE]: New.
4737 (struct BusConfigParser) [pidfile]: New.
4738 (element_type_to_name, merge_included, start_busconfig_child)
4739 (bus_config_parser_end_element, bus_config_parser_content): Handle it.
4740 (bus_config_parser_unref): Free it.
4741 (bus_config_parser_get_pidfile): New function.
4743 * bus/config-parser.h (_dbus_write_pid_file): Prototype.
4745 * dbus/dbus-errors.h (DBUS_ERROR_PIDFILE_EXISTS): New error.
4747 * dbus/dbus-sysdeps.c (_dbus_write_pid_file): New function.
4749 * dbus/dbus-sysdeps.h: Prototype it.
4751 2003-04-06 Havoc Pennington <hp@pobox.com>
4753 * bus/bus.c (bus_context_new): print the address in here, rather
4754 than in main(), because we need to do it before forking the daemon
4756 * bus/dispatch.c (send_service_nonexistent_error): set the sender
4757 on the service nonexistent error
4759 * bus/driver.c (bus_driver_handle_acquire_service): set the
4760 sender on the AcquireService reply
4762 * test/data/valid-config-files/debug-allow-all.conf.in: Make test
4763 server also listen on a UNIX socket so services can connect to it.
4765 2003-04-06 Havoc Pennington <hp@pobox.com>
4767 * dbus/dbus-threads.c: Redo how the fake debug mutexes are done
4768 so it detects deadlocks and also we actually init threads when
4771 2003-04-06 Havoc Pennington <hp@pobox.com>
4773 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
4774 save the domain socket name, and unlink it when we disconnect the
4775 server. Means that at least when we exit normally, we won't leave
4776 a bunch of junk in /tmp
4778 * dbus/dbus-transport-unix.c
4779 (_dbus_transport_new_for_domain_socket): code cleanup (nicer
4780 memory management). (I was making a real change here but then
4783 2003-04-06 Havoc Pennington <hp@pobox.com>
4785 * bus/bus.c (bus_context_new): fix wrong handling of
4786 server_data_slot_unref() in the error case.
4788 * dbus/dbus-internals.h (_dbus_assert): change so it passes
4789 "(condition) != 0" to _dbus_real_assert so that
4790 "_dbus_assert (pointer)" doesn't cause a warning
4792 * bus/main.c (main): accept --print-address option to print out
4793 the message bus address
4795 * dbus/dbus-sysdeps.c (_dbus_generate_random_ascii): export this
4797 * dbus/dbus-transport.c (_dbus_transport_open): special error for
4798 "tmpdir" option to unix: address on client side
4800 * dbus/dbus-server.c (dbus_server_listen): handle "tmpdir" option
4803 * configure.in (TEST_SOCKET_DIR): locate a temporary directory
4804 we can use to create sockets in the test suite.
4806 * bus/main.c (signal_handler): on SIGTERM, exit the daemon
4807 cleanly. To be used for testing.
4809 * dbus/dbus-spawn.c (babysit): use _dbus_set_signal_handler()
4811 * dbus/dbus-sysdeps.c (_dbus_set_signal_handler): new
4813 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
4814 handle trying to call this when there's no servers active
4816 2003-04-05 Havoc Pennington <hp@pobox.com>
4822 2003-04-05 Havoc Pennington <hp@pobox.com>
4824 * bus/bus.c (setup_server): fix this so dbus-daemon-1 doesn't
4825 crash on startup. Need to get "try starting the daemon"
4826 in the test suite I guess. ;-)
4828 * dbus/dbus-server.h, dbus/dbus-server.c: remove the stuff that
4829 tracked the number of open connections; it's better done in
4830 application-specific code as you want it to span all servers etc.
4832 2003-04-05 Havoc Pennington <hp@pobox.com>
4834 * bus/Makefile.am (install-data-hook): add missing DESTDIR,
4835 patch from Colin Walters
4837 2003-04-05 Havoc Pennington <hp@pobox.com>
4839 * doc/config-file.txt (Elements): fix docs of <auth> to reflect
4840 reality; in fact multiple mechanisms are allowed.
4842 * dbus/dbus-internals.c (_dbus_real_assert)
4843 (_dbus_real_assert_not_reached): move guts of _dbus_assert() and
4844 _dbus_assert_not_reached() into functions, so that they don't show
4845 up in basic block counts for test coverage, and don't use up as
4846 much disk space. Does mean slower execution speed though, so
4847 assumes --disable-asserts is the normal production case.
4849 2003-04-05 Havoc Pennington <hp@pobox.com>
4851 * test/Makefile.am (dist-hook): also dist *.in files
4857 2003-04-05 Havoc Pennington <hp@pobox.com>
4859 * dbus/dbus-string.c: docs warning
4861 * dbus/dbus-spawn.c: missing docs
4863 * dbus/dbus-memory.c (struct ShutdownClosure): missing docs
4865 2003-04-05 Havoc Pennington <hp@pobox.com>
4867 * bus/loop.c (bus_loop_iterate): fix the timeout code, using
4870 * dbus/dbus-spawn.c (_dbus_babysitter_unref): set sitter_pid
4871 to -1 once we've reaped the babysitter
4872 (_dbus_babysitter_handle_watch): do as much work as we can, not
4875 * bus/activation.c: add code using DBusBabysitter so that we
4876 handle it when a service fails to start up properly.
4877 (bus_activation_service_created): don't remove the activation
4878 entries as we go, just let them get removed when we free the pending
4879 activation. Unref reply messages after sending them.
4881 2003-04-05 Havoc Pennington <hp@pobox.com>
4883 * test/decode-gcov.c (main): print per-directory stats in the report
4885 * Makefile.am (coverage-report.txt): don't include test/* in gcov stats
4887 2003-04-05 Havoc Pennington <hp@pobox.com>
4889 * Makefile.am (coverage-report.txt): add target "coverage-report.txt"
4891 * test/decode-gcov.c: hack up a little program to suck data
4892 out of gcov files. Yes this is sort of silly.
4894 * configure.in: define something in config.h and do an
4895 AM_CONDITIONAL when gcov is enabled
4897 2003-04-04 Havoc Pennington <hp@redhat.com>
4899 * dbus/dbus-spawn.c, dbus/dbus-spawn.h: Change dbus_spawn to
4900 return a "babysitter" object that is used to monitor the status of
4901 the spawned process and reap it when required.
4903 * test/test-segfault.c, test/test-exit.c,
4904 test/test-sleep-forever.c: binaries that do various lame things,
4905 used in the test suite.
4907 * dbus/dbus-sysdeps.c: kill _dbus_errno_to_string()
4909 2003-04-03 Havoc Pennington <hp@pobox.com>
4911 * dbus/dbus-spawn.c: Move dbus-spawn into a separate file
4912 in preparation for modifying it, dbus-sysdeps is getting
4915 2003-04-03 Havoc Pennington <hp@redhat.com>
4917 * bus/loop.h, bus/loop.c: make the mainloop an object so we can
4920 * bus/*.[hc]: adapt to mainloop change
4922 2003-04-03 Havoc Pennington <hp@redhat.com>
4924 * bus/activation.c (load_directory): fix up memleaks
4925 (bus_activation_entry_free): free the entry
4927 * dbus/dbus-bus.c (dbus_bus_acquire_service): return an error if
4928 we get one from the message bus; fix memleaks.
4930 * dbus/dbus-message.c (dbus_set_error_from_message): new function
4932 2003-04-03 Havoc Pennington <hp@pobox.com>
4934 * bus/config-parser.c (bus_config_parser_unref): free
4935 list of mechanisms, bug discovered by test suite enhancements
4936 (putting system.conf and session.conf into suite)
4938 * test/Makefile.am, test/test-service.c: add placeholder for a
4939 test service that we'll activate as part of test suite. Doesn't
4942 * dbus/dbus-sysdeps.c (_dbus_setenv): support unsetenv by
4943 setting NULL value, and use system malloc not dbus_malloc()
4944 when we have unavoidable memleakage.
4946 * dbus/dbus-bus.c (dbus_bus_get): fix bug where bus type of 0
4947 didn't work, and support DBUS_BUS_ACTIVATION.
4949 * bus/activation.c (child_setup): pass our well-known bus type to
4952 * bus/config-parser.c: support <type> to specify well-known type
4954 * doc/dbus-specification.sgml: document the env variables to
4955 locate well-known buses and find service activator
4957 2003-04-02 Havoc Pennington <hp@redhat.com>
4959 * test/Makefile.am (all-local): add a rule to copy tests to
4960 builddir, so we can have generated tests. Use this to remove the
4961 silly hack for testing system.conf and session.conf. Will use this
4962 shortly to generate .service files pointing to test binaries.
4964 2003-04-02 Havoc Pennington <hp@redhat.com>
4966 * dbus/dbus-string.c (set_length): fix a bug - we allocated max of
4967 current alloc and needed new length, not max of the doubled
4968 allocation and needed new length. Also, when building tests,
4969 don't do the double-allocation stuff, just realloc every time.
4971 2003-04-02 Havoc Pennington <hp@redhat.com>
4973 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): include filenames
4975 (_dbus_string_get_dirname): new
4976 (_dbus_sysdeps_test): new
4977 (_dbus_directory_open): include dirnames in error messages
4979 * bus/config-parser.c: interpret <include> and <includedir> and
4980 <servicedir> relative to config file location if the given
4981 filename is not absolute.
4983 * dbus/dbus-string.c (_dbus_string_find_byte_backward): new
4985 2003-04-02 Havoc Pennington <hp@redhat.com>
4987 * bus/connection.c (bus_transaction_send_error_reply): set sender
4988 service for the error, and unref the reply on success
4990 * bus/activation.c: convert to use BusTransaction so OOM can be
4992 (bus_activation_service_created): set sender of the message
4994 2003-04-01 Havoc Pennington <hp@redhat.com>
4996 * bus/config-parser.c, bus/bus.c: implement <servicedir> and
4997 <includedir> (at least mostly)
4999 * dbus/dbus-sysdeps.c (_dbus_change_identity): set the group ID
5000 first, then the user ID
5002 2003-04-01 Havoc Pennington <hp@pobox.com>
5004 * dbus/dbus-server.c (dbus_server_set_auth_mechanisms): new
5007 * dbus/dbus-auth.c (_dbus_auth_set_mechanisms): new
5009 * dbus/dbus-internals.c (_dbus_dup_string_array): new function
5011 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): chmod the
5012 socket 0777, and unlink any existing socket.
5014 * bus/bus.c (bus_context_new): change our UID/GID and fork if
5015 the configuration file so specifies; set up auth mechanism
5018 * bus/config-parser.c (bus_config_parser_content): add support
5019 for <fork> option and fill in code for <auth>
5021 * bus/system.conf.in: add <fork/> to default configuration,
5022 and limit auth mechanisms to EXTERNAL
5024 * doc/config-file.txt (Elements): add <fork>
5026 * dbus/dbus-sysdeps.c (_dbus_become_daemon): new function
5027 (_dbus_change_identity): new function
5029 2003-03-31 Havoc Pennington <hp@redhat.com>
5031 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket)
5032 (_dbus_listen_unix_socket): fix off-by-one error in null
5033 termination spotted by Nalin
5035 2003-03-31 Havoc Pennington <hp@redhat.com>
5037 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): allow setting
5038 DBUS_TEST_HOMEDIR when tests are enabled, so we can test without
5039 having a real home directory available.
5041 2003-03-31 Havoc Pennington <hp@redhat.com>
5043 * bus/Makefile.am (install-data-hook): create /var/run/dbus
5045 * bus/messagebus.in: add init script for Red Hat /etc/init.d
5047 * configure.in: add support for specifying a style of init script
5050 2003-03-31 Havoc Pennington <hp@redhat.com>
5052 Fix some annoying DBusString API and fix all affected code.
5054 * dbus/dbus-string.c (_dbus_string_init): get rid of annoying
5056 (_dbus_string_get_data): change to return string instead of using
5058 (_dbus_string_get_const_data): ditto
5059 (_dbus_string_get_data_len): ditto
5060 (_dbus_string_get_const_data_len): ditto
5062 2003-03-31 Havoc Pennington <hp@redhat.com>
5064 * bus/main.c (main): fix up the command line arguments to be nicer
5066 2003-03-31 Havoc Pennington <hp@redhat.com>
5068 * dbus/Makefile.am (INCLUDES): use EXPANDED_LOCALSTATEDIR to
5069 define DBUS_SYSTEM_BUS_PATH as we want to compile in the same
5070 final location that lands in the config file
5072 * bus/config-loader-expat.c (bus_config_load): fix type of
5075 * doc/TODO: remove TODO item for dbus_bus_get()
5077 * dbus/dbus-bus.c (bus_data_free): add missing lock/unlock
5079 2003-03-31 Havoc Pennington <hp@pobox.com>
5081 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_domain_socket)
5082 (_dbus_transport_new_for_tcp_socket): these didn't need the "server"
5083 argument since they are always client side
5085 * dbus/dbus-server.c (dbus_server_get_address): new function
5087 * bus/main.c (main): take the configuration file as an argument.
5089 * test/data/valid-config-files/debug-allow-all.conf: new file to
5090 use with dispatch.c tests for example
5092 * bus/test-main.c (main): require test data dir
5094 * bus/bus.c (bus_context_new): change this to take a
5095 configuration file name as argument
5097 * doc/config-file.txt (Elements): add <servicedir>
5099 * bus/system.conf, bus/session.conf: new files
5101 * dbus/dbus-bus.c (dbus_bus_get): look for system bus on
5102 well-known socket if none set
5104 * configure.in: create system.conf and session.conf
5106 2003-03-30 Havoc Pennington <hp@pobox.com>
5108 * bus/config-parser.c: hacking
5110 * dbus/dbus-memory.c: don't use DBusList for the list of stuff
5111 to shut down, since it could cause weirdness with the DBusList
5114 * dbus/dbus-list.c (_dbus_list_test): add tests for the
5115 link-oriented stack routines
5116 (alloc_link): free the mempool if the first alloc from it fails
5118 * dbus/dbus-mempool.c (struct DBusMemBlock): fix alignment issue
5120 * dbus/dbus-string.c (UNICODE_VALID): sync new version of this
5122 (_dbus_string_skip_white): new
5124 * doc/config-file.txt (Elements): add <includedir>
5126 2003-03-28 Havoc Pennington <hp@pobox.com>
5128 * dbus/dbus-string.c (_dbus_string_copy_data_len)
5129 (_dbus_string_copy_data): new functions
5131 2003-03-28 Anders Carlsson <andersca@codefactory.se>
5133 * dbus/dbus-bus.c: (bus_data_free), (dbus_bus_get):
5137 * dbus/dbus-memory.c:
5140 2003-03-28 Havoc Pennington <hp@pobox.com>
5142 * bus/test.c (bus_test_flush_bus): remove the sleep from here,
5143 I think it may have just been superstition. Not sure.
5145 * dbus/dbus-string.c (_dbus_string_base64_decode): catch some OOM
5146 failures that were not being handled.
5148 * dbus/dbus-auth.c (process_auth): fix a memleak in OOM handling
5150 * dbus/dbus-memory.c: add ability to set number of mallocs in a
5151 row that will fail on out-of-memory.
5153 * dbus/dbus-internals.c (_dbus_test_oom_handling): convenience
5154 function for testing out-of-memory handling.
5156 * bus/config-loader-expat.c (memsuite): don't wrap the dbus
5157 allocation functions, they do map exactly to the expat ones.
5159 2003-03-27 Havoc Pennington <hp@redhat.com>
5161 * bus/config-loader-libxml.c (bus_config_load): add another error
5164 2003-03-26 Anders Carlsson <andersca@codefactory.se>
5167 Add note about automatic service activation.
5169 * doc/dbus-specification.sgml:
5170 Rename the specification and clarify a few things.
5172 2003-03-26 Anders Carlsson <andersca@codefactory.se>
5175 * dbus/dbus-address.c:
5177 * dbus/dbus-marshal.c:
5178 * dbus/dbus-server-debug-pipe.c:
5179 * dbus/dbus-transport-unix.c:
5180 Fix documentation warnings.
5182 2003-03-26 Havoc Pennington <hp@pobox.com>
5184 * bus/test-main.c, dbus/dbus-test.c (main): check memleaks
5185 after every test so it's quick and easy to see which leaked, and
5186 so we test multiple dbus_shutdown() calls
5188 * configure.in: change configure.in XML stuff to also support
5191 * config-loader-libxml.c: some hacking
5193 * config-loader-expat.c: some hacking
5195 * config-parser.c: some hacking, plus tests
5197 2003-03-25 Havoc Pennington <hp@redhat.com>
5199 * throughout - add more _DBUS_ASSERT_ERROR_IS_CLEAR
5201 * configure.in: add --with-xml option to specify XML library,
5202 right now only libxml is supported.
5204 * bus/config-loader-libxml.c, config-parser.c: sync some minor
5205 nonworking code between home and work, still just stubs
5207 2003-03-24 Havoc Pennington <hp@redhat.com>
5209 * dbus/dbus-sysdeps.c (_dbus_set_fd_nonblocking): move to this
5212 * dbus/dbus-errors.c (dbus_set_error, dbus_set_error_const): allow
5213 NULL argument for "message" if the error is a well-known one,
5214 fill in a generic message in this case.
5216 * dbus/dbus-errors.h (DBusResultCode): Kill DBusResultCode in
5219 * bus/test.c (bus_test_flush_bus): add
5221 * bus/policy.c (bus_policy_test): test code stub
5223 2003-03-24 Havoc Pennington <hp@pobox.com>
5225 * bus/connection.c (bus_connections_setup_connection): set up
5226 the "can this user connect" function, but it always returns
5227 TRUE until we have a config file parser so we can have a config
5228 file that allows connections.
5230 2003-03-23 Havoc Pennington <hp@pobox.com>
5232 * dbus/dbus-threads.c (dbus_mutex_new, dbus_condvar_new): with
5233 DBUS_BUILD_TESTS, actually alloc/free a block of memory for
5234 the mutex, so we can check for proper memory management
5237 * dbus/dbus-dataslot.c: remove the mutex from
5238 DBusDataSlotAllocator and lock it manually when using it,
5239 to simplify fitting it into the global slots framework.
5241 * dbus/dbus-threads.c (init_static_locks): rework how we're
5242 handling global locks so they are easily shut down.
5244 * bus/policy.c (bus_policy_append_rule): fix
5246 * bus/test-main.c (main): check for memleaks
5248 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): make
5249 test suite check for memleaks
5251 * dbus/dbus-memory.c: add support in test mode for tracking
5252 number of outstanding blocks
5254 2003-03-23 Havoc Pennington <hp@pobox.com>
5256 * bus/policy.c, bus/bus.c, bus/connection.c: implement allow/deny
5259 * dbus/dbus-hash.h: add ULONG hash keys
5261 * dbus/dbus-sysdeps.c (_dbus_get_groups): new
5262 (_dbus_get_group_id): new function
5264 2003-03-20 Havoc Pennington <hp@redhat.com>
5266 * dbus/dbus-connection.c (dbus_connection_set_unix_user_function):
5268 (dbus_connection_get_unix_user): new function
5270 2003-03-20 Havoc Pennington <hp@pobox.com>
5272 * bus/connection.c (bus_connection_send_oom_error): assert that
5273 message has a sender
5274 (connection_execute_transaction): ditto
5275 (bus_connection_preallocate_oom_error): fix to set the sender, and
5276 set recipient to the destination service, not the bus driver
5278 * bus/policy.c: hacking
5280 * dbus/dbus-message.c (dbus_message_service_is): new function
5281 (dbus_message_sender_is): new
5283 2003-03-19 Havoc Pennington <hp@redhat.com>
5285 * bus/policy.c: start sketching code for policy restrictions on
5286 what connections can do.
5288 2003-03-18 Havoc Pennington <hp@redhat.com>
5290 * doc/TODO: some notes on high-level todo items. Little nitpick
5291 stuff is all in @todo, so no need to add it here.
5293 * doc/config-file.txt: some notes on how config file might look
5295 2003-03-18 Anders Carlsson <andersca@codefactory.se>
5301 2003-03-17 Havoc Pennington <hp@redhat.com>
5303 * dbus/dbus-internals.h: add gcc attributes so that
5304 our printf-style functions warn on bad arguments to
5307 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): fix printf
5310 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
5313 2003-03-17 Havoc Pennington <hp@redhat.com>
5315 * bus/test-main.c (main): make it print something as it runs
5316 so make check doesn't look stuck
5318 * doc/negotiation.txt, doc/dbus-sasl-profile.txt: remove
5319 from CVS, now obsolete
5321 2003-03-17 Anders Carlsson <andersca@codefactory.se>
5323 * bus/dispatch.c: (bus_dispatch):
5324 Refetch the service name since it may have been reallocated
5325 when dbus_message_set_sender was called.
5327 * dbus/dbus-sysdeps.c: (_dbus_accept):
5328 Add address and address length variables and use them to stop
5329 valgrind from complaining.
5331 2003-03-17 Havoc Pennington <hp@pobox.com>
5333 All tests pass, no memleaks, no valgrind complaints.
5335 * bus/test.c: refcount handler_slot
5337 * bus/connection.c (bus_connections_new): refcount
5338 connection_data_slot
5340 * dbus/dbus-auth-script.c (_dbus_auth_script_run): delete unused
5341 bytes so that auth scripts pass.
5343 * bus/dispatch.c: init message_handler_slot so it gets allocated
5346 * bus/dispatch.c (message_handler_slot_ref): fix memleak
5348 * dbus/dbus-server-debug-pipe.c (_dbus_server_debug_pipe_new):
5349 dealloc server_pipe_hash when no longer used for benefit of
5352 * dbus/dbus-auth.c (process_command): memleak fix
5354 * bus/dispatch.c (check_hello_message): memleak fix
5356 2003-03-16 Havoc Pennington <hp@pobox.com>
5358 * dbus/dbus-bus.c (ensure_bus_data): fix double-unref of the data slot
5360 2003-03-17 Anders Carlsson <andersca@codefactory.se>
5362 * bus/activation.c (bus_activation_activate_service): Append
5363 the pending activation entry to the list of pending activations.
5365 2003-03-16 Havoc Pennington <hp@pobox.com>
5367 * bus/dispatch.c (bus_dispatch_test): remove double-unrefs of
5370 * dbus/dbus-address.c (create_entry): fix OOM handling when
5371 failing to alloc entry->method
5373 2003-03-16 Havoc Pennington <hp@pobox.com>
5375 * dbus/dbus-watch.c (_dbus_watch_new): handle failure to malloc
5378 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
5379 add some missing dbus_set_result
5381 * bus/dispatch.c (bus_dispatch_add_connection): handle failure to
5382 alloc the DBusMessageHandler
5384 * dbus/dbus-transport.c (_dbus_transport_disconnect): don't ref
5385 the transport here, since we call this from the finalizer; it
5386 resulted in a double-finalize.
5388 * dbus/dbus-transport.c (_dbus_transport_disconnect): fix a bug
5389 where we tried to use transport->connection that was NULL,
5390 happened when transport was disconnected early on due to OOM
5392 * bus/*.c: adapt to handle OOM for watches/timeouts
5394 * dbus/dbus-transport-unix.c: port to handle OOM during
5397 * dbus/dbus-auth.c (_dbus_auth_get_unused_bytes): return a
5398 reference to unused bytes instead of a copy
5400 * dbus/dbus-server.c (dbus_server_handle_watch): return FALSE for
5403 * dbus/dbus-connection.c (dbus_connection_handle_watch): return
5406 * dbus/dbus-timeout.c (dbus_timeout_handle): return FALSE for out
5409 2003-03-16 Anders Carlsson <andersca@codefactory.se>
5411 * doc/dbus-specification.sgml:
5412 Document reply message for ActivateService.
5414 2003-03-16 Anders Carlsson <andersca@codefactory.se>
5416 * bus/activation.c: (bus_pending_activation_entry_free),
5417 (bus_pending_activation_free), (bus_activation_new),
5418 (bus_activation_unref), (bus_activation_service_created),
5419 (bus_activation_activate_service):
5421 * bus/bus.c: (bus_context_new):
5422 * bus/desktop-file.c: (new_section):
5423 * bus/driver.c: (bus_driver_send_service_deleted),
5424 (bus_driver_handle_activate_service):
5425 * bus/services.c: (bus_registry_new), (bus_registry_ensure):
5427 * dbus/dbus-connection.c:
5428 (dbus_connection_send_with_reply_and_block):
5429 * dbus/dbus-message.c: (dbus_message_append_args_valist):
5430 * dbus/dbus-protocol.h:
5431 Make activation work better. Now pending activations will be queued
5432 and the daemon won't try to activate services that are already registered.
5434 2003-03-16 Havoc Pennington <hp@pobox.com>
5436 * dbus/dbus-bus.c (ensure_bus_data): handle failure to set
5439 * dbus/dbus-memory.c (_dbus_initialize_malloc_debug): support
5440 DBUS_MALLOC_BACKTRACES to print trace when failing an alloc
5442 2003-03-16 Havoc Pennington <hp@pobox.com>
5444 * dbus/dbus-string.c (_dbus_string_validate_utf8): oops, unbreak
5445 this. always run the test suite before commit...
5447 * bus/*: adapt to DBusConnection API changes
5449 * glib/dbus-gmain.c: adapt to DBusConnection API changes,
5450 requires renaming stuff to avoid dbus_connection_dispatch name
5453 * dbus/dbus-transport.c (_dbus_transport_queue_messages): new
5456 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
5457 separate from _dbus_message_loader_return_buffer()
5459 * dbus/dbus-connection.c (dbus_connection_get_n_messages): remove
5460 this, because it's now always broken to use; the number of
5461 messages in queue vs. the number still buffered by the message
5462 loader is undefined/meaningless. Should use
5463 dbus_connection_get_dispatch_state().
5464 (dbus_connection_dispatch): rename from
5465 dbus_connection_dispatch_message
5467 2003-03-16 Havoc Pennington <hp@pobox.com>
5469 * dbus/dbus-string.c (_dbus_string_validate_utf8): copy in a real
5472 2003-03-16 Anders Carlsson <andersca@codefactory.se>
5474 * dbus/dbus-connection.c:
5475 (dbus_connection_send_with_reply_and_block):
5476 Decrease connection->n_incoming when removing an entry
5478 * dbus/dbus-dict.c: (dbus_dict_entry_free),
5479 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
5480 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
5481 (dbus_dict_set_byte_array), (dbus_dict_set_string_array),
5482 (dbus_dict_get_boolean_array), (dbus_dict_get_double_array),
5483 (dbus_dict_get_byte_array):
5484 Handle NULL arrays and strings. Also add support for byte arrays.
5486 * dbus/dbus-marshal.c: (_dbus_marshal_byte_array),
5487 (_dbus_marshal_dict), (_dbus_demarshal_byte_array),
5488 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
5489 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
5490 (_dbus_demarshal_dict), (demarshal_and_validate_len),
5491 (_dbus_marshal_validate_arg), (_dbus_marshal_test):
5492 * dbus/dbus-marshal.h:
5493 Add support for marshalling and demarshalling empty arrays and strings.
5495 * dbus/dbus-message.c: (dbus_message_append_args_valist),
5496 (dbus_message_append_string_array),
5497 (dbus_message_iter_get_boolean),
5498 (dbus_message_iter_get_boolean_array),
5499 (dbus_message_iter_get_int32_array),
5500 (dbus_message_iter_get_uint32_array),
5501 (dbus_message_iter_get_double_array),
5502 (dbus_message_iter_get_byte_array),
5503 (dbus_message_iter_get_string_array), (dbus_message_iter_get_dict),
5504 (check_message_handling):
5505 Add support for getting empty arrays and dicts.
5507 * dbus/dbus-string.c: (_dbus_string_validate_utf8):
5508 Don't do any validation at all for now, that's better than just checking
5511 * test/data/valid-messages/emptiness.message:
5512 New test message with lots of empty arrays.
5514 2003-03-16 Havoc Pennington <hp@pobox.com>
5516 * dbus/dbus-connection.c
5517 (_dbus_connection_queue_received_message_link): new function that
5518 can't fail due to OOM
5520 * dbus/dbus-message.c (_dbus_message_loader_pop_message_link):
5521 new function pops a message together with a list link
5524 * dbus/dbus-transport-unix.c (queue_messages): use new link-based
5525 message queuing functions to avoid needing to alloc memory
5527 2003-03-16 Havoc Pennington <hp@pobox.com>
5529 Oops - test code was only testing failure of around 30 of the
5530 mallocs in the test path, but it turns out there are 500+
5531 mallocs. I believe this was due to misguided linking setup such
5532 that there was one copy of dbus_malloc etc. in the daemon and one
5533 in the shared lib, and only daemon mallocs were tested. In any
5534 case, the test case now tests all 500+ mallocs, and doesn't pass
5535 yet, though there are lots of fixes in this patch.
5537 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
5538 this so that it doesn't need to allocate memory, since it
5539 has no way of indicating failure due to OOM (and would be
5540 annoying if it did).
5542 * dbus/dbus-list.c (_dbus_list_pop_first_link): new function
5544 * bus/Makefile.am: rearrange to create two self-contained
5545 libraries, to avoid having libraries with overlapping symbols.
5546 that was resulting in weirdness, e.g. I'm pretty sure there
5547 were two copies of global static variables.
5549 * dbus/dbus-internals.c: move the malloc debug stuff to
5552 * dbus/dbus-list.c (free_link): free list mempool if it becomes
5555 * dbus/dbus-memory.c (_dbus_disable_mem_pools): new function
5557 * dbus/dbus-address.c (dbus_parse_address): free list nodes
5560 * bus/dispatch.c (bus_dispatch_add_connection): free
5561 message_handler_slot when no longer using it, so
5562 memory leak checkers are happy for the test suite.
5564 * dbus/dbus-server-debug-pipe.c (debug_finalize): free server name
5566 * bus/bus.c (new_connection_callback): disconnect in here if
5567 bus_connections_setup_connection fails.
5569 * bus/connection.c (bus_connections_unref): fix to free the
5571 (bus_connections_setup_connection): if this fails, don't
5572 disconnect the connection, just be sure there are no side
5575 * dbus/dbus-string.c (undo_alignment): unbreak this
5577 * dbus/dbus-auth.c (_dbus_auth_unref): free some stuff we were
5579 (_dbus_auth_new): fix the order in which we free strings
5582 * bus/connection.c (bus_connection_disconnected): fix to
5583 not send ServiceDeleted multiple times in case of memory
5586 * dbus/dbus-bus.c (dbus_bus_get_base_service): new function to
5587 get the base service name
5588 (dbus_bus_register_client): don't return base service name,
5589 instead store it on the DBusConnection and have an accessor
5591 (dbus_bus_register_client): rename dbus_bus_register()
5593 * bus/dispatch.c (check_hello_message): verify that other
5594 connections on the bus also got the correct results, not
5595 just the one sending hello
5597 2003-03-15 Havoc Pennington <hp@pobox.com>
5599 Make it pass the Hello handling test including all OOM codepaths.
5600 Now to do other messages...
5602 * bus/services.c (bus_service_remove_owner): fix crash when
5603 removing owner from an empty list of owners
5604 (bus_registry_ensure): don't leave service in the list of
5605 a connection's owned services if we fail to put the service
5608 * bus/connection.c (bus_connection_preallocate_oom_error): set
5609 error flag on the OOM error.
5611 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
5612 handle _dbus_transport_set_connection failure
5614 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd): modify
5615 to create watches up front and simply enable/disable them as
5617 (unix_connection_set): this can now fail on OOM
5619 * dbus/dbus-timeout.c, dbus/dbus-watch.c: add concept
5620 of enabling/disabling a watch or timeout.
5622 * bus/loop.c (bus_loop_iterate): don't touch disabled
5625 * glib/dbus-gmain.c: adapt to enable/disable watches and timeouts
5627 2003-03-15 Havoc Pennington <hp@pobox.com>
5629 * bus/dispatch.c (bus_dispatch_test): OK, now finally actually
5630 write useful test code, after all that futzing around ;-)
5632 Test does not yet pass because we can't handle OOM in
5633 _dbus_transport_messages_pending (basically,
5634 dbus_connection_preallocate_send() does not prealloc the write
5635 watch). To fix this, I think we need to add new stuff to
5636 set_watch_functions, namely a SetEnabled function so we can alloc
5637 the watch earlier, then enable it later.
5639 * dbus/Makefile.am (libdbus_convenience_la_SOURCES): move
5640 dbus-memory.c to the convenience lib
5642 * bus/test.c: rename some static functions to keep them clearly
5643 distinct from stuff in connection.c. Handle client disconnection.
5645 2003-03-14 Havoc Pennington <hp@pobox.com>
5647 * bus/dispatch.c (bus_dispatch_test): do test using debug-pipe
5648 transport, tests more of the real codepath. Set up clients
5649 with bus_setup_debug_client.
5651 * bus/test.c (bus_setup_debug_client): function to set up debug
5652 "clients" on the main loop
5654 * dbus/dbus-transport.c (_dbus_transport_open): add debug-pipe
5657 * dbus/dbus-server.c (dbus_server_listen): add debug-pipe
5660 * dbus/dbus-server-debug.c: support a debug server based on pipes
5662 * dbus/dbus-sysdeps.c (_dbus_full_duplex_pipe): new function
5663 (_dbus_close): new function
5665 * configure.in: check for socketpair
5667 2003-03-14 Havoc Pennington <hp@redhat.com>
5669 * dbus/dbus-memory.c: add a "detect buffer overwrites on free"
5672 * dbus/dbus-transport-debug.c: rework this a good bit to be
5673 less complicated. hopefully still works.
5675 * dbus/dbus-server-debug.c (handle_new_client): remove timeout
5678 * glib/dbus-gmain.c (timeout_handler): don't remove timeout
5681 * dbus/dbus-message.c (dbus_message_copy): rename from
5682 dbus_message_new_from_message, fix it up to copy
5683 all the message fields, add test case
5685 * bus/dispatch.c (bus_dispatch_test): add some more test code,
5686 not quite passing yet
5688 2003-03-14 Havoc Pennington <hp@pobox.com>
5690 * bus/loop.c (bus_loop_iterate): add this so we can "run loop
5691 until no work remains" in test code. (the large diff here
5692 is just code movement, no actual changes)
5694 * dbus/dbus-server-debug.c (DEFAULT_INTERVAL): change interval to
5695 1, no point waiting around for test code.
5696 (_dbus_server_debug_accept_transport): unref the timeout
5697 after adding it (right?)
5699 * dbus/dbus-transport-debug.c (DEFAULT_INTERVAL): ditto
5701 2003-03-13 Havoc Pennington <hp@redhat.com>
5703 * dbus/dbus-timeout.c (_dbus_timeout_list_set_functions): handle
5706 * dbus/dbus-watch.c (_dbus_watch_list_set_functions): handle out
5709 * dbus/dbus-connection.h: Make AddWatchFunction and
5710 AddTimeoutFunction return a bool so they can fail on out-of-memory
5712 * bus/bus.c (bus_context_new): set up timeout handlers
5714 * bus/connection.c (bus_connections_setup_connection): set up
5717 * glib/dbus-gmain.c: adapt to the fact that set_functions stuff
5720 * bus/bus.c (bus_context_new): adapt to changes
5722 * bus/connection.c: adapt to changes
5724 * test/watch.c: adapt to DBusWatch changes
5726 * bus/dispatch.c (bus_dispatch_test): started adding this but
5729 2003-03-14 Anders Carlsson <andersca@codefactory.se>
5731 * bus/dispatch.c (send_service_nonexistent_error): Fix typo.
5733 2003-03-13 Havoc Pennington <hp@pobox.com>
5735 * bus/test.c, bus/test.h, bus/Makefile.am, bus/test-main.c:
5736 set up a test framework as for the library
5738 2003-03-12 Havoc Pennington <hp@pobox.com>
5740 Throughout: purge global variables, introduce BusActivation,
5741 BusConnections, BusRegistry, etc. objects instead.
5743 * bus/bus.h, bus/bus.c: introduce BusContext as a global
5746 * test/Makefile.am (TEST_BINARIES): disable bus-test for now,
5747 going to redo this a bit differently I think
5749 2003-03-12 Havoc Pennington <hp@redhat.com>
5751 Mega-patch that gets the message bus daemon initially handling
5752 out-of-memory. Work still needed. Also lots of random
5753 moving stuff to DBusError instead of ResultCode.
5755 * dbus/dbus-list.c (_dbus_list_length_is_one): new function
5757 * dbus/dbus-connection.c
5758 (dbus_connection_send_with_reply_and_block): use DBusError
5760 * dbus/dbus-bus.c: adapt to API changes, make it use DBusError not
5763 * dbus/dbus-connection.c (dbus_connection_send): drop the result
5764 code here, as the only failure possible is OOM.
5766 * bus/connection.c (bus_connection_disconnect):
5767 rename bus_connection_disconnected as it's a notification only
5769 * bus/driver.c (bus_driver_handle_acquire_service): don't free
5770 "name" on get_args failure, should be done by get_args;
5771 don't disconnect client for bad args, just return an error.
5772 (bus_driver_handle_service_exists): ditto
5774 * bus/services.c (bus_services_list): NULL-terminate returned array
5776 * bus/driver.c (bus_driver_send_service_lost)
5777 (bus_driver_send_service_acquired): send messages from driver to a
5778 specific client to the client's unique name, not to the broadcast
5781 * dbus/dbus-message.c (decode_header_data): reject messages that
5782 contain no name field
5783 (_dbus_message_get_client_serial): rename to
5784 dbus_message_get_serial and make public
5785 (_dbus_message_set_serial): rename from set_client_serial
5786 (_dbus_message_set_reply_serial): make public
5787 (_dbus_message_get_reply_serial): make public
5789 * bus/connection.c (bus_connection_foreach): allow stopping
5790 iteration by returning FALSE from foreach function.
5792 * dbus/dbus-connection.c (dbus_connection_send_preallocated)
5793 (dbus_connection_free_preallocated_send)
5794 (dbus_connection_preallocate_send): new API for sending a message
5795 without possibility of malloc failure.
5796 (dbus_connection_send_message): rename to just
5797 dbus_connection_send (and same for whole function family)
5799 * dbus/dbus-errors.c (dbus_error_free): make this reinit the error
5801 * dbus/dbus-sysdeps.c (_dbus_exit): new function
5803 * bus/activation.c: handle/return errors
5805 * dbus/dbus-errors.h: add more DBUS_ERROR #define
5807 * dbus/dbus-sysdeps.c (_dbus_directory_open) (_dbus_file_get_contents)
5808 (_dbus_directory_get_next_file): use DBusError instead of DBusResultCode
5809 (_dbus_result_from_errno): move to this file
5811 2003-03-10 Anders Carlsson <andersca@codefactory.se>
5813 * dbus/dbus-marshal.c:
5814 (_dbus_marshal_set_string):
5815 Take a length argument so we can marshal the correct string
5818 (_dbus_marshal_dict), (_dbus_demarshal_dict),
5819 (_dbus_marshal_get_arg_end_pos), (_dbus_marshal_validate_arg),
5820 (_dbus_marshal_test):
5821 * dbus/dbus-marshal.h:
5822 Add support for marshalling and demarshalling dicts.
5824 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
5825 Add support for TYPE DICT.
5827 * dbus/dbus-message.c: (set_string_field):
5828 Adjust header padding.
5830 (dbus_message_append_args_valist), (dbus_message_append_dict),
5831 (dbus_message_get_args_valist), (dbus_message_iter_get_arg_type),
5832 (dbus_message_iter_get_dict), (_dbus_message_loader_return_buffer),
5833 (check_message_handling), (check_have_valid_message):
5834 * dbus/dbus-message.h:
5835 Add functions for setting and getting dicts.
5837 * dbus/dbus-protocol.h:
5843 * doc/dbus-specification.sgml:
5844 Add information about how dicts are marshalled.
5846 * test/data/invalid-messages/dict-with-nil-value.message:
5847 * test/data/invalid-messages/too-short-dict.message:
5848 * test/data/valid-messages/dict-simple.message:
5849 * test/data/valid-messages/dict.message:
5850 Add sample messages containing dicts.
5852 2003-03-08 Anders Carlsson <andersca@codefactory.se>
5854 * dbus/dbus-dict.h: Add DBUS_END_DECLS.
5856 2003-03-07 Anders Carlsson <andersca@codefactory.se>
5859 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
5860 (dbus_dict_get_keys), (insert_entry), (dbus_dict_set_boolean),
5861 (dbus_dict_set_int32), (dbus_dict_set_uint32),
5862 (dbus_dict_set_double), (dbus_dict_set_string),
5863 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
5864 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
5865 (dbus_dict_set_string_array), (_dbus_dict_test):
5867 Fix according to comments from Havoc.
5869 2003-03-06 Michael Meeks <michael@server.home>
5871 * configure.in: if we don't have kde-config, disable have_qt.
5873 2003-03-07 Anders Carlsson <andersca@codefactory.se>
5878 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
5879 (dbus_dict_ref), (dbus_dict_unref), (dbus_dict_contains),
5880 (dbus_dict_remove), (dbus_dict_get_value_type),
5881 (dbus_dict_get_keys), (dbus_dict_put_boolean),
5882 (dbus_dict_put_int32), (dbus_dict_put_uint32),
5883 (dbus_dict_put_double), (dbus_dict_put_string),
5884 (dbus_dict_put_boolean_array), (dbus_dict_put_int32_array),
5885 (dbus_dict_put_uint32_array), (dbus_dict_put_double_array),
5886 (dbus_dict_put_string_array), (dbus_dict_get_boolean),
5887 (dbus_dict_get_int32), (dbus_dict_get_uint32),
5888 (dbus_dict_get_double), (dbus_dict_get_string),
5889 (dbus_dict_get_boolean_array), (dbus_dict_get_int32_array),
5890 (dbus_dict_get_uint32_array), (dbus_dict_get_double_array),
5891 (dbus_dict_get_string_array), (_dbus_dict_test):
5893 Add DBusDict implementation
5895 * dbus/dbus-test.c: (dbus_internal_do_not_use_run_tests):
5899 2003-03-04 Havoc Pennington <hp@pobox.com>
5901 * test/data/auth/*: adapt to changes
5903 * dbus/dbus-auth-script.c (_dbus_auth_script_run): add
5904 USERID_BASE64 and change USERNAME_BASE64 to put in username not
5907 * dbus/dbus-keyring.c (_dbus_keyring_validate_context): prevent
5908 more stuff from being in a context name, to make the protocol
5909 simpler to deal with
5911 * dbus/dbus-errors.c (dbus_error_has_name): new function
5912 (dbus_error_is_set): new function
5914 * dbus/dbus-auth.c: replace DBUS_STUPID_TEST_MECH auth
5915 with DBUS_COOKIE_SHA1, implement DBUS_COOKIE_SHA1
5917 * dbus/dbus-connection.c (dbus_connection_flush): also read
5918 messages during a flush operation
5920 * dbus/Makefile.am: remove dbus-md5 since it isn't currently used.
5922 2003-03-05 Anders Carlsson <andersca@codefactory.se>
5924 * configure.in: Check for gethostbyname on Solaris.
5926 * dbus/dbus-transport.c: (_dbus_transport_open):
5927 Remove duplicate "tcp" entry.
5929 * doc/dbus-specification.sgml:
5930 Clarify some things.
5932 2003-03-05 Anders Carlsson <andersca@codefactory.se>
5934 * dbus/dbus-auth.c: (send_rejected), (process_test_subdir):
5935 * dbus/dbus-keyring.c: (_dbus_keyring_new_homedir),
5936 (_dbus_keyring_test):
5937 * dbus/dbus-md5.c: (_dbus_md5_compute):
5938 * dbus/dbus-sha.c: (_dbus_sha_compute):
5941 2003-03-05 Anders Carlsson <andersca@codefactory.se>
5943 * README: Add some things.
5945 2003-03-04 Anders Carlsson <andersca@codefactory.se>
5947 * dbus/dbus-message.c (dbus_message_append_args_valist): Add a break;
5948 after case DBUS_TYPE_BOOELAN.
5950 2003-03-02 Havoc Pennington <hp@pobox.com>
5952 * test/break-loader.c (randomly_set_extreme_ints): add test that
5953 sets really huge and small integers
5955 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add check
5956 that length of boolean array fits in the string, and that
5957 string has room for boolean value in single-bool case.
5959 * dbus/dbus-message-builder.c (_dbus_message_data_load): add
5960 optional value to "ALIGN" command which is what to fill the
5963 * test/data/valid-messages/no-padding.message: add regression
5964 test for the message padding problem
5966 2003-03-02 Havoc Pennington <hp@pobox.com>
5968 * dbus/dbus-message.c (decode_header_data): fix to always init
5969 message_padding, from Benjamin Dauvergne
5971 2003-03-02 Havoc Pennington <hp@pobox.com>
5977 2003-03-01 Joe Shaw <joe@assbarn.com>
5979 * configure.in: Check for "struct cmsgcred" and try to access its
5980 members for BSD-like unices.
5982 * dbus/dbus-sysdeps.c (read_credentials_byte): Fold this back into
5983 _dbus_read_credentials_unix_socket().
5984 (_dbus_read_credentials_unix_socket): Use recvmsg() instead of
5985 read() for reading the credential byte off the unix socket. Use
5986 struct cmsgcred on systems that support it.
5988 2003-02-27 Alexander Larsson <alexl@redhat.com>
5992 Make gthreads-2.0 dependency optional. Don't build thread test if
5995 2003-02-27 Havoc Pennington <hp@pobox.com>
5997 * dbus/dbus-connection.c
5998 (dbus_connection_send_message_with_reply_and_block): fix doh!
5999 doh! doh! bug that resulted in never removing a reply from the
6000 queue, no wonder we called get_reply_serial so much ;-)
6002 * dbus/dbus-message.c (struct DBusMessage): cache reply serial
6003 and client serial instead of demarshaling them every time
6005 2003-02-27 Havoc Pennington <hp@pobox.com>
6007 * dbus/dbus-marshal.c (_dbus_demarshal_int32): rewrite to be much
6008 more inlined, using dbus-string-private.h, speeds things up
6011 * dbus/dbus-string.c (_dbus_string_free): apply align offset
6012 when freeing the string
6013 (_dbus_string_steal_data): fix for align offset
6014 (undo_alignment): new function
6016 2003-02-26 Havoc Pennington <hp@redhat.com>
6018 All kinds of audit fixes from Owen, plus initial attempt to
6019 handle unaligned memory returned from malloc.
6021 * dbus/dbus-string.c (_dbus_string_init): clamp max length to
6022 leave room for align_offset and nul byte
6023 (fixup_alignment): function to track an align_offset and
6024 ensure real->str is aligned
6025 (DBUS_GENERIC_STRING_PREAMBLE): len must be less than allocated,
6026 to allow a nul byte plus align offset
6027 (_dbus_string_lock): fix overflow issue
6028 (_dbus_string_init_const_len): add assertions on sanity of len,
6029 assign allocated to be ALLOCATION_PADDING larger than len
6030 (set_length): fixup the overflow handling
6031 (_dbus_string_get_data_len): fix overflow in assertion
6032 (open_gap): detect overflow in size of gap to be opened
6033 (_dbus_string_lengthen): add overflow check
6034 (_dbus_string_align_length): fix overflow with _DBUS_ALIGN_VALUE
6035 (_dbus_string_append): add overflow check
6036 (_dbus_string_append_unichar): overflow
6037 (_dbus_string_delete): fix overflow in assertion
6038 (_dbus_string_copy_len): overflow in assertion
6039 (_dbus_string_replace_len): overflows in assertions
6040 (_dbus_string_find): change to implement in terms of
6041 _dbus_string_find_to
6042 (_dbus_string_find_to): assorted fixage
6043 (_dbus_string_equal_c_str): assert c_str != NULL,
6044 fix logic so the function works
6045 (_dbus_string_ends_with_c_str): fix overflow thingy
6046 (_dbus_string_base64_encode): overflow fix
6047 (_dbus_string_validate_ascii): overflow
6048 (_dbus_string_validate_nul): overflow
6050 2003-02-26 Havoc Pennington <hp@redhat.com>
6052 * dbus/dbus-marshal.c (_dbus_marshal_test): fix to work with DISABLE_ASSERTS
6054 2003-02-26 Alexander Larsson <alexl@redhat.com>
6057 Set DBUS_GLIB_THREADS_LIBS for apps using gthread-2.0
6059 * dbus/dbus-connection.c:
6060 * dbus/dbus-connection.h:
6061 Fix _dbus_connection_acquire_io_path and _dbus_connection_acquire_dispatch.
6062 Add dbus_connection_set_wakeup_main_function and use it when queueing
6063 incoming and outgoing messages.
6066 * dbus/dbus-dataslot.c:
6067 Threadsafe usage of DBusDataSlotAllocator
6069 * dbus/dbus-message.c: (dbus_message_get_args_iter):
6072 * dbus/dbus-server-unix.c:
6075 * glib/dbus-gmain.c:
6076 Implement the new wakeup functions for glib.
6079 * glib/test-thread-client.c:
6080 * glib/test-thread-server.c:
6081 * glib/test-thread.h:
6082 Initial cut at some thread test code. Not really done yet.
6084 2003-02-26 Havoc Pennington <hp@pobox.com>
6086 * dbus/dbus-connection.c
6087 (dbus_connection_send_message_with_reply_and_block): fix crash
6088 where we ref'd the outgoing message instead of the returned reply
6090 * dbus/dbus-transport-unix.c (do_authentication): check read watch
6091 at the end of this function, so if we didn't need to read for
6092 authentication, we reinstall it for receiving messages
6094 * dbus/dbus-message.c (dbus_message_new_reply): allow replies to
6095 a NULL sender for peer-to-peer case
6097 * dbus/dbus-transport-unix.c (check_read_watch): handle
6098 !authenticated case correctly
6100 * glib/dbus-gmain.c: add support for DBusServer
6102 * dbus/dbus-server.c: add data slot support
6104 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): check
6105 return values and handle errors
6107 * dbus/dbus-dataslot.c: factor out the data slot stuff from
6110 * Doxyfile.in (INPUT): add glib subdir
6112 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): rename
6113 setup_with_g_main instead of hookup_with_g_main; write docs
6115 2003-02-24 Anders Carlsson <andersca@codefactory.se>
6117 * dbus/dbus-marshal.c: (_dbus_marshal_validate_arg):
6118 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
6119 * dbus/dbus-message.c: (dbus_message_append_boolean),
6120 (dbus_message_append_boolean_array),
6121 (dbus_message_get_args_valist), (_dbus_message_test):
6122 * dbus/dbus-message.h:
6123 * doc/dbus-specification.sgml:
6124 Various fixes as pointed out by Havoc.
6126 * test/data/invalid-messages/bad-boolean-array.message:
6127 * test/data/invalid-messages/bad-boolean.message:
6128 Add invalid boolean value test cases.
6130 2003-02-24 Anders Carlsson <andersca@codefactory.se>
6132 * dbus/dbus-internals.c: (_dbus_type_to_string):
6133 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
6134 (_dbus_marshal_validate_arg):
6135 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
6136 * dbus/dbus-message.c: (dbus_message_append_args_valist),
6137 (dbus_message_append_boolean), (dbus_message_append_boolean_array),
6138 (dbus_message_get_args_valist), (dbus_message_iter_get_boolean),
6139 (dbus_message_iter_get_int32), (dbus_message_iter_get_uint32),
6140 (dbus_message_iter_get_double),
6141 (dbus_message_iter_get_boolean_array), (message_iter_test):
6142 * dbus/dbus-message.h:
6143 * dbus/dbus-protocol.h:
6144 * doc/dbus-specification.sgml:
6145 * test/data/valid-messages/lots-of-arguments.message:
6146 Add support for boolean and boolean array types.
6148 2003-02-23 Havoc Pennington <hp@pobox.com>
6150 * dbus/dbus-keyring.c: finish most of this implementation and
6153 * dbus/dbus-errors.c (dbus_set_error_const, dbus_set_error): make
6154 these barf if the error isn't cleared to NULL
6156 * dbus/dbus-sysdeps.c (_dbus_delete_file): set error on failure
6157 (_dbus_create_directory): new function
6159 * dbus/dbus-errors.c (dbus_set_error): fix warning
6161 * dbus/dbus-string.c (_dbus_string_hex_encode): new function
6162 (_dbus_string_hex_decode): new function
6163 (test_hex_roundtrip): test code
6165 * dbus/dbus-sha.c (_dbus_sha_compute): use dbus_string_hex_encode
6167 * dbus/dbus-md5.c (_dbus_md5_compute): use dbus_string_hex_encode
6169 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): make this use
6170 the save-to-temp/rename trick to atomically write the new file
6171 (_dbus_string_parse_uint): new function
6173 2003-02-22 Havoc Pennington <hp@pobox.com>
6175 * test/Makefile.am (dist-hook): fix dist for test/data/sha-1
6177 2003-02-22 Havoc Pennington <hp@pobox.com>
6179 * dbus/dbus-message.c (dbus_message_iter_get_string_array):
6180 (dbus_message_iter_get_byte_array): Fix up doxygen warnings
6182 * dbus/dbus-sha.c: add implementation of SHA-1 algorithm
6184 * dbus/test/data/sha-1: add US government test suite for SHA-1
6186 2003-02-21 Anders Carlsson <andersca@codefactory.se>
6188 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
6189 Make string arrays NULL-terminated.
6191 * dbus/dbus-memory.c: (dbus_free_string_array):
6192 * dbus/dbus-memory.h:
6193 New function for freeing NULL-terminated string arrays.
6195 * dbus/dbus-message-builder.c: (append_quoted_string),
6196 (_dbus_message_data_load):
6197 Add support for array types.
6199 * dbus/dbus-message.c: (check_message_handling):
6200 Add more types as test cases.
6202 * dbus/dbus-sysdeps.c: (_dbus_string_parse_int),
6203 (_dbus_string_parse_double):
6204 Add the start offset to the end offset.
6206 * test/data/valid-messages/lots-of-arguments.message:
6207 New test message with lots of arguments.
6209 2003-02-21 Anders Carlsson <andersca@codefactory.se>
6211 * dbus/dbus-message.c: (dbus_message_append_nil),
6212 (dbus_message_append_int32), (dbus_message_append_uint32),
6213 (dbus_message_append_double), (dbus_message_append_string),
6214 (dbus_message_append_int32_array),
6215 (dbus_message_append_uint32_array),
6216 (dbus_message_append_double_array),
6217 (dbus_message_append_byte_array),
6218 (dbus_message_append_string_array):
6219 Fix all out-of-memory handling in these functions.
6221 2003-02-21 Anders Carlsson <andersca@codefactory.se>
6223 * dbus/dbus-message.c: (dbus_message_append_nil):
6226 2003-02-21 Anders Carlsson <andersca@codefactory.se>
6228 * dbus/dbus-message.c: (dbus_message_append_args_valist),
6229 (dbus_message_append_nil), (dbus_message_append_int32_array),
6230 (dbus_message_append_uint32_array),
6231 (dbus_message_append_double_array),
6232 (dbus_message_append_byte_array),
6233 (dbus_message_append_string_array), (dbus_message_get_args_valist),
6234 (dbus_message_iter_get_int32_array),
6235 (dbus_message_iter_get_uint32_array),
6236 (dbus_message_iter_get_double_array),
6237 (dbus_message_iter_get_byte_array),
6238 (dbus_message_iter_get_string_array):
6240 * dbus/dbus-message.h:
6241 Add functions for appending and getting arrays.
6243 2003-02-21 Anders Carlsson <andersca@codefactory.se>
6245 * dbus/dbus-mempool.c (_dbus_mem_pool_new): Make the
6246 element size at least 8 bytes, fixes mempool tests on
6249 2003-02-20 Alexander Larsson <alexl@redhat.com>
6251 * dbus/dbus-transport-unix.c (unix_do_iteration):
6252 Unlock the connection mutex during a blocking select call.
6253 Add todo about how we need a way to wake up the select.
6255 * dbus/dbus-connection-internal.h:
6256 * dbus/dbus-connection.c:
6257 Add _dbus_connection_lock and _dbus_connection_unlock.
6259 2003-02-19 Havoc Pennington <hp@pobox.com>
6261 * Doxyfile.in (PREDEFINED): put DOXYGEN_SHOULD_SKIP_THIS in
6262 Doxyfile.in, not Doxyfile
6264 * dbus/dbus-keyring.c: do some hacking on this
6266 * dbus/dbus-sysdeps.c (_dbus_delete_file): new
6268 * dbus/dbus-errors.c (dbus_set_error_const): do not call
6270 (dbus_set_error): remove dbus_error_init, check for message ==
6271 NULL *before* we sprintf into it, and add @todo about including
6272 system headers in this file
6274 * dbus/dbus-sysdeps.c (_dbus_create_file_exclusively): new
6276 * dbus/dbus-errors.h (DBUS_ERROR_FAILED): add
6278 * dbus/dbus-sysdeps.c (get_user_info): break this function out to
6279 get various bits of user information based on either username
6281 (_dbus_homedir_from_username): new function
6283 2003-02-19 Anders Carlsson <andersca@codefactory.se>
6286 Add check for nonposix getpwnam_r
6288 * dbus/dbus-mempool.c: (_dbus_mem_pool_new):
6289 Align the pool element size to a sizeof (void *) boundary.
6291 * dbus/dbus-sysdeps.c: (_dbus_setenv), (_dbus_connect_unix_socket),
6292 (_dbus_listen_unix_socket), (_dbus_credentials_from_username):
6293 General Solaris fixes.
6295 * test/data/valid-messages/simplest-manual.message:
6296 Explicitly state that we want little-endian packing.
6298 2003-02-19 Mikael Hallendal <micke@codefactory.se>
6300 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
6302 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_tcp_socket):
6303 Added to create a transport connecting using a tcp/ip socket.
6305 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): Added to connect
6306 to a tcp socket at given host and port.
6307 (_dbus_listen_tcp_socket): added to listen on tcp socket for given
6310 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
6312 * dbus/dbus-server-unix.c (_dbus_server_new_for_tcp_socket):
6313 Added to create a server listening on a TCP/IP socket.
6315 2003-02-19 Havoc Pennington <hp@pobox.com>
6317 Throughout: mop up all the Doxygen warnings and undocumented
6320 * dbus/dbus-sysdeps.c (do_exec): do not use execvp, we don't want
6321 to search any paths.
6323 * dbus/dbus-threads.c: move global mutex initializers to
6324 dbus-internals.h, multiple prototypes was confusing doxygen
6325 besides being kind of ugly
6327 * Doxyfile (PREDEFINED): have Doxygen define
6328 DOXYGEN_SHOULD_SKIP_THIS so we can exclude things from
6329 docs with #ifndef DOXYGEN_SHOULD_SKIP_THIS
6330 (do not abuse the feature! it's for stuff like the autogenerated
6331 macros in dbus-md5.c, not just for things you don't feel like
6334 2003-02-18 Havoc Pennington <hp@pobox.com>
6336 * dbus/dbus-string.c (_dbus_string_zero): new function
6338 * dbus/dbus-md5.c: include MD5 implementation by L. Peter Deutsch,
6339 wrap it in some dbus-friendly API
6341 * dbus/dbus-types.h: add 16-bit types
6343 2003-02-18 Joe Shaw <joe@assbarn.com>
6345 * dbus/dbus-auth.c (handle_server_data_stupid_test_mech): Just get
6346 credentials from our currently running process.
6347 (get_word): Fix a buglet where we were copying the entire length
6348 instead of relative to our position.
6350 * dbus/dbus-hash.c (_dbus_hash_test): Don't try to allocate the
6351 keys on the stack... it's 640k of data.
6353 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): Always
6354 read the credentials byte off the socket, even if we don't have
6356 (_dbus_poll): Implement poll() using select() for systems which
6359 * glib/test-dbus-glib.c (main): Print out an error if no
6360 parameters are given.
6362 * test/data/auth/fallback.auth-script: Added. Tests that a client
6363 can fallback to a secondary auth mechanism if the first fails.
6365 2003-02-18 Havoc Pennington <hp@pobox.com>
6369 2003-02-17 Havoc Pennington <hp@pobox.com>
6371 * doc/dbus-specification.sgml: lots of cosmetic
6372 cleanups/rearrangement, add assorted FIXME, change DBUS_ADDRESS
6373 env variable to DBUS_BUS_ADDRESS, s/client/application/,
6374 s/server/bus/ (except in authentication section). Add a section
6375 "Message Bus Message Routing"
6377 2003-02-17 Anders Carlsson <andersca@codefactory.se.>
6383 2003-02-17 Anders Carlsson <andersca@codefactory.se>
6385 * doc/dbus-specification.sgml:
6386 Specification updates.
6388 2003-02-17 Anders Carlsson <andersca@codefactory.se>
6390 * bus/activation.c: (bus_activation_init), (child_setup),
6391 (bus_activation_activate_service):
6393 * bus/main.c: (main):
6394 Set DBUS_ADDRESS environment variable.
6396 * dbus/dbus-errors.c: (dbus_set_error):
6397 Don't use va_copy since that's a C99 feature.
6399 * dbus/dbus-sysdeps.c: (_dbus_setenv), (do_exec),
6400 (_dbus_spawn_async):
6401 * dbus/dbus-sysdeps.h:
6402 Add child_setup_func to _dbus_spawn_async.
6404 * doc/dbus-specification.sgml:
6405 Update specification.
6407 * test/spawn-test.c: (setup_func), (main):
6410 2003-02-17 Alexander Larsson <alexl@redhat.com>
6412 * dbus/dbus-connection.c (_dbus_connection_handler_destroyed_locked):
6415 2003-02-17 Anders Carlsson <andersca@codefactory.se>
6419 * doc/dbus-test-plan.sgml:
6420 Add test plan document.
6425 2003-02-17 Anders Carlsson <andersca@codefactory.se>
6427 * dbus/dbus-message.c: (decode_header_data),
6428 (_dbus_message_loader_return_buffer):
6429 Set the header padding amount when loading a message.
6431 2003-02-16 Anders Carlsson <andersca@codefactory.se>
6433 * bus/dispatch.c: (send_one_message):
6434 Only send broadcast messages to registered connections.
6436 * dbus/dbus-message.c: (dbus_message_name_is):
6437 * dbus/dbus-message.h:
6438 New convenience function.
6440 * dbus/dbus-transport-debug.c: (do_reading):
6441 Only dispatch one message per run.
6444 * test/bus-test.c: (new_connection_callback), (die),
6445 (test_hello_client1_handler), (test_hello_client2_handler),
6446 (test_hello_replies), (main):
6448 * test/bus-test-loop.[ch]:
6451 2003-02-16 Havoc Pennington <hp@pobox.com>
6453 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
6454 backward conditional
6456 2003-02-16 Alexander Larsson <alexl@redhat.com>
6458 * dbus/dbus-connection.c:
6459 Implement sent_message_with_reply. (with_reply_and block is still
6461 Made dispatch_message not lose message if OOM.
6463 * dbus/dbus-errors.h:
6464 Add NoReply error (for reply timeouts).
6466 2003-02-16 Alexander Larsson <alexl@redhat.com>
6468 * dbus/dbus-hash.c (_dbus_hash_table_unref):
6469 Actually free keys and values when destroying hashtable.
6471 2003-02-16 Anders Carlsson <andersca@codefactory.se>
6473 * dbus/dbus-auth.c: (client_try_next_mechanism):
6476 * dbus/dbus-threads.c: (dbus_condvar_wait_timeout):
6477 Return TRUE if there's no thread implementation around.
6479 * glib/dbus-gmain.c: (free_source),
6480 (dbus_connection_hookup_with_g_main):
6481 Make sure to remove the GSource when the connection is finalized.
6483 2003-02-16 Anders Carlsson <andersca@codefactory.se>
6485 * bus/dispatch.c: (bus_dispatch_message_handler):
6486 * dbus/dbus-errors.h:
6487 Return an error if someone tries to send a message to a service
6490 2003-02-16 Anders Carlsson <andersca@codefactory.se>
6492 * bus/activation.c: (load_directory), (bus_activation_init),
6493 (bus_activation_activate_service):
6496 (bus_driver_handle_activate_service), (bus_driver_handle_message):
6497 More work on the activation handling.
6499 * dbus/dbus-errors.h:
6500 Add some error messages
6502 * dbus/dbus-message.c: (dbus_message_new_error_reply):
6503 * dbus/dbus-message.h:
6504 New function that creates an error message.
6506 * dbus/dbus-protocol.h:
6507 Add ACTIVATE_SERVER message.
6509 * dbus/dbus-server-unix.c: (unix_handle_watch),
6510 (_dbus_server_new_for_domain_socket):
6511 Call _dbus_fd_set_close_on_exec.
6513 * dbus/dbus-sysdeps.c: (make_pipe), (do_exec),
6514 (_dbus_spawn_async), (_dbus_disable_sigpipe),
6515 (_dbus_fd_set_close_on_exec):
6516 * dbus/dbus-sysdeps.h:
6517 Add _dbus_fd_set_close_on exec function. Also add function that checks
6518 that all open fds are set to close-on-exec and warns otherwise.
6520 * dbus/dbus-transport-unix.c:
6521 (_dbus_transport_new_for_domain_socket):
6522 Call _dbus_fd_set_close_on_exec.
6524 2003-02-16 Havoc Pennington <hp@pobox.com>
6526 * dbus/dbus-connection.c (dbus_connection_set_change_sigpipe):
6527 allow people to avoid setting SIGPIPE to SIG_IGN
6528 (_dbus_connection_new_for_transport): disable SIGPIPE unless
6529 we've been asked not to
6531 2003-02-15 Anders Carlsson <andersca@codefactory.se>
6533 * dbus/dbus-list.c: (_dbus_list_append_link),
6534 (_dbus_list_prepend_link):
6535 * dbus/dbus-memory.c: (dbus_malloc), (dbus_malloc0),
6539 2003-02-15 Anders Carlsson <andersca@codefactory.se>
6542 * bus/activation.c: (bus_activation_entry_free),
6543 (add_desktop_file_entry), (load_directory), (bus_activation_init):
6545 * bus/main.c: (main):
6546 Add simple activation support, doesn't work yet though.
6548 2003-02-15 Zack Rusin <zack@kde.org>
6550 * qt/dbus-qthread.cpp: small casting fix
6552 2003-02-15 Anders Carlsson <andersca@codefactory.se>
6554 * dbus/dbus-errors.c: (dbus_set_error):
6555 * dbus/dbus-errors.h:
6556 Add a few errors and make dbus_set_error void.
6558 * dbus/dbus-sysdeps.c:
6559 (_dbus_errno_to_string), (close_and_invalidate), (make_pipe),
6560 (write_err_and_exit), (read_ints), (do_exec), (_dbus_spawn_async):
6561 * dbus/dbus-sysdeps.h:
6562 Add _dbus_spawn_async.
6564 * test/spawn-test.c: (main):
6565 Test for _dbus_spawn_async.
6567 2003-02-15 Anders Carlsson <andersca@codefactory.se>
6569 * dbus/dbus-internals.h:
6570 Fix build without tests.
6572 * dbus/dbus-list.c: (alloc_link):
6573 Fix a segfault when a malloc fails.
6575 * dbus/dbus-memory.c: (initialize_malloc_debug), (dbus_malloc),
6576 (dbus_malloc0), (dbus_realloc):
6577 Add support for malloc debugging.
6579 2003-02-15 Alexander Larsson <alexl@redhat.com>
6581 * dbus/dbus-threads.c:
6582 * dbus/dbus-threads.h:
6583 Add condvars. Remove static mutext from API.
6584 Implement static mutexes by initializing them from threads_init.
6586 * glib/dbus-gthread.c:
6587 * qt/dbus-qthread.cpp:
6588 Update with the thread api changes.
6593 Turn StaticMutex into normal mutex + init function.
6594 Export new functions _dbus_list_alloc_link, _dbus_list_free_link,
6595 _dbus_list_append_link, _dbus_list_prepend_link
6598 * dbus/dbus-sysdeps.c:
6599 * dbus/dbus-sysdeps.h:
6600 New type dbus_atomic_t, and new functions _dbus_atomic_inc,
6601 _dbus_atomic_dec. Only slow fallback implementation at the moment.
6603 * dbus/dbus-protocol.h:
6604 Add DBUS_MESSAGE_LOCAL_DISCONNECT define
6606 * dbus/dbus-message.c:
6607 Make ref/unref atomic.
6610 * dbus/dbus-connection-internal.h:
6611 * dbus/dbus-connection.c:
6612 * dbus/dbus-connection.h:
6614 Change _peek to _borrow,_return & _steal_borrowed.
6615 Change disconnect callback to event.
6616 Make dbus_connection_dispatch_messages reentrant.
6618 * dbus/dbus-transport.c:
6619 Don't ref the connection on calls to the transport
6622 * dbus/dbus-message-handler.c:
6625 * glib/dbus-gmain.c:
6626 Don't use peek_message anymore
6629 * test/debug-thread.c:
6630 * test/debug-thread.h:
6631 Simple thread implementation that asserts() on deadlocks in
6632 single-threaded code.
6635 (main) Call debug_threads_init.
6638 Use disconnect message instead of disconnect callback.
6642 Don't call dbus_connection_set_disconnect_function. Instead export
6643 bus_connection_disconnect.
6646 Call bus_connection_disconnect when we get a disconnected message.
6648 2003-02-15 Havoc Pennington <hp@pobox.com>
6650 * dbus/dbus-message.c (dbus_message_new): fool around with the
6653 2003-02-14 Havoc Pennington <hp@pobox.com>
6655 * dbus/dbus-mempool.c: fail if the debug functions so indicate
6657 * dbus/dbus-memory.c: fail if the debug functions indicate we
6660 * dbus/dbus-internals.c (_dbus_set_fail_alloc_counter)
6661 (_dbus_decrement_fail_alloc_counter): debug functions to
6662 simulate memory allocation failures
6664 2003-02-14 Havoc Pennington <hp@pobox.com>
6666 * dbus/dbus-errors.h (struct DBusError): add a word of padding
6669 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6671 * bus/driver.c: (bus_driver_handle_hello):
6673 * bus/services.c: (bus_service_lookup):
6674 Reorder message sending so we get a more sane order.
6676 * test/bus-test.c: (message_handler):
6679 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6681 * bus/driver.c: (bus_driver_send_service_deleted),
6682 (bus_driver_send_service_created), (bus_driver_send_service_lost),
6683 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
6684 (bus_driver_send_welcome_message),
6685 (bus_driver_handle_list_services),
6686 (bus_driver_handle_acquire_service),
6687 (bus_driver_handle_service_exists):
6688 * dbus/dbus-bus.c: (dbus_bus_register_client),
6689 (dbus_bus_acquire_service), (dbus_bus_service_exists):
6690 * dbus/dbus-errors.c: (dbus_result_to_string):
6691 * dbus/dbus-errors.h:
6692 * dbus/dbus-message.c: (dbus_message_append_args),
6693 (dbus_message_append_args_valist), (dbus_message_get_args),
6694 (dbus_message_get_args_valist), (dbus_message_get_args_iter),
6695 (dbus_message_iter_get_arg_type), (dbus_message_iter_get_string),
6696 (dbus_message_iter_get_byte_array),
6697 (dbus_message_iter_get_string_array), (message_iter_test),
6698 (check_message_handling), (_dbus_message_test):
6699 * dbus/dbus-message.h:
6700 * test/bus-test.c: (main):
6701 Change fields to arguments in messages, so that they won't be
6702 confused with header fields.
6704 * glib/test-dbus-glib.c: (main):
6705 Remove append_fields from hello message.
6707 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6709 * dbus/dbus-errors.c:
6710 * dbus/dbus-message.c:
6711 * dbus/dbus-string.c:
6712 Documentation fixes.
6714 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6716 * glib/dbus-gmain.c: (timeout_handler), (add_timeout),
6718 Implement support for timeouts in dbus-glib.
6720 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6722 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
6723 * dbus/dbus-message.c: (process_test_subdir):
6724 * test/break-loader.c: (find_breaks_based_on):
6725 Plug some memory leaks.
6727 2003-02-13 Richard Hult <rhult@codefactory.se>
6729 * bus/main.c: Fix build.
6731 * dbus/dbus-errors.h:
6732 * dbus/dbus-errors.c: Fix copyright for Anders.
6734 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6739 * bus/connection.c: (bus_connection_foreach):
6742 * bus/desktop-file.c: (grow_lines_in_section), (grow_sections),
6743 (unescape_string), (new_section), (parse_section_start),
6744 (parse_key_value), (report_error), (bus_desktop_file_load),
6745 (bus_desktop_file_get_string):
6746 * bus/desktop-file.h:
6747 Use DBusError for error reporting.
6749 * bus/dispatch.c: (send_one_message),
6750 (bus_dispatch_message_handler):
6751 * bus/driver.c: (bus_driver_send_service_deleted),
6752 (bus_driver_send_service_created), (bus_driver_send_service_lost),
6753 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
6754 (bus_driver_send_welcome_message),
6755 (bus_driver_handle_list_services),
6756 (bus_driver_handle_acquire_service),
6757 (bus_driver_handle_service_exists):
6758 * bus/loop.c: (bus_loop_run):
6760 Use BUS_HANDLE_OOM instead of _DBUS_HANDLE_OOM.
6762 * bus/utils.c: (bus_wait_for_memory):
6764 New files with general utility functions.
6766 * dbus/dbus-internals.h:
6767 Remove _DBUS_HANDLE_OOM.
6769 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6771 * dbus/dbus-errors.c: (dbus_result_to_string), (dbus_error_init),
6772 (dbus_error_free), (dbus_set_error_const), (dbus_set_error):
6773 * dbus/dbus-errors.h:
6774 Add DBusError structure.
6776 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6778 * test/data/valid-messages/standard-acquire-service.message:
6779 * test/data/valid-messages/standard-hello.message:
6780 * test/data/valid-messages/standard-list-services.message:
6781 * test/data/valid-messages/standard-service-exists.message:
6782 Add some standard messages.
6784 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6786 * bus/driver.c: (bus_driver_send_welcome_message),
6787 (bus_driver_handle_list_services),
6788 (bus_driver_handle_acquire_service),
6789 (bus_driver_handle_service_exists), (bus_driver_handle_message):
6790 Update for API changes in libdbus.
6792 * dbus/dbus-message.c: (dbus_message_new_reply):
6793 * dbus/dbus-message.h:
6794 Remove the name argument. The spec states that replies shouldn't
6797 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6799 * bus/desktop-file.c: (parse_section_start), (parse_key_value),
6800 (report_error), (bus_desktop_file_load), (lookup_section),
6801 (lookup_line), (bus_desktop_file_get_raw),
6802 (bus_desktop_file_get_string):
6803 * bus/desktop-file.h:
6804 Some fixes, and new functions for getting a key value from a section.
6806 2003-02-13 Havoc Pennington <hp@pobox.com>
6808 * test/data/auth/fail-after-n-attempts.auth-script: new test
6810 * dbus/dbus-auth.c (send_rejected): shutdown_mech() when we
6813 2003-02-13 Havoc Pennington <hp@pobox.com>
6815 * dbus/dbus-auth.c (handle_server_data_external_mech): args to
6816 dbus_credentials_match were backward
6818 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support
6819 NO_CREDENTIALS and ROOT_CREDENTIALS
6821 * dbus/dbus-auth.c (_dbus_auth_do_work): move get_state() routine
6822 into here. Never process more commands after we've reached an
6823 end state; store further data as unused bytes.
6825 * test/data/auth/*: add more auth tests
6827 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support EXPECT
6828 command to match exact string and EXPECT_UNUSED to match unused
6831 * test/Makefile.am (dist-hook): fix to dist all the test stuff
6833 2003-02-12 Havoc Pennington <hp@pobox.com>
6835 * dbus/dbus-string.c (_dbus_string_pop_line): fix to also strip
6836 \r off of popped lines
6838 * dbus/dbus-auth.c (_dbus_auth_test): write code to run auth
6841 * dbus/dbus-auth-script.c (_dbus_auth_script_run): when doing a
6844 2003-02-12 Havoc Pennington <hp@pobox.com>
6846 * dbus/Makefile.am: remove break-loader from the build, since it
6849 * configure.in: add --enable-gcov to turn on coverage profiling
6850 flags and disable optimization
6852 2003-02-10 Havoc Pennington <hp@pobox.com>
6854 * dbus/dbus-auth-script.c, dbus/dbus-auth-script.h: sync
6855 initial cut at test framework for DBusAuth from laptop.
6856 Doesn't quite work yet but it compiles and I need to get
6857 it off the 266mhz laptop. ;-)
6859 * dbus/dbus-server-debug.c (_dbus_server_debug_accept_transport):
6860 fix a memleak in error case
6862 2003-02-12 Anders Carlsson <andersca@codefactory.se>
6865 * bus/desktop-file.c:
6866 * bus/desktop-file.h:
6867 Add a desktop file parser.
6869 2003-02-11 Zack Rusin <zack@kde.org>
6871 * qt/message.[h|cpp]: sample implementation
6872 of the KDE wrapper for DBusMessage
6874 2003-02-09 Zack Rusin <zack@kde.org>
6876 * test/bus-test.c: make_it_compile
6877 * doc/dbus-specification.sgml: minimal semantic fix
6879 2003-02-06 Anders Carlsson <andersca@codefactory.se>
6885 2003-02-06 Anders Carlsson <andersca@codefactory.se>
6888 * dbus/dbus-break-loader.c:
6890 * test/break-loader.c:
6891 Move dbus-break-loader to test/ and rename it to break-loader.
6893 2003-02-02 Havoc Pennington <hp@pobox.com>
6895 * dbus/dbus-keyring.c, dbus/dbus-keyring.h: template files
6896 for code to manage cookies in your home directory
6898 * dbus/dbus-sysdeps.c (_dbus_generate_random_bytes): new function
6900 * dbus/dbus-auth.c (get_state): impose a maximum number of tries
6901 to authenticate, then disconnect the client.
6903 2003-02-03 Alexander Larsson <alexl@redhat.com>
6905 * dbus/dbus-message.c (dbus_message_append_fields):
6908 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6910 * doc/dbus-specification.sgml:
6911 Update address format section.
6913 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6916 * test/bus-test.c: (get_time), (add_timeout), (remove_timeout),
6917 (message_handler), (new_connection_callback), (loop_quit),
6921 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6923 * bus/driver.c: (bus_driver_handle_service_exists):
6924 Simplify the code a bit.
6926 * dbus/dbus-bus.c: (dbus_bus_service_exists):
6929 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6932 Add libdbus-daemon.la and link to it.
6934 2003-02-01 James Willcox <jwillcox@gnome.org>
6936 * bus/driver.c: (bus_driver_handle_own_service):
6937 Actually include the service reply code in the message.
6939 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6941 * bus/driver.c: (bus_driver_handle_service_exists):
6942 Don't unref the incoming message.
6944 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6946 * dbus/dbus.h: Add dbus-address.h and dbus-bus.h
6948 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6950 * dbus/dbus-server.c: (dbus_server_listen):
6951 * dbus/dbus-transport.c: (_dbus_transport_open):
6952 ifdef out the calls to the debug transport and server.
6954 2003-02-02 Alexander Larsson <alexl@redhat.com>
6956 * dbus/dbus-watch.c (dbus_watch_get_flags):
6957 Add note in the docs that ERROR or HANGUP won't be returned
6958 and are assumed always on.
6960 * glib/dbus-gmain.c (add_watch):
6961 Always add IO_ERR | IO_HUP
6963 * dbus/dbus-message.h:
6964 Add semicolon after dbus_message_iter_get_string_array().
6965 Makes qt code build again
6967 2003-02-01 Anders Carlsson <andersca@codefactory.se>
6969 * bus/driver.c: (create_unique_client_name),
6970 (bus_driver_handle_hello):
6971 Don't take a name, just use a numeric id to identify
6975 * dbus/dbus-bus.c: (dbus_bus_register_client),
6976 (dbus_bus_acquire_service), (dbus_bus_service_exists):
6978 Add new convenience functions for communicating with the bus.
6980 * dbus/dbus-message.h:
6982 * dbus/dbus-protocol.h:
6985 2003-02-01 Alexander Larsson <alexl@redhat.com>
6987 * dbus/dbus-message.c (dbus_message_append_fields):
6988 Add some more doc comments.
6990 2003-02-01 Havoc Pennington <hp@pobox.com>
6992 * dbus/dbus-break-loader.c (randomly_modify_length): change
6993 a 4-byte value in the message as if it were a length
6995 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): don't set
6996 execute bit on saved files
6998 2003-02-01 Havoc Pennington <hp@pobox.com>
7000 * dbus/dbus-break-loader.c (main): new program to find messages
7001 that break the loader.
7003 * dbus/dbus-sysdeps.c (_dbus_string_append_uint): new function
7004 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): new function
7006 * dbus/dbus-string.c (_dbus_string_set_byte): new
7008 2003-01-31 Havoc Pennington <hp@pobox.com>
7010 * dbus/dbus-message.c: refactor the test code to be more general,
7011 in preparation for writing a "randomly permute test cases to
7012 try to break the loader" program.
7014 2003-01-31 Havoc Pennington <hp@pobox.com>
7016 * doc/dbus-specification.sgml: work on the specification
7018 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): check
7019 the protocol version of the message.
7021 * dbus/dbus-protocol.h: drop special _REPLY names, the spec
7022 no longer specifies that.
7023 (DBUS_SERVICE_REPLY_SERVICE_EXISTS): fix flags (1/2/4/8 not
7026 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos): add missing
7027 "break" for DBUS_TYPE_NIL, remove @todo
7029 2003-01-31 Havoc Pennington <hp@pobox.com>
7031 * dbus/dbus-message.c (dbus_message_set_is_error_reply): rename
7032 just set_is_error/get_is_error as this is a commonly-used
7033 function, and write docs.
7035 2003-01-31 Anders Carlsson <andersca@codefactory.se>
7037 * dbus/dbus-address.c: (dbus_address_entry_free):
7038 Free key and value lists.
7040 * dbus/dbus-internals.c: (_dbus_type_to_string):
7041 Add the types we didn't have.
7043 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
7044 (_dbus_marshal_validate_arg):
7047 * dbus/dbus-message.c: (dbus_message_set_sender):
7048 Remove todo about being able to set sender to NULL.
7050 (dbus_message_set_is_error_reply),
7051 (dbus_message_get_is_error_reply):
7052 * dbus/dbus-message.h:
7055 * dbus/dbus-protocol.h:
7056 Add error reply flag.
7058 * test/data/valid-messages/opposite-endian.message:
7059 Add NIL type to test.
7061 2003-01-31 Havoc Pennington <hp@pobox.com>
7063 * doc/dbus-specification.sgml: fully specify the header. Add
7064 flags and major protocol version, and change header/body len to
7067 * dbus/dbus-message-builder.c (append_saved_length): append length
7070 * dbus/dbus-message.c (dbus_message_create_header): change header
7071 length and body length to unsigned. Add the new fields from the
7073 (_dbus_message_loader_return_buffer): unsigned header/body len
7075 2003-01-30 Havoc Pennington <hp@pobox.com>
7077 * dbus/dbus-auth.c: rework to use only REJECTED, no
7080 * doc/dbus-sasl-profile.txt: drop MECHANISMS and just
7081 use REJECTED, suggested by Mark McLoughlin
7083 2003-01-30 Havoc Pennington <hp@pobox.com>
7085 * dbus/dbus-server.c (dbus_server_listen): @todo about how we need
7086 a better way to report errors here. e.g. "unix address lacks
7087 path" or something. also "no such file" when the path doesn't
7090 * dbus/dbus-address.c (dbus_address_entries_free): add @todo about
7092 (dbus_parse_address): add @todo about documenting address format,
7093 and allowing , and ; to be escaped
7095 2003-01-30 Anders Carlsson <andersca@codefactory.se>
7098 Add dbus-address.[ch]
7100 * dbus/dbus-address.c: (dbus_address_entry_free),
7101 (dbus_address_entries_free), (create_entry),
7102 (dbus_address_entry_get_method), (dbus_address_entry_get_value),
7103 (dbus_parse_address), (_dbus_address_test):
7104 * dbus/dbus-address.h:
7105 New files for dealing with address parsing.
7107 * dbus/dbus-connection.c:
7108 Document timeout functions.
7110 * dbus/dbus-message.c:
7111 Document dbus_message_new_from_message.
7113 * dbus/dbus-server-debug.c:
7116 * dbus/dbus-server.c: (dbus_server_listen):
7117 Parse address and use correct server implementation.
7119 * dbus/dbus-string.c: (_dbus_string_find_to), (_dbus_string_test):
7120 * dbus/dbus-string.h:
7121 New function with test.
7123 * dbus/dbus-test.c: (dbus_internal_symbol_do_not_use_run_tests):
7127 * dbus/dbus-transport-debug.c:
7130 * dbus/dbus-transport.c: (_dbus_transport_open):
7131 Parse address and use correct transport implementation.
7133 2003-01-30 Havoc Pennington <hp@pobox.com>
7135 * dbus/dbus-message.c: use message->byte_order instead of
7136 DBUS_COMPILER_BYTE_ORDER throughout.
7137 (dbus_message_create_header): pad header to align the
7138 start of the body of the message to 8-byte boundary
7140 * dbus/dbus-marshal.h: make all the demarshalers take const
7141 DBusString arguments.
7143 * dbus/dbus-message.c (_dbus_message_loader_return_buffer):
7144 validate message args here, so we don't have to do slow validation
7145 later, and so we catch bad messages as they are incoming. Also add
7146 better checks on header_len and body_len. Also fill in
7149 * dbus/dbus-string.c (_dbus_string_validate_utf8): new (not
7150 implemented properly)
7151 (_dbus_string_validate_nul): new function to check all-nul
7153 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): rename
7154 get_arg_end_pos and remove all validation
7155 (_dbus_marshal_validate_arg): actually do validation here.
7157 2003-01-29 Havoc Pennington <hp@pobox.com>
7159 * dbus/dbus-message.c (check_message_handling): fix assertion
7160 failure on set_client_serial
7162 2003-01-28 Havoc Pennington <hp@pobox.com>
7164 * dbus/dbus-server-debug.c: Add doc section comments
7166 * dbus/dbus-transport-debug.c: add doc section comments
7168 2003-01-28 Havoc Pennington <hp@redhat.com>
7170 * dbus/dbus-string.c (_dbus_string_base64_decode): append bytes in
7171 the reverse order from how I had it
7172 (_dbus_string_base64_encode): reverse encoding order. I was
7173 basically byteswapping everything during encoding.
7175 2003-01-28 Anders Carlsson <andersca@codefactory.se>
7177 * dbus/dbus-connection-internal.h:
7178 * dbus/dbus-connection.c: (_dbus_connection_add_timeout),
7179 (_dbus_connection_remove_timeout):
7180 Add functions for adding and removing timeouts.
7182 * dbus/dbus-message.c: (dbus_message_new_from_message):
7183 Add new function that takes a message and creates an exact
7184 copy of it, but with the refcount set to 1.
7185 (check_message_handling):
7188 * dbus/dbus-server-protected.h:
7189 * dbus/dbus-server.c: (_dbus_server_init_base),
7190 (_dbus_server_finalize_base), (_dbus_server_add_timeout),
7191 (dbus_server_set_timeout_functions):
7192 (_dbus_server_remove_timeout):
7193 New functions so that a server can add and remove timeouts.
7195 (dbus_server_listen):
7196 Add commented out call to dbus_server_debug_new.
7198 * dbus/dbus-timeout.c: (_dbus_timeout_new):
7199 Actually set the handler, doh.
7201 * dbus/dbus-transport.c: (_dbus_transport_open):
7202 Add commented out call to dbus_transport_debug_client_new.
7205 Add dbus-transport-debug.[ch] and dbus-server-debug.[ch]
7207 2003-01-28 Havoc Pennington <hp@pobox.com>
7209 * dbus/dbus-message.c (check_message_handling): function to check
7210 on the loaded message, iterates over it etc.
7212 2003-01-28 Havoc Pennington <hp@pobox.com>
7214 * test/Makefile.am (dist-hook): fix make distdir
7216 * dbus/Makefile.am (TESTS_ENVIRONMENT): fix make check
7218 2003-01-27 Havoc Pennington <hp@pobox.com>
7220 * dbus/dbus-mempool.c (time_for_size): replace printf with
7223 * dbus/dbus-message-builder.c (_dbus_message_data_load): allow
7224 empty lines; fix the SAVE_LENGTH stuff to be
7225 START_LENGTH/END_LENGTH so it actually works; couple other
7228 * test/Makefile.am (dist-hook): add dist-hook for .message files
7230 * dbus/dbus-string.c (DBUS_STRING_COPY_PREAMBLE): source of a copy
7231 can be constant or locked.
7232 (_dbus_string_free): allow freeing a const string as
7235 * dbus/dbus-sysdeps.c (_dbus_concat_dir_and_file): utility
7237 * dbus/dbus-test-main.c (main): take an argument which is the
7238 directory containing test data
7240 * dbus/dbus-message.c (_dbus_message_test): pass a test_data_dir
7241 argument to this and load all the messages in test/data/
7242 checking that they can be loaded or not loaded as appropriate.
7244 2003-01-27 Anders Carlsson <andersca@codefactory.se>
7246 * bus/dispatch.c: (bus_dispatch_message_handler):
7247 Dispatch messages sent to services.
7249 * bus/driver.c: (bus_driver_send_service_deleted),
7250 (bus_driver_send_service_created), (bus_driver_send_service_lost),
7251 (bus_driver_send_service_acquired):
7252 Add helper functions for sending service related messages.
7254 (bus_driver_send_welcome_message):
7255 Send HELLO_REPLY instead of WELCOME.
7257 (bus_driver_handle_list_services):
7258 Send LIST_SERVICES_REPLY instead of SERVICES.
7260 (bus_driver_handle_own_service),
7261 (bus_driver_handle_service_exists):
7262 New message handlers.
7264 (bus_driver_handle_message):
7265 Invoke new message handlers.
7267 (bus_driver_remove_connection):
7268 Don't remove any services here since that's done automatically
7269 by bus_service_remove_owner now.
7272 New function signatures.
7274 * bus/services.c: (bus_service_add_owner):
7275 Send ServiceAcquired message if we're the only primary owner.
7277 (bus_service_remove_owner):
7278 Send ServiceAcquired/ServiceLost messages.
7280 (bus_service_set_prohibit_replacement),
7281 (bus_service_get_prohibit_replacement):
7282 Functions for setting prohibit replacement.
7284 (bus_service_has_owner):
7285 New function that checks if a connection is in the owner queue of
7289 Add new function signatures.
7291 * dbus/dbus-list.c: (_dbus_list_test):
7292 Add tests for _dbus_list_remove_last and traversing the list backwards.
7295 Fix a typo in _dbus_list_get_prev_link, if we're at the first element we can't
7296 go any further, so return NULL then.
7298 * dbus/dbus-protocol.h:
7299 Add new messages, service flags and service replies.
7301 2003-01-26 Havoc Pennington <hp@pobox.com>
7303 * dbus/dbus-message-builder.c: implement, completely untested.
7305 * test/data/*: add data to be used in testing.
7306 ".message" files are our simple loadable text format.
7307 ".message-raw" will be binary dumps of messages.
7309 * dbus/dbus-string.c (_dbus_string_starts_with_c_str): new
7311 2003-01-26 Havoc Pennington <hp@pobox.com>
7313 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): new function
7315 * dbus/dbus-errors.c (dbus_result_to_string): add
7318 * dbus/dbus-message-builder.c: new file, will contain code to load
7319 up messages from files. Not implemented yet.
7321 2003-01-26 Havoc Pennington <hp@pobox.com>
7323 * dbus/dbus-message.c (dbus_message_set_sender): support deleting
7324 the sender by setting to NULL
7326 2003-01-26 Havoc Pennington <hp@pobox.com>
7328 The unit tests pass, but otherwise untested. If it breaks, the
7329 tests should have been better. ;-)
7331 * bus/driver.c (bus_driver_handle_hello): return if we disconnect
7334 * dbus/dbus-message.c: redo everything so we maintain
7335 message->header as the only copy of the various fields.
7336 This avoids the possibility of out-of-memory in some cases,
7337 for example dbus_message_lock() can't run out of memory anymore,
7338 and avoids extra copying. Figured I may as well go ahead and do
7339 this since it was busted for dbus_message_lock to not return
7340 failure on OOM, and dbus_message_write_header was totally
7341 unchecked for OOM. Also fixed some random other bugs.
7343 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): verify
7344 that strings are nul-terminated. Also, end_pos can be equal
7345 to string length just not greater than, I think.
7346 (_dbus_marshal_set_int32): new function
7347 (_dbus_marshal_set_uint32): new function
7348 (_dbus_marshal_set_string): new function
7350 * dbus/dbus-connection.c (_dbus_connection_new_for_transport): fix
7351 a warning, init timeout_list to NULL
7352 (dbus_connection_send_message): don't use uninitialized variable
7355 * dbus/dbus-string.c (_dbus_string_replace_len): new function
7357 2003-01-26 Anders Carlsson <andersca@codefactory.se>
7359 * bus/driver.c: (bus_driver_handle_hello),
7360 (bus_driver_send_welcome_message):
7363 2003-01-26 Anders Carlsson <andersca@codefactory.se>
7365 * dbus/dbus-auth.c: (process_auth), (_dbus_auth_unref):
7366 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
7367 (dbus_connection_unref):
7368 * dbus/dbus-marshal.c: (_dbus_marshal_test):
7369 * dbus/dbus-message.c: (dbus_message_unref),
7372 (dbus_message_get_fields):
7373 Remove debugging printout.
7375 (_dbus_message_loader_return_buffer):
7376 Don't store the header string.
7378 (_dbus_message_test):
7381 2003-01-26 Richard Hult <rhult@codefactory.se>
7383 * glib/dbus-gmain.c (dbus_connection_dispatch): Traverse a copy of
7384 the file descriptor list, since it can change under us.
7386 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7388 * glib/dbus-gmain.c: (dbus_connection_prepare),
7389 (dbus_connection_check), (dbus_connection_dispatch), (add_watch),
7390 (remove_watch), (dbus_connection_hookup_with_g_main):
7391 Rewrite the glib handling to use its own GSource instead of a
7392 GIOChannel so we can catch messages put in the queue while waiting
7395 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7398 * bus/connection.c: (connection_disconnect_handler),
7399 (connection_watch_callback), (bus_connection_setup):
7400 * bus/dispatch.c: (send_one_message),
7401 (bus_dispatch_broadcast_message), (bus_dispatch_message_handler),
7402 (bus_dispatch_add_connection), (bus_dispatch_remove_connection):
7404 * bus/driver.c: (bus_driver_send_service_deleted),
7405 (bus_driver_send_service_created), (bus_driver_handle_hello),
7406 (bus_driver_send_welcome_message),
7407 (bus_driver_handle_list_services), (bus_driver_remove_connection),
7408 (bus_driver_handle_message):
7410 Refactor code, put the message dispatching in its own file. Use
7411 _DBUS_HANDLE_OOM. Also send ServiceDeleted messages when a client
7414 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7416 * dbus/dbus-internals.h:
7417 Add _DBUS_HANDLE_OOM macro, it doesn't do anything currently.
7419 * dbus/dbus-message.c: (dbus_message_get_sender):
7420 * dbus/dbus-message.h:
7421 Implement dbus_message_get_sender.
7423 * dbus/dbus-protocol.h:
7424 Add message and service defines.
7426 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7428 * dbus/dbus-connection.c: (dbus_connection_send_message):
7429 * dbus/dbus-message-internal.h:
7430 * dbus/dbus-message.c: (_dbus_message_get_client_serial),
7431 (dbus_message_write_header):
7432 Remove _dbus_messag_unlock and don't set the client serial on a
7433 message if one already exists.
7435 2003-01-24 Havoc Pennington <hp@pobox.com>
7437 * dbus/dbus-list.c (alloc_link): put a thread lock on the global
7440 * bus/driver.c (bus_driver_handle_list_services): fix a leak
7443 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7445 * dbus/dbus-list.c: (alloc_link), (free_link):
7446 Use a memory pool for the links.
7448 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7450 * bus/connection.c: (bus_connection_foreach):
7452 Add new bus_connection_foreach function.
7454 * bus/driver.c: (send_one_message), (bus_driver_broadcast_message):
7455 Add function that broadcasts a message to all clients.
7457 (bus_driver_send_service_created), (bus_driver_handle_hello),
7458 (bus_driver_send_welcome_message),
7459 (bus_driver_handle_list_services), (bus_driver_message_handler):
7460 Implement functions that take care of listing services, and notifying
7461 clients when new services are created.
7463 * bus/services.c: (bus_services_list):
7465 Add new function that returns an array of strings with the currently
7466 registered services.
7469 * glib/dbus-gmain.c:
7470 Update copyright year.
7472 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7474 * dbus/dbus-connection.c: (dbus_connection_send_message):
7475 Unlock the message in case it was sent earlier.
7477 (dbus_connection_send_message_with_reply_and_block):
7478 Remove the reply message from the list.
7480 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
7481 Set array_len and new_pos correctly.
7483 (_dbus_marshal_test):
7484 Remove debug output.
7486 * dbus/dbus-message-internal.h:
7487 * dbus/dbus-message.c: (_dbus_message_get_reply_serial):
7488 New function that returns the reply serial.
7490 (_dbus_message_unlock):
7491 New function that unlocks a message and resets its header.
7493 (dbus_message_append_string_array),
7494 (dbus_message_get_fields_valist),
7495 (dbus_message_iter_get_field_type),
7496 (dbus_message_iter_get_string_array),
7497 (dbus_message_get_fields),
7498 (dbus_message_append_fields_valist):
7499 Handle string arrays.
7501 (dbus_message_set_sender):
7502 Make this function public since the bus daemon needs it.
7504 (decode_header_data):
7505 Set the reply serial to -1 initially.
7507 * dbus/dbus-message.h:
7508 Add dbus_message_set_sender.
7510 2003-01-24 Havoc Pennington <hp@pobox.com>
7512 * doc/dbus-specification.sgml: add some stuff
7514 2003-01-22 Havoc Pennington <hp@pobox.com>
7516 * doc/dbus-specification.sgml: Start to document the protocol.
7518 2003-01-22 Havoc Pennington <hp@pobox.com>
7520 * dbus/dbus-connection.c
7521 (dbus_connection_send_message_with_reply_and_block): add some @todo
7523 * bus/driver.c (bus_driver_add_connection): add a FIXME about memleak
7525 2003-01-21 Havoc Pennington <hp@pobox.com>
7527 (patch untested because can't compile)
7529 * bus/driver.c (create_unique_client_name): make this function
7530 never recycle client names. Also, caller should initialize
7533 * dbus/dbus-sysdeps.c (_dbus_get_current_time): new function
7535 2003-01-21 Anders Carlsson <andersca@codefactory.se>
7537 * dbus/dbus-marshal.c: (_dbus_marshal_double),
7538 (_dbus_marshal_int32), (_dbus_marshal_uint32),
7539 (_dbus_marshal_int32_array), (_dbus_marshal_uint32_array),
7540 (_dbus_marshal_double_array), (_dbus_marshal_string_array),
7541 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
7542 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
7543 (_dbus_marshal_get_field_end_pos), (_dbus_marshal_test):
7544 * dbus/dbus-marshal.h:
7545 * dbus/dbus-protocol.h:
7546 Add support for marshalling and demarshalling integer, double
7549 2003-01-21 Anders Carlsson <andersca@codefactory.se>
7554 * bus/connection.c: (connection_disconnect_handler):
7555 Remove the connection from the bus driver's list.
7557 (connection_watch_callback): Dispatch messages.
7559 (free_connection_data): Free connection name.
7561 (bus_connection_setup): Add connection to the bus driver's list.
7562 (bus_connection_remove_owned_service):
7563 (bus_connection_set_name), (bus_connection_get_name):
7564 Add functions for setting and getting the connection's name.
7567 Add function headers.
7569 * bus/driver.c: (create_unique_client_name),
7570 (bus_driver_handle_hello_message),
7571 (bus_driver_send_welcome_message), (bus_driver_message_handler),
7572 (bus_driver_add_connection), (bus_driver_remove_connection):
7575 * bus/services.c: (bus_service_free):
7577 New file that handles communication and registreation with the bus
7580 2003-01-21 Anders Carlsson <andersca@codefactory.se>
7582 * dbus/dbus-connection.c: (dbus_connection_send_message):
7583 Add a new client_serial parameter.
7585 (dbus_connection_send_message_with_reply):
7586 Remove a @todo since we've implemented the blocking function.
7588 (dbus_connection_send_message_with_reply_and_block):
7589 New function that sends a message and waits for a reply and
7590 then returns the reply.
7592 * dbus/dbus-connection.h:
7595 * dbus/dbus-errors.c: (dbus_result_to_string):
7596 * dbus/dbus-errors.h:
7597 Add new DBUS_RESULT.
7599 * dbus/dbus-message-internal.h:
7600 * dbus/dbus-message.c: (_dbus_message_get_reply_serial),
7601 (_dbus_message_set_sender), (dbus_message_write_header),
7602 (dbus_message_new_reply), (decode_header_data),
7603 (_dbus_message_loader_return_buffer), (_dbus_message_test):
7604 * dbus/dbus-message.h:
7605 Add new functions that set the reply serial and sender.
7606 Also marshal and demarshal them correctly and add test.
7608 * dbus/dbus-protocol.h:
7609 Add new DBUS_MESSAGE_TYPE_SENDER.
7612 * glib/dbus-gmain.c: (watch_callback), (free_callback_data),
7613 (add_watch), (remove_watch), (add_timeout), (remove_timeout),
7614 (dbus_connection_hookup_with_g_main):
7615 * glib/test-dbus-glib.c: (main):
7616 Rewrite to use GIOChannel and remove the GSource crack.
7618 * test/echo-client.c: (main):
7619 * test/watch.c: (check_messages):
7620 Update for changed APIs
7622 2003-01-19 Anders Carlsson <andersca@codefactory.se>
7624 * dbus/Makefile.am: Add dbus-timeout.[cħ]
7626 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport):
7627 Create a DBusTimeoutList.
7628 (dbus_connection_set_timeout_functions): Add new function to
7629 set timeout callbacks
7631 * dbus/dbus-connection.h: Add public DBusTimeout API.
7633 * dbus/dbus-message.c: (dbus_message_get_service):
7634 * dbus/dbus-message.h: New function.
7636 * dbus/dbus-server.c: Fix small doc typo.
7638 * dbus/dbus-timeout.[ch]: New files for mainloop timeouts.
7640 2003-01-19 Anders Carlsson <andersca@codefactory.se>
7642 * dbus/dbus-string.c (_dbus_string_move_len): Don't delete all
7643 of the string, just as long as specified.
7645 2003-01-19 Havoc Pennington <hp@pobox.com>
7647 * dbus/dbus-connection.c (dbus_connection_get_is_authenticated):
7650 * dbus/dbus-server.c (dbus_server_set_max_connections)
7651 (dbus_server_get_max_connections, dbus_server_get_n_connections):
7652 keep track of current number of connections, and add API for
7653 setting a max (but haven't implemented enforcing the max yet)
7655 2003-01-18 Havoc Pennington <hp@pobox.com>
7657 * dbus/dbus-transport-unix.c (unix_do_iteration): only do the
7658 reading/writing if read_watch != NULL or write_watch != NULL.
7660 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): fix
7661 the message loader code to actually load message->header and
7662 message->body into the newly-created message.
7664 * dbus/dbus-transport-unix.c (check_write_watch): fix a mem leak
7667 * dbus/dbus-connection.c (dbus_connection_set_max_message_size)
7668 (dbus_connection_get_max_message_size)
7669 (dbus_connection_set_max_live_messages_size)
7670 (dbus_connection_get_max_live_messages_size): implement some
7671 resource limitation functions
7673 * dbus/dbus-resources.c: new file implementing some of the
7674 resource limits stuff
7676 * dbus/dbus-message.c (dbus_message_iter_get_byte_array): add
7677 missing docs, add @todo to handle OOM etc.
7679 * dbus/dbus-marshal.c (_dbus_demarshal_byte_array): add missing
7682 2003-01-18 Havoc Pennington <hp@pobox.com>
7684 * dbus/dbus-connection.c (dbus_connection_unref): disconnect the
7685 connection if it hasn't been already.
7687 * dbus/dbus-connection.h: kill off the idea of an ErrorFunction,
7688 replace with DisconnectFunction.
7690 2003-01-18 Havoc Pennington <hp@pobox.com>
7692 Building --disable-verbose-mode --disable-asserts --disable-tests
7693 cuts the library from 112K to 45K or so
7695 * configure.in: check for varargs macro support,
7696 add --enable-verbose-mode, --enable-asserts.
7698 * dbus/dbus-internals.h (_dbus_assert): support
7700 (_dbus_verbose): support DBUS_ENABLE_VERBOSE_MODE
7702 2003-01-18 Havoc Pennington <hp@pobox.com>
7704 * dbus/dbus-test.c: include config.h so that tests actually run
7706 * dbus/dbus-string.c: add assertions that stuff is 8-byte aligned,
7707 so the failure mode when that assumption fails will be plenty
7710 2003-01-18 Havoc Pennington <hp@pobox.com>
7712 * configure.in: default --enable-tests to $USE_MAINTAINER_MODE
7714 * dbus/Makefile.am: fix it up so dubs-test-main.c is included in
7717 * test/Makefile.am: don't use special variable "TESTS" for echo-*
7718 since we don't want to use those in make check
7720 2003-01-15 Havoc Pennington <hp@redhat.com>
7726 2003-01-15 Havoc Pennington <hp@redhat.com>
7728 * test/Makefile.am: fix so that test source code ends up in the
7729 distribution on make distcheck
7731 2003-01-15 Havoc Pennington <hp@redhat.com>
7737 2003-01-15 Havoc Pennington <hp@redhat.com>
7739 * dbus/dbus-test.c (dbus_internal_symbol_do_not_use_run_tests):
7740 fix build when --disable-tests
7742 * Makefile.am (EXTRA_DIST): put HACKING in here
7744 * HACKING: document procedure for making a tarball release.
7746 2003-01-14 Anders Carlsson <andersca@codefactory.se>
7748 * bus/connection.c: (connection_error_handler),
7749 (bus_connection_setup):
7750 * bus/main.c: (main):
7751 Make sure that the DBusConnectionData struct is NULLed
7752 out to prevent a segfault.
7754 * dbus/dbus-errors.c: (dbus_result_to_string):
7755 * dbus/dbus-errors.h:
7756 * dbus/dbus-message.c: (dbus_message_get_fields),
7757 (dbus_message_get_fields_valist), (_dbus_message_test):
7758 * dbus/dbus-message.h:
7759 Make dbus_message_get_fields return a result code so we can
7760 track invalid fields as well as oom.
7762 2003-01-11 Havoc Pennington <hp@pobox.com>
7764 * configure.in: change --enable-test/--enable-ansi action-if-given
7765 to enable_foo=$enableval instead of enable_foo=yes
7767 2003-01-08 Havoc Pennington <hp@pobox.com>
7769 * dbus/dbus-string.c (_dbus_string_align_length): new function
7771 * dbus/dbus-test-main.c: move main() for test app here
7773 (dbus_internal_symbol_do_not_use_run_tests): we have to export a
7774 symbol to run tests, because dbus-test isn't in the main
7777 Code review nitpicks.
7779 * dbus/dbus-message.c (dbus_message_write_header): add newlines
7780 for people with narrow emacs ;-). Assert client_serial was filled
7781 in. Assert message->name != NULL.
7782 (dbus_message_append_fields): have "first_field_type" arg separate
7783 from va list, needed for C++ binding that also uses varargs IIRC
7784 and helps with type safety
7785 (dbus_message_new): add @todo about using DBusString to store
7786 service/name internally
7787 (dbus_message_new): don't leak ->service and ->name on OOM later
7789 (dbus_message_unref): free the service name
7790 (dbus_message_get_fields): same change to varargs
7791 i.e. first_field_type
7792 (_dbus_message_loader_return_buffer): assert that the message data
7793 is aligned (if not it's a bug in our code). Put in verbose griping
7794 about why we set corrupted = TRUE.
7795 (decode_header_data): add FIXME that char* is evil. Was going to
7796 add FIXME about evil locale-specific string.h strncmp, but just
7797 switched to wacky string-as-uint32 optimization. Move check for
7798 "no room for field name" above get_const_data_len() to avoid
7799 assertion failure in get_const_data_len if we have trailing 2
7800 bytes or the like. Check for service and name fields being
7801 provided twice. Don't leak service/name on error. Require field
7802 names to be aligned to 4 bytes.
7804 * dbus/dbus-marshal.c: move byte swap stuff to header
7805 (_dbus_pack_int32): uscore-prefix
7806 (_dbus_unpack_int32): uscore-prefix
7807 (_dbus_unpack_uint32): export
7808 (_dbus_demarshal_string): add @todo complaining about use of
7810 (_dbus_marshal_get_field_end_pos): add @todo about bad error
7811 handling allowing corrupt data to go unchecked
7813 2003-01-08 Havoc Pennington <hp@redhat.com>
7815 * dbus/dbus-transport-unix.c (unix_do_iteration): add read/write
7816 to the select() as needed for authentication. (should be using
7817 _dbus_poll() not select, but for another day)
7819 * dbus/dbus.h: include dbus/dbus-protocol.h
7821 2003-01-08 Anders Carlsson <andersca@codefactory.se>
7823 * dbus/Makefile.am (dbusinclude_HEADERS): Install
7826 2003-01-08 Anders Carlsson <andersca@codefactory.se>
7828 * dbus/dbus-internals.c: (_dbus_type_to_string):
7829 New function that returns a string describing a type.
7831 * dbus/dbus-marshal.c: (_dbus_demarshal_byte_array):
7832 * dbus/dbus-marshal.h:
7833 * dbus/dbus-message.c: (dbus_message_get_fields_valist),
7834 (dbus_message_iter_get_field_type), (dbus_message_iter_get_double),
7835 (dbus_message_iter_get_byte_array):
7836 * dbus/dbus-message.h:
7837 Add new convenience functions for appending and getting message fields.
7838 Also add demarshalling routines for byte arrays.
7840 2003-01-07 Anders Carlsson <andersca@codefactory.se>
7842 * dbus/dbus-connection-internal.h:
7843 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
7844 (_dbus_connection_get_next_client_serial),
7845 (dbus_connection_send_message):
7846 * dbus/dbus-internals.h:
7847 * dbus/dbus-marshal.c: (unpack_uint32), (dbus_unpack_int32),
7848 (dbus_pack_int32), (_dbus_marshal_double), (_dbus_marshal_int32),
7849 (_dbus_marshal_uint32), (_dbus_demarshal_double),
7850 (_dbus_demarshal_int32), (_dbus_demarshal_uint32),
7851 (_dbus_demarshal_string), (_dbus_marshal_get_field_end_pos),
7852 (_dbus_verbose_bytes), (_dbus_marshal_test):
7853 * dbus/dbus-marshal.h:
7854 * dbus/dbus-message-internal.h:
7855 * dbus/dbus-message.c: (_dbus_message_set_client_serial),
7856 (dbus_message_write_header), (_dbus_message_lock),
7857 (dbus_message_new), (dbus_message_ref), (dbus_message_unref),
7858 (dbus_message_get_name), (dbus_message_append_int32),
7859 (dbus_message_append_uint32), (dbus_message_append_double),
7860 (dbus_message_append_string), (dbus_message_append_byte_array),
7861 (dbus_message_get_fields_iter), (dbus_message_iter_ref),
7862 (dbus_message_iter_unref), (dbus_message_iter_has_next),
7863 (dbus_message_iter_next), (dbus_message_iter_get_field_type),
7864 (dbus_message_iter_get_string), (dbus_message_iter_get_int32),
7865 (dbus_message_iter_get_uint32), (dbus_message_iter_get_double),
7866 (decode_header_data), (_dbus_message_loader_return_buffer),
7867 (message_iter_test), (_dbus_message_test):
7868 * dbus/dbus-message.h:
7869 * dbus/dbus-protocol.h:
7870 * dbus/dbus-test.c: (main):
7872 * glib/test-dbus-glib.c: (message_handler), (main):
7873 * test/echo-client.c: (main):
7874 * test/watch.c: (check_messages):
7875 Make messages sendable and receivable for real.
7877 2003-01-07 Anders Carlsson <andersca@codefactory.se>
7879 * dbus/dbus-marshal.c: (_dbus_marshal_double),
7880 (_dbus_marshal_string), (_dbus_marshal_byte_array):
7881 * dbus/dbus-message.c: (dbus_message_append_int32),
7882 (dbus_message_append_uint32), (dbus_message_append_double),
7883 (dbus_message_append_string), (dbus_message_append_byte_array):
7884 Handle OOM restoration.
7886 2003-01-07 Anders Carlsson <andersca@codefactory.se>
7888 * dbus/dbus-marshal.c: (_dbus_marshal_string),
7889 (_dbus_demarshal_string), (_dbus_marshal_test):
7890 * dbus/dbus-marshal.h:
7891 * dbus/dbus-message.c: (dbus_message_get_name),
7892 Document these functions.
7894 (dbus_message_append_int32), (dbus_message_append_uint32),
7895 (dbus_message_append_double), (dbus_message_append_string),
7896 (dbus_message_append_byte_array):
7897 * dbus/dbus-message.h:
7898 Add functions for adding message fields of different types.
7900 * dbus/dbus-protocol.h:
7901 Add the different types.
7903 2003-01-05 Havoc Pennington <hp@pobox.com>
7905 * bus/connection.c: implement routines for handling connections,
7906 first thing is keeping a list of owned services on each connection
7907 and setting up watches etc.
7909 * bus/services.c: implement a mapping from service names to lists
7912 * dbus/dbus-hash.c: add DBUS_HASH_POINTER
7914 * dbus/dbus-threads.c (dbus_static_mutex_lock): add functions
7915 to use static mutexes for global data
7917 * dbus/dbus-connection.c (dbus_connection_set_data): add new
7918 collection of functions to set/get application-specific data
7919 on the DBusConnection.
7921 2003-01-04 Havoc Pennington <hp@pobox.com>
7923 * dbus/dbus-sysdeps.c (_dbus_sleep_milliseconds): new function
7924 (_dbus_poll): new function
7926 * dbus/dbus-internals.h (_DBUS_STRUCT_OFFSET): new macro
7929 * bus/loop.c: initial code for the daemon main loop
7931 2003-01-04 Havoc Pennington <hp@pobox.com>
7933 * test/watch.c (error_handler): make it safe if the error handler
7934 is called multiple times (if we s/error handler/disconnect
7935 handler/ we should just guarantee it's called only once)
7937 * dbus/dbus-transport.c (_dbus_transport_disconnect): call the
7938 error handler on disconnect (it's quite possible we should
7939 just change the error handler to a "disconnect handler," I'm
7940 not sure we have any other meaningful errors)
7942 * configure.in: check for getpwnam_r
7944 * dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
7945 dbus/dbus-auth.c: add credentials support, add EXTERNAL auth
7946 mechanism as in SASL spec, using socket credentials
7948 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): new function
7949 (_dbus_send_credentials_unix_socket): new function
7951 * dbus/dbus-sysdeps.c (_dbus_accept_unix_socket): rename just
7953 (_dbus_write): only check errno if <0 returned
7954 (_dbus_write_two): ditto
7956 2003-01-02 Anders Carlsson <andersca@codefactory.se>
7958 * dbus/dbus-marshal.c: (_dbus_marshal_utf8_string),
7959 (_dbus_marshal_byte_array), (_dbus_demarshal_utf8_string),
7960 (_dbus_marshal_test):
7961 * dbus/dbus-marshal.h:
7962 Add _dbus_marshal_byte_array and rename _dbus_marshal_string
7963 to _dbus_marshal_utf8_string. Also fix some tests.
7965 2002-12-28 Harri Porten <porten@kde.org>
7967 * configure.in: added check for C++ compiler and a very cheesy
7968 check for the Qt integration
7970 * Makefile.am (SUBDIRS): compile qt subdir if support is enabled
7972 * qt/Makefile.am: added
7974 * qt/.cvsignore: added
7976 * qt/dbus-qthread.cc, qt/dbus-qthread.cpp: renamed former to
7977 latter, added #ifdef QT_THREAD_SUPPORT guard.
7979 * dbus/Makefile.am: added missing headers for make dist
7981 2002-12-28 Kristian Rietveld <kris@gtk.org>
7983 * dbus/Makefile.am: fixup export-symbols-regex.
7985 2002-12-27 Anders Carlsson <andersca@codefactory.se>
7987 * acinclude.m4: Add this file and put the
7988 PKG_CHECK_MODULE macro in it.
7990 2002-12-27 Anders Carlsson <andersca@codefactory.se>
7992 * dbus/dbus-marshal.c: (_dbus_marshal_string),
7993 (_dbus_demarshal_double), (_dbus_demarshal_int32),
7994 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
7995 (_dbus_marshal_test):
7996 Make the demarshalling routines align the pos argument.
7997 Add string marshalling tests and fix the obvious bugs
8000 2002-12-26 Havoc Pennington <hp@pobox.com>
8002 * dbus/dbus-auth.c: fixes fixes fixes
8004 * dbus/dbus-transport-unix.c: wire up support for
8005 encoding/decoding data on the wire
8007 * dbus/dbus-auth.c (_dbus_auth_encode_data)
8008 (_dbus_auth_decode_data): append to target string
8009 instead of nuking it.
8011 2002-12-26 Havoc Pennington <hp@pobox.com>
8013 * dbus/dbus-marshal.h (DBUS_COMPILER_BYTE_ORDER): #ifdef
8014 WORDS_BIGENDIAN then compiler byte order is DBUS_BIG_ENDIAN,
8017 * dbus/dbus-marshal.c: Add macros to do int swapping in-place and
8018 avoid swap_bytes() overhead (ignoring possible assembly stuff for
8019 now). Main point is because I wanted unpack_uint32 to implement
8021 (_dbus_verbose_bytes): new function
8023 * dbus/dbus-string.c (_dbus_string_validate_ascii): new function
8025 * dbus/dbus-message.c (_dbus_message_loader_get_is_corrupted): add
8026 mechanism to handle a corrupt message stream
8027 (_dbus_message_loader_new): fix preallocation to only prealloc,
8030 * dbus/dbus-string.c (_dbus_string_skip_blank): fix this function
8031 (_dbus_string_test): enhance tests for copy/move and fix the
8034 * dbus/dbus-transport-unix.c: Hold references in more places to
8035 avoid reentrancy problems
8037 * dbus/dbus-transport.c: ditto
8039 * dbus/dbus-connection.c (dbus_connection_dispatch_message): don't
8040 leak reference count in no-message case
8042 * test/watch.c (do_mainloop): handle adding/removing watches
8043 during iteration over the watches. Also, ref the connection/server
8044 stored on a watch, so we don't try to mangle a destroyed one.
8046 * dbus/dbus-transport-unix.c (do_authentication): perform
8049 * dbus/dbus-auth.c (get_state): add a state
8050 AUTHENTICATED_WITH_UNUSED_BYTES and return it if required
8051 (_dbus_auth_get_unused_bytes): append the unused bytes
8052 to the passed in string, rather than prepend
8054 * dbus/dbus-transport.c (_dbus_transport_init_base): create
8055 the auth conversation DBusAuth
8057 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd)
8058 (_dbus_transport_new_for_domain_socket): when creating a
8059 transport, pass in whether it's a client-side or server-side
8060 transport so we know which DBusAuth to create
8062 2002-12-03 Havoc Pennington <hp@pobox.com>
8064 * dbus/dbus-transport-unix.c (unix_finalize): finalize base
8065 _after_ finalizing the derived members
8066 (unix_connection_set): unref watch if we fail to add it
8068 * dbus/dbus-connection.c (dbus_connection_unref): delete the
8069 transport first, so that the connection owned by the
8070 transport will be valid as the transport finalizes.
8072 * dbus/dbus-transport-unix.c (unix_finalize): free the write_watch
8073 if necessary, and remove watches from the connection.
8075 * dbus/dbus-watch.c (_dbus_watch_list_free): improve a comment
8077 2002-12-26 Anders Carlsson <andersca@codefactory.se>
8079 * dbus/dbus-marshal.c: (_dbus_marshal_string),
8080 (_dbus_demarshal_double), (_dbus_demarshal_int32),
8081 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
8082 (_dbus_marshal_test):
8083 * dbus/dbus-marshal.h:
8084 Add string marshal functions and have the demarshal functions
8085 return the new position.
8087 2002-12-25 Havoc Pennington <hp@pobox.com>
8089 * doc/dbus-sasl-profile.txt: docs on the authentication protocol,
8090 it is a simple protocol that just maps directly to SASL.
8092 * dbus/dbus-auth.h, dbus/dbus-auth.c: authentication protocol
8093 initial implementation, not actually used yet.
8095 * dbus/dbus-string.c (_dbus_string_find): new function
8096 (_dbus_string_equal): new function
8097 (_dbus_string_base64_encode): new function
8098 (_dbus_string_base64_decode): new function
8100 2002-12-25 Anders Carlsson <andersca@codefactory.se>
8103 * dbus/dbus-marshal.c: (swap_bytes), (_dbus_marshal_double),
8104 (_dbus_marshal_int32), (_dbus_marshal_uint32),
8105 (_dbus_demarshal_double), (_dbus_demarshal_int32),
8106 (_dbus_demarshal_uint32), (_dbus_marshal_test):
8107 * dbus/dbus-marshal.h:
8108 * dbus/dbus-protocol.h:
8109 * dbus/dbus-test.c: (main):
8111 Add un-optimized marshalling/demarshalling routines.
8113 2002-12-25 Harri Porten <porten@kde.org>
8115 * qt/dbus-qt.h: adjusted ctor and getter to KDE/Qt conventions
8117 2002-12-24 Zack Rusin <zack@kde.org>
8119 * qt/dbus-qthread.cc: adding - integrates QMutex into Dbus
8120 * qt/dbus-qt.h: skeleton with two sample implemenatation of the
8123 2002-12-24 Havoc Pennington <hp@pobox.com>
8125 * glib/dbus-gthread.c: fix include
8127 * glib/dbus-glib.h: rename DBusMessageHandler for now.
8128 I think glib API needs to change, though, as you don't
8129 want to use DBusMessageFunction, you want to use the
8130 DBusMessageHandler object. Probably
8131 dbus_connection_open_with_g_main_loop()
8132 and dbus_connection_setup_g_main_loop() or something like that
8133 (but think of better names...) that just create a connection
8134 that has watch/timeout functions etc. already set up.
8136 * dbus/dbus-connection.c
8137 (dbus_connection_send_message_with_reply): new function just to
8138 show how the message handler helps us deal with replies.
8140 * dbus/dbus-list.c (_dbus_list_remove_last): new function
8142 * dbus/dbus-string.c (_dbus_string_test): free a string that
8145 * dbus/dbus-hash.c: use memory pools for the hash entries
8146 (rebuild_table): be more paranoid about overflow, and
8147 shrink table when we can
8148 (_dbus_hash_test): reduce number of sprintfs and write
8149 valid C89. Add tests for case where we grow and then
8150 shrink the hash table.
8152 * dbus/dbus-mempool.h, dbus/dbus-mempool.c: memory pools
8154 * dbus/dbus-connection.c (dbus_connection_register_handler)
8155 (dbus_connection_unregister_handler): new functions
8157 * dbus/dbus-message.c (dbus_message_get_name): new
8159 * dbus/dbus-list.c: fix docs typo
8161 * dbus/dbus-message-handler.h, dbus/dbus-message-handler.c:
8162 an object representing a handler for messages.
8164 2002-12-16 Anders Carlsson <andersca@codefactory.se>
8167 * glib/dbus-gthread.c: (dbus_gthread_init):
8168 Don't use the gdbus prefix for public functions.
8170 2002-12-16 Anders Carlsson <andersca@codefactory.se>
8174 Add GLib checks and fixup .pc files
8178 * glib/dbus-gmain.c: (gdbus_connection_prepare),
8179 (gdbus_connection_check), (gdbus_connection_dispatch),
8180 (gdbus_add_connection_watch), (gdbus_remove_connection_watch),
8181 (dbus_connection_gsource_new):
8182 * glib/dbus-gthread.c: (dbus_gmutex_new), (dbus_gmutex_free),
8183 (dbus_gmutex_lock), (dbus_gmutex_unlock), (dbus_gthread_init):
8184 * glib/test-dbus-glib.c: (message_handler), (main):
8187 2002-12-15 Harri Porten <porten@kde.org>
8189 * autogen.sh: check for libtoolize before attempting to use it
8191 * dbus/dbus-transport-unix.c: include <sys/time.h> for timeval
8194 * .cvsignore: ignore more stamp files
8196 * dbus/dbus-watch.c (_dbus_watch_list_new): fixed doc error
8198 * test/Makefile.am: added -I$(top_srcdir) to be able to compile
8199 without make install.
8201 2002-12-15 Havoc Pennington <hp@pobox.com>
8203 * dbus/dbus-threads.c: add thread stubs that a higher library
8204 layer can fill in. e.g. the GLib wrapper might fill them in with
8205 GThread stuff. We still need to use this thread API to
8206 thread-safe-ize the library.
8208 2002-12-12 Havoc Pennington <hp@pobox.com>
8210 * dbus/dbus-transport-unix.c, dbus/dbus-server-unix.c: use the
8211 below new interfaces and include fewer system headers.
8213 * dbus/dbus-sysdeps.c (_dbus_read): new function
8214 (_dbus_write): new function
8215 (_dbus_write_two): new function
8216 (_dbus_connect_unix_socket): new function
8217 (_dbus_listen_unix_socket): new function
8219 * dbus/dbus-message-internal.h: change interfaces to use
8222 2002-12-11 Havoc Pennington <hp@pobox.com>
8224 * dbus/dbus-types.h: add dbus_unichar
8226 * dbus/dbus-internals.c (_dbus_verbose): use _dbus_getenv
8228 * dbus/dbus-connection.c (dbus_connection_send_message): return
8231 * dbus/dbus-transport.c: include dbus-watch.h
8233 * dbus/dbus-connection.c: include dbus-message-internal.h
8235 * HACKING: add file with coding guidelines stuff.
8237 * dbus/dbus-string.h, dbus/dbus-string.c: Encapsulate all string
8238 handling here, for security purposes (as in vsftpd). Not actually
8239 using this class yet.
8241 * dbus/dbus-sysdeps.h, dbus/dbus-sysdeps.c: Encapsulate all
8242 system/libc usage here, as in vsftpd, for ease of auditing (and
8243 should also simplify portability). Haven't actually moved all the
8244 system/libc usage into here yet.
8246 2002-11-25 Havoc Pennington <hp@pobox.com>
8248 * dbus/dbus-internals.c (_dbus_verbose): fix to not
8249 always print the first verbose message.
8251 2002-11-24 Havoc Pennington <hp@pobox.com>
8253 * test/echo-client.c, test/echo-server.c: cheesy test
8256 * configure.in (AC_CHECK_FUNCS): check for writev
8258 * dbus/dbus-message.c (_dbus_message_get_network_data): new
8261 * dbus/dbus-list.c (_dbus_list_foreach): new function
8263 * dbus/dbus-internals.c (_dbus_verbose): new function
8265 * dbus/dbus-server.c, dbus/dbus-server.h: public object
8266 representing a server that listens for connections.
8268 * dbus/.cvsignore: create
8270 * dbus/dbus-errors.h, dbus/dbus-errors.c:
8271 public API for reporting errors
8273 * dbus/dbus-connection.h, dbus/dbus-connection.c:
8274 public object representing a connection that
8275 sends/receives messages. (Same object used for
8276 both client and server.)
8278 * dbus/dbus-transport.h, dbus/dbus-transport.c:
8279 Basic abstraction for different kinds of stream
8280 that we might read/write messages from.
8282 2002-11-23 Havoc Pennington <hp@pobox.com>
8284 * dbus/dbus-internals.h (_DBUS_INT_MAX): add _DBUS_INT_MIN
8287 * dbus/dbus-test.c (main): add list test, and include
8288 dbus-test.h as intended
8290 * dbus/dbus-hash.c (_dbus_hash_table_remove_string)
8291 (_dbus_hash_table_remove_int): return value indicates
8292 whether the entry existed to remove
8294 * dbus/dbus-list.c: add linked list utility class,
8297 * dbus/dbus-hash.c: add TODO item about shrinking the hash bucket
8300 2002-11-23 Havoc Pennington <hp@pobox.com>
8302 * Doxyfile.in (INCLUDE_FILE_PATTERNS): expand DBUS_BEGIN_DECLS/
8303 DBUS_END_DECLS to nothing, that should fix this once and for all
8305 * Doxyfile.in (JAVADOC_AUTOBRIEF): set to YES
8307 * dbus/dbus-message.c, dbus/dbus-hash.c:
8308 add some missing @brief
8310 2002-11-23 Havoc Pennington <hp@pobox.com>
8312 * dbus/dbus-message.h: put semicolons after DEBUG_BEGIN_DECLS
8313 to avoid confusing Doxygen
8315 * dbus/dbus-hash.c: @} not }@
8317 * dbus/dbus-message.c (struct DBusMessage): split out
8320 2002-11-23 Havoc Pennington <hp@pobox.com>
8322 * configure.in: pile on more warning flags if using gcc
8324 * Doxyfile.in (EXTRACT_STATIC): set to NO, so we don't have
8325 to document static functions
8327 * configure.in: add summary to end of configure so it
8328 looks nice and attractive
8330 * dbus/dbus-hash.c: finish implementation and write unit
8333 * configure.in: add --enable-tests to enable unit tests
8335 * dbus/dbus-test.c: test program to run unit tests
8336 for all files in dbus/*, initially runs a test for
8339 * dbus/dbus-internals.h: file to hold some internal utility stuff
8341 2002-11-22 Havoc Pennington <hp@redhat.com>
8343 * dbus/dbus-hash.c: copy in Tcl hash table, not yet
8344 "ported" away from Tcl
8346 * dbus/dbus-types.h: header for types such as dbus_bool_t
8348 2002-11-22 Havoc Pennington <hp@redhat.com>
8350 * dbus/dbus.h: fixups for doc warnings
8352 * Doxyfile.in (FILE_PATTERNS): we need to scan .h to pick up
8354 (QUIET): make it quiet so we can see warnings
8356 * dbus/dbus-memory.c: teach D-BUS to allocate and free memory
8358 2002-11-22 Havoc Pennington <hp@redhat.com>
8360 * Makefile.am: include "Doxyfile" target in all-local
8362 * configure.in: generate the Doxyfile
8364 * Doxyfile.in: move Doxyfile here, so we can use
8365 configure to generate a Doxyfile with the right
8368 2002-11-22 Havoc Pennington <hp@redhat.com>
8370 * dbus/dbus-message.c: move inline docs into .c file
8372 * Doxyfile (OUTPUT_DIRECTORY): move output to doc/api
8373 so all docs are under doc/
8374 (MAN_EXTENSION): generate man pages. Use extension
8375 ".3dbus" which matches ".3qt" on my system,
8376 I guess this is OK, I don't know really.
8377 (FILE_PATTERNS): look for .c files not .h, makes sense
8380 2002-11-22 Havoc Pennington <hp@pobox.com>
8382 * Makefile.am (SUBDIRS): rename subdir "server" to "bus"
8383 because any app can be a server, and any app can be a client,
8384 the bus is a special kind of server.
8386 Thu Nov 21 23:35:31 2002 Zack Rusin <zack@kde.org>
8388 * Doxyfile : adding. Still needs Makefile rules to be generated
8389 automatically (just run "doxygen" in the toplevel dir for now to
8392 * dbus/dbus-message.h : Adding sample docs (javadoc since
8393 resembles gtk-doc a little more)
8395 * dbus/dbus.h : Adding sample docs
8397 2002-11-21 Havoc Pennington <hp@redhat.com>
8399 * dbus/Makefile.am (INCLUDES): define DBUS_COMPILATION
8400 so we can allow ourselves to include files directly,
8401 instead of having to use dbus.h
8403 * dbus/dbus.h: fill in
8405 * dbus/dbus-message.h: sketch out a sample header file.
8406 Include griping if you include it directly instead of
8409 * dbus/dbus-macros.h: new file with macros for extern "C",
8410 TRUE/FALSE, NULL, etc.
8412 * doc/file-boilerplate.c: put include guards in here
8414 2002-11-21 Havoc Pennington <hp@redhat.com>
8416 * doc/file-boilerplate.c: include both AFL and GPL boilerplate.
8418 * COPYING: include the GPL as well, and license code
8419 under both AFL and GPL.
8421 2002-11-21 Havoc Pennington <hp@redhat.com>
8423 * acconfig.h: get rid of this
8425 * autogen.sh (run_configure): add --no-configure option
8427 * configure.in: remove AC_ARG_PROGRAM to make
8428 autoconf complain less. add AC_PREREQ.
8429 add AC_DEFINE third arg.
8431 2002-11-21 Anders Carlsson <andersca@codefactory.se>
8434 Fix references so we can distcheck.
8436 2002-11-21 Havoc Pennington <hp@redhat.com>
8438 * Initial module creation