1 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
5 * src/expr.c (eval4): Detect overflow properly when multiplying
8 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
10 * NEWS: The 'expr' command now detects and reports integer overflow.
11 (It would be better to use extended precision instead, but that
13 * src/expr.c (integer_overflow): New function.
14 (eval4, eval3): Check for integer overflow.
16 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
18 Fix problems when building with Solaris/SVR4/etc. make, which uses a
19 different and somewhat bogus implementation of VPATH. In the
20 directory tests/misc, rename tests whose names might appear in the
21 Automake-generated rules. For example, we can't use a test named
22 'test', since Automake generates a rule that contains the text
23 "if test -f ./$$tst; ...", and this might expand to something like
24 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
25 which executes the 'test' script rather than the 'test' command.
26 * tests/misc/false-status: Renamed from tests/misc/false.
27 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
28 * tests/misc/sort-merge: Renamed from tests/misc/sort.
29 ($prog): Set to 'sort' rather than to $PROG.
30 * tests/misc/test-diag: Renamed from tests/misc/test.
31 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
32 in case Solaris make has prepended the directory.
33 (TESTS): Adjust to above renamings.
34 * tests/misc/expand: Don't assign to PROG; no longer needed
35 now that Makefile.am sets PROG to the basename.
36 * tests/misc/fold: Likewise.
38 2006-06-03 Jim Meyering <jim@meyering.net>
40 Make `cp --link --no-dereference' work also on systems where the
41 link system call cannot create a hard link to a symbolic link.
42 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
43 the link syscall on a symlink when it would do the wrong thing.
44 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
45 * tests/cp/link-no-deref: New file/test for the above.
46 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
47 * NEWS: Mention the change (doesn't affect Linux).
49 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
51 Fix some porting problems in the test cases reported by
52 Ralf Wildenhues for HP-UX 11.23 in:
53 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
54 * tests/help-version: Don't assume that \< \> works in sed.
55 * tests/misc/close-stdout: Don't assume that >&- works.
57 * tests/touch/no-create-missing: Don't assume that >&- works.
59 2006-05-30 Jim Meyering <jim@meyering.net>
61 * src/ls.c (usage): Add `v' to the list of sorting-related options.
64 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
66 * tests/cp/fail-perm: source lang-default.
67 * tests/rm/inaccessible: Likewise.
69 2006-05-28 Jim Meyering <jim@meyering.net>
71 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
72 Recognize it, too. Reported by Ralf Wildenhues, in
73 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
75 2006-05-27 Jim Meyering <jim@meyering.net>
77 * src/chgrp.c: Support new options: --preserve-root and
78 --no-preserve-root. Somehow this program was skipped when those
79 options were added to chown, chmod, and rm. Reported by
80 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
83 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
85 * NEWS: Remove mention of --seed. We'll replace it with something
86 better, and don't want to indicate that it is supported.
87 * src/sort.c (usage): Likewise.
89 2006-05-20 Jim Meyering <jim@meyering.net>
91 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
93 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
94 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
95 FTS_COMFOLLOW. Spotted by Justin Pryzby.
97 * gnupload: Merge changes from automake, retaining the ""--to...
98 kludge to placate overzealous `make distcheck' check.
100 2006-05-19 Jim Meyering <jim@meyering.net>
102 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
103 FTS_TIGHT_CYCLE_CHECK directory traversal option.
104 Reported by Justin Pryzby in http://bugs.debian.org/367691
106 2006-05-15 Jim Meyering <jim@meyering.net>
108 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
111 2006-05-13 Jim Meyering <jim@meyering.net>
113 * tests/mv/no-target-dir: Test two more cases.
115 2006-05-11 Jim Meyering <jim@meyering.net>
117 mv -T DIR EMPTY_DIR no longer fails unconditionally
118 * src/copy.c (copy_internal): Don't manually prohibit a move where
119 the destination is an existing directory. Sometimes doing that is
120 valid. Let the rename system call enforce the rules. That is
121 allowed only when the source is a directory and the destination
122 directory (to be replaced) is empty. Reported by Eric Blake.
123 * tests/mv/no-target-dir: New file/test for this.
124 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
125 * NEWS: Mention this.
127 * tests/mv/atomic: New file/test for yesterday's fix.
128 * tests/mv/Makefile.am (TESTS): Add atomic.
130 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
132 2006-05-10 Jim Meyering <jim@meyering.net>
134 * src/copy.c (copy_internal): Don't explicitly unlink the destination
135 when moving a symlink into the place of an existing non-directory.
136 Reported by Joshua Hudson.
137 * NEWS: mention this.
139 2006-05-07 Jim Meyering <jim@meyering.net>
141 * Makefile.maint (patch-check): Fail if patch generates any output,
142 even merely for changed offsets.
144 * src/c99-to-c89.diff: Adjust to reflect new offsets.
146 * NEWS: Mention changes affecting df, pwd, shred.
148 2006-05-06 Jim Meyering <jim@meyering.net>
150 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
151 system condition where dirent.d_ino != stat.st_ino.
152 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
154 2006-05-06 Eric Blake <ebb9@byu.net>
156 * tests/ls/inode: Expand to test inode from readdir case.
157 * tests/ls/follow-slink: Expand to test broken links encountered
158 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
160 2006-05-06 Eric Blake <ebb9@byu.net>
162 * tests/mv/leak-fd: Work even on case-insensitive file system.
164 2006-05-04 Jim Meyering <jim@meyering.net>
166 * NEWS: Mention the 2006-03-19 pwd-related change that makes
167 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
169 2006-05-03 Jim Meyering <jim@meyering.net>
171 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
172 Use better macro parameter names: s/basename/key_name/,
173 s/basefunc/key_cmp_func. Fix typo in comment.
175 2006-04-29 Eric Blake <ebb9@byu.net>
177 * src/ls.c (main): On systems with d_type, directories_first only
178 implies format_needs_type, not format_needs_stat.
180 2006-05-03 Jim Meyering <jim@meyering.net>
182 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
183 after comma in arg list, from Eric Blake.
185 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
187 * tests/misc/date (relative-3): New test, derived from a bug
188 report by John Thomas McDole.
190 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
192 New option for ls: --group-directories-first.
193 It makes ls list directories before files.
194 * NEWS [New features]: Mention it.
195 * src/ls.c (sort_type): Rearrange to use as an array index when
196 choosing sort function; added new sort_numtypes member for
198 (time_type): Add new time_numtypes member for compile-time check.
199 (directories_first): New global variable.
200 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
201 (long_options): Add --directories-first.
202 (main): Support new option.
203 (is_directory): New function.
204 (extract_dirs_from_files): Use it.
205 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
206 (LIST_SORTFUNCTION_VARIANTS): New macros.
207 (sort_functions): New global variable.
208 (sort_files): Use it.
209 (usage): Document new option.
211 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
213 * src/shred.c (fillrand): The assertion was way too weak, due to
214 what must be a typo. Strengthen it to its intended value.
215 (dopass): Don't use alloca; it's not worth the aggravation here,
216 since it's used only to get a page-aligned buffer, and page
217 alignment doesn't buy us much here. I'm suspicious that alloca
218 causes problems on some hosts, due to a recent bug report by Adam
219 Waltman: http://bugs.gentoo.org/130246.
221 2006-04-18 Jim Meyering <jim@meyering.net>
223 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
224 sha384sum, sha512sum.
226 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
228 * src/chmod.c (describe_change): Adjust to filemode changes.
229 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
230 (print_long_format): Use (new) filemodestring rather than
231 (old) mode_string, so that we get more file types right, at least
232 in theory. Adjust to filemode changes.
233 * src/stat.c (human_access): Likewise.
235 2006-04-18 Jim Meyering <jim@meyering.net>
237 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
238 ignore file. This has never been enabled. Reported by Eric Blake.
240 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
242 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
243 bug in Interix. Just call symlink or link directly. All uses changed.
244 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
245 * src/stat.c (USE_STATVFS): New macro.
246 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
247 (NAMEMAX_FORMAT): define a bit more clearly, now that the
248 statvfs-using code is a bit more regular.
249 * src/system.h (sync) [!HAVE_SYNC]: New macro.
251 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
253 * NEWS: csplit, nl, expr now conform to POSIX better, and are
254 more-compatible with traditional Unix, with respect to regular
256 * src/csplit.c (extract_regexp): Set re_syntax_options to a
257 value that is compatible with what POSIX requires.
258 * src/nl.c (build_type_arg): Likewise.
259 * src/expr.c (docolon): Likewise. Also, don't let anchors match
260 newline; this fixes an incompatibility with tradition and with POSIX.
261 Don't warn about leading ^. POSIX says it is unspecified whether
262 ^ is a special character, which means that implementations can
263 either treat it as special or not, but either way a warning is not
264 allowed (unless the regexp is otherwise invalid). Instead, anchor
265 the expression but treat ^ as an anchor; this is the traditional
266 behavior (e.g., Solaris 10).
267 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
268 and the like as invalid expressions (exit status 2), not as
269 failure of 'expr' (exit status 3). This is more consistent with
271 * tests/expr/basic (fail-a): Adjust exit status to match new expr
272 behavior, for status 2 versus 3.
274 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
275 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
276 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
277 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
278 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
279 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
280 (bre61, bre62): New tests.
281 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
285 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
286 "if !". Do not assume that 'sed' can handle long, newline-free input.
287 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
289 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
291 Adjust to new regex.h API (with new fastmap type), and clean
292 up the regex storage allocation a bit.
294 * src/csplit.c (struct control): Put re_compiled member at the
295 end, since it's large. Change regexpr member from char * to bool;
296 all uses changed. Add new member fastmap.
297 (extract_regexp): regexp arg is now char const *, not char *.
298 Don't bother duplicating the regular expression; it's not needed.
299 Set fastmap from new fastmap member. Don't bother allocating
300 a buffer, as the regexp code does a better job than we do.
301 * src/expr.c (docolon): Allocate and use a fastmap.
302 Don't bother allocating a buffer.
303 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
305 (build_type_arg): New fastmap arg. All uses changed.
306 Don't bother allocating a buffer, but set a fastmap.
307 * src/ptx.c (context_regex_string, word_regex_string): Remove.
308 (context_regex, word_regex): New vars, replacing the above.
310 (struct regex_data): New type.
311 (compile_regex): Renamed from alloc_and_compile_regex, since
312 we no longer allocate storage. Arg is now a struct regex_data *,
313 not a const char *. All uses changed. Don't allocate the fastmap;
314 instead, take it from the caller. Don't convert size_t to int,
315 to avoid arithmetic overflow problems. Don't bother freeing
316 storage afterwards; it's not worth the aggravation.
317 * src/tac.c (compiled_separator_fastmap): New ver.
318 (main): Use it. Don't bother allocating a buffer.
320 2006-03-30 Jim Meyering <jim@meyering.net>
322 * src/dd.c (iwrite): Remove assignment without effect.
323 Reported by Felix Rauch Valenti.
325 2006-03-22 Eric Blake <ebb9@byu.net>
327 * src/ptx.c (usage): Remove mention of --copyright/-C.
328 (main): Alias --copyright to --version plus a deprecation warning.
329 * NEWS: Mention this.
331 2006-03-27 Jim Meyering <jim@meyering.net>
333 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
334 use of strtod. Tiny patch from Nickolai Zeldovich.
336 2006-03-11 Eric Blake <ebb9@byu.net>
338 * tests/misc/dirname: New file.
339 * tests/basename/Makefile.am: Delete.
340 * tests/basename/basic: Move to...
341 * tests/misc/basename: ... this new file. Add some tests,
342 including fixed behavior for //.
343 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
344 * tests/Makefile.am (SUBDIRS): Remove basename.
345 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
347 Improvements to dirname/basename handling on platforms like
348 cygwin with distinct // and with drive letters.
349 * NEWS: Document new behavior.
350 * src/basename.c (main): Don't strip suffix from file system
352 * src/cp.c (target_directory_operand): Use new last_component.
353 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
354 traversing the string.
355 * src/dircolors.c (guess_shell_syntax): Use new last_component.
356 * src/install.c (target_directory_operand, install_file_in_dir):
358 * src/ln.c (target_directory_operand, main): Likewise.
359 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
360 * src/mv.c (target_directory_operand, movefile): Likewise.
361 * src/remove.c (rm_1): Likewise.
362 * src/shred.c (wipename): Likewise.
363 * src/split.c (next_file_name): Likewise.
364 * src/su.c (log_su, run_shell): Likewise.
366 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
368 * NEWS: nohup diagnostics are now more precise, and nohup now
369 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
370 * src/nohup.c (main): Implement this.
371 * tests/misc/nohup: Test the new behavior.
373 2006-03-12 Jim Meyering <jim@meyering.net>
375 * src/copy.c (set_author): Rename function, from preserve_author.
377 * src/remove.c (AD_pop_and_chdir): Use new macro,
378 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
380 * src/system.h (SAME_INODE): Remove definition.
381 Include "same-inode.h", instead.
383 2006-03-11 Eric Blake <ebb9@byu.net>
385 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
387 2006-03-10 Jim Meyering <jim@meyering.net>
389 Fix a bug whereby a user with write access to a directory being removed
390 could cause the removal of that directory to fail with an erroneous
391 diagnostic about a directory cycle. Reported by Vineet Chadha.
393 * NEWS: Mention this.
394 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
395 leave (and try to rmdir) is the one whose dev_ino is being used to
396 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
398 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
400 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
401 * src/dd.c (set_fd_flags): Handle file-creation flags on file
402 descriptors, rather than ignoring them.
403 * tests/dd/misc: Add test cases for append, nofollow, directory,
404 and nolinks flags. Simplify redirection to /dev/null in some cases.
406 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
407 noatime test never tested anything.
409 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
411 * src/dd.c (flags, usage): New flags directory, nolinks.
412 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
414 * src/ls.c (usage): Mention that -f disables --color.
415 Problem reported by Niels Möller.
417 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
419 * man/*.x: Add references to syscalls from utilities of the same name.
421 2006-03-05 Jim Meyering <jim@meyering.net>
423 * tests/help-version: Set SHELL, if not already set, in order to
424 avoid failure when `make check' is run through debuild; dircolors
425 would fail due to lack of $SHELL. Reported by Sven Joachim.
427 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
428 * src/base64.c (wrap_write, do_encode, main): Change type of
429 parameters and locals, wrap_column, form size_t to uintmax_t.
430 (main): Adjust to use xstrtoumax, accordingly.
432 2006-03-03 Jim Meyering <jim@meyering.net>
434 Don't fail when run from an environment with SHELL not a Bourne
435 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
436 * tests/dircolors/simple: Invoke each non-failing test with -b.
437 Reported by Michael Stone.
439 2006-02-27 Jim Meyering <jim@meyering.net>
441 * tests/misc/base64: Derive --decode-using tests from the
444 * tests/misc/base64: Factor out a long constant string.
445 Split lines to stay within 80 columns.
447 * tests/misc/Makefile.am (TESTS): Add base64.
448 * tests/misc/base64: Test base64. From Simon Josefsson.
450 * src/base64.c (do_decode): Use correct type for parameter,
451 ignore_garbage: s/size_t/bool/.
453 * src/base64.c: Don't include .h files already included by system.h:
454 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
455 Include "system.h" before the other lib/*.h header files.
456 Include <sys/types.h> before "system.h".
457 (wrap_write): Remove declaration of unused local, initial_column.
458 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
460 * README: Add base64 to the list.
462 2006-02-17 Simon Josefsson <jas@extundo.com>
465 * AUTHORS: Mention base64.
467 * man/Makefile.am: Build base64.1.
468 * man/base64.x: New file.
469 * src/Makefile.am (bin_PROGRAMS): Add base64.
470 * src/base64.c: New file.
472 2006-02-25 Eric Blake <ebb9@byu.net>
474 In ls, avoid calling stat for --inode (-i), when possible.
475 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
476 * src/system.h: ... here, for use in ...
477 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
479 (gobble_file): Add inode argument.
480 (print_dir): Pass inode if available.
481 (usage): Remove inaccuracy.
483 2006-02-23 Jim Meyering <jim@meyering.net>
485 * TODO: Update/correct some obsolete entries.
487 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
489 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
490 * src/join.c (usage): Likewise.
491 Documentation problem reported by Philip Kensche.
493 2006-02-20 Eric Blake <ebb9@byu.net>
495 * man/rm.x: Update documentation to match previous patch.
497 2006-02-18 Eric Blake <ebb9@byu.net>
499 New option for rm: --interactive=once (-I).
500 * NEWS: Document it, along with change to rm --interactive.
501 * TODO: Remove entry for implementing rm -I
502 * src/rm.c (INTERACTIVE_OPTION): New enum value.
503 (interactive_type): New enum.
504 (long_opts): Let interactive take an optional argument.
505 (interactive_args, interactive_types): New option arguments.
506 (usage): Document -I, --interactive=WHEN. Use program_name
507 instead of a basename.
508 (main): New -I option, new behavior to --interactive.
509 * tests/rm/interactive-once: New tests.
510 * tests/rm/interactive-always: Ditto.
511 * tests/rm/Makefile.am (TESTS): Run them.
513 2006-02-18 Jim Meyering <jim@meyering.net>
515 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
516 expression match more of the target lines, e.g., those that start with
517 `-S,' (short option followed by a comma) or that include `=[...]'.
518 Patch by Nicolas François.
519 Fix the four offenders thus exposed:
520 * src/join.c (usage): Use two spaces (not one) to separate the
521 --first-only option string from its description, so help2man formats
522 the derived man page properly.
523 * src/pr.c (usage): Likewise.
524 * src/uniq.c (usage): Likewise.
525 * src/install.c (usage): Likewise.
527 2006-02-15 Jim Meyering <jim@meyering.net>
529 * Makefile.maint (alpha beta major): For `make major', ensure that the
530 version string is of the form N.N[.N]*, where N is one or more digits.
532 2006-02-14 Jim Meyering <jim@meyering.net>
534 * INSTALL: Update from gnulib.
536 2006-02-13 Jim Meyering <jim@meyering.net>
538 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
540 2006-02-12 Jim Meyering <jim@meyering.net>
542 * Makefile.maint (patch-check): New target.
543 (local-checks-available): Add to the list.
545 2006-02-11 Jim Meyering <jim@meyering.net>
547 * src/c99-to-c89.diff: New file.
548 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
550 * .x-po-check: New file, with exclusions so that `make distcheck'
552 * Makefile.am (EXTRA_DIST): Add .x-po-check.
554 rm -r must remove an empty directory, even if it is inaccessible.
555 * src/remove.c (close_preserve_errno): New function.
556 (fd_to_subdirp): Don't print a diagnostic in this function.
557 Do it from the callers instead, unless rmdir succeeds.
558 (remove_cwd_entries, remove_dir): Adjust callers.
559 * tests/rm/empty-inacc: New test for the above.
560 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
561 * NEWS: Mention this bug fix.
562 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
563 a tiny bit less precise: cannot remove `a/1': ... instead of
564 cannot open directory `a/1': ...
566 * Makefile.maint (syntax-check-rules): Automatically derive this
567 list of sc_-prefixed rule names.
569 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
571 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
572 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
573 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
574 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
575 go away? was that an accident?)
576 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
577 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
578 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
579 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
580 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
581 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
582 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
583 (author_mark_check, makefile_path_separator_check):
584 Output line numbers, to simplify navigation of Emacs *compilation*
586 (sc_prohibit_atoi_atof, sc_file_system):
587 Rework slightly so that Makefile.maint doesn't get reported as a
588 violation of its own syntax rules.
589 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
590 it at run-time (which didn't work with Bison). Fix a makefile typo,
591 caught by Makefile.maint itself: spaces where a tab should be.
592 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
593 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
594 Ignore djgpp and man subdirectories, to avoid false matches with
595 Bison and coreutils, respectively. Use sort -u to remove the
596 resulting duplicates.
597 * gnupload: Rework slightly to avoid bogus warning from
598 sc_two_space_separator_in_usage.
600 2006-02-10 Jim Meyering <jim@meyering.net>
602 Use gzip's --rsyncable option only if it's available.
603 * Makefile.maint (gzip_rsyncable): New variable.
606 2006-02-08 Jim Meyering <jim@meyering.net>
608 * Makefile.maint (local-checks-available): Define in terms of
609 the expansion, $(syntax-check-rules), rather than the single,
610 top-level target `syntax-check', so that it's easier to exclude
611 individual rules (via $(local-checks-to-skip)).
612 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
614 2006-02-07 Jim Meyering <jim@meyering.net>
616 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
617 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
619 * tests/help-version (expected_failure_status_vdir):
620 Redirect an expected disk-full diagnostic to /dev/null.
622 2006-02-06 Jim Meyering <jim@meyering.net>
624 * src/unexpand.c (usage): Use two spaces (not one) to separate the
625 --first-only option string from its description, so help2man formats
626 the derived man page properly.
627 * src/rm.c (usage): Likewise for --no-preserve-root.
628 * src/chown.c (usage): Likewise.
629 * src/chgrp.c (usage): Likewise.
631 Add a rule to ensure that the above doesn't happen again.
632 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
633 (syntax-check-rules): Add it.
634 * .x-sc_two_space_separator_in_usage: New empty file.
635 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
637 2006-02-06 Jim Meyering <jim@meyering.net>
639 * src/cp.c (usage): Use two spaces (not one) to separate each
640 option string from its description, so help2man formats the
641 derived man page properly.
642 * src/mv.c (usage): Likewise.
643 Patch from Nicolas François in http://bugs.debian.org/351601.
645 2006-02-04 Jim Meyering <jim@meyering.net>
647 * src/copy.c (copy_internal): cp -RL would fail when encountering
648 the same directory more than once in the hierarchy beneath a single
649 command-line argument. That is legitimate, e.g. when there are
650 two or more symbolic links, each pointing to some directory that
651 would not otherwise be copied. Reported by Christophe LYON.
652 * tests/cp/cp-deref: New file. Test for today's fix.
653 * tests/cp/Makefile.am (TESTS): Add cp-deref.
654 * NEWS: Document this.
656 2006-02-03 Jim Meyering <jim@meyering.net>
658 * configure.ac: Require automake-1.9.6, not 1.8.3.
660 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
662 * src/od.c (usage): Mention that -t a ignores high order bit.
663 Documentation problem reported by Ed Avis.
665 2006-02-01 Jim Meyering <jim@meyering.net>
667 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
669 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
671 * src/head.c (main): Use a better diagnostic when someone uses a
672 trailing numeric option in an invalid way. Problem reported by
674 * src/tail.c (parse_options): Likewise.
676 2006-01-30 Jim Meyering <jim@meyering.net>
678 * man/wc.x: Include `count' keyword in man page synopsis,
679 per suggestion from http://bugs.debian.org/181585.
681 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
683 * src/df.c (show_dev): If the file system claims to have
684 more available than total blocks, report the number of used
685 blocks as being total - available (a negative number) rather
686 than as garbage. Problem reported by Toralf Foerster.
688 2006-01-24 Jim Meyering <jim@meyering.net>
690 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
691 to put a regular file in O_NONBLOCK mode fails with EPERM.
692 That happens on Linux (up to 2.6.15) when using tail -f on a file with
693 the append-only attribute. Reported by Dean Gaudet. For details,
694 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
695 * NEWS: Mention this fix.
696 * tests/tail-2/append-only: New file. Test for the above.
697 * tests/tail-2/Makefile.am (TESTS): Add append-only.
698 * tests/Makefile.am (check-root): Add tail-2/append-only
700 2006-01-21 Jim Meyering <jim@meyering.net>
702 * NEWS: Mention fts-related improvements and bug fixes.
704 2006-01-19 Jim Meyering <jim@meyering.net>
706 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
707 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
709 2006-01-18 Jim Meyering <jim@meyering.net>
711 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
713 2006-01-17 Jim Meyering <jim@meyering.net>
715 Now that fts no longer changes the current working directory, adjust
716 its clients accordingly -- note that du.c uses fts but doesn't need
717 any adjustment, since it doesn't operate on the actual files,
718 but rather just uses the stat buffers provided by fts.
720 * src/chown-core.c: Include "openat.h".
721 Don't include "lchown.h".
722 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
723 calling openat, lchownat, chownat, rather than open, lchown, chown.
725 * src/chmod.c: Include "openat.h".
726 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
728 * tests/du/long-from-unreadable: New test, to exercise one small
731 2006-01-13 Jim Meyering <jim@meyering.net>
733 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
734 addition of new directories under tests/.
736 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
739 2006-01-12 Jim Meyering <jim@meyering.net>
741 * tests/du/long-sloop: Adjust not to hard-code the expected
742 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
743 from that of GNU libc. Reported by Paul Eggert.
745 * tests/du/long-sloop: Create file at end of symlink chain.
747 * tests/misc/test: New file, with a test for one of the
748 bugs fixed by yesterday's test.c changes.
749 * tests/misc/Makefile.am (TESTS): Add test.
751 2006-01-11 Jim Meyering <jim@meyering.net>
753 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
754 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
755 a very long sequence of symbolic links (not necessarily a loop).
756 * tests/du/Makefile.am (TESTS): Add long-sloop.
758 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
760 * src/test.c (test_syntax_error): Append a newline. All callers
761 changed, except for the ones that didn't already append a newline.
762 Bug reported by Eric Blake.
764 2006-01-11 Jim Meyering <jim@meyering.net>
766 * src/system.h (X2NREALLOC): Now that verify_true is no longer
767 void, cast its result to void, to avoid gcc's warning that
768 ``left-hand operand of comma expression has no effect''.
769 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
771 2006-01-10 Jim Meyering <jim@meyering.net>
773 * tests/chmod/no-x: Add a test for today's fts.c fix.
775 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
777 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
778 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
780 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
782 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
783 Use verify_true instead of verify_expr, to sync with gnulib.
785 2006-01-08 Jim Meyering <jim@meyering.net>
787 * src/date.c (usage): Adjust the formatting of the entries for
788 %::z and %:::z (separate with two spaces, not one) so that help2man
789 formats them properly. Reported by Philip Rowlands.
791 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
793 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
795 2006-01-06 Jim Meyering <jim@meyering.net>
797 * Makefile.maint (copyright-check): Use date +%Y in place of
800 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
801 First off, the attribute should have been `volatile' (not static)
802 to avoid longjmp-related risk of clobber. Secondly, now there is
803 no longer any risk of a local variable being clobbered, so there's
804 no need for any attribute at all.
806 2006-01-05 Jim Meyering <jim@meyering.net>
808 * src/remove.c: Give a few functions the inline attribute.
809 (AD_pop_and_chdir): Use gotos to avoid some duplication.
810 (AD_push): Rewrite an assertion so that the entire computation
811 goes away when assertions are turned off.
813 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
814 It's already defined in "system.h".
815 * Makefile.maint: Add a FIXME comment.
817 2006-01-04 Jim Meyering <jim@meyering.net>
819 * ChangeLog: Remove entries from 2005-10-22 and earlier.
820 * ChangeLog-2005: New file, for entries up to version 5.92.
822 2006-01-03 Jim Meyering <jim@meyering.net>
824 * tests/du/no-x: Also allow a slightly different diagnostic -- the
825 one you get when using openat-enabled fts.c and du (coming soon).
826 * tests/chmod/no-x: Likewise.
827 * tests/chgrp/no-x: Likewise.
829 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
831 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
833 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
834 (restricted_chown): Return it, if the file cannot be accessed due
835 to EPERM, or if no uid or gid are required, or if the file is
836 neither a directory nor a regular file. Rewrite to avoid gotos.
837 (change_file_owner): Handle RC_do_ordinary_chown case.
838 Rewrite to avoid gotos.
839 * tests/chgrp/basic: Make sure we can change the group of
842 * src/date.c (usage): Explain %g, %G, and %V a bit better.
844 2006-01-02 Jim Meyering <jim@meyering.net>
846 * src/copy.c (set_owner): Correct a comment.
848 * src/tail.c (parse_options): Change warning to say that --retry
849 is useful `mainly' (not `only') when following by name.
850 Reported here: http://bugs.debian.org/273781
852 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
854 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
855 * src/copy.c: Include lchmod.h.
856 (copy_internal): Use lchmod rather than chmod.
857 * src/cp.c: Include lchmod.h.
858 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
859 * src/mkdir.c: Include lchmod.h.
860 (usage): Clarify -m's operation.
861 (main): Use lchmod rather than chmod. Don't use lchmod unless the
862 new mode contains bits outside the 777 range.
863 * src/mkfifo.c (usage): Clarify -m's operation.
864 (main): If -m is given, don't invoke chmod; use umask 0 instead.
865 Report an error if -m asks for bits outside the 777 range.
866 * src/mknod.c (usage, main): Likewise.
868 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
870 2005-12-27 Jim Meyering <jim@meyering.net>
872 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
873 (sc_prohibit_assert_without_use): New rule.
874 (syntax-check-rules): Add it to the list.
875 * .x-sc_prohibit_assert_without_use: New empty file.
876 * Makefile.am (EXTRA_DIST): Add it.
878 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
880 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
881 Don't include <assert.h>; it wasn't used.
883 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
885 * src/chown-core.c (restricted_chown):
886 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
887 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
888 | O_NOFOLLOW too, for consistency with other dir-openers.
889 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
890 (is_empty_dir): Likewise.
891 * src/shred.c (wipename): Likewise. Don't bother trying to open
892 dir for writing, since POSIX prohibits it.
894 2005-12-22 Jim Meyering <jim@meyering.net>
896 * tests/help-version: Redirect stderr to /dev/full, to suppress
897 write error diagnostic.
899 2005-12-19 Jim Meyering <jim@meyering.net>
901 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
902 Avoid a minor race condition when `-m MODE' is specified, by using
903 open, fchown, and close rather than just chown. To do that reliably --
904 even with an overly restrictive umask -- ensure that each mkdir,
905 mknod and mkfifo call uses a mode including at least owner-read access.
906 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
907 the subsequent chown (or equivalent open,fchown,close) fails.
908 * tests/misc/mknod: New tests.
909 * tests/misc/Makefile.am (TESTS): Add mknod.
911 2005-12-17 Jim Meyering <jim@meyering.net>
913 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
914 e.g., on a named pipe.
915 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
916 place of all uses, since it is guaranteed (system.h) to be defined.
918 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
920 Add POSIX ACL support
921 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
922 is no requirement for ACL support; particularly, it does not exist
923 on systems that have POSIX ACLs.
924 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
925 * src/cp.c (umask_kill): With default acls, the umask is not to be
926 applied. Remove umask_kill, don't change the process umask, and let
927 the kernel apply the umask where appropriate.
928 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
929 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
931 (copy_reg, copy_internal): Use copy_acl and set_acl
932 instead of fchown/chown. Fix the logic for POSIX ACLs.
933 (chown_succeded): Remove; we now always copy acls and
934 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
935 did a chown before or not.
936 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
937 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
938 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
939 to link with it via $(LIB_ACL), for the utilities that need it.
941 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
943 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
944 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
945 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
946 value is now signified by whether cwd_errno is null.
947 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
948 pointer-to-bool to pointer-to-errno-value. All callers changed.
949 (rm_1): Don't bother setting a local cwd failure flag and then
950 ORing it into the caller's. Just set the caller's.
951 (rm): Use cwd failure errno value to print a slightly-better
954 2005-12-15 Jim Meyering <jim@meyering.net>
956 * src/stat.c (print_it): Properly handle a backslash at the
957 end of a --printf format string. Reported by Paul Eggert.
958 * tests/misc/stat-printf (end-bs): Add a test for the above.
960 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
962 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
963 Don't assume /etc/passwd contains user names; use 'id' instead.
965 2005-12-15 Jim Meyering <jim@meyering.net>
967 stat: revert behavior of --format=FMT (-c)
968 stat: add new option: --printf=FMT
969 * NEWS: Mention this.
970 * src/stat.c (isodigit, octtobin, hextobin): Define.
971 (PRINTF_OPTION): Define.
972 (interpret_backslash_escapes, trailing_delim): New globals.
973 (usage): Document them. Alphabetize on long option names.
974 (print_esc_char): New function.
975 (print_it): Rewrite, in order to handle backslash escapes.
976 (main): Handle new option. Set globals for --format, too.
978 * tests/misc/stat-printf: Test --printf and --format.
979 * tests/misc/Makefile.am (TESTS): Add stat-printf.
981 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
983 * NEWS: sort now reports incompatible options.
984 * src/sort.c (incompatible_options, check_ordering_compatibility):
986 (main): Use them. Don't bother with a usage message for
987 "sort -c a b", for consistency with other error diagnostics.
988 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
991 * src/cat.c (main): Undo previous change. close_stdout already
992 does the check, so the previous change wasn't necessary.
994 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
996 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
998 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1000 Install a more-conservative approach for sort -R. It's the
1001 same basic idea as the existing code, except it uses the full ISAAC
1002 approach (called the "more kosher" approach in the existing comments).
1003 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1004 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1005 better to be conservative here at first, and review any performance
1006 improvements carefully.
1007 * .x-sc_require_config_h: Add src/rand-isaac.c.
1008 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1009 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1010 (shred_SOURCES, sort_SOURCES): Remove.
1011 (EXTRA_DIST): Add rand-isaac.c.
1012 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1013 changing it to allow for varying numbers of words in the state.
1014 Alter so that we include rand-isaac.c directly rather than
1015 compiling it and linking to it. Don't include config.h or
1016 system.h; that's the includer's responsibility.
1017 Omit functions that are specific to shred.
1018 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1019 (isaac_step, struct irand_state):
1020 Resurrect these, with the same defns that used to be in shred.c.
1021 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1022 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1024 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1025 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1026 (irand_init, irand32, irand_mod):
1027 Number of words is constant again.
1028 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1029 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1030 * src/sort.c: Likewise.
1031 * src/shred.c (fillrand, dopass, main): Undo previous change.
1032 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1034 * src/sort.c: Don't include md5.h; it wasn't needed.
1035 (struct keyfield): Rename random_hash to random, for consistency
1036 with the other member names. All uses changed.
1037 (usage): Tweak wording to mention STRING for --seed option.
1038 (short_options): Rorder for consistency with other programs.
1039 (rand_state): Now a struct, not a pointer to one. All uses changed.
1040 (HASH_WORDS, HASH_SIZE): Remove.
1041 (get_hash): Remove comments around resbuf size, since we can assume C89.
1042 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1043 (keycompare): Adjust to the new get_hash.
1045 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1046 (main): Don't set need_random simply because gkey has it set; that
1047 doesn't necessarily mean we'll need random numbers.
1048 Redo seeding to match new get_hash approach.
1050 2005-12-10 Jim Meyering <jim@meyering.net>
1052 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1054 Avoid shred segfault on 64-bit systems.
1055 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1056 local of type uint32_t. Make the local an `int' instead.
1058 * NEWS: Mention sort's new options.
1060 * src/rand-isaac.c (isaac_mix): Declare to be static.
1061 Mark all other functions as `extern' so the tight-scope
1062 part of `make distcheck' passes once again.
1063 * src/rand-isaac.h (isaac_mix): Remove declaration.
1065 * src/sort.c (get_hash): Change position of `*' in parameter
1066 type to conform with convention.
1067 (main): Split a long line so it fits in 80 columns.
1068 (keycompare): Remove stray SPACE before TAB that was
1069 causing `make distcheck' to fail.
1071 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1073 * tests/misc/sort-rand: New file: basic tests for the new options.
1074 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1076 2005-12-10 Frederik Eaton <frederik@ofb.net>
1078 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1079 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1080 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1081 Make state size runtime-configurable.
1082 (isaac_new, isaac_copy): New functions.
1083 * src/rand-isaac.h: New file.
1084 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1085 (fillrand, main): Adjust to the fact that the state size is now
1086 runtime-configurable.
1087 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1088 (usage): Add options --random-sort and --seed to implement a random
1090 Include md5.h and rand-isaac.h.
1091 (get_hash): New function.
1092 (rand_state): New var.
1093 (HASH_WORDS, HASH_SIZE): New macros.
1095 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1097 * tests/dd/misc: Add test for dd iflags=noatime.
1099 2005-12-09 Jim Meyering <jim@meyering.net>
1101 * src/sort.c (usage): Mention white space vs -b and -t options.
1104 2005-12-09 Eric Blake <ebb9@byu.net>
1106 * src/test.c (main): Fix misleading comment.
1108 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1110 * NEWS: Mention dd's new noatime flag.
1111 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1112 * src/dd.c (flags, usage): Add support for noatime flag.
1114 2005-12-07 Jim Meyering <jim@meyering.net>
1116 Distribute the cvsu script, used only by `make syntax-check'.
1117 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1118 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1119 distribute a copy of this script.
1120 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1122 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1123 to create a temporary directory on another partition.
1124 From Andreas Gruenbacher.
1126 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1128 * man/basename.x: Cross-reference to dirname and readlink.
1129 * man/dirname.x: Cross-reference to basename and readlink.
1131 2005-12-05 Andreas Gruenbacher
1133 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1134 (set_owner, preserve_author): New functions, factored out of copy_reg.
1135 (copy_reg): Use them.
1136 (copy_internal): Use them here, too.
1138 2005-12-04 Jim Meyering <jim@meyering.net>
1140 * src/sleep.c (usage): Say what happens with two or more arguments.
1141 Suggested by Justin Pryzby.
1143 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1146 2005-12-03 Jim Meyering <jim@meyering.net>
1148 * src/rm.c (long_opts): Change the name of each undocumented, for-
1149 testing-only option to start with `-', so that it cannot render
1150 ambiguous any prefix it happens to share with some other option name.
1151 Problem reported by Eric Blake.
1152 * src/head.c (long_options): Likewise.
1153 * src/tail.c (long_options): Likewise.
1155 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1156 testing-only --presume* options to start with `---'.
1157 * tests/rm/dangling-symlink: Likewise.
1158 * tests/rm/dir-no-w: Likewise.
1159 * tests/rm/isatty: Likewise.
1161 2005-11-30 Jim Meyering <jim@meyering.net>
1163 * Makefile.maint: Add a comment about cvsu.
1165 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1167 * NEWS: df updates for "none", "proc", inaccessible file systems.
1168 * src/df.c (show_point): Ignore inaccessible file systems.
1169 (usage): -a includes dummy file systems, not size-0 file systems.
1171 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1172 to avoid collision with POSIX name space. All uses changed.
1174 2005-11-24 Jim Meyering <jim@meyering.net>
1176 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1177 * tests/acl: Add `$0: ' prefix to diagnostics.
1179 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1181 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1183 * src/copy.c: Improve performance a bit by optimizing away
1184 unnecessary system calls and going to a block size of at least
1185 8192 (on normal hosts, anyway). This improved performance 5% on my
1186 Debian stable host (2.4.27 kernel, x86, copying from root
1187 ext3 file system to itself).
1188 Include "buffer-lcm.h".
1189 (copy_reg): Omit last argument. All callers changed.
1190 Use xmalloc to allocate rather than trusting alloca
1191 (which is unwise with large block sizes).
1192 Declare locals more locally, if possible.
1193 Use uintptr_t words instead of int words, for a bit more speed
1194 when looking for null blocks on 64-bit hosts.
1195 Optimize away reads of zero bytes on regular files.
1196 In the typical case, insist on 8 KiB buffers, at least.
1197 Avoid unnecessary extra call to fstat when checking for sparse files.
1198 Avoid now-unnecessary cast to off_t, and "0L".
1199 Avoid unnecessary test of *new_dst when checking for same owner
1202 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1204 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1206 2005-11-22 Jim Meyering <jim@meyering.net>
1208 * src/remove.c (AD_push): Remove debugging cruft.
1210 * tests/rm/unread2 (rm): Change expected diagnostic,
1211 `cannot open directory' to `cannot remove', to align with
1213 * tests/rm/rm2: Ensure that rm now continues removing entries
1214 even after certain types of failure.
1216 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1217 that provide openat (Solaris), and on systems like Linux+procfs
1218 where our openat emulation code is reentrant. This also fixes a
1219 few low-probability leaks and eliminates some code that could,
1220 in very unusual circumstances, cause rm() (via a callee) to exit.
1221 * NEWS: Mention this.
1223 * configure.ac: Put copyright dates all on one line so the
1224 emacs function that updates them works properly.
1226 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1228 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1229 Problem reported by Eric Blake.
1230 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1231 we get a standard-conforming compiler. This relies on the new
1232 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1233 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1234 m4/c.m4 can go away with Autoconf 2.60 comes out.
1236 2005-11-17 Jim Meyering <jim@meyering.net>
1238 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1239 (AD_mark_current_as_unremovable): Likewise, but for a local.
1242 * tests/mv/acl: Let traps handle removing temporary directories.
1244 Expect acl-related tests to fail, until the corresponding
1245 patches are committed.
1246 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1247 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1249 ACL tests, from Andreas Gruenbacher.
1250 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1251 * tests/mv/Makefile.am (TESTS): Add acl.
1252 * tests/cp/Makefile.am (TESTS): Add acl.
1254 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1256 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1258 * NEWS: Improve quality of ln's diagnostics.
1259 * src/ln.c (do_link, usage): Likewise.
1260 (do_link): Don't use alloca on a buffer of unbounded size.
1262 2005-11-16 Jim Meyering <jim@meyering.net>
1264 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1265 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1266 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1267 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1268 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1270 2005-11-14 Jim Meyering <jim@meyering.net>
1272 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1274 2005-11-13 Jim Meyering <jim@meyering.net>
1276 * announce-gen: Accept new option, --gpg-key-id=ID and
1277 emit a blurb telling how to use the .sig files.
1278 * Makefile.cfg (gpg_key_ID): Define.
1279 * Makefile.maint (announcement): Use new option and key.
1281 Require that most .c files include <config.h>.
1282 * Makefile.maint (sc_require_config_h): New rule.
1283 (syntax-check-rules): Add it.
1284 * .x-sc_require_config_h: New file listing exceptions to the
1285 above rule. Some are legit, others are simply grandfathered in.
1286 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1288 2005-11-12 Jim Meyering <jim@meyering.net>
1290 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1292 2005-11-11 Jim Meyering <jim@meyering.net>
1294 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1295 Mention new readlink options in 5.3.0's `New features' section.
1296 Spotted by Thomas Hood.
1298 2005-11-08 Jim Meyering <jim@meyering.net>
1300 * NEWS: Merge in changes from b5_9x branch.
1302 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1304 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1305 like --time-style='posix-long-iso' if the locale settings are messed up.
1306 * src/ls.c (decode_switches): Implement this.
1308 2005-11-08 Jim Meyering <jim@meyering.net>
1310 * tests/du/2g: s/expensive/very expensive/ in a comment.
1313 2005-10-17 Eric Blake <ebb9@byu.net>
1315 * src/ls.c (usage): Fix descriptions of --sort, --time.
1316 Reported by Vitaly A. Ostanin.
1318 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1320 * src/ln.c: Include filenamecat.c.
1321 (FILE_BASENAME_CONCAT): Remove.
1322 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1323 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1324 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1327 2005-11-04 Jim Meyering <jim@meyering.net>
1329 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1330 on systems with stat.st_blocks of a signed 32-bit type.
1331 This bug causes trouble on some AIX 5.1 systems.
1332 Report and trivial patch from Paul Townsend:
1333 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1334 * NEWS: Mention this.
1336 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1337 * tests/du/Makefile.am (TESTS): Add it here.
1338 * tests/very-expensive: New file.
1339 * tests/Makefile.am (EXTRA_DIST): Add it here.
1340 * tests/cp/perm: Mark this test as `very-expensive', too.
1342 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1344 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1346 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1348 * src/rm.c (usage): Don't mention rm -d.
1350 2005-11-02 Jim Meyering <jim@meyering.net>
1352 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1353 From Andreas Schwab.
1355 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1356 `M+N records in/out' lines don't pollute `make check' output.
1358 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1359 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1360 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1361 to indicate that the input file should be piped into the command
1362 under test (via `cat FILE | $prog ...').
1364 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1365 (without -r) fails to remove a directory on a non-Linux system.
1366 This change affects only newer Solaris systems (with priv_*
1367 functions like priv_allocset). Reported by Keith Thompson.
1369 * tests/rm/dir-nonrecur: New file/test for the above fix.
1370 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1372 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1374 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1375 POSIX 1002.1-2001 requires.
1376 * src/tail.c (parse_obsolete_option): Implement this.
1377 Problem reported by Vincent Lefevre.
1378 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1379 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1380 (test_vector): Add special cases for _POSIX2_VERSION, and
1381 regularize the old ones a bit.
1382 * tests/touch/obsolescent: Add y2000 test.
1384 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1386 * src/dd.c (skip): Fix off-by-one error reported by
1387 Theodoros V. Kalamatianos.
1389 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1391 * tests/mkdir/p-3: Require that the test be run as non-root.
1392 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1394 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1396 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1397 boundary between DEST and SOURCE in the result.
1399 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1401 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1402 back to text, to sync with documentation and for backwards
1405 2005-10-25 Jim Meyering <jim@meyering.net>
1407 * tests/dircolors/simple (other-wr): Add an explicit test for
1408 the dircolors bug (NULL-dereference) fixed yesterday.
1410 2005-10-24 Jim Meyering <jim@meyering.net>
1412 * src/tac.c (tac_file): When determining whether a file is seekable,
1413 also test whether it is a tty. Using only the lseek-based test would
1414 give a false positive on Solaris. Reported by Peter Fales.
1416 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1418 * tests/install/d-slashdot: New test, for "install -d" failure.
1419 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1420 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1421 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1423 2005-10-24 Jim Meyering <jim@meyering.net>
1425 * src/dircolors.c (ls_codes): Add missing comma.
1426 Anonymous report and patch from
1427 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1429 * src/dircolors.c: Add compile-time assertion that the slack_codes
1430 and ls_codes arrays have the same number of elements. This would
1431 have prevented the above-fixed bug.
1433 * src/expand.c (parse_tab_stops): Add a comment to make this function
1434 identical to the one in unexpand.c.
1435 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1436 identical to the one in expand.c.
1438 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1440 2005-10-23 Jim Meyering <jim@meyering.net>
1442 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1443 a dangerous pointer-value-to-`unsigned' cast.
1444 * NEWS: mention the new sha* programs.
1445 * AUTHORS: Add new sha* programs.
1447 2005-08-28 David Madore <david.madore@ens.fr>
1449 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1450 * README: Add their names to the list.
1451 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1452 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1453 Rules for compiling sha-2 utilities
1454 (noinst_HEADERS): Remove checksum.h.
1455 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1457 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1458 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1459 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1460 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1461 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1462 sha384sum, sha512sum test scripts here rather that each in its
1465 2005-08-28 David Madore <david.madore@ens.fr>
1467 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1468 of the FIPS test vectors).
1470 2005-10-23 Jim Meyering <jim@meyering.net>
1472 * configure.ac: Use 6.0-cvs as the version string.
1473 * NEWS: Adjust accordingly.