1 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
5 * src/dd.c (flags, usage): New flags directory, nolinks.
6 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
8 * src/ls.c (usage): Mention that -f disables --color.
9 Problem reported by Niels Möller.
11 2006-03-05 Jim Meyering <jim@meyering.net>
13 * tests/help-version: Set SHELL, if not already set, in order to
14 avoid failure when `make check' is run through debuild; dircolors
15 would fail due to lack of $SHELL. Reported by Sven Joachim.
17 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
18 * src/base64.c (wrap_write, do_encode, main): Change type of
19 parameters and locals, wrap_column, form size_t to uintmax_t.
20 (main): Adjust to use xstrtoumax, accordingly.
22 2006-03-03 Jim Meyering <jim@meyering.net>
24 Don't fail when run from an environment with SHELL not a Bourne
25 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
26 * tests/dircolors/simple: Invoke each non-failing test with -b.
27 Reported by Michael Stone.
29 2006-02-27 Jim Meyering <jim@meyering.net>
31 * tests/misc/base64: Derive --decode-using tests from the
34 * tests/misc/base64: Factor out a long constant string.
35 Split lines to stay within 80 columns.
37 * tests/misc/Makefile.am (TESTS): Add base64.
38 * tests/misc/base64: Test base64. From Simon Josefsson.
40 * src/base64.c (do_decode): Use correct type for parameter,
41 ignore_garbage: s/size_t/bool/.
43 * src/base64.c: Don't include .h files already included by system.h:
44 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
45 Include "system.h" before the other lib/*.h header files.
46 Include <sys/types.h> before "system.h".
47 (wrap_write): Remove declaration of unused local, initial_column.
48 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
50 * README: Add base64 to the list.
52 2006-02-17 Simon Josefsson <jas@extundo.com>
55 * AUTHORS: Mention base64.
57 * man/Makefile.am: Build base64.1.
58 * man/base64.x: New file.
59 * src/Makefile.am (bin_PROGRAMS): Add base64.
60 * src/base64.c: New file.
62 2006-02-25 Eric Blake <ebb9@byu.net>
64 In ls, avoid calling stat for --inode (-i), when possible.
65 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
66 * src/system.h: ... here, for use in ...
67 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
69 (gobble_file): Add inode argument.
70 (print_dir): Pass inode if available.
71 (usage): Remove inaccuracy.
73 2006-02-23 Jim Meyering <jim@meyering.net>
75 * TODO: Update/correct some obsolete entries.
77 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
79 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
80 * src/join.c (usage): Likewise.
81 Documentation problem reported by Philip Kensche.
83 2006-02-20 Eric Blake <ebb9@byu.net>
85 * man/rm.x: Update documentation to match previous patch.
87 2006-02-18 Eric Blake <ebb9@byu.net>
89 New option for rm: --interactive=once (-I).
90 * NEWS: Document it, along with change to rm --interactive.
91 * TODO: Remove entry for implementing rm -I
92 * src/rm.c (INTERACTIVE_OPTION): New enum value.
93 (interactive_type): New enum.
94 (long_opts): Let interactive take an optional argument.
95 (interactive_args, interactive_types): New option arguments.
96 (usage): Document -I, --interactive=WHEN. Use program_name
97 instead of a basename.
98 (main): New -I option, new behavior to --interactive.
99 * tests/rm/interactive-once: New tests.
100 * tests/rm/interactive-always: Ditto.
101 * tests/rm/Makefile.am (TESTS): Run them.
103 2006-02-18 Jim Meyering <jim@meyering.net>
105 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
106 expression match more of the target lines, e.g., those that start with
107 `-S,' (short option followed by a comma) or that include `=[...]'.
108 Patch by Nicolas François.
109 Fix the four offenders thus exposed:
110 * src/join.c (usage): Use two spaces (not one) to separate the
111 --first-only option string from its description, so help2man formats
112 the derived man page properly.
113 * src/pr.c (usage): Likewise.
114 * src/uniq.c (usage): Likewise.
115 * src/install.c (usage): Likewise.
117 2006-02-15 Jim Meyering <jim@meyering.net>
119 * Makefile.maint (alpha beta major): For `make major', ensure that the
120 version string is of the form N.N[.N]*, where N is one or more digits.
122 2006-02-14 Jim Meyering <jim@meyering.net>
124 * INSTALL: Update from gnulib.
126 2006-02-13 Jim Meyering <jim@meyering.net>
128 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
130 2006-02-12 Jim Meyering <jim@meyering.net>
132 * Makefile.maint (patch-check): New target.
133 (local-checks-available): Add to the list.
135 2006-02-11 Jim Meyering <jim@meyering.net>
137 * src/c99-to-c89.diff: New file.
138 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
140 * .x-po-check: New file, with exclusions so that `make distcheck'
142 * Makefile.am (EXTRA_DIST): Add .x-po-check.
144 rm -r must remove an empty directory, even if it is inaccessible.
145 * src/remove.c (close_preserve_errno): New function.
146 (fd_to_subdirp): Don't print a diagnostic in this function.
147 Do it from the callers instead, unless rmdir succeeds.
148 (remove_cwd_entries, remove_dir): Adjust callers.
149 * tests/rm/empty-inacc: New test for the above.
150 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
151 * NEWS: Mention this bug fix.
152 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
153 a tiny bit less precise: cannot remove `a/1': ... instead of
154 cannot open directory `a/1': ...
156 * Makefile.maint (syntax-check-rules): Automatically derive this
157 list of sc_-prefixed rule names.
159 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
161 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
162 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
163 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
164 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
165 go away? was that an accident?)
166 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
167 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
168 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
169 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
170 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
171 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
172 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
173 (author_mark_check, makefile_path_separator_check):
174 Output line numbers, to simplify navigation of Emacs *compilation*
176 (sc_prohibit_atoi_atof, sc_file_system):
177 Rework slightly so that Makefile.maint doesn't get reported as a
178 violation of its own syntax rules.
179 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
180 it at run-time (which didn't work with Bison). Fix a makefile typo,
181 caught by Makefile.maint itself: spaces where a tab should be.
182 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
183 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
184 Ignore djgpp and man subdirectories, to avoid false matches with
185 Bison and coreutils, respectively. Use sort -u to remove the
186 resulting duplicates.
187 * gnupload: Rework slightly to avoid bogus warning from
188 sc_two_space_separator_in_usage.
190 2006-02-10 Jim Meyering <jim@meyering.net>
192 Use gzip's --rsyncable option only if it's available.
193 * Makefile.maint (gzip_rsyncable): New variable.
196 2006-02-08 Jim Meyering <jim@meyering.net>
198 * Makefile.maint (local-checks-available): Define in terms of
199 the expansion, $(syntax-check-rules), rather than the single,
200 top-level target `syntax-check', so that it's easier to exclude
201 individual rules (via $(local-checks-to-skip)).
202 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
204 2006-02-07 Jim Meyering <jim@meyering.net>
206 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
207 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
209 * tests/help-version (expected_failure_status_vdir):
210 Redirect an expected disk-full diagnostic to /dev/null.
212 2006-02-06 Jim Meyering <jim@meyering.net>
214 * src/unexpand.c (usage): Use two spaces (not one) to separate the
215 --first-only option string from its description, so help2man formats
216 the derived man page properly.
217 * src/rm.c (usage): Likewise for --no-preserve-root.
218 * src/chown.c (usage): Likewise.
219 * src/chgrp.c (usage): Likewise.
221 Add a rule to ensure that the above doesn't happen again.
222 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
223 (syntax-check-rules): Add it.
224 * .x-sc_two_space_separator_in_usage: New empty file.
225 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
227 2006-02-06 Jim Meyering <jim@meyering.net>
229 * src/cp.c (usage): Use two spaces (not one) to separate each
230 option string from its description, so help2man formats the
231 derived man page properly.
232 * src/mv.c (usage): Likewise.
233 Patch from Nicolas François in http://bugs.debian.org/351601.
235 2006-02-04 Jim Meyering <jim@meyering.net>
237 * src/copy.c (copy_internal): cp -RL would fail when encountering
238 the same directory more than once in the hierarchy beneath a single
239 command-line argument. That is legitimate, e.g. when there are
240 two or more symbolic links, each pointing to some directory that
241 would not otherwise be copied. Reported by Christophe LYON.
242 * tests/cp/cp-deref: New file. Test for today's fix.
243 * tests/cp/Makefile.am (TESTS): Add cp-deref.
244 * NEWS: Document this.
246 2006-02-03 Jim Meyering <jim@meyering.net>
248 * configure.ac: Require automake-1.9.6, not 1.8.3.
250 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
252 * src/od.c (usage): Mention that -t a ignores high order bit.
253 Documentation problem reported by Ed Avis.
255 2006-02-01 Jim Meyering <jim@meyering.net>
257 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
259 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
261 * src/head.c (main): Use a better diagnostic when someone uses a
262 trailing numeric option in an invalid way. Problem reported by
264 * src/tail.c (parse_options): Likewise.
266 2006-01-30 Jim Meyering <jim@meyering.net>
268 * man/wc.x: Include `count' keyword in man page synopsis,
269 per suggestion from http://bugs.debian.org/181585.
271 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
273 * src/df.c (show_dev): If the file system claims to have
274 more available than total blocks, report the number of used
275 blocks as being total - available (a negative number) rather
276 than as garbage. Problem reported by Toralf Foerster.
278 2006-01-24 Jim Meyering <jim@meyering.net>
280 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
281 to put a regular file in O_NONBLOCK mode fails with EPERM.
282 That happens on Linux (up to 2.6.15) when using tail -f on a file with
283 the append-only attribute. Reported by Dean Gaudet. For details,
284 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
285 * NEWS: Mention this fix.
286 * tests/tail-2/append-only: New file. Test for the above.
287 * tests/tail-2/Makefile.am (TESTS): Add append-only.
288 * tests/Makefile.am (check-root): Add tail-2/append-only
290 2006-01-21 Jim Meyering <jim@meyering.net>
292 * NEWS: Mention fts-related improvements and bug fixes.
294 2006-01-19 Jim Meyering <jim@meyering.net>
296 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
297 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
299 2006-01-18 Jim Meyering <jim@meyering.net>
301 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
303 2006-01-17 Jim Meyering <jim@meyering.net>
305 Now that fts no longer changes the current working directory, adjust
306 its clients accordingly -- note that du.c uses fts but doesn't need
307 any adjustment, since it doesn't operate on the actual files,
308 but rather just uses the stat buffers provided by fts.
310 * src/chown-core.c: Include "openat.h".
311 Don't include "lchown.h".
312 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
313 calling openat, lchownat, chownat, rather than open, lchown, chown.
315 * src/chmod.c: Include "openat.h".
316 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
318 * tests/du/long-from-unreadable: New test, to exercise one small
321 2006-01-13 Jim Meyering <jim@meyering.net>
323 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
324 addition of new directories under tests/.
326 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
329 2006-01-12 Jim Meyering <jim@meyering.net>
331 * tests/du/long-sloop: Adjust not to hard-code the expected
332 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
333 from that of GNU libc. Reported by Paul Eggert.
335 * tests/du/long-sloop: Create file at end of symlink chain.
337 * tests/misc/test: New file, with a test for one of the
338 bugs fixed by yesterday's test.c changes.
339 * tests/misc/Makefile.am (TESTS): Add test.
341 2006-01-11 Jim Meyering <jim@meyering.net>
343 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
344 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
345 a very long sequence of symbolic links (not necessarily a loop).
346 * tests/du/Makefile.am (TESTS): Add long-sloop.
348 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
350 * src/test.c (test_syntax_error): Append a newline. All callers
351 changed, except for the ones that didn't already append a newline.
352 Bug reported by Eric Blake.
354 2006-01-11 Jim Meyering <jim@meyering.net>
356 * src/system.h (X2NREALLOC): Now that verify_true is no longer
357 void, cast its result to void, to avoid gcc's warning that
358 ``left-hand operand of comma expression has no effect''.
359 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
361 2006-01-10 Jim Meyering <jim@meyering.net>
363 * tests/chmod/no-x: Add a test for today's fts.c fix.
365 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
367 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
368 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
370 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
372 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
373 Use verify_true instead of verify_expr, to sync with gnulib.
375 2006-01-08 Jim Meyering <jim@meyering.net>
377 * src/date.c (usage): Adjust the formatting of the entries for
378 %::z and %:::z (separate with two spaces, not one) so that help2man
379 formats them properly. Reported by Philip Rowlands.
381 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
383 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
385 2006-01-06 Jim Meyering <jim@meyering.net>
387 * Makefile.maint (copyright-check): Use date +%Y in place of
390 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
391 First off, the attribute should have been `volatile' (not static)
392 to avoid longjmp-related risk of clobber. Secondly, now there is
393 no longer any risk of a local variable being clobbered, so there's
394 no need for any attribute at all.
396 2006-01-05 Jim Meyering <jim@meyering.net>
398 * src/remove.c: Give a few functions the inline attribute.
399 (AD_pop_and_chdir): Use gotos to avoid some duplication.
400 (AD_push): Rewrite an assertion so that the entire computation
401 goes away when assertions are turned off.
403 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
404 It's already defined in "system.h".
405 * Makefile.maint: Add a FIXME comment.
407 2006-01-04 Jim Meyering <jim@meyering.net>
409 * ChangeLog: Remove entries from 2005-10-22 and earlier.
410 * ChangeLog-2005: New file, for entries up to version 5.92.
412 2006-01-03 Jim Meyering <jim@meyering.net>
414 * tests/du/no-x: Also allow a slightly different diagnostic -- the
415 one you get when using openat-enabled fts.c and du (coming soon).
416 * tests/chmod/no-x: Likewise.
417 * tests/chgrp/no-x: Likewise.
419 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
421 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
423 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
424 (restricted_chown): Return it, if the file cannot be accessed due
425 to EPERM, or if no uid or gid are required, or if the file is
426 neither a directory nor a regular file. Rewrite to avoid gotos.
427 (change_file_owner): Handle RC_do_ordinary_chown case.
428 Rewrite to avoid gotos.
429 * tests/chgrp/basic: Make sure we can change the group of
432 * src/date.c (usage): Explain %g, %G, and %V a bit better.
434 2006-01-02 Jim Meyering <jim@meyering.net>
436 * src/copy.c (set_owner): Correct a comment.
438 * src/tail.c (parse_options): Change warning to say that --retry
439 is useful `mainly' (not `only') when following by name.
440 Reported here: http://bugs.debian.org/273781
442 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
444 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
445 * src/copy.c: Include lchmod.h.
446 (copy_internal): Use lchmod rather than chmod.
447 * src/cp.c: Include lchmod.h.
448 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
449 * src/mkdir.c: Include lchmod.h.
450 (usage): Clarify -m's operation.
451 (main): Use lchmod rather than chmod. Don't use lchmod unless the
452 new mode contains bits outside the 777 range.
453 * src/mkfifo.c (usage): Clarify -m's operation.
454 (main): If -m is given, don't invoke chmod; use umask 0 instead.
455 Report an error if -m asks for bits outside the 777 range.
456 * src/mknod.c (usage, main): Likewise.
458 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
460 2005-12-27 Jim Meyering <jim@meyering.net>
462 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
463 (sc_prohibit_assert_without_use): New rule.
464 (syntax-check-rules): Add it to the list.
465 * .x-sc_prohibit_assert_without_use: New empty file.
466 * Makefile.am (EXTRA_DIST): Add it.
468 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
470 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
471 Don't include <assert.h>; it wasn't used.
473 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
475 * src/chown-core.c (restricted_chown):
476 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
477 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
478 | O_NOFOLLOW too, for consistency with other dir-openers.
479 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
480 (is_empty_dir): Likewise.
481 * src/shred.c (wipename): Likewise. Don't bother trying to open
482 dir for writing, since POSIX prohibits it.
484 2005-12-22 Jim Meyering <jim@meyering.net>
486 * tests/help-version: Redirect stderr to /dev/full, to suppress
487 write error diagnostic.
489 2005-12-19 Jim Meyering <jim@meyering.net>
491 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
492 Avoid a minor race condition when `-m MODE' is specified, by using
493 open, fchown, and close rather than just chown. To do that reliably --
494 even with an overly restrictive umask -- ensure that each mkdir,
495 mknod and mkfifo call uses a mode including at least owner-read access.
496 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
497 the subsequent chown (or equivalent open,fchown,close) fails.
498 * tests/misc/mknod: New tests.
499 * tests/misc/Makefile.am (TESTS): Add mknod.
501 2005-12-17 Jim Meyering <jim@meyering.net>
503 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
504 e.g., on a named pipe.
505 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
506 place of all uses, since it is guaranteed (system.h) to be defined.
508 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
510 Add POSIX ACL support
511 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
512 is no requirement for ACL support; particularly, it does not exist
513 on systems that have POSIX ACLs.
514 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
515 * src/cp.c (umask_kill): With default acls, the umask is not to be
516 applied. Remove umask_kill, don't change the process umask, and let
517 the kernel apply the umask where appropriate.
518 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
519 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
521 (copy_reg, copy_internal): Use copy_acl and set_acl
522 instead of fchown/chown. Fix the logic for POSIX ACLs.
523 (chown_succeded): Remove; we now always copy acls and
524 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
525 did a chown before or not.
526 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
527 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
528 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
529 to link with it via $(LIB_ACL), for the utilities that need it.
531 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
533 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
534 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
535 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
536 value is now signified by whether cwd_errno is null.
537 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
538 pointer-to-bool to pointer-to-errno-value. All callers changed.
539 (rm_1): Don't bother setting a local cwd failure flag and then
540 ORing it into the caller's. Just set the caller's.
541 (rm): Use cwd failure errno value to print a slightly-better
544 2005-12-15 Jim Meyering <jim@meyering.net>
546 * src/stat.c (print_it): Properly handle a backslash at the
547 end of a --printf format string. Reported by Paul Eggert.
548 * tests/misc/stat-printf (end-bs): Add a test for the above.
550 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
552 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
553 Don't assume /etc/passwd contains user names; use 'id' instead.
555 2005-12-15 Jim Meyering <jim@meyering.net>
557 stat: revert behavior of --format=FMT (-c)
558 stat: add new option: --printf=FMT
559 * NEWS: Mention this.
560 * src/stat.c (isodigit, octtobin, hextobin): Define.
561 (PRINTF_OPTION): Define.
562 (interpret_backslash_escapes, trailing_delim): New globals.
563 (usage): Document them. Alphabetize on long option names.
564 (print_esc_char): New function.
565 (print_it): Rewrite, in order to handle backslash escapes.
566 (main): Handle new option. Set globals for --format, too.
568 * tests/misc/stat-printf: Test --printf and --format.
569 * tests/misc/Makefile.am (TESTS): Add stat-printf.
571 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
573 * NEWS: sort now reports incompatible options.
574 * src/sort.c (incompatible_options, check_ordering_compatibility):
576 (main): Use them. Don't bother with a usage message for
577 "sort -c a b", for consistency with other error diagnostics.
578 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
581 * src/cat.c (main): Undo previous change. close_stdout already
582 does the check, so the previous change wasn't necessary.
584 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
586 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
588 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
590 Install a more-conservative approach for sort -R. It's the
591 same basic idea as the existing code, except it uses the full ISAAC
592 approach (called the "more kosher" approach in the existing comments).
593 This makes "sort -R" quite a bit slower (about a factor of 2 on my
594 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
595 better to be conservative here at first, and review any performance
596 improvements carefully.
597 * .x-sc_require_config_h: Add src/rand-isaac.c.
598 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
599 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
600 (shred_SOURCES, sort_SOURCES): Remove.
601 (EXTRA_DIST): Add rand-isaac.c.
602 * src/rand-isaac.c: Revert to what used to be in shred.c, without
603 changing it to allow for varying numbers of words in the state.
604 Alter so that we include rand-isaac.c directly rather than
605 compiling it and linking to it. Don't include config.h or
606 system.h; that's the includer's responsibility.
607 Omit functions that are specific to shred.
608 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
609 (isaac_step, struct irand_state):
610 Resurrect these, with the same defns that used to be in shred.c.
611 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
612 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
614 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
615 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
616 (irand_init, irand32, irand_mod):
617 Number of words is constant again.
618 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
619 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
620 * src/sort.c: Likewise.
621 * src/shred.c (fillrand, dopass, main): Undo previous change.
622 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
624 * src/sort.c: Don't include md5.h; it wasn't needed.
625 (struct keyfield): Rename random_hash to random, for consistency
626 with the other member names. All uses changed.
627 (usage): Tweak wording to mention STRING for --seed option.
628 (short_options): Rorder for consistency with other programs.
629 (rand_state): Now a struct, not a pointer to one. All uses changed.
630 (HASH_WORDS, HASH_SIZE): Remove.
631 (get_hash): Remove comments around resbuf size, since we can assume C89.
632 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
633 (keycompare): Adjust to the new get_hash.
635 (badfieldspec): Omit recently-introduced comment; it isn't needed.
636 (main): Don't set need_random simply because gkey has it set; that
637 doesn't necessarily mean we'll need random numbers.
638 Redo seeding to match new get_hash approach.
640 2005-12-10 Jim Meyering <jim@meyering.net>
642 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
644 Avoid shred segfault on 64-bit systems.
645 * src/rand-isaac.c (isaac_refill): Don't try to negate a
646 local of type uint32_t. Make the local an `int' instead.
648 * NEWS: Mention sort's new options.
650 * src/rand-isaac.c (isaac_mix): Declare to be static.
651 Mark all other functions as `extern' so the tight-scope
652 part of `make distcheck' passes once again.
653 * src/rand-isaac.h (isaac_mix): Remove declaration.
655 * src/sort.c (get_hash): Change position of `*' in parameter
656 type to conform with convention.
657 (main): Split a long line so it fits in 80 columns.
658 (keycompare): Remove stray SPACE before TAB that was
659 causing `make distcheck' to fail.
661 * src/shred.c: Don't include gethrxtime.h. No longer needed.
663 * tests/misc/sort-rand: New file: basic tests for the new options.
664 * tests/misc/Makefile.am (TESTS): Add sort-rand.
666 2005-12-10 Frederik Eaton <frederik@ofb.net>
668 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
669 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
670 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
671 Make state size runtime-configurable.
672 (isaac_new, isaac_copy): New functions.
673 * src/rand-isaac.h: New file.
674 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
675 (fillrand, main): Adjust to the fact that the state size is now
676 runtime-configurable.
677 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
678 (usage): Add options --random-sort and --seed to implement a random
680 Include md5.h and rand-isaac.h.
681 (get_hash): New function.
682 (rand_state): New var.
683 (HASH_WORDS, HASH_SIZE): New macros.
685 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
687 * tests/dd/misc: Add test for dd iflags=noatime.
689 2005-12-09 Jim Meyering <jim@meyering.net>
691 * src/sort.c (usage): Mention white space vs -b and -t options.
694 2005-12-09 Eric Blake <ebb9@byu.net>
696 * src/test.c (main): Fix misleading comment.
698 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
700 * NEWS: Mention dd's new noatime flag.
701 * src/system.h (O_NOATIME): Define to 0 if not already defined.
702 * src/dd.c (flags, usage): Add support for noatime flag.
704 2005-12-07 Jim Meyering <jim@meyering.net>
706 Distribute the cvsu script, used only by `make syntax-check'.
707 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
708 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
709 distribute a copy of this script.
710 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
712 * tests/mv/acl: exit-77 before the trap, not after, if we fail
713 to create a temporary directory on another partition.
714 From Andreas Gruenbacher.
716 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
718 * man/basename.x: Cross-reference to dirname and readlink.
719 * man/dirname.x: Cross-reference to basename and readlink.
721 2005-12-05 Andreas Gruenbacher
723 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
724 (set_owner, preserve_author): New functions, factored out of copy_reg.
725 (copy_reg): Use them.
726 (copy_internal): Use them here, too.
728 2005-12-04 Jim Meyering <jim@meyering.net>
730 * src/sleep.c (usage): Say what happens with two or more arguments.
731 Suggested by Justin Pryzby.
733 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
736 2005-12-03 Jim Meyering <jim@meyering.net>
738 * src/rm.c (long_opts): Change the name of each undocumented, for-
739 testing-only option to start with `-', so that it cannot render
740 ambiguous any prefix it happens to share with some other option name.
741 Problem reported by Eric Blake.
742 * src/head.c (long_options): Likewise.
743 * src/tail.c (long_options): Likewise.
745 * tests/misc/head-elide-tail: Update uses of undocumented, for-
746 testing-only --presume* options to start with `---'.
747 * tests/rm/dangling-symlink: Likewise.
748 * tests/rm/dir-no-w: Likewise.
749 * tests/rm/isatty: Likewise.
751 2005-11-30 Jim Meyering <jim@meyering.net>
753 * Makefile.maint: Add a comment about cvsu.
755 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
757 * NEWS: df updates for "none", "proc", inaccessible file systems.
758 * src/df.c (show_point): Ignore inaccessible file systems.
759 (usage): -a includes dummy file systems, not size-0 file systems.
761 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
762 to avoid collision with POSIX name space. All uses changed.
764 2005-11-24 Jim Meyering <jim@meyering.net>
766 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
767 * tests/acl: Add `$0: ' prefix to diagnostics.
769 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
771 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
773 * src/copy.c: Improve performance a bit by optimizing away
774 unnecessary system calls and going to a block size of at least
775 8192 (on normal hosts, anyway). This improved performance 5% on my
776 Debian stable host (2.4.27 kernel, x86, copying from root
777 ext3 file system to itself).
778 Include "buffer-lcm.h".
779 (copy_reg): Omit last argument. All callers changed.
780 Use xmalloc to allocate rather than trusting alloca
781 (which is unwise with large block sizes).
782 Declare locals more locally, if possible.
783 Use uintptr_t words instead of int words, for a bit more speed
784 when looking for null blocks on 64-bit hosts.
785 Optimize away reads of zero bytes on regular files.
786 In the typical case, insist on 8 KiB buffers, at least.
787 Avoid unnecessary extra call to fstat when checking for sparse files.
788 Avoid now-unnecessary cast to off_t, and "0L".
789 Avoid unnecessary test of *new_dst when checking for same owner
792 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
794 * src/remove.c (rm): Don't assume C99 for-loop syntax.
796 2005-11-22 Jim Meyering <jim@meyering.net>
798 * src/remove.c (AD_push): Remove debugging cruft.
800 * tests/rm/unread2 (rm): Change expected diagnostic,
801 `cannot open directory' to `cannot remove', to align with
803 * tests/rm/rm2: Ensure that rm now continues removing entries
804 even after certain types of failure.
806 * src/remove.c: Rewrite. Now, this module is reentrant on systems
807 that provide openat (Solaris), and on systems like Linux+procfs
808 where our openat emulation code is reentrant. This also fixes a
809 few low-probability leaks and eliminates some code that could,
810 in very unusual circumstances, cause rm() (via a callee) to exit.
811 * NEWS: Mention this.
813 * configure.ac: Put copyright dates all on one line so the
814 emacs function that updates them works properly.
816 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
818 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
819 Problem reported by Eric Blake.
820 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
821 we get a standard-conforming compiler. This relies on the new
822 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
823 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
824 m4/c.m4 can go away with Autoconf 2.60 comes out.
826 2005-11-17 Jim Meyering <jim@meyering.net>
828 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
829 (AD_mark_current_as_unremovable): Likewise, but for a local.
832 * tests/mv/acl: Let traps handle removing temporary directories.
834 Expect acl-related tests to fail, until the corresponding
835 patches are committed.
836 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
837 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
839 ACL tests, from Andreas Gruenbacher.
840 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
841 * tests/mv/Makefile.am (TESTS): Add acl.
842 * tests/cp/Makefile.am (TESTS): Add acl.
844 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
846 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
848 * NEWS: Improve quality of ln's diagnostics.
849 * src/ln.c (do_link, usage): Likewise.
850 (do_link): Don't use alloca on a buffer of unbounded size.
852 2005-11-16 Jim Meyering <jim@meyering.net>
854 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
855 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
856 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
858 2005-11-14 Jim Meyering <jim@meyering.net>
860 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
862 2005-11-13 Jim Meyering <jim@meyering.net>
864 * announce-gen: Accept new option, --gpg-key-id=ID and
865 emit a blurb telling how to use the .sig files.
866 * Makefile.cfg (gpg_key_ID): Define.
867 * Makefile.maint (announcement): Use new option and key.
869 Require that most .c files include <config.h>.
870 * Makefile.maint (sc_require_config_h): New rule.
871 (syntax-check-rules): Add it.
872 * .x-sc_require_config_h: New file listing exceptions to the
873 above rule. Some are legit, others are simply grandfathered in.
874 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
876 2005-11-12 Jim Meyering <jim@meyering.net>
878 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
880 2005-11-11 Jim Meyering <jim@meyering.net>
882 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
883 Mention new readlink options in 5.3.0's `New features' section.
884 Spotted by Thomas Hood.
886 2005-11-08 Jim Meyering <jim@meyering.net>
888 * NEWS: Merge in changes from b5_9x branch.
890 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
892 * NEWS: ls now defaults to --time-style='locale', which in turn acts
893 like --time-style='posix-long-iso' if the locale settings are messed up.
894 * src/ls.c (decode_switches): Implement this.
896 2005-11-08 Jim Meyering <jim@meyering.net>
898 * tests/du/2g: s/expensive/very expensive/ in a comment.
901 2005-10-17 Eric Blake <ebb9@byu.net>
903 * src/ls.c (usage): Fix descriptions of --sort, --time.
904 Reported by Vitaly A. Ostanin.
906 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
908 * src/ln.c: Include filenamecat.c.
909 (FILE_BASENAME_CONCAT): Remove.
910 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
911 (main): Use file_name_concat, base_name, and strip_trailing_slashes
912 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
915 2005-11-04 Jim Meyering <jim@meyering.net>
917 * src/du.c (process_file): Don't overflow for files of size >= 2^31
918 on systems with stat.st_blocks of a signed 32-bit type.
919 This bug causes trouble on some AIX 5.1 systems.
920 Report and trivial patch from Paul Townsend:
921 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
922 * NEWS: Mention this.
924 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
925 * tests/du/Makefile.am (TESTS): Add it here.
926 * tests/very-expensive: New file.
927 * tests/Makefile.am (EXTRA_DIST): Add it here.
928 * tests/cp/perm: Mark this test as `very-expensive', too.
930 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
932 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
934 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
936 * src/rm.c (usage): Don't mention rm -d.
938 2005-11-02 Jim Meyering <jim@meyering.net>
940 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
943 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
944 `M+N records in/out' lines don't pollute `make check' output.
946 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
947 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
948 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
949 to indicate that the input file should be piped into the command
950 under test (via `cat FILE | $prog ...').
952 * src/remove.c (remove_entry): Emit a better diagnostic when rm
953 (without -r) fails to remove a directory on a non-Linux system.
954 This change affects only newer Solaris systems (with priv_*
955 functions like priv_allocset). Reported by Keith Thompson.
957 * tests/rm/dir-nonrecur: New file/test for the above fix.
958 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
960 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
962 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
963 POSIX 1002.1-2001 requires.
964 * src/tail.c (parse_obsolete_option): Implement this.
965 Problem reported by Vincent Lefevre.
966 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
967 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
968 (test_vector): Add special cases for _POSIX2_VERSION, and
969 regularize the old ones a bit.
970 * tests/touch/obsolescent: Add y2000 test.
972 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
974 * src/dd.c (skip): Fix off-by-one error reported by
975 Theodoros V. Kalamatianos.
977 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
979 * tests/mkdir/p-3: Require that the test be run as non-root.
980 Problem and trivial fix reported by Theodoros V. Kalamatianos.
982 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
984 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
985 boundary between DEST and SOURCE in the result.
987 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
989 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
990 back to text, to sync with documentation and for backwards
993 2005-10-25 Jim Meyering <jim@meyering.net>
995 * tests/dircolors/simple (other-wr): Add an explicit test for
996 the dircolors bug (NULL-dereference) fixed yesterday.
998 2005-10-24 Jim Meyering <jim@meyering.net>
1000 * src/tac.c (tac_file): When determining whether a file is seekable,
1001 also test whether it is a tty. Using only the lseek-based test would
1002 give a false positive on Solaris. Reported by Peter Fales.
1004 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1006 * tests/install/d-slashdot: New test, for "install -d" failure.
1007 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1008 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1009 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1011 2005-10-24 Jim Meyering <jim@meyering.net>
1013 * src/dircolors.c (ls_codes): Add missing comma.
1014 Anonymous report and patch from
1015 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1017 * src/dircolors.c: Add compile-time assertion that the slack_codes
1018 and ls_codes arrays have the same number of elements. This would
1019 have prevented the above-fixed bug.
1021 * src/expand.c (parse_tab_stops): Add a comment to make this function
1022 identical to the one in unexpand.c.
1023 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1024 identical to the one in expand.c.
1026 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1028 2005-10-23 Jim Meyering <jim@meyering.net>
1030 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1031 a dangerous pointer-value-to-`unsigned' cast.
1032 * NEWS: mention the new sha* programs.
1033 * AUTHORS: Add new sha* programs.
1035 2005-08-28 David Madore <david.madore@ens.fr>
1037 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1038 * README: Add their names to the list.
1039 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1040 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1041 Rules for compiling sha-2 utilities
1042 (noinst_HEADERS): Remove checksum.h.
1043 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1045 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1046 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1047 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1048 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1049 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1050 sha384sum, sha512sum test scripts here rather that each in its
1053 2005-08-28 David Madore <david.madore@ens.fr>
1055 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1056 of the FIPS test vectors).
1058 2005-10-23 Jim Meyering <jim@meyering.net>
1060 * configure.ac: Use 6.0-cvs as the version string.
1061 * NEWS: Adjust accordingly.