1 2006-05-11 Jim Meyering <jim@meyering.net>
5 * tests/mv/atomic: New file/test for yesterday's fix.
6 * tests/mv/Makefile.am (TESTS): Add atomic.
8 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
10 2006-05-10 Jim Meyering <jim@meyering.net>
12 * src/copy.c (copy_internal): Don't explicitly unlink the destination
13 when moving a symlink into the place of an existing non-directory.
14 Reported by Joshua Hudson.
17 2006-05-07 Jim Meyering <jim@meyering.net>
19 * Makefile.maint (patch-check): Fail if patch generates any output,
20 even merely for changed offsets.
22 * src/c99-to-c89.diff: Adjust to reflect new offsets.
24 * NEWS: Mention changes affecting df, pwd, shred.
26 2006-05-06 Jim Meyering <jim@meyering.net>
28 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
29 system condition where dirent.d_ino != stat.st_ino.
30 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
32 2006-05-06 Eric Blake <address@hidden>
34 * tests/ls/inode: Expand to test inode from readdir case.
35 * tests/ls/follow-slink: Expand to test broken links encountered
36 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
38 2006-05-06 Eric Blake <ebb9@byu.net>
40 * tests/mv/leak-fd: Work even on case-insensitive file system.
42 2006-05-04 Jim Meyering <jim@meyering.net>
44 * NEWS: Mention the 2006-03-19 pwd-related change that makes
45 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
47 2006-05-03 Jim Meyering <jim@meyering.net>
49 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
50 Use better macro parameter names: s/basename/key_name/,
51 s/basefunc/key_cmp_func. Fix typo in comment.
53 2006-04-29 Eric Blake <ebb9@byu.net>
55 * src/ls.c (main): On systems with d_type, directories_first only
56 implies format_needs_type, not format_needs_stat.
58 2006-05-03 Jim Meyering <jim@meyering.net>
60 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
61 after comma in arg list, from Eric Blake.
63 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
65 * tests/misc/date (relative-3): New test, derived from a bug
66 report by John Thomas McDole.
68 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
70 New option for ls: --group-directories-first.
71 It makes ls list directories before files.
72 * NEWS [New features]: Mention it.
73 * src/ls.c (sort_type): Rearrange to use as an array index when
74 choosing sort function; added new sort_numtypes member for
76 (time_type): Add new time_numtypes member for compile-time check.
77 (directories_first): New global variable.
78 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
79 (long_options): Add --directories-first.
80 (main): Support new option.
81 (is_directory): New function.
82 (extract_dirs_from_files): Use it.
83 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
84 (LIST_SORTFUNCTION_VARIANTS): New macros.
85 (sort_functions): New global variable.
87 (usage): Document new option.
89 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
91 * src/shred.c (fillrand): The assertion was way too weak, due to
92 what must be a typo. Strengthen it to its intended value.
93 (dopass): Don't use alloca; it's not worth the aggravation here,
94 since it's used only to get a page-aligned buffer, and page
95 alignment doesn't buy us much here. I'm suspicious that alloca
96 causes problems on some hosts, due to a recent bug report by Adam
97 Waltman: http://bugs.gentoo.org/130246.
99 2006-04-18 Jim Meyering <jim@meyering.net>
101 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
102 sha384sum, sha512sum.
104 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
106 * src/chmod.c (describe_change): Adjust to filemode changes.
107 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
108 (print_long_format): Use (new) filemodestring rather than
109 (old) mode_string, so that we get more file types right, at least
110 in theory. Adjust to filemode changes.
111 * src/stat.c (human_access): Likewise.
113 2006-04-18 Jim Meyering <jim@meyering.net>
115 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
116 ignore file. This has never been enabled. Reported by Eric Blake.
118 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
120 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
121 bug in Interix. Just call symlink or link directly. All uses changed.
122 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
123 * src/stat.c (USE_STATVFS): New macro.
124 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
125 (NAMEMAX_FORMAT): define a bit more clearly, now that the
126 statvfs-using code is a bit more regular.
127 * src/system.h (sync) [!HAVE_SYNC]: New macro.
129 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
131 * NEWS: csplit, nl, expr now conform to POSIX better, and are
132 more-compatible with traditional Unix, with respect to regular
134 * src/csplit.c (extract_regexp): Set re_syntax_options to a
135 value that is compatible with what POSIX requires.
136 * src/nl.c (build_type_arg): Likewise.
137 * src/expr.c (docolon): Likewise. Also, don't let anchors match
138 newline; this fixes an incompatibility with tradition and with POSIX.
139 Don't warn about leading ^. POSIX says it is unspecified whether
140 ^ is a special character, which means that implementations can
141 either treat it as special or not, but either way a warning is not
142 allowed (unless the regexp is otherwise invalid). Instead, anchor
143 the expression but treat ^ as an anchor; this is the traditional
144 behavior (e.g., Solaris 10).
145 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
146 and the like as invalid expressions (exit status 2), not as
147 failure of 'expr' (exit status 3). This is more consistent with
149 * tests/expr/basic (fail-a): Adjust exit status to match new expr
150 behavior, for status 2 versus 3.
152 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
153 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
154 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
155 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
156 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
157 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
158 (bre61, bre62): New tests.
159 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
163 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
164 "if !". Do not assume that 'sed' can handle long, newline-free input.
165 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
167 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
169 Adjust to new regex.h API (with new fastmap type), and clean
170 up the regex storage allocation a bit.
172 * src/csplit.c (struct control): Put re_compiled member at the
173 end, since it's large. Change regexpr member from char * to bool;
174 all uses changed. Add new member fastmap.
175 (extract_regexp): regexp arg is now char const *, not char *.
176 Don't bother duplicating the regular expression; it's not needed.
177 Set fastmap from new fastmap member. Don't bother allocating
178 a buffer, as the regexp code does a better job than we do.
179 * src/expr.c (docolon): Allocate and use a fastmap.
180 Don't bother allocating a buffer.
181 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
183 (build_type_arg): New fastmap arg. All uses changed.
184 Don't bother allocating a buffer, but set a fastmap.
185 * src/ptx.c (context_regex_string, word_regex_string): Remove.
186 (context_regex, word_regex): New vars, replacing the above.
188 (struct regex_data): New type.
189 (compile_regex): Renamed from alloc_and_compile_regex, since
190 we no longer allocate storage. Arg is now a struct regex_data *,
191 not a const char *. All uses changed. Don't allocate the fastmap;
192 instead, take it from the caller. Don't convert size_t to int,
193 to avoid arithmetic overflow problems. Don't bother freeing
194 storage afterwards; it's not worth the aggravation.
195 * src/tac.c (compiled_separator_fastmap): New ver.
196 (main): Use it. Don't bother allocating a buffer.
198 2006-03-30 Jim Meyering <jim@meyering.net>
200 * src/dd.c (iwrite): Remove assignment without effect.
201 Reported by Felix Rauch Valenti.
203 2006-03-22 Eric Blake <ebb9@byu.net>
205 * src/ptx.c (usage): Remove mention of --copyright/-C.
206 (main): Alias --copyright to --version plus a deprecation warning.
207 * NEWS: Mention this.
209 2006-03-27 Jim Meyering <jim@meyering.net>
211 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
212 use of strtod. Tiny patch from Nickolai Zeldovich.
214 2006-03-11 Eric Blake <ebb9@byu.net>
216 * tests/misc/dirname: New file.
217 * tests/basename/Makefile.am: Delete.
218 * tests/basename/basic: Move to...
219 * tests/misc/basename: ... this new file. Add some tests,
220 including fixed behavior for //.
221 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
222 * tests/Makefile.am (SUBDIRS): Remove basename.
223 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
225 Improvements to dirname/basename handling on platforms like
226 cygwin with distinct // and with drive letters.
227 * NEWS: Document new behavior.
228 * src/basename.c (main): Don't strip suffix from file system
230 * src/cp.c (target_directory_operand): Use new last_component.
231 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
232 traversing the string.
233 * src/dircolors.c (guess_shell_syntax): Use new last_component.
234 * src/install.c (target_directory_operand, install_file_in_dir):
236 * src/ln.c (target_directory_operand, main): Likewise.
237 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
238 * src/mv.c (target_directory_operand, movefile): Likewise.
239 * src/remove.c (rm_1): Likewise.
240 * src/shred.c (wipename): Likewise.
241 * src/split.c (next_file_name): Likewise.
242 * src/su.c (log_su, run_shell): Likewise.
244 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
246 * NEWS: nohup diagnostics are now more precise, and nohup now
247 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
248 * src/nohup.c (main): Implement this.
249 * tests/misc/nohup: Test the new behavior.
251 2006-03-12 Jim Meyering <jim@meyering.net>
253 * src/copy.c (set_author): Rename function, from preserve_author.
255 * src/remove.c (AD_pop_and_chdir): Use new macro,
256 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
258 * src/system.h (SAME_INODE): Remove definition.
259 Include "same-inode.h", instead.
261 2006-03-11 Eric Blake <ebb9@byu.net>
263 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
265 2006-03-10 Jim Meyering <jim@meyering.net>
267 Fix a bug whereby a user with write access to a directory being removed
268 could cause the removal of that directory to fail with an erroneous
269 diagnostic about a directory cycle. Reported by Vineet Chadha.
271 * NEWS: Mention this.
272 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
273 leave (and try to rmdir) is the one whose dev_ino is being used to
274 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
276 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
278 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
279 * src/dd.c (set_fd_flags): Handle file-creation flags on file
280 descriptors, rather than ignoring them.
281 * tests/dd/misc: Add test cases for append, nofollow, directory,
282 and nolinks flags. Simplify redirection to /dev/null in some cases.
284 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
285 noatime test never tested anything.
287 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
289 * src/dd.c (flags, usage): New flags directory, nolinks.
290 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
292 * src/ls.c (usage): Mention that -f disables --color.
293 Problem reported by Niels Möller.
295 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
297 * man/*.x: Add references to syscalls from utilities of the same name.
299 2006-03-05 Jim Meyering <jim@meyering.net>
301 * tests/help-version: Set SHELL, if not already set, in order to
302 avoid failure when `make check' is run through debuild; dircolors
303 would fail due to lack of $SHELL. Reported by Sven Joachim.
305 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
306 * src/base64.c (wrap_write, do_encode, main): Change type of
307 parameters and locals, wrap_column, form size_t to uintmax_t.
308 (main): Adjust to use xstrtoumax, accordingly.
310 2006-03-03 Jim Meyering <jim@meyering.net>
312 Don't fail when run from an environment with SHELL not a Bourne
313 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
314 * tests/dircolors/simple: Invoke each non-failing test with -b.
315 Reported by Michael Stone.
317 2006-02-27 Jim Meyering <jim@meyering.net>
319 * tests/misc/base64: Derive --decode-using tests from the
322 * tests/misc/base64: Factor out a long constant string.
323 Split lines to stay within 80 columns.
325 * tests/misc/Makefile.am (TESTS): Add base64.
326 * tests/misc/base64: Test base64. From Simon Josefsson.
328 * src/base64.c (do_decode): Use correct type for parameter,
329 ignore_garbage: s/size_t/bool/.
331 * src/base64.c: Don't include .h files already included by system.h:
332 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
333 Include "system.h" before the other lib/*.h header files.
334 Include <sys/types.h> before "system.h".
335 (wrap_write): Remove declaration of unused local, initial_column.
336 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
338 * README: Add base64 to the list.
340 2006-02-17 Simon Josefsson <jas@extundo.com>
343 * AUTHORS: Mention base64.
345 * man/Makefile.am: Build base64.1.
346 * man/base64.x: New file.
347 * src/Makefile.am (bin_PROGRAMS): Add base64.
348 * src/base64.c: New file.
350 2006-02-25 Eric Blake <ebb9@byu.net>
352 In ls, avoid calling stat for --inode (-i), when possible.
353 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
354 * src/system.h: ... here, for use in ...
355 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
357 (gobble_file): Add inode argument.
358 (print_dir): Pass inode if available.
359 (usage): Remove inaccuracy.
361 2006-02-23 Jim Meyering <jim@meyering.net>
363 * TODO: Update/correct some obsolete entries.
365 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
367 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
368 * src/join.c (usage): Likewise.
369 Documentation problem reported by Philip Kensche.
371 2006-02-20 Eric Blake <ebb9@byu.net>
373 * man/rm.x: Update documentation to match previous patch.
375 2006-02-18 Eric Blake <ebb9@byu.net>
377 New option for rm: --interactive=once (-I).
378 * NEWS: Document it, along with change to rm --interactive.
379 * TODO: Remove entry for implementing rm -I
380 * src/rm.c (INTERACTIVE_OPTION): New enum value.
381 (interactive_type): New enum.
382 (long_opts): Let interactive take an optional argument.
383 (interactive_args, interactive_types): New option arguments.
384 (usage): Document -I, --interactive=WHEN. Use program_name
385 instead of a basename.
386 (main): New -I option, new behavior to --interactive.
387 * tests/rm/interactive-once: New tests.
388 * tests/rm/interactive-always: Ditto.
389 * tests/rm/Makefile.am (TESTS): Run them.
391 2006-02-18 Jim Meyering <jim@meyering.net>
393 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
394 expression match more of the target lines, e.g., those that start with
395 `-S,' (short option followed by a comma) or that include `=[...]'.
396 Patch by Nicolas François.
397 Fix the four offenders thus exposed:
398 * src/join.c (usage): Use two spaces (not one) to separate the
399 --first-only option string from its description, so help2man formats
400 the derived man page properly.
401 * src/pr.c (usage): Likewise.
402 * src/uniq.c (usage): Likewise.
403 * src/install.c (usage): Likewise.
405 2006-02-15 Jim Meyering <jim@meyering.net>
407 * Makefile.maint (alpha beta major): For `make major', ensure that the
408 version string is of the form N.N[.N]*, where N is one or more digits.
410 2006-02-14 Jim Meyering <jim@meyering.net>
412 * INSTALL: Update from gnulib.
414 2006-02-13 Jim Meyering <jim@meyering.net>
416 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
418 2006-02-12 Jim Meyering <jim@meyering.net>
420 * Makefile.maint (patch-check): New target.
421 (local-checks-available): Add to the list.
423 2006-02-11 Jim Meyering <jim@meyering.net>
425 * src/c99-to-c89.diff: New file.
426 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
428 * .x-po-check: New file, with exclusions so that `make distcheck'
430 * Makefile.am (EXTRA_DIST): Add .x-po-check.
432 rm -r must remove an empty directory, even if it is inaccessible.
433 * src/remove.c (close_preserve_errno): New function.
434 (fd_to_subdirp): Don't print a diagnostic in this function.
435 Do it from the callers instead, unless rmdir succeeds.
436 (remove_cwd_entries, remove_dir): Adjust callers.
437 * tests/rm/empty-inacc: New test for the above.
438 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
439 * NEWS: Mention this bug fix.
440 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
441 a tiny bit less precise: cannot remove `a/1': ... instead of
442 cannot open directory `a/1': ...
444 * Makefile.maint (syntax-check-rules): Automatically derive this
445 list of sc_-prefixed rule names.
447 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
449 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
450 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
451 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
452 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
453 go away? was that an accident?)
454 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
455 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
456 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
457 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
458 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
459 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
460 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
461 (author_mark_check, makefile_path_separator_check):
462 Output line numbers, to simplify navigation of Emacs *compilation*
464 (sc_prohibit_atoi_atof, sc_file_system):
465 Rework slightly so that Makefile.maint doesn't get reported as a
466 violation of its own syntax rules.
467 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
468 it at run-time (which didn't work with Bison). Fix a makefile typo,
469 caught by Makefile.maint itself: spaces where a tab should be.
470 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
471 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
472 Ignore djgpp and man subdirectories, to avoid false matches with
473 Bison and coreutils, respectively. Use sort -u to remove the
474 resulting duplicates.
475 * gnupload: Rework slightly to avoid bogus warning from
476 sc_two_space_separator_in_usage.
478 2006-02-10 Jim Meyering <jim@meyering.net>
480 Use gzip's --rsyncable option only if it's available.
481 * Makefile.maint (gzip_rsyncable): New variable.
484 2006-02-08 Jim Meyering <jim@meyering.net>
486 * Makefile.maint (local-checks-available): Define in terms of
487 the expansion, $(syntax-check-rules), rather than the single,
488 top-level target `syntax-check', so that it's easier to exclude
489 individual rules (via $(local-checks-to-skip)).
490 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
492 2006-02-07 Jim Meyering <jim@meyering.net>
494 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
495 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
497 * tests/help-version (expected_failure_status_vdir):
498 Redirect an expected disk-full diagnostic to /dev/null.
500 2006-02-06 Jim Meyering <jim@meyering.net>
502 * src/unexpand.c (usage): Use two spaces (not one) to separate the
503 --first-only option string from its description, so help2man formats
504 the derived man page properly.
505 * src/rm.c (usage): Likewise for --no-preserve-root.
506 * src/chown.c (usage): Likewise.
507 * src/chgrp.c (usage): Likewise.
509 Add a rule to ensure that the above doesn't happen again.
510 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
511 (syntax-check-rules): Add it.
512 * .x-sc_two_space_separator_in_usage: New empty file.
513 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
515 2006-02-06 Jim Meyering <jim@meyering.net>
517 * src/cp.c (usage): Use two spaces (not one) to separate each
518 option string from its description, so help2man formats the
519 derived man page properly.
520 * src/mv.c (usage): Likewise.
521 Patch from Nicolas François in http://bugs.debian.org/351601.
523 2006-02-04 Jim Meyering <jim@meyering.net>
525 * src/copy.c (copy_internal): cp -RL would fail when encountering
526 the same directory more than once in the hierarchy beneath a single
527 command-line argument. That is legitimate, e.g. when there are
528 two or more symbolic links, each pointing to some directory that
529 would not otherwise be copied. Reported by Christophe LYON.
530 * tests/cp/cp-deref: New file. Test for today's fix.
531 * tests/cp/Makefile.am (TESTS): Add cp-deref.
532 * NEWS: Document this.
534 2006-02-03 Jim Meyering <jim@meyering.net>
536 * configure.ac: Require automake-1.9.6, not 1.8.3.
538 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
540 * src/od.c (usage): Mention that -t a ignores high order bit.
541 Documentation problem reported by Ed Avis.
543 2006-02-01 Jim Meyering <jim@meyering.net>
545 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
547 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
549 * src/head.c (main): Use a better diagnostic when someone uses a
550 trailing numeric option in an invalid way. Problem reported by
552 * src/tail.c (parse_options): Likewise.
554 2006-01-30 Jim Meyering <jim@meyering.net>
556 * man/wc.x: Include `count' keyword in man page synopsis,
557 per suggestion from http://bugs.debian.org/181585.
559 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
561 * src/df.c (show_dev): If the file system claims to have
562 more available than total blocks, report the number of used
563 blocks as being total - available (a negative number) rather
564 than as garbage. Problem reported by Toralf Foerster.
566 2006-01-24 Jim Meyering <jim@meyering.net>
568 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
569 to put a regular file in O_NONBLOCK mode fails with EPERM.
570 That happens on Linux (up to 2.6.15) when using tail -f on a file with
571 the append-only attribute. Reported by Dean Gaudet. For details,
572 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
573 * NEWS: Mention this fix.
574 * tests/tail-2/append-only: New file. Test for the above.
575 * tests/tail-2/Makefile.am (TESTS): Add append-only.
576 * tests/Makefile.am (check-root): Add tail-2/append-only
578 2006-01-21 Jim Meyering <jim@meyering.net>
580 * NEWS: Mention fts-related improvements and bug fixes.
582 2006-01-19 Jim Meyering <jim@meyering.net>
584 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
585 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
587 2006-01-18 Jim Meyering <jim@meyering.net>
589 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
591 2006-01-17 Jim Meyering <jim@meyering.net>
593 Now that fts no longer changes the current working directory, adjust
594 its clients accordingly -- note that du.c uses fts but doesn't need
595 any adjustment, since it doesn't operate on the actual files,
596 but rather just uses the stat buffers provided by fts.
598 * src/chown-core.c: Include "openat.h".
599 Don't include "lchown.h".
600 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
601 calling openat, lchownat, chownat, rather than open, lchown, chown.
603 * src/chmod.c: Include "openat.h".
604 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
606 * tests/du/long-from-unreadable: New test, to exercise one small
609 2006-01-13 Jim Meyering <jim@meyering.net>
611 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
612 addition of new directories under tests/.
614 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
617 2006-01-12 Jim Meyering <jim@meyering.net>
619 * tests/du/long-sloop: Adjust not to hard-code the expected
620 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
621 from that of GNU libc. Reported by Paul Eggert.
623 * tests/du/long-sloop: Create file at end of symlink chain.
625 * tests/misc/test: New file, with a test for one of the
626 bugs fixed by yesterday's test.c changes.
627 * tests/misc/Makefile.am (TESTS): Add test.
629 2006-01-11 Jim Meyering <jim@meyering.net>
631 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
632 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
633 a very long sequence of symbolic links (not necessarily a loop).
634 * tests/du/Makefile.am (TESTS): Add long-sloop.
636 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
638 * src/test.c (test_syntax_error): Append a newline. All callers
639 changed, except for the ones that didn't already append a newline.
640 Bug reported by Eric Blake.
642 2006-01-11 Jim Meyering <jim@meyering.net>
644 * src/system.h (X2NREALLOC): Now that verify_true is no longer
645 void, cast its result to void, to avoid gcc's warning that
646 ``left-hand operand of comma expression has no effect''.
647 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
649 2006-01-10 Jim Meyering <jim@meyering.net>
651 * tests/chmod/no-x: Add a test for today's fts.c fix.
653 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
655 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
656 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
658 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
660 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
661 Use verify_true instead of verify_expr, to sync with gnulib.
663 2006-01-08 Jim Meyering <jim@meyering.net>
665 * src/date.c (usage): Adjust the formatting of the entries for
666 %::z and %:::z (separate with two spaces, not one) so that help2man
667 formats them properly. Reported by Philip Rowlands.
669 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
671 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
673 2006-01-06 Jim Meyering <jim@meyering.net>
675 * Makefile.maint (copyright-check): Use date +%Y in place of
678 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
679 First off, the attribute should have been `volatile' (not static)
680 to avoid longjmp-related risk of clobber. Secondly, now there is
681 no longer any risk of a local variable being clobbered, so there's
682 no need for any attribute at all.
684 2006-01-05 Jim Meyering <jim@meyering.net>
686 * src/remove.c: Give a few functions the inline attribute.
687 (AD_pop_and_chdir): Use gotos to avoid some duplication.
688 (AD_push): Rewrite an assertion so that the entire computation
689 goes away when assertions are turned off.
691 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
692 It's already defined in "system.h".
693 * Makefile.maint: Add a FIXME comment.
695 2006-01-04 Jim Meyering <jim@meyering.net>
697 * ChangeLog: Remove entries from 2005-10-22 and earlier.
698 * ChangeLog-2005: New file, for entries up to version 5.92.
700 2006-01-03 Jim Meyering <jim@meyering.net>
702 * tests/du/no-x: Also allow a slightly different diagnostic -- the
703 one you get when using openat-enabled fts.c and du (coming soon).
704 * tests/chmod/no-x: Likewise.
705 * tests/chgrp/no-x: Likewise.
707 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
709 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
711 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
712 (restricted_chown): Return it, if the file cannot be accessed due
713 to EPERM, or if no uid or gid are required, or if the file is
714 neither a directory nor a regular file. Rewrite to avoid gotos.
715 (change_file_owner): Handle RC_do_ordinary_chown case.
716 Rewrite to avoid gotos.
717 * tests/chgrp/basic: Make sure we can change the group of
720 * src/date.c (usage): Explain %g, %G, and %V a bit better.
722 2006-01-02 Jim Meyering <jim@meyering.net>
724 * src/copy.c (set_owner): Correct a comment.
726 * src/tail.c (parse_options): Change warning to say that --retry
727 is useful `mainly' (not `only') when following by name.
728 Reported here: http://bugs.debian.org/273781
730 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
732 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
733 * src/copy.c: Include lchmod.h.
734 (copy_internal): Use lchmod rather than chmod.
735 * src/cp.c: Include lchmod.h.
736 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
737 * src/mkdir.c: Include lchmod.h.
738 (usage): Clarify -m's operation.
739 (main): Use lchmod rather than chmod. Don't use lchmod unless the
740 new mode contains bits outside the 777 range.
741 * src/mkfifo.c (usage): Clarify -m's operation.
742 (main): If -m is given, don't invoke chmod; use umask 0 instead.
743 Report an error if -m asks for bits outside the 777 range.
744 * src/mknod.c (usage, main): Likewise.
746 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
748 2005-12-27 Jim Meyering <jim@meyering.net>
750 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
751 (sc_prohibit_assert_without_use): New rule.
752 (syntax-check-rules): Add it to the list.
753 * .x-sc_prohibit_assert_without_use: New empty file.
754 * Makefile.am (EXTRA_DIST): Add it.
756 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
758 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
759 Don't include <assert.h>; it wasn't used.
761 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
763 * src/chown-core.c (restricted_chown):
764 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
765 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
766 | O_NOFOLLOW too, for consistency with other dir-openers.
767 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
768 (is_empty_dir): Likewise.
769 * src/shred.c (wipename): Likewise. Don't bother trying to open
770 dir for writing, since POSIX prohibits it.
772 2005-12-22 Jim Meyering <jim@meyering.net>
774 * tests/help-version: Redirect stderr to /dev/full, to suppress
775 write error diagnostic.
777 2005-12-19 Jim Meyering <jim@meyering.net>
779 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
780 Avoid a minor race condition when `-m MODE' is specified, by using
781 open, fchown, and close rather than just chown. To do that reliably --
782 even with an overly restrictive umask -- ensure that each mkdir,
783 mknod and mkfifo call uses a mode including at least owner-read access.
784 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
785 the subsequent chown (or equivalent open,fchown,close) fails.
786 * tests/misc/mknod: New tests.
787 * tests/misc/Makefile.am (TESTS): Add mknod.
789 2005-12-17 Jim Meyering <jim@meyering.net>
791 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
792 e.g., on a named pipe.
793 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
794 place of all uses, since it is guaranteed (system.h) to be defined.
796 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
798 Add POSIX ACL support
799 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
800 is no requirement for ACL support; particularly, it does not exist
801 on systems that have POSIX ACLs.
802 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
803 * src/cp.c (umask_kill): With default acls, the umask is not to be
804 applied. Remove umask_kill, don't change the process umask, and let
805 the kernel apply the umask where appropriate.
806 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
807 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
809 (copy_reg, copy_internal): Use copy_acl and set_acl
810 instead of fchown/chown. Fix the logic for POSIX ACLs.
811 (chown_succeded): Remove; we now always copy acls and
812 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
813 did a chown before or not.
814 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
815 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
816 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
817 to link with it via $(LIB_ACL), for the utilities that need it.
819 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
821 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
822 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
823 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
824 value is now signified by whether cwd_errno is null.
825 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
826 pointer-to-bool to pointer-to-errno-value. All callers changed.
827 (rm_1): Don't bother setting a local cwd failure flag and then
828 ORing it into the caller's. Just set the caller's.
829 (rm): Use cwd failure errno value to print a slightly-better
832 2005-12-15 Jim Meyering <jim@meyering.net>
834 * src/stat.c (print_it): Properly handle a backslash at the
835 end of a --printf format string. Reported by Paul Eggert.
836 * tests/misc/stat-printf (end-bs): Add a test for the above.
838 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
840 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
841 Don't assume /etc/passwd contains user names; use 'id' instead.
843 2005-12-15 Jim Meyering <jim@meyering.net>
845 stat: revert behavior of --format=FMT (-c)
846 stat: add new option: --printf=FMT
847 * NEWS: Mention this.
848 * src/stat.c (isodigit, octtobin, hextobin): Define.
849 (PRINTF_OPTION): Define.
850 (interpret_backslash_escapes, trailing_delim): New globals.
851 (usage): Document them. Alphabetize on long option names.
852 (print_esc_char): New function.
853 (print_it): Rewrite, in order to handle backslash escapes.
854 (main): Handle new option. Set globals for --format, too.
856 * tests/misc/stat-printf: Test --printf and --format.
857 * tests/misc/Makefile.am (TESTS): Add stat-printf.
859 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
861 * NEWS: sort now reports incompatible options.
862 * src/sort.c (incompatible_options, check_ordering_compatibility):
864 (main): Use them. Don't bother with a usage message for
865 "sort -c a b", for consistency with other error diagnostics.
866 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
869 * src/cat.c (main): Undo previous change. close_stdout already
870 does the check, so the previous change wasn't necessary.
872 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
874 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
876 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
878 Install a more-conservative approach for sort -R. It's the
879 same basic idea as the existing code, except it uses the full ISAAC
880 approach (called the "more kosher" approach in the existing comments).
881 This makes "sort -R" quite a bit slower (about a factor of 2 on my
882 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
883 better to be conservative here at first, and review any performance
884 improvements carefully.
885 * .x-sc_require_config_h: Add src/rand-isaac.c.
886 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
887 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
888 (shred_SOURCES, sort_SOURCES): Remove.
889 (EXTRA_DIST): Add rand-isaac.c.
890 * src/rand-isaac.c: Revert to what used to be in shred.c, without
891 changing it to allow for varying numbers of words in the state.
892 Alter so that we include rand-isaac.c directly rather than
893 compiling it and linking to it. Don't include config.h or
894 system.h; that's the includer's responsibility.
895 Omit functions that are specific to shred.
896 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
897 (isaac_step, struct irand_state):
898 Resurrect these, with the same defns that used to be in shred.c.
899 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
900 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
902 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
903 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
904 (irand_init, irand32, irand_mod):
905 Number of words is constant again.
906 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
907 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
908 * src/sort.c: Likewise.
909 * src/shred.c (fillrand, dopass, main): Undo previous change.
910 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
912 * src/sort.c: Don't include md5.h; it wasn't needed.
913 (struct keyfield): Rename random_hash to random, for consistency
914 with the other member names. All uses changed.
915 (usage): Tweak wording to mention STRING for --seed option.
916 (short_options): Rorder for consistency with other programs.
917 (rand_state): Now a struct, not a pointer to one. All uses changed.
918 (HASH_WORDS, HASH_SIZE): Remove.
919 (get_hash): Remove comments around resbuf size, since we can assume C89.
920 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
921 (keycompare): Adjust to the new get_hash.
923 (badfieldspec): Omit recently-introduced comment; it isn't needed.
924 (main): Don't set need_random simply because gkey has it set; that
925 doesn't necessarily mean we'll need random numbers.
926 Redo seeding to match new get_hash approach.
928 2005-12-10 Jim Meyering <jim@meyering.net>
930 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
932 Avoid shred segfault on 64-bit systems.
933 * src/rand-isaac.c (isaac_refill): Don't try to negate a
934 local of type uint32_t. Make the local an `int' instead.
936 * NEWS: Mention sort's new options.
938 * src/rand-isaac.c (isaac_mix): Declare to be static.
939 Mark all other functions as `extern' so the tight-scope
940 part of `make distcheck' passes once again.
941 * src/rand-isaac.h (isaac_mix): Remove declaration.
943 * src/sort.c (get_hash): Change position of `*' in parameter
944 type to conform with convention.
945 (main): Split a long line so it fits in 80 columns.
946 (keycompare): Remove stray SPACE before TAB that was
947 causing `make distcheck' to fail.
949 * src/shred.c: Don't include gethrxtime.h. No longer needed.
951 * tests/misc/sort-rand: New file: basic tests for the new options.
952 * tests/misc/Makefile.am (TESTS): Add sort-rand.
954 2005-12-10 Frederik Eaton <frederik@ofb.net>
956 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
957 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
958 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
959 Make state size runtime-configurable.
960 (isaac_new, isaac_copy): New functions.
961 * src/rand-isaac.h: New file.
962 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
963 (fillrand, main): Adjust to the fact that the state size is now
964 runtime-configurable.
965 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
966 (usage): Add options --random-sort and --seed to implement a random
968 Include md5.h and rand-isaac.h.
969 (get_hash): New function.
970 (rand_state): New var.
971 (HASH_WORDS, HASH_SIZE): New macros.
973 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
975 * tests/dd/misc: Add test for dd iflags=noatime.
977 2005-12-09 Jim Meyering <jim@meyering.net>
979 * src/sort.c (usage): Mention white space vs -b and -t options.
982 2005-12-09 Eric Blake <ebb9@byu.net>
984 * src/test.c (main): Fix misleading comment.
986 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
988 * NEWS: Mention dd's new noatime flag.
989 * src/system.h (O_NOATIME): Define to 0 if not already defined.
990 * src/dd.c (flags, usage): Add support for noatime flag.
992 2005-12-07 Jim Meyering <jim@meyering.net>
994 Distribute the cvsu script, used only by `make syntax-check'.
995 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
996 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
997 distribute a copy of this script.
998 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1000 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1001 to create a temporary directory on another partition.
1002 From Andreas Gruenbacher.
1004 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1006 * man/basename.x: Cross-reference to dirname and readlink.
1007 * man/dirname.x: Cross-reference to basename and readlink.
1009 2005-12-05 Andreas Gruenbacher
1011 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1012 (set_owner, preserve_author): New functions, factored out of copy_reg.
1013 (copy_reg): Use them.
1014 (copy_internal): Use them here, too.
1016 2005-12-04 Jim Meyering <jim@meyering.net>
1018 * src/sleep.c (usage): Say what happens with two or more arguments.
1019 Suggested by Justin Pryzby.
1021 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1024 2005-12-03 Jim Meyering <jim@meyering.net>
1026 * src/rm.c (long_opts): Change the name of each undocumented, for-
1027 testing-only option to start with `-', so that it cannot render
1028 ambiguous any prefix it happens to share with some other option name.
1029 Problem reported by Eric Blake.
1030 * src/head.c (long_options): Likewise.
1031 * src/tail.c (long_options): Likewise.
1033 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1034 testing-only --presume* options to start with `---'.
1035 * tests/rm/dangling-symlink: Likewise.
1036 * tests/rm/dir-no-w: Likewise.
1037 * tests/rm/isatty: Likewise.
1039 2005-11-30 Jim Meyering <jim@meyering.net>
1041 * Makefile.maint: Add a comment about cvsu.
1043 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1045 * NEWS: df updates for "none", "proc", inaccessible file systems.
1046 * src/df.c (show_point): Ignore inaccessible file systems.
1047 (usage): -a includes dummy file systems, not size-0 file systems.
1049 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1050 to avoid collision with POSIX name space. All uses changed.
1052 2005-11-24 Jim Meyering <jim@meyering.net>
1054 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1055 * tests/acl: Add `$0: ' prefix to diagnostics.
1057 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1059 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1061 * src/copy.c: Improve performance a bit by optimizing away
1062 unnecessary system calls and going to a block size of at least
1063 8192 (on normal hosts, anyway). This improved performance 5% on my
1064 Debian stable host (2.4.27 kernel, x86, copying from root
1065 ext3 file system to itself).
1066 Include "buffer-lcm.h".
1067 (copy_reg): Omit last argument. All callers changed.
1068 Use xmalloc to allocate rather than trusting alloca
1069 (which is unwise with large block sizes).
1070 Declare locals more locally, if possible.
1071 Use uintptr_t words instead of int words, for a bit more speed
1072 when looking for null blocks on 64-bit hosts.
1073 Optimize away reads of zero bytes on regular files.
1074 In the typical case, insist on 8 KiB buffers, at least.
1075 Avoid unnecessary extra call to fstat when checking for sparse files.
1076 Avoid now-unnecessary cast to off_t, and "0L".
1077 Avoid unnecessary test of *new_dst when checking for same owner
1080 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1082 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1084 2005-11-22 Jim Meyering <jim@meyering.net>
1086 * src/remove.c (AD_push): Remove debugging cruft.
1088 * tests/rm/unread2 (rm): Change expected diagnostic,
1089 `cannot open directory' to `cannot remove', to align with
1091 * tests/rm/rm2: Ensure that rm now continues removing entries
1092 even after certain types of failure.
1094 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1095 that provide openat (Solaris), and on systems like Linux+procfs
1096 where our openat emulation code is reentrant. This also fixes a
1097 few low-probability leaks and eliminates some code that could,
1098 in very unusual circumstances, cause rm() (via a callee) to exit.
1099 * NEWS: Mention this.
1101 * configure.ac: Put copyright dates all on one line so the
1102 emacs function that updates them works properly.
1104 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1106 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1107 Problem reported by Eric Blake.
1108 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1109 we get a standard-conforming compiler. This relies on the new
1110 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1111 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1112 m4/c.m4 can go away with Autoconf 2.60 comes out.
1114 2005-11-17 Jim Meyering <jim@meyering.net>
1116 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1117 (AD_mark_current_as_unremovable): Likewise, but for a local.
1120 * tests/mv/acl: Let traps handle removing temporary directories.
1122 Expect acl-related tests to fail, until the corresponding
1123 patches are committed.
1124 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1125 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1127 ACL tests, from Andreas Gruenbacher.
1128 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1129 * tests/mv/Makefile.am (TESTS): Add acl.
1130 * tests/cp/Makefile.am (TESTS): Add acl.
1132 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1134 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1136 * NEWS: Improve quality of ln's diagnostics.
1137 * src/ln.c (do_link, usage): Likewise.
1138 (do_link): Don't use alloca on a buffer of unbounded size.
1140 2005-11-16 Jim Meyering <jim@meyering.net>
1142 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1143 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1144 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1146 2005-11-14 Jim Meyering <jim@meyering.net>
1148 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1150 2005-11-13 Jim Meyering <jim@meyering.net>
1152 * announce-gen: Accept new option, --gpg-key-id=ID and
1153 emit a blurb telling how to use the .sig files.
1154 * Makefile.cfg (gpg_key_ID): Define.
1155 * Makefile.maint (announcement): Use new option and key.
1157 Require that most .c files include <config.h>.
1158 * Makefile.maint (sc_require_config_h): New rule.
1159 (syntax-check-rules): Add it.
1160 * .x-sc_require_config_h: New file listing exceptions to the
1161 above rule. Some are legit, others are simply grandfathered in.
1162 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1164 2005-11-12 Jim Meyering <jim@meyering.net>
1166 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1168 2005-11-11 Jim Meyering <jim@meyering.net>
1170 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1171 Mention new readlink options in 5.3.0's `New features' section.
1172 Spotted by Thomas Hood.
1174 2005-11-08 Jim Meyering <jim@meyering.net>
1176 * NEWS: Merge in changes from b5_9x branch.
1178 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1180 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1181 like --time-style='posix-long-iso' if the locale settings are messed up.
1182 * src/ls.c (decode_switches): Implement this.
1184 2005-11-08 Jim Meyering <jim@meyering.net>
1186 * tests/du/2g: s/expensive/very expensive/ in a comment.
1189 2005-10-17 Eric Blake <ebb9@byu.net>
1191 * src/ls.c (usage): Fix descriptions of --sort, --time.
1192 Reported by Vitaly A. Ostanin.
1194 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1196 * src/ln.c: Include filenamecat.c.
1197 (FILE_BASENAME_CONCAT): Remove.
1198 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1199 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1200 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1203 2005-11-04 Jim Meyering <jim@meyering.net>
1205 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1206 on systems with stat.st_blocks of a signed 32-bit type.
1207 This bug causes trouble on some AIX 5.1 systems.
1208 Report and trivial patch from Paul Townsend:
1209 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1210 * NEWS: Mention this.
1212 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1213 * tests/du/Makefile.am (TESTS): Add it here.
1214 * tests/very-expensive: New file.
1215 * tests/Makefile.am (EXTRA_DIST): Add it here.
1216 * tests/cp/perm: Mark this test as `very-expensive', too.
1218 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1220 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1222 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1224 * src/rm.c (usage): Don't mention rm -d.
1226 2005-11-02 Jim Meyering <jim@meyering.net>
1228 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1229 From Andreas Schwab.
1231 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1232 `M+N records in/out' lines don't pollute `make check' output.
1234 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1235 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1236 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1237 to indicate that the input file should be piped into the command
1238 under test (via `cat FILE | $prog ...').
1240 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1241 (without -r) fails to remove a directory on a non-Linux system.
1242 This change affects only newer Solaris systems (with priv_*
1243 functions like priv_allocset). Reported by Keith Thompson.
1245 * tests/rm/dir-nonrecur: New file/test for the above fix.
1246 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1248 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1250 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1251 POSIX 1002.1-2001 requires.
1252 * src/tail.c (parse_obsolete_option): Implement this.
1253 Problem reported by Vincent Lefevre.
1254 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1255 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1256 (test_vector): Add special cases for _POSIX2_VERSION, and
1257 regularize the old ones a bit.
1258 * tests/touch/obsolescent: Add y2000 test.
1260 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1262 * src/dd.c (skip): Fix off-by-one error reported by
1263 Theodoros V. Kalamatianos.
1265 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1267 * tests/mkdir/p-3: Require that the test be run as non-root.
1268 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1270 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1272 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1273 boundary between DEST and SOURCE in the result.
1275 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1277 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1278 back to text, to sync with documentation and for backwards
1281 2005-10-25 Jim Meyering <jim@meyering.net>
1283 * tests/dircolors/simple (other-wr): Add an explicit test for
1284 the dircolors bug (NULL-dereference) fixed yesterday.
1286 2005-10-24 Jim Meyering <jim@meyering.net>
1288 * src/tac.c (tac_file): When determining whether a file is seekable,
1289 also test whether it is a tty. Using only the lseek-based test would
1290 give a false positive on Solaris. Reported by Peter Fales.
1292 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1294 * tests/install/d-slashdot: New test, for "install -d" failure.
1295 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1296 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1297 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1299 2005-10-24 Jim Meyering <jim@meyering.net>
1301 * src/dircolors.c (ls_codes): Add missing comma.
1302 Anonymous report and patch from
1303 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1305 * src/dircolors.c: Add compile-time assertion that the slack_codes
1306 and ls_codes arrays have the same number of elements. This would
1307 have prevented the above-fixed bug.
1309 * src/expand.c (parse_tab_stops): Add a comment to make this function
1310 identical to the one in unexpand.c.
1311 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1312 identical to the one in expand.c.
1314 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1316 2005-10-23 Jim Meyering <jim@meyering.net>
1318 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1319 a dangerous pointer-value-to-`unsigned' cast.
1320 * NEWS: mention the new sha* programs.
1321 * AUTHORS: Add new sha* programs.
1323 2005-08-28 David Madore <david.madore@ens.fr>
1325 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1326 * README: Add their names to the list.
1327 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1328 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1329 Rules for compiling sha-2 utilities
1330 (noinst_HEADERS): Remove checksum.h.
1331 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1333 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1334 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1335 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1336 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1337 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1338 sha384sum, sha512sum test scripts here rather that each in its
1341 2005-08-28 David Madore <david.madore@ens.fr>
1343 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1344 of the FIPS test vectors).
1346 2005-10-23 Jim Meyering <jim@meyering.net>
1348 * configure.ac: Use 6.0-cvs as the version string.
1349 * NEWS: Adjust accordingly.