1 2006-07-21 Jim Meyering <jim@meyering.net>
3 * src/su.c (usage): Correct typo in --help output: s/commmand/command/
5 Also remove the comment duplicating much of --help output.
7 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): Reposition this new
8 name so the list remains alphabetized.
10 Fix another bug: ls --indicator-style=file-type would call
11 stat for a symlink, even though it wasn't always needed.
12 In some cases, that unnecessary stat would cause ls to fail.
13 * src/ls.c (gobble_file): Don't treat symlinks specially (in
14 requiring a stat syscall). Remove the offending exclusion.
16 * NEWS: Mention the fix.
18 * tests/ls/stat-dtype: New file/test, for the above fix.
19 Also exercises the new df feature, below.
21 * src/df.c (main): Fail and don't print the headers if no
22 file system is processed. This makes it easy to test whether
23 a specified directory is on a file system of a given type or types.
24 Otherwise, applications would have had to parse df's output.
25 E.g., is "." either ext3 or reiserfs: df -t ext3 -t reiserfs .
27 Fix a bug: ls --file-type worked like --indicator-style=slash,
28 rather than like --indicator-style=file-type.
29 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): New enum member.
30 (long_options): Map "file-type" to FILE_TYPE_INDICATOR_OPTION,
32 (decode_switches): Handle new case: FILE_TYPE_INDICATOR_OPTION.
33 * NEWS: Mention the fix.
34 * tests/ls-2/tests (file-type): New test, for the above fix.
36 2006-07-19 Jim Meyering <jim@meyering.net>
38 * src/ls.c (print_dir): Give a better diagnostic for failed opendir.
40 * Makefile.am (EXTRA_DIST): Add build-aux/vc-list-files.
42 2006-07-16 Paul Eggert <eggert@cs.ucla.edu>
44 * NEWS: chmod, install, and mkdir now leave setgid and setuid bits
45 of directories alone unless you specify them explicitly.
46 install and mkdir now implement X correctly.
47 install now creates parent directories with mode 755, without
48 changing their owner or group.
49 * src/chmod.c (process_file): Adjust to mode_adjust API change.
50 * src/install.c: Include mkancesdirs.h.
51 (announce_mkdir, make_ancestor): New functions.
52 (DEFAULT_MODE): New macro, specifying initial value of 'mode'.
54 (dir_mode, dir_mode_bits): New vars.
55 (main): Set dir modes separately from nondir, so that the X
56 op of -m works correctly.
57 (main): Remove cwd_errno cruft, since make_dir_parents no longer
58 affects cwd. Adjust to new make_dir_parents API.
59 (install_file_in_file_parents): 2nd arg is now char *, not char
60 const *. Use mkancesdirs instead of rolling our own code.
61 (change_attributes): Don't worry about AFS, since that kludge
62 should not be needed any more.
63 * src/mkdir.c (struct mkdir_options): New struct.
64 (announce_mkdir, make_ancestor): New functions.
65 (main): Use them. Adjust to mode_adjust API change. Stick with
66 umask 0. Use make_dir_parents for all the work.
67 * src/mkfifo.c (main): Adjust to new mode_adjust API.
68 * src/mknod.c (main): Likewise.
69 * tests/chmod/setgid: Do the setgid test instead of bailing.
70 * tests/mkdir/p-3: Remove re_protect case that no longer applies.
71 GNU chmod now behaves like other versions of chmod.
72 * tests/mkdir/perm: Add a test for the X bug.
74 2006-07-14 Paul Eggert <eggert@cs.ucla.edu>
76 * src/base64.c (do_decode): Output to parameter OUT, not to stdout.
77 This doesn't fix any bugs, since OUT always equals stdout, but it
78 makes the code easier to understand.
80 2006-07-14 Jim Meyering <jim@meyering.net>
82 * Makefile.maint (CVS_LIST): Use new file, build-aux/vc-list-files,
83 rather than open-coding it. Now supports mercurial, too.
84 * .hgignore: New file.
85 * Makefile.am (EXTRA_DIST): Add .hgignore, which ignores nearly
86 all generated files, including ones like configure and po/*.po
87 that are currently version-controlled in cvs.
89 * Makefile.am (EXTRA_DIST): Add a few more .??* files.
90 They've been in CVS, just haven't been distributed before this.
91 Distribute ChangeLog-2005, too.
92 (MAINTAINERCLEANFILES): Add THANKS-to-translators.
94 2006-07-11 Paul Eggert <eggert@cs.ucla.edu>
96 * src/system.h: Assume <dirent.h> exists, since gnulib assumes
99 2006-07-09 Jim Meyering <jim@meyering.net>
101 * tests/mv/dir2dir: Adjust so failing with ENOTEMPTY is ok, too.
102 That happens with Linux/tmpfs.
103 * tests/mv/Makefile.am (TESTS): Add dir2dir.
105 2006-07-09 Paul Eggert <eggert@cs.ucla.edu>
107 Adjust to recent updates from gnulib.
108 * src/dd.c (apply_translations): Use toupper rather than
109 islower followed by toupper; it's simpler and typically
110 faster now that we assume at least C89 semantics. Similarly
112 * src/sort.c (inittables): Likewise.
113 * src/expand.c (expand): Don't assume that isprint etc. return
114 booleans (needed for pre-C99 hosts).
115 * src/fmt.c (check_punctuation): Likewise.
116 * src/ptx.c (initialize_regex, fix_output_parameters): Likewise.
117 * src/tr.c (is_char_class_member): Likewise.
118 * src/unexpand.c (unexpand): Likewise.
119 * src/join.c (is_blank): Remove; no longer needed. All uses
120 replaced by isblank (to_uchar (...)).
121 * src/pinky.c (create_fullname): Don't assume char is unsigned.
122 * src/printf.c (print_esc): Likewise.
123 * src/ptx.c (SKIP_NON_WHITE, SKIP_WHITE, SKIP_WHITE_BACKWARDS):
124 (copy_unescaped_string): Likewise.
125 * src/stat.c (print_it): Likewise.
126 * src/system.h (_D_EXACT_NAMELEN): Renamed from NLENGTH, for
127 convenience on GNU systems. All uses changed. Don't bother
128 looking for any dirent.h substitute other than ndir.h.
129 (D_INO): Remove unnecessary parentheses.
130 (IN_CTYPE_DOMAIN, ISGRAPH, ISPRINT, ISALNUM, ISALPHA):
131 (ISCNTRL, ISLOWER, ISPUNCT, ISSPACE, ISUPPER, ISXDIGIT):
132 (ISDIGIT_LOCALE, TOLOWER, TOUPPER): Remove. All uses changed
133 to ctype.h equivalents.
134 (isblank): Renamed from ISBLANK. Check for HAVE_DECL_ISBLANK too.
137 2006-07-08 Jim Meyering <jim@meyering.net>
139 * tests/mv/dir2dir: New file, test for 2006-07-05 fix in copy.c.
141 * Makefile.maint (sc_the_the): New rule.
143 * src/dd.c (skip): Remove one of two adjacent "the"s in a comment.
144 * tests/Coreutils.pm (run_tests): Remove one of two adjacent "then"s
147 2006-07-07 Jim Meyering <jim@meyering.net>
149 * NEWS: Mention that mv can now remove an empty destination directory,
150 and give an example. Prompted by a report from Florent Bayle.
152 2006-07-05 Jim Meyering <jim@meyering.net>
154 * src/ls.c (usage): Correct the description of -G: it is useful
155 only in a long listing. Reported by Martin Pool in
156 <https://launchpad.net/distros/ubuntu/+source/coreutils/+bug/51653>.
158 * man/chmod.x: Correct the description of the sticky bit. Reported
159 by Chris Moore via Ian Jackson in <http://bugs.debian.org/376745>.
161 * src/copy.c (copy_internal): Don't work around old NFS clients like
162 SunOS-4.1.4 and Irix 5.3 that set errno to values like EIO and
163 ENOTEMPTY upon failed rename. Otherwise, we risk misinterpreting
164 a banal failure as a recursive move-into-self failure.
165 Reported by Florent Bayle in <http://bugs.debian.org/376749>.
167 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
169 2006-07-03 Jim Meyering <jim@meyering.net>
171 Plug another unusual leak.
172 (AD_mark_helper): Free malloc'd filename if hash_insert says
173 that string is already in the hash table.
175 The dev/inode of the topmost directory in each hierarchy were not
177 * src/remove.c (remove_cwd_entries): Don't call cycle_check here.
178 (AD_push): Call it from here instead.
181 * src/remove.c (AD_stack_clear): New function.
183 (AD_pop_and_chdir): Free *prev_dir just before longjmp.
185 * tests/Makefile.am, tests/*/Makefile.am: (TESTS_ENVIRONMENT):
186 Add $VG_PATH_PREFIX as a prefix to $PATH
188 * tests/envvar-check (vars): Add CDPATH and POSIXLY_CORRECT.
189 * tests/Makefile.am (evar-check): Remove rule.
190 (EXTRA_DIST): Remove .env-warn.
191 * tests/.env-warn: Remove file. No longer used.
192 Suggestion from Eric Blake.
194 2006-07-02 Paul Eggert <eggert@cs.ucla.edu>
196 * src/system.h: Include <stdint.h> unconditionally, since we
197 now assume the stdint module.
199 2006-07-01 Paul Eggert <eggert@cs.ucla.edu>
201 * NEWS: With no operand, 'tail -f' now silently ignores the '-f'
202 only if standard input is a FIFO or pipe and POSIXLY_CORRECT is set.
203 * src/tail.c (main): Implement this.
204 * tests/tail/Test.pm (f-pipe-1): Renamed from f-1.
205 (test_vector): Set POSIXLY_CORRECT for the f-pipe-* tests.
207 2006-07-01 Jim Meyering <jim@meyering.net>
209 * src/ln.c (do_link): Use new, shorter URL, for ag-review link.
211 * .x-sc_require_config_h: Add ^lib/xstrtold\.c$, so make distcheck
214 2006-06-30 Paul Eggert <eggert@cs.ucla.edu>
216 * NEWS: seq now uses long double internally rather than double.
217 It now defaults to a minimal fixed point format if possible.
218 It lets you use %a, %A, %E, %F, %G.
219 * src/Makefile.am (seq_LDADD): Remove $(SEQ_LIBM); add $(POW_LIB).
220 * src/seq.c: Don't include <math.h> or <xstrtol.h>; no longer needed.
221 (isfinite) [!defined isfinite]: New macro.
222 (separator, terminator): Now points to const.
223 (first, step, last): Remove.
224 (usage): Update to match new behavior.
225 (struct operand, operand): New type.
226 (scan_arg): Renamed from scan_double_arg, since we no longer use double.
228 Compute and return a value of type operand, not double.
229 (long_double_format): Renamed from valid_format, and now returns a
230 new format with an "L" added if needed, if the original format was
231 valid. Allow %a, %A, %E, %F, and %G formats.
232 (print_numbers): Take numeric values as args rather than from globals.
233 Print long double, not double.
234 (get_width_format): Remove.
235 (get_default_format): New function.
236 (main): Implement new way of calculating default format.
237 Don't worry about locale's representation of the decimal point, since
238 the arguments are always processed in the C locale.
239 * tests/seq/basic (neg-2): Adjust to new default format.
240 (eq-wid-1, eq-wid-2): Resurrect these tests, since the new
241 implementation should do the right thing.
243 2006-06-30 Jim Meyering <jim@meyering.net>
245 * tests/stty/basic-1: Work around an intermittent test failure
246 on HP-UX 11.11. Report and analysis from Bob Proulx.
247 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7475
249 2006-06-28 Paul Eggert <eggert@cs.ucla.edu>
251 * NEWS: Support obsolete usages like "sort +1 -2" even when
252 conforming to POSIX 1003.1-2001, since this is a pure extension to
253 POSIX. Problem reported by Christian in:
254 http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00220.html
255 * src/sort.c (main): Implement this.
257 * src/system.h (CLOSEDIR): Remove. All uses changed to closedir.
258 Autoconf 2.60 says this stuff was obsolete.
260 2006-06-28 Jim Meyering <jim@meyering.net>
262 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
264 2006-06-28 Bob Proulx <bob@proulx.com> (tiny change)
266 * tests/mv/i-link-no: Work around HP-UX /bin/sh tracing problem
267 (set -x when VERBOSE=yes) when stderr is redirected before stdout
268 causing shell tracing of the stdout redirection to be written to
269 the stderr file. Avoid problem and test failure on HP-UX by
270 redirecting stderr last.
271 * tests/dd/unblock-sync: Order shell file redirections for
272 stderr and stdout in the common style.
275 2006-06-27 Jim Meyering <jim@meyering.net>
277 * tests/misc/cat-proc: Try to avoid any spurious numeric
278 differences in frequently-changing /proc/cpuinfo.
279 Reported by Nelson Beebe.
281 2006-06-26 Jim Meyering <jim@meyering.net>
283 Attempt rmdir (actually, unlinkat-with-AT_REMOVEDIR) upon any
284 fd_to_subdirp failure, not just when errno == EACCES.
285 * src/remove.c (remove_dir): Use unlinkat-with-AT_REMOVEDIR, not
286 rmdir, here, even though rmdir may happen to be adequate.
288 * NEWS: rm no longer fails to remove an empty, unreadable directory
289 * src/remove.c (remove_cwd_entries): If we can't open a directory,
290 and the failure is not being ignored, try to remove the directory
291 with rmdir (aka unlinkat-with-AT_REMOVEDIR), in case it's empty.
292 Problem report and test case from Paul Eggert in
293 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7425>.
295 * tests/rm/empty-inacc: New test, for the above.
297 Avoid a segfault for wc --files0=- < /dev/null.
298 * src/wc.c (compute_number_width): Return right away if nfiles == 0.
300 2006-06-25 Jim Meyering <jim@meyering.net>
302 * NEWS: wc accepts a new option --files0-from=FILE, where FILE
303 contains a list of NUL-separated file names.
305 * src/wc.c: Include "readtokens.h".
306 (usage): Describe the new option, and adjust the `Usage':
307 with this option, no FILE may be specified on the command line.
308 (main): Handle the new option.
309 * tests/misc/wc-files0: New tests, for the above.
310 * tests/misc/wc-files0-from: Likewise.
311 * tests/misc/Makefile.am (TESTS): Add wc-files0.
313 2006-06-24 Jim Meyering <jim@meyering.net>
315 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
317 2006-06-22 Jim Meyering <jim@meyering.net>
319 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
320 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
322 2006-06-19 Jim Meyering <jim@meyering.net>
324 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
325 so this check is not run as part of "make distcheck".
327 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
329 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
331 2006-06-18 Jim Meyering <jim@meyering.net>
333 * tests/misc/pwd-long: Make error output a little clearer.
335 2006-06-17 Jim Meyering <jim@meyering.net>
337 * tests/rm/inaccessible: Skip this test on systems without openat
338 support. Reported by Bob Proulx.
340 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
342 * tests/misc/mknod: Improve permission checks to handle
343 running mkdir test in set-gid directories.
345 2006-06-14 Jim Meyering <jim@meyering.net>
347 * tests/du/basic: Revamp not to hard-code file system block sizes.
349 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
351 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
354 2006-06-11 Jim Meyering <jim@meyering.net>
356 * .gitignore: New file.
357 * Makefile.am (EXTRA_DIST): Add .gitignore.
359 Setting TIME_STYLE=long-iso in the environment would make the
360 cp/same-file test fail.
361 * tests/envvar-check (vars): Add TIME_STYLE to the list.
362 * tests/cp/same-file: Revert last change.
363 Source the envvar-check script, to ensure that TIME_STYLE
364 settings don't affect these tests.
366 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
368 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
369 uses POSIX time stamp formats. Problem reported by John Nixon in
370 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
372 2006-06-10 Jim Meyering <jim@meyering.net>
374 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
376 Require a "Version N.M" line at the top of the ChangeLog
377 file only when making the actual release, not when running
379 * Makefile.maint (maintainer-distcheck): Don't depend on
381 (alpha beta major): Depend on it here, instead.
383 2006-06-08 Jim Meyering <jim@meyering.net>
385 Ensure that cat works with any of the options, -A -v -e -E -T,
386 when applied to files in /proc and /sys, even when the FIONREAD
387 ioctl produces nonsensical results. Before this change, cat would
388 produce no output (or truncated output), for some linux kernels.
390 * src/cat.c (write_pending): New function, factored out of cat.
391 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
392 that there are bytes to read. Some versions of linux-2.6.16 do that.
393 Write any pending output before returning.
394 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
395 * NEWS: Mention this bug fix.
396 * tests/misc/cat-proc: New file. Test for the above.
397 * tests/misc/Makefile.am (TESTS): Add cat-proc.
399 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
401 * src/expr.c (eval4): Detect overflow properly when multiplying
404 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
406 * NEWS: The 'expr' command now detects and reports integer overflow.
407 (It would be better to use extended precision instead, but that
409 * src/expr.c (integer_overflow): New function.
410 (eval4, eval3): Check for integer overflow.
412 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
414 Fix problems when building with Solaris/SVR4/etc. make, which uses a
415 different and somewhat bogus implementation of VPATH. In the
416 directory tests/misc, rename tests whose names might appear in the
417 Automake-generated rules. For example, we can't use a test named
418 'test', since Automake generates a rule that contains the text
419 "if test -f ./$$tst; ...", and this might expand to something like
420 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
421 which executes the 'test' script rather than the 'test' command.
422 * tests/misc/false-status: Renamed from tests/misc/false.
423 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
424 * tests/misc/sort-merge: Renamed from tests/misc/sort.
425 ($prog): Set to 'sort' rather than to $PROG.
426 * tests/misc/test-diag: Renamed from tests/misc/test.
427 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
428 in case Solaris make has prepended the directory.
429 (TESTS): Adjust to above renamings.
430 * tests/misc/expand: Don't assign to PROG; no longer needed
431 now that Makefile.am sets PROG to the basename.
432 * tests/misc/fold: Likewise.
434 2006-06-03 Jim Meyering <jim@meyering.net>
436 Make `cp --link --no-dereference' work also on systems where the
437 link system call cannot create a hard link to a symbolic link.
438 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
439 the link syscall on a symlink when it would do the wrong thing.
440 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
441 * tests/cp/link-no-deref: New file/test for the above.
442 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
443 * NEWS: Mention the change (doesn't affect Linux).
445 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
447 Fix some porting problems in the test cases reported by
448 Ralf Wildenhues for HP-UX 11.23 in:
449 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
450 * tests/help-version: Don't assume that \< \> works in sed.
451 * tests/misc/close-stdout: Don't assume that >&- works.
452 Add a /dev/full test.
453 * tests/touch/no-create-missing: Don't assume that >&- works.
455 2006-05-30 Jim Meyering <jim@meyering.net>
457 * src/ls.c (usage): Add `v' to the list of sorting-related options.
460 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
462 * tests/cp/fail-perm: source lang-default.
463 * tests/rm/inaccessible: Likewise.
465 2006-05-28 Jim Meyering <jim@meyering.net>
467 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
468 Recognize it, too. Reported by Ralf Wildenhues, in
469 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
471 2006-05-27 Jim Meyering <jim@meyering.net>
473 * src/chgrp.c: Support new options: --preserve-root and
474 --no-preserve-root. Somehow this program was skipped when those
475 options were added to chown, chmod, and rm. Reported by
476 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
477 * NEWS: Mention this.
479 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
481 * NEWS: Remove mention of --seed. We'll replace it with something
482 better, and don't want to indicate that it is supported.
483 * src/sort.c (usage): Likewise.
485 2006-05-20 Jim Meyering <jim@meyering.net>
487 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
489 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
490 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
491 FTS_COMFOLLOW. Spotted by Justin Pryzby.
493 * gnupload: Merge changes from automake, retaining the ""--to...
494 kludge to placate overzealous `make distcheck' check.
496 2006-05-19 Jim Meyering <jim@meyering.net>
498 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
499 FTS_TIGHT_CYCLE_CHECK directory traversal option.
500 Reported by Justin Pryzby in http://bugs.debian.org/367691
502 2006-05-15 Jim Meyering <jim@meyering.net>
504 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
507 2006-05-13 Jim Meyering <jim@meyering.net>
509 * tests/mv/no-target-dir: Test two more cases.
511 2006-05-11 Jim Meyering <jim@meyering.net>
513 mv -T DIR EMPTY_DIR no longer fails unconditionally
514 * src/copy.c (copy_internal): Don't manually prohibit a move where
515 the destination is an existing directory. Sometimes doing that is
516 valid. Let the rename system call enforce the rules. That is
517 allowed only when the source is a directory and the destination
518 directory (to be replaced) is empty. Reported by Eric Blake.
519 * tests/mv/no-target-dir: New file/test for this.
520 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
521 * NEWS: Mention this.
523 * tests/mv/atomic: New file/test for yesterday's fix.
524 * tests/mv/Makefile.am (TESTS): Add atomic.
526 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
528 2006-05-10 Jim Meyering <jim@meyering.net>
530 * src/copy.c (copy_internal): Don't explicitly unlink the destination
531 when moving a symlink into the place of an existing non-directory.
532 Reported by Joshua Hudson.
533 * NEWS: mention this.
535 2006-05-07 Jim Meyering <jim@meyering.net>
537 * Makefile.maint (patch-check): Fail if patch generates any output,
538 even merely for changed offsets.
540 * src/c99-to-c89.diff: Adjust to reflect new offsets.
542 * NEWS: Mention changes affecting df, pwd, shred.
544 2006-05-06 Jim Meyering <jim@meyering.net>
546 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
547 system condition where dirent.d_ino != stat.st_ino.
548 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
550 2006-05-06 Eric Blake <ebb9@byu.net>
552 * tests/ls/inode: Expand to test inode from readdir case.
553 * tests/ls/follow-slink: Expand to test broken links encountered
554 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
556 2006-05-06 Eric Blake <ebb9@byu.net>
558 * tests/mv/leak-fd: Work even on case-insensitive file system.
560 2006-05-04 Jim Meyering <jim@meyering.net>
562 * NEWS: Mention the 2006-03-19 pwd-related change that makes
563 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
565 2006-05-03 Jim Meyering <jim@meyering.net>
567 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
568 Use better macro parameter names: s/basename/key_name/,
569 s/basefunc/key_cmp_func. Fix typo in comment.
571 2006-04-29 Eric Blake <ebb9@byu.net>
573 * src/ls.c (main): On systems with d_type, directories_first only
574 implies format_needs_type, not format_needs_stat.
576 2006-05-03 Jim Meyering <jim@meyering.net>
578 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
579 after comma in arg list, from Eric Blake.
581 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
583 * tests/misc/date (relative-3): New test, derived from a bug
584 report by John Thomas McDole.
586 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
588 New option for ls: --group-directories-first.
589 It makes ls list directories before files.
590 * NEWS [New features]: Mention it.
591 * src/ls.c (sort_type): Rearrange to use as an array index when
592 choosing sort function; added new sort_numtypes member for
594 (time_type): Add new time_numtypes member for compile-time check.
595 (directories_first): New global variable.
596 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
597 (long_options): Add --directories-first.
598 (main): Support new option.
599 (is_directory): New function.
600 (extract_dirs_from_files): Use it.
601 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
602 (LIST_SORTFUNCTION_VARIANTS): New macros.
603 (sort_functions): New global variable.
604 (sort_files): Use it.
605 (usage): Document new option.
607 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
609 * src/shred.c (fillrand): The assertion was way too weak, due to
610 what must be a typo. Strengthen it to its intended value.
611 (dopass): Don't use alloca; it's not worth the aggravation here,
612 since it's used only to get a page-aligned buffer, and page
613 alignment doesn't buy us much here. I'm suspicious that alloca
614 causes problems on some hosts, due to a recent bug report by Adam
615 Waltman: http://bugs.gentoo.org/130246.
617 2006-04-18 Jim Meyering <jim@meyering.net>
619 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
620 sha384sum, sha512sum.
622 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
624 * src/chmod.c (describe_change): Adjust to filemode changes.
625 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
626 (print_long_format): Use (new) filemodestring rather than
627 (old) mode_string, so that we get more file types right, at least
628 in theory. Adjust to filemode changes.
629 * src/stat.c (human_access): Likewise.
631 2006-04-18 Jim Meyering <jim@meyering.net>
633 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
634 ignore file. This has never been enabled. Reported by Eric Blake.
636 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
638 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
639 bug in Interix. Just call symlink or link directly. All uses changed.
640 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
641 * src/stat.c (USE_STATVFS): New macro.
642 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
643 (NAMEMAX_FORMAT): define a bit more clearly, now that the
644 statvfs-using code is a bit more regular.
645 * src/system.h (sync) [!HAVE_SYNC]: New macro.
647 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
649 * NEWS: csplit, nl, expr now conform to POSIX better, and are
650 more-compatible with traditional Unix, with respect to regular
652 * src/csplit.c (extract_regexp): Set re_syntax_options to a
653 value that is compatible with what POSIX requires.
654 * src/nl.c (build_type_arg): Likewise.
655 * src/expr.c (docolon): Likewise. Also, don't let anchors match
656 newline; this fixes an incompatibility with tradition and with POSIX.
657 Don't warn about leading ^. POSIX says it is unspecified whether
658 ^ is a special character, which means that implementations can
659 either treat it as special or not, but either way a warning is not
660 allowed (unless the regexp is otherwise invalid). Instead, anchor
661 the expression but treat ^ as an anchor; this is the traditional
662 behavior (e.g., Solaris 10).
663 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
664 and the like as invalid expressions (exit status 2), not as
665 failure of 'expr' (exit status 3). This is more consistent with
667 * tests/expr/basic (fail-a): Adjust exit status to match new expr
668 behavior, for status 2 versus 3.
670 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
671 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
672 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
673 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
674 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
675 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
676 (bre61, bre62): New tests.
677 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
681 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
682 "if !". Do not assume that 'sed' can handle long, newline-free input.
683 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
685 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
687 Adjust to new regex.h API (with new fastmap type), and clean
688 up the regex storage allocation a bit.
690 * src/csplit.c (struct control): Put re_compiled member at the
691 end, since it's large. Change regexpr member from char * to bool;
692 all uses changed. Add new member fastmap.
693 (extract_regexp): regexp arg is now char const *, not char *.
694 Don't bother duplicating the regular expression; it's not needed.
695 Set fastmap from new fastmap member. Don't bother allocating
696 a buffer, as the regexp code does a better job than we do.
697 * src/expr.c (docolon): Allocate and use a fastmap.
698 Don't bother allocating a buffer.
699 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
701 (build_type_arg): New fastmap arg. All uses changed.
702 Don't bother allocating a buffer, but set a fastmap.
703 * src/ptx.c (context_regex_string, word_regex_string): Remove.
704 (context_regex, word_regex): New vars, replacing the above.
706 (struct regex_data): New type.
707 (compile_regex): Renamed from alloc_and_compile_regex, since
708 we no longer allocate storage. Arg is now a struct regex_data *,
709 not a const char *. All uses changed. Don't allocate the fastmap;
710 instead, take it from the caller. Don't convert size_t to int,
711 to avoid arithmetic overflow problems. Don't bother freeing
712 storage afterwards; it's not worth the aggravation.
713 * src/tac.c (compiled_separator_fastmap): New ver.
714 (main): Use it. Don't bother allocating a buffer.
716 2006-03-30 Jim Meyering <jim@meyering.net>
718 * src/dd.c (iwrite): Remove assignment without effect.
719 Reported by Felix Rauch Valenti.
721 2006-03-22 Eric Blake <ebb9@byu.net>
723 * src/ptx.c (usage): Remove mention of --copyright/-C.
724 (main): Alias --copyright to --version plus a deprecation warning.
725 * NEWS: Mention this.
727 2006-03-27 Jim Meyering <jim@meyering.net>
729 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
730 use of strtod. Tiny patch from Nickolai Zeldovich.
732 2006-03-11 Eric Blake <ebb9@byu.net>
734 * tests/misc/dirname: New file.
735 * tests/basename/Makefile.am: Delete.
736 * tests/basename/basic: Move to...
737 * tests/misc/basename: ... this new file. Add some tests,
738 including fixed behavior for //.
739 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
740 * tests/Makefile.am (SUBDIRS): Remove basename.
741 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
743 Improvements to dirname/basename handling on platforms like
744 cygwin with distinct // and with drive letters.
745 * NEWS: Document new behavior.
746 * src/basename.c (main): Don't strip suffix from file system
748 * src/cp.c (target_directory_operand): Use new last_component.
749 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
750 traversing the string.
751 * src/dircolors.c (guess_shell_syntax): Use new last_component.
752 * src/install.c (target_directory_operand, install_file_in_dir):
754 * src/ln.c (target_directory_operand, main): Likewise.
755 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
756 * src/mv.c (target_directory_operand, movefile): Likewise.
757 * src/remove.c (rm_1): Likewise.
758 * src/shred.c (wipename): Likewise.
759 * src/split.c (next_file_name): Likewise.
760 * src/su.c (log_su, run_shell): Likewise.
762 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
764 * NEWS: nohup diagnostics are now more precise, and nohup now
765 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
766 * src/nohup.c (main): Implement this.
767 * tests/misc/nohup: Test the new behavior.
769 2006-03-12 Jim Meyering <jim@meyering.net>
771 * src/copy.c (set_author): Rename function, from preserve_author.
773 * src/remove.c (AD_pop_and_chdir): Use new macro,
774 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
776 * src/system.h (SAME_INODE): Remove definition.
777 Include "same-inode.h", instead.
779 2006-03-11 Eric Blake <ebb9@byu.net>
781 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
783 2006-03-10 Jim Meyering <jim@meyering.net>
785 Fix a bug whereby a user with write access to a directory being removed
786 could cause the removal of that directory to fail with an erroneous
787 diagnostic about a directory cycle. Reported by Vineet Chadha.
789 * NEWS: Mention this.
790 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
791 leave (and try to rmdir) is the one whose dev_ino is being used to
792 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
794 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
796 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
797 * src/dd.c (set_fd_flags): Handle file-creation flags on file
798 descriptors, rather than ignoring them.
799 * tests/dd/misc: Add test cases for append, nofollow, directory,
800 and nolinks flags. Simplify redirection to /dev/null in some cases.
802 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
803 noatime test never tested anything.
805 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
807 * src/dd.c (flags, usage): New flags directory, nolinks.
808 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
810 * src/ls.c (usage): Mention that -f disables --color.
811 Problem reported by Niels Möller.
813 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
815 * man/*.x: Add references to syscalls from utilities of the same name.
817 2006-03-05 Jim Meyering <jim@meyering.net>
819 * tests/help-version: Set SHELL, if not already set, in order to
820 avoid failure when `make check' is run through debuild; dircolors
821 would fail due to lack of $SHELL. Reported by Sven Joachim.
823 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
824 * src/base64.c (wrap_write, do_encode, main): Change type of
825 parameters and locals, wrap_column, form size_t to uintmax_t.
826 (main): Adjust to use xstrtoumax, accordingly.
828 2006-03-03 Jim Meyering <jim@meyering.net>
830 Don't fail when run from an environment with SHELL not a Bourne
831 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
832 * tests/dircolors/simple: Invoke each non-failing test with -b.
833 Reported by Michael Stone.
835 2006-02-27 Jim Meyering <jim@meyering.net>
837 * tests/misc/base64: Derive --decode-using tests from the
840 * tests/misc/base64: Factor out a long constant string.
841 Split lines to stay within 80 columns.
843 * tests/misc/Makefile.am (TESTS): Add base64.
844 * tests/misc/base64: Test base64. From Simon Josefsson.
846 * src/base64.c (do_decode): Use correct type for parameter,
847 ignore_garbage: s/size_t/bool/.
849 * src/base64.c: Don't include .h files already included by system.h:
850 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
851 Include "system.h" before the other lib/*.h header files.
852 Include <sys/types.h> before "system.h".
853 (wrap_write): Remove declaration of unused local, initial_column.
854 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
856 * README: Add base64 to the list.
858 2006-02-17 Simon Josefsson <jas@extundo.com>
861 * AUTHORS: Mention base64.
863 * man/Makefile.am: Build base64.1.
864 * man/base64.x: New file.
865 * src/Makefile.am (bin_PROGRAMS): Add base64.
866 * src/base64.c: New file.
868 2006-02-25 Eric Blake <ebb9@byu.net>
870 In ls, avoid calling stat for --inode (-i), when possible.
871 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
872 * src/system.h: ... here, for use in ...
873 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
875 (gobble_file): Add inode argument.
876 (print_dir): Pass inode if available.
877 (usage): Remove inaccuracy.
879 2006-02-23 Jim Meyering <jim@meyering.net>
881 * TODO: Update/correct some obsolete entries.
883 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
885 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
886 * src/join.c (usage): Likewise.
887 Documentation problem reported by Philip Kensche.
889 2006-02-20 Eric Blake <ebb9@byu.net>
891 * man/rm.x: Update documentation to match previous patch.
893 2006-02-18 Eric Blake <ebb9@byu.net>
895 New option for rm: --interactive=once (-I).
896 * NEWS: Document it, along with change to rm --interactive.
897 * TODO: Remove entry for implementing rm -I
898 * src/rm.c (INTERACTIVE_OPTION): New enum value.
899 (interactive_type): New enum.
900 (long_opts): Let interactive take an optional argument.
901 (interactive_args, interactive_types): New option arguments.
902 (usage): Document -I, --interactive=WHEN. Use program_name
903 instead of a basename.
904 (main): New -I option, new behavior to --interactive.
905 * tests/rm/interactive-once: New tests.
906 * tests/rm/interactive-always: Ditto.
907 * tests/rm/Makefile.am (TESTS): Run them.
909 2006-02-18 Jim Meyering <jim@meyering.net>
911 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
912 expression match more of the target lines, e.g., those that start with
913 `-S,' (short option followed by a comma) or that include `=[...]'.
914 Patch by Nicolas François.
915 Fix the four offenders thus exposed:
916 * src/join.c (usage): Use two spaces (not one) to separate the
917 --first-only option string from its description, so help2man formats
918 the derived man page properly.
919 * src/pr.c (usage): Likewise.
920 * src/uniq.c (usage): Likewise.
921 * src/install.c (usage): Likewise.
923 2006-02-15 Jim Meyering <jim@meyering.net>
925 * Makefile.maint (alpha beta major): For `make major', ensure that the
926 version string is of the form N.N[.N]*, where N is one or more digits.
928 2006-02-14 Jim Meyering <jim@meyering.net>
930 * INSTALL: Update from gnulib.
932 2006-02-13 Jim Meyering <jim@meyering.net>
934 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
936 2006-02-12 Jim Meyering <jim@meyering.net>
938 * Makefile.maint (patch-check): New target.
939 (local-checks-available): Add to the list.
941 2006-02-11 Jim Meyering <jim@meyering.net>
943 * src/c99-to-c89.diff: New file.
944 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
946 * .x-po-check: New file, with exclusions so that `make distcheck'
948 * Makefile.am (EXTRA_DIST): Add .x-po-check.
950 rm -r must remove an empty directory, even if it is inaccessible.
951 * src/remove.c (close_preserve_errno): New function.
952 (fd_to_subdirp): Don't print a diagnostic in this function.
953 Do it from the callers instead, unless rmdir succeeds.
954 (remove_cwd_entries, remove_dir): Adjust callers.
955 * tests/rm/empty-inacc: New test for the above.
956 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
957 * NEWS: Mention this bug fix.
958 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
959 a tiny bit less precise: cannot remove `a/1': ... instead of
960 cannot open directory `a/1': ...
962 * Makefile.maint (syntax-check-rules): Automatically derive this
963 list of sc_-prefixed rule names.
965 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
967 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
968 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
969 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
970 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
971 go away? was that an accident?)
972 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
973 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
974 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
975 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
976 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
977 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
978 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
979 (author_mark_check, makefile_path_separator_check):
980 Output line numbers, to simplify navigation of Emacs *compilation*
982 (sc_prohibit_atoi_atof, sc_file_system):
983 Rework slightly so that Makefile.maint doesn't get reported as a
984 violation of its own syntax rules.
985 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
986 it at run-time (which didn't work with Bison). Fix a makefile typo,
987 caught by Makefile.maint itself: spaces where a tab should be.
988 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
989 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
990 Ignore djgpp and man subdirectories, to avoid false matches with
991 Bison and coreutils, respectively. Use sort -u to remove the
992 resulting duplicates.
993 * gnupload: Rework slightly to avoid bogus warning from
994 sc_two_space_separator_in_usage.
996 2006-02-10 Jim Meyering <jim@meyering.net>
998 Use gzip's --rsyncable option only if it's available.
999 * Makefile.maint (gzip_rsyncable): New variable.
1002 2006-02-08 Jim Meyering <jim@meyering.net>
1004 * Makefile.maint (local-checks-available): Define in terms of
1005 the expansion, $(syntax-check-rules), rather than the single,
1006 top-level target `syntax-check', so that it's easier to exclude
1007 individual rules (via $(local-checks-to-skip)).
1008 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
1010 2006-02-07 Jim Meyering <jim@meyering.net>
1012 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
1013 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
1015 * tests/help-version (expected_failure_status_vdir):
1016 Redirect an expected disk-full diagnostic to /dev/null.
1018 2006-02-06 Jim Meyering <jim@meyering.net>
1020 * src/unexpand.c (usage): Use two spaces (not one) to separate the
1021 --first-only option string from its description, so help2man formats
1022 the derived man page properly.
1023 * src/rm.c (usage): Likewise for --no-preserve-root.
1024 * src/chown.c (usage): Likewise.
1025 * src/chgrp.c (usage): Likewise.
1027 Add a rule to ensure that the above doesn't happen again.
1028 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
1029 (syntax-check-rules): Add it.
1030 * .x-sc_two_space_separator_in_usage: New empty file.
1031 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
1033 2006-02-06 Jim Meyering <jim@meyering.net>
1035 * src/cp.c (usage): Use two spaces (not one) to separate each
1036 option string from its description, so help2man formats the
1037 derived man page properly.
1038 * src/mv.c (usage): Likewise.
1039 Patch from Nicolas François in http://bugs.debian.org/351601.
1041 2006-02-04 Jim Meyering <jim@meyering.net>
1043 * src/copy.c (copy_internal): cp -RL would fail when encountering
1044 the same directory more than once in the hierarchy beneath a single
1045 command-line argument. That is legitimate, e.g. when there are
1046 two or more symbolic links, each pointing to some directory that
1047 would not otherwise be copied. Reported by Christophe LYON.
1048 * tests/cp/cp-deref: New file. Test for today's fix.
1049 * tests/cp/Makefile.am (TESTS): Add cp-deref.
1050 * NEWS: Document this.
1052 2006-02-03 Jim Meyering <jim@meyering.net>
1054 * configure.ac: Require automake-1.9.6, not 1.8.3.
1056 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
1058 * src/od.c (usage): Mention that -t a ignores high order bit.
1059 Documentation problem reported by Ed Avis.
1061 2006-02-01 Jim Meyering <jim@meyering.net>
1063 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
1065 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
1067 * src/head.c (main): Use a better diagnostic when someone uses a
1068 trailing numeric option in an invalid way. Problem reported by
1070 * src/tail.c (parse_options): Likewise.
1072 2006-01-30 Jim Meyering <jim@meyering.net>
1074 * man/wc.x: Include `count' keyword in man page synopsis,
1075 per suggestion from http://bugs.debian.org/181585.
1077 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
1079 * src/df.c (show_dev): If the file system claims to have
1080 more available than total blocks, report the number of used
1081 blocks as being total - available (a negative number) rather
1082 than as garbage. Problem reported by Toralf Foerster.
1084 2006-01-24 Jim Meyering <jim@meyering.net>
1086 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
1087 to put a regular file in O_NONBLOCK mode fails with EPERM.
1088 That happens on Linux (up to 2.6.15) when using tail -f on a file with
1089 the append-only attribute. Reported by Dean Gaudet. For details,
1090 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
1091 * NEWS: Mention this fix.
1092 * tests/tail-2/append-only: New file. Test for the above.
1093 * tests/tail-2/Makefile.am (TESTS): Add append-only.
1094 * tests/Makefile.am (check-root): Add tail-2/append-only
1096 2006-01-21 Jim Meyering <jim@meyering.net>
1098 * NEWS: Mention fts-related improvements and bug fixes.
1100 2006-01-19 Jim Meyering <jim@meyering.net>
1102 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
1103 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
1105 2006-01-18 Jim Meyering <jim@meyering.net>
1107 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
1109 2006-01-17 Jim Meyering <jim@meyering.net>
1111 Now that fts no longer changes the current working directory, adjust
1112 its clients accordingly -- note that du.c uses fts but doesn't need
1113 any adjustment, since it doesn't operate on the actual files,
1114 but rather just uses the stat buffers provided by fts.
1116 * src/chown-core.c: Include "openat.h".
1117 Don't include "lchown.h".
1118 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
1119 calling openat, lchownat, chownat, rather than open, lchown, chown.
1121 * src/chmod.c: Include "openat.h".
1122 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
1124 * tests/du/long-from-unreadable: New test, to exercise one small
1127 2006-01-13 Jim Meyering <jim@meyering.net>
1129 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
1130 addition of new directories under tests/.
1132 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
1135 2006-01-12 Jim Meyering <jim@meyering.net>
1137 * tests/du/long-sloop: Adjust not to hard-code the expected
1138 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
1139 from that of GNU libc. Reported by Paul Eggert.
1141 * tests/du/long-sloop: Create file at end of symlink chain.
1143 * tests/misc/test: New file, with a test for one of the
1144 bugs fixed by yesterday's test.c changes.
1145 * tests/misc/Makefile.am (TESTS): Add test.
1147 2006-01-11 Jim Meyering <jim@meyering.net>
1149 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
1150 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
1151 a very long sequence of symbolic links (not necessarily a loop).
1152 * tests/du/Makefile.am (TESTS): Add long-sloop.
1154 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
1156 * src/test.c (test_syntax_error): Append a newline. All callers
1157 changed, except for the ones that didn't already append a newline.
1158 Bug reported by Eric Blake.
1160 2006-01-11 Jim Meyering <jim@meyering.net>
1162 * src/system.h (X2NREALLOC): Now that verify_true is no longer
1163 void, cast its result to void, to avoid gcc's warning that
1164 ``left-hand operand of comma expression has no effect''.
1165 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
1167 2006-01-10 Jim Meyering <jim@meyering.net>
1169 * tests/chmod/no-x: Add a test for today's fts.c fix.
1171 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
1173 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
1174 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
1176 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
1178 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
1179 Use verify_true instead of verify_expr, to sync with gnulib.
1181 2006-01-08 Jim Meyering <jim@meyering.net>
1183 * src/date.c (usage): Adjust the formatting of the entries for
1184 %::z and %:::z (separate with two spaces, not one) so that help2man
1185 formats them properly. Reported by Philip Rowlands.
1187 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
1189 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
1191 2006-01-06 Jim Meyering <jim@meyering.net>
1193 * Makefile.maint (copyright-check): Use date +%Y in place of
1196 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
1197 First off, the attribute should have been `volatile' (not static)
1198 to avoid longjmp-related risk of clobber. Secondly, now there is
1199 no longer any risk of a local variable being clobbered, so there's
1200 no need for any attribute at all.
1202 2006-01-05 Jim Meyering <jim@meyering.net>
1204 * src/remove.c: Give a few functions the inline attribute.
1205 (AD_pop_and_chdir): Use gotos to avoid some duplication.
1206 (AD_push): Rewrite an assertion so that the entire computation
1207 goes away when assertions are turned off.
1209 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
1210 It's already defined in "system.h".
1211 * Makefile.maint: Add a FIXME comment.
1213 2006-01-04 Jim Meyering <jim@meyering.net>
1215 * ChangeLog: Remove entries from 2005-10-22 and earlier.
1216 * ChangeLog-2005: New file, for entries up to version 5.92.
1218 2006-01-03 Jim Meyering <jim@meyering.net>
1220 * tests/du/no-x: Also allow a slightly different diagnostic -- the
1221 one you get when using openat-enabled fts.c and du (coming soon).
1222 * tests/chmod/no-x: Likewise.
1223 * tests/chgrp/no-x: Likewise.
1225 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
1227 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
1229 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
1230 (restricted_chown): Return it, if the file cannot be accessed due
1231 to EPERM, or if no uid or gid are required, or if the file is
1232 neither a directory nor a regular file. Rewrite to avoid gotos.
1233 (change_file_owner): Handle RC_do_ordinary_chown case.
1234 Rewrite to avoid gotos.
1235 * tests/chgrp/basic: Make sure we can change the group of
1238 * src/date.c (usage): Explain %g, %G, and %V a bit better.
1240 2006-01-02 Jim Meyering <jim@meyering.net>
1242 * src/copy.c (set_owner): Correct a comment.
1244 * src/tail.c (parse_options): Change warning to say that --retry
1245 is useful `mainly' (not `only') when following by name.
1246 Reported here: http://bugs.debian.org/273781
1248 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
1250 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
1251 * src/copy.c: Include lchmod.h.
1252 (copy_internal): Use lchmod rather than chmod.
1253 * src/cp.c: Include lchmod.h.
1254 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
1255 * src/mkdir.c: Include lchmod.h.
1256 (usage): Clarify -m's operation.
1257 (main): Use lchmod rather than chmod. Don't use lchmod unless the
1258 new mode contains bits outside the 777 range.
1259 * src/mkfifo.c (usage): Clarify -m's operation.
1260 (main): If -m is given, don't invoke chmod; use umask 0 instead.
1261 Report an error if -m asks for bits outside the 777 range.
1262 * src/mknod.c (usage, main): Likewise.
1264 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
1266 2005-12-27 Jim Meyering <jim@meyering.net>
1268 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
1269 (sc_prohibit_assert_without_use): New rule.
1270 (syntax-check-rules): Add it to the list.
1271 * .x-sc_prohibit_assert_without_use: New empty file.
1272 * Makefile.am (EXTRA_DIST): Add it.
1274 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
1276 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
1277 Don't include <assert.h>; it wasn't used.
1279 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
1281 * src/chown-core.c (restricted_chown):
1282 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
1283 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
1284 | O_NOFOLLOW too, for consistency with other dir-openers.
1285 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
1286 (is_empty_dir): Likewise.
1287 * src/shred.c (wipename): Likewise. Don't bother trying to open
1288 dir for writing, since POSIX prohibits it.
1290 2005-12-22 Jim Meyering <jim@meyering.net>
1292 * tests/help-version: Redirect stderr to /dev/full, to suppress
1293 write error diagnostic.
1295 2005-12-19 Jim Meyering <jim@meyering.net>
1297 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
1298 Avoid a minor race condition when `-m MODE' is specified, by using
1299 open, fchown, and close rather than just chown. To do that reliably --
1300 even with an overly restrictive umask -- ensure that each mkdir,
1301 mknod and mkfifo call uses a mode including at least owner-read access.
1302 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
1303 the subsequent chown (or equivalent open,fchown,close) fails.
1304 * tests/misc/mknod: New tests.
1305 * tests/misc/Makefile.am (TESTS): Add mknod.
1307 2005-12-17 Jim Meyering <jim@meyering.net>
1309 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
1310 e.g., on a named pipe.
1311 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
1312 place of all uses, since it is guaranteed (system.h) to be defined.
1314 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
1316 Add POSIX ACL support
1317 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
1318 is no requirement for ACL support; particularly, it does not exist
1319 on systems that have POSIX ACLs.
1320 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1321 * src/cp.c (umask_kill): With default acls, the umask is not to be
1322 applied. Remove umask_kill, don't change the process umask, and let
1323 the kernel apply the umask where appropriate.
1324 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1325 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1327 (copy_reg, copy_internal): Use copy_acl and set_acl
1328 instead of fchown/chown. Fix the logic for POSIX ACLs.
1329 (chown_succeded): Remove; we now always copy acls and
1330 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1331 did a chown before or not.
1332 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1333 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1334 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1335 to link with it via $(LIB_ACL), for the utilities that need it.
1337 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1339 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1340 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1341 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1342 value is now signified by whether cwd_errno is null.
1343 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1344 pointer-to-bool to pointer-to-errno-value. All callers changed.
1345 (rm_1): Don't bother setting a local cwd failure flag and then
1346 ORing it into the caller's. Just set the caller's.
1347 (rm): Use cwd failure errno value to print a slightly-better
1350 2005-12-15 Jim Meyering <jim@meyering.net>
1352 * src/stat.c (print_it): Properly handle a backslash at the
1353 end of a --printf format string. Reported by Paul Eggert.
1354 * tests/misc/stat-printf (end-bs): Add a test for the above.
1356 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1358 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1359 Don't assume /etc/passwd contains user names; use 'id' instead.
1361 2005-12-15 Jim Meyering <jim@meyering.net>
1363 stat: revert behavior of --format=FMT (-c)
1364 stat: add new option: --printf=FMT
1365 * NEWS: Mention this.
1366 * src/stat.c (isodigit, octtobin, hextobin): Define.
1367 (PRINTF_OPTION): Define.
1368 (interpret_backslash_escapes, trailing_delim): New globals.
1369 (usage): Document them. Alphabetize on long option names.
1370 (print_esc_char): New function.
1371 (print_it): Rewrite, in order to handle backslash escapes.
1372 (main): Handle new option. Set globals for --format, too.
1374 * tests/misc/stat-printf: Test --printf and --format.
1375 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1377 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1379 * NEWS: sort now reports incompatible options.
1380 * src/sort.c (incompatible_options, check_ordering_compatibility):
1382 (main): Use them. Don't bother with a usage message for
1383 "sort -c a b", for consistency with other error diagnostics.
1384 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1387 * src/cat.c (main): Undo previous change. close_stdout already
1388 does the check, so the previous change wasn't necessary.
1390 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1392 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1394 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1396 Install a more-conservative approach for sort -R. It's the
1397 same basic idea as the existing code, except it uses the full ISAAC
1398 approach (called the "more kosher" approach in the existing comments).
1399 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1400 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1401 better to be conservative here at first, and review any performance
1402 improvements carefully.
1403 * .x-sc_require_config_h: Add src/rand-isaac.c.
1404 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1405 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1406 (shred_SOURCES, sort_SOURCES): Remove.
1407 (EXTRA_DIST): Add rand-isaac.c.
1408 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1409 changing it to allow for varying numbers of words in the state.
1410 Alter so that we include rand-isaac.c directly rather than
1411 compiling it and linking to it. Don't include config.h or
1412 system.h; that's the includer's responsibility.
1413 Omit functions that are specific to shred.
1414 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1415 (isaac_step, struct irand_state):
1416 Resurrect these, with the same defns that used to be in shred.c.
1417 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1418 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1420 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1421 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1422 (irand_init, irand32, irand_mod):
1423 Number of words is constant again.
1424 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1425 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1426 * src/sort.c: Likewise.
1427 * src/shred.c (fillrand, dopass, main): Undo previous change.
1428 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1430 * src/sort.c: Don't include md5.h; it wasn't needed.
1431 (struct keyfield): Rename random_hash to random, for consistency
1432 with the other member names. All uses changed.
1433 (usage): Tweak wording to mention STRING for --seed option.
1434 (short_options): Rorder for consistency with other programs.
1435 (rand_state): Now a struct, not a pointer to one. All uses changed.
1436 (HASH_WORDS, HASH_SIZE): Remove.
1437 (get_hash): Remove comments around resbuf size, since we can assume C89.
1438 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1439 (keycompare): Adjust to the new get_hash.
1441 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1442 (main): Don't set need_random simply because gkey has it set; that
1443 doesn't necessarily mean we'll need random numbers.
1444 Redo seeding to match new get_hash approach.
1446 2005-12-10 Jim Meyering <jim@meyering.net>
1448 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1450 Avoid shred segfault on 64-bit systems.
1451 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1452 local of type uint32_t. Make the local an `int' instead.
1454 * NEWS: Mention sort's new options.
1456 * src/rand-isaac.c (isaac_mix): Declare to be static.
1457 Mark all other functions as `extern' so the tight-scope
1458 part of `make distcheck' passes once again.
1459 * src/rand-isaac.h (isaac_mix): Remove declaration.
1461 * src/sort.c (get_hash): Change position of `*' in parameter
1462 type to conform with convention.
1463 (main): Split a long line so it fits in 80 columns.
1464 (keycompare): Remove stray SPACE before TAB that was
1465 causing `make distcheck' to fail.
1467 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1469 * tests/misc/sort-rand: New file: basic tests for the new options.
1470 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1472 2005-12-10 Frederik Eaton <frederik@ofb.net>
1474 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1475 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1476 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1477 Make state size runtime-configurable.
1478 (isaac_new, isaac_copy): New functions.
1479 * src/rand-isaac.h: New file.
1480 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1481 (fillrand, main): Adjust to the fact that the state size is now
1482 runtime-configurable.
1483 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1484 (usage): Add options --random-sort and --seed to implement a random
1486 Include md5.h and rand-isaac.h.
1487 (get_hash): New function.
1488 (rand_state): New var.
1489 (HASH_WORDS, HASH_SIZE): New macros.
1491 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1493 * tests/dd/misc: Add test for dd iflags=noatime.
1495 2005-12-09 Jim Meyering <jim@meyering.net>
1497 * src/sort.c (usage): Mention white space vs -b and -t options.
1500 2005-12-09 Eric Blake <ebb9@byu.net>
1502 * src/test.c (main): Fix misleading comment.
1504 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1506 * NEWS: Mention dd's new noatime flag.
1507 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1508 * src/dd.c (flags, usage): Add support for noatime flag.
1510 2005-12-07 Jim Meyering <jim@meyering.net>
1512 Distribute the cvsu script, used only by `make syntax-check'.
1513 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1514 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1515 distribute a copy of this script.
1516 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1518 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1519 to create a temporary directory on another partition.
1520 From Andreas Gruenbacher.
1522 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1524 * man/basename.x: Cross-reference to dirname and readlink.
1525 * man/dirname.x: Cross-reference to basename and readlink.
1527 2005-12-05 Andreas Gruenbacher
1529 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1530 (set_owner, preserve_author): New functions, factored out of copy_reg.
1531 (copy_reg): Use them.
1532 (copy_internal): Use them here, too.
1534 2005-12-04 Jim Meyering <jim@meyering.net>
1536 * src/sleep.c (usage): Say what happens with two or more arguments.
1537 Suggested by Justin Pryzby.
1539 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1542 2005-12-03 Jim Meyering <jim@meyering.net>
1544 * src/rm.c (long_opts): Change the name of each undocumented, for-
1545 testing-only option to start with `-', so that it cannot render
1546 ambiguous any prefix it happens to share with some other option name.
1547 Problem reported by Eric Blake.
1548 * src/head.c (long_options): Likewise.
1549 * src/tail.c (long_options): Likewise.
1551 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1552 testing-only --presume* options to start with `---'.
1553 * tests/rm/dangling-symlink: Likewise.
1554 * tests/rm/dir-no-w: Likewise.
1555 * tests/rm/isatty: Likewise.
1557 2005-11-30 Jim Meyering <jim@meyering.net>
1559 * Makefile.maint: Add a comment about cvsu.
1561 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1563 * NEWS: df updates for "none", "proc", inaccessible file systems.
1564 * src/df.c (show_point): Ignore inaccessible file systems.
1565 (usage): -a includes dummy file systems, not size-0 file systems.
1567 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1568 to avoid collision with POSIX name space. All uses changed.
1570 2005-11-24 Jim Meyering <jim@meyering.net>
1572 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1573 * tests/acl: Add `$0: ' prefix to diagnostics.
1575 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1577 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1579 * src/copy.c: Improve performance a bit by optimizing away
1580 unnecessary system calls and going to a block size of at least
1581 8192 (on normal hosts, anyway). This improved performance 5% on my
1582 Debian stable host (2.4.27 kernel, x86, copying from root
1583 ext3 file system to itself).
1584 Include "buffer-lcm.h".
1585 (copy_reg): Omit last argument. All callers changed.
1586 Use xmalloc to allocate rather than trusting alloca
1587 (which is unwise with large block sizes).
1588 Declare locals more locally, if possible.
1589 Use uintptr_t words instead of int words, for a bit more speed
1590 when looking for null blocks on 64-bit hosts.
1591 Optimize away reads of zero bytes on regular files.
1592 In the typical case, insist on 8 KiB buffers, at least.
1593 Avoid unnecessary extra call to fstat when checking for sparse files.
1594 Avoid now-unnecessary cast to off_t, and "0L".
1595 Avoid unnecessary test of *new_dst when checking for same owner
1598 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1600 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1602 2005-11-22 Jim Meyering <jim@meyering.net>
1604 * src/remove.c (AD_push): Remove debugging cruft.
1606 * tests/rm/unread2 (rm): Change expected diagnostic,
1607 `cannot open directory' to `cannot remove', to align with
1609 * tests/rm/rm2: Ensure that rm now continues removing entries
1610 even after certain types of failure.
1612 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1613 that provide openat (Solaris), and on systems like Linux+procfs
1614 where our openat emulation code is reentrant. This also fixes a
1615 few low-probability leaks and eliminates some code that could,
1616 in very unusual circumstances, cause rm() (via a callee) to exit.
1617 * NEWS: Mention this.
1619 * configure.ac: Put copyright dates all on one line so the
1620 emacs function that updates them works properly.
1622 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1624 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1625 Problem reported by Eric Blake.
1626 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1627 we get a standard-conforming compiler. This relies on the new
1628 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1629 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1630 m4/c.m4 can go away with Autoconf 2.60 comes out.
1632 2005-11-17 Jim Meyering <jim@meyering.net>
1634 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1635 (AD_mark_current_as_unremovable): Likewise, but for a local.
1638 * tests/mv/acl: Let traps handle removing temporary directories.
1640 Expect acl-related tests to fail, until the corresponding
1641 patches are committed.
1642 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1643 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1645 ACL tests, from Andreas Gruenbacher.
1646 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1647 * tests/mv/Makefile.am (TESTS): Add acl.
1648 * tests/cp/Makefile.am (TESTS): Add acl.
1650 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1652 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1654 * NEWS: Improve quality of ln's diagnostics.
1655 * src/ln.c (do_link, usage): Likewise.
1656 (do_link): Don't use alloca on a buffer of unbounded size.
1658 2005-11-16 Jim Meyering <jim@meyering.net>
1660 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1661 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1662 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1663 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1664 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1666 2005-11-14 Jim Meyering <jim@meyering.net>
1668 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1670 2005-11-13 Jim Meyering <jim@meyering.net>
1672 * announce-gen: Accept new option, --gpg-key-id=ID and
1673 emit a blurb telling how to use the .sig files.
1674 * Makefile.cfg (gpg_key_ID): Define.
1675 * Makefile.maint (announcement): Use new option and key.
1677 Require that most .c files include <config.h>.
1678 * Makefile.maint (sc_require_config_h): New rule.
1679 (syntax-check-rules): Add it.
1680 * .x-sc_require_config_h: New file listing exceptions to the
1681 above rule. Some are legit, others are simply grandfathered in.
1682 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1684 2005-11-12 Jim Meyering <jim@meyering.net>
1686 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1688 2005-11-11 Jim Meyering <jim@meyering.net>
1690 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1691 Mention new readlink options in 5.3.0's `New features' section.
1692 Spotted by Thomas Hood.
1694 2005-11-08 Jim Meyering <jim@meyering.net>
1696 * NEWS: Merge in changes from b5_9x branch.
1698 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1700 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1701 like --time-style='posix-long-iso' if the locale settings are messed up.
1702 * src/ls.c (decode_switches): Implement this.
1704 2005-11-08 Jim Meyering <jim@meyering.net>
1706 * tests/du/2g: s/expensive/very expensive/ in a comment.
1709 2005-10-17 Eric Blake <ebb9@byu.net>
1711 * src/ls.c (usage): Fix descriptions of --sort, --time.
1712 Reported by Vitaly A. Ostanin.
1714 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1716 * src/ln.c: Include filenamecat.c.
1717 (FILE_BASENAME_CONCAT): Remove.
1718 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1719 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1720 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1723 2005-11-04 Jim Meyering <jim@meyering.net>
1725 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1726 on systems with stat.st_blocks of a signed 32-bit type.
1727 This bug causes trouble on some AIX 5.1 systems.
1728 Report and trivial patch from Paul Townsend:
1729 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1730 * NEWS: Mention this.
1732 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1733 * tests/du/Makefile.am (TESTS): Add it here.
1734 * tests/very-expensive: New file.
1735 * tests/Makefile.am (EXTRA_DIST): Add it here.
1736 * tests/cp/perm: Mark this test as `very-expensive', too.
1738 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1740 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1742 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1744 * src/rm.c (usage): Don't mention rm -d.
1746 2005-11-02 Jim Meyering <jim@meyering.net>
1748 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1749 From Andreas Schwab.
1751 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1752 `M+N records in/out' lines don't pollute `make check' output.
1754 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1755 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1756 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1757 to indicate that the input file should be piped into the command
1758 under test (via `cat FILE | $prog ...').
1760 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1761 (without -r) fails to remove a directory on a non-Linux system.
1762 This change affects only newer Solaris systems (with priv_*
1763 functions like priv_allocset). Reported by Keith Thompson.
1765 * tests/rm/dir-nonrecur: New file/test for the above fix.
1766 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1768 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1770 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1771 POSIX 1002.1-2001 requires.
1772 * src/tail.c (parse_obsolete_option): Implement this.
1773 Problem reported by Vincent Lefevre.
1774 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1775 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1776 (test_vector): Add special cases for _POSIX2_VERSION, and
1777 regularize the old ones a bit.
1778 * tests/touch/obsolescent: Add y2000 test.
1780 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1782 * src/dd.c (skip): Fix off-by-one error reported by
1783 Theodoros V. Kalamatianos.
1785 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1787 * tests/mkdir/p-3: Require that the test be run as non-root.
1788 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1790 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1792 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1793 boundary between DEST and SOURCE in the result.
1795 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1797 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1798 back to text, to sync with documentation and for backwards
1801 2005-10-25 Jim Meyering <jim@meyering.net>
1803 * tests/dircolors/simple (other-wr): Add an explicit test for
1804 the dircolors bug (NULL-dereference) fixed yesterday.
1806 2005-10-24 Jim Meyering <jim@meyering.net>
1808 * src/tac.c (tac_file): When determining whether a file is seekable,
1809 also test whether it is a tty. Using only the lseek-based test would
1810 give a false positive on Solaris. Reported by Peter Fales.
1812 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1814 * tests/install/d-slashdot: New test, for "install -d" failure.
1815 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1816 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1817 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1819 2005-10-24 Jim Meyering <jim@meyering.net>
1821 * src/dircolors.c (ls_codes): Add missing comma.
1822 Anonymous report and patch from
1823 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1825 * src/dircolors.c: Add compile-time assertion that the slack_codes
1826 and ls_codes arrays have the same number of elements. This would
1827 have prevented the above-fixed bug.
1829 * src/expand.c (parse_tab_stops): Add a comment to make this function
1830 identical to the one in unexpand.c.
1831 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1832 identical to the one in expand.c.
1834 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1836 2005-10-23 Jim Meyering <jim@meyering.net>
1838 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1839 a dangerous pointer-value-to-`unsigned' cast.
1840 * NEWS: mention the new sha* programs.
1841 * AUTHORS: Add new sha* programs.
1843 2005-08-28 David Madore <david.madore@ens.fr>
1845 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1846 * README: Add their names to the list.
1847 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1848 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1849 Rules for compiling sha-2 utilities
1850 (noinst_HEADERS): Remove checksum.h.
1851 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1853 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1854 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1855 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1856 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1857 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1858 sha384sum, sha512sum test scripts here rather that each in its
1861 2005-08-28 David Madore <david.madore@ens.fr>
1863 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1864 of the FIPS test vectors).
1866 2005-10-23 Jim Meyering <jim@meyering.net>
1868 * configure.ac: Use 6.0-cvs as the version string.
1869 * NEWS: Adjust accordingly.