1 2003-10-09 Havoc Pennington <hp@redhat.com>
3 * configure.in: define DBUS_HAVE_GCC33_GCOV if we have
4 gcc 3.3. Not that we do anything about it yet.
6 * bus/signals.c (bus_match_rule_parse): impose max length on the
9 * dbus/dbus-protocol.h: add DBUS_MAXIMUM_MATCH_RULE_LENGTH
11 2003-10-09 Havoc Pennington <hp@redhat.com>
13 Make matching rules theoretically work (add parser).
15 * bus/bus.c (bus_context_check_security_policy): fix up to handle
16 the case where destination is explicitly specified as bus driver
17 and someone else is eavesdropping.
19 * bus/policy.c (bus_client_policy_check_can_receive): fix up
20 definition of eavesdropping and assertion
22 * tools/dbus-send.c (main): use dbus_message_type_from_string
24 * bus/signals.c (bus_match_rule_parse): implement
26 * dbus/dbus-message.c (dbus_message_type_from_string): new
28 * dbus/dbus-errors.h (DBUS_ERROR_MATCH_RULE_INVALID): add
30 2003-10-02 Havoc Pennington <hp@pobox.com>
32 * glib/dbus-gproxy.c (dbus_gproxy_call_no_reply): rename from
33 dbus_gproxy_oneway_call
35 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main)
36 (dbus_server_setup_with_g_main): fix to allow calling them more
37 than once on the same args
38 (dbus_bus_get_with_g_main): new function
40 2003-10-02 Havoc Pennington <hp@redhat.com>
42 * doc/dbus-tutorial.xml: write some stuff
44 2003-09-29 Havoc Pennington <hp@pobox.com>
46 * configure.in: split checks for Doxygen from XML docs, check for
49 * doc/Makefile.am: XML-ify all the docs, and add a blank
52 2003-09-29 Havoc Pennington <hp@pobox.com>
54 * Merge dbus-object-names branch. To see the entire patch
55 do cvs diff -r DBUS_OBJECT_NAMES_BRANCHPOINT -r dbus-object-names,
57 To revert, I tagged DBUS_BEFORE_OBJECT_NAMES_MERGE.
59 2003-09-28 Havoc Pennington <hp@pobox.com>
61 * HACKING: update to reflect new server
63 2003-09-26 Seth Nickell <seth@gnome.org>
66 * python/examples/example-signals.py:
68 Start implementing some notions of signals. The API
69 is really terrible, but they sort of work (with the
70 exception of being able to filter by service, and to
71 transmit signals *as* a particular service). Need to
72 figure out how to make messages come from the service
75 * python/dbus_bindings.pyx.in:
77 Removed duplicate message_handler callbacks.
79 2003-09-25 Havoc Pennington <hp@redhat.com>
81 * bus/session.conf.in: fix my mess
83 2003-09-25 Havoc Pennington <hp@pobox.com>
85 * bus/session.conf.in: fix security policy, reported by Seth Nickell
87 2003-09-25 Seth Nickell <seth@gnome.org>
89 * python/examples/example-service.py:
91 Johan notices complete wrong code in example-service, but
92 completely wrong in a way that works exactly the same (!).
93 Johan is confused, how could this possibly work? Example
94 code fails to serve purpose of making things clear.
97 2003-09-25 Mark McLoughlin <mark@skynet.ie>
99 * doc/dbus-specification.sgml: don't require header fields
100 to be 4-byte aligned and specify that fields should be
101 distinguished from padding by the fact that zero is not
104 * doc/TODO: remove re-alignment item and add item to doc
105 the OBJECT_PATH type.
107 * dbus/dbus-message.c:
108 (HeaderField): rename the original member to value_offset
109 and introduce a name_offset member to keep track of where
110 the field actually begins.
111 (adjust_field_offsets): remove.
112 (append_int_field), (append_uint_field),
113 (append_string_field): don't align the start of the header
114 field to a 4-byte boundary.
115 (get_next_field): impl finding the next marhsalled field
117 (re_align_field_recurse): impl re-aligning a number of
118 already marshalled fields.
119 (delete_field): impl deleting a field of any type and
120 re-aligning any following fields.
121 (delete_int_or_uint_field), (delete_string_field): remove.
122 (set_int_field), (set_uint_field): no need to re-check
123 that we have the correct type for the field.
124 (set_string_field): ditto and impl re-aligning any
126 (decode_header_data): update to take into account that
127 the fields aren't 4-byte aligned any more and the new
128 way to distinguish padding from header fields. Also,
129 don't exit when there is too much header padding.
130 (process_test_subdir): print the directory.
131 (_dbus_message_test): add test to make sure a following
132 field is re-aligned correctly after field deletion.
134 * dbus/dbus-string.[ch]:
135 (_dbus_string_insert_bytes): rename from insert_byte and
136 allow the insert of multiple bytes.
137 (_dbus_string_test): test inserting multiple bytes.
139 * dbus/dbus-marshal.c: (_dbus_marshal_set_string): add
140 warning note to docs about having to re-align any
141 marshalled values following the string.
143 * dbus/dbus-message-builder.c:
144 (append_string_field), (_dbus_message_data_load):
145 don't align the header field.
147 * dbus/dbus-auth.c: (process_test_subdir): print the
150 * test/break-loader.c: (randomly_add_one_byte): upd. for
153 * test/data/invalid-messages/bad-header-field-alignment.message:
156 * test/data/valid-messages/unknown-header-field.message: shove
157 a dict in the unknown field.
159 2003-09-25 Seth Nickell <seth@gnome.org>
162 * python/dbus_bindings.pyx.in:
164 Handle return values.
166 * python/examples/example-client.py:
167 * python/examples/example-service.py:
169 Pass back return values from the service to the client.
171 2003-09-24 Seth Nickell <seth@gnome.org>
175 Connect Object methods (when you are sharing an object) up... pass
176 in a list of methods to be shared. Sharing all the methods just
177 worked out too weird. You can now create nice Services over the
180 * python/dbus_bindings.pyx.in:
182 Keep references to user_data tuples passed into C functions so
183 Python doesn't garbage collect on us.
185 Implement MethodReturn and Error subclasses of Message for creating
186 DBusMessage's of those types.
188 * python/examples/example-client.py:
189 * python/examples/example-service.py:
191 Simple example code showing both how create DBus services and objects,
194 2003-09-23 Havoc Pennington <hp@pobox.com>
196 * glib/dbus-gproxy.c (dbus_gproxy_manager_filter): implement
198 2003-09-23 Havoc Pennington <hp@redhat.com>
200 * glib/dbus-gproxy.c (dbus_gproxy_connect_signal): implement
201 (dbus_gproxy_disconnect_signal): implement
202 (dbus_gproxy_manager_remove_signal_match): implement
203 (dbus_gproxy_manager_add_signal_match): implement
204 (dbus_gproxy_oneway_call): implement
206 2003-09-23 Havoc Pennington <hp@pobox.com>
208 * glib/dbus-gproxy.c (struct DBusGProxy): convert to a GObject
209 subclass. This means dropping the transparent thread safety of the
210 proxy; you now need a separate proxy per-thread, or your own
211 locking on the proxy. Probably right anyway.
212 (dbus_gproxy_ref, dbus_gproxy_unref): nuke, just use g_object_ref
214 2003-09-22 Havoc Pennington <hp@redhat.com>
216 * glib/dbus-gproxy.c (dbus_gproxy_manager_get): implement
218 2003-09-21 Seth Nickell <seth@gnome.org>
220 First checkin of the Python bindings.
223 * python/Makefile.am:
224 * python/dbus_bindings.pyx.in:
225 * python/dbus_h_wrapper.h:
227 Pieces for Pyrex to operate on, building a dbus_bindings.so
228 python module for low-level access to the DBus APIs.
232 High-level Python module for accessing DBus objects.
237 Build stuff for the python bindings.
241 Extra macro needed for finding the Python C header files.
243 2003-09-21 Havoc Pennington <hp@pobox.com>
245 * glib/dbus-gproxy.c (dbus_gproxy_manager_new): start
246 implementing the proxy manager, didn't get very far.
248 * dbus/dbus-bus.c (dbus_bus_add_match): new
249 (dbus_bus_remove_match): new
251 * glib/dbus-gproxy.c (dbus_gproxy_new_for_service): add a
252 path_name argument; adjust the other not-yet-implemented
253 gproxy constructors to be what I think they should be.
255 2003-09-21 Havoc Pennington <hp@pobox.com>
257 * dbus/dbus-bus.c (dbus_bus_get): set exit_on_disconnect to TRUE
258 by default for message bus connections.
260 * dbus/dbus-connection.c (dbus_connection_dispatch): exit if
261 exit_on_disconnect flag is set and we process the disconnected
263 (dbus_connection_set_exit_on_disconnect): new function
265 2003-09-21 Havoc Pennington <hp@pobox.com>
267 Get matching rules mostly working in the bus; only actually
268 parsing the rule text remains. However, the client side of
269 "signal connections" hasn't been started, this patch is only the
272 * dbus/dispatch.c: fix for the matching rules changes
274 * bus/driver.c (bus_driver_handle_remove_match)
275 (bus_driver_handle_add_match): send an ack reply from these
278 * glib/dbus-gproxy.c (dbus_gproxy_begin_call): fix order of
279 arguments, reported by Seth Nickell
281 * bus/config-parser.c (append_rule_from_element): support
282 eavesdrop=true|false attribute on policies so match rules
283 can be prevented from snooping on the system bus.
285 * bus/dbus-daemon-1.1.in: consistently use terminology "sender"
286 and "destination" in attribute names; fix some docs bugs;
287 add eavesdrop=true|false attribute
289 * bus/driver.c (bus_driver_handle_add_match)
290 (bus_driver_handle_remove_match): handle AddMatch, RemoveMatch
293 * dbus/dbus-protocol.h (DBUS_SERVICE_ORG_FREEDESKTOP_BROADCAST): get
294 rid of broadcast service concept, signals are just always broadcast
296 * bus/signals.c, bus/dispatch.c, bus/connection.c, bus/bus.c:
297 mostly implement matching rules stuff (currently only exposed as signal
300 2003-09-21 Mark McLoughlin <mark@skynet.ie>
302 * doc/dbus-specification.sgml: Change the header field name
303 to be an enum and update the rest of the spec to reference
304 the fields using the conventinal name.
306 * dbus/dbus-protocol.h: update to reflect the spec.
308 * doc/TODO: add item to remove the 4 byte alignment requirement.
310 * dbus/dbus-message.c: Remove the code to generalise the
311 header/body length and serial number header fields as named
312 header fields so we can reference field names using the
314 (append_int_field), (append_uint_field), (append_string_field):
315 Append the field name as a byte rather than four chars.
316 (delete_int_or_uint_field), (delete_string_field): reflect the
317 fact that the field name and typecode now occupy 4 bytes instead
319 (decode_string_field), (decode_header_data): update to reflect
320 protocol changes and move the field specific encoding from
321 decode_string_field() back into decode_header_data().
323 * dbus/dbus-internals.[ch]: (_dbus_header_field_to_string):
324 Add utility to aid debugging.
326 * dbus/dbus-message-builder.c:
327 (append_string_field), (_dbus_message_data_load): Update to
328 reflect protocol changes; Change the FIELD_NAME directive
329 to HEADER_FIELD and allow it to take the field's conventional
330 name rather than the actual value.
332 * test/data/*/*.message: Update to use HEADER_FIELD instead
333 of FIELD_NAME; Always align the header on an 8 byte boundary
334 *before* updating the header length.
336 2003-09-15 Havoc Pennington <hp@pobox.com>
338 * dbus/dbus-pending-call.c: add the get/set object data
339 boilerplate as for DBusConnection, etc. Use generic object data
340 for the notify callback.
342 * glib/dbus-gparser.c (parse_node): parse child nodes
344 * tools/dbus-viewer.c: more hacking on the dbus-viewer
346 * glib/dbus-gutils.c (_dbus_gutils_split_path): add a file to
347 contain functions shared between the convenience lib and the
350 * glib/Makefile.am (libdbus_glib_1_la_LDFLAGS): add
351 -export-symbols-regex to the GLib library
353 * dbus/dbus-object-tree.c (_dbus_object_tree_dispatch_and_unlock):
354 fix the locking in here, and add a default handler for
355 Introspect() that just returns sub-nodes.
357 2003-09-14 Havoc Pennington <hp@pobox.com>
359 * glib/dbus-gthread.c (dbus_g_thread_init): rename to make g_foo
360 rather than gfoo consistent
362 * glib/dbus-gproxy.h: delete for now, move contents to
363 dbus-glib.h, because the include files don't work right since we
364 aren't in the dbus/ subdir.
366 * glib/dbus-gproxy.c (dbus_gproxy_send): finish implementing
367 (dbus_gproxy_end_call): finish
368 (dbus_gproxy_begin_call): finish
370 * glib/dbus-gmain.c (dbus_set_g_error): new
372 * glib/dbus-gobject.c (handle_introspect): include information
373 about child nodes in the introspection
375 * dbus/dbus-connection.c (dbus_connection_list_registered): new
376 function to help in implementation of introspection
378 * dbus/dbus-object-tree.c
379 (_dbus_object_tree_list_registered_and_unlock): new function
381 2003-09-12 Havoc Pennington <hp@pobox.com>
383 * glib/dbus-gidl.h: add common base class for all the foo_info
386 * tools/dbus-viewer.c: add GTK-based introspection UI thingy
389 * test/Makefile.am: try test srcdir -ef . in addition to test
390 srcdir = ., one of them should work (yeah lame)
392 * glib/Makefile.am: build the "idl" parser stuff as a convenience
395 * glib/dbus-gparser.h: make description_load routines return
396 NodeInfo* not Parser*
398 * Makefile.am (SUBDIRS): build test dir after all library dirs
400 * configure.in: add GTK+ detection
402 2003-09-07 Havoc Pennington <hp@pobox.com>
404 * Make Doxygen contented.
406 2003-09-07 Havoc Pennington <hp@pobox.com>
408 * doc/dbus-specification.sgml: more updates
410 2003-09-06 Havoc Pennington <hp@pobox.com>
412 * doc/dbus-specification.sgml: partial updates
414 * bus/dbus-daemon-1.1.in: fix the config file docs for the
415 zillionth time; hopefully I edited the right file this time.
417 * bus/config-parser.c (append_rule_from_element): support
418 send_type, send_path, receive_type, receive_path
420 * bus/policy.c: add message type and path to the list of things
421 that can be "firewalled"
423 2003-09-06 Havoc Pennington <hp@pobox.com>
425 * dbus/dbus-connection.c (dbus_connection_register_fallback): add this
426 (dbus_connection_register_object_path): make this not handle
427 messages to paths below the given path
429 2003-09-03 Havoc Pennington <hp@pobox.com>
431 * test/glib/Makefile.am: add this with random glib-linked test
434 * glib/Makefile.am: remove the random test programs from here,
435 leave only the unit tests
437 * glib/dbus-gobject.c (_dbus_gobject_test): add test for
438 uscore/javacaps conversion, and fix
439 (get_object_property, set_object_property): change to .NET
440 convention for mapping props to methods, set_FooBar/get_FooBar,
441 since one language has such a convention we may as well copy it.
442 Plus real methods in either getFooBar or get_foo_bar style won't
443 collide with this convention.
445 2003-09-01 Havoc Pennington <hp@pobox.com>
447 * glib/dbus-gparser.c: implement
449 * glib/dbus-gobject.c: start implementing skeletons support
451 * configure.in: when disabling checks/assert, also define
452 G_DISABLE_ASSERT and G_DISABLE_CHECKS
454 2003-09-01 Havoc Pennington <hp@pobox.com>
456 * glib/Makefile.am: rearrange a bunch of files and get "make
457 check" framework set up
459 2003-08-31 Havoc Pennington <hp@pobox.com>
461 * fix build with --disable-tests
463 2003-08-30 Havoc Pennington <hp@pobox.com>
465 * dbus/dbus-connection.c: purge DBusMessageHandler
467 * dbus/dbus-message-handler.c: remove DBusMessageHandler, just
468 use callbacks everywhere
470 2003-08-30 Havoc Pennington <hp@pobox.com>
472 * test/data/valid-config-files/system.d/test.conf: change to
473 root for the user so warnings don't get printed
475 * dbus/dbus-message.c: add dbus_message_get_path,
476 dbus_message_set_path
478 * dbus/dbus-object-tree.c (do_test_dispatch): add test of
479 dispatching to a path
481 * dbus/dbus-string.c (_dbus_string_validate_path): add
483 * dbus/dbus-marshal.c (_dbus_demarshal_object_path): implement
484 (_dbus_marshal_object_path): implement
486 * dbus/dbus-protocol.h (DBUS_HEADER_FIELD_PATH): new header field
487 to contain the path to the target object
488 (DBUS_HEADER_FIELD_SENDER_SERVICE): rename
489 DBUS_HEADER_FIELD_SENDER to explicitly say it's the sender service
491 2003-08-30 Havoc Pennington <hp@pobox.com>
493 * dbus/dbus-object-tree.c: write tests and fix the discovered bugs
495 2003-08-29 Havoc Pennington <hp@pobox.com>
497 * dbus/dbus-object-tree.c: modify to allow overlapping paths to be
499 (struct DBusObjectSubtree): shrink this
500 a lot, since we may have a lot of them
501 (_dbus_object_tree_free_all_unlocked): implement
502 (_dbus_object_tree_dispatch_and_unlock): implement
504 2003-08-29 Havoc Pennington <hp@pobox.com>
506 * dbus/dbus-internals.h: fix _DBUS_N_GLOBAL_LOCKS
508 2003-08-28 Havoc Pennington <hp@pobox.com>
512 * dbus/dbus-connection.c: port to no ObjectID, create a
513 DBusObjectTree, rename ObjectTree to ObjectPath in public API
515 * dbus/dbus-connection.h (struct DBusObjectTreeVTable): delete
516 everything except UnregisterFunction and MessageFunction
518 * dbus/dbus-marshal.c: port away from DBusObjectID,
519 add DBUS_TYPE_OBJECT_PATH
521 * dbus/dbus-object-registry.[hc], dbus/dbus-object.[hc],
522 dbus/dbus-objectid.[hc]: remove these, we are moving to
523 path-based object IDs
525 2003-08-25 Havoc Pennington <hp@pobox.com>
527 Just noticed that dbus_message_test is hosed, I wonder when I
528 broke that. I thought make check was passing earlier...
530 * dbus/dbus-object-tree.c: add new "object tree" to match DCOP
531 container tree, will replace most of dbus-object-registry
533 * dbus/dbus-string.c (_dbus_string_append_printf_valist): fix C99
536 2003-08-19 Havoc Pennington <hp@pobox.com>
538 * dbus/dbus-message.c (decode_string_field): support FIELD_SENDER
539 (dbus_message_is_error): fix this function
541 * bus/dbus-daemon-1.1: clarify logic on when <deny>/<allow> rules
544 * bus/policy.c (bus_client_policy_check_can_receive): fix code to
545 reflect clarified man page
546 (bus_client_policy_check_can_send): ditto
548 * bus/session.conf.in: fixup
550 * bus/system.conf.in: fixup
552 2003-08-18 Havoc Pennington <hp@redhat.com>
554 * dbus/dbus-hash.c (_dbus_hash_table_insert_two_strings): fix
556 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
557 dumb bug created earlier (wrong order of args to
558 decode_header_data())
560 * tools/dbus-send.c: port
562 * tools/dbus-print-message.c (print_message): port
564 * test/data/*messages: port all messages over
566 * dbus/dbus-message-builder.c: support including
569 * bus/driver.c: port over
571 * bus/dispatch.c: port over to new stuff
573 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
574 rename disconnect signal to "Disconnected"
576 2003-08-17 Havoc Pennington <hp@pobox.com>
578 This doesn't compile yet, but syncing up so I can hack on it from
579 work. What are branches for if not broken code? ;-)
581 * dbus/dbus-protocol.h: remove DBUS_HEADER_FIELD_NAME, add
582 DBUS_HEADER_FIELD_INTERFACE, DBUS_HEADER_FIELD_MEMBER,
583 DBUS_HEADER_FIELD_ERROR_NAME
585 * dbus/dbus-hash.c: Introduce DBUS_HASH_TWO_STRINGS as hack to use
586 for the interface+member pairs
587 (string_hash): change to use g_str_hash algorithm
588 (find_direct_function, find_string_function): refactor these to
591 * dbus/dbus-message.c: port all of this over to support
592 interface/member fields instead of name field
594 * dbus/dbus-object-registry.c: port over
596 * dbus/dbus-string.c (_dbus_string_validate_interface): rename
597 from _dbus_string_validate_name
599 * bus/dbus-daemon-1.1: change file format for the
600 <deny>/<allow> stuff to match new message naming scheme
602 * bus/policy.c: port over
604 * bus/config-parser.c: parse new format
606 2003-08-16 Havoc Pennington <hp@pobox.com>
608 * dbus/dbus-object-registry.c (add_and_remove_objects): remove
611 * glib/dbus-gproxy.c: some hacking
613 2003-08-15 Havoc Pennington <hp@redhat.com>
615 * dbus/dbus-pending-call.c (dbus_pending_call_block): implement
617 * dbus/dbus-connection.c
618 (dbus_connection_send_with_reply_and_block): factor out internals;
619 change to convert any error replies to DBusError instead of
620 returning them as a message
622 2003-08-15 Havoc Pennington <hp@pobox.com>
624 * dbus/dbus-connection.c,
625 dbus/dbus-pending-call.c: Finish the pending call stuff
627 2003-08-14 Havoc Pennington <hp@redhat.com>
629 * dbus/dbus-pending-call.c: start on new object that will replace
630 DBusMessageHandler and ReplyHandlerData for tracking outstanding
633 * dbus/dbus-gproxy.c: start on proxy object used to communicate
634 with remote interfaces
636 * dbus/dbus-gidl.c: do the boring boilerplate in here
638 2003-08-12 Havoc Pennington <hp@pobox.com>
640 * bus/dispatch.c (bus_dispatch): make this return proper
641 DBusHandlerResult to avoid DBUS_ERROR_UNKNOWN_METHOD
643 * dbus/dbus-errors.c (dbus_set_error): use
644 _dbus_string_append_printf_valist
646 * dbus/dbus-string.c (_dbus_string_append_printf_valist)
647 (_dbus_string_append_printf): new
649 * dbus/dbus-errors.h (DBUS_ERROR_UNKNOWN_MESSAGE): change to
652 * dbus/dbus-connection.c (dbus_connection_dispatch): handle
653 DBUS_HANDLER_RESULT_NEED_MEMORY; send default error reply if a
654 message is unhandled.
656 2003-08-11 Havoc Pennington <hp@pobox.com>
658 * bus/test.c (client_disconnect_handler): change to return
659 HANDLED (would have been REMOVE_MESSAGE)
661 * dbus/dbus-object.h (enum DBusHandlerResult): rename to
662 HANDLED/NOT_YET_HANDLED instead of
663 REMOVE_MESSAGE/ALLOW_MORE_HANDLERS to make it clearer how it
666 2003-08-10 Havoc Pennington <hp@pobox.com>
668 * tools/dbus-send.c (main): add --type argument, for now
669 supporting only method_call and signal types.
671 * tools/dbus-print-message.c: print message type
673 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
674 init connection->objects
676 * doc/dbus-specification.sgml: fix sgml
678 * bus/*.c: port over to object-instance API changes
680 * test/test-service.c: ditto
682 * dbus/dbus-message.c (dbus_message_create_header): allow #NULL
683 name, we will have to fix up the rest of the code to also handle
685 (dbus_message_new): generic message-creation call
686 (set_string_field): allow appending name field
688 2003-08-06 Havoc Pennington <hp@pobox.com>
690 * dbus/dbus-object-registry.c: implement signal connection
693 * dbus/dbus-connection.c (_dbus_connection_unref_unlocked): new
695 * dbus/dbus-internals.c (_dbus_memdup): new function
697 2003-08-02 Havoc Pennington <hp@pobox.com>
699 * dbus/dbus-message.c (dbus_message_get_no_reply)
700 (dbus_message_set_no_reply): add these and remove
701 set_is_error/get_is_error
703 * dbus/dbus-protocol.h, doc/dbus-specification.sgml:
704 remove the ERROR flag, since there's now an ERROR type
706 2003-08-01 Havoc Pennington <hp@pobox.com>
708 * dbus/dbus-object-registry.c (_dbus_object_registry_handle_and_unlock):
711 * dbus/dbus-message.c (dbus_message_get_type): new function
713 * doc/dbus-specification.sgml: add "type" byte to messages
715 2003-08-01 Havoc Pennington <hp@pobox.com>
717 * dbus/dbus-protocol.h (DBUS_MESSAGE_TYPE_*): introduce
718 a message type enum to distinguish kinds of message
719 (DBUS_HEADER_FLAG_NO_REPLY_EXPECTED): flag for a message
720 that need not be replied to
722 2003-08-01 Havoc Pennington <hp@pobox.com>
724 * dbus/dbus-marshal.c: adapt to DBusObjectID changes
725 (unpack_8_octets): fix no-64-bit-int bug
727 * dbus/dbus-object-registry.c (validate_id): validate the
728 connection ID bits, not just the instance ID.
730 * dbus/dbus-connection.c (_dbus_connection_init_id): initialize
731 the connection-global 33 bits of the object ID
733 * dbus/dbus-object-registry.c (info_from_entry): fill in
734 object ID in the new way
736 * dbus/dbus-objectid.h: rather than high/low bits, specifically
737 define server/client/instance bits.
739 2003-07-30 Havoc Pennington <hp@pobox.com>
741 * dbus/dbus-connection.c (dbus_connection_register_object): fix
744 2003-07-13 Havoc Pennington <hp@pobox.com>
746 * dbus/dbus-object.h (struct DBusObjectVTable): add padding
747 fields to DBusObjectVTable and DBusObjectInfo
749 2003-07-12 Havoc Pennington <hp@pobox.com>
751 * dbus/dbus-object-registry.c: implement unit test,
752 fix bugs discovered in process
754 * dbus/dbus-connection.c: remove handler_table and
755 register_handler(), add DBusObjectRegistry usage
757 * dbus/dbus-objectid.c (dbus_object_id_is_null)
758 (dbus_object_id_set_null): new functions
760 2003-07-08 Havoc Pennington <hp@pobox.com>
762 * dbus/dbus-object.c: implement some of this
764 * dbus/dbus-object-registry.c
765 (_dbus_object_registry_add_and_unlock): fill in the object_id out
767 (_dbus_object_registry_new): handle OOM
769 2003-07-08 Havoc Pennington <hp@pobox.com>
771 * dbus/dbus-object.h: sketch out an API for registering objects
772 with a connection, that allows us to use as little as 24 bytes
773 per object and lets application code represent an object in
776 * dbus/dbus-object-registry.c: implement the hard bits of the
777 DBusConnection aspect of object API. Not yet wired up.
779 2003-07-06 Havoc Pennington <hp@pobox.com>
781 * dbus/dbus-marshal.c (_dbus_marshal_set_object_id): new function
782 (_dbus_marshal_object_id): new
783 (_dbus_demarshal_object_id): new
784 (_dbus_marshal_get_arg_end_pos): support object ID type, and
785 consolidate identical switch cases. Don't conditionalize handling
786 of DBUS_TYPE_UINT64, need to handle the type always.
787 (_dbus_marshal_validate_arg): consolidate identical cases, and
788 handle DBUS_TYPE_OBJECT_ID
790 * dbus/dbus-objectid.c: new file with DBusObjectID data type.
792 * dbus/dbus-protocol.h: add DBUS_TYPE_OBJECT_ID
794 2003-09-28 Havoc Pennington <hp@pobox.com>
798 2003-09-28 Havoc Pennington <hp@pobox.com>
800 * doc/Makefile.am (dbus-specification.html): testing a funky hack
801 to work with Debian db2html
803 2003-09-28 Havoc Pennington <hp@pobox.com>
807 * doc/Makefile.am (dbus-test-plan.html): accept nonexistence of
808 stylesheet-images for benefit of Debian
810 Change back to using filesystem-linked sockets for the system
811 bus, so only root can create the default system bus address.
813 * bus/system.conf.in: change to use
814 DBUS_SYSTEM_BUS_DEFAULT_ADDRESS
816 * dbus/Makefile.am (INCLUDES): remove DBUS_SYSTEM_BUS_PATH define
819 * configure.in: define DBUS_SYSTEM_BUS_DEFAULT_ADDRESS
820 here, and AC_DEFINE DBUS_SYSTEM_PATH
822 2003-08-09 Anders Carlsson <andersca@codefactory.se>
828 2003-08-09 Anders Carlsson <andersca@codefactory.se>
830 * doc/dbus-specification.sgml:
831 Add activation reply values.
833 2003-08-05 Havoc Pennington <hp@redhat.com>
837 2003-08-05 Anders Carlsson <andersca@codefactory.se>
839 * glib/dbus-gmain.c: (watch_fd_new), (watch_fd_ref),
840 (watch_fd_unref), (dbus_gsource_check), (dbus_gsource_dispatch),
841 (add_watch), (remove_watch), (create_source):
842 Refcount fds, fixes some reentrancy issues.
844 2003-07-30 Havoc Pennington <hp@redhat.com>
846 * dbus/dbus-bus.c (init_connections_unlocked): fix default system
847 bus address to be abstract if we have abstract sockets
851 2003-07-28 Havoc Pennington <hp@redhat.com>
853 * bus/messagebus.in: fix to avoid processname/servicename
854 confusion, from Michael Kearey
855 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=100965
857 2003-07-23 Havoc Pennington <hp@pobox.com>
859 * dbus/dbus-message.c (dbus_message_iter_get_named):
860 fix from Andy Hanton to remove broken "+1"
862 2003-07-16 Havoc Pennington <hp@pobox.com>
864 * tools/dbus-launch.c (babysit): close stdout/stderr in the
865 babysitter process, as suggested by Thomas Leonard, so
866 an "eval `dbus-launch --exit-with-session`" will actually
869 2003-07-16 Havoc Pennington <hp@pobox.com>
871 * configure.in: print out EXPANDED_* variables in the summary at
872 the end; clean up the code that computes EXPANDED_ variables and
873 get the ones using exec_prefix right. Should make things work
874 when you build without --prefix
876 2003-06-29 Havoc Pennington <hp@pobox.com>
878 * mono/Test.cs (class Test): fire up a main loop and run it
880 * mono/DBus.cs (DBus): don't g_thread_init since it can only be
881 done once, the app has to do it
883 2003-06-26 Havoc Pennington <hp@pobox.com>
885 * mono/Connection.cs: set up connection with the glib main loop
887 2003-07-01 Havoc Pennington <hp@redhat.com>
889 * doc/dbus-specification.sgml: clarify the format of a type code,
890 change suggested by Jim Blandy
892 2003-06-29 Miloslav Trmac <mitr@volny.cz>
895 * tools/Makefile.am: Don't assume srcdir == builddir.
897 * dbus/dbus-memory.c (dbus_realloc): Don't check guards after shrinking
899 (_dbus_memory_test): New function.
900 * dbus/dbus-test.h: Add _dbus_memory_test ().
901 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): Call it.
903 * dbus/dbus-message.c (decode_header_data): Use %.4s instead
905 (dbus_message_new): Remove obsolete @todo.
907 * dbus/dbus-marshal.c (_dbus_marshal_set_int64)
908 (_dbus_marshal_set_uint64): Fix comment.
910 * dbus/dbus-message.c (append_int_field, append_uint_field): Don't
911 hardcode FIELD_REPLY_SERIAL.
913 * dbus/dbus-mainloop.c (_dbus_loop_remove_watch)
914 (_dbus_loop_remove_timeout): Cast function pointers to (void *) for %p
916 * configure.in: Add -D_POSIX_C_SOURCE=199309L -DBSD_SOURCE to CFLAGS
917 and disable DBUS_USE_ATOMIC_INT_486 when --enable-ansi is used
919 2003-06-24 Havoc Pennington <hp@pobox.com>
921 * mono/*.cs: Use IntPtr.Zero instead of ((IntPtr) 0)
923 2003-06-23 Anders Carlsson <andersca@codefactory.se>
929 * gcj/TestMessage.java: (TestMessage), (TestMessage.main):
930 * gcj/org/.cvsignore:
931 * gcj/org/Makefile.am:
932 * gcj/org/freedesktop/.cvsignore:
933 * gcj/org/freedesktop/Makefile.am:
934 * gcj/org/freedesktop/dbus/.cvsignore:
935 * gcj/org/freedesktop/dbus/Makefile.am:
936 * gcj/org/freedesktop/dbus/Message.java: (Message),
938 * gcj/org/freedesktop/dbus/natMessage.cc:
939 Fix the build system.
941 2003-06-22 Havoc Pennington <hp@pobox.com>
943 * mono/Connection.cs: add more bindings
945 * dbus/dbus-threads.c (dbus_threads_init): allow calling this
948 2003-06-22 Havoc Pennington <hp@pobox.com>
950 * mono/Connection.cs, mono/DBus.cs, mono/Error.cs:
951 Start wrapping more stuff.
953 2003-06-22 Havoc Pennington <hp@pobox.com>
955 * mono/Message.cs: implement Message.Wrap() that ensures we only
956 have a single C# wrapper per DBusMessage, assuming it works which
959 * dbus/dbus-message.c (dbus_message_allocate_data_slot): new
960 (dbus_message_free_data_slot): new
961 (dbus_message_set_data): new
962 (dbus_message_get_data): new
964 2003-06-22 Havoc Pennington <hp@pobox.com>
966 * dbus/dbus-dataslot.c (_dbus_data_slot_allocator_unref)
967 (_dbus_data_slot_allocator_alloc): rework these to keep a
968 reference count on each slot and automatically manage a global
969 slot ID variable passed in by address
971 * bus/bus.c: convert to new dataslot API
973 * dbus/dbus-bus.c: convert to new dataslot API
975 * dbus/dbus-connection.c: convert to new dataslot API
977 * dbus/dbus-server.c: convert to new dataslot API
979 * glib/dbus-gmain.c: ditto
983 * bus/connection.c: ditto
985 2003-06-22 Anders Carlsson <andersca@codefactory.se>
987 * configure.in: Add AM_PROG_GCJ and move AM_PROG_LIBTOOL
988 after the gcj checks so that the correct configuration tags
989 will be added to libtool.
991 * dbus-glib-1.pc.in: No need to specify any includes since
992 dbus-1.pc.in has those.
994 2003-06-22 Havoc Pennington <hp@pobox.com>
996 * mono/*, gcj/*, configure.in, Makefile.am:
997 Check in makefiles and subdirs for mono and gcj bindings.
998 Neither binding actually exists, just trying to get through
999 all the build and other boring bits.
1001 2003-06-21 Philip Blundell <philb@gnu.org>
1003 * tools/dbus-monitor.1: Updated.
1005 * tools/dbus-send.1: Likewise.
1007 2003-06-20 Anders Carlsson <andersca@codefactory.se>
1009 * dbus/dbus-transport-unix.c (unix_handle_watch): Check
1010 for hangup and error after checking read so we won't discard
1011 pending data if both hangup and read are set.
1013 2003-06-19 Philip Blundell <philb@gnu.org>
1015 * tools/dbus-print-message.c (print_message): Handle BOOLEAN.
1017 * tools/dbus-send.c: Accept both --system and --session.
1019 * tools/dbus-monitor.c: Same here.
1021 2003-06-19 Anders Carlsson <andersca@codefactory.se>
1023 * glib/dbus-glib.h: Fix so that dbus-glib.h can be used
1024 from C++ (Patch by Miloslav Trmac).
1026 2003-06-15 Joe Shaw <joe@assbarn.com>
1028 * configure.in: Check for socklen_t.
1030 * dbus/dbus-sysdeps.c: Define socklen_t if it's not defined.
1032 * test/test-segfault.c: Add #include <sys/time.h>
1034 * tools/Makefile.am: Add DBUS_X_CFLAGS to the INCLUDES since
1035 dbus-launch needs it.
1037 2003-06-09 Havoc Pennington <hp@redhat.com>
1039 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): don't use
1040 SUN_LEN, it breaks abstract socket usage
1042 * dbus/dbus-internals.c (_dbus_verbose_real): only print PID at
1045 2003-06-04 Havoc Pennington <hp@pobox.com>
1047 * dbus/dbus-server.c (dbus_server_listen): allow abstract sockets
1048 using unix:abstract=/foo, and when listening in a tmpdir
1049 i.e. unix:tmpdir=/tmp, always use abstract sockets if we can.
1051 * dbus/dbus-transport.c (_dbus_transport_open): support
1054 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
1055 support abstract sockets
1057 * dbus/dbus-transport-unix.c
1058 (_dbus_transport_new_for_domain_socket): support abstract sockets
1060 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket): add "abstract"
1061 toggle as an argument, implement abstract namespace support
1062 (_dbus_listen_unix_socket): ditto
1064 * configure.in: add --enable-abstract-sockets and implement
1065 a configure check for autodetection of the right value.
1067 2003-06-01 Havoc Pennington <hp@pobox.com>
1069 * tools/dbus-cleanup-sockets.c: add utility to clean up sockets
1070 in /tmp (though on Linux this will end up being useless,
1071 when we add abstract namespace support)
1073 * configure.in: define DBUS_SESSION_SOCKET_DIR in addition to
1076 2003-05-28 Colin Walters <walters@verbum.org>
1078 * tools/dbus-monitor.c (main): Fix silly typo (s/--session/--system/).
1080 2003-05-18 Anders Carlsson <andersca@codefactory.se>
1082 * dbus/dbus-message.c (dbus_message_new): Remove @todo.
1084 2003-05-17 Colin Walters <walters@gnu.org>
1086 * tools/dbus-send.c: Don't exit with an error code if --help was
1087 passed. Default to using the session bus instead of the system
1090 * tools/dbus-launch.c: Ditto.
1092 * tools/dbus-monitor.c: Ditto.
1094 * tools/dbus-send.1: Update with new arguments.
1096 * tools/dbus-launch.c: Emit code to export variables. New
1097 arguments -s and -c to specify shell syntax, and a bit of code to
1098 autodetect syntax. Also, allow specifying a program to run.
1100 * tools/dbus-launch.1: Update with new arguments.
1102 * tools/dbus-send.1: Ditto.
1104 * tools/dbus-monitor.1: Ditto.
1106 2003-05-17 Havoc Pennington <hp@pobox.com>
1108 * bus/config-parser.c (merge_included): merge in policies from
1109 child configuration file.
1111 * bus/policy.c (bus_policy_merge): function to merge two policies
1114 2003-05-16 Havoc Pennington <hp@redhat.com>
1116 * dbus/dbus-connection.c: disable verbose lock spew
1118 * tools/dbus-send.c: add --print-reply command line option
1120 * tools/dbus-print-message.h (print_message): new util function
1121 shared by dbus-send and dbus-monitor
1123 * tools/dbus-monitor.c (handler_func): exit on disconnect
1125 * dbus/dbus-transport-unix.c (do_reading): if the transport is
1126 disconnected, don't try to use the read_watch
1128 * dbus/dbus-watch.c (dbus_watch_get_enabled): assert watch != NULL
1129 so we can find this bug more easily
1131 2003-05-16 Havoc Pennington <hp@redhat.com>
1133 * bus/policy.c (free_rule_list_func): avoid a crash when passed
1134 NULL as DBusHashTable is annoyingly likely to do.
1136 2003-05-16 Colin Walters <walters@verbum.org>
1138 * tools/dbus-monitor.c: Add --session argument and usage()
1141 * tools/dbus-monitor.1: Update with new --session arg.
1143 * bus/Makefile.am (install-data-hook): Create
1144 $(libdir)/dbus-1.0/services so that the session bus is happy.
1146 2003-05-15 Havoc Pennington <hp@redhat.com>
1148 * dbus/dbus-sysdeps.c (_dbus_atomic_dec, _dbus_atomic_inc): work
1149 on non-x86. ifdef's are evil.
1151 2003-05-15 Havoc Pennington <hp@redhat.com>
1153 * configure.in: 0.11
1157 * bus/Makefile.am (initddir): apparently we are supposed to put
1158 init scripts in /etc/rc.d/init.d not /etc/init.d
1160 * bus/Makefile.am: remove the "you must --enable-tests to make
1161 check" as it broke distcheck
1163 * bus/Makefile.am (install-data-hook): create /etc/dbus-1/system.d
1165 2003-05-13 James Willcox <jwillcox@gnome.org>
1168 * bus/activation.c: (bus_activation_service_created),
1169 (bus_activation_activate_service):
1170 * bus/driver.c: (bus_driver_send_service_deleted),
1171 (bus_driver_send_service_created), (bus_driver_send_service_lost),
1172 (bus_driver_send_service_acquired),
1173 (bus_driver_send_welcome_message),
1174 (bus_driver_handle_list_services):
1175 * bus/session.conf.in:
1176 * dbus/dbus-bus.c: (dbus_bus_acquire_service),
1177 (dbus_bus_service_exists), (dbus_bus_activate_service):
1180 Add some convenience API which lets you activate a service, and did a
1181 bunch of s/0/DBUS_TYPE_INVALID/ in calls to dbus_message_append_args()
1182 and dbus_message_get_args()
1184 2003-05-11 Havoc Pennington <hp@pobox.com>
1186 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix to avoid
1187 calling _dbus_marshal_validate_arg() for every byte in a byte
1190 * dbus/dbus-message-handler.c: use atomic reference counting to
1191 reduce number of locks slightly; the global lock in here sucks
1193 * dbus/dbus-connection.c
1194 (_dbus_connection_update_dispatch_status_and_unlock): variant of
1195 update_dispatch_status that can be called with lock held; then use
1196 in a couple places to reduce locking/unlocking
1197 (dbus_connection_send): hold the lock over the whole function
1198 instead of acquiring it twice.
1200 * dbus/dbus-timeout.c (_dbus_timeout_new): handle OOM
1202 * bus/connection.c (bus_connections_setup_connection): fix access
1203 to already-freed memory.
1205 * dbus/dbus-connection.c: keep a little cache of linked list
1206 nodes, to avoid using the global linked list alloc lock in the
1207 normal send-message case. Instead we just use the connection lock
1208 that we already have to take.
1210 * dbus/dbus-list.c (_dbus_list_find_last): new function
1212 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec):
1213 change to use a struct for the atomic type; fix docs,
1214 they return value before increment, not after increment.
1216 * dbus/dbus-string.c (_dbus_string_append_4_aligned)
1217 (_dbus_string_append_8_aligned): new functions to try to
1218 microoptimize this operation.
1219 (reallocate_for_length): break this out of set_length(), to
1220 improve profile info, and also so we can consider inlining the
1223 * dbus/dbus-message.c (dbus_message_new_empty_header): init data
1224 strings with some preallocation, cuts down on our calls to realloc
1225 a fair bit. Though if we can get the "move entire string to empty
1226 string" optimization below to kick in here, it would be better.
1228 * dbus/dbus-string.c (_dbus_string_move): just call
1229 _dbus_string_move_len
1230 (_dbus_string_move_len): add a special case for moving
1231 an entire string into an empty string; we can just
1232 swap the string data instead of doing any reallocs.
1233 (_dbus_string_init_preallocated): new function
1235 2003-05-11 Havoc Pennington <hp@pobox.com>
1237 Write a "test-profile" that does echo client-server with threads;
1238 profile reveals lock contention, memcpy/realloc of buffers, and
1239 UTF-8 validation as hot spots. 20% of lock contention eliminated
1240 with dbus_atomic_inc/dec implementation on x86. Much remaining
1241 contention is global mempool locks for GList and DBusList.
1243 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec): add
1246 * dbus/dbus-connection.c (struct DBusConnection): use
1247 dbus_atomic_t for the reference count
1249 * dbus/dbus-message.c (struct DBusMessage): declare
1250 dbus_atomic_t values as volatile
1252 * configure.in: code to detect ability to use atomic integer
1253 operations in assembly, from GLib patch
1255 * dbus/dbus-internals.c (_dbus_verbose_real): call getpid every
1256 time, tired of it being wrong in threads and forked processes
1258 * glib/test-profile.c: a little program to bounce messages back
1259 and forth between threads and eat CPU
1261 * dbus/dbus-connection.c: add debug spew macros for debugging
1262 thread locks; include config.h at top; fix deadlock in
1263 dbus_connection_flush()
1265 2003-05-08 Havoc Pennington <hp@pobox.com>
1267 * dbus/dbus-spawn.c: s/_exit/exit/ because it was keeping gcov
1268 data from getting written, and there wasn't a good reason to
1271 * test/decode-gcov.c (mark_inside_dbus_build_tests): don't count
1272 dbus_verbose lines in test coverage
1273 (main): add list of functions sorted by # of untested blocks
1274 to the coverage report
1276 * dbus/dbus-mempool.c: put some test-only code in DBUS_BUILD_TESTS
1278 * dbus/dbus-marshal.c (_dbus_marshal_test): extend test coverage
1280 * dbus/dbus-message-handler.c (_dbus_message_handler_test):
1281 extend test coverage
1283 * test/data/auth/cancel.auth-script: test canceling an
1286 * dbus/Makefile.am: remove dbus-server-debug.[hc] for now, as they
1287 aren't used. in CVS history if we end up needing them.
1289 2003-05-04 Havoc Pennington <hp@pobox.com>
1291 * dbus/dbus-message-handler.c (_dbus_message_handler_test): add
1294 * dbus/dbus-marshal.c (_dbus_demarshal_string_array): fix this
1295 function, which assumed length was in # of strings, not bytes
1297 * dbus/dbus-message.c (_dbus_message_test): add tests for some
1300 * dbus/dbus-connection.c
1301 (_dbus_connection_queue_received_message): disable function for
1302 now, we are only using it in test mode
1304 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
1305 remove a mistaken FIXME
1307 2003-05-04 Havoc Pennington <hp@pobox.com>
1309 * dbus/dbus-connection.c (dbus_connection_preallocate_send):
1310 unlock mutex on successful return, patch from Anders Gustafsson
1312 2003-05-04 Havoc Pennington <hp@pobox.com>
1314 * dbus-glib-1.pc.in (Requires): fix dependencies, from
1317 2003-05-04 Havoc Pennington <hp@pobox.com>
1319 * tools/dbus-launch.c: implement
1321 * bus/main.c (main), bus/bus.c (bus_context_new):
1322 implement --print-pid and --fork
1324 2003-05-03 Havoc Pennington <hp@redhat.com>
1326 * dbus/dbus-address.c (dbus_parse_address): fix bug when a key in
1327 the address had no value, and add to test suite. Fix and
1328 regression test from Miloslav Trmac
1330 2003-05-03 Havoc Pennington <hp@pobox.com>
1332 * dbus/dbus-watch.c (dbus_watch_handle): warn and return if a
1333 watch is invalid when handled
1335 * tools/Makefile.am, tools/dbus-launch.c, tools/dbus-launch.1: add
1336 dbus-launch utility to launch the bus from a shell script. Didn't
1337 actually implement dbus-launch yet, it's just a placeholder still.
1339 2003-05-03 Havoc Pennington <hp@pobox.com>
1341 * bus/Makefile.am, bus/dbus-daemon-1.1.in: man page for the
1342 daemon; also documents daemon config file, so replaces
1343 doc/config-file.txt. Corrected some stuff from config-file.txt in
1344 the process of moving it.
1346 2003-05-03 Havoc Pennington <hp@pobox.com>
1348 * tools/Makefile.am, tools/dbus-send.1, tools/dbus-monitor.1:
1351 2003-05-03 Colin Walters <walters@verbum.org>
1353 * dbus/dbus-sysdeps.c (fill_user_info): Test against
1354 DBUS_UID_UNSET to determine whether to do a uid lookup or not.
1356 * Makefile.am: Update to use new .pc versioning scheme.
1358 2003-05-02 Havoc Pennington <hp@redhat.com>
1360 * bus/system.conf.in: allow send/receive to/from message bus
1363 2003-04-30 Havoc Pennington <hp@redhat.com>
1365 * configure.in: print a note when building with unit tests and
1368 2003-04-30 Havoc Pennington <hp@redhat.com>
1370 * Makefile.am: add a check-local that complains if you didn't
1371 configure with --enable-tests
1373 2003-04-29 Havoc Pennington <hp@redhat.com>
1375 * glib/dbus-gmain.c: docs cleanups
1377 * dbus/dbus-types.h: add docs on int64 types
1379 * dbus/dbus-memory.c: fix docs to avoid putting private API in
1380 public API docs section
1382 2003-04-29 Havoc Pennington <hp@redhat.com>
1384 * dbus-1.pc.in, dbus-glib-1.pc.in: rename these from
1385 dbus-1.0.pc.in, dbus-glib-1.0.pc.in. As these change with the
1386 parallel install API version, not with the D-BUS package version.
1388 * HACKING: move some of README over here
1390 * README: updates, and document API/ABI policy
1392 * configure.in: reindentation
1394 2003-04-29 Havoc Pennington <hp@redhat.com>
1396 * dbus/dbus.h: add "you have to define DBUS_API_SUBJECT_TO_CHANGE
1397 to use this library" to be sure people have the right
1400 2003-04-28 Havoc Pennington <hp@redhat.com>
1402 * configure.in: add --enable-docs which by default is auto yes if
1403 doxygen and db2html found, no otherwise; but can be forced on/off
1405 * doc/Makefile.am: conditionalize whether to build docs on
1408 2003-04-28 Havoc Pennington <hp@redhat.com>
1410 * configure.in: 0.10
1414 * bus/system.conf.in: add <includedir>system.d</includedir>
1416 * dbus/dbus-userdb.c (_dbus_user_database_lookup): fix bug when
1417 username was provided but not uid
1419 * bus/config-parser.c (struct BusConfigParser): keep track of
1420 whether the parser is toplevel or was included; change some
1421 of the error handling if it's included.
1423 2003-04-27 Havoc Pennington <hp@pobox.com>
1427 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
1428 report correct status if we finish processing authentication
1429 inside this function.
1431 * bus/activation.c (try_send_activation_failure): use
1432 bus_transaction_send_error_reply
1434 * bus/connection.c (bus_connection_get_groups): return an error
1435 explaining the problem
1437 * bus/bus.c (bus_context_check_security_policy): implement
1438 restriction here that inactive connections can only send the
1439 hello message. Also, allow bus driver to send anything to
1442 * bus/connection.c (bus_connection_complete): create the
1443 BusClientPolicy here instead of on-demand.
1444 (bus_connection_get_policy): don't return an error
1446 * dbus/dbus-message.c (dbus_message_new_error_reply): allow NULL
1447 sender field in message being replied to
1449 * bus/bus.c (bus_context_check_security_policy): fix silly typo
1450 causing it to return FALSE always
1452 * bus/policy.c (bus_client_policy_check_can_send): fix bug where
1453 we checked sender rather than destination
1455 2003-04-25 Havoc Pennington <hp@redhat.com>
1457 test suite is slightly hosed at the moment, will fix soon
1459 * bus/connection.c (bus_connections_expire_incomplete): fix to
1460 properly disable the timeout when required
1461 (bus_connection_set_name): check whether we can remove incomplete
1462 connections timeout after we complete each connection.
1464 * dbus/dbus-mainloop.c (check_timeout): fix this up a bit,
1465 probably still broken.
1467 * bus/services.c (bus_registry_acquire_service): implement max
1468 number of services owned, and honor allow/deny rules on which
1469 services a connection can own.
1471 * bus/connection.c (bus_connection_get_policy): report errors here
1473 * bus/activation.c: implement limit on number of pending
1476 2003-04-25 Havoc Pennington <hp@redhat.com>
1478 * dbus/dbus-transport.c (_dbus_transport_get_unix_user): fix bug
1479 where we used >= 0 instead of != DBUS_UID_UNSET.
1481 2003-04-25 Havoc Pennington <hp@redhat.com>
1483 * glib/dbus-gmain.c (remove_watch): fix for a crash when watches
1484 were toggled without add/remove, fix from Anders Gustafsson
1486 2003-04-24 Havoc Pennington <hp@redhat.com>
1488 * test/data/valid-config-files/basic.conf: add <limit> tags to
1491 * bus/config-parser.h, bus/config-parser.c, bus/bus.c: Implement
1492 <limit> tag in configuration file.
1494 2003-04-24 Havoc Pennington <hp@redhat.com>
1496 * bus/dispatch.c: somehow missed some name_is
1498 * dbus/dbus-timeout.c (_dbus_timeout_set_enabled)
1499 (_dbus_timeout_set_interval): new
1501 * bus/connection.c (bus_connections_setup_connection): record time
1502 when each connection is first set up, and expire them after the
1503 auth timeout passes.
1505 2003-04-24 Havoc Pennington <hp@redhat.com>
1507 * dbus/dbus-message.c (dbus_message_name_is): rename
1508 (dbus_message_service_is): rename
1509 (dbus_message_sender_is): rename
1510 (dbus_message_get_service): rename
1512 2003-04-24 Havoc Pennington <hp@redhat.com>
1514 * configure.in: add --enable-checks
1516 * dbus/dbus-message.c (dbus_message_new): reverse name/service arguments
1518 * dbus/dbus-connection.c (dbus_connection_preallocate_send): fix
1519 to use thread locks.
1520 (_dbus_connection_handler_destroyed_locked): move some private
1521 functions into proper docs group
1523 * dbus/dbus-internals.h: add _dbus_return_if_fail,
1524 _dbus_return_val_if_fail
1526 Throughout: use dbus_return_if_fail
1528 2003-04-23 James Willcox <jwillcox@gnome.org>
1531 * glib/dbus-gmain.c: (add_timeout), (wakeup_main), (create_source),
1532 (dbus_connection_setup_with_g_main),
1533 (dbus_server_setup_with_g_main):
1534 * glib/test-dbus-glib.c: (main):
1535 * glib/test-thread-client.c: (main):
1536 * glib/test-thread-server.c: (new_connection_callback), (main):
1537 * tools/dbus-monitor.c: (main):
1539 Added a GMainContext argument to dbus_connection_setup_with_g_main()
1540 and dbus_server_setup_with_g_main().
1542 2003-04-20 Havoc Pennington <hp@pobox.com>
1544 * doc/dbus-specification.sgml: document the restrictions on
1545 message and service names
1547 2003-04-22 Havoc Pennington <hp@redhat.com>
1549 * dbus/dbus-message.c, dbus/dbus-marshal.c: add 64-bit integer
1550 support, and do some code cleanups to share more code and
1551 speed up array marshal/demarshal.
1553 * dbus-1.0.pc.in (Cflags): put libdir include file in cflags
1555 * configure.in: generate dbus-arch-deps.h
1557 * dbus/dbus-protocol.h (DBUS_TYPE_INT64, DBUS_TYPE_UINT64): add
1560 2003-04-22 Havoc Pennington <hp@redhat.com>
1562 * test/data/valid-messages/opposite-endian.message: fix test
1563 to use proper type for rply field
1565 * test/data/invalid-messages: add tests for below validation
1567 * dbus/dbus-message.c (decode_header_data): validate field types,
1568 and validate that named fields are valid names
1569 (decode_name_field): consider messages in the
1570 org.freedesktop.Local. namespace to be invalid.
1572 * dbus/dbus-string.c (_dbus_string_validate_name): new
1574 2003-04-19 Havoc Pennington <hp@pobox.com>
1576 * bus/driver.c (bus_driver_handle_hello): check limits and
1577 return an error if they are exceeded.
1579 * bus/connection.c: maintain separate lists of active and inactive
1580 connections, and a count of each. Maintain count of completed
1581 connections per user. Implement code to check connection limits.
1583 * dbus/dbus-list.c (_dbus_list_unlink): export
1585 * bus/bus.c (bus_context_check_security_policy): enforce a maximum
1586 number of bytes in the message queue for a connection
1588 2003-04-18 Havoc Pennington <hp@pobox.com>
1590 * dbus/dbus-auth.c (record_mechanisms): memleak fixes
1592 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): fix some
1595 * dbus/dbus-keyring.c (add_new_key): fix a memleak, and
1596 on realloc be sure to update the pointer in the keyring
1598 * dbus/dbus-string.c (_dbus_string_zero): compensate for align
1599 offset to avoid writing to unallocated memory
1601 * dbus/dbus-auth.c (process_rejected): return FALSE if we fail to
1602 try the next mechanism, so we properly handle OOM
1604 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): fix double-free
1606 (_dbus_keyring_new): fix OOM bug
1607 (_dbus_keyring_new_homedir): always set error; impose a maximum
1608 number of keys we'll load from the file, mostly to speed up the
1609 test suite and make its OOM checks more useful, but also for
1612 * dbus/dbus-auth.c (process_error_server): reject authentication
1613 if we get an error from the client
1614 (process_cancel): on cancel, send REJECTED, per the spec
1615 (process_error_client): send CANCEL if we get an error from the
1618 2003-04-18 Havoc Pennington <hp@pobox.com>
1620 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix UMR in verbose
1623 * dbus/dbus-auth.c (handle_client_data_cookie_sha1_mech): fix OOM
1626 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): only whine
1627 about DBUS_TEST_HOMEDIR once
1629 * bus/Makefile.am (TESTS_ENVIRONMENT): put DBUS_TEST_HOMEDIR in
1632 * bus/dispatch.c (bus_dispatch_sha1_test): actually load sha1
1633 config file so we test the right thing
1635 Throughout: assorted docs improvements
1637 2003-04-18 Havoc Pennington <hp@pobox.com>
1639 * glib/dbus-gmain.c: adapt to watch changes
1641 * bus/bus.c, bus/activation.c, etc.: adjust to watch changes
1643 * dbus/dbus-server.h: remove dbus_server_handle_watch
1645 * dbus/dbus-connection.h: remove dbus_connection_handle_watch
1647 * dbus/dbus-watch.c (dbus_watch_handle): change DBusWatch to work
1648 like DBusTimeout, so we don't need dbus_connection_handle_watch
1651 2003-04-17 Havoc Pennington <hp@redhat.com>
1653 * dbus/dbus-userdb.c, dbus/dbus-sysdeps.c: redo all the passwd
1654 database usage so it all goes via the DBusUserDatabase cache.
1656 2003-04-17 Havoc Pennington <hp@redhat.com>
1658 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix logic so that if
1659 there was an OOM watch we skipped, we always return TRUE so we
1660 iterate again to have a look at it again. Fixes test suite hang.
1661 Code rearrangement also lets us lose some memset and only iterate
1662 over callbacks once.
1664 * bus/driver.c (bus_driver_handle_message): sense of test for
1667 2003-04-16 Havoc Pennington <hp@pobox.com>
1669 * doc/dbus-specification.sgml: make spec say serials are unsigned
1671 * dbus/dbus-message.h: change message serials to unsigned
1673 * dbus/dbus-connection.c: adapt to message serials being unsigned
1675 2003-04-15 Havoc Pennington <hp@pobox.com>
1677 * bus/bus.c: create and keep around a shared DBusUserDatabase
1680 * bus/connection.c (bus_connection_get_groups): don't cache
1681 groups for user in the connection object, since user database
1682 object now does that.
1684 2003-04-16 Havoc Pennington <hp@redhat.com>
1686 * dbus/dbus-message.c (_dbus_message_add_size_counter): keep a
1687 list of size counters
1688 (_dbus_message_loader_putback_message_link): put back a popped link
1690 * dbus/dbus-connection.c
1691 (dbus_connection_set_max_live_messages_size): rename
1693 (dbus_connection_get_outgoing_size): get size of outgoing
1695 (_dbus_connection_set_connection_counter): remove this cruft
1697 2003-04-14 Havoc Pennington <hp@redhat.com>
1699 * dbus/dbus-userdb.c: user database abstraction, mostly to get
1700 caching, but at some point we might want to be able to use a
1703 * bus/dispatch.c (bus_dispatch_sha1_test): add a test that uses
1704 SHA1 conf file to test the sha1 auth mechanism, since the regular
1705 test always uses EXTERNAL when available.
1708 test/data/valid-config-files/debug-allow-all-sha1.conf.in:
1709 add conf file that requires use of sha1 auth
1711 2003-04-13 Havoc Pennington <hp@pobox.com>
1713 * tools/dbus-send.c, tools/dbus-monitor.c: two utility programs
1714 from Philip Blundell to send messages and monitor them.
1716 2003-04-13 Havoc Pennington <hp@pobox.com>
1718 * dbus/dbus-mainloop.c: fix some reentrancy issues by refcounting
1721 * test/data/valid-config-files/debug-allow-all.conf.in: allow all
1724 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
1725 fix to only recover unused bytes if we're already authenticated
1726 (_dbus_transport_get_is_authenticated): fix to still mark us
1727 authenticated if there are unused bytes.
1729 * bus/dispatch.c: implement security policy checking
1731 * bus/connection.c (bus_transaction_send_from_driver): new
1733 * bus/bus.c (bus_context_check_security_policy): new
1735 * bus/dispatch.c (send_service_nonexistent_error): delete this,
1736 now we just set the DBusError and it gets converted to an error
1739 * bus/connection.c (allow_user_function): enable code using actual
1740 data from the config file
1742 * bus/policy.c (list_allows_user): handle wildcard rules for
1743 user/group connection perms
1745 2003-04-13 Havoc Pennington <hp@pobox.com>
1747 * bus/config-parser.c: Load up the BusPolicy and BusPolicyRules
1749 * dbus/dbus-sysdeps.c (_dbus_get_user_id): new function
1751 * bus/policy.c (bus_policy_append_mandatory_rule)
1752 (bus_policy_append_default_rule, bus_policy_append_user_rule)
1753 (bus_policy_append_group_rule): new functions
1755 2003-04-12 Havoc Pennington <hp@pobox.com>
1757 * bus/config-parser.c (bus_config_parser_new): fix a memleak
1759 * dbus/dbus-sysdeps.c: change DBusCredentials to use longs for
1760 the pid/gid/uid, just for paranoia.
1762 * test/break-loader.c (randomly_do_n_things): find a byte
1763 containing a type code, and randomly change it to a different
1766 2003-04-12 Havoc Pennington <hp@pobox.com>
1768 * bus/policy.h: change BusPolicy to be the thing from the config
1769 file, and rename old BusPolicy to BusClientPolicy
1771 * bus/bus.c, bus/connection.c, bus/config-parser.c: change to
1772 match change in how policy works
1774 * dbus/dbus-internals.h: mark assert_not_reached as
1775 __attribute((noreturn))__
1777 2003-04-11 Havoc Pennington <hp@redhat.com>
1779 * doc/dbus-specification.sgml: fix a spot with the wrong name for
1780 the broadcast service. Use boolean return for ServiceExists.
1782 2003-04-11 Havoc Pennington <hp@redhat.com>
1784 * configure.in: add another directory to look for qt in.
1786 2003-04-11 Havoc Pennington <hp@redhat.com>
1788 * AUTHORS: add Colin Walters
1790 2003-04-11 Havoc Pennington <hp@redhat.com>
1796 2003-04-11 Havoc Pennington <hp@redhat.com>
1798 * bus/messagebus.in: remove pid file when stopping the
1799 message bus, since the bus won't have privileges to remove it
1802 2003-04-11 Havoc Pennington <hp@redhat.com>
1804 * bus/bus.c (bus_context_new): move credentials change after
1807 2003-04-11 Havoc Pennington <hp@pobox.com>
1809 * test/decode-gcov.c: add "below average functions" to the
1810 coverage report, and change how some of the code works.
1812 * bus/test-main.c: bracket some stuff in DBUS_BUILD_TESTS so it's
1813 not in the coverage stats.
1815 * test/test-service.c (main): use _dbus_verbose not fprintf in a
1816 couple places so running the test suite doesn't result in megaspam.
1818 2003-04-11 Havoc Pennington <hp@pobox.com>
1820 * bus/dispatch.c (check_existent_service_activation): accept a no
1821 memory error in a place we didn't before
1823 * bus/test.c (bus_test_run_everything): remove hacky "do it twice
1824 in case the first one failed," since the test suite is less
1827 2003-04-10 Havoc Pennington <hp@pobox.com>
1829 * bus/dispatch.c (check_segfault_service_activation): add test
1830 for launching an executable that just crashes.
1832 * test/test-segfault.c (main): try setting coredumpsize to 0 so we
1833 don't leave a million cores. We'll see how portable this is.
1835 2003-04-10 Havoc Pennington <hp@pobox.com>
1837 * dbus/dbus-spawn.c (_dbus_spawn_async_with_babysitter): move all
1838 the possible parent failures before we fork, so that we don't
1839 fail to create a babysitter after creating the child.
1841 * bus/activation.c (bus_activation_activate_service): kill child
1842 if we don't successfully complete the activation.
1844 2003-04-10 Havoc Pennington <hp@redhat.com>
1846 * dbus/dbus-connection.c (dbus_connection_flush): don't spin on
1847 the connection if it's disconnected
1849 * bus/activation.c (bus_activation_service_created): use new
1850 transaction features to roll back removal of pending activation if
1851 we don't successfully create the service after all. Don't remove
1852 pending activation if the function fails.
1854 * dbus/dbus-list.c (_dbus_list_insert_before_link)
1855 (_dbus_list_insert_after_link): new code to facilitate
1858 * dbus/dbus-hash.c (_dbus_hash_table_insert_string_preallocated):
1859 new functionality, so we can preallocate the ability to insert
1862 * bus/connection.c (bus_transaction_add_cancel_hook): new function
1863 allowing us to put custom hooks in a transaction to be used for
1864 cancelling said transaction
1866 * doc/dbus-specification.sgml: add some discussion of secondary
1867 service owners, and disallow zero-length service names
1869 * bus/services.c (bus_registry_acquire_service): new function,
1870 splits out part of bus_driver_handle_acquire_service() and fixes
1871 a bug where we didn't remove the service doing the acquiring
1872 from the secondary queue if we failed to remove the current owner
1873 from the front of the queue.
1875 2003-04-10 Alexander Larsson <alexl@redhat.com>
1877 * doc/dbus-specification.sgml:
1878 s/org.freedesktop.Broadcast/org.freedesktop.DBus.Broadcast/
1880 2003-04-10 Alexander Larsson <alexl@redhat.com>
1885 Added files to cvsignore
1887 * dbus/dbus-message.h:
1888 * dbus/dbus-message.c: (dbus_message_iter_get_named):
1889 Make get_named() take two out argument and return a boolean.
1890 (dbus_message_iter_get_args_valist):
1891 Update usage of get_named().
1892 (dbus_message_iter_append_byte):
1894 (dbus_message_iter_append_named)
1896 (message_iter_test), (check_message_handling_type), (_dbus_message_test):
1899 2003-04-10 Alexander Larsson <alexl@redhat.com>
1901 * dbus/dbus-marshal.[ch]:
1902 Add array_type_pos argument to _dbus_marshal_validate_arg.
1903 Let you pass a NULL end_pos to _dbus_marshal_validate_type.
1905 * dbus/dbus-message.[ch]:
1906 Multi-dimensional arrays have full type specification in the
1907 outermost array. Iter code re-arranged to handle this.
1908 Added some more iter tests.
1910 * doc/dbus-specification.sgml:
1913 Update new array encoding description.
1914 Correct DBUS_SERVICE_FLAGS_REPLACE_EXISTING description.
1916 * test/data/invalid-messages/array-with-mixed-types.message:
1917 * test/data/valid-messages/array-of-array-of-uint32.message:
1918 Change to the new array format.
1920 * test/data/invalid-messages/too-short-dict.message:
1923 * test/data/valid-messages/recursive-types.message:
1924 Fix up and extend test.
1926 2003-04-10 Havoc Pennington <hp@pobox.com>
1928 * bus/dispatch.c: lots of fixes
1930 * dbus/dbus-mainloop.c (_dbus_loop_dispatch): export
1931 (_dbus_loop_iterate): remove old "quit if no callbacks" code,
1932 that was crack, broke the test service.
1934 * dbus/dbus-transport.c (_dbus_transport_open): fix error
1935 handling to avoid piling up errors if we get a failure on the
1938 * dbus/dbus-internals.c (_dbus_real_assert_not_reached): include
1939 pid in assertion failures.
1941 * dbus/dbus-mainloop.c (_dbus_loop_iterate): use static arrays up
1942 to some fixed size of file descriptor array. Don't return TRUE
1943 anytime a timeout exists, that led to lots of busy loop silliness
1946 2003-04-09 Havoc Pennington <hp@redhat.com>
1948 * dbus/dbus-mainloop.c (check_timeout): fix timeouts, I thought
1949 I'd checked this in earlier but hadn't.
1951 2003-04-09 Havoc Pennington <hp@redhat.com>
1953 * bus/dispatch.c (bus_dispatch_test): get a bit further through
1954 the activation test (man this is getting old!)
1956 2003-04-09 Havoc Pennington <hp@redhat.com>
1958 * test/test-utils.c: use dispatch status function to fix this up
1960 * bus/connection.c (connection_watch_callback): don't dispatch
1962 (connection_timeout_callback): don't dispatch from here
1963 (bus_connections_setup_connection): set the dispatch status function
1964 (bus_connection_disconnected): unset it
1966 * dbus/dbus-mainloop.c (_dbus_loop_queue_dispatch): new function
1967 used to add a connection to be dispatched
1968 (_dbus_loop_iterate): do the dispatching at the end of each
1971 * dbus/dbus-connection.c
1972 (dbus_connection_set_dispatch_status_function): new function
1973 allowing us to fix up main loop usage
1974 (_dbus_connection_last_unref): free all the various function
1976 (dbus_connection_dispatch): call the DispatchStatusFunction
1977 whenever this function returns
1978 (dbus_connection_handle_watch): call DispatchStatusFunction
1979 (dbus_connection_send_with_reply_and_block): call DispatchStatusFunction
1980 (reply_handler_timeout): call DispatchStatusFunction
1981 (dbus_connection_flush): call DispatchStatusFunction
1983 2003-04-09 Havoc Pennington <hp@redhat.com>
1985 * dbus/dbus-bus.c (dbus_bus_register): fix up error handling and
1988 * bus/dispatch.c (check_service_activated): fix bug in test
1990 * dbus/dbus-mainloop.c (check_timeout): fix this up
1992 * dbus/dbus-internals.c (_dbus_verbose_real): include PID in
1993 verbose output so we can sort out output from different processes,
1994 e.g. in the activation case.
1996 2003-04-08 Colin Walters <walters@gnu.org>
1998 * bus/bus.c (struct BusContext) [pidfile]: New member, to store
2000 (bus_context_new): Set it.
2001 (bus_context_unref): Use it to delete the pid file.
2003 2003-04-08 Havoc Pennington <hp@redhat.com>
2005 * test/data/invalid-messages/array-with-mixed-types.message:
2006 regression test that fails for the moment
2008 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): reorder
2009 tests for convenience
2011 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): don't allow
2012 array of nil, it broke things.
2014 * test/data/invalid-messages/array-of-nil.message: regression test
2016 * test/data/valid-messages/array-of-array-of-uint32.message:
2017 happened to write this so added it to suite
2019 2003-04-08 Havoc Pennington <hp@redhat.com>
2021 * bus/driver.c (bus_driver_handle_acquire_service): init
2022 retval/reply before checking name
2024 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add a
2025 recursion depth argument
2027 * dbus/dbus-message.h (struct DBusMessageIter): put some padding
2028 in the public struct for future extension
2030 * dbus/dbus-message-builder.c (_dbus_message_data_load): fix
2033 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix a verbose
2036 * doc/dbus-specification.sgml: fix typo
2038 2003-04-08 Alexander Larsson <alexl@redhat.com>
2040 Implemented recursive types, named types and new-style iters
2043 * glib/test-thread-client.c: (thread_func):
2044 * glib/test-thread-server.c: (handle_test_message):
2045 * test/test-service.c: (handle_echo):
2054 * dbus/dbus-internals.c: (_dbus_type_to_string):
2055 Update for new types.
2057 * dbus/dbus-marshal.[ch]:
2058 Implement recursive types and the new marshalling format.
2059 Remove hardcoded dict marshalling.
2060 Marshal named types.
2062 * dbus/dbus-message-builder.c:
2064 Remove references to old types
2066 * dbus/dbus-message.[ch]:
2067 New non-refcounted iter API that supports recursive iters.
2068 Use iters for appending, including support for recursive
2070 Add byte and named type support.
2071 Update everything to new marshalling formats.
2072 Add tests for new API.
2074 * dbus/dbus-protocol.h:
2075 Remove old array types.
2076 Add types: BYTE, ARRAY, DICT, NAMED
2078 * dbus/dbus-string.c:
2079 * dbus/dbus-sysdeps.c:
2080 Make parse_double locale safe.
2082 * dbus/dbus-test-main.c:
2088 * doc/dbus-specification.sgml:
2091 * test/data/incomplete-messages/missing-body.message:
2092 * test/data/invalid-messages/bad-boolean.message:
2093 * test/data/invalid-messages/bad-boolean-array.message:
2094 * test/data/invalid-messages/boolean-array-length-too-long.message-raw:
2095 * test/data/invalid-messages/boolean-has-no-value.message-raw:
2096 * test/data/invalid-messages/too-short-dict.message:
2097 * test/data/valid-messages/dict-simple.message:
2098 * test/data/valid-messages/dict.message:
2099 * test/data/valid-messages/emptiness.message:
2100 * test/data/valid-messages/lots-of-arguments.message:
2101 * test/data/valid-messages/no-padding.message:
2102 * test/data/valid-messages/recursive-types.message:
2103 Add missing NAME fields
2104 Fix up dicts & arrays
2106 * test/data/invalid-messages/dict-with-nil-value.message:
2107 Removed, this is not invalid anymore.
2109 * test/data/valid-messages/recursive-types.message:
2110 Add new test for deeply recursive types.
2112 2003-04-07 Havoc Pennington <hp@pobox.com>
2114 * bus/driver.c (bus_driver_handle_acquire_service): return an
2115 error if you try to acquire a service that starts with ':'
2117 2003-04-07 Havoc Pennington <hp@redhat.com>
2119 * doc/dbus-specification.sgml: require that base service names
2120 start with ':' and that the base service is created/deleted
2121 as first and last things a connection does on the bus
2123 * bus/dispatch.c (check_existent_service_activation): lots more
2124 work on the activation test; it doesn't fully pass yet...
2126 * test/test-service.c (main): fix so we don't memleak the
2127 connection to the message bus
2128 (filter_func): accept a message asking us to exit
2130 2003-04-06 Havoc Pennington <hp@pobox.com>
2132 * qt/Makefile.am (dbusinclude_HEADERS): install dbus-qt.h,
2135 * configure.in: fixes to Qt detection from Colin Walters
2137 * doc/Makefile.am: Only remove generated docbook dirs if they
2138 exist, from Colin Walters
2140 * dbus/dbus-bus.c: change how we set well-known connections to
2141 NULL, so that it works if a single connection is stored in
2142 two well-known array slots.
2144 * test/Makefile.am: remove a lot of stuff that isn't immediately
2145 useful, it's in CVS history if we want it.
2147 * test/test-service.c: use dbus-mainloop instead of that
2150 2003-04-06 Havoc Pennington <hp@pobox.com>
2152 * dbus/Makefile.am: split lists of sources into stuff that goes in
2153 the library, util functions that go in the lib and are also used
2154 elsewhere, and util functions that are used in tests/daemon but
2155 don't go in the lib.
2157 * dbus/dbus-mainloop.h, dbus/dbus-mainloop.c: move bus/loop.[hc]
2158 here so it can be used in test binaries also
2160 2003-04-06 Havoc Pennington <hp@pobox.com>
2162 * dbus/dbus-sysdeps.c (_dbus_become_daemon): write the pidfile
2163 here in the parent process, so we can return an error if it
2164 fails. Also, move some of the code into the child so the parent
2165 is less hosed if we fail midway through.
2167 * bus/bus.c (bus_context_new): move pidfile detection further up
2168 in the function, before we start overwriting sockets and such.
2170 * bus/messagebus.in: adjust this a bit, not sure if it will work.
2172 * configure.in: add --with-system-pid-file and --with-system-socket
2174 2003-04-06 Colin Walters <walters@verbum.org>
2176 * configure.in (DBUS_SYSTEM_PID_FILE): New variable.
2178 * bus/system.conf.in: Declare a pidfile.
2180 * bus/bus.c (bus_context_new): Test for an existing pid file, and
2181 create one (if appropriate).
2183 * bus/config-parser.c (enum ElementType) [ELEMENT_PIDFILE]: New.
2184 (struct BusConfigParser) [pidfile]: New.
2185 (element_type_to_name, merge_included, start_busconfig_child)
2186 (bus_config_parser_end_element, bus_config_parser_content): Handle it.
2187 (bus_config_parser_unref): Free it.
2188 (bus_config_parser_get_pidfile): New function.
2190 * bus/config-parser.h (_dbus_write_pid_file): Prototype.
2192 * dbus/dbus-errors.h (DBUS_ERROR_PIDFILE_EXISTS): New error.
2194 * dbus/dbus-sysdeps.c (_dbus_write_pid_file): New function.
2196 * dbus/dbus-sysdeps.h: Prototype it.
2198 2003-04-06 Havoc Pennington <hp@pobox.com>
2200 * bus/bus.c (bus_context_new): print the address in here, rather
2201 than in main(), because we need to do it before forking the daemon
2203 * bus/dispatch.c (send_service_nonexistent_error): set the sender
2204 on the service nonexistent error
2206 * bus/driver.c (bus_driver_handle_acquire_service): set the
2207 sender on the AcquireService reply
2209 * test/data/valid-config-files/debug-allow-all.conf.in: Make test
2210 server also listen on a UNIX socket so services can connect to it.
2212 2003-04-06 Havoc Pennington <hp@pobox.com>
2214 * dbus/dbus-threads.c: Redo how the fake debug mutexes are done
2215 so it detects deadlocks and also we actually init threads when
2218 2003-04-06 Havoc Pennington <hp@pobox.com>
2220 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
2221 save the domain socket name, and unlink it when we disconnect the
2222 server. Means that at least when we exit normally, we won't leave
2223 a bunch of junk in /tmp
2225 * dbus/dbus-transport-unix.c
2226 (_dbus_transport_new_for_domain_socket): code cleanup (nicer
2227 memory management). (I was making a real change here but then
2230 2003-04-06 Havoc Pennington <hp@pobox.com>
2232 * bus/bus.c (bus_context_new): fix wrong handling of
2233 server_data_slot_unref() in the error case.
2235 * dbus/dbus-internals.h (_dbus_assert): change so it passes
2236 "(condition) != 0" to _dbus_real_assert so that
2237 "_dbus_assert (pointer)" doesn't cause a warning
2239 * bus/main.c (main): accept --print-address option to print out
2240 the message bus address
2242 * dbus/dbus-sysdeps.c (_dbus_generate_random_ascii): export this
2244 * dbus/dbus-transport.c (_dbus_transport_open): special error for
2245 "tmpdir" option to unix: address on client side
2247 * dbus/dbus-server.c (dbus_server_listen): handle "tmpdir" option
2250 * configure.in (TEST_SOCKET_DIR): locate a temporary directory
2251 we can use to create sockets in the test suite.
2253 * bus/main.c (signal_handler): on SIGTERM, exit the daemon
2254 cleanly. To be used for testing.
2256 * dbus/dbus-spawn.c (babysit): use _dbus_set_signal_handler()
2258 * dbus/dbus-sysdeps.c (_dbus_set_signal_handler): new
2260 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
2261 handle trying to call this when there's no servers active
2263 2003-04-05 Havoc Pennington <hp@pobox.com>
2269 2003-04-05 Havoc Pennington <hp@pobox.com>
2271 * bus/bus.c (setup_server): fix this so dbus-daemon-1 doesn't
2272 crash on startup. Need to get "try starting the daemon"
2273 in the test suite I guess. ;-)
2275 * dbus/dbus-server.h, dbus/dbus-server.c: remove the stuff that
2276 tracked the number of open connections; it's better done in
2277 application-specific code as you want it to span all servers etc.
2279 2003-04-05 Havoc Pennington <hp@pobox.com>
2281 * bus/Makefile.am (install-data-hook): add missing DESTDIR,
2282 patch from Colin Walters
2284 2003-04-05 Havoc Pennington <hp@pobox.com>
2286 * doc/config-file.txt (Elements): fix docs of <auth> to reflect
2287 reality; in fact multiple mechanisms are allowed.
2289 * dbus/dbus-internals.c (_dbus_real_assert)
2290 (_dbus_real_assert_not_reached): move guts of _dbus_assert() and
2291 _dbus_assert_not_reached() into functions, so that they don't show
2292 up in basic block counts for test coverage, and don't use up as
2293 much disk space. Does mean slower execution speed though, so
2294 assumes --disable-asserts is the normal production case.
2296 2003-04-05 Havoc Pennington <hp@pobox.com>
2298 * test/Makefile.am (dist-hook): also dist *.in files
2304 2003-04-05 Havoc Pennington <hp@pobox.com>
2306 * dbus/dbus-string.c: docs warning
2308 * dbus/dbus-spawn.c: missing docs
2310 * dbus/dbus-memory.c (struct ShutdownClosure): missing docs
2312 2003-04-05 Havoc Pennington <hp@pobox.com>
2314 * bus/loop.c (bus_loop_iterate): fix the timeout code, using
2317 * dbus/dbus-spawn.c (_dbus_babysitter_unref): set sitter_pid
2318 to -1 once we've reaped the babysitter
2319 (_dbus_babysitter_handle_watch): do as much work as we can, not
2322 * bus/activation.c: add code using DBusBabysitter so that we
2323 handle it when a service fails to start up properly.
2324 (bus_activation_service_created): don't remove the activation
2325 entries as we go, just let them get removed when we free the pending
2326 activation. Unref reply messages after sending them.
2328 2003-04-05 Havoc Pennington <hp@pobox.com>
2330 * test/decode-gcov.c (main): print per-directory stats in the report
2332 * Makefile.am (coverage-report.txt): don't include test/* in gcov stats
2334 2003-04-05 Havoc Pennington <hp@pobox.com>
2336 * Makefile.am (coverage-report.txt): add target "coverage-report.txt"
2338 * test/decode-gcov.c: hack up a little program to suck data
2339 out of gcov files. Yes this is sort of silly.
2341 * configure.in: define something in config.h and do an
2342 AM_CONDITIONAL when gcov is enabled
2344 2003-04-04 Havoc Pennington <hp@redhat.com>
2346 * dbus/dbus-spawn.c, dbus/dbus-spawn.h: Change dbus_spawn to
2347 return a "babysitter" object that is used to monitor the status of
2348 the spawned process and reap it when required.
2350 * test/test-segfault.c, test/test-exit.c,
2351 test/test-sleep-forever.c: binaries that do various lame things,
2352 used in the test suite.
2354 * dbus/dbus-sysdeps.c: kill _dbus_errno_to_string()
2356 2003-04-03 Havoc Pennington <hp@pobox.com>
2358 * dbus/dbus-spawn.c: Move dbus-spawn into a separate file
2359 in preparation for modifying it, dbus-sysdeps is getting
2362 2003-04-03 Havoc Pennington <hp@redhat.com>
2364 * bus/loop.h, bus/loop.c: make the mainloop an object so we can
2367 * bus/*.[hc]: adapt to mainloop change
2369 2003-04-03 Havoc Pennington <hp@redhat.com>
2371 * bus/activation.c (load_directory): fix up memleaks
2372 (bus_activation_entry_free): free the entry
2374 * dbus/dbus-bus.c (dbus_bus_acquire_service): return an error if
2375 we get one from the message bus; fix memleaks.
2377 * dbus/dbus-message.c (dbus_set_error_from_message): new function
2379 2003-04-03 Havoc Pennington <hp@pobox.com>
2381 * bus/config-parser.c (bus_config_parser_unref): free
2382 list of mechanisms, bug discovered by test suite enhancements
2383 (putting system.conf and session.conf into suite)
2385 * test/Makefile.am, test/test-service.c: add placeholder for a
2386 test service that we'll activate as part of test suite. Doesn't
2389 * dbus/dbus-sysdeps.c (_dbus_setenv): support unsetenv by
2390 setting NULL value, and use system malloc not dbus_malloc()
2391 when we have unavoidable memleakage.
2393 * dbus/dbus-bus.c (dbus_bus_get): fix bug where bus type of 0
2394 didn't work, and support DBUS_BUS_ACTIVATION.
2396 * bus/activation.c (child_setup): pass our well-known bus type to
2399 * bus/config-parser.c: support <type> to specify well-known type
2401 * doc/dbus-specification.sgml: document the env variables to
2402 locate well-known buses and find service activator
2404 2003-04-02 Havoc Pennington <hp@redhat.com>
2406 * test/Makefile.am (all-local): add a rule to copy tests to
2407 builddir, so we can have generated tests. Use this to remove the
2408 silly hack for testing system.conf and session.conf. Will use this
2409 shortly to generate .service files pointing to test binaries.
2411 2003-04-02 Havoc Pennington <hp@redhat.com>
2413 * dbus/dbus-string.c (set_length): fix a bug - we allocated max of
2414 current alloc and needed new length, not max of the doubled
2415 allocation and needed new length. Also, when building tests,
2416 don't do the double-allocation stuff, just realloc every time.
2418 2003-04-02 Havoc Pennington <hp@redhat.com>
2420 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): include filenames
2422 (_dbus_string_get_dirname): new
2423 (_dbus_sysdeps_test): new
2424 (_dbus_directory_open): include dirnames in error messages
2426 * bus/config-parser.c: interpret <include> and <includedir> and
2427 <servicedir> relative to config file location if the given
2428 filename is not absolute.
2430 * dbus/dbus-string.c (_dbus_string_find_byte_backward): new
2432 2003-04-02 Havoc Pennington <hp@redhat.com>
2434 * bus/connection.c (bus_transaction_send_error_reply): set sender
2435 service for the error, and unref the reply on success
2437 * bus/activation.c: convert to use BusTransaction so OOM can be
2439 (bus_activation_service_created): set sender of the message
2441 2003-04-01 Havoc Pennington <hp@redhat.com>
2443 * bus/config-parser.c, bus/bus.c: implement <servicedir> and
2444 <includedir> (at least mostly)
2446 * dbus/dbus-sysdeps.c (_dbus_change_identity): set the group ID
2447 first, then the user ID
2449 2003-04-01 Havoc Pennington <hp@pobox.com>
2451 * dbus/dbus-server.c (dbus_server_set_auth_mechanisms): new
2454 * dbus/dbus-auth.c (_dbus_auth_set_mechanisms): new
2456 * dbus/dbus-internals.c (_dbus_dup_string_array): new function
2458 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): chmod the
2459 socket 0777, and unlink any existing socket.
2461 * bus/bus.c (bus_context_new): change our UID/GID and fork if
2462 the configuration file so specifies; set up auth mechanism
2465 * bus/config-parser.c (bus_config_parser_content): add support
2466 for <fork> option and fill in code for <auth>
2468 * bus/system.conf.in: add <fork/> to default configuration,
2469 and limit auth mechanisms to EXTERNAL
2471 * doc/config-file.txt (Elements): add <fork>
2473 * dbus/dbus-sysdeps.c (_dbus_become_daemon): new function
2474 (_dbus_change_identity): new function
2476 2003-03-31 Havoc Pennington <hp@redhat.com>
2478 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket)
2479 (_dbus_listen_unix_socket): fix off-by-one error in null
2480 termination spotted by Nalin
2482 2003-03-31 Havoc Pennington <hp@redhat.com>
2484 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): allow setting
2485 DBUS_TEST_HOMEDIR when tests are enabled, so we can test without
2486 having a real home directory available.
2488 2003-03-31 Havoc Pennington <hp@redhat.com>
2490 * bus/Makefile.am (install-data-hook): create /var/run/dbus
2492 * bus/messagebus.in: add init script for Red Hat /etc/init.d
2494 * configure.in: add support for specifying a style of init script
2497 2003-03-31 Havoc Pennington <hp@redhat.com>
2499 Fix some annoying DBusString API and fix all affected code.
2501 * dbus/dbus-string.c (_dbus_string_init): get rid of annoying
2503 (_dbus_string_get_data): change to return string instead of using
2505 (_dbus_string_get_const_data): ditto
2506 (_dbus_string_get_data_len): ditto
2507 (_dbus_string_get_const_data_len): ditto
2509 2003-03-31 Havoc Pennington <hp@redhat.com>
2511 * bus/main.c (main): fix up the command line arguments to be nicer
2513 2003-03-31 Havoc Pennington <hp@redhat.com>
2515 * dbus/Makefile.am (INCLUDES): use EXPANDED_LOCALSTATEDIR to
2516 define DBUS_SYSTEM_BUS_PATH as we want to compile in the same
2517 final location that lands in the config file
2519 * bus/config-loader-expat.c (bus_config_load): fix type of
2522 * doc/TODO: remove TODO item for dbus_bus_get()
2524 * dbus/dbus-bus.c (bus_data_free): add missing lock/unlock
2526 2003-03-31 Havoc Pennington <hp@pobox.com>
2528 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_domain_socket)
2529 (_dbus_transport_new_for_tcp_socket): these didn't need the "server"
2530 argument since they are always client side
2532 * dbus/dbus-server.c (dbus_server_get_address): new function
2534 * bus/main.c (main): take the configuration file as an argument.
2536 * test/data/valid-config-files/debug-allow-all.conf: new file to
2537 use with dispatch.c tests for example
2539 * bus/test-main.c (main): require test data dir
2541 * bus/bus.c (bus_context_new): change this to take a
2542 configuration file name as argument
2544 * doc/config-file.txt (Elements): add <servicedir>
2546 * bus/system.conf, bus/session.conf: new files
2548 * dbus/dbus-bus.c (dbus_bus_get): look for system bus on
2549 well-known socket if none set
2551 * configure.in: create system.conf and session.conf
2553 2003-03-30 Havoc Pennington <hp@pobox.com>
2555 * bus/config-parser.c: hacking
2557 * dbus/dbus-memory.c: don't use DBusList for the list of stuff
2558 to shut down, since it could cause weirdness with the DBusList
2561 * dbus/dbus-list.c (_dbus_list_test): add tests for the
2562 link-oriented stack routines
2563 (alloc_link): free the mempool if the first alloc from it fails
2565 * dbus/dbus-mempool.c (struct DBusMemBlock): fix alignment issue
2567 * dbus/dbus-string.c (UNICODE_VALID): sync new version of this
2569 (_dbus_string_skip_white): new
2571 * doc/config-file.txt (Elements): add <includedir>
2573 2003-03-28 Havoc Pennington <hp@pobox.com>
2575 * dbus/dbus-string.c (_dbus_string_copy_data_len)
2576 (_dbus_string_copy_data): new functions
2578 2003-03-28 Anders Carlsson <andersca@codefactory.se>
2580 * dbus/dbus-bus.c: (bus_data_free), (dbus_bus_get):
2584 * dbus/dbus-memory.c:
2587 2003-03-28 Havoc Pennington <hp@pobox.com>
2589 * bus/test.c (bus_test_flush_bus): remove the sleep from here,
2590 I think it may have just been superstition. Not sure.
2592 * dbus/dbus-string.c (_dbus_string_base64_decode): catch some OOM
2593 failures that were not being handled.
2595 * dbus/dbus-auth.c (process_auth): fix a memleak in OOM handling
2597 * dbus/dbus-memory.c: add ability to set number of mallocs in a
2598 row that will fail on out-of-memory.
2600 * dbus/dbus-internals.c (_dbus_test_oom_handling): convenience
2601 function for testing out-of-memory handling.
2603 * bus/config-loader-expat.c (memsuite): don't wrap the dbus
2604 allocation functions, they do map exactly to the expat ones.
2606 2003-03-27 Havoc Pennington <hp@redhat.com>
2608 * bus/config-loader-libxml.c (bus_config_load): add another error
2611 2003-03-26 Anders Carlsson <andersca@codefactory.se>
2614 Add note about automatic service activation.
2616 * doc/dbus-specification.sgml:
2617 Rename the specification and clarify a few things.
2619 2003-03-26 Anders Carlsson <andersca@codefactory.se>
2622 * dbus/dbus-address.c:
2624 * dbus/dbus-marshal.c:
2625 * dbus/dbus-server-debug-pipe.c:
2626 * dbus/dbus-transport-unix.c:
2627 Fix documentation warnings.
2629 2003-03-26 Havoc Pennington <hp@pobox.com>
2631 * bus/test-main.c, dbus/dbus-test.c (main): check memleaks
2632 after every test so it's quick and easy to see which leaked, and
2633 so we test multiple dbus_shutdown() calls
2635 * configure.in: change configure.in XML stuff to also support
2638 * config-loader-libxml.c: some hacking
2640 * config-loader-expat.c: some hacking
2642 * config-parser.c: some hacking, plus tests
2644 2003-03-25 Havoc Pennington <hp@redhat.com>
2646 * throughout - add more _DBUS_ASSERT_ERROR_IS_CLEAR
2648 * configure.in: add --with-xml option to specify XML library,
2649 right now only libxml is supported.
2651 * bus/config-loader-libxml.c, config-parser.c: sync some minor
2652 nonworking code between home and work, still just stubs
2654 2003-03-24 Havoc Pennington <hp@redhat.com>
2656 * dbus/dbus-sysdeps.c (_dbus_set_fd_nonblocking): move to this
2659 * dbus/dbus-errors.c (dbus_set_error, dbus_set_error_const): allow
2660 NULL argument for "message" if the error is a well-known one,
2661 fill in a generic message in this case.
2663 * dbus/dbus-errors.h (DBusResultCode): Kill DBusResultCode in
2666 * bus/test.c (bus_test_flush_bus): add
2668 * bus/policy.c (bus_policy_test): test code stub
2670 2003-03-24 Havoc Pennington <hp@pobox.com>
2672 * bus/connection.c (bus_connections_setup_connection): set up
2673 the "can this user connect" function, but it always returns
2674 TRUE until we have a config file parser so we can have a config
2675 file that allows connections.
2677 2003-03-23 Havoc Pennington <hp@pobox.com>
2679 * dbus/dbus-threads.c (dbus_mutex_new, dbus_condvar_new): with
2680 DBUS_BUILD_TESTS, actually alloc/free a block of memory for
2681 the mutex, so we can check for proper memory management
2684 * dbus/dbus-dataslot.c: remove the mutex from
2685 DBusDataSlotAllocator and lock it manually when using it,
2686 to simplify fitting it into the global slots framework.
2688 * dbus/dbus-threads.c (init_static_locks): rework how we're
2689 handling global locks so they are easily shut down.
2691 * bus/policy.c (bus_policy_append_rule): fix
2693 * bus/test-main.c (main): check for memleaks
2695 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): make
2696 test suite check for memleaks
2698 * dbus/dbus-memory.c: add support in test mode for tracking
2699 number of outstanding blocks
2701 2003-03-23 Havoc Pennington <hp@pobox.com>
2703 * bus/policy.c, bus/bus.c, bus/connection.c: implement allow/deny
2706 * dbus/dbus-hash.h: add ULONG hash keys
2708 * dbus/dbus-sysdeps.c (_dbus_get_groups): new
2709 (_dbus_get_group_id): new function
2711 2003-03-20 Havoc Pennington <hp@redhat.com>
2713 * dbus/dbus-connection.c (dbus_connection_set_unix_user_function):
2715 (dbus_connection_get_unix_user): new function
2717 2003-03-20 Havoc Pennington <hp@pobox.com>
2719 * bus/connection.c (bus_connection_send_oom_error): assert that
2720 message has a sender
2721 (connection_execute_transaction): ditto
2722 (bus_connection_preallocate_oom_error): fix to set the sender, and
2723 set recipient to the destination service, not the bus driver
2725 * bus/policy.c: hacking
2727 * dbus/dbus-message.c (dbus_message_service_is): new function
2728 (dbus_message_sender_is): new
2730 2003-03-19 Havoc Pennington <hp@redhat.com>
2732 * bus/policy.c: start sketching code for policy restrictions on
2733 what connections can do.
2735 2003-03-18 Havoc Pennington <hp@redhat.com>
2737 * doc/TODO: some notes on high-level todo items. Little nitpick
2738 stuff is all in @todo, so no need to add it here.
2740 * doc/config-file.txt: some notes on how config file might look
2742 2003-03-18 Anders Carlsson <andersca@codefactory.se>
2748 2003-03-17 Havoc Pennington <hp@redhat.com>
2750 * dbus/dbus-internals.h: add gcc attributes so that
2751 our printf-style functions warn on bad arguments to
2754 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): fix printf
2757 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
2760 2003-03-17 Havoc Pennington <hp@redhat.com>
2762 * bus/test-main.c (main): make it print something as it runs
2763 so make check doesn't look stuck
2765 * doc/negotiation.txt, doc/dbus-sasl-profile.txt: remove
2766 from CVS, now obsolete
2768 2003-03-17 Anders Carlsson <andersca@codefactory.se>
2770 * bus/dispatch.c: (bus_dispatch):
2771 Refetch the service name since it may have been reallocated
2772 when dbus_message_set_sender was called.
2774 * dbus/dbus-sysdeps.c: (_dbus_accept):
2775 Add address and address length variables and use them to stop
2776 valgrind from complaining.
2778 2003-03-17 Havoc Pennington <hp@pobox.com>
2780 All tests pass, no memleaks, no valgrind complaints.
2782 * bus/test.c: refcount handler_slot
2784 * bus/connection.c (bus_connections_new): refcount
2785 connection_data_slot
2787 * dbus/dbus-auth-script.c (_dbus_auth_script_run): delete unused
2788 bytes so that auth scripts pass.
2790 * bus/dispatch.c: init message_handler_slot so it gets allocated
2793 * bus/dispatch.c (message_handler_slot_ref): fix memleak
2795 * dbus/dbus-server-debug-pipe.c (_dbus_server_debug_pipe_new):
2796 dealloc server_pipe_hash when no longer used for benefit of
2799 * dbus/dbus-auth.c (process_command): memleak fix
2801 * bus/dispatch.c (check_hello_message): memleak fix
2803 2003-03-16 Havoc Pennington <hp@pobox.com>
2805 * dbus/dbus-bus.c (ensure_bus_data): fix double-unref of the data slot
2807 2003-03-17 Anders Carlsson <andersca@codefactory.se>
2809 * bus/activation.c (bus_activation_activate_service): Append
2810 the pending activation entry to the list of pending activations.
2812 2003-03-16 Havoc Pennington <hp@pobox.com>
2814 * bus/dispatch.c (bus_dispatch_test): remove double-unrefs of
2817 * dbus/dbus-address.c (create_entry): fix OOM handling when
2818 failing to alloc entry->method
2820 2003-03-16 Havoc Pennington <hp@pobox.com>
2822 * dbus/dbus-watch.c (_dbus_watch_new): handle failure to malloc
2825 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
2826 add some missing dbus_set_result
2828 * bus/dispatch.c (bus_dispatch_add_connection): handle failure to
2829 alloc the DBusMessageHandler
2831 * dbus/dbus-transport.c (_dbus_transport_disconnect): don't ref
2832 the transport here, since we call this from the finalizer; it
2833 resulted in a double-finalize.
2835 * dbus/dbus-transport.c (_dbus_transport_disconnect): fix a bug
2836 where we tried to use transport->connection that was NULL,
2837 happened when transport was disconnected early on due to OOM
2839 * bus/*.c: adapt to handle OOM for watches/timeouts
2841 * dbus/dbus-transport-unix.c: port to handle OOM during
2844 * dbus/dbus-auth.c (_dbus_auth_get_unused_bytes): return a
2845 reference to unused bytes instead of a copy
2847 * dbus/dbus-server.c (dbus_server_handle_watch): return FALSE for
2850 * dbus/dbus-connection.c (dbus_connection_handle_watch): return
2853 * dbus/dbus-timeout.c (dbus_timeout_handle): return FALSE for out
2856 2003-03-16 Anders Carlsson <andersca@codefactory.se>
2858 * doc/dbus-specification.sgml:
2859 Document reply message for ActivateService.
2861 2003-03-16 Anders Carlsson <andersca@codefactory.se>
2863 * bus/activation.c: (bus_pending_activation_entry_free),
2864 (bus_pending_activation_free), (bus_activation_new),
2865 (bus_activation_unref), (bus_activation_service_created),
2866 (bus_activation_activate_service):
2868 * bus/bus.c: (bus_context_new):
2869 * bus/desktop-file.c: (new_section):
2870 * bus/driver.c: (bus_driver_send_service_deleted),
2871 (bus_driver_handle_activate_service):
2872 * bus/services.c: (bus_registry_new), (bus_registry_ensure):
2874 * dbus/dbus-connection.c:
2875 (dbus_connection_send_with_reply_and_block):
2876 * dbus/dbus-message.c: (dbus_message_append_args_valist):
2877 * dbus/dbus-protocol.h:
2878 Make activation work better. Now pending activations will be queued
2879 and the daemon won't try to activate services that are already registered.
2881 2003-03-16 Havoc Pennington <hp@pobox.com>
2883 * dbus/dbus-bus.c (ensure_bus_data): handle failure to set
2886 * dbus/dbus-memory.c (_dbus_initialize_malloc_debug): support
2887 DBUS_MALLOC_BACKTRACES to print trace when failing an alloc
2889 2003-03-16 Havoc Pennington <hp@pobox.com>
2891 * dbus/dbus-string.c (_dbus_string_validate_utf8): oops, unbreak
2892 this. always run the test suite before commit...
2894 * bus/*: adapt to DBusConnection API changes
2896 * glib/dbus-gmain.c: adapt to DBusConnection API changes,
2897 requires renaming stuff to avoid dbus_connection_dispatch name
2900 * dbus/dbus-transport.c (_dbus_transport_queue_messages): new
2903 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
2904 separate from _dbus_message_loader_return_buffer()
2906 * dbus/dbus-connection.c (dbus_connection_get_n_messages): remove
2907 this, because it's now always broken to use; the number of
2908 messages in queue vs. the number still buffered by the message
2909 loader is undefined/meaningless. Should use
2910 dbus_connection_get_dispatch_state().
2911 (dbus_connection_dispatch): rename from
2912 dbus_connection_dispatch_message
2914 2003-03-16 Havoc Pennington <hp@pobox.com>
2916 * dbus/dbus-string.c (_dbus_string_validate_utf8): copy in a real
2919 2003-03-16 Anders Carlsson <andersca@codefactory.se>
2921 * dbus/dbus-connection.c:
2922 (dbus_connection_send_with_reply_and_block):
2923 Decrease connection->n_incoming when removing an entry
2925 * dbus/dbus-dict.c: (dbus_dict_entry_free),
2926 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
2927 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
2928 (dbus_dict_set_byte_array), (dbus_dict_set_string_array),
2929 (dbus_dict_get_boolean_array), (dbus_dict_get_double_array),
2930 (dbus_dict_get_byte_array):
2931 Handle NULL arrays and strings. Also add support for byte arrays.
2933 * dbus/dbus-marshal.c: (_dbus_marshal_byte_array),
2934 (_dbus_marshal_dict), (_dbus_demarshal_byte_array),
2935 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
2936 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
2937 (_dbus_demarshal_dict), (demarshal_and_validate_len),
2938 (_dbus_marshal_validate_arg), (_dbus_marshal_test):
2939 * dbus/dbus-marshal.h:
2940 Add support for marshalling and demarshalling empty arrays and strings.
2942 * dbus/dbus-message.c: (dbus_message_append_args_valist),
2943 (dbus_message_append_string_array),
2944 (dbus_message_iter_get_boolean),
2945 (dbus_message_iter_get_boolean_array),
2946 (dbus_message_iter_get_int32_array),
2947 (dbus_message_iter_get_uint32_array),
2948 (dbus_message_iter_get_double_array),
2949 (dbus_message_iter_get_byte_array),
2950 (dbus_message_iter_get_string_array), (dbus_message_iter_get_dict),
2951 (check_message_handling):
2952 Add support for getting empty arrays and dicts.
2954 * dbus/dbus-string.c: (_dbus_string_validate_utf8):
2955 Don't do any validation at all for now, that's better than just checking
2958 * test/data/valid-messages/emptiness.message:
2959 New test message with lots of empty arrays.
2961 2003-03-16 Havoc Pennington <hp@pobox.com>
2963 * dbus/dbus-connection.c
2964 (_dbus_connection_queue_received_message_link): new function that
2965 can't fail due to OOM
2967 * dbus/dbus-message.c (_dbus_message_loader_pop_message_link):
2968 new function pops a message together with a list link
2971 * dbus/dbus-transport-unix.c (queue_messages): use new link-based
2972 message queuing functions to avoid needing to alloc memory
2974 2003-03-16 Havoc Pennington <hp@pobox.com>
2976 Oops - test code was only testing failure of around 30 of the
2977 mallocs in the test path, but it turns out there are 500+
2978 mallocs. I believe this was due to misguided linking setup such
2979 that there was one copy of dbus_malloc etc. in the daemon and one
2980 in the shared lib, and only daemon mallocs were tested. In any
2981 case, the test case now tests all 500+ mallocs, and doesn't pass
2982 yet, though there are lots of fixes in this patch.
2984 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
2985 this so that it doesn't need to allocate memory, since it
2986 has no way of indicating failure due to OOM (and would be
2987 annoying if it did).
2989 * dbus/dbus-list.c (_dbus_list_pop_first_link): new function
2991 * bus/Makefile.am: rearrange to create two self-contained
2992 libraries, to avoid having libraries with overlapping symbols.
2993 that was resulting in weirdness, e.g. I'm pretty sure there
2994 were two copies of global static variables.
2996 * dbus/dbus-internals.c: move the malloc debug stuff to
2999 * dbus/dbus-list.c (free_link): free list mempool if it becomes
3002 * dbus/dbus-memory.c (_dbus_disable_mem_pools): new function
3004 * dbus/dbus-address.c (dbus_parse_address): free list nodes
3007 * bus/dispatch.c (bus_dispatch_add_connection): free
3008 message_handler_slot when no longer using it, so
3009 memory leak checkers are happy for the test suite.
3011 * dbus/dbus-server-debug-pipe.c (debug_finalize): free server name
3013 * bus/bus.c (new_connection_callback): disconnect in here if
3014 bus_connections_setup_connection fails.
3016 * bus/connection.c (bus_connections_unref): fix to free the
3018 (bus_connections_setup_connection): if this fails, don't
3019 disconnect the connection, just be sure there are no side
3022 * dbus/dbus-string.c (undo_alignment): unbreak this
3024 * dbus/dbus-auth.c (_dbus_auth_unref): free some stuff we were
3026 (_dbus_auth_new): fix the order in which we free strings
3029 * bus/connection.c (bus_connection_disconnected): fix to
3030 not send ServiceDeleted multiple times in case of memory
3033 * dbus/dbus-bus.c (dbus_bus_get_base_service): new function to
3034 get the base service name
3035 (dbus_bus_register_client): don't return base service name,
3036 instead store it on the DBusConnection and have an accessor
3038 (dbus_bus_register_client): rename dbus_bus_register()
3040 * bus/dispatch.c (check_hello_message): verify that other
3041 connections on the bus also got the correct results, not
3042 just the one sending hello
3044 2003-03-15 Havoc Pennington <hp@pobox.com>
3046 Make it pass the Hello handling test including all OOM codepaths.
3047 Now to do other messages...
3049 * bus/services.c (bus_service_remove_owner): fix crash when
3050 removing owner from an empty list of owners
3051 (bus_registry_ensure): don't leave service in the list of
3052 a connection's owned services if we fail to put the service
3055 * bus/connection.c (bus_connection_preallocate_oom_error): set
3056 error flag on the OOM error.
3058 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
3059 handle _dbus_transport_set_connection failure
3061 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd): modify
3062 to create watches up front and simply enable/disable them as
3064 (unix_connection_set): this can now fail on OOM
3066 * dbus/dbus-timeout.c, dbus/dbus-watch.c: add concept
3067 of enabling/disabling a watch or timeout.
3069 * bus/loop.c (bus_loop_iterate): don't touch disabled
3072 * glib/dbus-gmain.c: adapt to enable/disable watches and timeouts
3074 2003-03-15 Havoc Pennington <hp@pobox.com>
3076 * bus/dispatch.c (bus_dispatch_test): OK, now finally actually
3077 write useful test code, after all that futzing around ;-)
3079 Test does not yet pass because we can't handle OOM in
3080 _dbus_transport_messages_pending (basically,
3081 dbus_connection_preallocate_send() does not prealloc the write
3082 watch). To fix this, I think we need to add new stuff to
3083 set_watch_functions, namely a SetEnabled function so we can alloc
3084 the watch earlier, then enable it later.
3086 * dbus/Makefile.am (libdbus_convenience_la_SOURCES): move
3087 dbus-memory.c to the convenience lib
3089 * bus/test.c: rename some static functions to keep them clearly
3090 distinct from stuff in connection.c. Handle client disconnection.
3092 2003-03-14 Havoc Pennington <hp@pobox.com>
3094 * bus/dispatch.c (bus_dispatch_test): do test using debug-pipe
3095 transport, tests more of the real codepath. Set up clients
3096 with bus_setup_debug_client.
3098 * bus/test.c (bus_setup_debug_client): function to set up debug
3099 "clients" on the main loop
3101 * dbus/dbus-transport.c (_dbus_transport_open): add debug-pipe
3104 * dbus/dbus-server.c (dbus_server_listen): add debug-pipe
3107 * dbus/dbus-server-debug.c: support a debug server based on pipes
3109 * dbus/dbus-sysdeps.c (_dbus_full_duplex_pipe): new function
3110 (_dbus_close): new function
3112 * configure.in: check for socketpair
3114 2003-03-14 Havoc Pennington <hp@redhat.com>
3116 * dbus/dbus-memory.c: add a "detect buffer overwrites on free"
3119 * dbus/dbus-transport-debug.c: rework this a good bit to be
3120 less complicated. hopefully still works.
3122 * dbus/dbus-server-debug.c (handle_new_client): remove timeout
3125 * glib/dbus-gmain.c (timeout_handler): don't remove timeout
3128 * dbus/dbus-message.c (dbus_message_copy): rename from
3129 dbus_message_new_from_message, fix it up to copy
3130 all the message fields, add test case
3132 * bus/dispatch.c (bus_dispatch_test): add some more test code,
3133 not quite passing yet
3135 2003-03-14 Havoc Pennington <hp@pobox.com>
3137 * bus/loop.c (bus_loop_iterate): add this so we can "run loop
3138 until no work remains" in test code. (the large diff here
3139 is just code movement, no actual changes)
3141 * dbus/dbus-server-debug.c (DEFAULT_INTERVAL): change interval to
3142 1, no point waiting around for test code.
3143 (_dbus_server_debug_accept_transport): unref the timeout
3144 after adding it (right?)
3146 * dbus/dbus-transport-debug.c (DEFAULT_INTERVAL): ditto
3148 2003-03-13 Havoc Pennington <hp@redhat.com>
3150 * dbus/dbus-timeout.c (_dbus_timeout_list_set_functions): handle
3153 * dbus/dbus-watch.c (_dbus_watch_list_set_functions): handle out
3156 * dbus/dbus-connection.h: Make AddWatchFunction and
3157 AddTimeoutFunction return a bool so they can fail on out-of-memory
3159 * bus/bus.c (bus_context_new): set up timeout handlers
3161 * bus/connection.c (bus_connections_setup_connection): set up
3164 * glib/dbus-gmain.c: adapt to the fact that set_functions stuff
3167 * bus/bus.c (bus_context_new): adapt to changes
3169 * bus/connection.c: adapt to changes
3171 * test/watch.c: adapt to DBusWatch changes
3173 * bus/dispatch.c (bus_dispatch_test): started adding this but
3176 2003-03-14 Anders Carlsson <andersca@codefactory.se>
3178 * bus/dispatch.c (send_service_nonexistent_error): Fix typo.
3180 2003-03-13 Havoc Pennington <hp@pobox.com>
3182 * bus/test.c, bus/test.h, bus/Makefile.am, bus/test-main.c:
3183 set up a test framework as for the library
3185 2003-03-12 Havoc Pennington <hp@pobox.com>
3187 Throughout: purge global variables, introduce BusActivation,
3188 BusConnections, BusRegistry, etc. objects instead.
3190 * bus/bus.h, bus/bus.c: introduce BusContext as a global
3193 * test/Makefile.am (TEST_BINARIES): disable bus-test for now,
3194 going to redo this a bit differently I think
3196 2003-03-12 Havoc Pennington <hp@redhat.com>
3198 Mega-patch that gets the message bus daemon initially handling
3199 out-of-memory. Work still needed. Also lots of random
3200 moving stuff to DBusError instead of ResultCode.
3202 * dbus/dbus-list.c (_dbus_list_length_is_one): new function
3204 * dbus/dbus-connection.c
3205 (dbus_connection_send_with_reply_and_block): use DBusError
3207 * dbus/dbus-bus.c: adapt to API changes, make it use DBusError not
3210 * dbus/dbus-connection.c (dbus_connection_send): drop the result
3211 code here, as the only failure possible is OOM.
3213 * bus/connection.c (bus_connection_disconnect):
3214 rename bus_connection_disconnected as it's a notification only
3216 * bus/driver.c (bus_driver_handle_acquire_service): don't free
3217 "name" on get_args failure, should be done by get_args;
3218 don't disconnect client for bad args, just return an error.
3219 (bus_driver_handle_service_exists): ditto
3221 * bus/services.c (bus_services_list): NULL-terminate returned array
3223 * bus/driver.c (bus_driver_send_service_lost)
3224 (bus_driver_send_service_acquired): send messages from driver to a
3225 specific client to the client's unique name, not to the broadcast
3228 * dbus/dbus-message.c (decode_header_data): reject messages that
3229 contain no name field
3230 (_dbus_message_get_client_serial): rename to
3231 dbus_message_get_serial and make public
3232 (_dbus_message_set_serial): rename from set_client_serial
3233 (_dbus_message_set_reply_serial): make public
3234 (_dbus_message_get_reply_serial): make public
3236 * bus/connection.c (bus_connection_foreach): allow stopping
3237 iteration by returning FALSE from foreach function.
3239 * dbus/dbus-connection.c (dbus_connection_send_preallocated)
3240 (dbus_connection_free_preallocated_send)
3241 (dbus_connection_preallocate_send): new API for sending a message
3242 without possibility of malloc failure.
3243 (dbus_connection_send_message): rename to just
3244 dbus_connection_send (and same for whole function family)
3246 * dbus/dbus-errors.c (dbus_error_free): make this reinit the error
3248 * dbus/dbus-sysdeps.c (_dbus_exit): new function
3250 * bus/activation.c: handle/return errors
3252 * dbus/dbus-errors.h: add more DBUS_ERROR #define
3254 * dbus/dbus-sysdeps.c (_dbus_directory_open) (_dbus_file_get_contents)
3255 (_dbus_directory_get_next_file): use DBusError instead of DBusResultCode
3256 (_dbus_result_from_errno): move to this file
3258 2003-03-10 Anders Carlsson <andersca@codefactory.se>
3260 * dbus/dbus-marshal.c:
3261 (_dbus_marshal_set_string):
3262 Take a length argument so we can marshal the correct string
3265 (_dbus_marshal_dict), (_dbus_demarshal_dict),
3266 (_dbus_marshal_get_arg_end_pos), (_dbus_marshal_validate_arg),
3267 (_dbus_marshal_test):
3268 * dbus/dbus-marshal.h:
3269 Add support for marshalling and demarshalling dicts.
3271 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
3272 Add support for TYPE DICT.
3274 * dbus/dbus-message.c: (set_string_field):
3275 Adjust header padding.
3277 (dbus_message_append_args_valist), (dbus_message_append_dict),
3278 (dbus_message_get_args_valist), (dbus_message_iter_get_arg_type),
3279 (dbus_message_iter_get_dict), (_dbus_message_loader_return_buffer),
3280 (check_message_handling), (check_have_valid_message):
3281 * dbus/dbus-message.h:
3282 Add functions for setting and getting dicts.
3284 * dbus/dbus-protocol.h:
3290 * doc/dbus-specification.sgml:
3291 Add information about how dicts are marshalled.
3293 * test/data/invalid-messages/dict-with-nil-value.message:
3294 * test/data/invalid-messages/too-short-dict.message:
3295 * test/data/valid-messages/dict-simple.message:
3296 * test/data/valid-messages/dict.message:
3297 Add sample messages containing dicts.
3299 2003-03-08 Anders Carlsson <andersca@codefactory.se>
3301 * dbus/dbus-dict.h: Add DBUS_END_DECLS.
3303 2003-03-07 Anders Carlsson <andersca@codefactory.se>
3306 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
3307 (dbus_dict_get_keys), (insert_entry), (dbus_dict_set_boolean),
3308 (dbus_dict_set_int32), (dbus_dict_set_uint32),
3309 (dbus_dict_set_double), (dbus_dict_set_string),
3310 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
3311 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
3312 (dbus_dict_set_string_array), (_dbus_dict_test):
3314 Fix according to comments from Havoc.
3316 2003-03-06 Michael Meeks <michael@server.home>
3318 * configure.in: if we don't have kde-config, disable have_qt.
3320 2003-03-07 Anders Carlsson <andersca@codefactory.se>
3325 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
3326 (dbus_dict_ref), (dbus_dict_unref), (dbus_dict_contains),
3327 (dbus_dict_remove), (dbus_dict_get_value_type),
3328 (dbus_dict_get_keys), (dbus_dict_put_boolean),
3329 (dbus_dict_put_int32), (dbus_dict_put_uint32),
3330 (dbus_dict_put_double), (dbus_dict_put_string),
3331 (dbus_dict_put_boolean_array), (dbus_dict_put_int32_array),
3332 (dbus_dict_put_uint32_array), (dbus_dict_put_double_array),
3333 (dbus_dict_put_string_array), (dbus_dict_get_boolean),
3334 (dbus_dict_get_int32), (dbus_dict_get_uint32),
3335 (dbus_dict_get_double), (dbus_dict_get_string),
3336 (dbus_dict_get_boolean_array), (dbus_dict_get_int32_array),
3337 (dbus_dict_get_uint32_array), (dbus_dict_get_double_array),
3338 (dbus_dict_get_string_array), (_dbus_dict_test):
3340 Add DBusDict implementation
3342 * dbus/dbus-test.c: (dbus_internal_do_not_use_run_tests):
3346 2003-03-04 Havoc Pennington <hp@pobox.com>
3348 * test/data/auth/*: adapt to changes
3350 * dbus/dbus-auth-script.c (_dbus_auth_script_run): add
3351 USERID_BASE64 and change USERNAME_BASE64 to put in username not
3354 * dbus/dbus-keyring.c (_dbus_keyring_validate_context): prevent
3355 more stuff from being in a context name, to make the protocol
3356 simpler to deal with
3358 * dbus/dbus-errors.c (dbus_error_has_name): new function
3359 (dbus_error_is_set): new function
3361 * dbus/dbus-auth.c: replace DBUS_STUPID_TEST_MECH auth
3362 with DBUS_COOKIE_SHA1, implement DBUS_COOKIE_SHA1
3364 * dbus/dbus-connection.c (dbus_connection_flush): also read
3365 messages during a flush operation
3367 * dbus/Makefile.am: remove dbus-md5 since it isn't currently used.
3369 2003-03-05 Anders Carlsson <andersca@codefactory.se>
3371 * configure.in: Check for gethostbyname on Solaris.
3373 * dbus/dbus-transport.c: (_dbus_transport_open):
3374 Remove duplicate "tcp" entry.
3376 * doc/dbus-specification.sgml:
3377 Clarify some things.
3379 2003-03-05 Anders Carlsson <andersca@codefactory.se>
3381 * dbus/dbus-auth.c: (send_rejected), (process_test_subdir):
3382 * dbus/dbus-keyring.c: (_dbus_keyring_new_homedir),
3383 (_dbus_keyring_test):
3384 * dbus/dbus-md5.c: (_dbus_md5_compute):
3385 * dbus/dbus-sha.c: (_dbus_sha_compute):
3388 2003-03-05 Anders Carlsson <andersca@codefactory.se>
3390 * README: Add some things.
3392 2003-03-04 Anders Carlsson <andersca@codefactory.se>
3394 * dbus/dbus-message.c (dbus_message_append_args_valist): Add a break;
3395 after case DBUS_TYPE_BOOELAN.
3397 2003-03-02 Havoc Pennington <hp@pobox.com>
3399 * test/break-loader.c (randomly_set_extreme_ints): add test that
3400 sets really huge and small integers
3402 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add check
3403 that length of boolean array fits in the string, and that
3404 string has room for boolean value in single-bool case.
3406 * dbus/dbus-message-builder.c (_dbus_message_data_load): add
3407 optional value to "ALIGN" command which is what to fill the
3410 * test/data/valid-messages/no-padding.message: add regression
3411 test for the message padding problem
3413 2003-03-02 Havoc Pennington <hp@pobox.com>
3415 * dbus/dbus-message.c (decode_header_data): fix to always init
3416 message_padding, from Benjamin Dauvergne
3418 2003-03-02 Havoc Pennington <hp@pobox.com>
3424 2003-03-01 Joe Shaw <joe@assbarn.com>
3426 * configure.in: Check for "struct cmsgcred" and try to access its
3427 members for BSD-like unices.
3429 * dbus/dbus-sysdeps.c (read_credentials_byte): Fold this back into
3430 _dbus_read_credentials_unix_socket().
3431 (_dbus_read_credentials_unix_socket): Use recvmsg() instead of
3432 read() for reading the credential byte off the unix socket. Use
3433 struct cmsgcred on systems that support it.
3435 2003-02-27 Alexander Larsson <alexl@redhat.com>
3439 Make gthreads-2.0 dependency optional. Don't build thread test if
3442 2003-02-27 Havoc Pennington <hp@pobox.com>
3444 * dbus/dbus-connection.c
3445 (dbus_connection_send_message_with_reply_and_block): fix doh!
3446 doh! doh! bug that resulted in never removing a reply from the
3447 queue, no wonder we called get_reply_serial so much ;-)
3449 * dbus/dbus-message.c (struct DBusMessage): cache reply serial
3450 and client serial instead of demarshaling them every time
3452 2003-02-27 Havoc Pennington <hp@pobox.com>
3454 * dbus/dbus-marshal.c (_dbus_demarshal_int32): rewrite to be much
3455 more inlined, using dbus-string-private.h, speeds things up
3458 * dbus/dbus-string.c (_dbus_string_free): apply align offset
3459 when freeing the string
3460 (_dbus_string_steal_data): fix for align offset
3461 (undo_alignment): new function
3463 2003-02-26 Havoc Pennington <hp@redhat.com>
3465 All kinds of audit fixes from Owen, plus initial attempt to
3466 handle unaligned memory returned from malloc.
3468 * dbus/dbus-string.c (_dbus_string_init): clamp max length to
3469 leave room for align_offset and nul byte
3470 (fixup_alignment): function to track an align_offset and
3471 ensure real->str is aligned
3472 (DBUS_GENERIC_STRING_PREAMBLE): len must be less than allocated,
3473 to allow a nul byte plus align offset
3474 (_dbus_string_lock): fix overflow issue
3475 (_dbus_string_init_const_len): add assertions on sanity of len,
3476 assign allocated to be ALLOCATION_PADDING larger than len
3477 (set_length): fixup the overflow handling
3478 (_dbus_string_get_data_len): fix overflow in assertion
3479 (open_gap): detect overflow in size of gap to be opened
3480 (_dbus_string_lengthen): add overflow check
3481 (_dbus_string_align_length): fix overflow with _DBUS_ALIGN_VALUE
3482 (_dbus_string_append): add overflow check
3483 (_dbus_string_append_unichar): overflow
3484 (_dbus_string_delete): fix overflow in assertion
3485 (_dbus_string_copy_len): overflow in assertion
3486 (_dbus_string_replace_len): overflows in assertions
3487 (_dbus_string_find): change to implement in terms of
3488 _dbus_string_find_to
3489 (_dbus_string_find_to): assorted fixage
3490 (_dbus_string_equal_c_str): assert c_str != NULL,
3491 fix logic so the function works
3492 (_dbus_string_ends_with_c_str): fix overflow thingy
3493 (_dbus_string_base64_encode): overflow fix
3494 (_dbus_string_validate_ascii): overflow
3495 (_dbus_string_validate_nul): overflow
3497 2003-02-26 Havoc Pennington <hp@redhat.com>
3499 * dbus/dbus-marshal.c (_dbus_marshal_test): fix to work with DISABLE_ASSERTS
3501 2003-02-26 Alexander Larsson <alexl@redhat.com>
3504 Set DBUS_GLIB_THREADS_LIBS for apps using gthread-2.0
3506 * dbus/dbus-connection.c:
3507 * dbus/dbus-connection.h:
3508 Fix _dbus_connection_acquire_io_path and _dbus_connection_acquire_dispatch.
3509 Add dbus_connection_set_wakeup_main_function and use it when queueing
3510 incoming and outgoing messages.
3513 * dbus/dbus-dataslot.c:
3514 Threadsafe usage of DBusDataSlotAllocator
3516 * dbus/dbus-message.c: (dbus_message_get_args_iter):
3519 * dbus/dbus-server-unix.c:
3522 * glib/dbus-gmain.c:
3523 Implement the new wakeup functions for glib.
3526 * glib/test-thread-client.c:
3527 * glib/test-thread-server.c:
3528 * glib/test-thread.h:
3529 Initial cut at some thread test code. Not really done yet.
3531 2003-02-26 Havoc Pennington <hp@pobox.com>
3533 * dbus/dbus-connection.c
3534 (dbus_connection_send_message_with_reply_and_block): fix crash
3535 where we ref'd the outgoing message instead of the returned reply
3537 * dbus/dbus-transport-unix.c (do_authentication): check read watch
3538 at the end of this function, so if we didn't need to read for
3539 authentication, we reinstall it for receiving messages
3541 * dbus/dbus-message.c (dbus_message_new_reply): allow replies to
3542 a NULL sender for peer-to-peer case
3544 * dbus/dbus-transport-unix.c (check_read_watch): handle
3545 !authenticated case correctly
3547 * glib/dbus-gmain.c: add support for DBusServer
3549 * dbus/dbus-server.c: add data slot support
3551 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): check
3552 return values and handle errors
3554 * dbus/dbus-dataslot.c: factor out the data slot stuff from
3557 * Doxyfile.in (INPUT): add glib subdir
3559 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): rename
3560 setup_with_g_main instead of hookup_with_g_main; write docs
3562 2003-02-24 Anders Carlsson <andersca@codefactory.se>
3564 * dbus/dbus-marshal.c: (_dbus_marshal_validate_arg):
3565 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
3566 * dbus/dbus-message.c: (dbus_message_append_boolean),
3567 (dbus_message_append_boolean_array),
3568 (dbus_message_get_args_valist), (_dbus_message_test):
3569 * dbus/dbus-message.h:
3570 * doc/dbus-specification.sgml:
3571 Various fixes as pointed out by Havoc.
3573 * test/data/invalid-messages/bad-boolean-array.message:
3574 * test/data/invalid-messages/bad-boolean.message:
3575 Add invalid boolean value test cases.
3577 2003-02-24 Anders Carlsson <andersca@codefactory.se>
3579 * dbus/dbus-internals.c: (_dbus_type_to_string):
3580 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
3581 (_dbus_marshal_validate_arg):
3582 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
3583 * dbus/dbus-message.c: (dbus_message_append_args_valist),
3584 (dbus_message_append_boolean), (dbus_message_append_boolean_array),
3585 (dbus_message_get_args_valist), (dbus_message_iter_get_boolean),
3586 (dbus_message_iter_get_int32), (dbus_message_iter_get_uint32),
3587 (dbus_message_iter_get_double),
3588 (dbus_message_iter_get_boolean_array), (message_iter_test):
3589 * dbus/dbus-message.h:
3590 * dbus/dbus-protocol.h:
3591 * doc/dbus-specification.sgml:
3592 * test/data/valid-messages/lots-of-arguments.message:
3593 Add support for boolean and boolean array types.
3595 2003-02-23 Havoc Pennington <hp@pobox.com>
3597 * dbus/dbus-keyring.c: finish most of this implementation and
3600 * dbus/dbus-errors.c (dbus_set_error_const, dbus_set_error): make
3601 these barf if the error isn't cleared to NULL
3603 * dbus/dbus-sysdeps.c (_dbus_delete_file): set error on failure
3604 (_dbus_create_directory): new function
3606 * dbus/dbus-errors.c (dbus_set_error): fix warning
3608 * dbus/dbus-string.c (_dbus_string_hex_encode): new function
3609 (_dbus_string_hex_decode): new function
3610 (test_hex_roundtrip): test code
3612 * dbus/dbus-sha.c (_dbus_sha_compute): use dbus_string_hex_encode
3614 * dbus/dbus-md5.c (_dbus_md5_compute): use dbus_string_hex_encode
3616 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): make this use
3617 the save-to-temp/rename trick to atomically write the new file
3618 (_dbus_string_parse_uint): new function
3620 2003-02-22 Havoc Pennington <hp@pobox.com>
3622 * test/Makefile.am (dist-hook): fix dist for test/data/sha-1
3624 2003-02-22 Havoc Pennington <hp@pobox.com>
3626 * dbus/dbus-message.c (dbus_message_iter_get_string_array):
3627 (dbus_message_iter_get_byte_array): Fix up doxygen warnings
3629 * dbus/dbus-sha.c: add implementation of SHA-1 algorithm
3631 * dbus/test/data/sha-1: add US government test suite for SHA-1
3633 2003-02-21 Anders Carlsson <andersca@codefactory.se>
3635 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
3636 Make string arrays NULL-terminated.
3638 * dbus/dbus-memory.c: (dbus_free_string_array):
3639 * dbus/dbus-memory.h:
3640 New function for freeing NULL-terminated string arrays.
3642 * dbus/dbus-message-builder.c: (append_quoted_string),
3643 (_dbus_message_data_load):
3644 Add support for array types.
3646 * dbus/dbus-message.c: (check_message_handling):
3647 Add more types as test cases.
3649 * dbus/dbus-sysdeps.c: (_dbus_string_parse_int),
3650 (_dbus_string_parse_double):
3651 Add the start offset to the end offset.
3653 * test/data/valid-messages/lots-of-arguments.message:
3654 New test message with lots of arguments.
3656 2003-02-21 Anders Carlsson <andersca@codefactory.se>
3658 * dbus/dbus-message.c: (dbus_message_append_nil),
3659 (dbus_message_append_int32), (dbus_message_append_uint32),
3660 (dbus_message_append_double), (dbus_message_append_string),
3661 (dbus_message_append_int32_array),
3662 (dbus_message_append_uint32_array),
3663 (dbus_message_append_double_array),
3664 (dbus_message_append_byte_array),
3665 (dbus_message_append_string_array):
3666 Fix all out-of-memory handling in these functions.
3668 2003-02-21 Anders Carlsson <andersca@codefactory.se>
3670 * dbus/dbus-message.c: (dbus_message_append_nil):
3673 2003-02-21 Anders Carlsson <andersca@codefactory.se>
3675 * dbus/dbus-message.c: (dbus_message_append_args_valist),
3676 (dbus_message_append_nil), (dbus_message_append_int32_array),
3677 (dbus_message_append_uint32_array),
3678 (dbus_message_append_double_array),
3679 (dbus_message_append_byte_array),
3680 (dbus_message_append_string_array), (dbus_message_get_args_valist),
3681 (dbus_message_iter_get_int32_array),
3682 (dbus_message_iter_get_uint32_array),
3683 (dbus_message_iter_get_double_array),
3684 (dbus_message_iter_get_byte_array),
3685 (dbus_message_iter_get_string_array):
3687 * dbus/dbus-message.h:
3688 Add functions for appending and getting arrays.
3690 2003-02-21 Anders Carlsson <andersca@codefactory.se>
3692 * dbus/dbus-mempool.c (_dbus_mem_pool_new): Make the
3693 element size at least 8 bytes, fixes mempool tests on
3696 2003-02-20 Alexander Larsson <alexl@redhat.com>
3698 * dbus/dbus-transport-unix.c (unix_do_iteration):
3699 Unlock the connection mutex during a blocking select call.
3700 Add todo about how we need a way to wake up the select.
3702 * dbus/dbus-connection-internal.h:
3703 * dbus/dbus-connection.c:
3704 Add _dbus_connection_lock and _dbus_connection_unlock.
3706 2003-02-19 Havoc Pennington <hp@pobox.com>
3708 * Doxyfile.in (PREDEFINED): put DOXYGEN_SHOULD_SKIP_THIS in
3709 Doxyfile.in, not Doxyfile
3711 * dbus/dbus-keyring.c: do some hacking on this
3713 * dbus/dbus-sysdeps.c (_dbus_delete_file): new
3715 * dbus/dbus-errors.c (dbus_set_error_const): do not call
3717 (dbus_set_error): remove dbus_error_init, check for message ==
3718 NULL *before* we sprintf into it, and add @todo about including
3719 system headers in this file
3721 * dbus/dbus-sysdeps.c (_dbus_create_file_exclusively): new
3723 * dbus/dbus-errors.h (DBUS_ERROR_FAILED): add
3725 * dbus/dbus-sysdeps.c (get_user_info): break this function out to
3726 get various bits of user information based on either username
3728 (_dbus_homedir_from_username): new function
3730 2003-02-19 Anders Carlsson <andersca@codefactory.se>
3733 Add check for nonposix getpwnam_r
3735 * dbus/dbus-mempool.c: (_dbus_mem_pool_new):
3736 Align the pool element size to a sizeof (void *) boundary.
3738 * dbus/dbus-sysdeps.c: (_dbus_setenv), (_dbus_connect_unix_socket),
3739 (_dbus_listen_unix_socket), (_dbus_credentials_from_username):
3740 General Solaris fixes.
3742 * test/data/valid-messages/simplest-manual.message:
3743 Explicitly state that we want little-endian packing.
3745 2003-02-19 Mikael Hallendal <micke@codefactory.se>
3747 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
3749 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_tcp_socket):
3750 Added to create a transport connecting using a tcp/ip socket.
3752 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): Added to connect
3753 to a tcp socket at given host and port.
3754 (_dbus_listen_tcp_socket): added to listen on tcp socket for given
3757 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
3759 * dbus/dbus-server-unix.c (_dbus_server_new_for_tcp_socket):
3760 Added to create a server listening on a TCP/IP socket.
3762 2003-02-19 Havoc Pennington <hp@pobox.com>
3764 Throughout: mop up all the Doxygen warnings and undocumented
3767 * dbus/dbus-sysdeps.c (do_exec): do not use execvp, we don't want
3768 to search any paths.
3770 * dbus/dbus-threads.c: move global mutex initializers to
3771 dbus-internals.h, multiple prototypes was confusing doxygen
3772 besides being kind of ugly
3774 * Doxyfile (PREDEFINED): have Doxygen define
3775 DOXYGEN_SHOULD_SKIP_THIS so we can exclude things from
3776 docs with #ifndef DOXYGEN_SHOULD_SKIP_THIS
3777 (do not abuse the feature! it's for stuff like the autogenerated
3778 macros in dbus-md5.c, not just for things you don't feel like
3781 2003-02-18 Havoc Pennington <hp@pobox.com>
3783 * dbus/dbus-string.c (_dbus_string_zero): new function
3785 * dbus/dbus-md5.c: include MD5 implementation by L. Peter Deutsch,
3786 wrap it in some dbus-friendly API
3788 * dbus/dbus-types.h: add 16-bit types
3790 2003-02-18 Joe Shaw <joe@assbarn.com>
3792 * dbus/dbus-auth.c (handle_server_data_stupid_test_mech): Just get
3793 credentials from our currently running process.
3794 (get_word): Fix a buglet where we were copying the entire length
3795 instead of relative to our position.
3797 * dbus/dbus-hash.c (_dbus_hash_test): Don't try to allocate the
3798 keys on the stack... it's 640k of data.
3800 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): Always
3801 read the credentials byte off the socket, even if we don't have
3803 (_dbus_poll): Implement poll() using select() for systems which
3806 * glib/test-dbus-glib.c (main): Print out an error if no
3807 parameters are given.
3809 * test/data/auth/fallback.auth-script: Added. Tests that a client
3810 can fallback to a secondary auth mechanism if the first fails.
3812 2003-02-18 Havoc Pennington <hp@pobox.com>
3816 2003-02-17 Havoc Pennington <hp@pobox.com>
3818 * doc/dbus-specification.sgml: lots of cosmetic
3819 cleanups/rearrangement, add assorted FIXME, change DBUS_ADDRESS
3820 env variable to DBUS_BUS_ADDRESS, s/client/application/,
3821 s/server/bus/ (except in authentication section). Add a section
3822 "Message Bus Message Routing"
3824 2003-02-17 Anders Carlsson <andersca@codefactory.se.>
3830 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3832 * doc/dbus-specification.sgml:
3833 Specification updates.
3835 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3837 * bus/activation.c: (bus_activation_init), (child_setup),
3838 (bus_activation_activate_service):
3840 * bus/main.c: (main):
3841 Set DBUS_ADDRESS environment variable.
3843 * dbus/dbus-errors.c: (dbus_set_error):
3844 Don't use va_copy since that's a C99 feature.
3846 * dbus/dbus-sysdeps.c: (_dbus_setenv), (do_exec),
3847 (_dbus_spawn_async):
3848 * dbus/dbus-sysdeps.h:
3849 Add child_setup_func to _dbus_spawn_async.
3851 * doc/dbus-specification.sgml:
3852 Update specification.
3854 * test/spawn-test.c: (setup_func), (main):
3857 2003-02-17 Alexander Larsson <alexl@redhat.com>
3859 * dbus/dbus-connection.c (_dbus_connection_handler_destroyed_locked):
3862 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3866 * doc/dbus-test-plan.sgml:
3867 Add test plan document.
3872 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3874 * dbus/dbus-message.c: (decode_header_data),
3875 (_dbus_message_loader_return_buffer):
3876 Set the header padding amount when loading a message.
3878 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3880 * bus/dispatch.c: (send_one_message):
3881 Only send broadcast messages to registered connections.
3883 * dbus/dbus-message.c: (dbus_message_name_is):
3884 * dbus/dbus-message.h:
3885 New convenience function.
3887 * dbus/dbus-transport-debug.c: (do_reading):
3888 Only dispatch one message per run.
3891 * test/bus-test.c: (new_connection_callback), (die),
3892 (test_hello_client1_handler), (test_hello_client2_handler),
3893 (test_hello_replies), (main):
3895 * test/bus-test-loop.[ch]:
3898 2003-02-16 Havoc Pennington <hp@pobox.com>
3900 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
3901 backward conditional
3903 2003-02-16 Alexander Larsson <alexl@redhat.com>
3905 * dbus/dbus-connection.c:
3906 Implement sent_message_with_reply. (with_reply_and block is still
3908 Made dispatch_message not lose message if OOM.
3910 * dbus/dbus-errors.h:
3911 Add NoReply error (for reply timeouts).
3913 2003-02-16 Alexander Larsson <alexl@redhat.com>
3915 * dbus/dbus-hash.c (_dbus_hash_table_unref):
3916 Actually free keys and values when destroying hashtable.
3918 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3920 * dbus/dbus-auth.c: (client_try_next_mechanism):
3923 * dbus/dbus-threads.c: (dbus_condvar_wait_timeout):
3924 Return TRUE if there's no thread implementation around.
3926 * glib/dbus-gmain.c: (free_source),
3927 (dbus_connection_hookup_with_g_main):
3928 Make sure to remove the GSource when the connection is finalized.
3930 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3932 * bus/dispatch.c: (bus_dispatch_message_handler):
3933 * dbus/dbus-errors.h:
3934 Return an error if someone tries to send a message to a service
3937 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3939 * bus/activation.c: (load_directory), (bus_activation_init),
3940 (bus_activation_activate_service):
3943 (bus_driver_handle_activate_service), (bus_driver_handle_message):
3944 More work on the activation handling.
3946 * dbus/dbus-errors.h:
3947 Add some error messages
3949 * dbus/dbus-message.c: (dbus_message_new_error_reply):
3950 * dbus/dbus-message.h:
3951 New function that creates an error message.
3953 * dbus/dbus-protocol.h:
3954 Add ACTIVATE_SERVER message.
3956 * dbus/dbus-server-unix.c: (unix_handle_watch),
3957 (_dbus_server_new_for_domain_socket):
3958 Call _dbus_fd_set_close_on_exec.
3960 * dbus/dbus-sysdeps.c: (make_pipe), (do_exec),
3961 (_dbus_spawn_async), (_dbus_disable_sigpipe),
3962 (_dbus_fd_set_close_on_exec):
3963 * dbus/dbus-sysdeps.h:
3964 Add _dbus_fd_set_close_on exec function. Also add function that checks
3965 that all open fds are set to close-on-exec and warns otherwise.
3967 * dbus/dbus-transport-unix.c:
3968 (_dbus_transport_new_for_domain_socket):
3969 Call _dbus_fd_set_close_on_exec.
3971 2003-02-16 Havoc Pennington <hp@pobox.com>
3973 * dbus/dbus-connection.c (dbus_connection_set_change_sigpipe):
3974 allow people to avoid setting SIGPIPE to SIG_IGN
3975 (_dbus_connection_new_for_transport): disable SIGPIPE unless
3976 we've been asked not to
3978 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3980 * dbus/dbus-list.c: (_dbus_list_append_link),
3981 (_dbus_list_prepend_link):
3982 * dbus/dbus-memory.c: (dbus_malloc), (dbus_malloc0),
3986 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3989 * bus/activation.c: (bus_activation_entry_free),
3990 (add_desktop_file_entry), (load_directory), (bus_activation_init):
3992 * bus/main.c: (main):
3993 Add simple activation support, doesn't work yet though.
3995 2003-02-15 Zack Rusin <zack@kde.org>
3997 * qt/dbus-qthread.cpp: small casting fix
3999 2003-02-15 Anders Carlsson <andersca@codefactory.se>
4001 * dbus/dbus-errors.c: (dbus_set_error):
4002 * dbus/dbus-errors.h:
4003 Add a few errors and make dbus_set_error void.
4005 * dbus/dbus-sysdeps.c:
4006 (_dbus_errno_to_string), (close_and_invalidate), (make_pipe),
4007 (write_err_and_exit), (read_ints), (do_exec), (_dbus_spawn_async):
4008 * dbus/dbus-sysdeps.h:
4009 Add _dbus_spawn_async.
4011 * test/spawn-test.c: (main):
4012 Test for _dbus_spawn_async.
4014 2003-02-15 Anders Carlsson <andersca@codefactory.se>
4016 * dbus/dbus-internals.h:
4017 Fix build without tests.
4019 * dbus/dbus-list.c: (alloc_link):
4020 Fix a segfault when a malloc fails.
4022 * dbus/dbus-memory.c: (initialize_malloc_debug), (dbus_malloc),
4023 (dbus_malloc0), (dbus_realloc):
4024 Add support for malloc debugging.
4026 2003-02-15 Alexander Larsson <alexl@redhat.com>
4028 * dbus/dbus-threads.c:
4029 * dbus/dbus-threads.h:
4030 Add condvars. Remove static mutext from API.
4031 Implement static mutexes by initializing them from threads_init.
4033 * glib/dbus-gthread.c:
4034 * qt/dbus-qthread.cpp:
4035 Update with the thread api changes.
4040 Turn StaticMutex into normal mutex + init function.
4041 Export new functions _dbus_list_alloc_link, _dbus_list_free_link,
4042 _dbus_list_append_link, _dbus_list_prepend_link
4045 * dbus/dbus-sysdeps.c:
4046 * dbus/dbus-sysdeps.h:
4047 New type dbus_atomic_t, and new functions _dbus_atomic_inc,
4048 _dbus_atomic_dec. Only slow fallback implementation at the moment.
4050 * dbus/dbus-protocol.h:
4051 Add DBUS_MESSAGE_LOCAL_DISCONNECT define
4053 * dbus/dbus-message.c:
4054 Make ref/unref atomic.
4057 * dbus/dbus-connection-internal.h:
4058 * dbus/dbus-connection.c:
4059 * dbus/dbus-connection.h:
4061 Change _peek to _borrow,_return & _steal_borrowed.
4062 Change disconnect callback to event.
4063 Make dbus_connection_dispatch_messages reentrant.
4065 * dbus/dbus-transport.c:
4066 Don't ref the connection on calls to the transport
4069 * dbus/dbus-message-handler.c:
4072 * glib/dbus-gmain.c:
4073 Don't use peek_message anymore
4076 * test/debug-thread.c:
4077 * test/debug-thread.h:
4078 Simple thread implementation that asserts() on deadlocks in
4079 single-threaded code.
4082 (main) Call debug_threads_init.
4085 Use disconnect message instead of disconnect callback.
4089 Don't call dbus_connection_set_disconnect_function. Instead export
4090 bus_connection_disconnect.
4093 Call bus_connection_disconnect when we get a disconnected message.
4095 2003-02-15 Havoc Pennington <hp@pobox.com>
4097 * dbus/dbus-message.c (dbus_message_new): fool around with the
4100 2003-02-14 Havoc Pennington <hp@pobox.com>
4102 * dbus/dbus-mempool.c: fail if the debug functions so indicate
4104 * dbus/dbus-memory.c: fail if the debug functions indicate we
4107 * dbus/dbus-internals.c (_dbus_set_fail_alloc_counter)
4108 (_dbus_decrement_fail_alloc_counter): debug functions to
4109 simulate memory allocation failures
4111 2003-02-14 Havoc Pennington <hp@pobox.com>
4113 * dbus/dbus-errors.h (struct DBusError): add a word of padding
4116 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4118 * bus/driver.c: (bus_driver_handle_hello):
4120 * bus/services.c: (bus_service_lookup):
4121 Reorder message sending so we get a more sane order.
4123 * test/bus-test.c: (message_handler):
4126 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4128 * bus/driver.c: (bus_driver_send_service_deleted),
4129 (bus_driver_send_service_created), (bus_driver_send_service_lost),
4130 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
4131 (bus_driver_send_welcome_message),
4132 (bus_driver_handle_list_services),
4133 (bus_driver_handle_acquire_service),
4134 (bus_driver_handle_service_exists):
4135 * dbus/dbus-bus.c: (dbus_bus_register_client),
4136 (dbus_bus_acquire_service), (dbus_bus_service_exists):
4137 * dbus/dbus-errors.c: (dbus_result_to_string):
4138 * dbus/dbus-errors.h:
4139 * dbus/dbus-message.c: (dbus_message_append_args),
4140 (dbus_message_append_args_valist), (dbus_message_get_args),
4141 (dbus_message_get_args_valist), (dbus_message_get_args_iter),
4142 (dbus_message_iter_get_arg_type), (dbus_message_iter_get_string),
4143 (dbus_message_iter_get_byte_array),
4144 (dbus_message_iter_get_string_array), (message_iter_test),
4145 (check_message_handling), (_dbus_message_test):
4146 * dbus/dbus-message.h:
4147 * test/bus-test.c: (main):
4148 Change fields to arguments in messages, so that they won't be
4149 confused with header fields.
4151 * glib/test-dbus-glib.c: (main):
4152 Remove append_fields from hello message.
4154 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4156 * dbus/dbus-errors.c:
4157 * dbus/dbus-message.c:
4158 * dbus/dbus-string.c:
4159 Documentation fixes.
4161 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4163 * glib/dbus-gmain.c: (timeout_handler), (add_timeout),
4165 Implement support for timeouts in dbus-glib.
4167 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4169 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
4170 * dbus/dbus-message.c: (process_test_subdir):
4171 * test/break-loader.c: (find_breaks_based_on):
4172 Plug some memory leaks.
4174 2003-02-13 Richard Hult <rhult@codefactory.se>
4176 * bus/main.c: Fix build.
4178 * dbus/dbus-errors.h:
4179 * dbus/dbus-errors.c: Fix copyright for Anders.
4181 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4186 * bus/connection.c: (bus_connection_foreach):
4189 * bus/desktop-file.c: (grow_lines_in_section), (grow_sections),
4190 (unescape_string), (new_section), (parse_section_start),
4191 (parse_key_value), (report_error), (bus_desktop_file_load),
4192 (bus_desktop_file_get_string):
4193 * bus/desktop-file.h:
4194 Use DBusError for error reporting.
4196 * bus/dispatch.c: (send_one_message),
4197 (bus_dispatch_message_handler):
4198 * bus/driver.c: (bus_driver_send_service_deleted),
4199 (bus_driver_send_service_created), (bus_driver_send_service_lost),
4200 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
4201 (bus_driver_send_welcome_message),
4202 (bus_driver_handle_list_services),
4203 (bus_driver_handle_acquire_service),
4204 (bus_driver_handle_service_exists):
4205 * bus/loop.c: (bus_loop_run):
4207 Use BUS_HANDLE_OOM instead of _DBUS_HANDLE_OOM.
4209 * bus/utils.c: (bus_wait_for_memory):
4211 New files with general utility functions.
4213 * dbus/dbus-internals.h:
4214 Remove _DBUS_HANDLE_OOM.
4216 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4218 * dbus/dbus-errors.c: (dbus_result_to_string), (dbus_error_init),
4219 (dbus_error_free), (dbus_set_error_const), (dbus_set_error):
4220 * dbus/dbus-errors.h:
4221 Add DBusError structure.
4223 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4225 * test/data/valid-messages/standard-acquire-service.message:
4226 * test/data/valid-messages/standard-hello.message:
4227 * test/data/valid-messages/standard-list-services.message:
4228 * test/data/valid-messages/standard-service-exists.message:
4229 Add some standard messages.
4231 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4233 * bus/driver.c: (bus_driver_send_welcome_message),
4234 (bus_driver_handle_list_services),
4235 (bus_driver_handle_acquire_service),
4236 (bus_driver_handle_service_exists), (bus_driver_handle_message):
4237 Update for API changes in libdbus.
4239 * dbus/dbus-message.c: (dbus_message_new_reply):
4240 * dbus/dbus-message.h:
4241 Remove the name argument. The spec states that replies shouldn't
4244 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4246 * bus/desktop-file.c: (parse_section_start), (parse_key_value),
4247 (report_error), (bus_desktop_file_load), (lookup_section),
4248 (lookup_line), (bus_desktop_file_get_raw),
4249 (bus_desktop_file_get_string):
4250 * bus/desktop-file.h:
4251 Some fixes, and new functions for getting a key value from a section.
4253 2003-02-13 Havoc Pennington <hp@pobox.com>
4255 * test/data/auth/fail-after-n-attempts.auth-script: new test
4257 * dbus/dbus-auth.c (send_rejected): shutdown_mech() when we
4260 2003-02-13 Havoc Pennington <hp@pobox.com>
4262 * dbus/dbus-auth.c (handle_server_data_external_mech): args to
4263 dbus_credentials_match were backward
4265 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support
4266 NO_CREDENTIALS and ROOT_CREDENTIALS
4268 * dbus/dbus-auth.c (_dbus_auth_do_work): move get_state() routine
4269 into here. Never process more commands after we've reached an
4270 end state; store further data as unused bytes.
4272 * test/data/auth/*: add more auth tests
4274 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support EXPECT
4275 command to match exact string and EXPECT_UNUSED to match unused
4278 * test/Makefile.am (dist-hook): fix to dist all the test stuff
4280 2003-02-12 Havoc Pennington <hp@pobox.com>
4282 * dbus/dbus-string.c (_dbus_string_pop_line): fix to also strip
4283 \r off of popped lines
4285 * dbus/dbus-auth.c (_dbus_auth_test): write code to run auth
4288 * dbus/dbus-auth-script.c (_dbus_auth_script_run): when doing a
4291 2003-02-12 Havoc Pennington <hp@pobox.com>
4293 * dbus/Makefile.am: remove break-loader from the build, since it
4296 * configure.in: add --enable-gcov to turn on coverage profiling
4297 flags and disable optimization
4299 2003-02-10 Havoc Pennington <hp@pobox.com>
4301 * dbus/dbus-auth-script.c, dbus/dbus-auth-script.h: sync
4302 initial cut at test framework for DBusAuth from laptop.
4303 Doesn't quite work yet but it compiles and I need to get
4304 it off the 266mhz laptop. ;-)
4306 * dbus/dbus-server-debug.c (_dbus_server_debug_accept_transport):
4307 fix a memleak in error case
4309 2003-02-12 Anders Carlsson <andersca@codefactory.se>
4312 * bus/desktop-file.c:
4313 * bus/desktop-file.h:
4314 Add a desktop file parser.
4316 2003-02-11 Zack Rusin <zack@kde.org>
4318 * qt/message.[h|cpp]: sample implementation
4319 of the KDE wrapper for DBusMessage
4321 2003-02-09 Zack Rusin <zack@kde.org>
4323 * test/bus-test.c: make_it_compile
4324 * doc/dbus-specification.sgml: minimal semantic fix
4326 2003-02-06 Anders Carlsson <andersca@codefactory.se>
4332 2003-02-06 Anders Carlsson <andersca@codefactory.se>
4335 * dbus/dbus-break-loader.c:
4337 * test/break-loader.c:
4338 Move dbus-break-loader to test/ and rename it to break-loader.
4340 2003-02-02 Havoc Pennington <hp@pobox.com>
4342 * dbus/dbus-keyring.c, dbus/dbus-keyring.h: template files
4343 for code to manage cookies in your home directory
4345 * dbus/dbus-sysdeps.c (_dbus_generate_random_bytes): new function
4347 * dbus/dbus-auth.c (get_state): impose a maximum number of tries
4348 to authenticate, then disconnect the client.
4350 2003-02-03 Alexander Larsson <alexl@redhat.com>
4352 * dbus/dbus-message.c (dbus_message_append_fields):
4355 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4357 * doc/dbus-specification.sgml:
4358 Update address format section.
4360 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4363 * test/bus-test.c: (get_time), (add_timeout), (remove_timeout),
4364 (message_handler), (new_connection_callback), (loop_quit),
4368 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4370 * bus/driver.c: (bus_driver_handle_service_exists):
4371 Simplify the code a bit.
4373 * dbus/dbus-bus.c: (dbus_bus_service_exists):
4376 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4379 Add libdbus-daemon.la and link to it.
4381 2003-02-01 James Willcox <jwillcox@gnome.org>
4383 * bus/driver.c: (bus_driver_handle_own_service):
4384 Actually include the service reply code in the message.
4386 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4388 * bus/driver.c: (bus_driver_handle_service_exists):
4389 Don't unref the incoming message.
4391 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4393 * dbus/dbus.h: Add dbus-address.h and dbus-bus.h
4395 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4397 * dbus/dbus-server.c: (dbus_server_listen):
4398 * dbus/dbus-transport.c: (_dbus_transport_open):
4399 ifdef out the calls to the debug transport and server.
4401 2003-02-02 Alexander Larsson <alexl@redhat.com>
4403 * dbus/dbus-watch.c (dbus_watch_get_flags):
4404 Add note in the docs that ERROR or HANGUP won't be returned
4405 and are assumed always on.
4407 * glib/dbus-gmain.c (add_watch):
4408 Always add IO_ERR | IO_HUP
4410 * dbus/dbus-message.h:
4411 Add semicolon after dbus_message_iter_get_string_array().
4412 Makes qt code build again
4414 2003-02-01 Anders Carlsson <andersca@codefactory.se>
4416 * bus/driver.c: (create_unique_client_name),
4417 (bus_driver_handle_hello):
4418 Don't take a name, just use a numeric id to identify
4422 * dbus/dbus-bus.c: (dbus_bus_register_client),
4423 (dbus_bus_acquire_service), (dbus_bus_service_exists):
4425 Add new convenience functions for communicating with the bus.
4427 * dbus/dbus-message.h:
4429 * dbus/dbus-protocol.h:
4432 2003-02-01 Alexander Larsson <alexl@redhat.com>
4434 * dbus/dbus-message.c (dbus_message_append_fields):
4435 Add some more doc comments.
4437 2003-02-01 Havoc Pennington <hp@pobox.com>
4439 * dbus/dbus-break-loader.c (randomly_modify_length): change
4440 a 4-byte value in the message as if it were a length
4442 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): don't set
4443 execute bit on saved files
4445 2003-02-01 Havoc Pennington <hp@pobox.com>
4447 * dbus/dbus-break-loader.c (main): new program to find messages
4448 that break the loader.
4450 * dbus/dbus-sysdeps.c (_dbus_string_append_uint): new function
4451 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): new function
4453 * dbus/dbus-string.c (_dbus_string_set_byte): new
4455 2003-01-31 Havoc Pennington <hp@pobox.com>
4457 * dbus/dbus-message.c: refactor the test code to be more general,
4458 in preparation for writing a "randomly permute test cases to
4459 try to break the loader" program.
4461 2003-01-31 Havoc Pennington <hp@pobox.com>
4463 * doc/dbus-specification.sgml: work on the specification
4465 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): check
4466 the protocol version of the message.
4468 * dbus/dbus-protocol.h: drop special _REPLY names, the spec
4469 no longer specifies that.
4470 (DBUS_SERVICE_REPLY_SERVICE_EXISTS): fix flags (1/2/4/8 not
4473 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos): add missing
4474 "break" for DBUS_TYPE_NIL, remove @todo
4476 2003-01-31 Havoc Pennington <hp@pobox.com>
4478 * dbus/dbus-message.c (dbus_message_set_is_error_reply): rename
4479 just set_is_error/get_is_error as this is a commonly-used
4480 function, and write docs.
4482 2003-01-31 Anders Carlsson <andersca@codefactory.se>
4484 * dbus/dbus-address.c: (dbus_address_entry_free):
4485 Free key and value lists.
4487 * dbus/dbus-internals.c: (_dbus_type_to_string):
4488 Add the types we didn't have.
4490 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
4491 (_dbus_marshal_validate_arg):
4494 * dbus/dbus-message.c: (dbus_message_set_sender):
4495 Remove todo about being able to set sender to NULL.
4497 (dbus_message_set_is_error_reply),
4498 (dbus_message_get_is_error_reply):
4499 * dbus/dbus-message.h:
4502 * dbus/dbus-protocol.h:
4503 Add error reply flag.
4505 * test/data/valid-messages/opposite-endian.message:
4506 Add NIL type to test.
4508 2003-01-31 Havoc Pennington <hp@pobox.com>
4510 * doc/dbus-specification.sgml: fully specify the header. Add
4511 flags and major protocol version, and change header/body len to
4514 * dbus/dbus-message-builder.c (append_saved_length): append length
4517 * dbus/dbus-message.c (dbus_message_create_header): change header
4518 length and body length to unsigned. Add the new fields from the
4520 (_dbus_message_loader_return_buffer): unsigned header/body len
4522 2003-01-30 Havoc Pennington <hp@pobox.com>
4524 * dbus/dbus-auth.c: rework to use only REJECTED, no
4527 * doc/dbus-sasl-profile.txt: drop MECHANISMS and just
4528 use REJECTED, suggested by Mark McLoughlin
4530 2003-01-30 Havoc Pennington <hp@pobox.com>
4532 * dbus/dbus-server.c (dbus_server_listen): @todo about how we need
4533 a better way to report errors here. e.g. "unix address lacks
4534 path" or something. also "no such file" when the path doesn't
4537 * dbus/dbus-address.c (dbus_address_entries_free): add @todo about
4539 (dbus_parse_address): add @todo about documenting address format,
4540 and allowing , and ; to be escaped
4542 2003-01-30 Anders Carlsson <andersca@codefactory.se>
4545 Add dbus-address.[ch]
4547 * dbus/dbus-address.c: (dbus_address_entry_free),
4548 (dbus_address_entries_free), (create_entry),
4549 (dbus_address_entry_get_method), (dbus_address_entry_get_value),
4550 (dbus_parse_address), (_dbus_address_test):
4551 * dbus/dbus-address.h:
4552 New files for dealing with address parsing.
4554 * dbus/dbus-connection.c:
4555 Document timeout functions.
4557 * dbus/dbus-message.c:
4558 Document dbus_message_new_from_message.
4560 * dbus/dbus-server-debug.c:
4563 * dbus/dbus-server.c: (dbus_server_listen):
4564 Parse address and use correct server implementation.
4566 * dbus/dbus-string.c: (_dbus_string_find_to), (_dbus_string_test):
4567 * dbus/dbus-string.h:
4568 New function with test.
4570 * dbus/dbus-test.c: (dbus_internal_symbol_do_not_use_run_tests):
4574 * dbus/dbus-transport-debug.c:
4577 * dbus/dbus-transport.c: (_dbus_transport_open):
4578 Parse address and use correct transport implementation.
4580 2003-01-30 Havoc Pennington <hp@pobox.com>
4582 * dbus/dbus-message.c: use message->byte_order instead of
4583 DBUS_COMPILER_BYTE_ORDER throughout.
4584 (dbus_message_create_header): pad header to align the
4585 start of the body of the message to 8-byte boundary
4587 * dbus/dbus-marshal.h: make all the demarshalers take const
4588 DBusString arguments.
4590 * dbus/dbus-message.c (_dbus_message_loader_return_buffer):
4591 validate message args here, so we don't have to do slow validation
4592 later, and so we catch bad messages as they are incoming. Also add
4593 better checks on header_len and body_len. Also fill in
4596 * dbus/dbus-string.c (_dbus_string_validate_utf8): new (not
4597 implemented properly)
4598 (_dbus_string_validate_nul): new function to check all-nul
4600 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): rename
4601 get_arg_end_pos and remove all validation
4602 (_dbus_marshal_validate_arg): actually do validation here.
4604 2003-01-29 Havoc Pennington <hp@pobox.com>
4606 * dbus/dbus-message.c (check_message_handling): fix assertion
4607 failure on set_client_serial
4609 2003-01-28 Havoc Pennington <hp@pobox.com>
4611 * dbus/dbus-server-debug.c: Add doc section comments
4613 * dbus/dbus-transport-debug.c: add doc section comments
4615 2003-01-28 Havoc Pennington <hp@redhat.com>
4617 * dbus/dbus-string.c (_dbus_string_base64_decode): append bytes in
4618 the reverse order from how I had it
4619 (_dbus_string_base64_encode): reverse encoding order. I was
4620 basically byteswapping everything during encoding.
4622 2003-01-28 Anders Carlsson <andersca@codefactory.se>
4624 * dbus/dbus-connection-internal.h:
4625 * dbus/dbus-connection.c: (_dbus_connection_add_timeout),
4626 (_dbus_connection_remove_timeout):
4627 Add functions for adding and removing timeouts.
4629 * dbus/dbus-message.c: (dbus_message_new_from_message):
4630 Add new function that takes a message and creates an exact
4631 copy of it, but with the refcount set to 1.
4632 (check_message_handling):
4635 * dbus/dbus-server-protected.h:
4636 * dbus/dbus-server.c: (_dbus_server_init_base),
4637 (_dbus_server_finalize_base), (_dbus_server_add_timeout),
4638 (dbus_server_set_timeout_functions):
4639 (_dbus_server_remove_timeout):
4640 New functions so that a server can add and remove timeouts.
4642 (dbus_server_listen):
4643 Add commented out call to dbus_server_debug_new.
4645 * dbus/dbus-timeout.c: (_dbus_timeout_new):
4646 Actually set the handler, doh.
4648 * dbus/dbus-transport.c: (_dbus_transport_open):
4649 Add commented out call to dbus_transport_debug_client_new.
4652 Add dbus-transport-debug.[ch] and dbus-server-debug.[ch]
4654 2003-01-28 Havoc Pennington <hp@pobox.com>
4656 * dbus/dbus-message.c (check_message_handling): function to check
4657 on the loaded message, iterates over it etc.
4659 2003-01-28 Havoc Pennington <hp@pobox.com>
4661 * test/Makefile.am (dist-hook): fix make distdir
4663 * dbus/Makefile.am (TESTS_ENVIRONMENT): fix make check
4665 2003-01-27 Havoc Pennington <hp@pobox.com>
4667 * dbus/dbus-mempool.c (time_for_size): replace printf with
4670 * dbus/dbus-message-builder.c (_dbus_message_data_load): allow
4671 empty lines; fix the SAVE_LENGTH stuff to be
4672 START_LENGTH/END_LENGTH so it actually works; couple other
4675 * test/Makefile.am (dist-hook): add dist-hook for .message files
4677 * dbus/dbus-string.c (DBUS_STRING_COPY_PREAMBLE): source of a copy
4678 can be constant or locked.
4679 (_dbus_string_free): allow freeing a const string as
4682 * dbus/dbus-sysdeps.c (_dbus_concat_dir_and_file): utility
4684 * dbus/dbus-test-main.c (main): take an argument which is the
4685 directory containing test data
4687 * dbus/dbus-message.c (_dbus_message_test): pass a test_data_dir
4688 argument to this and load all the messages in test/data/
4689 checking that they can be loaded or not loaded as appropriate.
4691 2003-01-27 Anders Carlsson <andersca@codefactory.se>
4693 * bus/dispatch.c: (bus_dispatch_message_handler):
4694 Dispatch messages sent to services.
4696 * bus/driver.c: (bus_driver_send_service_deleted),
4697 (bus_driver_send_service_created), (bus_driver_send_service_lost),
4698 (bus_driver_send_service_acquired):
4699 Add helper functions for sending service related messages.
4701 (bus_driver_send_welcome_message):
4702 Send HELLO_REPLY instead of WELCOME.
4704 (bus_driver_handle_list_services):
4705 Send LIST_SERVICES_REPLY instead of SERVICES.
4707 (bus_driver_handle_own_service),
4708 (bus_driver_handle_service_exists):
4709 New message handlers.
4711 (bus_driver_handle_message):
4712 Invoke new message handlers.
4714 (bus_driver_remove_connection):
4715 Don't remove any services here since that's done automatically
4716 by bus_service_remove_owner now.
4719 New function signatures.
4721 * bus/services.c: (bus_service_add_owner):
4722 Send ServiceAcquired message if we're the only primary owner.
4724 (bus_service_remove_owner):
4725 Send ServiceAcquired/ServiceLost messages.
4727 (bus_service_set_prohibit_replacement),
4728 (bus_service_get_prohibit_replacement):
4729 Functions for setting prohibit replacement.
4731 (bus_service_has_owner):
4732 New function that checks if a connection is in the owner queue of
4736 Add new function signatures.
4738 * dbus/dbus-list.c: (_dbus_list_test):
4739 Add tests for _dbus_list_remove_last and traversing the list backwards.
4742 Fix a typo in _dbus_list_get_prev_link, if we're at the first element we can't
4743 go any further, so return NULL then.
4745 * dbus/dbus-protocol.h:
4746 Add new messages, service flags and service replies.
4748 2003-01-26 Havoc Pennington <hp@pobox.com>
4750 * dbus/dbus-message-builder.c: implement, completely untested.
4752 * test/data/*: add data to be used in testing.
4753 ".message" files are our simple loadable text format.
4754 ".message-raw" will be binary dumps of messages.
4756 * dbus/dbus-string.c (_dbus_string_starts_with_c_str): new
4758 2003-01-26 Havoc Pennington <hp@pobox.com>
4760 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): new function
4762 * dbus/dbus-errors.c (dbus_result_to_string): add
4765 * dbus/dbus-message-builder.c: new file, will contain code to load
4766 up messages from files. Not implemented yet.
4768 2003-01-26 Havoc Pennington <hp@pobox.com>
4770 * dbus/dbus-message.c (dbus_message_set_sender): support deleting
4771 the sender by setting to NULL
4773 2003-01-26 Havoc Pennington <hp@pobox.com>
4775 The unit tests pass, but otherwise untested. If it breaks, the
4776 tests should have been better. ;-)
4778 * bus/driver.c (bus_driver_handle_hello): return if we disconnect
4781 * dbus/dbus-message.c: redo everything so we maintain
4782 message->header as the only copy of the various fields.
4783 This avoids the possibility of out-of-memory in some cases,
4784 for example dbus_message_lock() can't run out of memory anymore,
4785 and avoids extra copying. Figured I may as well go ahead and do
4786 this since it was busted for dbus_message_lock to not return
4787 failure on OOM, and dbus_message_write_header was totally
4788 unchecked for OOM. Also fixed some random other bugs.
4790 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): verify
4791 that strings are nul-terminated. Also, end_pos can be equal
4792 to string length just not greater than, I think.
4793 (_dbus_marshal_set_int32): new function
4794 (_dbus_marshal_set_uint32): new function
4795 (_dbus_marshal_set_string): new function
4797 * dbus/dbus-connection.c (_dbus_connection_new_for_transport): fix
4798 a warning, init timeout_list to NULL
4799 (dbus_connection_send_message): don't use uninitialized variable
4802 * dbus/dbus-string.c (_dbus_string_replace_len): new function
4804 2003-01-26 Anders Carlsson <andersca@codefactory.se>
4806 * bus/driver.c: (bus_driver_handle_hello),
4807 (bus_driver_send_welcome_message):
4810 2003-01-26 Anders Carlsson <andersca@codefactory.se>
4812 * dbus/dbus-auth.c: (process_auth), (_dbus_auth_unref):
4813 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
4814 (dbus_connection_unref):
4815 * dbus/dbus-marshal.c: (_dbus_marshal_test):
4816 * dbus/dbus-message.c: (dbus_message_unref),
4819 (dbus_message_get_fields):
4820 Remove debugging printout.
4822 (_dbus_message_loader_return_buffer):
4823 Don't store the header string.
4825 (_dbus_message_test):
4828 2003-01-26 Richard Hult <rhult@codefactory.se>
4830 * glib/dbus-gmain.c (dbus_connection_dispatch): Traverse a copy of
4831 the file descriptor list, since it can change under us.
4833 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4835 * glib/dbus-gmain.c: (dbus_connection_prepare),
4836 (dbus_connection_check), (dbus_connection_dispatch), (add_watch),
4837 (remove_watch), (dbus_connection_hookup_with_g_main):
4838 Rewrite the glib handling to use its own GSource instead of a
4839 GIOChannel so we can catch messages put in the queue while waiting
4842 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4845 * bus/connection.c: (connection_disconnect_handler),
4846 (connection_watch_callback), (bus_connection_setup):
4847 * bus/dispatch.c: (send_one_message),
4848 (bus_dispatch_broadcast_message), (bus_dispatch_message_handler),
4849 (bus_dispatch_add_connection), (bus_dispatch_remove_connection):
4851 * bus/driver.c: (bus_driver_send_service_deleted),
4852 (bus_driver_send_service_created), (bus_driver_handle_hello),
4853 (bus_driver_send_welcome_message),
4854 (bus_driver_handle_list_services), (bus_driver_remove_connection),
4855 (bus_driver_handle_message):
4857 Refactor code, put the message dispatching in its own file. Use
4858 _DBUS_HANDLE_OOM. Also send ServiceDeleted messages when a client
4861 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4863 * dbus/dbus-internals.h:
4864 Add _DBUS_HANDLE_OOM macro, it doesn't do anything currently.
4866 * dbus/dbus-message.c: (dbus_message_get_sender):
4867 * dbus/dbus-message.h:
4868 Implement dbus_message_get_sender.
4870 * dbus/dbus-protocol.h:
4871 Add message and service defines.
4873 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4875 * dbus/dbus-connection.c: (dbus_connection_send_message):
4876 * dbus/dbus-message-internal.h:
4877 * dbus/dbus-message.c: (_dbus_message_get_client_serial),
4878 (dbus_message_write_header):
4879 Remove _dbus_messag_unlock and don't set the client serial on a
4880 message if one already exists.
4882 2003-01-24 Havoc Pennington <hp@pobox.com>
4884 * dbus/dbus-list.c (alloc_link): put a thread lock on the global
4887 * bus/driver.c (bus_driver_handle_list_services): fix a leak
4890 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4892 * dbus/dbus-list.c: (alloc_link), (free_link):
4893 Use a memory pool for the links.
4895 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4897 * bus/connection.c: (bus_connection_foreach):
4899 Add new bus_connection_foreach function.
4901 * bus/driver.c: (send_one_message), (bus_driver_broadcast_message):
4902 Add function that broadcasts a message to all clients.
4904 (bus_driver_send_service_created), (bus_driver_handle_hello),
4905 (bus_driver_send_welcome_message),
4906 (bus_driver_handle_list_services), (bus_driver_message_handler):
4907 Implement functions that take care of listing services, and notifying
4908 clients when new services are created.
4910 * bus/services.c: (bus_services_list):
4912 Add new function that returns an array of strings with the currently
4913 registered services.
4916 * glib/dbus-gmain.c:
4917 Update copyright year.
4919 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4921 * dbus/dbus-connection.c: (dbus_connection_send_message):
4922 Unlock the message in case it was sent earlier.
4924 (dbus_connection_send_message_with_reply_and_block):
4925 Remove the reply message from the list.
4927 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
4928 Set array_len and new_pos correctly.
4930 (_dbus_marshal_test):
4931 Remove debug output.
4933 * dbus/dbus-message-internal.h:
4934 * dbus/dbus-message.c: (_dbus_message_get_reply_serial):
4935 New function that returns the reply serial.
4937 (_dbus_message_unlock):
4938 New function that unlocks a message and resets its header.
4940 (dbus_message_append_string_array),
4941 (dbus_message_get_fields_valist),
4942 (dbus_message_iter_get_field_type),
4943 (dbus_message_iter_get_string_array),
4944 (dbus_message_get_fields),
4945 (dbus_message_append_fields_valist):
4946 Handle string arrays.
4948 (dbus_message_set_sender):
4949 Make this function public since the bus daemon needs it.
4951 (decode_header_data):
4952 Set the reply serial to -1 initially.
4954 * dbus/dbus-message.h:
4955 Add dbus_message_set_sender.
4957 2003-01-24 Havoc Pennington <hp@pobox.com>
4959 * doc/dbus-specification.sgml: add some stuff
4961 2003-01-22 Havoc Pennington <hp@pobox.com>
4963 * doc/dbus-specification.sgml: Start to document the protocol.
4965 2003-01-22 Havoc Pennington <hp@pobox.com>
4967 * dbus/dbus-connection.c
4968 (dbus_connection_send_message_with_reply_and_block): add some @todo
4970 * bus/driver.c (bus_driver_add_connection): add a FIXME about memleak
4972 2003-01-21 Havoc Pennington <hp@pobox.com>
4974 (patch untested because can't compile)
4976 * bus/driver.c (create_unique_client_name): make this function
4977 never recycle client names. Also, caller should initialize
4980 * dbus/dbus-sysdeps.c (_dbus_get_current_time): new function
4982 2003-01-21 Anders Carlsson <andersca@codefactory.se>
4984 * dbus/dbus-marshal.c: (_dbus_marshal_double),
4985 (_dbus_marshal_int32), (_dbus_marshal_uint32),
4986 (_dbus_marshal_int32_array), (_dbus_marshal_uint32_array),
4987 (_dbus_marshal_double_array), (_dbus_marshal_string_array),
4988 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
4989 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
4990 (_dbus_marshal_get_field_end_pos), (_dbus_marshal_test):
4991 * dbus/dbus-marshal.h:
4992 * dbus/dbus-protocol.h:
4993 Add support for marshalling and demarshalling integer, double
4996 2003-01-21 Anders Carlsson <andersca@codefactory.se>
5001 * bus/connection.c: (connection_disconnect_handler):
5002 Remove the connection from the bus driver's list.
5004 (connection_watch_callback): Dispatch messages.
5006 (free_connection_data): Free connection name.
5008 (bus_connection_setup): Add connection to the bus driver's list.
5009 (bus_connection_remove_owned_service):
5010 (bus_connection_set_name), (bus_connection_get_name):
5011 Add functions for setting and getting the connection's name.
5014 Add function headers.
5016 * bus/driver.c: (create_unique_client_name),
5017 (bus_driver_handle_hello_message),
5018 (bus_driver_send_welcome_message), (bus_driver_message_handler),
5019 (bus_driver_add_connection), (bus_driver_remove_connection):
5022 * bus/services.c: (bus_service_free):
5024 New file that handles communication and registreation with the bus
5027 2003-01-21 Anders Carlsson <andersca@codefactory.se>
5029 * dbus/dbus-connection.c: (dbus_connection_send_message):
5030 Add a new client_serial parameter.
5032 (dbus_connection_send_message_with_reply):
5033 Remove a @todo since we've implemented the blocking function.
5035 (dbus_connection_send_message_with_reply_and_block):
5036 New function that sends a message and waits for a reply and
5037 then returns the reply.
5039 * dbus/dbus-connection.h:
5042 * dbus/dbus-errors.c: (dbus_result_to_string):
5043 * dbus/dbus-errors.h:
5044 Add new DBUS_RESULT.
5046 * dbus/dbus-message-internal.h:
5047 * dbus/dbus-message.c: (_dbus_message_get_reply_serial),
5048 (_dbus_message_set_sender), (dbus_message_write_header),
5049 (dbus_message_new_reply), (decode_header_data),
5050 (_dbus_message_loader_return_buffer), (_dbus_message_test):
5051 * dbus/dbus-message.h:
5052 Add new functions that set the reply serial and sender.
5053 Also marshal and demarshal them correctly and add test.
5055 * dbus/dbus-protocol.h:
5056 Add new DBUS_MESSAGE_TYPE_SENDER.
5059 * glib/dbus-gmain.c: (watch_callback), (free_callback_data),
5060 (add_watch), (remove_watch), (add_timeout), (remove_timeout),
5061 (dbus_connection_hookup_with_g_main):
5062 * glib/test-dbus-glib.c: (main):
5063 Rewrite to use GIOChannel and remove the GSource crack.
5065 * test/echo-client.c: (main):
5066 * test/watch.c: (check_messages):
5067 Update for changed APIs
5069 2003-01-19 Anders Carlsson <andersca@codefactory.se>
5071 * dbus/Makefile.am: Add dbus-timeout.[cħ]
5073 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport):
5074 Create a DBusTimeoutList.
5075 (dbus_connection_set_timeout_functions): Add new function to
5076 set timeout callbacks
5078 * dbus/dbus-connection.h: Add public DBusTimeout API.
5080 * dbus/dbus-message.c: (dbus_message_get_service):
5081 * dbus/dbus-message.h: New function.
5083 * dbus/dbus-server.c: Fix small doc typo.
5085 * dbus/dbus-timeout.[ch]: New files for mainloop timeouts.
5087 2003-01-19 Anders Carlsson <andersca@codefactory.se>
5089 * dbus/dbus-string.c (_dbus_string_move_len): Don't delete all
5090 of the string, just as long as specified.
5092 2003-01-19 Havoc Pennington <hp@pobox.com>
5094 * dbus/dbus-connection.c (dbus_connection_get_is_authenticated):
5097 * dbus/dbus-server.c (dbus_server_set_max_connections)
5098 (dbus_server_get_max_connections, dbus_server_get_n_connections):
5099 keep track of current number of connections, and add API for
5100 setting a max (but haven't implemented enforcing the max yet)
5102 2003-01-18 Havoc Pennington <hp@pobox.com>
5104 * dbus/dbus-transport-unix.c (unix_do_iteration): only do the
5105 reading/writing if read_watch != NULL or write_watch != NULL.
5107 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): fix
5108 the message loader code to actually load message->header and
5109 message->body into the newly-created message.
5111 * dbus/dbus-transport-unix.c (check_write_watch): fix a mem leak
5114 * dbus/dbus-connection.c (dbus_connection_set_max_message_size)
5115 (dbus_connection_get_max_message_size)
5116 (dbus_connection_set_max_live_messages_size)
5117 (dbus_connection_get_max_live_messages_size): implement some
5118 resource limitation functions
5120 * dbus/dbus-resources.c: new file implementing some of the
5121 resource limits stuff
5123 * dbus/dbus-message.c (dbus_message_iter_get_byte_array): add
5124 missing docs, add @todo to handle OOM etc.
5126 * dbus/dbus-marshal.c (_dbus_demarshal_byte_array): add missing
5129 2003-01-18 Havoc Pennington <hp@pobox.com>
5131 * dbus/dbus-connection.c (dbus_connection_unref): disconnect the
5132 connection if it hasn't been already.
5134 * dbus/dbus-connection.h: kill off the idea of an ErrorFunction,
5135 replace with DisconnectFunction.
5137 2003-01-18 Havoc Pennington <hp@pobox.com>
5139 Building --disable-verbose-mode --disable-asserts --disable-tests
5140 cuts the library from 112K to 45K or so
5142 * configure.in: check for varargs macro support,
5143 add --enable-verbose-mode, --enable-asserts.
5145 * dbus/dbus-internals.h (_dbus_assert): support
5147 (_dbus_verbose): support DBUS_ENABLE_VERBOSE_MODE
5149 2003-01-18 Havoc Pennington <hp@pobox.com>
5151 * dbus/dbus-test.c: include config.h so that tests actually run
5153 * dbus/dbus-string.c: add assertions that stuff is 8-byte aligned,
5154 so the failure mode when that assumption fails will be plenty
5157 2003-01-18 Havoc Pennington <hp@pobox.com>
5159 * configure.in: default --enable-tests to $USE_MAINTAINER_MODE
5161 * dbus/Makefile.am: fix it up so dubs-test-main.c is included in
5164 * test/Makefile.am: don't use special variable "TESTS" for echo-*
5165 since we don't want to use those in make check
5167 2003-01-15 Havoc Pennington <hp@redhat.com>
5173 2003-01-15 Havoc Pennington <hp@redhat.com>
5175 * test/Makefile.am: fix so that test source code ends up in the
5176 distribution on make distcheck
5178 2003-01-15 Havoc Pennington <hp@redhat.com>
5184 2003-01-15 Havoc Pennington <hp@redhat.com>
5186 * dbus/dbus-test.c (dbus_internal_symbol_do_not_use_run_tests):
5187 fix build when --disable-tests
5189 * Makefile.am (EXTRA_DIST): put HACKING in here
5191 * HACKING: document procedure for making a tarball release.
5193 2003-01-14 Anders Carlsson <andersca@codefactory.se>
5195 * bus/connection.c: (connection_error_handler),
5196 (bus_connection_setup):
5197 * bus/main.c: (main):
5198 Make sure that the DBusConnectionData struct is NULLed
5199 out to prevent a segfault.
5201 * dbus/dbus-errors.c: (dbus_result_to_string):
5202 * dbus/dbus-errors.h:
5203 * dbus/dbus-message.c: (dbus_message_get_fields),
5204 (dbus_message_get_fields_valist), (_dbus_message_test):
5205 * dbus/dbus-message.h:
5206 Make dbus_message_get_fields return a result code so we can
5207 track invalid fields as well as oom.
5209 2003-01-11 Havoc Pennington <hp@pobox.com>
5211 * configure.in: change --enable-test/--enable-ansi action-if-given
5212 to enable_foo=$enableval instead of enable_foo=yes
5214 2003-01-08 Havoc Pennington <hp@pobox.com>
5216 * dbus/dbus-string.c (_dbus_string_align_length): new function
5218 * dbus/dbus-test-main.c: move main() for test app here
5220 (dbus_internal_symbol_do_not_use_run_tests): we have to export a
5221 symbol to run tests, because dbus-test isn't in the main
5224 Code review nitpicks.
5226 * dbus/dbus-message.c (dbus_message_write_header): add newlines
5227 for people with narrow emacs ;-). Assert client_serial was filled
5228 in. Assert message->name != NULL.
5229 (dbus_message_append_fields): have "first_field_type" arg separate
5230 from va list, needed for C++ binding that also uses varargs IIRC
5231 and helps with type safety
5232 (dbus_message_new): add @todo about using DBusString to store
5233 service/name internally
5234 (dbus_message_new): don't leak ->service and ->name on OOM later
5236 (dbus_message_unref): free the service name
5237 (dbus_message_get_fields): same change to varargs
5238 i.e. first_field_type
5239 (_dbus_message_loader_return_buffer): assert that the message data
5240 is aligned (if not it's a bug in our code). Put in verbose griping
5241 about why we set corrupted = TRUE.
5242 (decode_header_data): add FIXME that char* is evil. Was going to
5243 add FIXME about evil locale-specific string.h strncmp, but just
5244 switched to wacky string-as-uint32 optimization. Move check for
5245 "no room for field name" above get_const_data_len() to avoid
5246 assertion failure in get_const_data_len if we have trailing 2
5247 bytes or the like. Check for service and name fields being
5248 provided twice. Don't leak service/name on error. Require field
5249 names to be aligned to 4 bytes.
5251 * dbus/dbus-marshal.c: move byte swap stuff to header
5252 (_dbus_pack_int32): uscore-prefix
5253 (_dbus_unpack_int32): uscore-prefix
5254 (_dbus_unpack_uint32): export
5255 (_dbus_demarshal_string): add @todo complaining about use of
5257 (_dbus_marshal_get_field_end_pos): add @todo about bad error
5258 handling allowing corrupt data to go unchecked
5260 2003-01-08 Havoc Pennington <hp@redhat.com>
5262 * dbus/dbus-transport-unix.c (unix_do_iteration): add read/write
5263 to the select() as needed for authentication. (should be using
5264 _dbus_poll() not select, but for another day)
5266 * dbus/dbus.h: include dbus/dbus-protocol.h
5268 2003-01-08 Anders Carlsson <andersca@codefactory.se>
5270 * dbus/Makefile.am (dbusinclude_HEADERS): Install
5273 2003-01-08 Anders Carlsson <andersca@codefactory.se>
5275 * dbus/dbus-internals.c: (_dbus_type_to_string):
5276 New function that returns a string describing a type.
5278 * dbus/dbus-marshal.c: (_dbus_demarshal_byte_array):
5279 * dbus/dbus-marshal.h:
5280 * dbus/dbus-message.c: (dbus_message_get_fields_valist),
5281 (dbus_message_iter_get_field_type), (dbus_message_iter_get_double),
5282 (dbus_message_iter_get_byte_array):
5283 * dbus/dbus-message.h:
5284 Add new convenience functions for appending and getting message fields.
5285 Also add demarshalling routines for byte arrays.
5287 2003-01-07 Anders Carlsson <andersca@codefactory.se>
5289 * dbus/dbus-connection-internal.h:
5290 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
5291 (_dbus_connection_get_next_client_serial),
5292 (dbus_connection_send_message):
5293 * dbus/dbus-internals.h:
5294 * dbus/dbus-marshal.c: (unpack_uint32), (dbus_unpack_int32),
5295 (dbus_pack_int32), (_dbus_marshal_double), (_dbus_marshal_int32),
5296 (_dbus_marshal_uint32), (_dbus_demarshal_double),
5297 (_dbus_demarshal_int32), (_dbus_demarshal_uint32),
5298 (_dbus_demarshal_string), (_dbus_marshal_get_field_end_pos),
5299 (_dbus_verbose_bytes), (_dbus_marshal_test):
5300 * dbus/dbus-marshal.h:
5301 * dbus/dbus-message-internal.h:
5302 * dbus/dbus-message.c: (_dbus_message_set_client_serial),
5303 (dbus_message_write_header), (_dbus_message_lock),
5304 (dbus_message_new), (dbus_message_ref), (dbus_message_unref),
5305 (dbus_message_get_name), (dbus_message_append_int32),
5306 (dbus_message_append_uint32), (dbus_message_append_double),
5307 (dbus_message_append_string), (dbus_message_append_byte_array),
5308 (dbus_message_get_fields_iter), (dbus_message_iter_ref),
5309 (dbus_message_iter_unref), (dbus_message_iter_has_next),
5310 (dbus_message_iter_next), (dbus_message_iter_get_field_type),
5311 (dbus_message_iter_get_string), (dbus_message_iter_get_int32),
5312 (dbus_message_iter_get_uint32), (dbus_message_iter_get_double),
5313 (decode_header_data), (_dbus_message_loader_return_buffer),
5314 (message_iter_test), (_dbus_message_test):
5315 * dbus/dbus-message.h:
5316 * dbus/dbus-protocol.h:
5317 * dbus/dbus-test.c: (main):
5319 * glib/test-dbus-glib.c: (message_handler), (main):
5320 * test/echo-client.c: (main):
5321 * test/watch.c: (check_messages):
5322 Make messages sendable and receivable for real.
5324 2003-01-07 Anders Carlsson <andersca@codefactory.se>
5326 * dbus/dbus-marshal.c: (_dbus_marshal_double),
5327 (_dbus_marshal_string), (_dbus_marshal_byte_array):
5328 * dbus/dbus-message.c: (dbus_message_append_int32),
5329 (dbus_message_append_uint32), (dbus_message_append_double),
5330 (dbus_message_append_string), (dbus_message_append_byte_array):
5331 Handle OOM restoration.
5333 2003-01-07 Anders Carlsson <andersca@codefactory.se>
5335 * dbus/dbus-marshal.c: (_dbus_marshal_string),
5336 (_dbus_demarshal_string), (_dbus_marshal_test):
5337 * dbus/dbus-marshal.h:
5338 * dbus/dbus-message.c: (dbus_message_get_name),
5339 Document these functions.
5341 (dbus_message_append_int32), (dbus_message_append_uint32),
5342 (dbus_message_append_double), (dbus_message_append_string),
5343 (dbus_message_append_byte_array):
5344 * dbus/dbus-message.h:
5345 Add functions for adding message fields of different types.
5347 * dbus/dbus-protocol.h:
5348 Add the different types.
5350 2003-01-05 Havoc Pennington <hp@pobox.com>
5352 * bus/connection.c: implement routines for handling connections,
5353 first thing is keeping a list of owned services on each connection
5354 and setting up watches etc.
5356 * bus/services.c: implement a mapping from service names to lists
5359 * dbus/dbus-hash.c: add DBUS_HASH_POINTER
5361 * dbus/dbus-threads.c (dbus_static_mutex_lock): add functions
5362 to use static mutexes for global data
5364 * dbus/dbus-connection.c (dbus_connection_set_data): add new
5365 collection of functions to set/get application-specific data
5366 on the DBusConnection.
5368 2003-01-04 Havoc Pennington <hp@pobox.com>
5370 * dbus/dbus-sysdeps.c (_dbus_sleep_milliseconds): new function
5371 (_dbus_poll): new function
5373 * dbus/dbus-internals.h (_DBUS_STRUCT_OFFSET): new macro
5376 * bus/loop.c: initial code for the daemon main loop
5378 2003-01-04 Havoc Pennington <hp@pobox.com>
5380 * test/watch.c (error_handler): make it safe if the error handler
5381 is called multiple times (if we s/error handler/disconnect
5382 handler/ we should just guarantee it's called only once)
5384 * dbus/dbus-transport.c (_dbus_transport_disconnect): call the
5385 error handler on disconnect (it's quite possible we should
5386 just change the error handler to a "disconnect handler," I'm
5387 not sure we have any other meaningful errors)
5389 * configure.in: check for getpwnam_r
5391 * dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
5392 dbus/dbus-auth.c: add credentials support, add EXTERNAL auth
5393 mechanism as in SASL spec, using socket credentials
5395 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): new function
5396 (_dbus_send_credentials_unix_socket): new function
5398 * dbus/dbus-sysdeps.c (_dbus_accept_unix_socket): rename just
5400 (_dbus_write): only check errno if <0 returned
5401 (_dbus_write_two): ditto
5403 2003-01-02 Anders Carlsson <andersca@codefactory.se>
5405 * dbus/dbus-marshal.c: (_dbus_marshal_utf8_string),
5406 (_dbus_marshal_byte_array), (_dbus_demarshal_utf8_string),
5407 (_dbus_marshal_test):
5408 * dbus/dbus-marshal.h:
5409 Add _dbus_marshal_byte_array and rename _dbus_marshal_string
5410 to _dbus_marshal_utf8_string. Also fix some tests.
5412 2002-12-28 Harri Porten <porten@kde.org>
5414 * configure.in: added check for C++ compiler and a very cheesy
5415 check for the Qt integration
5417 * Makefile.am (SUBDIRS): compile qt subdir if support is enabled
5419 * qt/Makefile.am: added
5421 * qt/.cvsignore: added
5423 * qt/dbus-qthread.cc, qt/dbus-qthread.cpp: renamed former to
5424 latter, added #ifdef QT_THREAD_SUPPORT guard.
5426 * dbus/Makefile.am: added missing headers for make dist
5428 2002-12-28 Kristian Rietveld <kris@gtk.org>
5430 * dbus/Makefile.am: fixup export-symbols-regex.
5432 2002-12-27 Anders Carlsson <andersca@codefactory.se>
5434 * acinclude.m4: Add this file and put the
5435 PKG_CHECK_MODULE macro in it.
5437 2002-12-27 Anders Carlsson <andersca@codefactory.se>
5439 * dbus/dbus-marshal.c: (_dbus_marshal_string),
5440 (_dbus_demarshal_double), (_dbus_demarshal_int32),
5441 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
5442 (_dbus_marshal_test):
5443 Make the demarshalling routines align the pos argument.
5444 Add string marshalling tests and fix the obvious bugs
5447 2002-12-26 Havoc Pennington <hp@pobox.com>
5449 * dbus/dbus-auth.c: fixes fixes fixes
5451 * dbus/dbus-transport-unix.c: wire up support for
5452 encoding/decoding data on the wire
5454 * dbus/dbus-auth.c (_dbus_auth_encode_data)
5455 (_dbus_auth_decode_data): append to target string
5456 instead of nuking it.
5458 2002-12-26 Havoc Pennington <hp@pobox.com>
5460 * dbus/dbus-marshal.h (DBUS_COMPILER_BYTE_ORDER): #ifdef
5461 WORDS_BIGENDIAN then compiler byte order is DBUS_BIG_ENDIAN,
5464 * dbus/dbus-marshal.c: Add macros to do int swapping in-place and
5465 avoid swap_bytes() overhead (ignoring possible assembly stuff for
5466 now). Main point is because I wanted unpack_uint32 to implement
5468 (_dbus_verbose_bytes): new function
5470 * dbus/dbus-string.c (_dbus_string_validate_ascii): new function
5472 * dbus/dbus-message.c (_dbus_message_loader_get_is_corrupted): add
5473 mechanism to handle a corrupt message stream
5474 (_dbus_message_loader_new): fix preallocation to only prealloc,
5477 * dbus/dbus-string.c (_dbus_string_skip_blank): fix this function
5478 (_dbus_string_test): enhance tests for copy/move and fix the
5481 * dbus/dbus-transport-unix.c: Hold references in more places to
5482 avoid reentrancy problems
5484 * dbus/dbus-transport.c: ditto
5486 * dbus/dbus-connection.c (dbus_connection_dispatch_message): don't
5487 leak reference count in no-message case
5489 * test/watch.c (do_mainloop): handle adding/removing watches
5490 during iteration over the watches. Also, ref the connection/server
5491 stored on a watch, so we don't try to mangle a destroyed one.
5493 * dbus/dbus-transport-unix.c (do_authentication): perform
5496 * dbus/dbus-auth.c (get_state): add a state
5497 AUTHENTICATED_WITH_UNUSED_BYTES and return it if required
5498 (_dbus_auth_get_unused_bytes): append the unused bytes
5499 to the passed in string, rather than prepend
5501 * dbus/dbus-transport.c (_dbus_transport_init_base): create
5502 the auth conversation DBusAuth
5504 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd)
5505 (_dbus_transport_new_for_domain_socket): when creating a
5506 transport, pass in whether it's a client-side or server-side
5507 transport so we know which DBusAuth to create
5509 2002-12-03 Havoc Pennington <hp@pobox.com>
5511 * dbus/dbus-transport-unix.c (unix_finalize): finalize base
5512 _after_ finalizing the derived members
5513 (unix_connection_set): unref watch if we fail to add it
5515 * dbus/dbus-connection.c (dbus_connection_unref): delete the
5516 transport first, so that the connection owned by the
5517 transport will be valid as the transport finalizes.
5519 * dbus/dbus-transport-unix.c (unix_finalize): free the write_watch
5520 if necessary, and remove watches from the connection.
5522 * dbus/dbus-watch.c (_dbus_watch_list_free): improve a comment
5524 2002-12-26 Anders Carlsson <andersca@codefactory.se>
5526 * dbus/dbus-marshal.c: (_dbus_marshal_string),
5527 (_dbus_demarshal_double), (_dbus_demarshal_int32),
5528 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
5529 (_dbus_marshal_test):
5530 * dbus/dbus-marshal.h:
5531 Add string marshal functions and have the demarshal functions
5532 return the new position.
5534 2002-12-25 Havoc Pennington <hp@pobox.com>
5536 * doc/dbus-sasl-profile.txt: docs on the authentication protocol,
5537 it is a simple protocol that just maps directly to SASL.
5539 * dbus/dbus-auth.h, dbus/dbus-auth.c: authentication protocol
5540 initial implementation, not actually used yet.
5542 * dbus/dbus-string.c (_dbus_string_find): new function
5543 (_dbus_string_equal): new function
5544 (_dbus_string_base64_encode): new function
5545 (_dbus_string_base64_decode): new function
5547 2002-12-25 Anders Carlsson <andersca@codefactory.se>
5550 * dbus/dbus-marshal.c: (swap_bytes), (_dbus_marshal_double),
5551 (_dbus_marshal_int32), (_dbus_marshal_uint32),
5552 (_dbus_demarshal_double), (_dbus_demarshal_int32),
5553 (_dbus_demarshal_uint32), (_dbus_marshal_test):
5554 * dbus/dbus-marshal.h:
5555 * dbus/dbus-protocol.h:
5556 * dbus/dbus-test.c: (main):
5558 Add un-optimized marshalling/demarshalling routines.
5560 2002-12-25 Harri Porten <porten@kde.org>
5562 * qt/dbus-qt.h: adjusted ctor and getter to KDE/Qt conventions
5564 2002-12-24 Zack Rusin <zack@kde.org>
5566 * qt/dbus-qthread.cc: adding - integrates QMutex into Dbus
5567 * qt/dbus-qt.h: skeleton with two sample implemenatation of the
5570 2002-12-24 Havoc Pennington <hp@pobox.com>
5572 * glib/dbus-gthread.c: fix include
5574 * glib/dbus-glib.h: rename DBusMessageHandler for now.
5575 I think glib API needs to change, though, as you don't
5576 want to use DBusMessageFunction, you want to use the
5577 DBusMessageHandler object. Probably
5578 dbus_connection_open_with_g_main_loop()
5579 and dbus_connection_setup_g_main_loop() or something like that
5580 (but think of better names...) that just create a connection
5581 that has watch/timeout functions etc. already set up.
5583 * dbus/dbus-connection.c
5584 (dbus_connection_send_message_with_reply): new function just to
5585 show how the message handler helps us deal with replies.
5587 * dbus/dbus-list.c (_dbus_list_remove_last): new function
5589 * dbus/dbus-string.c (_dbus_string_test): free a string that
5592 * dbus/dbus-hash.c: use memory pools for the hash entries
5593 (rebuild_table): be more paranoid about overflow, and
5594 shrink table when we can
5595 (_dbus_hash_test): reduce number of sprintfs and write
5596 valid C89. Add tests for case where we grow and then
5597 shrink the hash table.
5599 * dbus/dbus-mempool.h, dbus/dbus-mempool.c: memory pools
5601 * dbus/dbus-connection.c (dbus_connection_register_handler)
5602 (dbus_connection_unregister_handler): new functions
5604 * dbus/dbus-message.c (dbus_message_get_name): new
5606 * dbus/dbus-list.c: fix docs typo
5608 * dbus/dbus-message-handler.h, dbus/dbus-message-handler.c:
5609 an object representing a handler for messages.
5611 2002-12-16 Anders Carlsson <andersca@codefactory.se>
5614 * glib/dbus-gthread.c: (dbus_gthread_init):
5615 Don't use the gdbus prefix for public functions.
5617 2002-12-16 Anders Carlsson <andersca@codefactory.se>
5621 Add GLib checks and fixup .pc files
5625 * glib/dbus-gmain.c: (gdbus_connection_prepare),
5626 (gdbus_connection_check), (gdbus_connection_dispatch),
5627 (gdbus_add_connection_watch), (gdbus_remove_connection_watch),
5628 (dbus_connection_gsource_new):
5629 * glib/dbus-gthread.c: (dbus_gmutex_new), (dbus_gmutex_free),
5630 (dbus_gmutex_lock), (dbus_gmutex_unlock), (dbus_gthread_init):
5631 * glib/test-dbus-glib.c: (message_handler), (main):
5634 2002-12-15 Harri Porten <porten@kde.org>
5636 * autogen.sh: check for libtoolize before attempting to use it
5638 * dbus/dbus-transport-unix.c: include <sys/time.h> for timeval
5641 * .cvsignore: ignore more stamp files
5643 * dbus/dbus-watch.c (_dbus_watch_list_new): fixed doc error
5645 * test/Makefile.am: added -I$(top_srcdir) to be able to compile
5646 without make install.
5648 2002-12-15 Havoc Pennington <hp@pobox.com>
5650 * dbus/dbus-threads.c: add thread stubs that a higher library
5651 layer can fill in. e.g. the GLib wrapper might fill them in with
5652 GThread stuff. We still need to use this thread API to
5653 thread-safe-ize the library.
5655 2002-12-12 Havoc Pennington <hp@pobox.com>
5657 * dbus/dbus-transport-unix.c, dbus/dbus-server-unix.c: use the
5658 below new interfaces and include fewer system headers.
5660 * dbus/dbus-sysdeps.c (_dbus_read): new function
5661 (_dbus_write): new function
5662 (_dbus_write_two): new function
5663 (_dbus_connect_unix_socket): new function
5664 (_dbus_listen_unix_socket): new function
5666 * dbus/dbus-message-internal.h: change interfaces to use
5669 2002-12-11 Havoc Pennington <hp@pobox.com>
5671 * dbus/dbus-types.h: add dbus_unichar
5673 * dbus/dbus-internals.c (_dbus_verbose): use _dbus_getenv
5675 * dbus/dbus-connection.c (dbus_connection_send_message): return
5678 * dbus/dbus-transport.c: include dbus-watch.h
5680 * dbus/dbus-connection.c: include dbus-message-internal.h
5682 * HACKING: add file with coding guidelines stuff.
5684 * dbus/dbus-string.h, dbus/dbus-string.c: Encapsulate all string
5685 handling here, for security purposes (as in vsftpd). Not actually
5686 using this class yet.
5688 * dbus/dbus-sysdeps.h, dbus/dbus-sysdeps.c: Encapsulate all
5689 system/libc usage here, as in vsftpd, for ease of auditing (and
5690 should also simplify portability). Haven't actually moved all the
5691 system/libc usage into here yet.
5693 2002-11-25 Havoc Pennington <hp@pobox.com>
5695 * dbus/dbus-internals.c (_dbus_verbose): fix to not
5696 always print the first verbose message.
5698 2002-11-24 Havoc Pennington <hp@pobox.com>
5700 * test/echo-client.c, test/echo-server.c: cheesy test
5703 * configure.in (AC_CHECK_FUNCS): check for writev
5705 * dbus/dbus-message.c (_dbus_message_get_network_data): new
5708 * dbus/dbus-list.c (_dbus_list_foreach): new function
5710 * dbus/dbus-internals.c (_dbus_verbose): new function
5712 * dbus/dbus-server.c, dbus/dbus-server.h: public object
5713 representing a server that listens for connections.
5715 * dbus/.cvsignore: create
5717 * dbus/dbus-errors.h, dbus/dbus-errors.c:
5718 public API for reporting errors
5720 * dbus/dbus-connection.h, dbus/dbus-connection.c:
5721 public object representing a connection that
5722 sends/receives messages. (Same object used for
5723 both client and server.)
5725 * dbus/dbus-transport.h, dbus/dbus-transport.c:
5726 Basic abstraction for different kinds of stream
5727 that we might read/write messages from.
5729 2002-11-23 Havoc Pennington <hp@pobox.com>
5731 * dbus/dbus-internals.h (_DBUS_INT_MAX): add _DBUS_INT_MIN
5734 * dbus/dbus-test.c (main): add list test, and include
5735 dbus-test.h as intended
5737 * dbus/dbus-hash.c (_dbus_hash_table_remove_string)
5738 (_dbus_hash_table_remove_int): return value indicates
5739 whether the entry existed to remove
5741 * dbus/dbus-list.c: add linked list utility class,
5744 * dbus/dbus-hash.c: add TODO item about shrinking the hash bucket
5747 2002-11-23 Havoc Pennington <hp@pobox.com>
5749 * Doxyfile.in (INCLUDE_FILE_PATTERNS): expand DBUS_BEGIN_DECLS/
5750 DBUS_END_DECLS to nothing, that should fix this once and for all
5752 * Doxyfile.in (JAVADOC_AUTOBRIEF): set to YES
5754 * dbus/dbus-message.c, dbus/dbus-hash.c:
5755 add some missing @brief
5757 2002-11-23 Havoc Pennington <hp@pobox.com>
5759 * dbus/dbus-message.h: put semicolons after DEBUG_BEGIN_DECLS
5760 to avoid confusing Doxygen
5762 * dbus/dbus-hash.c: @} not }@
5764 * dbus/dbus-message.c (struct DBusMessage): split out
5767 2002-11-23 Havoc Pennington <hp@pobox.com>
5769 * configure.in: pile on more warning flags if using gcc
5771 * Doxyfile.in (EXTRACT_STATIC): set to NO, so we don't have
5772 to document static functions
5774 * configure.in: add summary to end of configure so it
5775 looks nice and attractive
5777 * dbus/dbus-hash.c: finish implementation and write unit
5780 * configure.in: add --enable-tests to enable unit tests
5782 * dbus/dbus-test.c: test program to run unit tests
5783 for all files in dbus/*, initially runs a test for
5786 * dbus/dbus-internals.h: file to hold some internal utility stuff
5788 2002-11-22 Havoc Pennington <hp@redhat.com>
5790 * dbus/dbus-hash.c: copy in Tcl hash table, not yet
5791 "ported" away from Tcl
5793 * dbus/dbus-types.h: header for types such as dbus_bool_t
5795 2002-11-22 Havoc Pennington <hp@redhat.com>
5797 * dbus/dbus.h: fixups for doc warnings
5799 * Doxyfile.in (FILE_PATTERNS): we need to scan .h to pick up
5801 (QUIET): make it quiet so we can see warnings
5803 * dbus/dbus-memory.c: teach D-BUS to allocate and free memory
5805 2002-11-22 Havoc Pennington <hp@redhat.com>
5807 * Makefile.am: include "Doxyfile" target in all-local
5809 * configure.in: generate the Doxyfile
5811 * Doxyfile.in: move Doxyfile here, so we can use
5812 configure to generate a Doxyfile with the right
5815 2002-11-22 Havoc Pennington <hp@redhat.com>
5817 * dbus/dbus-message.c: move inline docs into .c file
5819 * Doxyfile (OUTPUT_DIRECTORY): move output to doc/api
5820 so all docs are under doc/
5821 (MAN_EXTENSION): generate man pages. Use extension
5822 ".3dbus" which matches ".3qt" on my system,
5823 I guess this is OK, I don't know really.
5824 (FILE_PATTERNS): look for .c files not .h, makes sense
5827 2002-11-22 Havoc Pennington <hp@pobox.com>
5829 * Makefile.am (SUBDIRS): rename subdir "server" to "bus"
5830 because any app can be a server, and any app can be a client,
5831 the bus is a special kind of server.
5833 Thu Nov 21 23:35:31 2002 Zack Rusin <zack@kde.org>
5835 * Doxyfile : adding. Still needs Makefile rules to be generated
5836 automatically (just run "doxygen" in the toplevel dir for now to
5839 * dbus/dbus-message.h : Adding sample docs (javadoc since
5840 resembles gtk-doc a little more)
5842 * dbus/dbus.h : Adding sample docs
5844 2002-11-21 Havoc Pennington <hp@redhat.com>
5846 * dbus/Makefile.am (INCLUDES): define DBUS_COMPILATION
5847 so we can allow ourselves to include files directly,
5848 instead of having to use dbus.h
5850 * dbus/dbus.h: fill in
5852 * dbus/dbus-message.h: sketch out a sample header file.
5853 Include griping if you include it directly instead of
5856 * dbus/dbus-macros.h: new file with macros for extern "C",
5857 TRUE/FALSE, NULL, etc.
5859 * doc/file-boilerplate.c: put include guards in here
5861 2002-11-21 Havoc Pennington <hp@redhat.com>
5863 * doc/file-boilerplate.c: include both AFL and GPL boilerplate.
5865 * COPYING: include the GPL as well, and license code
5866 under both AFL and GPL.
5868 2002-11-21 Havoc Pennington <hp@redhat.com>
5870 * acconfig.h: get rid of this
5872 * autogen.sh (run_configure): add --no-configure option
5874 * configure.in: remove AC_ARG_PROGRAM to make
5875 autoconf complain less. add AC_PREREQ.
5876 add AC_DEFINE third arg.
5878 2002-11-21 Anders Carlsson <andersca@codefactory.se>
5881 Fix references so we can distcheck.
5883 2002-11-21 Havoc Pennington <hp@redhat.com>
5885 * Initial module creation