1 2006-06-11 Jim Meyering <jim@meyering.net>
3 Setting TIME_STYLE=long-iso in the environment would make the
4 cp/same-file test fail.
5 * tests/envvar-check (vars): Add TIME_STYLE to the list.
6 * tests/cp/same-file: Revert last change.
7 Source the envvar-check script, to ensure that TIME_STYLE
8 settings don't affect these tests.
10 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
12 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
13 uses POSIX time stamp formats. Problem reported by John Nixon in
14 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
16 2006-06-10 Jim Meyering <jim@meyering.net>
18 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
20 Require a "Version N.M" line at the top of the ChangeLog
21 file only when making the actual release, not when running
23 * Makefile.maint (maintainer-distcheck): Don't depend on
25 (alpha beta major): Depend on it here, instead.
27 2006-06-08 Jim Meyering <jim@meyering.net>
29 Ensure that cat works with any of the options, -A -v -e -E -T,
30 when applied to files in /proc and /sys, even when the FIONREAD
31 ioctl produces nonsensical results. Before this change, cat would
32 produce no output (or truncated output), for some linux kernels.
34 * src/cat.c (write_pending): New function, factored out of cat.
35 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
36 that there are bytes to read. Some versions of linux-2.6.16 do that.
37 Write any pending output before returning.
38 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
39 * NEWS: Mention this bug fix.
40 * tests/misc/cat-proc: New file. Test for the above.
41 * tests/misc/Makefile.am (TESTS): Add cat-proc.
43 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
45 * src/expr.c (eval4): Detect overflow properly when multiplying
48 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
50 * NEWS: The 'expr' command now detects and reports integer overflow.
51 (It would be better to use extended precision instead, but that
53 * src/expr.c (integer_overflow): New function.
54 (eval4, eval3): Check for integer overflow.
56 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
58 Fix problems when building with Solaris/SVR4/etc. make, which uses a
59 different and somewhat bogus implementation of VPATH. In the
60 directory tests/misc, rename tests whose names might appear in the
61 Automake-generated rules. For example, we can't use a test named
62 'test', since Automake generates a rule that contains the text
63 "if test -f ./$$tst; ...", and this might expand to something like
64 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
65 which executes the 'test' script rather than the 'test' command.
66 * tests/misc/false-status: Renamed from tests/misc/false.
67 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
68 * tests/misc/sort-merge: Renamed from tests/misc/sort.
69 ($prog): Set to 'sort' rather than to $PROG.
70 * tests/misc/test-diag: Renamed from tests/misc/test.
71 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
72 in case Solaris make has prepended the directory.
73 (TESTS): Adjust to above renamings.
74 * tests/misc/expand: Don't assign to PROG; no longer needed
75 now that Makefile.am sets PROG to the basename.
76 * tests/misc/fold: Likewise.
78 2006-06-03 Jim Meyering <jim@meyering.net>
80 Make `cp --link --no-dereference' work also on systems where the
81 link system call cannot create a hard link to a symbolic link.
82 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
83 the link syscall on a symlink when it would do the wrong thing.
84 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
85 * tests/cp/link-no-deref: New file/test for the above.
86 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
87 * NEWS: Mention the change (doesn't affect Linux).
89 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
91 Fix some porting problems in the test cases reported by
92 Ralf Wildenhues for HP-UX 11.23 in:
93 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
94 * tests/help-version: Don't assume that \< \> works in sed.
95 * tests/misc/close-stdout: Don't assume that >&- works.
97 * tests/touch/no-create-missing: Don't assume that >&- works.
99 2006-05-30 Jim Meyering <jim@meyering.net>
101 * src/ls.c (usage): Add `v' to the list of sorting-related options.
104 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
106 * tests/cp/fail-perm: source lang-default.
107 * tests/rm/inaccessible: Likewise.
109 2006-05-28 Jim Meyering <jim@meyering.net>
111 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
112 Recognize it, too. Reported by Ralf Wildenhues, in
113 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
115 2006-05-27 Jim Meyering <jim@meyering.net>
117 * src/chgrp.c: Support new options: --preserve-root and
118 --no-preserve-root. Somehow this program was skipped when those
119 options were added to chown, chmod, and rm. Reported by
120 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
121 * NEWS: Mention this.
123 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
125 * NEWS: Remove mention of --seed. We'll replace it with something
126 better, and don't want to indicate that it is supported.
127 * src/sort.c (usage): Likewise.
129 2006-05-20 Jim Meyering <jim@meyering.net>
131 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
133 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
134 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
135 FTS_COMFOLLOW. Spotted by Justin Pryzby.
137 * gnupload: Merge changes from automake, retaining the ""--to...
138 kludge to placate overzealous `make distcheck' check.
140 2006-05-19 Jim Meyering <jim@meyering.net>
142 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
143 FTS_TIGHT_CYCLE_CHECK directory traversal option.
144 Reported by Justin Pryzby in http://bugs.debian.org/367691
146 2006-05-15 Jim Meyering <jim@meyering.net>
148 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
151 2006-05-13 Jim Meyering <jim@meyering.net>
153 * tests/mv/no-target-dir: Test two more cases.
155 2006-05-11 Jim Meyering <jim@meyering.net>
157 mv -T DIR EMPTY_DIR no longer fails unconditionally
158 * src/copy.c (copy_internal): Don't manually prohibit a move where
159 the destination is an existing directory. Sometimes doing that is
160 valid. Let the rename system call enforce the rules. That is
161 allowed only when the source is a directory and the destination
162 directory (to be replaced) is empty. Reported by Eric Blake.
163 * tests/mv/no-target-dir: New file/test for this.
164 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
165 * NEWS: Mention this.
167 * tests/mv/atomic: New file/test for yesterday's fix.
168 * tests/mv/Makefile.am (TESTS): Add atomic.
170 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
172 2006-05-10 Jim Meyering <jim@meyering.net>
174 * src/copy.c (copy_internal): Don't explicitly unlink the destination
175 when moving a symlink into the place of an existing non-directory.
176 Reported by Joshua Hudson.
177 * NEWS: mention this.
179 2006-05-07 Jim Meyering <jim@meyering.net>
181 * Makefile.maint (patch-check): Fail if patch generates any output,
182 even merely for changed offsets.
184 * src/c99-to-c89.diff: Adjust to reflect new offsets.
186 * NEWS: Mention changes affecting df, pwd, shred.
188 2006-05-06 Jim Meyering <jim@meyering.net>
190 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
191 system condition where dirent.d_ino != stat.st_ino.
192 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
194 2006-05-06 Eric Blake <ebb9@byu.net>
196 * tests/ls/inode: Expand to test inode from readdir case.
197 * tests/ls/follow-slink: Expand to test broken links encountered
198 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
200 2006-05-06 Eric Blake <ebb9@byu.net>
202 * tests/mv/leak-fd: Work even on case-insensitive file system.
204 2006-05-04 Jim Meyering <jim@meyering.net>
206 * NEWS: Mention the 2006-03-19 pwd-related change that makes
207 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
209 2006-05-03 Jim Meyering <jim@meyering.net>
211 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
212 Use better macro parameter names: s/basename/key_name/,
213 s/basefunc/key_cmp_func. Fix typo in comment.
215 2006-04-29 Eric Blake <ebb9@byu.net>
217 * src/ls.c (main): On systems with d_type, directories_first only
218 implies format_needs_type, not format_needs_stat.
220 2006-05-03 Jim Meyering <jim@meyering.net>
222 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
223 after comma in arg list, from Eric Blake.
225 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
227 * tests/misc/date (relative-3): New test, derived from a bug
228 report by John Thomas McDole.
230 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
232 New option for ls: --group-directories-first.
233 It makes ls list directories before files.
234 * NEWS [New features]: Mention it.
235 * src/ls.c (sort_type): Rearrange to use as an array index when
236 choosing sort function; added new sort_numtypes member for
238 (time_type): Add new time_numtypes member for compile-time check.
239 (directories_first): New global variable.
240 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
241 (long_options): Add --directories-first.
242 (main): Support new option.
243 (is_directory): New function.
244 (extract_dirs_from_files): Use it.
245 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
246 (LIST_SORTFUNCTION_VARIANTS): New macros.
247 (sort_functions): New global variable.
248 (sort_files): Use it.
249 (usage): Document new option.
251 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
253 * src/shred.c (fillrand): The assertion was way too weak, due to
254 what must be a typo. Strengthen it to its intended value.
255 (dopass): Don't use alloca; it's not worth the aggravation here,
256 since it's used only to get a page-aligned buffer, and page
257 alignment doesn't buy us much here. I'm suspicious that alloca
258 causes problems on some hosts, due to a recent bug report by Adam
259 Waltman: http://bugs.gentoo.org/130246.
261 2006-04-18 Jim Meyering <jim@meyering.net>
263 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
264 sha384sum, sha512sum.
266 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
268 * src/chmod.c (describe_change): Adjust to filemode changes.
269 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
270 (print_long_format): Use (new) filemodestring rather than
271 (old) mode_string, so that we get more file types right, at least
272 in theory. Adjust to filemode changes.
273 * src/stat.c (human_access): Likewise.
275 2006-04-18 Jim Meyering <jim@meyering.net>
277 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
278 ignore file. This has never been enabled. Reported by Eric Blake.
280 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
282 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
283 bug in Interix. Just call symlink or link directly. All uses changed.
284 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
285 * src/stat.c (USE_STATVFS): New macro.
286 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
287 (NAMEMAX_FORMAT): define a bit more clearly, now that the
288 statvfs-using code is a bit more regular.
289 * src/system.h (sync) [!HAVE_SYNC]: New macro.
291 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
293 * NEWS: csplit, nl, expr now conform to POSIX better, and are
294 more-compatible with traditional Unix, with respect to regular
296 * src/csplit.c (extract_regexp): Set re_syntax_options to a
297 value that is compatible with what POSIX requires.
298 * src/nl.c (build_type_arg): Likewise.
299 * src/expr.c (docolon): Likewise. Also, don't let anchors match
300 newline; this fixes an incompatibility with tradition and with POSIX.
301 Don't warn about leading ^. POSIX says it is unspecified whether
302 ^ is a special character, which means that implementations can
303 either treat it as special or not, but either way a warning is not
304 allowed (unless the regexp is otherwise invalid). Instead, anchor
305 the expression but treat ^ as an anchor; this is the traditional
306 behavior (e.g., Solaris 10).
307 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
308 and the like as invalid expressions (exit status 2), not as
309 failure of 'expr' (exit status 3). This is more consistent with
311 * tests/expr/basic (fail-a): Adjust exit status to match new expr
312 behavior, for status 2 versus 3.
314 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
315 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
316 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
317 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
318 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
319 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
320 (bre61, bre62): New tests.
321 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
325 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
326 "if !". Do not assume that 'sed' can handle long, newline-free input.
327 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
329 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
331 Adjust to new regex.h API (with new fastmap type), and clean
332 up the regex storage allocation a bit.
334 * src/csplit.c (struct control): Put re_compiled member at the
335 end, since it's large. Change regexpr member from char * to bool;
336 all uses changed. Add new member fastmap.
337 (extract_regexp): regexp arg is now char const *, not char *.
338 Don't bother duplicating the regular expression; it's not needed.
339 Set fastmap from new fastmap member. Don't bother allocating
340 a buffer, as the regexp code does a better job than we do.
341 * src/expr.c (docolon): Allocate and use a fastmap.
342 Don't bother allocating a buffer.
343 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
345 (build_type_arg): New fastmap arg. All uses changed.
346 Don't bother allocating a buffer, but set a fastmap.
347 * src/ptx.c (context_regex_string, word_regex_string): Remove.
348 (context_regex, word_regex): New vars, replacing the above.
350 (struct regex_data): New type.
351 (compile_regex): Renamed from alloc_and_compile_regex, since
352 we no longer allocate storage. Arg is now a struct regex_data *,
353 not a const char *. All uses changed. Don't allocate the fastmap;
354 instead, take it from the caller. Don't convert size_t to int,
355 to avoid arithmetic overflow problems. Don't bother freeing
356 storage afterwards; it's not worth the aggravation.
357 * src/tac.c (compiled_separator_fastmap): New ver.
358 (main): Use it. Don't bother allocating a buffer.
360 2006-03-30 Jim Meyering <jim@meyering.net>
362 * src/dd.c (iwrite): Remove assignment without effect.
363 Reported by Felix Rauch Valenti.
365 2006-03-22 Eric Blake <ebb9@byu.net>
367 * src/ptx.c (usage): Remove mention of --copyright/-C.
368 (main): Alias --copyright to --version plus a deprecation warning.
369 * NEWS: Mention this.
371 2006-03-27 Jim Meyering <jim@meyering.net>
373 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
374 use of strtod. Tiny patch from Nickolai Zeldovich.
376 2006-03-11 Eric Blake <ebb9@byu.net>
378 * tests/misc/dirname: New file.
379 * tests/basename/Makefile.am: Delete.
380 * tests/basename/basic: Move to...
381 * tests/misc/basename: ... this new file. Add some tests,
382 including fixed behavior for //.
383 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
384 * tests/Makefile.am (SUBDIRS): Remove basename.
385 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
387 Improvements to dirname/basename handling on platforms like
388 cygwin with distinct // and with drive letters.
389 * NEWS: Document new behavior.
390 * src/basename.c (main): Don't strip suffix from file system
392 * src/cp.c (target_directory_operand): Use new last_component.
393 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
394 traversing the string.
395 * src/dircolors.c (guess_shell_syntax): Use new last_component.
396 * src/install.c (target_directory_operand, install_file_in_dir):
398 * src/ln.c (target_directory_operand, main): Likewise.
399 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
400 * src/mv.c (target_directory_operand, movefile): Likewise.
401 * src/remove.c (rm_1): Likewise.
402 * src/shred.c (wipename): Likewise.
403 * src/split.c (next_file_name): Likewise.
404 * src/su.c (log_su, run_shell): Likewise.
406 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
408 * NEWS: nohup diagnostics are now more precise, and nohup now
409 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
410 * src/nohup.c (main): Implement this.
411 * tests/misc/nohup: Test the new behavior.
413 2006-03-12 Jim Meyering <jim@meyering.net>
415 * src/copy.c (set_author): Rename function, from preserve_author.
417 * src/remove.c (AD_pop_and_chdir): Use new macro,
418 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
420 * src/system.h (SAME_INODE): Remove definition.
421 Include "same-inode.h", instead.
423 2006-03-11 Eric Blake <ebb9@byu.net>
425 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
427 2006-03-10 Jim Meyering <jim@meyering.net>
429 Fix a bug whereby a user with write access to a directory being removed
430 could cause the removal of that directory to fail with an erroneous
431 diagnostic about a directory cycle. Reported by Vineet Chadha.
433 * NEWS: Mention this.
434 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
435 leave (and try to rmdir) is the one whose dev_ino is being used to
436 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
438 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
440 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
441 * src/dd.c (set_fd_flags): Handle file-creation flags on file
442 descriptors, rather than ignoring them.
443 * tests/dd/misc: Add test cases for append, nofollow, directory,
444 and nolinks flags. Simplify redirection to /dev/null in some cases.
446 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
447 noatime test never tested anything.
449 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
451 * src/dd.c (flags, usage): New flags directory, nolinks.
452 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
454 * src/ls.c (usage): Mention that -f disables --color.
455 Problem reported by Niels Möller.
457 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
459 * man/*.x: Add references to syscalls from utilities of the same name.
461 2006-03-05 Jim Meyering <jim@meyering.net>
463 * tests/help-version: Set SHELL, if not already set, in order to
464 avoid failure when `make check' is run through debuild; dircolors
465 would fail due to lack of $SHELL. Reported by Sven Joachim.
467 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
468 * src/base64.c (wrap_write, do_encode, main): Change type of
469 parameters and locals, wrap_column, form size_t to uintmax_t.
470 (main): Adjust to use xstrtoumax, accordingly.
472 2006-03-03 Jim Meyering <jim@meyering.net>
474 Don't fail when run from an environment with SHELL not a Bourne
475 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
476 * tests/dircolors/simple: Invoke each non-failing test with -b.
477 Reported by Michael Stone.
479 2006-02-27 Jim Meyering <jim@meyering.net>
481 * tests/misc/base64: Derive --decode-using tests from the
484 * tests/misc/base64: Factor out a long constant string.
485 Split lines to stay within 80 columns.
487 * tests/misc/Makefile.am (TESTS): Add base64.
488 * tests/misc/base64: Test base64. From Simon Josefsson.
490 * src/base64.c (do_decode): Use correct type for parameter,
491 ignore_garbage: s/size_t/bool/.
493 * src/base64.c: Don't include .h files already included by system.h:
494 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
495 Include "system.h" before the other lib/*.h header files.
496 Include <sys/types.h> before "system.h".
497 (wrap_write): Remove declaration of unused local, initial_column.
498 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
500 * README: Add base64 to the list.
502 2006-02-17 Simon Josefsson <jas@extundo.com>
505 * AUTHORS: Mention base64.
507 * man/Makefile.am: Build base64.1.
508 * man/base64.x: New file.
509 * src/Makefile.am (bin_PROGRAMS): Add base64.
510 * src/base64.c: New file.
512 2006-02-25 Eric Blake <ebb9@byu.net>
514 In ls, avoid calling stat for --inode (-i), when possible.
515 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
516 * src/system.h: ... here, for use in ...
517 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
519 (gobble_file): Add inode argument.
520 (print_dir): Pass inode if available.
521 (usage): Remove inaccuracy.
523 2006-02-23 Jim Meyering <jim@meyering.net>
525 * TODO: Update/correct some obsolete entries.
527 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
529 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
530 * src/join.c (usage): Likewise.
531 Documentation problem reported by Philip Kensche.
533 2006-02-20 Eric Blake <ebb9@byu.net>
535 * man/rm.x: Update documentation to match previous patch.
537 2006-02-18 Eric Blake <ebb9@byu.net>
539 New option for rm: --interactive=once (-I).
540 * NEWS: Document it, along with change to rm --interactive.
541 * TODO: Remove entry for implementing rm -I
542 * src/rm.c (INTERACTIVE_OPTION): New enum value.
543 (interactive_type): New enum.
544 (long_opts): Let interactive take an optional argument.
545 (interactive_args, interactive_types): New option arguments.
546 (usage): Document -I, --interactive=WHEN. Use program_name
547 instead of a basename.
548 (main): New -I option, new behavior to --interactive.
549 * tests/rm/interactive-once: New tests.
550 * tests/rm/interactive-always: Ditto.
551 * tests/rm/Makefile.am (TESTS): Run them.
553 2006-02-18 Jim Meyering <jim@meyering.net>
555 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
556 expression match more of the target lines, e.g., those that start with
557 `-S,' (short option followed by a comma) or that include `=[...]'.
558 Patch by Nicolas François.
559 Fix the four offenders thus exposed:
560 * src/join.c (usage): Use two spaces (not one) to separate the
561 --first-only option string from its description, so help2man formats
562 the derived man page properly.
563 * src/pr.c (usage): Likewise.
564 * src/uniq.c (usage): Likewise.
565 * src/install.c (usage): Likewise.
567 2006-02-15 Jim Meyering <jim@meyering.net>
569 * Makefile.maint (alpha beta major): For `make major', ensure that the
570 version string is of the form N.N[.N]*, where N is one or more digits.
572 2006-02-14 Jim Meyering <jim@meyering.net>
574 * INSTALL: Update from gnulib.
576 2006-02-13 Jim Meyering <jim@meyering.net>
578 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
580 2006-02-12 Jim Meyering <jim@meyering.net>
582 * Makefile.maint (patch-check): New target.
583 (local-checks-available): Add to the list.
585 2006-02-11 Jim Meyering <jim@meyering.net>
587 * src/c99-to-c89.diff: New file.
588 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
590 * .x-po-check: New file, with exclusions so that `make distcheck'
592 * Makefile.am (EXTRA_DIST): Add .x-po-check.
594 rm -r must remove an empty directory, even if it is inaccessible.
595 * src/remove.c (close_preserve_errno): New function.
596 (fd_to_subdirp): Don't print a diagnostic in this function.
597 Do it from the callers instead, unless rmdir succeeds.
598 (remove_cwd_entries, remove_dir): Adjust callers.
599 * tests/rm/empty-inacc: New test for the above.
600 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
601 * NEWS: Mention this bug fix.
602 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
603 a tiny bit less precise: cannot remove `a/1': ... instead of
604 cannot open directory `a/1': ...
606 * Makefile.maint (syntax-check-rules): Automatically derive this
607 list of sc_-prefixed rule names.
609 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
611 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
612 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
613 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
614 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
615 go away? was that an accident?)
616 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
617 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
618 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
619 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
620 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
621 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
622 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
623 (author_mark_check, makefile_path_separator_check):
624 Output line numbers, to simplify navigation of Emacs *compilation*
626 (sc_prohibit_atoi_atof, sc_file_system):
627 Rework slightly so that Makefile.maint doesn't get reported as a
628 violation of its own syntax rules.
629 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
630 it at run-time (which didn't work with Bison). Fix a makefile typo,
631 caught by Makefile.maint itself: spaces where a tab should be.
632 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
633 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
634 Ignore djgpp and man subdirectories, to avoid false matches with
635 Bison and coreutils, respectively. Use sort -u to remove the
636 resulting duplicates.
637 * gnupload: Rework slightly to avoid bogus warning from
638 sc_two_space_separator_in_usage.
640 2006-02-10 Jim Meyering <jim@meyering.net>
642 Use gzip's --rsyncable option only if it's available.
643 * Makefile.maint (gzip_rsyncable): New variable.
646 2006-02-08 Jim Meyering <jim@meyering.net>
648 * Makefile.maint (local-checks-available): Define in terms of
649 the expansion, $(syntax-check-rules), rather than the single,
650 top-level target `syntax-check', so that it's easier to exclude
651 individual rules (via $(local-checks-to-skip)).
652 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
654 2006-02-07 Jim Meyering <jim@meyering.net>
656 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
657 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
659 * tests/help-version (expected_failure_status_vdir):
660 Redirect an expected disk-full diagnostic to /dev/null.
662 2006-02-06 Jim Meyering <jim@meyering.net>
664 * src/unexpand.c (usage): Use two spaces (not one) to separate the
665 --first-only option string from its description, so help2man formats
666 the derived man page properly.
667 * src/rm.c (usage): Likewise for --no-preserve-root.
668 * src/chown.c (usage): Likewise.
669 * src/chgrp.c (usage): Likewise.
671 Add a rule to ensure that the above doesn't happen again.
672 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
673 (syntax-check-rules): Add it.
674 * .x-sc_two_space_separator_in_usage: New empty file.
675 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
677 2006-02-06 Jim Meyering <jim@meyering.net>
679 * src/cp.c (usage): Use two spaces (not one) to separate each
680 option string from its description, so help2man formats the
681 derived man page properly.
682 * src/mv.c (usage): Likewise.
683 Patch from Nicolas François in http://bugs.debian.org/351601.
685 2006-02-04 Jim Meyering <jim@meyering.net>
687 * src/copy.c (copy_internal): cp -RL would fail when encountering
688 the same directory more than once in the hierarchy beneath a single
689 command-line argument. That is legitimate, e.g. when there are
690 two or more symbolic links, each pointing to some directory that
691 would not otherwise be copied. Reported by Christophe LYON.
692 * tests/cp/cp-deref: New file. Test for today's fix.
693 * tests/cp/Makefile.am (TESTS): Add cp-deref.
694 * NEWS: Document this.
696 2006-02-03 Jim Meyering <jim@meyering.net>
698 * configure.ac: Require automake-1.9.6, not 1.8.3.
700 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
702 * src/od.c (usage): Mention that -t a ignores high order bit.
703 Documentation problem reported by Ed Avis.
705 2006-02-01 Jim Meyering <jim@meyering.net>
707 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
709 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
711 * src/head.c (main): Use a better diagnostic when someone uses a
712 trailing numeric option in an invalid way. Problem reported by
714 * src/tail.c (parse_options): Likewise.
716 2006-01-30 Jim Meyering <jim@meyering.net>
718 * man/wc.x: Include `count' keyword in man page synopsis,
719 per suggestion from http://bugs.debian.org/181585.
721 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
723 * src/df.c (show_dev): If the file system claims to have
724 more available than total blocks, report the number of used
725 blocks as being total - available (a negative number) rather
726 than as garbage. Problem reported by Toralf Foerster.
728 2006-01-24 Jim Meyering <jim@meyering.net>
730 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
731 to put a regular file in O_NONBLOCK mode fails with EPERM.
732 That happens on Linux (up to 2.6.15) when using tail -f on a file with
733 the append-only attribute. Reported by Dean Gaudet. For details,
734 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
735 * NEWS: Mention this fix.
736 * tests/tail-2/append-only: New file. Test for the above.
737 * tests/tail-2/Makefile.am (TESTS): Add append-only.
738 * tests/Makefile.am (check-root): Add tail-2/append-only
740 2006-01-21 Jim Meyering <jim@meyering.net>
742 * NEWS: Mention fts-related improvements and bug fixes.
744 2006-01-19 Jim Meyering <jim@meyering.net>
746 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
747 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
749 2006-01-18 Jim Meyering <jim@meyering.net>
751 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
753 2006-01-17 Jim Meyering <jim@meyering.net>
755 Now that fts no longer changes the current working directory, adjust
756 its clients accordingly -- note that du.c uses fts but doesn't need
757 any adjustment, since it doesn't operate on the actual files,
758 but rather just uses the stat buffers provided by fts.
760 * src/chown-core.c: Include "openat.h".
761 Don't include "lchown.h".
762 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
763 calling openat, lchownat, chownat, rather than open, lchown, chown.
765 * src/chmod.c: Include "openat.h".
766 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
768 * tests/du/long-from-unreadable: New test, to exercise one small
771 2006-01-13 Jim Meyering <jim@meyering.net>
773 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
774 addition of new directories under tests/.
776 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
779 2006-01-12 Jim Meyering <jim@meyering.net>
781 * tests/du/long-sloop: Adjust not to hard-code the expected
782 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
783 from that of GNU libc. Reported by Paul Eggert.
785 * tests/du/long-sloop: Create file at end of symlink chain.
787 * tests/misc/test: New file, with a test for one of the
788 bugs fixed by yesterday's test.c changes.
789 * tests/misc/Makefile.am (TESTS): Add test.
791 2006-01-11 Jim Meyering <jim@meyering.net>
793 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
794 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
795 a very long sequence of symbolic links (not necessarily a loop).
796 * tests/du/Makefile.am (TESTS): Add long-sloop.
798 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
800 * src/test.c (test_syntax_error): Append a newline. All callers
801 changed, except for the ones that didn't already append a newline.
802 Bug reported by Eric Blake.
804 2006-01-11 Jim Meyering <jim@meyering.net>
806 * src/system.h (X2NREALLOC): Now that verify_true is no longer
807 void, cast its result to void, to avoid gcc's warning that
808 ``left-hand operand of comma expression has no effect''.
809 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
811 2006-01-10 Jim Meyering <jim@meyering.net>
813 * tests/chmod/no-x: Add a test for today's fts.c fix.
815 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
817 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
818 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
820 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
822 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
823 Use verify_true instead of verify_expr, to sync with gnulib.
825 2006-01-08 Jim Meyering <jim@meyering.net>
827 * src/date.c (usage): Adjust the formatting of the entries for
828 %::z and %:::z (separate with two spaces, not one) so that help2man
829 formats them properly. Reported by Philip Rowlands.
831 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
833 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
835 2006-01-06 Jim Meyering <jim@meyering.net>
837 * Makefile.maint (copyright-check): Use date +%Y in place of
840 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
841 First off, the attribute should have been `volatile' (not static)
842 to avoid longjmp-related risk of clobber. Secondly, now there is
843 no longer any risk of a local variable being clobbered, so there's
844 no need for any attribute at all.
846 2006-01-05 Jim Meyering <jim@meyering.net>
848 * src/remove.c: Give a few functions the inline attribute.
849 (AD_pop_and_chdir): Use gotos to avoid some duplication.
850 (AD_push): Rewrite an assertion so that the entire computation
851 goes away when assertions are turned off.
853 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
854 It's already defined in "system.h".
855 * Makefile.maint: Add a FIXME comment.
857 2006-01-04 Jim Meyering <jim@meyering.net>
859 * ChangeLog: Remove entries from 2005-10-22 and earlier.
860 * ChangeLog-2005: New file, for entries up to version 5.92.
862 2006-01-03 Jim Meyering <jim@meyering.net>
864 * tests/du/no-x: Also allow a slightly different diagnostic -- the
865 one you get when using openat-enabled fts.c and du (coming soon).
866 * tests/chmod/no-x: Likewise.
867 * tests/chgrp/no-x: Likewise.
869 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
871 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
873 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
874 (restricted_chown): Return it, if the file cannot be accessed due
875 to EPERM, or if no uid or gid are required, or if the file is
876 neither a directory nor a regular file. Rewrite to avoid gotos.
877 (change_file_owner): Handle RC_do_ordinary_chown case.
878 Rewrite to avoid gotos.
879 * tests/chgrp/basic: Make sure we can change the group of
882 * src/date.c (usage): Explain %g, %G, and %V a bit better.
884 2006-01-02 Jim Meyering <jim@meyering.net>
886 * src/copy.c (set_owner): Correct a comment.
888 * src/tail.c (parse_options): Change warning to say that --retry
889 is useful `mainly' (not `only') when following by name.
890 Reported here: http://bugs.debian.org/273781
892 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
894 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
895 * src/copy.c: Include lchmod.h.
896 (copy_internal): Use lchmod rather than chmod.
897 * src/cp.c: Include lchmod.h.
898 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
899 * src/mkdir.c: Include lchmod.h.
900 (usage): Clarify -m's operation.
901 (main): Use lchmod rather than chmod. Don't use lchmod unless the
902 new mode contains bits outside the 777 range.
903 * src/mkfifo.c (usage): Clarify -m's operation.
904 (main): If -m is given, don't invoke chmod; use umask 0 instead.
905 Report an error if -m asks for bits outside the 777 range.
906 * src/mknod.c (usage, main): Likewise.
908 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
910 2005-12-27 Jim Meyering <jim@meyering.net>
912 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
913 (sc_prohibit_assert_without_use): New rule.
914 (syntax-check-rules): Add it to the list.
915 * .x-sc_prohibit_assert_without_use: New empty file.
916 * Makefile.am (EXTRA_DIST): Add it.
918 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
920 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
921 Don't include <assert.h>; it wasn't used.
923 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
925 * src/chown-core.c (restricted_chown):
926 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
927 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
928 | O_NOFOLLOW too, for consistency with other dir-openers.
929 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
930 (is_empty_dir): Likewise.
931 * src/shred.c (wipename): Likewise. Don't bother trying to open
932 dir for writing, since POSIX prohibits it.
934 2005-12-22 Jim Meyering <jim@meyering.net>
936 * tests/help-version: Redirect stderr to /dev/full, to suppress
937 write error diagnostic.
939 2005-12-19 Jim Meyering <jim@meyering.net>
941 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
942 Avoid a minor race condition when `-m MODE' is specified, by using
943 open, fchown, and close rather than just chown. To do that reliably --
944 even with an overly restrictive umask -- ensure that each mkdir,
945 mknod and mkfifo call uses a mode including at least owner-read access.
946 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
947 the subsequent chown (or equivalent open,fchown,close) fails.
948 * tests/misc/mknod: New tests.
949 * tests/misc/Makefile.am (TESTS): Add mknod.
951 2005-12-17 Jim Meyering <jim@meyering.net>
953 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
954 e.g., on a named pipe.
955 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
956 place of all uses, since it is guaranteed (system.h) to be defined.
958 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
960 Add POSIX ACL support
961 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
962 is no requirement for ACL support; particularly, it does not exist
963 on systems that have POSIX ACLs.
964 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
965 * src/cp.c (umask_kill): With default acls, the umask is not to be
966 applied. Remove umask_kill, don't change the process umask, and let
967 the kernel apply the umask where appropriate.
968 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
969 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
971 (copy_reg, copy_internal): Use copy_acl and set_acl
972 instead of fchown/chown. Fix the logic for POSIX ACLs.
973 (chown_succeded): Remove; we now always copy acls and
974 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
975 did a chown before or not.
976 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
977 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
978 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
979 to link with it via $(LIB_ACL), for the utilities that need it.
981 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
983 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
984 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
985 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
986 value is now signified by whether cwd_errno is null.
987 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
988 pointer-to-bool to pointer-to-errno-value. All callers changed.
989 (rm_1): Don't bother setting a local cwd failure flag and then
990 ORing it into the caller's. Just set the caller's.
991 (rm): Use cwd failure errno value to print a slightly-better
994 2005-12-15 Jim Meyering <jim@meyering.net>
996 * src/stat.c (print_it): Properly handle a backslash at the
997 end of a --printf format string. Reported by Paul Eggert.
998 * tests/misc/stat-printf (end-bs): Add a test for the above.
1000 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1002 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1003 Don't assume /etc/passwd contains user names; use 'id' instead.
1005 2005-12-15 Jim Meyering <jim@meyering.net>
1007 stat: revert behavior of --format=FMT (-c)
1008 stat: add new option: --printf=FMT
1009 * NEWS: Mention this.
1010 * src/stat.c (isodigit, octtobin, hextobin): Define.
1011 (PRINTF_OPTION): Define.
1012 (interpret_backslash_escapes, trailing_delim): New globals.
1013 (usage): Document them. Alphabetize on long option names.
1014 (print_esc_char): New function.
1015 (print_it): Rewrite, in order to handle backslash escapes.
1016 (main): Handle new option. Set globals for --format, too.
1018 * tests/misc/stat-printf: Test --printf and --format.
1019 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1021 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1023 * NEWS: sort now reports incompatible options.
1024 * src/sort.c (incompatible_options, check_ordering_compatibility):
1026 (main): Use them. Don't bother with a usage message for
1027 "sort -c a b", for consistency with other error diagnostics.
1028 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1031 * src/cat.c (main): Undo previous change. close_stdout already
1032 does the check, so the previous change wasn't necessary.
1034 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1036 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1038 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1040 Install a more-conservative approach for sort -R. It's the
1041 same basic idea as the existing code, except it uses the full ISAAC
1042 approach (called the "more kosher" approach in the existing comments).
1043 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1044 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1045 better to be conservative here at first, and review any performance
1046 improvements carefully.
1047 * .x-sc_require_config_h: Add src/rand-isaac.c.
1048 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1049 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1050 (shred_SOURCES, sort_SOURCES): Remove.
1051 (EXTRA_DIST): Add rand-isaac.c.
1052 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1053 changing it to allow for varying numbers of words in the state.
1054 Alter so that we include rand-isaac.c directly rather than
1055 compiling it and linking to it. Don't include config.h or
1056 system.h; that's the includer's responsibility.
1057 Omit functions that are specific to shred.
1058 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1059 (isaac_step, struct irand_state):
1060 Resurrect these, with the same defns that used to be in shred.c.
1061 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1062 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1064 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1065 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1066 (irand_init, irand32, irand_mod):
1067 Number of words is constant again.
1068 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1069 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1070 * src/sort.c: Likewise.
1071 * src/shred.c (fillrand, dopass, main): Undo previous change.
1072 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1074 * src/sort.c: Don't include md5.h; it wasn't needed.
1075 (struct keyfield): Rename random_hash to random, for consistency
1076 with the other member names. All uses changed.
1077 (usage): Tweak wording to mention STRING for --seed option.
1078 (short_options): Rorder for consistency with other programs.
1079 (rand_state): Now a struct, not a pointer to one. All uses changed.
1080 (HASH_WORDS, HASH_SIZE): Remove.
1081 (get_hash): Remove comments around resbuf size, since we can assume C89.
1082 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1083 (keycompare): Adjust to the new get_hash.
1085 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1086 (main): Don't set need_random simply because gkey has it set; that
1087 doesn't necessarily mean we'll need random numbers.
1088 Redo seeding to match new get_hash approach.
1090 2005-12-10 Jim Meyering <jim@meyering.net>
1092 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1094 Avoid shred segfault on 64-bit systems.
1095 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1096 local of type uint32_t. Make the local an `int' instead.
1098 * NEWS: Mention sort's new options.
1100 * src/rand-isaac.c (isaac_mix): Declare to be static.
1101 Mark all other functions as `extern' so the tight-scope
1102 part of `make distcheck' passes once again.
1103 * src/rand-isaac.h (isaac_mix): Remove declaration.
1105 * src/sort.c (get_hash): Change position of `*' in parameter
1106 type to conform with convention.
1107 (main): Split a long line so it fits in 80 columns.
1108 (keycompare): Remove stray SPACE before TAB that was
1109 causing `make distcheck' to fail.
1111 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1113 * tests/misc/sort-rand: New file: basic tests for the new options.
1114 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1116 2005-12-10 Frederik Eaton <frederik@ofb.net>
1118 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1119 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1120 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1121 Make state size runtime-configurable.
1122 (isaac_new, isaac_copy): New functions.
1123 * src/rand-isaac.h: New file.
1124 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1125 (fillrand, main): Adjust to the fact that the state size is now
1126 runtime-configurable.
1127 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1128 (usage): Add options --random-sort and --seed to implement a random
1130 Include md5.h and rand-isaac.h.
1131 (get_hash): New function.
1132 (rand_state): New var.
1133 (HASH_WORDS, HASH_SIZE): New macros.
1135 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1137 * tests/dd/misc: Add test for dd iflags=noatime.
1139 2005-12-09 Jim Meyering <jim@meyering.net>
1141 * src/sort.c (usage): Mention white space vs -b and -t options.
1144 2005-12-09 Eric Blake <ebb9@byu.net>
1146 * src/test.c (main): Fix misleading comment.
1148 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1150 * NEWS: Mention dd's new noatime flag.
1151 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1152 * src/dd.c (flags, usage): Add support for noatime flag.
1154 2005-12-07 Jim Meyering <jim@meyering.net>
1156 Distribute the cvsu script, used only by `make syntax-check'.
1157 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1158 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1159 distribute a copy of this script.
1160 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1162 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1163 to create a temporary directory on another partition.
1164 From Andreas Gruenbacher.
1166 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1168 * man/basename.x: Cross-reference to dirname and readlink.
1169 * man/dirname.x: Cross-reference to basename and readlink.
1171 2005-12-05 Andreas Gruenbacher
1173 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1174 (set_owner, preserve_author): New functions, factored out of copy_reg.
1175 (copy_reg): Use them.
1176 (copy_internal): Use them here, too.
1178 2005-12-04 Jim Meyering <jim@meyering.net>
1180 * src/sleep.c (usage): Say what happens with two or more arguments.
1181 Suggested by Justin Pryzby.
1183 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1186 2005-12-03 Jim Meyering <jim@meyering.net>
1188 * src/rm.c (long_opts): Change the name of each undocumented, for-
1189 testing-only option to start with `-', so that it cannot render
1190 ambiguous any prefix it happens to share with some other option name.
1191 Problem reported by Eric Blake.
1192 * src/head.c (long_options): Likewise.
1193 * src/tail.c (long_options): Likewise.
1195 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1196 testing-only --presume* options to start with `---'.
1197 * tests/rm/dangling-symlink: Likewise.
1198 * tests/rm/dir-no-w: Likewise.
1199 * tests/rm/isatty: Likewise.
1201 2005-11-30 Jim Meyering <jim@meyering.net>
1203 * Makefile.maint: Add a comment about cvsu.
1205 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1207 * NEWS: df updates for "none", "proc", inaccessible file systems.
1208 * src/df.c (show_point): Ignore inaccessible file systems.
1209 (usage): -a includes dummy file systems, not size-0 file systems.
1211 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1212 to avoid collision with POSIX name space. All uses changed.
1214 2005-11-24 Jim Meyering <jim@meyering.net>
1216 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1217 * tests/acl: Add `$0: ' prefix to diagnostics.
1219 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1221 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1223 * src/copy.c: Improve performance a bit by optimizing away
1224 unnecessary system calls and going to a block size of at least
1225 8192 (on normal hosts, anyway). This improved performance 5% on my
1226 Debian stable host (2.4.27 kernel, x86, copying from root
1227 ext3 file system to itself).
1228 Include "buffer-lcm.h".
1229 (copy_reg): Omit last argument. All callers changed.
1230 Use xmalloc to allocate rather than trusting alloca
1231 (which is unwise with large block sizes).
1232 Declare locals more locally, if possible.
1233 Use uintptr_t words instead of int words, for a bit more speed
1234 when looking for null blocks on 64-bit hosts.
1235 Optimize away reads of zero bytes on regular files.
1236 In the typical case, insist on 8 KiB buffers, at least.
1237 Avoid unnecessary extra call to fstat when checking for sparse files.
1238 Avoid now-unnecessary cast to off_t, and "0L".
1239 Avoid unnecessary test of *new_dst when checking for same owner
1242 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1244 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1246 2005-11-22 Jim Meyering <jim@meyering.net>
1248 * src/remove.c (AD_push): Remove debugging cruft.
1250 * tests/rm/unread2 (rm): Change expected diagnostic,
1251 `cannot open directory' to `cannot remove', to align with
1253 * tests/rm/rm2: Ensure that rm now continues removing entries
1254 even after certain types of failure.
1256 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1257 that provide openat (Solaris), and on systems like Linux+procfs
1258 where our openat emulation code is reentrant. This also fixes a
1259 few low-probability leaks and eliminates some code that could,
1260 in very unusual circumstances, cause rm() (via a callee) to exit.
1261 * NEWS: Mention this.
1263 * configure.ac: Put copyright dates all on one line so the
1264 emacs function that updates them works properly.
1266 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1268 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1269 Problem reported by Eric Blake.
1270 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1271 we get a standard-conforming compiler. This relies on the new
1272 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1273 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1274 m4/c.m4 can go away with Autoconf 2.60 comes out.
1276 2005-11-17 Jim Meyering <jim@meyering.net>
1278 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1279 (AD_mark_current_as_unremovable): Likewise, but for a local.
1282 * tests/mv/acl: Let traps handle removing temporary directories.
1284 Expect acl-related tests to fail, until the corresponding
1285 patches are committed.
1286 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1287 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1289 ACL tests, from Andreas Gruenbacher.
1290 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1291 * tests/mv/Makefile.am (TESTS): Add acl.
1292 * tests/cp/Makefile.am (TESTS): Add acl.
1294 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1296 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1298 * NEWS: Improve quality of ln's diagnostics.
1299 * src/ln.c (do_link, usage): Likewise.
1300 (do_link): Don't use alloca on a buffer of unbounded size.
1302 2005-11-16 Jim Meyering <jim@meyering.net>
1304 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1305 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1306 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1307 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1308 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1310 2005-11-14 Jim Meyering <jim@meyering.net>
1312 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1314 2005-11-13 Jim Meyering <jim@meyering.net>
1316 * announce-gen: Accept new option, --gpg-key-id=ID and
1317 emit a blurb telling how to use the .sig files.
1318 * Makefile.cfg (gpg_key_ID): Define.
1319 * Makefile.maint (announcement): Use new option and key.
1321 Require that most .c files include <config.h>.
1322 * Makefile.maint (sc_require_config_h): New rule.
1323 (syntax-check-rules): Add it.
1324 * .x-sc_require_config_h: New file listing exceptions to the
1325 above rule. Some are legit, others are simply grandfathered in.
1326 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1328 2005-11-12 Jim Meyering <jim@meyering.net>
1330 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1332 2005-11-11 Jim Meyering <jim@meyering.net>
1334 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1335 Mention new readlink options in 5.3.0's `New features' section.
1336 Spotted by Thomas Hood.
1338 2005-11-08 Jim Meyering <jim@meyering.net>
1340 * NEWS: Merge in changes from b5_9x branch.
1342 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1344 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1345 like --time-style='posix-long-iso' if the locale settings are messed up.
1346 * src/ls.c (decode_switches): Implement this.
1348 2005-11-08 Jim Meyering <jim@meyering.net>
1350 * tests/du/2g: s/expensive/very expensive/ in a comment.
1353 2005-10-17 Eric Blake <ebb9@byu.net>
1355 * src/ls.c (usage): Fix descriptions of --sort, --time.
1356 Reported by Vitaly A. Ostanin.
1358 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1360 * src/ln.c: Include filenamecat.c.
1361 (FILE_BASENAME_CONCAT): Remove.
1362 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1363 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1364 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1367 2005-11-04 Jim Meyering <jim@meyering.net>
1369 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1370 on systems with stat.st_blocks of a signed 32-bit type.
1371 This bug causes trouble on some AIX 5.1 systems.
1372 Report and trivial patch from Paul Townsend:
1373 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1374 * NEWS: Mention this.
1376 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1377 * tests/du/Makefile.am (TESTS): Add it here.
1378 * tests/very-expensive: New file.
1379 * tests/Makefile.am (EXTRA_DIST): Add it here.
1380 * tests/cp/perm: Mark this test as `very-expensive', too.
1382 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1384 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1386 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1388 * src/rm.c (usage): Don't mention rm -d.
1390 2005-11-02 Jim Meyering <jim@meyering.net>
1392 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1393 From Andreas Schwab.
1395 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1396 `M+N records in/out' lines don't pollute `make check' output.
1398 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1399 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1400 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1401 to indicate that the input file should be piped into the command
1402 under test (via `cat FILE | $prog ...').
1404 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1405 (without -r) fails to remove a directory on a non-Linux system.
1406 This change affects only newer Solaris systems (with priv_*
1407 functions like priv_allocset). Reported by Keith Thompson.
1409 * tests/rm/dir-nonrecur: New file/test for the above fix.
1410 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1412 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1414 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1415 POSIX 1002.1-2001 requires.
1416 * src/tail.c (parse_obsolete_option): Implement this.
1417 Problem reported by Vincent Lefevre.
1418 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1419 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1420 (test_vector): Add special cases for _POSIX2_VERSION, and
1421 regularize the old ones a bit.
1422 * tests/touch/obsolescent: Add y2000 test.
1424 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1426 * src/dd.c (skip): Fix off-by-one error reported by
1427 Theodoros V. Kalamatianos.
1429 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1431 * tests/mkdir/p-3: Require that the test be run as non-root.
1432 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1434 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1436 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1437 boundary between DEST and SOURCE in the result.
1439 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1441 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1442 back to text, to sync with documentation and for backwards
1445 2005-10-25 Jim Meyering <jim@meyering.net>
1447 * tests/dircolors/simple (other-wr): Add an explicit test for
1448 the dircolors bug (NULL-dereference) fixed yesterday.
1450 2005-10-24 Jim Meyering <jim@meyering.net>
1452 * src/tac.c (tac_file): When determining whether a file is seekable,
1453 also test whether it is a tty. Using only the lseek-based test would
1454 give a false positive on Solaris. Reported by Peter Fales.
1456 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1458 * tests/install/d-slashdot: New test, for "install -d" failure.
1459 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1460 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1461 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1463 2005-10-24 Jim Meyering <jim@meyering.net>
1465 * src/dircolors.c (ls_codes): Add missing comma.
1466 Anonymous report and patch from
1467 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1469 * src/dircolors.c: Add compile-time assertion that the slack_codes
1470 and ls_codes arrays have the same number of elements. This would
1471 have prevented the above-fixed bug.
1473 * src/expand.c (parse_tab_stops): Add a comment to make this function
1474 identical to the one in unexpand.c.
1475 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1476 identical to the one in expand.c.
1478 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1480 2005-10-23 Jim Meyering <jim@meyering.net>
1482 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1483 a dangerous pointer-value-to-`unsigned' cast.
1484 * NEWS: mention the new sha* programs.
1485 * AUTHORS: Add new sha* programs.
1487 2005-08-28 David Madore <david.madore@ens.fr>
1489 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1490 * README: Add their names to the list.
1491 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1492 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1493 Rules for compiling sha-2 utilities
1494 (noinst_HEADERS): Remove checksum.h.
1495 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1497 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1498 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1499 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1500 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1501 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1502 sha384sum, sha512sum test scripts here rather that each in its
1505 2005-08-28 David Madore <david.madore@ens.fr>
1507 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1508 of the FIPS test vectors).
1510 2005-10-23 Jim Meyering <jim@meyering.net>
1512 * configure.ac: Use 6.0-cvs as the version string.
1513 * NEWS: Adjust accordingly.