1 2003-09-28 Havoc Pennington <hp@pobox.com>
5 * doc/Makefile.am (dbus-test-plan.html): accept nonexistence of
6 stylesheet-images for benefit of Debian
8 Change back to using filesystem-linked sockets for the system
9 bus, so only root can create the default system bus address.
11 * bus/system.conf.in: change to use
12 DBUS_SYSTEM_BUS_DEFAULT_ADDRESS
14 * dbus/Makefile.am (INCLUDES): remove DBUS_SYSTEM_BUS_PATH define
17 * configure.in: define DBUS_SYSTEM_BUS_DEFAULT_ADDRESS
18 here, and AC_DEFINE DBUS_SYSTEM_PATH
20 2003-08-09 Anders Carlsson <andersca@codefactory.se>
26 2003-08-09 Anders Carlsson <andersca@codefactory.se>
28 * doc/dbus-specification.sgml:
29 Add activation reply values.
31 2003-08-05 Havoc Pennington <hp@redhat.com>
35 2003-08-05 Anders Carlsson <andersca@codefactory.se>
37 * glib/dbus-gmain.c: (watch_fd_new), (watch_fd_ref),
38 (watch_fd_unref), (dbus_gsource_check), (dbus_gsource_dispatch),
39 (add_watch), (remove_watch), (create_source):
40 Refcount fds, fixes some reentrancy issues.
42 2003-07-30 Havoc Pennington <hp@redhat.com>
44 * dbus/dbus-bus.c (init_connections_unlocked): fix default system
45 bus address to be abstract if we have abstract sockets
49 2003-07-28 Havoc Pennington <hp@redhat.com>
51 * bus/messagebus.in: fix to avoid processname/servicename
52 confusion, from Michael Kearey
53 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=100965
55 2003-07-23 Havoc Pennington <hp@pobox.com>
57 * dbus/dbus-message.c (dbus_message_iter_get_named):
58 fix from Andy Hanton to remove broken "+1"
60 2003-07-16 Havoc Pennington <hp@pobox.com>
62 * tools/dbus-launch.c (babysit): close stdout/stderr in the
63 babysitter process, as suggested by Thomas Leonard, so
64 an "eval `dbus-launch --exit-with-session`" will actually
67 2003-07-16 Havoc Pennington <hp@pobox.com>
69 * configure.in: print out EXPANDED_* variables in the summary at
70 the end; clean up the code that computes EXPANDED_ variables and
71 get the ones using exec_prefix right. Should make things work
72 when you build without --prefix
74 2003-06-29 Havoc Pennington <hp@pobox.com>
76 * mono/Test.cs (class Test): fire up a main loop and run it
78 * mono/DBus.cs (DBus): don't g_thread_init since it can only be
79 done once, the app has to do it
81 2003-06-26 Havoc Pennington <hp@pobox.com>
83 * mono/Connection.cs: set up connection with the glib main loop
85 2003-07-01 Havoc Pennington <hp@redhat.com>
87 * doc/dbus-specification.sgml: clarify the format of a type code,
88 change suggested by Jim Blandy
90 2003-06-29 Miloslav Trmac <mitr@volny.cz>
93 * tools/Makefile.am: Don't assume srcdir == builddir.
95 * dbus/dbus-memory.c (dbus_realloc): Don't check guards after shrinking
97 (_dbus_memory_test): New function.
98 * dbus/dbus-test.h: Add _dbus_memory_test ().
99 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): Call it.
101 * dbus/dbus-message.c (decode_header_data): Use %.4s instead
103 (dbus_message_new): Remove obsolete @todo.
105 * dbus/dbus-marshal.c (_dbus_marshal_set_int64)
106 (_dbus_marshal_set_uint64): Fix comment.
108 * dbus/dbus-message.c (append_int_field, append_uint_field): Don't
109 hardcode FIELD_REPLY_SERIAL.
111 * dbus/dbus-mainloop.c (_dbus_loop_remove_watch)
112 (_dbus_loop_remove_timeout): Cast function pointers to (void *) for %p
114 * configure.in: Add -D_POSIX_C_SOURCE=199309L -DBSD_SOURCE to CFLAGS
115 and disable DBUS_USE_ATOMIC_INT_486 when --enable-ansi is used
117 2003-06-24 Havoc Pennington <hp@pobox.com>
119 * mono/*.cs: Use IntPtr.Zero instead of ((IntPtr) 0)
121 2003-06-23 Anders Carlsson <andersca@codefactory.se>
127 * gcj/TestMessage.java: (TestMessage), (TestMessage.main):
128 * gcj/org/.cvsignore:
129 * gcj/org/Makefile.am:
130 * gcj/org/freedesktop/.cvsignore:
131 * gcj/org/freedesktop/Makefile.am:
132 * gcj/org/freedesktop/dbus/.cvsignore:
133 * gcj/org/freedesktop/dbus/Makefile.am:
134 * gcj/org/freedesktop/dbus/Message.java: (Message),
136 * gcj/org/freedesktop/dbus/natMessage.cc:
137 Fix the build system.
139 2003-06-22 Havoc Pennington <hp@pobox.com>
141 * mono/Connection.cs: add more bindings
143 * dbus/dbus-threads.c (dbus_threads_init): allow calling this
146 2003-06-22 Havoc Pennington <hp@pobox.com>
148 * mono/Connection.cs, mono/DBus.cs, mono/Error.cs:
149 Start wrapping more stuff.
151 2003-06-22 Havoc Pennington <hp@pobox.com>
153 * mono/Message.cs: implement Message.Wrap() that ensures we only
154 have a single C# wrapper per DBusMessage, assuming it works which
157 * dbus/dbus-message.c (dbus_message_allocate_data_slot): new
158 (dbus_message_free_data_slot): new
159 (dbus_message_set_data): new
160 (dbus_message_get_data): new
162 2003-06-22 Havoc Pennington <hp@pobox.com>
164 * dbus/dbus-dataslot.c (_dbus_data_slot_allocator_unref)
165 (_dbus_data_slot_allocator_alloc): rework these to keep a
166 reference count on each slot and automatically manage a global
167 slot ID variable passed in by address
169 * bus/bus.c: convert to new dataslot API
171 * dbus/dbus-bus.c: convert to new dataslot API
173 * dbus/dbus-connection.c: convert to new dataslot API
175 * dbus/dbus-server.c: convert to new dataslot API
177 * glib/dbus-gmain.c: ditto
181 * bus/connection.c: ditto
183 2003-06-22 Anders Carlsson <andersca@codefactory.se>
185 * configure.in: Add AM_PROG_GCJ and move AM_PROG_LIBTOOL
186 after the gcj checks so that the correct configuration tags
187 will be added to libtool.
189 * dbus-glib-1.pc.in: No need to specify any includes since
190 dbus-1.pc.in has those.
192 2003-06-22 Havoc Pennington <hp@pobox.com>
194 * mono/*, gcj/*, configure.in, Makefile.am:
195 Check in makefiles and subdirs for mono and gcj bindings.
196 Neither binding actually exists, just trying to get through
197 all the build and other boring bits.
199 2003-06-21 Philip Blundell <philb@gnu.org>
201 * tools/dbus-monitor.1: Updated.
203 * tools/dbus-send.1: Likewise.
205 2003-06-20 Anders Carlsson <andersca@codefactory.se>
207 * dbus/dbus-transport-unix.c (unix_handle_watch): Check
208 for hangup and error after checking read so we won't discard
209 pending data if both hangup and read are set.
211 2003-06-19 Philip Blundell <philb@gnu.org>
213 * tools/dbus-print-message.c (print_message): Handle BOOLEAN.
215 * tools/dbus-send.c: Accept both --system and --session.
217 * tools/dbus-monitor.c: Same here.
219 2003-06-19 Anders Carlsson <andersca@codefactory.se>
221 * glib/dbus-glib.h: Fix so that dbus-glib.h can be used
222 from C++ (Patch by Miloslav Trmac).
224 2003-06-15 Joe Shaw <joe@assbarn.com>
226 * configure.in: Check for socklen_t.
228 * dbus/dbus-sysdeps.c: Define socklen_t if it's not defined.
230 * test/test-segfault.c: Add #include <sys/time.h>
232 * tools/Makefile.am: Add DBUS_X_CFLAGS to the INCLUDES since
233 dbus-launch needs it.
235 2003-06-09 Havoc Pennington <hp@redhat.com>
237 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): don't use
238 SUN_LEN, it breaks abstract socket usage
240 * dbus/dbus-internals.c (_dbus_verbose_real): only print PID at
243 2003-06-04 Havoc Pennington <hp@pobox.com>
245 * dbus/dbus-server.c (dbus_server_listen): allow abstract sockets
246 using unix:abstract=/foo, and when listening in a tmpdir
247 i.e. unix:tmpdir=/tmp, always use abstract sockets if we can.
249 * dbus/dbus-transport.c (_dbus_transport_open): support
252 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
253 support abstract sockets
255 * dbus/dbus-transport-unix.c
256 (_dbus_transport_new_for_domain_socket): support abstract sockets
258 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket): add "abstract"
259 toggle as an argument, implement abstract namespace support
260 (_dbus_listen_unix_socket): ditto
262 * configure.in: add --enable-abstract-sockets and implement
263 a configure check for autodetection of the right value.
265 2003-06-01 Havoc Pennington <hp@pobox.com>
267 * tools/dbus-cleanup-sockets.c: add utility to clean up sockets
268 in /tmp (though on Linux this will end up being useless,
269 when we add abstract namespace support)
271 * configure.in: define DBUS_SESSION_SOCKET_DIR in addition to
274 2003-05-28 Colin Walters <walters@verbum.org>
276 * tools/dbus-monitor.c (main): Fix silly typo (s/--session/--system/).
278 2003-05-18 Anders Carlsson <andersca@codefactory.se>
280 * dbus/dbus-message.c (dbus_message_new): Remove @todo.
282 2003-05-17 Colin Walters <walters@gnu.org>
284 * tools/dbus-send.c: Don't exit with an error code if --help was
285 passed. Default to using the session bus instead of the system
288 * tools/dbus-launch.c: Ditto.
290 * tools/dbus-monitor.c: Ditto.
292 * tools/dbus-send.1: Update with new arguments.
294 * tools/dbus-launch.c: Emit code to export variables. New
295 arguments -s and -c to specify shell syntax, and a bit of code to
296 autodetect syntax. Also, allow specifying a program to run.
298 * tools/dbus-launch.1: Update with new arguments.
300 * tools/dbus-send.1: Ditto.
302 * tools/dbus-monitor.1: Ditto.
304 2003-05-17 Havoc Pennington <hp@pobox.com>
306 * bus/config-parser.c (merge_included): merge in policies from
307 child configuration file.
309 * bus/policy.c (bus_policy_merge): function to merge two policies
312 2003-05-16 Havoc Pennington <hp@redhat.com>
314 * dbus/dbus-connection.c: disable verbose lock spew
316 * tools/dbus-send.c: add --print-reply command line option
318 * tools/dbus-print-message.h (print_message): new util function
319 shared by dbus-send and dbus-monitor
321 * tools/dbus-monitor.c (handler_func): exit on disconnect
323 * dbus/dbus-transport-unix.c (do_reading): if the transport is
324 disconnected, don't try to use the read_watch
326 * dbus/dbus-watch.c (dbus_watch_get_enabled): assert watch != NULL
327 so we can find this bug more easily
329 2003-05-16 Havoc Pennington <hp@redhat.com>
331 * bus/policy.c (free_rule_list_func): avoid a crash when passed
332 NULL as DBusHashTable is annoyingly likely to do.
334 2003-05-16 Colin Walters <walters@verbum.org>
336 * tools/dbus-monitor.c: Add --session argument and usage()
339 * tools/dbus-monitor.1: Update with new --session arg.
341 * bus/Makefile.am (install-data-hook): Create
342 $(libdir)/dbus-1.0/services so that the session bus is happy.
344 2003-05-15 Havoc Pennington <hp@redhat.com>
346 * dbus/dbus-sysdeps.c (_dbus_atomic_dec, _dbus_atomic_inc): work
347 on non-x86. ifdef's are evil.
349 2003-05-15 Havoc Pennington <hp@redhat.com>
355 * bus/Makefile.am (initddir): apparently we are supposed to put
356 init scripts in /etc/rc.d/init.d not /etc/init.d
358 * bus/Makefile.am: remove the "you must --enable-tests to make
359 check" as it broke distcheck
361 * bus/Makefile.am (install-data-hook): create /etc/dbus-1/system.d
363 2003-05-13 James Willcox <jwillcox@gnome.org>
366 * bus/activation.c: (bus_activation_service_created),
367 (bus_activation_activate_service):
368 * bus/driver.c: (bus_driver_send_service_deleted),
369 (bus_driver_send_service_created), (bus_driver_send_service_lost),
370 (bus_driver_send_service_acquired),
371 (bus_driver_send_welcome_message),
372 (bus_driver_handle_list_services):
373 * bus/session.conf.in:
374 * dbus/dbus-bus.c: (dbus_bus_acquire_service),
375 (dbus_bus_service_exists), (dbus_bus_activate_service):
378 Add some convenience API which lets you activate a service, and did a
379 bunch of s/0/DBUS_TYPE_INVALID/ in calls to dbus_message_append_args()
380 and dbus_message_get_args()
382 2003-05-11 Havoc Pennington <hp@pobox.com>
384 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix to avoid
385 calling _dbus_marshal_validate_arg() for every byte in a byte
388 * dbus/dbus-message-handler.c: use atomic reference counting to
389 reduce number of locks slightly; the global lock in here sucks
391 * dbus/dbus-connection.c
392 (_dbus_connection_update_dispatch_status_and_unlock): variant of
393 update_dispatch_status that can be called with lock held; then use
394 in a couple places to reduce locking/unlocking
395 (dbus_connection_send): hold the lock over the whole function
396 instead of acquiring it twice.
398 * dbus/dbus-timeout.c (_dbus_timeout_new): handle OOM
400 * bus/connection.c (bus_connections_setup_connection): fix access
401 to already-freed memory.
403 * dbus/dbus-connection.c: keep a little cache of linked list
404 nodes, to avoid using the global linked list alloc lock in the
405 normal send-message case. Instead we just use the connection lock
406 that we already have to take.
408 * dbus/dbus-list.c (_dbus_list_find_last): new function
410 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec):
411 change to use a struct for the atomic type; fix docs,
412 they return value before increment, not after increment.
414 * dbus/dbus-string.c (_dbus_string_append_4_aligned)
415 (_dbus_string_append_8_aligned): new functions to try to
416 microoptimize this operation.
417 (reallocate_for_length): break this out of set_length(), to
418 improve profile info, and also so we can consider inlining the
421 * dbus/dbus-message.c (dbus_message_new_empty_header): init data
422 strings with some preallocation, cuts down on our calls to realloc
423 a fair bit. Though if we can get the "move entire string to empty
424 string" optimization below to kick in here, it would be better.
426 * dbus/dbus-string.c (_dbus_string_move): just call
427 _dbus_string_move_len
428 (_dbus_string_move_len): add a special case for moving
429 an entire string into an empty string; we can just
430 swap the string data instead of doing any reallocs.
431 (_dbus_string_init_preallocated): new function
433 2003-05-11 Havoc Pennington <hp@pobox.com>
435 Write a "test-profile" that does echo client-server with threads;
436 profile reveals lock contention, memcpy/realloc of buffers, and
437 UTF-8 validation as hot spots. 20% of lock contention eliminated
438 with dbus_atomic_inc/dec implementation on x86. Much remaining
439 contention is global mempool locks for GList and DBusList.
441 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec): add
444 * dbus/dbus-connection.c (struct DBusConnection): use
445 dbus_atomic_t for the reference count
447 * dbus/dbus-message.c (struct DBusMessage): declare
448 dbus_atomic_t values as volatile
450 * configure.in: code to detect ability to use atomic integer
451 operations in assembly, from GLib patch
453 * dbus/dbus-internals.c (_dbus_verbose_real): call getpid every
454 time, tired of it being wrong in threads and forked processes
456 * glib/test-profile.c: a little program to bounce messages back
457 and forth between threads and eat CPU
459 * dbus/dbus-connection.c: add debug spew macros for debugging
460 thread locks; include config.h at top; fix deadlock in
461 dbus_connection_flush()
463 2003-05-08 Havoc Pennington <hp@pobox.com>
465 * dbus/dbus-spawn.c: s/_exit/exit/ because it was keeping gcov
466 data from getting written, and there wasn't a good reason to
469 * test/decode-gcov.c (mark_inside_dbus_build_tests): don't count
470 dbus_verbose lines in test coverage
471 (main): add list of functions sorted by # of untested blocks
472 to the coverage report
474 * dbus/dbus-mempool.c: put some test-only code in DBUS_BUILD_TESTS
476 * dbus/dbus-marshal.c (_dbus_marshal_test): extend test coverage
478 * dbus/dbus-message-handler.c (_dbus_message_handler_test):
481 * test/data/auth/cancel.auth-script: test canceling an
484 * dbus/Makefile.am: remove dbus-server-debug.[hc] for now, as they
485 aren't used. in CVS history if we end up needing them.
487 2003-05-04 Havoc Pennington <hp@pobox.com>
489 * dbus/dbus-message-handler.c (_dbus_message_handler_test): add
492 * dbus/dbus-marshal.c (_dbus_demarshal_string_array): fix this
493 function, which assumed length was in # of strings, not bytes
495 * dbus/dbus-message.c (_dbus_message_test): add tests for some
498 * dbus/dbus-connection.c
499 (_dbus_connection_queue_received_message): disable function for
500 now, we are only using it in test mode
502 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
503 remove a mistaken FIXME
505 2003-05-04 Havoc Pennington <hp@pobox.com>
507 * dbus/dbus-connection.c (dbus_connection_preallocate_send):
508 unlock mutex on successful return, patch from Anders Gustafsson
510 2003-05-04 Havoc Pennington <hp@pobox.com>
512 * dbus-glib-1.pc.in (Requires): fix dependencies, from
515 2003-05-04 Havoc Pennington <hp@pobox.com>
517 * tools/dbus-launch.c: implement
519 * bus/main.c (main), bus/bus.c (bus_context_new):
520 implement --print-pid and --fork
522 2003-05-03 Havoc Pennington <hp@redhat.com>
524 * dbus/dbus-address.c (dbus_parse_address): fix bug when a key in
525 the address had no value, and add to test suite. Fix and
526 regression test from Miloslav Trmac
528 2003-05-03 Havoc Pennington <hp@pobox.com>
530 * dbus/dbus-watch.c (dbus_watch_handle): warn and return if a
531 watch is invalid when handled
533 * tools/Makefile.am, tools/dbus-launch.c, tools/dbus-launch.1: add
534 dbus-launch utility to launch the bus from a shell script. Didn't
535 actually implement dbus-launch yet, it's just a placeholder still.
537 2003-05-03 Havoc Pennington <hp@pobox.com>
539 * bus/Makefile.am, bus/dbus-daemon-1.1.in: man page for the
540 daemon; also documents daemon config file, so replaces
541 doc/config-file.txt. Corrected some stuff from config-file.txt in
542 the process of moving it.
544 2003-05-03 Havoc Pennington <hp@pobox.com>
546 * tools/Makefile.am, tools/dbus-send.1, tools/dbus-monitor.1:
549 2003-05-03 Colin Walters <walters@verbum.org>
551 * dbus/dbus-sysdeps.c (fill_user_info): Test against
552 DBUS_UID_UNSET to determine whether to do a uid lookup or not.
554 * Makefile.am: Update to use new .pc versioning scheme.
556 2003-05-02 Havoc Pennington <hp@redhat.com>
558 * bus/system.conf.in: allow send/receive to/from message bus
561 2003-04-30 Havoc Pennington <hp@redhat.com>
563 * configure.in: print a note when building with unit tests and
566 2003-04-30 Havoc Pennington <hp@redhat.com>
568 * Makefile.am: add a check-local that complains if you didn't
569 configure with --enable-tests
571 2003-04-29 Havoc Pennington <hp@redhat.com>
573 * glib/dbus-gmain.c: docs cleanups
575 * dbus/dbus-types.h: add docs on int64 types
577 * dbus/dbus-memory.c: fix docs to avoid putting private API in
578 public API docs section
580 2003-04-29 Havoc Pennington <hp@redhat.com>
582 * dbus-1.pc.in, dbus-glib-1.pc.in: rename these from
583 dbus-1.0.pc.in, dbus-glib-1.0.pc.in. As these change with the
584 parallel install API version, not with the D-BUS package version.
586 * HACKING: move some of README over here
588 * README: updates, and document API/ABI policy
590 * configure.in: reindentation
592 2003-04-29 Havoc Pennington <hp@redhat.com>
594 * dbus/dbus.h: add "you have to define DBUS_API_SUBJECT_TO_CHANGE
595 to use this library" to be sure people have the right
598 2003-04-28 Havoc Pennington <hp@redhat.com>
600 * configure.in: add --enable-docs which by default is auto yes if
601 doxygen and db2html found, no otherwise; but can be forced on/off
603 * doc/Makefile.am: conditionalize whether to build docs on
606 2003-04-28 Havoc Pennington <hp@redhat.com>
612 * bus/system.conf.in: add <includedir>system.d</includedir>
614 * dbus/dbus-userdb.c (_dbus_user_database_lookup): fix bug when
615 username was provided but not uid
617 * bus/config-parser.c (struct BusConfigParser): keep track of
618 whether the parser is toplevel or was included; change some
619 of the error handling if it's included.
621 2003-04-27 Havoc Pennington <hp@pobox.com>
625 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
626 report correct status if we finish processing authentication
627 inside this function.
629 * bus/activation.c (try_send_activation_failure): use
630 bus_transaction_send_error_reply
632 * bus/connection.c (bus_connection_get_groups): return an error
633 explaining the problem
635 * bus/bus.c (bus_context_check_security_policy): implement
636 restriction here that inactive connections can only send the
637 hello message. Also, allow bus driver to send anything to
640 * bus/connection.c (bus_connection_complete): create the
641 BusClientPolicy here instead of on-demand.
642 (bus_connection_get_policy): don't return an error
644 * dbus/dbus-message.c (dbus_message_new_error_reply): allow NULL
645 sender field in message being replied to
647 * bus/bus.c (bus_context_check_security_policy): fix silly typo
648 causing it to return FALSE always
650 * bus/policy.c (bus_client_policy_check_can_send): fix bug where
651 we checked sender rather than destination
653 2003-04-25 Havoc Pennington <hp@redhat.com>
655 test suite is slightly hosed at the moment, will fix soon
657 * bus/connection.c (bus_connections_expire_incomplete): fix to
658 properly disable the timeout when required
659 (bus_connection_set_name): check whether we can remove incomplete
660 connections timeout after we complete each connection.
662 * dbus/dbus-mainloop.c (check_timeout): fix this up a bit,
663 probably still broken.
665 * bus/services.c (bus_registry_acquire_service): implement max
666 number of services owned, and honor allow/deny rules on which
667 services a connection can own.
669 * bus/connection.c (bus_connection_get_policy): report errors here
671 * bus/activation.c: implement limit on number of pending
674 2003-04-25 Havoc Pennington <hp@redhat.com>
676 * dbus/dbus-transport.c (_dbus_transport_get_unix_user): fix bug
677 where we used >= 0 instead of != DBUS_UID_UNSET.
679 2003-04-25 Havoc Pennington <hp@redhat.com>
681 * glib/dbus-gmain.c (remove_watch): fix for a crash when watches
682 were toggled without add/remove, fix from Anders Gustafsson
684 2003-04-24 Havoc Pennington <hp@redhat.com>
686 * test/data/valid-config-files/basic.conf: add <limit> tags to
689 * bus/config-parser.h, bus/config-parser.c, bus/bus.c: Implement
690 <limit> tag in configuration file.
692 2003-04-24 Havoc Pennington <hp@redhat.com>
694 * bus/dispatch.c: somehow missed some name_is
696 * dbus/dbus-timeout.c (_dbus_timeout_set_enabled)
697 (_dbus_timeout_set_interval): new
699 * bus/connection.c (bus_connections_setup_connection): record time
700 when each connection is first set up, and expire them after the
703 2003-04-24 Havoc Pennington <hp@redhat.com>
705 * dbus/dbus-message.c (dbus_message_name_is): rename
706 (dbus_message_service_is): rename
707 (dbus_message_sender_is): rename
708 (dbus_message_get_service): rename
710 2003-04-24 Havoc Pennington <hp@redhat.com>
712 * configure.in: add --enable-checks
714 * dbus/dbus-message.c (dbus_message_new): reverse name/service arguments
716 * dbus/dbus-connection.c (dbus_connection_preallocate_send): fix
718 (_dbus_connection_handler_destroyed_locked): move some private
719 functions into proper docs group
721 * dbus/dbus-internals.h: add _dbus_return_if_fail,
722 _dbus_return_val_if_fail
724 Throughout: use dbus_return_if_fail
726 2003-04-23 James Willcox <jwillcox@gnome.org>
729 * glib/dbus-gmain.c: (add_timeout), (wakeup_main), (create_source),
730 (dbus_connection_setup_with_g_main),
731 (dbus_server_setup_with_g_main):
732 * glib/test-dbus-glib.c: (main):
733 * glib/test-thread-client.c: (main):
734 * glib/test-thread-server.c: (new_connection_callback), (main):
735 * tools/dbus-monitor.c: (main):
737 Added a GMainContext argument to dbus_connection_setup_with_g_main()
738 and dbus_server_setup_with_g_main().
740 2003-04-20 Havoc Pennington <hp@pobox.com>
742 * doc/dbus-specification.sgml: document the restrictions on
743 message and service names
745 2003-04-22 Havoc Pennington <hp@redhat.com>
747 * dbus/dbus-message.c, dbus/dbus-marshal.c: add 64-bit integer
748 support, and do some code cleanups to share more code and
749 speed up array marshal/demarshal.
751 * dbus-1.0.pc.in (Cflags): put libdir include file in cflags
753 * configure.in: generate dbus-arch-deps.h
755 * dbus/dbus-protocol.h (DBUS_TYPE_INT64, DBUS_TYPE_UINT64): add
758 2003-04-22 Havoc Pennington <hp@redhat.com>
760 * test/data/valid-messages/opposite-endian.message: fix test
761 to use proper type for rply field
763 * test/data/invalid-messages: add tests for below validation
765 * dbus/dbus-message.c (decode_header_data): validate field types,
766 and validate that named fields are valid names
767 (decode_name_field): consider messages in the
768 org.freedesktop.Local. namespace to be invalid.
770 * dbus/dbus-string.c (_dbus_string_validate_name): new
772 2003-04-19 Havoc Pennington <hp@pobox.com>
774 * bus/driver.c (bus_driver_handle_hello): check limits and
775 return an error if they are exceeded.
777 * bus/connection.c: maintain separate lists of active and inactive
778 connections, and a count of each. Maintain count of completed
779 connections per user. Implement code to check connection limits.
781 * dbus/dbus-list.c (_dbus_list_unlink): export
783 * bus/bus.c (bus_context_check_security_policy): enforce a maximum
784 number of bytes in the message queue for a connection
786 2003-04-18 Havoc Pennington <hp@pobox.com>
788 * dbus/dbus-auth.c (record_mechanisms): memleak fixes
790 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): fix some
793 * dbus/dbus-keyring.c (add_new_key): fix a memleak, and
794 on realloc be sure to update the pointer in the keyring
796 * dbus/dbus-string.c (_dbus_string_zero): compensate for align
797 offset to avoid writing to unallocated memory
799 * dbus/dbus-auth.c (process_rejected): return FALSE if we fail to
800 try the next mechanism, so we properly handle OOM
802 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): fix double-free
804 (_dbus_keyring_new): fix OOM bug
805 (_dbus_keyring_new_homedir): always set error; impose a maximum
806 number of keys we'll load from the file, mostly to speed up the
807 test suite and make its OOM checks more useful, but also for
810 * dbus/dbus-auth.c (process_error_server): reject authentication
811 if we get an error from the client
812 (process_cancel): on cancel, send REJECTED, per the spec
813 (process_error_client): send CANCEL if we get an error from the
816 2003-04-18 Havoc Pennington <hp@pobox.com>
818 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix UMR in verbose
821 * dbus/dbus-auth.c (handle_client_data_cookie_sha1_mech): fix OOM
824 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): only whine
825 about DBUS_TEST_HOMEDIR once
827 * bus/Makefile.am (TESTS_ENVIRONMENT): put DBUS_TEST_HOMEDIR in
830 * bus/dispatch.c (bus_dispatch_sha1_test): actually load sha1
831 config file so we test the right thing
833 Throughout: assorted docs improvements
835 2003-04-18 Havoc Pennington <hp@pobox.com>
837 * glib/dbus-gmain.c: adapt to watch changes
839 * bus/bus.c, bus/activation.c, etc.: adjust to watch changes
841 * dbus/dbus-server.h: remove dbus_server_handle_watch
843 * dbus/dbus-connection.h: remove dbus_connection_handle_watch
845 * dbus/dbus-watch.c (dbus_watch_handle): change DBusWatch to work
846 like DBusTimeout, so we don't need dbus_connection_handle_watch
849 2003-04-17 Havoc Pennington <hp@redhat.com>
851 * dbus/dbus-userdb.c, dbus/dbus-sysdeps.c: redo all the passwd
852 database usage so it all goes via the DBusUserDatabase cache.
854 2003-04-17 Havoc Pennington <hp@redhat.com>
856 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix logic so that if
857 there was an OOM watch we skipped, we always return TRUE so we
858 iterate again to have a look at it again. Fixes test suite hang.
859 Code rearrangement also lets us lose some memset and only iterate
862 * bus/driver.c (bus_driver_handle_message): sense of test for
865 2003-04-16 Havoc Pennington <hp@pobox.com>
867 * doc/dbus-specification.sgml: make spec say serials are unsigned
869 * dbus/dbus-message.h: change message serials to unsigned
871 * dbus/dbus-connection.c: adapt to message serials being unsigned
873 2003-04-15 Havoc Pennington <hp@pobox.com>
875 * bus/bus.c: create and keep around a shared DBusUserDatabase
878 * bus/connection.c (bus_connection_get_groups): don't cache
879 groups for user in the connection object, since user database
880 object now does that.
882 2003-04-16 Havoc Pennington <hp@redhat.com>
884 * dbus/dbus-message.c (_dbus_message_add_size_counter): keep a
885 list of size counters
886 (_dbus_message_loader_putback_message_link): put back a popped link
888 * dbus/dbus-connection.c
889 (dbus_connection_set_max_live_messages_size): rename
891 (dbus_connection_get_outgoing_size): get size of outgoing
893 (_dbus_connection_set_connection_counter): remove this cruft
895 2003-04-14 Havoc Pennington <hp@redhat.com>
897 * dbus/dbus-userdb.c: user database abstraction, mostly to get
898 caching, but at some point we might want to be able to use a
901 * bus/dispatch.c (bus_dispatch_sha1_test): add a test that uses
902 SHA1 conf file to test the sha1 auth mechanism, since the regular
903 test always uses EXTERNAL when available.
906 test/data/valid-config-files/debug-allow-all-sha1.conf.in:
907 add conf file that requires use of sha1 auth
909 2003-04-13 Havoc Pennington <hp@pobox.com>
911 * tools/dbus-send.c, tools/dbus-monitor.c: two utility programs
912 from Philip Blundell to send messages and monitor them.
914 2003-04-13 Havoc Pennington <hp@pobox.com>
916 * dbus/dbus-mainloop.c: fix some reentrancy issues by refcounting
919 * test/data/valid-config-files/debug-allow-all.conf.in: allow all
922 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
923 fix to only recover unused bytes if we're already authenticated
924 (_dbus_transport_get_is_authenticated): fix to still mark us
925 authenticated if there are unused bytes.
927 * bus/dispatch.c: implement security policy checking
929 * bus/connection.c (bus_transaction_send_from_driver): new
931 * bus/bus.c (bus_context_check_security_policy): new
933 * bus/dispatch.c (send_service_nonexistent_error): delete this,
934 now we just set the DBusError and it gets converted to an error
937 * bus/connection.c (allow_user_function): enable code using actual
938 data from the config file
940 * bus/policy.c (list_allows_user): handle wildcard rules for
941 user/group connection perms
943 2003-04-13 Havoc Pennington <hp@pobox.com>
945 * bus/config-parser.c: Load up the BusPolicy and BusPolicyRules
947 * dbus/dbus-sysdeps.c (_dbus_get_user_id): new function
949 * bus/policy.c (bus_policy_append_mandatory_rule)
950 (bus_policy_append_default_rule, bus_policy_append_user_rule)
951 (bus_policy_append_group_rule): new functions
953 2003-04-12 Havoc Pennington <hp@pobox.com>
955 * bus/config-parser.c (bus_config_parser_new): fix a memleak
957 * dbus/dbus-sysdeps.c: change DBusCredentials to use longs for
958 the pid/gid/uid, just for paranoia.
960 * test/break-loader.c (randomly_do_n_things): find a byte
961 containing a type code, and randomly change it to a different
964 2003-04-12 Havoc Pennington <hp@pobox.com>
966 * bus/policy.h: change BusPolicy to be the thing from the config
967 file, and rename old BusPolicy to BusClientPolicy
969 * bus/bus.c, bus/connection.c, bus/config-parser.c: change to
970 match change in how policy works
972 * dbus/dbus-internals.h: mark assert_not_reached as
973 __attribute((noreturn))__
975 2003-04-11 Havoc Pennington <hp@redhat.com>
977 * doc/dbus-specification.sgml: fix a spot with the wrong name for
978 the broadcast service. Use boolean return for ServiceExists.
980 2003-04-11 Havoc Pennington <hp@redhat.com>
982 * configure.in: add another directory to look for qt in.
984 2003-04-11 Havoc Pennington <hp@redhat.com>
986 * AUTHORS: add Colin Walters
988 2003-04-11 Havoc Pennington <hp@redhat.com>
994 2003-04-11 Havoc Pennington <hp@redhat.com>
996 * bus/messagebus.in: remove pid file when stopping the
997 message bus, since the bus won't have privileges to remove it
1000 2003-04-11 Havoc Pennington <hp@redhat.com>
1002 * bus/bus.c (bus_context_new): move credentials change after
1005 2003-04-11 Havoc Pennington <hp@pobox.com>
1007 * test/decode-gcov.c: add "below average functions" to the
1008 coverage report, and change how some of the code works.
1010 * bus/test-main.c: bracket some stuff in DBUS_BUILD_TESTS so it's
1011 not in the coverage stats.
1013 * test/test-service.c (main): use _dbus_verbose not fprintf in a
1014 couple places so running the test suite doesn't result in megaspam.
1016 2003-04-11 Havoc Pennington <hp@pobox.com>
1018 * bus/dispatch.c (check_existent_service_activation): accept a no
1019 memory error in a place we didn't before
1021 * bus/test.c (bus_test_run_everything): remove hacky "do it twice
1022 in case the first one failed," since the test suite is less
1025 2003-04-10 Havoc Pennington <hp@pobox.com>
1027 * bus/dispatch.c (check_segfault_service_activation): add test
1028 for launching an executable that just crashes.
1030 * test/test-segfault.c (main): try setting coredumpsize to 0 so we
1031 don't leave a million cores. We'll see how portable this is.
1033 2003-04-10 Havoc Pennington <hp@pobox.com>
1035 * dbus/dbus-spawn.c (_dbus_spawn_async_with_babysitter): move all
1036 the possible parent failures before we fork, so that we don't
1037 fail to create a babysitter after creating the child.
1039 * bus/activation.c (bus_activation_activate_service): kill child
1040 if we don't successfully complete the activation.
1042 2003-04-10 Havoc Pennington <hp@redhat.com>
1044 * dbus/dbus-connection.c (dbus_connection_flush): don't spin on
1045 the connection if it's disconnected
1047 * bus/activation.c (bus_activation_service_created): use new
1048 transaction features to roll back removal of pending activation if
1049 we don't successfully create the service after all. Don't remove
1050 pending activation if the function fails.
1052 * dbus/dbus-list.c (_dbus_list_insert_before_link)
1053 (_dbus_list_insert_after_link): new code to facilitate
1056 * dbus/dbus-hash.c (_dbus_hash_table_insert_string_preallocated):
1057 new functionality, so we can preallocate the ability to insert
1060 * bus/connection.c (bus_transaction_add_cancel_hook): new function
1061 allowing us to put custom hooks in a transaction to be used for
1062 cancelling said transaction
1064 * doc/dbus-specification.sgml: add some discussion of secondary
1065 service owners, and disallow zero-length service names
1067 * bus/services.c (bus_registry_acquire_service): new function,
1068 splits out part of bus_driver_handle_acquire_service() and fixes
1069 a bug where we didn't remove the service doing the acquiring
1070 from the secondary queue if we failed to remove the current owner
1071 from the front of the queue.
1073 2003-04-10 Alexander Larsson <alexl@redhat.com>
1075 * doc/dbus-specification.sgml:
1076 s/org.freedesktop.Broadcast/org.freedesktop.DBus.Broadcast/
1078 2003-04-10 Alexander Larsson <alexl@redhat.com>
1083 Added files to cvsignore
1085 * dbus/dbus-message.h:
1086 * dbus/dbus-message.c: (dbus_message_iter_get_named):
1087 Make get_named() take two out argument and return a boolean.
1088 (dbus_message_iter_get_args_valist):
1089 Update usage of get_named().
1090 (dbus_message_iter_append_byte):
1092 (dbus_message_iter_append_named)
1094 (message_iter_test), (check_message_handling_type), (_dbus_message_test):
1097 2003-04-10 Alexander Larsson <alexl@redhat.com>
1099 * dbus/dbus-marshal.[ch]:
1100 Add array_type_pos argument to _dbus_marshal_validate_arg.
1101 Let you pass a NULL end_pos to _dbus_marshal_validate_type.
1103 * dbus/dbus-message.[ch]:
1104 Multi-dimensional arrays have full type specification in the
1105 outermost array. Iter code re-arranged to handle this.
1106 Added some more iter tests.
1108 * doc/dbus-specification.sgml:
1111 Update new array encoding description.
1112 Correct DBUS_SERVICE_FLAGS_REPLACE_EXISTING description.
1114 * test/data/invalid-messages/array-with-mixed-types.message:
1115 * test/data/valid-messages/array-of-array-of-uint32.message:
1116 Change to the new array format.
1118 * test/data/invalid-messages/too-short-dict.message:
1121 * test/data/valid-messages/recursive-types.message:
1122 Fix up and extend test.
1124 2003-04-10 Havoc Pennington <hp@pobox.com>
1126 * bus/dispatch.c: lots of fixes
1128 * dbus/dbus-mainloop.c (_dbus_loop_dispatch): export
1129 (_dbus_loop_iterate): remove old "quit if no callbacks" code,
1130 that was crack, broke the test service.
1132 * dbus/dbus-transport.c (_dbus_transport_open): fix error
1133 handling to avoid piling up errors if we get a failure on the
1136 * dbus/dbus-internals.c (_dbus_real_assert_not_reached): include
1137 pid in assertion failures.
1139 * dbus/dbus-mainloop.c (_dbus_loop_iterate): use static arrays up
1140 to some fixed size of file descriptor array. Don't return TRUE
1141 anytime a timeout exists, that led to lots of busy loop silliness
1144 2003-04-09 Havoc Pennington <hp@redhat.com>
1146 * dbus/dbus-mainloop.c (check_timeout): fix timeouts, I thought
1147 I'd checked this in earlier but hadn't.
1149 2003-04-09 Havoc Pennington <hp@redhat.com>
1151 * bus/dispatch.c (bus_dispatch_test): get a bit further through
1152 the activation test (man this is getting old!)
1154 2003-04-09 Havoc Pennington <hp@redhat.com>
1156 * test/test-utils.c: use dispatch status function to fix this up
1158 * bus/connection.c (connection_watch_callback): don't dispatch
1160 (connection_timeout_callback): don't dispatch from here
1161 (bus_connections_setup_connection): set the dispatch status function
1162 (bus_connection_disconnected): unset it
1164 * dbus/dbus-mainloop.c (_dbus_loop_queue_dispatch): new function
1165 used to add a connection to be dispatched
1166 (_dbus_loop_iterate): do the dispatching at the end of each
1169 * dbus/dbus-connection.c
1170 (dbus_connection_set_dispatch_status_function): new function
1171 allowing us to fix up main loop usage
1172 (_dbus_connection_last_unref): free all the various function
1174 (dbus_connection_dispatch): call the DispatchStatusFunction
1175 whenever this function returns
1176 (dbus_connection_handle_watch): call DispatchStatusFunction
1177 (dbus_connection_send_with_reply_and_block): call DispatchStatusFunction
1178 (reply_handler_timeout): call DispatchStatusFunction
1179 (dbus_connection_flush): call DispatchStatusFunction
1181 2003-04-09 Havoc Pennington <hp@redhat.com>
1183 * dbus/dbus-bus.c (dbus_bus_register): fix up error handling and
1186 * bus/dispatch.c (check_service_activated): fix bug in test
1188 * dbus/dbus-mainloop.c (check_timeout): fix this up
1190 * dbus/dbus-internals.c (_dbus_verbose_real): include PID in
1191 verbose output so we can sort out output from different processes,
1192 e.g. in the activation case.
1194 2003-04-08 Colin Walters <walters@gnu.org>
1196 * bus/bus.c (struct BusContext) [pidfile]: New member, to store
1198 (bus_context_new): Set it.
1199 (bus_context_unref): Use it to delete the pid file.
1201 2003-04-08 Havoc Pennington <hp@redhat.com>
1203 * test/data/invalid-messages/array-with-mixed-types.message:
1204 regression test that fails for the moment
1206 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): reorder
1207 tests for convenience
1209 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): don't allow
1210 array of nil, it broke things.
1212 * test/data/invalid-messages/array-of-nil.message: regression test
1214 * test/data/valid-messages/array-of-array-of-uint32.message:
1215 happened to write this so added it to suite
1217 2003-04-08 Havoc Pennington <hp@redhat.com>
1219 * bus/driver.c (bus_driver_handle_acquire_service): init
1220 retval/reply before checking name
1222 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add a
1223 recursion depth argument
1225 * dbus/dbus-message.h (struct DBusMessageIter): put some padding
1226 in the public struct for future extension
1228 * dbus/dbus-message-builder.c (_dbus_message_data_load): fix
1231 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix a verbose
1234 * doc/dbus-specification.sgml: fix typo
1236 2003-04-08 Alexander Larsson <alexl@redhat.com>
1238 Implemented recursive types, named types and new-style iters
1241 * glib/test-thread-client.c: (thread_func):
1242 * glib/test-thread-server.c: (handle_test_message):
1243 * test/test-service.c: (handle_echo):
1252 * dbus/dbus-internals.c: (_dbus_type_to_string):
1253 Update for new types.
1255 * dbus/dbus-marshal.[ch]:
1256 Implement recursive types and the new marshalling format.
1257 Remove hardcoded dict marshalling.
1258 Marshal named types.
1260 * dbus/dbus-message-builder.c:
1262 Remove references to old types
1264 * dbus/dbus-message.[ch]:
1265 New non-refcounted iter API that supports recursive iters.
1266 Use iters for appending, including support for recursive
1268 Add byte and named type support.
1269 Update everything to new marshalling formats.
1270 Add tests for new API.
1272 * dbus/dbus-protocol.h:
1273 Remove old array types.
1274 Add types: BYTE, ARRAY, DICT, NAMED
1276 * dbus/dbus-string.c:
1277 * dbus/dbus-sysdeps.c:
1278 Make parse_double locale safe.
1280 * dbus/dbus-test-main.c:
1286 * doc/dbus-specification.sgml:
1289 * test/data/incomplete-messages/missing-body.message:
1290 * test/data/invalid-messages/bad-boolean.message:
1291 * test/data/invalid-messages/bad-boolean-array.message:
1292 * test/data/invalid-messages/boolean-array-length-too-long.message-raw:
1293 * test/data/invalid-messages/boolean-has-no-value.message-raw:
1294 * test/data/invalid-messages/too-short-dict.message:
1295 * test/data/valid-messages/dict-simple.message:
1296 * test/data/valid-messages/dict.message:
1297 * test/data/valid-messages/emptiness.message:
1298 * test/data/valid-messages/lots-of-arguments.message:
1299 * test/data/valid-messages/no-padding.message:
1300 * test/data/valid-messages/recursive-types.message:
1301 Add missing NAME fields
1302 Fix up dicts & arrays
1304 * test/data/invalid-messages/dict-with-nil-value.message:
1305 Removed, this is not invalid anymore.
1307 * test/data/valid-messages/recursive-types.message:
1308 Add new test for deeply recursive types.
1310 2003-04-07 Havoc Pennington <hp@pobox.com>
1312 * bus/driver.c (bus_driver_handle_acquire_service): return an
1313 error if you try to acquire a service that starts with ':'
1315 2003-04-07 Havoc Pennington <hp@redhat.com>
1317 * doc/dbus-specification.sgml: require that base service names
1318 start with ':' and that the base service is created/deleted
1319 as first and last things a connection does on the bus
1321 * bus/dispatch.c (check_existent_service_activation): lots more
1322 work on the activation test; it doesn't fully pass yet...
1324 * test/test-service.c (main): fix so we don't memleak the
1325 connection to the message bus
1326 (filter_func): accept a message asking us to exit
1328 2003-04-06 Havoc Pennington <hp@pobox.com>
1330 * qt/Makefile.am (dbusinclude_HEADERS): install dbus-qt.h,
1333 * configure.in: fixes to Qt detection from Colin Walters
1335 * doc/Makefile.am: Only remove generated docbook dirs if they
1336 exist, from Colin Walters
1338 * dbus/dbus-bus.c: change how we set well-known connections to
1339 NULL, so that it works if a single connection is stored in
1340 two well-known array slots.
1342 * test/Makefile.am: remove a lot of stuff that isn't immediately
1343 useful, it's in CVS history if we want it.
1345 * test/test-service.c: use dbus-mainloop instead of that
1348 2003-04-06 Havoc Pennington <hp@pobox.com>
1350 * dbus/Makefile.am: split lists of sources into stuff that goes in
1351 the library, util functions that go in the lib and are also used
1352 elsewhere, and util functions that are used in tests/daemon but
1353 don't go in the lib.
1355 * dbus/dbus-mainloop.h, dbus/dbus-mainloop.c: move bus/loop.[hc]
1356 here so it can be used in test binaries also
1358 2003-04-06 Havoc Pennington <hp@pobox.com>
1360 * dbus/dbus-sysdeps.c (_dbus_become_daemon): write the pidfile
1361 here in the parent process, so we can return an error if it
1362 fails. Also, move some of the code into the child so the parent
1363 is less hosed if we fail midway through.
1365 * bus/bus.c (bus_context_new): move pidfile detection further up
1366 in the function, before we start overwriting sockets and such.
1368 * bus/messagebus.in: adjust this a bit, not sure if it will work.
1370 * configure.in: add --with-system-pid-file and --with-system-socket
1372 2003-04-06 Colin Walters <walters@verbum.org>
1374 * configure.in (DBUS_SYSTEM_PID_FILE): New variable.
1376 * bus/system.conf.in: Declare a pidfile.
1378 * bus/bus.c (bus_context_new): Test for an existing pid file, and
1379 create one (if appropriate).
1381 * bus/config-parser.c (enum ElementType) [ELEMENT_PIDFILE]: New.
1382 (struct BusConfigParser) [pidfile]: New.
1383 (element_type_to_name, merge_included, start_busconfig_child)
1384 (bus_config_parser_end_element, bus_config_parser_content): Handle it.
1385 (bus_config_parser_unref): Free it.
1386 (bus_config_parser_get_pidfile): New function.
1388 * bus/config-parser.h (_dbus_write_pid_file): Prototype.
1390 * dbus/dbus-errors.h (DBUS_ERROR_PIDFILE_EXISTS): New error.
1392 * dbus/dbus-sysdeps.c (_dbus_write_pid_file): New function.
1394 * dbus/dbus-sysdeps.h: Prototype it.
1396 2003-04-06 Havoc Pennington <hp@pobox.com>
1398 * bus/bus.c (bus_context_new): print the address in here, rather
1399 than in main(), because we need to do it before forking the daemon
1401 * bus/dispatch.c (send_service_nonexistent_error): set the sender
1402 on the service nonexistent error
1404 * bus/driver.c (bus_driver_handle_acquire_service): set the
1405 sender on the AcquireService reply
1407 * test/data/valid-config-files/debug-allow-all.conf.in: Make test
1408 server also listen on a UNIX socket so services can connect to it.
1410 2003-04-06 Havoc Pennington <hp@pobox.com>
1412 * dbus/dbus-threads.c: Redo how the fake debug mutexes are done
1413 so it detects deadlocks and also we actually init threads when
1416 2003-04-06 Havoc Pennington <hp@pobox.com>
1418 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
1419 save the domain socket name, and unlink it when we disconnect the
1420 server. Means that at least when we exit normally, we won't leave
1421 a bunch of junk in /tmp
1423 * dbus/dbus-transport-unix.c
1424 (_dbus_transport_new_for_domain_socket): code cleanup (nicer
1425 memory management). (I was making a real change here but then
1428 2003-04-06 Havoc Pennington <hp@pobox.com>
1430 * bus/bus.c (bus_context_new): fix wrong handling of
1431 server_data_slot_unref() in the error case.
1433 * dbus/dbus-internals.h (_dbus_assert): change so it passes
1434 "(condition) != 0" to _dbus_real_assert so that
1435 "_dbus_assert (pointer)" doesn't cause a warning
1437 * bus/main.c (main): accept --print-address option to print out
1438 the message bus address
1440 * dbus/dbus-sysdeps.c (_dbus_generate_random_ascii): export this
1442 * dbus/dbus-transport.c (_dbus_transport_open): special error for
1443 "tmpdir" option to unix: address on client side
1445 * dbus/dbus-server.c (dbus_server_listen): handle "tmpdir" option
1448 * configure.in (TEST_SOCKET_DIR): locate a temporary directory
1449 we can use to create sockets in the test suite.
1451 * bus/main.c (signal_handler): on SIGTERM, exit the daemon
1452 cleanly. To be used for testing.
1454 * dbus/dbus-spawn.c (babysit): use _dbus_set_signal_handler()
1456 * dbus/dbus-sysdeps.c (_dbus_set_signal_handler): new
1458 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
1459 handle trying to call this when there's no servers active
1461 2003-04-05 Havoc Pennington <hp@pobox.com>
1467 2003-04-05 Havoc Pennington <hp@pobox.com>
1469 * bus/bus.c (setup_server): fix this so dbus-daemon-1 doesn't
1470 crash on startup. Need to get "try starting the daemon"
1471 in the test suite I guess. ;-)
1473 * dbus/dbus-server.h, dbus/dbus-server.c: remove the stuff that
1474 tracked the number of open connections; it's better done in
1475 application-specific code as you want it to span all servers etc.
1477 2003-04-05 Havoc Pennington <hp@pobox.com>
1479 * bus/Makefile.am (install-data-hook): add missing DESTDIR,
1480 patch from Colin Walters
1482 2003-04-05 Havoc Pennington <hp@pobox.com>
1484 * doc/config-file.txt (Elements): fix docs of <auth> to reflect
1485 reality; in fact multiple mechanisms are allowed.
1487 * dbus/dbus-internals.c (_dbus_real_assert)
1488 (_dbus_real_assert_not_reached): move guts of _dbus_assert() and
1489 _dbus_assert_not_reached() into functions, so that they don't show
1490 up in basic block counts for test coverage, and don't use up as
1491 much disk space. Does mean slower execution speed though, so
1492 assumes --disable-asserts is the normal production case.
1494 2003-04-05 Havoc Pennington <hp@pobox.com>
1496 * test/Makefile.am (dist-hook): also dist *.in files
1502 2003-04-05 Havoc Pennington <hp@pobox.com>
1504 * dbus/dbus-string.c: docs warning
1506 * dbus/dbus-spawn.c: missing docs
1508 * dbus/dbus-memory.c (struct ShutdownClosure): missing docs
1510 2003-04-05 Havoc Pennington <hp@pobox.com>
1512 * bus/loop.c (bus_loop_iterate): fix the timeout code, using
1515 * dbus/dbus-spawn.c (_dbus_babysitter_unref): set sitter_pid
1516 to -1 once we've reaped the babysitter
1517 (_dbus_babysitter_handle_watch): do as much work as we can, not
1520 * bus/activation.c: add code using DBusBabysitter so that we
1521 handle it when a service fails to start up properly.
1522 (bus_activation_service_created): don't remove the activation
1523 entries as we go, just let them get removed when we free the pending
1524 activation. Unref reply messages after sending them.
1526 2003-04-05 Havoc Pennington <hp@pobox.com>
1528 * test/decode-gcov.c (main): print per-directory stats in the report
1530 * Makefile.am (coverage-report.txt): don't include test/* in gcov stats
1532 2003-04-05 Havoc Pennington <hp@pobox.com>
1534 * Makefile.am (coverage-report.txt): add target "coverage-report.txt"
1536 * test/decode-gcov.c: hack up a little program to suck data
1537 out of gcov files. Yes this is sort of silly.
1539 * configure.in: define something in config.h and do an
1540 AM_CONDITIONAL when gcov is enabled
1542 2003-04-04 Havoc Pennington <hp@redhat.com>
1544 * dbus/dbus-spawn.c, dbus/dbus-spawn.h: Change dbus_spawn to
1545 return a "babysitter" object that is used to monitor the status of
1546 the spawned process and reap it when required.
1548 * test/test-segfault.c, test/test-exit.c,
1549 test/test-sleep-forever.c: binaries that do various lame things,
1550 used in the test suite.
1552 * dbus/dbus-sysdeps.c: kill _dbus_errno_to_string()
1554 2003-04-03 Havoc Pennington <hp@pobox.com>
1556 * dbus/dbus-spawn.c: Move dbus-spawn into a separate file
1557 in preparation for modifying it, dbus-sysdeps is getting
1560 2003-04-03 Havoc Pennington <hp@redhat.com>
1562 * bus/loop.h, bus/loop.c: make the mainloop an object so we can
1565 * bus/*.[hc]: adapt to mainloop change
1567 2003-04-03 Havoc Pennington <hp@redhat.com>
1569 * bus/activation.c (load_directory): fix up memleaks
1570 (bus_activation_entry_free): free the entry
1572 * dbus/dbus-bus.c (dbus_bus_acquire_service): return an error if
1573 we get one from the message bus; fix memleaks.
1575 * dbus/dbus-message.c (dbus_set_error_from_message): new function
1577 2003-04-03 Havoc Pennington <hp@pobox.com>
1579 * bus/config-parser.c (bus_config_parser_unref): free
1580 list of mechanisms, bug discovered by test suite enhancements
1581 (putting system.conf and session.conf into suite)
1583 * test/Makefile.am, test/test-service.c: add placeholder for a
1584 test service that we'll activate as part of test suite. Doesn't
1587 * dbus/dbus-sysdeps.c (_dbus_setenv): support unsetenv by
1588 setting NULL value, and use system malloc not dbus_malloc()
1589 when we have unavoidable memleakage.
1591 * dbus/dbus-bus.c (dbus_bus_get): fix bug where bus type of 0
1592 didn't work, and support DBUS_BUS_ACTIVATION.
1594 * bus/activation.c (child_setup): pass our well-known bus type to
1597 * bus/config-parser.c: support <type> to specify well-known type
1599 * doc/dbus-specification.sgml: document the env variables to
1600 locate well-known buses and find service activator
1602 2003-04-02 Havoc Pennington <hp@redhat.com>
1604 * test/Makefile.am (all-local): add a rule to copy tests to
1605 builddir, so we can have generated tests. Use this to remove the
1606 silly hack for testing system.conf and session.conf. Will use this
1607 shortly to generate .service files pointing to test binaries.
1609 2003-04-02 Havoc Pennington <hp@redhat.com>
1611 * dbus/dbus-string.c (set_length): fix a bug - we allocated max of
1612 current alloc and needed new length, not max of the doubled
1613 allocation and needed new length. Also, when building tests,
1614 don't do the double-allocation stuff, just realloc every time.
1616 2003-04-02 Havoc Pennington <hp@redhat.com>
1618 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): include filenames
1620 (_dbus_string_get_dirname): new
1621 (_dbus_sysdeps_test): new
1622 (_dbus_directory_open): include dirnames in error messages
1624 * bus/config-parser.c: interpret <include> and <includedir> and
1625 <servicedir> relative to config file location if the given
1626 filename is not absolute.
1628 * dbus/dbus-string.c (_dbus_string_find_byte_backward): new
1630 2003-04-02 Havoc Pennington <hp@redhat.com>
1632 * bus/connection.c (bus_transaction_send_error_reply): set sender
1633 service for the error, and unref the reply on success
1635 * bus/activation.c: convert to use BusTransaction so OOM can be
1637 (bus_activation_service_created): set sender of the message
1639 2003-04-01 Havoc Pennington <hp@redhat.com>
1641 * bus/config-parser.c, bus/bus.c: implement <servicedir> and
1642 <includedir> (at least mostly)
1644 * dbus/dbus-sysdeps.c (_dbus_change_identity): set the group ID
1645 first, then the user ID
1647 2003-04-01 Havoc Pennington <hp@pobox.com>
1649 * dbus/dbus-server.c (dbus_server_set_auth_mechanisms): new
1652 * dbus/dbus-auth.c (_dbus_auth_set_mechanisms): new
1654 * dbus/dbus-internals.c (_dbus_dup_string_array): new function
1656 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): chmod the
1657 socket 0777, and unlink any existing socket.
1659 * bus/bus.c (bus_context_new): change our UID/GID and fork if
1660 the configuration file so specifies; set up auth mechanism
1663 * bus/config-parser.c (bus_config_parser_content): add support
1664 for <fork> option and fill in code for <auth>
1666 * bus/system.conf.in: add <fork/> to default configuration,
1667 and limit auth mechanisms to EXTERNAL
1669 * doc/config-file.txt (Elements): add <fork>
1671 * dbus/dbus-sysdeps.c (_dbus_become_daemon): new function
1672 (_dbus_change_identity): new function
1674 2003-03-31 Havoc Pennington <hp@redhat.com>
1676 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket)
1677 (_dbus_listen_unix_socket): fix off-by-one error in null
1678 termination spotted by Nalin
1680 2003-03-31 Havoc Pennington <hp@redhat.com>
1682 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): allow setting
1683 DBUS_TEST_HOMEDIR when tests are enabled, so we can test without
1684 having a real home directory available.
1686 2003-03-31 Havoc Pennington <hp@redhat.com>
1688 * bus/Makefile.am (install-data-hook): create /var/run/dbus
1690 * bus/messagebus.in: add init script for Red Hat /etc/init.d
1692 * configure.in: add support for specifying a style of init script
1695 2003-03-31 Havoc Pennington <hp@redhat.com>
1697 Fix some annoying DBusString API and fix all affected code.
1699 * dbus/dbus-string.c (_dbus_string_init): get rid of annoying
1701 (_dbus_string_get_data): change to return string instead of using
1703 (_dbus_string_get_const_data): ditto
1704 (_dbus_string_get_data_len): ditto
1705 (_dbus_string_get_const_data_len): ditto
1707 2003-03-31 Havoc Pennington <hp@redhat.com>
1709 * bus/main.c (main): fix up the command line arguments to be nicer
1711 2003-03-31 Havoc Pennington <hp@redhat.com>
1713 * dbus/Makefile.am (INCLUDES): use EXPANDED_LOCALSTATEDIR to
1714 define DBUS_SYSTEM_BUS_PATH as we want to compile in the same
1715 final location that lands in the config file
1717 * bus/config-loader-expat.c (bus_config_load): fix type of
1720 * doc/TODO: remove TODO item for dbus_bus_get()
1722 * dbus/dbus-bus.c (bus_data_free): add missing lock/unlock
1724 2003-03-31 Havoc Pennington <hp@pobox.com>
1726 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_domain_socket)
1727 (_dbus_transport_new_for_tcp_socket): these didn't need the "server"
1728 argument since they are always client side
1730 * dbus/dbus-server.c (dbus_server_get_address): new function
1732 * bus/main.c (main): take the configuration file as an argument.
1734 * test/data/valid-config-files/debug-allow-all.conf: new file to
1735 use with dispatch.c tests for example
1737 * bus/test-main.c (main): require test data dir
1739 * bus/bus.c (bus_context_new): change this to take a
1740 configuration file name as argument
1742 * doc/config-file.txt (Elements): add <servicedir>
1744 * bus/system.conf, bus/session.conf: new files
1746 * dbus/dbus-bus.c (dbus_bus_get): look for system bus on
1747 well-known socket if none set
1749 * configure.in: create system.conf and session.conf
1751 2003-03-30 Havoc Pennington <hp@pobox.com>
1753 * bus/config-parser.c: hacking
1755 * dbus/dbus-memory.c: don't use DBusList for the list of stuff
1756 to shut down, since it could cause weirdness with the DBusList
1759 * dbus/dbus-list.c (_dbus_list_test): add tests for the
1760 link-oriented stack routines
1761 (alloc_link): free the mempool if the first alloc from it fails
1763 * dbus/dbus-mempool.c (struct DBusMemBlock): fix alignment issue
1765 * dbus/dbus-string.c (UNICODE_VALID): sync new version of this
1767 (_dbus_string_skip_white): new
1769 * doc/config-file.txt (Elements): add <includedir>
1771 2003-03-28 Havoc Pennington <hp@pobox.com>
1773 * dbus/dbus-string.c (_dbus_string_copy_data_len)
1774 (_dbus_string_copy_data): new functions
1776 2003-03-28 Anders Carlsson <andersca@codefactory.se>
1778 * dbus/dbus-bus.c: (bus_data_free), (dbus_bus_get):
1782 * dbus/dbus-memory.c:
1785 2003-03-28 Havoc Pennington <hp@pobox.com>
1787 * bus/test.c (bus_test_flush_bus): remove the sleep from here,
1788 I think it may have just been superstition. Not sure.
1790 * dbus/dbus-string.c (_dbus_string_base64_decode): catch some OOM
1791 failures that were not being handled.
1793 * dbus/dbus-auth.c (process_auth): fix a memleak in OOM handling
1795 * dbus/dbus-memory.c: add ability to set number of mallocs in a
1796 row that will fail on out-of-memory.
1798 * dbus/dbus-internals.c (_dbus_test_oom_handling): convenience
1799 function for testing out-of-memory handling.
1801 * bus/config-loader-expat.c (memsuite): don't wrap the dbus
1802 allocation functions, they do map exactly to the expat ones.
1804 2003-03-27 Havoc Pennington <hp@redhat.com>
1806 * bus/config-loader-libxml.c (bus_config_load): add another error
1809 2003-03-26 Anders Carlsson <andersca@codefactory.se>
1812 Add note about automatic service activation.
1814 * doc/dbus-specification.sgml:
1815 Rename the specification and clarify a few things.
1817 2003-03-26 Anders Carlsson <andersca@codefactory.se>
1820 * dbus/dbus-address.c:
1822 * dbus/dbus-marshal.c:
1823 * dbus/dbus-server-debug-pipe.c:
1824 * dbus/dbus-transport-unix.c:
1825 Fix documentation warnings.
1827 2003-03-26 Havoc Pennington <hp@pobox.com>
1829 * bus/test-main.c, dbus/dbus-test.c (main): check memleaks
1830 after every test so it's quick and easy to see which leaked, and
1831 so we test multiple dbus_shutdown() calls
1833 * configure.in: change configure.in XML stuff to also support
1836 * config-loader-libxml.c: some hacking
1838 * config-loader-expat.c: some hacking
1840 * config-parser.c: some hacking, plus tests
1842 2003-03-25 Havoc Pennington <hp@redhat.com>
1844 * throughout - add more _DBUS_ASSERT_ERROR_IS_CLEAR
1846 * configure.in: add --with-xml option to specify XML library,
1847 right now only libxml is supported.
1849 * bus/config-loader-libxml.c, config-parser.c: sync some minor
1850 nonworking code between home and work, still just stubs
1852 2003-03-24 Havoc Pennington <hp@redhat.com>
1854 * dbus/dbus-sysdeps.c (_dbus_set_fd_nonblocking): move to this
1857 * dbus/dbus-errors.c (dbus_set_error, dbus_set_error_const): allow
1858 NULL argument for "message" if the error is a well-known one,
1859 fill in a generic message in this case.
1861 * dbus/dbus-errors.h (DBusResultCode): Kill DBusResultCode in
1864 * bus/test.c (bus_test_flush_bus): add
1866 * bus/policy.c (bus_policy_test): test code stub
1868 2003-03-24 Havoc Pennington <hp@pobox.com>
1870 * bus/connection.c (bus_connections_setup_connection): set up
1871 the "can this user connect" function, but it always returns
1872 TRUE until we have a config file parser so we can have a config
1873 file that allows connections.
1875 2003-03-23 Havoc Pennington <hp@pobox.com>
1877 * dbus/dbus-threads.c (dbus_mutex_new, dbus_condvar_new): with
1878 DBUS_BUILD_TESTS, actually alloc/free a block of memory for
1879 the mutex, so we can check for proper memory management
1882 * dbus/dbus-dataslot.c: remove the mutex from
1883 DBusDataSlotAllocator and lock it manually when using it,
1884 to simplify fitting it into the global slots framework.
1886 * dbus/dbus-threads.c (init_static_locks): rework how we're
1887 handling global locks so they are easily shut down.
1889 * bus/policy.c (bus_policy_append_rule): fix
1891 * bus/test-main.c (main): check for memleaks
1893 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): make
1894 test suite check for memleaks
1896 * dbus/dbus-memory.c: add support in test mode for tracking
1897 number of outstanding blocks
1899 2003-03-23 Havoc Pennington <hp@pobox.com>
1901 * bus/policy.c, bus/bus.c, bus/connection.c: implement allow/deny
1904 * dbus/dbus-hash.h: add ULONG hash keys
1906 * dbus/dbus-sysdeps.c (_dbus_get_groups): new
1907 (_dbus_get_group_id): new function
1909 2003-03-20 Havoc Pennington <hp@redhat.com>
1911 * dbus/dbus-connection.c (dbus_connection_set_unix_user_function):
1913 (dbus_connection_get_unix_user): new function
1915 2003-03-20 Havoc Pennington <hp@pobox.com>
1917 * bus/connection.c (bus_connection_send_oom_error): assert that
1918 message has a sender
1919 (connection_execute_transaction): ditto
1920 (bus_connection_preallocate_oom_error): fix to set the sender, and
1921 set recipient to the destination service, not the bus driver
1923 * bus/policy.c: hacking
1925 * dbus/dbus-message.c (dbus_message_service_is): new function
1926 (dbus_message_sender_is): new
1928 2003-03-19 Havoc Pennington <hp@redhat.com>
1930 * bus/policy.c: start sketching code for policy restrictions on
1931 what connections can do.
1933 2003-03-18 Havoc Pennington <hp@redhat.com>
1935 * doc/TODO: some notes on high-level todo items. Little nitpick
1936 stuff is all in @todo, so no need to add it here.
1938 * doc/config-file.txt: some notes on how config file might look
1940 2003-03-18 Anders Carlsson <andersca@codefactory.se>
1946 2003-03-17 Havoc Pennington <hp@redhat.com>
1948 * dbus/dbus-internals.h: add gcc attributes so that
1949 our printf-style functions warn on bad arguments to
1952 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): fix printf
1955 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
1958 2003-03-17 Havoc Pennington <hp@redhat.com>
1960 * bus/test-main.c (main): make it print something as it runs
1961 so make check doesn't look stuck
1963 * doc/negotiation.txt, doc/dbus-sasl-profile.txt: remove
1964 from CVS, now obsolete
1966 2003-03-17 Anders Carlsson <andersca@codefactory.se>
1968 * bus/dispatch.c: (bus_dispatch):
1969 Refetch the service name since it may have been reallocated
1970 when dbus_message_set_sender was called.
1972 * dbus/dbus-sysdeps.c: (_dbus_accept):
1973 Add address and address length variables and use them to stop
1974 valgrind from complaining.
1976 2003-03-17 Havoc Pennington <hp@pobox.com>
1978 All tests pass, no memleaks, no valgrind complaints.
1980 * bus/test.c: refcount handler_slot
1982 * bus/connection.c (bus_connections_new): refcount
1983 connection_data_slot
1985 * dbus/dbus-auth-script.c (_dbus_auth_script_run): delete unused
1986 bytes so that auth scripts pass.
1988 * bus/dispatch.c: init message_handler_slot so it gets allocated
1991 * bus/dispatch.c (message_handler_slot_ref): fix memleak
1993 * dbus/dbus-server-debug-pipe.c (_dbus_server_debug_pipe_new):
1994 dealloc server_pipe_hash when no longer used for benefit of
1997 * dbus/dbus-auth.c (process_command): memleak fix
1999 * bus/dispatch.c (check_hello_message): memleak fix
2001 2003-03-16 Havoc Pennington <hp@pobox.com>
2003 * dbus/dbus-bus.c (ensure_bus_data): fix double-unref of the data slot
2005 2003-03-17 Anders Carlsson <andersca@codefactory.se>
2007 * bus/activation.c (bus_activation_activate_service): Append
2008 the pending activation entry to the list of pending activations.
2010 2003-03-16 Havoc Pennington <hp@pobox.com>
2012 * bus/dispatch.c (bus_dispatch_test): remove double-unrefs of
2015 * dbus/dbus-address.c (create_entry): fix OOM handling when
2016 failing to alloc entry->method
2018 2003-03-16 Havoc Pennington <hp@pobox.com>
2020 * dbus/dbus-watch.c (_dbus_watch_new): handle failure to malloc
2023 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
2024 add some missing dbus_set_result
2026 * bus/dispatch.c (bus_dispatch_add_connection): handle failure to
2027 alloc the DBusMessageHandler
2029 * dbus/dbus-transport.c (_dbus_transport_disconnect): don't ref
2030 the transport here, since we call this from the finalizer; it
2031 resulted in a double-finalize.
2033 * dbus/dbus-transport.c (_dbus_transport_disconnect): fix a bug
2034 where we tried to use transport->connection that was NULL,
2035 happened when transport was disconnected early on due to OOM
2037 * bus/*.c: adapt to handle OOM for watches/timeouts
2039 * dbus/dbus-transport-unix.c: port to handle OOM during
2042 * dbus/dbus-auth.c (_dbus_auth_get_unused_bytes): return a
2043 reference to unused bytes instead of a copy
2045 * dbus/dbus-server.c (dbus_server_handle_watch): return FALSE for
2048 * dbus/dbus-connection.c (dbus_connection_handle_watch): return
2051 * dbus/dbus-timeout.c (dbus_timeout_handle): return FALSE for out
2054 2003-03-16 Anders Carlsson <andersca@codefactory.se>
2056 * doc/dbus-specification.sgml:
2057 Document reply message for ActivateService.
2059 2003-03-16 Anders Carlsson <andersca@codefactory.se>
2061 * bus/activation.c: (bus_pending_activation_entry_free),
2062 (bus_pending_activation_free), (bus_activation_new),
2063 (bus_activation_unref), (bus_activation_service_created),
2064 (bus_activation_activate_service):
2066 * bus/bus.c: (bus_context_new):
2067 * bus/desktop-file.c: (new_section):
2068 * bus/driver.c: (bus_driver_send_service_deleted),
2069 (bus_driver_handle_activate_service):
2070 * bus/services.c: (bus_registry_new), (bus_registry_ensure):
2072 * dbus/dbus-connection.c:
2073 (dbus_connection_send_with_reply_and_block):
2074 * dbus/dbus-message.c: (dbus_message_append_args_valist):
2075 * dbus/dbus-protocol.h:
2076 Make activation work better. Now pending activations will be queued
2077 and the daemon won't try to activate services that are already registered.
2079 2003-03-16 Havoc Pennington <hp@pobox.com>
2081 * dbus/dbus-bus.c (ensure_bus_data): handle failure to set
2084 * dbus/dbus-memory.c (_dbus_initialize_malloc_debug): support
2085 DBUS_MALLOC_BACKTRACES to print trace when failing an alloc
2087 2003-03-16 Havoc Pennington <hp@pobox.com>
2089 * dbus/dbus-string.c (_dbus_string_validate_utf8): oops, unbreak
2090 this. always run the test suite before commit...
2092 * bus/*: adapt to DBusConnection API changes
2094 * glib/dbus-gmain.c: adapt to DBusConnection API changes,
2095 requires renaming stuff to avoid dbus_connection_dispatch name
2098 * dbus/dbus-transport.c (_dbus_transport_queue_messages): new
2101 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
2102 separate from _dbus_message_loader_return_buffer()
2104 * dbus/dbus-connection.c (dbus_connection_get_n_messages): remove
2105 this, because it's now always broken to use; the number of
2106 messages in queue vs. the number still buffered by the message
2107 loader is undefined/meaningless. Should use
2108 dbus_connection_get_dispatch_state().
2109 (dbus_connection_dispatch): rename from
2110 dbus_connection_dispatch_message
2112 2003-03-16 Havoc Pennington <hp@pobox.com>
2114 * dbus/dbus-string.c (_dbus_string_validate_utf8): copy in a real
2117 2003-03-16 Anders Carlsson <andersca@codefactory.se>
2119 * dbus/dbus-connection.c:
2120 (dbus_connection_send_with_reply_and_block):
2121 Decrease connection->n_incoming when removing an entry
2123 * dbus/dbus-dict.c: (dbus_dict_entry_free),
2124 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
2125 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
2126 (dbus_dict_set_byte_array), (dbus_dict_set_string_array),
2127 (dbus_dict_get_boolean_array), (dbus_dict_get_double_array),
2128 (dbus_dict_get_byte_array):
2129 Handle NULL arrays and strings. Also add support for byte arrays.
2131 * dbus/dbus-marshal.c: (_dbus_marshal_byte_array),
2132 (_dbus_marshal_dict), (_dbus_demarshal_byte_array),
2133 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
2134 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
2135 (_dbus_demarshal_dict), (demarshal_and_validate_len),
2136 (_dbus_marshal_validate_arg), (_dbus_marshal_test):
2137 * dbus/dbus-marshal.h:
2138 Add support for marshalling and demarshalling empty arrays and strings.
2140 * dbus/dbus-message.c: (dbus_message_append_args_valist),
2141 (dbus_message_append_string_array),
2142 (dbus_message_iter_get_boolean),
2143 (dbus_message_iter_get_boolean_array),
2144 (dbus_message_iter_get_int32_array),
2145 (dbus_message_iter_get_uint32_array),
2146 (dbus_message_iter_get_double_array),
2147 (dbus_message_iter_get_byte_array),
2148 (dbus_message_iter_get_string_array), (dbus_message_iter_get_dict),
2149 (check_message_handling):
2150 Add support for getting empty arrays and dicts.
2152 * dbus/dbus-string.c: (_dbus_string_validate_utf8):
2153 Don't do any validation at all for now, that's better than just checking
2156 * test/data/valid-messages/emptiness.message:
2157 New test message with lots of empty arrays.
2159 2003-03-16 Havoc Pennington <hp@pobox.com>
2161 * dbus/dbus-connection.c
2162 (_dbus_connection_queue_received_message_link): new function that
2163 can't fail due to OOM
2165 * dbus/dbus-message.c (_dbus_message_loader_pop_message_link):
2166 new function pops a message together with a list link
2169 * dbus/dbus-transport-unix.c (queue_messages): use new link-based
2170 message queuing functions to avoid needing to alloc memory
2172 2003-03-16 Havoc Pennington <hp@pobox.com>
2174 Oops - test code was only testing failure of around 30 of the
2175 mallocs in the test path, but it turns out there are 500+
2176 mallocs. I believe this was due to misguided linking setup such
2177 that there was one copy of dbus_malloc etc. in the daemon and one
2178 in the shared lib, and only daemon mallocs were tested. In any
2179 case, the test case now tests all 500+ mallocs, and doesn't pass
2180 yet, though there are lots of fixes in this patch.
2182 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
2183 this so that it doesn't need to allocate memory, since it
2184 has no way of indicating failure due to OOM (and would be
2185 annoying if it did).
2187 * dbus/dbus-list.c (_dbus_list_pop_first_link): new function
2189 * bus/Makefile.am: rearrange to create two self-contained
2190 libraries, to avoid having libraries with overlapping symbols.
2191 that was resulting in weirdness, e.g. I'm pretty sure there
2192 were two copies of global static variables.
2194 * dbus/dbus-internals.c: move the malloc debug stuff to
2197 * dbus/dbus-list.c (free_link): free list mempool if it becomes
2200 * dbus/dbus-memory.c (_dbus_disable_mem_pools): new function
2202 * dbus/dbus-address.c (dbus_parse_address): free list nodes
2205 * bus/dispatch.c (bus_dispatch_add_connection): free
2206 message_handler_slot when no longer using it, so
2207 memory leak checkers are happy for the test suite.
2209 * dbus/dbus-server-debug-pipe.c (debug_finalize): free server name
2211 * bus/bus.c (new_connection_callback): disconnect in here if
2212 bus_connections_setup_connection fails.
2214 * bus/connection.c (bus_connections_unref): fix to free the
2216 (bus_connections_setup_connection): if this fails, don't
2217 disconnect the connection, just be sure there are no side
2220 * dbus/dbus-string.c (undo_alignment): unbreak this
2222 * dbus/dbus-auth.c (_dbus_auth_unref): free some stuff we were
2224 (_dbus_auth_new): fix the order in which we free strings
2227 * bus/connection.c (bus_connection_disconnected): fix to
2228 not send ServiceDeleted multiple times in case of memory
2231 * dbus/dbus-bus.c (dbus_bus_get_base_service): new function to
2232 get the base service name
2233 (dbus_bus_register_client): don't return base service name,
2234 instead store it on the DBusConnection and have an accessor
2236 (dbus_bus_register_client): rename dbus_bus_register()
2238 * bus/dispatch.c (check_hello_message): verify that other
2239 connections on the bus also got the correct results, not
2240 just the one sending hello
2242 2003-03-15 Havoc Pennington <hp@pobox.com>
2244 Make it pass the Hello handling test including all OOM codepaths.
2245 Now to do other messages...
2247 * bus/services.c (bus_service_remove_owner): fix crash when
2248 removing owner from an empty list of owners
2249 (bus_registry_ensure): don't leave service in the list of
2250 a connection's owned services if we fail to put the service
2253 * bus/connection.c (bus_connection_preallocate_oom_error): set
2254 error flag on the OOM error.
2256 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
2257 handle _dbus_transport_set_connection failure
2259 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd): modify
2260 to create watches up front and simply enable/disable them as
2262 (unix_connection_set): this can now fail on OOM
2264 * dbus/dbus-timeout.c, dbus/dbus-watch.c: add concept
2265 of enabling/disabling a watch or timeout.
2267 * bus/loop.c (bus_loop_iterate): don't touch disabled
2270 * glib/dbus-gmain.c: adapt to enable/disable watches and timeouts
2272 2003-03-15 Havoc Pennington <hp@pobox.com>
2274 * bus/dispatch.c (bus_dispatch_test): OK, now finally actually
2275 write useful test code, after all that futzing around ;-)
2277 Test does not yet pass because we can't handle OOM in
2278 _dbus_transport_messages_pending (basically,
2279 dbus_connection_preallocate_send() does not prealloc the write
2280 watch). To fix this, I think we need to add new stuff to
2281 set_watch_functions, namely a SetEnabled function so we can alloc
2282 the watch earlier, then enable it later.
2284 * dbus/Makefile.am (libdbus_convenience_la_SOURCES): move
2285 dbus-memory.c to the convenience lib
2287 * bus/test.c: rename some static functions to keep them clearly
2288 distinct from stuff in connection.c. Handle client disconnection.
2290 2003-03-14 Havoc Pennington <hp@pobox.com>
2292 * bus/dispatch.c (bus_dispatch_test): do test using debug-pipe
2293 transport, tests more of the real codepath. Set up clients
2294 with bus_setup_debug_client.
2296 * bus/test.c (bus_setup_debug_client): function to set up debug
2297 "clients" on the main loop
2299 * dbus/dbus-transport.c (_dbus_transport_open): add debug-pipe
2302 * dbus/dbus-server.c (dbus_server_listen): add debug-pipe
2305 * dbus/dbus-server-debug.c: support a debug server based on pipes
2307 * dbus/dbus-sysdeps.c (_dbus_full_duplex_pipe): new function
2308 (_dbus_close): new function
2310 * configure.in: check for socketpair
2312 2003-03-14 Havoc Pennington <hp@redhat.com>
2314 * dbus/dbus-memory.c: add a "detect buffer overwrites on free"
2317 * dbus/dbus-transport-debug.c: rework this a good bit to be
2318 less complicated. hopefully still works.
2320 * dbus/dbus-server-debug.c (handle_new_client): remove timeout
2323 * glib/dbus-gmain.c (timeout_handler): don't remove timeout
2326 * dbus/dbus-message.c (dbus_message_copy): rename from
2327 dbus_message_new_from_message, fix it up to copy
2328 all the message fields, add test case
2330 * bus/dispatch.c (bus_dispatch_test): add some more test code,
2331 not quite passing yet
2333 2003-03-14 Havoc Pennington <hp@pobox.com>
2335 * bus/loop.c (bus_loop_iterate): add this so we can "run loop
2336 until no work remains" in test code. (the large diff here
2337 is just code movement, no actual changes)
2339 * dbus/dbus-server-debug.c (DEFAULT_INTERVAL): change interval to
2340 1, no point waiting around for test code.
2341 (_dbus_server_debug_accept_transport): unref the timeout
2342 after adding it (right?)
2344 * dbus/dbus-transport-debug.c (DEFAULT_INTERVAL): ditto
2346 2003-03-13 Havoc Pennington <hp@redhat.com>
2348 * dbus/dbus-timeout.c (_dbus_timeout_list_set_functions): handle
2351 * dbus/dbus-watch.c (_dbus_watch_list_set_functions): handle out
2354 * dbus/dbus-connection.h: Make AddWatchFunction and
2355 AddTimeoutFunction return a bool so they can fail on out-of-memory
2357 * bus/bus.c (bus_context_new): set up timeout handlers
2359 * bus/connection.c (bus_connections_setup_connection): set up
2362 * glib/dbus-gmain.c: adapt to the fact that set_functions stuff
2365 * bus/bus.c (bus_context_new): adapt to changes
2367 * bus/connection.c: adapt to changes
2369 * test/watch.c: adapt to DBusWatch changes
2371 * bus/dispatch.c (bus_dispatch_test): started adding this but
2374 2003-03-14 Anders Carlsson <andersca@codefactory.se>
2376 * bus/dispatch.c (send_service_nonexistent_error): Fix typo.
2378 2003-03-13 Havoc Pennington <hp@pobox.com>
2380 * bus/test.c, bus/test.h, bus/Makefile.am, bus/test-main.c:
2381 set up a test framework as for the library
2383 2003-03-12 Havoc Pennington <hp@pobox.com>
2385 Throughout: purge global variables, introduce BusActivation,
2386 BusConnections, BusRegistry, etc. objects instead.
2388 * bus/bus.h, bus/bus.c: introduce BusContext as a global
2391 * test/Makefile.am (TEST_BINARIES): disable bus-test for now,
2392 going to redo this a bit differently I think
2394 2003-03-12 Havoc Pennington <hp@redhat.com>
2396 Mega-patch that gets the message bus daemon initially handling
2397 out-of-memory. Work still needed. Also lots of random
2398 moving stuff to DBusError instead of ResultCode.
2400 * dbus/dbus-list.c (_dbus_list_length_is_one): new function
2402 * dbus/dbus-connection.c
2403 (dbus_connection_send_with_reply_and_block): use DBusError
2405 * dbus/dbus-bus.c: adapt to API changes, make it use DBusError not
2408 * dbus/dbus-connection.c (dbus_connection_send): drop the result
2409 code here, as the only failure possible is OOM.
2411 * bus/connection.c (bus_connection_disconnect):
2412 rename bus_connection_disconnected as it's a notification only
2414 * bus/driver.c (bus_driver_handle_acquire_service): don't free
2415 "name" on get_args failure, should be done by get_args;
2416 don't disconnect client for bad args, just return an error.
2417 (bus_driver_handle_service_exists): ditto
2419 * bus/services.c (bus_services_list): NULL-terminate returned array
2421 * bus/driver.c (bus_driver_send_service_lost)
2422 (bus_driver_send_service_acquired): send messages from driver to a
2423 specific client to the client's unique name, not to the broadcast
2426 * dbus/dbus-message.c (decode_header_data): reject messages that
2427 contain no name field
2428 (_dbus_message_get_client_serial): rename to
2429 dbus_message_get_serial and make public
2430 (_dbus_message_set_serial): rename from set_client_serial
2431 (_dbus_message_set_reply_serial): make public
2432 (_dbus_message_get_reply_serial): make public
2434 * bus/connection.c (bus_connection_foreach): allow stopping
2435 iteration by returning FALSE from foreach function.
2437 * dbus/dbus-connection.c (dbus_connection_send_preallocated)
2438 (dbus_connection_free_preallocated_send)
2439 (dbus_connection_preallocate_send): new API for sending a message
2440 without possibility of malloc failure.
2441 (dbus_connection_send_message): rename to just
2442 dbus_connection_send (and same for whole function family)
2444 * dbus/dbus-errors.c (dbus_error_free): make this reinit the error
2446 * dbus/dbus-sysdeps.c (_dbus_exit): new function
2448 * bus/activation.c: handle/return errors
2450 * dbus/dbus-errors.h: add more DBUS_ERROR #define
2452 * dbus/dbus-sysdeps.c (_dbus_directory_open) (_dbus_file_get_contents)
2453 (_dbus_directory_get_next_file): use DBusError instead of DBusResultCode
2454 (_dbus_result_from_errno): move to this file
2456 2003-03-10 Anders Carlsson <andersca@codefactory.se>
2458 * dbus/dbus-marshal.c:
2459 (_dbus_marshal_set_string):
2460 Take a length argument so we can marshal the correct string
2463 (_dbus_marshal_dict), (_dbus_demarshal_dict),
2464 (_dbus_marshal_get_arg_end_pos), (_dbus_marshal_validate_arg),
2465 (_dbus_marshal_test):
2466 * dbus/dbus-marshal.h:
2467 Add support for marshalling and demarshalling dicts.
2469 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
2470 Add support for TYPE DICT.
2472 * dbus/dbus-message.c: (set_string_field):
2473 Adjust header padding.
2475 (dbus_message_append_args_valist), (dbus_message_append_dict),
2476 (dbus_message_get_args_valist), (dbus_message_iter_get_arg_type),
2477 (dbus_message_iter_get_dict), (_dbus_message_loader_return_buffer),
2478 (check_message_handling), (check_have_valid_message):
2479 * dbus/dbus-message.h:
2480 Add functions for setting and getting dicts.
2482 * dbus/dbus-protocol.h:
2488 * doc/dbus-specification.sgml:
2489 Add information about how dicts are marshalled.
2491 * test/data/invalid-messages/dict-with-nil-value.message:
2492 * test/data/invalid-messages/too-short-dict.message:
2493 * test/data/valid-messages/dict-simple.message:
2494 * test/data/valid-messages/dict.message:
2495 Add sample messages containing dicts.
2497 2003-03-08 Anders Carlsson <andersca@codefactory.se>
2499 * dbus/dbus-dict.h: Add DBUS_END_DECLS.
2501 2003-03-07 Anders Carlsson <andersca@codefactory.se>
2504 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
2505 (dbus_dict_get_keys), (insert_entry), (dbus_dict_set_boolean),
2506 (dbus_dict_set_int32), (dbus_dict_set_uint32),
2507 (dbus_dict_set_double), (dbus_dict_set_string),
2508 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
2509 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
2510 (dbus_dict_set_string_array), (_dbus_dict_test):
2512 Fix according to comments from Havoc.
2514 2003-03-06 Michael Meeks <michael@server.home>
2516 * configure.in: if we don't have kde-config, disable have_qt.
2518 2003-03-07 Anders Carlsson <andersca@codefactory.se>
2523 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
2524 (dbus_dict_ref), (dbus_dict_unref), (dbus_dict_contains),
2525 (dbus_dict_remove), (dbus_dict_get_value_type),
2526 (dbus_dict_get_keys), (dbus_dict_put_boolean),
2527 (dbus_dict_put_int32), (dbus_dict_put_uint32),
2528 (dbus_dict_put_double), (dbus_dict_put_string),
2529 (dbus_dict_put_boolean_array), (dbus_dict_put_int32_array),
2530 (dbus_dict_put_uint32_array), (dbus_dict_put_double_array),
2531 (dbus_dict_put_string_array), (dbus_dict_get_boolean),
2532 (dbus_dict_get_int32), (dbus_dict_get_uint32),
2533 (dbus_dict_get_double), (dbus_dict_get_string),
2534 (dbus_dict_get_boolean_array), (dbus_dict_get_int32_array),
2535 (dbus_dict_get_uint32_array), (dbus_dict_get_double_array),
2536 (dbus_dict_get_string_array), (_dbus_dict_test):
2538 Add DBusDict implementation
2540 * dbus/dbus-test.c: (dbus_internal_do_not_use_run_tests):
2544 2003-03-04 Havoc Pennington <hp@pobox.com>
2546 * test/data/auth/*: adapt to changes
2548 * dbus/dbus-auth-script.c (_dbus_auth_script_run): add
2549 USERID_BASE64 and change USERNAME_BASE64 to put in username not
2552 * dbus/dbus-keyring.c (_dbus_keyring_validate_context): prevent
2553 more stuff from being in a context name, to make the protocol
2554 simpler to deal with
2556 * dbus/dbus-errors.c (dbus_error_has_name): new function
2557 (dbus_error_is_set): new function
2559 * dbus/dbus-auth.c: replace DBUS_STUPID_TEST_MECH auth
2560 with DBUS_COOKIE_SHA1, implement DBUS_COOKIE_SHA1
2562 * dbus/dbus-connection.c (dbus_connection_flush): also read
2563 messages during a flush operation
2565 * dbus/Makefile.am: remove dbus-md5 since it isn't currently used.
2567 2003-03-05 Anders Carlsson <andersca@codefactory.se>
2569 * configure.in: Check for gethostbyname on Solaris.
2571 * dbus/dbus-transport.c: (_dbus_transport_open):
2572 Remove duplicate "tcp" entry.
2574 * doc/dbus-specification.sgml:
2575 Clarify some things.
2577 2003-03-05 Anders Carlsson <andersca@codefactory.se>
2579 * dbus/dbus-auth.c: (send_rejected), (process_test_subdir):
2580 * dbus/dbus-keyring.c: (_dbus_keyring_new_homedir),
2581 (_dbus_keyring_test):
2582 * dbus/dbus-md5.c: (_dbus_md5_compute):
2583 * dbus/dbus-sha.c: (_dbus_sha_compute):
2586 2003-03-05 Anders Carlsson <andersca@codefactory.se>
2588 * README: Add some things.
2590 2003-03-04 Anders Carlsson <andersca@codefactory.se>
2592 * dbus/dbus-message.c (dbus_message_append_args_valist): Add a break;
2593 after case DBUS_TYPE_BOOELAN.
2595 2003-03-02 Havoc Pennington <hp@pobox.com>
2597 * test/break-loader.c (randomly_set_extreme_ints): add test that
2598 sets really huge and small integers
2600 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add check
2601 that length of boolean array fits in the string, and that
2602 string has room for boolean value in single-bool case.
2604 * dbus/dbus-message-builder.c (_dbus_message_data_load): add
2605 optional value to "ALIGN" command which is what to fill the
2608 * test/data/valid-messages/no-padding.message: add regression
2609 test for the message padding problem
2611 2003-03-02 Havoc Pennington <hp@pobox.com>
2613 * dbus/dbus-message.c (decode_header_data): fix to always init
2614 message_padding, from Benjamin Dauvergne
2616 2003-03-02 Havoc Pennington <hp@pobox.com>
2622 2003-03-01 Joe Shaw <joe@assbarn.com>
2624 * configure.in: Check for "struct cmsgcred" and try to access its
2625 members for BSD-like unices.
2627 * dbus/dbus-sysdeps.c (read_credentials_byte): Fold this back into
2628 _dbus_read_credentials_unix_socket().
2629 (_dbus_read_credentials_unix_socket): Use recvmsg() instead of
2630 read() for reading the credential byte off the unix socket. Use
2631 struct cmsgcred on systems that support it.
2633 2003-02-27 Alexander Larsson <alexl@redhat.com>
2637 Make gthreads-2.0 dependency optional. Don't build thread test if
2640 2003-02-27 Havoc Pennington <hp@pobox.com>
2642 * dbus/dbus-connection.c
2643 (dbus_connection_send_message_with_reply_and_block): fix doh!
2644 doh! doh! bug that resulted in never removing a reply from the
2645 queue, no wonder we called get_reply_serial so much ;-)
2647 * dbus/dbus-message.c (struct DBusMessage): cache reply serial
2648 and client serial instead of demarshaling them every time
2650 2003-02-27 Havoc Pennington <hp@pobox.com>
2652 * dbus/dbus-marshal.c (_dbus_demarshal_int32): rewrite to be much
2653 more inlined, using dbus-string-private.h, speeds things up
2656 * dbus/dbus-string.c (_dbus_string_free): apply align offset
2657 when freeing the string
2658 (_dbus_string_steal_data): fix for align offset
2659 (undo_alignment): new function
2661 2003-02-26 Havoc Pennington <hp@redhat.com>
2663 All kinds of audit fixes from Owen, plus initial attempt to
2664 handle unaligned memory returned from malloc.
2666 * dbus/dbus-string.c (_dbus_string_init): clamp max length to
2667 leave room for align_offset and nul byte
2668 (fixup_alignment): function to track an align_offset and
2669 ensure real->str is aligned
2670 (DBUS_GENERIC_STRING_PREAMBLE): len must be less than allocated,
2671 to allow a nul byte plus align offset
2672 (_dbus_string_lock): fix overflow issue
2673 (_dbus_string_init_const_len): add assertions on sanity of len,
2674 assign allocated to be ALLOCATION_PADDING larger than len
2675 (set_length): fixup the overflow handling
2676 (_dbus_string_get_data_len): fix overflow in assertion
2677 (open_gap): detect overflow in size of gap to be opened
2678 (_dbus_string_lengthen): add overflow check
2679 (_dbus_string_align_length): fix overflow with _DBUS_ALIGN_VALUE
2680 (_dbus_string_append): add overflow check
2681 (_dbus_string_append_unichar): overflow
2682 (_dbus_string_delete): fix overflow in assertion
2683 (_dbus_string_copy_len): overflow in assertion
2684 (_dbus_string_replace_len): overflows in assertions
2685 (_dbus_string_find): change to implement in terms of
2686 _dbus_string_find_to
2687 (_dbus_string_find_to): assorted fixage
2688 (_dbus_string_equal_c_str): assert c_str != NULL,
2689 fix logic so the function works
2690 (_dbus_string_ends_with_c_str): fix overflow thingy
2691 (_dbus_string_base64_encode): overflow fix
2692 (_dbus_string_validate_ascii): overflow
2693 (_dbus_string_validate_nul): overflow
2695 2003-02-26 Havoc Pennington <hp@redhat.com>
2697 * dbus/dbus-marshal.c (_dbus_marshal_test): fix to work with DISABLE_ASSERTS
2699 2003-02-26 Alexander Larsson <alexl@redhat.com>
2702 Set DBUS_GLIB_THREADS_LIBS for apps using gthread-2.0
2704 * dbus/dbus-connection.c:
2705 * dbus/dbus-connection.h:
2706 Fix _dbus_connection_acquire_io_path and _dbus_connection_acquire_dispatch.
2707 Add dbus_connection_set_wakeup_main_function and use it when queueing
2708 incoming and outgoing messages.
2711 * dbus/dbus-dataslot.c:
2712 Threadsafe usage of DBusDataSlotAllocator
2714 * dbus/dbus-message.c: (dbus_message_get_args_iter):
2717 * dbus/dbus-server-unix.c:
2720 * glib/dbus-gmain.c:
2721 Implement the new wakeup functions for glib.
2724 * glib/test-thread-client.c:
2725 * glib/test-thread-server.c:
2726 * glib/test-thread.h:
2727 Initial cut at some thread test code. Not really done yet.
2729 2003-02-26 Havoc Pennington <hp@pobox.com>
2731 * dbus/dbus-connection.c
2732 (dbus_connection_send_message_with_reply_and_block): fix crash
2733 where we ref'd the outgoing message instead of the returned reply
2735 * dbus/dbus-transport-unix.c (do_authentication): check read watch
2736 at the end of this function, so if we didn't need to read for
2737 authentication, we reinstall it for receiving messages
2739 * dbus/dbus-message.c (dbus_message_new_reply): allow replies to
2740 a NULL sender for peer-to-peer case
2742 * dbus/dbus-transport-unix.c (check_read_watch): handle
2743 !authenticated case correctly
2745 * glib/dbus-gmain.c: add support for DBusServer
2747 * dbus/dbus-server.c: add data slot support
2749 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): check
2750 return values and handle errors
2752 * dbus/dbus-dataslot.c: factor out the data slot stuff from
2755 * Doxyfile.in (INPUT): add glib subdir
2757 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): rename
2758 setup_with_g_main instead of hookup_with_g_main; write docs
2760 2003-02-24 Anders Carlsson <andersca@codefactory.se>
2762 * dbus/dbus-marshal.c: (_dbus_marshal_validate_arg):
2763 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
2764 * dbus/dbus-message.c: (dbus_message_append_boolean),
2765 (dbus_message_append_boolean_array),
2766 (dbus_message_get_args_valist), (_dbus_message_test):
2767 * dbus/dbus-message.h:
2768 * doc/dbus-specification.sgml:
2769 Various fixes as pointed out by Havoc.
2771 * test/data/invalid-messages/bad-boolean-array.message:
2772 * test/data/invalid-messages/bad-boolean.message:
2773 Add invalid boolean value test cases.
2775 2003-02-24 Anders Carlsson <andersca@codefactory.se>
2777 * dbus/dbus-internals.c: (_dbus_type_to_string):
2778 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
2779 (_dbus_marshal_validate_arg):
2780 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
2781 * dbus/dbus-message.c: (dbus_message_append_args_valist),
2782 (dbus_message_append_boolean), (dbus_message_append_boolean_array),
2783 (dbus_message_get_args_valist), (dbus_message_iter_get_boolean),
2784 (dbus_message_iter_get_int32), (dbus_message_iter_get_uint32),
2785 (dbus_message_iter_get_double),
2786 (dbus_message_iter_get_boolean_array), (message_iter_test):
2787 * dbus/dbus-message.h:
2788 * dbus/dbus-protocol.h:
2789 * doc/dbus-specification.sgml:
2790 * test/data/valid-messages/lots-of-arguments.message:
2791 Add support for boolean and boolean array types.
2793 2003-02-23 Havoc Pennington <hp@pobox.com>
2795 * dbus/dbus-keyring.c: finish most of this implementation and
2798 * dbus/dbus-errors.c (dbus_set_error_const, dbus_set_error): make
2799 these barf if the error isn't cleared to NULL
2801 * dbus/dbus-sysdeps.c (_dbus_delete_file): set error on failure
2802 (_dbus_create_directory): new function
2804 * dbus/dbus-errors.c (dbus_set_error): fix warning
2806 * dbus/dbus-string.c (_dbus_string_hex_encode): new function
2807 (_dbus_string_hex_decode): new function
2808 (test_hex_roundtrip): test code
2810 * dbus/dbus-sha.c (_dbus_sha_compute): use dbus_string_hex_encode
2812 * dbus/dbus-md5.c (_dbus_md5_compute): use dbus_string_hex_encode
2814 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): make this use
2815 the save-to-temp/rename trick to atomically write the new file
2816 (_dbus_string_parse_uint): new function
2818 2003-02-22 Havoc Pennington <hp@pobox.com>
2820 * test/Makefile.am (dist-hook): fix dist for test/data/sha-1
2822 2003-02-22 Havoc Pennington <hp@pobox.com>
2824 * dbus/dbus-message.c (dbus_message_iter_get_string_array):
2825 (dbus_message_iter_get_byte_array): Fix up doxygen warnings
2827 * dbus/dbus-sha.c: add implementation of SHA-1 algorithm
2829 * dbus/test/data/sha-1: add US government test suite for SHA-1
2831 2003-02-21 Anders Carlsson <andersca@codefactory.se>
2833 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
2834 Make string arrays NULL-terminated.
2836 * dbus/dbus-memory.c: (dbus_free_string_array):
2837 * dbus/dbus-memory.h:
2838 New function for freeing NULL-terminated string arrays.
2840 * dbus/dbus-message-builder.c: (append_quoted_string),
2841 (_dbus_message_data_load):
2842 Add support for array types.
2844 * dbus/dbus-message.c: (check_message_handling):
2845 Add more types as test cases.
2847 * dbus/dbus-sysdeps.c: (_dbus_string_parse_int),
2848 (_dbus_string_parse_double):
2849 Add the start offset to the end offset.
2851 * test/data/valid-messages/lots-of-arguments.message:
2852 New test message with lots of arguments.
2854 2003-02-21 Anders Carlsson <andersca@codefactory.se>
2856 * dbus/dbus-message.c: (dbus_message_append_nil),
2857 (dbus_message_append_int32), (dbus_message_append_uint32),
2858 (dbus_message_append_double), (dbus_message_append_string),
2859 (dbus_message_append_int32_array),
2860 (dbus_message_append_uint32_array),
2861 (dbus_message_append_double_array),
2862 (dbus_message_append_byte_array),
2863 (dbus_message_append_string_array):
2864 Fix all out-of-memory handling in these functions.
2866 2003-02-21 Anders Carlsson <andersca@codefactory.se>
2868 * dbus/dbus-message.c: (dbus_message_append_nil):
2871 2003-02-21 Anders Carlsson <andersca@codefactory.se>
2873 * dbus/dbus-message.c: (dbus_message_append_args_valist),
2874 (dbus_message_append_nil), (dbus_message_append_int32_array),
2875 (dbus_message_append_uint32_array),
2876 (dbus_message_append_double_array),
2877 (dbus_message_append_byte_array),
2878 (dbus_message_append_string_array), (dbus_message_get_args_valist),
2879 (dbus_message_iter_get_int32_array),
2880 (dbus_message_iter_get_uint32_array),
2881 (dbus_message_iter_get_double_array),
2882 (dbus_message_iter_get_byte_array),
2883 (dbus_message_iter_get_string_array):
2885 * dbus/dbus-message.h:
2886 Add functions for appending and getting arrays.
2888 2003-02-21 Anders Carlsson <andersca@codefactory.se>
2890 * dbus/dbus-mempool.c (_dbus_mem_pool_new): Make the
2891 element size at least 8 bytes, fixes mempool tests on
2894 2003-02-20 Alexander Larsson <alexl@redhat.com>
2896 * dbus/dbus-transport-unix.c (unix_do_iteration):
2897 Unlock the connection mutex during a blocking select call.
2898 Add todo about how we need a way to wake up the select.
2900 * dbus/dbus-connection-internal.h:
2901 * dbus/dbus-connection.c:
2902 Add _dbus_connection_lock and _dbus_connection_unlock.
2904 2003-02-19 Havoc Pennington <hp@pobox.com>
2906 * Doxyfile.in (PREDEFINED): put DOXYGEN_SHOULD_SKIP_THIS in
2907 Doxyfile.in, not Doxyfile
2909 * dbus/dbus-keyring.c: do some hacking on this
2911 * dbus/dbus-sysdeps.c (_dbus_delete_file): new
2913 * dbus/dbus-errors.c (dbus_set_error_const): do not call
2915 (dbus_set_error): remove dbus_error_init, check for message ==
2916 NULL *before* we sprintf into it, and add @todo about including
2917 system headers in this file
2919 * dbus/dbus-sysdeps.c (_dbus_create_file_exclusively): new
2921 * dbus/dbus-errors.h (DBUS_ERROR_FAILED): add
2923 * dbus/dbus-sysdeps.c (get_user_info): break this function out to
2924 get various bits of user information based on either username
2926 (_dbus_homedir_from_username): new function
2928 2003-02-19 Anders Carlsson <andersca@codefactory.se>
2931 Add check for nonposix getpwnam_r
2933 * dbus/dbus-mempool.c: (_dbus_mem_pool_new):
2934 Align the pool element size to a sizeof (void *) boundary.
2936 * dbus/dbus-sysdeps.c: (_dbus_setenv), (_dbus_connect_unix_socket),
2937 (_dbus_listen_unix_socket), (_dbus_credentials_from_username):
2938 General Solaris fixes.
2940 * test/data/valid-messages/simplest-manual.message:
2941 Explicitly state that we want little-endian packing.
2943 2003-02-19 Mikael Hallendal <micke@codefactory.se>
2945 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
2947 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_tcp_socket):
2948 Added to create a transport connecting using a tcp/ip socket.
2950 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): Added to connect
2951 to a tcp socket at given host and port.
2952 (_dbus_listen_tcp_socket): added to listen on tcp socket for given
2955 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
2957 * dbus/dbus-server-unix.c (_dbus_server_new_for_tcp_socket):
2958 Added to create a server listening on a TCP/IP socket.
2960 2003-02-19 Havoc Pennington <hp@pobox.com>
2962 Throughout: mop up all the Doxygen warnings and undocumented
2965 * dbus/dbus-sysdeps.c (do_exec): do not use execvp, we don't want
2966 to search any paths.
2968 * dbus/dbus-threads.c: move global mutex initializers to
2969 dbus-internals.h, multiple prototypes was confusing doxygen
2970 besides being kind of ugly
2972 * Doxyfile (PREDEFINED): have Doxygen define
2973 DOXYGEN_SHOULD_SKIP_THIS so we can exclude things from
2974 docs with #ifndef DOXYGEN_SHOULD_SKIP_THIS
2975 (do not abuse the feature! it's for stuff like the autogenerated
2976 macros in dbus-md5.c, not just for things you don't feel like
2979 2003-02-18 Havoc Pennington <hp@pobox.com>
2981 * dbus/dbus-string.c (_dbus_string_zero): new function
2983 * dbus/dbus-md5.c: include MD5 implementation by L. Peter Deutsch,
2984 wrap it in some dbus-friendly API
2986 * dbus/dbus-types.h: add 16-bit types
2988 2003-02-18 Joe Shaw <joe@assbarn.com>
2990 * dbus/dbus-auth.c (handle_server_data_stupid_test_mech): Just get
2991 credentials from our currently running process.
2992 (get_word): Fix a buglet where we were copying the entire length
2993 instead of relative to our position.
2995 * dbus/dbus-hash.c (_dbus_hash_test): Don't try to allocate the
2996 keys on the stack... it's 640k of data.
2998 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): Always
2999 read the credentials byte off the socket, even if we don't have
3001 (_dbus_poll): Implement poll() using select() for systems which
3004 * glib/test-dbus-glib.c (main): Print out an error if no
3005 parameters are given.
3007 * test/data/auth/fallback.auth-script: Added. Tests that a client
3008 can fallback to a secondary auth mechanism if the first fails.
3010 2003-02-18 Havoc Pennington <hp@pobox.com>
3014 2003-02-17 Havoc Pennington <hp@pobox.com>
3016 * doc/dbus-specification.sgml: lots of cosmetic
3017 cleanups/rearrangement, add assorted FIXME, change DBUS_ADDRESS
3018 env variable to DBUS_BUS_ADDRESS, s/client/application/,
3019 s/server/bus/ (except in authentication section). Add a section
3020 "Message Bus Message Routing"
3022 2003-02-17 Anders Carlsson <andersca@codefactory.se.>
3028 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3030 * doc/dbus-specification.sgml:
3031 Specification updates.
3033 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3035 * bus/activation.c: (bus_activation_init), (child_setup),
3036 (bus_activation_activate_service):
3038 * bus/main.c: (main):
3039 Set DBUS_ADDRESS environment variable.
3041 * dbus/dbus-errors.c: (dbus_set_error):
3042 Don't use va_copy since that's a C99 feature.
3044 * dbus/dbus-sysdeps.c: (_dbus_setenv), (do_exec),
3045 (_dbus_spawn_async):
3046 * dbus/dbus-sysdeps.h:
3047 Add child_setup_func to _dbus_spawn_async.
3049 * doc/dbus-specification.sgml:
3050 Update specification.
3052 * test/spawn-test.c: (setup_func), (main):
3055 2003-02-17 Alexander Larsson <alexl@redhat.com>
3057 * dbus/dbus-connection.c (_dbus_connection_handler_destroyed_locked):
3060 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3064 * doc/dbus-test-plan.sgml:
3065 Add test plan document.
3070 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3072 * dbus/dbus-message.c: (decode_header_data),
3073 (_dbus_message_loader_return_buffer):
3074 Set the header padding amount when loading a message.
3076 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3078 * bus/dispatch.c: (send_one_message):
3079 Only send broadcast messages to registered connections.
3081 * dbus/dbus-message.c: (dbus_message_name_is):
3082 * dbus/dbus-message.h:
3083 New convenience function.
3085 * dbus/dbus-transport-debug.c: (do_reading):
3086 Only dispatch one message per run.
3089 * test/bus-test.c: (new_connection_callback), (die),
3090 (test_hello_client1_handler), (test_hello_client2_handler),
3091 (test_hello_replies), (main):
3093 * test/bus-test-loop.[ch]:
3096 2003-02-16 Havoc Pennington <hp@pobox.com>
3098 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
3099 backward conditional
3101 2003-02-16 Alexander Larsson <alexl@redhat.com>
3103 * dbus/dbus-connection.c:
3104 Implement sent_message_with_reply. (with_reply_and block is still
3106 Made dispatch_message not lose message if OOM.
3108 * dbus/dbus-errors.h:
3109 Add NoReply error (for reply timeouts).
3111 2003-02-16 Alexander Larsson <alexl@redhat.com>
3113 * dbus/dbus-hash.c (_dbus_hash_table_unref):
3114 Actually free keys and values when destroying hashtable.
3116 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3118 * dbus/dbus-auth.c: (client_try_next_mechanism):
3121 * dbus/dbus-threads.c: (dbus_condvar_wait_timeout):
3122 Return TRUE if there's no thread implementation around.
3124 * glib/dbus-gmain.c: (free_source),
3125 (dbus_connection_hookup_with_g_main):
3126 Make sure to remove the GSource when the connection is finalized.
3128 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3130 * bus/dispatch.c: (bus_dispatch_message_handler):
3131 * dbus/dbus-errors.h:
3132 Return an error if someone tries to send a message to a service
3135 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3137 * bus/activation.c: (load_directory), (bus_activation_init),
3138 (bus_activation_activate_service):
3141 (bus_driver_handle_activate_service), (bus_driver_handle_message):
3142 More work on the activation handling.
3144 * dbus/dbus-errors.h:
3145 Add some error messages
3147 * dbus/dbus-message.c: (dbus_message_new_error_reply):
3148 * dbus/dbus-message.h:
3149 New function that creates an error message.
3151 * dbus/dbus-protocol.h:
3152 Add ACTIVATE_SERVER message.
3154 * dbus/dbus-server-unix.c: (unix_handle_watch),
3155 (_dbus_server_new_for_domain_socket):
3156 Call _dbus_fd_set_close_on_exec.
3158 * dbus/dbus-sysdeps.c: (make_pipe), (do_exec),
3159 (_dbus_spawn_async), (_dbus_disable_sigpipe),
3160 (_dbus_fd_set_close_on_exec):
3161 * dbus/dbus-sysdeps.h:
3162 Add _dbus_fd_set_close_on exec function. Also add function that checks
3163 that all open fds are set to close-on-exec and warns otherwise.
3165 * dbus/dbus-transport-unix.c:
3166 (_dbus_transport_new_for_domain_socket):
3167 Call _dbus_fd_set_close_on_exec.
3169 2003-02-16 Havoc Pennington <hp@pobox.com>
3171 * dbus/dbus-connection.c (dbus_connection_set_change_sigpipe):
3172 allow people to avoid setting SIGPIPE to SIG_IGN
3173 (_dbus_connection_new_for_transport): disable SIGPIPE unless
3174 we've been asked not to
3176 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3178 * dbus/dbus-list.c: (_dbus_list_append_link),
3179 (_dbus_list_prepend_link):
3180 * dbus/dbus-memory.c: (dbus_malloc), (dbus_malloc0),
3184 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3187 * bus/activation.c: (bus_activation_entry_free),
3188 (add_desktop_file_entry), (load_directory), (bus_activation_init):
3190 * bus/main.c: (main):
3191 Add simple activation support, doesn't work yet though.
3193 2003-02-15 Zack Rusin <zack@kde.org>
3195 * qt/dbus-qthread.cpp: small casting fix
3197 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3199 * dbus/dbus-errors.c: (dbus_set_error):
3200 * dbus/dbus-errors.h:
3201 Add a few errors and make dbus_set_error void.
3203 * dbus/dbus-sysdeps.c:
3204 (_dbus_errno_to_string), (close_and_invalidate), (make_pipe),
3205 (write_err_and_exit), (read_ints), (do_exec), (_dbus_spawn_async):
3206 * dbus/dbus-sysdeps.h:
3207 Add _dbus_spawn_async.
3209 * test/spawn-test.c: (main):
3210 Test for _dbus_spawn_async.
3212 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3214 * dbus/dbus-internals.h:
3215 Fix build without tests.
3217 * dbus/dbus-list.c: (alloc_link):
3218 Fix a segfault when a malloc fails.
3220 * dbus/dbus-memory.c: (initialize_malloc_debug), (dbus_malloc),
3221 (dbus_malloc0), (dbus_realloc):
3222 Add support for malloc debugging.
3224 2003-02-15 Alexander Larsson <alexl@redhat.com>
3226 * dbus/dbus-threads.c:
3227 * dbus/dbus-threads.h:
3228 Add condvars. Remove static mutext from API.
3229 Implement static mutexes by initializing them from threads_init.
3231 * glib/dbus-gthread.c:
3232 * qt/dbus-qthread.cpp:
3233 Update with the thread api changes.
3238 Turn StaticMutex into normal mutex + init function.
3239 Export new functions _dbus_list_alloc_link, _dbus_list_free_link,
3240 _dbus_list_append_link, _dbus_list_prepend_link
3243 * dbus/dbus-sysdeps.c:
3244 * dbus/dbus-sysdeps.h:
3245 New type dbus_atomic_t, and new functions _dbus_atomic_inc,
3246 _dbus_atomic_dec. Only slow fallback implementation at the moment.
3248 * dbus/dbus-protocol.h:
3249 Add DBUS_MESSAGE_LOCAL_DISCONNECT define
3251 * dbus/dbus-message.c:
3252 Make ref/unref atomic.
3255 * dbus/dbus-connection-internal.h:
3256 * dbus/dbus-connection.c:
3257 * dbus/dbus-connection.h:
3259 Change _peek to _borrow,_return & _steal_borrowed.
3260 Change disconnect callback to event.
3261 Make dbus_connection_dispatch_messages reentrant.
3263 * dbus/dbus-transport.c:
3264 Don't ref the connection on calls to the transport
3267 * dbus/dbus-message-handler.c:
3270 * glib/dbus-gmain.c:
3271 Don't use peek_message anymore
3274 * test/debug-thread.c:
3275 * test/debug-thread.h:
3276 Simple thread implementation that asserts() on deadlocks in
3277 single-threaded code.
3280 (main) Call debug_threads_init.
3283 Use disconnect message instead of disconnect callback.
3287 Don't call dbus_connection_set_disconnect_function. Instead export
3288 bus_connection_disconnect.
3291 Call bus_connection_disconnect when we get a disconnected message.
3293 2003-02-15 Havoc Pennington <hp@pobox.com>
3295 * dbus/dbus-message.c (dbus_message_new): fool around with the
3298 2003-02-14 Havoc Pennington <hp@pobox.com>
3300 * dbus/dbus-mempool.c: fail if the debug functions so indicate
3302 * dbus/dbus-memory.c: fail if the debug functions indicate we
3305 * dbus/dbus-internals.c (_dbus_set_fail_alloc_counter)
3306 (_dbus_decrement_fail_alloc_counter): debug functions to
3307 simulate memory allocation failures
3309 2003-02-14 Havoc Pennington <hp@pobox.com>
3311 * dbus/dbus-errors.h (struct DBusError): add a word of padding
3314 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3316 * bus/driver.c: (bus_driver_handle_hello):
3318 * bus/services.c: (bus_service_lookup):
3319 Reorder message sending so we get a more sane order.
3321 * test/bus-test.c: (message_handler):
3324 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3326 * bus/driver.c: (bus_driver_send_service_deleted),
3327 (bus_driver_send_service_created), (bus_driver_send_service_lost),
3328 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
3329 (bus_driver_send_welcome_message),
3330 (bus_driver_handle_list_services),
3331 (bus_driver_handle_acquire_service),
3332 (bus_driver_handle_service_exists):
3333 * dbus/dbus-bus.c: (dbus_bus_register_client),
3334 (dbus_bus_acquire_service), (dbus_bus_service_exists):
3335 * dbus/dbus-errors.c: (dbus_result_to_string):
3336 * dbus/dbus-errors.h:
3337 * dbus/dbus-message.c: (dbus_message_append_args),
3338 (dbus_message_append_args_valist), (dbus_message_get_args),
3339 (dbus_message_get_args_valist), (dbus_message_get_args_iter),
3340 (dbus_message_iter_get_arg_type), (dbus_message_iter_get_string),
3341 (dbus_message_iter_get_byte_array),
3342 (dbus_message_iter_get_string_array), (message_iter_test),
3343 (check_message_handling), (_dbus_message_test):
3344 * dbus/dbus-message.h:
3345 * test/bus-test.c: (main):
3346 Change fields to arguments in messages, so that they won't be
3347 confused with header fields.
3349 * glib/test-dbus-glib.c: (main):
3350 Remove append_fields from hello message.
3352 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3354 * dbus/dbus-errors.c:
3355 * dbus/dbus-message.c:
3356 * dbus/dbus-string.c:
3357 Documentation fixes.
3359 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3361 * glib/dbus-gmain.c: (timeout_handler), (add_timeout),
3363 Implement support for timeouts in dbus-glib.
3365 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3367 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
3368 * dbus/dbus-message.c: (process_test_subdir):
3369 * test/break-loader.c: (find_breaks_based_on):
3370 Plug some memory leaks.
3372 2003-02-13 Richard Hult <rhult@codefactory.se>
3374 * bus/main.c: Fix build.
3376 * dbus/dbus-errors.h:
3377 * dbus/dbus-errors.c: Fix copyright for Anders.
3379 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3384 * bus/connection.c: (bus_connection_foreach):
3387 * bus/desktop-file.c: (grow_lines_in_section), (grow_sections),
3388 (unescape_string), (new_section), (parse_section_start),
3389 (parse_key_value), (report_error), (bus_desktop_file_load),
3390 (bus_desktop_file_get_string):
3391 * bus/desktop-file.h:
3392 Use DBusError for error reporting.
3394 * bus/dispatch.c: (send_one_message),
3395 (bus_dispatch_message_handler):
3396 * bus/driver.c: (bus_driver_send_service_deleted),
3397 (bus_driver_send_service_created), (bus_driver_send_service_lost),
3398 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
3399 (bus_driver_send_welcome_message),
3400 (bus_driver_handle_list_services),
3401 (bus_driver_handle_acquire_service),
3402 (bus_driver_handle_service_exists):
3403 * bus/loop.c: (bus_loop_run):
3405 Use BUS_HANDLE_OOM instead of _DBUS_HANDLE_OOM.
3407 * bus/utils.c: (bus_wait_for_memory):
3409 New files with general utility functions.
3411 * dbus/dbus-internals.h:
3412 Remove _DBUS_HANDLE_OOM.
3414 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3416 * dbus/dbus-errors.c: (dbus_result_to_string), (dbus_error_init),
3417 (dbus_error_free), (dbus_set_error_const), (dbus_set_error):
3418 * dbus/dbus-errors.h:
3419 Add DBusError structure.
3421 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3423 * test/data/valid-messages/standard-acquire-service.message:
3424 * test/data/valid-messages/standard-hello.message:
3425 * test/data/valid-messages/standard-list-services.message:
3426 * test/data/valid-messages/standard-service-exists.message:
3427 Add some standard messages.
3429 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3431 * bus/driver.c: (bus_driver_send_welcome_message),
3432 (bus_driver_handle_list_services),
3433 (bus_driver_handle_acquire_service),
3434 (bus_driver_handle_service_exists), (bus_driver_handle_message):
3435 Update for API changes in libdbus.
3437 * dbus/dbus-message.c: (dbus_message_new_reply):
3438 * dbus/dbus-message.h:
3439 Remove the name argument. The spec states that replies shouldn't
3442 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3444 * bus/desktop-file.c: (parse_section_start), (parse_key_value),
3445 (report_error), (bus_desktop_file_load), (lookup_section),
3446 (lookup_line), (bus_desktop_file_get_raw),
3447 (bus_desktop_file_get_string):
3448 * bus/desktop-file.h:
3449 Some fixes, and new functions for getting a key value from a section.
3451 2003-02-13 Havoc Pennington <hp@pobox.com>
3453 * test/data/auth/fail-after-n-attempts.auth-script: new test
3455 * dbus/dbus-auth.c (send_rejected): shutdown_mech() when we
3458 2003-02-13 Havoc Pennington <hp@pobox.com>
3460 * dbus/dbus-auth.c (handle_server_data_external_mech): args to
3461 dbus_credentials_match were backward
3463 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support
3464 NO_CREDENTIALS and ROOT_CREDENTIALS
3466 * dbus/dbus-auth.c (_dbus_auth_do_work): move get_state() routine
3467 into here. Never process more commands after we've reached an
3468 end state; store further data as unused bytes.
3470 * test/data/auth/*: add more auth tests
3472 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support EXPECT
3473 command to match exact string and EXPECT_UNUSED to match unused
3476 * test/Makefile.am (dist-hook): fix to dist all the test stuff
3478 2003-02-12 Havoc Pennington <hp@pobox.com>
3480 * dbus/dbus-string.c (_dbus_string_pop_line): fix to also strip
3481 \r off of popped lines
3483 * dbus/dbus-auth.c (_dbus_auth_test): write code to run auth
3486 * dbus/dbus-auth-script.c (_dbus_auth_script_run): when doing a
3489 2003-02-12 Havoc Pennington <hp@pobox.com>
3491 * dbus/Makefile.am: remove break-loader from the build, since it
3494 * configure.in: add --enable-gcov to turn on coverage profiling
3495 flags and disable optimization
3497 2003-02-10 Havoc Pennington <hp@pobox.com>
3499 * dbus/dbus-auth-script.c, dbus/dbus-auth-script.h: sync
3500 initial cut at test framework for DBusAuth from laptop.
3501 Doesn't quite work yet but it compiles and I need to get
3502 it off the 266mhz laptop. ;-)
3504 * dbus/dbus-server-debug.c (_dbus_server_debug_accept_transport):
3505 fix a memleak in error case
3507 2003-02-12 Anders Carlsson <andersca@codefactory.se>
3510 * bus/desktop-file.c:
3511 * bus/desktop-file.h:
3512 Add a desktop file parser.
3514 2003-02-11 Zack Rusin <zack@kde.org>
3516 * qt/message.[h|cpp]: sample implementation
3517 of the KDE wrapper for DBusMessage
3519 2003-02-09 Zack Rusin <zack@kde.org>
3521 * test/bus-test.c: make_it_compile
3522 * doc/dbus-specification.sgml: minimal semantic fix
3524 2003-02-06 Anders Carlsson <andersca@codefactory.se>
3530 2003-02-06 Anders Carlsson <andersca@codefactory.se>
3533 * dbus/dbus-break-loader.c:
3535 * test/break-loader.c:
3536 Move dbus-break-loader to test/ and rename it to break-loader.
3538 2003-02-02 Havoc Pennington <hp@pobox.com>
3540 * dbus/dbus-keyring.c, dbus/dbus-keyring.h: template files
3541 for code to manage cookies in your home directory
3543 * dbus/dbus-sysdeps.c (_dbus_generate_random_bytes): new function
3545 * dbus/dbus-auth.c (get_state): impose a maximum number of tries
3546 to authenticate, then disconnect the client.
3548 2003-02-03 Alexander Larsson <alexl@redhat.com>
3550 * dbus/dbus-message.c (dbus_message_append_fields):
3553 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3555 * doc/dbus-specification.sgml:
3556 Update address format section.
3558 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3561 * test/bus-test.c: (get_time), (add_timeout), (remove_timeout),
3562 (message_handler), (new_connection_callback), (loop_quit),
3566 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3568 * bus/driver.c: (bus_driver_handle_service_exists):
3569 Simplify the code a bit.
3571 * dbus/dbus-bus.c: (dbus_bus_service_exists):
3574 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3577 Add libdbus-daemon.la and link to it.
3579 2003-02-01 James Willcox <jwillcox@gnome.org>
3581 * bus/driver.c: (bus_driver_handle_own_service):
3582 Actually include the service reply code in the message.
3584 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3586 * bus/driver.c: (bus_driver_handle_service_exists):
3587 Don't unref the incoming message.
3589 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3591 * dbus/dbus.h: Add dbus-address.h and dbus-bus.h
3593 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3595 * dbus/dbus-server.c: (dbus_server_listen):
3596 * dbus/dbus-transport.c: (_dbus_transport_open):
3597 ifdef out the calls to the debug transport and server.
3599 2003-02-02 Alexander Larsson <alexl@redhat.com>
3601 * dbus/dbus-watch.c (dbus_watch_get_flags):
3602 Add note in the docs that ERROR or HANGUP won't be returned
3603 and are assumed always on.
3605 * glib/dbus-gmain.c (add_watch):
3606 Always add IO_ERR | IO_HUP
3608 * dbus/dbus-message.h:
3609 Add semicolon after dbus_message_iter_get_string_array().
3610 Makes qt code build again
3612 2003-02-01 Anders Carlsson <andersca@codefactory.se>
3614 * bus/driver.c: (create_unique_client_name),
3615 (bus_driver_handle_hello):
3616 Don't take a name, just use a numeric id to identify
3620 * dbus/dbus-bus.c: (dbus_bus_register_client),
3621 (dbus_bus_acquire_service), (dbus_bus_service_exists):
3623 Add new convenience functions for communicating with the bus.
3625 * dbus/dbus-message.h:
3627 * dbus/dbus-protocol.h:
3630 2003-02-01 Alexander Larsson <alexl@redhat.com>
3632 * dbus/dbus-message.c (dbus_message_append_fields):
3633 Add some more doc comments.
3635 2003-02-01 Havoc Pennington <hp@pobox.com>
3637 * dbus/dbus-break-loader.c (randomly_modify_length): change
3638 a 4-byte value in the message as if it were a length
3640 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): don't set
3641 execute bit on saved files
3643 2003-02-01 Havoc Pennington <hp@pobox.com>
3645 * dbus/dbus-break-loader.c (main): new program to find messages
3646 that break the loader.
3648 * dbus/dbus-sysdeps.c (_dbus_string_append_uint): new function
3649 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): new function
3651 * dbus/dbus-string.c (_dbus_string_set_byte): new
3653 2003-01-31 Havoc Pennington <hp@pobox.com>
3655 * dbus/dbus-message.c: refactor the test code to be more general,
3656 in preparation for writing a "randomly permute test cases to
3657 try to break the loader" program.
3659 2003-01-31 Havoc Pennington <hp@pobox.com>
3661 * doc/dbus-specification.sgml: work on the specification
3663 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): check
3664 the protocol version of the message.
3666 * dbus/dbus-protocol.h: drop special _REPLY names, the spec
3667 no longer specifies that.
3668 (DBUS_SERVICE_REPLY_SERVICE_EXISTS): fix flags (1/2/4/8 not
3671 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos): add missing
3672 "break" for DBUS_TYPE_NIL, remove @todo
3674 2003-01-31 Havoc Pennington <hp@pobox.com>
3676 * dbus/dbus-message.c (dbus_message_set_is_error_reply): rename
3677 just set_is_error/get_is_error as this is a commonly-used
3678 function, and write docs.
3680 2003-01-31 Anders Carlsson <andersca@codefactory.se>
3682 * dbus/dbus-address.c: (dbus_address_entry_free):
3683 Free key and value lists.
3685 * dbus/dbus-internals.c: (_dbus_type_to_string):
3686 Add the types we didn't have.
3688 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
3689 (_dbus_marshal_validate_arg):
3692 * dbus/dbus-message.c: (dbus_message_set_sender):
3693 Remove todo about being able to set sender to NULL.
3695 (dbus_message_set_is_error_reply),
3696 (dbus_message_get_is_error_reply):
3697 * dbus/dbus-message.h:
3700 * dbus/dbus-protocol.h:
3701 Add error reply flag.
3703 * test/data/valid-messages/opposite-endian.message:
3704 Add NIL type to test.
3706 2003-01-31 Havoc Pennington <hp@pobox.com>
3708 * doc/dbus-specification.sgml: fully specify the header. Add
3709 flags and major protocol version, and change header/body len to
3712 * dbus/dbus-message-builder.c (append_saved_length): append length
3715 * dbus/dbus-message.c (dbus_message_create_header): change header
3716 length and body length to unsigned. Add the new fields from the
3718 (_dbus_message_loader_return_buffer): unsigned header/body len
3720 2003-01-30 Havoc Pennington <hp@pobox.com>
3722 * dbus/dbus-auth.c: rework to use only REJECTED, no
3725 * doc/dbus-sasl-profile.txt: drop MECHANISMS and just
3726 use REJECTED, suggested by Mark McLoughlin
3728 2003-01-30 Havoc Pennington <hp@pobox.com>
3730 * dbus/dbus-server.c (dbus_server_listen): @todo about how we need
3731 a better way to report errors here. e.g. "unix address lacks
3732 path" or something. also "no such file" when the path doesn't
3735 * dbus/dbus-address.c (dbus_address_entries_free): add @todo about
3737 (dbus_parse_address): add @todo about documenting address format,
3738 and allowing , and ; to be escaped
3740 2003-01-30 Anders Carlsson <andersca@codefactory.se>
3743 Add dbus-address.[ch]
3745 * dbus/dbus-address.c: (dbus_address_entry_free),
3746 (dbus_address_entries_free), (create_entry),
3747 (dbus_address_entry_get_method), (dbus_address_entry_get_value),
3748 (dbus_parse_address), (_dbus_address_test):
3749 * dbus/dbus-address.h:
3750 New files for dealing with address parsing.
3752 * dbus/dbus-connection.c:
3753 Document timeout functions.
3755 * dbus/dbus-message.c:
3756 Document dbus_message_new_from_message.
3758 * dbus/dbus-server-debug.c:
3761 * dbus/dbus-server.c: (dbus_server_listen):
3762 Parse address and use correct server implementation.
3764 * dbus/dbus-string.c: (_dbus_string_find_to), (_dbus_string_test):
3765 * dbus/dbus-string.h:
3766 New function with test.
3768 * dbus/dbus-test.c: (dbus_internal_symbol_do_not_use_run_tests):
3772 * dbus/dbus-transport-debug.c:
3775 * dbus/dbus-transport.c: (_dbus_transport_open):
3776 Parse address and use correct transport implementation.
3778 2003-01-30 Havoc Pennington <hp@pobox.com>
3780 * dbus/dbus-message.c: use message->byte_order instead of
3781 DBUS_COMPILER_BYTE_ORDER throughout.
3782 (dbus_message_create_header): pad header to align the
3783 start of the body of the message to 8-byte boundary
3785 * dbus/dbus-marshal.h: make all the demarshalers take const
3786 DBusString arguments.
3788 * dbus/dbus-message.c (_dbus_message_loader_return_buffer):
3789 validate message args here, so we don't have to do slow validation
3790 later, and so we catch bad messages as they are incoming. Also add
3791 better checks on header_len and body_len. Also fill in
3794 * dbus/dbus-string.c (_dbus_string_validate_utf8): new (not
3795 implemented properly)
3796 (_dbus_string_validate_nul): new function to check all-nul
3798 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): rename
3799 get_arg_end_pos and remove all validation
3800 (_dbus_marshal_validate_arg): actually do validation here.
3802 2003-01-29 Havoc Pennington <hp@pobox.com>
3804 * dbus/dbus-message.c (check_message_handling): fix assertion
3805 failure on set_client_serial
3807 2003-01-28 Havoc Pennington <hp@pobox.com>
3809 * dbus/dbus-server-debug.c: Add doc section comments
3811 * dbus/dbus-transport-debug.c: add doc section comments
3813 2003-01-28 Havoc Pennington <hp@redhat.com>
3815 * dbus/dbus-string.c (_dbus_string_base64_decode): append bytes in
3816 the reverse order from how I had it
3817 (_dbus_string_base64_encode): reverse encoding order. I was
3818 basically byteswapping everything during encoding.
3820 2003-01-28 Anders Carlsson <andersca@codefactory.se>
3822 * dbus/dbus-connection-internal.h:
3823 * dbus/dbus-connection.c: (_dbus_connection_add_timeout),
3824 (_dbus_connection_remove_timeout):
3825 Add functions for adding and removing timeouts.
3827 * dbus/dbus-message.c: (dbus_message_new_from_message):
3828 Add new function that takes a message and creates an exact
3829 copy of it, but with the refcount set to 1.
3830 (check_message_handling):
3833 * dbus/dbus-server-protected.h:
3834 * dbus/dbus-server.c: (_dbus_server_init_base),
3835 (_dbus_server_finalize_base), (_dbus_server_add_timeout),
3836 (dbus_server_set_timeout_functions):
3837 (_dbus_server_remove_timeout):
3838 New functions so that a server can add and remove timeouts.
3840 (dbus_server_listen):
3841 Add commented out call to dbus_server_debug_new.
3843 * dbus/dbus-timeout.c: (_dbus_timeout_new):
3844 Actually set the handler, doh.
3846 * dbus/dbus-transport.c: (_dbus_transport_open):
3847 Add commented out call to dbus_transport_debug_client_new.
3850 Add dbus-transport-debug.[ch] and dbus-server-debug.[ch]
3852 2003-01-28 Havoc Pennington <hp@pobox.com>
3854 * dbus/dbus-message.c (check_message_handling): function to check
3855 on the loaded message, iterates over it etc.
3857 2003-01-28 Havoc Pennington <hp@pobox.com>
3859 * test/Makefile.am (dist-hook): fix make distdir
3861 * dbus/Makefile.am (TESTS_ENVIRONMENT): fix make check
3863 2003-01-27 Havoc Pennington <hp@pobox.com>
3865 * dbus/dbus-mempool.c (time_for_size): replace printf with
3868 * dbus/dbus-message-builder.c (_dbus_message_data_load): allow
3869 empty lines; fix the SAVE_LENGTH stuff to be
3870 START_LENGTH/END_LENGTH so it actually works; couple other
3873 * test/Makefile.am (dist-hook): add dist-hook for .message files
3875 * dbus/dbus-string.c (DBUS_STRING_COPY_PREAMBLE): source of a copy
3876 can be constant or locked.
3877 (_dbus_string_free): allow freeing a const string as
3880 * dbus/dbus-sysdeps.c (_dbus_concat_dir_and_file): utility
3882 * dbus/dbus-test-main.c (main): take an argument which is the
3883 directory containing test data
3885 * dbus/dbus-message.c (_dbus_message_test): pass a test_data_dir
3886 argument to this and load all the messages in test/data/
3887 checking that they can be loaded or not loaded as appropriate.
3889 2003-01-27 Anders Carlsson <andersca@codefactory.se>
3891 * bus/dispatch.c: (bus_dispatch_message_handler):
3892 Dispatch messages sent to services.
3894 * bus/driver.c: (bus_driver_send_service_deleted),
3895 (bus_driver_send_service_created), (bus_driver_send_service_lost),
3896 (bus_driver_send_service_acquired):
3897 Add helper functions for sending service related messages.
3899 (bus_driver_send_welcome_message):
3900 Send HELLO_REPLY instead of WELCOME.
3902 (bus_driver_handle_list_services):
3903 Send LIST_SERVICES_REPLY instead of SERVICES.
3905 (bus_driver_handle_own_service),
3906 (bus_driver_handle_service_exists):
3907 New message handlers.
3909 (bus_driver_handle_message):
3910 Invoke new message handlers.
3912 (bus_driver_remove_connection):
3913 Don't remove any services here since that's done automatically
3914 by bus_service_remove_owner now.
3917 New function signatures.
3919 * bus/services.c: (bus_service_add_owner):
3920 Send ServiceAcquired message if we're the only primary owner.
3922 (bus_service_remove_owner):
3923 Send ServiceAcquired/ServiceLost messages.
3925 (bus_service_set_prohibit_replacement),
3926 (bus_service_get_prohibit_replacement):
3927 Functions for setting prohibit replacement.
3929 (bus_service_has_owner):
3930 New function that checks if a connection is in the owner queue of
3934 Add new function signatures.
3936 * dbus/dbus-list.c: (_dbus_list_test):
3937 Add tests for _dbus_list_remove_last and traversing the list backwards.
3940 Fix a typo in _dbus_list_get_prev_link, if we're at the first element we can't
3941 go any further, so return NULL then.
3943 * dbus/dbus-protocol.h:
3944 Add new messages, service flags and service replies.
3946 2003-01-26 Havoc Pennington <hp@pobox.com>
3948 * dbus/dbus-message-builder.c: implement, completely untested.
3950 * test/data/*: add data to be used in testing.
3951 ".message" files are our simple loadable text format.
3952 ".message-raw" will be binary dumps of messages.
3954 * dbus/dbus-string.c (_dbus_string_starts_with_c_str): new
3956 2003-01-26 Havoc Pennington <hp@pobox.com>
3958 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): new function
3960 * dbus/dbus-errors.c (dbus_result_to_string): add
3963 * dbus/dbus-message-builder.c: new file, will contain code to load
3964 up messages from files. Not implemented yet.
3966 2003-01-26 Havoc Pennington <hp@pobox.com>
3968 * dbus/dbus-message.c (dbus_message_set_sender): support deleting
3969 the sender by setting to NULL
3971 2003-01-26 Havoc Pennington <hp@pobox.com>
3973 The unit tests pass, but otherwise untested. If it breaks, the
3974 tests should have been better. ;-)
3976 * bus/driver.c (bus_driver_handle_hello): return if we disconnect
3979 * dbus/dbus-message.c: redo everything so we maintain
3980 message->header as the only copy of the various fields.
3981 This avoids the possibility of out-of-memory in some cases,
3982 for example dbus_message_lock() can't run out of memory anymore,
3983 and avoids extra copying. Figured I may as well go ahead and do
3984 this since it was busted for dbus_message_lock to not return
3985 failure on OOM, and dbus_message_write_header was totally
3986 unchecked for OOM. Also fixed some random other bugs.
3988 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): verify
3989 that strings are nul-terminated. Also, end_pos can be equal
3990 to string length just not greater than, I think.
3991 (_dbus_marshal_set_int32): new function
3992 (_dbus_marshal_set_uint32): new function
3993 (_dbus_marshal_set_string): new function
3995 * dbus/dbus-connection.c (_dbus_connection_new_for_transport): fix
3996 a warning, init timeout_list to NULL
3997 (dbus_connection_send_message): don't use uninitialized variable
4000 * dbus/dbus-string.c (_dbus_string_replace_len): new function
4002 2003-01-26 Anders Carlsson <andersca@codefactory.se>
4004 * bus/driver.c: (bus_driver_handle_hello),
4005 (bus_driver_send_welcome_message):
4008 2003-01-26 Anders Carlsson <andersca@codefactory.se>
4010 * dbus/dbus-auth.c: (process_auth), (_dbus_auth_unref):
4011 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
4012 (dbus_connection_unref):
4013 * dbus/dbus-marshal.c: (_dbus_marshal_test):
4014 * dbus/dbus-message.c: (dbus_message_unref),
4017 (dbus_message_get_fields):
4018 Remove debugging printout.
4020 (_dbus_message_loader_return_buffer):
4021 Don't store the header string.
4023 (_dbus_message_test):
4026 2003-01-26 Richard Hult <rhult@codefactory.se>
4028 * glib/dbus-gmain.c (dbus_connection_dispatch): Traverse a copy of
4029 the file descriptor list, since it can change under us.
4031 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4033 * glib/dbus-gmain.c: (dbus_connection_prepare),
4034 (dbus_connection_check), (dbus_connection_dispatch), (add_watch),
4035 (remove_watch), (dbus_connection_hookup_with_g_main):
4036 Rewrite the glib handling to use its own GSource instead of a
4037 GIOChannel so we can catch messages put in the queue while waiting
4040 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4043 * bus/connection.c: (connection_disconnect_handler),
4044 (connection_watch_callback), (bus_connection_setup):
4045 * bus/dispatch.c: (send_one_message),
4046 (bus_dispatch_broadcast_message), (bus_dispatch_message_handler),
4047 (bus_dispatch_add_connection), (bus_dispatch_remove_connection):
4049 * bus/driver.c: (bus_driver_send_service_deleted),
4050 (bus_driver_send_service_created), (bus_driver_handle_hello),
4051 (bus_driver_send_welcome_message),
4052 (bus_driver_handle_list_services), (bus_driver_remove_connection),
4053 (bus_driver_handle_message):
4055 Refactor code, put the message dispatching in its own file. Use
4056 _DBUS_HANDLE_OOM. Also send ServiceDeleted messages when a client
4059 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4061 * dbus/dbus-internals.h:
4062 Add _DBUS_HANDLE_OOM macro, it doesn't do anything currently.
4064 * dbus/dbus-message.c: (dbus_message_get_sender):
4065 * dbus/dbus-message.h:
4066 Implement dbus_message_get_sender.
4068 * dbus/dbus-protocol.h:
4069 Add message and service defines.
4071 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4073 * dbus/dbus-connection.c: (dbus_connection_send_message):
4074 * dbus/dbus-message-internal.h:
4075 * dbus/dbus-message.c: (_dbus_message_get_client_serial),
4076 (dbus_message_write_header):
4077 Remove _dbus_messag_unlock and don't set the client serial on a
4078 message if one already exists.
4080 2003-01-24 Havoc Pennington <hp@pobox.com>
4082 * dbus/dbus-list.c (alloc_link): put a thread lock on the global
4085 * bus/driver.c (bus_driver_handle_list_services): fix a leak
4088 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4090 * dbus/dbus-list.c: (alloc_link), (free_link):
4091 Use a memory pool for the links.
4093 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4095 * bus/connection.c: (bus_connection_foreach):
4097 Add new bus_connection_foreach function.
4099 * bus/driver.c: (send_one_message), (bus_driver_broadcast_message):
4100 Add function that broadcasts a message to all clients.
4102 (bus_driver_send_service_created), (bus_driver_handle_hello),
4103 (bus_driver_send_welcome_message),
4104 (bus_driver_handle_list_services), (bus_driver_message_handler):
4105 Implement functions that take care of listing services, and notifying
4106 clients when new services are created.
4108 * bus/services.c: (bus_services_list):
4110 Add new function that returns an array of strings with the currently
4111 registered services.
4114 * glib/dbus-gmain.c:
4115 Update copyright year.
4117 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4119 * dbus/dbus-connection.c: (dbus_connection_send_message):
4120 Unlock the message in case it was sent earlier.
4122 (dbus_connection_send_message_with_reply_and_block):
4123 Remove the reply message from the list.
4125 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
4126 Set array_len and new_pos correctly.
4128 (_dbus_marshal_test):
4129 Remove debug output.
4131 * dbus/dbus-message-internal.h:
4132 * dbus/dbus-message.c: (_dbus_message_get_reply_serial):
4133 New function that returns the reply serial.
4135 (_dbus_message_unlock):
4136 New function that unlocks a message and resets its header.
4138 (dbus_message_append_string_array),
4139 (dbus_message_get_fields_valist),
4140 (dbus_message_iter_get_field_type),
4141 (dbus_message_iter_get_string_array),
4142 (dbus_message_get_fields),
4143 (dbus_message_append_fields_valist):
4144 Handle string arrays.
4146 (dbus_message_set_sender):
4147 Make this function public since the bus daemon needs it.
4149 (decode_header_data):
4150 Set the reply serial to -1 initially.
4152 * dbus/dbus-message.h:
4153 Add dbus_message_set_sender.
4155 2003-01-24 Havoc Pennington <hp@pobox.com>
4157 * doc/dbus-specification.sgml: add some stuff
4159 2003-01-22 Havoc Pennington <hp@pobox.com>
4161 * doc/dbus-specification.sgml: Start to document the protocol.
4163 2003-01-22 Havoc Pennington <hp@pobox.com>
4165 * dbus/dbus-connection.c
4166 (dbus_connection_send_message_with_reply_and_block): add some @todo
4168 * bus/driver.c (bus_driver_add_connection): add a FIXME about memleak
4170 2003-01-21 Havoc Pennington <hp@pobox.com>
4172 (patch untested because can't compile)
4174 * bus/driver.c (create_unique_client_name): make this function
4175 never recycle client names. Also, caller should initialize
4178 * dbus/dbus-sysdeps.c (_dbus_get_current_time): new function
4180 2003-01-21 Anders Carlsson <andersca@codefactory.se>
4182 * dbus/dbus-marshal.c: (_dbus_marshal_double),
4183 (_dbus_marshal_int32), (_dbus_marshal_uint32),
4184 (_dbus_marshal_int32_array), (_dbus_marshal_uint32_array),
4185 (_dbus_marshal_double_array), (_dbus_marshal_string_array),
4186 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
4187 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
4188 (_dbus_marshal_get_field_end_pos), (_dbus_marshal_test):
4189 * dbus/dbus-marshal.h:
4190 * dbus/dbus-protocol.h:
4191 Add support for marshalling and demarshalling integer, double
4194 2003-01-21 Anders Carlsson <andersca@codefactory.se>
4199 * bus/connection.c: (connection_disconnect_handler):
4200 Remove the connection from the bus driver's list.
4202 (connection_watch_callback): Dispatch messages.
4204 (free_connection_data): Free connection name.
4206 (bus_connection_setup): Add connection to the bus driver's list.
4207 (bus_connection_remove_owned_service):
4208 (bus_connection_set_name), (bus_connection_get_name):
4209 Add functions for setting and getting the connection's name.
4212 Add function headers.
4214 * bus/driver.c: (create_unique_client_name),
4215 (bus_driver_handle_hello_message),
4216 (bus_driver_send_welcome_message), (bus_driver_message_handler),
4217 (bus_driver_add_connection), (bus_driver_remove_connection):
4220 * bus/services.c: (bus_service_free):
4222 New file that handles communication and registreation with the bus
4225 2003-01-21 Anders Carlsson <andersca@codefactory.se>
4227 * dbus/dbus-connection.c: (dbus_connection_send_message):
4228 Add a new client_serial parameter.
4230 (dbus_connection_send_message_with_reply):
4231 Remove a @todo since we've implemented the blocking function.
4233 (dbus_connection_send_message_with_reply_and_block):
4234 New function that sends a message and waits for a reply and
4235 then returns the reply.
4237 * dbus/dbus-connection.h:
4240 * dbus/dbus-errors.c: (dbus_result_to_string):
4241 * dbus/dbus-errors.h:
4242 Add new DBUS_RESULT.
4244 * dbus/dbus-message-internal.h:
4245 * dbus/dbus-message.c: (_dbus_message_get_reply_serial),
4246 (_dbus_message_set_sender), (dbus_message_write_header),
4247 (dbus_message_new_reply), (decode_header_data),
4248 (_dbus_message_loader_return_buffer), (_dbus_message_test):
4249 * dbus/dbus-message.h:
4250 Add new functions that set the reply serial and sender.
4251 Also marshal and demarshal them correctly and add test.
4253 * dbus/dbus-protocol.h:
4254 Add new DBUS_MESSAGE_TYPE_SENDER.
4257 * glib/dbus-gmain.c: (watch_callback), (free_callback_data),
4258 (add_watch), (remove_watch), (add_timeout), (remove_timeout),
4259 (dbus_connection_hookup_with_g_main):
4260 * glib/test-dbus-glib.c: (main):
4261 Rewrite to use GIOChannel and remove the GSource crack.
4263 * test/echo-client.c: (main):
4264 * test/watch.c: (check_messages):
4265 Update for changed APIs
4267 2003-01-19 Anders Carlsson <andersca@codefactory.se>
4269 * dbus/Makefile.am: Add dbus-timeout.[cħ]
4271 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport):
4272 Create a DBusTimeoutList.
4273 (dbus_connection_set_timeout_functions): Add new function to
4274 set timeout callbacks
4276 * dbus/dbus-connection.h: Add public DBusTimeout API.
4278 * dbus/dbus-message.c: (dbus_message_get_service):
4279 * dbus/dbus-message.h: New function.
4281 * dbus/dbus-server.c: Fix small doc typo.
4283 * dbus/dbus-timeout.[ch]: New files for mainloop timeouts.
4285 2003-01-19 Anders Carlsson <andersca@codefactory.se>
4287 * dbus/dbus-string.c (_dbus_string_move_len): Don't delete all
4288 of the string, just as long as specified.
4290 2003-01-19 Havoc Pennington <hp@pobox.com>
4292 * dbus/dbus-connection.c (dbus_connection_get_is_authenticated):
4295 * dbus/dbus-server.c (dbus_server_set_max_connections)
4296 (dbus_server_get_max_connections, dbus_server_get_n_connections):
4297 keep track of current number of connections, and add API for
4298 setting a max (but haven't implemented enforcing the max yet)
4300 2003-01-18 Havoc Pennington <hp@pobox.com>
4302 * dbus/dbus-transport-unix.c (unix_do_iteration): only do the
4303 reading/writing if read_watch != NULL or write_watch != NULL.
4305 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): fix
4306 the message loader code to actually load message->header and
4307 message->body into the newly-created message.
4309 * dbus/dbus-transport-unix.c (check_write_watch): fix a mem leak
4312 * dbus/dbus-connection.c (dbus_connection_set_max_message_size)
4313 (dbus_connection_get_max_message_size)
4314 (dbus_connection_set_max_live_messages_size)
4315 (dbus_connection_get_max_live_messages_size): implement some
4316 resource limitation functions
4318 * dbus/dbus-resources.c: new file implementing some of the
4319 resource limits stuff
4321 * dbus/dbus-message.c (dbus_message_iter_get_byte_array): add
4322 missing docs, add @todo to handle OOM etc.
4324 * dbus/dbus-marshal.c (_dbus_demarshal_byte_array): add missing
4327 2003-01-18 Havoc Pennington <hp@pobox.com>
4329 * dbus/dbus-connection.c (dbus_connection_unref): disconnect the
4330 connection if it hasn't been already.
4332 * dbus/dbus-connection.h: kill off the idea of an ErrorFunction,
4333 replace with DisconnectFunction.
4335 2003-01-18 Havoc Pennington <hp@pobox.com>
4337 Building --disable-verbose-mode --disable-asserts --disable-tests
4338 cuts the library from 112K to 45K or so
4340 * configure.in: check for varargs macro support,
4341 add --enable-verbose-mode, --enable-asserts.
4343 * dbus/dbus-internals.h (_dbus_assert): support
4345 (_dbus_verbose): support DBUS_ENABLE_VERBOSE_MODE
4347 2003-01-18 Havoc Pennington <hp@pobox.com>
4349 * dbus/dbus-test.c: include config.h so that tests actually run
4351 * dbus/dbus-string.c: add assertions that stuff is 8-byte aligned,
4352 so the failure mode when that assumption fails will be plenty
4355 2003-01-18 Havoc Pennington <hp@pobox.com>
4357 * configure.in: default --enable-tests to $USE_MAINTAINER_MODE
4359 * dbus/Makefile.am: fix it up so dubs-test-main.c is included in
4362 * test/Makefile.am: don't use special variable "TESTS" for echo-*
4363 since we don't want to use those in make check
4365 2003-01-15 Havoc Pennington <hp@redhat.com>
4371 2003-01-15 Havoc Pennington <hp@redhat.com>
4373 * test/Makefile.am: fix so that test source code ends up in the
4374 distribution on make distcheck
4376 2003-01-15 Havoc Pennington <hp@redhat.com>
4382 2003-01-15 Havoc Pennington <hp@redhat.com>
4384 * dbus/dbus-test.c (dbus_internal_symbol_do_not_use_run_tests):
4385 fix build when --disable-tests
4387 * Makefile.am (EXTRA_DIST): put HACKING in here
4389 * HACKING: document procedure for making a tarball release.
4391 2003-01-14 Anders Carlsson <andersca@codefactory.se>
4393 * bus/connection.c: (connection_error_handler),
4394 (bus_connection_setup):
4395 * bus/main.c: (main):
4396 Make sure that the DBusConnectionData struct is NULLed
4397 out to prevent a segfault.
4399 * dbus/dbus-errors.c: (dbus_result_to_string):
4400 * dbus/dbus-errors.h:
4401 * dbus/dbus-message.c: (dbus_message_get_fields),
4402 (dbus_message_get_fields_valist), (_dbus_message_test):
4403 * dbus/dbus-message.h:
4404 Make dbus_message_get_fields return a result code so we can
4405 track invalid fields as well as oom.
4407 2003-01-11 Havoc Pennington <hp@pobox.com>
4409 * configure.in: change --enable-test/--enable-ansi action-if-given
4410 to enable_foo=$enableval instead of enable_foo=yes
4412 2003-01-08 Havoc Pennington <hp@pobox.com>
4414 * dbus/dbus-string.c (_dbus_string_align_length): new function
4416 * dbus/dbus-test-main.c: move main() for test app here
4418 (dbus_internal_symbol_do_not_use_run_tests): we have to export a
4419 symbol to run tests, because dbus-test isn't in the main
4422 Code review nitpicks.
4424 * dbus/dbus-message.c (dbus_message_write_header): add newlines
4425 for people with narrow emacs ;-). Assert client_serial was filled
4426 in. Assert message->name != NULL.
4427 (dbus_message_append_fields): have "first_field_type" arg separate
4428 from va list, needed for C++ binding that also uses varargs IIRC
4429 and helps with type safety
4430 (dbus_message_new): add @todo about using DBusString to store
4431 service/name internally
4432 (dbus_message_new): don't leak ->service and ->name on OOM later
4434 (dbus_message_unref): free the service name
4435 (dbus_message_get_fields): same change to varargs
4436 i.e. first_field_type
4437 (_dbus_message_loader_return_buffer): assert that the message data
4438 is aligned (if not it's a bug in our code). Put in verbose griping
4439 about why we set corrupted = TRUE.
4440 (decode_header_data): add FIXME that char* is evil. Was going to
4441 add FIXME about evil locale-specific string.h strncmp, but just
4442 switched to wacky string-as-uint32 optimization. Move check for
4443 "no room for field name" above get_const_data_len() to avoid
4444 assertion failure in get_const_data_len if we have trailing 2
4445 bytes or the like. Check for service and name fields being
4446 provided twice. Don't leak service/name on error. Require field
4447 names to be aligned to 4 bytes.
4449 * dbus/dbus-marshal.c: move byte swap stuff to header
4450 (_dbus_pack_int32): uscore-prefix
4451 (_dbus_unpack_int32): uscore-prefix
4452 (_dbus_unpack_uint32): export
4453 (_dbus_demarshal_string): add @todo complaining about use of
4455 (_dbus_marshal_get_field_end_pos): add @todo about bad error
4456 handling allowing corrupt data to go unchecked
4458 2003-01-08 Havoc Pennington <hp@redhat.com>
4460 * dbus/dbus-transport-unix.c (unix_do_iteration): add read/write
4461 to the select() as needed for authentication. (should be using
4462 _dbus_poll() not select, but for another day)
4464 * dbus/dbus.h: include dbus/dbus-protocol.h
4466 2003-01-08 Anders Carlsson <andersca@codefactory.se>
4468 * dbus/Makefile.am (dbusinclude_HEADERS): Install
4471 2003-01-08 Anders Carlsson <andersca@codefactory.se>
4473 * dbus/dbus-internals.c: (_dbus_type_to_string):
4474 New function that returns a string describing a type.
4476 * dbus/dbus-marshal.c: (_dbus_demarshal_byte_array):
4477 * dbus/dbus-marshal.h:
4478 * dbus/dbus-message.c: (dbus_message_get_fields_valist),
4479 (dbus_message_iter_get_field_type), (dbus_message_iter_get_double),
4480 (dbus_message_iter_get_byte_array):
4481 * dbus/dbus-message.h:
4482 Add new convenience functions for appending and getting message fields.
4483 Also add demarshalling routines for byte arrays.
4485 2003-01-07 Anders Carlsson <andersca@codefactory.se>
4487 * dbus/dbus-connection-internal.h:
4488 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
4489 (_dbus_connection_get_next_client_serial),
4490 (dbus_connection_send_message):
4491 * dbus/dbus-internals.h:
4492 * dbus/dbus-marshal.c: (unpack_uint32), (dbus_unpack_int32),
4493 (dbus_pack_int32), (_dbus_marshal_double), (_dbus_marshal_int32),
4494 (_dbus_marshal_uint32), (_dbus_demarshal_double),
4495 (_dbus_demarshal_int32), (_dbus_demarshal_uint32),
4496 (_dbus_demarshal_string), (_dbus_marshal_get_field_end_pos),
4497 (_dbus_verbose_bytes), (_dbus_marshal_test):
4498 * dbus/dbus-marshal.h:
4499 * dbus/dbus-message-internal.h:
4500 * dbus/dbus-message.c: (_dbus_message_set_client_serial),
4501 (dbus_message_write_header), (_dbus_message_lock),
4502 (dbus_message_new), (dbus_message_ref), (dbus_message_unref),
4503 (dbus_message_get_name), (dbus_message_append_int32),
4504 (dbus_message_append_uint32), (dbus_message_append_double),
4505 (dbus_message_append_string), (dbus_message_append_byte_array),
4506 (dbus_message_get_fields_iter), (dbus_message_iter_ref),
4507 (dbus_message_iter_unref), (dbus_message_iter_has_next),
4508 (dbus_message_iter_next), (dbus_message_iter_get_field_type),
4509 (dbus_message_iter_get_string), (dbus_message_iter_get_int32),
4510 (dbus_message_iter_get_uint32), (dbus_message_iter_get_double),
4511 (decode_header_data), (_dbus_message_loader_return_buffer),
4512 (message_iter_test), (_dbus_message_test):
4513 * dbus/dbus-message.h:
4514 * dbus/dbus-protocol.h:
4515 * dbus/dbus-test.c: (main):
4517 * glib/test-dbus-glib.c: (message_handler), (main):
4518 * test/echo-client.c: (main):
4519 * test/watch.c: (check_messages):
4520 Make messages sendable and receivable for real.
4522 2003-01-07 Anders Carlsson <andersca@codefactory.se>
4524 * dbus/dbus-marshal.c: (_dbus_marshal_double),
4525 (_dbus_marshal_string), (_dbus_marshal_byte_array):
4526 * dbus/dbus-message.c: (dbus_message_append_int32),
4527 (dbus_message_append_uint32), (dbus_message_append_double),
4528 (dbus_message_append_string), (dbus_message_append_byte_array):
4529 Handle OOM restoration.
4531 2003-01-07 Anders Carlsson <andersca@codefactory.se>
4533 * dbus/dbus-marshal.c: (_dbus_marshal_string),
4534 (_dbus_demarshal_string), (_dbus_marshal_test):
4535 * dbus/dbus-marshal.h:
4536 * dbus/dbus-message.c: (dbus_message_get_name),
4537 Document these functions.
4539 (dbus_message_append_int32), (dbus_message_append_uint32),
4540 (dbus_message_append_double), (dbus_message_append_string),
4541 (dbus_message_append_byte_array):
4542 * dbus/dbus-message.h:
4543 Add functions for adding message fields of different types.
4545 * dbus/dbus-protocol.h:
4546 Add the different types.
4548 2003-01-05 Havoc Pennington <hp@pobox.com>
4550 * bus/connection.c: implement routines for handling connections,
4551 first thing is keeping a list of owned services on each connection
4552 and setting up watches etc.
4554 * bus/services.c: implement a mapping from service names to lists
4557 * dbus/dbus-hash.c: add DBUS_HASH_POINTER
4559 * dbus/dbus-threads.c (dbus_static_mutex_lock): add functions
4560 to use static mutexes for global data
4562 * dbus/dbus-connection.c (dbus_connection_set_data): add new
4563 collection of functions to set/get application-specific data
4564 on the DBusConnection.
4566 2003-01-04 Havoc Pennington <hp@pobox.com>
4568 * dbus/dbus-sysdeps.c (_dbus_sleep_milliseconds): new function
4569 (_dbus_poll): new function
4571 * dbus/dbus-internals.h (_DBUS_STRUCT_OFFSET): new macro
4574 * bus/loop.c: initial code for the daemon main loop
4576 2003-01-04 Havoc Pennington <hp@pobox.com>
4578 * test/watch.c (error_handler): make it safe if the error handler
4579 is called multiple times (if we s/error handler/disconnect
4580 handler/ we should just guarantee it's called only once)
4582 * dbus/dbus-transport.c (_dbus_transport_disconnect): call the
4583 error handler on disconnect (it's quite possible we should
4584 just change the error handler to a "disconnect handler," I'm
4585 not sure we have any other meaningful errors)
4587 * configure.in: check for getpwnam_r
4589 * dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
4590 dbus/dbus-auth.c: add credentials support, add EXTERNAL auth
4591 mechanism as in SASL spec, using socket credentials
4593 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): new function
4594 (_dbus_send_credentials_unix_socket): new function
4596 * dbus/dbus-sysdeps.c (_dbus_accept_unix_socket): rename just
4598 (_dbus_write): only check errno if <0 returned
4599 (_dbus_write_two): ditto
4601 2003-01-02 Anders Carlsson <andersca@codefactory.se>
4603 * dbus/dbus-marshal.c: (_dbus_marshal_utf8_string),
4604 (_dbus_marshal_byte_array), (_dbus_demarshal_utf8_string),
4605 (_dbus_marshal_test):
4606 * dbus/dbus-marshal.h:
4607 Add _dbus_marshal_byte_array and rename _dbus_marshal_string
4608 to _dbus_marshal_utf8_string. Also fix some tests.
4610 2002-12-28 Harri Porten <porten@kde.org>
4612 * configure.in: added check for C++ compiler and a very cheesy
4613 check for the Qt integration
4615 * Makefile.am (SUBDIRS): compile qt subdir if support is enabled
4617 * qt/Makefile.am: added
4619 * qt/.cvsignore: added
4621 * qt/dbus-qthread.cc, qt/dbus-qthread.cpp: renamed former to
4622 latter, added #ifdef QT_THREAD_SUPPORT guard.
4624 * dbus/Makefile.am: added missing headers for make dist
4626 2002-12-28 Kristian Rietveld <kris@gtk.org>
4628 * dbus/Makefile.am: fixup export-symbols-regex.
4630 2002-12-27 Anders Carlsson <andersca@codefactory.se>
4632 * acinclude.m4: Add this file and put the
4633 PKG_CHECK_MODULE macro in it.
4635 2002-12-27 Anders Carlsson <andersca@codefactory.se>
4637 * dbus/dbus-marshal.c: (_dbus_marshal_string),
4638 (_dbus_demarshal_double), (_dbus_demarshal_int32),
4639 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
4640 (_dbus_marshal_test):
4641 Make the demarshalling routines align the pos argument.
4642 Add string marshalling tests and fix the obvious bugs
4645 2002-12-26 Havoc Pennington <hp@pobox.com>
4647 * dbus/dbus-auth.c: fixes fixes fixes
4649 * dbus/dbus-transport-unix.c: wire up support for
4650 encoding/decoding data on the wire
4652 * dbus/dbus-auth.c (_dbus_auth_encode_data)
4653 (_dbus_auth_decode_data): append to target string
4654 instead of nuking it.
4656 2002-12-26 Havoc Pennington <hp@pobox.com>
4658 * dbus/dbus-marshal.h (DBUS_COMPILER_BYTE_ORDER): #ifdef
4659 WORDS_BIGENDIAN then compiler byte order is DBUS_BIG_ENDIAN,
4662 * dbus/dbus-marshal.c: Add macros to do int swapping in-place and
4663 avoid swap_bytes() overhead (ignoring possible assembly stuff for
4664 now). Main point is because I wanted unpack_uint32 to implement
4666 (_dbus_verbose_bytes): new function
4668 * dbus/dbus-string.c (_dbus_string_validate_ascii): new function
4670 * dbus/dbus-message.c (_dbus_message_loader_get_is_corrupted): add
4671 mechanism to handle a corrupt message stream
4672 (_dbus_message_loader_new): fix preallocation to only prealloc,
4675 * dbus/dbus-string.c (_dbus_string_skip_blank): fix this function
4676 (_dbus_string_test): enhance tests for copy/move and fix the
4679 * dbus/dbus-transport-unix.c: Hold references in more places to
4680 avoid reentrancy problems
4682 * dbus/dbus-transport.c: ditto
4684 * dbus/dbus-connection.c (dbus_connection_dispatch_message): don't
4685 leak reference count in no-message case
4687 * test/watch.c (do_mainloop): handle adding/removing watches
4688 during iteration over the watches. Also, ref the connection/server
4689 stored on a watch, so we don't try to mangle a destroyed one.
4691 * dbus/dbus-transport-unix.c (do_authentication): perform
4694 * dbus/dbus-auth.c (get_state): add a state
4695 AUTHENTICATED_WITH_UNUSED_BYTES and return it if required
4696 (_dbus_auth_get_unused_bytes): append the unused bytes
4697 to the passed in string, rather than prepend
4699 * dbus/dbus-transport.c (_dbus_transport_init_base): create
4700 the auth conversation DBusAuth
4702 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd)
4703 (_dbus_transport_new_for_domain_socket): when creating a
4704 transport, pass in whether it's a client-side or server-side
4705 transport so we know which DBusAuth to create
4707 2002-12-03 Havoc Pennington <hp@pobox.com>
4709 * dbus/dbus-transport-unix.c (unix_finalize): finalize base
4710 _after_ finalizing the derived members
4711 (unix_connection_set): unref watch if we fail to add it
4713 * dbus/dbus-connection.c (dbus_connection_unref): delete the
4714 transport first, so that the connection owned by the
4715 transport will be valid as the transport finalizes.
4717 * dbus/dbus-transport-unix.c (unix_finalize): free the write_watch
4718 if necessary, and remove watches from the connection.
4720 * dbus/dbus-watch.c (_dbus_watch_list_free): improve a comment
4722 2002-12-26 Anders Carlsson <andersca@codefactory.se>
4724 * dbus/dbus-marshal.c: (_dbus_marshal_string),
4725 (_dbus_demarshal_double), (_dbus_demarshal_int32),
4726 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
4727 (_dbus_marshal_test):
4728 * dbus/dbus-marshal.h:
4729 Add string marshal functions and have the demarshal functions
4730 return the new position.
4732 2002-12-25 Havoc Pennington <hp@pobox.com>
4734 * doc/dbus-sasl-profile.txt: docs on the authentication protocol,
4735 it is a simple protocol that just maps directly to SASL.
4737 * dbus/dbus-auth.h, dbus/dbus-auth.c: authentication protocol
4738 initial implementation, not actually used yet.
4740 * dbus/dbus-string.c (_dbus_string_find): new function
4741 (_dbus_string_equal): new function
4742 (_dbus_string_base64_encode): new function
4743 (_dbus_string_base64_decode): new function
4745 2002-12-25 Anders Carlsson <andersca@codefactory.se>
4748 * dbus/dbus-marshal.c: (swap_bytes), (_dbus_marshal_double),
4749 (_dbus_marshal_int32), (_dbus_marshal_uint32),
4750 (_dbus_demarshal_double), (_dbus_demarshal_int32),
4751 (_dbus_demarshal_uint32), (_dbus_marshal_test):
4752 * dbus/dbus-marshal.h:
4753 * dbus/dbus-protocol.h:
4754 * dbus/dbus-test.c: (main):
4756 Add un-optimized marshalling/demarshalling routines.
4758 2002-12-25 Harri Porten <porten@kde.org>
4760 * qt/dbus-qt.h: adjusted ctor and getter to KDE/Qt conventions
4762 2002-12-24 Zack Rusin <zack@kde.org>
4764 * qt/dbus-qthread.cc: adding - integrates QMutex into Dbus
4765 * qt/dbus-qt.h: skeleton with two sample implemenatation of the
4768 2002-12-24 Havoc Pennington <hp@pobox.com>
4770 * glib/dbus-gthread.c: fix include
4772 * glib/dbus-glib.h: rename DBusMessageHandler for now.
4773 I think glib API needs to change, though, as you don't
4774 want to use DBusMessageFunction, you want to use the
4775 DBusMessageHandler object. Probably
4776 dbus_connection_open_with_g_main_loop()
4777 and dbus_connection_setup_g_main_loop() or something like that
4778 (but think of better names...) that just create a connection
4779 that has watch/timeout functions etc. already set up.
4781 * dbus/dbus-connection.c
4782 (dbus_connection_send_message_with_reply): new function just to
4783 show how the message handler helps us deal with replies.
4785 * dbus/dbus-list.c (_dbus_list_remove_last): new function
4787 * dbus/dbus-string.c (_dbus_string_test): free a string that
4790 * dbus/dbus-hash.c: use memory pools for the hash entries
4791 (rebuild_table): be more paranoid about overflow, and
4792 shrink table when we can
4793 (_dbus_hash_test): reduce number of sprintfs and write
4794 valid C89. Add tests for case where we grow and then
4795 shrink the hash table.
4797 * dbus/dbus-mempool.h, dbus/dbus-mempool.c: memory pools
4799 * dbus/dbus-connection.c (dbus_connection_register_handler)
4800 (dbus_connection_unregister_handler): new functions
4802 * dbus/dbus-message.c (dbus_message_get_name): new
4804 * dbus/dbus-list.c: fix docs typo
4806 * dbus/dbus-message-handler.h, dbus/dbus-message-handler.c:
4807 an object representing a handler for messages.
4809 2002-12-16 Anders Carlsson <andersca@codefactory.se>
4812 * glib/dbus-gthread.c: (dbus_gthread_init):
4813 Don't use the gdbus prefix for public functions.
4815 2002-12-16 Anders Carlsson <andersca@codefactory.se>
4819 Add GLib checks and fixup .pc files
4823 * glib/dbus-gmain.c: (gdbus_connection_prepare),
4824 (gdbus_connection_check), (gdbus_connection_dispatch),
4825 (gdbus_add_connection_watch), (gdbus_remove_connection_watch),
4826 (dbus_connection_gsource_new):
4827 * glib/dbus-gthread.c: (dbus_gmutex_new), (dbus_gmutex_free),
4828 (dbus_gmutex_lock), (dbus_gmutex_unlock), (dbus_gthread_init):
4829 * glib/test-dbus-glib.c: (message_handler), (main):
4832 2002-12-15 Harri Porten <porten@kde.org>
4834 * autogen.sh: check for libtoolize before attempting to use it
4836 * dbus/dbus-transport-unix.c: include <sys/time.h> for timeval
4839 * .cvsignore: ignore more stamp files
4841 * dbus/dbus-watch.c (_dbus_watch_list_new): fixed doc error
4843 * test/Makefile.am: added -I$(top_srcdir) to be able to compile
4844 without make install.
4846 2002-12-15 Havoc Pennington <hp@pobox.com>
4848 * dbus/dbus-threads.c: add thread stubs that a higher library
4849 layer can fill in. e.g. the GLib wrapper might fill them in with
4850 GThread stuff. We still need to use this thread API to
4851 thread-safe-ize the library.
4853 2002-12-12 Havoc Pennington <hp@pobox.com>
4855 * dbus/dbus-transport-unix.c, dbus/dbus-server-unix.c: use the
4856 below new interfaces and include fewer system headers.
4858 * dbus/dbus-sysdeps.c (_dbus_read): new function
4859 (_dbus_write): new function
4860 (_dbus_write_two): new function
4861 (_dbus_connect_unix_socket): new function
4862 (_dbus_listen_unix_socket): new function
4864 * dbus/dbus-message-internal.h: change interfaces to use
4867 2002-12-11 Havoc Pennington <hp@pobox.com>
4869 * dbus/dbus-types.h: add dbus_unichar
4871 * dbus/dbus-internals.c (_dbus_verbose): use _dbus_getenv
4873 * dbus/dbus-connection.c (dbus_connection_send_message): return
4876 * dbus/dbus-transport.c: include dbus-watch.h
4878 * dbus/dbus-connection.c: include dbus-message-internal.h
4880 * HACKING: add file with coding guidelines stuff.
4882 * dbus/dbus-string.h, dbus/dbus-string.c: Encapsulate all string
4883 handling here, for security purposes (as in vsftpd). Not actually
4884 using this class yet.
4886 * dbus/dbus-sysdeps.h, dbus/dbus-sysdeps.c: Encapsulate all
4887 system/libc usage here, as in vsftpd, for ease of auditing (and
4888 should also simplify portability). Haven't actually moved all the
4889 system/libc usage into here yet.
4891 2002-11-25 Havoc Pennington <hp@pobox.com>
4893 * dbus/dbus-internals.c (_dbus_verbose): fix to not
4894 always print the first verbose message.
4896 2002-11-24 Havoc Pennington <hp@pobox.com>
4898 * test/echo-client.c, test/echo-server.c: cheesy test
4901 * configure.in (AC_CHECK_FUNCS): check for writev
4903 * dbus/dbus-message.c (_dbus_message_get_network_data): new
4906 * dbus/dbus-list.c (_dbus_list_foreach): new function
4908 * dbus/dbus-internals.c (_dbus_verbose): new function
4910 * dbus/dbus-server.c, dbus/dbus-server.h: public object
4911 representing a server that listens for connections.
4913 * dbus/.cvsignore: create
4915 * dbus/dbus-errors.h, dbus/dbus-errors.c:
4916 public API for reporting errors
4918 * dbus/dbus-connection.h, dbus/dbus-connection.c:
4919 public object representing a connection that
4920 sends/receives messages. (Same object used for
4921 both client and server.)
4923 * dbus/dbus-transport.h, dbus/dbus-transport.c:
4924 Basic abstraction for different kinds of stream
4925 that we might read/write messages from.
4927 2002-11-23 Havoc Pennington <hp@pobox.com>
4929 * dbus/dbus-internals.h (_DBUS_INT_MAX): add _DBUS_INT_MIN
4932 * dbus/dbus-test.c (main): add list test, and include
4933 dbus-test.h as intended
4935 * dbus/dbus-hash.c (_dbus_hash_table_remove_string)
4936 (_dbus_hash_table_remove_int): return value indicates
4937 whether the entry existed to remove
4939 * dbus/dbus-list.c: add linked list utility class,
4942 * dbus/dbus-hash.c: add TODO item about shrinking the hash bucket
4945 2002-11-23 Havoc Pennington <hp@pobox.com>
4947 * Doxyfile.in (INCLUDE_FILE_PATTERNS): expand DBUS_BEGIN_DECLS/
4948 DBUS_END_DECLS to nothing, that should fix this once and for all
4950 * Doxyfile.in (JAVADOC_AUTOBRIEF): set to YES
4952 * dbus/dbus-message.c, dbus/dbus-hash.c:
4953 add some missing @brief
4955 2002-11-23 Havoc Pennington <hp@pobox.com>
4957 * dbus/dbus-message.h: put semicolons after DEBUG_BEGIN_DECLS
4958 to avoid confusing Doxygen
4960 * dbus/dbus-hash.c: @} not }@
4962 * dbus/dbus-message.c (struct DBusMessage): split out
4965 2002-11-23 Havoc Pennington <hp@pobox.com>
4967 * configure.in: pile on more warning flags if using gcc
4969 * Doxyfile.in (EXTRACT_STATIC): set to NO, so we don't have
4970 to document static functions
4972 * configure.in: add summary to end of configure so it
4973 looks nice and attractive
4975 * dbus/dbus-hash.c: finish implementation and write unit
4978 * configure.in: add --enable-tests to enable unit tests
4980 * dbus/dbus-test.c: test program to run unit tests
4981 for all files in dbus/*, initially runs a test for
4984 * dbus/dbus-internals.h: file to hold some internal utility stuff
4986 2002-11-22 Havoc Pennington <hp@redhat.com>
4988 * dbus/dbus-hash.c: copy in Tcl hash table, not yet
4989 "ported" away from Tcl
4991 * dbus/dbus-types.h: header for types such as dbus_bool_t
4993 2002-11-22 Havoc Pennington <hp@redhat.com>
4995 * dbus/dbus.h: fixups for doc warnings
4997 * Doxyfile.in (FILE_PATTERNS): we need to scan .h to pick up
4999 (QUIET): make it quiet so we can see warnings
5001 * dbus/dbus-memory.c: teach D-BUS to allocate and free memory
5003 2002-11-22 Havoc Pennington <hp@redhat.com>
5005 * Makefile.am: include "Doxyfile" target in all-local
5007 * configure.in: generate the Doxyfile
5009 * Doxyfile.in: move Doxyfile here, so we can use
5010 configure to generate a Doxyfile with the right
5013 2002-11-22 Havoc Pennington <hp@redhat.com>
5015 * dbus/dbus-message.c: move inline docs into .c file
5017 * Doxyfile (OUTPUT_DIRECTORY): move output to doc/api
5018 so all docs are under doc/
5019 (MAN_EXTENSION): generate man pages. Use extension
5020 ".3dbus" which matches ".3qt" on my system,
5021 I guess this is OK, I don't know really.
5022 (FILE_PATTERNS): look for .c files not .h, makes sense
5025 2002-11-22 Havoc Pennington <hp@pobox.com>
5027 * Makefile.am (SUBDIRS): rename subdir "server" to "bus"
5028 because any app can be a server, and any app can be a client,
5029 the bus is a special kind of server.
5031 Thu Nov 21 23:35:31 2002 Zack Rusin <zack@kde.org>
5033 * Doxyfile : adding. Still needs Makefile rules to be generated
5034 automatically (just run "doxygen" in the toplevel dir for now to
5037 * dbus/dbus-message.h : Adding sample docs (javadoc since
5038 resembles gtk-doc a little more)
5040 * dbus/dbus.h : Adding sample docs
5042 2002-11-21 Havoc Pennington <hp@redhat.com>
5044 * dbus/Makefile.am (INCLUDES): define DBUS_COMPILATION
5045 so we can allow ourselves to include files directly,
5046 instead of having to use dbus.h
5048 * dbus/dbus.h: fill in
5050 * dbus/dbus-message.h: sketch out a sample header file.
5051 Include griping if you include it directly instead of
5054 * dbus/dbus-macros.h: new file with macros for extern "C",
5055 TRUE/FALSE, NULL, etc.
5057 * doc/file-boilerplate.c: put include guards in here
5059 2002-11-21 Havoc Pennington <hp@redhat.com>
5061 * doc/file-boilerplate.c: include both AFL and GPL boilerplate.
5063 * COPYING: include the GPL as well, and license code
5064 under both AFL and GPL.
5066 2002-11-21 Havoc Pennington <hp@redhat.com>
5068 * acconfig.h: get rid of this
5070 * autogen.sh (run_configure): add --no-configure option
5072 * configure.in: remove AC_ARG_PROGRAM to make
5073 autoconf complain less. add AC_PREREQ.
5074 add AC_DEFINE third arg.
5076 2002-11-21 Anders Carlsson <andersca@codefactory.se>
5079 Fix references so we can distcheck.
5081 2002-11-21 Havoc Pennington <hp@redhat.com>
5083 * Initial module creation