1 2006-07-25 Paul Eggert <eggert@cs.ucla.edu>
3 * tests/cp/fail-perm: Use "chmod 0500" rather than "chmod 500".
4 Problem report and fix from Bob Proulx.
5 * NEWS: Clarify the "chmod 0500" news, and correct the vague
6 statements about compatibility with BSD.
8 2006-07-25 Jim Meyering <jim@meyering.net>
10 * src/ls.c (gobble_file): When handling a stat-failed entry,
11 print the entry name not the absolute_name -- to be consistent
13 * tests/ls/stat-failed: Update accordingly.
15 * src/ls.c: Add parens around the new uses of ?: ternary operator.
17 * src/dircolors.hin: Mention that ORPHAN refers not just to dangling
20 Get --dired offsets right when handling stat-failed entries.
21 * src/ls.c (print_long_format): Be careful to increment P by the
22 appropriate amount, even when inode_number_width and nlink_width
24 * tests/ls/stat-failed: Test for the above.
26 * src/ls.c (gobble_file) [USE_ACL]: Don't use-uninitialized the
27 have_acl member. That would happen for a directory with both a
28 non-stat'able entry and one with an ACL.
30 * src/ls.c (gobble_file): Make it so failure to stat a
31 non-command-line file provokes an exit status of 1, not 0.
32 Say "cannot access" rather than "cannot stat".
33 * tests/ls/stat-failed: New file/test, for the above.
34 * tests/ls/Makefile.am (TESTS): Add stat-failed.
35 * tests/ls-2/tests (no-a-isdir-b): Update to reflect addition
36 of "cannot access " to diagnostic.
38 * src/ls.c: Declare stat_failed to be "bool", not "int" everywhere.
40 * src/ls.c [enum filetype] (command_line): Remove member. Not needed.
41 Replace all occurrences of "type == command_line" with the
42 equivalent, "command_line_arg".
44 * src/ls.c: Apply the stat-failed parts of Red Hat's
45 coreutils-selinux.patch. From Ulrich Drepper.
46 This makes it so files not mentioned on the command line (e.g.,
47 names read from a directory that *is* mentioned on the command
48 line) for which stat fails are still listed. With --color,
49 such files are colored just like ORPHANs (aka dangling symlinks).
51 * src/df.c (n_valid_args): Declare global to be static.
53 2006-07-24 Jim Meyering <jim@meyering.net>
55 * tests/ls/stat-dtype: Skip this test on reiserfs, since that file
56 system lacks d_type support.
58 2006-07-22 Paul Eggert <eggert@cs.ucla.edu>
60 * man/chmod.x: Update to reflect recent changes to coreutils.texi.
62 2006-07-21 Jim Meyering <jim@meyering.net>
64 * src/su.c (usage): Correct typo in --help output: s/commmand/command/
65 Reported by Tim Waugh.
66 Also remove the comment duplicating much of --help output.
68 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): Reposition this new
69 name so the list remains alphabetized.
71 Fix another bug: ls --indicator-style=file-type would call
72 stat for a symlink, even though it wasn't always needed.
73 In some cases, that unnecessary stat would cause ls to fail.
74 * src/ls.c (gobble_file): Don't treat symlinks specially (in
75 requiring a stat syscall). Remove the offending exclusion.
77 * NEWS: Mention the fix.
79 * tests/ls/stat-dtype: New file/test, for the above fix.
80 Also exercises the new df feature, below.
82 * src/df.c (main): Fail and don't print the headers if no
83 file system is processed. This makes it easy to test whether
84 a specified directory is on a file system of a given type or types.
85 Otherwise, applications would have had to parse df's output.
86 E.g., is "." either ext3 or reiserfs: df -t ext3 -t reiserfs .
88 Fix a bug: ls --file-type worked like --indicator-style=slash,
89 rather than like --indicator-style=file-type.
90 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): New enum member.
91 (long_options): Map "file-type" to FILE_TYPE_INDICATOR_OPTION,
93 (decode_switches): Handle new case: FILE_TYPE_INDICATOR_OPTION.
94 * NEWS: Mention the fix.
95 * tests/ls-2/tests (file-type): New test, for the above fix.
97 2006-07-19 Jim Meyering <jim@meyering.net>
99 * src/ls.c (print_dir): Give a better diagnostic for failed opendir.
101 * Makefile.am (EXTRA_DIST): Add build-aux/vc-list-files.
103 2006-07-16 Paul Eggert <eggert@cs.ucla.edu>
105 * NEWS: chmod, install, and mkdir now leave setgid and setuid bits
106 of directories alone unless you specify them explicitly.
107 install and mkdir now implement X correctly.
108 install now creates parent directories with mode 755, without
109 changing their owner or group.
110 * src/chmod.c (process_file): Adjust to mode_adjust API change.
111 * src/install.c: Include mkancesdirs.h.
112 (announce_mkdir, make_ancestor): New functions.
113 (DEFAULT_MODE): New macro, specifying initial value of 'mode'.
115 (dir_mode, dir_mode_bits): New vars.
116 (main): Set dir modes separately from nondir, so that the X
117 op of -m works correctly.
118 (main): Remove cwd_errno cruft, since make_dir_parents no longer
119 affects cwd. Adjust to new make_dir_parents API.
120 (install_file_in_file_parents): 2nd arg is now char *, not char
121 const *. Use mkancesdirs instead of rolling our own code.
122 (change_attributes): Don't worry about AFS, since that kludge
123 should not be needed any more.
124 * src/mkdir.c (struct mkdir_options): New struct.
125 (announce_mkdir, make_ancestor): New functions.
126 (main): Use them. Adjust to mode_adjust API change. Stick with
127 umask 0. Use make_dir_parents for all the work.
128 * src/mkfifo.c (main): Adjust to new mode_adjust API.
129 * src/mknod.c (main): Likewise.
130 * tests/chmod/setgid: Do the setgid test instead of bailing.
131 * tests/mkdir/p-3: Remove re_protect case that no longer applies.
132 GNU chmod now behaves like other versions of chmod.
133 * tests/mkdir/perm: Add a test for the X bug.
135 2006-07-14 Paul Eggert <eggert@cs.ucla.edu>
137 * src/base64.c (do_decode): Output to parameter OUT, not to stdout.
138 This doesn't fix any bugs, since OUT always equals stdout, but it
139 makes the code easier to understand.
141 2006-07-14 Jim Meyering <jim@meyering.net>
143 * Makefile.maint (CVS_LIST): Use new file, build-aux/vc-list-files,
144 rather than open-coding it. Now supports mercurial, too.
145 * .hgignore: New file.
146 * Makefile.am (EXTRA_DIST): Add .hgignore, which ignores nearly
147 all generated files, including ones like configure and po/*.po
148 that are currently version-controlled in cvs.
150 * Makefile.am (EXTRA_DIST): Add a few more .??* files.
151 They've been in CVS, just haven't been distributed before this.
152 Distribute ChangeLog-2005, too.
153 (MAINTAINERCLEANFILES): Add THANKS-to-translators.
155 2006-07-11 Paul Eggert <eggert@cs.ucla.edu>
157 * src/system.h: Assume <dirent.h> exists, since gnulib assumes
160 2006-07-09 Jim Meyering <jim@meyering.net>
162 * tests/mv/dir2dir: Adjust so failing with ENOTEMPTY is ok, too.
163 That happens with Linux/tmpfs.
164 * tests/mv/Makefile.am (TESTS): Add dir2dir.
166 2006-07-09 Paul Eggert <eggert@cs.ucla.edu>
168 Adjust to recent updates from gnulib.
169 * src/dd.c (apply_translations): Use toupper rather than
170 islower followed by toupper; it's simpler and typically
171 faster now that we assume at least C89 semantics. Similarly
173 * src/sort.c (inittables): Likewise.
174 * src/expand.c (expand): Don't assume that isprint etc. return
175 booleans (needed for pre-C99 hosts).
176 * src/fmt.c (check_punctuation): Likewise.
177 * src/ptx.c (initialize_regex, fix_output_parameters): Likewise.
178 * src/tr.c (is_char_class_member): Likewise.
179 * src/unexpand.c (unexpand): Likewise.
180 * src/join.c (is_blank): Remove; no longer needed. All uses
181 replaced by isblank (to_uchar (...)).
182 * src/pinky.c (create_fullname): Don't assume char is unsigned.
183 * src/printf.c (print_esc): Likewise.
184 * src/ptx.c (SKIP_NON_WHITE, SKIP_WHITE, SKIP_WHITE_BACKWARDS):
185 (copy_unescaped_string): Likewise.
186 * src/stat.c (print_it): Likewise.
187 * src/system.h (_D_EXACT_NAMELEN): Renamed from NLENGTH, for
188 convenience on GNU systems. All uses changed. Don't bother
189 looking for any dirent.h substitute other than ndir.h.
190 (D_INO): Remove unnecessary parentheses.
191 (IN_CTYPE_DOMAIN, ISGRAPH, ISPRINT, ISALNUM, ISALPHA):
192 (ISCNTRL, ISLOWER, ISPUNCT, ISSPACE, ISUPPER, ISXDIGIT):
193 (ISDIGIT_LOCALE, TOLOWER, TOUPPER): Remove. All uses changed
194 to ctype.h equivalents.
195 (isblank): Renamed from ISBLANK. Check for HAVE_DECL_ISBLANK too.
198 2006-07-08 Jim Meyering <jim@meyering.net>
200 * tests/mv/dir2dir: New file, test for 2006-07-05 fix in copy.c.
202 * Makefile.maint (sc_the_the): New rule.
204 * src/dd.c (skip): Remove one of two adjacent "the"s in a comment.
205 * tests/Coreutils.pm (run_tests): Remove one of two adjacent "then"s
208 2006-07-07 Jim Meyering <jim@meyering.net>
210 * NEWS: Mention that mv can now remove an empty destination directory,
211 and give an example. Prompted by a report from Florent Bayle.
213 2006-07-05 Jim Meyering <jim@meyering.net>
215 * src/ls.c (usage): Correct the description of -G: it is useful
216 only in a long listing. Reported by Martin Pool in
217 <https://launchpad.net/distros/ubuntu/+source/coreutils/+bug/51653>.
219 * man/chmod.x: Correct the description of the sticky bit. Reported
220 by Chris Moore via Ian Jackson in <http://bugs.debian.org/376745>.
222 * src/copy.c (copy_internal): Don't work around old NFS clients like
223 SunOS-4.1.4 and Irix 5.3 that set errno to values like EIO and
224 ENOTEMPTY upon failed rename. Otherwise, we risk misinterpreting
225 a banal failure as a recursive move-into-self failure.
226 Reported by Florent Bayle in <http://bugs.debian.org/376749>.
228 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
230 2006-07-03 Jim Meyering <jim@meyering.net>
232 Plug another unusual leak.
233 (AD_mark_helper): Free malloc'd filename if hash_insert says
234 that string is already in the hash table.
236 The dev/inode of the topmost directory in each hierarchy were not
238 * src/remove.c (remove_cwd_entries): Don't call cycle_check here.
239 (AD_push): Call it from here instead.
242 * src/remove.c (AD_stack_clear): New function.
244 (AD_pop_and_chdir): Free *prev_dir just before longjmp.
246 * tests/Makefile.am, tests/*/Makefile.am: (TESTS_ENVIRONMENT):
247 Add $VG_PATH_PREFIX as a prefix to $PATH
249 * tests/envvar-check (vars): Add CDPATH and POSIXLY_CORRECT.
250 * tests/Makefile.am (evar-check): Remove rule.
251 (EXTRA_DIST): Remove .env-warn.
252 * tests/.env-warn: Remove file. No longer used.
253 Suggestion from Eric Blake.
255 2006-07-02 Paul Eggert <eggert@cs.ucla.edu>
257 * src/system.h: Include <stdint.h> unconditionally, since we
258 now assume the stdint module.
260 2006-07-01 Paul Eggert <eggert@cs.ucla.edu>
262 * NEWS: With no operand, 'tail -f' now silently ignores the '-f'
263 only if standard input is a FIFO or pipe and POSIXLY_CORRECT is set.
264 * src/tail.c (main): Implement this.
265 * tests/tail/Test.pm (f-pipe-1): Renamed from f-1.
266 (test_vector): Set POSIXLY_CORRECT for the f-pipe-* tests.
268 2006-07-01 Jim Meyering <jim@meyering.net>
270 * src/ln.c (do_link): Use new, shorter URL, for ag-review link.
272 * .x-sc_require_config_h: Add ^lib/xstrtold\.c$, so make distcheck
275 2006-06-30 Paul Eggert <eggert@cs.ucla.edu>
277 * NEWS: seq now uses long double internally rather than double.
278 It now defaults to a minimal fixed point format if possible.
279 It lets you use %a, %A, %E, %F, %G.
280 * src/Makefile.am (seq_LDADD): Remove $(SEQ_LIBM); add $(POW_LIB).
281 * src/seq.c: Don't include <math.h> or <xstrtol.h>; no longer needed.
282 (isfinite) [!defined isfinite]: New macro.
283 (separator, terminator): Now points to const.
284 (first, step, last): Remove.
285 (usage): Update to match new behavior.
286 (struct operand, operand): New type.
287 (scan_arg): Renamed from scan_double_arg, since we no longer use double.
289 Compute and return a value of type operand, not double.
290 (long_double_format): Renamed from valid_format, and now returns a
291 new format with an "L" added if needed, if the original format was
292 valid. Allow %a, %A, %E, %F, and %G formats.
293 (print_numbers): Take numeric values as args rather than from globals.
294 Print long double, not double.
295 (get_width_format): Remove.
296 (get_default_format): New function.
297 (main): Implement new way of calculating default format.
298 Don't worry about locale's representation of the decimal point, since
299 the arguments are always processed in the C locale.
300 * tests/seq/basic (neg-2): Adjust to new default format.
301 (eq-wid-1, eq-wid-2): Resurrect these tests, since the new
302 implementation should do the right thing.
304 2006-06-30 Jim Meyering <jim@meyering.net>
306 * tests/stty/basic-1: Work around an intermittent test failure
307 on HP-UX 11.11. Report and analysis from Bob Proulx.
308 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7475
310 2006-06-28 Paul Eggert <eggert@cs.ucla.edu>
312 * NEWS: Support obsolete usages like "sort +1 -2" even when
313 conforming to POSIX 1003.1-2001, since this is a pure extension to
314 POSIX. Problem reported by Christian in:
315 http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00220.html
316 * src/sort.c (main): Implement this.
318 * src/system.h (CLOSEDIR): Remove. All uses changed to closedir.
319 Autoconf 2.60 says this stuff was obsolete.
321 2006-06-28 Jim Meyering <jim@meyering.net>
323 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
325 2006-06-28 Bob Proulx <bob@proulx.com> (tiny change)
327 * tests/mv/i-link-no: Work around HP-UX /bin/sh tracing problem
328 (set -x when VERBOSE=yes) when stderr is redirected before stdout
329 causing shell tracing of the stdout redirection to be written to
330 the stderr file. Avoid problem and test failure on HP-UX by
331 redirecting stderr last.
332 * tests/dd/unblock-sync: Order shell file redirections for
333 stderr and stdout in the common style.
336 2006-06-27 Jim Meyering <jim@meyering.net>
338 * tests/misc/cat-proc: Try to avoid any spurious numeric
339 differences in frequently-changing /proc/cpuinfo.
340 Reported by Nelson Beebe.
342 2006-06-26 Jim Meyering <jim@meyering.net>
344 Attempt rmdir (actually, unlinkat-with-AT_REMOVEDIR) upon any
345 fd_to_subdirp failure, not just when errno == EACCES.
346 * src/remove.c (remove_dir): Use unlinkat-with-AT_REMOVEDIR, not
347 rmdir, here, even though rmdir may happen to be adequate.
349 * NEWS: rm no longer fails to remove an empty, unreadable directory
350 * src/remove.c (remove_cwd_entries): If we can't open a directory,
351 and the failure is not being ignored, try to remove the directory
352 with rmdir (aka unlinkat-with-AT_REMOVEDIR), in case it's empty.
353 Problem report and test case from Paul Eggert in
354 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7425>.
356 * tests/rm/empty-inacc: New test, for the above.
358 Avoid a segfault for wc --files0=- < /dev/null.
359 * src/wc.c (compute_number_width): Return right away if nfiles == 0.
361 2006-06-25 Jim Meyering <jim@meyering.net>
363 * NEWS: wc accepts a new option --files0-from=FILE, where FILE
364 contains a list of NUL-separated file names.
366 * src/wc.c: Include "readtokens.h".
367 (usage): Describe the new option, and adjust the `Usage':
368 with this option, no FILE may be specified on the command line.
369 (main): Handle the new option.
370 * tests/misc/wc-files0: New tests, for the above.
371 * tests/misc/wc-files0-from: Likewise.
372 * tests/misc/Makefile.am (TESTS): Add wc-files0.
374 2006-06-24 Jim Meyering <jim@meyering.net>
376 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
378 2006-06-22 Jim Meyering <jim@meyering.net>
380 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
381 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
383 2006-06-19 Jim Meyering <jim@meyering.net>
385 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
386 so this check is not run as part of "make distcheck".
388 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
390 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
392 2006-06-18 Jim Meyering <jim@meyering.net>
394 * tests/misc/pwd-long: Make error output a little clearer.
396 2006-06-17 Jim Meyering <jim@meyering.net>
398 * tests/rm/inaccessible: Skip this test on systems without openat
399 support. Reported by Bob Proulx.
401 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
403 * tests/misc/mknod: Improve permission checks to handle
404 running mkdir test in set-gid directories.
406 2006-06-14 Jim Meyering <jim@meyering.net>
408 * tests/du/basic: Revamp not to hard-code file system block sizes.
410 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
412 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
415 2006-06-11 Jim Meyering <jim@meyering.net>
417 * .gitignore: New file.
418 * Makefile.am (EXTRA_DIST): Add .gitignore.
420 Setting TIME_STYLE=long-iso in the environment would make the
421 cp/same-file test fail.
422 * tests/envvar-check (vars): Add TIME_STYLE to the list.
423 * tests/cp/same-file: Revert last change.
424 Source the envvar-check script, to ensure that TIME_STYLE
425 settings don't affect these tests.
427 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
429 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
430 uses POSIX time stamp formats. Problem reported by John Nixon in
431 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
433 2006-06-10 Jim Meyering <jim@meyering.net>
435 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
437 Require a "Version N.M" line at the top of the ChangeLog
438 file only when making the actual release, not when running
440 * Makefile.maint (maintainer-distcheck): Don't depend on
442 (alpha beta major): Depend on it here, instead.
444 2006-06-08 Jim Meyering <jim@meyering.net>
446 Ensure that cat works with any of the options, -A -v -e -E -T,
447 when applied to files in /proc and /sys, even when the FIONREAD
448 ioctl produces nonsensical results. Before this change, cat would
449 produce no output (or truncated output), for some linux kernels.
451 * src/cat.c (write_pending): New function, factored out of cat.
452 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
453 that there are bytes to read. Some versions of linux-2.6.16 do that.
454 Write any pending output before returning.
455 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
456 * NEWS: Mention this bug fix.
457 * tests/misc/cat-proc: New file. Test for the above.
458 * tests/misc/Makefile.am (TESTS): Add cat-proc.
460 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
462 * src/expr.c (eval4): Detect overflow properly when multiplying
465 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
467 * NEWS: The 'expr' command now detects and reports integer overflow.
468 (It would be better to use extended precision instead, but that
470 * src/expr.c (integer_overflow): New function.
471 (eval4, eval3): Check for integer overflow.
473 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
475 Fix problems when building with Solaris/SVR4/etc. make, which uses a
476 different and somewhat bogus implementation of VPATH. In the
477 directory tests/misc, rename tests whose names might appear in the
478 Automake-generated rules. For example, we can't use a test named
479 'test', since Automake generates a rule that contains the text
480 "if test -f ./$$tst; ...", and this might expand to something like
481 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
482 which executes the 'test' script rather than the 'test' command.
483 * tests/misc/false-status: Renamed from tests/misc/false.
484 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
485 * tests/misc/sort-merge: Renamed from tests/misc/sort.
486 ($prog): Set to 'sort' rather than to $PROG.
487 * tests/misc/test-diag: Renamed from tests/misc/test.
488 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
489 in case Solaris make has prepended the directory.
490 (TESTS): Adjust to above renamings.
491 * tests/misc/expand: Don't assign to PROG; no longer needed
492 now that Makefile.am sets PROG to the basename.
493 * tests/misc/fold: Likewise.
495 2006-06-03 Jim Meyering <jim@meyering.net>
497 Make `cp --link --no-dereference' work also on systems where the
498 link system call cannot create a hard link to a symbolic link.
499 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
500 the link syscall on a symlink when it would do the wrong thing.
501 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
502 * tests/cp/link-no-deref: New file/test for the above.
503 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
504 * NEWS: Mention the change (doesn't affect Linux).
506 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
508 Fix some porting problems in the test cases reported by
509 Ralf Wildenhues for HP-UX 11.23 in:
510 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
511 * tests/help-version: Don't assume that \< \> works in sed.
512 * tests/misc/close-stdout: Don't assume that >&- works.
513 Add a /dev/full test.
514 * tests/touch/no-create-missing: Don't assume that >&- works.
516 2006-05-30 Jim Meyering <jim@meyering.net>
518 * src/ls.c (usage): Add `v' to the list of sorting-related options.
521 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
523 * tests/cp/fail-perm: source lang-default.
524 * tests/rm/inaccessible: Likewise.
526 2006-05-28 Jim Meyering <jim@meyering.net>
528 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
529 Recognize it, too. Reported by Ralf Wildenhues, in
530 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
532 2006-05-27 Jim Meyering <jim@meyering.net>
534 * src/chgrp.c: Support new options: --preserve-root and
535 --no-preserve-root. Somehow this program was skipped when those
536 options were added to chown, chmod, and rm. Reported by
537 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
538 * NEWS: Mention this.
540 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
542 * NEWS: Remove mention of --seed. We'll replace it with something
543 better, and don't want to indicate that it is supported.
544 * src/sort.c (usage): Likewise.
546 2006-05-20 Jim Meyering <jim@meyering.net>
548 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
550 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
551 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
552 FTS_COMFOLLOW. Spotted by Justin Pryzby.
554 * gnupload: Merge changes from automake, retaining the ""--to...
555 kludge to placate overzealous `make distcheck' check.
557 2006-05-19 Jim Meyering <jim@meyering.net>
559 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
560 FTS_TIGHT_CYCLE_CHECK directory traversal option.
561 Reported by Justin Pryzby in http://bugs.debian.org/367691
563 2006-05-15 Jim Meyering <jim@meyering.net>
565 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
568 2006-05-13 Jim Meyering <jim@meyering.net>
570 * tests/mv/no-target-dir: Test two more cases.
572 2006-05-11 Jim Meyering <jim@meyering.net>
574 mv -T DIR EMPTY_DIR no longer fails unconditionally
575 * src/copy.c (copy_internal): Don't manually prohibit a move where
576 the destination is an existing directory. Sometimes doing that is
577 valid. Let the rename system call enforce the rules. That is
578 allowed only when the source is a directory and the destination
579 directory (to be replaced) is empty. Reported by Eric Blake.
580 * tests/mv/no-target-dir: New file/test for this.
581 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
582 * NEWS: Mention this.
584 * tests/mv/atomic: New file/test for yesterday's fix.
585 * tests/mv/Makefile.am (TESTS): Add atomic.
587 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
589 2006-05-10 Jim Meyering <jim@meyering.net>
591 * src/copy.c (copy_internal): Don't explicitly unlink the destination
592 when moving a symlink into the place of an existing non-directory.
593 Reported by Joshua Hudson.
594 * NEWS: mention this.
596 2006-05-07 Jim Meyering <jim@meyering.net>
598 * Makefile.maint (patch-check): Fail if patch generates any output,
599 even merely for changed offsets.
601 * src/c99-to-c89.diff: Adjust to reflect new offsets.
603 * NEWS: Mention changes affecting df, pwd, shred.
605 2006-05-06 Jim Meyering <jim@meyering.net>
607 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
608 system condition where dirent.d_ino != stat.st_ino.
609 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
611 2006-05-06 Eric Blake <ebb9@byu.net>
613 * tests/ls/inode: Expand to test inode from readdir case.
614 * tests/ls/follow-slink: Expand to test broken links encountered
615 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
617 2006-05-06 Eric Blake <ebb9@byu.net>
619 * tests/mv/leak-fd: Work even on case-insensitive file system.
621 2006-05-04 Jim Meyering <jim@meyering.net>
623 * NEWS: Mention the 2006-03-19 pwd-related change that makes
624 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
626 2006-05-03 Jim Meyering <jim@meyering.net>
628 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
629 Use better macro parameter names: s/basename/key_name/,
630 s/basefunc/key_cmp_func. Fix typo in comment.
632 2006-04-29 Eric Blake <ebb9@byu.net>
634 * src/ls.c (main): On systems with d_type, directories_first only
635 implies format_needs_type, not format_needs_stat.
637 2006-05-03 Jim Meyering <jim@meyering.net>
639 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
640 after comma in arg list, from Eric Blake.
642 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
644 * tests/misc/date (relative-3): New test, derived from a bug
645 report by John Thomas McDole.
647 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
649 New option for ls: --group-directories-first.
650 It makes ls list directories before files.
651 * NEWS [New features]: Mention it.
652 * src/ls.c (sort_type): Rearrange to use as an array index when
653 choosing sort function; added new sort_numtypes member for
655 (time_type): Add new time_numtypes member for compile-time check.
656 (directories_first): New global variable.
657 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
658 (long_options): Add --directories-first.
659 (main): Support new option.
660 (is_directory): New function.
661 (extract_dirs_from_files): Use it.
662 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
663 (LIST_SORTFUNCTION_VARIANTS): New macros.
664 (sort_functions): New global variable.
665 (sort_files): Use it.
666 (usage): Document new option.
668 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
670 * src/shred.c (fillrand): The assertion was way too weak, due to
671 what must be a typo. Strengthen it to its intended value.
672 (dopass): Don't use alloca; it's not worth the aggravation here,
673 since it's used only to get a page-aligned buffer, and page
674 alignment doesn't buy us much here. I'm suspicious that alloca
675 causes problems on some hosts, due to a recent bug report by Adam
676 Waltman: http://bugs.gentoo.org/130246.
678 2006-04-18 Jim Meyering <jim@meyering.net>
680 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
681 sha384sum, sha512sum.
683 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
685 * src/chmod.c (describe_change): Adjust to filemode changes.
686 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
687 (print_long_format): Use (new) filemodestring rather than
688 (old) mode_string, so that we get more file types right, at least
689 in theory. Adjust to filemode changes.
690 * src/stat.c (human_access): Likewise.
692 2006-04-18 Jim Meyering <jim@meyering.net>
694 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
695 ignore file. This has never been enabled. Reported by Eric Blake.
697 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
699 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
700 bug in Interix. Just call symlink or link directly. All uses changed.
701 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
702 * src/stat.c (USE_STATVFS): New macro.
703 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
704 (NAMEMAX_FORMAT): define a bit more clearly, now that the
705 statvfs-using code is a bit more regular.
706 * src/system.h (sync) [!HAVE_SYNC]: New macro.
708 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
710 * NEWS: csplit, nl, expr now conform to POSIX better, and are
711 more-compatible with traditional Unix, with respect to regular
713 * src/csplit.c (extract_regexp): Set re_syntax_options to a
714 value that is compatible with what POSIX requires.
715 * src/nl.c (build_type_arg): Likewise.
716 * src/expr.c (docolon): Likewise. Also, don't let anchors match
717 newline; this fixes an incompatibility with tradition and with POSIX.
718 Don't warn about leading ^. POSIX says it is unspecified whether
719 ^ is a special character, which means that implementations can
720 either treat it as special or not, but either way a warning is not
721 allowed (unless the regexp is otherwise invalid). Instead, anchor
722 the expression but treat ^ as an anchor; this is the traditional
723 behavior (e.g., Solaris 10).
724 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
725 and the like as invalid expressions (exit status 2), not as
726 failure of 'expr' (exit status 3). This is more consistent with
728 * tests/expr/basic (fail-a): Adjust exit status to match new expr
729 behavior, for status 2 versus 3.
731 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
732 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
733 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
734 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
735 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
736 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
737 (bre61, bre62): New tests.
738 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
742 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
743 "if !". Do not assume that 'sed' can handle long, newline-free input.
744 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
746 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
748 Adjust to new regex.h API (with new fastmap type), and clean
749 up the regex storage allocation a bit.
751 * src/csplit.c (struct control): Put re_compiled member at the
752 end, since it's large. Change regexpr member from char * to bool;
753 all uses changed. Add new member fastmap.
754 (extract_regexp): regexp arg is now char const *, not char *.
755 Don't bother duplicating the regular expression; it's not needed.
756 Set fastmap from new fastmap member. Don't bother allocating
757 a buffer, as the regexp code does a better job than we do.
758 * src/expr.c (docolon): Allocate and use a fastmap.
759 Don't bother allocating a buffer.
760 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
762 (build_type_arg): New fastmap arg. All uses changed.
763 Don't bother allocating a buffer, but set a fastmap.
764 * src/ptx.c (context_regex_string, word_regex_string): Remove.
765 (context_regex, word_regex): New vars, replacing the above.
767 (struct regex_data): New type.
768 (compile_regex): Renamed from alloc_and_compile_regex, since
769 we no longer allocate storage. Arg is now a struct regex_data *,
770 not a const char *. All uses changed. Don't allocate the fastmap;
771 instead, take it from the caller. Don't convert size_t to int,
772 to avoid arithmetic overflow problems. Don't bother freeing
773 storage afterwards; it's not worth the aggravation.
774 * src/tac.c (compiled_separator_fastmap): New ver.
775 (main): Use it. Don't bother allocating a buffer.
777 2006-03-30 Jim Meyering <jim@meyering.net>
779 * src/dd.c (iwrite): Remove assignment without effect.
780 Reported by Felix Rauch Valenti.
782 2006-03-22 Eric Blake <ebb9@byu.net>
784 * src/ptx.c (usage): Remove mention of --copyright/-C.
785 (main): Alias --copyright to --version plus a deprecation warning.
786 * NEWS: Mention this.
788 2006-03-27 Jim Meyering <jim@meyering.net>
790 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
791 use of strtod. Tiny patch from Nickolai Zeldovich.
793 2006-03-11 Eric Blake <ebb9@byu.net>
795 * tests/misc/dirname: New file.
796 * tests/basename/Makefile.am: Delete.
797 * tests/basename/basic: Move to...
798 * tests/misc/basename: ... this new file. Add some tests,
799 including fixed behavior for //.
800 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
801 * tests/Makefile.am (SUBDIRS): Remove basename.
802 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
804 Improvements to dirname/basename handling on platforms like
805 cygwin with distinct // and with drive letters.
806 * NEWS: Document new behavior.
807 * src/basename.c (main): Don't strip suffix from file system
809 * src/cp.c (target_directory_operand): Use new last_component.
810 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
811 traversing the string.
812 * src/dircolors.c (guess_shell_syntax): Use new last_component.
813 * src/install.c (target_directory_operand, install_file_in_dir):
815 * src/ln.c (target_directory_operand, main): Likewise.
816 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
817 * src/mv.c (target_directory_operand, movefile): Likewise.
818 * src/remove.c (rm_1): Likewise.
819 * src/shred.c (wipename): Likewise.
820 * src/split.c (next_file_name): Likewise.
821 * src/su.c (log_su, run_shell): Likewise.
823 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
825 * NEWS: nohup diagnostics are now more precise, and nohup now
826 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
827 * src/nohup.c (main): Implement this.
828 * tests/misc/nohup: Test the new behavior.
830 2006-03-12 Jim Meyering <jim@meyering.net>
832 * src/copy.c (set_author): Rename function, from preserve_author.
834 * src/remove.c (AD_pop_and_chdir): Use new macro,
835 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
837 * src/system.h (SAME_INODE): Remove definition.
838 Include "same-inode.h", instead.
840 2006-03-11 Eric Blake <ebb9@byu.net>
842 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
844 2006-03-10 Jim Meyering <jim@meyering.net>
846 Fix a bug whereby a user with write access to a directory being removed
847 could cause the removal of that directory to fail with an erroneous
848 diagnostic about a directory cycle. Reported by Vineet Chadha.
850 * NEWS: Mention this.
851 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
852 leave (and try to rmdir) is the one whose dev_ino is being used to
853 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
855 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
857 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
858 * src/dd.c (set_fd_flags): Handle file-creation flags on file
859 descriptors, rather than ignoring them.
860 * tests/dd/misc: Add test cases for append, nofollow, directory,
861 and nolinks flags. Simplify redirection to /dev/null in some cases.
863 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
864 noatime test never tested anything.
866 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
868 * src/dd.c (flags, usage): New flags directory, nolinks.
869 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
871 * src/ls.c (usage): Mention that -f disables --color.
872 Problem reported by Niels Möller.
874 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
876 * man/*.x: Add references to syscalls from utilities of the same name.
878 2006-03-05 Jim Meyering <jim@meyering.net>
880 * tests/help-version: Set SHELL, if not already set, in order to
881 avoid failure when `make check' is run through debuild; dircolors
882 would fail due to lack of $SHELL. Reported by Sven Joachim.
884 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
885 * src/base64.c (wrap_write, do_encode, main): Change type of
886 parameters and locals, wrap_column, form size_t to uintmax_t.
887 (main): Adjust to use xstrtoumax, accordingly.
889 2006-03-03 Jim Meyering <jim@meyering.net>
891 Don't fail when run from an environment with SHELL not a Bourne
892 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
893 * tests/dircolors/simple: Invoke each non-failing test with -b.
894 Reported by Michael Stone.
896 2006-02-27 Jim Meyering <jim@meyering.net>
898 * tests/misc/base64: Derive --decode-using tests from the
901 * tests/misc/base64: Factor out a long constant string.
902 Split lines to stay within 80 columns.
904 * tests/misc/Makefile.am (TESTS): Add base64.
905 * tests/misc/base64: Test base64. From Simon Josefsson.
907 * src/base64.c (do_decode): Use correct type for parameter,
908 ignore_garbage: s/size_t/bool/.
910 * src/base64.c: Don't include .h files already included by system.h:
911 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
912 Include "system.h" before the other lib/*.h header files.
913 Include <sys/types.h> before "system.h".
914 (wrap_write): Remove declaration of unused local, initial_column.
915 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
917 * README: Add base64 to the list.
919 2006-02-17 Simon Josefsson <jas@extundo.com>
922 * AUTHORS: Mention base64.
924 * man/Makefile.am: Build base64.1.
925 * man/base64.x: New file.
926 * src/Makefile.am (bin_PROGRAMS): Add base64.
927 * src/base64.c: New file.
929 2006-02-25 Eric Blake <ebb9@byu.net>
931 In ls, avoid calling stat for --inode (-i), when possible.
932 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
933 * src/system.h: ... here, for use in ...
934 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
936 (gobble_file): Add inode argument.
937 (print_dir): Pass inode if available.
938 (usage): Remove inaccuracy.
940 2006-02-23 Jim Meyering <jim@meyering.net>
942 * TODO: Update/correct some obsolete entries.
944 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
946 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
947 * src/join.c (usage): Likewise.
948 Documentation problem reported by Philip Kensche.
950 2006-02-20 Eric Blake <ebb9@byu.net>
952 * man/rm.x: Update documentation to match previous patch.
954 2006-02-18 Eric Blake <ebb9@byu.net>
956 New option for rm: --interactive=once (-I).
957 * NEWS: Document it, along with change to rm --interactive.
958 * TODO: Remove entry for implementing rm -I
959 * src/rm.c (INTERACTIVE_OPTION): New enum value.
960 (interactive_type): New enum.
961 (long_opts): Let interactive take an optional argument.
962 (interactive_args, interactive_types): New option arguments.
963 (usage): Document -I, --interactive=WHEN. Use program_name
964 instead of a basename.
965 (main): New -I option, new behavior to --interactive.
966 * tests/rm/interactive-once: New tests.
967 * tests/rm/interactive-always: Ditto.
968 * tests/rm/Makefile.am (TESTS): Run them.
970 2006-02-18 Jim Meyering <jim@meyering.net>
972 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
973 expression match more of the target lines, e.g., those that start with
974 `-S,' (short option followed by a comma) or that include `=[...]'.
975 Patch by Nicolas François.
976 Fix the four offenders thus exposed:
977 * src/join.c (usage): Use two spaces (not one) to separate the
978 --first-only option string from its description, so help2man formats
979 the derived man page properly.
980 * src/pr.c (usage): Likewise.
981 * src/uniq.c (usage): Likewise.
982 * src/install.c (usage): Likewise.
984 2006-02-15 Jim Meyering <jim@meyering.net>
986 * Makefile.maint (alpha beta major): For `make major', ensure that the
987 version string is of the form N.N[.N]*, where N is one or more digits.
989 2006-02-14 Jim Meyering <jim@meyering.net>
991 * INSTALL: Update from gnulib.
993 2006-02-13 Jim Meyering <jim@meyering.net>
995 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
997 2006-02-12 Jim Meyering <jim@meyering.net>
999 * Makefile.maint (patch-check): New target.
1000 (local-checks-available): Add to the list.
1002 2006-02-11 Jim Meyering <jim@meyering.net>
1004 * src/c99-to-c89.diff: New file.
1005 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
1007 * .x-po-check: New file, with exclusions so that `make distcheck'
1009 * Makefile.am (EXTRA_DIST): Add .x-po-check.
1011 rm -r must remove an empty directory, even if it is inaccessible.
1012 * src/remove.c (close_preserve_errno): New function.
1013 (fd_to_subdirp): Don't print a diagnostic in this function.
1014 Do it from the callers instead, unless rmdir succeeds.
1015 (remove_cwd_entries, remove_dir): Adjust callers.
1016 * tests/rm/empty-inacc: New test for the above.
1017 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
1018 * NEWS: Mention this bug fix.
1019 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
1020 a tiny bit less precise: cannot remove `a/1': ... instead of
1021 cannot open directory `a/1': ...
1023 * Makefile.maint (syntax-check-rules): Automatically derive this
1024 list of sc_-prefixed rule names.
1026 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
1028 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
1029 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
1030 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
1031 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
1032 go away? was that an accident?)
1033 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
1034 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
1035 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
1036 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
1037 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
1038 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
1039 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
1040 (author_mark_check, makefile_path_separator_check):
1041 Output line numbers, to simplify navigation of Emacs *compilation*
1043 (sc_prohibit_atoi_atof, sc_file_system):
1044 Rework slightly so that Makefile.maint doesn't get reported as a
1045 violation of its own syntax rules.
1046 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
1047 it at run-time (which didn't work with Bison). Fix a makefile typo,
1048 caught by Makefile.maint itself: spaces where a tab should be.
1049 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
1050 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
1051 Ignore djgpp and man subdirectories, to avoid false matches with
1052 Bison and coreutils, respectively. Use sort -u to remove the
1053 resulting duplicates.
1054 * gnupload: Rework slightly to avoid bogus warning from
1055 sc_two_space_separator_in_usage.
1057 2006-02-10 Jim Meyering <jim@meyering.net>
1059 Use gzip's --rsyncable option only if it's available.
1060 * Makefile.maint (gzip_rsyncable): New variable.
1063 2006-02-08 Jim Meyering <jim@meyering.net>
1065 * Makefile.maint (local-checks-available): Define in terms of
1066 the expansion, $(syntax-check-rules), rather than the single,
1067 top-level target `syntax-check', so that it's easier to exclude
1068 individual rules (via $(local-checks-to-skip)).
1069 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
1071 2006-02-07 Jim Meyering <jim@meyering.net>
1073 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
1074 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
1076 * tests/help-version (expected_failure_status_vdir):
1077 Redirect an expected disk-full diagnostic to /dev/null.
1079 2006-02-06 Jim Meyering <jim@meyering.net>
1081 * src/unexpand.c (usage): Use two spaces (not one) to separate the
1082 --first-only option string from its description, so help2man formats
1083 the derived man page properly.
1084 * src/rm.c (usage): Likewise for --no-preserve-root.
1085 * src/chown.c (usage): Likewise.
1086 * src/chgrp.c (usage): Likewise.
1088 Add a rule to ensure that the above doesn't happen again.
1089 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
1090 (syntax-check-rules): Add it.
1091 * .x-sc_two_space_separator_in_usage: New empty file.
1092 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
1094 2006-02-06 Jim Meyering <jim@meyering.net>
1096 * src/cp.c (usage): Use two spaces (not one) to separate each
1097 option string from its description, so help2man formats the
1098 derived man page properly.
1099 * src/mv.c (usage): Likewise.
1100 Patch from Nicolas François in http://bugs.debian.org/351601.
1102 2006-02-04 Jim Meyering <jim@meyering.net>
1104 * src/copy.c (copy_internal): cp -RL would fail when encountering
1105 the same directory more than once in the hierarchy beneath a single
1106 command-line argument. That is legitimate, e.g. when there are
1107 two or more symbolic links, each pointing to some directory that
1108 would not otherwise be copied. Reported by Christophe LYON.
1109 * tests/cp/cp-deref: New file. Test for today's fix.
1110 * tests/cp/Makefile.am (TESTS): Add cp-deref.
1111 * NEWS: Document this.
1113 2006-02-03 Jim Meyering <jim@meyering.net>
1115 * configure.ac: Require automake-1.9.6, not 1.8.3.
1117 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
1119 * src/od.c (usage): Mention that -t a ignores high order bit.
1120 Documentation problem reported by Ed Avis.
1122 2006-02-01 Jim Meyering <jim@meyering.net>
1124 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
1126 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
1128 * src/head.c (main): Use a better diagnostic when someone uses a
1129 trailing numeric option in an invalid way. Problem reported by
1131 * src/tail.c (parse_options): Likewise.
1133 2006-01-30 Jim Meyering <jim@meyering.net>
1135 * man/wc.x: Include `count' keyword in man page synopsis,
1136 per suggestion from http://bugs.debian.org/181585.
1138 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
1140 * src/df.c (show_dev): If the file system claims to have
1141 more available than total blocks, report the number of used
1142 blocks as being total - available (a negative number) rather
1143 than as garbage. Problem reported by Toralf Foerster.
1145 2006-01-24 Jim Meyering <jim@meyering.net>
1147 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
1148 to put a regular file in O_NONBLOCK mode fails with EPERM.
1149 That happens on Linux (up to 2.6.15) when using tail -f on a file with
1150 the append-only attribute. Reported by Dean Gaudet. For details,
1151 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
1152 * NEWS: Mention this fix.
1153 * tests/tail-2/append-only: New file. Test for the above.
1154 * tests/tail-2/Makefile.am (TESTS): Add append-only.
1155 * tests/Makefile.am (check-root): Add tail-2/append-only
1157 2006-01-21 Jim Meyering <jim@meyering.net>
1159 * NEWS: Mention fts-related improvements and bug fixes.
1161 2006-01-19 Jim Meyering <jim@meyering.net>
1163 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
1164 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
1166 2006-01-18 Jim Meyering <jim@meyering.net>
1168 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
1170 2006-01-17 Jim Meyering <jim@meyering.net>
1172 Now that fts no longer changes the current working directory, adjust
1173 its clients accordingly -- note that du.c uses fts but doesn't need
1174 any adjustment, since it doesn't operate on the actual files,
1175 but rather just uses the stat buffers provided by fts.
1177 * src/chown-core.c: Include "openat.h".
1178 Don't include "lchown.h".
1179 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
1180 calling openat, lchownat, chownat, rather than open, lchown, chown.
1182 * src/chmod.c: Include "openat.h".
1183 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
1185 * tests/du/long-from-unreadable: New test, to exercise one small
1188 2006-01-13 Jim Meyering <jim@meyering.net>
1190 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
1191 addition of new directories under tests/.
1193 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
1196 2006-01-12 Jim Meyering <jim@meyering.net>
1198 * tests/du/long-sloop: Adjust not to hard-code the expected
1199 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
1200 from that of GNU libc. Reported by Paul Eggert.
1202 * tests/du/long-sloop: Create file at end of symlink chain.
1204 * tests/misc/test: New file, with a test for one of the
1205 bugs fixed by yesterday's test.c changes.
1206 * tests/misc/Makefile.am (TESTS): Add test.
1208 2006-01-11 Jim Meyering <jim@meyering.net>
1210 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
1211 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
1212 a very long sequence of symbolic links (not necessarily a loop).
1213 * tests/du/Makefile.am (TESTS): Add long-sloop.
1215 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
1217 * src/test.c (test_syntax_error): Append a newline. All callers
1218 changed, except for the ones that didn't already append a newline.
1219 Bug reported by Eric Blake.
1221 2006-01-11 Jim Meyering <jim@meyering.net>
1223 * src/system.h (X2NREALLOC): Now that verify_true is no longer
1224 void, cast its result to void, to avoid gcc's warning that
1225 ``left-hand operand of comma expression has no effect''.
1226 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
1228 2006-01-10 Jim Meyering <jim@meyering.net>
1230 * tests/chmod/no-x: Add a test for today's fts.c fix.
1232 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
1234 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
1235 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
1237 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
1239 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
1240 Use verify_true instead of verify_expr, to sync with gnulib.
1242 2006-01-08 Jim Meyering <jim@meyering.net>
1244 * src/date.c (usage): Adjust the formatting of the entries for
1245 %::z and %:::z (separate with two spaces, not one) so that help2man
1246 formats them properly. Reported by Philip Rowlands.
1248 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
1250 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
1252 2006-01-06 Jim Meyering <jim@meyering.net>
1254 * Makefile.maint (copyright-check): Use date +%Y in place of
1257 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
1258 First off, the attribute should have been `volatile' (not static)
1259 to avoid longjmp-related risk of clobber. Secondly, now there is
1260 no longer any risk of a local variable being clobbered, so there's
1261 no need for any attribute at all.
1263 2006-01-05 Jim Meyering <jim@meyering.net>
1265 * src/remove.c: Give a few functions the inline attribute.
1266 (AD_pop_and_chdir): Use gotos to avoid some duplication.
1267 (AD_push): Rewrite an assertion so that the entire computation
1268 goes away when assertions are turned off.
1270 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
1271 It's already defined in "system.h".
1272 * Makefile.maint: Add a FIXME comment.
1274 2006-01-04 Jim Meyering <jim@meyering.net>
1276 * ChangeLog: Remove entries from 2005-10-22 and earlier.
1277 * ChangeLog-2005: New file, for entries up to version 5.92.
1279 2006-01-03 Jim Meyering <jim@meyering.net>
1281 * tests/du/no-x: Also allow a slightly different diagnostic -- the
1282 one you get when using openat-enabled fts.c and du (coming soon).
1283 * tests/chmod/no-x: Likewise.
1284 * tests/chgrp/no-x: Likewise.
1286 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
1288 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
1290 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
1291 (restricted_chown): Return it, if the file cannot be accessed due
1292 to EPERM, or if no uid or gid are required, or if the file is
1293 neither a directory nor a regular file. Rewrite to avoid gotos.
1294 (change_file_owner): Handle RC_do_ordinary_chown case.
1295 Rewrite to avoid gotos.
1296 * tests/chgrp/basic: Make sure we can change the group of
1299 * src/date.c (usage): Explain %g, %G, and %V a bit better.
1301 2006-01-02 Jim Meyering <jim@meyering.net>
1303 * src/copy.c (set_owner): Correct a comment.
1305 * src/tail.c (parse_options): Change warning to say that --retry
1306 is useful `mainly' (not `only') when following by name.
1307 Reported here: http://bugs.debian.org/273781
1309 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
1311 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
1312 * src/copy.c: Include lchmod.h.
1313 (copy_internal): Use lchmod rather than chmod.
1314 * src/cp.c: Include lchmod.h.
1315 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
1316 * src/mkdir.c: Include lchmod.h.
1317 (usage): Clarify -m's operation.
1318 (main): Use lchmod rather than chmod. Don't use lchmod unless the
1319 new mode contains bits outside the 777 range.
1320 * src/mkfifo.c (usage): Clarify -m's operation.
1321 (main): If -m is given, don't invoke chmod; use umask 0 instead.
1322 Report an error if -m asks for bits outside the 777 range.
1323 * src/mknod.c (usage, main): Likewise.
1325 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
1327 2005-12-27 Jim Meyering <jim@meyering.net>
1329 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
1330 (sc_prohibit_assert_without_use): New rule.
1331 (syntax-check-rules): Add it to the list.
1332 * .x-sc_prohibit_assert_without_use: New empty file.
1333 * Makefile.am (EXTRA_DIST): Add it.
1335 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
1337 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
1338 Don't include <assert.h>; it wasn't used.
1340 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
1342 * src/chown-core.c (restricted_chown):
1343 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
1344 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
1345 | O_NOFOLLOW too, for consistency with other dir-openers.
1346 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
1347 (is_empty_dir): Likewise.
1348 * src/shred.c (wipename): Likewise. Don't bother trying to open
1349 dir for writing, since POSIX prohibits it.
1351 2005-12-22 Jim Meyering <jim@meyering.net>
1353 * tests/help-version: Redirect stderr to /dev/full, to suppress
1354 write error diagnostic.
1356 2005-12-19 Jim Meyering <jim@meyering.net>
1358 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
1359 Avoid a minor race condition when `-m MODE' is specified, by using
1360 open, fchown, and close rather than just chown. To do that reliably --
1361 even with an overly restrictive umask -- ensure that each mkdir,
1362 mknod and mkfifo call uses a mode including at least owner-read access.
1363 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
1364 the subsequent chown (or equivalent open,fchown,close) fails.
1365 * tests/misc/mknod: New tests.
1366 * tests/misc/Makefile.am (TESTS): Add mknod.
1368 2005-12-17 Jim Meyering <jim@meyering.net>
1370 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
1371 e.g., on a named pipe.
1372 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
1373 place of all uses, since it is guaranteed (system.h) to be defined.
1375 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
1377 Add POSIX ACL support
1378 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
1379 is no requirement for ACL support; particularly, it does not exist
1380 on systems that have POSIX ACLs.
1381 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1382 * src/cp.c (umask_kill): With default acls, the umask is not to be
1383 applied. Remove umask_kill, don't change the process umask, and let
1384 the kernel apply the umask where appropriate.
1385 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1386 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1388 (copy_reg, copy_internal): Use copy_acl and set_acl
1389 instead of fchown/chown. Fix the logic for POSIX ACLs.
1390 (chown_succeded): Remove; we now always copy acls and
1391 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1392 did a chown before or not.
1393 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1394 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1395 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1396 to link with it via $(LIB_ACL), for the utilities that need it.
1398 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1400 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1401 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1402 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1403 value is now signified by whether cwd_errno is null.
1404 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1405 pointer-to-bool to pointer-to-errno-value. All callers changed.
1406 (rm_1): Don't bother setting a local cwd failure flag and then
1407 ORing it into the caller's. Just set the caller's.
1408 (rm): Use cwd failure errno value to print a slightly-better
1411 2005-12-15 Jim Meyering <jim@meyering.net>
1413 * src/stat.c (print_it): Properly handle a backslash at the
1414 end of a --printf format string. Reported by Paul Eggert.
1415 * tests/misc/stat-printf (end-bs): Add a test for the above.
1417 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1419 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1420 Don't assume /etc/passwd contains user names; use 'id' instead.
1422 2005-12-15 Jim Meyering <jim@meyering.net>
1424 stat: revert behavior of --format=FMT (-c)
1425 stat: add new option: --printf=FMT
1426 * NEWS: Mention this.
1427 * src/stat.c (isodigit, octtobin, hextobin): Define.
1428 (PRINTF_OPTION): Define.
1429 (interpret_backslash_escapes, trailing_delim): New globals.
1430 (usage): Document them. Alphabetize on long option names.
1431 (print_esc_char): New function.
1432 (print_it): Rewrite, in order to handle backslash escapes.
1433 (main): Handle new option. Set globals for --format, too.
1435 * tests/misc/stat-printf: Test --printf and --format.
1436 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1438 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1440 * NEWS: sort now reports incompatible options.
1441 * src/sort.c (incompatible_options, check_ordering_compatibility):
1443 (main): Use them. Don't bother with a usage message for
1444 "sort -c a b", for consistency with other error diagnostics.
1445 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1448 * src/cat.c (main): Undo previous change. close_stdout already
1449 does the check, so the previous change wasn't necessary.
1451 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1453 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1455 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1457 Install a more-conservative approach for sort -R. It's the
1458 same basic idea as the existing code, except it uses the full ISAAC
1459 approach (called the "more kosher" approach in the existing comments).
1460 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1461 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1462 better to be conservative here at first, and review any performance
1463 improvements carefully.
1464 * .x-sc_require_config_h: Add src/rand-isaac.c.
1465 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1466 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1467 (shred_SOURCES, sort_SOURCES): Remove.
1468 (EXTRA_DIST): Add rand-isaac.c.
1469 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1470 changing it to allow for varying numbers of words in the state.
1471 Alter so that we include rand-isaac.c directly rather than
1472 compiling it and linking to it. Don't include config.h or
1473 system.h; that's the includer's responsibility.
1474 Omit functions that are specific to shred.
1475 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1476 (isaac_step, struct irand_state):
1477 Resurrect these, with the same defns that used to be in shred.c.
1478 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1479 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1481 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1482 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1483 (irand_init, irand32, irand_mod):
1484 Number of words is constant again.
1485 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1486 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1487 * src/sort.c: Likewise.
1488 * src/shred.c (fillrand, dopass, main): Undo previous change.
1489 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1491 * src/sort.c: Don't include md5.h; it wasn't needed.
1492 (struct keyfield): Rename random_hash to random, for consistency
1493 with the other member names. All uses changed.
1494 (usage): Tweak wording to mention STRING for --seed option.
1495 (short_options): Rorder for consistency with other programs.
1496 (rand_state): Now a struct, not a pointer to one. All uses changed.
1497 (HASH_WORDS, HASH_SIZE): Remove.
1498 (get_hash): Remove comments around resbuf size, since we can assume C89.
1499 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1500 (keycompare): Adjust to the new get_hash.
1502 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1503 (main): Don't set need_random simply because gkey has it set; that
1504 doesn't necessarily mean we'll need random numbers.
1505 Redo seeding to match new get_hash approach.
1507 2005-12-10 Jim Meyering <jim@meyering.net>
1509 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1511 Avoid shred segfault on 64-bit systems.
1512 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1513 local of type uint32_t. Make the local an `int' instead.
1515 * NEWS: Mention sort's new options.
1517 * src/rand-isaac.c (isaac_mix): Declare to be static.
1518 Mark all other functions as `extern' so the tight-scope
1519 part of `make distcheck' passes once again.
1520 * src/rand-isaac.h (isaac_mix): Remove declaration.
1522 * src/sort.c (get_hash): Change position of `*' in parameter
1523 type to conform with convention.
1524 (main): Split a long line so it fits in 80 columns.
1525 (keycompare): Remove stray SPACE before TAB that was
1526 causing `make distcheck' to fail.
1528 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1530 * tests/misc/sort-rand: New file: basic tests for the new options.
1531 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1533 2005-12-10 Frederik Eaton <frederik@ofb.net>
1535 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1536 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1537 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1538 Make state size runtime-configurable.
1539 (isaac_new, isaac_copy): New functions.
1540 * src/rand-isaac.h: New file.
1541 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1542 (fillrand, main): Adjust to the fact that the state size is now
1543 runtime-configurable.
1544 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1545 (usage): Add options --random-sort and --seed to implement a random
1547 Include md5.h and rand-isaac.h.
1548 (get_hash): New function.
1549 (rand_state): New var.
1550 (HASH_WORDS, HASH_SIZE): New macros.
1552 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1554 * tests/dd/misc: Add test for dd iflags=noatime.
1556 2005-12-09 Jim Meyering <jim@meyering.net>
1558 * src/sort.c (usage): Mention white space vs -b and -t options.
1561 2005-12-09 Eric Blake <ebb9@byu.net>
1563 * src/test.c (main): Fix misleading comment.
1565 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1567 * NEWS: Mention dd's new noatime flag.
1568 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1569 * src/dd.c (flags, usage): Add support for noatime flag.
1571 2005-12-07 Jim Meyering <jim@meyering.net>
1573 Distribute the cvsu script, used only by `make syntax-check'.
1574 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1575 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1576 distribute a copy of this script.
1577 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1579 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1580 to create a temporary directory on another partition.
1581 From Andreas Gruenbacher.
1583 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1585 * man/basename.x: Cross-reference to dirname and readlink.
1586 * man/dirname.x: Cross-reference to basename and readlink.
1588 2005-12-05 Andreas Gruenbacher
1590 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1591 (set_owner, preserve_author): New functions, factored out of copy_reg.
1592 (copy_reg): Use them.
1593 (copy_internal): Use them here, too.
1595 2005-12-04 Jim Meyering <jim@meyering.net>
1597 * src/sleep.c (usage): Say what happens with two or more arguments.
1598 Suggested by Justin Pryzby.
1600 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1603 2005-12-03 Jim Meyering <jim@meyering.net>
1605 * src/rm.c (long_opts): Change the name of each undocumented, for-
1606 testing-only option to start with `-', so that it cannot render
1607 ambiguous any prefix it happens to share with some other option name.
1608 Problem reported by Eric Blake.
1609 * src/head.c (long_options): Likewise.
1610 * src/tail.c (long_options): Likewise.
1612 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1613 testing-only --presume* options to start with `---'.
1614 * tests/rm/dangling-symlink: Likewise.
1615 * tests/rm/dir-no-w: Likewise.
1616 * tests/rm/isatty: Likewise.
1618 2005-11-30 Jim Meyering <jim@meyering.net>
1620 * Makefile.maint: Add a comment about cvsu.
1622 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1624 * NEWS: df updates for "none", "proc", inaccessible file systems.
1625 * src/df.c (show_point): Ignore inaccessible file systems.
1626 (usage): -a includes dummy file systems, not size-0 file systems.
1628 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1629 to avoid collision with POSIX name space. All uses changed.
1631 2005-11-24 Jim Meyering <jim@meyering.net>
1633 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1634 * tests/acl: Add `$0: ' prefix to diagnostics.
1636 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1638 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1640 * src/copy.c: Improve performance a bit by optimizing away
1641 unnecessary system calls and going to a block size of at least
1642 8192 (on normal hosts, anyway). This improved performance 5% on my
1643 Debian stable host (2.4.27 kernel, x86, copying from root
1644 ext3 file system to itself).
1645 Include "buffer-lcm.h".
1646 (copy_reg): Omit last argument. All callers changed.
1647 Use xmalloc to allocate rather than trusting alloca
1648 (which is unwise with large block sizes).
1649 Declare locals more locally, if possible.
1650 Use uintptr_t words instead of int words, for a bit more speed
1651 when looking for null blocks on 64-bit hosts.
1652 Optimize away reads of zero bytes on regular files.
1653 In the typical case, insist on 8 KiB buffers, at least.
1654 Avoid unnecessary extra call to fstat when checking for sparse files.
1655 Avoid now-unnecessary cast to off_t, and "0L".
1656 Avoid unnecessary test of *new_dst when checking for same owner
1659 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1661 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1663 2005-11-22 Jim Meyering <jim@meyering.net>
1665 * src/remove.c (AD_push): Remove debugging cruft.
1667 * tests/rm/unread2 (rm): Change expected diagnostic,
1668 `cannot open directory' to `cannot remove', to align with
1670 * tests/rm/rm2: Ensure that rm now continues removing entries
1671 even after certain types of failure.
1673 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1674 that provide openat (Solaris), and on systems like Linux+procfs
1675 where our openat emulation code is reentrant. This also fixes a
1676 few low-probability leaks and eliminates some code that could,
1677 in very unusual circumstances, cause rm() (via a callee) to exit.
1678 * NEWS: Mention this.
1680 * configure.ac: Put copyright dates all on one line so the
1681 emacs function that updates them works properly.
1683 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1685 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1686 Problem reported by Eric Blake.
1687 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1688 we get a standard-conforming compiler. This relies on the new
1689 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1690 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1691 m4/c.m4 can go away with Autoconf 2.60 comes out.
1693 2005-11-17 Jim Meyering <jim@meyering.net>
1695 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1696 (AD_mark_current_as_unremovable): Likewise, but for a local.
1699 * tests/mv/acl: Let traps handle removing temporary directories.
1701 Expect acl-related tests to fail, until the corresponding
1702 patches are committed.
1703 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1704 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1706 ACL tests, from Andreas Gruenbacher.
1707 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1708 * tests/mv/Makefile.am (TESTS): Add acl.
1709 * tests/cp/Makefile.am (TESTS): Add acl.
1711 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1713 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1715 * NEWS: Improve quality of ln's diagnostics.
1716 * src/ln.c (do_link, usage): Likewise.
1717 (do_link): Don't use alloca on a buffer of unbounded size.
1719 2005-11-16 Jim Meyering <jim@meyering.net>
1721 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1722 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1723 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1724 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1725 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1727 2005-11-14 Jim Meyering <jim@meyering.net>
1729 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1731 2005-11-13 Jim Meyering <jim@meyering.net>
1733 * announce-gen: Accept new option, --gpg-key-id=ID and
1734 emit a blurb telling how to use the .sig files.
1735 * Makefile.cfg (gpg_key_ID): Define.
1736 * Makefile.maint (announcement): Use new option and key.
1738 Require that most .c files include <config.h>.
1739 * Makefile.maint (sc_require_config_h): New rule.
1740 (syntax-check-rules): Add it.
1741 * .x-sc_require_config_h: New file listing exceptions to the
1742 above rule. Some are legit, others are simply grandfathered in.
1743 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1745 2005-11-12 Jim Meyering <jim@meyering.net>
1747 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1749 2005-11-11 Jim Meyering <jim@meyering.net>
1751 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1752 Mention new readlink options in 5.3.0's `New features' section.
1753 Spotted by Thomas Hood.
1755 2005-11-08 Jim Meyering <jim@meyering.net>
1757 * NEWS: Merge in changes from b5_9x branch.
1759 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1761 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1762 like --time-style='posix-long-iso' if the locale settings are messed up.
1763 * src/ls.c (decode_switches): Implement this.
1765 2005-11-08 Jim Meyering <jim@meyering.net>
1767 * tests/du/2g: s/expensive/very expensive/ in a comment.
1770 2005-10-17 Eric Blake <ebb9@byu.net>
1772 * src/ls.c (usage): Fix descriptions of --sort, --time.
1773 Reported by Vitaly A. Ostanin.
1775 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1777 * src/ln.c: Include filenamecat.c.
1778 (FILE_BASENAME_CONCAT): Remove.
1779 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1780 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1781 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1784 2005-11-04 Jim Meyering <jim@meyering.net>
1786 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1787 on systems with stat.st_blocks of a signed 32-bit type.
1788 This bug causes trouble on some AIX 5.1 systems.
1789 Report and trivial patch from Paul Townsend:
1790 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1791 * NEWS: Mention this.
1793 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1794 * tests/du/Makefile.am (TESTS): Add it here.
1795 * tests/very-expensive: New file.
1796 * tests/Makefile.am (EXTRA_DIST): Add it here.
1797 * tests/cp/perm: Mark this test as `very-expensive', too.
1799 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1801 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1803 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1805 * src/rm.c (usage): Don't mention rm -d.
1807 2005-11-02 Jim Meyering <jim@meyering.net>
1809 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1810 From Andreas Schwab.
1812 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1813 `M+N records in/out' lines don't pollute `make check' output.
1815 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1816 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1817 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1818 to indicate that the input file should be piped into the command
1819 under test (via `cat FILE | $prog ...').
1821 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1822 (without -r) fails to remove a directory on a non-Linux system.
1823 This change affects only newer Solaris systems (with priv_*
1824 functions like priv_allocset). Reported by Keith Thompson.
1826 * tests/rm/dir-nonrecur: New file/test for the above fix.
1827 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1829 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1831 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1832 POSIX 1002.1-2001 requires.
1833 * src/tail.c (parse_obsolete_option): Implement this.
1834 Problem reported by Vincent Lefevre.
1835 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1836 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1837 (test_vector): Add special cases for _POSIX2_VERSION, and
1838 regularize the old ones a bit.
1839 * tests/touch/obsolescent: Add y2000 test.
1841 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1843 * src/dd.c (skip): Fix off-by-one error reported by
1844 Theodoros V. Kalamatianos.
1846 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1848 * tests/mkdir/p-3: Require that the test be run as non-root.
1849 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1851 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1853 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1854 boundary between DEST and SOURCE in the result.
1856 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1858 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1859 back to text, to sync with documentation and for backwards
1862 2005-10-25 Jim Meyering <jim@meyering.net>
1864 * tests/dircolors/simple (other-wr): Add an explicit test for
1865 the dircolors bug (NULL-dereference) fixed yesterday.
1867 2005-10-24 Jim Meyering <jim@meyering.net>
1869 * src/tac.c (tac_file): When determining whether a file is seekable,
1870 also test whether it is a tty. Using only the lseek-based test would
1871 give a false positive on Solaris. Reported by Peter Fales.
1873 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1875 * tests/install/d-slashdot: New test, for "install -d" failure.
1876 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1877 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1878 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1880 2005-10-24 Jim Meyering <jim@meyering.net>
1882 * src/dircolors.c (ls_codes): Add missing comma.
1883 Anonymous report and patch from
1884 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1886 * src/dircolors.c: Add compile-time assertion that the slack_codes
1887 and ls_codes arrays have the same number of elements. This would
1888 have prevented the above-fixed bug.
1890 * src/expand.c (parse_tab_stops): Add a comment to make this function
1891 identical to the one in unexpand.c.
1892 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1893 identical to the one in expand.c.
1895 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1897 2005-10-23 Jim Meyering <jim@meyering.net>
1899 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1900 a dangerous pointer-value-to-`unsigned' cast.
1901 * NEWS: mention the new sha* programs.
1902 * AUTHORS: Add new sha* programs.
1904 2005-08-28 David Madore <david.madore@ens.fr>
1906 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1907 * README: Add their names to the list.
1908 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1909 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1910 Rules for compiling sha-2 utilities
1911 (noinst_HEADERS): Remove checksum.h.
1912 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1914 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1915 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1916 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1917 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1918 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1919 sha384sum, sha512sum test scripts here rather that each in its
1922 2005-08-28 David Madore <david.madore@ens.fr>
1924 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1925 of the FIPS test vectors).
1927 2005-10-23 Jim Meyering <jim@meyering.net>
1929 * configure.ac: Use 6.0-cvs as the version string.
1930 * NEWS: Adjust accordingly.