1 2006-05-11 Jim Meyering <jim@meyering.net>
5 mv -T DIR EMPTY_DIR no longer fails
6 * src/copy.c (copy_internal): Don't manually prohibit a move where
7 the destination is an existing directory. Sometimes doing that is
8 valid. Let the rename system call enforce the rules. That is
9 allowed only when the source is a directory and the destination
10 directory (to be replaced) is empty. Reported by Eric Blake.
11 * tests/mv/no-target-dir: New file/test for this.
12 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
14 * tests/mv/atomic: New file/test for yesterday's fix.
15 * tests/mv/Makefile.am (TESTS): Add atomic.
17 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
19 2006-05-10 Jim Meyering <jim@meyering.net>
21 * src/copy.c (copy_internal): Don't explicitly unlink the destination
22 when moving a symlink into the place of an existing non-directory.
23 Reported by Joshua Hudson.
26 2006-05-07 Jim Meyering <jim@meyering.net>
28 * Makefile.maint (patch-check): Fail if patch generates any output,
29 even merely for changed offsets.
31 * src/c99-to-c89.diff: Adjust to reflect new offsets.
33 * NEWS: Mention changes affecting df, pwd, shred.
35 2006-05-06 Jim Meyering <jim@meyering.net>
37 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
38 system condition where dirent.d_ino != stat.st_ino.
39 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
41 2006-05-06 Eric Blake <address@hidden>
43 * tests/ls/inode: Expand to test inode from readdir case.
44 * tests/ls/follow-slink: Expand to test broken links encountered
45 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
47 2006-05-06 Eric Blake <ebb9@byu.net>
49 * tests/mv/leak-fd: Work even on case-insensitive file system.
51 2006-05-04 Jim Meyering <jim@meyering.net>
53 * NEWS: Mention the 2006-03-19 pwd-related change that makes
54 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
56 2006-05-03 Jim Meyering <jim@meyering.net>
58 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
59 Use better macro parameter names: s/basename/key_name/,
60 s/basefunc/key_cmp_func. Fix typo in comment.
62 2006-04-29 Eric Blake <ebb9@byu.net>
64 * src/ls.c (main): On systems with d_type, directories_first only
65 implies format_needs_type, not format_needs_stat.
67 2006-05-03 Jim Meyering <jim@meyering.net>
69 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
70 after comma in arg list, from Eric Blake.
72 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
74 * tests/misc/date (relative-3): New test, derived from a bug
75 report by John Thomas McDole.
77 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
79 New option for ls: --group-directories-first.
80 It makes ls list directories before files.
81 * NEWS [New features]: Mention it.
82 * src/ls.c (sort_type): Rearrange to use as an array index when
83 choosing sort function; added new sort_numtypes member for
85 (time_type): Add new time_numtypes member for compile-time check.
86 (directories_first): New global variable.
87 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
88 (long_options): Add --directories-first.
89 (main): Support new option.
90 (is_directory): New function.
91 (extract_dirs_from_files): Use it.
92 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
93 (LIST_SORTFUNCTION_VARIANTS): New macros.
94 (sort_functions): New global variable.
96 (usage): Document new option.
98 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
100 * src/shred.c (fillrand): The assertion was way too weak, due to
101 what must be a typo. Strengthen it to its intended value.
102 (dopass): Don't use alloca; it's not worth the aggravation here,
103 since it's used only to get a page-aligned buffer, and page
104 alignment doesn't buy us much here. I'm suspicious that alloca
105 causes problems on some hosts, due to a recent bug report by Adam
106 Waltman: http://bugs.gentoo.org/130246.
108 2006-04-18 Jim Meyering <jim@meyering.net>
110 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
111 sha384sum, sha512sum.
113 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
115 * src/chmod.c (describe_change): Adjust to filemode changes.
116 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
117 (print_long_format): Use (new) filemodestring rather than
118 (old) mode_string, so that we get more file types right, at least
119 in theory. Adjust to filemode changes.
120 * src/stat.c (human_access): Likewise.
122 2006-04-18 Jim Meyering <jim@meyering.net>
124 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
125 ignore file. This has never been enabled. Reported by Eric Blake.
127 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
129 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
130 bug in Interix. Just call symlink or link directly. All uses changed.
131 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
132 * src/stat.c (USE_STATVFS): New macro.
133 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
134 (NAMEMAX_FORMAT): define a bit more clearly, now that the
135 statvfs-using code is a bit more regular.
136 * src/system.h (sync) [!HAVE_SYNC]: New macro.
138 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
140 * NEWS: csplit, nl, expr now conform to POSIX better, and are
141 more-compatible with traditional Unix, with respect to regular
143 * src/csplit.c (extract_regexp): Set re_syntax_options to a
144 value that is compatible with what POSIX requires.
145 * src/nl.c (build_type_arg): Likewise.
146 * src/expr.c (docolon): Likewise. Also, don't let anchors match
147 newline; this fixes an incompatibility with tradition and with POSIX.
148 Don't warn about leading ^. POSIX says it is unspecified whether
149 ^ is a special character, which means that implementations can
150 either treat it as special or not, but either way a warning is not
151 allowed (unless the regexp is otherwise invalid). Instead, anchor
152 the expression but treat ^ as an anchor; this is the traditional
153 behavior (e.g., Solaris 10).
154 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
155 and the like as invalid expressions (exit status 2), not as
156 failure of 'expr' (exit status 3). This is more consistent with
158 * tests/expr/basic (fail-a): Adjust exit status to match new expr
159 behavior, for status 2 versus 3.
161 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
162 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
163 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
164 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
165 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
166 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
167 (bre61, bre62): New tests.
168 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
172 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
173 "if !". Do not assume that 'sed' can handle long, newline-free input.
174 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
176 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
178 Adjust to new regex.h API (with new fastmap type), and clean
179 up the regex storage allocation a bit.
181 * src/csplit.c (struct control): Put re_compiled member at the
182 end, since it's large. Change regexpr member from char * to bool;
183 all uses changed. Add new member fastmap.
184 (extract_regexp): regexp arg is now char const *, not char *.
185 Don't bother duplicating the regular expression; it's not needed.
186 Set fastmap from new fastmap member. Don't bother allocating
187 a buffer, as the regexp code does a better job than we do.
188 * src/expr.c (docolon): Allocate and use a fastmap.
189 Don't bother allocating a buffer.
190 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
192 (build_type_arg): New fastmap arg. All uses changed.
193 Don't bother allocating a buffer, but set a fastmap.
194 * src/ptx.c (context_regex_string, word_regex_string): Remove.
195 (context_regex, word_regex): New vars, replacing the above.
197 (struct regex_data): New type.
198 (compile_regex): Renamed from alloc_and_compile_regex, since
199 we no longer allocate storage. Arg is now a struct regex_data *,
200 not a const char *. All uses changed. Don't allocate the fastmap;
201 instead, take it from the caller. Don't convert size_t to int,
202 to avoid arithmetic overflow problems. Don't bother freeing
203 storage afterwards; it's not worth the aggravation.
204 * src/tac.c (compiled_separator_fastmap): New ver.
205 (main): Use it. Don't bother allocating a buffer.
207 2006-03-30 Jim Meyering <jim@meyering.net>
209 * src/dd.c (iwrite): Remove assignment without effect.
210 Reported by Felix Rauch Valenti.
212 2006-03-22 Eric Blake <ebb9@byu.net>
214 * src/ptx.c (usage): Remove mention of --copyright/-C.
215 (main): Alias --copyright to --version plus a deprecation warning.
216 * NEWS: Mention this.
218 2006-03-27 Jim Meyering <jim@meyering.net>
220 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
221 use of strtod. Tiny patch from Nickolai Zeldovich.
223 2006-03-11 Eric Blake <ebb9@byu.net>
225 * tests/misc/dirname: New file.
226 * tests/basename/Makefile.am: Delete.
227 * tests/basename/basic: Move to...
228 * tests/misc/basename: ... this new file. Add some tests,
229 including fixed behavior for //.
230 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
231 * tests/Makefile.am (SUBDIRS): Remove basename.
232 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
234 Improvements to dirname/basename handling on platforms like
235 cygwin with distinct // and with drive letters.
236 * NEWS: Document new behavior.
237 * src/basename.c (main): Don't strip suffix from file system
239 * src/cp.c (target_directory_operand): Use new last_component.
240 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
241 traversing the string.
242 * src/dircolors.c (guess_shell_syntax): Use new last_component.
243 * src/install.c (target_directory_operand, install_file_in_dir):
245 * src/ln.c (target_directory_operand, main): Likewise.
246 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
247 * src/mv.c (target_directory_operand, movefile): Likewise.
248 * src/remove.c (rm_1): Likewise.
249 * src/shred.c (wipename): Likewise.
250 * src/split.c (next_file_name): Likewise.
251 * src/su.c (log_su, run_shell): Likewise.
253 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
255 * NEWS: nohup diagnostics are now more precise, and nohup now
256 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
257 * src/nohup.c (main): Implement this.
258 * tests/misc/nohup: Test the new behavior.
260 2006-03-12 Jim Meyering <jim@meyering.net>
262 * src/copy.c (set_author): Rename function, from preserve_author.
264 * src/remove.c (AD_pop_and_chdir): Use new macro,
265 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
267 * src/system.h (SAME_INODE): Remove definition.
268 Include "same-inode.h", instead.
270 2006-03-11 Eric Blake <ebb9@byu.net>
272 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
274 2006-03-10 Jim Meyering <jim@meyering.net>
276 Fix a bug whereby a user with write access to a directory being removed
277 could cause the removal of that directory to fail with an erroneous
278 diagnostic about a directory cycle. Reported by Vineet Chadha.
280 * NEWS: Mention this.
281 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
282 leave (and try to rmdir) is the one whose dev_ino is being used to
283 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
285 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
287 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
288 * src/dd.c (set_fd_flags): Handle file-creation flags on file
289 descriptors, rather than ignoring them.
290 * tests/dd/misc: Add test cases for append, nofollow, directory,
291 and nolinks flags. Simplify redirection to /dev/null in some cases.
293 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
294 noatime test never tested anything.
296 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
298 * src/dd.c (flags, usage): New flags directory, nolinks.
299 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
301 * src/ls.c (usage): Mention that -f disables --color.
302 Problem reported by Niels Möller.
304 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
306 * man/*.x: Add references to syscalls from utilities of the same name.
308 2006-03-05 Jim Meyering <jim@meyering.net>
310 * tests/help-version: Set SHELL, if not already set, in order to
311 avoid failure when `make check' is run through debuild; dircolors
312 would fail due to lack of $SHELL. Reported by Sven Joachim.
314 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
315 * src/base64.c (wrap_write, do_encode, main): Change type of
316 parameters and locals, wrap_column, form size_t to uintmax_t.
317 (main): Adjust to use xstrtoumax, accordingly.
319 2006-03-03 Jim Meyering <jim@meyering.net>
321 Don't fail when run from an environment with SHELL not a Bourne
322 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
323 * tests/dircolors/simple: Invoke each non-failing test with -b.
324 Reported by Michael Stone.
326 2006-02-27 Jim Meyering <jim@meyering.net>
328 * tests/misc/base64: Derive --decode-using tests from the
331 * tests/misc/base64: Factor out a long constant string.
332 Split lines to stay within 80 columns.
334 * tests/misc/Makefile.am (TESTS): Add base64.
335 * tests/misc/base64: Test base64. From Simon Josefsson.
337 * src/base64.c (do_decode): Use correct type for parameter,
338 ignore_garbage: s/size_t/bool/.
340 * src/base64.c: Don't include .h files already included by system.h:
341 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
342 Include "system.h" before the other lib/*.h header files.
343 Include <sys/types.h> before "system.h".
344 (wrap_write): Remove declaration of unused local, initial_column.
345 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
347 * README: Add base64 to the list.
349 2006-02-17 Simon Josefsson <jas@extundo.com>
352 * AUTHORS: Mention base64.
354 * man/Makefile.am: Build base64.1.
355 * man/base64.x: New file.
356 * src/Makefile.am (bin_PROGRAMS): Add base64.
357 * src/base64.c: New file.
359 2006-02-25 Eric Blake <ebb9@byu.net>
361 In ls, avoid calling stat for --inode (-i), when possible.
362 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
363 * src/system.h: ... here, for use in ...
364 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
366 (gobble_file): Add inode argument.
367 (print_dir): Pass inode if available.
368 (usage): Remove inaccuracy.
370 2006-02-23 Jim Meyering <jim@meyering.net>
372 * TODO: Update/correct some obsolete entries.
374 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
376 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
377 * src/join.c (usage): Likewise.
378 Documentation problem reported by Philip Kensche.
380 2006-02-20 Eric Blake <ebb9@byu.net>
382 * man/rm.x: Update documentation to match previous patch.
384 2006-02-18 Eric Blake <ebb9@byu.net>
386 New option for rm: --interactive=once (-I).
387 * NEWS: Document it, along with change to rm --interactive.
388 * TODO: Remove entry for implementing rm -I
389 * src/rm.c (INTERACTIVE_OPTION): New enum value.
390 (interactive_type): New enum.
391 (long_opts): Let interactive take an optional argument.
392 (interactive_args, interactive_types): New option arguments.
393 (usage): Document -I, --interactive=WHEN. Use program_name
394 instead of a basename.
395 (main): New -I option, new behavior to --interactive.
396 * tests/rm/interactive-once: New tests.
397 * tests/rm/interactive-always: Ditto.
398 * tests/rm/Makefile.am (TESTS): Run them.
400 2006-02-18 Jim Meyering <jim@meyering.net>
402 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
403 expression match more of the target lines, e.g., those that start with
404 `-S,' (short option followed by a comma) or that include `=[...]'.
405 Patch by Nicolas François.
406 Fix the four offenders thus exposed:
407 * src/join.c (usage): Use two spaces (not one) to separate the
408 --first-only option string from its description, so help2man formats
409 the derived man page properly.
410 * src/pr.c (usage): Likewise.
411 * src/uniq.c (usage): Likewise.
412 * src/install.c (usage): Likewise.
414 2006-02-15 Jim Meyering <jim@meyering.net>
416 * Makefile.maint (alpha beta major): For `make major', ensure that the
417 version string is of the form N.N[.N]*, where N is one or more digits.
419 2006-02-14 Jim Meyering <jim@meyering.net>
421 * INSTALL: Update from gnulib.
423 2006-02-13 Jim Meyering <jim@meyering.net>
425 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
427 2006-02-12 Jim Meyering <jim@meyering.net>
429 * Makefile.maint (patch-check): New target.
430 (local-checks-available): Add to the list.
432 2006-02-11 Jim Meyering <jim@meyering.net>
434 * src/c99-to-c89.diff: New file.
435 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
437 * .x-po-check: New file, with exclusions so that `make distcheck'
439 * Makefile.am (EXTRA_DIST): Add .x-po-check.
441 rm -r must remove an empty directory, even if it is inaccessible.
442 * src/remove.c (close_preserve_errno): New function.
443 (fd_to_subdirp): Don't print a diagnostic in this function.
444 Do it from the callers instead, unless rmdir succeeds.
445 (remove_cwd_entries, remove_dir): Adjust callers.
446 * tests/rm/empty-inacc: New test for the above.
447 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
448 * NEWS: Mention this bug fix.
449 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
450 a tiny bit less precise: cannot remove `a/1': ... instead of
451 cannot open directory `a/1': ...
453 * Makefile.maint (syntax-check-rules): Automatically derive this
454 list of sc_-prefixed rule names.
456 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
458 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
459 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
460 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
461 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
462 go away? was that an accident?)
463 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
464 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
465 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
466 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
467 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
468 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
469 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
470 (author_mark_check, makefile_path_separator_check):
471 Output line numbers, to simplify navigation of Emacs *compilation*
473 (sc_prohibit_atoi_atof, sc_file_system):
474 Rework slightly so that Makefile.maint doesn't get reported as a
475 violation of its own syntax rules.
476 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
477 it at run-time (which didn't work with Bison). Fix a makefile typo,
478 caught by Makefile.maint itself: spaces where a tab should be.
479 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
480 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
481 Ignore djgpp and man subdirectories, to avoid false matches with
482 Bison and coreutils, respectively. Use sort -u to remove the
483 resulting duplicates.
484 * gnupload: Rework slightly to avoid bogus warning from
485 sc_two_space_separator_in_usage.
487 2006-02-10 Jim Meyering <jim@meyering.net>
489 Use gzip's --rsyncable option only if it's available.
490 * Makefile.maint (gzip_rsyncable): New variable.
493 2006-02-08 Jim Meyering <jim@meyering.net>
495 * Makefile.maint (local-checks-available): Define in terms of
496 the expansion, $(syntax-check-rules), rather than the single,
497 top-level target `syntax-check', so that it's easier to exclude
498 individual rules (via $(local-checks-to-skip)).
499 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
501 2006-02-07 Jim Meyering <jim@meyering.net>
503 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
504 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
506 * tests/help-version (expected_failure_status_vdir):
507 Redirect an expected disk-full diagnostic to /dev/null.
509 2006-02-06 Jim Meyering <jim@meyering.net>
511 * src/unexpand.c (usage): Use two spaces (not one) to separate the
512 --first-only option string from its description, so help2man formats
513 the derived man page properly.
514 * src/rm.c (usage): Likewise for --no-preserve-root.
515 * src/chown.c (usage): Likewise.
516 * src/chgrp.c (usage): Likewise.
518 Add a rule to ensure that the above doesn't happen again.
519 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
520 (syntax-check-rules): Add it.
521 * .x-sc_two_space_separator_in_usage: New empty file.
522 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
524 2006-02-06 Jim Meyering <jim@meyering.net>
526 * src/cp.c (usage): Use two spaces (not one) to separate each
527 option string from its description, so help2man formats the
528 derived man page properly.
529 * src/mv.c (usage): Likewise.
530 Patch from Nicolas François in http://bugs.debian.org/351601.
532 2006-02-04 Jim Meyering <jim@meyering.net>
534 * src/copy.c (copy_internal): cp -RL would fail when encountering
535 the same directory more than once in the hierarchy beneath a single
536 command-line argument. That is legitimate, e.g. when there are
537 two or more symbolic links, each pointing to some directory that
538 would not otherwise be copied. Reported by Christophe LYON.
539 * tests/cp/cp-deref: New file. Test for today's fix.
540 * tests/cp/Makefile.am (TESTS): Add cp-deref.
541 * NEWS: Document this.
543 2006-02-03 Jim Meyering <jim@meyering.net>
545 * configure.ac: Require automake-1.9.6, not 1.8.3.
547 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
549 * src/od.c (usage): Mention that -t a ignores high order bit.
550 Documentation problem reported by Ed Avis.
552 2006-02-01 Jim Meyering <jim@meyering.net>
554 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
556 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
558 * src/head.c (main): Use a better diagnostic when someone uses a
559 trailing numeric option in an invalid way. Problem reported by
561 * src/tail.c (parse_options): Likewise.
563 2006-01-30 Jim Meyering <jim@meyering.net>
565 * man/wc.x: Include `count' keyword in man page synopsis,
566 per suggestion from http://bugs.debian.org/181585.
568 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
570 * src/df.c (show_dev): If the file system claims to have
571 more available than total blocks, report the number of used
572 blocks as being total - available (a negative number) rather
573 than as garbage. Problem reported by Toralf Foerster.
575 2006-01-24 Jim Meyering <jim@meyering.net>
577 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
578 to put a regular file in O_NONBLOCK mode fails with EPERM.
579 That happens on Linux (up to 2.6.15) when using tail -f on a file with
580 the append-only attribute. Reported by Dean Gaudet. For details,
581 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
582 * NEWS: Mention this fix.
583 * tests/tail-2/append-only: New file. Test for the above.
584 * tests/tail-2/Makefile.am (TESTS): Add append-only.
585 * tests/Makefile.am (check-root): Add tail-2/append-only
587 2006-01-21 Jim Meyering <jim@meyering.net>
589 * NEWS: Mention fts-related improvements and bug fixes.
591 2006-01-19 Jim Meyering <jim@meyering.net>
593 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
594 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
596 2006-01-18 Jim Meyering <jim@meyering.net>
598 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
600 2006-01-17 Jim Meyering <jim@meyering.net>
602 Now that fts no longer changes the current working directory, adjust
603 its clients accordingly -- note that du.c uses fts but doesn't need
604 any adjustment, since it doesn't operate on the actual files,
605 but rather just uses the stat buffers provided by fts.
607 * src/chown-core.c: Include "openat.h".
608 Don't include "lchown.h".
609 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
610 calling openat, lchownat, chownat, rather than open, lchown, chown.
612 * src/chmod.c: Include "openat.h".
613 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
615 * tests/du/long-from-unreadable: New test, to exercise one small
618 2006-01-13 Jim Meyering <jim@meyering.net>
620 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
621 addition of new directories under tests/.
623 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
626 2006-01-12 Jim Meyering <jim@meyering.net>
628 * tests/du/long-sloop: Adjust not to hard-code the expected
629 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
630 from that of GNU libc. Reported by Paul Eggert.
632 * tests/du/long-sloop: Create file at end of symlink chain.
634 * tests/misc/test: New file, with a test for one of the
635 bugs fixed by yesterday's test.c changes.
636 * tests/misc/Makefile.am (TESTS): Add test.
638 2006-01-11 Jim Meyering <jim@meyering.net>
640 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
641 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
642 a very long sequence of symbolic links (not necessarily a loop).
643 * tests/du/Makefile.am (TESTS): Add long-sloop.
645 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
647 * src/test.c (test_syntax_error): Append a newline. All callers
648 changed, except for the ones that didn't already append a newline.
649 Bug reported by Eric Blake.
651 2006-01-11 Jim Meyering <jim@meyering.net>
653 * src/system.h (X2NREALLOC): Now that verify_true is no longer
654 void, cast its result to void, to avoid gcc's warning that
655 ``left-hand operand of comma expression has no effect''.
656 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
658 2006-01-10 Jim Meyering <jim@meyering.net>
660 * tests/chmod/no-x: Add a test for today's fts.c fix.
662 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
664 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
665 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
667 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
669 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
670 Use verify_true instead of verify_expr, to sync with gnulib.
672 2006-01-08 Jim Meyering <jim@meyering.net>
674 * src/date.c (usage): Adjust the formatting of the entries for
675 %::z and %:::z (separate with two spaces, not one) so that help2man
676 formats them properly. Reported by Philip Rowlands.
678 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
680 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
682 2006-01-06 Jim Meyering <jim@meyering.net>
684 * Makefile.maint (copyright-check): Use date +%Y in place of
687 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
688 First off, the attribute should have been `volatile' (not static)
689 to avoid longjmp-related risk of clobber. Secondly, now there is
690 no longer any risk of a local variable being clobbered, so there's
691 no need for any attribute at all.
693 2006-01-05 Jim Meyering <jim@meyering.net>
695 * src/remove.c: Give a few functions the inline attribute.
696 (AD_pop_and_chdir): Use gotos to avoid some duplication.
697 (AD_push): Rewrite an assertion so that the entire computation
698 goes away when assertions are turned off.
700 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
701 It's already defined in "system.h".
702 * Makefile.maint: Add a FIXME comment.
704 2006-01-04 Jim Meyering <jim@meyering.net>
706 * ChangeLog: Remove entries from 2005-10-22 and earlier.
707 * ChangeLog-2005: New file, for entries up to version 5.92.
709 2006-01-03 Jim Meyering <jim@meyering.net>
711 * tests/du/no-x: Also allow a slightly different diagnostic -- the
712 one you get when using openat-enabled fts.c and du (coming soon).
713 * tests/chmod/no-x: Likewise.
714 * tests/chgrp/no-x: Likewise.
716 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
718 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
720 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
721 (restricted_chown): Return it, if the file cannot be accessed due
722 to EPERM, or if no uid or gid are required, or if the file is
723 neither a directory nor a regular file. Rewrite to avoid gotos.
724 (change_file_owner): Handle RC_do_ordinary_chown case.
725 Rewrite to avoid gotos.
726 * tests/chgrp/basic: Make sure we can change the group of
729 * src/date.c (usage): Explain %g, %G, and %V a bit better.
731 2006-01-02 Jim Meyering <jim@meyering.net>
733 * src/copy.c (set_owner): Correct a comment.
735 * src/tail.c (parse_options): Change warning to say that --retry
736 is useful `mainly' (not `only') when following by name.
737 Reported here: http://bugs.debian.org/273781
739 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
741 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
742 * src/copy.c: Include lchmod.h.
743 (copy_internal): Use lchmod rather than chmod.
744 * src/cp.c: Include lchmod.h.
745 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
746 * src/mkdir.c: Include lchmod.h.
747 (usage): Clarify -m's operation.
748 (main): Use lchmod rather than chmod. Don't use lchmod unless the
749 new mode contains bits outside the 777 range.
750 * src/mkfifo.c (usage): Clarify -m's operation.
751 (main): If -m is given, don't invoke chmod; use umask 0 instead.
752 Report an error if -m asks for bits outside the 777 range.
753 * src/mknod.c (usage, main): Likewise.
755 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
757 2005-12-27 Jim Meyering <jim@meyering.net>
759 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
760 (sc_prohibit_assert_without_use): New rule.
761 (syntax-check-rules): Add it to the list.
762 * .x-sc_prohibit_assert_without_use: New empty file.
763 * Makefile.am (EXTRA_DIST): Add it.
765 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
767 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
768 Don't include <assert.h>; it wasn't used.
770 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
772 * src/chown-core.c (restricted_chown):
773 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
774 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
775 | O_NOFOLLOW too, for consistency with other dir-openers.
776 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
777 (is_empty_dir): Likewise.
778 * src/shred.c (wipename): Likewise. Don't bother trying to open
779 dir for writing, since POSIX prohibits it.
781 2005-12-22 Jim Meyering <jim@meyering.net>
783 * tests/help-version: Redirect stderr to /dev/full, to suppress
784 write error diagnostic.
786 2005-12-19 Jim Meyering <jim@meyering.net>
788 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
789 Avoid a minor race condition when `-m MODE' is specified, by using
790 open, fchown, and close rather than just chown. To do that reliably --
791 even with an overly restrictive umask -- ensure that each mkdir,
792 mknod and mkfifo call uses a mode including at least owner-read access.
793 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
794 the subsequent chown (or equivalent open,fchown,close) fails.
795 * tests/misc/mknod: New tests.
796 * tests/misc/Makefile.am (TESTS): Add mknod.
798 2005-12-17 Jim Meyering <jim@meyering.net>
800 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
801 e.g., on a named pipe.
802 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
803 place of all uses, since it is guaranteed (system.h) to be defined.
805 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
807 Add POSIX ACL support
808 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
809 is no requirement for ACL support; particularly, it does not exist
810 on systems that have POSIX ACLs.
811 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
812 * src/cp.c (umask_kill): With default acls, the umask is not to be
813 applied. Remove umask_kill, don't change the process umask, and let
814 the kernel apply the umask where appropriate.
815 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
816 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
818 (copy_reg, copy_internal): Use copy_acl and set_acl
819 instead of fchown/chown. Fix the logic for POSIX ACLs.
820 (chown_succeded): Remove; we now always copy acls and
821 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
822 did a chown before or not.
823 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
824 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
825 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
826 to link with it via $(LIB_ACL), for the utilities that need it.
828 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
830 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
831 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
832 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
833 value is now signified by whether cwd_errno is null.
834 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
835 pointer-to-bool to pointer-to-errno-value. All callers changed.
836 (rm_1): Don't bother setting a local cwd failure flag and then
837 ORing it into the caller's. Just set the caller's.
838 (rm): Use cwd failure errno value to print a slightly-better
841 2005-12-15 Jim Meyering <jim@meyering.net>
843 * src/stat.c (print_it): Properly handle a backslash at the
844 end of a --printf format string. Reported by Paul Eggert.
845 * tests/misc/stat-printf (end-bs): Add a test for the above.
847 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
849 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
850 Don't assume /etc/passwd contains user names; use 'id' instead.
852 2005-12-15 Jim Meyering <jim@meyering.net>
854 stat: revert behavior of --format=FMT (-c)
855 stat: add new option: --printf=FMT
856 * NEWS: Mention this.
857 * src/stat.c (isodigit, octtobin, hextobin): Define.
858 (PRINTF_OPTION): Define.
859 (interpret_backslash_escapes, trailing_delim): New globals.
860 (usage): Document them. Alphabetize on long option names.
861 (print_esc_char): New function.
862 (print_it): Rewrite, in order to handle backslash escapes.
863 (main): Handle new option. Set globals for --format, too.
865 * tests/misc/stat-printf: Test --printf and --format.
866 * tests/misc/Makefile.am (TESTS): Add stat-printf.
868 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
870 * NEWS: sort now reports incompatible options.
871 * src/sort.c (incompatible_options, check_ordering_compatibility):
873 (main): Use them. Don't bother with a usage message for
874 "sort -c a b", for consistency with other error diagnostics.
875 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
878 * src/cat.c (main): Undo previous change. close_stdout already
879 does the check, so the previous change wasn't necessary.
881 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
883 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
885 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
887 Install a more-conservative approach for sort -R. It's the
888 same basic idea as the existing code, except it uses the full ISAAC
889 approach (called the "more kosher" approach in the existing comments).
890 This makes "sort -R" quite a bit slower (about a factor of 2 on my
891 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
892 better to be conservative here at first, and review any performance
893 improvements carefully.
894 * .x-sc_require_config_h: Add src/rand-isaac.c.
895 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
896 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
897 (shred_SOURCES, sort_SOURCES): Remove.
898 (EXTRA_DIST): Add rand-isaac.c.
899 * src/rand-isaac.c: Revert to what used to be in shred.c, without
900 changing it to allow for varying numbers of words in the state.
901 Alter so that we include rand-isaac.c directly rather than
902 compiling it and linking to it. Don't include config.h or
903 system.h; that's the includer's responsibility.
904 Omit functions that are specific to shred.
905 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
906 (isaac_step, struct irand_state):
907 Resurrect these, with the same defns that used to be in shred.c.
908 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
909 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
911 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
912 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
913 (irand_init, irand32, irand_mod):
914 Number of words is constant again.
915 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
916 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
917 * src/sort.c: Likewise.
918 * src/shred.c (fillrand, dopass, main): Undo previous change.
919 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
921 * src/sort.c: Don't include md5.h; it wasn't needed.
922 (struct keyfield): Rename random_hash to random, for consistency
923 with the other member names. All uses changed.
924 (usage): Tweak wording to mention STRING for --seed option.
925 (short_options): Rorder for consistency with other programs.
926 (rand_state): Now a struct, not a pointer to one. All uses changed.
927 (HASH_WORDS, HASH_SIZE): Remove.
928 (get_hash): Remove comments around resbuf size, since we can assume C89.
929 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
930 (keycompare): Adjust to the new get_hash.
932 (badfieldspec): Omit recently-introduced comment; it isn't needed.
933 (main): Don't set need_random simply because gkey has it set; that
934 doesn't necessarily mean we'll need random numbers.
935 Redo seeding to match new get_hash approach.
937 2005-12-10 Jim Meyering <jim@meyering.net>
939 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
941 Avoid shred segfault on 64-bit systems.
942 * src/rand-isaac.c (isaac_refill): Don't try to negate a
943 local of type uint32_t. Make the local an `int' instead.
945 * NEWS: Mention sort's new options.
947 * src/rand-isaac.c (isaac_mix): Declare to be static.
948 Mark all other functions as `extern' so the tight-scope
949 part of `make distcheck' passes once again.
950 * src/rand-isaac.h (isaac_mix): Remove declaration.
952 * src/sort.c (get_hash): Change position of `*' in parameter
953 type to conform with convention.
954 (main): Split a long line so it fits in 80 columns.
955 (keycompare): Remove stray SPACE before TAB that was
956 causing `make distcheck' to fail.
958 * src/shred.c: Don't include gethrxtime.h. No longer needed.
960 * tests/misc/sort-rand: New file: basic tests for the new options.
961 * tests/misc/Makefile.am (TESTS): Add sort-rand.
963 2005-12-10 Frederik Eaton <frederik@ofb.net>
965 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
966 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
967 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
968 Make state size runtime-configurable.
969 (isaac_new, isaac_copy): New functions.
970 * src/rand-isaac.h: New file.
971 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
972 (fillrand, main): Adjust to the fact that the state size is now
973 runtime-configurable.
974 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
975 (usage): Add options --random-sort and --seed to implement a random
977 Include md5.h and rand-isaac.h.
978 (get_hash): New function.
979 (rand_state): New var.
980 (HASH_WORDS, HASH_SIZE): New macros.
982 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
984 * tests/dd/misc: Add test for dd iflags=noatime.
986 2005-12-09 Jim Meyering <jim@meyering.net>
988 * src/sort.c (usage): Mention white space vs -b and -t options.
991 2005-12-09 Eric Blake <ebb9@byu.net>
993 * src/test.c (main): Fix misleading comment.
995 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
997 * NEWS: Mention dd's new noatime flag.
998 * src/system.h (O_NOATIME): Define to 0 if not already defined.
999 * src/dd.c (flags, usage): Add support for noatime flag.
1001 2005-12-07 Jim Meyering <jim@meyering.net>
1003 Distribute the cvsu script, used only by `make syntax-check'.
1004 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1005 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1006 distribute a copy of this script.
1007 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1009 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1010 to create a temporary directory on another partition.
1011 From Andreas Gruenbacher.
1013 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1015 * man/basename.x: Cross-reference to dirname and readlink.
1016 * man/dirname.x: Cross-reference to basename and readlink.
1018 2005-12-05 Andreas Gruenbacher
1020 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1021 (set_owner, preserve_author): New functions, factored out of copy_reg.
1022 (copy_reg): Use them.
1023 (copy_internal): Use them here, too.
1025 2005-12-04 Jim Meyering <jim@meyering.net>
1027 * src/sleep.c (usage): Say what happens with two or more arguments.
1028 Suggested by Justin Pryzby.
1030 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1033 2005-12-03 Jim Meyering <jim@meyering.net>
1035 * src/rm.c (long_opts): Change the name of each undocumented, for-
1036 testing-only option to start with `-', so that it cannot render
1037 ambiguous any prefix it happens to share with some other option name.
1038 Problem reported by Eric Blake.
1039 * src/head.c (long_options): Likewise.
1040 * src/tail.c (long_options): Likewise.
1042 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1043 testing-only --presume* options to start with `---'.
1044 * tests/rm/dangling-symlink: Likewise.
1045 * tests/rm/dir-no-w: Likewise.
1046 * tests/rm/isatty: Likewise.
1048 2005-11-30 Jim Meyering <jim@meyering.net>
1050 * Makefile.maint: Add a comment about cvsu.
1052 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1054 * NEWS: df updates for "none", "proc", inaccessible file systems.
1055 * src/df.c (show_point): Ignore inaccessible file systems.
1056 (usage): -a includes dummy file systems, not size-0 file systems.
1058 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1059 to avoid collision with POSIX name space. All uses changed.
1061 2005-11-24 Jim Meyering <jim@meyering.net>
1063 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1064 * tests/acl: Add `$0: ' prefix to diagnostics.
1066 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1068 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1070 * src/copy.c: Improve performance a bit by optimizing away
1071 unnecessary system calls and going to a block size of at least
1072 8192 (on normal hosts, anyway). This improved performance 5% on my
1073 Debian stable host (2.4.27 kernel, x86, copying from root
1074 ext3 file system to itself).
1075 Include "buffer-lcm.h".
1076 (copy_reg): Omit last argument. All callers changed.
1077 Use xmalloc to allocate rather than trusting alloca
1078 (which is unwise with large block sizes).
1079 Declare locals more locally, if possible.
1080 Use uintptr_t words instead of int words, for a bit more speed
1081 when looking for null blocks on 64-bit hosts.
1082 Optimize away reads of zero bytes on regular files.
1083 In the typical case, insist on 8 KiB buffers, at least.
1084 Avoid unnecessary extra call to fstat when checking for sparse files.
1085 Avoid now-unnecessary cast to off_t, and "0L".
1086 Avoid unnecessary test of *new_dst when checking for same owner
1089 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1091 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1093 2005-11-22 Jim Meyering <jim@meyering.net>
1095 * src/remove.c (AD_push): Remove debugging cruft.
1097 * tests/rm/unread2 (rm): Change expected diagnostic,
1098 `cannot open directory' to `cannot remove', to align with
1100 * tests/rm/rm2: Ensure that rm now continues removing entries
1101 even after certain types of failure.
1103 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1104 that provide openat (Solaris), and on systems like Linux+procfs
1105 where our openat emulation code is reentrant. This also fixes a
1106 few low-probability leaks and eliminates some code that could,
1107 in very unusual circumstances, cause rm() (via a callee) to exit.
1108 * NEWS: Mention this.
1110 * configure.ac: Put copyright dates all on one line so the
1111 emacs function that updates them works properly.
1113 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1115 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1116 Problem reported by Eric Blake.
1117 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1118 we get a standard-conforming compiler. This relies on the new
1119 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1120 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1121 m4/c.m4 can go away with Autoconf 2.60 comes out.
1123 2005-11-17 Jim Meyering <jim@meyering.net>
1125 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1126 (AD_mark_current_as_unremovable): Likewise, but for a local.
1129 * tests/mv/acl: Let traps handle removing temporary directories.
1131 Expect acl-related tests to fail, until the corresponding
1132 patches are committed.
1133 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1134 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1136 ACL tests, from Andreas Gruenbacher.
1137 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1138 * tests/mv/Makefile.am (TESTS): Add acl.
1139 * tests/cp/Makefile.am (TESTS): Add acl.
1141 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1143 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1145 * NEWS: Improve quality of ln's diagnostics.
1146 * src/ln.c (do_link, usage): Likewise.
1147 (do_link): Don't use alloca on a buffer of unbounded size.
1149 2005-11-16 Jim Meyering <jim@meyering.net>
1151 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1152 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1153 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1155 2005-11-14 Jim Meyering <jim@meyering.net>
1157 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1159 2005-11-13 Jim Meyering <jim@meyering.net>
1161 * announce-gen: Accept new option, --gpg-key-id=ID and
1162 emit a blurb telling how to use the .sig files.
1163 * Makefile.cfg (gpg_key_ID): Define.
1164 * Makefile.maint (announcement): Use new option and key.
1166 Require that most .c files include <config.h>.
1167 * Makefile.maint (sc_require_config_h): New rule.
1168 (syntax-check-rules): Add it.
1169 * .x-sc_require_config_h: New file listing exceptions to the
1170 above rule. Some are legit, others are simply grandfathered in.
1171 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1173 2005-11-12 Jim Meyering <jim@meyering.net>
1175 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1177 2005-11-11 Jim Meyering <jim@meyering.net>
1179 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1180 Mention new readlink options in 5.3.0's `New features' section.
1181 Spotted by Thomas Hood.
1183 2005-11-08 Jim Meyering <jim@meyering.net>
1185 * NEWS: Merge in changes from b5_9x branch.
1187 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1189 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1190 like --time-style='posix-long-iso' if the locale settings are messed up.
1191 * src/ls.c (decode_switches): Implement this.
1193 2005-11-08 Jim Meyering <jim@meyering.net>
1195 * tests/du/2g: s/expensive/very expensive/ in a comment.
1198 2005-10-17 Eric Blake <ebb9@byu.net>
1200 * src/ls.c (usage): Fix descriptions of --sort, --time.
1201 Reported by Vitaly A. Ostanin.
1203 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1205 * src/ln.c: Include filenamecat.c.
1206 (FILE_BASENAME_CONCAT): Remove.
1207 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1208 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1209 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1212 2005-11-04 Jim Meyering <jim@meyering.net>
1214 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1215 on systems with stat.st_blocks of a signed 32-bit type.
1216 This bug causes trouble on some AIX 5.1 systems.
1217 Report and trivial patch from Paul Townsend:
1218 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1219 * NEWS: Mention this.
1221 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1222 * tests/du/Makefile.am (TESTS): Add it here.
1223 * tests/very-expensive: New file.
1224 * tests/Makefile.am (EXTRA_DIST): Add it here.
1225 * tests/cp/perm: Mark this test as `very-expensive', too.
1227 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1229 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1231 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1233 * src/rm.c (usage): Don't mention rm -d.
1235 2005-11-02 Jim Meyering <jim@meyering.net>
1237 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1238 From Andreas Schwab.
1240 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1241 `M+N records in/out' lines don't pollute `make check' output.
1243 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1244 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1245 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1246 to indicate that the input file should be piped into the command
1247 under test (via `cat FILE | $prog ...').
1249 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1250 (without -r) fails to remove a directory on a non-Linux system.
1251 This change affects only newer Solaris systems (with priv_*
1252 functions like priv_allocset). Reported by Keith Thompson.
1254 * tests/rm/dir-nonrecur: New file/test for the above fix.
1255 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1257 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1259 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1260 POSIX 1002.1-2001 requires.
1261 * src/tail.c (parse_obsolete_option): Implement this.
1262 Problem reported by Vincent Lefevre.
1263 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1264 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1265 (test_vector): Add special cases for _POSIX2_VERSION, and
1266 regularize the old ones a bit.
1267 * tests/touch/obsolescent: Add y2000 test.
1269 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1271 * src/dd.c (skip): Fix off-by-one error reported by
1272 Theodoros V. Kalamatianos.
1274 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1276 * tests/mkdir/p-3: Require that the test be run as non-root.
1277 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1279 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1281 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1282 boundary between DEST and SOURCE in the result.
1284 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1286 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1287 back to text, to sync with documentation and for backwards
1290 2005-10-25 Jim Meyering <jim@meyering.net>
1292 * tests/dircolors/simple (other-wr): Add an explicit test for
1293 the dircolors bug (NULL-dereference) fixed yesterday.
1295 2005-10-24 Jim Meyering <jim@meyering.net>
1297 * src/tac.c (tac_file): When determining whether a file is seekable,
1298 also test whether it is a tty. Using only the lseek-based test would
1299 give a false positive on Solaris. Reported by Peter Fales.
1301 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1303 * tests/install/d-slashdot: New test, for "install -d" failure.
1304 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1305 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1306 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1308 2005-10-24 Jim Meyering <jim@meyering.net>
1310 * src/dircolors.c (ls_codes): Add missing comma.
1311 Anonymous report and patch from
1312 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1314 * src/dircolors.c: Add compile-time assertion that the slack_codes
1315 and ls_codes arrays have the same number of elements. This would
1316 have prevented the above-fixed bug.
1318 * src/expand.c (parse_tab_stops): Add a comment to make this function
1319 identical to the one in unexpand.c.
1320 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1321 identical to the one in expand.c.
1323 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1325 2005-10-23 Jim Meyering <jim@meyering.net>
1327 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1328 a dangerous pointer-value-to-`unsigned' cast.
1329 * NEWS: mention the new sha* programs.
1330 * AUTHORS: Add new sha* programs.
1332 2005-08-28 David Madore <david.madore@ens.fr>
1334 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1335 * README: Add their names to the list.
1336 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1337 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1338 Rules for compiling sha-2 utilities
1339 (noinst_HEADERS): Remove checksum.h.
1340 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1342 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1343 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1344 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1345 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1346 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1347 sha384sum, sha512sum test scripts here rather that each in its
1350 2005-08-28 David Madore <david.madore@ens.fr>
1352 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1353 of the FIPS test vectors).
1355 2005-10-23 Jim Meyering <jim@meyering.net>
1357 * configure.ac: Use 6.0-cvs as the version string.
1358 * NEWS: Adjust accordingly.