1 2006-02-11 Jim Meyering <jim@meyering.net>
5 * .x-po-check: New file, with exclusions so that `make distcheck'
7 * Makefile.am (EXTRA_DIST): Add .x-po-check.
9 rm -r must remove an empty directory, even if it is inaccessible.
10 * src/remove.c (close_preserve_errno): New function.
11 (fd_to_subdirp): Don't print a diagnostic in this function.
12 Do it from the callers instead, unless rmdir succeeds.
13 (remove_cwd_entries, remove_dir): Adjust callers.
14 * tests/rm/empty-inacc: New test for the above.
15 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
16 * NEWS: Mention this bug fix.
18 * Makefile.maint (syntax-check-rules): Automatically derive this
19 list of sc_-prefixed rule names.
21 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
23 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
24 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
25 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
26 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
27 go away? was that an accident?)
28 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
29 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
30 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
31 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
32 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
33 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
34 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
35 (author_mark_check, makefile_path_separator_check):
36 Output line numbers, to simplify navigation of Emacs *compilation*
38 (sc_prohibit_atoi_atof, sc_file_system):
39 Rework slightly so that Makefile.maint doesn't get reported as a
40 violation of its own syntax rules.
41 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
42 it at run-time (which didn't work with Bison). Fix a makefile typo,
43 caught by Makefile.maint itself: spaces where a tab should be.
44 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
45 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
46 Ignore djgpp and man subdirectories, to avoid false matches with
47 Bison and coreutils, respectively. Use sort -u to remove the
49 * gnupload: Rework slightly to avoid bogus warning from
50 sc_two_space_separator_in_usage.
52 2006-02-10 Jim Meyering <jim@meyering.net>
54 Use gzip's --rsyncable option only if it's available.
55 * Makefile.maint (gzip_rsyncable): New variable.
58 2006-02-08 Jim Meyering <jim@meyering.net>
60 * Makefile.maint (local-checks-available): Define in terms of
61 the expansion, $(syntax-check-rules), rather than the single,
62 top-level target `syntax-check', so that it's easier to exclude
63 individual rules (via $(local-checks-to-skip)).
64 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
66 2006-02-07 Jim Meyering <jim@meyering.net>
68 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
69 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
71 * tests/help-version (expected_failure_status_vdir):
72 Redirect an expected disk-full diagnostic to /dev/null.
74 2006-02-06 Jim Meyering <jim@meyering.net>
76 * src/unexpand.c (usage): Use two spaces (not one) to separate the
77 --first-only option string from its description, so help2man formats
78 the derived man page properly.
79 * src/rm.c (usage): Likewise for --no-preserve-root.
80 * src/chown.c (usage): Likewise.
81 * src/chgrp.c (usage): Likewise.
83 Add a rule to ensure that the above doesn't happen again.
84 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
85 (syntax-check-rules): Add it.
86 * .x-sc_two_space_separator_in_usage: New empty file.
87 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
89 2006-02-06 Jim Meyering <jim@meyering.net>
91 * src/cp.c (usage): Use two spaces (not one) to separate each
92 option string from its description, so help2man formats the
93 derived man page properly.
94 * src/mv.c (usage): Likewise.
95 Patch from Nicolas François in http://bugs.debian.org/351601.
97 2006-02-04 Jim Meyering <jim@meyering.net>
99 * src/copy.c (copy_internal): cp -RL would fail when encountering
100 the same directory more than once in the hierarchy beneath a single
101 command-line argument. That is legitimate, e.g. when there are
102 two or more symbolic links, each pointing to some directory that
103 would not otherwise be copied. Reported by Christophe LYON.
104 * tests/cp/cp-deref: New file. Test for today's fix.
105 * tests/cp/Makefile.am (TESTS): Add cp-deref.
106 * NEWS: Document this.
108 2006-02-03 Jim Meyering <jim@meyering.net>
110 * configure.ac: Require automake-1.9.6, not 1.8.3.
112 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
114 * src/od.c (usage): Mention that -t a ignores high order bit.
115 Documentation problem reported by Ed Avis.
117 2006-02-01 Jim Meyering <jim@meyering.net>
119 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
121 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
123 * src/head.c (main): Use a better diagnostic when someone uses a
124 trailing numeric option in an invalid way. Problem reported by
126 * src/tail.c (parse_options): Likewise.
128 2006-01-30 Jim Meyering <jim@meyering.net>
130 * man/wc.x: Include `count' keyword in man page synopsis,
131 per suggestion from http://bugs.debian.org/181585.
133 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
135 * src/df.c (show_dev): If the file system claims to have
136 more available than total blocks, report the number of used
137 blocks as being total - available (a negative number) rather
138 than as garbage. Problem reported by Toralf Foerster.
140 2006-01-24 Jim Meyering <jim@meyering.net>
142 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
143 to put a regular file in O_NONBLOCK mode fails with EPERM.
144 That happens on Linux (up to 2.6.15) when using tail -f on a file with
145 the append-only attribute. Reported by Dean Gaudet. For details,
146 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
147 * NEWS: Mention this fix.
148 * tests/tail-2/append-only: New file. Test for the above.
149 * tests/tail-2/Makefile.am (TESTS): Add append-only.
150 * tests/Makefile.am (check-root): Add tail-2/append-only
152 2006-01-21 Jim Meyering <jim@meyering.net>
154 * NEWS: Mention fts-related improvements and bug fixes.
156 2006-01-19 Jim Meyering <jim@meyering.net>
158 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
159 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
161 2006-01-18 Jim Meyering <jim@meyering.net>
163 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
165 2006-01-17 Jim Meyering <jim@meyering.net>
167 Now that fts no longer changes the current working directory, adjust
168 its clients accordingly -- note that du.c uses fts but doesn't need
169 any adjustment, since it doesn't operate on the actual files,
170 but rather just uses the stat buffers provided by fts.
172 * src/chown-core.c: Include "openat.h".
173 Don't include "lchown.h".
174 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
175 calling openat, lchownat, chownat, rather than open, lchown, chown.
177 * src/chmod.c: Include "openat.h".
178 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
180 * tests/du/long-from-unreadable: New test, to exercise one small
183 2006-01-13 Jim Meyering <jim@meyering.net>
185 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
186 addition of new directories under tests/.
188 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
191 2006-01-12 Jim Meyering <jim@meyering.net>
193 * tests/du/long-sloop: Adjust not to hard-code the expected
194 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
195 from that of GNU libc. Reported by Paul Eggert.
197 * tests/du/long-sloop: Create file at end of symlink chain.
199 * tests/misc/test: New file, with a test for one of the
200 bugs fixed by yesterday's test.c changes.
201 * tests/misc/Makefile.am (TESTS): Add test.
203 2006-01-11 Jim Meyering <jim@meyering.net>
205 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
206 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
207 a very long sequence of symbolic links (not necessarily a loop).
208 * tests/du/Makefile.am (TESTS): Add long-sloop.
210 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
212 * src/test.c (test_syntax_error): Append a newline. All callers
213 changed, except for the ones that didn't already append a newline.
214 Bug reported by Eric Blake.
216 2006-01-11 Jim Meyering <jim@meyering.net>
218 * src/system.h (X2NREALLOC): Now that verify_true is no longer
219 void, cast its result to void, to avoid gcc's warning that
220 ``left-hand operand of comma expression has no effect''.
221 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
223 2006-01-10 Jim Meyering <jim@meyering.net>
225 * tests/chmod/no-x: Add a test for today's fts.c fix.
227 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
229 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
230 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
232 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
234 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
235 Use verify_true instead of verify_expr, to sync with gnulib.
237 2006-01-08 Jim Meyering <jim@meyering.net>
239 * src/date.c (usage): Adjust the formatting of the entries for
240 %::z and %:::z (separate with two spaces, not one) so that help2man
241 formats them properly. Reported by Philip Rowlands.
243 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
245 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
247 2006-01-06 Jim Meyering <jim@meyering.net>
249 * Makefile.maint (copyright-check): Use date +%Y in place of
252 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
253 First off, the attribute should have been `volatile' (not static)
254 to avoid longjmp-related risk of clobber. Secondly, now there is
255 no longer any risk of a local variable being clobbered, so there's
256 no need for any attribute at all.
258 2006-01-05 Jim Meyering <jim@meyering.net>
260 * src/remove.c: Give a few functions the inline attribute.
261 (AD_pop_and_chdir): Use gotos to avoid some duplication.
262 (AD_push): Rewrite an assertion so that the entire computation
263 goes away when assertions are turned off.
265 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
266 It's already defined in "system.h".
267 * Makefile.maint: Add a FIXME comment.
269 2006-01-04 Jim Meyering <jim@meyering.net>
271 * ChangeLog: Remove entries from 2005-10-22 and earlier.
272 * ChangeLog-2005: New file, for entries up to version 5.92.
274 2006-01-03 Jim Meyering <jim@meyering.net>
276 * tests/du/no-x: Also allow a slightly different diagnostic -- the
277 one you get when using openat-enabled fts.c and du (coming soon).
278 * tests/chmod/no-x: Likewise.
279 * tests/chgrp/no-x: Likewise.
281 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
283 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
285 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
286 (restricted_chown): Return it, if the file cannot be accessed due
287 to EPERM, or if no uid or gid are required, or if the file is
288 neither a directory nor a regular file. Rewrite to avoid gotos.
289 (change_file_owner): Handle RC_do_ordinary_chown case.
290 Rewrite to avoid gotos.
291 * tests/chgrp/basic: Make sure we can change the group of
294 * src/date.c (usage): Explain %g, %G, and %V a bit better.
296 2006-01-02 Jim Meyering <jim@meyering.net>
298 * src/copy.c (set_owner): Correct a comment.
300 * src/tail.c (parse_options): Change warning to say that --retry
301 is useful `mainly' (not `only') when following by name.
302 Reported here: http://bugs.debian.org/273781
304 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
306 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
307 * src/copy.c: Include lchmod.h.
308 (copy_internal): Use lchmod rather than chmod.
309 * src/cp.c: Include lchmod.h.
310 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
311 * src/mkdir.c: Include lchmod.h.
312 (usage): Clarify -m's operation.
313 (main): Use lchmod rather than chmod. Don't use lchmod unless the
314 new mode contains bits outside the 777 range.
315 * src/mkfifo.c (usage): Clarify -m's operation.
316 (main): If -m is given, don't invoke chmod; use umask 0 instead.
317 Report an error if -m asks for bits outside the 777 range.
318 * src/mknod.c (usage, main): Likewise.
320 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
322 2005-12-27 Jim Meyering <jim@meyering.net>
324 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
325 (sc_prohibit_assert_without_use): New rule.
326 (syntax-check-rules): Add it to the list.
327 * .x-sc_prohibit_assert_without_use: New empty file.
328 * Makefile.am (EXTRA_DIST): Add it.
330 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
332 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
333 Don't include <assert.h>; it wasn't used.
335 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
337 * src/chown-core.c (restricted_chown):
338 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
339 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
340 | O_NOFOLLOW too, for consistency with other dir-openers.
341 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
342 (is_empty_dir): Likewise.
343 * src/shred.c (wipename): Likewise. Don't bother trying to open
344 dir for writing, since POSIX prohibits it.
346 2005-12-22 Jim Meyering <jim@meyering.net>
348 * tests/help-version: Redirect stderr to /dev/full, to suppress
349 write error diagnostic.
351 2005-12-19 Jim Meyering <jim@meyering.net>
353 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
354 Avoid a minor race condition when `-m MODE' is specified, by using
355 open, fchown, and close rather than just chown. To do that reliably --
356 even with an overly restrictive umask -- ensure that each mkdir,
357 mknod and mkfifo call uses a mode including at least owner-read access.
358 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
359 the subsequent chown (or equivalent open,fchown,close) fails.
360 * tests/misc/mknod: New tests.
361 * tests/misc/Makefile.am (TESTS): Add mknod.
363 2005-12-17 Jim Meyering <jim@meyering.net>
365 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
366 e.g., on a named pipe.
367 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
368 place of all uses, since it is guaranteed (system.h) to be defined.
370 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
372 Add POSIX ACL support
373 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
374 is no requirement for ACL support; particularly, it does not exist
375 on systems that have POSIX ACLs.
376 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
377 * src/cp.c (umask_kill): With default acls, the umask is not to be
378 applied. Remove umask_kill, don't change the process umask, and let
379 the kernel apply the umask where appropriate.
380 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
381 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
383 (copy_reg, copy_internal): Use copy_acl and set_acl
384 instead of fchown/chown. Fix the logic for POSIX ACLs.
385 (chown_succeded): Remove; we now always copy acls and
386 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
387 did a chown before or not.
388 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
389 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
390 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
391 to link with it via $(LIB_ACL), for the utilities that need it.
393 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
395 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
396 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
397 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
398 value is now signified by whether cwd_errno is null.
399 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
400 pointer-to-bool to pointer-to-errno-value. All callers changed.
401 (rm_1): Don't bother setting a local cwd failure flag and then
402 ORing it into the caller's. Just set the caller's.
403 (rm): Use cwd failure errno value to print a slightly-better
406 2005-12-15 Jim Meyering <jim@meyering.net>
408 * src/stat.c (print_it): Properly handle a backslash at the
409 end of a --printf format string. Reported by Paul Eggert.
410 * tests/misc/stat-printf (end-bs): Add a test for the above.
412 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
414 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
415 Don't assume /etc/passwd contains user names; use 'id' instead.
417 2005-12-15 Jim Meyering <jim@meyering.net>
419 stat: revert behavior of --format=FMT (-c)
420 stat: add new option: --printf=FMT
421 * NEWS: Mention this.
422 * src/stat.c (isodigit, octtobin, hextobin): Define.
423 (PRINTF_OPTION): Define.
424 (interpret_backslash_escapes, trailing_delim): New globals.
425 (usage): Document them. Alphabetize on long option names.
426 (print_esc_char): New function.
427 (print_it): Rewrite, in order to handle backslash escapes.
428 (main): Handle new option. Set globals for --format, too.
430 * tests/misc/stat-printf: Test --printf and --format.
431 * tests/misc/Makefile.am (TESTS): Add stat-printf.
433 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
435 * NEWS: sort now reports incompatible options.
436 * src/sort.c (incompatible_options, check_ordering_compatibility):
438 (main): Use them. Don't bother with a usage message for
439 "sort -c a b", for consistency with other error diagnostics.
440 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
443 * src/cat.c (main): Undo previous change. close_stdout already
444 does the check, so the previous change wasn't necessary.
446 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
448 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
450 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
452 Install a more-conservative approach for sort -R. It's the
453 same basic idea as the existing code, except it uses the full ISAAC
454 approach (called the "more kosher" approach in the existing comments).
455 This makes "sort -R" quite a bit slower (about a factor of 2 on my
456 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
457 better to be conservative here at first, and review any performance
458 improvements carefully.
459 * .x-sc_require_config_h: Add src/rand-isaac.c.
460 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
461 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
462 (shred_SOURCES, sort_SOURCES): Remove.
463 (EXTRA_DIST): Add rand-isaac.c.
464 * src/rand-isaac.c: Revert to what used to be in shred.c, without
465 changing it to allow for varying numbers of words in the state.
466 Alter so that we include rand-isaac.c directly rather than
467 compiling it and linking to it. Don't include config.h or
468 system.h; that's the includer's responsibility.
469 Omit functions that are specific to shred.
470 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
471 (isaac_step, struct irand_state):
472 Resurrect these, with the same defns that used to be in shred.c.
473 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
474 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
476 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
477 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
478 (irand_init, irand32, irand_mod):
479 Number of words is constant again.
480 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
481 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
482 * src/sort.c: Likewise.
483 * src/shred.c (fillrand, dopass, main): Undo previous change.
484 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
486 * src/sort.c: Don't include md5.h; it wasn't needed.
487 (struct keyfield): Rename random_hash to random, for consistency
488 with the other member names. All uses changed.
489 (usage): Tweak wording to mention STRING for --seed option.
490 (short_options): Rorder for consistency with other programs.
491 (rand_state): Now a struct, not a pointer to one. All uses changed.
492 (HASH_WORDS, HASH_SIZE): Remove.
493 (get_hash): Remove comments around resbuf size, since we can assume C89.
494 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
495 (keycompare): Adjust to the new get_hash.
497 (badfieldspec): Omit recently-introduced comment; it isn't needed.
498 (main): Don't set need_random simply because gkey has it set; that
499 doesn't necessarily mean we'll need random numbers.
500 Redo seeding to match new get_hash approach.
502 2005-12-10 Jim Meyering <jim@meyering.net>
504 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
506 Avoid shred segfault on 64-bit systems.
507 * src/rand-isaac.c (isaac_refill): Don't try to negate a
508 local of type uint32_t. Make the local an `int' instead.
510 * NEWS: Mention sort's new options.
512 * src/rand-isaac.c (isaac_mix): Declare to be static.
513 Mark all other functions as `extern' so the tight-scope
514 part of `make distcheck' passes once again.
515 * src/rand-isaac.h (isaac_mix): Remove declaration.
517 * src/sort.c (get_hash): Change position of `*' in parameter
518 type to conform with convention.
519 (main): Split a long line so it fits in 80 columns.
520 (keycompare): Remove stray SPACE before TAB that was
521 causing `make distcheck' to fail.
523 * src/shred.c: Don't include gethrxtime.h. No longer needed.
525 * tests/misc/sort-rand: New file: basic tests for the new options.
526 * tests/misc/Makefile.am (TESTS): Add sort-rand.
528 2005-12-10 Frederik Eaton <frederik@ofb.net>
530 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
531 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
532 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
533 Make state size runtime-configurable.
534 (isaac_new, isaac_copy): New functions.
535 * src/rand-isaac.h: New file.
536 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
537 (fillrand, main): Adjust to the fact that the state size is now
538 runtime-configurable.
539 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
540 (usage): Add options --random-sort and --seed to implement a random
542 Include md5.h and rand-isaac.h.
543 (get_hash): New function.
544 (rand_state): New var.
545 (HASH_WORDS, HASH_SIZE): New macros.
547 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
549 * tests/dd/misc: Add test for dd iflags=noatime.
551 2005-12-09 Jim Meyering <jim@meyering.net>
553 * src/sort.c (usage): Mention white space vs -b and -t options.
556 2005-12-09 Eric Blake <ebb9@byu.net>
558 * src/test.c (main): Fix misleading comment.
560 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
562 * NEWS: Mention dd's new noatime flag.
563 * src/system.h (O_NOATIME): Define to 0 if not already defined.
564 * src/dd.c (flags, usage): Add support for noatime flag.
566 2005-12-07 Jim Meyering <jim@meyering.net>
568 Distribute the cvsu script, used only by `make syntax-check'.
569 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
570 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
571 distribute a copy of this script.
572 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
574 * tests/mv/acl: exit-77 before the trap, not after, if we fail
575 to create a temporary directory on another partition.
576 From Andreas Gruenbacher.
578 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
580 * man/basename.x: Cross-reference to dirname and readlink.
581 * man/dirname.x: Cross-reference to basename and readlink.
583 2005-12-05 Andreas Gruenbacher
585 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
586 (set_owner, preserve_author): New functions, factored out of copy_reg.
587 (copy_reg): Use them.
588 (copy_internal): Use them here, too.
590 2005-12-04 Jim Meyering <jim@meyering.net>
592 * src/sleep.c (usage): Say what happens with two or more arguments.
593 Suggested by Justin Pryzby.
595 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
598 2005-12-03 Jim Meyering <jim@meyering.net>
600 * src/rm.c (long_opts): Change the name of each undocumented, for-
601 testing-only option to start with `-', so that it cannot render
602 ambiguous any prefix it happens to share with some other option name.
603 Problem reported by Eric Blake.
604 * src/head.c (long_options): Likewise.
605 * src/tail.c (long_options): Likewise.
607 * tests/misc/head-elide-tail: Update uses of undocumented, for-
608 testing-only --presume* options to start with `---'.
609 * tests/rm/dangling-symlink: Likewise.
610 * tests/rm/dir-no-w: Likewise.
611 * tests/rm/isatty: Likewise.
613 2005-11-30 Jim Meyering <jim@meyering.net>
615 * Makefile.maint: Add a comment about cvsu.
617 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
619 * NEWS: df updates for "none", "proc", inaccessible file systems.
620 * src/df.c (show_point): Ignore inaccessible file systems.
621 (usage): -a includes dummy file systems, not size-0 file systems.
623 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
624 to avoid collision with POSIX name space. All uses changed.
626 2005-11-24 Jim Meyering <jim@meyering.net>
628 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
629 * tests/acl: Add `$0: ' prefix to diagnostics.
631 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
633 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
635 * src/copy.c: Improve performance a bit by optimizing away
636 unnecessary system calls and going to a block size of at least
637 8192 (on normal hosts, anyway). This improved performance 5% on my
638 Debian stable host (2.4.27 kernel, x86, copying from root
639 ext3 file system to itself).
640 Include "buffer-lcm.h".
641 (copy_reg): Omit last argument. All callers changed.
642 Use xmalloc to allocate rather than trusting alloca
643 (which is unwise with large block sizes).
644 Declare locals more locally, if possible.
645 Use uintptr_t words instead of int words, for a bit more speed
646 when looking for null blocks on 64-bit hosts.
647 Optimize away reads of zero bytes on regular files.
648 In the typical case, insist on 8 KiB buffers, at least.
649 Avoid unnecessary extra call to fstat when checking for sparse files.
650 Avoid now-unnecessary cast to off_t, and "0L".
651 Avoid unnecessary test of *new_dst when checking for same owner
654 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
656 * src/remove.c (rm): Don't assume C99 for-loop syntax.
658 2005-11-22 Jim Meyering <jim@meyering.net>
660 * src/remove.c (AD_push): Remove debugging cruft.
662 * tests/rm/unread2 (rm): Change expected diagnostic,
663 `cannot open directory' to `cannot remove', to align with
665 * tests/rm/rm2: Ensure that rm now continues removing entries
666 even after certain types of failure.
668 * src/remove.c: Rewrite. Now, this module is reentrant on systems
669 that provide openat (Solaris), and on systems like Linux+procfs
670 where our openat emulation code is reentrant. This also fixes a
671 few low-probability leaks and eliminates some code that could,
672 in very unusual circumstances, cause rm() (via a callee) to exit.
673 * NEWS: Mention this.
675 * configure.ac: Put copyright dates all on one line so the
676 emacs function that updates them works properly.
678 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
680 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
681 Problem reported by Eric Blake.
682 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
683 we get a standard-conforming compiler. This relies on the new
684 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
685 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
686 m4/c.m4 can go away with Autoconf 2.60 comes out.
688 2005-11-17 Jim Meyering <jim@meyering.net>
690 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
691 (AD_mark_current_as_unremovable): Likewise, but for a local.
694 * tests/mv/acl: Let traps handle removing temporary directories.
696 Expect acl-related tests to fail, until the corresponding
697 patches are committed.
698 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
699 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
701 ACL tests, from Andreas Gruenbacher.
702 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
703 * tests/mv/Makefile.am (TESTS): Add acl.
704 * tests/cp/Makefile.am (TESTS): Add acl.
706 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
708 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
710 * NEWS: Improve quality of ln's diagnostics.
711 * src/ln.c (do_link, usage): Likewise.
712 (do_link): Don't use alloca on a buffer of unbounded size.
714 2005-11-16 Jim Meyering <jim@meyering.net>
716 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
717 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
718 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
720 2005-11-14 Jim Meyering <jim@meyering.net>
722 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
724 2005-11-13 Jim Meyering <jim@meyering.net>
726 * announce-gen: Accept new option, --gpg-key-id=ID and
727 emit a blurb telling how to use the .sig files.
728 * Makefile.cfg (gpg_key_ID): Define.
729 * Makefile.maint (announcement): Use new option and key.
731 Require that most .c files include <config.h>.
732 * Makefile.maint (sc_require_config_h): New rule.
733 (syntax-check-rules): Add it.
734 * .x-sc_require_config_h: New file listing exceptions to the
735 above rule. Some are legit, others are simply grandfathered in.
736 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
738 2005-11-12 Jim Meyering <jim@meyering.net>
740 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
742 2005-11-11 Jim Meyering <jim@meyering.net>
744 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
745 Mention new readlink options in 5.3.0's `New features' section.
746 Spotted by Thomas Hood.
748 2005-11-08 Jim Meyering <jim@meyering.net>
750 * NEWS: Merge in changes from b5_9x branch.
752 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
754 * NEWS: ls now defaults to --time-style='locale', which in turn acts
755 like --time-style='posix-long-iso' if the locale settings are messed up.
756 * src/ls.c (decode_switches): Implement this.
758 2005-11-08 Jim Meyering <jim@meyering.net>
760 * tests/du/2g: s/expensive/very expensive/ in a comment.
763 2005-10-17 Eric Blake <ebb9@byu.net>
765 * src/ls.c (usage): Fix descriptions of --sort, --time.
766 Reported by Vitaly A. Ostanin.
768 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
770 * src/ln.c: Include filenamecat.c.
771 (FILE_BASENAME_CONCAT): Remove.
772 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
773 (main): Use file_name_concat, base_name, and strip_trailing_slashes
774 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
777 2005-11-04 Jim Meyering <jim@meyering.net>
779 * src/du.c (process_file): Don't overflow for files of size >= 2^31
780 on systems with stat.st_blocks of a signed 32-bit type.
781 This bug causes trouble on some AIX 5.1 systems.
782 Report and trivial patch from Paul Townsend:
783 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
784 * NEWS: Mention this.
786 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
787 * tests/du/Makefile.am (TESTS): Add it here.
788 * tests/very-expensive: New file.
789 * tests/Makefile.am (EXTRA_DIST): Add it here.
790 * tests/cp/perm: Mark this test as `very-expensive', too.
792 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
794 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
796 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
798 * src/rm.c (usage): Don't mention rm -d.
800 2005-11-02 Jim Meyering <jim@meyering.net>
802 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
805 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
806 `M+N records in/out' lines don't pollute `make check' output.
808 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
809 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
810 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
811 to indicate that the input file should be piped into the command
812 under test (via `cat FILE | $prog ...').
814 * src/remove.c (remove_entry): Emit a better diagnostic when rm
815 (without -r) fails to remove a directory on a non-Linux system.
816 This change affects only newer Solaris systems (with priv_*
817 functions like priv_allocset). Reported by Keith Thompson.
819 * tests/rm/dir-nonrecur: New file/test for the above fix.
820 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
822 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
824 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
825 POSIX 1002.1-2001 requires.
826 * src/tail.c (parse_obsolete_option): Implement this.
827 Problem reported by Vincent Lefevre.
828 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
829 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
830 (test_vector): Add special cases for _POSIX2_VERSION, and
831 regularize the old ones a bit.
832 * tests/touch/obsolescent: Add y2000 test.
834 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
836 * src/dd.c (skip): Fix off-by-one error reported by
837 Theodoros V. Kalamatianos.
839 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
841 * tests/mkdir/p-3: Require that the test be run as non-root.
842 Problem and trivial fix reported by Theodoros V. Kalamatianos.
844 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
846 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
847 boundary between DEST and SOURCE in the result.
849 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
851 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
852 back to text, to sync with documentation and for backwards
855 2005-10-25 Jim Meyering <jim@meyering.net>
857 * tests/dircolors/simple (other-wr): Add an explicit test for
858 the dircolors bug (NULL-dereference) fixed yesterday.
860 2005-10-24 Jim Meyering <jim@meyering.net>
862 * src/tac.c (tac_file): When determining whether a file is seekable,
863 also test whether it is a tty. Using only the lseek-based test would
864 give a false positive on Solaris. Reported by Peter Fales.
866 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
868 * tests/install/d-slashdot: New test, for "install -d" failure.
869 * tests/install/Makefile.am (TESTS): Add d-slashdot.
870 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
871 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
873 2005-10-24 Jim Meyering <jim@meyering.net>
875 * src/dircolors.c (ls_codes): Add missing comma.
876 Anonymous report and patch from
877 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
879 * src/dircolors.c: Add compile-time assertion that the slack_codes
880 and ls_codes arrays have the same number of elements. This would
881 have prevented the above-fixed bug.
883 * src/expand.c (parse_tab_stops): Add a comment to make this function
884 identical to the one in unexpand.c.
885 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
886 identical to the one in expand.c.
888 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
890 2005-10-23 Jim Meyering <jim@meyering.net>
892 * src/md5sum.c (digest_check, main): Use ptr_align rather than
893 a dangerous pointer-value-to-`unsigned' cast.
894 * NEWS: mention the new sha* programs.
895 * AUTHORS: Add new sha* programs.
897 2005-08-28 David Madore <david.madore@ens.fr>
899 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
900 * README: Add their names to the list.
901 * src/md5sum.c: Provide framework for computing sha-2 hashes.
902 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
903 Rules for compiling sha-2 utilities
904 (noinst_HEADERS): Remove checksum.h.
905 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
907 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
908 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
909 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
910 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
911 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
912 sha384sum, sha512sum test scripts here rather that each in its
915 2005-08-28 David Madore <david.madore@ens.fr>
917 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
918 of the FIPS test vectors).
920 2005-10-23 Jim Meyering <jim@meyering.net>
922 * configure.ac: Use 6.0-cvs as the version string.
923 * NEWS: Adjust accordingly.