1 2006-08-09 Jim Meyering <jim@meyering.net>
3 * src/ls.c: Add a compile-time check to ensure that filetype
4 and filetype_letter have the same number of elements.
6 * tests/misc/sort-rand: Remove use of --seed=S.
8 2006-08-08 Paul Eggert <eggert@cs.ucla.edu>
10 Add a command 'shuf', and modify shred and sort to use the new
11 random number generator library of 'shuf'.
15 * NEWS: Likewise. Mention new --random-source option for shred
16 and sort. Move "sort +1 -2" notice to the appropriate section,
17 and clarify its role with respect to POSIXLY_CORRECT.
18 * man/.cvsignore: Add shuf.1.
19 * man/Makefile.am (dist_man_MANS): Add shuf.1.
20 (shuf.1): New dependency.
21 * man/shuf.x: New file.
22 * src/Makefile.am (bin_PROGRAMS): Add shuf.
23 (EXTRA_DIST): Remove rand-isaac.c.
24 (shuf_LDADD): New macro.
25 * src/rand-isaac.c: Remove, moving most of its contents to
27 * src/shuf.c: New file.
28 * src/shred.c: Use new random-number interface rather than rand-isaac.c.
29 Don't include rand-isaac.c; include randint.h and randread.h instead.
30 (RANDOM_SOURCE_OPTION): New enum.
31 (long_opts, usage, main): New option --random-source.
32 * src/sort.c: Likewise.
33 * src/shred.c (struct irand_state, irand_init, irand32, irand_mod): Remove.
34 All callers changed to use randint interface.
35 (fillrand): Remove. All callers changed to use randread interface.
36 (dopass): Remove dependency on ISAAC buffer size.
37 (genpattern): Don't wipe the random state here.
38 (randint_source): New static var.
39 (clear_random_data): New function.
40 (main): Allocate random source, and arrange to wipe it on exit.
41 * src/sort.c: Include md5.h, randread.h, xmemxfrm.h.
42 (longopts, usage, main): Remove undocumented --seed option;
43 it's now replaced by --random-source.
44 (rand_state, get_hash): Remove.
45 (randread_source): New static var.
46 (random_state, cmp_hashes, compare_random): New functions; they guarantee
47 no collisions in the random hash function.
48 (keycompare): Use compare_random for -R; don't fall back on comparing
49 via memcoll, since compare_random does the right thing.
50 * tests/misc/Makefile.am (TESTS): Add shuf.
51 * tests/misc/shuf: New file.
53 2006-07-29 Paul Eggert <eggert@cs.ucla.edu>
55 * src/copy.c (set_author): Preserve the st_author field via the
56 file descriptor dest_desc.
58 2006-07-28 Paul Eggert <eggert@cs.ucla.edu>
60 * NEWS: chmod now preserves setuid and setgid bits on directories
61 if you use a numeric mode with them clear, e.g., "chmod 755 DIR".
63 Fix test case problems if working directory is setgid,
64 reported by Bob Proulx.
65 * tests/cp/fail-perm: Use symbolic mode so that we clear
66 setgid bit more reliably on directories.
67 * tests/mkdir/special-1 (set_mode_string): Likewise.
69 2006-07-27 Jim Meyering <jim@meyering.net>
71 * src/chgrp.c (usage): Use correct grammar in description of the
73 * src/chown.c (usage): Likewise.
75 2006-07-26 Thomas Schwinge <tschwinge@gnu.org> (tiny change)
77 * src/copy.c (set_author) [HAVE_STRUCT_STAT_ST_AUTHOR]:
78 Correctly access SRC_SB's element ST_AUTHOR.
80 2006-07-26 Jim Meyering <jim@meyering.net>
82 * tests/ls/stat-failed: Adapt to match new expected output.
85 * src/ls.c (print_color_indicator): Test for S_IFREG first, rather
86 than having the code test for all of the other types first.
87 Hoist the set-uid/gid-testing code "up" into this new block.
88 Classify any other type of file (e.g., S_TYPEISSHM, etc.) as
89 C_ORPHAN, not as C_FILE.
91 2006-07-26 Jim Meyering <jim@meyering.net>
93 Checking in a change from Paul.
95 2006-07-25 Paul Eggert <eggert@cs.ucla.edu>
97 * src/ls.c (DT_INIT): Remove. All uses removed.
98 (enum filetype): Use an ordinary enum rather than trying to keep
99 the values in sync with DT_FIFO etc. That way, we don't have
100 to make special assumptions about them. All uses changed.
101 (whiteout): New constant member of enum filetype.
102 (filetype_letter): New constant, for use with enum filetype.
103 (FILETYPE_INDICATORS): New initializer list.
104 (print_dir): Add case for DT_WHT.
105 (gobble_file): If stat fails, don't discard information from
106 readdir; instead, preserve it so it can be printed.
107 (print_long_format): Fall back on readdir result if stat info
108 is not available. Use "?" to denote each unknown mode char,
109 instead of an overall "?", since we now know some of the mode
111 (print_type_indicator): Now that MODE isn't necessarily
112 useful, guard all uses.
113 Now that two blocks in the type-checking tree can set "type = C_FILE",
114 move the suffix-handling code out and down.
116 2006-07-26 Jim Meyering <jim@meyering.net>
118 Prepare for the above change.
119 * src/ls.c [struct fileinfo] (stat_ok): Rename from stat_failed,
120 and adjust uses. From a patch by Paul Eggert.
122 2006-07-26 Jim Meyering <jim@meyering.net>
124 * src/ls.c: Correct indentation/formatting in a few places.
126 2006-07-25 Paul Eggert <eggert@cs.ucla.edu>
128 * tests/cp/fail-perm: Use "chmod 0500" rather than "chmod 500".
129 Problem report and fix from Bob Proulx.
130 * NEWS: Clarify the "chmod 0500" news, and correct the vague
131 statements about compatibility with BSD.
133 2006-07-25 Jim Meyering <jim@meyering.net>
135 * src/ls.c (gobble_file): When handling a stat-failed entry,
136 print the entry name not the absolute_name -- to be consistent
138 * tests/ls/stat-failed: Update accordingly.
140 * src/ls.c: Add parens around the new uses of ?: ternary operator.
142 * src/dircolors.hin: Mention that ORPHAN refers not just to dangling
145 Get --dired offsets right when handling stat-failed entries.
146 * src/ls.c (print_long_format): Be careful to increment P by the
147 appropriate amount, even when inode_number_width and nlink_width
149 * tests/ls/stat-failed: Test for the above.
151 * src/ls.c (gobble_file) [USE_ACL]: Don't use-uninitialized the
152 have_acl member. That would happen for a directory with both a
153 non-stat'able entry and one with an ACL.
155 * src/ls.c (gobble_file): Make it so failure to stat a
156 non-command-line file provokes an exit status of 1, not 0.
157 Say "cannot access" rather than "cannot stat".
158 * tests/ls/stat-failed: New file/test, for the above.
159 * tests/ls/Makefile.am (TESTS): Add stat-failed.
160 * tests/ls-2/tests (no-a-isdir-b): Update to reflect addition
161 of "cannot access " to diagnostic.
163 * src/ls.c: Declare stat_failed to be "bool", not "int" everywhere.
165 * src/ls.c [enum filetype] (command_line): Remove member. Not needed.
166 Replace all occurrences of "type == command_line" with the
167 equivalent, "command_line_arg".
169 * src/ls.c: Apply the stat-failed parts of Red Hat's
170 coreutils-selinux.patch. From Ulrich Drepper.
171 This makes it so files not mentioned on the command line (e.g.,
172 names read from a directory that *is* mentioned on the command
173 line) for which stat fails are still listed. With --color,
174 such files are colored just like ORPHANs (aka dangling symlinks).
176 * src/df.c (n_valid_args): Declare global to be static.
178 2006-07-24 Jim Meyering <jim@meyering.net>
180 * tests/ls/stat-dtype: Skip this test on reiserfs, since that file
181 system lacks d_type support.
183 2006-07-22 Paul Eggert <eggert@cs.ucla.edu>
185 * man/chmod.x: Update to reflect recent changes to coreutils.texi.
187 2006-07-21 Jim Meyering <jim@meyering.net>
189 * src/su.c (usage): Correct typo in --help output: s/commmand/command/
190 Reported by Tim Waugh.
191 Also remove the comment duplicating much of --help output.
193 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): Reposition this new
194 name so the list remains alphabetized.
196 Fix another bug: ls --indicator-style=file-type would call
197 stat for a symlink, even though it wasn't always needed.
198 In some cases, that unnecessary stat would cause ls to fail.
199 * src/ls.c (gobble_file): Don't treat symlinks specially (in
200 requiring a stat syscall). Remove the offending exclusion.
202 * NEWS: Mention the fix.
204 * tests/ls/stat-dtype: New file/test, for the above fix.
205 Also exercises the new df feature, below.
207 * src/df.c (main): Fail and don't print the headers if no
208 file system is processed. This makes it easy to test whether
209 a specified directory is on a file system of a given type or types.
210 Otherwise, applications would have had to parse df's output.
211 E.g., is "." either ext3 or reiserfs: df -t ext3 -t reiserfs .
213 Fix a bug: ls --file-type worked like --indicator-style=slash,
214 rather than like --indicator-style=file-type.
215 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): New enum member.
216 (long_options): Map "file-type" to FILE_TYPE_INDICATOR_OPTION,
218 (decode_switches): Handle new case: FILE_TYPE_INDICATOR_OPTION.
219 * NEWS: Mention the fix.
220 * tests/ls-2/tests (file-type): New test, for the above fix.
222 2006-07-19 Jim Meyering <jim@meyering.net>
224 * src/ls.c (print_dir): Give a better diagnostic for failed opendir.
226 * Makefile.am (EXTRA_DIST): Add build-aux/vc-list-files.
228 2006-07-16 Paul Eggert <eggert@cs.ucla.edu>
230 * NEWS: chmod, install, and mkdir now leave setgid and setuid bits
231 of directories alone unless you specify them explicitly.
232 install and mkdir now implement X correctly.
233 install now creates parent directories with mode 755, without
234 changing their owner or group.
235 * src/chmod.c (process_file): Adjust to mode_adjust API change.
236 * src/install.c: Include mkancesdirs.h.
237 (announce_mkdir, make_ancestor): New functions.
238 (DEFAULT_MODE): New macro, specifying initial value of 'mode'.
240 (dir_mode, dir_mode_bits): New vars.
241 (main): Set dir modes separately from nondir, so that the X
242 op of -m works correctly.
243 (main): Remove cwd_errno cruft, since make_dir_parents no longer
244 affects cwd. Adjust to new make_dir_parents API.
245 (install_file_in_file_parents): 2nd arg is now char *, not char
246 const *. Use mkancesdirs instead of rolling our own code.
247 (change_attributes): Don't worry about AFS, since that kludge
248 should not be needed any more.
249 * src/mkdir.c (struct mkdir_options): New struct.
250 (announce_mkdir, make_ancestor): New functions.
251 (main): Use them. Adjust to mode_adjust API change. Stick with
252 umask 0. Use make_dir_parents for all the work.
253 * src/mkfifo.c (main): Adjust to new mode_adjust API.
254 * src/mknod.c (main): Likewise.
255 * tests/chmod/setgid: Do the setgid test instead of bailing.
256 * tests/mkdir/p-3: Remove re_protect case that no longer applies.
257 GNU chmod now behaves like other versions of chmod.
258 * tests/mkdir/perm: Add a test for the X bug.
260 2006-07-14 Paul Eggert <eggert@cs.ucla.edu>
262 * src/base64.c (do_decode): Output to parameter OUT, not to stdout.
263 This doesn't fix any bugs, since OUT always equals stdout, but it
264 makes the code easier to understand.
266 2006-07-14 Jim Meyering <jim@meyering.net>
268 * Makefile.maint (CVS_LIST): Use new file, build-aux/vc-list-files,
269 rather than open-coding it. Now supports mercurial, too.
270 * .hgignore: New file.
271 * Makefile.am (EXTRA_DIST): Add .hgignore, which ignores nearly
272 all generated files, including ones like configure and po/*.po
273 that are currently version-controlled in cvs.
275 * Makefile.am (EXTRA_DIST): Add a few more .??* files.
276 They've been in CVS, just haven't been distributed before this.
277 Distribute ChangeLog-2005, too.
278 (MAINTAINERCLEANFILES): Add THANKS-to-translators.
280 2006-07-11 Paul Eggert <eggert@cs.ucla.edu>
282 * src/system.h: Assume <dirent.h> exists, since gnulib assumes
285 2006-07-09 Jim Meyering <jim@meyering.net>
287 * tests/mv/dir2dir: Adjust so failing with ENOTEMPTY is ok, too.
288 That happens with Linux/tmpfs.
289 * tests/mv/Makefile.am (TESTS): Add dir2dir.
291 2006-07-09 Paul Eggert <eggert@cs.ucla.edu>
293 Adjust to recent updates from gnulib.
294 * src/dd.c (apply_translations): Use toupper rather than
295 islower followed by toupper; it's simpler and typically
296 faster now that we assume at least C89 semantics. Similarly
298 * src/sort.c (inittables): Likewise.
299 * src/expand.c (expand): Don't assume that isprint etc. return
300 booleans (needed for pre-C99 hosts).
301 * src/fmt.c (check_punctuation): Likewise.
302 * src/ptx.c (initialize_regex, fix_output_parameters): Likewise.
303 * src/tr.c (is_char_class_member): Likewise.
304 * src/unexpand.c (unexpand): Likewise.
305 * src/join.c (is_blank): Remove; no longer needed. All uses
306 replaced by isblank (to_uchar (...)).
307 * src/pinky.c (create_fullname): Don't assume char is unsigned.
308 * src/printf.c (print_esc): Likewise.
309 * src/ptx.c (SKIP_NON_WHITE, SKIP_WHITE, SKIP_WHITE_BACKWARDS):
310 (copy_unescaped_string): Likewise.
311 * src/stat.c (print_it): Likewise.
312 * src/system.h (_D_EXACT_NAMELEN): Renamed from NLENGTH, for
313 convenience on GNU systems. All uses changed. Don't bother
314 looking for any dirent.h substitute other than ndir.h.
315 (D_INO): Remove unnecessary parentheses.
316 (IN_CTYPE_DOMAIN, ISGRAPH, ISPRINT, ISALNUM, ISALPHA):
317 (ISCNTRL, ISLOWER, ISPUNCT, ISSPACE, ISUPPER, ISXDIGIT):
318 (ISDIGIT_LOCALE, TOLOWER, TOUPPER): Remove. All uses changed
319 to ctype.h equivalents.
320 (isblank): Renamed from ISBLANK. Check for HAVE_DECL_ISBLANK too.
323 2006-07-08 Jim Meyering <jim@meyering.net>
325 * tests/mv/dir2dir: New file, test for 2006-07-05 fix in copy.c.
327 * Makefile.maint (sc_the_the): New rule.
329 * src/dd.c (skip): Remove one of two adjacent "the"s in a comment.
330 * tests/Coreutils.pm (run_tests): Remove one of two adjacent "then"s
333 2006-07-07 Jim Meyering <jim@meyering.net>
335 * NEWS: Mention that mv can now remove an empty destination directory,
336 and give an example. Prompted by a report from Florent Bayle.
338 2006-07-05 Jim Meyering <jim@meyering.net>
340 * src/ls.c (usage): Correct the description of -G: it is useful
341 only in a long listing. Reported by Martin Pool in
342 <https://launchpad.net/distros/ubuntu/+source/coreutils/+bug/51653>.
344 * man/chmod.x: Correct the description of the sticky bit. Reported
345 by Chris Moore via Ian Jackson in <http://bugs.debian.org/376745>.
347 * src/copy.c (copy_internal): Don't work around old NFS clients like
348 SunOS-4.1.4 and Irix 5.3 that set errno to values like EIO and
349 ENOTEMPTY upon failed rename. Otherwise, we risk misinterpreting
350 a banal failure as a recursive move-into-self failure.
351 Reported by Florent Bayle in <http://bugs.debian.org/376749>.
353 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
355 2006-07-03 Jim Meyering <jim@meyering.net>
357 Plug another unusual leak.
358 (AD_mark_helper): Free malloc'd filename if hash_insert says
359 that string is already in the hash table.
361 The dev/inode of the topmost directory in each hierarchy were not
363 * src/remove.c (remove_cwd_entries): Don't call cycle_check here.
364 (AD_push): Call it from here instead.
367 * src/remove.c (AD_stack_clear): New function.
369 (AD_pop_and_chdir): Free *prev_dir just before longjmp.
371 * tests/Makefile.am, tests/*/Makefile.am: (TESTS_ENVIRONMENT):
372 Add $VG_PATH_PREFIX as a prefix to $PATH
374 * tests/envvar-check (vars): Add CDPATH and POSIXLY_CORRECT.
375 * tests/Makefile.am (evar-check): Remove rule.
376 (EXTRA_DIST): Remove .env-warn.
377 * tests/.env-warn: Remove file. No longer used.
378 Suggestion from Eric Blake.
380 2006-07-02 Paul Eggert <eggert@cs.ucla.edu>
382 * src/system.h: Include <stdint.h> unconditionally, since we
383 now assume the stdint module.
385 2006-07-01 Paul Eggert <eggert@cs.ucla.edu>
387 * NEWS: With no operand, 'tail -f' now silently ignores the '-f'
388 only if standard input is a FIFO or pipe and POSIXLY_CORRECT is set.
389 * src/tail.c (main): Implement this.
390 * tests/tail/Test.pm (f-pipe-1): Renamed from f-1.
391 (test_vector): Set POSIXLY_CORRECT for the f-pipe-* tests.
393 2006-07-01 Jim Meyering <jim@meyering.net>
395 * src/ln.c (do_link): Use new, shorter URL, for ag-review link.
397 * .x-sc_require_config_h: Add ^lib/xstrtold\.c$, so make distcheck
400 2006-06-30 Paul Eggert <eggert@cs.ucla.edu>
402 * NEWS: seq now uses long double internally rather than double.
403 It now defaults to a minimal fixed point format if possible.
404 It lets you use %a, %A, %E, %F, %G.
405 * src/Makefile.am (seq_LDADD): Remove $(SEQ_LIBM); add $(POW_LIB).
406 * src/seq.c: Don't include <math.h> or <xstrtol.h>; no longer needed.
407 (isfinite) [!defined isfinite]: New macro.
408 (separator, terminator): Now points to const.
409 (first, step, last): Remove.
410 (usage): Update to match new behavior.
411 (struct operand, operand): New type.
412 (scan_arg): Renamed from scan_double_arg, since we no longer use double.
414 Compute and return a value of type operand, not double.
415 (long_double_format): Renamed from valid_format, and now returns a
416 new format with an "L" added if needed, if the original format was
417 valid. Allow %a, %A, %E, %F, and %G formats.
418 (print_numbers): Take numeric values as args rather than from globals.
419 Print long double, not double.
420 (get_width_format): Remove.
421 (get_default_format): New function.
422 (main): Implement new way of calculating default format.
423 Don't worry about locale's representation of the decimal point, since
424 the arguments are always processed in the C locale.
425 * tests/seq/basic (neg-2): Adjust to new default format.
426 (eq-wid-1, eq-wid-2): Resurrect these tests, since the new
427 implementation should do the right thing.
429 2006-06-30 Jim Meyering <jim@meyering.net>
431 * tests/stty/basic-1: Work around an intermittent test failure
432 on HP-UX 11.11. Report and analysis from Bob Proulx.
433 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7475
435 2006-06-28 Paul Eggert <eggert@cs.ucla.edu>
437 * NEWS: Support obsolete usages like "sort +1 -2" even when
438 conforming to POSIX 1003.1-2001, since this is a pure extension to
439 POSIX. Problem reported by Christian in:
440 http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00220.html
441 * src/sort.c (main): Implement this.
443 * src/system.h (CLOSEDIR): Remove. All uses changed to closedir.
444 Autoconf 2.60 says this stuff was obsolete.
446 2006-06-28 Jim Meyering <jim@meyering.net>
448 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
450 2006-06-28 Bob Proulx <bob@proulx.com> (tiny change)
452 * tests/mv/i-link-no: Work around HP-UX /bin/sh tracing problem
453 (set -x when VERBOSE=yes) when stderr is redirected before stdout
454 causing shell tracing of the stdout redirection to be written to
455 the stderr file. Avoid problem and test failure on HP-UX by
456 redirecting stderr last.
457 * tests/dd/unblock-sync: Order shell file redirections for
458 stderr and stdout in the common style.
461 2006-06-27 Jim Meyering <jim@meyering.net>
463 * tests/misc/cat-proc: Try to avoid any spurious numeric
464 differences in frequently-changing /proc/cpuinfo.
465 Reported by Nelson Beebe.
467 2006-06-26 Jim Meyering <jim@meyering.net>
469 Attempt rmdir (actually, unlinkat-with-AT_REMOVEDIR) upon any
470 fd_to_subdirp failure, not just when errno == EACCES.
471 * src/remove.c (remove_dir): Use unlinkat-with-AT_REMOVEDIR, not
472 rmdir, here, even though rmdir may happen to be adequate.
474 * NEWS: rm no longer fails to remove an empty, unreadable directory
475 * src/remove.c (remove_cwd_entries): If we can't open a directory,
476 and the failure is not being ignored, try to remove the directory
477 with rmdir (aka unlinkat-with-AT_REMOVEDIR), in case it's empty.
478 Problem report and test case from Paul Eggert in
479 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7425>.
481 * tests/rm/empty-inacc: New test, for the above.
483 Avoid a segfault for wc --files0=- < /dev/null.
484 * src/wc.c (compute_number_width): Return right away if nfiles == 0.
486 2006-06-25 Jim Meyering <jim@meyering.net>
488 * NEWS: wc accepts a new option --files0-from=FILE, where FILE
489 contains a list of NUL-separated file names.
491 * src/wc.c: Include "readtokens.h".
492 (usage): Describe the new option, and adjust the `Usage':
493 with this option, no FILE may be specified on the command line.
494 (main): Handle the new option.
495 * tests/misc/wc-files0: New tests, for the above.
496 * tests/misc/wc-files0-from: Likewise.
497 * tests/misc/Makefile.am (TESTS): Add wc-files0.
499 2006-06-24 Jim Meyering <jim@meyering.net>
501 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
503 2006-06-22 Jim Meyering <jim@meyering.net>
505 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
506 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
508 2006-06-19 Jim Meyering <jim@meyering.net>
510 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
511 so this check is not run as part of "make distcheck".
513 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
515 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
517 2006-06-18 Jim Meyering <jim@meyering.net>
519 * tests/misc/pwd-long: Make error output a little clearer.
521 2006-06-17 Jim Meyering <jim@meyering.net>
523 * tests/rm/inaccessible: Skip this test on systems without openat
524 support. Reported by Bob Proulx.
526 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
528 * tests/misc/mknod: Improve permission checks to handle
529 running mkdir test in set-gid directories.
531 2006-06-14 Jim Meyering <jim@meyering.net>
533 * tests/du/basic: Revamp not to hard-code file system block sizes.
535 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
537 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
540 2006-06-11 Jim Meyering <jim@meyering.net>
542 * .gitignore: New file.
543 * Makefile.am (EXTRA_DIST): Add .gitignore.
545 Setting TIME_STYLE=long-iso in the environment would make the
546 cp/same-file test fail.
547 * tests/envvar-check (vars): Add TIME_STYLE to the list.
548 * tests/cp/same-file: Revert last change.
549 Source the envvar-check script, to ensure that TIME_STYLE
550 settings don't affect these tests.
552 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
554 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
555 uses POSIX time stamp formats. Problem reported by John Nixon in
556 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
558 2006-06-10 Jim Meyering <jim@meyering.net>
560 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
562 Require a "Version N.M" line at the top of the ChangeLog
563 file only when making the actual release, not when running
565 * Makefile.maint (maintainer-distcheck): Don't depend on
567 (alpha beta major): Depend on it here, instead.
569 2006-06-08 Jim Meyering <jim@meyering.net>
571 Ensure that cat works with any of the options, -A -v -e -E -T,
572 when applied to files in /proc and /sys, even when the FIONREAD
573 ioctl produces nonsensical results. Before this change, cat would
574 produce no output (or truncated output), for some linux kernels.
576 * src/cat.c (write_pending): New function, factored out of cat.
577 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
578 that there are bytes to read. Some versions of linux-2.6.16 do that.
579 Write any pending output before returning.
580 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
581 * NEWS: Mention this bug fix.
582 * tests/misc/cat-proc: New file. Test for the above.
583 * tests/misc/Makefile.am (TESTS): Add cat-proc.
585 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
587 * src/expr.c (eval4): Detect overflow properly when multiplying
590 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
592 * NEWS: The 'expr' command now detects and reports integer overflow.
593 (It would be better to use extended precision instead, but that
595 * src/expr.c (integer_overflow): New function.
596 (eval4, eval3): Check for integer overflow.
598 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
600 Fix problems when building with Solaris/SVR4/etc. make, which uses a
601 different and somewhat bogus implementation of VPATH. In the
602 directory tests/misc, rename tests whose names might appear in the
603 Automake-generated rules. For example, we can't use a test named
604 'test', since Automake generates a rule that contains the text
605 "if test -f ./$$tst; ...", and this might expand to something like
606 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
607 which executes the 'test' script rather than the 'test' command.
608 * tests/misc/false-status: Renamed from tests/misc/false.
609 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
610 * tests/misc/sort-merge: Renamed from tests/misc/sort.
611 ($prog): Set to 'sort' rather than to $PROG.
612 * tests/misc/test-diag: Renamed from tests/misc/test.
613 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
614 in case Solaris make has prepended the directory.
615 (TESTS): Adjust to above renamings.
616 * tests/misc/expand: Don't assign to PROG; no longer needed
617 now that Makefile.am sets PROG to the basename.
618 * tests/misc/fold: Likewise.
620 2006-06-03 Jim Meyering <jim@meyering.net>
622 Make `cp --link --no-dereference' work also on systems where the
623 link system call cannot create a hard link to a symbolic link.
624 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
625 the link syscall on a symlink when it would do the wrong thing.
626 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
627 * tests/cp/link-no-deref: New file/test for the above.
628 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
629 * NEWS: Mention the change (doesn't affect Linux).
631 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
633 Fix some porting problems in the test cases reported by
634 Ralf Wildenhues for HP-UX 11.23 in:
635 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
636 * tests/help-version: Don't assume that \< \> works in sed.
637 * tests/misc/close-stdout: Don't assume that >&- works.
638 Add a /dev/full test.
639 * tests/touch/no-create-missing: Don't assume that >&- works.
641 2006-05-30 Jim Meyering <jim@meyering.net>
643 * src/ls.c (usage): Add `v' to the list of sorting-related options.
646 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
648 * tests/cp/fail-perm: source lang-default.
649 * tests/rm/inaccessible: Likewise.
651 2006-05-28 Jim Meyering <jim@meyering.net>
653 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
654 Recognize it, too. Reported by Ralf Wildenhues, in
655 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
657 2006-05-27 Jim Meyering <jim@meyering.net>
659 * src/chgrp.c: Support new options: --preserve-root and
660 --no-preserve-root. Somehow this program was skipped when those
661 options were added to chown, chmod, and rm. Reported by
662 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
663 * NEWS: Mention this.
665 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
667 * NEWS: Remove mention of --seed. We'll replace it with something
668 better, and don't want to indicate that it is supported.
669 * src/sort.c (usage): Likewise.
671 2006-05-20 Jim Meyering <jim@meyering.net>
673 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
675 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
676 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
677 FTS_COMFOLLOW. Spotted by Justin Pryzby.
679 * gnupload: Merge changes from automake, retaining the ""--to...
680 kludge to placate overzealous `make distcheck' check.
682 2006-05-19 Jim Meyering <jim@meyering.net>
684 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
685 FTS_TIGHT_CYCLE_CHECK directory traversal option.
686 Reported by Justin Pryzby in http://bugs.debian.org/367691
688 2006-05-15 Jim Meyering <jim@meyering.net>
690 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
693 2006-05-13 Jim Meyering <jim@meyering.net>
695 * tests/mv/no-target-dir: Test two more cases.
697 2006-05-11 Jim Meyering <jim@meyering.net>
699 mv -T DIR EMPTY_DIR no longer fails unconditionally
700 * src/copy.c (copy_internal): Don't manually prohibit a move where
701 the destination is an existing directory. Sometimes doing that is
702 valid. Let the rename system call enforce the rules. That is
703 allowed only when the source is a directory and the destination
704 directory (to be replaced) is empty. Reported by Eric Blake.
705 * tests/mv/no-target-dir: New file/test for this.
706 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
707 * NEWS: Mention this.
709 * tests/mv/atomic: New file/test for yesterday's fix.
710 * tests/mv/Makefile.am (TESTS): Add atomic.
712 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
714 2006-05-10 Jim Meyering <jim@meyering.net>
716 * src/copy.c (copy_internal): Don't explicitly unlink the destination
717 when moving a symlink into the place of an existing non-directory.
718 Reported by Joshua Hudson.
719 * NEWS: mention this.
721 2006-05-07 Jim Meyering <jim@meyering.net>
723 * Makefile.maint (patch-check): Fail if patch generates any output,
724 even merely for changed offsets.
726 * src/c99-to-c89.diff: Adjust to reflect new offsets.
728 * NEWS: Mention changes affecting df, pwd, shred.
730 2006-05-06 Jim Meyering <jim@meyering.net>
732 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
733 system condition where dirent.d_ino != stat.st_ino.
734 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
736 2006-05-06 Eric Blake <ebb9@byu.net>
738 * tests/ls/inode: Expand to test inode from readdir case.
739 * tests/ls/follow-slink: Expand to test broken links encountered
740 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
742 2006-05-06 Eric Blake <ebb9@byu.net>
744 * tests/mv/leak-fd: Work even on case-insensitive file system.
746 2006-05-04 Jim Meyering <jim@meyering.net>
748 * NEWS: Mention the 2006-03-19 pwd-related change that makes
749 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
751 2006-05-03 Jim Meyering <jim@meyering.net>
753 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
754 Use better macro parameter names: s/basename/key_name/,
755 s/basefunc/key_cmp_func. Fix typo in comment.
757 2006-04-29 Eric Blake <ebb9@byu.net>
759 * src/ls.c (main): On systems with d_type, directories_first only
760 implies format_needs_type, not format_needs_stat.
762 2006-05-03 Jim Meyering <jim@meyering.net>
764 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
765 after comma in arg list, from Eric Blake.
767 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
769 * tests/misc/date (relative-3): New test, derived from a bug
770 report by John Thomas McDole.
772 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
774 New option for ls: --group-directories-first.
775 It makes ls list directories before files.
776 * NEWS [New features]: Mention it.
777 * src/ls.c (sort_type): Rearrange to use as an array index when
778 choosing sort function; added new sort_numtypes member for
780 (time_type): Add new time_numtypes member for compile-time check.
781 (directories_first): New global variable.
782 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
783 (long_options): Add --directories-first.
784 (main): Support new option.
785 (is_directory): New function.
786 (extract_dirs_from_files): Use it.
787 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
788 (LIST_SORTFUNCTION_VARIANTS): New macros.
789 (sort_functions): New global variable.
790 (sort_files): Use it.
791 (usage): Document new option.
793 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
795 * src/shred.c (fillrand): The assertion was way too weak, due to
796 what must be a typo. Strengthen it to its intended value.
797 (dopass): Don't use alloca; it's not worth the aggravation here,
798 since it's used only to get a page-aligned buffer, and page
799 alignment doesn't buy us much here. I'm suspicious that alloca
800 causes problems on some hosts, due to a recent bug report by Adam
801 Waltman: http://bugs.gentoo.org/130246.
803 2006-04-18 Jim Meyering <jim@meyering.net>
805 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
806 sha384sum, sha512sum.
808 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
810 * src/chmod.c (describe_change): Adjust to filemode changes.
811 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
812 (print_long_format): Use (new) filemodestring rather than
813 (old) mode_string, so that we get more file types right, at least
814 in theory. Adjust to filemode changes.
815 * src/stat.c (human_access): Likewise.
817 2006-04-18 Jim Meyering <jim@meyering.net>
819 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
820 ignore file. This has never been enabled. Reported by Eric Blake.
822 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
824 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
825 bug in Interix. Just call symlink or link directly. All uses changed.
826 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
827 * src/stat.c (USE_STATVFS): New macro.
828 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
829 (NAMEMAX_FORMAT): define a bit more clearly, now that the
830 statvfs-using code is a bit more regular.
831 * src/system.h (sync) [!HAVE_SYNC]: New macro.
833 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
835 * NEWS: csplit, nl, expr now conform to POSIX better, and are
836 more-compatible with traditional Unix, with respect to regular
838 * src/csplit.c (extract_regexp): Set re_syntax_options to a
839 value that is compatible with what POSIX requires.
840 * src/nl.c (build_type_arg): Likewise.
841 * src/expr.c (docolon): Likewise. Also, don't let anchors match
842 newline; this fixes an incompatibility with tradition and with POSIX.
843 Don't warn about leading ^. POSIX says it is unspecified whether
844 ^ is a special character, which means that implementations can
845 either treat it as special or not, but either way a warning is not
846 allowed (unless the regexp is otherwise invalid). Instead, anchor
847 the expression but treat ^ as an anchor; this is the traditional
848 behavior (e.g., Solaris 10).
849 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
850 and the like as invalid expressions (exit status 2), not as
851 failure of 'expr' (exit status 3). This is more consistent with
853 * tests/expr/basic (fail-a): Adjust exit status to match new expr
854 behavior, for status 2 versus 3.
856 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
857 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
858 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
859 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
860 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
861 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
862 (bre61, bre62): New tests.
863 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
867 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
868 "if !". Do not assume that 'sed' can handle long, newline-free input.
869 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
871 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
873 Adjust to new regex.h API (with new fastmap type), and clean
874 up the regex storage allocation a bit.
876 * src/csplit.c (struct control): Put re_compiled member at the
877 end, since it's large. Change regexpr member from char * to bool;
878 all uses changed. Add new member fastmap.
879 (extract_regexp): regexp arg is now char const *, not char *.
880 Don't bother duplicating the regular expression; it's not needed.
881 Set fastmap from new fastmap member. Don't bother allocating
882 a buffer, as the regexp code does a better job than we do.
883 * src/expr.c (docolon): Allocate and use a fastmap.
884 Don't bother allocating a buffer.
885 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
887 (build_type_arg): New fastmap arg. All uses changed.
888 Don't bother allocating a buffer, but set a fastmap.
889 * src/ptx.c (context_regex_string, word_regex_string): Remove.
890 (context_regex, word_regex): New vars, replacing the above.
892 (struct regex_data): New type.
893 (compile_regex): Renamed from alloc_and_compile_regex, since
894 we no longer allocate storage. Arg is now a struct regex_data *,
895 not a const char *. All uses changed. Don't allocate the fastmap;
896 instead, take it from the caller. Don't convert size_t to int,
897 to avoid arithmetic overflow problems. Don't bother freeing
898 storage afterwards; it's not worth the aggravation.
899 * src/tac.c (compiled_separator_fastmap): New ver.
900 (main): Use it. Don't bother allocating a buffer.
902 2006-03-30 Jim Meyering <jim@meyering.net>
904 * src/dd.c (iwrite): Remove assignment without effect.
905 Reported by Felix Rauch Valenti.
907 2006-03-22 Eric Blake <ebb9@byu.net>
909 * src/ptx.c (usage): Remove mention of --copyright/-C.
910 (main): Alias --copyright to --version plus a deprecation warning.
911 * NEWS: Mention this.
913 2006-03-27 Jim Meyering <jim@meyering.net>
915 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
916 use of strtod. Tiny patch from Nickolai Zeldovich.
918 2006-03-11 Eric Blake <ebb9@byu.net>
920 * tests/misc/dirname: New file.
921 * tests/basename/Makefile.am: Delete.
922 * tests/basename/basic: Move to...
923 * tests/misc/basename: ... this new file. Add some tests,
924 including fixed behavior for //.
925 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
926 * tests/Makefile.am (SUBDIRS): Remove basename.
927 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
929 Improvements to dirname/basename handling on platforms like
930 cygwin with distinct // and with drive letters.
931 * NEWS: Document new behavior.
932 * src/basename.c (main): Don't strip suffix from file system
934 * src/cp.c (target_directory_operand): Use new last_component.
935 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
936 traversing the string.
937 * src/dircolors.c (guess_shell_syntax): Use new last_component.
938 * src/install.c (target_directory_operand, install_file_in_dir):
940 * src/ln.c (target_directory_operand, main): Likewise.
941 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
942 * src/mv.c (target_directory_operand, movefile): Likewise.
943 * src/remove.c (rm_1): Likewise.
944 * src/shred.c (wipename): Likewise.
945 * src/split.c (next_file_name): Likewise.
946 * src/su.c (log_su, run_shell): Likewise.
948 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
950 * NEWS: nohup diagnostics are now more precise, and nohup now
951 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
952 * src/nohup.c (main): Implement this.
953 * tests/misc/nohup: Test the new behavior.
955 2006-03-12 Jim Meyering <jim@meyering.net>
957 * src/copy.c (set_author): Rename function, from preserve_author.
959 * src/remove.c (AD_pop_and_chdir): Use new macro,
960 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
962 * src/system.h (SAME_INODE): Remove definition.
963 Include "same-inode.h", instead.
965 2006-03-11 Eric Blake <ebb9@byu.net>
967 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
969 2006-03-10 Jim Meyering <jim@meyering.net>
971 Fix a bug whereby a user with write access to a directory being removed
972 could cause the removal of that directory to fail with an erroneous
973 diagnostic about a directory cycle. Reported by Vineet Chadha.
975 * NEWS: Mention this.
976 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
977 leave (and try to rmdir) is the one whose dev_ino is being used to
978 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
980 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
982 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
983 * src/dd.c (set_fd_flags): Handle file-creation flags on file
984 descriptors, rather than ignoring them.
985 * tests/dd/misc: Add test cases for append, nofollow, directory,
986 and nolinks flags. Simplify redirection to /dev/null in some cases.
988 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
989 noatime test never tested anything.
991 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
993 * src/dd.c (flags, usage): New flags directory, nolinks.
994 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
996 * src/ls.c (usage): Mention that -f disables --color.
997 Problem reported by Niels Möller.
999 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
1001 * man/*.x: Add references to syscalls from utilities of the same name.
1003 2006-03-05 Jim Meyering <jim@meyering.net>
1005 * tests/help-version: Set SHELL, if not already set, in order to
1006 avoid failure when `make check' is run through debuild; dircolors
1007 would fail due to lack of $SHELL. Reported by Sven Joachim.
1009 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
1010 * src/base64.c (wrap_write, do_encode, main): Change type of
1011 parameters and locals, wrap_column, form size_t to uintmax_t.
1012 (main): Adjust to use xstrtoumax, accordingly.
1014 2006-03-03 Jim Meyering <jim@meyering.net>
1016 Don't fail when run from an environment with SHELL not a Bourne
1017 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
1018 * tests/dircolors/simple: Invoke each non-failing test with -b.
1019 Reported by Michael Stone.
1021 2006-02-27 Jim Meyering <jim@meyering.net>
1023 * tests/misc/base64: Derive --decode-using tests from the
1026 * tests/misc/base64: Factor out a long constant string.
1027 Split lines to stay within 80 columns.
1029 * tests/misc/Makefile.am (TESTS): Add base64.
1030 * tests/misc/base64: Test base64. From Simon Josefsson.
1032 * src/base64.c (do_decode): Use correct type for parameter,
1033 ignore_garbage: s/size_t/bool/.
1035 * src/base64.c: Don't include .h files already included by system.h:
1036 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
1037 Include "system.h" before the other lib/*.h header files.
1038 Include <sys/types.h> before "system.h".
1039 (wrap_write): Remove declaration of unused local, initial_column.
1040 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
1042 * README: Add base64 to the list.
1044 2006-02-17 Simon Josefsson <jas@extundo.com>
1046 New program: base64.
1047 * AUTHORS: Mention base64.
1049 * man/Makefile.am: Build base64.1.
1050 * man/base64.x: New file.
1051 * src/Makefile.am (bin_PROGRAMS): Add base64.
1052 * src/base64.c: New file.
1054 2006-02-25 Eric Blake <ebb9@byu.net>
1056 In ls, avoid calling stat for --inode (-i), when possible.
1057 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
1058 * src/system.h: ... here, for use in ...
1059 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
1061 (gobble_file): Add inode argument.
1062 (print_dir): Pass inode if available.
1063 (usage): Remove inaccuracy.
1065 2006-02-23 Jim Meyering <jim@meyering.net>
1067 * TODO: Update/correct some obsolete entries.
1069 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
1071 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
1072 * src/join.c (usage): Likewise.
1073 Documentation problem reported by Philip Kensche.
1075 2006-02-20 Eric Blake <ebb9@byu.net>
1077 * man/rm.x: Update documentation to match previous patch.
1079 2006-02-18 Eric Blake <ebb9@byu.net>
1081 New option for rm: --interactive=once (-I).
1082 * NEWS: Document it, along with change to rm --interactive.
1083 * TODO: Remove entry for implementing rm -I
1084 * src/rm.c (INTERACTIVE_OPTION): New enum value.
1085 (interactive_type): New enum.
1086 (long_opts): Let interactive take an optional argument.
1087 (interactive_args, interactive_types): New option arguments.
1088 (usage): Document -I, --interactive=WHEN. Use program_name
1089 instead of a basename.
1090 (main): New -I option, new behavior to --interactive.
1091 * tests/rm/interactive-once: New tests.
1092 * tests/rm/interactive-always: Ditto.
1093 * tests/rm/Makefile.am (TESTS): Run them.
1095 2006-02-18 Jim Meyering <jim@meyering.net>
1097 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
1098 expression match more of the target lines, e.g., those that start with
1099 `-S,' (short option followed by a comma) or that include `=[...]'.
1100 Patch by Nicolas François.
1101 Fix the four offenders thus exposed:
1102 * src/join.c (usage): Use two spaces (not one) to separate the
1103 --first-only option string from its description, so help2man formats
1104 the derived man page properly.
1105 * src/pr.c (usage): Likewise.
1106 * src/uniq.c (usage): Likewise.
1107 * src/install.c (usage): Likewise.
1109 2006-02-15 Jim Meyering <jim@meyering.net>
1111 * Makefile.maint (alpha beta major): For `make major', ensure that the
1112 version string is of the form N.N[.N]*, where N is one or more digits.
1114 2006-02-14 Jim Meyering <jim@meyering.net>
1116 * INSTALL: Update from gnulib.
1118 2006-02-13 Jim Meyering <jim@meyering.net>
1120 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
1122 2006-02-12 Jim Meyering <jim@meyering.net>
1124 * Makefile.maint (patch-check): New target.
1125 (local-checks-available): Add to the list.
1127 2006-02-11 Jim Meyering <jim@meyering.net>
1129 * src/c99-to-c89.diff: New file.
1130 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
1132 * .x-po-check: New file, with exclusions so that `make distcheck'
1134 * Makefile.am (EXTRA_DIST): Add .x-po-check.
1136 rm -r must remove an empty directory, even if it is inaccessible.
1137 * src/remove.c (close_preserve_errno): New function.
1138 (fd_to_subdirp): Don't print a diagnostic in this function.
1139 Do it from the callers instead, unless rmdir succeeds.
1140 (remove_cwd_entries, remove_dir): Adjust callers.
1141 * tests/rm/empty-inacc: New test for the above.
1142 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
1143 * NEWS: Mention this bug fix.
1144 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
1145 a tiny bit less precise: cannot remove `a/1': ... instead of
1146 cannot open directory `a/1': ...
1148 * Makefile.maint (syntax-check-rules): Automatically derive this
1149 list of sc_-prefixed rule names.
1151 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
1153 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
1154 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
1155 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
1156 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
1157 go away? was that an accident?)
1158 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
1159 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
1160 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
1161 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
1162 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
1163 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
1164 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
1165 (author_mark_check, makefile_path_separator_check):
1166 Output line numbers, to simplify navigation of Emacs *compilation*
1168 (sc_prohibit_atoi_atof, sc_file_system):
1169 Rework slightly so that Makefile.maint doesn't get reported as a
1170 violation of its own syntax rules.
1171 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
1172 it at run-time (which didn't work with Bison). Fix a makefile typo,
1173 caught by Makefile.maint itself: spaces where a tab should be.
1174 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
1175 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
1176 Ignore djgpp and man subdirectories, to avoid false matches with
1177 Bison and coreutils, respectively. Use sort -u to remove the
1178 resulting duplicates.
1179 * gnupload: Rework slightly to avoid bogus warning from
1180 sc_two_space_separator_in_usage.
1182 2006-02-10 Jim Meyering <jim@meyering.net>
1184 Use gzip's --rsyncable option only if it's available.
1185 * Makefile.maint (gzip_rsyncable): New variable.
1188 2006-02-08 Jim Meyering <jim@meyering.net>
1190 * Makefile.maint (local-checks-available): Define in terms of
1191 the expansion, $(syntax-check-rules), rather than the single,
1192 top-level target `syntax-check', so that it's easier to exclude
1193 individual rules (via $(local-checks-to-skip)).
1194 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
1196 2006-02-07 Jim Meyering <jim@meyering.net>
1198 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
1199 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
1201 * tests/help-version (expected_failure_status_vdir):
1202 Redirect an expected disk-full diagnostic to /dev/null.
1204 2006-02-06 Jim Meyering <jim@meyering.net>
1206 * src/unexpand.c (usage): Use two spaces (not one) to separate the
1207 --first-only option string from its description, so help2man formats
1208 the derived man page properly.
1209 * src/rm.c (usage): Likewise for --no-preserve-root.
1210 * src/chown.c (usage): Likewise.
1211 * src/chgrp.c (usage): Likewise.
1213 Add a rule to ensure that the above doesn't happen again.
1214 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
1215 (syntax-check-rules): Add it.
1216 * .x-sc_two_space_separator_in_usage: New empty file.
1217 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
1219 2006-02-06 Jim Meyering <jim@meyering.net>
1221 * src/cp.c (usage): Use two spaces (not one) to separate each
1222 option string from its description, so help2man formats the
1223 derived man page properly.
1224 * src/mv.c (usage): Likewise.
1225 Patch from Nicolas François in http://bugs.debian.org/351601.
1227 2006-02-04 Jim Meyering <jim@meyering.net>
1229 * src/copy.c (copy_internal): cp -RL would fail when encountering
1230 the same directory more than once in the hierarchy beneath a single
1231 command-line argument. That is legitimate, e.g. when there are
1232 two or more symbolic links, each pointing to some directory that
1233 would not otherwise be copied. Reported by Christophe LYON.
1234 * tests/cp/cp-deref: New file. Test for today's fix.
1235 * tests/cp/Makefile.am (TESTS): Add cp-deref.
1236 * NEWS: Document this.
1238 2006-02-03 Jim Meyering <jim@meyering.net>
1240 * configure.ac: Require automake-1.9.6, not 1.8.3.
1242 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
1244 * src/od.c (usage): Mention that -t a ignores high order bit.
1245 Documentation problem reported by Ed Avis.
1247 2006-02-01 Jim Meyering <jim@meyering.net>
1249 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
1251 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
1253 * src/head.c (main): Use a better diagnostic when someone uses a
1254 trailing numeric option in an invalid way. Problem reported by
1256 * src/tail.c (parse_options): Likewise.
1258 2006-01-30 Jim Meyering <jim@meyering.net>
1260 * man/wc.x: Include `count' keyword in man page synopsis,
1261 per suggestion from http://bugs.debian.org/181585.
1263 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
1265 * src/df.c (show_dev): If the file system claims to have
1266 more available than total blocks, report the number of used
1267 blocks as being total - available (a negative number) rather
1268 than as garbage. Problem reported by Toralf Foerster.
1270 2006-01-24 Jim Meyering <jim@meyering.net>
1272 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
1273 to put a regular file in O_NONBLOCK mode fails with EPERM.
1274 That happens on Linux (up to 2.6.15) when using tail -f on a file with
1275 the append-only attribute. Reported by Dean Gaudet. For details,
1276 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
1277 * NEWS: Mention this fix.
1278 * tests/tail-2/append-only: New file. Test for the above.
1279 * tests/tail-2/Makefile.am (TESTS): Add append-only.
1280 * tests/Makefile.am (check-root): Add tail-2/append-only
1282 2006-01-21 Jim Meyering <jim@meyering.net>
1284 * NEWS: Mention fts-related improvements and bug fixes.
1286 2006-01-19 Jim Meyering <jim@meyering.net>
1288 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
1289 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
1291 2006-01-18 Jim Meyering <jim@meyering.net>
1293 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
1295 2006-01-17 Jim Meyering <jim@meyering.net>
1297 Now that fts no longer changes the current working directory, adjust
1298 its clients accordingly -- note that du.c uses fts but doesn't need
1299 any adjustment, since it doesn't operate on the actual files,
1300 but rather just uses the stat buffers provided by fts.
1302 * src/chown-core.c: Include "openat.h".
1303 Don't include "lchown.h".
1304 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
1305 calling openat, lchownat, chownat, rather than open, lchown, chown.
1307 * src/chmod.c: Include "openat.h".
1308 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
1310 * tests/du/long-from-unreadable: New test, to exercise one small
1313 2006-01-13 Jim Meyering <jim@meyering.net>
1315 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
1316 addition of new directories under tests/.
1318 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
1321 2006-01-12 Jim Meyering <jim@meyering.net>
1323 * tests/du/long-sloop: Adjust not to hard-code the expected
1324 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
1325 from that of GNU libc. Reported by Paul Eggert.
1327 * tests/du/long-sloop: Create file at end of symlink chain.
1329 * tests/misc/test: New file, with a test for one of the
1330 bugs fixed by yesterday's test.c changes.
1331 * tests/misc/Makefile.am (TESTS): Add test.
1333 2006-01-11 Jim Meyering <jim@meyering.net>
1335 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
1336 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
1337 a very long sequence of symbolic links (not necessarily a loop).
1338 * tests/du/Makefile.am (TESTS): Add long-sloop.
1340 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
1342 * src/test.c (test_syntax_error): Append a newline. All callers
1343 changed, except for the ones that didn't already append a newline.
1344 Bug reported by Eric Blake.
1346 2006-01-11 Jim Meyering <jim@meyering.net>
1348 * src/system.h (X2NREALLOC): Now that verify_true is no longer
1349 void, cast its result to void, to avoid gcc's warning that
1350 ``left-hand operand of comma expression has no effect''.
1351 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
1353 2006-01-10 Jim Meyering <jim@meyering.net>
1355 * tests/chmod/no-x: Add a test for today's fts.c fix.
1357 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
1359 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
1360 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
1362 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
1364 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
1365 Use verify_true instead of verify_expr, to sync with gnulib.
1367 2006-01-08 Jim Meyering <jim@meyering.net>
1369 * src/date.c (usage): Adjust the formatting of the entries for
1370 %::z and %:::z (separate with two spaces, not one) so that help2man
1371 formats them properly. Reported by Philip Rowlands.
1373 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
1375 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
1377 2006-01-06 Jim Meyering <jim@meyering.net>
1379 * Makefile.maint (copyright-check): Use date +%Y in place of
1382 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
1383 First off, the attribute should have been `volatile' (not static)
1384 to avoid longjmp-related risk of clobber. Secondly, now there is
1385 no longer any risk of a local variable being clobbered, so there's
1386 no need for any attribute at all.
1388 2006-01-05 Jim Meyering <jim@meyering.net>
1390 * src/remove.c: Give a few functions the inline attribute.
1391 (AD_pop_and_chdir): Use gotos to avoid some duplication.
1392 (AD_push): Rewrite an assertion so that the entire computation
1393 goes away when assertions are turned off.
1395 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
1396 It's already defined in "system.h".
1397 * Makefile.maint: Add a FIXME comment.
1399 2006-01-04 Jim Meyering <jim@meyering.net>
1401 * ChangeLog: Remove entries from 2005-10-22 and earlier.
1402 * ChangeLog-2005: New file, for entries up to version 5.92.
1404 2006-01-03 Jim Meyering <jim@meyering.net>
1406 * tests/du/no-x: Also allow a slightly different diagnostic -- the
1407 one you get when using openat-enabled fts.c and du (coming soon).
1408 * tests/chmod/no-x: Likewise.
1409 * tests/chgrp/no-x: Likewise.
1411 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
1413 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
1415 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
1416 (restricted_chown): Return it, if the file cannot be accessed due
1417 to EPERM, or if no uid or gid are required, or if the file is
1418 neither a directory nor a regular file. Rewrite to avoid gotos.
1419 (change_file_owner): Handle RC_do_ordinary_chown case.
1420 Rewrite to avoid gotos.
1421 * tests/chgrp/basic: Make sure we can change the group of
1424 * src/date.c (usage): Explain %g, %G, and %V a bit better.
1426 2006-01-02 Jim Meyering <jim@meyering.net>
1428 * src/copy.c (set_owner): Correct a comment.
1430 * src/tail.c (parse_options): Change warning to say that --retry
1431 is useful `mainly' (not `only') when following by name.
1432 Reported here: http://bugs.debian.org/273781
1434 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
1436 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
1437 * src/copy.c: Include lchmod.h.
1438 (copy_internal): Use lchmod rather than chmod.
1439 * src/cp.c: Include lchmod.h.
1440 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
1441 * src/mkdir.c: Include lchmod.h.
1442 (usage): Clarify -m's operation.
1443 (main): Use lchmod rather than chmod. Don't use lchmod unless the
1444 new mode contains bits outside the 777 range.
1445 * src/mkfifo.c (usage): Clarify -m's operation.
1446 (main): If -m is given, don't invoke chmod; use umask 0 instead.
1447 Report an error if -m asks for bits outside the 777 range.
1448 * src/mknod.c (usage, main): Likewise.
1450 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
1452 2005-12-27 Jim Meyering <jim@meyering.net>
1454 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
1455 (sc_prohibit_assert_without_use): New rule.
1456 (syntax-check-rules): Add it to the list.
1457 * .x-sc_prohibit_assert_without_use: New empty file.
1458 * Makefile.am (EXTRA_DIST): Add it.
1460 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
1462 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
1463 Don't include <assert.h>; it wasn't used.
1465 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
1467 * src/chown-core.c (restricted_chown):
1468 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
1469 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
1470 | O_NOFOLLOW too, for consistency with other dir-openers.
1471 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
1472 (is_empty_dir): Likewise.
1473 * src/shred.c (wipename): Likewise. Don't bother trying to open
1474 dir for writing, since POSIX prohibits it.
1476 2005-12-22 Jim Meyering <jim@meyering.net>
1478 * tests/help-version: Redirect stderr to /dev/full, to suppress
1479 write error diagnostic.
1481 2005-12-19 Jim Meyering <jim@meyering.net>
1483 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
1484 Avoid a minor race condition when `-m MODE' is specified, by using
1485 open, fchown, and close rather than just chown. To do that reliably --
1486 even with an overly restrictive umask -- ensure that each mkdir,
1487 mknod and mkfifo call uses a mode including at least owner-read access.
1488 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
1489 the subsequent chown (or equivalent open,fchown,close) fails.
1490 * tests/misc/mknod: New tests.
1491 * tests/misc/Makefile.am (TESTS): Add mknod.
1493 2005-12-17 Jim Meyering <jim@meyering.net>
1495 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
1496 e.g., on a named pipe.
1497 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
1498 place of all uses, since it is guaranteed (system.h) to be defined.
1500 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
1502 Add POSIX ACL support
1503 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
1504 is no requirement for ACL support; particularly, it does not exist
1505 on systems that have POSIX ACLs.
1506 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1507 * src/cp.c (umask_kill): With default acls, the umask is not to be
1508 applied. Remove umask_kill, don't change the process umask, and let
1509 the kernel apply the umask where appropriate.
1510 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1511 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1513 (copy_reg, copy_internal): Use copy_acl and set_acl
1514 instead of fchown/chown. Fix the logic for POSIX ACLs.
1515 (chown_succeded): Remove; we now always copy acls and
1516 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1517 did a chown before or not.
1518 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1519 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1520 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1521 to link with it via $(LIB_ACL), for the utilities that need it.
1523 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1525 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1526 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1527 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1528 value is now signified by whether cwd_errno is null.
1529 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1530 pointer-to-bool to pointer-to-errno-value. All callers changed.
1531 (rm_1): Don't bother setting a local cwd failure flag and then
1532 ORing it into the caller's. Just set the caller's.
1533 (rm): Use cwd failure errno value to print a slightly-better
1536 2005-12-15 Jim Meyering <jim@meyering.net>
1538 * src/stat.c (print_it): Properly handle a backslash at the
1539 end of a --printf format string. Reported by Paul Eggert.
1540 * tests/misc/stat-printf (end-bs): Add a test for the above.
1542 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1544 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1545 Don't assume /etc/passwd contains user names; use 'id' instead.
1547 2005-12-15 Jim Meyering <jim@meyering.net>
1549 stat: revert behavior of --format=FMT (-c)
1550 stat: add new option: --printf=FMT
1551 * NEWS: Mention this.
1552 * src/stat.c (isodigit, octtobin, hextobin): Define.
1553 (PRINTF_OPTION): Define.
1554 (interpret_backslash_escapes, trailing_delim): New globals.
1555 (usage): Document them. Alphabetize on long option names.
1556 (print_esc_char): New function.
1557 (print_it): Rewrite, in order to handle backslash escapes.
1558 (main): Handle new option. Set globals for --format, too.
1560 * tests/misc/stat-printf: Test --printf and --format.
1561 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1563 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1565 * NEWS: sort now reports incompatible options.
1566 * src/sort.c (incompatible_options, check_ordering_compatibility):
1568 (main): Use them. Don't bother with a usage message for
1569 "sort -c a b", for consistency with other error diagnostics.
1570 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1573 * src/cat.c (main): Undo previous change. close_stdout already
1574 does the check, so the previous change wasn't necessary.
1576 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1578 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1580 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1582 Install a more-conservative approach for sort -R. It's the
1583 same basic idea as the existing code, except it uses the full ISAAC
1584 approach (called the "more kosher" approach in the existing comments).
1585 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1586 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1587 better to be conservative here at first, and review any performance
1588 improvements carefully.
1589 * .x-sc_require_config_h: Add src/rand-isaac.c.
1590 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1591 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1592 (shred_SOURCES, sort_SOURCES): Remove.
1593 (EXTRA_DIST): Add rand-isaac.c.
1594 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1595 changing it to allow for varying numbers of words in the state.
1596 Alter so that we include rand-isaac.c directly rather than
1597 compiling it and linking to it. Don't include config.h or
1598 system.h; that's the includer's responsibility.
1599 Omit functions that are specific to shred.
1600 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1601 (isaac_step, struct irand_state):
1602 Resurrect these, with the same defns that used to be in shred.c.
1603 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1604 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1606 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1607 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1608 (irand_init, irand32, irand_mod):
1609 Number of words is constant again.
1610 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1611 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1612 * src/sort.c: Likewise.
1613 * src/shred.c (fillrand, dopass, main): Undo previous change.
1614 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1616 * src/sort.c: Don't include md5.h; it wasn't needed.
1617 (struct keyfield): Rename random_hash to random, for consistency
1618 with the other member names. All uses changed.
1619 (usage): Tweak wording to mention STRING for --seed option.
1620 (short_options): Rorder for consistency with other programs.
1621 (rand_state): Now a struct, not a pointer to one. All uses changed.
1622 (HASH_WORDS, HASH_SIZE): Remove.
1623 (get_hash): Remove comments around resbuf size, since we can assume C89.
1624 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1625 (keycompare): Adjust to the new get_hash.
1627 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1628 (main): Don't set need_random simply because gkey has it set; that
1629 doesn't necessarily mean we'll need random numbers.
1630 Redo seeding to match new get_hash approach.
1632 2005-12-10 Jim Meyering <jim@meyering.net>
1634 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1636 Avoid shred segfault on 64-bit systems.
1637 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1638 local of type uint32_t. Make the local an `int' instead.
1640 * NEWS: Mention sort's new options.
1642 * src/rand-isaac.c (isaac_mix): Declare to be static.
1643 Mark all other functions as `extern' so the tight-scope
1644 part of `make distcheck' passes once again.
1645 * src/rand-isaac.h (isaac_mix): Remove declaration.
1647 * src/sort.c (get_hash): Change position of `*' in parameter
1648 type to conform with convention.
1649 (main): Split a long line so it fits in 80 columns.
1650 (keycompare): Remove stray SPACE before TAB that was
1651 causing `make distcheck' to fail.
1653 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1655 * tests/misc/sort-rand: New file: basic tests for the new options.
1656 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1658 2005-12-10 Frederik Eaton <frederik@ofb.net>
1660 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1661 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1662 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1663 Make state size runtime-configurable.
1664 (isaac_new, isaac_copy): New functions.
1665 * src/rand-isaac.h: New file.
1666 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1667 (fillrand, main): Adjust to the fact that the state size is now
1668 runtime-configurable.
1669 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1670 (usage): Add options --random-sort and --seed to implement a random
1672 Include md5.h and rand-isaac.h.
1673 (get_hash): New function.
1674 (rand_state): New var.
1675 (HASH_WORDS, HASH_SIZE): New macros.
1677 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1679 * tests/dd/misc: Add test for dd iflags=noatime.
1681 2005-12-09 Jim Meyering <jim@meyering.net>
1683 * src/sort.c (usage): Mention white space vs -b and -t options.
1686 2005-12-09 Eric Blake <ebb9@byu.net>
1688 * src/test.c (main): Fix misleading comment.
1690 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1692 * NEWS: Mention dd's new noatime flag.
1693 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1694 * src/dd.c (flags, usage): Add support for noatime flag.
1696 2005-12-07 Jim Meyering <jim@meyering.net>
1698 Distribute the cvsu script, used only by `make syntax-check'.
1699 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1700 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1701 distribute a copy of this script.
1702 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1704 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1705 to create a temporary directory on another partition.
1706 From Andreas Gruenbacher.
1708 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1710 * man/basename.x: Cross-reference to dirname and readlink.
1711 * man/dirname.x: Cross-reference to basename and readlink.
1713 2005-12-05 Andreas Gruenbacher
1715 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1716 (set_owner, preserve_author): New functions, factored out of copy_reg.
1717 (copy_reg): Use them.
1718 (copy_internal): Use them here, too.
1720 2005-12-04 Jim Meyering <jim@meyering.net>
1722 * src/sleep.c (usage): Say what happens with two or more arguments.
1723 Suggested by Justin Pryzby.
1725 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1728 2005-12-03 Jim Meyering <jim@meyering.net>
1730 * src/rm.c (long_opts): Change the name of each undocumented, for-
1731 testing-only option to start with `-', so that it cannot render
1732 ambiguous any prefix it happens to share with some other option name.
1733 Problem reported by Eric Blake.
1734 * src/head.c (long_options): Likewise.
1735 * src/tail.c (long_options): Likewise.
1737 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1738 testing-only --presume* options to start with `---'.
1739 * tests/rm/dangling-symlink: Likewise.
1740 * tests/rm/dir-no-w: Likewise.
1741 * tests/rm/isatty: Likewise.
1743 2005-11-30 Jim Meyering <jim@meyering.net>
1745 * Makefile.maint: Add a comment about cvsu.
1747 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1749 * NEWS: df updates for "none", "proc", inaccessible file systems.
1750 * src/df.c (show_point): Ignore inaccessible file systems.
1751 (usage): -a includes dummy file systems, not size-0 file systems.
1753 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1754 to avoid collision with POSIX name space. All uses changed.
1756 2005-11-24 Jim Meyering <jim@meyering.net>
1758 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1759 * tests/acl: Add `$0: ' prefix to diagnostics.
1761 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1763 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1765 * src/copy.c: Improve performance a bit by optimizing away
1766 unnecessary system calls and going to a block size of at least
1767 8192 (on normal hosts, anyway). This improved performance 5% on my
1768 Debian stable host (2.4.27 kernel, x86, copying from root
1769 ext3 file system to itself).
1770 Include "buffer-lcm.h".
1771 (copy_reg): Omit last argument. All callers changed.
1772 Use xmalloc to allocate rather than trusting alloca
1773 (which is unwise with large block sizes).
1774 Declare locals more locally, if possible.
1775 Use uintptr_t words instead of int words, for a bit more speed
1776 when looking for null blocks on 64-bit hosts.
1777 Optimize away reads of zero bytes on regular files.
1778 In the typical case, insist on 8 KiB buffers, at least.
1779 Avoid unnecessary extra call to fstat when checking for sparse files.
1780 Avoid now-unnecessary cast to off_t, and "0L".
1781 Avoid unnecessary test of *new_dst when checking for same owner
1784 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1786 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1788 2005-11-22 Jim Meyering <jim@meyering.net>
1790 * src/remove.c (AD_push): Remove debugging cruft.
1792 * tests/rm/unread2 (rm): Change expected diagnostic,
1793 `cannot open directory' to `cannot remove', to align with
1795 * tests/rm/rm2: Ensure that rm now continues removing entries
1796 even after certain types of failure.
1798 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1799 that provide openat (Solaris), and on systems like Linux+procfs
1800 where our openat emulation code is reentrant. This also fixes a
1801 few low-probability leaks and eliminates some code that could,
1802 in very unusual circumstances, cause rm() (via a callee) to exit.
1803 * NEWS: Mention this.
1805 * configure.ac: Put copyright dates all on one line so the
1806 emacs function that updates them works properly.
1808 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1810 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1811 Problem reported by Eric Blake.
1812 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1813 we get a standard-conforming compiler. This relies on the new
1814 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1815 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1816 m4/c.m4 can go away with Autoconf 2.60 comes out.
1818 2005-11-17 Jim Meyering <jim@meyering.net>
1820 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1821 (AD_mark_current_as_unremovable): Likewise, but for a local.
1824 * tests/mv/acl: Let traps handle removing temporary directories.
1826 Expect acl-related tests to fail, until the corresponding
1827 patches are committed.
1828 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1829 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1831 ACL tests, from Andreas Gruenbacher.
1832 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1833 * tests/mv/Makefile.am (TESTS): Add acl.
1834 * tests/cp/Makefile.am (TESTS): Add acl.
1836 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1838 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1840 * NEWS: Improve quality of ln's diagnostics.
1841 * src/ln.c (do_link, usage): Likewise.
1842 (do_link): Don't use alloca on a buffer of unbounded size.
1844 2005-11-16 Jim Meyering <jim@meyering.net>
1846 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1847 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1848 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1849 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1850 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1852 2005-11-14 Jim Meyering <jim@meyering.net>
1854 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1856 2005-11-13 Jim Meyering <jim@meyering.net>
1858 * announce-gen: Accept new option, --gpg-key-id=ID and
1859 emit a blurb telling how to use the .sig files.
1860 * Makefile.cfg (gpg_key_ID): Define.
1861 * Makefile.maint (announcement): Use new option and key.
1863 Require that most .c files include <config.h>.
1864 * Makefile.maint (sc_require_config_h): New rule.
1865 (syntax-check-rules): Add it.
1866 * .x-sc_require_config_h: New file listing exceptions to the
1867 above rule. Some are legit, others are simply grandfathered in.
1868 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1870 2005-11-12 Jim Meyering <jim@meyering.net>
1872 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1874 2005-11-11 Jim Meyering <jim@meyering.net>
1876 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1877 Mention new readlink options in 5.3.0's `New features' section.
1878 Spotted by Thomas Hood.
1880 2005-11-08 Jim Meyering <jim@meyering.net>
1882 * NEWS: Merge in changes from b5_9x branch.
1884 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1886 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1887 like --time-style='posix-long-iso' if the locale settings are messed up.
1888 * src/ls.c (decode_switches): Implement this.
1890 2005-11-08 Jim Meyering <jim@meyering.net>
1892 * tests/du/2g: s/expensive/very expensive/ in a comment.
1895 2005-10-17 Eric Blake <ebb9@byu.net>
1897 * src/ls.c (usage): Fix descriptions of --sort, --time.
1898 Reported by Vitaly A. Ostanin.
1900 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1902 * src/ln.c: Include filenamecat.c.
1903 (FILE_BASENAME_CONCAT): Remove.
1904 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1905 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1906 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1909 2005-11-04 Jim Meyering <jim@meyering.net>
1911 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1912 on systems with stat.st_blocks of a signed 32-bit type.
1913 This bug causes trouble on some AIX 5.1 systems.
1914 Report and trivial patch from Paul Townsend:
1915 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1916 * NEWS: Mention this.
1918 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1919 * tests/du/Makefile.am (TESTS): Add it here.
1920 * tests/very-expensive: New file.
1921 * tests/Makefile.am (EXTRA_DIST): Add it here.
1922 * tests/cp/perm: Mark this test as `very-expensive', too.
1924 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1926 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1928 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1930 * src/rm.c (usage): Don't mention rm -d.
1932 2005-11-02 Jim Meyering <jim@meyering.net>
1934 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1935 From Andreas Schwab.
1937 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1938 `M+N records in/out' lines don't pollute `make check' output.
1940 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1941 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1942 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1943 to indicate that the input file should be piped into the command
1944 under test (via `cat FILE | $prog ...').
1946 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1947 (without -r) fails to remove a directory on a non-Linux system.
1948 This change affects only newer Solaris systems (with priv_*
1949 functions like priv_allocset). Reported by Keith Thompson.
1951 * tests/rm/dir-nonrecur: New file/test for the above fix.
1952 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1954 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1956 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1957 POSIX 1002.1-2001 requires.
1958 * src/tail.c (parse_obsolete_option): Implement this.
1959 Problem reported by Vincent Lefevre.
1960 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1961 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1962 (test_vector): Add special cases for _POSIX2_VERSION, and
1963 regularize the old ones a bit.
1964 * tests/touch/obsolescent: Add y2000 test.
1966 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1968 * src/dd.c (skip): Fix off-by-one error reported by
1969 Theodoros V. Kalamatianos.
1971 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1973 * tests/mkdir/p-3: Require that the test be run as non-root.
1974 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1976 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1978 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1979 boundary between DEST and SOURCE in the result.
1981 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1983 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1984 back to text, to sync with documentation and for backwards
1987 2005-10-25 Jim Meyering <jim@meyering.net>
1989 * tests/dircolors/simple (other-wr): Add an explicit test for
1990 the dircolors bug (NULL-dereference) fixed yesterday.
1992 2005-10-24 Jim Meyering <jim@meyering.net>
1994 * src/tac.c (tac_file): When determining whether a file is seekable,
1995 also test whether it is a tty. Using only the lseek-based test would
1996 give a false positive on Solaris. Reported by Peter Fales.
1998 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
2000 * tests/install/d-slashdot: New test, for "install -d" failure.
2001 * tests/install/Makefile.am (TESTS): Add d-slashdot.
2002 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
2003 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
2005 2005-10-24 Jim Meyering <jim@meyering.net>
2007 * src/dircolors.c (ls_codes): Add missing comma.
2008 Anonymous report and patch from
2009 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
2011 * src/dircolors.c: Add compile-time assertion that the slack_codes
2012 and ls_codes arrays have the same number of elements. This would
2013 have prevented the above-fixed bug.
2015 * src/expand.c (parse_tab_stops): Add a comment to make this function
2016 identical to the one in unexpand.c.
2017 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
2018 identical to the one in expand.c.
2020 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
2022 2005-10-23 Jim Meyering <jim@meyering.net>
2024 * src/md5sum.c (digest_check, main): Use ptr_align rather than
2025 a dangerous pointer-value-to-`unsigned' cast.
2026 * NEWS: mention the new sha* programs.
2027 * AUTHORS: Add new sha* programs.
2029 2005-08-28 David Madore <david.madore@ens.fr>
2031 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
2032 * README: Add their names to the list.
2033 * src/md5sum.c: Provide framework for computing sha-2 hashes.
2034 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
2035 Rules for compiling sha-2 utilities
2036 (noinst_HEADERS): Remove checksum.h.
2037 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
2039 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
2040 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
2041 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
2042 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
2043 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
2044 sha384sum, sha512sum test scripts here rather that each in its
2047 2005-08-28 David Madore <david.madore@ens.fr>
2049 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
2050 of the FIPS test vectors).
2052 2005-10-23 Jim Meyering <jim@meyering.net>
2054 * configure.ac: Use 6.0-cvs as the version string.
2055 * NEWS: Adjust accordingly.