1 2003-06-29 Miloslav Trmac <mitr@volny.cz>
3 * dbus/dbus-marshal.c (_dbus_marshal_set_int64)
4 (_dbus_marshal_set_uint64): Fix comment.
6 * dbus/dbus-message.c (append_int_field, append_uint_field): Don't
7 hardcode FIELD_REPLY_SERIAL.
9 * dbus/dbus-mainloop.c (_dbus_loop_remove_watch)
10 (_dbus_loop_remove_timeout): Cast function pointers to (void *) for %p
12 * configure.in: Add -D_POSIX_C_SOURCE=199309L -DBSD_SOURCE to CFLAGS
13 and disable DBUS_USE_ATOMIC_INT_486 when --enable-ansi is used
15 2003-06-24 Havoc Pennington <hp@pobox.com>
17 * mono/*.cs: Use IntPtr.Zero instead of ((IntPtr) 0)
19 2003-06-23 Anders Carlsson <andersca@codefactory.se>
25 * gcj/TestMessage.java: (TestMessage), (TestMessage.main):
27 * gcj/org/Makefile.am:
28 * gcj/org/freedesktop/.cvsignore:
29 * gcj/org/freedesktop/Makefile.am:
30 * gcj/org/freedesktop/dbus/.cvsignore:
31 * gcj/org/freedesktop/dbus/Makefile.am:
32 * gcj/org/freedesktop/dbus/Message.java: (Message),
34 * gcj/org/freedesktop/dbus/natMessage.cc:
37 2003-06-22 Havoc Pennington <hp@pobox.com>
39 * mono/Connection.cs: add more bindings
41 * dbus/dbus-threads.c (dbus_threads_init): allow calling this
44 2003-06-22 Havoc Pennington <hp@pobox.com>
46 * mono/Connection.cs, mono/DBus.cs, mono/Error.cs:
47 Start wrapping more stuff.
49 2003-06-22 Havoc Pennington <hp@pobox.com>
51 * mono/Message.cs: implement Message.Wrap() that ensures we only
52 have a single C# wrapper per DBusMessage, assuming it works which
55 * dbus/dbus-message.c (dbus_message_allocate_data_slot): new
56 (dbus_message_free_data_slot): new
57 (dbus_message_set_data): new
58 (dbus_message_get_data): new
60 2003-06-22 Havoc Pennington <hp@pobox.com>
62 * dbus/dbus-dataslot.c (_dbus_data_slot_allocator_unref)
63 (_dbus_data_slot_allocator_alloc): rework these to keep a
64 reference count on each slot and automatically manage a global
65 slot ID variable passed in by address
67 * bus/bus.c: convert to new dataslot API
69 * dbus/dbus-bus.c: convert to new dataslot API
71 * dbus/dbus-connection.c: convert to new dataslot API
73 * dbus/dbus-server.c: convert to new dataslot API
75 * glib/dbus-gmain.c: ditto
79 * bus/connection.c: ditto
81 2003-06-22 Anders Carlsson <andersca@codefactory.se>
83 * configure.in: Add AM_PROG_GCJ and move AM_PROG_LIBTOOL
84 after the gcj checks so that the correct configuration tags
85 will be added to libtool.
87 * dbus-glib-1.pc.in: No need to specify any includes since
88 dbus-1.pc.in has those.
90 2003-06-22 Havoc Pennington <hp@pobox.com>
92 * mono/*, gcj/*, configure.in, Makefile.am:
93 Check in makefiles and subdirs for mono and gcj bindings.
94 Neither binding actually exists, just trying to get through
95 all the build and other boring bits.
97 2003-06-21 Philip Blundell <philb@gnu.org>
99 * tools/dbus-monitor.1: Updated.
101 * tools/dbus-send.1: Likewise.
103 2003-06-20 Anders Carlsson <andersca@codefactory.se>
105 * dbus/dbus-transport-unix.c (unix_handle_watch): Check
106 for hangup and error after checking read so we won't discard
107 pending data if both hangup and read are set.
109 2003-06-19 Philip Blundell <philb@gnu.org>
111 * tools/dbus-print-message.c (print_message): Handle BOOLEAN.
113 * tools/dbus-send.c: Accept both --system and --session.
115 * tools/dbus-monitor.c: Same here.
117 2003-06-19 Anders Carlsson <andersca@codefactory.se>
119 * glib/dbus-glib.h: Fix so that dbus-glib.h can be used
120 from C++ (Patch by Miloslav Trmac).
122 2003-06-15 Joe Shaw <joe@assbarn.com>
124 * configure.in: Check for socklen_t.
126 * dbus/dbus-sysdeps.c: Define socklen_t if it's not defined.
128 * test/test-segfault.c: Add #include <sys/time.h>
130 * tools/Makefile.am: Add DBUS_X_CFLAGS to the INCLUDES since
131 dbus-launch needs it.
133 2003-06-09 Havoc Pennington <hp@redhat.com>
135 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): don't use
136 SUN_LEN, it breaks abstract socket usage
138 * dbus/dbus-internals.c (_dbus_verbose_real): only print PID at
141 2003-06-04 Havoc Pennington <hp@pobox.com>
143 * dbus/dbus-server.c (dbus_server_listen): allow abstract sockets
144 using unix:abstract=/foo, and when listening in a tmpdir
145 i.e. unix:tmpdir=/tmp, always use abstract sockets if we can.
147 * dbus/dbus-transport.c (_dbus_transport_open): support
150 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
151 support abstract sockets
153 * dbus/dbus-transport-unix.c
154 (_dbus_transport_new_for_domain_socket): support abstract sockets
156 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket): add "abstract"
157 toggle as an argument, implement abstract namespace support
158 (_dbus_listen_unix_socket): ditto
160 * configure.in: add --enable-abstract-sockets and implement
161 a configure check for autodetection of the right value.
163 2003-06-01 Havoc Pennington <hp@pobox.com>
165 * tools/dbus-cleanup-sockets.c: add utility to clean up sockets
166 in /tmp (though on Linux this will end up being useless,
167 when we add abstract namespace support)
169 * configure.in: define DBUS_SESSION_SOCKET_DIR in addition to
172 2003-05-28 Colin Walters <walters@verbum.org>
174 * tools/dbus-monitor.c (main): Fix silly typo (s/--session/--system/).
176 2003-05-18 Anders Carlsson <andersca@codefactory.se>
178 * dbus/dbus-message.c (dbus_message_new): Remove @todo.
180 2003-05-17 Colin Walters <walters@gnu.org>
182 * tools/dbus-send.c: Don't exit with an error code if --help was
183 passed. Default to using the session bus instead of the system
186 * tools/dbus-launch.c: Ditto.
188 * tools/dbus-monitor.c: Ditto.
190 * tools/dbus-send.1: Update with new arguments.
192 * tools/dbus-launch.c: Emit code to export variables. New
193 arguments -s and -c to specify shell syntax, and a bit of code to
194 autodetect syntax. Also, allow specifying a program to run.
196 * tools/dbus-launch.1: Update with new arguments.
198 * tools/dbus-send.1: Ditto.
200 * tools/dbus-monitor.1: Ditto.
202 2003-05-17 Havoc Pennington <hp@pobox.com>
204 * bus/config-parser.c (merge_included): merge in policies from
205 child configuration file.
207 * bus/policy.c (bus_policy_merge): function to merge two policies
210 2003-05-16 Havoc Pennington <hp@redhat.com>
212 * dbus/dbus-connection.c: disable verbose lock spew
214 * tools/dbus-send.c: add --print-reply command line option
216 * tools/dbus-print-message.h (print_message): new util function
217 shared by dbus-send and dbus-monitor
219 * tools/dbus-monitor.c (handler_func): exit on disconnect
221 * dbus/dbus-transport-unix.c (do_reading): if the transport is
222 disconnected, don't try to use the read_watch
224 * dbus/dbus-watch.c (dbus_watch_get_enabled): assert watch != NULL
225 so we can find this bug more easily
227 2003-05-16 Havoc Pennington <hp@redhat.com>
229 * bus/policy.c (free_rule_list_func): avoid a crash when passed
230 NULL as DBusHashTable is annoyingly likely to do.
232 2003-05-16 Colin Walters <walters@verbum.org>
234 * tools/dbus-monitor.c: Add --session argument and usage()
237 * tools/dbus-monitor.1: Update with new --session arg.
239 * bus/Makefile.am (install-data-hook): Create
240 $(libdir)/dbus-1.0/services so that the session bus is happy.
242 2003-05-15 Havoc Pennington <hp@redhat.com>
244 * dbus/dbus-sysdeps.c (_dbus_atomic_dec, _dbus_atomic_inc): work
245 on non-x86. ifdef's are evil.
247 2003-05-15 Havoc Pennington <hp@redhat.com>
253 * bus/Makefile.am (initddir): apparently we are supposed to put
254 init scripts in /etc/rc.d/init.d not /etc/init.d
256 * bus/Makefile.am: remove the "you must --enable-tests to make
257 check" as it broke distcheck
259 * bus/Makefile.am (install-data-hook): create /etc/dbus-1/system.d
261 2003-05-13 James Willcox <jwillcox@gnome.org>
264 * bus/activation.c: (bus_activation_service_created),
265 (bus_activation_activate_service):
266 * bus/driver.c: (bus_driver_send_service_deleted),
267 (bus_driver_send_service_created), (bus_driver_send_service_lost),
268 (bus_driver_send_service_acquired),
269 (bus_driver_send_welcome_message),
270 (bus_driver_handle_list_services):
271 * bus/session.conf.in:
272 * dbus/dbus-bus.c: (dbus_bus_acquire_service),
273 (dbus_bus_service_exists), (dbus_bus_activate_service):
276 Add some convenience API which lets you activate a service, and did a
277 bunch of s/0/DBUS_TYPE_INVALID/ in calls to dbus_message_append_args()
278 and dbus_message_get_args()
280 2003-05-11 Havoc Pennington <hp@pobox.com>
282 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix to avoid
283 calling _dbus_marshal_validate_arg() for every byte in a byte
286 * dbus/dbus-message-handler.c: use atomic reference counting to
287 reduce number of locks slightly; the global lock in here sucks
289 * dbus/dbus-connection.c
290 (_dbus_connection_update_dispatch_status_and_unlock): variant of
291 update_dispatch_status that can be called with lock held; then use
292 in a couple places to reduce locking/unlocking
293 (dbus_connection_send): hold the lock over the whole function
294 instead of acquiring it twice.
296 * dbus/dbus-timeout.c (_dbus_timeout_new): handle OOM
298 * bus/connection.c (bus_connections_setup_connection): fix access
299 to already-freed memory.
301 * dbus/dbus-connection.c: keep a little cache of linked list
302 nodes, to avoid using the global linked list alloc lock in the
303 normal send-message case. Instead we just use the connection lock
304 that we already have to take.
306 * dbus/dbus-list.c (_dbus_list_find_last): new function
308 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec):
309 change to use a struct for the atomic type; fix docs,
310 they return value before increment, not after increment.
312 * dbus/dbus-string.c (_dbus_string_append_4_aligned)
313 (_dbus_string_append_8_aligned): new functions to try to
314 microoptimize this operation.
315 (reallocate_for_length): break this out of set_length(), to
316 improve profile info, and also so we can consider inlining the
319 * dbus/dbus-message.c (dbus_message_new_empty_header): init data
320 strings with some preallocation, cuts down on our calls to realloc
321 a fair bit. Though if we can get the "move entire string to empty
322 string" optimization below to kick in here, it would be better.
324 * dbus/dbus-string.c (_dbus_string_move): just call
325 _dbus_string_move_len
326 (_dbus_string_move_len): add a special case for moving
327 an entire string into an empty string; we can just
328 swap the string data instead of doing any reallocs.
329 (_dbus_string_init_preallocated): new function
331 2003-05-11 Havoc Pennington <hp@pobox.com>
333 Write a "test-profile" that does echo client-server with threads;
334 profile reveals lock contention, memcpy/realloc of buffers, and
335 UTF-8 validation as hot spots. 20% of lock contention eliminated
336 with dbus_atomic_inc/dec implementation on x86. Much remaining
337 contention is global mempool locks for GList and DBusList.
339 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec): add
342 * dbus/dbus-connection.c (struct DBusConnection): use
343 dbus_atomic_t for the reference count
345 * dbus/dbus-message.c (struct DBusMessage): declare
346 dbus_atomic_t values as volatile
348 * configure.in: code to detect ability to use atomic integer
349 operations in assembly, from GLib patch
351 * dbus/dbus-internals.c (_dbus_verbose_real): call getpid every
352 time, tired of it being wrong in threads and forked processes
354 * glib/test-profile.c: a little program to bounce messages back
355 and forth between threads and eat CPU
357 * dbus/dbus-connection.c: add debug spew macros for debugging
358 thread locks; include config.h at top; fix deadlock in
359 dbus_connection_flush()
361 2003-05-08 Havoc Pennington <hp@pobox.com>
363 * dbus/dbus-spawn.c: s/_exit/exit/ because it was keeping gcov
364 data from getting written, and there wasn't a good reason to
367 * test/decode-gcov.c (mark_inside_dbus_build_tests): don't count
368 dbus_verbose lines in test coverage
369 (main): add list of functions sorted by # of untested blocks
370 to the coverage report
372 * dbus/dbus-mempool.c: put some test-only code in DBUS_BUILD_TESTS
374 * dbus/dbus-marshal.c (_dbus_marshal_test): extend test coverage
376 * dbus/dbus-message-handler.c (_dbus_message_handler_test):
379 * test/data/auth/cancel.auth-script: test canceling an
382 * dbus/Makefile.am: remove dbus-server-debug.[hc] for now, as they
383 aren't used. in CVS history if we end up needing them.
385 2003-05-04 Havoc Pennington <hp@pobox.com>
387 * dbus/dbus-message-handler.c (_dbus_message_handler_test): add
390 * dbus/dbus-marshal.c (_dbus_demarshal_string_array): fix this
391 function, which assumed length was in # of strings, not bytes
393 * dbus/dbus-message.c (_dbus_message_test): add tests for some
396 * dbus/dbus-connection.c
397 (_dbus_connection_queue_received_message): disable function for
398 now, we are only using it in test mode
400 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
401 remove a mistaken FIXME
403 2003-05-04 Havoc Pennington <hp@pobox.com>
405 * dbus/dbus-connection.c (dbus_connection_preallocate_send):
406 unlock mutex on successful return, patch from Anders Gustafsson
408 2003-05-04 Havoc Pennington <hp@pobox.com>
410 * dbus-glib-1.pc.in (Requires): fix dependencies, from
413 2003-05-04 Havoc Pennington <hp@pobox.com>
415 * tools/dbus-launch.c: implement
417 * bus/main.c (main), bus/bus.c (bus_context_new):
418 implement --print-pid and --fork
420 2003-05-03 Havoc Pennington <hp@redhat.com>
422 * dbus/dbus-address.c (dbus_parse_address): fix bug when a key in
423 the address had no value, and add to test suite. Fix and
424 regression test from Miloslav Trmac
426 2003-05-03 Havoc Pennington <hp@pobox.com>
428 * dbus/dbus-watch.c (dbus_watch_handle): warn and return if a
429 watch is invalid when handled
431 * tools/Makefile.am, tools/dbus-launch.c, tools/dbus-launch.1: add
432 dbus-launch utility to launch the bus from a shell script. Didn't
433 actually implement dbus-launch yet, it's just a placeholder still.
435 2003-05-03 Havoc Pennington <hp@pobox.com>
437 * bus/Makefile.am, bus/dbus-daemon-1.1.in: man page for the
438 daemon; also documents daemon config file, so replaces
439 doc/config-file.txt. Corrected some stuff from config-file.txt in
440 the process of moving it.
442 2003-05-03 Havoc Pennington <hp@pobox.com>
444 * tools/Makefile.am, tools/dbus-send.1, tools/dbus-monitor.1:
447 2003-05-03 Colin Walters <walters@verbum.org>
449 * dbus/dbus-sysdeps.c (fill_user_info): Test against
450 DBUS_UID_UNSET to determine whether to do a uid lookup or not.
452 * Makefile.am: Update to use new .pc versioning scheme.
454 2003-05-02 Havoc Pennington <hp@redhat.com>
456 * bus/system.conf.in: allow send/receive to/from message bus
459 2003-04-30 Havoc Pennington <hp@redhat.com>
461 * configure.in: print a note when building with unit tests and
464 2003-04-30 Havoc Pennington <hp@redhat.com>
466 * Makefile.am: add a check-local that complains if you didn't
467 configure with --enable-tests
469 2003-04-29 Havoc Pennington <hp@redhat.com>
471 * glib/dbus-gmain.c: docs cleanups
473 * dbus/dbus-types.h: add docs on int64 types
475 * dbus/dbus-memory.c: fix docs to avoid putting private API in
476 public API docs section
478 2003-04-29 Havoc Pennington <hp@redhat.com>
480 * dbus-1.pc.in, dbus-glib-1.pc.in: rename these from
481 dbus-1.0.pc.in, dbus-glib-1.0.pc.in. As these change with the
482 parallel install API version, not with the D-BUS package version.
484 * HACKING: move some of README over here
486 * README: updates, and document API/ABI policy
488 * configure.in: reindentation
490 2003-04-29 Havoc Pennington <hp@redhat.com>
492 * dbus/dbus.h: add "you have to define DBUS_API_SUBJECT_TO_CHANGE
493 to use this library" to be sure people have the right
496 2003-04-28 Havoc Pennington <hp@redhat.com>
498 * configure.in: add --enable-docs which by default is auto yes if
499 doxygen and db2html found, no otherwise; but can be forced on/off
501 * doc/Makefile.am: conditionalize whether to build docs on
504 2003-04-28 Havoc Pennington <hp@redhat.com>
510 * bus/system.conf.in: add <includedir>system.d</includedir>
512 * dbus/dbus-userdb.c (_dbus_user_database_lookup): fix bug when
513 username was provided but not uid
515 * bus/config-parser.c (struct BusConfigParser): keep track of
516 whether the parser is toplevel or was included; change some
517 of the error handling if it's included.
519 2003-04-27 Havoc Pennington <hp@pobox.com>
523 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
524 report correct status if we finish processing authentication
525 inside this function.
527 * bus/activation.c (try_send_activation_failure): use
528 bus_transaction_send_error_reply
530 * bus/connection.c (bus_connection_get_groups): return an error
531 explaining the problem
533 * bus/bus.c (bus_context_check_security_policy): implement
534 restriction here that inactive connections can only send the
535 hello message. Also, allow bus driver to send anything to
538 * bus/connection.c (bus_connection_complete): create the
539 BusClientPolicy here instead of on-demand.
540 (bus_connection_get_policy): don't return an error
542 * dbus/dbus-message.c (dbus_message_new_error_reply): allow NULL
543 sender field in message being replied to
545 * bus/bus.c (bus_context_check_security_policy): fix silly typo
546 causing it to return FALSE always
548 * bus/policy.c (bus_client_policy_check_can_send): fix bug where
549 we checked sender rather than destination
551 2003-04-25 Havoc Pennington <hp@redhat.com>
553 test suite is slightly hosed at the moment, will fix soon
555 * bus/connection.c (bus_connections_expire_incomplete): fix to
556 properly disable the timeout when required
557 (bus_connection_set_name): check whether we can remove incomplete
558 connections timeout after we complete each connection.
560 * dbus/dbus-mainloop.c (check_timeout): fix this up a bit,
561 probably still broken.
563 * bus/services.c (bus_registry_acquire_service): implement max
564 number of services owned, and honor allow/deny rules on which
565 services a connection can own.
567 * bus/connection.c (bus_connection_get_policy): report errors here
569 * bus/activation.c: implement limit on number of pending
572 2003-04-25 Havoc Pennington <hp@redhat.com>
574 * dbus/dbus-transport.c (_dbus_transport_get_unix_user): fix bug
575 where we used >= 0 instead of != DBUS_UID_UNSET.
577 2003-04-25 Havoc Pennington <hp@redhat.com>
579 * glib/dbus-gmain.c (remove_watch): fix for a crash when watches
580 were toggled without add/remove, fix from Anders Gustafsson
582 2003-04-24 Havoc Pennington <hp@redhat.com>
584 * test/data/valid-config-files/basic.conf: add <limit> tags to
587 * bus/config-parser.h, bus/config-parser.c, bus/bus.c: Implement
588 <limit> tag in configuration file.
590 2003-04-24 Havoc Pennington <hp@redhat.com>
592 * bus/dispatch.c: somehow missed some name_is
594 * dbus/dbus-timeout.c (_dbus_timeout_set_enabled)
595 (_dbus_timeout_set_interval): new
597 * bus/connection.c (bus_connections_setup_connection): record time
598 when each connection is first set up, and expire them after the
601 2003-04-24 Havoc Pennington <hp@redhat.com>
603 * dbus/dbus-message.c (dbus_message_name_is): rename
604 (dbus_message_service_is): rename
605 (dbus_message_sender_is): rename
606 (dbus_message_get_service): rename
608 2003-04-24 Havoc Pennington <hp@redhat.com>
610 * configure.in: add --enable-checks
612 * dbus/dbus-message.c (dbus_message_new): reverse name/service arguments
614 * dbus/dbus-connection.c (dbus_connection_preallocate_send): fix
616 (_dbus_connection_handler_destroyed_locked): move some private
617 functions into proper docs group
619 * dbus/dbus-internals.h: add _dbus_return_if_fail,
620 _dbus_return_val_if_fail
622 Throughout: use dbus_return_if_fail
624 2003-04-23 James Willcox <jwillcox@gnome.org>
627 * glib/dbus-gmain.c: (add_timeout), (wakeup_main), (create_source),
628 (dbus_connection_setup_with_g_main),
629 (dbus_server_setup_with_g_main):
630 * glib/test-dbus-glib.c: (main):
631 * glib/test-thread-client.c: (main):
632 * glib/test-thread-server.c: (new_connection_callback), (main):
633 * tools/dbus-monitor.c: (main):
635 Added a GMainContext argument to dbus_connection_setup_with_g_main()
636 and dbus_server_setup_with_g_main().
638 2003-04-20 Havoc Pennington <hp@pobox.com>
640 * doc/dbus-specification.sgml: document the restrictions on
641 message and service names
643 2003-04-22 Havoc Pennington <hp@redhat.com>
645 * dbus/dbus-message.c, dbus/dbus-marshal.c: add 64-bit integer
646 support, and do some code cleanups to share more code and
647 speed up array marshal/demarshal.
649 * dbus-1.0.pc.in (Cflags): put libdir include file in cflags
651 * configure.in: generate dbus-arch-deps.h
653 * dbus/dbus-protocol.h (DBUS_TYPE_INT64, DBUS_TYPE_UINT64): add
656 2003-04-22 Havoc Pennington <hp@redhat.com>
658 * test/data/valid-messages/opposite-endian.message: fix test
659 to use proper type for rply field
661 * test/data/invalid-messages: add tests for below validation
663 * dbus/dbus-message.c (decode_header_data): validate field types,
664 and validate that named fields are valid names
665 (decode_name_field): consider messages in the
666 org.freedesktop.Local. namespace to be invalid.
668 * dbus/dbus-string.c (_dbus_string_validate_name): new
670 2003-04-19 Havoc Pennington <hp@pobox.com>
672 * bus/driver.c (bus_driver_handle_hello): check limits and
673 return an error if they are exceeded.
675 * bus/connection.c: maintain separate lists of active and inactive
676 connections, and a count of each. Maintain count of completed
677 connections per user. Implement code to check connection limits.
679 * dbus/dbus-list.c (_dbus_list_unlink): export
681 * bus/bus.c (bus_context_check_security_policy): enforce a maximum
682 number of bytes in the message queue for a connection
684 2003-04-18 Havoc Pennington <hp@pobox.com>
686 * dbus/dbus-auth.c (record_mechanisms): memleak fixes
688 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): fix some
691 * dbus/dbus-keyring.c (add_new_key): fix a memleak, and
692 on realloc be sure to update the pointer in the keyring
694 * dbus/dbus-string.c (_dbus_string_zero): compensate for align
695 offset to avoid writing to unallocated memory
697 * dbus/dbus-auth.c (process_rejected): return FALSE if we fail to
698 try the next mechanism, so we properly handle OOM
700 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): fix double-free
702 (_dbus_keyring_new): fix OOM bug
703 (_dbus_keyring_new_homedir): always set error; impose a maximum
704 number of keys we'll load from the file, mostly to speed up the
705 test suite and make its OOM checks more useful, but also for
708 * dbus/dbus-auth.c (process_error_server): reject authentication
709 if we get an error from the client
710 (process_cancel): on cancel, send REJECTED, per the spec
711 (process_error_client): send CANCEL if we get an error from the
714 2003-04-18 Havoc Pennington <hp@pobox.com>
716 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix UMR in verbose
719 * dbus/dbus-auth.c (handle_client_data_cookie_sha1_mech): fix OOM
722 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): only whine
723 about DBUS_TEST_HOMEDIR once
725 * bus/Makefile.am (TESTS_ENVIRONMENT): put DBUS_TEST_HOMEDIR in
728 * bus/dispatch.c (bus_dispatch_sha1_test): actually load sha1
729 config file so we test the right thing
731 Throughout: assorted docs improvements
733 2003-04-18 Havoc Pennington <hp@pobox.com>
735 * glib/dbus-gmain.c: adapt to watch changes
737 * bus/bus.c, bus/activation.c, etc.: adjust to watch changes
739 * dbus/dbus-server.h: remove dbus_server_handle_watch
741 * dbus/dbus-connection.h: remove dbus_connection_handle_watch
743 * dbus/dbus-watch.c (dbus_watch_handle): change DBusWatch to work
744 like DBusTimeout, so we don't need dbus_connection_handle_watch
747 2003-04-17 Havoc Pennington <hp@redhat.com>
749 * dbus/dbus-userdb.c, dbus/dbus-sysdeps.c: redo all the passwd
750 database usage so it all goes via the DBusUserDatabase cache.
752 2003-04-17 Havoc Pennington <hp@redhat.com>
754 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix logic so that if
755 there was an OOM watch we skipped, we always return TRUE so we
756 iterate again to have a look at it again. Fixes test suite hang.
757 Code rearrangement also lets us lose some memset and only iterate
760 * bus/driver.c (bus_driver_handle_message): sense of test for
763 2003-04-16 Havoc Pennington <hp@pobox.com>
765 * doc/dbus-specification.sgml: make spec say serials are unsigned
767 * dbus/dbus-message.h: change message serials to unsigned
769 * dbus/dbus-connection.c: adapt to message serials being unsigned
771 2003-04-15 Havoc Pennington <hp@pobox.com>
773 * bus/bus.c: create and keep around a shared DBusUserDatabase
776 * bus/connection.c (bus_connection_get_groups): don't cache
777 groups for user in the connection object, since user database
778 object now does that.
780 2003-04-16 Havoc Pennington <hp@redhat.com>
782 * dbus/dbus-message.c (_dbus_message_add_size_counter): keep a
783 list of size counters
784 (_dbus_message_loader_putback_message_link): put back a popped link
786 * dbus/dbus-connection.c
787 (dbus_connection_set_max_live_messages_size): rename
789 (dbus_connection_get_outgoing_size): get size of outgoing
791 (_dbus_connection_set_connection_counter): remove this cruft
793 2003-04-14 Havoc Pennington <hp@redhat.com>
795 * dbus/dbus-userdb.c: user database abstraction, mostly to get
796 caching, but at some point we might want to be able to use a
799 * bus/dispatch.c (bus_dispatch_sha1_test): add a test that uses
800 SHA1 conf file to test the sha1 auth mechanism, since the regular
801 test always uses EXTERNAL when available.
804 test/data/valid-config-files/debug-allow-all-sha1.conf.in:
805 add conf file that requires use of sha1 auth
807 2003-04-13 Havoc Pennington <hp@pobox.com>
809 * tools/dbus-send.c, tools/dbus-monitor.c: two utility programs
810 from Philip Blundell to send messages and monitor them.
812 2003-04-13 Havoc Pennington <hp@pobox.com>
814 * dbus/dbus-mainloop.c: fix some reentrancy issues by refcounting
817 * test/data/valid-config-files/debug-allow-all.conf.in: allow all
820 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
821 fix to only recover unused bytes if we're already authenticated
822 (_dbus_transport_get_is_authenticated): fix to still mark us
823 authenticated if there are unused bytes.
825 * bus/dispatch.c: implement security policy checking
827 * bus/connection.c (bus_transaction_send_from_driver): new
829 * bus/bus.c (bus_context_check_security_policy): new
831 * bus/dispatch.c (send_service_nonexistent_error): delete this,
832 now we just set the DBusError and it gets converted to an error
835 * bus/connection.c (allow_user_function): enable code using actual
836 data from the config file
838 * bus/policy.c (list_allows_user): handle wildcard rules for
839 user/group connection perms
841 2003-04-13 Havoc Pennington <hp@pobox.com>
843 * bus/config-parser.c: Load up the BusPolicy and BusPolicyRules
845 * dbus/dbus-sysdeps.c (_dbus_get_user_id): new function
847 * bus/policy.c (bus_policy_append_mandatory_rule)
848 (bus_policy_append_default_rule, bus_policy_append_user_rule)
849 (bus_policy_append_group_rule): new functions
851 2003-04-12 Havoc Pennington <hp@pobox.com>
853 * bus/config-parser.c (bus_config_parser_new): fix a memleak
855 * dbus/dbus-sysdeps.c: change DBusCredentials to use longs for
856 the pid/gid/uid, just for paranoia.
858 * test/break-loader.c (randomly_do_n_things): find a byte
859 containing a type code, and randomly change it to a different
862 2003-04-12 Havoc Pennington <hp@pobox.com>
864 * bus/policy.h: change BusPolicy to be the thing from the config
865 file, and rename old BusPolicy to BusClientPolicy
867 * bus/bus.c, bus/connection.c, bus/config-parser.c: change to
868 match change in how policy works
870 * dbus/dbus-internals.h: mark assert_not_reached as
871 __attribute((noreturn))__
873 2003-04-11 Havoc Pennington <hp@redhat.com>
875 * doc/dbus-specification.sgml: fix a spot with the wrong name for
876 the broadcast service. Use boolean return for ServiceExists.
878 2003-04-11 Havoc Pennington <hp@redhat.com>
880 * configure.in: add another directory to look for qt in.
882 2003-04-11 Havoc Pennington <hp@redhat.com>
884 * AUTHORS: add Colin Walters
886 2003-04-11 Havoc Pennington <hp@redhat.com>
892 2003-04-11 Havoc Pennington <hp@redhat.com>
894 * bus/messagebus.in: remove pid file when stopping the
895 message bus, since the bus won't have privileges to remove it
898 2003-04-11 Havoc Pennington <hp@redhat.com>
900 * bus/bus.c (bus_context_new): move credentials change after
903 2003-04-11 Havoc Pennington <hp@pobox.com>
905 * test/decode-gcov.c: add "below average functions" to the
906 coverage report, and change how some of the code works.
908 * bus/test-main.c: bracket some stuff in DBUS_BUILD_TESTS so it's
909 not in the coverage stats.
911 * test/test-service.c (main): use _dbus_verbose not fprintf in a
912 couple places so running the test suite doesn't result in megaspam.
914 2003-04-11 Havoc Pennington <hp@pobox.com>
916 * bus/dispatch.c (check_existent_service_activation): accept a no
917 memory error in a place we didn't before
919 * bus/test.c (bus_test_run_everything): remove hacky "do it twice
920 in case the first one failed," since the test suite is less
923 2003-04-10 Havoc Pennington <hp@pobox.com>
925 * bus/dispatch.c (check_segfault_service_activation): add test
926 for launching an executable that just crashes.
928 * test/test-segfault.c (main): try setting coredumpsize to 0 so we
929 don't leave a million cores. We'll see how portable this is.
931 2003-04-10 Havoc Pennington <hp@pobox.com>
933 * dbus/dbus-spawn.c (_dbus_spawn_async_with_babysitter): move all
934 the possible parent failures before we fork, so that we don't
935 fail to create a babysitter after creating the child.
937 * bus/activation.c (bus_activation_activate_service): kill child
938 if we don't successfully complete the activation.
940 2003-04-10 Havoc Pennington <hp@redhat.com>
942 * dbus/dbus-connection.c (dbus_connection_flush): don't spin on
943 the connection if it's disconnected
945 * bus/activation.c (bus_activation_service_created): use new
946 transaction features to roll back removal of pending activation if
947 we don't successfully create the service after all. Don't remove
948 pending activation if the function fails.
950 * dbus/dbus-list.c (_dbus_list_insert_before_link)
951 (_dbus_list_insert_after_link): new code to facilitate
954 * dbus/dbus-hash.c (_dbus_hash_table_insert_string_preallocated):
955 new functionality, so we can preallocate the ability to insert
958 * bus/connection.c (bus_transaction_add_cancel_hook): new function
959 allowing us to put custom hooks in a transaction to be used for
960 cancelling said transaction
962 * doc/dbus-specification.sgml: add some discussion of secondary
963 service owners, and disallow zero-length service names
965 * bus/services.c (bus_registry_acquire_service): new function,
966 splits out part of bus_driver_handle_acquire_service() and fixes
967 a bug where we didn't remove the service doing the acquiring
968 from the secondary queue if we failed to remove the current owner
969 from the front of the queue.
971 2003-04-10 Alexander Larsson <alexl@redhat.com>
973 * doc/dbus-specification.sgml:
974 s/org.freedesktop.Broadcast/org.freedesktop.DBus.Broadcast/
976 2003-04-10 Alexander Larsson <alexl@redhat.com>
981 Added files to cvsignore
983 * dbus/dbus-message.h:
984 * dbus/dbus-message.c: (dbus_message_iter_get_named):
985 Make get_named() take two out argument and return a boolean.
986 (dbus_message_iter_get_args_valist):
987 Update usage of get_named().
988 (dbus_message_iter_append_byte):
990 (dbus_message_iter_append_named)
992 (message_iter_test), (check_message_handling_type), (_dbus_message_test):
995 2003-04-10 Alexander Larsson <alexl@redhat.com>
997 * dbus/dbus-marshal.[ch]:
998 Add array_type_pos argument to _dbus_marshal_validate_arg.
999 Let you pass a NULL end_pos to _dbus_marshal_validate_type.
1001 * dbus/dbus-message.[ch]:
1002 Multi-dimensional arrays have full type specification in the
1003 outermost array. Iter code re-arranged to handle this.
1004 Added some more iter tests.
1006 * doc/dbus-specification.sgml:
1009 Update new array encoding description.
1010 Correct DBUS_SERVICE_FLAGS_REPLACE_EXISTING description.
1012 * test/data/invalid-messages/array-with-mixed-types.message:
1013 * test/data/valid-messages/array-of-array-of-uint32.message:
1014 Change to the new array format.
1016 * test/data/invalid-messages/too-short-dict.message:
1019 * test/data/valid-messages/recursive-types.message:
1020 Fix up and extend test.
1022 2003-04-10 Havoc Pennington <hp@pobox.com>
1024 * bus/dispatch.c: lots of fixes
1026 * dbus/dbus-mainloop.c (_dbus_loop_dispatch): export
1027 (_dbus_loop_iterate): remove old "quit if no callbacks" code,
1028 that was crack, broke the test service.
1030 * dbus/dbus-transport.c (_dbus_transport_open): fix error
1031 handling to avoid piling up errors if we get a failure on the
1034 * dbus/dbus-internals.c (_dbus_real_assert_not_reached): include
1035 pid in assertion failures.
1037 * dbus/dbus-mainloop.c (_dbus_loop_iterate): use static arrays up
1038 to some fixed size of file descriptor array. Don't return TRUE
1039 anytime a timeout exists, that led to lots of busy loop silliness
1042 2003-04-09 Havoc Pennington <hp@redhat.com>
1044 * dbus/dbus-mainloop.c (check_timeout): fix timeouts, I thought
1045 I'd checked this in earlier but hadn't.
1047 2003-04-09 Havoc Pennington <hp@redhat.com>
1049 * bus/dispatch.c (bus_dispatch_test): get a bit further through
1050 the activation test (man this is getting old!)
1052 2003-04-09 Havoc Pennington <hp@redhat.com>
1054 * test/test-utils.c: use dispatch status function to fix this up
1056 * bus/connection.c (connection_watch_callback): don't dispatch
1058 (connection_timeout_callback): don't dispatch from here
1059 (bus_connections_setup_connection): set the dispatch status function
1060 (bus_connection_disconnected): unset it
1062 * dbus/dbus-mainloop.c (_dbus_loop_queue_dispatch): new function
1063 used to add a connection to be dispatched
1064 (_dbus_loop_iterate): do the dispatching at the end of each
1067 * dbus/dbus-connection.c
1068 (dbus_connection_set_dispatch_status_function): new function
1069 allowing us to fix up main loop usage
1070 (_dbus_connection_last_unref): free all the various function
1072 (dbus_connection_dispatch): call the DispatchStatusFunction
1073 whenever this function returns
1074 (dbus_connection_handle_watch): call DispatchStatusFunction
1075 (dbus_connection_send_with_reply_and_block): call DispatchStatusFunction
1076 (reply_handler_timeout): call DispatchStatusFunction
1077 (dbus_connection_flush): call DispatchStatusFunction
1079 2003-04-09 Havoc Pennington <hp@redhat.com>
1081 * dbus/dbus-bus.c (dbus_bus_register): fix up error handling and
1084 * bus/dispatch.c (check_service_activated): fix bug in test
1086 * dbus/dbus-mainloop.c (check_timeout): fix this up
1088 * dbus/dbus-internals.c (_dbus_verbose_real): include PID in
1089 verbose output so we can sort out output from different processes,
1090 e.g. in the activation case.
1092 2003-04-08 Colin Walters <walters@gnu.org>
1094 * bus/bus.c (struct BusContext) [pidfile]: New member, to store
1096 (bus_context_new): Set it.
1097 (bus_context_unref): Use it to delete the pid file.
1099 2003-04-08 Havoc Pennington <hp@redhat.com>
1101 * test/data/invalid-messages/array-with-mixed-types.message:
1102 regression test that fails for the moment
1104 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): reorder
1105 tests for convenience
1107 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): don't allow
1108 array of nil, it broke things.
1110 * test/data/invalid-messages/array-of-nil.message: regression test
1112 * test/data/valid-messages/array-of-array-of-uint32.message:
1113 happened to write this so added it to suite
1115 2003-04-08 Havoc Pennington <hp@redhat.com>
1117 * bus/driver.c (bus_driver_handle_acquire_service): init
1118 retval/reply before checking name
1120 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add a
1121 recursion depth argument
1123 * dbus/dbus-message.h (struct DBusMessageIter): put some padding
1124 in the public struct for future extension
1126 * dbus/dbus-message-builder.c (_dbus_message_data_load): fix
1129 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix a verbose
1132 * doc/dbus-specification.sgml: fix typo
1134 2003-04-08 Alexander Larsson <alexl@redhat.com>
1136 Implemented recursive types, named types and new-style iters
1139 * glib/test-thread-client.c: (thread_func):
1140 * glib/test-thread-server.c: (handle_test_message):
1141 * test/test-service.c: (handle_echo):
1150 * dbus/dbus-internals.c: (_dbus_type_to_string):
1151 Update for new types.
1153 * dbus/dbus-marshal.[ch]:
1154 Implement recursive types and the new marshalling format.
1155 Remove hardcoded dict marshalling.
1156 Marshal named types.
1158 * dbus/dbus-message-builder.c:
1160 Remove references to old types
1162 * dbus/dbus-message.[ch]:
1163 New non-refcounted iter API that supports recursive iters.
1164 Use iters for appending, including support for recursive
1166 Add byte and named type support.
1167 Update everything to new marshalling formats.
1168 Add tests for new API.
1170 * dbus/dbus-protocol.h:
1171 Remove old array types.
1172 Add types: BYTE, ARRAY, DICT, NAMED
1174 * dbus/dbus-string.c:
1175 * dbus/dbus-sysdeps.c:
1176 Make parse_double locale safe.
1178 * dbus/dbus-test-main.c:
1184 * doc/dbus-specification.sgml:
1187 * test/data/incomplete-messages/missing-body.message:
1188 * test/data/invalid-messages/bad-boolean.message:
1189 * test/data/invalid-messages/bad-boolean-array.message:
1190 * test/data/invalid-messages/boolean-array-length-too-long.message-raw:
1191 * test/data/invalid-messages/boolean-has-no-value.message-raw:
1192 * test/data/invalid-messages/too-short-dict.message:
1193 * test/data/valid-messages/dict-simple.message:
1194 * test/data/valid-messages/dict.message:
1195 * test/data/valid-messages/emptiness.message:
1196 * test/data/valid-messages/lots-of-arguments.message:
1197 * test/data/valid-messages/no-padding.message:
1198 * test/data/valid-messages/recursive-types.message:
1199 Add missing NAME fields
1200 Fix up dicts & arrays
1202 * test/data/invalid-messages/dict-with-nil-value.message:
1203 Removed, this is not invalid anymore.
1205 * test/data/valid-messages/recursive-types.message:
1206 Add new test for deeply recursive types.
1208 2003-04-07 Havoc Pennington <hp@pobox.com>
1210 * bus/driver.c (bus_driver_handle_acquire_service): return an
1211 error if you try to acquire a service that starts with ':'
1213 2003-04-07 Havoc Pennington <hp@redhat.com>
1215 * doc/dbus-specification.sgml: require that base service names
1216 start with ':' and that the base service is created/deleted
1217 as first and last things a connection does on the bus
1219 * bus/dispatch.c (check_existent_service_activation): lots more
1220 work on the activation test; it doesn't fully pass yet...
1222 * test/test-service.c (main): fix so we don't memleak the
1223 connection to the message bus
1224 (filter_func): accept a message asking us to exit
1226 2003-04-06 Havoc Pennington <hp@pobox.com>
1228 * qt/Makefile.am (dbusinclude_HEADERS): install dbus-qt.h,
1231 * configure.in: fixes to Qt detection from Colin Walters
1233 * doc/Makefile.am: Only remove generated docbook dirs if they
1234 exist, from Colin Walters
1236 * dbus/dbus-bus.c: change how we set well-known connections to
1237 NULL, so that it works if a single connection is stored in
1238 two well-known array slots.
1240 * test/Makefile.am: remove a lot of stuff that isn't immediately
1241 useful, it's in CVS history if we want it.
1243 * test/test-service.c: use dbus-mainloop instead of that
1246 2003-04-06 Havoc Pennington <hp@pobox.com>
1248 * dbus/Makefile.am: split lists of sources into stuff that goes in
1249 the library, util functions that go in the lib and are also used
1250 elsewhere, and util functions that are used in tests/daemon but
1251 don't go in the lib.
1253 * dbus/dbus-mainloop.h, dbus/dbus-mainloop.c: move bus/loop.[hc]
1254 here so it can be used in test binaries also
1256 2003-04-06 Havoc Pennington <hp@pobox.com>
1258 * dbus/dbus-sysdeps.c (_dbus_become_daemon): write the pidfile
1259 here in the parent process, so we can return an error if it
1260 fails. Also, move some of the code into the child so the parent
1261 is less hosed if we fail midway through.
1263 * bus/bus.c (bus_context_new): move pidfile detection further up
1264 in the function, before we start overwriting sockets and such.
1266 * bus/messagebus.in: adjust this a bit, not sure if it will work.
1268 * configure.in: add --with-system-pid-file and --with-system-socket
1270 2003-04-06 Colin Walters <walters@verbum.org>
1272 * configure.in (DBUS_SYSTEM_PID_FILE): New variable.
1274 * bus/system.conf.in: Declare a pidfile.
1276 * bus/bus.c (bus_context_new): Test for an existing pid file, and
1277 create one (if appropriate).
1279 * bus/config-parser.c (enum ElementType) [ELEMENT_PIDFILE]: New.
1280 (struct BusConfigParser) [pidfile]: New.
1281 (element_type_to_name, merge_included, start_busconfig_child)
1282 (bus_config_parser_end_element, bus_config_parser_content): Handle it.
1283 (bus_config_parser_unref): Free it.
1284 (bus_config_parser_get_pidfile): New function.
1286 * bus/config-parser.h (_dbus_write_pid_file): Prototype.
1288 * dbus/dbus-errors.h (DBUS_ERROR_PIDFILE_EXISTS): New error.
1290 * dbus/dbus-sysdeps.c (_dbus_write_pid_file): New function.
1292 * dbus/dbus-sysdeps.h: Prototype it.
1294 2003-04-06 Havoc Pennington <hp@pobox.com>
1296 * bus/bus.c (bus_context_new): print the address in here, rather
1297 than in main(), because we need to do it before forking the daemon
1299 * bus/dispatch.c (send_service_nonexistent_error): set the sender
1300 on the service nonexistent error
1302 * bus/driver.c (bus_driver_handle_acquire_service): set the
1303 sender on the AcquireService reply
1305 * test/data/valid-config-files/debug-allow-all.conf.in: Make test
1306 server also listen on a UNIX socket so services can connect to it.
1308 2003-04-06 Havoc Pennington <hp@pobox.com>
1310 * dbus/dbus-threads.c: Redo how the fake debug mutexes are done
1311 so it detects deadlocks and also we actually init threads when
1314 2003-04-06 Havoc Pennington <hp@pobox.com>
1316 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
1317 save the domain socket name, and unlink it when we disconnect the
1318 server. Means that at least when we exit normally, we won't leave
1319 a bunch of junk in /tmp
1321 * dbus/dbus-transport-unix.c
1322 (_dbus_transport_new_for_domain_socket): code cleanup (nicer
1323 memory management). (I was making a real change here but then
1326 2003-04-06 Havoc Pennington <hp@pobox.com>
1328 * bus/bus.c (bus_context_new): fix wrong handling of
1329 server_data_slot_unref() in the error case.
1331 * dbus/dbus-internals.h (_dbus_assert): change so it passes
1332 "(condition) != 0" to _dbus_real_assert so that
1333 "_dbus_assert (pointer)" doesn't cause a warning
1335 * bus/main.c (main): accept --print-address option to print out
1336 the message bus address
1338 * dbus/dbus-sysdeps.c (_dbus_generate_random_ascii): export this
1340 * dbus/dbus-transport.c (_dbus_transport_open): special error for
1341 "tmpdir" option to unix: address on client side
1343 * dbus/dbus-server.c (dbus_server_listen): handle "tmpdir" option
1346 * configure.in (TEST_SOCKET_DIR): locate a temporary directory
1347 we can use to create sockets in the test suite.
1349 * bus/main.c (signal_handler): on SIGTERM, exit the daemon
1350 cleanly. To be used for testing.
1352 * dbus/dbus-spawn.c (babysit): use _dbus_set_signal_handler()
1354 * dbus/dbus-sysdeps.c (_dbus_set_signal_handler): new
1356 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
1357 handle trying to call this when there's no servers active
1359 2003-04-05 Havoc Pennington <hp@pobox.com>
1365 2003-04-05 Havoc Pennington <hp@pobox.com>
1367 * bus/bus.c (setup_server): fix this so dbus-daemon-1 doesn't
1368 crash on startup. Need to get "try starting the daemon"
1369 in the test suite I guess. ;-)
1371 * dbus/dbus-server.h, dbus/dbus-server.c: remove the stuff that
1372 tracked the number of open connections; it's better done in
1373 application-specific code as you want it to span all servers etc.
1375 2003-04-05 Havoc Pennington <hp@pobox.com>
1377 * bus/Makefile.am (install-data-hook): add missing DESTDIR,
1378 patch from Colin Walters
1380 2003-04-05 Havoc Pennington <hp@pobox.com>
1382 * doc/config-file.txt (Elements): fix docs of <auth> to reflect
1383 reality; in fact multiple mechanisms are allowed.
1385 * dbus/dbus-internals.c (_dbus_real_assert)
1386 (_dbus_real_assert_not_reached): move guts of _dbus_assert() and
1387 _dbus_assert_not_reached() into functions, so that they don't show
1388 up in basic block counts for test coverage, and don't use up as
1389 much disk space. Does mean slower execution speed though, so
1390 assumes --disable-asserts is the normal production case.
1392 2003-04-05 Havoc Pennington <hp@pobox.com>
1394 * test/Makefile.am (dist-hook): also dist *.in files
1400 2003-04-05 Havoc Pennington <hp@pobox.com>
1402 * dbus/dbus-string.c: docs warning
1404 * dbus/dbus-spawn.c: missing docs
1406 * dbus/dbus-memory.c (struct ShutdownClosure): missing docs
1408 2003-04-05 Havoc Pennington <hp@pobox.com>
1410 * bus/loop.c (bus_loop_iterate): fix the timeout code, using
1413 * dbus/dbus-spawn.c (_dbus_babysitter_unref): set sitter_pid
1414 to -1 once we've reaped the babysitter
1415 (_dbus_babysitter_handle_watch): do as much work as we can, not
1418 * bus/activation.c: add code using DBusBabysitter so that we
1419 handle it when a service fails to start up properly.
1420 (bus_activation_service_created): don't remove the activation
1421 entries as we go, just let them get removed when we free the pending
1422 activation. Unref reply messages after sending them.
1424 2003-04-05 Havoc Pennington <hp@pobox.com>
1426 * test/decode-gcov.c (main): print per-directory stats in the report
1428 * Makefile.am (coverage-report.txt): don't include test/* in gcov stats
1430 2003-04-05 Havoc Pennington <hp@pobox.com>
1432 * Makefile.am (coverage-report.txt): add target "coverage-report.txt"
1434 * test/decode-gcov.c: hack up a little program to suck data
1435 out of gcov files. Yes this is sort of silly.
1437 * configure.in: define something in config.h and do an
1438 AM_CONDITIONAL when gcov is enabled
1440 2003-04-04 Havoc Pennington <hp@redhat.com>
1442 * dbus/dbus-spawn.c, dbus/dbus-spawn.h: Change dbus_spawn to
1443 return a "babysitter" object that is used to monitor the status of
1444 the spawned process and reap it when required.
1446 * test/test-segfault.c, test/test-exit.c,
1447 test/test-sleep-forever.c: binaries that do various lame things,
1448 used in the test suite.
1450 * dbus/dbus-sysdeps.c: kill _dbus_errno_to_string()
1452 2003-04-03 Havoc Pennington <hp@pobox.com>
1454 * dbus/dbus-spawn.c: Move dbus-spawn into a separate file
1455 in preparation for modifying it, dbus-sysdeps is getting
1458 2003-04-03 Havoc Pennington <hp@redhat.com>
1460 * bus/loop.h, bus/loop.c: make the mainloop an object so we can
1463 * bus/*.[hc]: adapt to mainloop change
1465 2003-04-03 Havoc Pennington <hp@redhat.com>
1467 * bus/activation.c (load_directory): fix up memleaks
1468 (bus_activation_entry_free): free the entry
1470 * dbus/dbus-bus.c (dbus_bus_acquire_service): return an error if
1471 we get one from the message bus; fix memleaks.
1473 * dbus/dbus-message.c (dbus_set_error_from_message): new function
1475 2003-04-03 Havoc Pennington <hp@pobox.com>
1477 * bus/config-parser.c (bus_config_parser_unref): free
1478 list of mechanisms, bug discovered by test suite enhancements
1479 (putting system.conf and session.conf into suite)
1481 * test/Makefile.am, test/test-service.c: add placeholder for a
1482 test service that we'll activate as part of test suite. Doesn't
1485 * dbus/dbus-sysdeps.c (_dbus_setenv): support unsetenv by
1486 setting NULL value, and use system malloc not dbus_malloc()
1487 when we have unavoidable memleakage.
1489 * dbus/dbus-bus.c (dbus_bus_get): fix bug where bus type of 0
1490 didn't work, and support DBUS_BUS_ACTIVATION.
1492 * bus/activation.c (child_setup): pass our well-known bus type to
1495 * bus/config-parser.c: support <type> to specify well-known type
1497 * doc/dbus-specification.sgml: document the env variables to
1498 locate well-known buses and find service activator
1500 2003-04-02 Havoc Pennington <hp@redhat.com>
1502 * test/Makefile.am (all-local): add a rule to copy tests to
1503 builddir, so we can have generated tests. Use this to remove the
1504 silly hack for testing system.conf and session.conf. Will use this
1505 shortly to generate .service files pointing to test binaries.
1507 2003-04-02 Havoc Pennington <hp@redhat.com>
1509 * dbus/dbus-string.c (set_length): fix a bug - we allocated max of
1510 current alloc and needed new length, not max of the doubled
1511 allocation and needed new length. Also, when building tests,
1512 don't do the double-allocation stuff, just realloc every time.
1514 2003-04-02 Havoc Pennington <hp@redhat.com>
1516 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): include filenames
1518 (_dbus_string_get_dirname): new
1519 (_dbus_sysdeps_test): new
1520 (_dbus_directory_open): include dirnames in error messages
1522 * bus/config-parser.c: interpret <include> and <includedir> and
1523 <servicedir> relative to config file location if the given
1524 filename is not absolute.
1526 * dbus/dbus-string.c (_dbus_string_find_byte_backward): new
1528 2003-04-02 Havoc Pennington <hp@redhat.com>
1530 * bus/connection.c (bus_transaction_send_error_reply): set sender
1531 service for the error, and unref the reply on success
1533 * bus/activation.c: convert to use BusTransaction so OOM can be
1535 (bus_activation_service_created): set sender of the message
1537 2003-04-01 Havoc Pennington <hp@redhat.com>
1539 * bus/config-parser.c, bus/bus.c: implement <servicedir> and
1540 <includedir> (at least mostly)
1542 * dbus/dbus-sysdeps.c (_dbus_change_identity): set the group ID
1543 first, then the user ID
1545 2003-04-01 Havoc Pennington <hp@pobox.com>
1547 * dbus/dbus-server.c (dbus_server_set_auth_mechanisms): new
1550 * dbus/dbus-auth.c (_dbus_auth_set_mechanisms): new
1552 * dbus/dbus-internals.c (_dbus_dup_string_array): new function
1554 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): chmod the
1555 socket 0777, and unlink any existing socket.
1557 * bus/bus.c (bus_context_new): change our UID/GID and fork if
1558 the configuration file so specifies; set up auth mechanism
1561 * bus/config-parser.c (bus_config_parser_content): add support
1562 for <fork> option and fill in code for <auth>
1564 * bus/system.conf.in: add <fork/> to default configuration,
1565 and limit auth mechanisms to EXTERNAL
1567 * doc/config-file.txt (Elements): add <fork>
1569 * dbus/dbus-sysdeps.c (_dbus_become_daemon): new function
1570 (_dbus_change_identity): new function
1572 2003-03-31 Havoc Pennington <hp@redhat.com>
1574 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket)
1575 (_dbus_listen_unix_socket): fix off-by-one error in null
1576 termination spotted by Nalin
1578 2003-03-31 Havoc Pennington <hp@redhat.com>
1580 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): allow setting
1581 DBUS_TEST_HOMEDIR when tests are enabled, so we can test without
1582 having a real home directory available.
1584 2003-03-31 Havoc Pennington <hp@redhat.com>
1586 * bus/Makefile.am (install-data-hook): create /var/run/dbus
1588 * bus/messagebus.in: add init script for Red Hat /etc/init.d
1590 * configure.in: add support for specifying a style of init script
1593 2003-03-31 Havoc Pennington <hp@redhat.com>
1595 Fix some annoying DBusString API and fix all affected code.
1597 * dbus/dbus-string.c (_dbus_string_init): get rid of annoying
1599 (_dbus_string_get_data): change to return string instead of using
1601 (_dbus_string_get_const_data): ditto
1602 (_dbus_string_get_data_len): ditto
1603 (_dbus_string_get_const_data_len): ditto
1605 2003-03-31 Havoc Pennington <hp@redhat.com>
1607 * bus/main.c (main): fix up the command line arguments to be nicer
1609 2003-03-31 Havoc Pennington <hp@redhat.com>
1611 * dbus/Makefile.am (INCLUDES): use EXPANDED_LOCALSTATEDIR to
1612 define DBUS_SYSTEM_BUS_PATH as we want to compile in the same
1613 final location that lands in the config file
1615 * bus/config-loader-expat.c (bus_config_load): fix type of
1618 * doc/TODO: remove TODO item for dbus_bus_get()
1620 * dbus/dbus-bus.c (bus_data_free): add missing lock/unlock
1622 2003-03-31 Havoc Pennington <hp@pobox.com>
1624 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_domain_socket)
1625 (_dbus_transport_new_for_tcp_socket): these didn't need the "server"
1626 argument since they are always client side
1628 * dbus/dbus-server.c (dbus_server_get_address): new function
1630 * bus/main.c (main): take the configuration file as an argument.
1632 * test/data/valid-config-files/debug-allow-all.conf: new file to
1633 use with dispatch.c tests for example
1635 * bus/test-main.c (main): require test data dir
1637 * bus/bus.c (bus_context_new): change this to take a
1638 configuration file name as argument
1640 * doc/config-file.txt (Elements): add <servicedir>
1642 * bus/system.conf, bus/session.conf: new files
1644 * dbus/dbus-bus.c (dbus_bus_get): look for system bus on
1645 well-known socket if none set
1647 * configure.in: create system.conf and session.conf
1649 2003-03-30 Havoc Pennington <hp@pobox.com>
1651 * bus/config-parser.c: hacking
1653 * dbus/dbus-memory.c: don't use DBusList for the list of stuff
1654 to shut down, since it could cause weirdness with the DBusList
1657 * dbus/dbus-list.c (_dbus_list_test): add tests for the
1658 link-oriented stack routines
1659 (alloc_link): free the mempool if the first alloc from it fails
1661 * dbus/dbus-mempool.c (struct DBusMemBlock): fix alignment issue
1663 * dbus/dbus-string.c (UNICODE_VALID): sync new version of this
1665 (_dbus_string_skip_white): new
1667 * doc/config-file.txt (Elements): add <includedir>
1669 2003-03-28 Havoc Pennington <hp@pobox.com>
1671 * dbus/dbus-string.c (_dbus_string_copy_data_len)
1672 (_dbus_string_copy_data): new functions
1674 2003-03-28 Anders Carlsson <andersca@codefactory.se>
1676 * dbus/dbus-bus.c: (bus_data_free), (dbus_bus_get):
1680 * dbus/dbus-memory.c:
1683 2003-03-28 Havoc Pennington <hp@pobox.com>
1685 * bus/test.c (bus_test_flush_bus): remove the sleep from here,
1686 I think it may have just been superstition. Not sure.
1688 * dbus/dbus-string.c (_dbus_string_base64_decode): catch some OOM
1689 failures that were not being handled.
1691 * dbus/dbus-auth.c (process_auth): fix a memleak in OOM handling
1693 * dbus/dbus-memory.c: add ability to set number of mallocs in a
1694 row that will fail on out-of-memory.
1696 * dbus/dbus-internals.c (_dbus_test_oom_handling): convenience
1697 function for testing out-of-memory handling.
1699 * bus/config-loader-expat.c (memsuite): don't wrap the dbus
1700 allocation functions, they do map exactly to the expat ones.
1702 2003-03-27 Havoc Pennington <hp@redhat.com>
1704 * bus/config-loader-libxml.c (bus_config_load): add another error
1707 2003-03-26 Anders Carlsson <andersca@codefactory.se>
1710 Add note about automatic service activation.
1712 * doc/dbus-specification.sgml:
1713 Rename the specification and clarify a few things.
1715 2003-03-26 Anders Carlsson <andersca@codefactory.se>
1718 * dbus/dbus-address.c:
1720 * dbus/dbus-marshal.c:
1721 * dbus/dbus-server-debug-pipe.c:
1722 * dbus/dbus-transport-unix.c:
1723 Fix documentation warnings.
1725 2003-03-26 Havoc Pennington <hp@pobox.com>
1727 * bus/test-main.c, dbus/dbus-test.c (main): check memleaks
1728 after every test so it's quick and easy to see which leaked, and
1729 so we test multiple dbus_shutdown() calls
1731 * configure.in: change configure.in XML stuff to also support
1734 * config-loader-libxml.c: some hacking
1736 * config-loader-expat.c: some hacking
1738 * config-parser.c: some hacking, plus tests
1740 2003-03-25 Havoc Pennington <hp@redhat.com>
1742 * throughout - add more _DBUS_ASSERT_ERROR_IS_CLEAR
1744 * configure.in: add --with-xml option to specify XML library,
1745 right now only libxml is supported.
1747 * bus/config-loader-libxml.c, config-parser.c: sync some minor
1748 nonworking code between home and work, still just stubs
1750 2003-03-24 Havoc Pennington <hp@redhat.com>
1752 * dbus/dbus-sysdeps.c (_dbus_set_fd_nonblocking): move to this
1755 * dbus/dbus-errors.c (dbus_set_error, dbus_set_error_const): allow
1756 NULL argument for "message" if the error is a well-known one,
1757 fill in a generic message in this case.
1759 * dbus/dbus-errors.h (DBusResultCode): Kill DBusResultCode in
1762 * bus/test.c (bus_test_flush_bus): add
1764 * bus/policy.c (bus_policy_test): test code stub
1766 2003-03-24 Havoc Pennington <hp@pobox.com>
1768 * bus/connection.c (bus_connections_setup_connection): set up
1769 the "can this user connect" function, but it always returns
1770 TRUE until we have a config file parser so we can have a config
1771 file that allows connections.
1773 2003-03-23 Havoc Pennington <hp@pobox.com>
1775 * dbus/dbus-threads.c (dbus_mutex_new, dbus_condvar_new): with
1776 DBUS_BUILD_TESTS, actually alloc/free a block of memory for
1777 the mutex, so we can check for proper memory management
1780 * dbus/dbus-dataslot.c: remove the mutex from
1781 DBusDataSlotAllocator and lock it manually when using it,
1782 to simplify fitting it into the global slots framework.
1784 * dbus/dbus-threads.c (init_static_locks): rework how we're
1785 handling global locks so they are easily shut down.
1787 * bus/policy.c (bus_policy_append_rule): fix
1789 * bus/test-main.c (main): check for memleaks
1791 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): make
1792 test suite check for memleaks
1794 * dbus/dbus-memory.c: add support in test mode for tracking
1795 number of outstanding blocks
1797 2003-03-23 Havoc Pennington <hp@pobox.com>
1799 * bus/policy.c, bus/bus.c, bus/connection.c: implement allow/deny
1802 * dbus/dbus-hash.h: add ULONG hash keys
1804 * dbus/dbus-sysdeps.c (_dbus_get_groups): new
1805 (_dbus_get_group_id): new function
1807 2003-03-20 Havoc Pennington <hp@redhat.com>
1809 * dbus/dbus-connection.c (dbus_connection_set_unix_user_function):
1811 (dbus_connection_get_unix_user): new function
1813 2003-03-20 Havoc Pennington <hp@pobox.com>
1815 * bus/connection.c (bus_connection_send_oom_error): assert that
1816 message has a sender
1817 (connection_execute_transaction): ditto
1818 (bus_connection_preallocate_oom_error): fix to set the sender, and
1819 set recipient to the destination service, not the bus driver
1821 * bus/policy.c: hacking
1823 * dbus/dbus-message.c (dbus_message_service_is): new function
1824 (dbus_message_sender_is): new
1826 2003-03-19 Havoc Pennington <hp@redhat.com>
1828 * bus/policy.c: start sketching code for policy restrictions on
1829 what connections can do.
1831 2003-03-18 Havoc Pennington <hp@redhat.com>
1833 * doc/TODO: some notes on high-level todo items. Little nitpick
1834 stuff is all in @todo, so no need to add it here.
1836 * doc/config-file.txt: some notes on how config file might look
1838 2003-03-18 Anders Carlsson <andersca@codefactory.se>
1844 2003-03-17 Havoc Pennington <hp@redhat.com>
1846 * dbus/dbus-internals.h: add gcc attributes so that
1847 our printf-style functions warn on bad arguments to
1850 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): fix printf
1853 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
1856 2003-03-17 Havoc Pennington <hp@redhat.com>
1858 * bus/test-main.c (main): make it print something as it runs
1859 so make check doesn't look stuck
1861 * doc/negotiation.txt, doc/dbus-sasl-profile.txt: remove
1862 from CVS, now obsolete
1864 2003-03-17 Anders Carlsson <andersca@codefactory.se>
1866 * bus/dispatch.c: (bus_dispatch):
1867 Refetch the service name since it may have been reallocated
1868 when dbus_message_set_sender was called.
1870 * dbus/dbus-sysdeps.c: (_dbus_accept):
1871 Add address and address length variables and use them to stop
1872 valgrind from complaining.
1874 2003-03-17 Havoc Pennington <hp@pobox.com>
1876 All tests pass, no memleaks, no valgrind complaints.
1878 * bus/test.c: refcount handler_slot
1880 * bus/connection.c (bus_connections_new): refcount
1881 connection_data_slot
1883 * dbus/dbus-auth-script.c (_dbus_auth_script_run): delete unused
1884 bytes so that auth scripts pass.
1886 * bus/dispatch.c: init message_handler_slot so it gets allocated
1889 * bus/dispatch.c (message_handler_slot_ref): fix memleak
1891 * dbus/dbus-server-debug-pipe.c (_dbus_server_debug_pipe_new):
1892 dealloc server_pipe_hash when no longer used for benefit of
1895 * dbus/dbus-auth.c (process_command): memleak fix
1897 * bus/dispatch.c (check_hello_message): memleak fix
1899 2003-03-16 Havoc Pennington <hp@pobox.com>
1901 * dbus/dbus-bus.c (ensure_bus_data): fix double-unref of the data slot
1903 2003-03-17 Anders Carlsson <andersca@codefactory.se>
1905 * bus/activation.c (bus_activation_activate_service): Append
1906 the pending activation entry to the list of pending activations.
1908 2003-03-16 Havoc Pennington <hp@pobox.com>
1910 * bus/dispatch.c (bus_dispatch_test): remove double-unrefs of
1913 * dbus/dbus-address.c (create_entry): fix OOM handling when
1914 failing to alloc entry->method
1916 2003-03-16 Havoc Pennington <hp@pobox.com>
1918 * dbus/dbus-watch.c (_dbus_watch_new): handle failure to malloc
1921 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
1922 add some missing dbus_set_result
1924 * bus/dispatch.c (bus_dispatch_add_connection): handle failure to
1925 alloc the DBusMessageHandler
1927 * dbus/dbus-transport.c (_dbus_transport_disconnect): don't ref
1928 the transport here, since we call this from the finalizer; it
1929 resulted in a double-finalize.
1931 * dbus/dbus-transport.c (_dbus_transport_disconnect): fix a bug
1932 where we tried to use transport->connection that was NULL,
1933 happened when transport was disconnected early on due to OOM
1935 * bus/*.c: adapt to handle OOM for watches/timeouts
1937 * dbus/dbus-transport-unix.c: port to handle OOM during
1940 * dbus/dbus-auth.c (_dbus_auth_get_unused_bytes): return a
1941 reference to unused bytes instead of a copy
1943 * dbus/dbus-server.c (dbus_server_handle_watch): return FALSE for
1946 * dbus/dbus-connection.c (dbus_connection_handle_watch): return
1949 * dbus/dbus-timeout.c (dbus_timeout_handle): return FALSE for out
1952 2003-03-16 Anders Carlsson <andersca@codefactory.se>
1954 * doc/dbus-specification.sgml:
1955 Document reply message for ActivateService.
1957 2003-03-16 Anders Carlsson <andersca@codefactory.se>
1959 * bus/activation.c: (bus_pending_activation_entry_free),
1960 (bus_pending_activation_free), (bus_activation_new),
1961 (bus_activation_unref), (bus_activation_service_created),
1962 (bus_activation_activate_service):
1964 * bus/bus.c: (bus_context_new):
1965 * bus/desktop-file.c: (new_section):
1966 * bus/driver.c: (bus_driver_send_service_deleted),
1967 (bus_driver_handle_activate_service):
1968 * bus/services.c: (bus_registry_new), (bus_registry_ensure):
1970 * dbus/dbus-connection.c:
1971 (dbus_connection_send_with_reply_and_block):
1972 * dbus/dbus-message.c: (dbus_message_append_args_valist):
1973 * dbus/dbus-protocol.h:
1974 Make activation work better. Now pending activations will be queued
1975 and the daemon won't try to activate services that are already registered.
1977 2003-03-16 Havoc Pennington <hp@pobox.com>
1979 * dbus/dbus-bus.c (ensure_bus_data): handle failure to set
1982 * dbus/dbus-memory.c (_dbus_initialize_malloc_debug): support
1983 DBUS_MALLOC_BACKTRACES to print trace when failing an alloc
1985 2003-03-16 Havoc Pennington <hp@pobox.com>
1987 * dbus/dbus-string.c (_dbus_string_validate_utf8): oops, unbreak
1988 this. always run the test suite before commit...
1990 * bus/*: adapt to DBusConnection API changes
1992 * glib/dbus-gmain.c: adapt to DBusConnection API changes,
1993 requires renaming stuff to avoid dbus_connection_dispatch name
1996 * dbus/dbus-transport.c (_dbus_transport_queue_messages): new
1999 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
2000 separate from _dbus_message_loader_return_buffer()
2002 * dbus/dbus-connection.c (dbus_connection_get_n_messages): remove
2003 this, because it's now always broken to use; the number of
2004 messages in queue vs. the number still buffered by the message
2005 loader is undefined/meaningless. Should use
2006 dbus_connection_get_dispatch_state().
2007 (dbus_connection_dispatch): rename from
2008 dbus_connection_dispatch_message
2010 2003-03-16 Havoc Pennington <hp@pobox.com>
2012 * dbus/dbus-string.c (_dbus_string_validate_utf8): copy in a real
2015 2003-03-16 Anders Carlsson <andersca@codefactory.se>
2017 * dbus/dbus-connection.c:
2018 (dbus_connection_send_with_reply_and_block):
2019 Decrease connection->n_incoming when removing an entry
2021 * dbus/dbus-dict.c: (dbus_dict_entry_free),
2022 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
2023 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
2024 (dbus_dict_set_byte_array), (dbus_dict_set_string_array),
2025 (dbus_dict_get_boolean_array), (dbus_dict_get_double_array),
2026 (dbus_dict_get_byte_array):
2027 Handle NULL arrays and strings. Also add support for byte arrays.
2029 * dbus/dbus-marshal.c: (_dbus_marshal_byte_array),
2030 (_dbus_marshal_dict), (_dbus_demarshal_byte_array),
2031 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
2032 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
2033 (_dbus_demarshal_dict), (demarshal_and_validate_len),
2034 (_dbus_marshal_validate_arg), (_dbus_marshal_test):
2035 * dbus/dbus-marshal.h:
2036 Add support for marshalling and demarshalling empty arrays and strings.
2038 * dbus/dbus-message.c: (dbus_message_append_args_valist),
2039 (dbus_message_append_string_array),
2040 (dbus_message_iter_get_boolean),
2041 (dbus_message_iter_get_boolean_array),
2042 (dbus_message_iter_get_int32_array),
2043 (dbus_message_iter_get_uint32_array),
2044 (dbus_message_iter_get_double_array),
2045 (dbus_message_iter_get_byte_array),
2046 (dbus_message_iter_get_string_array), (dbus_message_iter_get_dict),
2047 (check_message_handling):
2048 Add support for getting empty arrays and dicts.
2050 * dbus/dbus-string.c: (_dbus_string_validate_utf8):
2051 Don't do any validation at all for now, that's better than just checking
2054 * test/data/valid-messages/emptiness.message:
2055 New test message with lots of empty arrays.
2057 2003-03-16 Havoc Pennington <hp@pobox.com>
2059 * dbus/dbus-connection.c
2060 (_dbus_connection_queue_received_message_link): new function that
2061 can't fail due to OOM
2063 * dbus/dbus-message.c (_dbus_message_loader_pop_message_link):
2064 new function pops a message together with a list link
2067 * dbus/dbus-transport-unix.c (queue_messages): use new link-based
2068 message queuing functions to avoid needing to alloc memory
2070 2003-03-16 Havoc Pennington <hp@pobox.com>
2072 Oops - test code was only testing failure of around 30 of the
2073 mallocs in the test path, but it turns out there are 500+
2074 mallocs. I believe this was due to misguided linking setup such
2075 that there was one copy of dbus_malloc etc. in the daemon and one
2076 in the shared lib, and only daemon mallocs were tested. In any
2077 case, the test case now tests all 500+ mallocs, and doesn't pass
2078 yet, though there are lots of fixes in this patch.
2080 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
2081 this so that it doesn't need to allocate memory, since it
2082 has no way of indicating failure due to OOM (and would be
2083 annoying if it did).
2085 * dbus/dbus-list.c (_dbus_list_pop_first_link): new function
2087 * bus/Makefile.am: rearrange to create two self-contained
2088 libraries, to avoid having libraries with overlapping symbols.
2089 that was resulting in weirdness, e.g. I'm pretty sure there
2090 were two copies of global static variables.
2092 * dbus/dbus-internals.c: move the malloc debug stuff to
2095 * dbus/dbus-list.c (free_link): free list mempool if it becomes
2098 * dbus/dbus-memory.c (_dbus_disable_mem_pools): new function
2100 * dbus/dbus-address.c (dbus_parse_address): free list nodes
2103 * bus/dispatch.c (bus_dispatch_add_connection): free
2104 message_handler_slot when no longer using it, so
2105 memory leak checkers are happy for the test suite.
2107 * dbus/dbus-server-debug-pipe.c (debug_finalize): free server name
2109 * bus/bus.c (new_connection_callback): disconnect in here if
2110 bus_connections_setup_connection fails.
2112 * bus/connection.c (bus_connections_unref): fix to free the
2114 (bus_connections_setup_connection): if this fails, don't
2115 disconnect the connection, just be sure there are no side
2118 * dbus/dbus-string.c (undo_alignment): unbreak this
2120 * dbus/dbus-auth.c (_dbus_auth_unref): free some stuff we were
2122 (_dbus_auth_new): fix the order in which we free strings
2125 * bus/connection.c (bus_connection_disconnected): fix to
2126 not send ServiceDeleted multiple times in case of memory
2129 * dbus/dbus-bus.c (dbus_bus_get_base_service): new function to
2130 get the base service name
2131 (dbus_bus_register_client): don't return base service name,
2132 instead store it on the DBusConnection and have an accessor
2134 (dbus_bus_register_client): rename dbus_bus_register()
2136 * bus/dispatch.c (check_hello_message): verify that other
2137 connections on the bus also got the correct results, not
2138 just the one sending hello
2140 2003-03-15 Havoc Pennington <hp@pobox.com>
2142 Make it pass the Hello handling test including all OOM codepaths.
2143 Now to do other messages...
2145 * bus/services.c (bus_service_remove_owner): fix crash when
2146 removing owner from an empty list of owners
2147 (bus_registry_ensure): don't leave service in the list of
2148 a connection's owned services if we fail to put the service
2151 * bus/connection.c (bus_connection_preallocate_oom_error): set
2152 error flag on the OOM error.
2154 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
2155 handle _dbus_transport_set_connection failure
2157 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd): modify
2158 to create watches up front and simply enable/disable them as
2160 (unix_connection_set): this can now fail on OOM
2162 * dbus/dbus-timeout.c, dbus/dbus-watch.c: add concept
2163 of enabling/disabling a watch or timeout.
2165 * bus/loop.c (bus_loop_iterate): don't touch disabled
2168 * glib/dbus-gmain.c: adapt to enable/disable watches and timeouts
2170 2003-03-15 Havoc Pennington <hp@pobox.com>
2172 * bus/dispatch.c (bus_dispatch_test): OK, now finally actually
2173 write useful test code, after all that futzing around ;-)
2175 Test does not yet pass because we can't handle OOM in
2176 _dbus_transport_messages_pending (basically,
2177 dbus_connection_preallocate_send() does not prealloc the write
2178 watch). To fix this, I think we need to add new stuff to
2179 set_watch_functions, namely a SetEnabled function so we can alloc
2180 the watch earlier, then enable it later.
2182 * dbus/Makefile.am (libdbus_convenience_la_SOURCES): move
2183 dbus-memory.c to the convenience lib
2185 * bus/test.c: rename some static functions to keep them clearly
2186 distinct from stuff in connection.c. Handle client disconnection.
2188 2003-03-14 Havoc Pennington <hp@pobox.com>
2190 * bus/dispatch.c (bus_dispatch_test): do test using debug-pipe
2191 transport, tests more of the real codepath. Set up clients
2192 with bus_setup_debug_client.
2194 * bus/test.c (bus_setup_debug_client): function to set up debug
2195 "clients" on the main loop
2197 * dbus/dbus-transport.c (_dbus_transport_open): add debug-pipe
2200 * dbus/dbus-server.c (dbus_server_listen): add debug-pipe
2203 * dbus/dbus-server-debug.c: support a debug server based on pipes
2205 * dbus/dbus-sysdeps.c (_dbus_full_duplex_pipe): new function
2206 (_dbus_close): new function
2208 * configure.in: check for socketpair
2210 2003-03-14 Havoc Pennington <hp@redhat.com>
2212 * dbus/dbus-memory.c: add a "detect buffer overwrites on free"
2215 * dbus/dbus-transport-debug.c: rework this a good bit to be
2216 less complicated. hopefully still works.
2218 * dbus/dbus-server-debug.c (handle_new_client): remove timeout
2221 * glib/dbus-gmain.c (timeout_handler): don't remove timeout
2224 * dbus/dbus-message.c (dbus_message_copy): rename from
2225 dbus_message_new_from_message, fix it up to copy
2226 all the message fields, add test case
2228 * bus/dispatch.c (bus_dispatch_test): add some more test code,
2229 not quite passing yet
2231 2003-03-14 Havoc Pennington <hp@pobox.com>
2233 * bus/loop.c (bus_loop_iterate): add this so we can "run loop
2234 until no work remains" in test code. (the large diff here
2235 is just code movement, no actual changes)
2237 * dbus/dbus-server-debug.c (DEFAULT_INTERVAL): change interval to
2238 1, no point waiting around for test code.
2239 (_dbus_server_debug_accept_transport): unref the timeout
2240 after adding it (right?)
2242 * dbus/dbus-transport-debug.c (DEFAULT_INTERVAL): ditto
2244 2003-03-13 Havoc Pennington <hp@redhat.com>
2246 * dbus/dbus-timeout.c (_dbus_timeout_list_set_functions): handle
2249 * dbus/dbus-watch.c (_dbus_watch_list_set_functions): handle out
2252 * dbus/dbus-connection.h: Make AddWatchFunction and
2253 AddTimeoutFunction return a bool so they can fail on out-of-memory
2255 * bus/bus.c (bus_context_new): set up timeout handlers
2257 * bus/connection.c (bus_connections_setup_connection): set up
2260 * glib/dbus-gmain.c: adapt to the fact that set_functions stuff
2263 * bus/bus.c (bus_context_new): adapt to changes
2265 * bus/connection.c: adapt to changes
2267 * test/watch.c: adapt to DBusWatch changes
2269 * bus/dispatch.c (bus_dispatch_test): started adding this but
2272 2003-03-14 Anders Carlsson <andersca@codefactory.se>
2274 * bus/dispatch.c (send_service_nonexistent_error): Fix typo.
2276 2003-03-13 Havoc Pennington <hp@pobox.com>
2278 * bus/test.c, bus/test.h, bus/Makefile.am, bus/test-main.c:
2279 set up a test framework as for the library
2281 2003-03-12 Havoc Pennington <hp@pobox.com>
2283 Throughout: purge global variables, introduce BusActivation,
2284 BusConnections, BusRegistry, etc. objects instead.
2286 * bus/bus.h, bus/bus.c: introduce BusContext as a global
2289 * test/Makefile.am (TEST_BINARIES): disable bus-test for now,
2290 going to redo this a bit differently I think
2292 2003-03-12 Havoc Pennington <hp@redhat.com>
2294 Mega-patch that gets the message bus daemon initially handling
2295 out-of-memory. Work still needed. Also lots of random
2296 moving stuff to DBusError instead of ResultCode.
2298 * dbus/dbus-list.c (_dbus_list_length_is_one): new function
2300 * dbus/dbus-connection.c
2301 (dbus_connection_send_with_reply_and_block): use DBusError
2303 * dbus/dbus-bus.c: adapt to API changes, make it use DBusError not
2306 * dbus/dbus-connection.c (dbus_connection_send): drop the result
2307 code here, as the only failure possible is OOM.
2309 * bus/connection.c (bus_connection_disconnect):
2310 rename bus_connection_disconnected as it's a notification only
2312 * bus/driver.c (bus_driver_handle_acquire_service): don't free
2313 "name" on get_args failure, should be done by get_args;
2314 don't disconnect client for bad args, just return an error.
2315 (bus_driver_handle_service_exists): ditto
2317 * bus/services.c (bus_services_list): NULL-terminate returned array
2319 * bus/driver.c (bus_driver_send_service_lost)
2320 (bus_driver_send_service_acquired): send messages from driver to a
2321 specific client to the client's unique name, not to the broadcast
2324 * dbus/dbus-message.c (decode_header_data): reject messages that
2325 contain no name field
2326 (_dbus_message_get_client_serial): rename to
2327 dbus_message_get_serial and make public
2328 (_dbus_message_set_serial): rename from set_client_serial
2329 (_dbus_message_set_reply_serial): make public
2330 (_dbus_message_get_reply_serial): make public
2332 * bus/connection.c (bus_connection_foreach): allow stopping
2333 iteration by returning FALSE from foreach function.
2335 * dbus/dbus-connection.c (dbus_connection_send_preallocated)
2336 (dbus_connection_free_preallocated_send)
2337 (dbus_connection_preallocate_send): new API for sending a message
2338 without possibility of malloc failure.
2339 (dbus_connection_send_message): rename to just
2340 dbus_connection_send (and same for whole function family)
2342 * dbus/dbus-errors.c (dbus_error_free): make this reinit the error
2344 * dbus/dbus-sysdeps.c (_dbus_exit): new function
2346 * bus/activation.c: handle/return errors
2348 * dbus/dbus-errors.h: add more DBUS_ERROR #define
2350 * dbus/dbus-sysdeps.c (_dbus_directory_open) (_dbus_file_get_contents)
2351 (_dbus_directory_get_next_file): use DBusError instead of DBusResultCode
2352 (_dbus_result_from_errno): move to this file
2354 2003-03-10 Anders Carlsson <andersca@codefactory.se>
2356 * dbus/dbus-marshal.c:
2357 (_dbus_marshal_set_string):
2358 Take a length argument so we can marshal the correct string
2361 (_dbus_marshal_dict), (_dbus_demarshal_dict),
2362 (_dbus_marshal_get_arg_end_pos), (_dbus_marshal_validate_arg),
2363 (_dbus_marshal_test):
2364 * dbus/dbus-marshal.h:
2365 Add support for marshalling and demarshalling dicts.
2367 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
2368 Add support for TYPE DICT.
2370 * dbus/dbus-message.c: (set_string_field):
2371 Adjust header padding.
2373 (dbus_message_append_args_valist), (dbus_message_append_dict),
2374 (dbus_message_get_args_valist), (dbus_message_iter_get_arg_type),
2375 (dbus_message_iter_get_dict), (_dbus_message_loader_return_buffer),
2376 (check_message_handling), (check_have_valid_message):
2377 * dbus/dbus-message.h:
2378 Add functions for setting and getting dicts.
2380 * dbus/dbus-protocol.h:
2386 * doc/dbus-specification.sgml:
2387 Add information about how dicts are marshalled.
2389 * test/data/invalid-messages/dict-with-nil-value.message:
2390 * test/data/invalid-messages/too-short-dict.message:
2391 * test/data/valid-messages/dict-simple.message:
2392 * test/data/valid-messages/dict.message:
2393 Add sample messages containing dicts.
2395 2003-03-08 Anders Carlsson <andersca@codefactory.se>
2397 * dbus/dbus-dict.h: Add DBUS_END_DECLS.
2399 2003-03-07 Anders Carlsson <andersca@codefactory.se>
2402 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
2403 (dbus_dict_get_keys), (insert_entry), (dbus_dict_set_boolean),
2404 (dbus_dict_set_int32), (dbus_dict_set_uint32),
2405 (dbus_dict_set_double), (dbus_dict_set_string),
2406 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
2407 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
2408 (dbus_dict_set_string_array), (_dbus_dict_test):
2410 Fix according to comments from Havoc.
2412 2003-03-06 Michael Meeks <michael@server.home>
2414 * configure.in: if we don't have kde-config, disable have_qt.
2416 2003-03-07 Anders Carlsson <andersca@codefactory.se>
2421 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
2422 (dbus_dict_ref), (dbus_dict_unref), (dbus_dict_contains),
2423 (dbus_dict_remove), (dbus_dict_get_value_type),
2424 (dbus_dict_get_keys), (dbus_dict_put_boolean),
2425 (dbus_dict_put_int32), (dbus_dict_put_uint32),
2426 (dbus_dict_put_double), (dbus_dict_put_string),
2427 (dbus_dict_put_boolean_array), (dbus_dict_put_int32_array),
2428 (dbus_dict_put_uint32_array), (dbus_dict_put_double_array),
2429 (dbus_dict_put_string_array), (dbus_dict_get_boolean),
2430 (dbus_dict_get_int32), (dbus_dict_get_uint32),
2431 (dbus_dict_get_double), (dbus_dict_get_string),
2432 (dbus_dict_get_boolean_array), (dbus_dict_get_int32_array),
2433 (dbus_dict_get_uint32_array), (dbus_dict_get_double_array),
2434 (dbus_dict_get_string_array), (_dbus_dict_test):
2436 Add DBusDict implementation
2438 * dbus/dbus-test.c: (dbus_internal_do_not_use_run_tests):
2442 2003-03-04 Havoc Pennington <hp@pobox.com>
2444 * test/data/auth/*: adapt to changes
2446 * dbus/dbus-auth-script.c (_dbus_auth_script_run): add
2447 USERID_BASE64 and change USERNAME_BASE64 to put in username not
2450 * dbus/dbus-keyring.c (_dbus_keyring_validate_context): prevent
2451 more stuff from being in a context name, to make the protocol
2452 simpler to deal with
2454 * dbus/dbus-errors.c (dbus_error_has_name): new function
2455 (dbus_error_is_set): new function
2457 * dbus/dbus-auth.c: replace DBUS_STUPID_TEST_MECH auth
2458 with DBUS_COOKIE_SHA1, implement DBUS_COOKIE_SHA1
2460 * dbus/dbus-connection.c (dbus_connection_flush): also read
2461 messages during a flush operation
2463 * dbus/Makefile.am: remove dbus-md5 since it isn't currently used.
2465 2003-03-05 Anders Carlsson <andersca@codefactory.se>
2467 * configure.in: Check for gethostbyname on Solaris.
2469 * dbus/dbus-transport.c: (_dbus_transport_open):
2470 Remove duplicate "tcp" entry.
2472 * doc/dbus-specification.sgml:
2473 Clarify some things.
2475 2003-03-05 Anders Carlsson <andersca@codefactory.se>
2477 * dbus/dbus-auth.c: (send_rejected), (process_test_subdir):
2478 * dbus/dbus-keyring.c: (_dbus_keyring_new_homedir),
2479 (_dbus_keyring_test):
2480 * dbus/dbus-md5.c: (_dbus_md5_compute):
2481 * dbus/dbus-sha.c: (_dbus_sha_compute):
2484 2003-03-05 Anders Carlsson <andersca@codefactory.se>
2486 * README: Add some things.
2488 2003-03-04 Anders Carlsson <andersca@codefactory.se>
2490 * dbus/dbus-message.c (dbus_message_append_args_valist): Add a break;
2491 after case DBUS_TYPE_BOOELAN.
2493 2003-03-02 Havoc Pennington <hp@pobox.com>
2495 * test/break-loader.c (randomly_set_extreme_ints): add test that
2496 sets really huge and small integers
2498 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add check
2499 that length of boolean array fits in the string, and that
2500 string has room for boolean value in single-bool case.
2502 * dbus/dbus-message-builder.c (_dbus_message_data_load): add
2503 optional value to "ALIGN" command which is what to fill the
2506 * test/data/valid-messages/no-padding.message: add regression
2507 test for the message padding problem
2509 2003-03-02 Havoc Pennington <hp@pobox.com>
2511 * dbus/dbus-message.c (decode_header_data): fix to always init
2512 message_padding, from Benjamin Dauvergne
2514 2003-03-02 Havoc Pennington <hp@pobox.com>
2520 2003-03-01 Joe Shaw <joe@assbarn.com>
2522 * configure.in: Check for "struct cmsgcred" and try to access its
2523 members for BSD-like unices.
2525 * dbus/dbus-sysdeps.c (read_credentials_byte): Fold this back into
2526 _dbus_read_credentials_unix_socket().
2527 (_dbus_read_credentials_unix_socket): Use recvmsg() instead of
2528 read() for reading the credential byte off the unix socket. Use
2529 struct cmsgcred on systems that support it.
2531 2003-02-27 Alexander Larsson <alexl@redhat.com>
2535 Make gthreads-2.0 dependency optional. Don't build thread test if
2538 2003-02-27 Havoc Pennington <hp@pobox.com>
2540 * dbus/dbus-connection.c
2541 (dbus_connection_send_message_with_reply_and_block): fix doh!
2542 doh! doh! bug that resulted in never removing a reply from the
2543 queue, no wonder we called get_reply_serial so much ;-)
2545 * dbus/dbus-message.c (struct DBusMessage): cache reply serial
2546 and client serial instead of demarshaling them every time
2548 2003-02-27 Havoc Pennington <hp@pobox.com>
2550 * dbus/dbus-marshal.c (_dbus_demarshal_int32): rewrite to be much
2551 more inlined, using dbus-string-private.h, speeds things up
2554 * dbus/dbus-string.c (_dbus_string_free): apply align offset
2555 when freeing the string
2556 (_dbus_string_steal_data): fix for align offset
2557 (undo_alignment): new function
2559 2003-02-26 Havoc Pennington <hp@redhat.com>
2561 All kinds of audit fixes from Owen, plus initial attempt to
2562 handle unaligned memory returned from malloc.
2564 * dbus/dbus-string.c (_dbus_string_init): clamp max length to
2565 leave room for align_offset and nul byte
2566 (fixup_alignment): function to track an align_offset and
2567 ensure real->str is aligned
2568 (DBUS_GENERIC_STRING_PREAMBLE): len must be less than allocated,
2569 to allow a nul byte plus align offset
2570 (_dbus_string_lock): fix overflow issue
2571 (_dbus_string_init_const_len): add assertions on sanity of len,
2572 assign allocated to be ALLOCATION_PADDING larger than len
2573 (set_length): fixup the overflow handling
2574 (_dbus_string_get_data_len): fix overflow in assertion
2575 (open_gap): detect overflow in size of gap to be opened
2576 (_dbus_string_lengthen): add overflow check
2577 (_dbus_string_align_length): fix overflow with _DBUS_ALIGN_VALUE
2578 (_dbus_string_append): add overflow check
2579 (_dbus_string_append_unichar): overflow
2580 (_dbus_string_delete): fix overflow in assertion
2581 (_dbus_string_copy_len): overflow in assertion
2582 (_dbus_string_replace_len): overflows in assertions
2583 (_dbus_string_find): change to implement in terms of
2584 _dbus_string_find_to
2585 (_dbus_string_find_to): assorted fixage
2586 (_dbus_string_equal_c_str): assert c_str != NULL,
2587 fix logic so the function works
2588 (_dbus_string_ends_with_c_str): fix overflow thingy
2589 (_dbus_string_base64_encode): overflow fix
2590 (_dbus_string_validate_ascii): overflow
2591 (_dbus_string_validate_nul): overflow
2593 2003-02-26 Havoc Pennington <hp@redhat.com>
2595 * dbus/dbus-marshal.c (_dbus_marshal_test): fix to work with DISABLE_ASSERTS
2597 2003-02-26 Alexander Larsson <alexl@redhat.com>
2600 Set DBUS_GLIB_THREADS_LIBS for apps using gthread-2.0
2602 * dbus/dbus-connection.c:
2603 * dbus/dbus-connection.h:
2604 Fix _dbus_connection_acquire_io_path and _dbus_connection_acquire_dispatch.
2605 Add dbus_connection_set_wakeup_main_function and use it when queueing
2606 incoming and outgoing messages.
2609 * dbus/dbus-dataslot.c:
2610 Threadsafe usage of DBusDataSlotAllocator
2612 * dbus/dbus-message.c: (dbus_message_get_args_iter):
2615 * dbus/dbus-server-unix.c:
2618 * glib/dbus-gmain.c:
2619 Implement the new wakeup functions for glib.
2622 * glib/test-thread-client.c:
2623 * glib/test-thread-server.c:
2624 * glib/test-thread.h:
2625 Initial cut at some thread test code. Not really done yet.
2627 2003-02-26 Havoc Pennington <hp@pobox.com>
2629 * dbus/dbus-connection.c
2630 (dbus_connection_send_message_with_reply_and_block): fix crash
2631 where we ref'd the outgoing message instead of the returned reply
2633 * dbus/dbus-transport-unix.c (do_authentication): check read watch
2634 at the end of this function, so if we didn't need to read for
2635 authentication, we reinstall it for receiving messages
2637 * dbus/dbus-message.c (dbus_message_new_reply): allow replies to
2638 a NULL sender for peer-to-peer case
2640 * dbus/dbus-transport-unix.c (check_read_watch): handle
2641 !authenticated case correctly
2643 * glib/dbus-gmain.c: add support for DBusServer
2645 * dbus/dbus-server.c: add data slot support
2647 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): check
2648 return values and handle errors
2650 * dbus/dbus-dataslot.c: factor out the data slot stuff from
2653 * Doxyfile.in (INPUT): add glib subdir
2655 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): rename
2656 setup_with_g_main instead of hookup_with_g_main; write docs
2658 2003-02-24 Anders Carlsson <andersca@codefactory.se>
2660 * dbus/dbus-marshal.c: (_dbus_marshal_validate_arg):
2661 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
2662 * dbus/dbus-message.c: (dbus_message_append_boolean),
2663 (dbus_message_append_boolean_array),
2664 (dbus_message_get_args_valist), (_dbus_message_test):
2665 * dbus/dbus-message.h:
2666 * doc/dbus-specification.sgml:
2667 Various fixes as pointed out by Havoc.
2669 * test/data/invalid-messages/bad-boolean-array.message:
2670 * test/data/invalid-messages/bad-boolean.message:
2671 Add invalid boolean value test cases.
2673 2003-02-24 Anders Carlsson <andersca@codefactory.se>
2675 * dbus/dbus-internals.c: (_dbus_type_to_string):
2676 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
2677 (_dbus_marshal_validate_arg):
2678 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
2679 * dbus/dbus-message.c: (dbus_message_append_args_valist),
2680 (dbus_message_append_boolean), (dbus_message_append_boolean_array),
2681 (dbus_message_get_args_valist), (dbus_message_iter_get_boolean),
2682 (dbus_message_iter_get_int32), (dbus_message_iter_get_uint32),
2683 (dbus_message_iter_get_double),
2684 (dbus_message_iter_get_boolean_array), (message_iter_test):
2685 * dbus/dbus-message.h:
2686 * dbus/dbus-protocol.h:
2687 * doc/dbus-specification.sgml:
2688 * test/data/valid-messages/lots-of-arguments.message:
2689 Add support for boolean and boolean array types.
2691 2003-02-23 Havoc Pennington <hp@pobox.com>
2693 * dbus/dbus-keyring.c: finish most of this implementation and
2696 * dbus/dbus-errors.c (dbus_set_error_const, dbus_set_error): make
2697 these barf if the error isn't cleared to NULL
2699 * dbus/dbus-sysdeps.c (_dbus_delete_file): set error on failure
2700 (_dbus_create_directory): new function
2702 * dbus/dbus-errors.c (dbus_set_error): fix warning
2704 * dbus/dbus-string.c (_dbus_string_hex_encode): new function
2705 (_dbus_string_hex_decode): new function
2706 (test_hex_roundtrip): test code
2708 * dbus/dbus-sha.c (_dbus_sha_compute): use dbus_string_hex_encode
2710 * dbus/dbus-md5.c (_dbus_md5_compute): use dbus_string_hex_encode
2712 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): make this use
2713 the save-to-temp/rename trick to atomically write the new file
2714 (_dbus_string_parse_uint): new function
2716 2003-02-22 Havoc Pennington <hp@pobox.com>
2718 * test/Makefile.am (dist-hook): fix dist for test/data/sha-1
2720 2003-02-22 Havoc Pennington <hp@pobox.com>
2722 * dbus/dbus-message.c (dbus_message_iter_get_string_array):
2723 (dbus_message_iter_get_byte_array): Fix up doxygen warnings
2725 * dbus/dbus-sha.c: add implementation of SHA-1 algorithm
2727 * dbus/test/data/sha-1: add US government test suite for SHA-1
2729 2003-02-21 Anders Carlsson <andersca@codefactory.se>
2731 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
2732 Make string arrays NULL-terminated.
2734 * dbus/dbus-memory.c: (dbus_free_string_array):
2735 * dbus/dbus-memory.h:
2736 New function for freeing NULL-terminated string arrays.
2738 * dbus/dbus-message-builder.c: (append_quoted_string),
2739 (_dbus_message_data_load):
2740 Add support for array types.
2742 * dbus/dbus-message.c: (check_message_handling):
2743 Add more types as test cases.
2745 * dbus/dbus-sysdeps.c: (_dbus_string_parse_int),
2746 (_dbus_string_parse_double):
2747 Add the start offset to the end offset.
2749 * test/data/valid-messages/lots-of-arguments.message:
2750 New test message with lots of arguments.
2752 2003-02-21 Anders Carlsson <andersca@codefactory.se>
2754 * dbus/dbus-message.c: (dbus_message_append_nil),
2755 (dbus_message_append_int32), (dbus_message_append_uint32),
2756 (dbus_message_append_double), (dbus_message_append_string),
2757 (dbus_message_append_int32_array),
2758 (dbus_message_append_uint32_array),
2759 (dbus_message_append_double_array),
2760 (dbus_message_append_byte_array),
2761 (dbus_message_append_string_array):
2762 Fix all out-of-memory handling in these functions.
2764 2003-02-21 Anders Carlsson <andersca@codefactory.se>
2766 * dbus/dbus-message.c: (dbus_message_append_nil):
2769 2003-02-21 Anders Carlsson <andersca@codefactory.se>
2771 * dbus/dbus-message.c: (dbus_message_append_args_valist),
2772 (dbus_message_append_nil), (dbus_message_append_int32_array),
2773 (dbus_message_append_uint32_array),
2774 (dbus_message_append_double_array),
2775 (dbus_message_append_byte_array),
2776 (dbus_message_append_string_array), (dbus_message_get_args_valist),
2777 (dbus_message_iter_get_int32_array),
2778 (dbus_message_iter_get_uint32_array),
2779 (dbus_message_iter_get_double_array),
2780 (dbus_message_iter_get_byte_array),
2781 (dbus_message_iter_get_string_array):
2783 * dbus/dbus-message.h:
2784 Add functions for appending and getting arrays.
2786 2003-02-21 Anders Carlsson <andersca@codefactory.se>
2788 * dbus/dbus-mempool.c (_dbus_mem_pool_new): Make the
2789 element size at least 8 bytes, fixes mempool tests on
2792 2003-02-20 Alexander Larsson <alexl@redhat.com>
2794 * dbus/dbus-transport-unix.c (unix_do_iteration):
2795 Unlock the connection mutex during a blocking select call.
2796 Add todo about how we need a way to wake up the select.
2798 * dbus/dbus-connection-internal.h:
2799 * dbus/dbus-connection.c:
2800 Add _dbus_connection_lock and _dbus_connection_unlock.
2802 2003-02-19 Havoc Pennington <hp@pobox.com>
2804 * Doxyfile.in (PREDEFINED): put DOXYGEN_SHOULD_SKIP_THIS in
2805 Doxyfile.in, not Doxyfile
2807 * dbus/dbus-keyring.c: do some hacking on this
2809 * dbus/dbus-sysdeps.c (_dbus_delete_file): new
2811 * dbus/dbus-errors.c (dbus_set_error_const): do not call
2813 (dbus_set_error): remove dbus_error_init, check for message ==
2814 NULL *before* we sprintf into it, and add @todo about including
2815 system headers in this file
2817 * dbus/dbus-sysdeps.c (_dbus_create_file_exclusively): new
2819 * dbus/dbus-errors.h (DBUS_ERROR_FAILED): add
2821 * dbus/dbus-sysdeps.c (get_user_info): break this function out to
2822 get various bits of user information based on either username
2824 (_dbus_homedir_from_username): new function
2826 2003-02-19 Anders Carlsson <andersca@codefactory.se>
2829 Add check for nonposix getpwnam_r
2831 * dbus/dbus-mempool.c: (_dbus_mem_pool_new):
2832 Align the pool element size to a sizeof (void *) boundary.
2834 * dbus/dbus-sysdeps.c: (_dbus_setenv), (_dbus_connect_unix_socket),
2835 (_dbus_listen_unix_socket), (_dbus_credentials_from_username):
2836 General Solaris fixes.
2838 * test/data/valid-messages/simplest-manual.message:
2839 Explicitly state that we want little-endian packing.
2841 2003-02-19 Mikael Hallendal <micke@codefactory.se>
2843 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
2845 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_tcp_socket):
2846 Added to create a transport connecting using a tcp/ip socket.
2848 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): Added to connect
2849 to a tcp socket at given host and port.
2850 (_dbus_listen_tcp_socket): added to listen on tcp socket for given
2853 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
2855 * dbus/dbus-server-unix.c (_dbus_server_new_for_tcp_socket):
2856 Added to create a server listening on a TCP/IP socket.
2858 2003-02-19 Havoc Pennington <hp@pobox.com>
2860 Throughout: mop up all the Doxygen warnings and undocumented
2863 * dbus/dbus-sysdeps.c (do_exec): do not use execvp, we don't want
2864 to search any paths.
2866 * dbus/dbus-threads.c: move global mutex initializers to
2867 dbus-internals.h, multiple prototypes was confusing doxygen
2868 besides being kind of ugly
2870 * Doxyfile (PREDEFINED): have Doxygen define
2871 DOXYGEN_SHOULD_SKIP_THIS so we can exclude things from
2872 docs with #ifndef DOXYGEN_SHOULD_SKIP_THIS
2873 (do not abuse the feature! it's for stuff like the autogenerated
2874 macros in dbus-md5.c, not just for things you don't feel like
2877 2003-02-18 Havoc Pennington <hp@pobox.com>
2879 * dbus/dbus-string.c (_dbus_string_zero): new function
2881 * dbus/dbus-md5.c: include MD5 implementation by L. Peter Deutsch,
2882 wrap it in some dbus-friendly API
2884 * dbus/dbus-types.h: add 16-bit types
2886 2003-02-18 Joe Shaw <joe@assbarn.com>
2888 * dbus/dbus-auth.c (handle_server_data_stupid_test_mech): Just get
2889 credentials from our currently running process.
2890 (get_word): Fix a buglet where we were copying the entire length
2891 instead of relative to our position.
2893 * dbus/dbus-hash.c (_dbus_hash_test): Don't try to allocate the
2894 keys on the stack... it's 640k of data.
2896 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): Always
2897 read the credentials byte off the socket, even if we don't have
2899 (_dbus_poll): Implement poll() using select() for systems which
2902 * glib/test-dbus-glib.c (main): Print out an error if no
2903 parameters are given.
2905 * test/data/auth/fallback.auth-script: Added. Tests that a client
2906 can fallback to a secondary auth mechanism if the first fails.
2908 2003-02-18 Havoc Pennington <hp@pobox.com>
2912 2003-02-17 Havoc Pennington <hp@pobox.com>
2914 * doc/dbus-specification.sgml: lots of cosmetic
2915 cleanups/rearrangement, add assorted FIXME, change DBUS_ADDRESS
2916 env variable to DBUS_BUS_ADDRESS, s/client/application/,
2917 s/server/bus/ (except in authentication section). Add a section
2918 "Message Bus Message Routing"
2920 2003-02-17 Anders Carlsson <andersca@codefactory.se.>
2926 2003-02-17 Anders Carlsson <andersca@codefactory.se>
2928 * doc/dbus-specification.sgml:
2929 Specification updates.
2931 2003-02-17 Anders Carlsson <andersca@codefactory.se>
2933 * bus/activation.c: (bus_activation_init), (child_setup),
2934 (bus_activation_activate_service):
2936 * bus/main.c: (main):
2937 Set DBUS_ADDRESS environment variable.
2939 * dbus/dbus-errors.c: (dbus_set_error):
2940 Don't use va_copy since that's a C99 feature.
2942 * dbus/dbus-sysdeps.c: (_dbus_setenv), (do_exec),
2943 (_dbus_spawn_async):
2944 * dbus/dbus-sysdeps.h:
2945 Add child_setup_func to _dbus_spawn_async.
2947 * doc/dbus-specification.sgml:
2948 Update specification.
2950 * test/spawn-test.c: (setup_func), (main):
2953 2003-02-17 Alexander Larsson <alexl@redhat.com>
2955 * dbus/dbus-connection.c (_dbus_connection_handler_destroyed_locked):
2958 2003-02-17 Anders Carlsson <andersca@codefactory.se>
2962 * doc/dbus-test-plan.sgml:
2963 Add test plan document.
2968 2003-02-17 Anders Carlsson <andersca@codefactory.se>
2970 * dbus/dbus-message.c: (decode_header_data),
2971 (_dbus_message_loader_return_buffer):
2972 Set the header padding amount when loading a message.
2974 2003-02-16 Anders Carlsson <andersca@codefactory.se>
2976 * bus/dispatch.c: (send_one_message):
2977 Only send broadcast messages to registered connections.
2979 * dbus/dbus-message.c: (dbus_message_name_is):
2980 * dbus/dbus-message.h:
2981 New convenience function.
2983 * dbus/dbus-transport-debug.c: (do_reading):
2984 Only dispatch one message per run.
2987 * test/bus-test.c: (new_connection_callback), (die),
2988 (test_hello_client1_handler), (test_hello_client2_handler),
2989 (test_hello_replies), (main):
2991 * test/bus-test-loop.[ch]:
2994 2003-02-16 Havoc Pennington <hp@pobox.com>
2996 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
2997 backward conditional
2999 2003-02-16 Alexander Larsson <alexl@redhat.com>
3001 * dbus/dbus-connection.c:
3002 Implement sent_message_with_reply. (with_reply_and block is still
3004 Made dispatch_message not lose message if OOM.
3006 * dbus/dbus-errors.h:
3007 Add NoReply error (for reply timeouts).
3009 2003-02-16 Alexander Larsson <alexl@redhat.com>
3011 * dbus/dbus-hash.c (_dbus_hash_table_unref):
3012 Actually free keys and values when destroying hashtable.
3014 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3016 * dbus/dbus-auth.c: (client_try_next_mechanism):
3019 * dbus/dbus-threads.c: (dbus_condvar_wait_timeout):
3020 Return TRUE if there's no thread implementation around.
3022 * glib/dbus-gmain.c: (free_source),
3023 (dbus_connection_hookup_with_g_main):
3024 Make sure to remove the GSource when the connection is finalized.
3026 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3028 * bus/dispatch.c: (bus_dispatch_message_handler):
3029 * dbus/dbus-errors.h:
3030 Return an error if someone tries to send a message to a service
3033 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3035 * bus/activation.c: (load_directory), (bus_activation_init),
3036 (bus_activation_activate_service):
3039 (bus_driver_handle_activate_service), (bus_driver_handle_message):
3040 More work on the activation handling.
3042 * dbus/dbus-errors.h:
3043 Add some error messages
3045 * dbus/dbus-message.c: (dbus_message_new_error_reply):
3046 * dbus/dbus-message.h:
3047 New function that creates an error message.
3049 * dbus/dbus-protocol.h:
3050 Add ACTIVATE_SERVER message.
3052 * dbus/dbus-server-unix.c: (unix_handle_watch),
3053 (_dbus_server_new_for_domain_socket):
3054 Call _dbus_fd_set_close_on_exec.
3056 * dbus/dbus-sysdeps.c: (make_pipe), (do_exec),
3057 (_dbus_spawn_async), (_dbus_disable_sigpipe),
3058 (_dbus_fd_set_close_on_exec):
3059 * dbus/dbus-sysdeps.h:
3060 Add _dbus_fd_set_close_on exec function. Also add function that checks
3061 that all open fds are set to close-on-exec and warns otherwise.
3063 * dbus/dbus-transport-unix.c:
3064 (_dbus_transport_new_for_domain_socket):
3065 Call _dbus_fd_set_close_on_exec.
3067 2003-02-16 Havoc Pennington <hp@pobox.com>
3069 * dbus/dbus-connection.c (dbus_connection_set_change_sigpipe):
3070 allow people to avoid setting SIGPIPE to SIG_IGN
3071 (_dbus_connection_new_for_transport): disable SIGPIPE unless
3072 we've been asked not to
3074 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3076 * dbus/dbus-list.c: (_dbus_list_append_link),
3077 (_dbus_list_prepend_link):
3078 * dbus/dbus-memory.c: (dbus_malloc), (dbus_malloc0),
3082 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3085 * bus/activation.c: (bus_activation_entry_free),
3086 (add_desktop_file_entry), (load_directory), (bus_activation_init):
3088 * bus/main.c: (main):
3089 Add simple activation support, doesn't work yet though.
3091 2003-02-15 Zack Rusin <zack@kde.org>
3093 * qt/dbus-qthread.cpp: small casting fix
3095 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3097 * dbus/dbus-errors.c: (dbus_set_error):
3098 * dbus/dbus-errors.h:
3099 Add a few errors and make dbus_set_error void.
3101 * dbus/dbus-sysdeps.c:
3102 (_dbus_errno_to_string), (close_and_invalidate), (make_pipe),
3103 (write_err_and_exit), (read_ints), (do_exec), (_dbus_spawn_async):
3104 * dbus/dbus-sysdeps.h:
3105 Add _dbus_spawn_async.
3107 * test/spawn-test.c: (main):
3108 Test for _dbus_spawn_async.
3110 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3112 * dbus/dbus-internals.h:
3113 Fix build without tests.
3115 * dbus/dbus-list.c: (alloc_link):
3116 Fix a segfault when a malloc fails.
3118 * dbus/dbus-memory.c: (initialize_malloc_debug), (dbus_malloc),
3119 (dbus_malloc0), (dbus_realloc):
3120 Add support for malloc debugging.
3122 2003-02-15 Alexander Larsson <alexl@redhat.com>
3124 * dbus/dbus-threads.c:
3125 * dbus/dbus-threads.h:
3126 Add condvars. Remove static mutext from API.
3127 Implement static mutexes by initializing them from threads_init.
3129 * glib/dbus-gthread.c:
3130 * qt/dbus-qthread.cpp:
3131 Update with the thread api changes.
3136 Turn StaticMutex into normal mutex + init function.
3137 Export new functions _dbus_list_alloc_link, _dbus_list_free_link,
3138 _dbus_list_append_link, _dbus_list_prepend_link
3141 * dbus/dbus-sysdeps.c:
3142 * dbus/dbus-sysdeps.h:
3143 New type dbus_atomic_t, and new functions _dbus_atomic_inc,
3144 _dbus_atomic_dec. Only slow fallback implementation at the moment.
3146 * dbus/dbus-protocol.h:
3147 Add DBUS_MESSAGE_LOCAL_DISCONNECT define
3149 * dbus/dbus-message.c:
3150 Make ref/unref atomic.
3153 * dbus/dbus-connection-internal.h:
3154 * dbus/dbus-connection.c:
3155 * dbus/dbus-connection.h:
3157 Change _peek to _borrow,_return & _steal_borrowed.
3158 Change disconnect callback to event.
3159 Make dbus_connection_dispatch_messages reentrant.
3161 * dbus/dbus-transport.c:
3162 Don't ref the connection on calls to the transport
3165 * dbus/dbus-message-handler.c:
3168 * glib/dbus-gmain.c:
3169 Don't use peek_message anymore
3172 * test/debug-thread.c:
3173 * test/debug-thread.h:
3174 Simple thread implementation that asserts() on deadlocks in
3175 single-threaded code.
3178 (main) Call debug_threads_init.
3181 Use disconnect message instead of disconnect callback.
3185 Don't call dbus_connection_set_disconnect_function. Instead export
3186 bus_connection_disconnect.
3189 Call bus_connection_disconnect when we get a disconnected message.
3191 2003-02-15 Havoc Pennington <hp@pobox.com>
3193 * dbus/dbus-message.c (dbus_message_new): fool around with the
3196 2003-02-14 Havoc Pennington <hp@pobox.com>
3198 * dbus/dbus-mempool.c: fail if the debug functions so indicate
3200 * dbus/dbus-memory.c: fail if the debug functions indicate we
3203 * dbus/dbus-internals.c (_dbus_set_fail_alloc_counter)
3204 (_dbus_decrement_fail_alloc_counter): debug functions to
3205 simulate memory allocation failures
3207 2003-02-14 Havoc Pennington <hp@pobox.com>
3209 * dbus/dbus-errors.h (struct DBusError): add a word of padding
3212 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3214 * bus/driver.c: (bus_driver_handle_hello):
3216 * bus/services.c: (bus_service_lookup):
3217 Reorder message sending so we get a more sane order.
3219 * test/bus-test.c: (message_handler):
3222 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3224 * bus/driver.c: (bus_driver_send_service_deleted),
3225 (bus_driver_send_service_created), (bus_driver_send_service_lost),
3226 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
3227 (bus_driver_send_welcome_message),
3228 (bus_driver_handle_list_services),
3229 (bus_driver_handle_acquire_service),
3230 (bus_driver_handle_service_exists):
3231 * dbus/dbus-bus.c: (dbus_bus_register_client),
3232 (dbus_bus_acquire_service), (dbus_bus_service_exists):
3233 * dbus/dbus-errors.c: (dbus_result_to_string):
3234 * dbus/dbus-errors.h:
3235 * dbus/dbus-message.c: (dbus_message_append_args),
3236 (dbus_message_append_args_valist), (dbus_message_get_args),
3237 (dbus_message_get_args_valist), (dbus_message_get_args_iter),
3238 (dbus_message_iter_get_arg_type), (dbus_message_iter_get_string),
3239 (dbus_message_iter_get_byte_array),
3240 (dbus_message_iter_get_string_array), (message_iter_test),
3241 (check_message_handling), (_dbus_message_test):
3242 * dbus/dbus-message.h:
3243 * test/bus-test.c: (main):
3244 Change fields to arguments in messages, so that they won't be
3245 confused with header fields.
3247 * glib/test-dbus-glib.c: (main):
3248 Remove append_fields from hello message.
3250 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3252 * dbus/dbus-errors.c:
3253 * dbus/dbus-message.c:
3254 * dbus/dbus-string.c:
3255 Documentation fixes.
3257 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3259 * glib/dbus-gmain.c: (timeout_handler), (add_timeout),
3261 Implement support for timeouts in dbus-glib.
3263 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3265 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
3266 * dbus/dbus-message.c: (process_test_subdir):
3267 * test/break-loader.c: (find_breaks_based_on):
3268 Plug some memory leaks.
3270 2003-02-13 Richard Hult <rhult@codefactory.se>
3272 * bus/main.c: Fix build.
3274 * dbus/dbus-errors.h:
3275 * dbus/dbus-errors.c: Fix copyright for Anders.
3277 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3282 * bus/connection.c: (bus_connection_foreach):
3285 * bus/desktop-file.c: (grow_lines_in_section), (grow_sections),
3286 (unescape_string), (new_section), (parse_section_start),
3287 (parse_key_value), (report_error), (bus_desktop_file_load),
3288 (bus_desktop_file_get_string):
3289 * bus/desktop-file.h:
3290 Use DBusError for error reporting.
3292 * bus/dispatch.c: (send_one_message),
3293 (bus_dispatch_message_handler):
3294 * bus/driver.c: (bus_driver_send_service_deleted),
3295 (bus_driver_send_service_created), (bus_driver_send_service_lost),
3296 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
3297 (bus_driver_send_welcome_message),
3298 (bus_driver_handle_list_services),
3299 (bus_driver_handle_acquire_service),
3300 (bus_driver_handle_service_exists):
3301 * bus/loop.c: (bus_loop_run):
3303 Use BUS_HANDLE_OOM instead of _DBUS_HANDLE_OOM.
3305 * bus/utils.c: (bus_wait_for_memory):
3307 New files with general utility functions.
3309 * dbus/dbus-internals.h:
3310 Remove _DBUS_HANDLE_OOM.
3312 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3314 * dbus/dbus-errors.c: (dbus_result_to_string), (dbus_error_init),
3315 (dbus_error_free), (dbus_set_error_const), (dbus_set_error):
3316 * dbus/dbus-errors.h:
3317 Add DBusError structure.
3319 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3321 * test/data/valid-messages/standard-acquire-service.message:
3322 * test/data/valid-messages/standard-hello.message:
3323 * test/data/valid-messages/standard-list-services.message:
3324 * test/data/valid-messages/standard-service-exists.message:
3325 Add some standard messages.
3327 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3329 * bus/driver.c: (bus_driver_send_welcome_message),
3330 (bus_driver_handle_list_services),
3331 (bus_driver_handle_acquire_service),
3332 (bus_driver_handle_service_exists), (bus_driver_handle_message):
3333 Update for API changes in libdbus.
3335 * dbus/dbus-message.c: (dbus_message_new_reply):
3336 * dbus/dbus-message.h:
3337 Remove the name argument. The spec states that replies shouldn't
3340 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3342 * bus/desktop-file.c: (parse_section_start), (parse_key_value),
3343 (report_error), (bus_desktop_file_load), (lookup_section),
3344 (lookup_line), (bus_desktop_file_get_raw),
3345 (bus_desktop_file_get_string):
3346 * bus/desktop-file.h:
3347 Some fixes, and new functions for getting a key value from a section.
3349 2003-02-13 Havoc Pennington <hp@pobox.com>
3351 * test/data/auth/fail-after-n-attempts.auth-script: new test
3353 * dbus/dbus-auth.c (send_rejected): shutdown_mech() when we
3356 2003-02-13 Havoc Pennington <hp@pobox.com>
3358 * dbus/dbus-auth.c (handle_server_data_external_mech): args to
3359 dbus_credentials_match were backward
3361 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support
3362 NO_CREDENTIALS and ROOT_CREDENTIALS
3364 * dbus/dbus-auth.c (_dbus_auth_do_work): move get_state() routine
3365 into here. Never process more commands after we've reached an
3366 end state; store further data as unused bytes.
3368 * test/data/auth/*: add more auth tests
3370 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support EXPECT
3371 command to match exact string and EXPECT_UNUSED to match unused
3374 * test/Makefile.am (dist-hook): fix to dist all the test stuff
3376 2003-02-12 Havoc Pennington <hp@pobox.com>
3378 * dbus/dbus-string.c (_dbus_string_pop_line): fix to also strip
3379 \r off of popped lines
3381 * dbus/dbus-auth.c (_dbus_auth_test): write code to run auth
3384 * dbus/dbus-auth-script.c (_dbus_auth_script_run): when doing a
3387 2003-02-12 Havoc Pennington <hp@pobox.com>
3389 * dbus/Makefile.am: remove break-loader from the build, since it
3392 * configure.in: add --enable-gcov to turn on coverage profiling
3393 flags and disable optimization
3395 2003-02-10 Havoc Pennington <hp@pobox.com>
3397 * dbus/dbus-auth-script.c, dbus/dbus-auth-script.h: sync
3398 initial cut at test framework for DBusAuth from laptop.
3399 Doesn't quite work yet but it compiles and I need to get
3400 it off the 266mhz laptop. ;-)
3402 * dbus/dbus-server-debug.c (_dbus_server_debug_accept_transport):
3403 fix a memleak in error case
3405 2003-02-12 Anders Carlsson <andersca@codefactory.se>
3408 * bus/desktop-file.c:
3409 * bus/desktop-file.h:
3410 Add a desktop file parser.
3412 2003-02-11 Zack Rusin <zack@kde.org>
3414 * qt/message.[h|cpp]: sample implementation
3415 of the KDE wrapper for DBusMessage
3417 2003-02-09 Zack Rusin <zack@kde.org>
3419 * test/bus-test.c: make_it_compile
3420 * doc/dbus-specification.sgml: minimal semantic fix
3422 2003-02-06 Anders Carlsson <andersca@codefactory.se>
3428 2003-02-06 Anders Carlsson <andersca@codefactory.se>
3431 * dbus/dbus-break-loader.c:
3433 * test/break-loader.c:
3434 Move dbus-break-loader to test/ and rename it to break-loader.
3436 2003-02-02 Havoc Pennington <hp@pobox.com>
3438 * dbus/dbus-keyring.c, dbus/dbus-keyring.h: template files
3439 for code to manage cookies in your home directory
3441 * dbus/dbus-sysdeps.c (_dbus_generate_random_bytes): new function
3443 * dbus/dbus-auth.c (get_state): impose a maximum number of tries
3444 to authenticate, then disconnect the client.
3446 2003-02-03 Alexander Larsson <alexl@redhat.com>
3448 * dbus/dbus-message.c (dbus_message_append_fields):
3451 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3453 * doc/dbus-specification.sgml:
3454 Update address format section.
3456 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3459 * test/bus-test.c: (get_time), (add_timeout), (remove_timeout),
3460 (message_handler), (new_connection_callback), (loop_quit),
3464 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3466 * bus/driver.c: (bus_driver_handle_service_exists):
3467 Simplify the code a bit.
3469 * dbus/dbus-bus.c: (dbus_bus_service_exists):
3472 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3475 Add libdbus-daemon.la and link to it.
3477 2003-02-01 James Willcox <jwillcox@gnome.org>
3479 * bus/driver.c: (bus_driver_handle_own_service):
3480 Actually include the service reply code in the message.
3482 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3484 * bus/driver.c: (bus_driver_handle_service_exists):
3485 Don't unref the incoming message.
3487 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3489 * dbus/dbus.h: Add dbus-address.h and dbus-bus.h
3491 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3493 * dbus/dbus-server.c: (dbus_server_listen):
3494 * dbus/dbus-transport.c: (_dbus_transport_open):
3495 ifdef out the calls to the debug transport and server.
3497 2003-02-02 Alexander Larsson <alexl@redhat.com>
3499 * dbus/dbus-watch.c (dbus_watch_get_flags):
3500 Add note in the docs that ERROR or HANGUP won't be returned
3501 and are assumed always on.
3503 * glib/dbus-gmain.c (add_watch):
3504 Always add IO_ERR | IO_HUP
3506 * dbus/dbus-message.h:
3507 Add semicolon after dbus_message_iter_get_string_array().
3508 Makes qt code build again
3510 2003-02-01 Anders Carlsson <andersca@codefactory.se>
3512 * bus/driver.c: (create_unique_client_name),
3513 (bus_driver_handle_hello):
3514 Don't take a name, just use a numeric id to identify
3518 * dbus/dbus-bus.c: (dbus_bus_register_client),
3519 (dbus_bus_acquire_service), (dbus_bus_service_exists):
3521 Add new convenience functions for communicating with the bus.
3523 * dbus/dbus-message.h:
3525 * dbus/dbus-protocol.h:
3528 2003-02-01 Alexander Larsson <alexl@redhat.com>
3530 * dbus/dbus-message.c (dbus_message_append_fields):
3531 Add some more doc comments.
3533 2003-02-01 Havoc Pennington <hp@pobox.com>
3535 * dbus/dbus-break-loader.c (randomly_modify_length): change
3536 a 4-byte value in the message as if it were a length
3538 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): don't set
3539 execute bit on saved files
3541 2003-02-01 Havoc Pennington <hp@pobox.com>
3543 * dbus/dbus-break-loader.c (main): new program to find messages
3544 that break the loader.
3546 * dbus/dbus-sysdeps.c (_dbus_string_append_uint): new function
3547 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): new function
3549 * dbus/dbus-string.c (_dbus_string_set_byte): new
3551 2003-01-31 Havoc Pennington <hp@pobox.com>
3553 * dbus/dbus-message.c: refactor the test code to be more general,
3554 in preparation for writing a "randomly permute test cases to
3555 try to break the loader" program.
3557 2003-01-31 Havoc Pennington <hp@pobox.com>
3559 * doc/dbus-specification.sgml: work on the specification
3561 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): check
3562 the protocol version of the message.
3564 * dbus/dbus-protocol.h: drop special _REPLY names, the spec
3565 no longer specifies that.
3566 (DBUS_SERVICE_REPLY_SERVICE_EXISTS): fix flags (1/2/4/8 not
3569 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos): add missing
3570 "break" for DBUS_TYPE_NIL, remove @todo
3572 2003-01-31 Havoc Pennington <hp@pobox.com>
3574 * dbus/dbus-message.c (dbus_message_set_is_error_reply): rename
3575 just set_is_error/get_is_error as this is a commonly-used
3576 function, and write docs.
3578 2003-01-31 Anders Carlsson <andersca@codefactory.se>
3580 * dbus/dbus-address.c: (dbus_address_entry_free):
3581 Free key and value lists.
3583 * dbus/dbus-internals.c: (_dbus_type_to_string):
3584 Add the types we didn't have.
3586 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
3587 (_dbus_marshal_validate_arg):
3590 * dbus/dbus-message.c: (dbus_message_set_sender):
3591 Remove todo about being able to set sender to NULL.
3593 (dbus_message_set_is_error_reply),
3594 (dbus_message_get_is_error_reply):
3595 * dbus/dbus-message.h:
3598 * dbus/dbus-protocol.h:
3599 Add error reply flag.
3601 * test/data/valid-messages/opposite-endian.message:
3602 Add NIL type to test.
3604 2003-01-31 Havoc Pennington <hp@pobox.com>
3606 * doc/dbus-specification.sgml: fully specify the header. Add
3607 flags and major protocol version, and change header/body len to
3610 * dbus/dbus-message-builder.c (append_saved_length): append length
3613 * dbus/dbus-message.c (dbus_message_create_header): change header
3614 length and body length to unsigned. Add the new fields from the
3616 (_dbus_message_loader_return_buffer): unsigned header/body len
3618 2003-01-30 Havoc Pennington <hp@pobox.com>
3620 * dbus/dbus-auth.c: rework to use only REJECTED, no
3623 * doc/dbus-sasl-profile.txt: drop MECHANISMS and just
3624 use REJECTED, suggested by Mark McLoughlin
3626 2003-01-30 Havoc Pennington <hp@pobox.com>
3628 * dbus/dbus-server.c (dbus_server_listen): @todo about how we need
3629 a better way to report errors here. e.g. "unix address lacks
3630 path" or something. also "no such file" when the path doesn't
3633 * dbus/dbus-address.c (dbus_address_entries_free): add @todo about
3635 (dbus_parse_address): add @todo about documenting address format,
3636 and allowing , and ; to be escaped
3638 2003-01-30 Anders Carlsson <andersca@codefactory.se>
3641 Add dbus-address.[ch]
3643 * dbus/dbus-address.c: (dbus_address_entry_free),
3644 (dbus_address_entries_free), (create_entry),
3645 (dbus_address_entry_get_method), (dbus_address_entry_get_value),
3646 (dbus_parse_address), (_dbus_address_test):
3647 * dbus/dbus-address.h:
3648 New files for dealing with address parsing.
3650 * dbus/dbus-connection.c:
3651 Document timeout functions.
3653 * dbus/dbus-message.c:
3654 Document dbus_message_new_from_message.
3656 * dbus/dbus-server-debug.c:
3659 * dbus/dbus-server.c: (dbus_server_listen):
3660 Parse address and use correct server implementation.
3662 * dbus/dbus-string.c: (_dbus_string_find_to), (_dbus_string_test):
3663 * dbus/dbus-string.h:
3664 New function with test.
3666 * dbus/dbus-test.c: (dbus_internal_symbol_do_not_use_run_tests):
3670 * dbus/dbus-transport-debug.c:
3673 * dbus/dbus-transport.c: (_dbus_transport_open):
3674 Parse address and use correct transport implementation.
3676 2003-01-30 Havoc Pennington <hp@pobox.com>
3678 * dbus/dbus-message.c: use message->byte_order instead of
3679 DBUS_COMPILER_BYTE_ORDER throughout.
3680 (dbus_message_create_header): pad header to align the
3681 start of the body of the message to 8-byte boundary
3683 * dbus/dbus-marshal.h: make all the demarshalers take const
3684 DBusString arguments.
3686 * dbus/dbus-message.c (_dbus_message_loader_return_buffer):
3687 validate message args here, so we don't have to do slow validation
3688 later, and so we catch bad messages as they are incoming. Also add
3689 better checks on header_len and body_len. Also fill in
3692 * dbus/dbus-string.c (_dbus_string_validate_utf8): new (not
3693 implemented properly)
3694 (_dbus_string_validate_nul): new function to check all-nul
3696 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): rename
3697 get_arg_end_pos and remove all validation
3698 (_dbus_marshal_validate_arg): actually do validation here.
3700 2003-01-29 Havoc Pennington <hp@pobox.com>
3702 * dbus/dbus-message.c (check_message_handling): fix assertion
3703 failure on set_client_serial
3705 2003-01-28 Havoc Pennington <hp@pobox.com>
3707 * dbus/dbus-server-debug.c: Add doc section comments
3709 * dbus/dbus-transport-debug.c: add doc section comments
3711 2003-01-28 Havoc Pennington <hp@redhat.com>
3713 * dbus/dbus-string.c (_dbus_string_base64_decode): append bytes in
3714 the reverse order from how I had it
3715 (_dbus_string_base64_encode): reverse encoding order. I was
3716 basically byteswapping everything during encoding.
3718 2003-01-28 Anders Carlsson <andersca@codefactory.se>
3720 * dbus/dbus-connection-internal.h:
3721 * dbus/dbus-connection.c: (_dbus_connection_add_timeout),
3722 (_dbus_connection_remove_timeout):
3723 Add functions for adding and removing timeouts.
3725 * dbus/dbus-message.c: (dbus_message_new_from_message):
3726 Add new function that takes a message and creates an exact
3727 copy of it, but with the refcount set to 1.
3728 (check_message_handling):
3731 * dbus/dbus-server-protected.h:
3732 * dbus/dbus-server.c: (_dbus_server_init_base),
3733 (_dbus_server_finalize_base), (_dbus_server_add_timeout),
3734 (dbus_server_set_timeout_functions):
3735 (_dbus_server_remove_timeout):
3736 New functions so that a server can add and remove timeouts.
3738 (dbus_server_listen):
3739 Add commented out call to dbus_server_debug_new.
3741 * dbus/dbus-timeout.c: (_dbus_timeout_new):
3742 Actually set the handler, doh.
3744 * dbus/dbus-transport.c: (_dbus_transport_open):
3745 Add commented out call to dbus_transport_debug_client_new.
3748 Add dbus-transport-debug.[ch] and dbus-server-debug.[ch]
3750 2003-01-28 Havoc Pennington <hp@pobox.com>
3752 * dbus/dbus-message.c (check_message_handling): function to check
3753 on the loaded message, iterates over it etc.
3755 2003-01-28 Havoc Pennington <hp@pobox.com>
3757 * test/Makefile.am (dist-hook): fix make distdir
3759 * dbus/Makefile.am (TESTS_ENVIRONMENT): fix make check
3761 2003-01-27 Havoc Pennington <hp@pobox.com>
3763 * dbus/dbus-mempool.c (time_for_size): replace printf with
3766 * dbus/dbus-message-builder.c (_dbus_message_data_load): allow
3767 empty lines; fix the SAVE_LENGTH stuff to be
3768 START_LENGTH/END_LENGTH so it actually works; couple other
3771 * test/Makefile.am (dist-hook): add dist-hook for .message files
3773 * dbus/dbus-string.c (DBUS_STRING_COPY_PREAMBLE): source of a copy
3774 can be constant or locked.
3775 (_dbus_string_free): allow freeing a const string as
3778 * dbus/dbus-sysdeps.c (_dbus_concat_dir_and_file): utility
3780 * dbus/dbus-test-main.c (main): take an argument which is the
3781 directory containing test data
3783 * dbus/dbus-message.c (_dbus_message_test): pass a test_data_dir
3784 argument to this and load all the messages in test/data/
3785 checking that they can be loaded or not loaded as appropriate.
3787 2003-01-27 Anders Carlsson <andersca@codefactory.se>
3789 * bus/dispatch.c: (bus_dispatch_message_handler):
3790 Dispatch messages sent to services.
3792 * bus/driver.c: (bus_driver_send_service_deleted),
3793 (bus_driver_send_service_created), (bus_driver_send_service_lost),
3794 (bus_driver_send_service_acquired):
3795 Add helper functions for sending service related messages.
3797 (bus_driver_send_welcome_message):
3798 Send HELLO_REPLY instead of WELCOME.
3800 (bus_driver_handle_list_services):
3801 Send LIST_SERVICES_REPLY instead of SERVICES.
3803 (bus_driver_handle_own_service),
3804 (bus_driver_handle_service_exists):
3805 New message handlers.
3807 (bus_driver_handle_message):
3808 Invoke new message handlers.
3810 (bus_driver_remove_connection):
3811 Don't remove any services here since that's done automatically
3812 by bus_service_remove_owner now.
3815 New function signatures.
3817 * bus/services.c: (bus_service_add_owner):
3818 Send ServiceAcquired message if we're the only primary owner.
3820 (bus_service_remove_owner):
3821 Send ServiceAcquired/ServiceLost messages.
3823 (bus_service_set_prohibit_replacement),
3824 (bus_service_get_prohibit_replacement):
3825 Functions for setting prohibit replacement.
3827 (bus_service_has_owner):
3828 New function that checks if a connection is in the owner queue of
3832 Add new function signatures.
3834 * dbus/dbus-list.c: (_dbus_list_test):
3835 Add tests for _dbus_list_remove_last and traversing the list backwards.
3838 Fix a typo in _dbus_list_get_prev_link, if we're at the first element we can't
3839 go any further, so return NULL then.
3841 * dbus/dbus-protocol.h:
3842 Add new messages, service flags and service replies.
3844 2003-01-26 Havoc Pennington <hp@pobox.com>
3846 * dbus/dbus-message-builder.c: implement, completely untested.
3848 * test/data/*: add data to be used in testing.
3849 ".message" files are our simple loadable text format.
3850 ".message-raw" will be binary dumps of messages.
3852 * dbus/dbus-string.c (_dbus_string_starts_with_c_str): new
3854 2003-01-26 Havoc Pennington <hp@pobox.com>
3856 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): new function
3858 * dbus/dbus-errors.c (dbus_result_to_string): add
3861 * dbus/dbus-message-builder.c: new file, will contain code to load
3862 up messages from files. Not implemented yet.
3864 2003-01-26 Havoc Pennington <hp@pobox.com>
3866 * dbus/dbus-message.c (dbus_message_set_sender): support deleting
3867 the sender by setting to NULL
3869 2003-01-26 Havoc Pennington <hp@pobox.com>
3871 The unit tests pass, but otherwise untested. If it breaks, the
3872 tests should have been better. ;-)
3874 * bus/driver.c (bus_driver_handle_hello): return if we disconnect
3877 * dbus/dbus-message.c: redo everything so we maintain
3878 message->header as the only copy of the various fields.
3879 This avoids the possibility of out-of-memory in some cases,
3880 for example dbus_message_lock() can't run out of memory anymore,
3881 and avoids extra copying. Figured I may as well go ahead and do
3882 this since it was busted for dbus_message_lock to not return
3883 failure on OOM, and dbus_message_write_header was totally
3884 unchecked for OOM. Also fixed some random other bugs.
3886 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): verify
3887 that strings are nul-terminated. Also, end_pos can be equal
3888 to string length just not greater than, I think.
3889 (_dbus_marshal_set_int32): new function
3890 (_dbus_marshal_set_uint32): new function
3891 (_dbus_marshal_set_string): new function
3893 * dbus/dbus-connection.c (_dbus_connection_new_for_transport): fix
3894 a warning, init timeout_list to NULL
3895 (dbus_connection_send_message): don't use uninitialized variable
3898 * dbus/dbus-string.c (_dbus_string_replace_len): new function
3900 2003-01-26 Anders Carlsson <andersca@codefactory.se>
3902 * bus/driver.c: (bus_driver_handle_hello),
3903 (bus_driver_send_welcome_message):
3906 2003-01-26 Anders Carlsson <andersca@codefactory.se>
3908 * dbus/dbus-auth.c: (process_auth), (_dbus_auth_unref):
3909 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
3910 (dbus_connection_unref):
3911 * dbus/dbus-marshal.c: (_dbus_marshal_test):
3912 * dbus/dbus-message.c: (dbus_message_unref),
3915 (dbus_message_get_fields):
3916 Remove debugging printout.
3918 (_dbus_message_loader_return_buffer):
3919 Don't store the header string.
3921 (_dbus_message_test):
3924 2003-01-26 Richard Hult <rhult@codefactory.se>
3926 * glib/dbus-gmain.c (dbus_connection_dispatch): Traverse a copy of
3927 the file descriptor list, since it can change under us.
3929 2003-01-25 Anders Carlsson <andersca@codefactory.se>
3931 * glib/dbus-gmain.c: (dbus_connection_prepare),
3932 (dbus_connection_check), (dbus_connection_dispatch), (add_watch),
3933 (remove_watch), (dbus_connection_hookup_with_g_main):
3934 Rewrite the glib handling to use its own GSource instead of a
3935 GIOChannel so we can catch messages put in the queue while waiting
3938 2003-01-25 Anders Carlsson <andersca@codefactory.se>
3941 * bus/connection.c: (connection_disconnect_handler),
3942 (connection_watch_callback), (bus_connection_setup):
3943 * bus/dispatch.c: (send_one_message),
3944 (bus_dispatch_broadcast_message), (bus_dispatch_message_handler),
3945 (bus_dispatch_add_connection), (bus_dispatch_remove_connection):
3947 * bus/driver.c: (bus_driver_send_service_deleted),
3948 (bus_driver_send_service_created), (bus_driver_handle_hello),
3949 (bus_driver_send_welcome_message),
3950 (bus_driver_handle_list_services), (bus_driver_remove_connection),
3951 (bus_driver_handle_message):
3953 Refactor code, put the message dispatching in its own file. Use
3954 _DBUS_HANDLE_OOM. Also send ServiceDeleted messages when a client
3957 2003-01-25 Anders Carlsson <andersca@codefactory.se>
3959 * dbus/dbus-internals.h:
3960 Add _DBUS_HANDLE_OOM macro, it doesn't do anything currently.
3962 * dbus/dbus-message.c: (dbus_message_get_sender):
3963 * dbus/dbus-message.h:
3964 Implement dbus_message_get_sender.
3966 * dbus/dbus-protocol.h:
3967 Add message and service defines.
3969 2003-01-25 Anders Carlsson <andersca@codefactory.se>
3971 * dbus/dbus-connection.c: (dbus_connection_send_message):
3972 * dbus/dbus-message-internal.h:
3973 * dbus/dbus-message.c: (_dbus_message_get_client_serial),
3974 (dbus_message_write_header):
3975 Remove _dbus_messag_unlock and don't set the client serial on a
3976 message if one already exists.
3978 2003-01-24 Havoc Pennington <hp@pobox.com>
3980 * dbus/dbus-list.c (alloc_link): put a thread lock on the global
3983 * bus/driver.c (bus_driver_handle_list_services): fix a leak
3986 2003-01-25 Anders Carlsson <andersca@codefactory.se>
3988 * dbus/dbus-list.c: (alloc_link), (free_link):
3989 Use a memory pool for the links.
3991 2003-01-25 Anders Carlsson <andersca@codefactory.se>
3993 * bus/connection.c: (bus_connection_foreach):
3995 Add new bus_connection_foreach function.
3997 * bus/driver.c: (send_one_message), (bus_driver_broadcast_message):
3998 Add function that broadcasts a message to all clients.
4000 (bus_driver_send_service_created), (bus_driver_handle_hello),
4001 (bus_driver_send_welcome_message),
4002 (bus_driver_handle_list_services), (bus_driver_message_handler):
4003 Implement functions that take care of listing services, and notifying
4004 clients when new services are created.
4006 * bus/services.c: (bus_services_list):
4008 Add new function that returns an array of strings with the currently
4009 registered services.
4012 * glib/dbus-gmain.c:
4013 Update copyright year.
4015 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4017 * dbus/dbus-connection.c: (dbus_connection_send_message):
4018 Unlock the message in case it was sent earlier.
4020 (dbus_connection_send_message_with_reply_and_block):
4021 Remove the reply message from the list.
4023 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
4024 Set array_len and new_pos correctly.
4026 (_dbus_marshal_test):
4027 Remove debug output.
4029 * dbus/dbus-message-internal.h:
4030 * dbus/dbus-message.c: (_dbus_message_get_reply_serial):
4031 New function that returns the reply serial.
4033 (_dbus_message_unlock):
4034 New function that unlocks a message and resets its header.
4036 (dbus_message_append_string_array),
4037 (dbus_message_get_fields_valist),
4038 (dbus_message_iter_get_field_type),
4039 (dbus_message_iter_get_string_array),
4040 (dbus_message_get_fields),
4041 (dbus_message_append_fields_valist):
4042 Handle string arrays.
4044 (dbus_message_set_sender):
4045 Make this function public since the bus daemon needs it.
4047 (decode_header_data):
4048 Set the reply serial to -1 initially.
4050 * dbus/dbus-message.h:
4051 Add dbus_message_set_sender.
4053 2003-01-24 Havoc Pennington <hp@pobox.com>
4055 * doc/dbus-specification.sgml: add some stuff
4057 2003-01-22 Havoc Pennington <hp@pobox.com>
4059 * doc/dbus-specification.sgml: Start to document the protocol.
4061 2003-01-22 Havoc Pennington <hp@pobox.com>
4063 * dbus/dbus-connection.c
4064 (dbus_connection_send_message_with_reply_and_block): add some @todo
4066 * bus/driver.c (bus_driver_add_connection): add a FIXME about memleak
4068 2003-01-21 Havoc Pennington <hp@pobox.com>
4070 (patch untested because can't compile)
4072 * bus/driver.c (create_unique_client_name): make this function
4073 never recycle client names. Also, caller should initialize
4076 * dbus/dbus-sysdeps.c (_dbus_get_current_time): new function
4078 2003-01-21 Anders Carlsson <andersca@codefactory.se>
4080 * dbus/dbus-marshal.c: (_dbus_marshal_double),
4081 (_dbus_marshal_int32), (_dbus_marshal_uint32),
4082 (_dbus_marshal_int32_array), (_dbus_marshal_uint32_array),
4083 (_dbus_marshal_double_array), (_dbus_marshal_string_array),
4084 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
4085 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
4086 (_dbus_marshal_get_field_end_pos), (_dbus_marshal_test):
4087 * dbus/dbus-marshal.h:
4088 * dbus/dbus-protocol.h:
4089 Add support for marshalling and demarshalling integer, double
4092 2003-01-21 Anders Carlsson <andersca@codefactory.se>
4097 * bus/connection.c: (connection_disconnect_handler):
4098 Remove the connection from the bus driver's list.
4100 (connection_watch_callback): Dispatch messages.
4102 (free_connection_data): Free connection name.
4104 (bus_connection_setup): Add connection to the bus driver's list.
4105 (bus_connection_remove_owned_service):
4106 (bus_connection_set_name), (bus_connection_get_name):
4107 Add functions for setting and getting the connection's name.
4110 Add function headers.
4112 * bus/driver.c: (create_unique_client_name),
4113 (bus_driver_handle_hello_message),
4114 (bus_driver_send_welcome_message), (bus_driver_message_handler),
4115 (bus_driver_add_connection), (bus_driver_remove_connection):
4118 * bus/services.c: (bus_service_free):
4120 New file that handles communication and registreation with the bus
4123 2003-01-21 Anders Carlsson <andersca@codefactory.se>
4125 * dbus/dbus-connection.c: (dbus_connection_send_message):
4126 Add a new client_serial parameter.
4128 (dbus_connection_send_message_with_reply):
4129 Remove a @todo since we've implemented the blocking function.
4131 (dbus_connection_send_message_with_reply_and_block):
4132 New function that sends a message and waits for a reply and
4133 then returns the reply.
4135 * dbus/dbus-connection.h:
4138 * dbus/dbus-errors.c: (dbus_result_to_string):
4139 * dbus/dbus-errors.h:
4140 Add new DBUS_RESULT.
4142 * dbus/dbus-message-internal.h:
4143 * dbus/dbus-message.c: (_dbus_message_get_reply_serial),
4144 (_dbus_message_set_sender), (dbus_message_write_header),
4145 (dbus_message_new_reply), (decode_header_data),
4146 (_dbus_message_loader_return_buffer), (_dbus_message_test):
4147 * dbus/dbus-message.h:
4148 Add new functions that set the reply serial and sender.
4149 Also marshal and demarshal them correctly and add test.
4151 * dbus/dbus-protocol.h:
4152 Add new DBUS_MESSAGE_TYPE_SENDER.
4155 * glib/dbus-gmain.c: (watch_callback), (free_callback_data),
4156 (add_watch), (remove_watch), (add_timeout), (remove_timeout),
4157 (dbus_connection_hookup_with_g_main):
4158 * glib/test-dbus-glib.c: (main):
4159 Rewrite to use GIOChannel and remove the GSource crack.
4161 * test/echo-client.c: (main):
4162 * test/watch.c: (check_messages):
4163 Update for changed APIs
4165 2003-01-19 Anders Carlsson <andersca@codefactory.se>
4167 * dbus/Makefile.am: Add dbus-timeout.[cħ]
4169 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport):
4170 Create a DBusTimeoutList.
4171 (dbus_connection_set_timeout_functions): Add new function to
4172 set timeout callbacks
4174 * dbus/dbus-connection.h: Add public DBusTimeout API.
4176 * dbus/dbus-message.c: (dbus_message_get_service):
4177 * dbus/dbus-message.h: New function.
4179 * dbus/dbus-server.c: Fix small doc typo.
4181 * dbus/dbus-timeout.[ch]: New files for mainloop timeouts.
4183 2003-01-19 Anders Carlsson <andersca@codefactory.se>
4185 * dbus/dbus-string.c (_dbus_string_move_len): Don't delete all
4186 of the string, just as long as specified.
4188 2003-01-19 Havoc Pennington <hp@pobox.com>
4190 * dbus/dbus-connection.c (dbus_connection_get_is_authenticated):
4193 * dbus/dbus-server.c (dbus_server_set_max_connections)
4194 (dbus_server_get_max_connections, dbus_server_get_n_connections):
4195 keep track of current number of connections, and add API for
4196 setting a max (but haven't implemented enforcing the max yet)
4198 2003-01-18 Havoc Pennington <hp@pobox.com>
4200 * dbus/dbus-transport-unix.c (unix_do_iteration): only do the
4201 reading/writing if read_watch != NULL or write_watch != NULL.
4203 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): fix
4204 the message loader code to actually load message->header and
4205 message->body into the newly-created message.
4207 * dbus/dbus-transport-unix.c (check_write_watch): fix a mem leak
4210 * dbus/dbus-connection.c (dbus_connection_set_max_message_size)
4211 (dbus_connection_get_max_message_size)
4212 (dbus_connection_set_max_live_messages_size)
4213 (dbus_connection_get_max_live_messages_size): implement some
4214 resource limitation functions
4216 * dbus/dbus-resources.c: new file implementing some of the
4217 resource limits stuff
4219 * dbus/dbus-message.c (dbus_message_iter_get_byte_array): add
4220 missing docs, add @todo to handle OOM etc.
4222 * dbus/dbus-marshal.c (_dbus_demarshal_byte_array): add missing
4225 2003-01-18 Havoc Pennington <hp@pobox.com>
4227 * dbus/dbus-connection.c (dbus_connection_unref): disconnect the
4228 connection if it hasn't been already.
4230 * dbus/dbus-connection.h: kill off the idea of an ErrorFunction,
4231 replace with DisconnectFunction.
4233 2003-01-18 Havoc Pennington <hp@pobox.com>
4235 Building --disable-verbose-mode --disable-asserts --disable-tests
4236 cuts the library from 112K to 45K or so
4238 * configure.in: check for varargs macro support,
4239 add --enable-verbose-mode, --enable-asserts.
4241 * dbus/dbus-internals.h (_dbus_assert): support
4243 (_dbus_verbose): support DBUS_ENABLE_VERBOSE_MODE
4245 2003-01-18 Havoc Pennington <hp@pobox.com>
4247 * dbus/dbus-test.c: include config.h so that tests actually run
4249 * dbus/dbus-string.c: add assertions that stuff is 8-byte aligned,
4250 so the failure mode when that assumption fails will be plenty
4253 2003-01-18 Havoc Pennington <hp@pobox.com>
4255 * configure.in: default --enable-tests to $USE_MAINTAINER_MODE
4257 * dbus/Makefile.am: fix it up so dubs-test-main.c is included in
4260 * test/Makefile.am: don't use special variable "TESTS" for echo-*
4261 since we don't want to use those in make check
4263 2003-01-15 Havoc Pennington <hp@redhat.com>
4269 2003-01-15 Havoc Pennington <hp@redhat.com>
4271 * test/Makefile.am: fix so that test source code ends up in the
4272 distribution on make distcheck
4274 2003-01-15 Havoc Pennington <hp@redhat.com>
4280 2003-01-15 Havoc Pennington <hp@redhat.com>
4282 * dbus/dbus-test.c (dbus_internal_symbol_do_not_use_run_tests):
4283 fix build when --disable-tests
4285 * Makefile.am (EXTRA_DIST): put HACKING in here
4287 * HACKING: document procedure for making a tarball release.
4289 2003-01-14 Anders Carlsson <andersca@codefactory.se>
4291 * bus/connection.c: (connection_error_handler),
4292 (bus_connection_setup):
4293 * bus/main.c: (main):
4294 Make sure that the DBusConnectionData struct is NULLed
4295 out to prevent a segfault.
4297 * dbus/dbus-errors.c: (dbus_result_to_string):
4298 * dbus/dbus-errors.h:
4299 * dbus/dbus-message.c: (dbus_message_get_fields),
4300 (dbus_message_get_fields_valist), (_dbus_message_test):
4301 * dbus/dbus-message.h:
4302 Make dbus_message_get_fields return a result code so we can
4303 track invalid fields as well as oom.
4305 2003-01-11 Havoc Pennington <hp@pobox.com>
4307 * configure.in: change --enable-test/--enable-ansi action-if-given
4308 to enable_foo=$enableval instead of enable_foo=yes
4310 2003-01-08 Havoc Pennington <hp@pobox.com>
4312 * dbus/dbus-string.c (_dbus_string_align_length): new function
4314 * dbus/dbus-test-main.c: move main() for test app here
4316 (dbus_internal_symbol_do_not_use_run_tests): we have to export a
4317 symbol to run tests, because dbus-test isn't in the main
4320 Code review nitpicks.
4322 * dbus/dbus-message.c (dbus_message_write_header): add newlines
4323 for people with narrow emacs ;-). Assert client_serial was filled
4324 in. Assert message->name != NULL.
4325 (dbus_message_append_fields): have "first_field_type" arg separate
4326 from va list, needed for C++ binding that also uses varargs IIRC
4327 and helps with type safety
4328 (dbus_message_new): add @todo about using DBusString to store
4329 service/name internally
4330 (dbus_message_new): don't leak ->service and ->name on OOM later
4332 (dbus_message_unref): free the service name
4333 (dbus_message_get_fields): same change to varargs
4334 i.e. first_field_type
4335 (_dbus_message_loader_return_buffer): assert that the message data
4336 is aligned (if not it's a bug in our code). Put in verbose griping
4337 about why we set corrupted = TRUE.
4338 (decode_header_data): add FIXME that char* is evil. Was going to
4339 add FIXME about evil locale-specific string.h strncmp, but just
4340 switched to wacky string-as-uint32 optimization. Move check for
4341 "no room for field name" above get_const_data_len() to avoid
4342 assertion failure in get_const_data_len if we have trailing 2
4343 bytes or the like. Check for service and name fields being
4344 provided twice. Don't leak service/name on error. Require field
4345 names to be aligned to 4 bytes.
4347 * dbus/dbus-marshal.c: move byte swap stuff to header
4348 (_dbus_pack_int32): uscore-prefix
4349 (_dbus_unpack_int32): uscore-prefix
4350 (_dbus_unpack_uint32): export
4351 (_dbus_demarshal_string): add @todo complaining about use of
4353 (_dbus_marshal_get_field_end_pos): add @todo about bad error
4354 handling allowing corrupt data to go unchecked
4356 2003-01-08 Havoc Pennington <hp@redhat.com>
4358 * dbus/dbus-transport-unix.c (unix_do_iteration): add read/write
4359 to the select() as needed for authentication. (should be using
4360 _dbus_poll() not select, but for another day)
4362 * dbus/dbus.h: include dbus/dbus-protocol.h
4364 2003-01-08 Anders Carlsson <andersca@codefactory.se>
4366 * dbus/Makefile.am (dbusinclude_HEADERS): Install
4369 2003-01-08 Anders Carlsson <andersca@codefactory.se>
4371 * dbus/dbus-internals.c: (_dbus_type_to_string):
4372 New function that returns a string describing a type.
4374 * dbus/dbus-marshal.c: (_dbus_demarshal_byte_array):
4375 * dbus/dbus-marshal.h:
4376 * dbus/dbus-message.c: (dbus_message_get_fields_valist),
4377 (dbus_message_iter_get_field_type), (dbus_message_iter_get_double),
4378 (dbus_message_iter_get_byte_array):
4379 * dbus/dbus-message.h:
4380 Add new convenience functions for appending and getting message fields.
4381 Also add demarshalling routines for byte arrays.
4383 2003-01-07 Anders Carlsson <andersca@codefactory.se>
4385 * dbus/dbus-connection-internal.h:
4386 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
4387 (_dbus_connection_get_next_client_serial),
4388 (dbus_connection_send_message):
4389 * dbus/dbus-internals.h:
4390 * dbus/dbus-marshal.c: (unpack_uint32), (dbus_unpack_int32),
4391 (dbus_pack_int32), (_dbus_marshal_double), (_dbus_marshal_int32),
4392 (_dbus_marshal_uint32), (_dbus_demarshal_double),
4393 (_dbus_demarshal_int32), (_dbus_demarshal_uint32),
4394 (_dbus_demarshal_string), (_dbus_marshal_get_field_end_pos),
4395 (_dbus_verbose_bytes), (_dbus_marshal_test):
4396 * dbus/dbus-marshal.h:
4397 * dbus/dbus-message-internal.h:
4398 * dbus/dbus-message.c: (_dbus_message_set_client_serial),
4399 (dbus_message_write_header), (_dbus_message_lock),
4400 (dbus_message_new), (dbus_message_ref), (dbus_message_unref),
4401 (dbus_message_get_name), (dbus_message_append_int32),
4402 (dbus_message_append_uint32), (dbus_message_append_double),
4403 (dbus_message_append_string), (dbus_message_append_byte_array),
4404 (dbus_message_get_fields_iter), (dbus_message_iter_ref),
4405 (dbus_message_iter_unref), (dbus_message_iter_has_next),
4406 (dbus_message_iter_next), (dbus_message_iter_get_field_type),
4407 (dbus_message_iter_get_string), (dbus_message_iter_get_int32),
4408 (dbus_message_iter_get_uint32), (dbus_message_iter_get_double),
4409 (decode_header_data), (_dbus_message_loader_return_buffer),
4410 (message_iter_test), (_dbus_message_test):
4411 * dbus/dbus-message.h:
4412 * dbus/dbus-protocol.h:
4413 * dbus/dbus-test.c: (main):
4415 * glib/test-dbus-glib.c: (message_handler), (main):
4416 * test/echo-client.c: (main):
4417 * test/watch.c: (check_messages):
4418 Make messages sendable and receivable for real.
4420 2003-01-07 Anders Carlsson <andersca@codefactory.se>
4422 * dbus/dbus-marshal.c: (_dbus_marshal_double),
4423 (_dbus_marshal_string), (_dbus_marshal_byte_array):
4424 * dbus/dbus-message.c: (dbus_message_append_int32),
4425 (dbus_message_append_uint32), (dbus_message_append_double),
4426 (dbus_message_append_string), (dbus_message_append_byte_array):
4427 Handle OOM restoration.
4429 2003-01-07 Anders Carlsson <andersca@codefactory.se>
4431 * dbus/dbus-marshal.c: (_dbus_marshal_string),
4432 (_dbus_demarshal_string), (_dbus_marshal_test):
4433 * dbus/dbus-marshal.h:
4434 * dbus/dbus-message.c: (dbus_message_get_name),
4435 Document these functions.
4437 (dbus_message_append_int32), (dbus_message_append_uint32),
4438 (dbus_message_append_double), (dbus_message_append_string),
4439 (dbus_message_append_byte_array):
4440 * dbus/dbus-message.h:
4441 Add functions for adding message fields of different types.
4443 * dbus/dbus-protocol.h:
4444 Add the different types.
4446 2003-01-05 Havoc Pennington <hp@pobox.com>
4448 * bus/connection.c: implement routines for handling connections,
4449 first thing is keeping a list of owned services on each connection
4450 and setting up watches etc.
4452 * bus/services.c: implement a mapping from service names to lists
4455 * dbus/dbus-hash.c: add DBUS_HASH_POINTER
4457 * dbus/dbus-threads.c (dbus_static_mutex_lock): add functions
4458 to use static mutexes for global data
4460 * dbus/dbus-connection.c (dbus_connection_set_data): add new
4461 collection of functions to set/get application-specific data
4462 on the DBusConnection.
4464 2003-01-04 Havoc Pennington <hp@pobox.com>
4466 * dbus/dbus-sysdeps.c (_dbus_sleep_milliseconds): new function
4467 (_dbus_poll): new function
4469 * dbus/dbus-internals.h (_DBUS_STRUCT_OFFSET): new macro
4472 * bus/loop.c: initial code for the daemon main loop
4474 2003-01-04 Havoc Pennington <hp@pobox.com>
4476 * test/watch.c (error_handler): make it safe if the error handler
4477 is called multiple times (if we s/error handler/disconnect
4478 handler/ we should just guarantee it's called only once)
4480 * dbus/dbus-transport.c (_dbus_transport_disconnect): call the
4481 error handler on disconnect (it's quite possible we should
4482 just change the error handler to a "disconnect handler," I'm
4483 not sure we have any other meaningful errors)
4485 * configure.in: check for getpwnam_r
4487 * dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
4488 dbus/dbus-auth.c: add credentials support, add EXTERNAL auth
4489 mechanism as in SASL spec, using socket credentials
4491 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): new function
4492 (_dbus_send_credentials_unix_socket): new function
4494 * dbus/dbus-sysdeps.c (_dbus_accept_unix_socket): rename just
4496 (_dbus_write): only check errno if <0 returned
4497 (_dbus_write_two): ditto
4499 2003-01-02 Anders Carlsson <andersca@codefactory.se>
4501 * dbus/dbus-marshal.c: (_dbus_marshal_utf8_string),
4502 (_dbus_marshal_byte_array), (_dbus_demarshal_utf8_string),
4503 (_dbus_marshal_test):
4504 * dbus/dbus-marshal.h:
4505 Add _dbus_marshal_byte_array and rename _dbus_marshal_string
4506 to _dbus_marshal_utf8_string. Also fix some tests.
4508 2002-12-28 Harri Porten <porten@kde.org>
4510 * configure.in: added check for C++ compiler and a very cheesy
4511 check for the Qt integration
4513 * Makefile.am (SUBDIRS): compile qt subdir if support is enabled
4515 * qt/Makefile.am: added
4517 * qt/.cvsignore: added
4519 * qt/dbus-qthread.cc, qt/dbus-qthread.cpp: renamed former to
4520 latter, added #ifdef QT_THREAD_SUPPORT guard.
4522 * dbus/Makefile.am: added missing headers for make dist
4524 2002-12-28 Kristian Rietveld <kris@gtk.org>
4526 * dbus/Makefile.am: fixup export-symbols-regex.
4528 2002-12-27 Anders Carlsson <andersca@codefactory.se>
4530 * acinclude.m4: Add this file and put the
4531 PKG_CHECK_MODULE macro in it.
4533 2002-12-27 Anders Carlsson <andersca@codefactory.se>
4535 * dbus/dbus-marshal.c: (_dbus_marshal_string),
4536 (_dbus_demarshal_double), (_dbus_demarshal_int32),
4537 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
4538 (_dbus_marshal_test):
4539 Make the demarshalling routines align the pos argument.
4540 Add string marshalling tests and fix the obvious bugs
4543 2002-12-26 Havoc Pennington <hp@pobox.com>
4545 * dbus/dbus-auth.c: fixes fixes fixes
4547 * dbus/dbus-transport-unix.c: wire up support for
4548 encoding/decoding data on the wire
4550 * dbus/dbus-auth.c (_dbus_auth_encode_data)
4551 (_dbus_auth_decode_data): append to target string
4552 instead of nuking it.
4554 2002-12-26 Havoc Pennington <hp@pobox.com>
4556 * dbus/dbus-marshal.h (DBUS_COMPILER_BYTE_ORDER): #ifdef
4557 WORDS_BIGENDIAN then compiler byte order is DBUS_BIG_ENDIAN,
4560 * dbus/dbus-marshal.c: Add macros to do int swapping in-place and
4561 avoid swap_bytes() overhead (ignoring possible assembly stuff for
4562 now). Main point is because I wanted unpack_uint32 to implement
4564 (_dbus_verbose_bytes): new function
4566 * dbus/dbus-string.c (_dbus_string_validate_ascii): new function
4568 * dbus/dbus-message.c (_dbus_message_loader_get_is_corrupted): add
4569 mechanism to handle a corrupt message stream
4570 (_dbus_message_loader_new): fix preallocation to only prealloc,
4573 * dbus/dbus-string.c (_dbus_string_skip_blank): fix this function
4574 (_dbus_string_test): enhance tests for copy/move and fix the
4577 * dbus/dbus-transport-unix.c: Hold references in more places to
4578 avoid reentrancy problems
4580 * dbus/dbus-transport.c: ditto
4582 * dbus/dbus-connection.c (dbus_connection_dispatch_message): don't
4583 leak reference count in no-message case
4585 * test/watch.c (do_mainloop): handle adding/removing watches
4586 during iteration over the watches. Also, ref the connection/server
4587 stored on a watch, so we don't try to mangle a destroyed one.
4589 * dbus/dbus-transport-unix.c (do_authentication): perform
4592 * dbus/dbus-auth.c (get_state): add a state
4593 AUTHENTICATED_WITH_UNUSED_BYTES and return it if required
4594 (_dbus_auth_get_unused_bytes): append the unused bytes
4595 to the passed in string, rather than prepend
4597 * dbus/dbus-transport.c (_dbus_transport_init_base): create
4598 the auth conversation DBusAuth
4600 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd)
4601 (_dbus_transport_new_for_domain_socket): when creating a
4602 transport, pass in whether it's a client-side or server-side
4603 transport so we know which DBusAuth to create
4605 2002-12-03 Havoc Pennington <hp@pobox.com>
4607 * dbus/dbus-transport-unix.c (unix_finalize): finalize base
4608 _after_ finalizing the derived members
4609 (unix_connection_set): unref watch if we fail to add it
4611 * dbus/dbus-connection.c (dbus_connection_unref): delete the
4612 transport first, so that the connection owned by the
4613 transport will be valid as the transport finalizes.
4615 * dbus/dbus-transport-unix.c (unix_finalize): free the write_watch
4616 if necessary, and remove watches from the connection.
4618 * dbus/dbus-watch.c (_dbus_watch_list_free): improve a comment
4620 2002-12-26 Anders Carlsson <andersca@codefactory.se>
4622 * dbus/dbus-marshal.c: (_dbus_marshal_string),
4623 (_dbus_demarshal_double), (_dbus_demarshal_int32),
4624 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
4625 (_dbus_marshal_test):
4626 * dbus/dbus-marshal.h:
4627 Add string marshal functions and have the demarshal functions
4628 return the new position.
4630 2002-12-25 Havoc Pennington <hp@pobox.com>
4632 * doc/dbus-sasl-profile.txt: docs on the authentication protocol,
4633 it is a simple protocol that just maps directly to SASL.
4635 * dbus/dbus-auth.h, dbus/dbus-auth.c: authentication protocol
4636 initial implementation, not actually used yet.
4638 * dbus/dbus-string.c (_dbus_string_find): new function
4639 (_dbus_string_equal): new function
4640 (_dbus_string_base64_encode): new function
4641 (_dbus_string_base64_decode): new function
4643 2002-12-25 Anders Carlsson <andersca@codefactory.se>
4646 * dbus/dbus-marshal.c: (swap_bytes), (_dbus_marshal_double),
4647 (_dbus_marshal_int32), (_dbus_marshal_uint32),
4648 (_dbus_demarshal_double), (_dbus_demarshal_int32),
4649 (_dbus_demarshal_uint32), (_dbus_marshal_test):
4650 * dbus/dbus-marshal.h:
4651 * dbus/dbus-protocol.h:
4652 * dbus/dbus-test.c: (main):
4654 Add un-optimized marshalling/demarshalling routines.
4656 2002-12-25 Harri Porten <porten@kde.org>
4658 * qt/dbus-qt.h: adjusted ctor and getter to KDE/Qt conventions
4660 2002-12-24 Zack Rusin <zack@kde.org>
4662 * qt/dbus-qthread.cc: adding - integrates QMutex into Dbus
4663 * qt/dbus-qt.h: skeleton with two sample implemenatation of the
4666 2002-12-24 Havoc Pennington <hp@pobox.com>
4668 * glib/dbus-gthread.c: fix include
4670 * glib/dbus-glib.h: rename DBusMessageHandler for now.
4671 I think glib API needs to change, though, as you don't
4672 want to use DBusMessageFunction, you want to use the
4673 DBusMessageHandler object. Probably
4674 dbus_connection_open_with_g_main_loop()
4675 and dbus_connection_setup_g_main_loop() or something like that
4676 (but think of better names...) that just create a connection
4677 that has watch/timeout functions etc. already set up.
4679 * dbus/dbus-connection.c
4680 (dbus_connection_send_message_with_reply): new function just to
4681 show how the message handler helps us deal with replies.
4683 * dbus/dbus-list.c (_dbus_list_remove_last): new function
4685 * dbus/dbus-string.c (_dbus_string_test): free a string that
4688 * dbus/dbus-hash.c: use memory pools for the hash entries
4689 (rebuild_table): be more paranoid about overflow, and
4690 shrink table when we can
4691 (_dbus_hash_test): reduce number of sprintfs and write
4692 valid C89. Add tests for case where we grow and then
4693 shrink the hash table.
4695 * dbus/dbus-mempool.h, dbus/dbus-mempool.c: memory pools
4697 * dbus/dbus-connection.c (dbus_connection_register_handler)
4698 (dbus_connection_unregister_handler): new functions
4700 * dbus/dbus-message.c (dbus_message_get_name): new
4702 * dbus/dbus-list.c: fix docs typo
4704 * dbus/dbus-message-handler.h, dbus/dbus-message-handler.c:
4705 an object representing a handler for messages.
4707 2002-12-16 Anders Carlsson <andersca@codefactory.se>
4710 * glib/dbus-gthread.c: (dbus_gthread_init):
4711 Don't use the gdbus prefix for public functions.
4713 2002-12-16 Anders Carlsson <andersca@codefactory.se>
4717 Add GLib checks and fixup .pc files
4721 * glib/dbus-gmain.c: (gdbus_connection_prepare),
4722 (gdbus_connection_check), (gdbus_connection_dispatch),
4723 (gdbus_add_connection_watch), (gdbus_remove_connection_watch),
4724 (dbus_connection_gsource_new):
4725 * glib/dbus-gthread.c: (dbus_gmutex_new), (dbus_gmutex_free),
4726 (dbus_gmutex_lock), (dbus_gmutex_unlock), (dbus_gthread_init):
4727 * glib/test-dbus-glib.c: (message_handler), (main):
4730 2002-12-15 Harri Porten <porten@kde.org>
4732 * autogen.sh: check for libtoolize before attempting to use it
4734 * dbus/dbus-transport-unix.c: include <sys/time.h> for timeval
4737 * .cvsignore: ignore more stamp files
4739 * dbus/dbus-watch.c (_dbus_watch_list_new): fixed doc error
4741 * test/Makefile.am: added -I$(top_srcdir) to be able to compile
4742 without make install.
4744 2002-12-15 Havoc Pennington <hp@pobox.com>
4746 * dbus/dbus-threads.c: add thread stubs that a higher library
4747 layer can fill in. e.g. the GLib wrapper might fill them in with
4748 GThread stuff. We still need to use this thread API to
4749 thread-safe-ize the library.
4751 2002-12-12 Havoc Pennington <hp@pobox.com>
4753 * dbus/dbus-transport-unix.c, dbus/dbus-server-unix.c: use the
4754 below new interfaces and include fewer system headers.
4756 * dbus/dbus-sysdeps.c (_dbus_read): new function
4757 (_dbus_write): new function
4758 (_dbus_write_two): new function
4759 (_dbus_connect_unix_socket): new function
4760 (_dbus_listen_unix_socket): new function
4762 * dbus/dbus-message-internal.h: change interfaces to use
4765 2002-12-11 Havoc Pennington <hp@pobox.com>
4767 * dbus/dbus-types.h: add dbus_unichar
4769 * dbus/dbus-internals.c (_dbus_verbose): use _dbus_getenv
4771 * dbus/dbus-connection.c (dbus_connection_send_message): return
4774 * dbus/dbus-transport.c: include dbus-watch.h
4776 * dbus/dbus-connection.c: include dbus-message-internal.h
4778 * HACKING: add file with coding guidelines stuff.
4780 * dbus/dbus-string.h, dbus/dbus-string.c: Encapsulate all string
4781 handling here, for security purposes (as in vsftpd). Not actually
4782 using this class yet.
4784 * dbus/dbus-sysdeps.h, dbus/dbus-sysdeps.c: Encapsulate all
4785 system/libc usage here, as in vsftpd, for ease of auditing (and
4786 should also simplify portability). Haven't actually moved all the
4787 system/libc usage into here yet.
4789 2002-11-25 Havoc Pennington <hp@pobox.com>
4791 * dbus/dbus-internals.c (_dbus_verbose): fix to not
4792 always print the first verbose message.
4794 2002-11-24 Havoc Pennington <hp@pobox.com>
4796 * test/echo-client.c, test/echo-server.c: cheesy test
4799 * configure.in (AC_CHECK_FUNCS): check for writev
4801 * dbus/dbus-message.c (_dbus_message_get_network_data): new
4804 * dbus/dbus-list.c (_dbus_list_foreach): new function
4806 * dbus/dbus-internals.c (_dbus_verbose): new function
4808 * dbus/dbus-server.c, dbus/dbus-server.h: public object
4809 representing a server that listens for connections.
4811 * dbus/.cvsignore: create
4813 * dbus/dbus-errors.h, dbus/dbus-errors.c:
4814 public API for reporting errors
4816 * dbus/dbus-connection.h, dbus/dbus-connection.c:
4817 public object representing a connection that
4818 sends/receives messages. (Same object used for
4819 both client and server.)
4821 * dbus/dbus-transport.h, dbus/dbus-transport.c:
4822 Basic abstraction for different kinds of stream
4823 that we might read/write messages from.
4825 2002-11-23 Havoc Pennington <hp@pobox.com>
4827 * dbus/dbus-internals.h (_DBUS_INT_MAX): add _DBUS_INT_MIN
4830 * dbus/dbus-test.c (main): add list test, and include
4831 dbus-test.h as intended
4833 * dbus/dbus-hash.c (_dbus_hash_table_remove_string)
4834 (_dbus_hash_table_remove_int): return value indicates
4835 whether the entry existed to remove
4837 * dbus/dbus-list.c: add linked list utility class,
4840 * dbus/dbus-hash.c: add TODO item about shrinking the hash bucket
4843 2002-11-23 Havoc Pennington <hp@pobox.com>
4845 * Doxyfile.in (INCLUDE_FILE_PATTERNS): expand DBUS_BEGIN_DECLS/
4846 DBUS_END_DECLS to nothing, that should fix this once and for all
4848 * Doxyfile.in (JAVADOC_AUTOBRIEF): set to YES
4850 * dbus/dbus-message.c, dbus/dbus-hash.c:
4851 add some missing @brief
4853 2002-11-23 Havoc Pennington <hp@pobox.com>
4855 * dbus/dbus-message.h: put semicolons after DEBUG_BEGIN_DECLS
4856 to avoid confusing Doxygen
4858 * dbus/dbus-hash.c: @} not }@
4860 * dbus/dbus-message.c (struct DBusMessage): split out
4863 2002-11-23 Havoc Pennington <hp@pobox.com>
4865 * configure.in: pile on more warning flags if using gcc
4867 * Doxyfile.in (EXTRACT_STATIC): set to NO, so we don't have
4868 to document static functions
4870 * configure.in: add summary to end of configure so it
4871 looks nice and attractive
4873 * dbus/dbus-hash.c: finish implementation and write unit
4876 * configure.in: add --enable-tests to enable unit tests
4878 * dbus/dbus-test.c: test program to run unit tests
4879 for all files in dbus/*, initially runs a test for
4882 * dbus/dbus-internals.h: file to hold some internal utility stuff
4884 2002-11-22 Havoc Pennington <hp@redhat.com>
4886 * dbus/dbus-hash.c: copy in Tcl hash table, not yet
4887 "ported" away from Tcl
4889 * dbus/dbus-types.h: header for types such as dbus_bool_t
4891 2002-11-22 Havoc Pennington <hp@redhat.com>
4893 * dbus/dbus.h: fixups for doc warnings
4895 * Doxyfile.in (FILE_PATTERNS): we need to scan .h to pick up
4897 (QUIET): make it quiet so we can see warnings
4899 * dbus/dbus-memory.c: teach D-BUS to allocate and free memory
4901 2002-11-22 Havoc Pennington <hp@redhat.com>
4903 * Makefile.am: include "Doxyfile" target in all-local
4905 * configure.in: generate the Doxyfile
4907 * Doxyfile.in: move Doxyfile here, so we can use
4908 configure to generate a Doxyfile with the right
4911 2002-11-22 Havoc Pennington <hp@redhat.com>
4913 * dbus/dbus-message.c: move inline docs into .c file
4915 * Doxyfile (OUTPUT_DIRECTORY): move output to doc/api
4916 so all docs are under doc/
4917 (MAN_EXTENSION): generate man pages. Use extension
4918 ".3dbus" which matches ".3qt" on my system,
4919 I guess this is OK, I don't know really.
4920 (FILE_PATTERNS): look for .c files not .h, makes sense
4923 2002-11-22 Havoc Pennington <hp@pobox.com>
4925 * Makefile.am (SUBDIRS): rename subdir "server" to "bus"
4926 because any app can be a server, and any app can be a client,
4927 the bus is a special kind of server.
4929 Thu Nov 21 23:35:31 2002 Zack Rusin <zack@kde.org>
4931 * Doxyfile : adding. Still needs Makefile rules to be generated
4932 automatically (just run "doxygen" in the toplevel dir for now to
4935 * dbus/dbus-message.h : Adding sample docs (javadoc since
4936 resembles gtk-doc a little more)
4938 * dbus/dbus.h : Adding sample docs
4940 2002-11-21 Havoc Pennington <hp@redhat.com>
4942 * dbus/Makefile.am (INCLUDES): define DBUS_COMPILATION
4943 so we can allow ourselves to include files directly,
4944 instead of having to use dbus.h
4946 * dbus/dbus.h: fill in
4948 * dbus/dbus-message.h: sketch out a sample header file.
4949 Include griping if you include it directly instead of
4952 * dbus/dbus-macros.h: new file with macros for extern "C",
4953 TRUE/FALSE, NULL, etc.
4955 * doc/file-boilerplate.c: put include guards in here
4957 2002-11-21 Havoc Pennington <hp@redhat.com>
4959 * doc/file-boilerplate.c: include both AFL and GPL boilerplate.
4961 * COPYING: include the GPL as well, and license code
4962 under both AFL and GPL.
4964 2002-11-21 Havoc Pennington <hp@redhat.com>
4966 * acconfig.h: get rid of this
4968 * autogen.sh (run_configure): add --no-configure option
4970 * configure.in: remove AC_ARG_PROGRAM to make
4971 autoconf complain less. add AC_PREREQ.
4972 add AC_DEFINE third arg.
4974 2002-11-21 Anders Carlsson <andersca@codefactory.se>
4977 Fix references so we can distcheck.
4979 2002-11-21 Havoc Pennington <hp@redhat.com>
4981 * Initial module creation