1 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
3 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
5 2006-06-18 Jim Meyering <jim@meyering.net>
7 * tests/misc/pwd-long: Make error output a little clearer.
9 2006-06-17 Jim Meyering <jim@meyering.net>
11 * tests/rm/inaccessible: Skip this test on systems without openat
12 support. Reported by Bob Proulx.
14 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
16 * tests/misc/mknod: Improve permission checks to handle
17 running mkdir test in set-gid directories.
19 2006-06-14 Jim Meyering <jim@meyering.net>
21 * tests/du/basic: Revamp not to hard-code file system block sizes.
23 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
25 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
28 2006-06-11 Jim Meyering <jim@meyering.net>
30 * .gitignore: New file.
31 * Makefile.am (EXTRA_DIST): Add .gitignore.
33 Setting TIME_STYLE=long-iso in the environment would make the
34 cp/same-file test fail.
35 * tests/envvar-check (vars): Add TIME_STYLE to the list.
36 * tests/cp/same-file: Revert last change.
37 Source the envvar-check script, to ensure that TIME_STYLE
38 settings don't affect these tests.
40 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
42 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
43 uses POSIX time stamp formats. Problem reported by John Nixon in
44 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
46 2006-06-10 Jim Meyering <jim@meyering.net>
48 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
50 Require a "Version N.M" line at the top of the ChangeLog
51 file only when making the actual release, not when running
53 * Makefile.maint (maintainer-distcheck): Don't depend on
55 (alpha beta major): Depend on it here, instead.
57 2006-06-08 Jim Meyering <jim@meyering.net>
59 Ensure that cat works with any of the options, -A -v -e -E -T,
60 when applied to files in /proc and /sys, even when the FIONREAD
61 ioctl produces nonsensical results. Before this change, cat would
62 produce no output (or truncated output), for some linux kernels.
64 * src/cat.c (write_pending): New function, factored out of cat.
65 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
66 that there are bytes to read. Some versions of linux-2.6.16 do that.
67 Write any pending output before returning.
68 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
69 * NEWS: Mention this bug fix.
70 * tests/misc/cat-proc: New file. Test for the above.
71 * tests/misc/Makefile.am (TESTS): Add cat-proc.
73 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
75 * src/expr.c (eval4): Detect overflow properly when multiplying
78 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
80 * NEWS: The 'expr' command now detects and reports integer overflow.
81 (It would be better to use extended precision instead, but that
83 * src/expr.c (integer_overflow): New function.
84 (eval4, eval3): Check for integer overflow.
86 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
88 Fix problems when building with Solaris/SVR4/etc. make, which uses a
89 different and somewhat bogus implementation of VPATH. In the
90 directory tests/misc, rename tests whose names might appear in the
91 Automake-generated rules. For example, we can't use a test named
92 'test', since Automake generates a rule that contains the text
93 "if test -f ./$$tst; ...", and this might expand to something like
94 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
95 which executes the 'test' script rather than the 'test' command.
96 * tests/misc/false-status: Renamed from tests/misc/false.
97 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
98 * tests/misc/sort-merge: Renamed from tests/misc/sort.
99 ($prog): Set to 'sort' rather than to $PROG.
100 * tests/misc/test-diag: Renamed from tests/misc/test.
101 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
102 in case Solaris make has prepended the directory.
103 (TESTS): Adjust to above renamings.
104 * tests/misc/expand: Don't assign to PROG; no longer needed
105 now that Makefile.am sets PROG to the basename.
106 * tests/misc/fold: Likewise.
108 2006-06-03 Jim Meyering <jim@meyering.net>
110 Make `cp --link --no-dereference' work also on systems where the
111 link system call cannot create a hard link to a symbolic link.
112 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
113 the link syscall on a symlink when it would do the wrong thing.
114 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
115 * tests/cp/link-no-deref: New file/test for the above.
116 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
117 * NEWS: Mention the change (doesn't affect Linux).
119 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
121 Fix some porting problems in the test cases reported by
122 Ralf Wildenhues for HP-UX 11.23 in:
123 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
124 * tests/help-version: Don't assume that \< \> works in sed.
125 * tests/misc/close-stdout: Don't assume that >&- works.
126 Add a /dev/full test.
127 * tests/touch/no-create-missing: Don't assume that >&- works.
129 2006-05-30 Jim Meyering <jim@meyering.net>
131 * src/ls.c (usage): Add `v' to the list of sorting-related options.
134 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
136 * tests/cp/fail-perm: source lang-default.
137 * tests/rm/inaccessible: Likewise.
139 2006-05-28 Jim Meyering <jim@meyering.net>
141 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
142 Recognize it, too. Reported by Ralf Wildenhues, in
143 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
145 2006-05-27 Jim Meyering <jim@meyering.net>
147 * src/chgrp.c: Support new options: --preserve-root and
148 --no-preserve-root. Somehow this program was skipped when those
149 options were added to chown, chmod, and rm. Reported by
150 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
151 * NEWS: Mention this.
153 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
155 * NEWS: Remove mention of --seed. We'll replace it with something
156 better, and don't want to indicate that it is supported.
157 * src/sort.c (usage): Likewise.
159 2006-05-20 Jim Meyering <jim@meyering.net>
161 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
163 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
164 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
165 FTS_COMFOLLOW. Spotted by Justin Pryzby.
167 * gnupload: Merge changes from automake, retaining the ""--to...
168 kludge to placate overzealous `make distcheck' check.
170 2006-05-19 Jim Meyering <jim@meyering.net>
172 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
173 FTS_TIGHT_CYCLE_CHECK directory traversal option.
174 Reported by Justin Pryzby in http://bugs.debian.org/367691
176 2006-05-15 Jim Meyering <jim@meyering.net>
178 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
181 2006-05-13 Jim Meyering <jim@meyering.net>
183 * tests/mv/no-target-dir: Test two more cases.
185 2006-05-11 Jim Meyering <jim@meyering.net>
187 mv -T DIR EMPTY_DIR no longer fails unconditionally
188 * src/copy.c (copy_internal): Don't manually prohibit a move where
189 the destination is an existing directory. Sometimes doing that is
190 valid. Let the rename system call enforce the rules. That is
191 allowed only when the source is a directory and the destination
192 directory (to be replaced) is empty. Reported by Eric Blake.
193 * tests/mv/no-target-dir: New file/test for this.
194 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
195 * NEWS: Mention this.
197 * tests/mv/atomic: New file/test for yesterday's fix.
198 * tests/mv/Makefile.am (TESTS): Add atomic.
200 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
202 2006-05-10 Jim Meyering <jim@meyering.net>
204 * src/copy.c (copy_internal): Don't explicitly unlink the destination
205 when moving a symlink into the place of an existing non-directory.
206 Reported by Joshua Hudson.
207 * NEWS: mention this.
209 2006-05-07 Jim Meyering <jim@meyering.net>
211 * Makefile.maint (patch-check): Fail if patch generates any output,
212 even merely for changed offsets.
214 * src/c99-to-c89.diff: Adjust to reflect new offsets.
216 * NEWS: Mention changes affecting df, pwd, shred.
218 2006-05-06 Jim Meyering <jim@meyering.net>
220 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
221 system condition where dirent.d_ino != stat.st_ino.
222 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
224 2006-05-06 Eric Blake <ebb9@byu.net>
226 * tests/ls/inode: Expand to test inode from readdir case.
227 * tests/ls/follow-slink: Expand to test broken links encountered
228 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
230 2006-05-06 Eric Blake <ebb9@byu.net>
232 * tests/mv/leak-fd: Work even on case-insensitive file system.
234 2006-05-04 Jim Meyering <jim@meyering.net>
236 * NEWS: Mention the 2006-03-19 pwd-related change that makes
237 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
239 2006-05-03 Jim Meyering <jim@meyering.net>
241 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
242 Use better macro parameter names: s/basename/key_name/,
243 s/basefunc/key_cmp_func. Fix typo in comment.
245 2006-04-29 Eric Blake <ebb9@byu.net>
247 * src/ls.c (main): On systems with d_type, directories_first only
248 implies format_needs_type, not format_needs_stat.
250 2006-05-03 Jim Meyering <jim@meyering.net>
252 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
253 after comma in arg list, from Eric Blake.
255 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
257 * tests/misc/date (relative-3): New test, derived from a bug
258 report by John Thomas McDole.
260 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
262 New option for ls: --group-directories-first.
263 It makes ls list directories before files.
264 * NEWS [New features]: Mention it.
265 * src/ls.c (sort_type): Rearrange to use as an array index when
266 choosing sort function; added new sort_numtypes member for
268 (time_type): Add new time_numtypes member for compile-time check.
269 (directories_first): New global variable.
270 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
271 (long_options): Add --directories-first.
272 (main): Support new option.
273 (is_directory): New function.
274 (extract_dirs_from_files): Use it.
275 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
276 (LIST_SORTFUNCTION_VARIANTS): New macros.
277 (sort_functions): New global variable.
278 (sort_files): Use it.
279 (usage): Document new option.
281 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
283 * src/shred.c (fillrand): The assertion was way too weak, due to
284 what must be a typo. Strengthen it to its intended value.
285 (dopass): Don't use alloca; it's not worth the aggravation here,
286 since it's used only to get a page-aligned buffer, and page
287 alignment doesn't buy us much here. I'm suspicious that alloca
288 causes problems on some hosts, due to a recent bug report by Adam
289 Waltman: http://bugs.gentoo.org/130246.
291 2006-04-18 Jim Meyering <jim@meyering.net>
293 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
294 sha384sum, sha512sum.
296 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
298 * src/chmod.c (describe_change): Adjust to filemode changes.
299 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
300 (print_long_format): Use (new) filemodestring rather than
301 (old) mode_string, so that we get more file types right, at least
302 in theory. Adjust to filemode changes.
303 * src/stat.c (human_access): Likewise.
305 2006-04-18 Jim Meyering <jim@meyering.net>
307 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
308 ignore file. This has never been enabled. Reported by Eric Blake.
310 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
312 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
313 bug in Interix. Just call symlink or link directly. All uses changed.
314 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
315 * src/stat.c (USE_STATVFS): New macro.
316 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
317 (NAMEMAX_FORMAT): define a bit more clearly, now that the
318 statvfs-using code is a bit more regular.
319 * src/system.h (sync) [!HAVE_SYNC]: New macro.
321 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
323 * NEWS: csplit, nl, expr now conform to POSIX better, and are
324 more-compatible with traditional Unix, with respect to regular
326 * src/csplit.c (extract_regexp): Set re_syntax_options to a
327 value that is compatible with what POSIX requires.
328 * src/nl.c (build_type_arg): Likewise.
329 * src/expr.c (docolon): Likewise. Also, don't let anchors match
330 newline; this fixes an incompatibility with tradition and with POSIX.
331 Don't warn about leading ^. POSIX says it is unspecified whether
332 ^ is a special character, which means that implementations can
333 either treat it as special or not, but either way a warning is not
334 allowed (unless the regexp is otherwise invalid). Instead, anchor
335 the expression but treat ^ as an anchor; this is the traditional
336 behavior (e.g., Solaris 10).
337 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
338 and the like as invalid expressions (exit status 2), not as
339 failure of 'expr' (exit status 3). This is more consistent with
341 * tests/expr/basic (fail-a): Adjust exit status to match new expr
342 behavior, for status 2 versus 3.
344 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
345 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
346 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
347 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
348 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
349 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
350 (bre61, bre62): New tests.
351 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
355 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
356 "if !". Do not assume that 'sed' can handle long, newline-free input.
357 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
359 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
361 Adjust to new regex.h API (with new fastmap type), and clean
362 up the regex storage allocation a bit.
364 * src/csplit.c (struct control): Put re_compiled member at the
365 end, since it's large. Change regexpr member from char * to bool;
366 all uses changed. Add new member fastmap.
367 (extract_regexp): regexp arg is now char const *, not char *.
368 Don't bother duplicating the regular expression; it's not needed.
369 Set fastmap from new fastmap member. Don't bother allocating
370 a buffer, as the regexp code does a better job than we do.
371 * src/expr.c (docolon): Allocate and use a fastmap.
372 Don't bother allocating a buffer.
373 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
375 (build_type_arg): New fastmap arg. All uses changed.
376 Don't bother allocating a buffer, but set a fastmap.
377 * src/ptx.c (context_regex_string, word_regex_string): Remove.
378 (context_regex, word_regex): New vars, replacing the above.
380 (struct regex_data): New type.
381 (compile_regex): Renamed from alloc_and_compile_regex, since
382 we no longer allocate storage. Arg is now a struct regex_data *,
383 not a const char *. All uses changed. Don't allocate the fastmap;
384 instead, take it from the caller. Don't convert size_t to int,
385 to avoid arithmetic overflow problems. Don't bother freeing
386 storage afterwards; it's not worth the aggravation.
387 * src/tac.c (compiled_separator_fastmap): New ver.
388 (main): Use it. Don't bother allocating a buffer.
390 2006-03-30 Jim Meyering <jim@meyering.net>
392 * src/dd.c (iwrite): Remove assignment without effect.
393 Reported by Felix Rauch Valenti.
395 2006-03-22 Eric Blake <ebb9@byu.net>
397 * src/ptx.c (usage): Remove mention of --copyright/-C.
398 (main): Alias --copyright to --version plus a deprecation warning.
399 * NEWS: Mention this.
401 2006-03-27 Jim Meyering <jim@meyering.net>
403 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
404 use of strtod. Tiny patch from Nickolai Zeldovich.
406 2006-03-11 Eric Blake <ebb9@byu.net>
408 * tests/misc/dirname: New file.
409 * tests/basename/Makefile.am: Delete.
410 * tests/basename/basic: Move to...
411 * tests/misc/basename: ... this new file. Add some tests,
412 including fixed behavior for //.
413 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
414 * tests/Makefile.am (SUBDIRS): Remove basename.
415 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
417 Improvements to dirname/basename handling on platforms like
418 cygwin with distinct // and with drive letters.
419 * NEWS: Document new behavior.
420 * src/basename.c (main): Don't strip suffix from file system
422 * src/cp.c (target_directory_operand): Use new last_component.
423 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
424 traversing the string.
425 * src/dircolors.c (guess_shell_syntax): Use new last_component.
426 * src/install.c (target_directory_operand, install_file_in_dir):
428 * src/ln.c (target_directory_operand, main): Likewise.
429 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
430 * src/mv.c (target_directory_operand, movefile): Likewise.
431 * src/remove.c (rm_1): Likewise.
432 * src/shred.c (wipename): Likewise.
433 * src/split.c (next_file_name): Likewise.
434 * src/su.c (log_su, run_shell): Likewise.
436 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
438 * NEWS: nohup diagnostics are now more precise, and nohup now
439 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
440 * src/nohup.c (main): Implement this.
441 * tests/misc/nohup: Test the new behavior.
443 2006-03-12 Jim Meyering <jim@meyering.net>
445 * src/copy.c (set_author): Rename function, from preserve_author.
447 * src/remove.c (AD_pop_and_chdir): Use new macro,
448 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
450 * src/system.h (SAME_INODE): Remove definition.
451 Include "same-inode.h", instead.
453 2006-03-11 Eric Blake <ebb9@byu.net>
455 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
457 2006-03-10 Jim Meyering <jim@meyering.net>
459 Fix a bug whereby a user with write access to a directory being removed
460 could cause the removal of that directory to fail with an erroneous
461 diagnostic about a directory cycle. Reported by Vineet Chadha.
463 * NEWS: Mention this.
464 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
465 leave (and try to rmdir) is the one whose dev_ino is being used to
466 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
468 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
470 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
471 * src/dd.c (set_fd_flags): Handle file-creation flags on file
472 descriptors, rather than ignoring them.
473 * tests/dd/misc: Add test cases for append, nofollow, directory,
474 and nolinks flags. Simplify redirection to /dev/null in some cases.
476 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
477 noatime test never tested anything.
479 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
481 * src/dd.c (flags, usage): New flags directory, nolinks.
482 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
484 * src/ls.c (usage): Mention that -f disables --color.
485 Problem reported by Niels Möller.
487 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
489 * man/*.x: Add references to syscalls from utilities of the same name.
491 2006-03-05 Jim Meyering <jim@meyering.net>
493 * tests/help-version: Set SHELL, if not already set, in order to
494 avoid failure when `make check' is run through debuild; dircolors
495 would fail due to lack of $SHELL. Reported by Sven Joachim.
497 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
498 * src/base64.c (wrap_write, do_encode, main): Change type of
499 parameters and locals, wrap_column, form size_t to uintmax_t.
500 (main): Adjust to use xstrtoumax, accordingly.
502 2006-03-03 Jim Meyering <jim@meyering.net>
504 Don't fail when run from an environment with SHELL not a Bourne
505 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
506 * tests/dircolors/simple: Invoke each non-failing test with -b.
507 Reported by Michael Stone.
509 2006-02-27 Jim Meyering <jim@meyering.net>
511 * tests/misc/base64: Derive --decode-using tests from the
514 * tests/misc/base64: Factor out a long constant string.
515 Split lines to stay within 80 columns.
517 * tests/misc/Makefile.am (TESTS): Add base64.
518 * tests/misc/base64: Test base64. From Simon Josefsson.
520 * src/base64.c (do_decode): Use correct type for parameter,
521 ignore_garbage: s/size_t/bool/.
523 * src/base64.c: Don't include .h files already included by system.h:
524 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
525 Include "system.h" before the other lib/*.h header files.
526 Include <sys/types.h> before "system.h".
527 (wrap_write): Remove declaration of unused local, initial_column.
528 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
530 * README: Add base64 to the list.
532 2006-02-17 Simon Josefsson <jas@extundo.com>
535 * AUTHORS: Mention base64.
537 * man/Makefile.am: Build base64.1.
538 * man/base64.x: New file.
539 * src/Makefile.am (bin_PROGRAMS): Add base64.
540 * src/base64.c: New file.
542 2006-02-25 Eric Blake <ebb9@byu.net>
544 In ls, avoid calling stat for --inode (-i), when possible.
545 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
546 * src/system.h: ... here, for use in ...
547 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
549 (gobble_file): Add inode argument.
550 (print_dir): Pass inode if available.
551 (usage): Remove inaccuracy.
553 2006-02-23 Jim Meyering <jim@meyering.net>
555 * TODO: Update/correct some obsolete entries.
557 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
559 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
560 * src/join.c (usage): Likewise.
561 Documentation problem reported by Philip Kensche.
563 2006-02-20 Eric Blake <ebb9@byu.net>
565 * man/rm.x: Update documentation to match previous patch.
567 2006-02-18 Eric Blake <ebb9@byu.net>
569 New option for rm: --interactive=once (-I).
570 * NEWS: Document it, along with change to rm --interactive.
571 * TODO: Remove entry for implementing rm -I
572 * src/rm.c (INTERACTIVE_OPTION): New enum value.
573 (interactive_type): New enum.
574 (long_opts): Let interactive take an optional argument.
575 (interactive_args, interactive_types): New option arguments.
576 (usage): Document -I, --interactive=WHEN. Use program_name
577 instead of a basename.
578 (main): New -I option, new behavior to --interactive.
579 * tests/rm/interactive-once: New tests.
580 * tests/rm/interactive-always: Ditto.
581 * tests/rm/Makefile.am (TESTS): Run them.
583 2006-02-18 Jim Meyering <jim@meyering.net>
585 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
586 expression match more of the target lines, e.g., those that start with
587 `-S,' (short option followed by a comma) or that include `=[...]'.
588 Patch by Nicolas François.
589 Fix the four offenders thus exposed:
590 * src/join.c (usage): Use two spaces (not one) to separate the
591 --first-only option string from its description, so help2man formats
592 the derived man page properly.
593 * src/pr.c (usage): Likewise.
594 * src/uniq.c (usage): Likewise.
595 * src/install.c (usage): Likewise.
597 2006-02-15 Jim Meyering <jim@meyering.net>
599 * Makefile.maint (alpha beta major): For `make major', ensure that the
600 version string is of the form N.N[.N]*, where N is one or more digits.
602 2006-02-14 Jim Meyering <jim@meyering.net>
604 * INSTALL: Update from gnulib.
606 2006-02-13 Jim Meyering <jim@meyering.net>
608 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
610 2006-02-12 Jim Meyering <jim@meyering.net>
612 * Makefile.maint (patch-check): New target.
613 (local-checks-available): Add to the list.
615 2006-02-11 Jim Meyering <jim@meyering.net>
617 * src/c99-to-c89.diff: New file.
618 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
620 * .x-po-check: New file, with exclusions so that `make distcheck'
622 * Makefile.am (EXTRA_DIST): Add .x-po-check.
624 rm -r must remove an empty directory, even if it is inaccessible.
625 * src/remove.c (close_preserve_errno): New function.
626 (fd_to_subdirp): Don't print a diagnostic in this function.
627 Do it from the callers instead, unless rmdir succeeds.
628 (remove_cwd_entries, remove_dir): Adjust callers.
629 * tests/rm/empty-inacc: New test for the above.
630 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
631 * NEWS: Mention this bug fix.
632 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
633 a tiny bit less precise: cannot remove `a/1': ... instead of
634 cannot open directory `a/1': ...
636 * Makefile.maint (syntax-check-rules): Automatically derive this
637 list of sc_-prefixed rule names.
639 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
641 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
642 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
643 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
644 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
645 go away? was that an accident?)
646 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
647 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
648 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
649 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
650 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
651 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
652 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
653 (author_mark_check, makefile_path_separator_check):
654 Output line numbers, to simplify navigation of Emacs *compilation*
656 (sc_prohibit_atoi_atof, sc_file_system):
657 Rework slightly so that Makefile.maint doesn't get reported as a
658 violation of its own syntax rules.
659 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
660 it at run-time (which didn't work with Bison). Fix a makefile typo,
661 caught by Makefile.maint itself: spaces where a tab should be.
662 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
663 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
664 Ignore djgpp and man subdirectories, to avoid false matches with
665 Bison and coreutils, respectively. Use sort -u to remove the
666 resulting duplicates.
667 * gnupload: Rework slightly to avoid bogus warning from
668 sc_two_space_separator_in_usage.
670 2006-02-10 Jim Meyering <jim@meyering.net>
672 Use gzip's --rsyncable option only if it's available.
673 * Makefile.maint (gzip_rsyncable): New variable.
676 2006-02-08 Jim Meyering <jim@meyering.net>
678 * Makefile.maint (local-checks-available): Define in terms of
679 the expansion, $(syntax-check-rules), rather than the single,
680 top-level target `syntax-check', so that it's easier to exclude
681 individual rules (via $(local-checks-to-skip)).
682 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
684 2006-02-07 Jim Meyering <jim@meyering.net>
686 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
687 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
689 * tests/help-version (expected_failure_status_vdir):
690 Redirect an expected disk-full diagnostic to /dev/null.
692 2006-02-06 Jim Meyering <jim@meyering.net>
694 * src/unexpand.c (usage): Use two spaces (not one) to separate the
695 --first-only option string from its description, so help2man formats
696 the derived man page properly.
697 * src/rm.c (usage): Likewise for --no-preserve-root.
698 * src/chown.c (usage): Likewise.
699 * src/chgrp.c (usage): Likewise.
701 Add a rule to ensure that the above doesn't happen again.
702 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
703 (syntax-check-rules): Add it.
704 * .x-sc_two_space_separator_in_usage: New empty file.
705 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
707 2006-02-06 Jim Meyering <jim@meyering.net>
709 * src/cp.c (usage): Use two spaces (not one) to separate each
710 option string from its description, so help2man formats the
711 derived man page properly.
712 * src/mv.c (usage): Likewise.
713 Patch from Nicolas François in http://bugs.debian.org/351601.
715 2006-02-04 Jim Meyering <jim@meyering.net>
717 * src/copy.c (copy_internal): cp -RL would fail when encountering
718 the same directory more than once in the hierarchy beneath a single
719 command-line argument. That is legitimate, e.g. when there are
720 two or more symbolic links, each pointing to some directory that
721 would not otherwise be copied. Reported by Christophe LYON.
722 * tests/cp/cp-deref: New file. Test for today's fix.
723 * tests/cp/Makefile.am (TESTS): Add cp-deref.
724 * NEWS: Document this.
726 2006-02-03 Jim Meyering <jim@meyering.net>
728 * configure.ac: Require automake-1.9.6, not 1.8.3.
730 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
732 * src/od.c (usage): Mention that -t a ignores high order bit.
733 Documentation problem reported by Ed Avis.
735 2006-02-01 Jim Meyering <jim@meyering.net>
737 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
739 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
741 * src/head.c (main): Use a better diagnostic when someone uses a
742 trailing numeric option in an invalid way. Problem reported by
744 * src/tail.c (parse_options): Likewise.
746 2006-01-30 Jim Meyering <jim@meyering.net>
748 * man/wc.x: Include `count' keyword in man page synopsis,
749 per suggestion from http://bugs.debian.org/181585.
751 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
753 * src/df.c (show_dev): If the file system claims to have
754 more available than total blocks, report the number of used
755 blocks as being total - available (a negative number) rather
756 than as garbage. Problem reported by Toralf Foerster.
758 2006-01-24 Jim Meyering <jim@meyering.net>
760 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
761 to put a regular file in O_NONBLOCK mode fails with EPERM.
762 That happens on Linux (up to 2.6.15) when using tail -f on a file with
763 the append-only attribute. Reported by Dean Gaudet. For details,
764 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
765 * NEWS: Mention this fix.
766 * tests/tail-2/append-only: New file. Test for the above.
767 * tests/tail-2/Makefile.am (TESTS): Add append-only.
768 * tests/Makefile.am (check-root): Add tail-2/append-only
770 2006-01-21 Jim Meyering <jim@meyering.net>
772 * NEWS: Mention fts-related improvements and bug fixes.
774 2006-01-19 Jim Meyering <jim@meyering.net>
776 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
777 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
779 2006-01-18 Jim Meyering <jim@meyering.net>
781 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
783 2006-01-17 Jim Meyering <jim@meyering.net>
785 Now that fts no longer changes the current working directory, adjust
786 its clients accordingly -- note that du.c uses fts but doesn't need
787 any adjustment, since it doesn't operate on the actual files,
788 but rather just uses the stat buffers provided by fts.
790 * src/chown-core.c: Include "openat.h".
791 Don't include "lchown.h".
792 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
793 calling openat, lchownat, chownat, rather than open, lchown, chown.
795 * src/chmod.c: Include "openat.h".
796 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
798 * tests/du/long-from-unreadable: New test, to exercise one small
801 2006-01-13 Jim Meyering <jim@meyering.net>
803 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
804 addition of new directories under tests/.
806 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
809 2006-01-12 Jim Meyering <jim@meyering.net>
811 * tests/du/long-sloop: Adjust not to hard-code the expected
812 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
813 from that of GNU libc. Reported by Paul Eggert.
815 * tests/du/long-sloop: Create file at end of symlink chain.
817 * tests/misc/test: New file, with a test for one of the
818 bugs fixed by yesterday's test.c changes.
819 * tests/misc/Makefile.am (TESTS): Add test.
821 2006-01-11 Jim Meyering <jim@meyering.net>
823 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
824 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
825 a very long sequence of symbolic links (not necessarily a loop).
826 * tests/du/Makefile.am (TESTS): Add long-sloop.
828 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
830 * src/test.c (test_syntax_error): Append a newline. All callers
831 changed, except for the ones that didn't already append a newline.
832 Bug reported by Eric Blake.
834 2006-01-11 Jim Meyering <jim@meyering.net>
836 * src/system.h (X2NREALLOC): Now that verify_true is no longer
837 void, cast its result to void, to avoid gcc's warning that
838 ``left-hand operand of comma expression has no effect''.
839 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
841 2006-01-10 Jim Meyering <jim@meyering.net>
843 * tests/chmod/no-x: Add a test for today's fts.c fix.
845 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
847 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
848 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
850 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
852 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
853 Use verify_true instead of verify_expr, to sync with gnulib.
855 2006-01-08 Jim Meyering <jim@meyering.net>
857 * src/date.c (usage): Adjust the formatting of the entries for
858 %::z and %:::z (separate with two spaces, not one) so that help2man
859 formats them properly. Reported by Philip Rowlands.
861 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
863 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
865 2006-01-06 Jim Meyering <jim@meyering.net>
867 * Makefile.maint (copyright-check): Use date +%Y in place of
870 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
871 First off, the attribute should have been `volatile' (not static)
872 to avoid longjmp-related risk of clobber. Secondly, now there is
873 no longer any risk of a local variable being clobbered, so there's
874 no need for any attribute at all.
876 2006-01-05 Jim Meyering <jim@meyering.net>
878 * src/remove.c: Give a few functions the inline attribute.
879 (AD_pop_and_chdir): Use gotos to avoid some duplication.
880 (AD_push): Rewrite an assertion so that the entire computation
881 goes away when assertions are turned off.
883 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
884 It's already defined in "system.h".
885 * Makefile.maint: Add a FIXME comment.
887 2006-01-04 Jim Meyering <jim@meyering.net>
889 * ChangeLog: Remove entries from 2005-10-22 and earlier.
890 * ChangeLog-2005: New file, for entries up to version 5.92.
892 2006-01-03 Jim Meyering <jim@meyering.net>
894 * tests/du/no-x: Also allow a slightly different diagnostic -- the
895 one you get when using openat-enabled fts.c and du (coming soon).
896 * tests/chmod/no-x: Likewise.
897 * tests/chgrp/no-x: Likewise.
899 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
901 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
903 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
904 (restricted_chown): Return it, if the file cannot be accessed due
905 to EPERM, or if no uid or gid are required, or if the file is
906 neither a directory nor a regular file. Rewrite to avoid gotos.
907 (change_file_owner): Handle RC_do_ordinary_chown case.
908 Rewrite to avoid gotos.
909 * tests/chgrp/basic: Make sure we can change the group of
912 * src/date.c (usage): Explain %g, %G, and %V a bit better.
914 2006-01-02 Jim Meyering <jim@meyering.net>
916 * src/copy.c (set_owner): Correct a comment.
918 * src/tail.c (parse_options): Change warning to say that --retry
919 is useful `mainly' (not `only') when following by name.
920 Reported here: http://bugs.debian.org/273781
922 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
924 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
925 * src/copy.c: Include lchmod.h.
926 (copy_internal): Use lchmod rather than chmod.
927 * src/cp.c: Include lchmod.h.
928 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
929 * src/mkdir.c: Include lchmod.h.
930 (usage): Clarify -m's operation.
931 (main): Use lchmod rather than chmod. Don't use lchmod unless the
932 new mode contains bits outside the 777 range.
933 * src/mkfifo.c (usage): Clarify -m's operation.
934 (main): If -m is given, don't invoke chmod; use umask 0 instead.
935 Report an error if -m asks for bits outside the 777 range.
936 * src/mknod.c (usage, main): Likewise.
938 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
940 2005-12-27 Jim Meyering <jim@meyering.net>
942 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
943 (sc_prohibit_assert_without_use): New rule.
944 (syntax-check-rules): Add it to the list.
945 * .x-sc_prohibit_assert_without_use: New empty file.
946 * Makefile.am (EXTRA_DIST): Add it.
948 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
950 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
951 Don't include <assert.h>; it wasn't used.
953 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
955 * src/chown-core.c (restricted_chown):
956 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
957 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
958 | O_NOFOLLOW too, for consistency with other dir-openers.
959 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
960 (is_empty_dir): Likewise.
961 * src/shred.c (wipename): Likewise. Don't bother trying to open
962 dir for writing, since POSIX prohibits it.
964 2005-12-22 Jim Meyering <jim@meyering.net>
966 * tests/help-version: Redirect stderr to /dev/full, to suppress
967 write error diagnostic.
969 2005-12-19 Jim Meyering <jim@meyering.net>
971 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
972 Avoid a minor race condition when `-m MODE' is specified, by using
973 open, fchown, and close rather than just chown. To do that reliably --
974 even with an overly restrictive umask -- ensure that each mkdir,
975 mknod and mkfifo call uses a mode including at least owner-read access.
976 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
977 the subsequent chown (or equivalent open,fchown,close) fails.
978 * tests/misc/mknod: New tests.
979 * tests/misc/Makefile.am (TESTS): Add mknod.
981 2005-12-17 Jim Meyering <jim@meyering.net>
983 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
984 e.g., on a named pipe.
985 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
986 place of all uses, since it is guaranteed (system.h) to be defined.
988 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
990 Add POSIX ACL support
991 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
992 is no requirement for ACL support; particularly, it does not exist
993 on systems that have POSIX ACLs.
994 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
995 * src/cp.c (umask_kill): With default acls, the umask is not to be
996 applied. Remove umask_kill, don't change the process umask, and let
997 the kernel apply the umask where appropriate.
998 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
999 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1001 (copy_reg, copy_internal): Use copy_acl and set_acl
1002 instead of fchown/chown. Fix the logic for POSIX ACLs.
1003 (chown_succeded): Remove; we now always copy acls and
1004 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1005 did a chown before or not.
1006 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1007 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1008 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1009 to link with it via $(LIB_ACL), for the utilities that need it.
1011 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1013 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1014 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1015 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1016 value is now signified by whether cwd_errno is null.
1017 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1018 pointer-to-bool to pointer-to-errno-value. All callers changed.
1019 (rm_1): Don't bother setting a local cwd failure flag and then
1020 ORing it into the caller's. Just set the caller's.
1021 (rm): Use cwd failure errno value to print a slightly-better
1024 2005-12-15 Jim Meyering <jim@meyering.net>
1026 * src/stat.c (print_it): Properly handle a backslash at the
1027 end of a --printf format string. Reported by Paul Eggert.
1028 * tests/misc/stat-printf (end-bs): Add a test for the above.
1030 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1032 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1033 Don't assume /etc/passwd contains user names; use 'id' instead.
1035 2005-12-15 Jim Meyering <jim@meyering.net>
1037 stat: revert behavior of --format=FMT (-c)
1038 stat: add new option: --printf=FMT
1039 * NEWS: Mention this.
1040 * src/stat.c (isodigit, octtobin, hextobin): Define.
1041 (PRINTF_OPTION): Define.
1042 (interpret_backslash_escapes, trailing_delim): New globals.
1043 (usage): Document them. Alphabetize on long option names.
1044 (print_esc_char): New function.
1045 (print_it): Rewrite, in order to handle backslash escapes.
1046 (main): Handle new option. Set globals for --format, too.
1048 * tests/misc/stat-printf: Test --printf and --format.
1049 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1051 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1053 * NEWS: sort now reports incompatible options.
1054 * src/sort.c (incompatible_options, check_ordering_compatibility):
1056 (main): Use them. Don't bother with a usage message for
1057 "sort -c a b", for consistency with other error diagnostics.
1058 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1061 * src/cat.c (main): Undo previous change. close_stdout already
1062 does the check, so the previous change wasn't necessary.
1064 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1066 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1068 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1070 Install a more-conservative approach for sort -R. It's the
1071 same basic idea as the existing code, except it uses the full ISAAC
1072 approach (called the "more kosher" approach in the existing comments).
1073 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1074 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1075 better to be conservative here at first, and review any performance
1076 improvements carefully.
1077 * .x-sc_require_config_h: Add src/rand-isaac.c.
1078 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1079 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1080 (shred_SOURCES, sort_SOURCES): Remove.
1081 (EXTRA_DIST): Add rand-isaac.c.
1082 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1083 changing it to allow for varying numbers of words in the state.
1084 Alter so that we include rand-isaac.c directly rather than
1085 compiling it and linking to it. Don't include config.h or
1086 system.h; that's the includer's responsibility.
1087 Omit functions that are specific to shred.
1088 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1089 (isaac_step, struct irand_state):
1090 Resurrect these, with the same defns that used to be in shred.c.
1091 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1092 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1094 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1095 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1096 (irand_init, irand32, irand_mod):
1097 Number of words is constant again.
1098 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1099 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1100 * src/sort.c: Likewise.
1101 * src/shred.c (fillrand, dopass, main): Undo previous change.
1102 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1104 * src/sort.c: Don't include md5.h; it wasn't needed.
1105 (struct keyfield): Rename random_hash to random, for consistency
1106 with the other member names. All uses changed.
1107 (usage): Tweak wording to mention STRING for --seed option.
1108 (short_options): Rorder for consistency with other programs.
1109 (rand_state): Now a struct, not a pointer to one. All uses changed.
1110 (HASH_WORDS, HASH_SIZE): Remove.
1111 (get_hash): Remove comments around resbuf size, since we can assume C89.
1112 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1113 (keycompare): Adjust to the new get_hash.
1115 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1116 (main): Don't set need_random simply because gkey has it set; that
1117 doesn't necessarily mean we'll need random numbers.
1118 Redo seeding to match new get_hash approach.
1120 2005-12-10 Jim Meyering <jim@meyering.net>
1122 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1124 Avoid shred segfault on 64-bit systems.
1125 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1126 local of type uint32_t. Make the local an `int' instead.
1128 * NEWS: Mention sort's new options.
1130 * src/rand-isaac.c (isaac_mix): Declare to be static.
1131 Mark all other functions as `extern' so the tight-scope
1132 part of `make distcheck' passes once again.
1133 * src/rand-isaac.h (isaac_mix): Remove declaration.
1135 * src/sort.c (get_hash): Change position of `*' in parameter
1136 type to conform with convention.
1137 (main): Split a long line so it fits in 80 columns.
1138 (keycompare): Remove stray SPACE before TAB that was
1139 causing `make distcheck' to fail.
1141 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1143 * tests/misc/sort-rand: New file: basic tests for the new options.
1144 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1146 2005-12-10 Frederik Eaton <frederik@ofb.net>
1148 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1149 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1150 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1151 Make state size runtime-configurable.
1152 (isaac_new, isaac_copy): New functions.
1153 * src/rand-isaac.h: New file.
1154 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1155 (fillrand, main): Adjust to the fact that the state size is now
1156 runtime-configurable.
1157 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1158 (usage): Add options --random-sort and --seed to implement a random
1160 Include md5.h and rand-isaac.h.
1161 (get_hash): New function.
1162 (rand_state): New var.
1163 (HASH_WORDS, HASH_SIZE): New macros.
1165 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1167 * tests/dd/misc: Add test for dd iflags=noatime.
1169 2005-12-09 Jim Meyering <jim@meyering.net>
1171 * src/sort.c (usage): Mention white space vs -b and -t options.
1174 2005-12-09 Eric Blake <ebb9@byu.net>
1176 * src/test.c (main): Fix misleading comment.
1178 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1180 * NEWS: Mention dd's new noatime flag.
1181 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1182 * src/dd.c (flags, usage): Add support for noatime flag.
1184 2005-12-07 Jim Meyering <jim@meyering.net>
1186 Distribute the cvsu script, used only by `make syntax-check'.
1187 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1188 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1189 distribute a copy of this script.
1190 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1192 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1193 to create a temporary directory on another partition.
1194 From Andreas Gruenbacher.
1196 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1198 * man/basename.x: Cross-reference to dirname and readlink.
1199 * man/dirname.x: Cross-reference to basename and readlink.
1201 2005-12-05 Andreas Gruenbacher
1203 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1204 (set_owner, preserve_author): New functions, factored out of copy_reg.
1205 (copy_reg): Use them.
1206 (copy_internal): Use them here, too.
1208 2005-12-04 Jim Meyering <jim@meyering.net>
1210 * src/sleep.c (usage): Say what happens with two or more arguments.
1211 Suggested by Justin Pryzby.
1213 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1216 2005-12-03 Jim Meyering <jim@meyering.net>
1218 * src/rm.c (long_opts): Change the name of each undocumented, for-
1219 testing-only option to start with `-', so that it cannot render
1220 ambiguous any prefix it happens to share with some other option name.
1221 Problem reported by Eric Blake.
1222 * src/head.c (long_options): Likewise.
1223 * src/tail.c (long_options): Likewise.
1225 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1226 testing-only --presume* options to start with `---'.
1227 * tests/rm/dangling-symlink: Likewise.
1228 * tests/rm/dir-no-w: Likewise.
1229 * tests/rm/isatty: Likewise.
1231 2005-11-30 Jim Meyering <jim@meyering.net>
1233 * Makefile.maint: Add a comment about cvsu.
1235 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1237 * NEWS: df updates for "none", "proc", inaccessible file systems.
1238 * src/df.c (show_point): Ignore inaccessible file systems.
1239 (usage): -a includes dummy file systems, not size-0 file systems.
1241 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1242 to avoid collision with POSIX name space. All uses changed.
1244 2005-11-24 Jim Meyering <jim@meyering.net>
1246 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1247 * tests/acl: Add `$0: ' prefix to diagnostics.
1249 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1251 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1253 * src/copy.c: Improve performance a bit by optimizing away
1254 unnecessary system calls and going to a block size of at least
1255 8192 (on normal hosts, anyway). This improved performance 5% on my
1256 Debian stable host (2.4.27 kernel, x86, copying from root
1257 ext3 file system to itself).
1258 Include "buffer-lcm.h".
1259 (copy_reg): Omit last argument. All callers changed.
1260 Use xmalloc to allocate rather than trusting alloca
1261 (which is unwise with large block sizes).
1262 Declare locals more locally, if possible.
1263 Use uintptr_t words instead of int words, for a bit more speed
1264 when looking for null blocks on 64-bit hosts.
1265 Optimize away reads of zero bytes on regular files.
1266 In the typical case, insist on 8 KiB buffers, at least.
1267 Avoid unnecessary extra call to fstat when checking for sparse files.
1268 Avoid now-unnecessary cast to off_t, and "0L".
1269 Avoid unnecessary test of *new_dst when checking for same owner
1272 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1274 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1276 2005-11-22 Jim Meyering <jim@meyering.net>
1278 * src/remove.c (AD_push): Remove debugging cruft.
1280 * tests/rm/unread2 (rm): Change expected diagnostic,
1281 `cannot open directory' to `cannot remove', to align with
1283 * tests/rm/rm2: Ensure that rm now continues removing entries
1284 even after certain types of failure.
1286 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1287 that provide openat (Solaris), and on systems like Linux+procfs
1288 where our openat emulation code is reentrant. This also fixes a
1289 few low-probability leaks and eliminates some code that could,
1290 in very unusual circumstances, cause rm() (via a callee) to exit.
1291 * NEWS: Mention this.
1293 * configure.ac: Put copyright dates all on one line so the
1294 emacs function that updates them works properly.
1296 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1298 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1299 Problem reported by Eric Blake.
1300 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1301 we get a standard-conforming compiler. This relies on the new
1302 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1303 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1304 m4/c.m4 can go away with Autoconf 2.60 comes out.
1306 2005-11-17 Jim Meyering <jim@meyering.net>
1308 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1309 (AD_mark_current_as_unremovable): Likewise, but for a local.
1312 * tests/mv/acl: Let traps handle removing temporary directories.
1314 Expect acl-related tests to fail, until the corresponding
1315 patches are committed.
1316 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1317 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1319 ACL tests, from Andreas Gruenbacher.
1320 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1321 * tests/mv/Makefile.am (TESTS): Add acl.
1322 * tests/cp/Makefile.am (TESTS): Add acl.
1324 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1326 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1328 * NEWS: Improve quality of ln's diagnostics.
1329 * src/ln.c (do_link, usage): Likewise.
1330 (do_link): Don't use alloca on a buffer of unbounded size.
1332 2005-11-16 Jim Meyering <jim@meyering.net>
1334 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1335 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1336 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1337 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1338 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1340 2005-11-14 Jim Meyering <jim@meyering.net>
1342 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1344 2005-11-13 Jim Meyering <jim@meyering.net>
1346 * announce-gen: Accept new option, --gpg-key-id=ID and
1347 emit a blurb telling how to use the .sig files.
1348 * Makefile.cfg (gpg_key_ID): Define.
1349 * Makefile.maint (announcement): Use new option and key.
1351 Require that most .c files include <config.h>.
1352 * Makefile.maint (sc_require_config_h): New rule.
1353 (syntax-check-rules): Add it.
1354 * .x-sc_require_config_h: New file listing exceptions to the
1355 above rule. Some are legit, others are simply grandfathered in.
1356 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1358 2005-11-12 Jim Meyering <jim@meyering.net>
1360 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1362 2005-11-11 Jim Meyering <jim@meyering.net>
1364 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1365 Mention new readlink options in 5.3.0's `New features' section.
1366 Spotted by Thomas Hood.
1368 2005-11-08 Jim Meyering <jim@meyering.net>
1370 * NEWS: Merge in changes from b5_9x branch.
1372 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1374 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1375 like --time-style='posix-long-iso' if the locale settings are messed up.
1376 * src/ls.c (decode_switches): Implement this.
1378 2005-11-08 Jim Meyering <jim@meyering.net>
1380 * tests/du/2g: s/expensive/very expensive/ in a comment.
1383 2005-10-17 Eric Blake <ebb9@byu.net>
1385 * src/ls.c (usage): Fix descriptions of --sort, --time.
1386 Reported by Vitaly A. Ostanin.
1388 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1390 * src/ln.c: Include filenamecat.c.
1391 (FILE_BASENAME_CONCAT): Remove.
1392 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1393 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1394 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1397 2005-11-04 Jim Meyering <jim@meyering.net>
1399 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1400 on systems with stat.st_blocks of a signed 32-bit type.
1401 This bug causes trouble on some AIX 5.1 systems.
1402 Report and trivial patch from Paul Townsend:
1403 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1404 * NEWS: Mention this.
1406 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1407 * tests/du/Makefile.am (TESTS): Add it here.
1408 * tests/very-expensive: New file.
1409 * tests/Makefile.am (EXTRA_DIST): Add it here.
1410 * tests/cp/perm: Mark this test as `very-expensive', too.
1412 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1414 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1416 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1418 * src/rm.c (usage): Don't mention rm -d.
1420 2005-11-02 Jim Meyering <jim@meyering.net>
1422 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1423 From Andreas Schwab.
1425 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1426 `M+N records in/out' lines don't pollute `make check' output.
1428 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1429 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1430 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1431 to indicate that the input file should be piped into the command
1432 under test (via `cat FILE | $prog ...').
1434 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1435 (without -r) fails to remove a directory on a non-Linux system.
1436 This change affects only newer Solaris systems (with priv_*
1437 functions like priv_allocset). Reported by Keith Thompson.
1439 * tests/rm/dir-nonrecur: New file/test for the above fix.
1440 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1442 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1444 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1445 POSIX 1002.1-2001 requires.
1446 * src/tail.c (parse_obsolete_option): Implement this.
1447 Problem reported by Vincent Lefevre.
1448 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1449 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1450 (test_vector): Add special cases for _POSIX2_VERSION, and
1451 regularize the old ones a bit.
1452 * tests/touch/obsolescent: Add y2000 test.
1454 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1456 * src/dd.c (skip): Fix off-by-one error reported by
1457 Theodoros V. Kalamatianos.
1459 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1461 * tests/mkdir/p-3: Require that the test be run as non-root.
1462 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1464 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1466 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1467 boundary between DEST and SOURCE in the result.
1469 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1471 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1472 back to text, to sync with documentation and for backwards
1475 2005-10-25 Jim Meyering <jim@meyering.net>
1477 * tests/dircolors/simple (other-wr): Add an explicit test for
1478 the dircolors bug (NULL-dereference) fixed yesterday.
1480 2005-10-24 Jim Meyering <jim@meyering.net>
1482 * src/tac.c (tac_file): When determining whether a file is seekable,
1483 also test whether it is a tty. Using only the lseek-based test would
1484 give a false positive on Solaris. Reported by Peter Fales.
1486 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1488 * tests/install/d-slashdot: New test, for "install -d" failure.
1489 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1490 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1491 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1493 2005-10-24 Jim Meyering <jim@meyering.net>
1495 * src/dircolors.c (ls_codes): Add missing comma.
1496 Anonymous report and patch from
1497 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1499 * src/dircolors.c: Add compile-time assertion that the slack_codes
1500 and ls_codes arrays have the same number of elements. This would
1501 have prevented the above-fixed bug.
1503 * src/expand.c (parse_tab_stops): Add a comment to make this function
1504 identical to the one in unexpand.c.
1505 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1506 identical to the one in expand.c.
1508 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1510 2005-10-23 Jim Meyering <jim@meyering.net>
1512 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1513 a dangerous pointer-value-to-`unsigned' cast.
1514 * NEWS: mention the new sha* programs.
1515 * AUTHORS: Add new sha* programs.
1517 2005-08-28 David Madore <david.madore@ens.fr>
1519 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1520 * README: Add their names to the list.
1521 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1522 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1523 Rules for compiling sha-2 utilities
1524 (noinst_HEADERS): Remove checksum.h.
1525 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1527 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1528 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1529 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1530 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1531 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1532 sha384sum, sha512sum test scripts here rather that each in its
1535 2005-08-28 David Madore <david.madore@ens.fr>
1537 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1538 of the FIPS test vectors).
1540 2005-10-23 Jim Meyering <jim@meyering.net>
1542 * configure.ac: Use 6.0-cvs as the version string.
1543 * NEWS: Adjust accordingly.