1 2005-01-20 Havoc Pennington <hp@redhat.com>
3 * update-dbus-docs.sh: script to update docs on the web site, only
4 works for me though. neener.
6 2005-01-20 Havoc Pennington <hp@redhat.com>
8 * dbus/dbus-sysdeps.c (_dbus_poll): amazingly, trying to compile
9 code can reveal bugs in it
11 2005-01-20 Havoc Pennington <hp@redhat.com>
13 * dbus/dbus-sysdeps.c (_dbus_poll): fix several bugs in the
14 select() version, patches from Tor Lillqvist
16 2005-01-20 Havoc Pennington <hp@redhat.com>
18 * doc/dbus-tutorial.xml: replace > with >
20 * bus/services.c (bus_registry_acquire_service): validate the name
21 and return a better error if it's no good.
23 * doc/dbus-specification.xml: note NO_AUTO_START change
25 * dbus/dbus-protocol.h (DBUS_HEADER_FLAG_NO_AUTO_START): change
26 from AUTO_START, we're toggling the default
28 * bus/dispatch.c: adapt the tests to change of auto-start default
30 2005-01-18 Havoc Pennington <hp@redhat.com>
32 * rename dbus-daemon-1 to dbus-daemon throughout
34 2005-01-18 Havoc Pennington <hp@redhat.com>
36 * Throughout, grand renaming to strip out the use of "service",
37 just say "name" instead (or "bus name" when ambiguous). Did not
38 change the internal code of the message bus itself, only the
39 programmer-facing API and messages.
41 * doc/dbus-specification.xml: further update the message bus section
43 * bus/config-parser.c (all_are_equiv): fix bug using freed string
46 2005-01-17 Havoc Pennington <hp@redhat.com>
48 * dbus/dbus-types.h: remove 16-bit types since we don't use them
51 * dbus/dbus-marshal-validate.c (_dbus_validate_path): disallow any
52 "invalid name character" not only non-ASCII
54 * doc/dbus-specification.xml: further update spec, message bus
55 parts are still out-of-date but the marshaling etc. stuff is now
58 2005-01-17 Havoc Pennington <hp@redhat.com>
60 * doc/dbus-specification.xml: partially update spec
62 2005-01-17 Havoc Pennington <hp@redhat.com>
64 * Throughout, align variant bodies according to the contained
65 type, rather than always to 8. Should save a fair bit of space in
68 * dbus/dbus-marshal-validate.c (_dbus_validate_body_with_reason):
69 fix handling of case where p == end
71 * doc/TODO: remove the dbus_bool_t item and variant alignment items
73 2005-01-17 Havoc Pennington <hp@redhat.com>
75 * dbus/dbus-types.h: hardcode dbus_bool_t to 32 bits
77 * Throughout: modify DBUS_TYPE_BOOLEAN to be a 32-bit type instead
78 of an 8-bit type. Now dbus_bool_t is the type to use whenever you
79 are marshaling/unmarshaling a boolean.
81 2005-01-16 Havoc Pennington <hp@redhat.com>
83 This is about it on what can be disabled/deleted from libdbus
84 easily, back below 150K anyhow. Deeper cuts are more work than
85 just turning the code off as I've done here.
87 * dbus/dbus-marshal-basic.c (_dbus_pack_int32): we don't need the
88 signed int convenience funcs
90 * dbus/dbus-internals.c (_dbus_verbose_real): omit when not in
93 * dbus/dbus-string-util.c, dbus/dbus-string.c: more breaking
96 * dbus/dbus-sysdeps.c, dbus/dbus-sysdeps-util.c: same
98 * dbus/dbus-hash.c: purge the TWO_STRINGS crap (well, make it
99 tests-enabled-only, though it should probably be deleted)
101 * dbus/dbus-message-util.c: same stuff
103 * dbus/dbus-auth-util.c: same stuff
105 2005-01-16 Havoc Pennington <hp@redhat.com>
107 * dbus/dbus-userdb-util.c: split out part of dbus-userdb.c
109 * dbus/dbus-sysdeps.c (_dbus_uid_from_string): move here to pave
110 way for stripping down dbus-userdb.c stuff included in libdbus.
111 Rename _dbus_parse_uid for consistency.
113 2005-01-16 Havoc Pennington <hp@redhat.com>
115 * dbus/dbus-internals.c (_dbus_real_assert): print the function
116 name the assertion failed in
118 * dbus/dbus-internals.h (_dbus_return_if_fail)
119 (_dbus_return_val_if_fail): assert that the name of the function
120 containing the check doesn't start with '_', since we only want to
121 use checks on public functions
123 * dbus/dbus-connection.c (_dbus_connection_ref_unlocked): change
126 * dbus/dbus-marshal-header.c (_dbus_header_set_field_basic):
127 change checks to asserts for private function
129 * dbus/dbus-message.c (_dbus_message_set_serial): checks
130 to asserts for private function
132 * dbus/dbus-marshal-recursive.c (skip_one_complete_type): remove
133 broken assertion that was breaking make check
134 (_dbus_type_reader_array_is_empty): remove this rather than fix
135 it, was only used in assertions
137 2005-01-16 Havoc Pennington <hp@redhat.com>
139 * test/unused-code-gc.py: hacky script to find code that's used
140 only by the bus (not libdbus) or used only by tests or not used at
141 all. It has some false alarms, but looks like we can clean up a
142 lot of size from libdbus.
144 * dbus/dbus-sysdeps.c, dbus/dbus-sysdeps-utils.c,
145 dbus/Makefile.am: initially move 10K of binary size out of libdbus
147 2005-01-16 Havoc Pennington <hp@redhat.com>
149 * Add and fix docs according to Doxygen warnings throughout
152 * dbus/dbus-marshal-recursive.c
153 (_dbus_type_reader_array_is_empty): change this to just call
154 array_reader_get_array_len() and make it static
156 * dbus/dbus-message.c (dbus_message_iter_get_element_type): rename
158 (dbus_message_iter_init_append): rename from append_iter_init
160 * dbus/dbus-marshal-recursive.c
161 (_dbus_type_reader_get_element_type): rename from
162 _dbus_type_reader_get_array_type
164 2005-01-15 Havoc Pennington <hp@redhat.com>
166 * test/glib/test-profile.c (with_bus_server_filter): fix crash
168 * dbus/dbus-marshal-basic.c (_dbus_unpack_uint32): inline as macro
169 when DBUS_DISABLE_ASSERT
170 (_dbus_marshal_set_basic): be sure we align for the string length
172 * dbus/dbus-marshal-recursive.c (skip_one_complete_type): make
175 * dbus/dbus-string.c (_dbus_string_get_const_data_len): add an
177 (_dbus_string_set_byte): provide inline macro version
179 2005-01-15 Havoc Pennington <hp@redhat.com>
181 * Land the new message args API and type system.
183 This patch is huge, but the public API change is not
184 really large. The set of D-BUS types has changed somewhat,
185 and the arg "getters" are more geared toward language bindings;
186 they don't make a copy, etc.
188 There are also some known issues. See these emails for details
190 http://lists.freedesktop.org/archives/dbus/2004-December/001836.html
191 http://lists.freedesktop.org/archives/dbus/2005-January/001922.html
193 * dbus/dbus-marshal-*: all the new stuff
195 * dbus/dbus-message.c: basically rewritten
197 * dbus/dbus-memory.c (check_guards): with "guards" enabled, init
198 freed blocks to be all non-nul bytes so using freed memory is less
201 * dbus/dbus-internals.c (_dbus_test_oom_handling): add
202 DBUS_FAIL_MALLOC=N environment variable, so you can do
203 DBUS_FAIL_MALLOC=0 to skip the out-of-memory checking, or
204 DBUS_FAIL_MALLOC=10 to make it really, really, really slow and
207 * qt/message.cpp: port to the new message args API
208 (operator<<): use str.utf8() rather than str.unicode()
209 (pretty sure this is right from the Qt docs?)
211 * glib/dbus-gvalue.c: port to the new message args API
213 * bus/dispatch.c, bus/driver.c: port to the new message args API
215 * dbus/dbus-string.c (_dbus_string_init_const_len): initialize the
216 "locked" flag to TRUE and align_offset to 0; I guess we never
217 looked at these anyhow, but seems cleaner.
219 * dbus/dbus-string.h (_DBUS_STRING_ALLOCATION_PADDING):
220 move allocation padding macro to this header; use it to implement
221 (_DBUS_STRING_STATIC): ability to declare a static string.
223 * dbus/dbus-message.c (_dbus_message_has_type_interface_member):
224 change to return TRUE if the interface is not set.
226 * dbus/dbus-string.[hc]: move the D-BUS specific validation stuff
227 to dbus-marshal-validate.[hc]
229 * dbus/dbus-marshal-basic.c (_dbus_type_to_string): move here from
232 * dbus/Makefile.am: cut over from dbus-marshal.[hc]
233 to dbus-marshal-*.[hc]
235 * dbus/dbus-object-tree.c (_dbus_decompose_path): move this
236 function here from dbus-marshal.c
238 2005-01-12 Joe Shaw <joeshaw@novell.com>
240 * NEWS: Update for 0.23.
242 * configure.in: Release 0.23.
244 2005-01-12 Joe Shaw <joeshaw@novell.com>
246 * mono/Makefile.am, mono/example/Makefile.am: Always build the
247 dbus DLL with --debug. Clean up after the .mdb files this leaves
250 * mono/doc/Makefile.am: Need to uninstall the docs on "make
253 * mono/Arguments.cs (GetDBusTypeConstructor): If the type
254 is an enum, get the enum's underlying type. Another mono
257 2005-01-11 Joe Shaw <joeshaw@novell.com>
259 Patch from Sjoerd Simons <sjoerd@luon.net>
261 * mono/Makefile.am, mono/example/Makefile.am: Don't redefine
262 DESTDIR. It breaks stuff.
264 2005-01-11 Joe Shaw <joeshaw@novell.com>
266 Patch from Tambet Ingo <tambet@ximian.com>
268 * mono/DBusType/Array.cs (Get): Get the underlying element type by
269 calling type.GetElementType(). The code previously depended on
270 broken Mono behavior, which was fixed in Mono 1.1.3.
272 * mono/DBusType/Dict.cs (constructor): Fix the parameters for
273 Activator.CreateInstance() so that the class's constructor is
274 called with the right parameters.
276 2005-01-11 Joe Shaw <joeshaw@novell.com>
278 Patch from Timo Teräs <ext-timo.teras@nokia.com>
280 * dbus/dbus-connection.c
281 (_dbus_connection_queue_received_message_link): Call
282 _dbus_connection_remove_timeout() instead of the _locked()
283 variant, since it's always called from
284 _dbus_connection_handle_watch(), which handles the locking.
285 Removed the _locked() variant since it's no longer used.
287 2005-01-03 Havoc Pennington <hp@redhat.com>
289 * dbus/dbus-internals.h: I'm an idiot, _dbus_assert certainly can
292 2004-12-26 Havoc Pennington <hp@redhat.com>
294 * dbus/dbus-internals.h: add _DBUS_GNUC_NORETURN to _dbus_assert
296 2005-01-03 Havoc Pennington <hp@redhat.com>
298 * dbus/dbus-sysdeps.c (_dbus_sysdeps_test): fix using == on
301 * dbus/dbus-string.c (_dbus_string_insert_alignment): new function
303 2005-01-02 Havoc Pennington <hp@redhat.com>
305 * dbus/dbus-internals.h (_DBUS_ALIGN_OFFSET): new macro
307 2005-01-01 Havoc Pennington <hp@redhat.com>
309 * configure.in: add -Wfloat-equal
311 2005-01-01 Havoc Pennington <hp@redhat.com>
313 * dbus/dbus-sysdeps.h: add _DBUS_DOUBLES_BITWISE_EQUAL macro,
314 for a variety of reasons '==' doesn't do this.
316 2004-12-31 Havoc Pennington <hp@redhat.com>
318 * dbus/dbus-string.c (_dbus_string_equal_substrings): new function
321 2004-12-30 John (J5) Palmieri <johnp@redhat.com>
323 * python/dbus.py: s/ACTIVATION_REPLY_ACTIVE/ACTIVATION_REPLY_ACTIVATED
325 2004-12-30 John (J5) Palmieri <johnp@redhat.com>
327 * python/dbus_bindings.pyx.in: Change DBUS_ACTIVATION_REPLY_ACTIVATED
328 and DBUS_ACTIVATION_REPLY_ALREADY_ACTIVE to match the values in
329 dbus-protocol.h. Because they are defines and not enums they are not
332 2004-12-26 John (J5) Palmieri <johnp@redhat.com>
334 * python/dbus_bindings.pyx.in (bus_activate_service): Bind
335 dbus_bus_activate_service
337 * python/dbus.py (Bus.activate_service): activate a service on the
340 2004-12-24 Havoc Pennington <hp@redhat.com>
342 * test/decode-gcov.c: change to use .gcno and .gcda files, but the
343 file format has also changed and I haven't adapted to that yet
345 * Makefile.am: load .gcno files from latest gcc
347 2004-12-23 John (J5) Palmieri <johnp@redhat.com>
348 * Patch from Rob Taylor <robtaylor@fastmail.fm>
350 * python/dbus_bindings.pyx.in (bus_get_unix_user): New
353 * python/dbus.py (get_unix_user): Added binding to
354 call dbus_bindings.bus_get_unix_user
356 * python/extract.py: Modified the proto_pat regex to
359 2004-12-21 Olivier Andrieu <oliv__a@users.sourceforge.net>
361 * dbus/make-dbus-glib-error-enum.sh: omit the function keyword for
362 better POSIX compliance.
364 2004-12-19 Havoc Pennington <hp@redhat.com>
366 * dbus/dbus-string.c (_dbus_string_insert_4_aligned)
367 (_dbus_string_insert_8_aligned): new functions
369 * dbus/dbus-string.c (_dbus_string_alloc_space): new function
371 2004-12-18 Havoc Pennington <hp@redhat.com>
373 * dbus/dbus-string.c (_dbus_string_validate_ascii): use ISASCII
376 * dbus/dbus-message.c: fix a comment, and add a still-unused
377 not-implemented function
379 * dbus/dbus-marshal.h: fix comment
381 * dbus/dbus-internals.h (_DBUS_ISASCII): new macro
383 2004-12-17 Joe Shaw <joeshaw@novell.com>
385 * mono/DBusType/Byte.cs, mono/DBusType/Int32.cs,
386 mono/DBusType/Int64.cs, mono/DBusType/UInt32.cs,
387 mono/DBusType/UInt64.cs: Use Enum.GetUnderlyingType() instead of
388 Type.UnderlyingSystemType to get the actual system type
389 underneath. This code previously depended on the broken Mono
390 behavior, which was fixed in 1.1.3.
392 2004-11-27 Havoc Pennington <hp@redhat.com>
394 * dbus/dbus-string.h (_dbus_string_get_byte): inline when asserts
396 (_dbus_string_get_const_data): inline when asserts are disabled
398 * dbus/dbus-message.c: record the _dbus_current_generation of
399 creation so we can complain if dbus_shutdown() is used improperly.
400 Do this only if checks are enabled.
402 * dbus/dbus-connection.c: ditto
404 2004-11-26 Havoc Pennington <hp@redhat.com>
406 * test/glib/test-profile.c: add with_bus mode to profile echoes
407 that go through the bus.
409 * test/glib/run-test.sh: add ability to run test-profile
411 * bus/dbus-daemon-1.1.in: fix to say that SIGHUP causes partial
414 2004-11-26 Havoc Pennington <hp@redhat.com>
416 * test/glib/test-profile.c: clean up how the fake_malloc_overhead
417 thing was implemented
419 2004-11-26 Havoc Pennington <hp@redhat.com>
421 * test/glib/test-profile.c: tweak a bit, add support for some
422 made-up minimal malloc overhead with plain sockets, since in
423 real life some sort of buffers are unavoidable thus we could
424 count them in the theoretical best case
426 2004-11-26 Havoc Pennington <hp@redhat.com>
428 * dbus/dbus-message.c (dbus_message_cache_or_finalize): fix bug
429 where I was trying to cache one too many messages
431 2004-11-26 Havoc Pennington <hp@redhat.com>
433 * dbus/dbus-message.c: reimplement message cache as an array which
434 makes the cache about twice as fast and saves maybe 1.5% overall
436 2004-11-26 Havoc Pennington <hp@redhat.com>
438 * dbus/dbus-threads.c (init_global_locks): forgot to put the
439 message cache lock here
441 2004-11-26 Havoc Pennington <hp@redhat.com>
443 * dbus/dbus-message.c (struct DBusMessage): put the locked bit and
444 the "char byte_order" next to each other to save 4 bytes
445 (dbus_message_new_empty_header): reduce preallocation, since the
446 message cache should achieve a similar effect
447 (dbus_message_cache_or_finalize, dbus_message_get_cached): add a
448 message cache that keeps a few DBusMessage around in a pool,
449 another 8% speedup or so.
451 * dbus/dbus-dataslot.c (_dbus_data_slot_list_clear): new function
453 2004-11-25 Havoc Pennington <hp@redhat.com>
455 * dbus/dbus-transport-unix.c (unix_do_iteration): if we're going
456 to write, without reading or blocking, try it before the poll()
457 and skip the poll() if nothing remains to write. This is about a
458 3% speedup in the echo client/server
460 2004-11-25 Havoc Pennington <hp@redhat.com>
462 The primary change here is to always write() once before adding
463 the write watch, which gives us about a 10% performance increase.
465 * dbus/dbus-transport-unix.c: a number of modifications to cope
466 with removing messages_pending
467 (check_write_watch): properly handle
468 DBUS_AUTH_STATE_WAITING_FOR_MEMORY; adapt to removal of
469 messages_pending stuff
470 (check_read_watch): properly handle WAITING_FOR_MEMORY and
472 (unix_handle_watch): after writing, see if the write watch can be
474 (unix_do_iteration): assert that write_watch/read_watch are
475 non-NULL rather than testing that they aren't, since they
476 aren't allowed to be NULL. check_write_watch() at the end so
477 we add the watch if we did not finish writing (e.g. got EAGAIN)
479 * dbus/dbus-transport-protected.h: remove messages_pending call,
480 since it resulted in too much inefficient watch adding/removing;
481 instead we now require that the transport user does an iteration
482 after queueing outgoing messages, and after trying the first
483 write() we add a write watch if we got EAGAIN or exceeded our
484 max bytes to write per iteration setting
486 * dbus/dbus-string.c (_dbus_string_validate_signature): add this
489 * dbus/dbus-server-unix.c (unix_finalize): the socket name was
490 freed and then accessed, valgrind flagged this bug, fix it
492 * dbus/dbus-message.c: fix several bugs where HEADER_FIELD_LAST was taken
493 as the last valid field plus 1, where really it is equal to the
494 last valid field. Corrects some message corruption issues.
496 * dbus/dbus-mainloop.c: verbosity changes
498 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): handle OOM
499 instead of aborting in one of the test codepaths
501 * dbus/dbus-internals.c (_dbus_verbose_real): fix a bug that
502 caused not printing the pid ever again if a verbose was missing
503 the newline at the end
504 (_dbus_header_field_to_string): add HEADER_FIELD_SIGNATURE
506 * dbus/dbus-connection.c: verbosity changes;
507 (dbus_connection_has_messages_to_send): new function
508 (_dbus_connection_message_sent): no longer call transport->messages_pending
509 (_dbus_connection_send_preallocated_unlocked): do one iteration to
510 try to write() immediately, so we can avoid the write watch. This
511 is the core purpose of this patchset
512 (_dbus_connection_get_dispatch_status_unlocked): if disconnected,
513 dump the outgoing message queue, so nobody will get confused
514 trying to send them or thinking stuff is pending to be sent
516 * bus/test.c: verbosity changes
518 * bus/driver.c: verbosity/assertion changes
520 * bus/dispatch.c: a bunch of little tweaks to get it working again
521 because this patchset changes when/where you need to block.
523 2004-11-23 Havoc Pennington <hp@redhat.com>
525 * test/glib/test-profile.c: modify to accept a plain_sockets
526 argument in which case it will bench plain sockets instead of
527 libdbus, for comparison purposes.
529 2004-11-22 Havoc Pennington <hp@redhat.com>
531 * test/glib/test-profile.c (N_CLIENT_THREADS): run multiple
532 threads for more time, so sysprof can get a grip on it.
534 * dbus/dbus-string.c (_dbus_string_validate_utf8): remove
537 2004-11-13 Havoc Pennington <hp@redhat.com>
539 * test/glib/test-profile.c: fix this thing up a bit
541 * dbus/dbus-message.c (dbus_message_new_empty_header): increase
542 preallocation sizes by a fair bit; not sure if this will be an
543 overall performance win or not, but it does reduce reallocs.
545 * dbus/dbus-string.c (set_length, reallocate_for_length): ignore
546 the test hack that forced constant realloc if asserts are
547 disabled, so we can profile sanely. Sprinkle in some
548 _DBUS_UNLIKELY() which are probably pointless, but before I
549 noticed the real performance problem I put them in.
550 (_dbus_string_validate_utf8): micro-optimize this thing a little
551 bit, though callgrind says it didn't help; then special-case
552 ascii, which did help a lot; then be sure we detect nul bytes as
553 invalid, which is a bugfix.
554 (align_length_then_lengthen): add some more _DBUS_UNLIKELY
555 superstition; use memset to nul the padding instead of a manual
557 (_dbus_string_get_length): inline this as a
558 macro; it showed up in the profile because it's used for loop
561 2004-11-10 Colin Walters <walters@verbum.org>
563 * dbus/dbus-spawn.c (check_babysit_events): Handle EINTR,
566 2004-11-09 Colin Walters <walters@verbum.org>
568 * dbus/dbus-string.c (_dbus_string_get_length): New
569 function, writes DBusString to C buffer.
571 * dbus/dbus-string.h: Prototype it.
573 * dbus/dbus-message.c (dbus_message_type_to_string): New
574 function, converts message type into C string.
576 * dbus/dbus-message.h: Prototype it.
578 * bus/selinux.c (bus_selinux_check): Take source pid,
579 target pid, and audit data. Pass audit data to
581 (log_audit_callback): New function, appends extra
583 (bus_selinux_allows_acquire_service): Also take
584 service name, add it to audit data.
585 (bus_selinux_allows_send): Also take message
586 type, interface, method member, error name,
587 and destination, and add them to audit data.
588 (log_cb): Initialize func_audit.
590 * bus/selinux.h (bus_selinux_allows_acquire_service)
591 (bus_selinux_allows_send): Update prototypes
593 * bus/services.c (bus_registry_acquire_service): Pass
594 service name to bus_selinux_allows_acquire_service.
596 * bus/bus.c (bus_context_check_security_policy): Pass
597 additional audit data. Move assignment of dest
600 2004-11-07 Colin Walters <walters@verbum.org>
602 * dbus/dbus-transport-unix.c (do_authentication): Always
603 initialize auth_completed.
605 2004-11-07 Colin Walters <walters@verbum.org>
607 * bus/bus.c (load_config): Break into three
608 separate functions: process_config_first_time_only,
609 process_config_every_time, and process_config_postinit.
610 (process_config_every_time): Move call of
611 bus_registry_set_service_context_table into
612 process_config_postinit.
613 (process_config_postinit): New function, does
614 any processing that needs to happen late
615 in initialization (and also on reload).
616 (bus_context_new): Instead of calling load_config,
617 open config parser here and call process_config_first_time_only
618 and process_config_every_time directly. Later, after
619 we have forked but before changing UID,
620 invoke bus_selinux_full_init, and then call
621 process_config_postinit.
622 (bus_context_reload_config): As in bus_context_new,
623 load parse file inside here, and call process_config_every_time
624 and process_config_postinit.
626 * bus/services.h, bus/services.c
627 (bus_registry_set_service_context_table): Rename
628 from bus_registry_set_sid_table. Take string hash from config
629 parser, and convert them here into SIDs.
631 * bus/config-parser.c (struct BusConfigParser): Have
632 config parser only store a mapping of service->context
634 (merge_service_context_hash): New function.
635 (merge_included): Merge context string hashes instead
636 of using bus_selinux_id_table_union.
637 (bus_config_parser_new): Don't use bus_selinux_id_table_new;
638 simply create a new string hash.
639 (bus_config_parser_unref): Unref it.
640 (start_selinux_child): Simply insert strings into hash,
641 don't call bus_selinux_id_table_copy_over.
643 * bus/selinux.h, bus/selinux.c (bus_selinux_id_table_union)
644 (bus_selinux_id_table_copy_over): Delete.
646 2004-11-03 Colin Walters <walters@verbum.org>
648 * bus/selinux.c (bus_selinux_pre_init): Kill some unused
651 2004-11-03 Colin Walters <walters@verbum.org>
653 * bus/test-main.c (test_pre_hook): Fix test logic,
654 thanks Joerg Barfurth <Joerg.Barfurth@Sun.COM>.
656 2004-11-02 Colin Walters <walters@redhat.com>
658 * bus/selinux.c (bus_selinux_init): Split into two functions,
659 bus_selinux_pre_init and bus_selinux_post_init.
660 (bus_selinux_pre_init): Just determine whether SELinux is
662 (bus_selinux_post_init): Do everything else.
664 * bus/main.c (main): Call bus_selinux_pre_init before parsing
665 config file, and bus_selinux_post_init after. This ensures that
666 we don't lose the policyreload notification thread that
667 bus_selinux_init created before forking previously.
669 * bus/test-main.c (test_pre_hook): Update for split.
671 2004-10-31 Owen Fraser-Green <owen@discobabe.net>
673 Patch from Johan Fischer <linux@fischaz.com>
675 * mono/doc/Makefile.am (install-data-local): Added directory
678 2004-10-29 Colin Walters <walters@redhat.com>
680 * dbus/dbus-sysdeps.h (_dbus_become_daemon): Also take
681 parameter for fd to write pid to.
683 * dbus/dbus-sysdeps.c (_dbus_become_daemon): Implement it.
685 * bus/bus.c (bus_context_new): Pass print_pid_fd
686 to _dbus_become_daemon (bug #1720)
688 2004-10-29 Colin Walters <walters@redhat.com>
690 Patch from Ed Catmur <ed@catmur.co.uk>
692 * mono/doc/Makefile.am (install-data-local): Handle
695 2004-10-29 Colin Walters <walters@redhat.com>
697 * bus/.cvsignore, qt/.cvsignore: Update.
699 2004-10-29 Colin Walters <walters@redhat.com>
701 Patch from Kristof Vansant <de_lupus@pandora.be>
703 * configure.in: Detect Slackware.
704 * bus/Makefile.am (SCRIPT_IN_FILES): Add rc.messagebus.in.
705 * bus/rc.messagebus.in: New file.
707 2004-10-29 Colin Walters <walters@redhat.com>
709 * tools/dbus-monitor.c (filter_func): Return
710 DBUS_HANDLER_RESULT_HANDLED in filter function
712 http://freedesktop.org/pipermail/dbus/2004-August/001433.html
714 2004-10-29 Colin Walters <walters@redhat.com>
716 Patch from Matthew Rickard <mjricka@epoch.ncsc.mil>
718 * bus/services.c (bus_registry_acquire_service):
719 Correctly retrieve service name from DBusString
722 2004-10-29 Colin Walters <walters@redhat.com>
724 * dbus/dbus-glib.h: Update documentation to not
725 refer to internal APIs.
727 2004-10-27 Joe Shaw <joeshaw@novell.com>
729 * mono/Arguments.cs (GetDBusTypeConstructor):
730 type.UnderlyingSystemType will return "System.Byte" if you do it
731 on "byte[]", which is not what we want. So check the type.IsArray
732 property and use System.Array instead.
734 2004-10-25 John (J5) Palmieri <johnp@redhat.com>
736 * dbus/dbus-sysdeps.c (fill_user_info): On errors do not free
737 the DBusUserInfo structure since this is passed into the function.
738 This would cause a double free when the function that allocated
739 the structure would try to free it when an error occured.
741 * (bus/session.conf.in, bus/Makefile.am, dbus/configure.in):
742 use /usr/share/dbus-1/services instead of /usr/lib/dbus-1.0/services
743 for service activation to avoid 32bit/64bit parallel install issues
745 2004-10-21 Colin Walters <walters@verbum.org>
747 * AUTHORS: Fix my email address, the @gnu.org one
748 has been bouncing for some time. Also add J5.
750 2004-10-21 Colin Walters <walters@verbum.org>
752 * dbus/dbus-transport-unix.c (do_authentication): Return
753 authentication status to callers.
754 (unix_handle_watch): If we completed authentication this round,
755 don't do another read. Instead wait until the next iteration,
756 after we've read any pending data in the auth buffer.
757 (unix_do_iteration): Ditto.
758 (unix_handle_watch): Updated for new do_authentication prototype.
760 2004-10-18 Colin Walters <walters@verbum.org>
762 * bus/selinux.c (bus_selinux_enabled): Handle
763 --disable-selinux case.
765 2004-10-18 Colin Walters <walters@verbum.org>
767 * bus/selinux.h: Add bus_selinux_enabled.
769 * bus/selinux.c (bus_selinux_enabled): Implement it.
771 * bus/config-parser.c (struct include): Add
772 if_selinux_enabled member.
773 (start_busconfig_child): Parse if_selinux_enabled
774 attribute for include.
775 (bus_config_parser_content): Handle it.
777 * bus/session.conf.in, bus/system.conf.in: Add
778 inclusion of context mapping to default config files;
779 conditional on SELinux being enabled.
781 * doc/busconfig.dtd: Add to if_selinux_enabled to default DTD.
783 * test/data/invalid-config-files/badselinux-1.conf,
784 test/data/invalid-config-files/badselinux-2.conf:
785 Test files for bad syntax.
787 2004-10-17 Colin Walters <walters@verbum.org>
789 * dbus/dbus-memory.c (_dbus_initialize_malloc_debug, check_guards)
790 (dbus_malloc, dbus_malloc0, dbus_realloc): Fix up printf
791 format specifier mismatches.
793 2004-10-07 Olivier Andrieu <oliv__a@users.sourceforge.net>
795 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): fix an incorrect
798 * glib/dbus-dbus-gmain.c (dbus_g_bus_get): do not mangle NULL
799 pointer (bug #1540, Leonardo Boiko).
801 2004-09-28 Jon Trowbridge <trow@ximian.com>
803 * mono/BusDriver.cs: Changed BusDriver struct to remove
804 the ServiceCreated and ServiceDeleted events and replace them
805 with the new ServiceOwnerChanged event.
807 * mono/example/BusListener.cs: Added a new example program,
808 which listens for and reports any ServiceOwnerChanged events
811 * mono/example/Makefile.am (DESTDIR): Build changes for the
812 new BusListener.cs example.
814 2004-09-27 Olivier Andrieu <oliv__a@users.sourceforge.net>
816 * bus/signals.c (bus_match_rule_parse): validate the components of
817 match rules (bug #1439).
819 * dbus/dbus-bus.c (dbus_bus_add_match): add a missing OOM test.
821 2004-09-24 Olivier Andrieu <oliv__a@users.sourceforge.net>
823 * doc/dbus-specification.xml: document ServiceOwnerChanged
826 * bus/driver.c, bus/driver.h, bus/services.c: Use
827 ServiceOwnerChanged signal instead of ServiceCreated and
830 * bus/dispatch.c: update testcase for the new signal.
832 2004-09-20 Jon Trowbridge <trow@ximian.com>
834 Patch from Nat Friedman <nat@novell.com>
836 * mono/Makefile.am: A number of small build fixes to allow "make
837 distcheck" to succeed.
839 * mono/example/Makefile.am: "make distcheck" fixes.
841 * mono/AssemblyInfo.cs.in: When signing the assembly, look for the
844 * test/Makefile.am: "make distcheck" fixes.
846 2004-09-17 Olivier Andrieu <oliv__a@users.sourceforge.net>
848 * dbus/dbus-sysdeps.c (_dbus_user_at_console): fix memleak in OOM.
850 * doc/busconfig.dtd: update the DTD for the at_console attribute.
852 * bus/driver.c (bus_driver_handle_hello): correctly handle Hello
853 messages after the first one (bug #1389).
855 * bus/dispatch.c (check_double_hello_message): add a test case for
856 the double hello message bug.
857 (check_existent_service_activation): fix check of spawning error.
859 2004-09-16 David Zeuthen <david@fubar.dk>
861 * python/dbus_bindings.pyx.in: Add support for int64 and uint64
863 2004-09-12 David Zeuthen <david@fubar.dk>
865 Patch from Kay Sievers <kay.sievers@vrfy.org>
867 * bus/bus.c (bus_context_new):
871 Add commandline option --nofork to override configuration file
874 2004-09-09 Olivier Andrieu <oliv__a@users.sourceforge.net>
876 * dbus/dbus-*.h: remove the ; after DBUS_(BEGIN|END)_DECLS. Some C
877 compilers don't like it (bug #974).
879 2004-09-04 Harald Fernengel <harry@kdevelop.org>
881 * qt/connection.*: Applied patch by Jérôme Lodewyck
882 <lodewyck@clipper.ens.fr> to integrate an existing
883 connection into the Qt eventloop
885 2004-08-30 Jon Trowbridge <trow@ximian.com>
887 * mono/BusDriver.cs: Added. This is a class for interacting with
888 the org.freedesktop.DBus service.
890 * mono/Message.cs: Added a mechanism to expose the message that is
891 currently being dispatched via the static Message.Current
892 property. Added Message.Sender and Message.Destination
895 * mono/Handler.cs: Expose the dispatched message via
896 Message.Current when handling method calls.
898 * mono/Service.cs: Expose the dispatched message via
899 Message.Current when handling signal emissions.
901 * mono/Connection.cs: Bind dbus_bus_get_base_service via the
902 Connection.BaseService property.
904 2004-08-28 Havoc Pennington <hp@redhat.com>
906 * dbus/dbus-userdb.c (_dbus_is_console_user): remove unused variable
908 More fixes from Steve Grubb
910 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): fix fd leak
911 (_dbus_listen_tcp_socket): fix fd leak
913 * dbus/dbus-spawn.c (read_pid, read_ints): move the "again:" for
914 EINTR to a bit lower in the code
916 2004-08-26 Jon Trowbridge <trow@ximian.com>
918 * bus/driver.c (bus_driver_handle_service_exists): Respond with
919 TRUE if we are inquiring about the existence of the built-in
920 org.freedesktop.DBus service.
922 2004-08-25 John Palmieri <johnp@redhat.com>
923 * bus/config-parser.c:
924 (struct PolicyType): Add POLICY_CONSOLE
925 (struct Element.d.policy): s/gid_or_uid/gid_uid_or_at_console
926 (start_busconfig_child): Sets up console element when
927 <policy at_console=""> is encountered in a policy file
928 (append_rule_from_element): Convert console elements to console
932 (bus_policy_create_client_policy): Add console rules to the client
933 policy based on if the client is at the console
934 (bus_policy_append_console_rule): New function for adding a
935 console rule to a policy
936 (bus_policy_merge): Handle console rule merging
938 * dbus/dbus-sysdeps.h: Added the DBUS_CONSOLE_DIR constant
939 where we check for console user files
941 * dbus/dbus-sysdeps.c:
942 (_dbus_file_exists): New function which checks if the given
944 (_dbus_user_at_console): New function which does the system
945 specific process of checking if the user is at the console
947 * dbus/dbus-userdb.c:
948 (_dbus_is_console_user): New function converts a UID to user name
949 and then calls the system specific _dbus_user_at_console to
950 see if the user is at the console and therefor a console user
952 2004-08-25 Olivier Andrieu <oliv__a@users.sourceforge.net>
954 * bus/config-parser.c (set_limit):
955 * bus/dbus-daemon-1.1.in:
956 * test/data/valid-config-files/many-rules.conf: set the
957 max_match_rules_per_connection limt from the config file.
959 * doc/busconfig.dtd: update the DTD.
961 * bus/driver.c: remove some unused variables.
963 2004-08-24 Mikael Hallendal <micke@imendio.com>
965 * dbus/dbus-glib-lowlevel.h: Removed dbus_bus_get_with_g_main since
966 it's been replaced by dbus_g_bus_get
968 2004-08-23 Colin Walters <walters@redhat.com>
970 Updated SELinux support from Matthew Rickard <mjricka@epoch.ncsc.mil>
972 * bus/selinux.h: Prototype bus_selinux_get_policy_root.
974 * bus/selinux.c: Create a thread for policy reload notification.
975 (bus_selinux_get_policy_root): Implement.
977 * bus/config-parser.c (start_busconfig_child)
978 (bus_config_parser_content): Support SELinux-root relative
981 * configure.in <HAVE_SELINUX>: Add -lpthread.
983 * bus/test-main.c (test_pre_hook, test_post_hook): New.
984 (test_post_hook): Move memory checking into here.
985 (test_pre_hook, test_post_hook): Move SELinux checks in
986 here, but conditional on a DBUS_TEST_SELINUX environment
987 variable. Unfortunately we can't run the SELinux checks
988 as a normal user, since they won't have any permissions
989 for /selinux. So this will have to be tested manually
990 for now, until we have virtualization for most of
993 2004-08-23 Havoc Pennington <hp@redhat.com>
995 * dbus/dbus-sysdeps.c (_dbus_change_identity): add setgroups() to
996 drop supplementary groups, suggested by Steve Grubb
998 2004-08-20 Colin Walters <walters@redhat.com>
1000 * bus/config-parser.c (start_busconfig_child): Remove some unused
1003 * bus/selinux.c (bus_selinux_id_table_insert): Avoid compiler
1006 2004-08-17 Joe Shaw <joeshaw@novell.com>
1008 * configure.in: If --enable-mono is passed in, if we can't find
1011 * mono/Makefile.am: Use /gacutil to install assemblies into the
1014 2004-08-12 Havoc Pennington <hp@redhat.com>
1016 * NEWS: update for 0.22
1018 * configure.in: release 0.22
1020 2004-08-11 Colin Walters <walters@redhat.com>
1022 * tools/dbus-send.c (main, usage): Add --reply-timeout
1025 2004-08-10 Olivier Andrieu <oliv__a@users.sourceforge.net>
1027 * bus/bus.c (process_config_first_time_only): get rid of an unused
1028 DBusError that was causing a memoy leak (bug #989).
1030 * dbus/dbus-keyring.c, dbus/dbus-message.c:
1031 fix compilation on Solaris/Forte C (bug #974)
1033 * bus/main.c (main): plug two minuscule memleaks.
1035 2004-08-10 Havoc Pennington <hp@redhat.com>
1037 * doc/dbus-tutorial.xml: add some more info on GLib bindings
1039 2004-08-09 Havoc Pennington <hp@redhat.com>
1041 * COPYING: switch to Academic Free License version 2.1 instead of
1042 2.0, to resolve complaints about patent termination clause.
1044 2004-07-31 John (J5) Palmieri <johnp@redhat.com>
1046 * README: added documentation for the --enable-python
1049 2004-07-31 Olivier Andrieu <oliv__a@users.sourceforge.net>
1051 * bus/config-parser.c (bus_config_parser_new): fix an invalid
1052 _unref in the SELinux support.
1054 * doc/busconfig.dtd: update DTD for SELinux support.
1056 * bus/config-loader-libxml.c: fix error handler and parser
1057 initialisation/cleanup. OOM test now works with libxml2 HEAD.
1059 * configure.in: remove the warning about libxml2.
1061 * dbus/dbus-bus.c: silence doxygen warning.
1063 2004-07-31 Colin Walters <walters@redhat.com>
1065 * configure.in: Move #error in SELinux check to its own line.
1067 2004-07-31 Olivier Andrieu <oliv__a@users.sourceforge.net>
1069 * dbus/dbus-internals.h (_DBUS_SET_OOM):
1070 * bus/utils.h (BUS_SET_OOM): use dbus_error_set_const instead of
1073 * bus/dispatch.c (check_send_exit_to_service): fix the test case,
1074 broken by the change in the _SET_OOM macros.
1076 2004-07-31 Colin Walters <walters@redhat.com>
1078 * bus/selinux.c <HAVE_SELINUX>: Include utils.h to get
1081 2004-07-31 Colin Walters <walters@redhat.com>
1083 * configure.in: Use AC_TRY_COMPILE instead of AC_EGREP_HEADER
1084 to correctly detect DBUS__ACQUIRE_SVC. Also add an
1087 2004-07-24 Havoc Pennington <hp@redhat.com>
1089 SELinux support from Matthew Rickard <mjricka@epoch.ncsc.mil>
1091 * bus/selinux.c, bus/selinux.h: new file encapsulating selinux
1094 * configure.in: add --enable-selinux
1096 * bus/policy.c (bus_policy_merge): add FIXME to a comment
1098 * bus/main.c (main): initialize and shut down selinux
1100 * bus/connection.c: store SELinux ID on each connection, to avoid
1101 repeated getting of the string context and converting it into
1104 * bus/bus.c (bus_context_get_policy): new accessor, though it
1106 (bus_context_check_security_policy): check whether the security
1107 context of sender connection can send to the security context of
1108 recipient connection
1110 * bus/config-parser.c: add parsing for <selinux> and <associate>
1112 * dbus/dbus-transport.c (_dbus_transport_get_unix_fd): to
1113 implement dbus_connection_get_unix_fd()
1115 * dbus/dbus-connection.c (dbus_connection_get_unix_fd): new
1116 function, used by the selinux stuff
1118 2004-07-29 Olivier Andrieu <oliv__a@users.sourceforge.net>
1120 * bus/config-loader-libxml.c: complete the implementation of
1121 libxml backend for config file loader. Doesn't work with full OOM
1124 * configure.in: change error when selecting libxml into a warning.
1126 * test/data/invalid-config-files: add two non-well-formed XML
1129 * glib/Makefile.am: libdbus_gtool always uses expat, not libxml.
1131 * dbus/dbus-transport-unix.c (unix_handle_watch): do not
1132 disconnect in case of DBUS_WATCH_HANGUP, several do_reading() may
1133 be necessary to read all the buffer. (bug #894)
1135 * bus/activation.c (bus_activation_activate_service): fix a
1136 potential assertion failure (bug #896). Small optimization in the
1137 case of auto-activation messages.
1139 * dbus/dbus-message.c (verify_test_message, _dbus_message_test):
1140 add test case for byte-through-vararg bug (#901). patch by Kimmo
1143 2004-07-28 Anders Carlsson <andersca@gnome.org>
1146 * python/dbus_bindings.pyx.in:
1147 Add dbus.init_gthreads (), allow emit_signal to pass
1148 arguments to the signal.
1150 2004-07-24 Havoc Pennington <hp@redhat.com>
1152 * AUTHORS: add some people, not really comprehensively, let me
1153 know if I missed you
1155 2004-07-24 Havoc Pennington <hp@redhat.com>
1157 * Makefile.am (DIST_SUBDIRS): add DIST_SUBDIRS, problem solved by
1160 * test/Makefile.am (DIST_SUBDIRS): here also
1162 2004-07-22 Olivier Andrieu <oliv__a@users.sourceforge.net>
1164 * dbus/dbus-sysdeps.c (fill_user_info): fix inexistent label name,
1165 breaking build on Solaris, reported by Farhad Saberi on the ML.
1167 * dbus/dbus-message.c (dbus_message_append_args_valist): fix the
1168 va_arg invocation to account for integer promotion in the case of
1169 DBUS_TYPE_BYTE (unsigned char is promoted to int). (bug #901)
1171 * bus/services.c (bus_service_remove_owner): fix bug #902, use
1172 _dbus_list_get_first_link, not _dbus_list_get_first.
1174 * dbus/dbus-bus.c (dbus_bus_service_exists): plug a memory leak.
1176 * dbus/dbus-object-tree.c (free_subtree_recurse): always null
1177 handler functions so that the asserts in _dbus_object_subtree_unref
1180 * dbus/dbus-transport-unix.c (do_reading):
1181 _dbus_transport_queue_messages return value is of type
1182 dbus_bool_t, not DBusDispatchStatus.
1184 2004-07-19 David Zeuthen <david@fubar.dk>
1186 * dbus/dbus-protocol.h: Add DBUS_ERROR_UNIX_PROCESS_ID_UNKNOWN
1189 (check_get_connection_unix_user): Debug says GetProperty; but the
1190 method is called GetConnectionUnixUser
1191 (check_get_connection_unix_process_id): New function
1192 (bus_dispatch_test): Actually call check_get_connection_unix_user();
1193 also call check_get_connection_unix_process_id()
1196 (bus_driver_handle_get_connection_unix_process_id): New function,
1197 handles GetConnectionUnixProcessID on the org.freedesktop.DBus
1201 (handle_server_data_external_mech): Set pid from the credentials
1202 obtained from the socket
1204 * dbus/dbus-connection.c:
1205 (dbus_connection_get_unix_process_id): New function
1207 * dbus/dbus-connection.h:
1208 Add prototype for dbus_connection_get_unix_process_id
1210 * dbus/dbus-transport.c:
1211 (_dbus_transport_get_unix_process_id): New function
1213 * dbus/dbus-transport.h:
1214 Add prototype for _dbus_transport_get_unix_process_id
1216 2004-07-19 Olivier Andrieu <oliv__a@users.sourceforge.net>
1218 * dbus/dbus-message.c: Message counter fix, patch by Christian
1219 Hammond <chipx86@gnupdate.org>
1221 2004-07-18 Seth Nickell <seth@gnome.org>
1224 * python/dbus_bindings.pyx.in:
1225 * python/tests/test-client.py:
1227 Add dbus.ByteArray and dbus_bindings.ByteArray
1228 types so that byte streams can be passed back.
1230 Give jdahlin the heaps of credit that are so
1233 2004-07-12 Seth Nickell <seth@gnome.org>
1237 Add message argument to the default object_method_handler
1240 * python/dbus_bindings.pyx.in:
1242 Automatically return NIL when passed an empty list
1243 (we can't pass back a list since lists are typed
1244 and we don't have any idea what type the the client
1245 intended the list to be... :-( )
1247 2004-07-10 Seth Nickell <seth@gnome.org>
1249 * python/examples/Makefile.am:
1251 Fix distcheck breakage caused by new examples.
1253 2004-07-10 Seth Nickell <seth@gnome.org>
1257 Add "message" argument to service-side dbus.Object
1258 methods. This will break existing services written
1259 using the python bindings, but will allow extraction
1260 of all the message information (e.g. who its from).
1262 Add improved "object oriented" signal handling/emission.
1264 * python/examples/example-service.py:
1268 * python/examples/example-signal-emitter.py:
1269 * python/examples/example-signal-recipient.py:
1271 Two new examples that show how to emit and receive
1272 signals using the new APIs.
1274 * python/examples/example-signals.py:
1275 * python/examples/gconf-proxy-service.py:
1276 * python/examples/gconf-proxy-service2.py:
1278 Add "message" argument to service methods.
1280 2004-06-28 Kay Sievers <kay.sievers@vrfy.org>
1282 * bus/driver.c (bus_driver_handle_get_connection_unix_user)
1283 * dbus/bus.c (dbus_bus_get_unix_user)
1284 * doc/dbus-specification.xml: implement GetConnectionUnixUser
1285 method of org.freedesktop.DBus interface.
1287 * bus/dispatch.c: test case
1289 2004-06-23 John (J5) Palmieri <johnp@redhat.com>
1291 * python/Makefile.am: switched include directory from glib/ to dbus/
1292 since dbus-glib.h moved
1294 2004-06-22 Olivier Andrieu <oliv__a@users.sourceforge.net>
1296 * configure.in: prevent building the gcj stuff and libxml loader
1297 since they are broken.
1299 2004-06-20 Havoc Pennington <hp@redhat.com>
1301 * dbus/dbus-glib-error-enum.h: autogenerate the GError enum
1302 codes from the dbus error names
1304 * glib/dbus-glib.h: move to subdir dbus/ since it's included
1305 as dbus/dbus-glib.h and that breakage is now visible due to
1306 including dbus/dbus-glib.h in dbus-glib-lowlevel.h
1308 * glib/dbus-glib.h: s/gproxy/g_proxy/
1310 * dbus/dbus-shared.h: new header to hold stuff shared with
1313 * dbus/dbus-protocol.h (DBUS_ERROR_*): move errors here rather
1316 * glib/dbus-glib.h (dbus_set_g_error): move to
1317 dbus-glib-lowlevel.h
1319 * glib/dbus-glib.h: remove dbus/dbus.h from here; change a bunch
1320 of stuff to enable this
1322 * dbus/dbus-glib-lowlevel.h: put dbus/dbus.h here
1324 * a bunch of other changes with the same basic "separate glib
1325 bindings from dbus.h" theme
1327 2004-06-10 Owen Fraser-Green <owen@discobabe.net>
1329 * dbus-sharp.pc.in: Removed glib-sharp inclusion in Libs.
1331 * python/examples/Makefile.am: Fixed typo in EXTRA_DIST.
1333 2004-06-09 Olivier Andrieu <oliv__a@users.sourceforge.net>
1335 * bus/driver.c, dbus/dbus-bus.c: use BOOLEAN instead of UINT32 for
1336 the reply value of the ServiceExists message.
1338 2004-06-07 John (J5) Palmieri <johnp@redhat.com>
1340 * python/dbus_bindings.pyx.in: No longer need to parse path
1341 elements and pass them as arrays of strings. The C API now
1342 accepts plain path strings.
1343 (_build_parsed_path): removed
1345 2004-06-07 Havoc Pennington <hp@redhat.com>
1347 * doc/TODO: remove auto-activation item since it's done; sort
1348 items by importance/milestone
1350 2004-06-07 Havoc Pennington <hp@redhat.com>
1352 * dbus/dbus-message-builder.c (_dbus_message_data_load): append
1353 random signature when using REQUIRED_FIELDS (this hack won't work
1356 * dbus/dbus-message.c: change the signature to be a header field,
1357 instead of message->signature special-case string. Incremental
1358 step forward. Then we can fix up code to send the signature in the
1359 message, then fix up code to validate said signature, then fix up
1360 code to not put the typecodes inline, etc.
1361 (load_one_message): don't make up the signature after the fact
1362 (decode_header_data): require signature field for the known
1365 * dbus/dbus-marshal.c (_dbus_marshal_string_len): new
1367 * dbus/dbus-protocol.h: add DBUS_HEADER_FIELD_SIGNATURE
1369 2004-06-07 Owen Fraser-Green <owen@discobabe.net>
1371 * mono/DBusType/ObjectPath.cs: Renamed PathName argument to Path
1373 * mono/Handler.cs: Updated to follow new path argument for
1374 (un-)registering objects.
1376 * mono/example/Makefile.am:
1378 * configure.in: Bumped required version for mono and use new -pkg
1381 2004-06-05 Olivier Andrieu <oliv__a@users.sourceforge.net>
1383 * dbus/dbus-connection.h, dbus/dbus-connection.c: have object path
1384 registration functions take the path argument as char* instead of
1387 * dbus/dbus-marshal.h, dbus/dbus-marshal.c (_dbus_decompose_path):
1388 split off the path decompostion part of
1389 _dbus_demarshal_object_path. Some misc. fixes to silence compiler
1392 * glib/dbus-gobject.c, test/test-service.c: update accordingly.
1394 2004-06-02 Kristian Høgsberg <krh@redhat.com>
1396 * dbus/dbus-auth.c: Rewrite auth protocol handling to use a state
1397 machine approach. A state is implemented as a function that
1398 handles incoming events as specified for that state.
1400 * doc/dbus-specification.xml: Update auth protocol state machine
1401 specification to match implementation. Remove some leftover
1404 2004-06-02 Kristian Høgsberg <krh@redhat.com>
1406 * glib/dbus-gproxy.c, glib/dbus-gmain.c, dbus/dbus-string.c,
1407 dbus/dbus-object-tree.c, dbus/dbus-message.c: add comments to
1410 * Doxyfile.in: remove deprecated options.
1412 * dbus/dbus-message-handler.c, dbus/dbus-message-handler.h,
1413 glib/test-thread.h, glib/test-thread-client.c,
1414 glib/test-thread-server.c, glib/test-profile.c,
1415 glib/test-dbus-glib.c: remove these unused files.
1417 2004-06-01 Olivier Andrieu <oliv__a@users.sourceforge.net>
1419 * dbus/dbus-object-tree.c
1420 (_dbus_object_tree_dispatch_and_unlock): fix dispatch for
1421 non-fallback handlers (bug #684).
1422 (_dbus_object_subtree_new): initialize invoke_as_fallback field.
1423 (find_subtree_recurse): report wether the returned subtree is an
1424 exact match or a "fallback" match higher up in the tree.
1425 (object_tree_test_iteration): update test case.
1427 2004-06-01 Seth Nickell <seth@gnome.org>
1429 * python/dbus_bindings.pyx.in:
1430 * python/tests/test-client.py:
1432 Round off basic type support. Add dicts (yay!), and
1433 remaining array types.
1435 Make MessageIter more general so it works for dicts too.
1437 Mark all loop variables as C integers.
1439 2004-05-31 Havoc Pennington <hp@redhat.com>
1441 * glib/dbus-gidl.c (method_info_add_arg): keep args sorted with
1444 * glib/dbus-gobject.c (dbus_type_to_string): move to dbus-gutils.c
1446 * glib/dbus-glib-tool.c (main): set up to have a --self-test
1447 option that runs the tests, and start filling in some code
1448 including for starters just dumping the interfaces to stdout
1450 * glib/Makefile.am (INCLUDES): define DBUS_LOCALEDIR
1452 * test/data/valid-introspection-files/lots-of-types.xml: test of
1453 an example introspection file
1455 * glib/dbus-gparser.c (parser_check_doctype): doctype should be
1458 2004-05-31 Seth Nickell <seth@gnome.org>
1460 * python/dbus_bindings.pyx.in:
1461 * python/tests/test-client.py:
1466 Fix string array memory trashing bug... oops...
1468 2004-05-30 Seth Nickell <seth@gnome.org>
1472 Add a nicer-but-less-flexible alternate API for handling
1473 calls to virtual objects in dbus.ObjectTree.
1475 Screw up the argument order to the dbus.Object constructor
1476 for consistency with dbus.ObjectTree (and to make dbus_methods
1477 optional for future extension)
1479 * python/examples/Makefile.am:
1480 * python/examples/gconf-proxy-service.py:
1481 * python/examples/gconf-proxy-service2.py:
1483 Alternate implementation of gconf-proxy-service using the
1484 nicer dbus.ObjectTree API.
1486 * python/examples/example-service.py:
1487 * python/tests/test-server.py
1489 Reverse the argument order to deal with dbus.Object constructor
1492 2004-05-30 Seth Nickell <seth@gnome.org>
1494 * python/examples/example-client.py:
1495 * python/examples/example-service.py:
1497 Take it back. Lists seem to work but they're broken
1498 in the test suite. Make the base examples use
1501 2004-05-30 Seth Nickell <seth@gnome.org>
1503 * python/dbus_bindings.pyx.in:
1504 * python/tests/test-client.py:
1506 Add some more tests and fix errors that crop up.
1507 Unfortunately, currently it seems like marshalling
1508 and unmarshalling of lists is completely broken :-(
1510 2004-05-30 Seth Nickell <seth@gnome.org>
1512 * python/dbus_bindings.pyx.in:
1514 Add support for ObjectPath type.
1518 Refactor message handling code to a common function.
1520 * python/tests/test-client.py:
1521 * python/tests/test-server.py:
1523 Add tests that check to make sure values of all types
1524 can be echoed from a service w/o mangling.
1526 2004-05-29 Seth Nickell <seth@gnome.org>
1530 Add ObjectTree class which allows implementation
1531 of trees of "virtual" objects. Basically the python
1532 wrapper for "register_fallback".
1534 * python/examples/Makefile.am
1535 * python/examples/gconf-proxy-client.py:
1536 * python/examples/gconf-proxy-service.py:
1538 Implement a simple GConf proxy service that supports
1539 get/set on string and int GConf keys using the ObjectTree.
1541 2004-05-29 Seth Nickell <seth@gnome.org>
1544 * python/examples/example-client.py:
1545 * python/examples/example-service.py:
1546 * python/examples/list-system-services.py:
1548 Add SessionBus, SystemBus and ActivationBus classes
1549 so you don't need to know the special little BUS_TYPE
1552 2004-05-29 Havoc Pennington <hp@redhat.com>
1554 * bus/config-parser.c (process_test_valid_subdir): temporarily
1555 stop testing config parser OOM handling, since expat has issues
1556 http://freedesktop.org/pipermail/dbus/2004-May/001153.html
1558 * bus/dbus-daemon-1.1.in: change requested_reply to
1559 send_requested_reply/receive_requested_reply so we can send the
1560 replies, not just receive them.
1562 * bus/config-parser.c: parse the new
1563 send_requested_reply/receive_requested_reply
1565 * bus/policy.c (bus_client_policy_check_can_send): add
1566 requested_reply argument and use it
1568 * bus/bus.c (bus_context_check_security_policy): pass through
1569 requested_reply status to message send check
1571 * bus/system.conf.in: adapt to requested_reply change
1573 2004-05-28 Havoc Pennington <hp@redhat.com>
1575 * test/glib/test-service-glib.c (main): remove unused variable
1577 * glib/dbus-gidl.c (base_info_ref): fix a silly compiler warning
1579 * dbus/dbus-auth.h (enum): remove AUTHENTICATED_WITH_UNUSED_BYTES
1580 from the enum, no longer in use.
1582 * dbus/dbus-sysdeps.h: include config.h so DBUS_VA_COPY actually
1585 * dbus/dbus-message.c: add various _dbus_return_val_if_fail for
1586 whether error_name passed in is a valid error name.
1588 2004-05-28 John (J5) Palmieri <johnp@redhat.com>
1590 * dbus/dbus-message.c (dbus_message_get_args): Added support for
1591 OBJECT_PATH and OBJECT_PATH_ARRAY
1593 2004-05-28 Seth Nickell <seth@gnome.org>
1595 * python/examples/Makefile.am:
1597 Forget to add Makefile.am. Do not pass go.
1599 2004-05-28 Michael Meeks <michael@ximian.com>
1601 * glib/dbus-gvalue.c (dbus_gvalue_marshal, dbus_gvalue_demarshal):
1604 * dbus/dbus-string.c (_dbus_string_parse_basic_type): impl.
1606 * dbus/dbus-message.c (_dbus_message_iter_get_basic_type),
1607 (_dbus_message_iter_get_basic_type_array): impl.
1608 drastically simplify ~all relevant _get methods to use these.
1609 (_dbus_message_iter_append_basic_array),
1610 (dbus_message_iter_append_basic): impl
1611 drastically simplify ~all relevant _append methods to use these.
1613 * dbus/dbus-message-builder.c (parse_basic_type)
1614 (parse_basic_array, lookup_basic_type): impl.
1615 (_dbus_message_data_load): prune scads of duplicate /
1618 * dbus/dbus-marshal.c (_dbus_demarshal_basic_type_array)
1619 (_dbus_demarshal_basic_type): implement,
1620 (demarshal_and_validate_len/arg): beef up debug.
1621 (_dbus_marshal_basic_type, _dbus_marshal_basic_type_array): impl.
1623 2004-05-27 Seth Nickell <seth@gnome.org>
1626 * python/Makefile.am:
1628 Include the example python apps in the tarball.
1630 * python/examples/list-system-services.py
1632 Add a python new example that fetches the list of services
1633 from the system bus.
1635 2004-05-27 Seth Nickell <seth@gnome.org>
1638 * python/dbus_bindings.pyx.in:
1640 Fix failure to notify that a signal was not handled,
1641 resulted in hung functions.
1643 2004-05-25 Colin Walters <walters@redhat.com>
1645 * tools/dbus-monitor.c (main): Monitor all types of messages.
1647 2004-05-23 Owen Fraser-Green <owen@discobabe.net>
1649 * mono/Handler.cs, mono/Service.cs: Added UnregisterObject method
1650 which unregisters the object path and disposes the handler.
1652 2004-05-23 Kristian Høgsberg <krh@redhat.com>
1654 Patch from Timo Teräs <ext-timo.teras@nokia.com> (#614):
1656 * dbus/dbus-message.c (dbus_message_iter_get_args_valist): Swap
1657 operands to && so we call dbus_message_iter_next () for the last
1660 2004-05-21 Olivier Andrieu <oliv__a@users.sourceforge.net>
1662 * dbus/dbus-object-tree.c
1663 (_dbus_object_tree_list_registered_unlock, lookup_subtree): return
1664 children even if the requested path isn't registered.
1665 (object_tree_test_iteration): test object_tree_list_registered.
1667 * configure.in: undefine HAVE_ABSTRACT_SOCKETS instead of defining
1670 2004-05-20 Kristian Høgsberg <krh@redhat.com>
1672 * doc/TODO: Remove resolved items.
1674 * bus/expirelist.h (struct BusExpireList): remove unused n_items
1677 * bus/connection.c (bus_connections_expect_reply): Enforce the
1678 per-connection limit on pending replies.
1680 Patch from Jon Trowbridge <trow@ximian.com>:
1682 * bus/main.c (setup_reload_pipe): Added. Creates a pipe and sets
1683 up a watch that triggers a config reload when one end of the pipe
1685 (signal_handler): Instead of doing the config reload in our SIGHUP
1686 handler, just write to the reload pipe and let the associated
1687 watch handle the reload when control returns to the main loop.
1689 * bus/driver.c (bus_driver_handle_reload_config): Added.
1690 Implements a ReloadConfig method for requesting a configuration
1691 file reload via the bus driver.
1693 2004-05-19 Owen Fraser-Green <owen@discobabe.net>
1695 * HACKING: Updated release instructions concerning the wiki page.
1697 2004-05-18 Kristian Høgsberg <krh@redhat.com>
1699 * dbus/dbus-auth.c (client_try_next_mechanism): Remove logic to
1700 filter against auth->allowed_mechs; we only add allowed mechs in
1701 record_mechanisms().
1703 * dbus/dbus-auth-script.c (_dbus_auth_script_run): Add an
1704 ALLOWED_MECHS to auth-script format so we can set the list of
1707 * data/auth/client-out-of-mechanisms.auth-script: New test to
1708 check client disconnects when it is out of mechanisms to try.
1710 * dbus/dbus-auth.c (process_command): Remove check for lines
1711 longer that 1 MB; we only buffer up maximum 16 kB.
1713 * dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
1714 dbus/dbus-auth-script.c, dbus/dbus-auth.c, dbus/dbus-auth.h:
1715 Remove auth state AUTHENTICATED_WITH_UNUSED_BYTES, instead always
1716 assume there might be unused bytes.
1718 * dbus/dbus-auth.c (_dbus_auth_do_work): Remove check for
1719 client-out-of-mechs, it is handled in process_reject(). Move check
1720 for max failures to send_rejected(), as it's a server-only thing.
1722 * dbus/dbus-auth.c: Factor out protocol reply code into functions
1723 send_auth(), send_data(), send_rejected(), send_error(),
1724 send_ok(), send_begin() and send_cancel().
1726 2004-05-17 Kristian Høgsberg <krh@redhat.com>
1728 Remove base64 encoding, replace with hex encoding. Original patch
1729 from trow@ximian.com, added error handling.
1731 * dbus/dbus-string.c (_dbus_string_base64_encode)
1732 (_dbus_string_base64_decode): Remove.
1733 (_dbus_string_hex_decode): Add end_return argument so we can
1734 distinguish between OOM and invalid hex encoding.
1735 (_dbus_string_test): Remove base64 tests and add test case for
1738 * dbus/dbus-keyring.c, dbus/dbus-auth-script.c, dbus/dbus-auth.c:
1739 Replace base64 with hex.
1741 * test/data/auth/invalid-hex-encoding.auth-script: New test case
1742 for invalid hex encoded data in auth protocol.
1744 2004-05-17 Olivier Andrieu <oliv__a@users.sourceforge.net>
1746 * dbus/dbus-connection.c (check_for_reply_unlocked): plug a memory
1749 2004-05-15 Owen Fraser-Green <owen@discobabe.net>
1751 * mono/dbus-sharp.dll.config.in: Added for GAC
1752 * mono/dbus-sharp.snk: Added for GAC
1753 * mono/Assembly.cs.in: Added for GAC
1754 * mono/Makefile.am: Changes for GAC installation
1755 * configure.in: Added refs for dbus-sharp.dll.config.in and
1756 Assembly.cs.in. More fixes for mono testing
1757 * mono/example/Makefile.am: Changed var to CSC
1758 * Makefile.am: Changed flag name to DBUS_USE_CSC
1760 2004-05-15 Owen Fraser-Green <owen@discobabe.net>
1762 * mono/Makefile.am: Added SUBDIRS for docs. Changed SUBDIRS order
1763 * mono/doc/*: Added documentation framework
1764 * configure.in: Added monodoc check
1765 * README: Added description of mono configure flags
1767 2004-05-11 John (J5) Palmieri <johnp@redhat.com>:
1769 * doc/dbus-specification.xml: Added a "Required" column to the
1770 header fields table and changed the "zero or more" verbage in
1771 the above paragraph to read "The header must contain the required
1772 named header fields and zero or more of the optional named header
1774 * test/data/invalid-messages/*.message: Added the required PATH
1775 named header field to the tests so that they don't fail on
1776 'Missing path field'
1778 2004-05-07 John (J5) Palmieri <johnp@redhat.com>
1780 * python/dbus-bindings.pyx.in: Stopped the bindings from trashing
1781 the stack by implicitly defining variable and parameter types and
1782 removing the hack of defining C pointers as python objects and later
1785 2004-05-02 Owen Fraser-Green <owen@discobabe.net>
1787 * mono/Makefile.am: Removed test-dbus-sharp.exe from all target
1789 2004-05-01 Owen Fraser-Green <owen@discobabe.net>
1791 * mono/DBusType/Dict.cs: Handle empty dicts
1792 * mono/DBusType/Array.cs: Handle empty arrays
1793 * mono/Arguments.cs: Handle empty arguments
1795 2004-04-30 Owen Fraser-Green <owen@discobabe.net>
1797 * dbus-sharp.pc.in: Modified to include include Libs and Requires
1800 2004-04-25 Kristian Høgsberg <krh@redhat.com>
1802 * test/data/valid-messages/standard-*.message: Update message
1803 test scripts to new header field names.
1805 2004-04-22 John (J5) Palmieri <johnp@redhat.com>
1807 * test/break-loader.c (randomly_do_n_things): tracked down buffer
1808 overflow to times_we_did_each_thing array which would chop off the
1809 first character of the failure_dir string. Increased the size of
1810 the array to 7 to reflect the number of random mutation functions
1813 2004-04-21 Kristian Høgsberg <krh@redhat.com>
1815 * dbus/dbus-server-unix.c (unix_finalize): Don't unref
1816 unix_server->watch here, it is unreffed in disconnect.
1817 (_dbus_server_new_for_tcp_socket): convert NULL host to
1818 "localhost" here so we don't append NULL to address.
1820 * dbus/dbus-server.c (_dbus_server_test): Add test case for
1821 various addresses, including tcp with no explicit host.
1823 2004-04-21 Olivier Andrieu <oliv__a@users.sourceforge.net>
1825 * dbus/dbus-message.c (decode_header_data, decode_string_field):
1826 fix incorrect setting of .name_offset in the HeaderField (it was
1827 off by two bytes, positioned right after the name and typecode)
1829 * bus/bus.c (bus_context_new, bus_context_unref): test before
1830 calling dbus_server_free_data_slot and _dbus_user_database_unref
1831 in case of an error.
1833 * tools/Makefile.am: add $(DBUS_GLIB_TOOL_LIBS), xml libs needed
1836 2004-04-19 Kristian Høgsberg <krh@redhat.com>
1838 * dbus/dbus-transport-unix.c (unix_do_iteration): Rewrite to use
1839 _dbus_poll() instead of select().
1841 2004-04-15 Jon Trowbridge <trow@ximian.com>
1843 * bus/main.c (signal_handler): Reload the configuration files
1845 (main): Set up our SIGHUP handler.
1847 * bus/bus.c (struct BusContext): Store the config file, user and
1848 fork flag in the BusContext.
1849 (process_config_first_time_only): Added. Contains the code
1850 (previously in bus_context_new) for setting up the BusContext from
1851 the BusConfigParser that should only be run the first time the
1852 config files are read.
1853 (process_config_every_time): Added. Contains the code (previously
1854 in bus_context_new) for setting up the BusContext from the
1855 BusConfigParser that should be run every time the config files are
1857 (load_config): Added. Builds a BusConfigParser from the config
1858 files and passes the resulting structure off to
1859 process_config_first_time_only (assuming this is the first time)
1860 and process_config_every_time.
1861 (bus_context_new): All of the config-related code has been moved
1862 to process_config_first_time_only and process_config_every_time.
1863 Now this function just does the non-config-related initializations
1864 and calls load_config.
1865 (bus_context_reload_config): Added.
1867 2004-04-15 Olivier Andrieu <oliv__a@users.sourceforge.net>
1869 * bus/driver.c (bus_driver_handle_get_service_owner):
1870 implement a GetServiceOwner method.
1871 * doc/dbus-specification.xml: document it.
1872 * dbus/dbus-errors.h: add a 'ServiceHasNoOwner' error.
1874 * glib/dbus-gproxy.c (dbus_gproxy_new_for_service_owner):
1875 implement, using the bus GetServiceOwner method.
1877 * test/glib/test-dbus-glib.c:
1878 use dbus_gproxy_new_for_service_owner so that we can receive the
1881 2004-04-15 John (J5) Palmieri <johnp@redhat.com>
1883 * dbus/dbus-internals.c, dbus/dbus-message-builder.c,
1884 dbus/dbus-message.c, dbus/dbus-protocol.h
1885 (DBUS_HEADER_FIELD_SERVICE): renamed DBUS_HEADER_FIELD_DESTINATION
1887 * dbus/dbus-internals.c, dbus/dbus-message-builder.c,
1888 dbus/dbus-message.c, dbus/dbus-protocol.h
1889 (DBUS_HEADER_FIELD_SENDER_SERVICE): renamed DBUS_HEADER_FIELD_SENDER
1891 * dbus/dbus-internals.c (_dbus_header_field_to_string):
1892 DBUS_HEADER_FIELD_DESTINATION resolves to "destination"
1893 DBUS_HEADER_FIELD_SENDER resolves to "sender"
1895 * doc/dbus-specification.xml (Header Fields Table):
1896 s/SERVICE/DESTINATION
1897 s/SENDER_SERVICE/SENDER
1900 2004-04-14 Olivier Andrieu <oliv__a@users.sourceforge.net>
1902 * test/glib/test-dbus-glib.c (timed_exit): fail the test after
1905 2004-04-13 Michael Meeks <michael@ximian.com>
1907 * glib/dbus-gobject.c (handle_introspect): split out
1908 (introspect_properties): this.
1909 (handle_introspect): implement this.
1911 * test/glib/Makefile.am: use the absolute path so the bus
1912 daemon's chdir ("/") doesn't kill us dead.
1914 * configure.in: subst ABSOLUTE_TOP_BUILDDIR
1916 2004-04-12 Jon Trowbridge <trow@ximian.com>
1918 * bus/config-parser.c (struct BusConfigParser): Added
1919 included_files field.
1920 (seen_include): Added. Checks whether or not a file has already
1921 been included by any parent BusConfigParser.
1922 (bus_config_parser_new): Copy the parent's included_files.
1923 (include_file): Track which files have been included, and fail on
1924 circular inclusions.
1925 (process_test_valid_subdir): Changed printf to report if we are
1926 testing valid or invalid conf files.
1927 (all_are_equiv): Changed printf to be a bit clearer about
1928 what we are actually doing.
1929 (bus_config_parser_test): Test invalid configuration files.
1931 2004-04-09 Jon Trowbridge <trow@ximian.com>
1933 * bus/config-parser.c (bus_config_parser_new): Added a 'parent'
1934 argument. If non-null, the newly-constructed BusConfigParser will
1935 be initialized with the parent's BusLimits instead of the default
1937 (include_file): When including a config file, pass in
1938 the current parser as the parent and then copy the BusLimits
1939 from the included BusConfigParser pack to the current parser.
1940 (process_test_valid_subdir): Renamed from process_test_subdir.
1941 (process_test_equiv_subdir): Added. Walks through a directory,
1942 descending into each subdirectory and loading the config files
1943 it finds there. If any subdirectory contains two config files
1944 that don't produce identical BusConfigParser structs, fail.
1945 For now, the BusConfigParser's BusPolicies are not compared.
1946 (bus_config_parser_test): Call both process_test_valid_subdir and
1947 process_test_equiv_subdir.
1949 * bus/config-loader-libxml.c (bus_config_load): Take a parent
1950 argument and pass it along to the call to bus_config_parser_new.
1951 Also made a few small changes to allow this code to compile.
1953 * bus/config-loader-expat.c (bus_config_load): Take a parent
1954 argument and pass it along to the call to bus_config_parser_new.
1956 * bus/bus.c (bus_context_new): Load the config file
1957 with a NULL parent argument.
1959 2004-03-29 Michael Meeks <michael@ximian.com>
1961 * glib/dbus-gobject.c (introspect_properties): split
1962 out, fix mangled 'while' flow control.
1963 (introspect_signals): implement.
1964 (handle_introspect): update.
1966 2004-03-29 Michael Meeks <michael@ximian.com>
1968 * glib/dbus-gobject.c (set_object_property): split out /
1969 re-work, use the property type, and not the message type(!)
1970 (get_object_property): ditto.
1972 * glib/dbus-gvalue.c (dbus_gvalue_demarshal),
1973 (dbus_gvalue_marshal): make this code re-usable, needed
1974 for signals too, also on both proxy and server side.
1975 Re-write for more efficiency / readability.
1977 2004-03-29 Michael Meeks <michael@ximian.com>
1979 * dbus/dbus-message.c
1980 (dbus_message_new_error_printf): impl.
1982 * dbus/dbus-connection.c
1983 (dbus_connection_unregister_object_path): fix warning.
1985 * configure.in: fix no-mono-installed situation.
1987 2004-03-27 Havoc Pennington <hp@redhat.com>
1989 Patch from Timo Teräs:
1991 * tools/dbus-send.c (main): if --print-reply, assume type is
1992 method call; support boolean type args
1994 * dbus/dbus-connection.c (dbus_connection_send_with_reply): fix a
1995 bunch of memleak and logic bugs
1997 2004-03-23 Owen Fraser-Green <owen@discobabe.net>
1999 * mono/Arguments.cs:
2000 * mono/Introspector.cs:
2002 * mono/InterfaceProxy.cs:
2004 * mono/ProxyBuilder.cs:
2006 Added InterfaceProxy class to avoid building proxies for every
2010 * dbus-message.c (dbus_message_append_args_valist)
2011 (dbus_message_iter_get_object_path)
2012 (dbus_message_iter_get_object_path_array)
2013 (dbus_message_iter_append_object_path)
2014 (dbus_message_iter_append_object_path_array):
2015 Added object_path iter functions to handle OBJECT_PATH arguments
2017 2004-03-23 Owen Fraser-Green <owen@discobabe.net>
2019 First checkin of mono bindings.
2022 Build stuff for the bindings
2023 * dbus-sharp.pc.in: Added for pkgconfig
2025 2004-03-21 Havoc Pennington <hp@redhat.com>
2027 * test/test-service.c (main): remove debug spew
2029 2004-03-21 Olivier Andrieu <oliv__a@users.sourceforge.net>
2031 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): accept empty
2034 * dbus/dbus-message.h, bus/dbus-message.c (dbus_message_iter_init)
2035 (dbus_message_iter_init_array_iterator)
2036 (dbus_message_iter_init_dict_iterator): return a dbus_bool_t to
2037 indicate whether the iterator is empty
2039 * dbus/dbus-pending-call.c, dbus/dbus-server.c: silence compiler
2042 2004-03-19 Havoc Pennington <hp@redhat.com>
2044 * NEWS: 0.21 updates
2046 * configure.in: 0.21
2048 * doc/Makefile.am: add all XMLTO usage to DBUS_XML_DOCS_ENABLED
2050 * python/Makefile.am: change to avoid dist of dbus_bindings.c so
2051 you don't need pyrex to make dist
2053 * qt/Makefile.am (libdbus_qt_1_la_SOURCES): add integrator.h to
2056 2004-03-18 Richard Hult <richard@imendio.com>
2058 * dbus/dbus-message.c (dbus_message_get_auto_activation)
2059 (dbus_message_set_auto_activation): Add doxygen docs.
2061 2004-03-16 Richard Hult <richard@imendio.com>
2063 * bus/activation.c: (bus_activation_service_created),
2064 (bus_activation_send_pending_auto_activation_messages),
2065 (bus_activation_activate_service):
2067 * bus/dispatch.c: (bus_dispatch),
2068 (check_nonexistent_service_auto_activation),
2069 (check_service_auto_activated),
2070 (check_segfault_service_auto_activation),
2071 (check_existent_service_auto_activation), (bus_dispatch_test):
2072 * bus/driver.c: (bus_driver_handle_activate_service):
2073 * bus/services.c: (bus_registry_acquire_service):
2074 * dbus/dbus-message.c: (dbus_message_set_auto_activation),
2075 (dbus_message_get_auto_activation):
2076 * dbus/dbus-message.h:
2077 * dbus/dbus-protocol.h: Implement auto-activation.
2079 * doc/dbus-specification.xml: Add auto-activation to the spec.
2081 2004-03-12 Olivier Andrieu <oliv__a@users.sourceforge.net>
2083 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos):
2084 fix a bug with CUSTOM types.
2086 * dbus/dbus-message.c (message_iter_test, _dbus_message_test): add
2087 a unit test for this bug (used to fail).
2089 2004-03-12 Mikael Hallendal <micke@imendio.com>
2092 (babysitter_watch_callback): notify all pending activations waiting for
2093 the same exec that the activation failed.
2094 (bus_activation_activate_service): shortcut the activation if we
2095 already waiting for the same executable to start up.
2097 2004-03-12 Mikael Hallendal <micke@imendio.com>
2100 - Added service file reloading.
2101 Each service files directory is kept in an hash table in
2102 BusActivation and each BusActivationEntry knows what .service-file it
2103 was read from. So when you try to activate a service the bus will
2104 check if it's been updated, removed or if new .service-files has
2106 - Test code at the bottom for the service file reloading.
2107 * bus/test-main.c: (main):
2109 - added service reloading test.
2110 * dbus/dbus-sysdeps.c:
2111 * dbus/dbus-sysdeps.h: (_dbus_delete_directory): Added.
2113 2004-03-08 Michael Meeks <michael@ximian.com>
2115 * dbus/dbus-connection.c (_dbus_connection_block_for_reply):
2116 bail immediately if disconnected, to avoid busy loop.
2118 * dbus/dbus-message.c (dbus_message_iter_get_args_valist):
2119 cleanup cut/paste/inefficiency.
2121 2004-03-01 David Zeuthen <david@fubar.dk>
2123 * dbus/dbus-string.c (_dbus_string_append_printf_valist): Fix a
2124 bug where args were used twice. This bug resulted in a segfault
2125 on a Debian/PPC system when starting the messagebus daemon. Include
2126 dbus-sysdeps.h for DBUS_VA_COPY
2128 * dbus/dbus-sysdeps.h: Define DBUS_VA_COPY if neccessary. From GLib
2130 * configure.in: Check for va_copy; define DBUS_VA_COPY to the
2131 appropriate va_copy implementation. From GLib
2133 2004-02-24 Joe Shaw <joe@ximian.com>
2135 * bus/services.c (bus_registry_acquire_service): We need to pass
2136 in the service name to dbus_set_error() to prevent a crash.
2138 2003-12-26 Anders Carlsson <andersca@gnome.org>
2140 * AUTHORS: Reveal my True identity.
2142 2003-12-17 Mikael Hallendal <micke@imendio.com>
2144 * dbus/dbus-message.c: (dbus_message_append_args_valist):
2145 - Added case for DBUS_TYPE_BYTE, patch from Johan Hedberg.
2147 2003-12-13 Mikael Hallendal <micke@imendio.com>
2149 * doc/TODO: Added not about better error check of configuration files.
2151 2003-12-02 Richard Hult <richard@imendio.com>
2153 * Update AFL version to 2.0 throughout the source files to reflect
2154 the update that was done a while ago.
2156 2003-12-02 Richard Hult <richard@imendio.com>
2158 * dbus/dbus-message.c (dbus_message_iter_append_dict): Set
2159 wrote_dict_key to FALSE on the iter that the dict is appended to,
2160 just like when appending other types. Fixes a bug where a dict
2161 couldn't be put inside a dict.
2162 (dbus_message_iter_append_dict_key): Fix typo in warning message.
2163 (message_iter_test, _dbus_message_test): Add test case for dict
2166 2003-12-01 David Zeuthen <david@fubar.dk>
2168 * python/dbus.py: Add the actual message when calling the reciever
2169 of a signal such that parameters can be inspected. Add the method
2170 remove_signal_receiver
2172 2003-11-26 Mikael Hallendal <micke@imendio.com>
2176 * glib/*.[ch]: Made ref functions return the pointer
2178 2003-11-25 Zack Rusin <zack@kde.org>
2180 * qt/integrator.h, qt/integrator.cpp: Adding handling of DBusServer,
2182 * qt/server.h, qt/server.cpp, qt/Makefile.am: Adding DBusServer
2185 * qt/connection.h, qt/connection.cpp: Adjusting to changes in
2186 the Integrator and to better fit with the server,
2188 2003-11-24 Zack Rusin <zack@kde.org>
2190 * qt/connection.h, qt/connection.cpp: removing initDbus method since
2191 the integrator handles it now
2193 * qt/integrator.h, qt/integrator.cpp: reworking handling of timeouts,
2194 since QTimer wasn't really meant to be used the way DBusTimeout is
2196 2003-11-24 Zack Rusin <zack@kde.org>
2198 * qt/integrator.h, qt/integrator.cpp, Makefile.am: Adding
2199 Integrator class which integrates D-BUS with the Qt event loop,
2201 * qt/connection.h, qt/connection.cpp: Move all the code which
2202 was dealing with D-BUS integration to the Integrator class,
2203 and start using Integrator,
2205 2003-11-23 Zack Rusin <zack@kde.org>
2207 * qt/connection.h, qt/connection.cpp: Adding the DBusConnection
2210 * qt/message.h, qt/message.cpp: updating to the current D-BUS api,
2211 switching namespaces to DBusQt, reworking the class,
2213 * Makefile.cvs: switching dependencies so that it matches KDE
2216 * qt/Makefile.am: adding connection.{h,cpp} and message.{h,cpp} to
2219 2003-11-19 Havoc Pennington <hp@redhat.com>
2223 * configure.in: bump version to 0.20
2225 * configure.in (have_qt): add yet another place to look for qt
2226 (someone hand trolltech a .pc file...)
2228 2003-11-01 Havoc Pennington <hp@redhat.com>
2230 * doc/dbus-specification.xml: add state machine docs on the auth
2231 protocol; just a first draft, I'm sure it's wrong.
2233 2003-10-28 David Zeuthen <david@fubar.dk>
2235 * python/dbus_bindings.pyx.in: add get_dict to handle dictionaries
2236 return types. Fixup TYPE_* to reflect changes in dbus/dbus-protocol.h
2238 2003-10-28 Havoc Pennington <hp@redhat.com>
2240 * dbus/dbus-message.c (get_next_field): delete unused function
2242 2003-10-28 Havoc Pennington <hp@redhat.com>
2244 * bus/expirelist.c (do_expiration_with_current_time): detect
2245 failure of the expire_func due to OOM
2247 * bus/connection.c (bus_pending_reply_expired): return FALSE on OOM
2249 * bus/dispatch.c (check_send_exit_to_service): fix to handle the
2250 NoReply error that's now created by the bus when the service exits
2252 2003-10-28 Havoc Pennington <hp@redhat.com>
2254 * dbus/dbus-message.c (_dbus_message_test): enable and fix the
2255 tests for set_path, set_interface, set_member, etc.
2257 * dbus/dbus-string.c (_dbus_string_insert_bytes): allow 0 bytes
2259 * dbus/dbus-message.c (set_string_field): always just delete and
2260 re-append the field; accept NULL for deletion
2261 (re_align_fields_recurse): reimplement
2263 2003-10-26 Havoc Pennington <hp@redhat.com>
2265 * dbus/dbus-connection.c: fix docs to properly describe the
2266 disconnected message
2267 (_dbus_connection_notify_disconnected): remove this function;
2268 we can't synchronously add the disconnected message, we have to
2269 do it after we've queued any remaining real messages
2270 (_dbus_connection_get_dispatch_status_unlocked): queue the
2271 disconnect message only if the transport has finished queueing all
2272 its real messages and is disconnected.
2273 (dbus_connection_disconnect): update the dispatch status here
2275 2003-10-22 Havoc Pennington <hp@redhat.com>
2277 * bus/bus.c (bus_context_check_security_policy): fix up assertion
2279 * bus/connection.c (bus_transaction_send_from_driver): set the
2280 destination to the connection's base service
2282 2003-10-20 Havoc Pennington <hp@redhat.com>
2284 hmm, make check is currently not passing.
2286 * doc/dbus-specification.xml: add requirement that custom type
2287 names follow the same rules as interface names.
2289 * dbus/dbus-protocol.h: change some of the byte codes, to avoid
2290 duplication and allow 'c' to be 'custom'; dict is now 'm' for
2293 * doc/dbus-specification.xml: update type codes to match
2294 dbus-protocol.h, using the ASCII byte values. Rename type NAMED to
2295 CUSTOM. Add type OBJECT_PATH to the spec.
2297 2003-10-17 Havoc Pennington <hp@redhat.com>
2299 * bus/driver.c (create_unique_client_name): use "." as separator
2300 in base service names instead of '-'
2302 * dbus/dbus-string.c (_dbus_string_get_byte): allow getting nul
2303 byte at the end of the string
2305 * dbus/dbus-internals.h (_DBUS_LIKELY, _DBUS_UNLIKELY): add
2306 optimization macros since string validation seems to be a slow
2309 * doc/dbus-specification.xml: restrict valid
2310 service/interface/member/error names. Add test suite code for the
2313 * dbus/dbus-string.c: limit service/interface/member/error names
2316 * dbus/dbus-connection.c (dbus_connection_dispatch): add missing
2317 format arg to verbose spew
2319 * glib/dbus-gproxy.c (dbus_gproxy_call_no_reply): if not out of
2320 memory, return instead of g_error
2322 * test/test-service.c (path_message_func): support emitting a
2325 * dbus/dbus-bus.c (init_connections_unlocked): only fill in
2326 activation bus type if DBUS_BUS_ACTIVATION was set; default to
2327 assuming the activation bus was the session bus so that services
2328 started manually will still register.
2329 (init_connections_unlocked): fix so that in OOM situation we get
2330 the same semantics when retrying the function
2332 * test/test-service.c (main): change to use path registration, to
2333 test those codepaths; register with DBUS_BUS_ACTIVATION rather
2334 than DBUS_BUS_SESSION
2336 2003-10-16 Havoc Pennington <hp@redhat.com>
2338 * glib/dbus-gtest-main.c: bracket with #ifdef DBUS_BUILD_TESTS
2340 * Makefile.am (GCOV_DIRS): remove "test", we don't care about test
2341 coverage of the tests
2342 (coverage-report.txt): don't move the .da and .bbg files around
2344 2003-10-16 Havoc Pennington <hp@redhat.com>
2346 * bus/bus.c (struct BusContext): remove struct field I didn't mean
2349 2003-10-16 Havoc Pennington <hp@redhat.com>
2351 * bus/connection.c (bus_pending_reply_expired): either cancel or
2353 (bus_connections_check_reply): use unlink, not remove_link, as we
2354 don't want to free the link; fixes double free mess
2356 * dbus/dbus-pending-call.c (dbus_pending_call_block): fix in case
2357 where no reply was received
2359 * dbus/dbus-connection.c (_dbus_pending_call_complete_and_unlock):
2362 * bus/signals.c (match_rule_matches): add special cases for the
2363 bus driver, so you can match on sender/destination for it.
2365 * dbus/dbus-sysdeps.c (_dbus_abort): print backtrace if
2366 DBUS_PRINT_BACKTRACE is set
2368 * dbus/dbus-internals.c: add pid to assertion failure messages
2370 * dbus/dbus-connection.c: add message type code to the debug spew
2372 * glib/dbus-gproxy.c (gproxy_get_match_rule): match rules want
2373 sender=foo not service=foo
2375 * dbus/dbus-bus.c (dbus_bus_get): if the activation bus is the
2376 session bus but DBUS_SESSION_BUS_ADDRESS isn't set, use
2377 DBUS_ACTIVATION_ADDRESS instead
2379 * bus/activation.c: set DBUS_SESSION_BUS_ADDRESS,
2380 DBUS_SYSTEM_BUS_ADDRESS if appropriate
2382 * bus/bus.c (bus_context_new): handle OOM copying bus type into
2385 * dbus/dbus-message.c (dbus_message_iter_get_object_path): new function
2386 (dbus_message_iter_get_object_path_array): new function (half
2387 finished, disabled for the moment)
2389 * glib/dbus-gproxy.c (dbus_gproxy_end_call): properly handle
2390 DBUS_MESSAGE_TYPE_ERROR
2392 * tools/dbus-launch.c (babysit): support DBUS_DEBUG_OUTPUT to
2393 avoid redirecting stderr to /dev/null
2394 (babysit): close stdin if not doing the "exit_with_session" thing
2396 * dbus/dbus-sysdeps.c (_dbus_become_daemon): delete some leftover
2397 debug code; change DBUS_DEBUG_OUTPUT to only enable stderr, not
2398 stdout/stdin, so things don't get confused
2400 * bus/system.conf.in: fix to allow replies, I modified .conf
2401 instead of .conf.in again.
2403 2003-10-14 David Zeuthen <david@fubar.dk>
2405 * python/dbus_bindings.pyx.in (MessageIter.get): fixed typo in
2406 argtype to arg_type when raising unknown arg type exception.
2407 Changed type list to reflect the changes in dbus-protocol.h so
2408 the bindings actually work.
2410 2003-10-14 Havoc Pennington <hp@redhat.com>
2412 * test/decode-gcov.c: support gcc 3.3 also, though gcc 3.3 seems
2413 to have a bug keeping it from outputting the .da files sometimes
2414 (string_get_string): don't append garbage nul bytes to the string.
2416 2003-10-15 Seth Nickell <seth@gnome.org>
2418 * python/Makefile.am:
2420 Include dbus_h_wrapper.h in the dist tarball.
2422 2003-10-14 Havoc Pennington <hp@redhat.com>
2424 * bus/bus.c (bus_context_check_security_policy): revamp this to
2425 work more sanely with new policy-based requested reply setup
2427 * bus/connection.c (bus_transaction_send_from_driver): set bus
2428 driver messages as no reply
2430 * bus/policy.c (bus_client_policy_check_can_receive): handle a
2431 requested_reply attribute on allow/deny rules
2433 * bus/system.conf: add <allow requested_reply="true"/>
2435 * bus/driver.c (bus_driver_handle_message): fix check for replies
2436 sent to the bus driver, which was backward. How did this ever work
2437 at all though? I think I'm missing something.
2439 * dbus/dbus-message.c (decode_header_data): require error and
2440 method return messages to have a reply serial field to be valid
2441 (_dbus_message_loader_queue_messages): break up this function;
2442 validate that reply serial and plain serial are nonzero;
2443 clean up the OOM/error handling.
2444 (get_uint_field): don't return -1 from this
2445 (dbus_message_create_header): fix signed/unsigned bug
2447 * bus/connection.c (bus_connections_expect_reply): save serial of
2448 the incoming message, not reply serial
2450 2003-10-14 Havoc Pennington <hp@redhat.com>
2452 * bus/connection.c: implement pending reply tracking using
2455 * bus/bus.c (bus_context_check_security_policy): verify that a
2456 reply is pending in order to allow a reply to be sent. Deny
2457 messages of unknown type.
2459 * bus/dbus-daemon-1.1.in: update to mention new resource limits
2461 * bus/bus.c (bus_context_get_max_replies_per_connection): new
2462 (bus_context_get_reply_timeout): new
2464 2003-10-13 Seth Nickell <seth@gnome.org>
2466 * python/Makefile.am:
2468 Pass "make distcheck": remove a couple files from DIST_FILES
2469 that weren't included in the final version.
2471 2003-10-12 Havoc Pennington <hp@pobox.com>
2473 Added test code that 1) starts an actual bus daemon and 2) uses
2474 DBusGProxy; fixed bugs that were revealed by the test. Lots
2475 more testing possible, but this is the basic framework.
2477 * glib/dbus-gproxy.c (dbus_gproxy_manager_unregister): remove
2478 empty proxy lists from the proxy list hash
2480 * dbus/dbus-message.c (dbus_message_iter_get_args_valist): add a
2481 couple of return_if_fail checks
2483 * dbus/dbus-pending-call.c (_dbus_pending_call_new): use dbus_new0
2484 to allocate, so everything is cleared to NULL as it should be.
2486 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): pass
2487 source as data to dbus_connection_set_timeout_functions() as the
2488 timeout functions expected
2490 * test/glib/run-test.sh: add a little script to start up a message
2491 bus and run tests using it
2493 * tools/dbus-launch.1: updates
2495 * tools/dbus-launch.c (main): add --config-file option
2497 * tools/dbus-launch.c (main): remove confusing else if (runprog)
2498 that could never be reached.
2500 * dbus/dbus-message.c (dbus_message_new_method_return)
2501 (dbus_message_new_error, dbus_message_new_signal): set the
2502 no-reply-expected flag on all these. Redundant, but may
2503 as well be consistent.
2505 2003-10-11 Havoc Pennington <hp@pobox.com>
2507 * test/decode-gcov.c (function_solve_graph): make broken block
2508 graph a nonfatal error since it seems to be broken. Need to debug
2511 * dbus/dbus-marshal.c (_dbus_type_is_valid): new function since we
2512 can't just check type > INVALID < LAST anymore
2514 * dbus/dbus-message.c (dbus_message_get_signature): new function
2515 (dbus_message_has_signature): new function
2516 (struct DBusMessage): add signature field (right now it isn't sent
2517 over the wire, just generated on the fly)
2518 (dbus_message_copy): copy the signature, and init strings to
2519 proper length to avoid some reallocs
2520 (dbus_message_iter_init_array_iterator): return void, since it
2522 (dbus_message_iter_init_dict_iterator): return void since it can't fail
2523 (_dbus_message_loader_queue_messages): add silly temporary hack to
2524 fill in message->signature on load
2526 * dbus/dbus-protocol.h: change DBUS_TYPE_* values to be ASCII
2527 characters, so they are relatively human-readable.
2529 2003-10-11 Havoc Pennington <hp@pobox.com>
2531 * dbus/dbus-message.c (_dbus_message_test): add more test
2532 coverage, but #if 0 for now since they uncover a bug
2533 not fixed yet; I think in re_align_field_recurse()
2534 (re_align_field_recurse): add FIXME about broken assertion
2536 * dbus/dbus-sysdeps.c (_dbus_sysdeps_test): add more test coverage
2538 * bus/connection.c: share a couple code bits with expirelist.c
2540 * bus/expirelist.h, bus/expirelist.c: implement a generic
2541 expire-items-after-N-seconds facility, was going to share between
2542 expiring connections and replies, decided not to use for expiring
2543 connections for now.
2545 * COPYING: include AFL 2.0 (still need to change all the file headers)
2547 2003-10-09 Havoc Pennington <hp@redhat.com>
2549 * configure.in: define DBUS_HAVE_GCC33_GCOV if we have
2550 gcc 3.3. Not that we do anything about it yet.
2552 * bus/signals.c (bus_match_rule_parse): impose max length on the
2555 * dbus/dbus-protocol.h: add DBUS_MAXIMUM_MATCH_RULE_LENGTH
2557 2003-10-09 Havoc Pennington <hp@redhat.com>
2559 Make matching rules theoretically work (add parser).
2561 * bus/bus.c (bus_context_check_security_policy): fix up to handle
2562 the case where destination is explicitly specified as bus driver
2563 and someone else is eavesdropping.
2565 * bus/policy.c (bus_client_policy_check_can_receive): fix up
2566 definition of eavesdropping and assertion
2568 * tools/dbus-send.c (main): use dbus_message_type_from_string
2570 * bus/signals.c (bus_match_rule_parse): implement
2572 * dbus/dbus-message.c (dbus_message_type_from_string): new
2574 * dbus/dbus-errors.h (DBUS_ERROR_MATCH_RULE_INVALID): add
2576 2003-10-02 Havoc Pennington <hp@pobox.com>
2578 * glib/dbus-gproxy.c (dbus_gproxy_call_no_reply): rename from
2579 dbus_gproxy_oneway_call
2581 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main)
2582 (dbus_server_setup_with_g_main): fix to allow calling them more
2583 than once on the same args
2584 (dbus_bus_get_with_g_main): new function
2586 2003-10-02 Havoc Pennington <hp@redhat.com>
2588 * doc/dbus-tutorial.xml: write some stuff
2590 2003-09-29 Havoc Pennington <hp@pobox.com>
2592 * configure.in: split checks for Doxygen from XML docs, check for
2595 * doc/Makefile.am: XML-ify all the docs, and add a blank
2598 2003-09-29 Havoc Pennington <hp@pobox.com>
2600 * Merge dbus-object-names branch. To see the entire patch
2601 do cvs diff -r DBUS_OBJECT_NAMES_BRANCHPOINT -r dbus-object-names,
2602 it's huuuuge though.
2603 To revert, I tagged DBUS_BEFORE_OBJECT_NAMES_MERGE.
2605 2003-09-28 Havoc Pennington <hp@pobox.com>
2607 * HACKING: update to reflect new server
2609 2003-09-26 Seth Nickell <seth@gnome.org>
2612 * python/examples/example-signals.py:
2614 Start implementing some notions of signals. The API
2615 is really terrible, but they sort of work (with the
2616 exception of being able to filter by service, and to
2617 transmit signals *as* a particular service). Need to
2618 figure out how to make messages come from the service
2621 * python/dbus_bindings.pyx.in:
2623 Removed duplicate message_handler callbacks.
2625 2003-09-25 Havoc Pennington <hp@redhat.com>
2627 * bus/session.conf.in: fix my mess
2629 2003-09-25 Havoc Pennington <hp@pobox.com>
2631 * bus/session.conf.in: fix security policy, reported by Seth Nickell
2633 2003-09-25 Seth Nickell <seth@gnome.org>
2635 * python/examples/example-service.py:
2637 Johan notices complete wrong code in example-service, but
2638 completely wrong in a way that works exactly the same (!).
2639 Johan is confused, how could this possibly work? Example
2640 code fails to serve purpose of making things clear.
2643 2003-09-25 Mark McLoughlin <mark@skynet.ie>
2645 * doc/dbus-specification.sgml: don't require header fields
2646 to be 4-byte aligned and specify that fields should be
2647 distinguished from padding by the fact that zero is not
2650 * doc/TODO: remove re-alignment item and add item to doc
2651 the OBJECT_PATH type.
2653 * dbus/dbus-message.c:
2654 (HeaderField): rename the original member to value_offset
2655 and introduce a name_offset member to keep track of where
2656 the field actually begins.
2657 (adjust_field_offsets): remove.
2658 (append_int_field), (append_uint_field),
2659 (append_string_field): don't align the start of the header
2660 field to a 4-byte boundary.
2661 (get_next_field): impl finding the next marhsalled field
2662 after a given field.
2663 (re_align_field_recurse): impl re-aligning a number of
2664 already marshalled fields.
2665 (delete_field): impl deleting a field of any type and
2666 re-aligning any following fields.
2667 (delete_int_or_uint_field), (delete_string_field): remove.
2668 (set_int_field), (set_uint_field): no need to re-check
2669 that we have the correct type for the field.
2670 (set_string_field): ditto and impl re-aligning any
2672 (decode_header_data): update to take into account that
2673 the fields aren't 4-byte aligned any more and the new
2674 way to distinguish padding from header fields. Also,
2675 don't exit when there is too much header padding.
2676 (process_test_subdir): print the directory.
2677 (_dbus_message_test): add test to make sure a following
2678 field is re-aligned correctly after field deletion.
2680 * dbus/dbus-string.[ch]:
2681 (_dbus_string_insert_bytes): rename from insert_byte and
2682 allow the insert of multiple bytes.
2683 (_dbus_string_test): test inserting multiple bytes.
2685 * dbus/dbus-marshal.c: (_dbus_marshal_set_string): add
2686 warning note to docs about having to re-align any
2687 marshalled values following the string.
2689 * dbus/dbus-message-builder.c:
2690 (append_string_field), (_dbus_message_data_load):
2691 don't align the header field.
2693 * dbus/dbus-auth.c: (process_test_subdir): print the
2696 * test/break-loader.c: (randomly_add_one_byte): upd. for
2699 * test/data/invalid-messages/bad-header-field-alignment.message:
2702 * test/data/valid-messages/unknown-header-field.message: shove
2703 a dict in the unknown field.
2705 2003-09-25 Seth Nickell <seth@gnome.org>
2708 * python/dbus_bindings.pyx.in:
2710 Handle return values.
2712 * python/examples/example-client.py:
2713 * python/examples/example-service.py:
2715 Pass back return values from the service to the client.
2717 2003-09-24 Seth Nickell <seth@gnome.org>
2721 Connect Object methods (when you are sharing an object) up... pass
2722 in a list of methods to be shared. Sharing all the methods just
2723 worked out too weird. You can now create nice Services over the
2726 * python/dbus_bindings.pyx.in:
2728 Keep references to user_data tuples passed into C functions so
2729 Python doesn't garbage collect on us.
2731 Implement MethodReturn and Error subclasses of Message for creating
2732 DBusMessage's of those types.
2734 * python/examples/example-client.py:
2735 * python/examples/example-service.py:
2737 Simple example code showing both how create DBus services and objects,
2738 and how to use them.
2740 2003-09-23 Havoc Pennington <hp@pobox.com>
2742 * glib/dbus-gproxy.c (dbus_gproxy_manager_filter): implement
2744 2003-09-23 Havoc Pennington <hp@redhat.com>
2746 * glib/dbus-gproxy.c (dbus_gproxy_connect_signal): implement
2747 (dbus_gproxy_disconnect_signal): implement
2748 (dbus_gproxy_manager_remove_signal_match): implement
2749 (dbus_gproxy_manager_add_signal_match): implement
2750 (dbus_gproxy_oneway_call): implement
2752 2003-09-23 Havoc Pennington <hp@pobox.com>
2754 * glib/dbus-gproxy.c (struct DBusGProxy): convert to a GObject
2755 subclass. This means dropping the transparent thread safety of the
2756 proxy; you now need a separate proxy per-thread, or your own
2757 locking on the proxy. Probably right anyway.
2758 (dbus_gproxy_ref, dbus_gproxy_unref): nuke, just use g_object_ref
2760 2003-09-22 Havoc Pennington <hp@redhat.com>
2762 * glib/dbus-gproxy.c (dbus_gproxy_manager_get): implement
2764 2003-09-21 Seth Nickell <seth@gnome.org>
2766 First checkin of the Python bindings.
2768 * python/.cvsignore:
2769 * python/Makefile.am:
2770 * python/dbus_bindings.pyx.in:
2771 * python/dbus_h_wrapper.h:
2773 Pieces for Pyrex to operate on, building a dbus_bindings.so
2774 python module for low-level access to the DBus APIs.
2778 High-level Python module for accessing DBus objects.
2783 Build stuff for the python bindings.
2787 Extra macro needed for finding the Python C header files.
2789 2003-09-21 Havoc Pennington <hp@pobox.com>
2791 * glib/dbus-gproxy.c (dbus_gproxy_manager_new): start
2792 implementing the proxy manager, didn't get very far.
2794 * dbus/dbus-bus.c (dbus_bus_add_match): new
2795 (dbus_bus_remove_match): new
2797 * glib/dbus-gproxy.c (dbus_gproxy_new_for_service): add a
2798 path_name argument; adjust the other not-yet-implemented
2799 gproxy constructors to be what I think they should be.
2801 2003-09-21 Havoc Pennington <hp@pobox.com>
2803 * dbus/dbus-bus.c (dbus_bus_get): set exit_on_disconnect to TRUE
2804 by default for message bus connections.
2806 * dbus/dbus-connection.c (dbus_connection_dispatch): exit if
2807 exit_on_disconnect flag is set and we process the disconnected
2809 (dbus_connection_set_exit_on_disconnect): new function
2811 2003-09-21 Havoc Pennington <hp@pobox.com>
2813 Get matching rules mostly working in the bus; only actually
2814 parsing the rule text remains. However, the client side of
2815 "signal connections" hasn't been started, this patch is only the
2818 * dbus/dispatch.c: fix for the matching rules changes
2820 * bus/driver.c (bus_driver_handle_remove_match)
2821 (bus_driver_handle_add_match): send an ack reply from these
2824 * glib/dbus-gproxy.c (dbus_gproxy_begin_call): fix order of
2825 arguments, reported by Seth Nickell
2827 * bus/config-parser.c (append_rule_from_element): support
2828 eavesdrop=true|false attribute on policies so match rules
2829 can be prevented from snooping on the system bus.
2831 * bus/dbus-daemon-1.1.in: consistently use terminology "sender"
2832 and "destination" in attribute names; fix some docs bugs;
2833 add eavesdrop=true|false attribute
2835 * bus/driver.c (bus_driver_handle_add_match)
2836 (bus_driver_handle_remove_match): handle AddMatch, RemoveMatch
2839 * dbus/dbus-protocol.h (DBUS_SERVICE_ORG_FREEDESKTOP_BROADCAST): get
2840 rid of broadcast service concept, signals are just always broadcast
2842 * bus/signals.c, bus/dispatch.c, bus/connection.c, bus/bus.c:
2843 mostly implement matching rules stuff (currently only exposed as signal
2846 2003-09-21 Mark McLoughlin <mark@skynet.ie>
2848 * doc/dbus-specification.sgml: Change the header field name
2849 to be an enum and update the rest of the spec to reference
2850 the fields using the conventinal name.
2852 * dbus/dbus-protocol.h: update to reflect the spec.
2854 * doc/TODO: add item to remove the 4 byte alignment requirement.
2856 * dbus/dbus-message.c: Remove the code to generalise the
2857 header/body length and serial number header fields as named
2858 header fields so we can reference field names using the
2860 (append_int_field), (append_uint_field), (append_string_field):
2861 Append the field name as a byte rather than four chars.
2862 (delete_int_or_uint_field), (delete_string_field): reflect the
2863 fact that the field name and typecode now occupy 4 bytes instead
2865 (decode_string_field), (decode_header_data): update to reflect
2866 protocol changes and move the field specific encoding from
2867 decode_string_field() back into decode_header_data().
2869 * dbus/dbus-internals.[ch]: (_dbus_header_field_to_string):
2870 Add utility to aid debugging.
2872 * dbus/dbus-message-builder.c:
2873 (append_string_field), (_dbus_message_data_load): Update to
2874 reflect protocol changes; Change the FIELD_NAME directive
2875 to HEADER_FIELD and allow it to take the field's conventional
2876 name rather than the actual value.
2878 * test/data/*/*.message: Update to use HEADER_FIELD instead
2879 of FIELD_NAME; Always align the header on an 8 byte boundary
2880 *before* updating the header length.
2882 2003-09-15 Havoc Pennington <hp@pobox.com>
2884 * dbus/dbus-pending-call.c: add the get/set object data
2885 boilerplate as for DBusConnection, etc. Use generic object data
2886 for the notify callback.
2888 * glib/dbus-gparser.c (parse_node): parse child nodes
2890 * tools/dbus-viewer.c: more hacking on the dbus-viewer
2892 * glib/dbus-gutils.c (_dbus_gutils_split_path): add a file to
2893 contain functions shared between the convenience lib and the
2896 * glib/Makefile.am (libdbus_glib_1_la_LDFLAGS): add
2897 -export-symbols-regex to the GLib library
2899 * dbus/dbus-object-tree.c (_dbus_object_tree_dispatch_and_unlock):
2900 fix the locking in here, and add a default handler for
2901 Introspect() that just returns sub-nodes.
2903 2003-09-14 Havoc Pennington <hp@pobox.com>
2905 * glib/dbus-gthread.c (dbus_g_thread_init): rename to make g_foo
2906 rather than gfoo consistent
2908 * glib/dbus-gproxy.h: delete for now, move contents to
2909 dbus-glib.h, because the include files don't work right since we
2910 aren't in the dbus/ subdir.
2912 * glib/dbus-gproxy.c (dbus_gproxy_send): finish implementing
2913 (dbus_gproxy_end_call): finish
2914 (dbus_gproxy_begin_call): finish
2916 * glib/dbus-gmain.c (dbus_set_g_error): new
2918 * glib/dbus-gobject.c (handle_introspect): include information
2919 about child nodes in the introspection
2921 * dbus/dbus-connection.c (dbus_connection_list_registered): new
2922 function to help in implementation of introspection
2924 * dbus/dbus-object-tree.c
2925 (_dbus_object_tree_list_registered_and_unlock): new function
2927 2003-09-12 Havoc Pennington <hp@pobox.com>
2929 * glib/dbus-gidl.h: add common base class for all the foo_info
2932 * tools/dbus-viewer.c: add GTK-based introspection UI thingy
2935 * test/Makefile.am: try test srcdir -ef . in addition to test
2936 srcdir = ., one of them should work (yeah lame)
2938 * glib/Makefile.am: build the "idl" parser stuff as a convenience
2941 * glib/dbus-gparser.h: make description_load routines return
2942 NodeInfo* not Parser*
2944 * Makefile.am (SUBDIRS): build test dir after all library dirs
2946 * configure.in: add GTK+ detection
2948 2003-09-07 Havoc Pennington <hp@pobox.com>
2950 * Make Doxygen contented.
2952 2003-09-07 Havoc Pennington <hp@pobox.com>
2954 * doc/dbus-specification.sgml: more updates
2956 2003-09-06 Havoc Pennington <hp@pobox.com>
2958 * doc/dbus-specification.sgml: partial updates
2960 * bus/dbus-daemon-1.1.in: fix the config file docs for the
2961 zillionth time; hopefully I edited the right file this time.
2963 * bus/config-parser.c (append_rule_from_element): support
2964 send_type, send_path, receive_type, receive_path
2966 * bus/policy.c: add message type and path to the list of things
2967 that can be "firewalled"
2969 2003-09-06 Havoc Pennington <hp@pobox.com>
2971 * dbus/dbus-connection.c (dbus_connection_register_fallback): add this
2972 (dbus_connection_register_object_path): make this not handle
2973 messages to paths below the given path
2975 2003-09-03 Havoc Pennington <hp@pobox.com>
2977 * test/glib/Makefile.am: add this with random glib-linked test
2980 * glib/Makefile.am: remove the random test programs from here,
2981 leave only the unit tests
2983 * glib/dbus-gobject.c (_dbus_gobject_test): add test for
2984 uscore/javacaps conversion, and fix
2985 (get_object_property, set_object_property): change to .NET
2986 convention for mapping props to methods, set_FooBar/get_FooBar,
2987 since one language has such a convention we may as well copy it.
2988 Plus real methods in either getFooBar or get_foo_bar style won't
2989 collide with this convention.
2991 2003-09-01 Havoc Pennington <hp@pobox.com>
2993 * glib/dbus-gparser.c: implement
2995 * glib/dbus-gobject.c: start implementing skeletons support
2997 * configure.in: when disabling checks/assert, also define
2998 G_DISABLE_ASSERT and G_DISABLE_CHECKS
3000 2003-09-01 Havoc Pennington <hp@pobox.com>
3002 * glib/Makefile.am: rearrange a bunch of files and get "make
3003 check" framework set up
3005 2003-08-31 Havoc Pennington <hp@pobox.com>
3007 * fix build with --disable-tests
3009 2003-08-30 Havoc Pennington <hp@pobox.com>
3011 * dbus/dbus-connection.c: purge DBusMessageHandler
3013 * dbus/dbus-message-handler.c: remove DBusMessageHandler, just
3014 use callbacks everywhere
3016 2003-08-30 Havoc Pennington <hp@pobox.com>
3018 * test/data/valid-config-files/system.d/test.conf: change to
3019 root for the user so warnings don't get printed
3021 * dbus/dbus-message.c: add dbus_message_get_path,
3022 dbus_message_set_path
3024 * dbus/dbus-object-tree.c (do_test_dispatch): add test of
3025 dispatching to a path
3027 * dbus/dbus-string.c (_dbus_string_validate_path): add
3029 * dbus/dbus-marshal.c (_dbus_demarshal_object_path): implement
3030 (_dbus_marshal_object_path): implement
3032 * dbus/dbus-protocol.h (DBUS_HEADER_FIELD_PATH): new header field
3033 to contain the path to the target object
3034 (DBUS_HEADER_FIELD_SENDER_SERVICE): rename
3035 DBUS_HEADER_FIELD_SENDER to explicitly say it's the sender service
3037 2003-08-30 Havoc Pennington <hp@pobox.com>
3039 * dbus/dbus-object-tree.c: write tests and fix the discovered bugs
3041 2003-08-29 Havoc Pennington <hp@pobox.com>
3043 * dbus/dbus-object-tree.c: modify to allow overlapping paths to be
3045 (struct DBusObjectSubtree): shrink this
3046 a lot, since we may have a lot of them
3047 (_dbus_object_tree_free_all_unlocked): implement
3048 (_dbus_object_tree_dispatch_and_unlock): implement
3050 2003-08-29 Havoc Pennington <hp@pobox.com>
3052 * dbus/dbus-internals.h: fix _DBUS_N_GLOBAL_LOCKS
3054 2003-08-28 Havoc Pennington <hp@pobox.com>
3058 * dbus/dbus-connection.c: port to no ObjectID, create a
3059 DBusObjectTree, rename ObjectTree to ObjectPath in public API
3061 * dbus/dbus-connection.h (struct DBusObjectTreeVTable): delete
3062 everything except UnregisterFunction and MessageFunction
3064 * dbus/dbus-marshal.c: port away from DBusObjectID,
3065 add DBUS_TYPE_OBJECT_PATH
3067 * dbus/dbus-object-registry.[hc], dbus/dbus-object.[hc],
3068 dbus/dbus-objectid.[hc]: remove these, we are moving to
3069 path-based object IDs
3071 2003-08-25 Havoc Pennington <hp@pobox.com>
3073 Just noticed that dbus_message_test is hosed, I wonder when I
3074 broke that. I thought make check was passing earlier...
3076 * dbus/dbus-object-tree.c: add new "object tree" to match DCOP
3077 container tree, will replace most of dbus-object-registry
3079 * dbus/dbus-string.c (_dbus_string_append_printf_valist): fix C99
3082 2003-08-19 Havoc Pennington <hp@pobox.com>
3084 * dbus/dbus-message.c (decode_string_field): support FIELD_SENDER
3085 (dbus_message_is_error): fix this function
3087 * bus/dbus-daemon-1.1: clarify logic on when <deny>/<allow> rules
3090 * bus/policy.c (bus_client_policy_check_can_receive): fix code to
3091 reflect clarified man page
3092 (bus_client_policy_check_can_send): ditto
3094 * bus/session.conf.in: fixup
3096 * bus/system.conf.in: fixup
3098 2003-08-18 Havoc Pennington <hp@redhat.com>
3100 * dbus/dbus-hash.c (_dbus_hash_table_insert_two_strings): fix
3102 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
3103 dumb bug created earlier (wrong order of args to
3104 decode_header_data())
3106 * tools/dbus-send.c: port
3108 * tools/dbus-print-message.c (print_message): port
3110 * test/data/*messages: port all messages over
3112 * dbus/dbus-message-builder.c: support including
3115 * bus/driver.c: port over
3117 * bus/dispatch.c: port over to new stuff
3119 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
3120 rename disconnect signal to "Disconnected"
3122 2003-08-17 Havoc Pennington <hp@pobox.com>
3124 This doesn't compile yet, but syncing up so I can hack on it from
3125 work. What are branches for if not broken code? ;-)
3127 * dbus/dbus-protocol.h: remove DBUS_HEADER_FIELD_NAME, add
3128 DBUS_HEADER_FIELD_INTERFACE, DBUS_HEADER_FIELD_MEMBER,
3129 DBUS_HEADER_FIELD_ERROR_NAME
3131 * dbus/dbus-hash.c: Introduce DBUS_HASH_TWO_STRINGS as hack to use
3132 for the interface+member pairs
3133 (string_hash): change to use g_str_hash algorithm
3134 (find_direct_function, find_string_function): refactor these to
3137 * dbus/dbus-message.c: port all of this over to support
3138 interface/member fields instead of name field
3140 * dbus/dbus-object-registry.c: port over
3142 * dbus/dbus-string.c (_dbus_string_validate_interface): rename
3143 from _dbus_string_validate_name
3145 * bus/dbus-daemon-1.1: change file format for the
3146 <deny>/<allow> stuff to match new message naming scheme
3148 * bus/policy.c: port over
3150 * bus/config-parser.c: parse new format
3152 2003-08-16 Havoc Pennington <hp@pobox.com>
3154 * dbus/dbus-object-registry.c (add_and_remove_objects): remove
3157 * glib/dbus-gproxy.c: some hacking
3159 2003-08-15 Havoc Pennington <hp@redhat.com>
3161 * dbus/dbus-pending-call.c (dbus_pending_call_block): implement
3163 * dbus/dbus-connection.c
3164 (dbus_connection_send_with_reply_and_block): factor out internals;
3165 change to convert any error replies to DBusError instead of
3166 returning them as a message
3168 2003-08-15 Havoc Pennington <hp@pobox.com>
3170 * dbus/dbus-connection.c,
3171 dbus/dbus-pending-call.c: Finish the pending call stuff
3173 2003-08-14 Havoc Pennington <hp@redhat.com>
3175 * dbus/dbus-pending-call.c: start on new object that will replace
3176 DBusMessageHandler and ReplyHandlerData for tracking outstanding
3179 * dbus/dbus-gproxy.c: start on proxy object used to communicate
3180 with remote interfaces
3182 * dbus/dbus-gidl.c: do the boring boilerplate in here
3184 2003-08-12 Havoc Pennington <hp@pobox.com>
3186 * bus/dispatch.c (bus_dispatch): make this return proper
3187 DBusHandlerResult to avoid DBUS_ERROR_UNKNOWN_METHOD
3189 * dbus/dbus-errors.c (dbus_set_error): use
3190 _dbus_string_append_printf_valist
3192 * dbus/dbus-string.c (_dbus_string_append_printf_valist)
3193 (_dbus_string_append_printf): new
3195 * dbus/dbus-errors.h (DBUS_ERROR_UNKNOWN_MESSAGE): change to
3198 * dbus/dbus-connection.c (dbus_connection_dispatch): handle
3199 DBUS_HANDLER_RESULT_NEED_MEMORY; send default error reply if a
3200 message is unhandled.
3202 2003-08-11 Havoc Pennington <hp@pobox.com>
3204 * bus/test.c (client_disconnect_handler): change to return
3205 HANDLED (would have been REMOVE_MESSAGE)
3207 * dbus/dbus-object.h (enum DBusHandlerResult): rename to
3208 HANDLED/NOT_YET_HANDLED instead of
3209 REMOVE_MESSAGE/ALLOW_MORE_HANDLERS to make it clearer how it
3212 2003-08-10 Havoc Pennington <hp@pobox.com>
3214 * tools/dbus-send.c (main): add --type argument, for now
3215 supporting only method_call and signal types.
3217 * tools/dbus-print-message.c: print message type
3219 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
3220 init connection->objects
3222 * doc/dbus-specification.sgml: fix sgml
3224 * bus/*.c: port over to object-instance API changes
3226 * test/test-service.c: ditto
3228 * dbus/dbus-message.c (dbus_message_create_header): allow #NULL
3229 name, we will have to fix up the rest of the code to also handle
3231 (dbus_message_new): generic message-creation call
3232 (set_string_field): allow appending name field
3234 2003-08-06 Havoc Pennington <hp@pobox.com>
3236 * dbus/dbus-object-registry.c: implement signal connection
3239 * dbus/dbus-connection.c (_dbus_connection_unref_unlocked): new
3241 * dbus/dbus-internals.c (_dbus_memdup): new function
3243 2003-08-02 Havoc Pennington <hp@pobox.com>
3245 * dbus/dbus-message.c (dbus_message_get_no_reply)
3246 (dbus_message_set_no_reply): add these and remove
3247 set_is_error/get_is_error
3249 * dbus/dbus-protocol.h, doc/dbus-specification.sgml:
3250 remove the ERROR flag, since there's now an ERROR type
3252 2003-08-01 Havoc Pennington <hp@pobox.com>
3254 * dbus/dbus-object-registry.c (_dbus_object_registry_handle_and_unlock):
3257 * dbus/dbus-message.c (dbus_message_get_type): new function
3259 * doc/dbus-specification.sgml: add "type" byte to messages
3261 2003-08-01 Havoc Pennington <hp@pobox.com>
3263 * dbus/dbus-protocol.h (DBUS_MESSAGE_TYPE_*): introduce
3264 a message type enum to distinguish kinds of message
3265 (DBUS_HEADER_FLAG_NO_REPLY_EXPECTED): flag for a message
3266 that need not be replied to
3268 2003-08-01 Havoc Pennington <hp@pobox.com>
3270 * dbus/dbus-marshal.c: adapt to DBusObjectID changes
3271 (unpack_8_octets): fix no-64-bit-int bug
3273 * dbus/dbus-object-registry.c (validate_id): validate the
3274 connection ID bits, not just the instance ID.
3276 * dbus/dbus-connection.c (_dbus_connection_init_id): initialize
3277 the connection-global 33 bits of the object ID
3279 * dbus/dbus-object-registry.c (info_from_entry): fill in
3280 object ID in the new way
3282 * dbus/dbus-objectid.h: rather than high/low bits, specifically
3283 define server/client/instance bits.
3285 2003-07-30 Havoc Pennington <hp@pobox.com>
3287 * dbus/dbus-connection.c (dbus_connection_register_object): fix
3290 2003-07-13 Havoc Pennington <hp@pobox.com>
3292 * dbus/dbus-object.h (struct DBusObjectVTable): add padding
3293 fields to DBusObjectVTable and DBusObjectInfo
3295 2003-07-12 Havoc Pennington <hp@pobox.com>
3297 * dbus/dbus-object-registry.c: implement unit test,
3298 fix bugs discovered in process
3300 * dbus/dbus-connection.c: remove handler_table and
3301 register_handler(), add DBusObjectRegistry usage
3303 * dbus/dbus-objectid.c (dbus_object_id_is_null)
3304 (dbus_object_id_set_null): new functions
3306 2003-07-08 Havoc Pennington <hp@pobox.com>
3308 * dbus/dbus-object.c: implement some of this
3310 * dbus/dbus-object-registry.c
3311 (_dbus_object_registry_add_and_unlock): fill in the object_id out
3313 (_dbus_object_registry_new): handle OOM
3315 2003-07-08 Havoc Pennington <hp@pobox.com>
3317 * dbus/dbus-object.h: sketch out an API for registering objects
3318 with a connection, that allows us to use as little as 24 bytes
3319 per object and lets application code represent an object in
3320 any conceivable way.
3322 * dbus/dbus-object-registry.c: implement the hard bits of the
3323 DBusConnection aspect of object API. Not yet wired up.
3325 2003-07-06 Havoc Pennington <hp@pobox.com>
3327 * dbus/dbus-marshal.c (_dbus_marshal_set_object_id): new function
3328 (_dbus_marshal_object_id): new
3329 (_dbus_demarshal_object_id): new
3330 (_dbus_marshal_get_arg_end_pos): support object ID type, and
3331 consolidate identical switch cases. Don't conditionalize handling
3332 of DBUS_TYPE_UINT64, need to handle the type always.
3333 (_dbus_marshal_validate_arg): consolidate identical cases, and
3334 handle DBUS_TYPE_OBJECT_ID
3336 * dbus/dbus-objectid.c: new file with DBusObjectID data type.
3338 * dbus/dbus-protocol.h: add DBUS_TYPE_OBJECT_ID
3340 2003-09-28 Havoc Pennington <hp@pobox.com>
3344 2003-09-28 Havoc Pennington <hp@pobox.com>
3346 * doc/Makefile.am (dbus-specification.html): testing a funky hack
3347 to work with Debian db2html
3349 2003-09-28 Havoc Pennington <hp@pobox.com>
3351 * configure.in: 0.13
3353 * doc/Makefile.am (dbus-test-plan.html): accept nonexistence of
3354 stylesheet-images for benefit of Debian
3356 Change back to using filesystem-linked sockets for the system
3357 bus, so only root can create the default system bus address.
3359 * bus/system.conf.in: change to use
3360 DBUS_SYSTEM_BUS_DEFAULT_ADDRESS
3362 * dbus/Makefile.am (INCLUDES): remove DBUS_SYSTEM_BUS_PATH define
3365 * configure.in: define DBUS_SYSTEM_BUS_DEFAULT_ADDRESS
3366 here, and AC_DEFINE DBUS_SYSTEM_PATH
3368 2003-08-09 Anders Carlsson <andersca@codefactory.se>
3371 * doc/busconfig.dtd:
3374 2003-08-09 Anders Carlsson <andersca@codefactory.se>
3376 * doc/dbus-specification.sgml:
3377 Add activation reply values.
3379 2003-08-05 Havoc Pennington <hp@redhat.com>
3381 * configure.in: 0.12
3383 2003-08-05 Anders Carlsson <andersca@codefactory.se>
3385 * glib/dbus-gmain.c: (watch_fd_new), (watch_fd_ref),
3386 (watch_fd_unref), (dbus_gsource_check), (dbus_gsource_dispatch),
3387 (add_watch), (remove_watch), (create_source):
3388 Refcount fds, fixes some reentrancy issues.
3390 2003-07-30 Havoc Pennington <hp@redhat.com>
3392 * dbus/dbus-bus.c (init_connections_unlocked): fix default system
3393 bus address to be abstract if we have abstract sockets
3397 2003-07-28 Havoc Pennington <hp@redhat.com>
3399 * bus/messagebus.in: fix to avoid processname/servicename
3400 confusion, from Michael Kearey
3401 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=100965
3403 2003-07-23 Havoc Pennington <hp@pobox.com>
3405 * dbus/dbus-message.c (dbus_message_iter_get_named):
3406 fix from Andy Hanton to remove broken "+1"
3408 2003-07-16 Havoc Pennington <hp@pobox.com>
3410 * tools/dbus-launch.c (babysit): close stdout/stderr in the
3411 babysitter process, as suggested by Thomas Leonard, so
3412 an "eval `dbus-launch --exit-with-session`" will actually
3415 2003-07-16 Havoc Pennington <hp@pobox.com>
3417 * configure.in: print out EXPANDED_* variables in the summary at
3418 the end; clean up the code that computes EXPANDED_ variables and
3419 get the ones using exec_prefix right. Should make things work
3420 when you build without --prefix
3422 2003-06-29 Havoc Pennington <hp@pobox.com>
3424 * mono/Test.cs (class Test): fire up a main loop and run it
3426 * mono/DBus.cs (DBus): don't g_thread_init since it can only be
3427 done once, the app has to do it
3429 2003-06-26 Havoc Pennington <hp@pobox.com>
3431 * mono/Connection.cs: set up connection with the glib main loop
3433 2003-07-01 Havoc Pennington <hp@redhat.com>
3435 * doc/dbus-specification.sgml: clarify the format of a type code,
3436 change suggested by Jim Blandy
3438 2003-06-29 Miloslav Trmac <mitr@volny.cz>
3441 * tools/Makefile.am: Don't assume srcdir == builddir.
3443 * dbus/dbus-memory.c (dbus_realloc): Don't check guards after shrinking
3444 the allocated block.
3445 (_dbus_memory_test): New function.
3446 * dbus/dbus-test.h: Add _dbus_memory_test ().
3447 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): Call it.
3449 * dbus/dbus-message.c (decode_header_data): Use %.4s instead
3451 (dbus_message_new): Remove obsolete @todo.
3453 * dbus/dbus-marshal.c (_dbus_marshal_set_int64)
3454 (_dbus_marshal_set_uint64): Fix comment.
3456 * dbus/dbus-message.c (append_int_field, append_uint_field): Don't
3457 hardcode FIELD_REPLY_SERIAL.
3459 * dbus/dbus-mainloop.c (_dbus_loop_remove_watch)
3460 (_dbus_loop_remove_timeout): Cast function pointers to (void *) for %p
3462 * configure.in: Add -D_POSIX_C_SOURCE=199309L -DBSD_SOURCE to CFLAGS
3463 and disable DBUS_USE_ATOMIC_INT_486 when --enable-ansi is used
3465 2003-06-24 Havoc Pennington <hp@pobox.com>
3467 * mono/*.cs: Use IntPtr.Zero instead of ((IntPtr) 0)
3469 2003-06-23 Anders Carlsson <andersca@codefactory.se>
3475 * gcj/TestMessage.java: (TestMessage), (TestMessage.main):
3476 * gcj/org/.cvsignore:
3477 * gcj/org/Makefile.am:
3478 * gcj/org/freedesktop/.cvsignore:
3479 * gcj/org/freedesktop/Makefile.am:
3480 * gcj/org/freedesktop/dbus/.cvsignore:
3481 * gcj/org/freedesktop/dbus/Makefile.am:
3482 * gcj/org/freedesktop/dbus/Message.java: (Message),
3484 * gcj/org/freedesktop/dbus/natMessage.cc:
3485 Fix the build system.
3487 2003-06-22 Havoc Pennington <hp@pobox.com>
3489 * mono/Connection.cs: add more bindings
3491 * dbus/dbus-threads.c (dbus_threads_init): allow calling this
3494 2003-06-22 Havoc Pennington <hp@pobox.com>
3496 * mono/Connection.cs, mono/DBus.cs, mono/Error.cs:
3497 Start wrapping more stuff.
3499 2003-06-22 Havoc Pennington <hp@pobox.com>
3501 * mono/Message.cs: implement Message.Wrap() that ensures we only
3502 have a single C# wrapper per DBusMessage, assuming it works which
3503 it probably doesn't.
3505 * dbus/dbus-message.c (dbus_message_allocate_data_slot): new
3506 (dbus_message_free_data_slot): new
3507 (dbus_message_set_data): new
3508 (dbus_message_get_data): new
3510 2003-06-22 Havoc Pennington <hp@pobox.com>
3512 * dbus/dbus-dataslot.c (_dbus_data_slot_allocator_unref)
3513 (_dbus_data_slot_allocator_alloc): rework these to keep a
3514 reference count on each slot and automatically manage a global
3515 slot ID variable passed in by address
3517 * bus/bus.c: convert to new dataslot API
3519 * dbus/dbus-bus.c: convert to new dataslot API
3521 * dbus/dbus-connection.c: convert to new dataslot API
3523 * dbus/dbus-server.c: convert to new dataslot API
3525 * glib/dbus-gmain.c: ditto
3529 * bus/connection.c: ditto
3531 2003-06-22 Anders Carlsson <andersca@codefactory.se>
3533 * configure.in: Add AM_PROG_GCJ and move AM_PROG_LIBTOOL
3534 after the gcj checks so that the correct configuration tags
3535 will be added to libtool.
3537 * dbus-glib-1.pc.in: No need to specify any includes since
3538 dbus-1.pc.in has those.
3540 2003-06-22 Havoc Pennington <hp@pobox.com>
3542 * mono/*, gcj/*, configure.in, Makefile.am:
3543 Check in makefiles and subdirs for mono and gcj bindings.
3544 Neither binding actually exists, just trying to get through
3545 all the build and other boring bits.
3547 2003-06-21 Philip Blundell <philb@gnu.org>
3549 * tools/dbus-monitor.1: Updated.
3551 * tools/dbus-send.1: Likewise.
3553 2003-06-20 Anders Carlsson <andersca@codefactory.se>
3555 * dbus/dbus-transport-unix.c (unix_handle_watch): Check
3556 for hangup and error after checking read so we won't discard
3557 pending data if both hangup and read are set.
3559 2003-06-19 Philip Blundell <philb@gnu.org>
3561 * tools/dbus-print-message.c (print_message): Handle BOOLEAN.
3563 * tools/dbus-send.c: Accept both --system and --session.
3565 * tools/dbus-monitor.c: Same here.
3567 2003-06-19 Anders Carlsson <andersca@codefactory.se>
3569 * glib/dbus-glib.h: Fix so that dbus-glib.h can be used
3570 from C++ (Patch by Miloslav Trmac).
3572 2003-06-15 Joe Shaw <joe@assbarn.com>
3574 * configure.in: Check for socklen_t.
3576 * dbus/dbus-sysdeps.c: Define socklen_t if it's not defined.
3578 * test/test-segfault.c: Add #include <sys/time.h>
3580 * tools/Makefile.am: Add DBUS_X_CFLAGS to the INCLUDES since
3581 dbus-launch needs it.
3583 2003-06-09 Havoc Pennington <hp@redhat.com>
3585 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): don't use
3586 SUN_LEN, it breaks abstract socket usage
3588 * dbus/dbus-internals.c (_dbus_verbose_real): only print PID at
3591 2003-06-04 Havoc Pennington <hp@pobox.com>
3593 * dbus/dbus-server.c (dbus_server_listen): allow abstract sockets
3594 using unix:abstract=/foo, and when listening in a tmpdir
3595 i.e. unix:tmpdir=/tmp, always use abstract sockets if we can.
3597 * dbus/dbus-transport.c (_dbus_transport_open): support
3600 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
3601 support abstract sockets
3603 * dbus/dbus-transport-unix.c
3604 (_dbus_transport_new_for_domain_socket): support abstract sockets
3606 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket): add "abstract"
3607 toggle as an argument, implement abstract namespace support
3608 (_dbus_listen_unix_socket): ditto
3610 * configure.in: add --enable-abstract-sockets and implement
3611 a configure check for autodetection of the right value.
3613 2003-06-01 Havoc Pennington <hp@pobox.com>
3615 * tools/dbus-cleanup-sockets.c: add utility to clean up sockets
3616 in /tmp (though on Linux this will end up being useless,
3617 when we add abstract namespace support)
3619 * configure.in: define DBUS_SESSION_SOCKET_DIR in addition to
3622 2003-05-28 Colin Walters <walters@verbum.org>
3624 * tools/dbus-monitor.c (main): Fix silly typo (s/--session/--system/).
3626 2003-05-18 Anders Carlsson <andersca@codefactory.se>
3628 * dbus/dbus-message.c (dbus_message_new): Remove @todo.
3630 2003-05-17 Colin Walters <walters@gnu.org>
3632 * tools/dbus-send.c: Don't exit with an error code if --help was
3633 passed. Default to using the session bus instead of the system
3636 * tools/dbus-launch.c: Ditto.
3638 * tools/dbus-monitor.c: Ditto.
3640 * tools/dbus-send.1: Update with new arguments.
3642 * tools/dbus-launch.c: Emit code to export variables. New
3643 arguments -s and -c to specify shell syntax, and a bit of code to
3644 autodetect syntax. Also, allow specifying a program to run.
3646 * tools/dbus-launch.1: Update with new arguments.
3648 * tools/dbus-send.1: Ditto.
3650 * tools/dbus-monitor.1: Ditto.
3652 2003-05-17 Havoc Pennington <hp@pobox.com>
3654 * bus/config-parser.c (merge_included): merge in policies from
3655 child configuration file.
3657 * bus/policy.c (bus_policy_merge): function to merge two policies
3660 2003-05-16 Havoc Pennington <hp@redhat.com>
3662 * dbus/dbus-connection.c: disable verbose lock spew
3664 * tools/dbus-send.c: add --print-reply command line option
3666 * tools/dbus-print-message.h (print_message): new util function
3667 shared by dbus-send and dbus-monitor
3669 * tools/dbus-monitor.c (handler_func): exit on disconnect
3671 * dbus/dbus-transport-unix.c (do_reading): if the transport is
3672 disconnected, don't try to use the read_watch
3674 * dbus/dbus-watch.c (dbus_watch_get_enabled): assert watch != NULL
3675 so we can find this bug more easily
3677 2003-05-16 Havoc Pennington <hp@redhat.com>
3679 * bus/policy.c (free_rule_list_func): avoid a crash when passed
3680 NULL as DBusHashTable is annoyingly likely to do.
3682 2003-05-16 Colin Walters <walters@verbum.org>
3684 * tools/dbus-monitor.c: Add --session argument and usage()
3687 * tools/dbus-monitor.1: Update with new --session arg.
3689 * bus/Makefile.am (install-data-hook): Create
3690 $(libdir)/dbus-1.0/services so that the session bus is happy.
3692 2003-05-15 Havoc Pennington <hp@redhat.com>
3694 * dbus/dbus-sysdeps.c (_dbus_atomic_dec, _dbus_atomic_inc): work
3695 on non-x86. ifdef's are evil.
3697 2003-05-15 Havoc Pennington <hp@redhat.com>
3699 * configure.in: 0.11
3703 * bus/Makefile.am (initddir): apparently we are supposed to put
3704 init scripts in /etc/rc.d/init.d not /etc/init.d
3706 * bus/Makefile.am: remove the "you must --enable-tests to make
3707 check" as it broke distcheck
3709 * bus/Makefile.am (install-data-hook): create /etc/dbus-1/system.d
3711 2003-05-13 James Willcox <jwillcox@gnome.org>
3714 * bus/activation.c: (bus_activation_service_created),
3715 (bus_activation_activate_service):
3716 * bus/driver.c: (bus_driver_send_service_deleted),
3717 (bus_driver_send_service_created), (bus_driver_send_service_lost),
3718 (bus_driver_send_service_acquired),
3719 (bus_driver_send_welcome_message),
3720 (bus_driver_handle_list_services):
3721 * bus/session.conf.in:
3722 * dbus/dbus-bus.c: (dbus_bus_acquire_service),
3723 (dbus_bus_service_exists), (dbus_bus_activate_service):
3726 Add some convenience API which lets you activate a service, and did a
3727 bunch of s/0/DBUS_TYPE_INVALID/ in calls to dbus_message_append_args()
3728 and dbus_message_get_args()
3730 2003-05-11 Havoc Pennington <hp@pobox.com>
3732 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix to avoid
3733 calling _dbus_marshal_validate_arg() for every byte in a byte
3736 * dbus/dbus-message-handler.c: use atomic reference counting to
3737 reduce number of locks slightly; the global lock in here sucks
3739 * dbus/dbus-connection.c
3740 (_dbus_connection_update_dispatch_status_and_unlock): variant of
3741 update_dispatch_status that can be called with lock held; then use
3742 in a couple places to reduce locking/unlocking
3743 (dbus_connection_send): hold the lock over the whole function
3744 instead of acquiring it twice.
3746 * dbus/dbus-timeout.c (_dbus_timeout_new): handle OOM
3748 * bus/connection.c (bus_connections_setup_connection): fix access
3749 to already-freed memory.
3751 * dbus/dbus-connection.c: keep a little cache of linked list
3752 nodes, to avoid using the global linked list alloc lock in the
3753 normal send-message case. Instead we just use the connection lock
3754 that we already have to take.
3756 * dbus/dbus-list.c (_dbus_list_find_last): new function
3758 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec):
3759 change to use a struct for the atomic type; fix docs,
3760 they return value before increment, not after increment.
3762 * dbus/dbus-string.c (_dbus_string_append_4_aligned)
3763 (_dbus_string_append_8_aligned): new functions to try to
3764 microoptimize this operation.
3765 (reallocate_for_length): break this out of set_length(), to
3766 improve profile info, and also so we can consider inlining the
3769 * dbus/dbus-message.c (dbus_message_new_empty_header): init data
3770 strings with some preallocation, cuts down on our calls to realloc
3771 a fair bit. Though if we can get the "move entire string to empty
3772 string" optimization below to kick in here, it would be better.
3774 * dbus/dbus-string.c (_dbus_string_move): just call
3775 _dbus_string_move_len
3776 (_dbus_string_move_len): add a special case for moving
3777 an entire string into an empty string; we can just
3778 swap the string data instead of doing any reallocs.
3779 (_dbus_string_init_preallocated): new function
3781 2003-05-11 Havoc Pennington <hp@pobox.com>
3783 Write a "test-profile" that does echo client-server with threads;
3784 profile reveals lock contention, memcpy/realloc of buffers, and
3785 UTF-8 validation as hot spots. 20% of lock contention eliminated
3786 with dbus_atomic_inc/dec implementation on x86. Much remaining
3787 contention is global mempool locks for GList and DBusList.
3789 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec): add
3792 * dbus/dbus-connection.c (struct DBusConnection): use
3793 dbus_atomic_t for the reference count
3795 * dbus/dbus-message.c (struct DBusMessage): declare
3796 dbus_atomic_t values as volatile
3798 * configure.in: code to detect ability to use atomic integer
3799 operations in assembly, from GLib patch
3801 * dbus/dbus-internals.c (_dbus_verbose_real): call getpid every
3802 time, tired of it being wrong in threads and forked processes
3804 * glib/test-profile.c: a little program to bounce messages back
3805 and forth between threads and eat CPU
3807 * dbus/dbus-connection.c: add debug spew macros for debugging
3808 thread locks; include config.h at top; fix deadlock in
3809 dbus_connection_flush()
3811 2003-05-08 Havoc Pennington <hp@pobox.com>
3813 * dbus/dbus-spawn.c: s/_exit/exit/ because it was keeping gcov
3814 data from getting written, and there wasn't a good reason to
3817 * test/decode-gcov.c (mark_inside_dbus_build_tests): don't count
3818 dbus_verbose lines in test coverage
3819 (main): add list of functions sorted by # of untested blocks
3820 to the coverage report
3822 * dbus/dbus-mempool.c: put some test-only code in DBUS_BUILD_TESTS
3824 * dbus/dbus-marshal.c (_dbus_marshal_test): extend test coverage
3826 * dbus/dbus-message-handler.c (_dbus_message_handler_test):
3827 extend test coverage
3829 * test/data/auth/cancel.auth-script: test canceling an
3832 * dbus/Makefile.am: remove dbus-server-debug.[hc] for now, as they
3833 aren't used. in CVS history if we end up needing them.
3835 2003-05-04 Havoc Pennington <hp@pobox.com>
3837 * dbus/dbus-message-handler.c (_dbus_message_handler_test): add
3840 * dbus/dbus-marshal.c (_dbus_demarshal_string_array): fix this
3841 function, which assumed length was in # of strings, not bytes
3843 * dbus/dbus-message.c (_dbus_message_test): add tests for some
3846 * dbus/dbus-connection.c
3847 (_dbus_connection_queue_received_message): disable function for
3848 now, we are only using it in test mode
3850 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
3851 remove a mistaken FIXME
3853 2003-05-04 Havoc Pennington <hp@pobox.com>
3855 * dbus/dbus-connection.c (dbus_connection_preallocate_send):
3856 unlock mutex on successful return, patch from Anders Gustafsson
3858 2003-05-04 Havoc Pennington <hp@pobox.com>
3860 * dbus-glib-1.pc.in (Requires): fix dependencies, from
3863 2003-05-04 Havoc Pennington <hp@pobox.com>
3865 * tools/dbus-launch.c: implement
3867 * bus/main.c (main), bus/bus.c (bus_context_new):
3868 implement --print-pid and --fork
3870 2003-05-03 Havoc Pennington <hp@redhat.com>
3872 * dbus/dbus-address.c (dbus_parse_address): fix bug when a key in
3873 the address had no value, and add to test suite. Fix and
3874 regression test from Miloslav Trmac
3876 2003-05-03 Havoc Pennington <hp@pobox.com>
3878 * dbus/dbus-watch.c (dbus_watch_handle): warn and return if a
3879 watch is invalid when handled
3881 * tools/Makefile.am, tools/dbus-launch.c, tools/dbus-launch.1: add
3882 dbus-launch utility to launch the bus from a shell script. Didn't
3883 actually implement dbus-launch yet, it's just a placeholder still.
3885 2003-05-03 Havoc Pennington <hp@pobox.com>
3887 * bus/Makefile.am, bus/dbus-daemon-1.1.in: man page for the
3888 daemon; also documents daemon config file, so replaces
3889 doc/config-file.txt. Corrected some stuff from config-file.txt in
3890 the process of moving it.
3892 2003-05-03 Havoc Pennington <hp@pobox.com>
3894 * tools/Makefile.am, tools/dbus-send.1, tools/dbus-monitor.1:
3897 2003-05-03 Colin Walters <walters@verbum.org>
3899 * dbus/dbus-sysdeps.c (fill_user_info): Test against
3900 DBUS_UID_UNSET to determine whether to do a uid lookup or not.
3902 * Makefile.am: Update to use new .pc versioning scheme.
3904 2003-05-02 Havoc Pennington <hp@redhat.com>
3906 * bus/system.conf.in: allow send/receive to/from message bus
3909 2003-04-30 Havoc Pennington <hp@redhat.com>
3911 * configure.in: print a note when building with unit tests and
3914 2003-04-30 Havoc Pennington <hp@redhat.com>
3916 * Makefile.am: add a check-local that complains if you didn't
3917 configure with --enable-tests
3919 2003-04-29 Havoc Pennington <hp@redhat.com>
3921 * glib/dbus-gmain.c: docs cleanups
3923 * dbus/dbus-types.h: add docs on int64 types
3925 * dbus/dbus-memory.c: fix docs to avoid putting private API in
3926 public API docs section
3928 2003-04-29 Havoc Pennington <hp@redhat.com>
3930 * dbus-1.pc.in, dbus-glib-1.pc.in: rename these from
3931 dbus-1.0.pc.in, dbus-glib-1.0.pc.in. As these change with the
3932 parallel install API version, not with the D-BUS package version.
3934 * HACKING: move some of README over here
3936 * README: updates, and document API/ABI policy
3938 * configure.in: reindentation
3940 2003-04-29 Havoc Pennington <hp@redhat.com>
3942 * dbus/dbus.h: add "you have to define DBUS_API_SUBJECT_TO_CHANGE
3943 to use this library" to be sure people have the right
3946 2003-04-28 Havoc Pennington <hp@redhat.com>
3948 * configure.in: add --enable-docs which by default is auto yes if
3949 doxygen and db2html found, no otherwise; but can be forced on/off
3951 * doc/Makefile.am: conditionalize whether to build docs on
3954 2003-04-28 Havoc Pennington <hp@redhat.com>
3956 * configure.in: 0.10
3960 * bus/system.conf.in: add <includedir>system.d</includedir>
3962 * dbus/dbus-userdb.c (_dbus_user_database_lookup): fix bug when
3963 username was provided but not uid
3965 * bus/config-parser.c (struct BusConfigParser): keep track of
3966 whether the parser is toplevel or was included; change some
3967 of the error handling if it's included.
3969 2003-04-27 Havoc Pennington <hp@pobox.com>
3973 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
3974 report correct status if we finish processing authentication
3975 inside this function.
3977 * bus/activation.c (try_send_activation_failure): use
3978 bus_transaction_send_error_reply
3980 * bus/connection.c (bus_connection_get_groups): return an error
3981 explaining the problem
3983 * bus/bus.c (bus_context_check_security_policy): implement
3984 restriction here that inactive connections can only send the
3985 hello message. Also, allow bus driver to send anything to
3988 * bus/connection.c (bus_connection_complete): create the
3989 BusClientPolicy here instead of on-demand.
3990 (bus_connection_get_policy): don't return an error
3992 * dbus/dbus-message.c (dbus_message_new_error_reply): allow NULL
3993 sender field in message being replied to
3995 * bus/bus.c (bus_context_check_security_policy): fix silly typo
3996 causing it to return FALSE always
3998 * bus/policy.c (bus_client_policy_check_can_send): fix bug where
3999 we checked sender rather than destination
4001 2003-04-25 Havoc Pennington <hp@redhat.com>
4003 test suite is slightly hosed at the moment, will fix soon
4005 * bus/connection.c (bus_connections_expire_incomplete): fix to
4006 properly disable the timeout when required
4007 (bus_connection_set_name): check whether we can remove incomplete
4008 connections timeout after we complete each connection.
4010 * dbus/dbus-mainloop.c (check_timeout): fix this up a bit,
4011 probably still broken.
4013 * bus/services.c (bus_registry_acquire_service): implement max
4014 number of services owned, and honor allow/deny rules on which
4015 services a connection can own.
4017 * bus/connection.c (bus_connection_get_policy): report errors here
4019 * bus/activation.c: implement limit on number of pending
4022 2003-04-25 Havoc Pennington <hp@redhat.com>
4024 * dbus/dbus-transport.c (_dbus_transport_get_unix_user): fix bug
4025 where we used >= 0 instead of != DBUS_UID_UNSET.
4027 2003-04-25 Havoc Pennington <hp@redhat.com>
4029 * glib/dbus-gmain.c (remove_watch): fix for a crash when watches
4030 were toggled without add/remove, fix from Anders Gustafsson
4032 2003-04-24 Havoc Pennington <hp@redhat.com>
4034 * test/data/valid-config-files/basic.conf: add <limit> tags to
4037 * bus/config-parser.h, bus/config-parser.c, bus/bus.c: Implement
4038 <limit> tag in configuration file.
4040 2003-04-24 Havoc Pennington <hp@redhat.com>
4042 * bus/dispatch.c: somehow missed some name_is
4044 * dbus/dbus-timeout.c (_dbus_timeout_set_enabled)
4045 (_dbus_timeout_set_interval): new
4047 * bus/connection.c (bus_connections_setup_connection): record time
4048 when each connection is first set up, and expire them after the
4049 auth timeout passes.
4051 2003-04-24 Havoc Pennington <hp@redhat.com>
4053 * dbus/dbus-message.c (dbus_message_name_is): rename
4054 (dbus_message_service_is): rename
4055 (dbus_message_sender_is): rename
4056 (dbus_message_get_service): rename
4058 2003-04-24 Havoc Pennington <hp@redhat.com>
4060 * configure.in: add --enable-checks
4062 * dbus/dbus-message.c (dbus_message_new): reverse name/service arguments
4064 * dbus/dbus-connection.c (dbus_connection_preallocate_send): fix
4065 to use thread locks.
4066 (_dbus_connection_handler_destroyed_locked): move some private
4067 functions into proper docs group
4069 * dbus/dbus-internals.h: add _dbus_return_if_fail,
4070 _dbus_return_val_if_fail
4072 Throughout: use dbus_return_if_fail
4074 2003-04-23 James Willcox <jwillcox@gnome.org>
4077 * glib/dbus-gmain.c: (add_timeout), (wakeup_main), (create_source),
4078 (dbus_connection_setup_with_g_main),
4079 (dbus_server_setup_with_g_main):
4080 * glib/test-dbus-glib.c: (main):
4081 * glib/test-thread-client.c: (main):
4082 * glib/test-thread-server.c: (new_connection_callback), (main):
4083 * tools/dbus-monitor.c: (main):
4085 Added a GMainContext argument to dbus_connection_setup_with_g_main()
4086 and dbus_server_setup_with_g_main().
4088 2003-04-20 Havoc Pennington <hp@pobox.com>
4090 * doc/dbus-specification.sgml: document the restrictions on
4091 message and service names
4093 2003-04-22 Havoc Pennington <hp@redhat.com>
4095 * dbus/dbus-message.c, dbus/dbus-marshal.c: add 64-bit integer
4096 support, and do some code cleanups to share more code and
4097 speed up array marshal/demarshal.
4099 * dbus-1.0.pc.in (Cflags): put libdir include file in cflags
4101 * configure.in: generate dbus-arch-deps.h
4103 * dbus/dbus-protocol.h (DBUS_TYPE_INT64, DBUS_TYPE_UINT64): add
4106 2003-04-22 Havoc Pennington <hp@redhat.com>
4108 * test/data/valid-messages/opposite-endian.message: fix test
4109 to use proper type for rply field
4111 * test/data/invalid-messages: add tests for below validation
4113 * dbus/dbus-message.c (decode_header_data): validate field types,
4114 and validate that named fields are valid names
4115 (decode_name_field): consider messages in the
4116 org.freedesktop.Local. namespace to be invalid.
4118 * dbus/dbus-string.c (_dbus_string_validate_name): new
4120 2003-04-19 Havoc Pennington <hp@pobox.com>
4122 * bus/driver.c (bus_driver_handle_hello): check limits and
4123 return an error if they are exceeded.
4125 * bus/connection.c: maintain separate lists of active and inactive
4126 connections, and a count of each. Maintain count of completed
4127 connections per user. Implement code to check connection limits.
4129 * dbus/dbus-list.c (_dbus_list_unlink): export
4131 * bus/bus.c (bus_context_check_security_policy): enforce a maximum
4132 number of bytes in the message queue for a connection
4134 2003-04-18 Havoc Pennington <hp@pobox.com>
4136 * dbus/dbus-auth.c (record_mechanisms): memleak fixes
4138 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): fix some
4141 * dbus/dbus-keyring.c (add_new_key): fix a memleak, and
4142 on realloc be sure to update the pointer in the keyring
4144 * dbus/dbus-string.c (_dbus_string_zero): compensate for align
4145 offset to avoid writing to unallocated memory
4147 * dbus/dbus-auth.c (process_rejected): return FALSE if we fail to
4148 try the next mechanism, so we properly handle OOM
4150 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): fix double-free
4152 (_dbus_keyring_new): fix OOM bug
4153 (_dbus_keyring_new_homedir): always set error; impose a maximum
4154 number of keys we'll load from the file, mostly to speed up the
4155 test suite and make its OOM checks more useful, but also for
4158 * dbus/dbus-auth.c (process_error_server): reject authentication
4159 if we get an error from the client
4160 (process_cancel): on cancel, send REJECTED, per the spec
4161 (process_error_client): send CANCEL if we get an error from the
4164 2003-04-18 Havoc Pennington <hp@pobox.com>
4166 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix UMR in verbose
4169 * dbus/dbus-auth.c (handle_client_data_cookie_sha1_mech): fix OOM
4172 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): only whine
4173 about DBUS_TEST_HOMEDIR once
4175 * bus/Makefile.am (TESTS_ENVIRONMENT): put DBUS_TEST_HOMEDIR in
4178 * bus/dispatch.c (bus_dispatch_sha1_test): actually load sha1
4179 config file so we test the right thing
4181 Throughout: assorted docs improvements
4183 2003-04-18 Havoc Pennington <hp@pobox.com>
4185 * glib/dbus-gmain.c: adapt to watch changes
4187 * bus/bus.c, bus/activation.c, etc.: adjust to watch changes
4189 * dbus/dbus-server.h: remove dbus_server_handle_watch
4191 * dbus/dbus-connection.h: remove dbus_connection_handle_watch
4193 * dbus/dbus-watch.c (dbus_watch_handle): change DBusWatch to work
4194 like DBusTimeout, so we don't need dbus_connection_handle_watch
4197 2003-04-17 Havoc Pennington <hp@redhat.com>
4199 * dbus/dbus-userdb.c, dbus/dbus-sysdeps.c: redo all the passwd
4200 database usage so it all goes via the DBusUserDatabase cache.
4202 2003-04-17 Havoc Pennington <hp@redhat.com>
4204 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix logic so that if
4205 there was an OOM watch we skipped, we always return TRUE so we
4206 iterate again to have a look at it again. Fixes test suite hang.
4207 Code rearrangement also lets us lose some memset and only iterate
4208 over callbacks once.
4210 * bus/driver.c (bus_driver_handle_message): sense of test for
4213 2003-04-16 Havoc Pennington <hp@pobox.com>
4215 * doc/dbus-specification.sgml: make spec say serials are unsigned
4217 * dbus/dbus-message.h: change message serials to unsigned
4219 * dbus/dbus-connection.c: adapt to message serials being unsigned
4221 2003-04-15 Havoc Pennington <hp@pobox.com>
4223 * bus/bus.c: create and keep around a shared DBusUserDatabase
4226 * bus/connection.c (bus_connection_get_groups): don't cache
4227 groups for user in the connection object, since user database
4228 object now does that.
4230 2003-04-16 Havoc Pennington <hp@redhat.com>
4232 * dbus/dbus-message.c (_dbus_message_add_size_counter): keep a
4233 list of size counters
4234 (_dbus_message_loader_putback_message_link): put back a popped link
4236 * dbus/dbus-connection.c
4237 (dbus_connection_set_max_live_messages_size): rename
4239 (dbus_connection_get_outgoing_size): get size of outgoing
4241 (_dbus_connection_set_connection_counter): remove this cruft
4243 2003-04-14 Havoc Pennington <hp@redhat.com>
4245 * dbus/dbus-userdb.c: user database abstraction, mostly to get
4246 caching, but at some point we might want to be able to use a
4249 * bus/dispatch.c (bus_dispatch_sha1_test): add a test that uses
4250 SHA1 conf file to test the sha1 auth mechanism, since the regular
4251 test always uses EXTERNAL when available.
4254 test/data/valid-config-files/debug-allow-all-sha1.conf.in:
4255 add conf file that requires use of sha1 auth
4257 2003-04-13 Havoc Pennington <hp@pobox.com>
4259 * tools/dbus-send.c, tools/dbus-monitor.c: two utility programs
4260 from Philip Blundell to send messages and monitor them.
4262 2003-04-13 Havoc Pennington <hp@pobox.com>
4264 * dbus/dbus-mainloop.c: fix some reentrancy issues by refcounting
4267 * test/data/valid-config-files/debug-allow-all.conf.in: allow all
4270 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
4271 fix to only recover unused bytes if we're already authenticated
4272 (_dbus_transport_get_is_authenticated): fix to still mark us
4273 authenticated if there are unused bytes.
4275 * bus/dispatch.c: implement security policy checking
4277 * bus/connection.c (bus_transaction_send_from_driver): new
4279 * bus/bus.c (bus_context_check_security_policy): new
4281 * bus/dispatch.c (send_service_nonexistent_error): delete this,
4282 now we just set the DBusError and it gets converted to an error
4285 * bus/connection.c (allow_user_function): enable code using actual
4286 data from the config file
4288 * bus/policy.c (list_allows_user): handle wildcard rules for
4289 user/group connection perms
4291 2003-04-13 Havoc Pennington <hp@pobox.com>
4293 * bus/config-parser.c: Load up the BusPolicy and BusPolicyRules
4295 * dbus/dbus-sysdeps.c (_dbus_get_user_id): new function
4297 * bus/policy.c (bus_policy_append_mandatory_rule)
4298 (bus_policy_append_default_rule, bus_policy_append_user_rule)
4299 (bus_policy_append_group_rule): new functions
4301 2003-04-12 Havoc Pennington <hp@pobox.com>
4303 * bus/config-parser.c (bus_config_parser_new): fix a memleak
4305 * dbus/dbus-sysdeps.c: change DBusCredentials to use longs for
4306 the pid/gid/uid, just for paranoia.
4308 * test/break-loader.c (randomly_do_n_things): find a byte
4309 containing a type code, and randomly change it to a different
4312 2003-04-12 Havoc Pennington <hp@pobox.com>
4314 * bus/policy.h: change BusPolicy to be the thing from the config
4315 file, and rename old BusPolicy to BusClientPolicy
4317 * bus/bus.c, bus/connection.c, bus/config-parser.c: change to
4318 match change in how policy works
4320 * dbus/dbus-internals.h: mark assert_not_reached as
4321 __attribute((noreturn))__
4323 2003-04-11 Havoc Pennington <hp@redhat.com>
4325 * doc/dbus-specification.sgml: fix a spot with the wrong name for
4326 the broadcast service. Use boolean return for ServiceExists.
4328 2003-04-11 Havoc Pennington <hp@redhat.com>
4330 * configure.in: add another directory to look for qt in.
4332 2003-04-11 Havoc Pennington <hp@redhat.com>
4334 * AUTHORS: add Colin Walters
4336 2003-04-11 Havoc Pennington <hp@redhat.com>
4342 2003-04-11 Havoc Pennington <hp@redhat.com>
4344 * bus/messagebus.in: remove pid file when stopping the
4345 message bus, since the bus won't have privileges to remove it
4348 2003-04-11 Havoc Pennington <hp@redhat.com>
4350 * bus/bus.c (bus_context_new): move credentials change after
4353 2003-04-11 Havoc Pennington <hp@pobox.com>
4355 * test/decode-gcov.c: add "below average functions" to the
4356 coverage report, and change how some of the code works.
4358 * bus/test-main.c: bracket some stuff in DBUS_BUILD_TESTS so it's
4359 not in the coverage stats.
4361 * test/test-service.c (main): use _dbus_verbose not fprintf in a
4362 couple places so running the test suite doesn't result in megaspam.
4364 2003-04-11 Havoc Pennington <hp@pobox.com>
4366 * bus/dispatch.c (check_existent_service_activation): accept a no
4367 memory error in a place we didn't before
4369 * bus/test.c (bus_test_run_everything): remove hacky "do it twice
4370 in case the first one failed," since the test suite is less
4373 2003-04-10 Havoc Pennington <hp@pobox.com>
4375 * bus/dispatch.c (check_segfault_service_activation): add test
4376 for launching an executable that just crashes.
4378 * test/test-segfault.c (main): try setting coredumpsize to 0 so we
4379 don't leave a million cores. We'll see how portable this is.
4381 2003-04-10 Havoc Pennington <hp@pobox.com>
4383 * dbus/dbus-spawn.c (_dbus_spawn_async_with_babysitter): move all
4384 the possible parent failures before we fork, so that we don't
4385 fail to create a babysitter after creating the child.
4387 * bus/activation.c (bus_activation_activate_service): kill child
4388 if we don't successfully complete the activation.
4390 2003-04-10 Havoc Pennington <hp@redhat.com>
4392 * dbus/dbus-connection.c (dbus_connection_flush): don't spin on
4393 the connection if it's disconnected
4395 * bus/activation.c (bus_activation_service_created): use new
4396 transaction features to roll back removal of pending activation if
4397 we don't successfully create the service after all. Don't remove
4398 pending activation if the function fails.
4400 * dbus/dbus-list.c (_dbus_list_insert_before_link)
4401 (_dbus_list_insert_after_link): new code to facilitate
4404 * dbus/dbus-hash.c (_dbus_hash_table_insert_string_preallocated):
4405 new functionality, so we can preallocate the ability to insert
4408 * bus/connection.c (bus_transaction_add_cancel_hook): new function
4409 allowing us to put custom hooks in a transaction to be used for
4410 cancelling said transaction
4412 * doc/dbus-specification.sgml: add some discussion of secondary
4413 service owners, and disallow zero-length service names
4415 * bus/services.c (bus_registry_acquire_service): new function,
4416 splits out part of bus_driver_handle_acquire_service() and fixes
4417 a bug where we didn't remove the service doing the acquiring
4418 from the secondary queue if we failed to remove the current owner
4419 from the front of the queue.
4421 2003-04-10 Alexander Larsson <alexl@redhat.com>
4423 * doc/dbus-specification.sgml:
4424 s/org.freedesktop.Broadcast/org.freedesktop.DBus.Broadcast/
4426 2003-04-10 Alexander Larsson <alexl@redhat.com>
4431 Added files to cvsignore
4433 * dbus/dbus-message.h:
4434 * dbus/dbus-message.c: (dbus_message_iter_get_named):
4435 Make get_named() take two out argument and return a boolean.
4436 (dbus_message_iter_get_args_valist):
4437 Update usage of get_named().
4438 (dbus_message_iter_append_byte):
4440 (dbus_message_iter_append_named)
4442 (message_iter_test), (check_message_handling_type), (_dbus_message_test):
4445 2003-04-10 Alexander Larsson <alexl@redhat.com>
4447 * dbus/dbus-marshal.[ch]:
4448 Add array_type_pos argument to _dbus_marshal_validate_arg.
4449 Let you pass a NULL end_pos to _dbus_marshal_validate_type.
4451 * dbus/dbus-message.[ch]:
4452 Multi-dimensional arrays have full type specification in the
4453 outermost array. Iter code re-arranged to handle this.
4454 Added some more iter tests.
4456 * doc/dbus-specification.sgml:
4459 Update new array encoding description.
4460 Correct DBUS_SERVICE_FLAGS_REPLACE_EXISTING description.
4462 * test/data/invalid-messages/array-with-mixed-types.message:
4463 * test/data/valid-messages/array-of-array-of-uint32.message:
4464 Change to the new array format.
4466 * test/data/invalid-messages/too-short-dict.message:
4469 * test/data/valid-messages/recursive-types.message:
4470 Fix up and extend test.
4472 2003-04-10 Havoc Pennington <hp@pobox.com>
4474 * bus/dispatch.c: lots of fixes
4476 * dbus/dbus-mainloop.c (_dbus_loop_dispatch): export
4477 (_dbus_loop_iterate): remove old "quit if no callbacks" code,
4478 that was crack, broke the test service.
4480 * dbus/dbus-transport.c (_dbus_transport_open): fix error
4481 handling to avoid piling up errors if we get a failure on the
4484 * dbus/dbus-internals.c (_dbus_real_assert_not_reached): include
4485 pid in assertion failures.
4487 * dbus/dbus-mainloop.c (_dbus_loop_iterate): use static arrays up
4488 to some fixed size of file descriptor array. Don't return TRUE
4489 anytime a timeout exists, that led to lots of busy loop silliness
4492 2003-04-09 Havoc Pennington <hp@redhat.com>
4494 * dbus/dbus-mainloop.c (check_timeout): fix timeouts, I thought
4495 I'd checked this in earlier but hadn't.
4497 2003-04-09 Havoc Pennington <hp@redhat.com>
4499 * bus/dispatch.c (bus_dispatch_test): get a bit further through
4500 the activation test (man this is getting old!)
4502 2003-04-09 Havoc Pennington <hp@redhat.com>
4504 * test/test-utils.c: use dispatch status function to fix this up
4506 * bus/connection.c (connection_watch_callback): don't dispatch
4508 (connection_timeout_callback): don't dispatch from here
4509 (bus_connections_setup_connection): set the dispatch status function
4510 (bus_connection_disconnected): unset it
4512 * dbus/dbus-mainloop.c (_dbus_loop_queue_dispatch): new function
4513 used to add a connection to be dispatched
4514 (_dbus_loop_iterate): do the dispatching at the end of each
4517 * dbus/dbus-connection.c
4518 (dbus_connection_set_dispatch_status_function): new function
4519 allowing us to fix up main loop usage
4520 (_dbus_connection_last_unref): free all the various function
4522 (dbus_connection_dispatch): call the DispatchStatusFunction
4523 whenever this function returns
4524 (dbus_connection_handle_watch): call DispatchStatusFunction
4525 (dbus_connection_send_with_reply_and_block): call DispatchStatusFunction
4526 (reply_handler_timeout): call DispatchStatusFunction
4527 (dbus_connection_flush): call DispatchStatusFunction
4529 2003-04-09 Havoc Pennington <hp@redhat.com>
4531 * dbus/dbus-bus.c (dbus_bus_register): fix up error handling and
4534 * bus/dispatch.c (check_service_activated): fix bug in test
4536 * dbus/dbus-mainloop.c (check_timeout): fix this up
4538 * dbus/dbus-internals.c (_dbus_verbose_real): include PID in
4539 verbose output so we can sort out output from different processes,
4540 e.g. in the activation case.
4542 2003-04-08 Colin Walters <walters@gnu.org>
4544 * bus/bus.c (struct BusContext) [pidfile]: New member, to store
4546 (bus_context_new): Set it.
4547 (bus_context_unref): Use it to delete the pid file.
4549 2003-04-08 Havoc Pennington <hp@redhat.com>
4551 * test/data/invalid-messages/array-with-mixed-types.message:
4552 regression test that fails for the moment
4554 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): reorder
4555 tests for convenience
4557 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): don't allow
4558 array of nil, it broke things.
4560 * test/data/invalid-messages/array-of-nil.message: regression test
4562 * test/data/valid-messages/array-of-array-of-uint32.message:
4563 happened to write this so added it to suite
4565 2003-04-08 Havoc Pennington <hp@redhat.com>
4567 * bus/driver.c (bus_driver_handle_acquire_service): init
4568 retval/reply before checking name
4570 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add a
4571 recursion depth argument
4573 * dbus/dbus-message.h (struct DBusMessageIter): put some padding
4574 in the public struct for future extension
4576 * dbus/dbus-message-builder.c (_dbus_message_data_load): fix
4579 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix a verbose
4582 * doc/dbus-specification.sgml: fix typo
4584 2003-04-08 Alexander Larsson <alexl@redhat.com>
4586 Implemented recursive types, named types and new-style iters
4589 * glib/test-thread-client.c: (thread_func):
4590 * glib/test-thread-server.c: (handle_test_message):
4591 * test/test-service.c: (handle_echo):
4600 * dbus/dbus-internals.c: (_dbus_type_to_string):
4601 Update for new types.
4603 * dbus/dbus-marshal.[ch]:
4604 Implement recursive types and the new marshalling format.
4605 Remove hardcoded dict marshalling.
4606 Marshal named types.
4608 * dbus/dbus-message-builder.c:
4610 Remove references to old types
4612 * dbus/dbus-message.[ch]:
4613 New non-refcounted iter API that supports recursive iters.
4614 Use iters for appending, including support for recursive
4616 Add byte and named type support.
4617 Update everything to new marshalling formats.
4618 Add tests for new API.
4620 * dbus/dbus-protocol.h:
4621 Remove old array types.
4622 Add types: BYTE, ARRAY, DICT, NAMED
4624 * dbus/dbus-string.c:
4625 * dbus/dbus-sysdeps.c:
4626 Make parse_double locale safe.
4628 * dbus/dbus-test-main.c:
4634 * doc/dbus-specification.sgml:
4637 * test/data/incomplete-messages/missing-body.message:
4638 * test/data/invalid-messages/bad-boolean.message:
4639 * test/data/invalid-messages/bad-boolean-array.message:
4640 * test/data/invalid-messages/boolean-array-length-too-long.message-raw:
4641 * test/data/invalid-messages/boolean-has-no-value.message-raw:
4642 * test/data/invalid-messages/too-short-dict.message:
4643 * test/data/valid-messages/dict-simple.message:
4644 * test/data/valid-messages/dict.message:
4645 * test/data/valid-messages/emptiness.message:
4646 * test/data/valid-messages/lots-of-arguments.message:
4647 * test/data/valid-messages/no-padding.message:
4648 * test/data/valid-messages/recursive-types.message:
4649 Add missing NAME fields
4650 Fix up dicts & arrays
4652 * test/data/invalid-messages/dict-with-nil-value.message:
4653 Removed, this is not invalid anymore.
4655 * test/data/valid-messages/recursive-types.message:
4656 Add new test for deeply recursive types.
4658 2003-04-07 Havoc Pennington <hp@pobox.com>
4660 * bus/driver.c (bus_driver_handle_acquire_service): return an
4661 error if you try to acquire a service that starts with ':'
4663 2003-04-07 Havoc Pennington <hp@redhat.com>
4665 * doc/dbus-specification.sgml: require that base service names
4666 start with ':' and that the base service is created/deleted
4667 as first and last things a connection does on the bus
4669 * bus/dispatch.c (check_existent_service_activation): lots more
4670 work on the activation test; it doesn't fully pass yet...
4672 * test/test-service.c (main): fix so we don't memleak the
4673 connection to the message bus
4674 (filter_func): accept a message asking us to exit
4676 2003-04-06 Havoc Pennington <hp@pobox.com>
4678 * qt/Makefile.am (dbusinclude_HEADERS): install dbus-qt.h,
4681 * configure.in: fixes to Qt detection from Colin Walters
4683 * doc/Makefile.am: Only remove generated docbook dirs if they
4684 exist, from Colin Walters
4686 * dbus/dbus-bus.c: change how we set well-known connections to
4687 NULL, so that it works if a single connection is stored in
4688 two well-known array slots.
4690 * test/Makefile.am: remove a lot of stuff that isn't immediately
4691 useful, it's in CVS history if we want it.
4693 * test/test-service.c: use dbus-mainloop instead of that
4696 2003-04-06 Havoc Pennington <hp@pobox.com>
4698 * dbus/Makefile.am: split lists of sources into stuff that goes in
4699 the library, util functions that go in the lib and are also used
4700 elsewhere, and util functions that are used in tests/daemon but
4701 don't go in the lib.
4703 * dbus/dbus-mainloop.h, dbus/dbus-mainloop.c: move bus/loop.[hc]
4704 here so it can be used in test binaries also
4706 2003-04-06 Havoc Pennington <hp@pobox.com>
4708 * dbus/dbus-sysdeps.c (_dbus_become_daemon): write the pidfile
4709 here in the parent process, so we can return an error if it
4710 fails. Also, move some of the code into the child so the parent
4711 is less hosed if we fail midway through.
4713 * bus/bus.c (bus_context_new): move pidfile detection further up
4714 in the function, before we start overwriting sockets and such.
4716 * bus/messagebus.in: adjust this a bit, not sure if it will work.
4718 * configure.in: add --with-system-pid-file and --with-system-socket
4720 2003-04-06 Colin Walters <walters@verbum.org>
4722 * configure.in (DBUS_SYSTEM_PID_FILE): New variable.
4724 * bus/system.conf.in: Declare a pidfile.
4726 * bus/bus.c (bus_context_new): Test for an existing pid file, and
4727 create one (if appropriate).
4729 * bus/config-parser.c (enum ElementType) [ELEMENT_PIDFILE]: New.
4730 (struct BusConfigParser) [pidfile]: New.
4731 (element_type_to_name, merge_included, start_busconfig_child)
4732 (bus_config_parser_end_element, bus_config_parser_content): Handle it.
4733 (bus_config_parser_unref): Free it.
4734 (bus_config_parser_get_pidfile): New function.
4736 * bus/config-parser.h (_dbus_write_pid_file): Prototype.
4738 * dbus/dbus-errors.h (DBUS_ERROR_PIDFILE_EXISTS): New error.
4740 * dbus/dbus-sysdeps.c (_dbus_write_pid_file): New function.
4742 * dbus/dbus-sysdeps.h: Prototype it.
4744 2003-04-06 Havoc Pennington <hp@pobox.com>
4746 * bus/bus.c (bus_context_new): print the address in here, rather
4747 than in main(), because we need to do it before forking the daemon
4749 * bus/dispatch.c (send_service_nonexistent_error): set the sender
4750 on the service nonexistent error
4752 * bus/driver.c (bus_driver_handle_acquire_service): set the
4753 sender on the AcquireService reply
4755 * test/data/valid-config-files/debug-allow-all.conf.in: Make test
4756 server also listen on a UNIX socket so services can connect to it.
4758 2003-04-06 Havoc Pennington <hp@pobox.com>
4760 * dbus/dbus-threads.c: Redo how the fake debug mutexes are done
4761 so it detects deadlocks and also we actually init threads when
4764 2003-04-06 Havoc Pennington <hp@pobox.com>
4766 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
4767 save the domain socket name, and unlink it when we disconnect the
4768 server. Means that at least when we exit normally, we won't leave
4769 a bunch of junk in /tmp
4771 * dbus/dbus-transport-unix.c
4772 (_dbus_transport_new_for_domain_socket): code cleanup (nicer
4773 memory management). (I was making a real change here but then
4776 2003-04-06 Havoc Pennington <hp@pobox.com>
4778 * bus/bus.c (bus_context_new): fix wrong handling of
4779 server_data_slot_unref() in the error case.
4781 * dbus/dbus-internals.h (_dbus_assert): change so it passes
4782 "(condition) != 0" to _dbus_real_assert so that
4783 "_dbus_assert (pointer)" doesn't cause a warning
4785 * bus/main.c (main): accept --print-address option to print out
4786 the message bus address
4788 * dbus/dbus-sysdeps.c (_dbus_generate_random_ascii): export this
4790 * dbus/dbus-transport.c (_dbus_transport_open): special error for
4791 "tmpdir" option to unix: address on client side
4793 * dbus/dbus-server.c (dbus_server_listen): handle "tmpdir" option
4796 * configure.in (TEST_SOCKET_DIR): locate a temporary directory
4797 we can use to create sockets in the test suite.
4799 * bus/main.c (signal_handler): on SIGTERM, exit the daemon
4800 cleanly. To be used for testing.
4802 * dbus/dbus-spawn.c (babysit): use _dbus_set_signal_handler()
4804 * dbus/dbus-sysdeps.c (_dbus_set_signal_handler): new
4806 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
4807 handle trying to call this when there's no servers active
4809 2003-04-05 Havoc Pennington <hp@pobox.com>
4815 2003-04-05 Havoc Pennington <hp@pobox.com>
4817 * bus/bus.c (setup_server): fix this so dbus-daemon-1 doesn't
4818 crash on startup. Need to get "try starting the daemon"
4819 in the test suite I guess. ;-)
4821 * dbus/dbus-server.h, dbus/dbus-server.c: remove the stuff that
4822 tracked the number of open connections; it's better done in
4823 application-specific code as you want it to span all servers etc.
4825 2003-04-05 Havoc Pennington <hp@pobox.com>
4827 * bus/Makefile.am (install-data-hook): add missing DESTDIR,
4828 patch from Colin Walters
4830 2003-04-05 Havoc Pennington <hp@pobox.com>
4832 * doc/config-file.txt (Elements): fix docs of <auth> to reflect
4833 reality; in fact multiple mechanisms are allowed.
4835 * dbus/dbus-internals.c (_dbus_real_assert)
4836 (_dbus_real_assert_not_reached): move guts of _dbus_assert() and
4837 _dbus_assert_not_reached() into functions, so that they don't show
4838 up in basic block counts for test coverage, and don't use up as
4839 much disk space. Does mean slower execution speed though, so
4840 assumes --disable-asserts is the normal production case.
4842 2003-04-05 Havoc Pennington <hp@pobox.com>
4844 * test/Makefile.am (dist-hook): also dist *.in files
4850 2003-04-05 Havoc Pennington <hp@pobox.com>
4852 * dbus/dbus-string.c: docs warning
4854 * dbus/dbus-spawn.c: missing docs
4856 * dbus/dbus-memory.c (struct ShutdownClosure): missing docs
4858 2003-04-05 Havoc Pennington <hp@pobox.com>
4860 * bus/loop.c (bus_loop_iterate): fix the timeout code, using
4863 * dbus/dbus-spawn.c (_dbus_babysitter_unref): set sitter_pid
4864 to -1 once we've reaped the babysitter
4865 (_dbus_babysitter_handle_watch): do as much work as we can, not
4868 * bus/activation.c: add code using DBusBabysitter so that we
4869 handle it when a service fails to start up properly.
4870 (bus_activation_service_created): don't remove the activation
4871 entries as we go, just let them get removed when we free the pending
4872 activation. Unref reply messages after sending them.
4874 2003-04-05 Havoc Pennington <hp@pobox.com>
4876 * test/decode-gcov.c (main): print per-directory stats in the report
4878 * Makefile.am (coverage-report.txt): don't include test/* in gcov stats
4880 2003-04-05 Havoc Pennington <hp@pobox.com>
4882 * Makefile.am (coverage-report.txt): add target "coverage-report.txt"
4884 * test/decode-gcov.c: hack up a little program to suck data
4885 out of gcov files. Yes this is sort of silly.
4887 * configure.in: define something in config.h and do an
4888 AM_CONDITIONAL when gcov is enabled
4890 2003-04-04 Havoc Pennington <hp@redhat.com>
4892 * dbus/dbus-spawn.c, dbus/dbus-spawn.h: Change dbus_spawn to
4893 return a "babysitter" object that is used to monitor the status of
4894 the spawned process and reap it when required.
4896 * test/test-segfault.c, test/test-exit.c,
4897 test/test-sleep-forever.c: binaries that do various lame things,
4898 used in the test suite.
4900 * dbus/dbus-sysdeps.c: kill _dbus_errno_to_string()
4902 2003-04-03 Havoc Pennington <hp@pobox.com>
4904 * dbus/dbus-spawn.c: Move dbus-spawn into a separate file
4905 in preparation for modifying it, dbus-sysdeps is getting
4908 2003-04-03 Havoc Pennington <hp@redhat.com>
4910 * bus/loop.h, bus/loop.c: make the mainloop an object so we can
4913 * bus/*.[hc]: adapt to mainloop change
4915 2003-04-03 Havoc Pennington <hp@redhat.com>
4917 * bus/activation.c (load_directory): fix up memleaks
4918 (bus_activation_entry_free): free the entry
4920 * dbus/dbus-bus.c (dbus_bus_acquire_service): return an error if
4921 we get one from the message bus; fix memleaks.
4923 * dbus/dbus-message.c (dbus_set_error_from_message): new function
4925 2003-04-03 Havoc Pennington <hp@pobox.com>
4927 * bus/config-parser.c (bus_config_parser_unref): free
4928 list of mechanisms, bug discovered by test suite enhancements
4929 (putting system.conf and session.conf into suite)
4931 * test/Makefile.am, test/test-service.c: add placeholder for a
4932 test service that we'll activate as part of test suite. Doesn't
4935 * dbus/dbus-sysdeps.c (_dbus_setenv): support unsetenv by
4936 setting NULL value, and use system malloc not dbus_malloc()
4937 when we have unavoidable memleakage.
4939 * dbus/dbus-bus.c (dbus_bus_get): fix bug where bus type of 0
4940 didn't work, and support DBUS_BUS_ACTIVATION.
4942 * bus/activation.c (child_setup): pass our well-known bus type to
4945 * bus/config-parser.c: support <type> to specify well-known type
4947 * doc/dbus-specification.sgml: document the env variables to
4948 locate well-known buses and find service activator
4950 2003-04-02 Havoc Pennington <hp@redhat.com>
4952 * test/Makefile.am (all-local): add a rule to copy tests to
4953 builddir, so we can have generated tests. Use this to remove the
4954 silly hack for testing system.conf and session.conf. Will use this
4955 shortly to generate .service files pointing to test binaries.
4957 2003-04-02 Havoc Pennington <hp@redhat.com>
4959 * dbus/dbus-string.c (set_length): fix a bug - we allocated max of
4960 current alloc and needed new length, not max of the doubled
4961 allocation and needed new length. Also, when building tests,
4962 don't do the double-allocation stuff, just realloc every time.
4964 2003-04-02 Havoc Pennington <hp@redhat.com>
4966 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): include filenames
4968 (_dbus_string_get_dirname): new
4969 (_dbus_sysdeps_test): new
4970 (_dbus_directory_open): include dirnames in error messages
4972 * bus/config-parser.c: interpret <include> and <includedir> and
4973 <servicedir> relative to config file location if the given
4974 filename is not absolute.
4976 * dbus/dbus-string.c (_dbus_string_find_byte_backward): new
4978 2003-04-02 Havoc Pennington <hp@redhat.com>
4980 * bus/connection.c (bus_transaction_send_error_reply): set sender
4981 service for the error, and unref the reply on success
4983 * bus/activation.c: convert to use BusTransaction so OOM can be
4985 (bus_activation_service_created): set sender of the message
4987 2003-04-01 Havoc Pennington <hp@redhat.com>
4989 * bus/config-parser.c, bus/bus.c: implement <servicedir> and
4990 <includedir> (at least mostly)
4992 * dbus/dbus-sysdeps.c (_dbus_change_identity): set the group ID
4993 first, then the user ID
4995 2003-04-01 Havoc Pennington <hp@pobox.com>
4997 * dbus/dbus-server.c (dbus_server_set_auth_mechanisms): new
5000 * dbus/dbus-auth.c (_dbus_auth_set_mechanisms): new
5002 * dbus/dbus-internals.c (_dbus_dup_string_array): new function
5004 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): chmod the
5005 socket 0777, and unlink any existing socket.
5007 * bus/bus.c (bus_context_new): change our UID/GID and fork if
5008 the configuration file so specifies; set up auth mechanism
5011 * bus/config-parser.c (bus_config_parser_content): add support
5012 for <fork> option and fill in code for <auth>
5014 * bus/system.conf.in: add <fork/> to default configuration,
5015 and limit auth mechanisms to EXTERNAL
5017 * doc/config-file.txt (Elements): add <fork>
5019 * dbus/dbus-sysdeps.c (_dbus_become_daemon): new function
5020 (_dbus_change_identity): new function
5022 2003-03-31 Havoc Pennington <hp@redhat.com>
5024 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket)
5025 (_dbus_listen_unix_socket): fix off-by-one error in null
5026 termination spotted by Nalin
5028 2003-03-31 Havoc Pennington <hp@redhat.com>
5030 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): allow setting
5031 DBUS_TEST_HOMEDIR when tests are enabled, so we can test without
5032 having a real home directory available.
5034 2003-03-31 Havoc Pennington <hp@redhat.com>
5036 * bus/Makefile.am (install-data-hook): create /var/run/dbus
5038 * bus/messagebus.in: add init script for Red Hat /etc/init.d
5040 * configure.in: add support for specifying a style of init script
5043 2003-03-31 Havoc Pennington <hp@redhat.com>
5045 Fix some annoying DBusString API and fix all affected code.
5047 * dbus/dbus-string.c (_dbus_string_init): get rid of annoying
5049 (_dbus_string_get_data): change to return string instead of using
5051 (_dbus_string_get_const_data): ditto
5052 (_dbus_string_get_data_len): ditto
5053 (_dbus_string_get_const_data_len): ditto
5055 2003-03-31 Havoc Pennington <hp@redhat.com>
5057 * bus/main.c (main): fix up the command line arguments to be nicer
5059 2003-03-31 Havoc Pennington <hp@redhat.com>
5061 * dbus/Makefile.am (INCLUDES): use EXPANDED_LOCALSTATEDIR to
5062 define DBUS_SYSTEM_BUS_PATH as we want to compile in the same
5063 final location that lands in the config file
5065 * bus/config-loader-expat.c (bus_config_load): fix type of
5068 * doc/TODO: remove TODO item for dbus_bus_get()
5070 * dbus/dbus-bus.c (bus_data_free): add missing lock/unlock
5072 2003-03-31 Havoc Pennington <hp@pobox.com>
5074 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_domain_socket)
5075 (_dbus_transport_new_for_tcp_socket): these didn't need the "server"
5076 argument since they are always client side
5078 * dbus/dbus-server.c (dbus_server_get_address): new function
5080 * bus/main.c (main): take the configuration file as an argument.
5082 * test/data/valid-config-files/debug-allow-all.conf: new file to
5083 use with dispatch.c tests for example
5085 * bus/test-main.c (main): require test data dir
5087 * bus/bus.c (bus_context_new): change this to take a
5088 configuration file name as argument
5090 * doc/config-file.txt (Elements): add <servicedir>
5092 * bus/system.conf, bus/session.conf: new files
5094 * dbus/dbus-bus.c (dbus_bus_get): look for system bus on
5095 well-known socket if none set
5097 * configure.in: create system.conf and session.conf
5099 2003-03-30 Havoc Pennington <hp@pobox.com>
5101 * bus/config-parser.c: hacking
5103 * dbus/dbus-memory.c: don't use DBusList for the list of stuff
5104 to shut down, since it could cause weirdness with the DBusList
5107 * dbus/dbus-list.c (_dbus_list_test): add tests for the
5108 link-oriented stack routines
5109 (alloc_link): free the mempool if the first alloc from it fails
5111 * dbus/dbus-mempool.c (struct DBusMemBlock): fix alignment issue
5113 * dbus/dbus-string.c (UNICODE_VALID): sync new version of this
5115 (_dbus_string_skip_white): new
5117 * doc/config-file.txt (Elements): add <includedir>
5119 2003-03-28 Havoc Pennington <hp@pobox.com>
5121 * dbus/dbus-string.c (_dbus_string_copy_data_len)
5122 (_dbus_string_copy_data): new functions
5124 2003-03-28 Anders Carlsson <andersca@codefactory.se>
5126 * dbus/dbus-bus.c: (bus_data_free), (dbus_bus_get):
5130 * dbus/dbus-memory.c:
5133 2003-03-28 Havoc Pennington <hp@pobox.com>
5135 * bus/test.c (bus_test_flush_bus): remove the sleep from here,
5136 I think it may have just been superstition. Not sure.
5138 * dbus/dbus-string.c (_dbus_string_base64_decode): catch some OOM
5139 failures that were not being handled.
5141 * dbus/dbus-auth.c (process_auth): fix a memleak in OOM handling
5143 * dbus/dbus-memory.c: add ability to set number of mallocs in a
5144 row that will fail on out-of-memory.
5146 * dbus/dbus-internals.c (_dbus_test_oom_handling): convenience
5147 function for testing out-of-memory handling.
5149 * bus/config-loader-expat.c (memsuite): don't wrap the dbus
5150 allocation functions, they do map exactly to the expat ones.
5152 2003-03-27 Havoc Pennington <hp@redhat.com>
5154 * bus/config-loader-libxml.c (bus_config_load): add another error
5157 2003-03-26 Anders Carlsson <andersca@codefactory.se>
5160 Add note about automatic service activation.
5162 * doc/dbus-specification.sgml:
5163 Rename the specification and clarify a few things.
5165 2003-03-26 Anders Carlsson <andersca@codefactory.se>
5168 * dbus/dbus-address.c:
5170 * dbus/dbus-marshal.c:
5171 * dbus/dbus-server-debug-pipe.c:
5172 * dbus/dbus-transport-unix.c:
5173 Fix documentation warnings.
5175 2003-03-26 Havoc Pennington <hp@pobox.com>
5177 * bus/test-main.c, dbus/dbus-test.c (main): check memleaks
5178 after every test so it's quick and easy to see which leaked, and
5179 so we test multiple dbus_shutdown() calls
5181 * configure.in: change configure.in XML stuff to also support
5184 * config-loader-libxml.c: some hacking
5186 * config-loader-expat.c: some hacking
5188 * config-parser.c: some hacking, plus tests
5190 2003-03-25 Havoc Pennington <hp@redhat.com>
5192 * throughout - add more _DBUS_ASSERT_ERROR_IS_CLEAR
5194 * configure.in: add --with-xml option to specify XML library,
5195 right now only libxml is supported.
5197 * bus/config-loader-libxml.c, config-parser.c: sync some minor
5198 nonworking code between home and work, still just stubs
5200 2003-03-24 Havoc Pennington <hp@redhat.com>
5202 * dbus/dbus-sysdeps.c (_dbus_set_fd_nonblocking): move to this
5205 * dbus/dbus-errors.c (dbus_set_error, dbus_set_error_const): allow
5206 NULL argument for "message" if the error is a well-known one,
5207 fill in a generic message in this case.
5209 * dbus/dbus-errors.h (DBusResultCode): Kill DBusResultCode in
5212 * bus/test.c (bus_test_flush_bus): add
5214 * bus/policy.c (bus_policy_test): test code stub
5216 2003-03-24 Havoc Pennington <hp@pobox.com>
5218 * bus/connection.c (bus_connections_setup_connection): set up
5219 the "can this user connect" function, but it always returns
5220 TRUE until we have a config file parser so we can have a config
5221 file that allows connections.
5223 2003-03-23 Havoc Pennington <hp@pobox.com>
5225 * dbus/dbus-threads.c (dbus_mutex_new, dbus_condvar_new): with
5226 DBUS_BUILD_TESTS, actually alloc/free a block of memory for
5227 the mutex, so we can check for proper memory management
5230 * dbus/dbus-dataslot.c: remove the mutex from
5231 DBusDataSlotAllocator and lock it manually when using it,
5232 to simplify fitting it into the global slots framework.
5234 * dbus/dbus-threads.c (init_static_locks): rework how we're
5235 handling global locks so they are easily shut down.
5237 * bus/policy.c (bus_policy_append_rule): fix
5239 * bus/test-main.c (main): check for memleaks
5241 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): make
5242 test suite check for memleaks
5244 * dbus/dbus-memory.c: add support in test mode for tracking
5245 number of outstanding blocks
5247 2003-03-23 Havoc Pennington <hp@pobox.com>
5249 * bus/policy.c, bus/bus.c, bus/connection.c: implement allow/deny
5252 * dbus/dbus-hash.h: add ULONG hash keys
5254 * dbus/dbus-sysdeps.c (_dbus_get_groups): new
5255 (_dbus_get_group_id): new function
5257 2003-03-20 Havoc Pennington <hp@redhat.com>
5259 * dbus/dbus-connection.c (dbus_connection_set_unix_user_function):
5261 (dbus_connection_get_unix_user): new function
5263 2003-03-20 Havoc Pennington <hp@pobox.com>
5265 * bus/connection.c (bus_connection_send_oom_error): assert that
5266 message has a sender
5267 (connection_execute_transaction): ditto
5268 (bus_connection_preallocate_oom_error): fix to set the sender, and
5269 set recipient to the destination service, not the bus driver
5271 * bus/policy.c: hacking
5273 * dbus/dbus-message.c (dbus_message_service_is): new function
5274 (dbus_message_sender_is): new
5276 2003-03-19 Havoc Pennington <hp@redhat.com>
5278 * bus/policy.c: start sketching code for policy restrictions on
5279 what connections can do.
5281 2003-03-18 Havoc Pennington <hp@redhat.com>
5283 * doc/TODO: some notes on high-level todo items. Little nitpick
5284 stuff is all in @todo, so no need to add it here.
5286 * doc/config-file.txt: some notes on how config file might look
5288 2003-03-18 Anders Carlsson <andersca@codefactory.se>
5294 2003-03-17 Havoc Pennington <hp@redhat.com>
5296 * dbus/dbus-internals.h: add gcc attributes so that
5297 our printf-style functions warn on bad arguments to
5300 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): fix printf
5303 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
5306 2003-03-17 Havoc Pennington <hp@redhat.com>
5308 * bus/test-main.c (main): make it print something as it runs
5309 so make check doesn't look stuck
5311 * doc/negotiation.txt, doc/dbus-sasl-profile.txt: remove
5312 from CVS, now obsolete
5314 2003-03-17 Anders Carlsson <andersca@codefactory.se>
5316 * bus/dispatch.c: (bus_dispatch):
5317 Refetch the service name since it may have been reallocated
5318 when dbus_message_set_sender was called.
5320 * dbus/dbus-sysdeps.c: (_dbus_accept):
5321 Add address and address length variables and use them to stop
5322 valgrind from complaining.
5324 2003-03-17 Havoc Pennington <hp@pobox.com>
5326 All tests pass, no memleaks, no valgrind complaints.
5328 * bus/test.c: refcount handler_slot
5330 * bus/connection.c (bus_connections_new): refcount
5331 connection_data_slot
5333 * dbus/dbus-auth-script.c (_dbus_auth_script_run): delete unused
5334 bytes so that auth scripts pass.
5336 * bus/dispatch.c: init message_handler_slot so it gets allocated
5339 * bus/dispatch.c (message_handler_slot_ref): fix memleak
5341 * dbus/dbus-server-debug-pipe.c (_dbus_server_debug_pipe_new):
5342 dealloc server_pipe_hash when no longer used for benefit of
5345 * dbus/dbus-auth.c (process_command): memleak fix
5347 * bus/dispatch.c (check_hello_message): memleak fix
5349 2003-03-16 Havoc Pennington <hp@pobox.com>
5351 * dbus/dbus-bus.c (ensure_bus_data): fix double-unref of the data slot
5353 2003-03-17 Anders Carlsson <andersca@codefactory.se>
5355 * bus/activation.c (bus_activation_activate_service): Append
5356 the pending activation entry to the list of pending activations.
5358 2003-03-16 Havoc Pennington <hp@pobox.com>
5360 * bus/dispatch.c (bus_dispatch_test): remove double-unrefs of
5363 * dbus/dbus-address.c (create_entry): fix OOM handling when
5364 failing to alloc entry->method
5366 2003-03-16 Havoc Pennington <hp@pobox.com>
5368 * dbus/dbus-watch.c (_dbus_watch_new): handle failure to malloc
5371 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
5372 add some missing dbus_set_result
5374 * bus/dispatch.c (bus_dispatch_add_connection): handle failure to
5375 alloc the DBusMessageHandler
5377 * dbus/dbus-transport.c (_dbus_transport_disconnect): don't ref
5378 the transport here, since we call this from the finalizer; it
5379 resulted in a double-finalize.
5381 * dbus/dbus-transport.c (_dbus_transport_disconnect): fix a bug
5382 where we tried to use transport->connection that was NULL,
5383 happened when transport was disconnected early on due to OOM
5385 * bus/*.c: adapt to handle OOM for watches/timeouts
5387 * dbus/dbus-transport-unix.c: port to handle OOM during
5390 * dbus/dbus-auth.c (_dbus_auth_get_unused_bytes): return a
5391 reference to unused bytes instead of a copy
5393 * dbus/dbus-server.c (dbus_server_handle_watch): return FALSE for
5396 * dbus/dbus-connection.c (dbus_connection_handle_watch): return
5399 * dbus/dbus-timeout.c (dbus_timeout_handle): return FALSE for out
5402 2003-03-16 Anders Carlsson <andersca@codefactory.se>
5404 * doc/dbus-specification.sgml:
5405 Document reply message for ActivateService.
5407 2003-03-16 Anders Carlsson <andersca@codefactory.se>
5409 * bus/activation.c: (bus_pending_activation_entry_free),
5410 (bus_pending_activation_free), (bus_activation_new),
5411 (bus_activation_unref), (bus_activation_service_created),
5412 (bus_activation_activate_service):
5414 * bus/bus.c: (bus_context_new):
5415 * bus/desktop-file.c: (new_section):
5416 * bus/driver.c: (bus_driver_send_service_deleted),
5417 (bus_driver_handle_activate_service):
5418 * bus/services.c: (bus_registry_new), (bus_registry_ensure):
5420 * dbus/dbus-connection.c:
5421 (dbus_connection_send_with_reply_and_block):
5422 * dbus/dbus-message.c: (dbus_message_append_args_valist):
5423 * dbus/dbus-protocol.h:
5424 Make activation work better. Now pending activations will be queued
5425 and the daemon won't try to activate services that are already registered.
5427 2003-03-16 Havoc Pennington <hp@pobox.com>
5429 * dbus/dbus-bus.c (ensure_bus_data): handle failure to set
5432 * dbus/dbus-memory.c (_dbus_initialize_malloc_debug): support
5433 DBUS_MALLOC_BACKTRACES to print trace when failing an alloc
5435 2003-03-16 Havoc Pennington <hp@pobox.com>
5437 * dbus/dbus-string.c (_dbus_string_validate_utf8): oops, unbreak
5438 this. always run the test suite before commit...
5440 * bus/*: adapt to DBusConnection API changes
5442 * glib/dbus-gmain.c: adapt to DBusConnection API changes,
5443 requires renaming stuff to avoid dbus_connection_dispatch name
5446 * dbus/dbus-transport.c (_dbus_transport_queue_messages): new
5449 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
5450 separate from _dbus_message_loader_return_buffer()
5452 * dbus/dbus-connection.c (dbus_connection_get_n_messages): remove
5453 this, because it's now always broken to use; the number of
5454 messages in queue vs. the number still buffered by the message
5455 loader is undefined/meaningless. Should use
5456 dbus_connection_get_dispatch_state().
5457 (dbus_connection_dispatch): rename from
5458 dbus_connection_dispatch_message
5460 2003-03-16 Havoc Pennington <hp@pobox.com>
5462 * dbus/dbus-string.c (_dbus_string_validate_utf8): copy in a real
5465 2003-03-16 Anders Carlsson <andersca@codefactory.se>
5467 * dbus/dbus-connection.c:
5468 (dbus_connection_send_with_reply_and_block):
5469 Decrease connection->n_incoming when removing an entry
5471 * dbus/dbus-dict.c: (dbus_dict_entry_free),
5472 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
5473 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
5474 (dbus_dict_set_byte_array), (dbus_dict_set_string_array),
5475 (dbus_dict_get_boolean_array), (dbus_dict_get_double_array),
5476 (dbus_dict_get_byte_array):
5477 Handle NULL arrays and strings. Also add support for byte arrays.
5479 * dbus/dbus-marshal.c: (_dbus_marshal_byte_array),
5480 (_dbus_marshal_dict), (_dbus_demarshal_byte_array),
5481 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
5482 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
5483 (_dbus_demarshal_dict), (demarshal_and_validate_len),
5484 (_dbus_marshal_validate_arg), (_dbus_marshal_test):
5485 * dbus/dbus-marshal.h:
5486 Add support for marshalling and demarshalling empty arrays and strings.
5488 * dbus/dbus-message.c: (dbus_message_append_args_valist),
5489 (dbus_message_append_string_array),
5490 (dbus_message_iter_get_boolean),
5491 (dbus_message_iter_get_boolean_array),
5492 (dbus_message_iter_get_int32_array),
5493 (dbus_message_iter_get_uint32_array),
5494 (dbus_message_iter_get_double_array),
5495 (dbus_message_iter_get_byte_array),
5496 (dbus_message_iter_get_string_array), (dbus_message_iter_get_dict),
5497 (check_message_handling):
5498 Add support for getting empty arrays and dicts.
5500 * dbus/dbus-string.c: (_dbus_string_validate_utf8):
5501 Don't do any validation at all for now, that's better than just checking
5504 * test/data/valid-messages/emptiness.message:
5505 New test message with lots of empty arrays.
5507 2003-03-16 Havoc Pennington <hp@pobox.com>
5509 * dbus/dbus-connection.c
5510 (_dbus_connection_queue_received_message_link): new function that
5511 can't fail due to OOM
5513 * dbus/dbus-message.c (_dbus_message_loader_pop_message_link):
5514 new function pops a message together with a list link
5517 * dbus/dbus-transport-unix.c (queue_messages): use new link-based
5518 message queuing functions to avoid needing to alloc memory
5520 2003-03-16 Havoc Pennington <hp@pobox.com>
5522 Oops - test code was only testing failure of around 30 of the
5523 mallocs in the test path, but it turns out there are 500+
5524 mallocs. I believe this was due to misguided linking setup such
5525 that there was one copy of dbus_malloc etc. in the daemon and one
5526 in the shared lib, and only daemon mallocs were tested. In any
5527 case, the test case now tests all 500+ mallocs, and doesn't pass
5528 yet, though there are lots of fixes in this patch.
5530 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
5531 this so that it doesn't need to allocate memory, since it
5532 has no way of indicating failure due to OOM (and would be
5533 annoying if it did).
5535 * dbus/dbus-list.c (_dbus_list_pop_first_link): new function
5537 * bus/Makefile.am: rearrange to create two self-contained
5538 libraries, to avoid having libraries with overlapping symbols.
5539 that was resulting in weirdness, e.g. I'm pretty sure there
5540 were two copies of global static variables.
5542 * dbus/dbus-internals.c: move the malloc debug stuff to
5545 * dbus/dbus-list.c (free_link): free list mempool if it becomes
5548 * dbus/dbus-memory.c (_dbus_disable_mem_pools): new function
5550 * dbus/dbus-address.c (dbus_parse_address): free list nodes
5553 * bus/dispatch.c (bus_dispatch_add_connection): free
5554 message_handler_slot when no longer using it, so
5555 memory leak checkers are happy for the test suite.
5557 * dbus/dbus-server-debug-pipe.c (debug_finalize): free server name
5559 * bus/bus.c (new_connection_callback): disconnect in here if
5560 bus_connections_setup_connection fails.
5562 * bus/connection.c (bus_connections_unref): fix to free the
5564 (bus_connections_setup_connection): if this fails, don't
5565 disconnect the connection, just be sure there are no side
5568 * dbus/dbus-string.c (undo_alignment): unbreak this
5570 * dbus/dbus-auth.c (_dbus_auth_unref): free some stuff we were
5572 (_dbus_auth_new): fix the order in which we free strings
5575 * bus/connection.c (bus_connection_disconnected): fix to
5576 not send ServiceDeleted multiple times in case of memory
5579 * dbus/dbus-bus.c (dbus_bus_get_base_service): new function to
5580 get the base service name
5581 (dbus_bus_register_client): don't return base service name,
5582 instead store it on the DBusConnection and have an accessor
5584 (dbus_bus_register_client): rename dbus_bus_register()
5586 * bus/dispatch.c (check_hello_message): verify that other
5587 connections on the bus also got the correct results, not
5588 just the one sending hello
5590 2003-03-15 Havoc Pennington <hp@pobox.com>
5592 Make it pass the Hello handling test including all OOM codepaths.
5593 Now to do other messages...
5595 * bus/services.c (bus_service_remove_owner): fix crash when
5596 removing owner from an empty list of owners
5597 (bus_registry_ensure): don't leave service in the list of
5598 a connection's owned services if we fail to put the service
5601 * bus/connection.c (bus_connection_preallocate_oom_error): set
5602 error flag on the OOM error.
5604 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
5605 handle _dbus_transport_set_connection failure
5607 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd): modify
5608 to create watches up front and simply enable/disable them as
5610 (unix_connection_set): this can now fail on OOM
5612 * dbus/dbus-timeout.c, dbus/dbus-watch.c: add concept
5613 of enabling/disabling a watch or timeout.
5615 * bus/loop.c (bus_loop_iterate): don't touch disabled
5618 * glib/dbus-gmain.c: adapt to enable/disable watches and timeouts
5620 2003-03-15 Havoc Pennington <hp@pobox.com>
5622 * bus/dispatch.c (bus_dispatch_test): OK, now finally actually
5623 write useful test code, after all that futzing around ;-)
5625 Test does not yet pass because we can't handle OOM in
5626 _dbus_transport_messages_pending (basically,
5627 dbus_connection_preallocate_send() does not prealloc the write
5628 watch). To fix this, I think we need to add new stuff to
5629 set_watch_functions, namely a SetEnabled function so we can alloc
5630 the watch earlier, then enable it later.
5632 * dbus/Makefile.am (libdbus_convenience_la_SOURCES): move
5633 dbus-memory.c to the convenience lib
5635 * bus/test.c: rename some static functions to keep them clearly
5636 distinct from stuff in connection.c. Handle client disconnection.
5638 2003-03-14 Havoc Pennington <hp@pobox.com>
5640 * bus/dispatch.c (bus_dispatch_test): do test using debug-pipe
5641 transport, tests more of the real codepath. Set up clients
5642 with bus_setup_debug_client.
5644 * bus/test.c (bus_setup_debug_client): function to set up debug
5645 "clients" on the main loop
5647 * dbus/dbus-transport.c (_dbus_transport_open): add debug-pipe
5650 * dbus/dbus-server.c (dbus_server_listen): add debug-pipe
5653 * dbus/dbus-server-debug.c: support a debug server based on pipes
5655 * dbus/dbus-sysdeps.c (_dbus_full_duplex_pipe): new function
5656 (_dbus_close): new function
5658 * configure.in: check for socketpair
5660 2003-03-14 Havoc Pennington <hp@redhat.com>
5662 * dbus/dbus-memory.c: add a "detect buffer overwrites on free"
5665 * dbus/dbus-transport-debug.c: rework this a good bit to be
5666 less complicated. hopefully still works.
5668 * dbus/dbus-server-debug.c (handle_new_client): remove timeout
5671 * glib/dbus-gmain.c (timeout_handler): don't remove timeout
5674 * dbus/dbus-message.c (dbus_message_copy): rename from
5675 dbus_message_new_from_message, fix it up to copy
5676 all the message fields, add test case
5678 * bus/dispatch.c (bus_dispatch_test): add some more test code,
5679 not quite passing yet
5681 2003-03-14 Havoc Pennington <hp@pobox.com>
5683 * bus/loop.c (bus_loop_iterate): add this so we can "run loop
5684 until no work remains" in test code. (the large diff here
5685 is just code movement, no actual changes)
5687 * dbus/dbus-server-debug.c (DEFAULT_INTERVAL): change interval to
5688 1, no point waiting around for test code.
5689 (_dbus_server_debug_accept_transport): unref the timeout
5690 after adding it (right?)
5692 * dbus/dbus-transport-debug.c (DEFAULT_INTERVAL): ditto
5694 2003-03-13 Havoc Pennington <hp@redhat.com>
5696 * dbus/dbus-timeout.c (_dbus_timeout_list_set_functions): handle
5699 * dbus/dbus-watch.c (_dbus_watch_list_set_functions): handle out
5702 * dbus/dbus-connection.h: Make AddWatchFunction and
5703 AddTimeoutFunction return a bool so they can fail on out-of-memory
5705 * bus/bus.c (bus_context_new): set up timeout handlers
5707 * bus/connection.c (bus_connections_setup_connection): set up
5710 * glib/dbus-gmain.c: adapt to the fact that set_functions stuff
5713 * bus/bus.c (bus_context_new): adapt to changes
5715 * bus/connection.c: adapt to changes
5717 * test/watch.c: adapt to DBusWatch changes
5719 * bus/dispatch.c (bus_dispatch_test): started adding this but
5722 2003-03-14 Anders Carlsson <andersca@codefactory.se>
5724 * bus/dispatch.c (send_service_nonexistent_error): Fix typo.
5726 2003-03-13 Havoc Pennington <hp@pobox.com>
5728 * bus/test.c, bus/test.h, bus/Makefile.am, bus/test-main.c:
5729 set up a test framework as for the library
5731 2003-03-12 Havoc Pennington <hp@pobox.com>
5733 Throughout: purge global variables, introduce BusActivation,
5734 BusConnections, BusRegistry, etc. objects instead.
5736 * bus/bus.h, bus/bus.c: introduce BusContext as a global
5739 * test/Makefile.am (TEST_BINARIES): disable bus-test for now,
5740 going to redo this a bit differently I think
5742 2003-03-12 Havoc Pennington <hp@redhat.com>
5744 Mega-patch that gets the message bus daemon initially handling
5745 out-of-memory. Work still needed. Also lots of random
5746 moving stuff to DBusError instead of ResultCode.
5748 * dbus/dbus-list.c (_dbus_list_length_is_one): new function
5750 * dbus/dbus-connection.c
5751 (dbus_connection_send_with_reply_and_block): use DBusError
5753 * dbus/dbus-bus.c: adapt to API changes, make it use DBusError not
5756 * dbus/dbus-connection.c (dbus_connection_send): drop the result
5757 code here, as the only failure possible is OOM.
5759 * bus/connection.c (bus_connection_disconnect):
5760 rename bus_connection_disconnected as it's a notification only
5762 * bus/driver.c (bus_driver_handle_acquire_service): don't free
5763 "name" on get_args failure, should be done by get_args;
5764 don't disconnect client for bad args, just return an error.
5765 (bus_driver_handle_service_exists): ditto
5767 * bus/services.c (bus_services_list): NULL-terminate returned array
5769 * bus/driver.c (bus_driver_send_service_lost)
5770 (bus_driver_send_service_acquired): send messages from driver to a
5771 specific client to the client's unique name, not to the broadcast
5774 * dbus/dbus-message.c (decode_header_data): reject messages that
5775 contain no name field
5776 (_dbus_message_get_client_serial): rename to
5777 dbus_message_get_serial and make public
5778 (_dbus_message_set_serial): rename from set_client_serial
5779 (_dbus_message_set_reply_serial): make public
5780 (_dbus_message_get_reply_serial): make public
5782 * bus/connection.c (bus_connection_foreach): allow stopping
5783 iteration by returning FALSE from foreach function.
5785 * dbus/dbus-connection.c (dbus_connection_send_preallocated)
5786 (dbus_connection_free_preallocated_send)
5787 (dbus_connection_preallocate_send): new API for sending a message
5788 without possibility of malloc failure.
5789 (dbus_connection_send_message): rename to just
5790 dbus_connection_send (and same for whole function family)
5792 * dbus/dbus-errors.c (dbus_error_free): make this reinit the error
5794 * dbus/dbus-sysdeps.c (_dbus_exit): new function
5796 * bus/activation.c: handle/return errors
5798 * dbus/dbus-errors.h: add more DBUS_ERROR #define
5800 * dbus/dbus-sysdeps.c (_dbus_directory_open) (_dbus_file_get_contents)
5801 (_dbus_directory_get_next_file): use DBusError instead of DBusResultCode
5802 (_dbus_result_from_errno): move to this file
5804 2003-03-10 Anders Carlsson <andersca@codefactory.se>
5806 * dbus/dbus-marshal.c:
5807 (_dbus_marshal_set_string):
5808 Take a length argument so we can marshal the correct string
5811 (_dbus_marshal_dict), (_dbus_demarshal_dict),
5812 (_dbus_marshal_get_arg_end_pos), (_dbus_marshal_validate_arg),
5813 (_dbus_marshal_test):
5814 * dbus/dbus-marshal.h:
5815 Add support for marshalling and demarshalling dicts.
5817 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
5818 Add support for TYPE DICT.
5820 * dbus/dbus-message.c: (set_string_field):
5821 Adjust header padding.
5823 (dbus_message_append_args_valist), (dbus_message_append_dict),
5824 (dbus_message_get_args_valist), (dbus_message_iter_get_arg_type),
5825 (dbus_message_iter_get_dict), (_dbus_message_loader_return_buffer),
5826 (check_message_handling), (check_have_valid_message):
5827 * dbus/dbus-message.h:
5828 Add functions for setting and getting dicts.
5830 * dbus/dbus-protocol.h:
5836 * doc/dbus-specification.sgml:
5837 Add information about how dicts are marshalled.
5839 * test/data/invalid-messages/dict-with-nil-value.message:
5840 * test/data/invalid-messages/too-short-dict.message:
5841 * test/data/valid-messages/dict-simple.message:
5842 * test/data/valid-messages/dict.message:
5843 Add sample messages containing dicts.
5845 2003-03-08 Anders Carlsson <andersca@codefactory.se>
5847 * dbus/dbus-dict.h: Add DBUS_END_DECLS.
5849 2003-03-07 Anders Carlsson <andersca@codefactory.se>
5852 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
5853 (dbus_dict_get_keys), (insert_entry), (dbus_dict_set_boolean),
5854 (dbus_dict_set_int32), (dbus_dict_set_uint32),
5855 (dbus_dict_set_double), (dbus_dict_set_string),
5856 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
5857 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
5858 (dbus_dict_set_string_array), (_dbus_dict_test):
5860 Fix according to comments from Havoc.
5862 2003-03-06 Michael Meeks <michael@server.home>
5864 * configure.in: if we don't have kde-config, disable have_qt.
5866 2003-03-07 Anders Carlsson <andersca@codefactory.se>
5871 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
5872 (dbus_dict_ref), (dbus_dict_unref), (dbus_dict_contains),
5873 (dbus_dict_remove), (dbus_dict_get_value_type),
5874 (dbus_dict_get_keys), (dbus_dict_put_boolean),
5875 (dbus_dict_put_int32), (dbus_dict_put_uint32),
5876 (dbus_dict_put_double), (dbus_dict_put_string),
5877 (dbus_dict_put_boolean_array), (dbus_dict_put_int32_array),
5878 (dbus_dict_put_uint32_array), (dbus_dict_put_double_array),
5879 (dbus_dict_put_string_array), (dbus_dict_get_boolean),
5880 (dbus_dict_get_int32), (dbus_dict_get_uint32),
5881 (dbus_dict_get_double), (dbus_dict_get_string),
5882 (dbus_dict_get_boolean_array), (dbus_dict_get_int32_array),
5883 (dbus_dict_get_uint32_array), (dbus_dict_get_double_array),
5884 (dbus_dict_get_string_array), (_dbus_dict_test):
5886 Add DBusDict implementation
5888 * dbus/dbus-test.c: (dbus_internal_do_not_use_run_tests):
5892 2003-03-04 Havoc Pennington <hp@pobox.com>
5894 * test/data/auth/*: adapt to changes
5896 * dbus/dbus-auth-script.c (_dbus_auth_script_run): add
5897 USERID_BASE64 and change USERNAME_BASE64 to put in username not
5900 * dbus/dbus-keyring.c (_dbus_keyring_validate_context): prevent
5901 more stuff from being in a context name, to make the protocol
5902 simpler to deal with
5904 * dbus/dbus-errors.c (dbus_error_has_name): new function
5905 (dbus_error_is_set): new function
5907 * dbus/dbus-auth.c: replace DBUS_STUPID_TEST_MECH auth
5908 with DBUS_COOKIE_SHA1, implement DBUS_COOKIE_SHA1
5910 * dbus/dbus-connection.c (dbus_connection_flush): also read
5911 messages during a flush operation
5913 * dbus/Makefile.am: remove dbus-md5 since it isn't currently used.
5915 2003-03-05 Anders Carlsson <andersca@codefactory.se>
5917 * configure.in: Check for gethostbyname on Solaris.
5919 * dbus/dbus-transport.c: (_dbus_transport_open):
5920 Remove duplicate "tcp" entry.
5922 * doc/dbus-specification.sgml:
5923 Clarify some things.
5925 2003-03-05 Anders Carlsson <andersca@codefactory.se>
5927 * dbus/dbus-auth.c: (send_rejected), (process_test_subdir):
5928 * dbus/dbus-keyring.c: (_dbus_keyring_new_homedir),
5929 (_dbus_keyring_test):
5930 * dbus/dbus-md5.c: (_dbus_md5_compute):
5931 * dbus/dbus-sha.c: (_dbus_sha_compute):
5934 2003-03-05 Anders Carlsson <andersca@codefactory.se>
5936 * README: Add some things.
5938 2003-03-04 Anders Carlsson <andersca@codefactory.se>
5940 * dbus/dbus-message.c (dbus_message_append_args_valist): Add a break;
5941 after case DBUS_TYPE_BOOELAN.
5943 2003-03-02 Havoc Pennington <hp@pobox.com>
5945 * test/break-loader.c (randomly_set_extreme_ints): add test that
5946 sets really huge and small integers
5948 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add check
5949 that length of boolean array fits in the string, and that
5950 string has room for boolean value in single-bool case.
5952 * dbus/dbus-message-builder.c (_dbus_message_data_load): add
5953 optional value to "ALIGN" command which is what to fill the
5956 * test/data/valid-messages/no-padding.message: add regression
5957 test for the message padding problem
5959 2003-03-02 Havoc Pennington <hp@pobox.com>
5961 * dbus/dbus-message.c (decode_header_data): fix to always init
5962 message_padding, from Benjamin Dauvergne
5964 2003-03-02 Havoc Pennington <hp@pobox.com>
5970 2003-03-01 Joe Shaw <joe@assbarn.com>
5972 * configure.in: Check for "struct cmsgcred" and try to access its
5973 members for BSD-like unices.
5975 * dbus/dbus-sysdeps.c (read_credentials_byte): Fold this back into
5976 _dbus_read_credentials_unix_socket().
5977 (_dbus_read_credentials_unix_socket): Use recvmsg() instead of
5978 read() for reading the credential byte off the unix socket. Use
5979 struct cmsgcred on systems that support it.
5981 2003-02-27 Alexander Larsson <alexl@redhat.com>
5985 Make gthreads-2.0 dependency optional. Don't build thread test if
5988 2003-02-27 Havoc Pennington <hp@pobox.com>
5990 * dbus/dbus-connection.c
5991 (dbus_connection_send_message_with_reply_and_block): fix doh!
5992 doh! doh! bug that resulted in never removing a reply from the
5993 queue, no wonder we called get_reply_serial so much ;-)
5995 * dbus/dbus-message.c (struct DBusMessage): cache reply serial
5996 and client serial instead of demarshaling them every time
5998 2003-02-27 Havoc Pennington <hp@pobox.com>
6000 * dbus/dbus-marshal.c (_dbus_demarshal_int32): rewrite to be much
6001 more inlined, using dbus-string-private.h, speeds things up
6004 * dbus/dbus-string.c (_dbus_string_free): apply align offset
6005 when freeing the string
6006 (_dbus_string_steal_data): fix for align offset
6007 (undo_alignment): new function
6009 2003-02-26 Havoc Pennington <hp@redhat.com>
6011 All kinds of audit fixes from Owen, plus initial attempt to
6012 handle unaligned memory returned from malloc.
6014 * dbus/dbus-string.c (_dbus_string_init): clamp max length to
6015 leave room for align_offset and nul byte
6016 (fixup_alignment): function to track an align_offset and
6017 ensure real->str is aligned
6018 (DBUS_GENERIC_STRING_PREAMBLE): len must be less than allocated,
6019 to allow a nul byte plus align offset
6020 (_dbus_string_lock): fix overflow issue
6021 (_dbus_string_init_const_len): add assertions on sanity of len,
6022 assign allocated to be ALLOCATION_PADDING larger than len
6023 (set_length): fixup the overflow handling
6024 (_dbus_string_get_data_len): fix overflow in assertion
6025 (open_gap): detect overflow in size of gap to be opened
6026 (_dbus_string_lengthen): add overflow check
6027 (_dbus_string_align_length): fix overflow with _DBUS_ALIGN_VALUE
6028 (_dbus_string_append): add overflow check
6029 (_dbus_string_append_unichar): overflow
6030 (_dbus_string_delete): fix overflow in assertion
6031 (_dbus_string_copy_len): overflow in assertion
6032 (_dbus_string_replace_len): overflows in assertions
6033 (_dbus_string_find): change to implement in terms of
6034 _dbus_string_find_to
6035 (_dbus_string_find_to): assorted fixage
6036 (_dbus_string_equal_c_str): assert c_str != NULL,
6037 fix logic so the function works
6038 (_dbus_string_ends_with_c_str): fix overflow thingy
6039 (_dbus_string_base64_encode): overflow fix
6040 (_dbus_string_validate_ascii): overflow
6041 (_dbus_string_validate_nul): overflow
6043 2003-02-26 Havoc Pennington <hp@redhat.com>
6045 * dbus/dbus-marshal.c (_dbus_marshal_test): fix to work with DISABLE_ASSERTS
6047 2003-02-26 Alexander Larsson <alexl@redhat.com>
6050 Set DBUS_GLIB_THREADS_LIBS for apps using gthread-2.0
6052 * dbus/dbus-connection.c:
6053 * dbus/dbus-connection.h:
6054 Fix _dbus_connection_acquire_io_path and _dbus_connection_acquire_dispatch.
6055 Add dbus_connection_set_wakeup_main_function and use it when queueing
6056 incoming and outgoing messages.
6059 * dbus/dbus-dataslot.c:
6060 Threadsafe usage of DBusDataSlotAllocator
6062 * dbus/dbus-message.c: (dbus_message_get_args_iter):
6065 * dbus/dbus-server-unix.c:
6068 * glib/dbus-gmain.c:
6069 Implement the new wakeup functions for glib.
6072 * glib/test-thread-client.c:
6073 * glib/test-thread-server.c:
6074 * glib/test-thread.h:
6075 Initial cut at some thread test code. Not really done yet.
6077 2003-02-26 Havoc Pennington <hp@pobox.com>
6079 * dbus/dbus-connection.c
6080 (dbus_connection_send_message_with_reply_and_block): fix crash
6081 where we ref'd the outgoing message instead of the returned reply
6083 * dbus/dbus-transport-unix.c (do_authentication): check read watch
6084 at the end of this function, so if we didn't need to read for
6085 authentication, we reinstall it for receiving messages
6087 * dbus/dbus-message.c (dbus_message_new_reply): allow replies to
6088 a NULL sender for peer-to-peer case
6090 * dbus/dbus-transport-unix.c (check_read_watch): handle
6091 !authenticated case correctly
6093 * glib/dbus-gmain.c: add support for DBusServer
6095 * dbus/dbus-server.c: add data slot support
6097 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): check
6098 return values and handle errors
6100 * dbus/dbus-dataslot.c: factor out the data slot stuff from
6103 * Doxyfile.in (INPUT): add glib subdir
6105 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): rename
6106 setup_with_g_main instead of hookup_with_g_main; write docs
6108 2003-02-24 Anders Carlsson <andersca@codefactory.se>
6110 * dbus/dbus-marshal.c: (_dbus_marshal_validate_arg):
6111 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
6112 * dbus/dbus-message.c: (dbus_message_append_boolean),
6113 (dbus_message_append_boolean_array),
6114 (dbus_message_get_args_valist), (_dbus_message_test):
6115 * dbus/dbus-message.h:
6116 * doc/dbus-specification.sgml:
6117 Various fixes as pointed out by Havoc.
6119 * test/data/invalid-messages/bad-boolean-array.message:
6120 * test/data/invalid-messages/bad-boolean.message:
6121 Add invalid boolean value test cases.
6123 2003-02-24 Anders Carlsson <andersca@codefactory.se>
6125 * dbus/dbus-internals.c: (_dbus_type_to_string):
6126 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
6127 (_dbus_marshal_validate_arg):
6128 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
6129 * dbus/dbus-message.c: (dbus_message_append_args_valist),
6130 (dbus_message_append_boolean), (dbus_message_append_boolean_array),
6131 (dbus_message_get_args_valist), (dbus_message_iter_get_boolean),
6132 (dbus_message_iter_get_int32), (dbus_message_iter_get_uint32),
6133 (dbus_message_iter_get_double),
6134 (dbus_message_iter_get_boolean_array), (message_iter_test):
6135 * dbus/dbus-message.h:
6136 * dbus/dbus-protocol.h:
6137 * doc/dbus-specification.sgml:
6138 * test/data/valid-messages/lots-of-arguments.message:
6139 Add support for boolean and boolean array types.
6141 2003-02-23 Havoc Pennington <hp@pobox.com>
6143 * dbus/dbus-keyring.c: finish most of this implementation and
6146 * dbus/dbus-errors.c (dbus_set_error_const, dbus_set_error): make
6147 these barf if the error isn't cleared to NULL
6149 * dbus/dbus-sysdeps.c (_dbus_delete_file): set error on failure
6150 (_dbus_create_directory): new function
6152 * dbus/dbus-errors.c (dbus_set_error): fix warning
6154 * dbus/dbus-string.c (_dbus_string_hex_encode): new function
6155 (_dbus_string_hex_decode): new function
6156 (test_hex_roundtrip): test code
6158 * dbus/dbus-sha.c (_dbus_sha_compute): use dbus_string_hex_encode
6160 * dbus/dbus-md5.c (_dbus_md5_compute): use dbus_string_hex_encode
6162 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): make this use
6163 the save-to-temp/rename trick to atomically write the new file
6164 (_dbus_string_parse_uint): new function
6166 2003-02-22 Havoc Pennington <hp@pobox.com>
6168 * test/Makefile.am (dist-hook): fix dist for test/data/sha-1
6170 2003-02-22 Havoc Pennington <hp@pobox.com>
6172 * dbus/dbus-message.c (dbus_message_iter_get_string_array):
6173 (dbus_message_iter_get_byte_array): Fix up doxygen warnings
6175 * dbus/dbus-sha.c: add implementation of SHA-1 algorithm
6177 * dbus/test/data/sha-1: add US government test suite for SHA-1
6179 2003-02-21 Anders Carlsson <andersca@codefactory.se>
6181 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
6182 Make string arrays NULL-terminated.
6184 * dbus/dbus-memory.c: (dbus_free_string_array):
6185 * dbus/dbus-memory.h:
6186 New function for freeing NULL-terminated string arrays.
6188 * dbus/dbus-message-builder.c: (append_quoted_string),
6189 (_dbus_message_data_load):
6190 Add support for array types.
6192 * dbus/dbus-message.c: (check_message_handling):
6193 Add more types as test cases.
6195 * dbus/dbus-sysdeps.c: (_dbus_string_parse_int),
6196 (_dbus_string_parse_double):
6197 Add the start offset to the end offset.
6199 * test/data/valid-messages/lots-of-arguments.message:
6200 New test message with lots of arguments.
6202 2003-02-21 Anders Carlsson <andersca@codefactory.se>
6204 * dbus/dbus-message.c: (dbus_message_append_nil),
6205 (dbus_message_append_int32), (dbus_message_append_uint32),
6206 (dbus_message_append_double), (dbus_message_append_string),
6207 (dbus_message_append_int32_array),
6208 (dbus_message_append_uint32_array),
6209 (dbus_message_append_double_array),
6210 (dbus_message_append_byte_array),
6211 (dbus_message_append_string_array):
6212 Fix all out-of-memory handling in these functions.
6214 2003-02-21 Anders Carlsson <andersca@codefactory.se>
6216 * dbus/dbus-message.c: (dbus_message_append_nil):
6219 2003-02-21 Anders Carlsson <andersca@codefactory.se>
6221 * dbus/dbus-message.c: (dbus_message_append_args_valist),
6222 (dbus_message_append_nil), (dbus_message_append_int32_array),
6223 (dbus_message_append_uint32_array),
6224 (dbus_message_append_double_array),
6225 (dbus_message_append_byte_array),
6226 (dbus_message_append_string_array), (dbus_message_get_args_valist),
6227 (dbus_message_iter_get_int32_array),
6228 (dbus_message_iter_get_uint32_array),
6229 (dbus_message_iter_get_double_array),
6230 (dbus_message_iter_get_byte_array),
6231 (dbus_message_iter_get_string_array):
6233 * dbus/dbus-message.h:
6234 Add functions for appending and getting arrays.
6236 2003-02-21 Anders Carlsson <andersca@codefactory.se>
6238 * dbus/dbus-mempool.c (_dbus_mem_pool_new): Make the
6239 element size at least 8 bytes, fixes mempool tests on
6242 2003-02-20 Alexander Larsson <alexl@redhat.com>
6244 * dbus/dbus-transport-unix.c (unix_do_iteration):
6245 Unlock the connection mutex during a blocking select call.
6246 Add todo about how we need a way to wake up the select.
6248 * dbus/dbus-connection-internal.h:
6249 * dbus/dbus-connection.c:
6250 Add _dbus_connection_lock and _dbus_connection_unlock.
6252 2003-02-19 Havoc Pennington <hp@pobox.com>
6254 * Doxyfile.in (PREDEFINED): put DOXYGEN_SHOULD_SKIP_THIS in
6255 Doxyfile.in, not Doxyfile
6257 * dbus/dbus-keyring.c: do some hacking on this
6259 * dbus/dbus-sysdeps.c (_dbus_delete_file): new
6261 * dbus/dbus-errors.c (dbus_set_error_const): do not call
6263 (dbus_set_error): remove dbus_error_init, check for message ==
6264 NULL *before* we sprintf into it, and add @todo about including
6265 system headers in this file
6267 * dbus/dbus-sysdeps.c (_dbus_create_file_exclusively): new
6269 * dbus/dbus-errors.h (DBUS_ERROR_FAILED): add
6271 * dbus/dbus-sysdeps.c (get_user_info): break this function out to
6272 get various bits of user information based on either username
6274 (_dbus_homedir_from_username): new function
6276 2003-02-19 Anders Carlsson <andersca@codefactory.se>
6279 Add check for nonposix getpwnam_r
6281 * dbus/dbus-mempool.c: (_dbus_mem_pool_new):
6282 Align the pool element size to a sizeof (void *) boundary.
6284 * dbus/dbus-sysdeps.c: (_dbus_setenv), (_dbus_connect_unix_socket),
6285 (_dbus_listen_unix_socket), (_dbus_credentials_from_username):
6286 General Solaris fixes.
6288 * test/data/valid-messages/simplest-manual.message:
6289 Explicitly state that we want little-endian packing.
6291 2003-02-19 Mikael Hallendal <micke@codefactory.se>
6293 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
6295 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_tcp_socket):
6296 Added to create a transport connecting using a tcp/ip socket.
6298 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): Added to connect
6299 to a tcp socket at given host and port.
6300 (_dbus_listen_tcp_socket): added to listen on tcp socket for given
6303 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
6305 * dbus/dbus-server-unix.c (_dbus_server_new_for_tcp_socket):
6306 Added to create a server listening on a TCP/IP socket.
6308 2003-02-19 Havoc Pennington <hp@pobox.com>
6310 Throughout: mop up all the Doxygen warnings and undocumented
6313 * dbus/dbus-sysdeps.c (do_exec): do not use execvp, we don't want
6314 to search any paths.
6316 * dbus/dbus-threads.c: move global mutex initializers to
6317 dbus-internals.h, multiple prototypes was confusing doxygen
6318 besides being kind of ugly
6320 * Doxyfile (PREDEFINED): have Doxygen define
6321 DOXYGEN_SHOULD_SKIP_THIS so we can exclude things from
6322 docs with #ifndef DOXYGEN_SHOULD_SKIP_THIS
6323 (do not abuse the feature! it's for stuff like the autogenerated
6324 macros in dbus-md5.c, not just for things you don't feel like
6327 2003-02-18 Havoc Pennington <hp@pobox.com>
6329 * dbus/dbus-string.c (_dbus_string_zero): new function
6331 * dbus/dbus-md5.c: include MD5 implementation by L. Peter Deutsch,
6332 wrap it in some dbus-friendly API
6334 * dbus/dbus-types.h: add 16-bit types
6336 2003-02-18 Joe Shaw <joe@assbarn.com>
6338 * dbus/dbus-auth.c (handle_server_data_stupid_test_mech): Just get
6339 credentials from our currently running process.
6340 (get_word): Fix a buglet where we were copying the entire length
6341 instead of relative to our position.
6343 * dbus/dbus-hash.c (_dbus_hash_test): Don't try to allocate the
6344 keys on the stack... it's 640k of data.
6346 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): Always
6347 read the credentials byte off the socket, even if we don't have
6349 (_dbus_poll): Implement poll() using select() for systems which
6352 * glib/test-dbus-glib.c (main): Print out an error if no
6353 parameters are given.
6355 * test/data/auth/fallback.auth-script: Added. Tests that a client
6356 can fallback to a secondary auth mechanism if the first fails.
6358 2003-02-18 Havoc Pennington <hp@pobox.com>
6362 2003-02-17 Havoc Pennington <hp@pobox.com>
6364 * doc/dbus-specification.sgml: lots of cosmetic
6365 cleanups/rearrangement, add assorted FIXME, change DBUS_ADDRESS
6366 env variable to DBUS_BUS_ADDRESS, s/client/application/,
6367 s/server/bus/ (except in authentication section). Add a section
6368 "Message Bus Message Routing"
6370 2003-02-17 Anders Carlsson <andersca@codefactory.se.>
6376 2003-02-17 Anders Carlsson <andersca@codefactory.se>
6378 * doc/dbus-specification.sgml:
6379 Specification updates.
6381 2003-02-17 Anders Carlsson <andersca@codefactory.se>
6383 * bus/activation.c: (bus_activation_init), (child_setup),
6384 (bus_activation_activate_service):
6386 * bus/main.c: (main):
6387 Set DBUS_ADDRESS environment variable.
6389 * dbus/dbus-errors.c: (dbus_set_error):
6390 Don't use va_copy since that's a C99 feature.
6392 * dbus/dbus-sysdeps.c: (_dbus_setenv), (do_exec),
6393 (_dbus_spawn_async):
6394 * dbus/dbus-sysdeps.h:
6395 Add child_setup_func to _dbus_spawn_async.
6397 * doc/dbus-specification.sgml:
6398 Update specification.
6400 * test/spawn-test.c: (setup_func), (main):
6403 2003-02-17 Alexander Larsson <alexl@redhat.com>
6405 * dbus/dbus-connection.c (_dbus_connection_handler_destroyed_locked):
6408 2003-02-17 Anders Carlsson <andersca@codefactory.se>
6412 * doc/dbus-test-plan.sgml:
6413 Add test plan document.
6418 2003-02-17 Anders Carlsson <andersca@codefactory.se>
6420 * dbus/dbus-message.c: (decode_header_data),
6421 (_dbus_message_loader_return_buffer):
6422 Set the header padding amount when loading a message.
6424 2003-02-16 Anders Carlsson <andersca@codefactory.se>
6426 * bus/dispatch.c: (send_one_message):
6427 Only send broadcast messages to registered connections.
6429 * dbus/dbus-message.c: (dbus_message_name_is):
6430 * dbus/dbus-message.h:
6431 New convenience function.
6433 * dbus/dbus-transport-debug.c: (do_reading):
6434 Only dispatch one message per run.
6437 * test/bus-test.c: (new_connection_callback), (die),
6438 (test_hello_client1_handler), (test_hello_client2_handler),
6439 (test_hello_replies), (main):
6441 * test/bus-test-loop.[ch]:
6444 2003-02-16 Havoc Pennington <hp@pobox.com>
6446 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
6447 backward conditional
6449 2003-02-16 Alexander Larsson <alexl@redhat.com>
6451 * dbus/dbus-connection.c:
6452 Implement sent_message_with_reply. (with_reply_and block is still
6454 Made dispatch_message not lose message if OOM.
6456 * dbus/dbus-errors.h:
6457 Add NoReply error (for reply timeouts).
6459 2003-02-16 Alexander Larsson <alexl@redhat.com>
6461 * dbus/dbus-hash.c (_dbus_hash_table_unref):
6462 Actually free keys and values when destroying hashtable.
6464 2003-02-16 Anders Carlsson <andersca@codefactory.se>
6466 * dbus/dbus-auth.c: (client_try_next_mechanism):
6469 * dbus/dbus-threads.c: (dbus_condvar_wait_timeout):
6470 Return TRUE if there's no thread implementation around.
6472 * glib/dbus-gmain.c: (free_source),
6473 (dbus_connection_hookup_with_g_main):
6474 Make sure to remove the GSource when the connection is finalized.
6476 2003-02-16 Anders Carlsson <andersca@codefactory.se>
6478 * bus/dispatch.c: (bus_dispatch_message_handler):
6479 * dbus/dbus-errors.h:
6480 Return an error if someone tries to send a message to a service
6483 2003-02-16 Anders Carlsson <andersca@codefactory.se>
6485 * bus/activation.c: (load_directory), (bus_activation_init),
6486 (bus_activation_activate_service):
6489 (bus_driver_handle_activate_service), (bus_driver_handle_message):
6490 More work on the activation handling.
6492 * dbus/dbus-errors.h:
6493 Add some error messages
6495 * dbus/dbus-message.c: (dbus_message_new_error_reply):
6496 * dbus/dbus-message.h:
6497 New function that creates an error message.
6499 * dbus/dbus-protocol.h:
6500 Add ACTIVATE_SERVER message.
6502 * dbus/dbus-server-unix.c: (unix_handle_watch),
6503 (_dbus_server_new_for_domain_socket):
6504 Call _dbus_fd_set_close_on_exec.
6506 * dbus/dbus-sysdeps.c: (make_pipe), (do_exec),
6507 (_dbus_spawn_async), (_dbus_disable_sigpipe),
6508 (_dbus_fd_set_close_on_exec):
6509 * dbus/dbus-sysdeps.h:
6510 Add _dbus_fd_set_close_on exec function. Also add function that checks
6511 that all open fds are set to close-on-exec and warns otherwise.
6513 * dbus/dbus-transport-unix.c:
6514 (_dbus_transport_new_for_domain_socket):
6515 Call _dbus_fd_set_close_on_exec.
6517 2003-02-16 Havoc Pennington <hp@pobox.com>
6519 * dbus/dbus-connection.c (dbus_connection_set_change_sigpipe):
6520 allow people to avoid setting SIGPIPE to SIG_IGN
6521 (_dbus_connection_new_for_transport): disable SIGPIPE unless
6522 we've been asked not to
6524 2003-02-15 Anders Carlsson <andersca@codefactory.se>
6526 * dbus/dbus-list.c: (_dbus_list_append_link),
6527 (_dbus_list_prepend_link):
6528 * dbus/dbus-memory.c: (dbus_malloc), (dbus_malloc0),
6532 2003-02-15 Anders Carlsson <andersca@codefactory.se>
6535 * bus/activation.c: (bus_activation_entry_free),
6536 (add_desktop_file_entry), (load_directory), (bus_activation_init):
6538 * bus/main.c: (main):
6539 Add simple activation support, doesn't work yet though.
6541 2003-02-15 Zack Rusin <zack@kde.org>
6543 * qt/dbus-qthread.cpp: small casting fix
6545 2003-02-15 Anders Carlsson <andersca@codefactory.se>
6547 * dbus/dbus-errors.c: (dbus_set_error):
6548 * dbus/dbus-errors.h:
6549 Add a few errors and make dbus_set_error void.
6551 * dbus/dbus-sysdeps.c:
6552 (_dbus_errno_to_string), (close_and_invalidate), (make_pipe),
6553 (write_err_and_exit), (read_ints), (do_exec), (_dbus_spawn_async):
6554 * dbus/dbus-sysdeps.h:
6555 Add _dbus_spawn_async.
6557 * test/spawn-test.c: (main):
6558 Test for _dbus_spawn_async.
6560 2003-02-15 Anders Carlsson <andersca@codefactory.se>
6562 * dbus/dbus-internals.h:
6563 Fix build without tests.
6565 * dbus/dbus-list.c: (alloc_link):
6566 Fix a segfault when a malloc fails.
6568 * dbus/dbus-memory.c: (initialize_malloc_debug), (dbus_malloc),
6569 (dbus_malloc0), (dbus_realloc):
6570 Add support for malloc debugging.
6572 2003-02-15 Alexander Larsson <alexl@redhat.com>
6574 * dbus/dbus-threads.c:
6575 * dbus/dbus-threads.h:
6576 Add condvars. Remove static mutext from API.
6577 Implement static mutexes by initializing them from threads_init.
6579 * glib/dbus-gthread.c:
6580 * qt/dbus-qthread.cpp:
6581 Update with the thread api changes.
6586 Turn StaticMutex into normal mutex + init function.
6587 Export new functions _dbus_list_alloc_link, _dbus_list_free_link,
6588 _dbus_list_append_link, _dbus_list_prepend_link
6591 * dbus/dbus-sysdeps.c:
6592 * dbus/dbus-sysdeps.h:
6593 New type dbus_atomic_t, and new functions _dbus_atomic_inc,
6594 _dbus_atomic_dec. Only slow fallback implementation at the moment.
6596 * dbus/dbus-protocol.h:
6597 Add DBUS_MESSAGE_LOCAL_DISCONNECT define
6599 * dbus/dbus-message.c:
6600 Make ref/unref atomic.
6603 * dbus/dbus-connection-internal.h:
6604 * dbus/dbus-connection.c:
6605 * dbus/dbus-connection.h:
6607 Change _peek to _borrow,_return & _steal_borrowed.
6608 Change disconnect callback to event.
6609 Make dbus_connection_dispatch_messages reentrant.
6611 * dbus/dbus-transport.c:
6612 Don't ref the connection on calls to the transport
6615 * dbus/dbus-message-handler.c:
6618 * glib/dbus-gmain.c:
6619 Don't use peek_message anymore
6622 * test/debug-thread.c:
6623 * test/debug-thread.h:
6624 Simple thread implementation that asserts() on deadlocks in
6625 single-threaded code.
6628 (main) Call debug_threads_init.
6631 Use disconnect message instead of disconnect callback.
6635 Don't call dbus_connection_set_disconnect_function. Instead export
6636 bus_connection_disconnect.
6639 Call bus_connection_disconnect when we get a disconnected message.
6641 2003-02-15 Havoc Pennington <hp@pobox.com>
6643 * dbus/dbus-message.c (dbus_message_new): fool around with the
6646 2003-02-14 Havoc Pennington <hp@pobox.com>
6648 * dbus/dbus-mempool.c: fail if the debug functions so indicate
6650 * dbus/dbus-memory.c: fail if the debug functions indicate we
6653 * dbus/dbus-internals.c (_dbus_set_fail_alloc_counter)
6654 (_dbus_decrement_fail_alloc_counter): debug functions to
6655 simulate memory allocation failures
6657 2003-02-14 Havoc Pennington <hp@pobox.com>
6659 * dbus/dbus-errors.h (struct DBusError): add a word of padding
6662 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6664 * bus/driver.c: (bus_driver_handle_hello):
6666 * bus/services.c: (bus_service_lookup):
6667 Reorder message sending so we get a more sane order.
6669 * test/bus-test.c: (message_handler):
6672 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6674 * bus/driver.c: (bus_driver_send_service_deleted),
6675 (bus_driver_send_service_created), (bus_driver_send_service_lost),
6676 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
6677 (bus_driver_send_welcome_message),
6678 (bus_driver_handle_list_services),
6679 (bus_driver_handle_acquire_service),
6680 (bus_driver_handle_service_exists):
6681 * dbus/dbus-bus.c: (dbus_bus_register_client),
6682 (dbus_bus_acquire_service), (dbus_bus_service_exists):
6683 * dbus/dbus-errors.c: (dbus_result_to_string):
6684 * dbus/dbus-errors.h:
6685 * dbus/dbus-message.c: (dbus_message_append_args),
6686 (dbus_message_append_args_valist), (dbus_message_get_args),
6687 (dbus_message_get_args_valist), (dbus_message_get_args_iter),
6688 (dbus_message_iter_get_arg_type), (dbus_message_iter_get_string),
6689 (dbus_message_iter_get_byte_array),
6690 (dbus_message_iter_get_string_array), (message_iter_test),
6691 (check_message_handling), (_dbus_message_test):
6692 * dbus/dbus-message.h:
6693 * test/bus-test.c: (main):
6694 Change fields to arguments in messages, so that they won't be
6695 confused with header fields.
6697 * glib/test-dbus-glib.c: (main):
6698 Remove append_fields from hello message.
6700 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6702 * dbus/dbus-errors.c:
6703 * dbus/dbus-message.c:
6704 * dbus/dbus-string.c:
6705 Documentation fixes.
6707 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6709 * glib/dbus-gmain.c: (timeout_handler), (add_timeout),
6711 Implement support for timeouts in dbus-glib.
6713 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6715 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
6716 * dbus/dbus-message.c: (process_test_subdir):
6717 * test/break-loader.c: (find_breaks_based_on):
6718 Plug some memory leaks.
6720 2003-02-13 Richard Hult <rhult@codefactory.se>
6722 * bus/main.c: Fix build.
6724 * dbus/dbus-errors.h:
6725 * dbus/dbus-errors.c: Fix copyright for Anders.
6727 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6732 * bus/connection.c: (bus_connection_foreach):
6735 * bus/desktop-file.c: (grow_lines_in_section), (grow_sections),
6736 (unescape_string), (new_section), (parse_section_start),
6737 (parse_key_value), (report_error), (bus_desktop_file_load),
6738 (bus_desktop_file_get_string):
6739 * bus/desktop-file.h:
6740 Use DBusError for error reporting.
6742 * bus/dispatch.c: (send_one_message),
6743 (bus_dispatch_message_handler):
6744 * bus/driver.c: (bus_driver_send_service_deleted),
6745 (bus_driver_send_service_created), (bus_driver_send_service_lost),
6746 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
6747 (bus_driver_send_welcome_message),
6748 (bus_driver_handle_list_services),
6749 (bus_driver_handle_acquire_service),
6750 (bus_driver_handle_service_exists):
6751 * bus/loop.c: (bus_loop_run):
6753 Use BUS_HANDLE_OOM instead of _DBUS_HANDLE_OOM.
6755 * bus/utils.c: (bus_wait_for_memory):
6757 New files with general utility functions.
6759 * dbus/dbus-internals.h:
6760 Remove _DBUS_HANDLE_OOM.
6762 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6764 * dbus/dbus-errors.c: (dbus_result_to_string), (dbus_error_init),
6765 (dbus_error_free), (dbus_set_error_const), (dbus_set_error):
6766 * dbus/dbus-errors.h:
6767 Add DBusError structure.
6769 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6771 * test/data/valid-messages/standard-acquire-service.message:
6772 * test/data/valid-messages/standard-hello.message:
6773 * test/data/valid-messages/standard-list-services.message:
6774 * test/data/valid-messages/standard-service-exists.message:
6775 Add some standard messages.
6777 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6779 * bus/driver.c: (bus_driver_send_welcome_message),
6780 (bus_driver_handle_list_services),
6781 (bus_driver_handle_acquire_service),
6782 (bus_driver_handle_service_exists), (bus_driver_handle_message):
6783 Update for API changes in libdbus.
6785 * dbus/dbus-message.c: (dbus_message_new_reply):
6786 * dbus/dbus-message.h:
6787 Remove the name argument. The spec states that replies shouldn't
6790 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6792 * bus/desktop-file.c: (parse_section_start), (parse_key_value),
6793 (report_error), (bus_desktop_file_load), (lookup_section),
6794 (lookup_line), (bus_desktop_file_get_raw),
6795 (bus_desktop_file_get_string):
6796 * bus/desktop-file.h:
6797 Some fixes, and new functions for getting a key value from a section.
6799 2003-02-13 Havoc Pennington <hp@pobox.com>
6801 * test/data/auth/fail-after-n-attempts.auth-script: new test
6803 * dbus/dbus-auth.c (send_rejected): shutdown_mech() when we
6806 2003-02-13 Havoc Pennington <hp@pobox.com>
6808 * dbus/dbus-auth.c (handle_server_data_external_mech): args to
6809 dbus_credentials_match were backward
6811 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support
6812 NO_CREDENTIALS and ROOT_CREDENTIALS
6814 * dbus/dbus-auth.c (_dbus_auth_do_work): move get_state() routine
6815 into here. Never process more commands after we've reached an
6816 end state; store further data as unused bytes.
6818 * test/data/auth/*: add more auth tests
6820 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support EXPECT
6821 command to match exact string and EXPECT_UNUSED to match unused
6824 * test/Makefile.am (dist-hook): fix to dist all the test stuff
6826 2003-02-12 Havoc Pennington <hp@pobox.com>
6828 * dbus/dbus-string.c (_dbus_string_pop_line): fix to also strip
6829 \r off of popped lines
6831 * dbus/dbus-auth.c (_dbus_auth_test): write code to run auth
6834 * dbus/dbus-auth-script.c (_dbus_auth_script_run): when doing a
6837 2003-02-12 Havoc Pennington <hp@pobox.com>
6839 * dbus/Makefile.am: remove break-loader from the build, since it
6842 * configure.in: add --enable-gcov to turn on coverage profiling
6843 flags and disable optimization
6845 2003-02-10 Havoc Pennington <hp@pobox.com>
6847 * dbus/dbus-auth-script.c, dbus/dbus-auth-script.h: sync
6848 initial cut at test framework for DBusAuth from laptop.
6849 Doesn't quite work yet but it compiles and I need to get
6850 it off the 266mhz laptop. ;-)
6852 * dbus/dbus-server-debug.c (_dbus_server_debug_accept_transport):
6853 fix a memleak in error case
6855 2003-02-12 Anders Carlsson <andersca@codefactory.se>
6858 * bus/desktop-file.c:
6859 * bus/desktop-file.h:
6860 Add a desktop file parser.
6862 2003-02-11 Zack Rusin <zack@kde.org>
6864 * qt/message.[h|cpp]: sample implementation
6865 of the KDE wrapper for DBusMessage
6867 2003-02-09 Zack Rusin <zack@kde.org>
6869 * test/bus-test.c: make_it_compile
6870 * doc/dbus-specification.sgml: minimal semantic fix
6872 2003-02-06 Anders Carlsson <andersca@codefactory.se>
6878 2003-02-06 Anders Carlsson <andersca@codefactory.se>
6881 * dbus/dbus-break-loader.c:
6883 * test/break-loader.c:
6884 Move dbus-break-loader to test/ and rename it to break-loader.
6886 2003-02-02 Havoc Pennington <hp@pobox.com>
6888 * dbus/dbus-keyring.c, dbus/dbus-keyring.h: template files
6889 for code to manage cookies in your home directory
6891 * dbus/dbus-sysdeps.c (_dbus_generate_random_bytes): new function
6893 * dbus/dbus-auth.c (get_state): impose a maximum number of tries
6894 to authenticate, then disconnect the client.
6896 2003-02-03 Alexander Larsson <alexl@redhat.com>
6898 * dbus/dbus-message.c (dbus_message_append_fields):
6901 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6903 * doc/dbus-specification.sgml:
6904 Update address format section.
6906 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6909 * test/bus-test.c: (get_time), (add_timeout), (remove_timeout),
6910 (message_handler), (new_connection_callback), (loop_quit),
6914 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6916 * bus/driver.c: (bus_driver_handle_service_exists):
6917 Simplify the code a bit.
6919 * dbus/dbus-bus.c: (dbus_bus_service_exists):
6922 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6925 Add libdbus-daemon.la and link to it.
6927 2003-02-01 James Willcox <jwillcox@gnome.org>
6929 * bus/driver.c: (bus_driver_handle_own_service):
6930 Actually include the service reply code in the message.
6932 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6934 * bus/driver.c: (bus_driver_handle_service_exists):
6935 Don't unref the incoming message.
6937 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6939 * dbus/dbus.h: Add dbus-address.h and dbus-bus.h
6941 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6943 * dbus/dbus-server.c: (dbus_server_listen):
6944 * dbus/dbus-transport.c: (_dbus_transport_open):
6945 ifdef out the calls to the debug transport and server.
6947 2003-02-02 Alexander Larsson <alexl@redhat.com>
6949 * dbus/dbus-watch.c (dbus_watch_get_flags):
6950 Add note in the docs that ERROR or HANGUP won't be returned
6951 and are assumed always on.
6953 * glib/dbus-gmain.c (add_watch):
6954 Always add IO_ERR | IO_HUP
6956 * dbus/dbus-message.h:
6957 Add semicolon after dbus_message_iter_get_string_array().
6958 Makes qt code build again
6960 2003-02-01 Anders Carlsson <andersca@codefactory.se>
6962 * bus/driver.c: (create_unique_client_name),
6963 (bus_driver_handle_hello):
6964 Don't take a name, just use a numeric id to identify
6968 * dbus/dbus-bus.c: (dbus_bus_register_client),
6969 (dbus_bus_acquire_service), (dbus_bus_service_exists):
6971 Add new convenience functions for communicating with the bus.
6973 * dbus/dbus-message.h:
6975 * dbus/dbus-protocol.h:
6978 2003-02-01 Alexander Larsson <alexl@redhat.com>
6980 * dbus/dbus-message.c (dbus_message_append_fields):
6981 Add some more doc comments.
6983 2003-02-01 Havoc Pennington <hp@pobox.com>
6985 * dbus/dbus-break-loader.c (randomly_modify_length): change
6986 a 4-byte value in the message as if it were a length
6988 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): don't set
6989 execute bit on saved files
6991 2003-02-01 Havoc Pennington <hp@pobox.com>
6993 * dbus/dbus-break-loader.c (main): new program to find messages
6994 that break the loader.
6996 * dbus/dbus-sysdeps.c (_dbus_string_append_uint): new function
6997 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): new function
6999 * dbus/dbus-string.c (_dbus_string_set_byte): new
7001 2003-01-31 Havoc Pennington <hp@pobox.com>
7003 * dbus/dbus-message.c: refactor the test code to be more general,
7004 in preparation for writing a "randomly permute test cases to
7005 try to break the loader" program.
7007 2003-01-31 Havoc Pennington <hp@pobox.com>
7009 * doc/dbus-specification.sgml: work on the specification
7011 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): check
7012 the protocol version of the message.
7014 * dbus/dbus-protocol.h: drop special _REPLY names, the spec
7015 no longer specifies that.
7016 (DBUS_SERVICE_REPLY_SERVICE_EXISTS): fix flags (1/2/4/8 not
7019 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos): add missing
7020 "break" for DBUS_TYPE_NIL, remove @todo
7022 2003-01-31 Havoc Pennington <hp@pobox.com>
7024 * dbus/dbus-message.c (dbus_message_set_is_error_reply): rename
7025 just set_is_error/get_is_error as this is a commonly-used
7026 function, and write docs.
7028 2003-01-31 Anders Carlsson <andersca@codefactory.se>
7030 * dbus/dbus-address.c: (dbus_address_entry_free):
7031 Free key and value lists.
7033 * dbus/dbus-internals.c: (_dbus_type_to_string):
7034 Add the types we didn't have.
7036 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
7037 (_dbus_marshal_validate_arg):
7040 * dbus/dbus-message.c: (dbus_message_set_sender):
7041 Remove todo about being able to set sender to NULL.
7043 (dbus_message_set_is_error_reply),
7044 (dbus_message_get_is_error_reply):
7045 * dbus/dbus-message.h:
7048 * dbus/dbus-protocol.h:
7049 Add error reply flag.
7051 * test/data/valid-messages/opposite-endian.message:
7052 Add NIL type to test.
7054 2003-01-31 Havoc Pennington <hp@pobox.com>
7056 * doc/dbus-specification.sgml: fully specify the header. Add
7057 flags and major protocol version, and change header/body len to
7060 * dbus/dbus-message-builder.c (append_saved_length): append length
7063 * dbus/dbus-message.c (dbus_message_create_header): change header
7064 length and body length to unsigned. Add the new fields from the
7066 (_dbus_message_loader_return_buffer): unsigned header/body len
7068 2003-01-30 Havoc Pennington <hp@pobox.com>
7070 * dbus/dbus-auth.c: rework to use only REJECTED, no
7073 * doc/dbus-sasl-profile.txt: drop MECHANISMS and just
7074 use REJECTED, suggested by Mark McLoughlin
7076 2003-01-30 Havoc Pennington <hp@pobox.com>
7078 * dbus/dbus-server.c (dbus_server_listen): @todo about how we need
7079 a better way to report errors here. e.g. "unix address lacks
7080 path" or something. also "no such file" when the path doesn't
7083 * dbus/dbus-address.c (dbus_address_entries_free): add @todo about
7085 (dbus_parse_address): add @todo about documenting address format,
7086 and allowing , and ; to be escaped
7088 2003-01-30 Anders Carlsson <andersca@codefactory.se>
7091 Add dbus-address.[ch]
7093 * dbus/dbus-address.c: (dbus_address_entry_free),
7094 (dbus_address_entries_free), (create_entry),
7095 (dbus_address_entry_get_method), (dbus_address_entry_get_value),
7096 (dbus_parse_address), (_dbus_address_test):
7097 * dbus/dbus-address.h:
7098 New files for dealing with address parsing.
7100 * dbus/dbus-connection.c:
7101 Document timeout functions.
7103 * dbus/dbus-message.c:
7104 Document dbus_message_new_from_message.
7106 * dbus/dbus-server-debug.c:
7109 * dbus/dbus-server.c: (dbus_server_listen):
7110 Parse address and use correct server implementation.
7112 * dbus/dbus-string.c: (_dbus_string_find_to), (_dbus_string_test):
7113 * dbus/dbus-string.h:
7114 New function with test.
7116 * dbus/dbus-test.c: (dbus_internal_symbol_do_not_use_run_tests):
7120 * dbus/dbus-transport-debug.c:
7123 * dbus/dbus-transport.c: (_dbus_transport_open):
7124 Parse address and use correct transport implementation.
7126 2003-01-30 Havoc Pennington <hp@pobox.com>
7128 * dbus/dbus-message.c: use message->byte_order instead of
7129 DBUS_COMPILER_BYTE_ORDER throughout.
7130 (dbus_message_create_header): pad header to align the
7131 start of the body of the message to 8-byte boundary
7133 * dbus/dbus-marshal.h: make all the demarshalers take const
7134 DBusString arguments.
7136 * dbus/dbus-message.c (_dbus_message_loader_return_buffer):
7137 validate message args here, so we don't have to do slow validation
7138 later, and so we catch bad messages as they are incoming. Also add
7139 better checks on header_len and body_len. Also fill in
7142 * dbus/dbus-string.c (_dbus_string_validate_utf8): new (not
7143 implemented properly)
7144 (_dbus_string_validate_nul): new function to check all-nul
7146 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): rename
7147 get_arg_end_pos and remove all validation
7148 (_dbus_marshal_validate_arg): actually do validation here.
7150 2003-01-29 Havoc Pennington <hp@pobox.com>
7152 * dbus/dbus-message.c (check_message_handling): fix assertion
7153 failure on set_client_serial
7155 2003-01-28 Havoc Pennington <hp@pobox.com>
7157 * dbus/dbus-server-debug.c: Add doc section comments
7159 * dbus/dbus-transport-debug.c: add doc section comments
7161 2003-01-28 Havoc Pennington <hp@redhat.com>
7163 * dbus/dbus-string.c (_dbus_string_base64_decode): append bytes in
7164 the reverse order from how I had it
7165 (_dbus_string_base64_encode): reverse encoding order. I was
7166 basically byteswapping everything during encoding.
7168 2003-01-28 Anders Carlsson <andersca@codefactory.se>
7170 * dbus/dbus-connection-internal.h:
7171 * dbus/dbus-connection.c: (_dbus_connection_add_timeout),
7172 (_dbus_connection_remove_timeout):
7173 Add functions for adding and removing timeouts.
7175 * dbus/dbus-message.c: (dbus_message_new_from_message):
7176 Add new function that takes a message and creates an exact
7177 copy of it, but with the refcount set to 1.
7178 (check_message_handling):
7181 * dbus/dbus-server-protected.h:
7182 * dbus/dbus-server.c: (_dbus_server_init_base),
7183 (_dbus_server_finalize_base), (_dbus_server_add_timeout),
7184 (dbus_server_set_timeout_functions):
7185 (_dbus_server_remove_timeout):
7186 New functions so that a server can add and remove timeouts.
7188 (dbus_server_listen):
7189 Add commented out call to dbus_server_debug_new.
7191 * dbus/dbus-timeout.c: (_dbus_timeout_new):
7192 Actually set the handler, doh.
7194 * dbus/dbus-transport.c: (_dbus_transport_open):
7195 Add commented out call to dbus_transport_debug_client_new.
7198 Add dbus-transport-debug.[ch] and dbus-server-debug.[ch]
7200 2003-01-28 Havoc Pennington <hp@pobox.com>
7202 * dbus/dbus-message.c (check_message_handling): function to check
7203 on the loaded message, iterates over it etc.
7205 2003-01-28 Havoc Pennington <hp@pobox.com>
7207 * test/Makefile.am (dist-hook): fix make distdir
7209 * dbus/Makefile.am (TESTS_ENVIRONMENT): fix make check
7211 2003-01-27 Havoc Pennington <hp@pobox.com>
7213 * dbus/dbus-mempool.c (time_for_size): replace printf with
7216 * dbus/dbus-message-builder.c (_dbus_message_data_load): allow
7217 empty lines; fix the SAVE_LENGTH stuff to be
7218 START_LENGTH/END_LENGTH so it actually works; couple other
7221 * test/Makefile.am (dist-hook): add dist-hook for .message files
7223 * dbus/dbus-string.c (DBUS_STRING_COPY_PREAMBLE): source of a copy
7224 can be constant or locked.
7225 (_dbus_string_free): allow freeing a const string as
7228 * dbus/dbus-sysdeps.c (_dbus_concat_dir_and_file): utility
7230 * dbus/dbus-test-main.c (main): take an argument which is the
7231 directory containing test data
7233 * dbus/dbus-message.c (_dbus_message_test): pass a test_data_dir
7234 argument to this and load all the messages in test/data/
7235 checking that they can be loaded or not loaded as appropriate.
7237 2003-01-27 Anders Carlsson <andersca@codefactory.se>
7239 * bus/dispatch.c: (bus_dispatch_message_handler):
7240 Dispatch messages sent to services.
7242 * bus/driver.c: (bus_driver_send_service_deleted),
7243 (bus_driver_send_service_created), (bus_driver_send_service_lost),
7244 (bus_driver_send_service_acquired):
7245 Add helper functions for sending service related messages.
7247 (bus_driver_send_welcome_message):
7248 Send HELLO_REPLY instead of WELCOME.
7250 (bus_driver_handle_list_services):
7251 Send LIST_SERVICES_REPLY instead of SERVICES.
7253 (bus_driver_handle_own_service),
7254 (bus_driver_handle_service_exists):
7255 New message handlers.
7257 (bus_driver_handle_message):
7258 Invoke new message handlers.
7260 (bus_driver_remove_connection):
7261 Don't remove any services here since that's done automatically
7262 by bus_service_remove_owner now.
7265 New function signatures.
7267 * bus/services.c: (bus_service_add_owner):
7268 Send ServiceAcquired message if we're the only primary owner.
7270 (bus_service_remove_owner):
7271 Send ServiceAcquired/ServiceLost messages.
7273 (bus_service_set_prohibit_replacement),
7274 (bus_service_get_prohibit_replacement):
7275 Functions for setting prohibit replacement.
7277 (bus_service_has_owner):
7278 New function that checks if a connection is in the owner queue of
7282 Add new function signatures.
7284 * dbus/dbus-list.c: (_dbus_list_test):
7285 Add tests for _dbus_list_remove_last and traversing the list backwards.
7288 Fix a typo in _dbus_list_get_prev_link, if we're at the first element we can't
7289 go any further, so return NULL then.
7291 * dbus/dbus-protocol.h:
7292 Add new messages, service flags and service replies.
7294 2003-01-26 Havoc Pennington <hp@pobox.com>
7296 * dbus/dbus-message-builder.c: implement, completely untested.
7298 * test/data/*: add data to be used in testing.
7299 ".message" files are our simple loadable text format.
7300 ".message-raw" will be binary dumps of messages.
7302 * dbus/dbus-string.c (_dbus_string_starts_with_c_str): new
7304 2003-01-26 Havoc Pennington <hp@pobox.com>
7306 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): new function
7308 * dbus/dbus-errors.c (dbus_result_to_string): add
7311 * dbus/dbus-message-builder.c: new file, will contain code to load
7312 up messages from files. Not implemented yet.
7314 2003-01-26 Havoc Pennington <hp@pobox.com>
7316 * dbus/dbus-message.c (dbus_message_set_sender): support deleting
7317 the sender by setting to NULL
7319 2003-01-26 Havoc Pennington <hp@pobox.com>
7321 The unit tests pass, but otherwise untested. If it breaks, the
7322 tests should have been better. ;-)
7324 * bus/driver.c (bus_driver_handle_hello): return if we disconnect
7327 * dbus/dbus-message.c: redo everything so we maintain
7328 message->header as the only copy of the various fields.
7329 This avoids the possibility of out-of-memory in some cases,
7330 for example dbus_message_lock() can't run out of memory anymore,
7331 and avoids extra copying. Figured I may as well go ahead and do
7332 this since it was busted for dbus_message_lock to not return
7333 failure on OOM, and dbus_message_write_header was totally
7334 unchecked for OOM. Also fixed some random other bugs.
7336 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): verify
7337 that strings are nul-terminated. Also, end_pos can be equal
7338 to string length just not greater than, I think.
7339 (_dbus_marshal_set_int32): new function
7340 (_dbus_marshal_set_uint32): new function
7341 (_dbus_marshal_set_string): new function
7343 * dbus/dbus-connection.c (_dbus_connection_new_for_transport): fix
7344 a warning, init timeout_list to NULL
7345 (dbus_connection_send_message): don't use uninitialized variable
7348 * dbus/dbus-string.c (_dbus_string_replace_len): new function
7350 2003-01-26 Anders Carlsson <andersca@codefactory.se>
7352 * bus/driver.c: (bus_driver_handle_hello),
7353 (bus_driver_send_welcome_message):
7356 2003-01-26 Anders Carlsson <andersca@codefactory.se>
7358 * dbus/dbus-auth.c: (process_auth), (_dbus_auth_unref):
7359 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
7360 (dbus_connection_unref):
7361 * dbus/dbus-marshal.c: (_dbus_marshal_test):
7362 * dbus/dbus-message.c: (dbus_message_unref),
7365 (dbus_message_get_fields):
7366 Remove debugging printout.
7368 (_dbus_message_loader_return_buffer):
7369 Don't store the header string.
7371 (_dbus_message_test):
7374 2003-01-26 Richard Hult <rhult@codefactory.se>
7376 * glib/dbus-gmain.c (dbus_connection_dispatch): Traverse a copy of
7377 the file descriptor list, since it can change under us.
7379 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7381 * glib/dbus-gmain.c: (dbus_connection_prepare),
7382 (dbus_connection_check), (dbus_connection_dispatch), (add_watch),
7383 (remove_watch), (dbus_connection_hookup_with_g_main):
7384 Rewrite the glib handling to use its own GSource instead of a
7385 GIOChannel so we can catch messages put in the queue while waiting
7388 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7391 * bus/connection.c: (connection_disconnect_handler),
7392 (connection_watch_callback), (bus_connection_setup):
7393 * bus/dispatch.c: (send_one_message),
7394 (bus_dispatch_broadcast_message), (bus_dispatch_message_handler),
7395 (bus_dispatch_add_connection), (bus_dispatch_remove_connection):
7397 * bus/driver.c: (bus_driver_send_service_deleted),
7398 (bus_driver_send_service_created), (bus_driver_handle_hello),
7399 (bus_driver_send_welcome_message),
7400 (bus_driver_handle_list_services), (bus_driver_remove_connection),
7401 (bus_driver_handle_message):
7403 Refactor code, put the message dispatching in its own file. Use
7404 _DBUS_HANDLE_OOM. Also send ServiceDeleted messages when a client
7407 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7409 * dbus/dbus-internals.h:
7410 Add _DBUS_HANDLE_OOM macro, it doesn't do anything currently.
7412 * dbus/dbus-message.c: (dbus_message_get_sender):
7413 * dbus/dbus-message.h:
7414 Implement dbus_message_get_sender.
7416 * dbus/dbus-protocol.h:
7417 Add message and service defines.
7419 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7421 * dbus/dbus-connection.c: (dbus_connection_send_message):
7422 * dbus/dbus-message-internal.h:
7423 * dbus/dbus-message.c: (_dbus_message_get_client_serial),
7424 (dbus_message_write_header):
7425 Remove _dbus_messag_unlock and don't set the client serial on a
7426 message if one already exists.
7428 2003-01-24 Havoc Pennington <hp@pobox.com>
7430 * dbus/dbus-list.c (alloc_link): put a thread lock on the global
7433 * bus/driver.c (bus_driver_handle_list_services): fix a leak
7436 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7438 * dbus/dbus-list.c: (alloc_link), (free_link):
7439 Use a memory pool for the links.
7441 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7443 * bus/connection.c: (bus_connection_foreach):
7445 Add new bus_connection_foreach function.
7447 * bus/driver.c: (send_one_message), (bus_driver_broadcast_message):
7448 Add function that broadcasts a message to all clients.
7450 (bus_driver_send_service_created), (bus_driver_handle_hello),
7451 (bus_driver_send_welcome_message),
7452 (bus_driver_handle_list_services), (bus_driver_message_handler):
7453 Implement functions that take care of listing services, and notifying
7454 clients when new services are created.
7456 * bus/services.c: (bus_services_list):
7458 Add new function that returns an array of strings with the currently
7459 registered services.
7462 * glib/dbus-gmain.c:
7463 Update copyright year.
7465 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7467 * dbus/dbus-connection.c: (dbus_connection_send_message):
7468 Unlock the message in case it was sent earlier.
7470 (dbus_connection_send_message_with_reply_and_block):
7471 Remove the reply message from the list.
7473 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
7474 Set array_len and new_pos correctly.
7476 (_dbus_marshal_test):
7477 Remove debug output.
7479 * dbus/dbus-message-internal.h:
7480 * dbus/dbus-message.c: (_dbus_message_get_reply_serial):
7481 New function that returns the reply serial.
7483 (_dbus_message_unlock):
7484 New function that unlocks a message and resets its header.
7486 (dbus_message_append_string_array),
7487 (dbus_message_get_fields_valist),
7488 (dbus_message_iter_get_field_type),
7489 (dbus_message_iter_get_string_array),
7490 (dbus_message_get_fields),
7491 (dbus_message_append_fields_valist):
7492 Handle string arrays.
7494 (dbus_message_set_sender):
7495 Make this function public since the bus daemon needs it.
7497 (decode_header_data):
7498 Set the reply serial to -1 initially.
7500 * dbus/dbus-message.h:
7501 Add dbus_message_set_sender.
7503 2003-01-24 Havoc Pennington <hp@pobox.com>
7505 * doc/dbus-specification.sgml: add some stuff
7507 2003-01-22 Havoc Pennington <hp@pobox.com>
7509 * doc/dbus-specification.sgml: Start to document the protocol.
7511 2003-01-22 Havoc Pennington <hp@pobox.com>
7513 * dbus/dbus-connection.c
7514 (dbus_connection_send_message_with_reply_and_block): add some @todo
7516 * bus/driver.c (bus_driver_add_connection): add a FIXME about memleak
7518 2003-01-21 Havoc Pennington <hp@pobox.com>
7520 (patch untested because can't compile)
7522 * bus/driver.c (create_unique_client_name): make this function
7523 never recycle client names. Also, caller should initialize
7526 * dbus/dbus-sysdeps.c (_dbus_get_current_time): new function
7528 2003-01-21 Anders Carlsson <andersca@codefactory.se>
7530 * dbus/dbus-marshal.c: (_dbus_marshal_double),
7531 (_dbus_marshal_int32), (_dbus_marshal_uint32),
7532 (_dbus_marshal_int32_array), (_dbus_marshal_uint32_array),
7533 (_dbus_marshal_double_array), (_dbus_marshal_string_array),
7534 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
7535 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
7536 (_dbus_marshal_get_field_end_pos), (_dbus_marshal_test):
7537 * dbus/dbus-marshal.h:
7538 * dbus/dbus-protocol.h:
7539 Add support for marshalling and demarshalling integer, double
7542 2003-01-21 Anders Carlsson <andersca@codefactory.se>
7547 * bus/connection.c: (connection_disconnect_handler):
7548 Remove the connection from the bus driver's list.
7550 (connection_watch_callback): Dispatch messages.
7552 (free_connection_data): Free connection name.
7554 (bus_connection_setup): Add connection to the bus driver's list.
7555 (bus_connection_remove_owned_service):
7556 (bus_connection_set_name), (bus_connection_get_name):
7557 Add functions for setting and getting the connection's name.
7560 Add function headers.
7562 * bus/driver.c: (create_unique_client_name),
7563 (bus_driver_handle_hello_message),
7564 (bus_driver_send_welcome_message), (bus_driver_message_handler),
7565 (bus_driver_add_connection), (bus_driver_remove_connection):
7568 * bus/services.c: (bus_service_free):
7570 New file that handles communication and registreation with the bus
7573 2003-01-21 Anders Carlsson <andersca@codefactory.se>
7575 * dbus/dbus-connection.c: (dbus_connection_send_message):
7576 Add a new client_serial parameter.
7578 (dbus_connection_send_message_with_reply):
7579 Remove a @todo since we've implemented the blocking function.
7581 (dbus_connection_send_message_with_reply_and_block):
7582 New function that sends a message and waits for a reply and
7583 then returns the reply.
7585 * dbus/dbus-connection.h:
7588 * dbus/dbus-errors.c: (dbus_result_to_string):
7589 * dbus/dbus-errors.h:
7590 Add new DBUS_RESULT.
7592 * dbus/dbus-message-internal.h:
7593 * dbus/dbus-message.c: (_dbus_message_get_reply_serial),
7594 (_dbus_message_set_sender), (dbus_message_write_header),
7595 (dbus_message_new_reply), (decode_header_data),
7596 (_dbus_message_loader_return_buffer), (_dbus_message_test):
7597 * dbus/dbus-message.h:
7598 Add new functions that set the reply serial and sender.
7599 Also marshal and demarshal them correctly and add test.
7601 * dbus/dbus-protocol.h:
7602 Add new DBUS_MESSAGE_TYPE_SENDER.
7605 * glib/dbus-gmain.c: (watch_callback), (free_callback_data),
7606 (add_watch), (remove_watch), (add_timeout), (remove_timeout),
7607 (dbus_connection_hookup_with_g_main):
7608 * glib/test-dbus-glib.c: (main):
7609 Rewrite to use GIOChannel and remove the GSource crack.
7611 * test/echo-client.c: (main):
7612 * test/watch.c: (check_messages):
7613 Update for changed APIs
7615 2003-01-19 Anders Carlsson <andersca@codefactory.se>
7617 * dbus/Makefile.am: Add dbus-timeout.[cħ]
7619 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport):
7620 Create a DBusTimeoutList.
7621 (dbus_connection_set_timeout_functions): Add new function to
7622 set timeout callbacks
7624 * dbus/dbus-connection.h: Add public DBusTimeout API.
7626 * dbus/dbus-message.c: (dbus_message_get_service):
7627 * dbus/dbus-message.h: New function.
7629 * dbus/dbus-server.c: Fix small doc typo.
7631 * dbus/dbus-timeout.[ch]: New files for mainloop timeouts.
7633 2003-01-19 Anders Carlsson <andersca@codefactory.se>
7635 * dbus/dbus-string.c (_dbus_string_move_len): Don't delete all
7636 of the string, just as long as specified.
7638 2003-01-19 Havoc Pennington <hp@pobox.com>
7640 * dbus/dbus-connection.c (dbus_connection_get_is_authenticated):
7643 * dbus/dbus-server.c (dbus_server_set_max_connections)
7644 (dbus_server_get_max_connections, dbus_server_get_n_connections):
7645 keep track of current number of connections, and add API for
7646 setting a max (but haven't implemented enforcing the max yet)
7648 2003-01-18 Havoc Pennington <hp@pobox.com>
7650 * dbus/dbus-transport-unix.c (unix_do_iteration): only do the
7651 reading/writing if read_watch != NULL or write_watch != NULL.
7653 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): fix
7654 the message loader code to actually load message->header and
7655 message->body into the newly-created message.
7657 * dbus/dbus-transport-unix.c (check_write_watch): fix a mem leak
7660 * dbus/dbus-connection.c (dbus_connection_set_max_message_size)
7661 (dbus_connection_get_max_message_size)
7662 (dbus_connection_set_max_live_messages_size)
7663 (dbus_connection_get_max_live_messages_size): implement some
7664 resource limitation functions
7666 * dbus/dbus-resources.c: new file implementing some of the
7667 resource limits stuff
7669 * dbus/dbus-message.c (dbus_message_iter_get_byte_array): add
7670 missing docs, add @todo to handle OOM etc.
7672 * dbus/dbus-marshal.c (_dbus_demarshal_byte_array): add missing
7675 2003-01-18 Havoc Pennington <hp@pobox.com>
7677 * dbus/dbus-connection.c (dbus_connection_unref): disconnect the
7678 connection if it hasn't been already.
7680 * dbus/dbus-connection.h: kill off the idea of an ErrorFunction,
7681 replace with DisconnectFunction.
7683 2003-01-18 Havoc Pennington <hp@pobox.com>
7685 Building --disable-verbose-mode --disable-asserts --disable-tests
7686 cuts the library from 112K to 45K or so
7688 * configure.in: check for varargs macro support,
7689 add --enable-verbose-mode, --enable-asserts.
7691 * dbus/dbus-internals.h (_dbus_assert): support
7693 (_dbus_verbose): support DBUS_ENABLE_VERBOSE_MODE
7695 2003-01-18 Havoc Pennington <hp@pobox.com>
7697 * dbus/dbus-test.c: include config.h so that tests actually run
7699 * dbus/dbus-string.c: add assertions that stuff is 8-byte aligned,
7700 so the failure mode when that assumption fails will be plenty
7703 2003-01-18 Havoc Pennington <hp@pobox.com>
7705 * configure.in: default --enable-tests to $USE_MAINTAINER_MODE
7707 * dbus/Makefile.am: fix it up so dubs-test-main.c is included in
7710 * test/Makefile.am: don't use special variable "TESTS" for echo-*
7711 since we don't want to use those in make check
7713 2003-01-15 Havoc Pennington <hp@redhat.com>
7719 2003-01-15 Havoc Pennington <hp@redhat.com>
7721 * test/Makefile.am: fix so that test source code ends up in the
7722 distribution on make distcheck
7724 2003-01-15 Havoc Pennington <hp@redhat.com>
7730 2003-01-15 Havoc Pennington <hp@redhat.com>
7732 * dbus/dbus-test.c (dbus_internal_symbol_do_not_use_run_tests):
7733 fix build when --disable-tests
7735 * Makefile.am (EXTRA_DIST): put HACKING in here
7737 * HACKING: document procedure for making a tarball release.
7739 2003-01-14 Anders Carlsson <andersca@codefactory.se>
7741 * bus/connection.c: (connection_error_handler),
7742 (bus_connection_setup):
7743 * bus/main.c: (main):
7744 Make sure that the DBusConnectionData struct is NULLed
7745 out to prevent a segfault.
7747 * dbus/dbus-errors.c: (dbus_result_to_string):
7748 * dbus/dbus-errors.h:
7749 * dbus/dbus-message.c: (dbus_message_get_fields),
7750 (dbus_message_get_fields_valist), (_dbus_message_test):
7751 * dbus/dbus-message.h:
7752 Make dbus_message_get_fields return a result code so we can
7753 track invalid fields as well as oom.
7755 2003-01-11 Havoc Pennington <hp@pobox.com>
7757 * configure.in: change --enable-test/--enable-ansi action-if-given
7758 to enable_foo=$enableval instead of enable_foo=yes
7760 2003-01-08 Havoc Pennington <hp@pobox.com>
7762 * dbus/dbus-string.c (_dbus_string_align_length): new function
7764 * dbus/dbus-test-main.c: move main() for test app here
7766 (dbus_internal_symbol_do_not_use_run_tests): we have to export a
7767 symbol to run tests, because dbus-test isn't in the main
7770 Code review nitpicks.
7772 * dbus/dbus-message.c (dbus_message_write_header): add newlines
7773 for people with narrow emacs ;-). Assert client_serial was filled
7774 in. Assert message->name != NULL.
7775 (dbus_message_append_fields): have "first_field_type" arg separate
7776 from va list, needed for C++ binding that also uses varargs IIRC
7777 and helps with type safety
7778 (dbus_message_new): add @todo about using DBusString to store
7779 service/name internally
7780 (dbus_message_new): don't leak ->service and ->name on OOM later
7782 (dbus_message_unref): free the service name
7783 (dbus_message_get_fields): same change to varargs
7784 i.e. first_field_type
7785 (_dbus_message_loader_return_buffer): assert that the message data
7786 is aligned (if not it's a bug in our code). Put in verbose griping
7787 about why we set corrupted = TRUE.
7788 (decode_header_data): add FIXME that char* is evil. Was going to
7789 add FIXME about evil locale-specific string.h strncmp, but just
7790 switched to wacky string-as-uint32 optimization. Move check for
7791 "no room for field name" above get_const_data_len() to avoid
7792 assertion failure in get_const_data_len if we have trailing 2
7793 bytes or the like. Check for service and name fields being
7794 provided twice. Don't leak service/name on error. Require field
7795 names to be aligned to 4 bytes.
7797 * dbus/dbus-marshal.c: move byte swap stuff to header
7798 (_dbus_pack_int32): uscore-prefix
7799 (_dbus_unpack_int32): uscore-prefix
7800 (_dbus_unpack_uint32): export
7801 (_dbus_demarshal_string): add @todo complaining about use of
7803 (_dbus_marshal_get_field_end_pos): add @todo about bad error
7804 handling allowing corrupt data to go unchecked
7806 2003-01-08 Havoc Pennington <hp@redhat.com>
7808 * dbus/dbus-transport-unix.c (unix_do_iteration): add read/write
7809 to the select() as needed for authentication. (should be using
7810 _dbus_poll() not select, but for another day)
7812 * dbus/dbus.h: include dbus/dbus-protocol.h
7814 2003-01-08 Anders Carlsson <andersca@codefactory.se>
7816 * dbus/Makefile.am (dbusinclude_HEADERS): Install
7819 2003-01-08 Anders Carlsson <andersca@codefactory.se>
7821 * dbus/dbus-internals.c: (_dbus_type_to_string):
7822 New function that returns a string describing a type.
7824 * dbus/dbus-marshal.c: (_dbus_demarshal_byte_array):
7825 * dbus/dbus-marshal.h:
7826 * dbus/dbus-message.c: (dbus_message_get_fields_valist),
7827 (dbus_message_iter_get_field_type), (dbus_message_iter_get_double),
7828 (dbus_message_iter_get_byte_array):
7829 * dbus/dbus-message.h:
7830 Add new convenience functions for appending and getting message fields.
7831 Also add demarshalling routines for byte arrays.
7833 2003-01-07 Anders Carlsson <andersca@codefactory.se>
7835 * dbus/dbus-connection-internal.h:
7836 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
7837 (_dbus_connection_get_next_client_serial),
7838 (dbus_connection_send_message):
7839 * dbus/dbus-internals.h:
7840 * dbus/dbus-marshal.c: (unpack_uint32), (dbus_unpack_int32),
7841 (dbus_pack_int32), (_dbus_marshal_double), (_dbus_marshal_int32),
7842 (_dbus_marshal_uint32), (_dbus_demarshal_double),
7843 (_dbus_demarshal_int32), (_dbus_demarshal_uint32),
7844 (_dbus_demarshal_string), (_dbus_marshal_get_field_end_pos),
7845 (_dbus_verbose_bytes), (_dbus_marshal_test):
7846 * dbus/dbus-marshal.h:
7847 * dbus/dbus-message-internal.h:
7848 * dbus/dbus-message.c: (_dbus_message_set_client_serial),
7849 (dbus_message_write_header), (_dbus_message_lock),
7850 (dbus_message_new), (dbus_message_ref), (dbus_message_unref),
7851 (dbus_message_get_name), (dbus_message_append_int32),
7852 (dbus_message_append_uint32), (dbus_message_append_double),
7853 (dbus_message_append_string), (dbus_message_append_byte_array),
7854 (dbus_message_get_fields_iter), (dbus_message_iter_ref),
7855 (dbus_message_iter_unref), (dbus_message_iter_has_next),
7856 (dbus_message_iter_next), (dbus_message_iter_get_field_type),
7857 (dbus_message_iter_get_string), (dbus_message_iter_get_int32),
7858 (dbus_message_iter_get_uint32), (dbus_message_iter_get_double),
7859 (decode_header_data), (_dbus_message_loader_return_buffer),
7860 (message_iter_test), (_dbus_message_test):
7861 * dbus/dbus-message.h:
7862 * dbus/dbus-protocol.h:
7863 * dbus/dbus-test.c: (main):
7865 * glib/test-dbus-glib.c: (message_handler), (main):
7866 * test/echo-client.c: (main):
7867 * test/watch.c: (check_messages):
7868 Make messages sendable and receivable for real.
7870 2003-01-07 Anders Carlsson <andersca@codefactory.se>
7872 * dbus/dbus-marshal.c: (_dbus_marshal_double),
7873 (_dbus_marshal_string), (_dbus_marshal_byte_array):
7874 * dbus/dbus-message.c: (dbus_message_append_int32),
7875 (dbus_message_append_uint32), (dbus_message_append_double),
7876 (dbus_message_append_string), (dbus_message_append_byte_array):
7877 Handle OOM restoration.
7879 2003-01-07 Anders Carlsson <andersca@codefactory.se>
7881 * dbus/dbus-marshal.c: (_dbus_marshal_string),
7882 (_dbus_demarshal_string), (_dbus_marshal_test):
7883 * dbus/dbus-marshal.h:
7884 * dbus/dbus-message.c: (dbus_message_get_name),
7885 Document these functions.
7887 (dbus_message_append_int32), (dbus_message_append_uint32),
7888 (dbus_message_append_double), (dbus_message_append_string),
7889 (dbus_message_append_byte_array):
7890 * dbus/dbus-message.h:
7891 Add functions for adding message fields of different types.
7893 * dbus/dbus-protocol.h:
7894 Add the different types.
7896 2003-01-05 Havoc Pennington <hp@pobox.com>
7898 * bus/connection.c: implement routines for handling connections,
7899 first thing is keeping a list of owned services on each connection
7900 and setting up watches etc.
7902 * bus/services.c: implement a mapping from service names to lists
7905 * dbus/dbus-hash.c: add DBUS_HASH_POINTER
7907 * dbus/dbus-threads.c (dbus_static_mutex_lock): add functions
7908 to use static mutexes for global data
7910 * dbus/dbus-connection.c (dbus_connection_set_data): add new
7911 collection of functions to set/get application-specific data
7912 on the DBusConnection.
7914 2003-01-04 Havoc Pennington <hp@pobox.com>
7916 * dbus/dbus-sysdeps.c (_dbus_sleep_milliseconds): new function
7917 (_dbus_poll): new function
7919 * dbus/dbus-internals.h (_DBUS_STRUCT_OFFSET): new macro
7922 * bus/loop.c: initial code for the daemon main loop
7924 2003-01-04 Havoc Pennington <hp@pobox.com>
7926 * test/watch.c (error_handler): make it safe if the error handler
7927 is called multiple times (if we s/error handler/disconnect
7928 handler/ we should just guarantee it's called only once)
7930 * dbus/dbus-transport.c (_dbus_transport_disconnect): call the
7931 error handler on disconnect (it's quite possible we should
7932 just change the error handler to a "disconnect handler," I'm
7933 not sure we have any other meaningful errors)
7935 * configure.in: check for getpwnam_r
7937 * dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
7938 dbus/dbus-auth.c: add credentials support, add EXTERNAL auth
7939 mechanism as in SASL spec, using socket credentials
7941 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): new function
7942 (_dbus_send_credentials_unix_socket): new function
7944 * dbus/dbus-sysdeps.c (_dbus_accept_unix_socket): rename just
7946 (_dbus_write): only check errno if <0 returned
7947 (_dbus_write_two): ditto
7949 2003-01-02 Anders Carlsson <andersca@codefactory.se>
7951 * dbus/dbus-marshal.c: (_dbus_marshal_utf8_string),
7952 (_dbus_marshal_byte_array), (_dbus_demarshal_utf8_string),
7953 (_dbus_marshal_test):
7954 * dbus/dbus-marshal.h:
7955 Add _dbus_marshal_byte_array and rename _dbus_marshal_string
7956 to _dbus_marshal_utf8_string. Also fix some tests.
7958 2002-12-28 Harri Porten <porten@kde.org>
7960 * configure.in: added check for C++ compiler and a very cheesy
7961 check for the Qt integration
7963 * Makefile.am (SUBDIRS): compile qt subdir if support is enabled
7965 * qt/Makefile.am: added
7967 * qt/.cvsignore: added
7969 * qt/dbus-qthread.cc, qt/dbus-qthread.cpp: renamed former to
7970 latter, added #ifdef QT_THREAD_SUPPORT guard.
7972 * dbus/Makefile.am: added missing headers for make dist
7974 2002-12-28 Kristian Rietveld <kris@gtk.org>
7976 * dbus/Makefile.am: fixup export-symbols-regex.
7978 2002-12-27 Anders Carlsson <andersca@codefactory.se>
7980 * acinclude.m4: Add this file and put the
7981 PKG_CHECK_MODULE macro in it.
7983 2002-12-27 Anders Carlsson <andersca@codefactory.se>
7985 * dbus/dbus-marshal.c: (_dbus_marshal_string),
7986 (_dbus_demarshal_double), (_dbus_demarshal_int32),
7987 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
7988 (_dbus_marshal_test):
7989 Make the demarshalling routines align the pos argument.
7990 Add string marshalling tests and fix the obvious bugs
7993 2002-12-26 Havoc Pennington <hp@pobox.com>
7995 * dbus/dbus-auth.c: fixes fixes fixes
7997 * dbus/dbus-transport-unix.c: wire up support for
7998 encoding/decoding data on the wire
8000 * dbus/dbus-auth.c (_dbus_auth_encode_data)
8001 (_dbus_auth_decode_data): append to target string
8002 instead of nuking it.
8004 2002-12-26 Havoc Pennington <hp@pobox.com>
8006 * dbus/dbus-marshal.h (DBUS_COMPILER_BYTE_ORDER): #ifdef
8007 WORDS_BIGENDIAN then compiler byte order is DBUS_BIG_ENDIAN,
8010 * dbus/dbus-marshal.c: Add macros to do int swapping in-place and
8011 avoid swap_bytes() overhead (ignoring possible assembly stuff for
8012 now). Main point is because I wanted unpack_uint32 to implement
8014 (_dbus_verbose_bytes): new function
8016 * dbus/dbus-string.c (_dbus_string_validate_ascii): new function
8018 * dbus/dbus-message.c (_dbus_message_loader_get_is_corrupted): add
8019 mechanism to handle a corrupt message stream
8020 (_dbus_message_loader_new): fix preallocation to only prealloc,
8023 * dbus/dbus-string.c (_dbus_string_skip_blank): fix this function
8024 (_dbus_string_test): enhance tests for copy/move and fix the
8027 * dbus/dbus-transport-unix.c: Hold references in more places to
8028 avoid reentrancy problems
8030 * dbus/dbus-transport.c: ditto
8032 * dbus/dbus-connection.c (dbus_connection_dispatch_message): don't
8033 leak reference count in no-message case
8035 * test/watch.c (do_mainloop): handle adding/removing watches
8036 during iteration over the watches. Also, ref the connection/server
8037 stored on a watch, so we don't try to mangle a destroyed one.
8039 * dbus/dbus-transport-unix.c (do_authentication): perform
8042 * dbus/dbus-auth.c (get_state): add a state
8043 AUTHENTICATED_WITH_UNUSED_BYTES and return it if required
8044 (_dbus_auth_get_unused_bytes): append the unused bytes
8045 to the passed in string, rather than prepend
8047 * dbus/dbus-transport.c (_dbus_transport_init_base): create
8048 the auth conversation DBusAuth
8050 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd)
8051 (_dbus_transport_new_for_domain_socket): when creating a
8052 transport, pass in whether it's a client-side or server-side
8053 transport so we know which DBusAuth to create
8055 2002-12-03 Havoc Pennington <hp@pobox.com>
8057 * dbus/dbus-transport-unix.c (unix_finalize): finalize base
8058 _after_ finalizing the derived members
8059 (unix_connection_set): unref watch if we fail to add it
8061 * dbus/dbus-connection.c (dbus_connection_unref): delete the
8062 transport first, so that the connection owned by the
8063 transport will be valid as the transport finalizes.
8065 * dbus/dbus-transport-unix.c (unix_finalize): free the write_watch
8066 if necessary, and remove watches from the connection.
8068 * dbus/dbus-watch.c (_dbus_watch_list_free): improve a comment
8070 2002-12-26 Anders Carlsson <andersca@codefactory.se>
8072 * dbus/dbus-marshal.c: (_dbus_marshal_string),
8073 (_dbus_demarshal_double), (_dbus_demarshal_int32),
8074 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
8075 (_dbus_marshal_test):
8076 * dbus/dbus-marshal.h:
8077 Add string marshal functions and have the demarshal functions
8078 return the new position.
8080 2002-12-25 Havoc Pennington <hp@pobox.com>
8082 * doc/dbus-sasl-profile.txt: docs on the authentication protocol,
8083 it is a simple protocol that just maps directly to SASL.
8085 * dbus/dbus-auth.h, dbus/dbus-auth.c: authentication protocol
8086 initial implementation, not actually used yet.
8088 * dbus/dbus-string.c (_dbus_string_find): new function
8089 (_dbus_string_equal): new function
8090 (_dbus_string_base64_encode): new function
8091 (_dbus_string_base64_decode): new function
8093 2002-12-25 Anders Carlsson <andersca@codefactory.se>
8096 * dbus/dbus-marshal.c: (swap_bytes), (_dbus_marshal_double),
8097 (_dbus_marshal_int32), (_dbus_marshal_uint32),
8098 (_dbus_demarshal_double), (_dbus_demarshal_int32),
8099 (_dbus_demarshal_uint32), (_dbus_marshal_test):
8100 * dbus/dbus-marshal.h:
8101 * dbus/dbus-protocol.h:
8102 * dbus/dbus-test.c: (main):
8104 Add un-optimized marshalling/demarshalling routines.
8106 2002-12-25 Harri Porten <porten@kde.org>
8108 * qt/dbus-qt.h: adjusted ctor and getter to KDE/Qt conventions
8110 2002-12-24 Zack Rusin <zack@kde.org>
8112 * qt/dbus-qthread.cc: adding - integrates QMutex into Dbus
8113 * qt/dbus-qt.h: skeleton with two sample implemenatation of the
8116 2002-12-24 Havoc Pennington <hp@pobox.com>
8118 * glib/dbus-gthread.c: fix include
8120 * glib/dbus-glib.h: rename DBusMessageHandler for now.
8121 I think glib API needs to change, though, as you don't
8122 want to use DBusMessageFunction, you want to use the
8123 DBusMessageHandler object. Probably
8124 dbus_connection_open_with_g_main_loop()
8125 and dbus_connection_setup_g_main_loop() or something like that
8126 (but think of better names...) that just create a connection
8127 that has watch/timeout functions etc. already set up.
8129 * dbus/dbus-connection.c
8130 (dbus_connection_send_message_with_reply): new function just to
8131 show how the message handler helps us deal with replies.
8133 * dbus/dbus-list.c (_dbus_list_remove_last): new function
8135 * dbus/dbus-string.c (_dbus_string_test): free a string that
8138 * dbus/dbus-hash.c: use memory pools for the hash entries
8139 (rebuild_table): be more paranoid about overflow, and
8140 shrink table when we can
8141 (_dbus_hash_test): reduce number of sprintfs and write
8142 valid C89. Add tests for case where we grow and then
8143 shrink the hash table.
8145 * dbus/dbus-mempool.h, dbus/dbus-mempool.c: memory pools
8147 * dbus/dbus-connection.c (dbus_connection_register_handler)
8148 (dbus_connection_unregister_handler): new functions
8150 * dbus/dbus-message.c (dbus_message_get_name): new
8152 * dbus/dbus-list.c: fix docs typo
8154 * dbus/dbus-message-handler.h, dbus/dbus-message-handler.c:
8155 an object representing a handler for messages.
8157 2002-12-16 Anders Carlsson <andersca@codefactory.se>
8160 * glib/dbus-gthread.c: (dbus_gthread_init):
8161 Don't use the gdbus prefix for public functions.
8163 2002-12-16 Anders Carlsson <andersca@codefactory.se>
8167 Add GLib checks and fixup .pc files
8171 * glib/dbus-gmain.c: (gdbus_connection_prepare),
8172 (gdbus_connection_check), (gdbus_connection_dispatch),
8173 (gdbus_add_connection_watch), (gdbus_remove_connection_watch),
8174 (dbus_connection_gsource_new):
8175 * glib/dbus-gthread.c: (dbus_gmutex_new), (dbus_gmutex_free),
8176 (dbus_gmutex_lock), (dbus_gmutex_unlock), (dbus_gthread_init):
8177 * glib/test-dbus-glib.c: (message_handler), (main):
8180 2002-12-15 Harri Porten <porten@kde.org>
8182 * autogen.sh: check for libtoolize before attempting to use it
8184 * dbus/dbus-transport-unix.c: include <sys/time.h> for timeval
8187 * .cvsignore: ignore more stamp files
8189 * dbus/dbus-watch.c (_dbus_watch_list_new): fixed doc error
8191 * test/Makefile.am: added -I$(top_srcdir) to be able to compile
8192 without make install.
8194 2002-12-15 Havoc Pennington <hp@pobox.com>
8196 * dbus/dbus-threads.c: add thread stubs that a higher library
8197 layer can fill in. e.g. the GLib wrapper might fill them in with
8198 GThread stuff. We still need to use this thread API to
8199 thread-safe-ize the library.
8201 2002-12-12 Havoc Pennington <hp@pobox.com>
8203 * dbus/dbus-transport-unix.c, dbus/dbus-server-unix.c: use the
8204 below new interfaces and include fewer system headers.
8206 * dbus/dbus-sysdeps.c (_dbus_read): new function
8207 (_dbus_write): new function
8208 (_dbus_write_two): new function
8209 (_dbus_connect_unix_socket): new function
8210 (_dbus_listen_unix_socket): new function
8212 * dbus/dbus-message-internal.h: change interfaces to use
8215 2002-12-11 Havoc Pennington <hp@pobox.com>
8217 * dbus/dbus-types.h: add dbus_unichar
8219 * dbus/dbus-internals.c (_dbus_verbose): use _dbus_getenv
8221 * dbus/dbus-connection.c (dbus_connection_send_message): return
8224 * dbus/dbus-transport.c: include dbus-watch.h
8226 * dbus/dbus-connection.c: include dbus-message-internal.h
8228 * HACKING: add file with coding guidelines stuff.
8230 * dbus/dbus-string.h, dbus/dbus-string.c: Encapsulate all string
8231 handling here, for security purposes (as in vsftpd). Not actually
8232 using this class yet.
8234 * dbus/dbus-sysdeps.h, dbus/dbus-sysdeps.c: Encapsulate all
8235 system/libc usage here, as in vsftpd, for ease of auditing (and
8236 should also simplify portability). Haven't actually moved all the
8237 system/libc usage into here yet.
8239 2002-11-25 Havoc Pennington <hp@pobox.com>
8241 * dbus/dbus-internals.c (_dbus_verbose): fix to not
8242 always print the first verbose message.
8244 2002-11-24 Havoc Pennington <hp@pobox.com>
8246 * test/echo-client.c, test/echo-server.c: cheesy test
8249 * configure.in (AC_CHECK_FUNCS): check for writev
8251 * dbus/dbus-message.c (_dbus_message_get_network_data): new
8254 * dbus/dbus-list.c (_dbus_list_foreach): new function
8256 * dbus/dbus-internals.c (_dbus_verbose): new function
8258 * dbus/dbus-server.c, dbus/dbus-server.h: public object
8259 representing a server that listens for connections.
8261 * dbus/.cvsignore: create
8263 * dbus/dbus-errors.h, dbus/dbus-errors.c:
8264 public API for reporting errors
8266 * dbus/dbus-connection.h, dbus/dbus-connection.c:
8267 public object representing a connection that
8268 sends/receives messages. (Same object used for
8269 both client and server.)
8271 * dbus/dbus-transport.h, dbus/dbus-transport.c:
8272 Basic abstraction for different kinds of stream
8273 that we might read/write messages from.
8275 2002-11-23 Havoc Pennington <hp@pobox.com>
8277 * dbus/dbus-internals.h (_DBUS_INT_MAX): add _DBUS_INT_MIN
8280 * dbus/dbus-test.c (main): add list test, and include
8281 dbus-test.h as intended
8283 * dbus/dbus-hash.c (_dbus_hash_table_remove_string)
8284 (_dbus_hash_table_remove_int): return value indicates
8285 whether the entry existed to remove
8287 * dbus/dbus-list.c: add linked list utility class,
8290 * dbus/dbus-hash.c: add TODO item about shrinking the hash bucket
8293 2002-11-23 Havoc Pennington <hp@pobox.com>
8295 * Doxyfile.in (INCLUDE_FILE_PATTERNS): expand DBUS_BEGIN_DECLS/
8296 DBUS_END_DECLS to nothing, that should fix this once and for all
8298 * Doxyfile.in (JAVADOC_AUTOBRIEF): set to YES
8300 * dbus/dbus-message.c, dbus/dbus-hash.c:
8301 add some missing @brief
8303 2002-11-23 Havoc Pennington <hp@pobox.com>
8305 * dbus/dbus-message.h: put semicolons after DEBUG_BEGIN_DECLS
8306 to avoid confusing Doxygen
8308 * dbus/dbus-hash.c: @} not }@
8310 * dbus/dbus-message.c (struct DBusMessage): split out
8313 2002-11-23 Havoc Pennington <hp@pobox.com>
8315 * configure.in: pile on more warning flags if using gcc
8317 * Doxyfile.in (EXTRACT_STATIC): set to NO, so we don't have
8318 to document static functions
8320 * configure.in: add summary to end of configure so it
8321 looks nice and attractive
8323 * dbus/dbus-hash.c: finish implementation and write unit
8326 * configure.in: add --enable-tests to enable unit tests
8328 * dbus/dbus-test.c: test program to run unit tests
8329 for all files in dbus/*, initially runs a test for
8332 * dbus/dbus-internals.h: file to hold some internal utility stuff
8334 2002-11-22 Havoc Pennington <hp@redhat.com>
8336 * dbus/dbus-hash.c: copy in Tcl hash table, not yet
8337 "ported" away from Tcl
8339 * dbus/dbus-types.h: header for types such as dbus_bool_t
8341 2002-11-22 Havoc Pennington <hp@redhat.com>
8343 * dbus/dbus.h: fixups for doc warnings
8345 * Doxyfile.in (FILE_PATTERNS): we need to scan .h to pick up
8347 (QUIET): make it quiet so we can see warnings
8349 * dbus/dbus-memory.c: teach D-BUS to allocate and free memory
8351 2002-11-22 Havoc Pennington <hp@redhat.com>
8353 * Makefile.am: include "Doxyfile" target in all-local
8355 * configure.in: generate the Doxyfile
8357 * Doxyfile.in: move Doxyfile here, so we can use
8358 configure to generate a Doxyfile with the right
8361 2002-11-22 Havoc Pennington <hp@redhat.com>
8363 * dbus/dbus-message.c: move inline docs into .c file
8365 * Doxyfile (OUTPUT_DIRECTORY): move output to doc/api
8366 so all docs are under doc/
8367 (MAN_EXTENSION): generate man pages. Use extension
8368 ".3dbus" which matches ".3qt" on my system,
8369 I guess this is OK, I don't know really.
8370 (FILE_PATTERNS): look for .c files not .h, makes sense
8373 2002-11-22 Havoc Pennington <hp@pobox.com>
8375 * Makefile.am (SUBDIRS): rename subdir "server" to "bus"
8376 because any app can be a server, and any app can be a client,
8377 the bus is a special kind of server.
8379 Thu Nov 21 23:35:31 2002 Zack Rusin <zack@kde.org>
8381 * Doxyfile : adding. Still needs Makefile rules to be generated
8382 automatically (just run "doxygen" in the toplevel dir for now to
8385 * dbus/dbus-message.h : Adding sample docs (javadoc since
8386 resembles gtk-doc a little more)
8388 * dbus/dbus.h : Adding sample docs
8390 2002-11-21 Havoc Pennington <hp@redhat.com>
8392 * dbus/Makefile.am (INCLUDES): define DBUS_COMPILATION
8393 so we can allow ourselves to include files directly,
8394 instead of having to use dbus.h
8396 * dbus/dbus.h: fill in
8398 * dbus/dbus-message.h: sketch out a sample header file.
8399 Include griping if you include it directly instead of
8402 * dbus/dbus-macros.h: new file with macros for extern "C",
8403 TRUE/FALSE, NULL, etc.
8405 * doc/file-boilerplate.c: put include guards in here
8407 2002-11-21 Havoc Pennington <hp@redhat.com>
8409 * doc/file-boilerplate.c: include both AFL and GPL boilerplate.
8411 * COPYING: include the GPL as well, and license code
8412 under both AFL and GPL.
8414 2002-11-21 Havoc Pennington <hp@redhat.com>
8416 * acconfig.h: get rid of this
8418 * autogen.sh (run_configure): add --no-configure option
8420 * configure.in: remove AC_ARG_PROGRAM to make
8421 autoconf complain less. add AC_PREREQ.
8422 add AC_DEFINE third arg.
8424 2002-11-21 Anders Carlsson <andersca@codefactory.se>
8427 Fix references so we can distcheck.
8429 2002-11-21 Havoc Pennington <hp@redhat.com>
8431 * Initial module creation