1 2003-08-15 Havoc Pennington <hp@redhat.com>
3 * dbus/dbus-pending-call.c (dbus_pending_call_block): implement
5 * dbus/dbus-connection.c
6 (dbus_connection_send_with_reply_and_block): factor out internals;
7 change to convert any error replies to DBusError instead of
8 returning them as a message
10 2003-08-15 Havoc Pennington <hp@pobox.com>
12 * dbus/dbus-connection.c,
13 dbus/dbus-pending-call.c: Finish the pending call stuff
15 2003-08-14 Havoc Pennington <hp@redhat.com>
17 * dbus/dbus-pending-call.c: start on new object that will replace
18 DBusMessageHandler and ReplyHandlerData for tracking outstanding
21 * dbus/dbus-gproxy.c: start on proxy object used to communicate
22 with remote interfaces
24 * dbus/dbus-gidl.c: do the boring boilerplate in here
26 2003-08-12 Havoc Pennington <hp@pobox.com>
28 * bus/dispatch.c (bus_dispatch): make this return proper
29 DBusHandlerResult to avoid DBUS_ERROR_UNKNOWN_METHOD
31 * dbus/dbus-errors.c (dbus_set_error): use
32 _dbus_string_append_printf_valist
34 * dbus/dbus-string.c (_dbus_string_append_printf_valist)
35 (_dbus_string_append_printf): new
37 * dbus/dbus-errors.h (DBUS_ERROR_UNKNOWN_MESSAGE): change to
40 * dbus/dbus-connection.c (dbus_connection_dispatch): handle
41 DBUS_HANDLER_RESULT_NEED_MEMORY; send default error reply if a
44 2003-08-11 Havoc Pennington <hp@pobox.com>
46 * bus/test.c (client_disconnect_handler): change to return
47 HANDLED (would have been REMOVE_MESSAGE)
49 * dbus/dbus-object.h (enum DBusHandlerResult): rename to
50 HANDLED/NOT_YET_HANDLED instead of
51 REMOVE_MESSAGE/ALLOW_MORE_HANDLERS to make it clearer how it
54 2003-08-10 Havoc Pennington <hp@pobox.com>
56 * tools/dbus-send.c (main): add --type argument, for now
57 supporting only method_call and signal types.
59 * tools/dbus-print-message.c: print message type
61 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
62 init connection->objects
64 * doc/dbus-specification.sgml: fix sgml
66 * bus/*.c: port over to object-instance API changes
68 * test/test-service.c: ditto
70 * dbus/dbus-message.c (dbus_message_create_header): allow #NULL
71 name, we will have to fix up the rest of the code to also handle
73 (dbus_message_new): generic message-creation call
74 (set_string_field): allow appending name field
76 2003-08-06 Havoc Pennington <hp@pobox.com>
78 * dbus/dbus-object-registry.c: implement signal connection
81 * dbus/dbus-connection.c (_dbus_connection_unref_unlocked): new
83 * dbus/dbus-internals.c (_dbus_memdup): new function
85 2003-08-02 Havoc Pennington <hp@pobox.com>
87 * dbus/dbus-message.c (dbus_message_get_no_reply)
88 (dbus_message_set_no_reply): add these and remove
89 set_is_error/get_is_error
91 * dbus/dbus-protocol.h, doc/dbus-specification.sgml:
92 remove the ERROR flag, since there's now an ERROR type
94 2003-08-01 Havoc Pennington <hp@pobox.com>
96 * dbus/dbus-object-registry.c (_dbus_object_registry_handle_and_unlock):
99 * dbus/dbus-message.c (dbus_message_get_type): new function
101 * doc/dbus-specification.sgml: add "type" byte to messages
103 2003-08-01 Havoc Pennington <hp@pobox.com>
105 * dbus/dbus-protocol.h (DBUS_MESSAGE_TYPE_*): introduce
106 a message type enum to distinguish kinds of message
107 (DBUS_HEADER_FLAG_NO_REPLY_EXPECTED): flag for a message
108 that need not be replied to
110 2003-08-01 Havoc Pennington <hp@pobox.com>
112 * dbus/dbus-marshal.c: adapt to DBusObjectID changes
113 (unpack_8_octets): fix no-64-bit-int bug
115 * dbus/dbus-object-registry.c (validate_id): validate the
116 connection ID bits, not just the instance ID.
118 * dbus/dbus-connection.c (_dbus_connection_init_id): initialize
119 the connection-global 33 bits of the object ID
121 * dbus/dbus-object-registry.c (info_from_entry): fill in
122 object ID in the new way
124 * dbus/dbus-objectid.h: rather than high/low bits, specifically
125 define server/client/instance bits.
127 2003-07-30 Havoc Pennington <hp@pobox.com>
129 * dbus/dbus-connection.c (dbus_connection_register_object): fix
132 2003-07-13 Havoc Pennington <hp@pobox.com>
134 * dbus/dbus-object.h (struct DBusObjectVTable): add padding
135 fields to DBusObjectVTable and DBusObjectInfo
137 2003-07-12 Havoc Pennington <hp@pobox.com>
139 * dbus/dbus-object-registry.c: implement unit test,
140 fix bugs discovered in process
142 * dbus/dbus-connection.c: remove handler_table and
143 register_handler(), add DBusObjectRegistry usage
145 * dbus/dbus-objectid.c (dbus_object_id_is_null)
146 (dbus_object_id_set_null): new functions
148 2003-07-08 Havoc Pennington <hp@pobox.com>
150 * dbus/dbus-object.c: implement some of this
152 * dbus/dbus-object-registry.c
153 (_dbus_object_registry_add_and_unlock): fill in the object_id out
155 (_dbus_object_registry_new): handle OOM
157 2003-07-08 Havoc Pennington <hp@pobox.com>
159 * dbus/dbus-object.h: sketch out an API for registering objects
160 with a connection, that allows us to use as little as 24 bytes
161 per object and lets application code represent an object in
164 * dbus/dbus-object-registry.c: implement the hard bits of the
165 DBusConnection aspect of object API. Not yet wired up.
167 2003-07-06 Havoc Pennington <hp@pobox.com>
169 * dbus/dbus-marshal.c (_dbus_marshal_set_object_id): new function
170 (_dbus_marshal_object_id): new
171 (_dbus_demarshal_object_id): new
172 (_dbus_marshal_get_arg_end_pos): support object ID type, and
173 consolidate identical switch cases. Don't conditionalize handling
174 of DBUS_TYPE_UINT64, need to handle the type always.
175 (_dbus_marshal_validate_arg): consolidate identical cases, and
176 handle DBUS_TYPE_OBJECT_ID
178 * dbus/dbus-objectid.c: new file with DBusObjectID data type.
180 * dbus/dbus-protocol.h: add DBUS_TYPE_OBJECT_ID
182 2003-06-29 Havoc Pennington <hp@pobox.com>
184 * mono/Test.cs (class Test): fire up a main loop and run it
186 * mono/DBus.cs (DBus): don't g_thread_init since it can only be
187 done once, the app has to do it
189 2003-06-26 Havoc Pennington <hp@pobox.com>
191 * mono/Connection.cs: set up connection with the glib main loop
193 2003-07-01 Havoc Pennington <hp@redhat.com>
195 * doc/dbus-specification.sgml: clarify the format of a type code,
196 change suggested by Jim Blandy
198 2003-06-29 Miloslav Trmac <mitr@volny.cz>
201 * tools/Makefile.am: Don't assume srcdir == builddir.
203 * dbus/dbus-memory.c (dbus_realloc): Don't check guards after shrinking
205 (_dbus_memory_test): New function.
206 * dbus/dbus-test.h: Add _dbus_memory_test ().
207 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): Call it.
209 * dbus/dbus-message.c (decode_header_data): Use %.4s instead
211 (dbus_message_new): Remove obsolete @todo.
213 * dbus/dbus-marshal.c (_dbus_marshal_set_int64)
214 (_dbus_marshal_set_uint64): Fix comment.
216 * dbus/dbus-message.c (append_int_field, append_uint_field): Don't
217 hardcode FIELD_REPLY_SERIAL.
219 * dbus/dbus-mainloop.c (_dbus_loop_remove_watch)
220 (_dbus_loop_remove_timeout): Cast function pointers to (void *) for %p
222 * configure.in: Add -D_POSIX_C_SOURCE=199309L -DBSD_SOURCE to CFLAGS
223 and disable DBUS_USE_ATOMIC_INT_486 when --enable-ansi is used
225 2003-06-24 Havoc Pennington <hp@pobox.com>
227 * mono/*.cs: Use IntPtr.Zero instead of ((IntPtr) 0)
229 2003-06-23 Anders Carlsson <andersca@codefactory.se>
235 * gcj/TestMessage.java: (TestMessage), (TestMessage.main):
236 * gcj/org/.cvsignore:
237 * gcj/org/Makefile.am:
238 * gcj/org/freedesktop/.cvsignore:
239 * gcj/org/freedesktop/Makefile.am:
240 * gcj/org/freedesktop/dbus/.cvsignore:
241 * gcj/org/freedesktop/dbus/Makefile.am:
242 * gcj/org/freedesktop/dbus/Message.java: (Message),
244 * gcj/org/freedesktop/dbus/natMessage.cc:
245 Fix the build system.
247 2003-06-22 Havoc Pennington <hp@pobox.com>
249 * mono/Connection.cs: add more bindings
251 * dbus/dbus-threads.c (dbus_threads_init): allow calling this
254 2003-06-22 Havoc Pennington <hp@pobox.com>
256 * mono/Connection.cs, mono/DBus.cs, mono/Error.cs:
257 Start wrapping more stuff.
259 2003-06-22 Havoc Pennington <hp@pobox.com>
261 * mono/Message.cs: implement Message.Wrap() that ensures we only
262 have a single C# wrapper per DBusMessage, assuming it works which
265 * dbus/dbus-message.c (dbus_message_allocate_data_slot): new
266 (dbus_message_free_data_slot): new
267 (dbus_message_set_data): new
268 (dbus_message_get_data): new
270 2003-06-22 Havoc Pennington <hp@pobox.com>
272 * dbus/dbus-dataslot.c (_dbus_data_slot_allocator_unref)
273 (_dbus_data_slot_allocator_alloc): rework these to keep a
274 reference count on each slot and automatically manage a global
275 slot ID variable passed in by address
277 * bus/bus.c: convert to new dataslot API
279 * dbus/dbus-bus.c: convert to new dataslot API
281 * dbus/dbus-connection.c: convert to new dataslot API
283 * dbus/dbus-server.c: convert to new dataslot API
285 * glib/dbus-gmain.c: ditto
289 * bus/connection.c: ditto
291 2003-06-22 Anders Carlsson <andersca@codefactory.se>
293 * configure.in: Add AM_PROG_GCJ and move AM_PROG_LIBTOOL
294 after the gcj checks so that the correct configuration tags
295 will be added to libtool.
297 * dbus-glib-1.pc.in: No need to specify any includes since
298 dbus-1.pc.in has those.
300 2003-06-22 Havoc Pennington <hp@pobox.com>
302 * mono/*, gcj/*, configure.in, Makefile.am:
303 Check in makefiles and subdirs for mono and gcj bindings.
304 Neither binding actually exists, just trying to get through
305 all the build and other boring bits.
307 2003-06-21 Philip Blundell <philb@gnu.org>
309 * tools/dbus-monitor.1: Updated.
311 * tools/dbus-send.1: Likewise.
313 2003-06-20 Anders Carlsson <andersca@codefactory.se>
315 * dbus/dbus-transport-unix.c (unix_handle_watch): Check
316 for hangup and error after checking read so we won't discard
317 pending data if both hangup and read are set.
319 2003-06-19 Philip Blundell <philb@gnu.org>
321 * tools/dbus-print-message.c (print_message): Handle BOOLEAN.
323 * tools/dbus-send.c: Accept both --system and --session.
325 * tools/dbus-monitor.c: Same here.
327 2003-06-19 Anders Carlsson <andersca@codefactory.se>
329 * glib/dbus-glib.h: Fix so that dbus-glib.h can be used
330 from C++ (Patch by Miloslav Trmac).
332 2003-06-15 Joe Shaw <joe@assbarn.com>
334 * configure.in: Check for socklen_t.
336 * dbus/dbus-sysdeps.c: Define socklen_t if it's not defined.
338 * test/test-segfault.c: Add #include <sys/time.h>
340 * tools/Makefile.am: Add DBUS_X_CFLAGS to the INCLUDES since
341 dbus-launch needs it.
343 2003-06-09 Havoc Pennington <hp@redhat.com>
345 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): don't use
346 SUN_LEN, it breaks abstract socket usage
348 * dbus/dbus-internals.c (_dbus_verbose_real): only print PID at
351 2003-06-04 Havoc Pennington <hp@pobox.com>
353 * dbus/dbus-server.c (dbus_server_listen): allow abstract sockets
354 using unix:abstract=/foo, and when listening in a tmpdir
355 i.e. unix:tmpdir=/tmp, always use abstract sockets if we can.
357 * dbus/dbus-transport.c (_dbus_transport_open): support
360 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
361 support abstract sockets
363 * dbus/dbus-transport-unix.c
364 (_dbus_transport_new_for_domain_socket): support abstract sockets
366 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket): add "abstract"
367 toggle as an argument, implement abstract namespace support
368 (_dbus_listen_unix_socket): ditto
370 * configure.in: add --enable-abstract-sockets and implement
371 a configure check for autodetection of the right value.
373 2003-06-01 Havoc Pennington <hp@pobox.com>
375 * tools/dbus-cleanup-sockets.c: add utility to clean up sockets
376 in /tmp (though on Linux this will end up being useless,
377 when we add abstract namespace support)
379 * configure.in: define DBUS_SESSION_SOCKET_DIR in addition to
382 2003-05-28 Colin Walters <walters@verbum.org>
384 * tools/dbus-monitor.c (main): Fix silly typo (s/--session/--system/).
386 2003-05-18 Anders Carlsson <andersca@codefactory.se>
388 * dbus/dbus-message.c (dbus_message_new): Remove @todo.
390 2003-05-17 Colin Walters <walters@gnu.org>
392 * tools/dbus-send.c: Don't exit with an error code if --help was
393 passed. Default to using the session bus instead of the system
396 * tools/dbus-launch.c: Ditto.
398 * tools/dbus-monitor.c: Ditto.
400 * tools/dbus-send.1: Update with new arguments.
402 * tools/dbus-launch.c: Emit code to export variables. New
403 arguments -s and -c to specify shell syntax, and a bit of code to
404 autodetect syntax. Also, allow specifying a program to run.
406 * tools/dbus-launch.1: Update with new arguments.
408 * tools/dbus-send.1: Ditto.
410 * tools/dbus-monitor.1: Ditto.
412 2003-05-17 Havoc Pennington <hp@pobox.com>
414 * bus/config-parser.c (merge_included): merge in policies from
415 child configuration file.
417 * bus/policy.c (bus_policy_merge): function to merge two policies
420 2003-05-16 Havoc Pennington <hp@redhat.com>
422 * dbus/dbus-connection.c: disable verbose lock spew
424 * tools/dbus-send.c: add --print-reply command line option
426 * tools/dbus-print-message.h (print_message): new util function
427 shared by dbus-send and dbus-monitor
429 * tools/dbus-monitor.c (handler_func): exit on disconnect
431 * dbus/dbus-transport-unix.c (do_reading): if the transport is
432 disconnected, don't try to use the read_watch
434 * dbus/dbus-watch.c (dbus_watch_get_enabled): assert watch != NULL
435 so we can find this bug more easily
437 2003-05-16 Havoc Pennington <hp@redhat.com>
439 * bus/policy.c (free_rule_list_func): avoid a crash when passed
440 NULL as DBusHashTable is annoyingly likely to do.
442 2003-05-16 Colin Walters <walters@verbum.org>
444 * tools/dbus-monitor.c: Add --session argument and usage()
447 * tools/dbus-monitor.1: Update with new --session arg.
449 * bus/Makefile.am (install-data-hook): Create
450 $(libdir)/dbus-1.0/services so that the session bus is happy.
452 2003-05-15 Havoc Pennington <hp@redhat.com>
454 * dbus/dbus-sysdeps.c (_dbus_atomic_dec, _dbus_atomic_inc): work
455 on non-x86. ifdef's are evil.
457 2003-05-15 Havoc Pennington <hp@redhat.com>
463 * bus/Makefile.am (initddir): apparently we are supposed to put
464 init scripts in /etc/rc.d/init.d not /etc/init.d
466 * bus/Makefile.am: remove the "you must --enable-tests to make
467 check" as it broke distcheck
469 * bus/Makefile.am (install-data-hook): create /etc/dbus-1/system.d
471 2003-05-13 James Willcox <jwillcox@gnome.org>
474 * bus/activation.c: (bus_activation_service_created),
475 (bus_activation_activate_service):
476 * bus/driver.c: (bus_driver_send_service_deleted),
477 (bus_driver_send_service_created), (bus_driver_send_service_lost),
478 (bus_driver_send_service_acquired),
479 (bus_driver_send_welcome_message),
480 (bus_driver_handle_list_services):
481 * bus/session.conf.in:
482 * dbus/dbus-bus.c: (dbus_bus_acquire_service),
483 (dbus_bus_service_exists), (dbus_bus_activate_service):
486 Add some convenience API which lets you activate a service, and did a
487 bunch of s/0/DBUS_TYPE_INVALID/ in calls to dbus_message_append_args()
488 and dbus_message_get_args()
490 2003-05-11 Havoc Pennington <hp@pobox.com>
492 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix to avoid
493 calling _dbus_marshal_validate_arg() for every byte in a byte
496 * dbus/dbus-message-handler.c: use atomic reference counting to
497 reduce number of locks slightly; the global lock in here sucks
499 * dbus/dbus-connection.c
500 (_dbus_connection_update_dispatch_status_and_unlock): variant of
501 update_dispatch_status that can be called with lock held; then use
502 in a couple places to reduce locking/unlocking
503 (dbus_connection_send): hold the lock over the whole function
504 instead of acquiring it twice.
506 * dbus/dbus-timeout.c (_dbus_timeout_new): handle OOM
508 * bus/connection.c (bus_connections_setup_connection): fix access
509 to already-freed memory.
511 * dbus/dbus-connection.c: keep a little cache of linked list
512 nodes, to avoid using the global linked list alloc lock in the
513 normal send-message case. Instead we just use the connection lock
514 that we already have to take.
516 * dbus/dbus-list.c (_dbus_list_find_last): new function
518 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec):
519 change to use a struct for the atomic type; fix docs,
520 they return value before increment, not after increment.
522 * dbus/dbus-string.c (_dbus_string_append_4_aligned)
523 (_dbus_string_append_8_aligned): new functions to try to
524 microoptimize this operation.
525 (reallocate_for_length): break this out of set_length(), to
526 improve profile info, and also so we can consider inlining the
529 * dbus/dbus-message.c (dbus_message_new_empty_header): init data
530 strings with some preallocation, cuts down on our calls to realloc
531 a fair bit. Though if we can get the "move entire string to empty
532 string" optimization below to kick in here, it would be better.
534 * dbus/dbus-string.c (_dbus_string_move): just call
535 _dbus_string_move_len
536 (_dbus_string_move_len): add a special case for moving
537 an entire string into an empty string; we can just
538 swap the string data instead of doing any reallocs.
539 (_dbus_string_init_preallocated): new function
541 2003-05-11 Havoc Pennington <hp@pobox.com>
543 Write a "test-profile" that does echo client-server with threads;
544 profile reveals lock contention, memcpy/realloc of buffers, and
545 UTF-8 validation as hot spots. 20% of lock contention eliminated
546 with dbus_atomic_inc/dec implementation on x86. Much remaining
547 contention is global mempool locks for GList and DBusList.
549 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec): add
552 * dbus/dbus-connection.c (struct DBusConnection): use
553 dbus_atomic_t for the reference count
555 * dbus/dbus-message.c (struct DBusMessage): declare
556 dbus_atomic_t values as volatile
558 * configure.in: code to detect ability to use atomic integer
559 operations in assembly, from GLib patch
561 * dbus/dbus-internals.c (_dbus_verbose_real): call getpid every
562 time, tired of it being wrong in threads and forked processes
564 * glib/test-profile.c: a little program to bounce messages back
565 and forth between threads and eat CPU
567 * dbus/dbus-connection.c: add debug spew macros for debugging
568 thread locks; include config.h at top; fix deadlock in
569 dbus_connection_flush()
571 2003-05-08 Havoc Pennington <hp@pobox.com>
573 * dbus/dbus-spawn.c: s/_exit/exit/ because it was keeping gcov
574 data from getting written, and there wasn't a good reason to
577 * test/decode-gcov.c (mark_inside_dbus_build_tests): don't count
578 dbus_verbose lines in test coverage
579 (main): add list of functions sorted by # of untested blocks
580 to the coverage report
582 * dbus/dbus-mempool.c: put some test-only code in DBUS_BUILD_TESTS
584 * dbus/dbus-marshal.c (_dbus_marshal_test): extend test coverage
586 * dbus/dbus-message-handler.c (_dbus_message_handler_test):
589 * test/data/auth/cancel.auth-script: test canceling an
592 * dbus/Makefile.am: remove dbus-server-debug.[hc] for now, as they
593 aren't used. in CVS history if we end up needing them.
595 2003-05-04 Havoc Pennington <hp@pobox.com>
597 * dbus/dbus-message-handler.c (_dbus_message_handler_test): add
600 * dbus/dbus-marshal.c (_dbus_demarshal_string_array): fix this
601 function, which assumed length was in # of strings, not bytes
603 * dbus/dbus-message.c (_dbus_message_test): add tests for some
606 * dbus/dbus-connection.c
607 (_dbus_connection_queue_received_message): disable function for
608 now, we are only using it in test mode
610 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
611 remove a mistaken FIXME
613 2003-05-04 Havoc Pennington <hp@pobox.com>
615 * dbus/dbus-connection.c (dbus_connection_preallocate_send):
616 unlock mutex on successful return, patch from Anders Gustafsson
618 2003-05-04 Havoc Pennington <hp@pobox.com>
620 * dbus-glib-1.pc.in (Requires): fix dependencies, from
623 2003-05-04 Havoc Pennington <hp@pobox.com>
625 * tools/dbus-launch.c: implement
627 * bus/main.c (main), bus/bus.c (bus_context_new):
628 implement --print-pid and --fork
630 2003-05-03 Havoc Pennington <hp@redhat.com>
632 * dbus/dbus-address.c (dbus_parse_address): fix bug when a key in
633 the address had no value, and add to test suite. Fix and
634 regression test from Miloslav Trmac
636 2003-05-03 Havoc Pennington <hp@pobox.com>
638 * dbus/dbus-watch.c (dbus_watch_handle): warn and return if a
639 watch is invalid when handled
641 * tools/Makefile.am, tools/dbus-launch.c, tools/dbus-launch.1: add
642 dbus-launch utility to launch the bus from a shell script. Didn't
643 actually implement dbus-launch yet, it's just a placeholder still.
645 2003-05-03 Havoc Pennington <hp@pobox.com>
647 * bus/Makefile.am, bus/dbus-daemon-1.1.in: man page for the
648 daemon; also documents daemon config file, so replaces
649 doc/config-file.txt. Corrected some stuff from config-file.txt in
650 the process of moving it.
652 2003-05-03 Havoc Pennington <hp@pobox.com>
654 * tools/Makefile.am, tools/dbus-send.1, tools/dbus-monitor.1:
657 2003-05-03 Colin Walters <walters@verbum.org>
659 * dbus/dbus-sysdeps.c (fill_user_info): Test against
660 DBUS_UID_UNSET to determine whether to do a uid lookup or not.
662 * Makefile.am: Update to use new .pc versioning scheme.
664 2003-05-02 Havoc Pennington <hp@redhat.com>
666 * bus/system.conf.in: allow send/receive to/from message bus
669 2003-04-30 Havoc Pennington <hp@redhat.com>
671 * configure.in: print a note when building with unit tests and
674 2003-04-30 Havoc Pennington <hp@redhat.com>
676 * Makefile.am: add a check-local that complains if you didn't
677 configure with --enable-tests
679 2003-04-29 Havoc Pennington <hp@redhat.com>
681 * glib/dbus-gmain.c: docs cleanups
683 * dbus/dbus-types.h: add docs on int64 types
685 * dbus/dbus-memory.c: fix docs to avoid putting private API in
686 public API docs section
688 2003-04-29 Havoc Pennington <hp@redhat.com>
690 * dbus-1.pc.in, dbus-glib-1.pc.in: rename these from
691 dbus-1.0.pc.in, dbus-glib-1.0.pc.in. As these change with the
692 parallel install API version, not with the D-BUS package version.
694 * HACKING: move some of README over here
696 * README: updates, and document API/ABI policy
698 * configure.in: reindentation
700 2003-04-29 Havoc Pennington <hp@redhat.com>
702 * dbus/dbus.h: add "you have to define DBUS_API_SUBJECT_TO_CHANGE
703 to use this library" to be sure people have the right
706 2003-04-28 Havoc Pennington <hp@redhat.com>
708 * configure.in: add --enable-docs which by default is auto yes if
709 doxygen and db2html found, no otherwise; but can be forced on/off
711 * doc/Makefile.am: conditionalize whether to build docs on
714 2003-04-28 Havoc Pennington <hp@redhat.com>
720 * bus/system.conf.in: add <includedir>system.d</includedir>
722 * dbus/dbus-userdb.c (_dbus_user_database_lookup): fix bug when
723 username was provided but not uid
725 * bus/config-parser.c (struct BusConfigParser): keep track of
726 whether the parser is toplevel or was included; change some
727 of the error handling if it's included.
729 2003-04-27 Havoc Pennington <hp@pobox.com>
733 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
734 report correct status if we finish processing authentication
735 inside this function.
737 * bus/activation.c (try_send_activation_failure): use
738 bus_transaction_send_error_reply
740 * bus/connection.c (bus_connection_get_groups): return an error
741 explaining the problem
743 * bus/bus.c (bus_context_check_security_policy): implement
744 restriction here that inactive connections can only send the
745 hello message. Also, allow bus driver to send anything to
748 * bus/connection.c (bus_connection_complete): create the
749 BusClientPolicy here instead of on-demand.
750 (bus_connection_get_policy): don't return an error
752 * dbus/dbus-message.c (dbus_message_new_error_reply): allow NULL
753 sender field in message being replied to
755 * bus/bus.c (bus_context_check_security_policy): fix silly typo
756 causing it to return FALSE always
758 * bus/policy.c (bus_client_policy_check_can_send): fix bug where
759 we checked sender rather than destination
761 2003-04-25 Havoc Pennington <hp@redhat.com>
763 test suite is slightly hosed at the moment, will fix soon
765 * bus/connection.c (bus_connections_expire_incomplete): fix to
766 properly disable the timeout when required
767 (bus_connection_set_name): check whether we can remove incomplete
768 connections timeout after we complete each connection.
770 * dbus/dbus-mainloop.c (check_timeout): fix this up a bit,
771 probably still broken.
773 * bus/services.c (bus_registry_acquire_service): implement max
774 number of services owned, and honor allow/deny rules on which
775 services a connection can own.
777 * bus/connection.c (bus_connection_get_policy): report errors here
779 * bus/activation.c: implement limit on number of pending
782 2003-04-25 Havoc Pennington <hp@redhat.com>
784 * dbus/dbus-transport.c (_dbus_transport_get_unix_user): fix bug
785 where we used >= 0 instead of != DBUS_UID_UNSET.
787 2003-04-25 Havoc Pennington <hp@redhat.com>
789 * glib/dbus-gmain.c (remove_watch): fix for a crash when watches
790 were toggled without add/remove, fix from Anders Gustafsson
792 2003-04-24 Havoc Pennington <hp@redhat.com>
794 * test/data/valid-config-files/basic.conf: add <limit> tags to
797 * bus/config-parser.h, bus/config-parser.c, bus/bus.c: Implement
798 <limit> tag in configuration file.
800 2003-04-24 Havoc Pennington <hp@redhat.com>
802 * bus/dispatch.c: somehow missed some name_is
804 * dbus/dbus-timeout.c (_dbus_timeout_set_enabled)
805 (_dbus_timeout_set_interval): new
807 * bus/connection.c (bus_connections_setup_connection): record time
808 when each connection is first set up, and expire them after the
811 2003-04-24 Havoc Pennington <hp@redhat.com>
813 * dbus/dbus-message.c (dbus_message_name_is): rename
814 (dbus_message_service_is): rename
815 (dbus_message_sender_is): rename
816 (dbus_message_get_service): rename
818 2003-04-24 Havoc Pennington <hp@redhat.com>
820 * configure.in: add --enable-checks
822 * dbus/dbus-message.c (dbus_message_new): reverse name/service arguments
824 * dbus/dbus-connection.c (dbus_connection_preallocate_send): fix
826 (_dbus_connection_handler_destroyed_locked): move some private
827 functions into proper docs group
829 * dbus/dbus-internals.h: add _dbus_return_if_fail,
830 _dbus_return_val_if_fail
832 Throughout: use dbus_return_if_fail
834 2003-04-23 James Willcox <jwillcox@gnome.org>
837 * glib/dbus-gmain.c: (add_timeout), (wakeup_main), (create_source),
838 (dbus_connection_setup_with_g_main),
839 (dbus_server_setup_with_g_main):
840 * glib/test-dbus-glib.c: (main):
841 * glib/test-thread-client.c: (main):
842 * glib/test-thread-server.c: (new_connection_callback), (main):
843 * tools/dbus-monitor.c: (main):
845 Added a GMainContext argument to dbus_connection_setup_with_g_main()
846 and dbus_server_setup_with_g_main().
848 2003-04-20 Havoc Pennington <hp@pobox.com>
850 * doc/dbus-specification.sgml: document the restrictions on
851 message and service names
853 2003-04-22 Havoc Pennington <hp@redhat.com>
855 * dbus/dbus-message.c, dbus/dbus-marshal.c: add 64-bit integer
856 support, and do some code cleanups to share more code and
857 speed up array marshal/demarshal.
859 * dbus-1.0.pc.in (Cflags): put libdir include file in cflags
861 * configure.in: generate dbus-arch-deps.h
863 * dbus/dbus-protocol.h (DBUS_TYPE_INT64, DBUS_TYPE_UINT64): add
866 2003-04-22 Havoc Pennington <hp@redhat.com>
868 * test/data/valid-messages/opposite-endian.message: fix test
869 to use proper type for rply field
871 * test/data/invalid-messages: add tests for below validation
873 * dbus/dbus-message.c (decode_header_data): validate field types,
874 and validate that named fields are valid names
875 (decode_name_field): consider messages in the
876 org.freedesktop.Local. namespace to be invalid.
878 * dbus/dbus-string.c (_dbus_string_validate_name): new
880 2003-04-19 Havoc Pennington <hp@pobox.com>
882 * bus/driver.c (bus_driver_handle_hello): check limits and
883 return an error if they are exceeded.
885 * bus/connection.c: maintain separate lists of active and inactive
886 connections, and a count of each. Maintain count of completed
887 connections per user. Implement code to check connection limits.
889 * dbus/dbus-list.c (_dbus_list_unlink): export
891 * bus/bus.c (bus_context_check_security_policy): enforce a maximum
892 number of bytes in the message queue for a connection
894 2003-04-18 Havoc Pennington <hp@pobox.com>
896 * dbus/dbus-auth.c (record_mechanisms): memleak fixes
898 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): fix some
901 * dbus/dbus-keyring.c (add_new_key): fix a memleak, and
902 on realloc be sure to update the pointer in the keyring
904 * dbus/dbus-string.c (_dbus_string_zero): compensate for align
905 offset to avoid writing to unallocated memory
907 * dbus/dbus-auth.c (process_rejected): return FALSE if we fail to
908 try the next mechanism, so we properly handle OOM
910 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): fix double-free
912 (_dbus_keyring_new): fix OOM bug
913 (_dbus_keyring_new_homedir): always set error; impose a maximum
914 number of keys we'll load from the file, mostly to speed up the
915 test suite and make its OOM checks more useful, but also for
918 * dbus/dbus-auth.c (process_error_server): reject authentication
919 if we get an error from the client
920 (process_cancel): on cancel, send REJECTED, per the spec
921 (process_error_client): send CANCEL if we get an error from the
924 2003-04-18 Havoc Pennington <hp@pobox.com>
926 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix UMR in verbose
929 * dbus/dbus-auth.c (handle_client_data_cookie_sha1_mech): fix OOM
932 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): only whine
933 about DBUS_TEST_HOMEDIR once
935 * bus/Makefile.am (TESTS_ENVIRONMENT): put DBUS_TEST_HOMEDIR in
938 * bus/dispatch.c (bus_dispatch_sha1_test): actually load sha1
939 config file so we test the right thing
941 Throughout: assorted docs improvements
943 2003-04-18 Havoc Pennington <hp@pobox.com>
945 * glib/dbus-gmain.c: adapt to watch changes
947 * bus/bus.c, bus/activation.c, etc.: adjust to watch changes
949 * dbus/dbus-server.h: remove dbus_server_handle_watch
951 * dbus/dbus-connection.h: remove dbus_connection_handle_watch
953 * dbus/dbus-watch.c (dbus_watch_handle): change DBusWatch to work
954 like DBusTimeout, so we don't need dbus_connection_handle_watch
957 2003-04-17 Havoc Pennington <hp@redhat.com>
959 * dbus/dbus-userdb.c, dbus/dbus-sysdeps.c: redo all the passwd
960 database usage so it all goes via the DBusUserDatabase cache.
962 2003-04-17 Havoc Pennington <hp@redhat.com>
964 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix logic so that if
965 there was an OOM watch we skipped, we always return TRUE so we
966 iterate again to have a look at it again. Fixes test suite hang.
967 Code rearrangement also lets us lose some memset and only iterate
970 * bus/driver.c (bus_driver_handle_message): sense of test for
973 2003-04-16 Havoc Pennington <hp@pobox.com>
975 * doc/dbus-specification.sgml: make spec say serials are unsigned
977 * dbus/dbus-message.h: change message serials to unsigned
979 * dbus/dbus-connection.c: adapt to message serials being unsigned
981 2003-04-15 Havoc Pennington <hp@pobox.com>
983 * bus/bus.c: create and keep around a shared DBusUserDatabase
986 * bus/connection.c (bus_connection_get_groups): don't cache
987 groups for user in the connection object, since user database
988 object now does that.
990 2003-04-16 Havoc Pennington <hp@redhat.com>
992 * dbus/dbus-message.c (_dbus_message_add_size_counter): keep a
993 list of size counters
994 (_dbus_message_loader_putback_message_link): put back a popped link
996 * dbus/dbus-connection.c
997 (dbus_connection_set_max_live_messages_size): rename
999 (dbus_connection_get_outgoing_size): get size of outgoing
1001 (_dbus_connection_set_connection_counter): remove this cruft
1003 2003-04-14 Havoc Pennington <hp@redhat.com>
1005 * dbus/dbus-userdb.c: user database abstraction, mostly to get
1006 caching, but at some point we might want to be able to use a
1009 * bus/dispatch.c (bus_dispatch_sha1_test): add a test that uses
1010 SHA1 conf file to test the sha1 auth mechanism, since the regular
1011 test always uses EXTERNAL when available.
1014 test/data/valid-config-files/debug-allow-all-sha1.conf.in:
1015 add conf file that requires use of sha1 auth
1017 2003-04-13 Havoc Pennington <hp@pobox.com>
1019 * tools/dbus-send.c, tools/dbus-monitor.c: two utility programs
1020 from Philip Blundell to send messages and monitor them.
1022 2003-04-13 Havoc Pennington <hp@pobox.com>
1024 * dbus/dbus-mainloop.c: fix some reentrancy issues by refcounting
1027 * test/data/valid-config-files/debug-allow-all.conf.in: allow all
1030 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
1031 fix to only recover unused bytes if we're already authenticated
1032 (_dbus_transport_get_is_authenticated): fix to still mark us
1033 authenticated if there are unused bytes.
1035 * bus/dispatch.c: implement security policy checking
1037 * bus/connection.c (bus_transaction_send_from_driver): new
1039 * bus/bus.c (bus_context_check_security_policy): new
1041 * bus/dispatch.c (send_service_nonexistent_error): delete this,
1042 now we just set the DBusError and it gets converted to an error
1045 * bus/connection.c (allow_user_function): enable code using actual
1046 data from the config file
1048 * bus/policy.c (list_allows_user): handle wildcard rules for
1049 user/group connection perms
1051 2003-04-13 Havoc Pennington <hp@pobox.com>
1053 * bus/config-parser.c: Load up the BusPolicy and BusPolicyRules
1055 * dbus/dbus-sysdeps.c (_dbus_get_user_id): new function
1057 * bus/policy.c (bus_policy_append_mandatory_rule)
1058 (bus_policy_append_default_rule, bus_policy_append_user_rule)
1059 (bus_policy_append_group_rule): new functions
1061 2003-04-12 Havoc Pennington <hp@pobox.com>
1063 * bus/config-parser.c (bus_config_parser_new): fix a memleak
1065 * dbus/dbus-sysdeps.c: change DBusCredentials to use longs for
1066 the pid/gid/uid, just for paranoia.
1068 * test/break-loader.c (randomly_do_n_things): find a byte
1069 containing a type code, and randomly change it to a different
1072 2003-04-12 Havoc Pennington <hp@pobox.com>
1074 * bus/policy.h: change BusPolicy to be the thing from the config
1075 file, and rename old BusPolicy to BusClientPolicy
1077 * bus/bus.c, bus/connection.c, bus/config-parser.c: change to
1078 match change in how policy works
1080 * dbus/dbus-internals.h: mark assert_not_reached as
1081 __attribute((noreturn))__
1083 2003-04-11 Havoc Pennington <hp@redhat.com>
1085 * doc/dbus-specification.sgml: fix a spot with the wrong name for
1086 the broadcast service. Use boolean return for ServiceExists.
1088 2003-04-11 Havoc Pennington <hp@redhat.com>
1090 * configure.in: add another directory to look for qt in.
1092 2003-04-11 Havoc Pennington <hp@redhat.com>
1094 * AUTHORS: add Colin Walters
1096 2003-04-11 Havoc Pennington <hp@redhat.com>
1102 2003-04-11 Havoc Pennington <hp@redhat.com>
1104 * bus/messagebus.in: remove pid file when stopping the
1105 message bus, since the bus won't have privileges to remove it
1108 2003-04-11 Havoc Pennington <hp@redhat.com>
1110 * bus/bus.c (bus_context_new): move credentials change after
1113 2003-04-11 Havoc Pennington <hp@pobox.com>
1115 * test/decode-gcov.c: add "below average functions" to the
1116 coverage report, and change how some of the code works.
1118 * bus/test-main.c: bracket some stuff in DBUS_BUILD_TESTS so it's
1119 not in the coverage stats.
1121 * test/test-service.c (main): use _dbus_verbose not fprintf in a
1122 couple places so running the test suite doesn't result in megaspam.
1124 2003-04-11 Havoc Pennington <hp@pobox.com>
1126 * bus/dispatch.c (check_existent_service_activation): accept a no
1127 memory error in a place we didn't before
1129 * bus/test.c (bus_test_run_everything): remove hacky "do it twice
1130 in case the first one failed," since the test suite is less
1133 2003-04-10 Havoc Pennington <hp@pobox.com>
1135 * bus/dispatch.c (check_segfault_service_activation): add test
1136 for launching an executable that just crashes.
1138 * test/test-segfault.c (main): try setting coredumpsize to 0 so we
1139 don't leave a million cores. We'll see how portable this is.
1141 2003-04-10 Havoc Pennington <hp@pobox.com>
1143 * dbus/dbus-spawn.c (_dbus_spawn_async_with_babysitter): move all
1144 the possible parent failures before we fork, so that we don't
1145 fail to create a babysitter after creating the child.
1147 * bus/activation.c (bus_activation_activate_service): kill child
1148 if we don't successfully complete the activation.
1150 2003-04-10 Havoc Pennington <hp@redhat.com>
1152 * dbus/dbus-connection.c (dbus_connection_flush): don't spin on
1153 the connection if it's disconnected
1155 * bus/activation.c (bus_activation_service_created): use new
1156 transaction features to roll back removal of pending activation if
1157 we don't successfully create the service after all. Don't remove
1158 pending activation if the function fails.
1160 * dbus/dbus-list.c (_dbus_list_insert_before_link)
1161 (_dbus_list_insert_after_link): new code to facilitate
1164 * dbus/dbus-hash.c (_dbus_hash_table_insert_string_preallocated):
1165 new functionality, so we can preallocate the ability to insert
1168 * bus/connection.c (bus_transaction_add_cancel_hook): new function
1169 allowing us to put custom hooks in a transaction to be used for
1170 cancelling said transaction
1172 * doc/dbus-specification.sgml: add some discussion of secondary
1173 service owners, and disallow zero-length service names
1175 * bus/services.c (bus_registry_acquire_service): new function,
1176 splits out part of bus_driver_handle_acquire_service() and fixes
1177 a bug where we didn't remove the service doing the acquiring
1178 from the secondary queue if we failed to remove the current owner
1179 from the front of the queue.
1181 2003-04-10 Alexander Larsson <alexl@redhat.com>
1183 * doc/dbus-specification.sgml:
1184 s/org.freedesktop.Broadcast/org.freedesktop.DBus.Broadcast/
1186 2003-04-10 Alexander Larsson <alexl@redhat.com>
1191 Added files to cvsignore
1193 * dbus/dbus-message.h:
1194 * dbus/dbus-message.c: (dbus_message_iter_get_named):
1195 Make get_named() take two out argument and return a boolean.
1196 (dbus_message_iter_get_args_valist):
1197 Update usage of get_named().
1198 (dbus_message_iter_append_byte):
1200 (dbus_message_iter_append_named)
1202 (message_iter_test), (check_message_handling_type), (_dbus_message_test):
1205 2003-04-10 Alexander Larsson <alexl@redhat.com>
1207 * dbus/dbus-marshal.[ch]:
1208 Add array_type_pos argument to _dbus_marshal_validate_arg.
1209 Let you pass a NULL end_pos to _dbus_marshal_validate_type.
1211 * dbus/dbus-message.[ch]:
1212 Multi-dimensional arrays have full type specification in the
1213 outermost array. Iter code re-arranged to handle this.
1214 Added some more iter tests.
1216 * doc/dbus-specification.sgml:
1219 Update new array encoding description.
1220 Correct DBUS_SERVICE_FLAGS_REPLACE_EXISTING description.
1222 * test/data/invalid-messages/array-with-mixed-types.message:
1223 * test/data/valid-messages/array-of-array-of-uint32.message:
1224 Change to the new array format.
1226 * test/data/invalid-messages/too-short-dict.message:
1229 * test/data/valid-messages/recursive-types.message:
1230 Fix up and extend test.
1232 2003-04-10 Havoc Pennington <hp@pobox.com>
1234 * bus/dispatch.c: lots of fixes
1236 * dbus/dbus-mainloop.c (_dbus_loop_dispatch): export
1237 (_dbus_loop_iterate): remove old "quit if no callbacks" code,
1238 that was crack, broke the test service.
1240 * dbus/dbus-transport.c (_dbus_transport_open): fix error
1241 handling to avoid piling up errors if we get a failure on the
1244 * dbus/dbus-internals.c (_dbus_real_assert_not_reached): include
1245 pid in assertion failures.
1247 * dbus/dbus-mainloop.c (_dbus_loop_iterate): use static arrays up
1248 to some fixed size of file descriptor array. Don't return TRUE
1249 anytime a timeout exists, that led to lots of busy loop silliness
1252 2003-04-09 Havoc Pennington <hp@redhat.com>
1254 * dbus/dbus-mainloop.c (check_timeout): fix timeouts, I thought
1255 I'd checked this in earlier but hadn't.
1257 2003-04-09 Havoc Pennington <hp@redhat.com>
1259 * bus/dispatch.c (bus_dispatch_test): get a bit further through
1260 the activation test (man this is getting old!)
1262 2003-04-09 Havoc Pennington <hp@redhat.com>
1264 * test/test-utils.c: use dispatch status function to fix this up
1266 * bus/connection.c (connection_watch_callback): don't dispatch
1268 (connection_timeout_callback): don't dispatch from here
1269 (bus_connections_setup_connection): set the dispatch status function
1270 (bus_connection_disconnected): unset it
1272 * dbus/dbus-mainloop.c (_dbus_loop_queue_dispatch): new function
1273 used to add a connection to be dispatched
1274 (_dbus_loop_iterate): do the dispatching at the end of each
1277 * dbus/dbus-connection.c
1278 (dbus_connection_set_dispatch_status_function): new function
1279 allowing us to fix up main loop usage
1280 (_dbus_connection_last_unref): free all the various function
1282 (dbus_connection_dispatch): call the DispatchStatusFunction
1283 whenever this function returns
1284 (dbus_connection_handle_watch): call DispatchStatusFunction
1285 (dbus_connection_send_with_reply_and_block): call DispatchStatusFunction
1286 (reply_handler_timeout): call DispatchStatusFunction
1287 (dbus_connection_flush): call DispatchStatusFunction
1289 2003-04-09 Havoc Pennington <hp@redhat.com>
1291 * dbus/dbus-bus.c (dbus_bus_register): fix up error handling and
1294 * bus/dispatch.c (check_service_activated): fix bug in test
1296 * dbus/dbus-mainloop.c (check_timeout): fix this up
1298 * dbus/dbus-internals.c (_dbus_verbose_real): include PID in
1299 verbose output so we can sort out output from different processes,
1300 e.g. in the activation case.
1302 2003-04-08 Colin Walters <walters@gnu.org>
1304 * bus/bus.c (struct BusContext) [pidfile]: New member, to store
1306 (bus_context_new): Set it.
1307 (bus_context_unref): Use it to delete the pid file.
1309 2003-04-08 Havoc Pennington <hp@redhat.com>
1311 * test/data/invalid-messages/array-with-mixed-types.message:
1312 regression test that fails for the moment
1314 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): reorder
1315 tests for convenience
1317 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): don't allow
1318 array of nil, it broke things.
1320 * test/data/invalid-messages/array-of-nil.message: regression test
1322 * test/data/valid-messages/array-of-array-of-uint32.message:
1323 happened to write this so added it to suite
1325 2003-04-08 Havoc Pennington <hp@redhat.com>
1327 * bus/driver.c (bus_driver_handle_acquire_service): init
1328 retval/reply before checking name
1330 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add a
1331 recursion depth argument
1333 * dbus/dbus-message.h (struct DBusMessageIter): put some padding
1334 in the public struct for future extension
1336 * dbus/dbus-message-builder.c (_dbus_message_data_load): fix
1339 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix a verbose
1342 * doc/dbus-specification.sgml: fix typo
1344 2003-04-08 Alexander Larsson <alexl@redhat.com>
1346 Implemented recursive types, named types and new-style iters
1349 * glib/test-thread-client.c: (thread_func):
1350 * glib/test-thread-server.c: (handle_test_message):
1351 * test/test-service.c: (handle_echo):
1360 * dbus/dbus-internals.c: (_dbus_type_to_string):
1361 Update for new types.
1363 * dbus/dbus-marshal.[ch]:
1364 Implement recursive types and the new marshalling format.
1365 Remove hardcoded dict marshalling.
1366 Marshal named types.
1368 * dbus/dbus-message-builder.c:
1370 Remove references to old types
1372 * dbus/dbus-message.[ch]:
1373 New non-refcounted iter API that supports recursive iters.
1374 Use iters for appending, including support for recursive
1376 Add byte and named type support.
1377 Update everything to new marshalling formats.
1378 Add tests for new API.
1380 * dbus/dbus-protocol.h:
1381 Remove old array types.
1382 Add types: BYTE, ARRAY, DICT, NAMED
1384 * dbus/dbus-string.c:
1385 * dbus/dbus-sysdeps.c:
1386 Make parse_double locale safe.
1388 * dbus/dbus-test-main.c:
1394 * doc/dbus-specification.sgml:
1397 * test/data/incomplete-messages/missing-body.message:
1398 * test/data/invalid-messages/bad-boolean.message:
1399 * test/data/invalid-messages/bad-boolean-array.message:
1400 * test/data/invalid-messages/boolean-array-length-too-long.message-raw:
1401 * test/data/invalid-messages/boolean-has-no-value.message-raw:
1402 * test/data/invalid-messages/too-short-dict.message:
1403 * test/data/valid-messages/dict-simple.message:
1404 * test/data/valid-messages/dict.message:
1405 * test/data/valid-messages/emptiness.message:
1406 * test/data/valid-messages/lots-of-arguments.message:
1407 * test/data/valid-messages/no-padding.message:
1408 * test/data/valid-messages/recursive-types.message:
1409 Add missing NAME fields
1410 Fix up dicts & arrays
1412 * test/data/invalid-messages/dict-with-nil-value.message:
1413 Removed, this is not invalid anymore.
1415 * test/data/valid-messages/recursive-types.message:
1416 Add new test for deeply recursive types.
1418 2003-04-07 Havoc Pennington <hp@pobox.com>
1420 * bus/driver.c (bus_driver_handle_acquire_service): return an
1421 error if you try to acquire a service that starts with ':'
1423 2003-04-07 Havoc Pennington <hp@redhat.com>
1425 * doc/dbus-specification.sgml: require that base service names
1426 start with ':' and that the base service is created/deleted
1427 as first and last things a connection does on the bus
1429 * bus/dispatch.c (check_existent_service_activation): lots more
1430 work on the activation test; it doesn't fully pass yet...
1432 * test/test-service.c (main): fix so we don't memleak the
1433 connection to the message bus
1434 (filter_func): accept a message asking us to exit
1436 2003-04-06 Havoc Pennington <hp@pobox.com>
1438 * qt/Makefile.am (dbusinclude_HEADERS): install dbus-qt.h,
1441 * configure.in: fixes to Qt detection from Colin Walters
1443 * doc/Makefile.am: Only remove generated docbook dirs if they
1444 exist, from Colin Walters
1446 * dbus/dbus-bus.c: change how we set well-known connections to
1447 NULL, so that it works if a single connection is stored in
1448 two well-known array slots.
1450 * test/Makefile.am: remove a lot of stuff that isn't immediately
1451 useful, it's in CVS history if we want it.
1453 * test/test-service.c: use dbus-mainloop instead of that
1456 2003-04-06 Havoc Pennington <hp@pobox.com>
1458 * dbus/Makefile.am: split lists of sources into stuff that goes in
1459 the library, util functions that go in the lib and are also used
1460 elsewhere, and util functions that are used in tests/daemon but
1461 don't go in the lib.
1463 * dbus/dbus-mainloop.h, dbus/dbus-mainloop.c: move bus/loop.[hc]
1464 here so it can be used in test binaries also
1466 2003-04-06 Havoc Pennington <hp@pobox.com>
1468 * dbus/dbus-sysdeps.c (_dbus_become_daemon): write the pidfile
1469 here in the parent process, so we can return an error if it
1470 fails. Also, move some of the code into the child so the parent
1471 is less hosed if we fail midway through.
1473 * bus/bus.c (bus_context_new): move pidfile detection further up
1474 in the function, before we start overwriting sockets and such.
1476 * bus/messagebus.in: adjust this a bit, not sure if it will work.
1478 * configure.in: add --with-system-pid-file and --with-system-socket
1480 2003-04-06 Colin Walters <walters@verbum.org>
1482 * configure.in (DBUS_SYSTEM_PID_FILE): New variable.
1484 * bus/system.conf.in: Declare a pidfile.
1486 * bus/bus.c (bus_context_new): Test for an existing pid file, and
1487 create one (if appropriate).
1489 * bus/config-parser.c (enum ElementType) [ELEMENT_PIDFILE]: New.
1490 (struct BusConfigParser) [pidfile]: New.
1491 (element_type_to_name, merge_included, start_busconfig_child)
1492 (bus_config_parser_end_element, bus_config_parser_content): Handle it.
1493 (bus_config_parser_unref): Free it.
1494 (bus_config_parser_get_pidfile): New function.
1496 * bus/config-parser.h (_dbus_write_pid_file): Prototype.
1498 * dbus/dbus-errors.h (DBUS_ERROR_PIDFILE_EXISTS): New error.
1500 * dbus/dbus-sysdeps.c (_dbus_write_pid_file): New function.
1502 * dbus/dbus-sysdeps.h: Prototype it.
1504 2003-04-06 Havoc Pennington <hp@pobox.com>
1506 * bus/bus.c (bus_context_new): print the address in here, rather
1507 than in main(), because we need to do it before forking the daemon
1509 * bus/dispatch.c (send_service_nonexistent_error): set the sender
1510 on the service nonexistent error
1512 * bus/driver.c (bus_driver_handle_acquire_service): set the
1513 sender on the AcquireService reply
1515 * test/data/valid-config-files/debug-allow-all.conf.in: Make test
1516 server also listen on a UNIX socket so services can connect to it.
1518 2003-04-06 Havoc Pennington <hp@pobox.com>
1520 * dbus/dbus-threads.c: Redo how the fake debug mutexes are done
1521 so it detects deadlocks and also we actually init threads when
1524 2003-04-06 Havoc Pennington <hp@pobox.com>
1526 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
1527 save the domain socket name, and unlink it when we disconnect the
1528 server. Means that at least when we exit normally, we won't leave
1529 a bunch of junk in /tmp
1531 * dbus/dbus-transport-unix.c
1532 (_dbus_transport_new_for_domain_socket): code cleanup (nicer
1533 memory management). (I was making a real change here but then
1536 2003-04-06 Havoc Pennington <hp@pobox.com>
1538 * bus/bus.c (bus_context_new): fix wrong handling of
1539 server_data_slot_unref() in the error case.
1541 * dbus/dbus-internals.h (_dbus_assert): change so it passes
1542 "(condition) != 0" to _dbus_real_assert so that
1543 "_dbus_assert (pointer)" doesn't cause a warning
1545 * bus/main.c (main): accept --print-address option to print out
1546 the message bus address
1548 * dbus/dbus-sysdeps.c (_dbus_generate_random_ascii): export this
1550 * dbus/dbus-transport.c (_dbus_transport_open): special error for
1551 "tmpdir" option to unix: address on client side
1553 * dbus/dbus-server.c (dbus_server_listen): handle "tmpdir" option
1556 * configure.in (TEST_SOCKET_DIR): locate a temporary directory
1557 we can use to create sockets in the test suite.
1559 * bus/main.c (signal_handler): on SIGTERM, exit the daemon
1560 cleanly. To be used for testing.
1562 * dbus/dbus-spawn.c (babysit): use _dbus_set_signal_handler()
1564 * dbus/dbus-sysdeps.c (_dbus_set_signal_handler): new
1566 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
1567 handle trying to call this when there's no servers active
1569 2003-04-05 Havoc Pennington <hp@pobox.com>
1575 2003-04-05 Havoc Pennington <hp@pobox.com>
1577 * bus/bus.c (setup_server): fix this so dbus-daemon-1 doesn't
1578 crash on startup. Need to get "try starting the daemon"
1579 in the test suite I guess. ;-)
1581 * dbus/dbus-server.h, dbus/dbus-server.c: remove the stuff that
1582 tracked the number of open connections; it's better done in
1583 application-specific code as you want it to span all servers etc.
1585 2003-04-05 Havoc Pennington <hp@pobox.com>
1587 * bus/Makefile.am (install-data-hook): add missing DESTDIR,
1588 patch from Colin Walters
1590 2003-04-05 Havoc Pennington <hp@pobox.com>
1592 * doc/config-file.txt (Elements): fix docs of <auth> to reflect
1593 reality; in fact multiple mechanisms are allowed.
1595 * dbus/dbus-internals.c (_dbus_real_assert)
1596 (_dbus_real_assert_not_reached): move guts of _dbus_assert() and
1597 _dbus_assert_not_reached() into functions, so that they don't show
1598 up in basic block counts for test coverage, and don't use up as
1599 much disk space. Does mean slower execution speed though, so
1600 assumes --disable-asserts is the normal production case.
1602 2003-04-05 Havoc Pennington <hp@pobox.com>
1604 * test/Makefile.am (dist-hook): also dist *.in files
1610 2003-04-05 Havoc Pennington <hp@pobox.com>
1612 * dbus/dbus-string.c: docs warning
1614 * dbus/dbus-spawn.c: missing docs
1616 * dbus/dbus-memory.c (struct ShutdownClosure): missing docs
1618 2003-04-05 Havoc Pennington <hp@pobox.com>
1620 * bus/loop.c (bus_loop_iterate): fix the timeout code, using
1623 * dbus/dbus-spawn.c (_dbus_babysitter_unref): set sitter_pid
1624 to -1 once we've reaped the babysitter
1625 (_dbus_babysitter_handle_watch): do as much work as we can, not
1628 * bus/activation.c: add code using DBusBabysitter so that we
1629 handle it when a service fails to start up properly.
1630 (bus_activation_service_created): don't remove the activation
1631 entries as we go, just let them get removed when we free the pending
1632 activation. Unref reply messages after sending them.
1634 2003-04-05 Havoc Pennington <hp@pobox.com>
1636 * test/decode-gcov.c (main): print per-directory stats in the report
1638 * Makefile.am (coverage-report.txt): don't include test/* in gcov stats
1640 2003-04-05 Havoc Pennington <hp@pobox.com>
1642 * Makefile.am (coverage-report.txt): add target "coverage-report.txt"
1644 * test/decode-gcov.c: hack up a little program to suck data
1645 out of gcov files. Yes this is sort of silly.
1647 * configure.in: define something in config.h and do an
1648 AM_CONDITIONAL when gcov is enabled
1650 2003-04-04 Havoc Pennington <hp@redhat.com>
1652 * dbus/dbus-spawn.c, dbus/dbus-spawn.h: Change dbus_spawn to
1653 return a "babysitter" object that is used to monitor the status of
1654 the spawned process and reap it when required.
1656 * test/test-segfault.c, test/test-exit.c,
1657 test/test-sleep-forever.c: binaries that do various lame things,
1658 used in the test suite.
1660 * dbus/dbus-sysdeps.c: kill _dbus_errno_to_string()
1662 2003-04-03 Havoc Pennington <hp@pobox.com>
1664 * dbus/dbus-spawn.c: Move dbus-spawn into a separate file
1665 in preparation for modifying it, dbus-sysdeps is getting
1668 2003-04-03 Havoc Pennington <hp@redhat.com>
1670 * bus/loop.h, bus/loop.c: make the mainloop an object so we can
1673 * bus/*.[hc]: adapt to mainloop change
1675 2003-04-03 Havoc Pennington <hp@redhat.com>
1677 * bus/activation.c (load_directory): fix up memleaks
1678 (bus_activation_entry_free): free the entry
1680 * dbus/dbus-bus.c (dbus_bus_acquire_service): return an error if
1681 we get one from the message bus; fix memleaks.
1683 * dbus/dbus-message.c (dbus_set_error_from_message): new function
1685 2003-04-03 Havoc Pennington <hp@pobox.com>
1687 * bus/config-parser.c (bus_config_parser_unref): free
1688 list of mechanisms, bug discovered by test suite enhancements
1689 (putting system.conf and session.conf into suite)
1691 * test/Makefile.am, test/test-service.c: add placeholder for a
1692 test service that we'll activate as part of test suite. Doesn't
1695 * dbus/dbus-sysdeps.c (_dbus_setenv): support unsetenv by
1696 setting NULL value, and use system malloc not dbus_malloc()
1697 when we have unavoidable memleakage.
1699 * dbus/dbus-bus.c (dbus_bus_get): fix bug where bus type of 0
1700 didn't work, and support DBUS_BUS_ACTIVATION.
1702 * bus/activation.c (child_setup): pass our well-known bus type to
1705 * bus/config-parser.c: support <type> to specify well-known type
1707 * doc/dbus-specification.sgml: document the env variables to
1708 locate well-known buses and find service activator
1710 2003-04-02 Havoc Pennington <hp@redhat.com>
1712 * test/Makefile.am (all-local): add a rule to copy tests to
1713 builddir, so we can have generated tests. Use this to remove the
1714 silly hack for testing system.conf and session.conf. Will use this
1715 shortly to generate .service files pointing to test binaries.
1717 2003-04-02 Havoc Pennington <hp@redhat.com>
1719 * dbus/dbus-string.c (set_length): fix a bug - we allocated max of
1720 current alloc and needed new length, not max of the doubled
1721 allocation and needed new length. Also, when building tests,
1722 don't do the double-allocation stuff, just realloc every time.
1724 2003-04-02 Havoc Pennington <hp@redhat.com>
1726 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): include filenames
1728 (_dbus_string_get_dirname): new
1729 (_dbus_sysdeps_test): new
1730 (_dbus_directory_open): include dirnames in error messages
1732 * bus/config-parser.c: interpret <include> and <includedir> and
1733 <servicedir> relative to config file location if the given
1734 filename is not absolute.
1736 * dbus/dbus-string.c (_dbus_string_find_byte_backward): new
1738 2003-04-02 Havoc Pennington <hp@redhat.com>
1740 * bus/connection.c (bus_transaction_send_error_reply): set sender
1741 service for the error, and unref the reply on success
1743 * bus/activation.c: convert to use BusTransaction so OOM can be
1745 (bus_activation_service_created): set sender of the message
1747 2003-04-01 Havoc Pennington <hp@redhat.com>
1749 * bus/config-parser.c, bus/bus.c: implement <servicedir> and
1750 <includedir> (at least mostly)
1752 * dbus/dbus-sysdeps.c (_dbus_change_identity): set the group ID
1753 first, then the user ID
1755 2003-04-01 Havoc Pennington <hp@pobox.com>
1757 * dbus/dbus-server.c (dbus_server_set_auth_mechanisms): new
1760 * dbus/dbus-auth.c (_dbus_auth_set_mechanisms): new
1762 * dbus/dbus-internals.c (_dbus_dup_string_array): new function
1764 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): chmod the
1765 socket 0777, and unlink any existing socket.
1767 * bus/bus.c (bus_context_new): change our UID/GID and fork if
1768 the configuration file so specifies; set up auth mechanism
1771 * bus/config-parser.c (bus_config_parser_content): add support
1772 for <fork> option and fill in code for <auth>
1774 * bus/system.conf.in: add <fork/> to default configuration,
1775 and limit auth mechanisms to EXTERNAL
1777 * doc/config-file.txt (Elements): add <fork>
1779 * dbus/dbus-sysdeps.c (_dbus_become_daemon): new function
1780 (_dbus_change_identity): new function
1782 2003-03-31 Havoc Pennington <hp@redhat.com>
1784 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket)
1785 (_dbus_listen_unix_socket): fix off-by-one error in null
1786 termination spotted by Nalin
1788 2003-03-31 Havoc Pennington <hp@redhat.com>
1790 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): allow setting
1791 DBUS_TEST_HOMEDIR when tests are enabled, so we can test without
1792 having a real home directory available.
1794 2003-03-31 Havoc Pennington <hp@redhat.com>
1796 * bus/Makefile.am (install-data-hook): create /var/run/dbus
1798 * bus/messagebus.in: add init script for Red Hat /etc/init.d
1800 * configure.in: add support for specifying a style of init script
1803 2003-03-31 Havoc Pennington <hp@redhat.com>
1805 Fix some annoying DBusString API and fix all affected code.
1807 * dbus/dbus-string.c (_dbus_string_init): get rid of annoying
1809 (_dbus_string_get_data): change to return string instead of using
1811 (_dbus_string_get_const_data): ditto
1812 (_dbus_string_get_data_len): ditto
1813 (_dbus_string_get_const_data_len): ditto
1815 2003-03-31 Havoc Pennington <hp@redhat.com>
1817 * bus/main.c (main): fix up the command line arguments to be nicer
1819 2003-03-31 Havoc Pennington <hp@redhat.com>
1821 * dbus/Makefile.am (INCLUDES): use EXPANDED_LOCALSTATEDIR to
1822 define DBUS_SYSTEM_BUS_PATH as we want to compile in the same
1823 final location that lands in the config file
1825 * bus/config-loader-expat.c (bus_config_load): fix type of
1828 * doc/TODO: remove TODO item for dbus_bus_get()
1830 * dbus/dbus-bus.c (bus_data_free): add missing lock/unlock
1832 2003-03-31 Havoc Pennington <hp@pobox.com>
1834 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_domain_socket)
1835 (_dbus_transport_new_for_tcp_socket): these didn't need the "server"
1836 argument since they are always client side
1838 * dbus/dbus-server.c (dbus_server_get_address): new function
1840 * bus/main.c (main): take the configuration file as an argument.
1842 * test/data/valid-config-files/debug-allow-all.conf: new file to
1843 use with dispatch.c tests for example
1845 * bus/test-main.c (main): require test data dir
1847 * bus/bus.c (bus_context_new): change this to take a
1848 configuration file name as argument
1850 * doc/config-file.txt (Elements): add <servicedir>
1852 * bus/system.conf, bus/session.conf: new files
1854 * dbus/dbus-bus.c (dbus_bus_get): look for system bus on
1855 well-known socket if none set
1857 * configure.in: create system.conf and session.conf
1859 2003-03-30 Havoc Pennington <hp@pobox.com>
1861 * bus/config-parser.c: hacking
1863 * dbus/dbus-memory.c: don't use DBusList for the list of stuff
1864 to shut down, since it could cause weirdness with the DBusList
1867 * dbus/dbus-list.c (_dbus_list_test): add tests for the
1868 link-oriented stack routines
1869 (alloc_link): free the mempool if the first alloc from it fails
1871 * dbus/dbus-mempool.c (struct DBusMemBlock): fix alignment issue
1873 * dbus/dbus-string.c (UNICODE_VALID): sync new version of this
1875 (_dbus_string_skip_white): new
1877 * doc/config-file.txt (Elements): add <includedir>
1879 2003-03-28 Havoc Pennington <hp@pobox.com>
1881 * dbus/dbus-string.c (_dbus_string_copy_data_len)
1882 (_dbus_string_copy_data): new functions
1884 2003-03-28 Anders Carlsson <andersca@codefactory.se>
1886 * dbus/dbus-bus.c: (bus_data_free), (dbus_bus_get):
1890 * dbus/dbus-memory.c:
1893 2003-03-28 Havoc Pennington <hp@pobox.com>
1895 * bus/test.c (bus_test_flush_bus): remove the sleep from here,
1896 I think it may have just been superstition. Not sure.
1898 * dbus/dbus-string.c (_dbus_string_base64_decode): catch some OOM
1899 failures that were not being handled.
1901 * dbus/dbus-auth.c (process_auth): fix a memleak in OOM handling
1903 * dbus/dbus-memory.c: add ability to set number of mallocs in a
1904 row that will fail on out-of-memory.
1906 * dbus/dbus-internals.c (_dbus_test_oom_handling): convenience
1907 function for testing out-of-memory handling.
1909 * bus/config-loader-expat.c (memsuite): don't wrap the dbus
1910 allocation functions, they do map exactly to the expat ones.
1912 2003-03-27 Havoc Pennington <hp@redhat.com>
1914 * bus/config-loader-libxml.c (bus_config_load): add another error
1917 2003-03-26 Anders Carlsson <andersca@codefactory.se>
1920 Add note about automatic service activation.
1922 * doc/dbus-specification.sgml:
1923 Rename the specification and clarify a few things.
1925 2003-03-26 Anders Carlsson <andersca@codefactory.se>
1928 * dbus/dbus-address.c:
1930 * dbus/dbus-marshal.c:
1931 * dbus/dbus-server-debug-pipe.c:
1932 * dbus/dbus-transport-unix.c:
1933 Fix documentation warnings.
1935 2003-03-26 Havoc Pennington <hp@pobox.com>
1937 * bus/test-main.c, dbus/dbus-test.c (main): check memleaks
1938 after every test so it's quick and easy to see which leaked, and
1939 so we test multiple dbus_shutdown() calls
1941 * configure.in: change configure.in XML stuff to also support
1944 * config-loader-libxml.c: some hacking
1946 * config-loader-expat.c: some hacking
1948 * config-parser.c: some hacking, plus tests
1950 2003-03-25 Havoc Pennington <hp@redhat.com>
1952 * throughout - add more _DBUS_ASSERT_ERROR_IS_CLEAR
1954 * configure.in: add --with-xml option to specify XML library,
1955 right now only libxml is supported.
1957 * bus/config-loader-libxml.c, config-parser.c: sync some minor
1958 nonworking code between home and work, still just stubs
1960 2003-03-24 Havoc Pennington <hp@redhat.com>
1962 * dbus/dbus-sysdeps.c (_dbus_set_fd_nonblocking): move to this
1965 * dbus/dbus-errors.c (dbus_set_error, dbus_set_error_const): allow
1966 NULL argument for "message" if the error is a well-known one,
1967 fill in a generic message in this case.
1969 * dbus/dbus-errors.h (DBusResultCode): Kill DBusResultCode in
1972 * bus/test.c (bus_test_flush_bus): add
1974 * bus/policy.c (bus_policy_test): test code stub
1976 2003-03-24 Havoc Pennington <hp@pobox.com>
1978 * bus/connection.c (bus_connections_setup_connection): set up
1979 the "can this user connect" function, but it always returns
1980 TRUE until we have a config file parser so we can have a config
1981 file that allows connections.
1983 2003-03-23 Havoc Pennington <hp@pobox.com>
1985 * dbus/dbus-threads.c (dbus_mutex_new, dbus_condvar_new): with
1986 DBUS_BUILD_TESTS, actually alloc/free a block of memory for
1987 the mutex, so we can check for proper memory management
1990 * dbus/dbus-dataslot.c: remove the mutex from
1991 DBusDataSlotAllocator and lock it manually when using it,
1992 to simplify fitting it into the global slots framework.
1994 * dbus/dbus-threads.c (init_static_locks): rework how we're
1995 handling global locks so they are easily shut down.
1997 * bus/policy.c (bus_policy_append_rule): fix
1999 * bus/test-main.c (main): check for memleaks
2001 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): make
2002 test suite check for memleaks
2004 * dbus/dbus-memory.c: add support in test mode for tracking
2005 number of outstanding blocks
2007 2003-03-23 Havoc Pennington <hp@pobox.com>
2009 * bus/policy.c, bus/bus.c, bus/connection.c: implement allow/deny
2012 * dbus/dbus-hash.h: add ULONG hash keys
2014 * dbus/dbus-sysdeps.c (_dbus_get_groups): new
2015 (_dbus_get_group_id): new function
2017 2003-03-20 Havoc Pennington <hp@redhat.com>
2019 * dbus/dbus-connection.c (dbus_connection_set_unix_user_function):
2021 (dbus_connection_get_unix_user): new function
2023 2003-03-20 Havoc Pennington <hp@pobox.com>
2025 * bus/connection.c (bus_connection_send_oom_error): assert that
2026 message has a sender
2027 (connection_execute_transaction): ditto
2028 (bus_connection_preallocate_oom_error): fix to set the sender, and
2029 set recipient to the destination service, not the bus driver
2031 * bus/policy.c: hacking
2033 * dbus/dbus-message.c (dbus_message_service_is): new function
2034 (dbus_message_sender_is): new
2036 2003-03-19 Havoc Pennington <hp@redhat.com>
2038 * bus/policy.c: start sketching code for policy restrictions on
2039 what connections can do.
2041 2003-03-18 Havoc Pennington <hp@redhat.com>
2043 * doc/TODO: some notes on high-level todo items. Little nitpick
2044 stuff is all in @todo, so no need to add it here.
2046 * doc/config-file.txt: some notes on how config file might look
2048 2003-03-18 Anders Carlsson <andersca@codefactory.se>
2054 2003-03-17 Havoc Pennington <hp@redhat.com>
2056 * dbus/dbus-internals.h: add gcc attributes so that
2057 our printf-style functions warn on bad arguments to
2060 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): fix printf
2063 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
2066 2003-03-17 Havoc Pennington <hp@redhat.com>
2068 * bus/test-main.c (main): make it print something as it runs
2069 so make check doesn't look stuck
2071 * doc/negotiation.txt, doc/dbus-sasl-profile.txt: remove
2072 from CVS, now obsolete
2074 2003-03-17 Anders Carlsson <andersca@codefactory.se>
2076 * bus/dispatch.c: (bus_dispatch):
2077 Refetch the service name since it may have been reallocated
2078 when dbus_message_set_sender was called.
2080 * dbus/dbus-sysdeps.c: (_dbus_accept):
2081 Add address and address length variables and use them to stop
2082 valgrind from complaining.
2084 2003-03-17 Havoc Pennington <hp@pobox.com>
2086 All tests pass, no memleaks, no valgrind complaints.
2088 * bus/test.c: refcount handler_slot
2090 * bus/connection.c (bus_connections_new): refcount
2091 connection_data_slot
2093 * dbus/dbus-auth-script.c (_dbus_auth_script_run): delete unused
2094 bytes so that auth scripts pass.
2096 * bus/dispatch.c: init message_handler_slot so it gets allocated
2099 * bus/dispatch.c (message_handler_slot_ref): fix memleak
2101 * dbus/dbus-server-debug-pipe.c (_dbus_server_debug_pipe_new):
2102 dealloc server_pipe_hash when no longer used for benefit of
2105 * dbus/dbus-auth.c (process_command): memleak fix
2107 * bus/dispatch.c (check_hello_message): memleak fix
2109 2003-03-16 Havoc Pennington <hp@pobox.com>
2111 * dbus/dbus-bus.c (ensure_bus_data): fix double-unref of the data slot
2113 2003-03-17 Anders Carlsson <andersca@codefactory.se>
2115 * bus/activation.c (bus_activation_activate_service): Append
2116 the pending activation entry to the list of pending activations.
2118 2003-03-16 Havoc Pennington <hp@pobox.com>
2120 * bus/dispatch.c (bus_dispatch_test): remove double-unrefs of
2123 * dbus/dbus-address.c (create_entry): fix OOM handling when
2124 failing to alloc entry->method
2126 2003-03-16 Havoc Pennington <hp@pobox.com>
2128 * dbus/dbus-watch.c (_dbus_watch_new): handle failure to malloc
2131 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
2132 add some missing dbus_set_result
2134 * bus/dispatch.c (bus_dispatch_add_connection): handle failure to
2135 alloc the DBusMessageHandler
2137 * dbus/dbus-transport.c (_dbus_transport_disconnect): don't ref
2138 the transport here, since we call this from the finalizer; it
2139 resulted in a double-finalize.
2141 * dbus/dbus-transport.c (_dbus_transport_disconnect): fix a bug
2142 where we tried to use transport->connection that was NULL,
2143 happened when transport was disconnected early on due to OOM
2145 * bus/*.c: adapt to handle OOM for watches/timeouts
2147 * dbus/dbus-transport-unix.c: port to handle OOM during
2150 * dbus/dbus-auth.c (_dbus_auth_get_unused_bytes): return a
2151 reference to unused bytes instead of a copy
2153 * dbus/dbus-server.c (dbus_server_handle_watch): return FALSE for
2156 * dbus/dbus-connection.c (dbus_connection_handle_watch): return
2159 * dbus/dbus-timeout.c (dbus_timeout_handle): return FALSE for out
2162 2003-03-16 Anders Carlsson <andersca@codefactory.se>
2164 * doc/dbus-specification.sgml:
2165 Document reply message for ActivateService.
2167 2003-03-16 Anders Carlsson <andersca@codefactory.se>
2169 * bus/activation.c: (bus_pending_activation_entry_free),
2170 (bus_pending_activation_free), (bus_activation_new),
2171 (bus_activation_unref), (bus_activation_service_created),
2172 (bus_activation_activate_service):
2174 * bus/bus.c: (bus_context_new):
2175 * bus/desktop-file.c: (new_section):
2176 * bus/driver.c: (bus_driver_send_service_deleted),
2177 (bus_driver_handle_activate_service):
2178 * bus/services.c: (bus_registry_new), (bus_registry_ensure):
2180 * dbus/dbus-connection.c:
2181 (dbus_connection_send_with_reply_and_block):
2182 * dbus/dbus-message.c: (dbus_message_append_args_valist):
2183 * dbus/dbus-protocol.h:
2184 Make activation work better. Now pending activations will be queued
2185 and the daemon won't try to activate services that are already registered.
2187 2003-03-16 Havoc Pennington <hp@pobox.com>
2189 * dbus/dbus-bus.c (ensure_bus_data): handle failure to set
2192 * dbus/dbus-memory.c (_dbus_initialize_malloc_debug): support
2193 DBUS_MALLOC_BACKTRACES to print trace when failing an alloc
2195 2003-03-16 Havoc Pennington <hp@pobox.com>
2197 * dbus/dbus-string.c (_dbus_string_validate_utf8): oops, unbreak
2198 this. always run the test suite before commit...
2200 * bus/*: adapt to DBusConnection API changes
2202 * glib/dbus-gmain.c: adapt to DBusConnection API changes,
2203 requires renaming stuff to avoid dbus_connection_dispatch name
2206 * dbus/dbus-transport.c (_dbus_transport_queue_messages): new
2209 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
2210 separate from _dbus_message_loader_return_buffer()
2212 * dbus/dbus-connection.c (dbus_connection_get_n_messages): remove
2213 this, because it's now always broken to use; the number of
2214 messages in queue vs. the number still buffered by the message
2215 loader is undefined/meaningless. Should use
2216 dbus_connection_get_dispatch_state().
2217 (dbus_connection_dispatch): rename from
2218 dbus_connection_dispatch_message
2220 2003-03-16 Havoc Pennington <hp@pobox.com>
2222 * dbus/dbus-string.c (_dbus_string_validate_utf8): copy in a real
2225 2003-03-16 Anders Carlsson <andersca@codefactory.se>
2227 * dbus/dbus-connection.c:
2228 (dbus_connection_send_with_reply_and_block):
2229 Decrease connection->n_incoming when removing an entry
2231 * dbus/dbus-dict.c: (dbus_dict_entry_free),
2232 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
2233 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
2234 (dbus_dict_set_byte_array), (dbus_dict_set_string_array),
2235 (dbus_dict_get_boolean_array), (dbus_dict_get_double_array),
2236 (dbus_dict_get_byte_array):
2237 Handle NULL arrays and strings. Also add support for byte arrays.
2239 * dbus/dbus-marshal.c: (_dbus_marshal_byte_array),
2240 (_dbus_marshal_dict), (_dbus_demarshal_byte_array),
2241 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
2242 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
2243 (_dbus_demarshal_dict), (demarshal_and_validate_len),
2244 (_dbus_marshal_validate_arg), (_dbus_marshal_test):
2245 * dbus/dbus-marshal.h:
2246 Add support for marshalling and demarshalling empty arrays and strings.
2248 * dbus/dbus-message.c: (dbus_message_append_args_valist),
2249 (dbus_message_append_string_array),
2250 (dbus_message_iter_get_boolean),
2251 (dbus_message_iter_get_boolean_array),
2252 (dbus_message_iter_get_int32_array),
2253 (dbus_message_iter_get_uint32_array),
2254 (dbus_message_iter_get_double_array),
2255 (dbus_message_iter_get_byte_array),
2256 (dbus_message_iter_get_string_array), (dbus_message_iter_get_dict),
2257 (check_message_handling):
2258 Add support for getting empty arrays and dicts.
2260 * dbus/dbus-string.c: (_dbus_string_validate_utf8):
2261 Don't do any validation at all for now, that's better than just checking
2264 * test/data/valid-messages/emptiness.message:
2265 New test message with lots of empty arrays.
2267 2003-03-16 Havoc Pennington <hp@pobox.com>
2269 * dbus/dbus-connection.c
2270 (_dbus_connection_queue_received_message_link): new function that
2271 can't fail due to OOM
2273 * dbus/dbus-message.c (_dbus_message_loader_pop_message_link):
2274 new function pops a message together with a list link
2277 * dbus/dbus-transport-unix.c (queue_messages): use new link-based
2278 message queuing functions to avoid needing to alloc memory
2280 2003-03-16 Havoc Pennington <hp@pobox.com>
2282 Oops - test code was only testing failure of around 30 of the
2283 mallocs in the test path, but it turns out there are 500+
2284 mallocs. I believe this was due to misguided linking setup such
2285 that there was one copy of dbus_malloc etc. in the daemon and one
2286 in the shared lib, and only daemon mallocs were tested. In any
2287 case, the test case now tests all 500+ mallocs, and doesn't pass
2288 yet, though there are lots of fixes in this patch.
2290 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
2291 this so that it doesn't need to allocate memory, since it
2292 has no way of indicating failure due to OOM (and would be
2293 annoying if it did).
2295 * dbus/dbus-list.c (_dbus_list_pop_first_link): new function
2297 * bus/Makefile.am: rearrange to create two self-contained
2298 libraries, to avoid having libraries with overlapping symbols.
2299 that was resulting in weirdness, e.g. I'm pretty sure there
2300 were two copies of global static variables.
2302 * dbus/dbus-internals.c: move the malloc debug stuff to
2305 * dbus/dbus-list.c (free_link): free list mempool if it becomes
2308 * dbus/dbus-memory.c (_dbus_disable_mem_pools): new function
2310 * dbus/dbus-address.c (dbus_parse_address): free list nodes
2313 * bus/dispatch.c (bus_dispatch_add_connection): free
2314 message_handler_slot when no longer using it, so
2315 memory leak checkers are happy for the test suite.
2317 * dbus/dbus-server-debug-pipe.c (debug_finalize): free server name
2319 * bus/bus.c (new_connection_callback): disconnect in here if
2320 bus_connections_setup_connection fails.
2322 * bus/connection.c (bus_connections_unref): fix to free the
2324 (bus_connections_setup_connection): if this fails, don't
2325 disconnect the connection, just be sure there are no side
2328 * dbus/dbus-string.c (undo_alignment): unbreak this
2330 * dbus/dbus-auth.c (_dbus_auth_unref): free some stuff we were
2332 (_dbus_auth_new): fix the order in which we free strings
2335 * bus/connection.c (bus_connection_disconnected): fix to
2336 not send ServiceDeleted multiple times in case of memory
2339 * dbus/dbus-bus.c (dbus_bus_get_base_service): new function to
2340 get the base service name
2341 (dbus_bus_register_client): don't return base service name,
2342 instead store it on the DBusConnection and have an accessor
2344 (dbus_bus_register_client): rename dbus_bus_register()
2346 * bus/dispatch.c (check_hello_message): verify that other
2347 connections on the bus also got the correct results, not
2348 just the one sending hello
2350 2003-03-15 Havoc Pennington <hp@pobox.com>
2352 Make it pass the Hello handling test including all OOM codepaths.
2353 Now to do other messages...
2355 * bus/services.c (bus_service_remove_owner): fix crash when
2356 removing owner from an empty list of owners
2357 (bus_registry_ensure): don't leave service in the list of
2358 a connection's owned services if we fail to put the service
2361 * bus/connection.c (bus_connection_preallocate_oom_error): set
2362 error flag on the OOM error.
2364 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
2365 handle _dbus_transport_set_connection failure
2367 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd): modify
2368 to create watches up front and simply enable/disable them as
2370 (unix_connection_set): this can now fail on OOM
2372 * dbus/dbus-timeout.c, dbus/dbus-watch.c: add concept
2373 of enabling/disabling a watch or timeout.
2375 * bus/loop.c (bus_loop_iterate): don't touch disabled
2378 * glib/dbus-gmain.c: adapt to enable/disable watches and timeouts
2380 2003-03-15 Havoc Pennington <hp@pobox.com>
2382 * bus/dispatch.c (bus_dispatch_test): OK, now finally actually
2383 write useful test code, after all that futzing around ;-)
2385 Test does not yet pass because we can't handle OOM in
2386 _dbus_transport_messages_pending (basically,
2387 dbus_connection_preallocate_send() does not prealloc the write
2388 watch). To fix this, I think we need to add new stuff to
2389 set_watch_functions, namely a SetEnabled function so we can alloc
2390 the watch earlier, then enable it later.
2392 * dbus/Makefile.am (libdbus_convenience_la_SOURCES): move
2393 dbus-memory.c to the convenience lib
2395 * bus/test.c: rename some static functions to keep them clearly
2396 distinct from stuff in connection.c. Handle client disconnection.
2398 2003-03-14 Havoc Pennington <hp@pobox.com>
2400 * bus/dispatch.c (bus_dispatch_test): do test using debug-pipe
2401 transport, tests more of the real codepath. Set up clients
2402 with bus_setup_debug_client.
2404 * bus/test.c (bus_setup_debug_client): function to set up debug
2405 "clients" on the main loop
2407 * dbus/dbus-transport.c (_dbus_transport_open): add debug-pipe
2410 * dbus/dbus-server.c (dbus_server_listen): add debug-pipe
2413 * dbus/dbus-server-debug.c: support a debug server based on pipes
2415 * dbus/dbus-sysdeps.c (_dbus_full_duplex_pipe): new function
2416 (_dbus_close): new function
2418 * configure.in: check for socketpair
2420 2003-03-14 Havoc Pennington <hp@redhat.com>
2422 * dbus/dbus-memory.c: add a "detect buffer overwrites on free"
2425 * dbus/dbus-transport-debug.c: rework this a good bit to be
2426 less complicated. hopefully still works.
2428 * dbus/dbus-server-debug.c (handle_new_client): remove timeout
2431 * glib/dbus-gmain.c (timeout_handler): don't remove timeout
2434 * dbus/dbus-message.c (dbus_message_copy): rename from
2435 dbus_message_new_from_message, fix it up to copy
2436 all the message fields, add test case
2438 * bus/dispatch.c (bus_dispatch_test): add some more test code,
2439 not quite passing yet
2441 2003-03-14 Havoc Pennington <hp@pobox.com>
2443 * bus/loop.c (bus_loop_iterate): add this so we can "run loop
2444 until no work remains" in test code. (the large diff here
2445 is just code movement, no actual changes)
2447 * dbus/dbus-server-debug.c (DEFAULT_INTERVAL): change interval to
2448 1, no point waiting around for test code.
2449 (_dbus_server_debug_accept_transport): unref the timeout
2450 after adding it (right?)
2452 * dbus/dbus-transport-debug.c (DEFAULT_INTERVAL): ditto
2454 2003-03-13 Havoc Pennington <hp@redhat.com>
2456 * dbus/dbus-timeout.c (_dbus_timeout_list_set_functions): handle
2459 * dbus/dbus-watch.c (_dbus_watch_list_set_functions): handle out
2462 * dbus/dbus-connection.h: Make AddWatchFunction and
2463 AddTimeoutFunction return a bool so they can fail on out-of-memory
2465 * bus/bus.c (bus_context_new): set up timeout handlers
2467 * bus/connection.c (bus_connections_setup_connection): set up
2470 * glib/dbus-gmain.c: adapt to the fact that set_functions stuff
2473 * bus/bus.c (bus_context_new): adapt to changes
2475 * bus/connection.c: adapt to changes
2477 * test/watch.c: adapt to DBusWatch changes
2479 * bus/dispatch.c (bus_dispatch_test): started adding this but
2482 2003-03-14 Anders Carlsson <andersca@codefactory.se>
2484 * bus/dispatch.c (send_service_nonexistent_error): Fix typo.
2486 2003-03-13 Havoc Pennington <hp@pobox.com>
2488 * bus/test.c, bus/test.h, bus/Makefile.am, bus/test-main.c:
2489 set up a test framework as for the library
2491 2003-03-12 Havoc Pennington <hp@pobox.com>
2493 Throughout: purge global variables, introduce BusActivation,
2494 BusConnections, BusRegistry, etc. objects instead.
2496 * bus/bus.h, bus/bus.c: introduce BusContext as a global
2499 * test/Makefile.am (TEST_BINARIES): disable bus-test for now,
2500 going to redo this a bit differently I think
2502 2003-03-12 Havoc Pennington <hp@redhat.com>
2504 Mega-patch that gets the message bus daemon initially handling
2505 out-of-memory. Work still needed. Also lots of random
2506 moving stuff to DBusError instead of ResultCode.
2508 * dbus/dbus-list.c (_dbus_list_length_is_one): new function
2510 * dbus/dbus-connection.c
2511 (dbus_connection_send_with_reply_and_block): use DBusError
2513 * dbus/dbus-bus.c: adapt to API changes, make it use DBusError not
2516 * dbus/dbus-connection.c (dbus_connection_send): drop the result
2517 code here, as the only failure possible is OOM.
2519 * bus/connection.c (bus_connection_disconnect):
2520 rename bus_connection_disconnected as it's a notification only
2522 * bus/driver.c (bus_driver_handle_acquire_service): don't free
2523 "name" on get_args failure, should be done by get_args;
2524 don't disconnect client for bad args, just return an error.
2525 (bus_driver_handle_service_exists): ditto
2527 * bus/services.c (bus_services_list): NULL-terminate returned array
2529 * bus/driver.c (bus_driver_send_service_lost)
2530 (bus_driver_send_service_acquired): send messages from driver to a
2531 specific client to the client's unique name, not to the broadcast
2534 * dbus/dbus-message.c (decode_header_data): reject messages that
2535 contain no name field
2536 (_dbus_message_get_client_serial): rename to
2537 dbus_message_get_serial and make public
2538 (_dbus_message_set_serial): rename from set_client_serial
2539 (_dbus_message_set_reply_serial): make public
2540 (_dbus_message_get_reply_serial): make public
2542 * bus/connection.c (bus_connection_foreach): allow stopping
2543 iteration by returning FALSE from foreach function.
2545 * dbus/dbus-connection.c (dbus_connection_send_preallocated)
2546 (dbus_connection_free_preallocated_send)
2547 (dbus_connection_preallocate_send): new API for sending a message
2548 without possibility of malloc failure.
2549 (dbus_connection_send_message): rename to just
2550 dbus_connection_send (and same for whole function family)
2552 * dbus/dbus-errors.c (dbus_error_free): make this reinit the error
2554 * dbus/dbus-sysdeps.c (_dbus_exit): new function
2556 * bus/activation.c: handle/return errors
2558 * dbus/dbus-errors.h: add more DBUS_ERROR #define
2560 * dbus/dbus-sysdeps.c (_dbus_directory_open) (_dbus_file_get_contents)
2561 (_dbus_directory_get_next_file): use DBusError instead of DBusResultCode
2562 (_dbus_result_from_errno): move to this file
2564 2003-03-10 Anders Carlsson <andersca@codefactory.se>
2566 * dbus/dbus-marshal.c:
2567 (_dbus_marshal_set_string):
2568 Take a length argument so we can marshal the correct string
2571 (_dbus_marshal_dict), (_dbus_demarshal_dict),
2572 (_dbus_marshal_get_arg_end_pos), (_dbus_marshal_validate_arg),
2573 (_dbus_marshal_test):
2574 * dbus/dbus-marshal.h:
2575 Add support for marshalling and demarshalling dicts.
2577 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
2578 Add support for TYPE DICT.
2580 * dbus/dbus-message.c: (set_string_field):
2581 Adjust header padding.
2583 (dbus_message_append_args_valist), (dbus_message_append_dict),
2584 (dbus_message_get_args_valist), (dbus_message_iter_get_arg_type),
2585 (dbus_message_iter_get_dict), (_dbus_message_loader_return_buffer),
2586 (check_message_handling), (check_have_valid_message):
2587 * dbus/dbus-message.h:
2588 Add functions for setting and getting dicts.
2590 * dbus/dbus-protocol.h:
2596 * doc/dbus-specification.sgml:
2597 Add information about how dicts are marshalled.
2599 * test/data/invalid-messages/dict-with-nil-value.message:
2600 * test/data/invalid-messages/too-short-dict.message:
2601 * test/data/valid-messages/dict-simple.message:
2602 * test/data/valid-messages/dict.message:
2603 Add sample messages containing dicts.
2605 2003-03-08 Anders Carlsson <andersca@codefactory.se>
2607 * dbus/dbus-dict.h: Add DBUS_END_DECLS.
2609 2003-03-07 Anders Carlsson <andersca@codefactory.se>
2612 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
2613 (dbus_dict_get_keys), (insert_entry), (dbus_dict_set_boolean),
2614 (dbus_dict_set_int32), (dbus_dict_set_uint32),
2615 (dbus_dict_set_double), (dbus_dict_set_string),
2616 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
2617 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
2618 (dbus_dict_set_string_array), (_dbus_dict_test):
2620 Fix according to comments from Havoc.
2622 2003-03-06 Michael Meeks <michael@server.home>
2624 * configure.in: if we don't have kde-config, disable have_qt.
2626 2003-03-07 Anders Carlsson <andersca@codefactory.se>
2631 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
2632 (dbus_dict_ref), (dbus_dict_unref), (dbus_dict_contains),
2633 (dbus_dict_remove), (dbus_dict_get_value_type),
2634 (dbus_dict_get_keys), (dbus_dict_put_boolean),
2635 (dbus_dict_put_int32), (dbus_dict_put_uint32),
2636 (dbus_dict_put_double), (dbus_dict_put_string),
2637 (dbus_dict_put_boolean_array), (dbus_dict_put_int32_array),
2638 (dbus_dict_put_uint32_array), (dbus_dict_put_double_array),
2639 (dbus_dict_put_string_array), (dbus_dict_get_boolean),
2640 (dbus_dict_get_int32), (dbus_dict_get_uint32),
2641 (dbus_dict_get_double), (dbus_dict_get_string),
2642 (dbus_dict_get_boolean_array), (dbus_dict_get_int32_array),
2643 (dbus_dict_get_uint32_array), (dbus_dict_get_double_array),
2644 (dbus_dict_get_string_array), (_dbus_dict_test):
2646 Add DBusDict implementation
2648 * dbus/dbus-test.c: (dbus_internal_do_not_use_run_tests):
2652 2003-03-04 Havoc Pennington <hp@pobox.com>
2654 * test/data/auth/*: adapt to changes
2656 * dbus/dbus-auth-script.c (_dbus_auth_script_run): add
2657 USERID_BASE64 and change USERNAME_BASE64 to put in username not
2660 * dbus/dbus-keyring.c (_dbus_keyring_validate_context): prevent
2661 more stuff from being in a context name, to make the protocol
2662 simpler to deal with
2664 * dbus/dbus-errors.c (dbus_error_has_name): new function
2665 (dbus_error_is_set): new function
2667 * dbus/dbus-auth.c: replace DBUS_STUPID_TEST_MECH auth
2668 with DBUS_COOKIE_SHA1, implement DBUS_COOKIE_SHA1
2670 * dbus/dbus-connection.c (dbus_connection_flush): also read
2671 messages during a flush operation
2673 * dbus/Makefile.am: remove dbus-md5 since it isn't currently used.
2675 2003-03-05 Anders Carlsson <andersca@codefactory.se>
2677 * configure.in: Check for gethostbyname on Solaris.
2679 * dbus/dbus-transport.c: (_dbus_transport_open):
2680 Remove duplicate "tcp" entry.
2682 * doc/dbus-specification.sgml:
2683 Clarify some things.
2685 2003-03-05 Anders Carlsson <andersca@codefactory.se>
2687 * dbus/dbus-auth.c: (send_rejected), (process_test_subdir):
2688 * dbus/dbus-keyring.c: (_dbus_keyring_new_homedir),
2689 (_dbus_keyring_test):
2690 * dbus/dbus-md5.c: (_dbus_md5_compute):
2691 * dbus/dbus-sha.c: (_dbus_sha_compute):
2694 2003-03-05 Anders Carlsson <andersca@codefactory.se>
2696 * README: Add some things.
2698 2003-03-04 Anders Carlsson <andersca@codefactory.se>
2700 * dbus/dbus-message.c (dbus_message_append_args_valist): Add a break;
2701 after case DBUS_TYPE_BOOELAN.
2703 2003-03-02 Havoc Pennington <hp@pobox.com>
2705 * test/break-loader.c (randomly_set_extreme_ints): add test that
2706 sets really huge and small integers
2708 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add check
2709 that length of boolean array fits in the string, and that
2710 string has room for boolean value in single-bool case.
2712 * dbus/dbus-message-builder.c (_dbus_message_data_load): add
2713 optional value to "ALIGN" command which is what to fill the
2716 * test/data/valid-messages/no-padding.message: add regression
2717 test for the message padding problem
2719 2003-03-02 Havoc Pennington <hp@pobox.com>
2721 * dbus/dbus-message.c (decode_header_data): fix to always init
2722 message_padding, from Benjamin Dauvergne
2724 2003-03-02 Havoc Pennington <hp@pobox.com>
2730 2003-03-01 Joe Shaw <joe@assbarn.com>
2732 * configure.in: Check for "struct cmsgcred" and try to access its
2733 members for BSD-like unices.
2735 * dbus/dbus-sysdeps.c (read_credentials_byte): Fold this back into
2736 _dbus_read_credentials_unix_socket().
2737 (_dbus_read_credentials_unix_socket): Use recvmsg() instead of
2738 read() for reading the credential byte off the unix socket. Use
2739 struct cmsgcred on systems that support it.
2741 2003-02-27 Alexander Larsson <alexl@redhat.com>
2745 Make gthreads-2.0 dependency optional. Don't build thread test if
2748 2003-02-27 Havoc Pennington <hp@pobox.com>
2750 * dbus/dbus-connection.c
2751 (dbus_connection_send_message_with_reply_and_block): fix doh!
2752 doh! doh! bug that resulted in never removing a reply from the
2753 queue, no wonder we called get_reply_serial so much ;-)
2755 * dbus/dbus-message.c (struct DBusMessage): cache reply serial
2756 and client serial instead of demarshaling them every time
2758 2003-02-27 Havoc Pennington <hp@pobox.com>
2760 * dbus/dbus-marshal.c (_dbus_demarshal_int32): rewrite to be much
2761 more inlined, using dbus-string-private.h, speeds things up
2764 * dbus/dbus-string.c (_dbus_string_free): apply align offset
2765 when freeing the string
2766 (_dbus_string_steal_data): fix for align offset
2767 (undo_alignment): new function
2769 2003-02-26 Havoc Pennington <hp@redhat.com>
2771 All kinds of audit fixes from Owen, plus initial attempt to
2772 handle unaligned memory returned from malloc.
2774 * dbus/dbus-string.c (_dbus_string_init): clamp max length to
2775 leave room for align_offset and nul byte
2776 (fixup_alignment): function to track an align_offset and
2777 ensure real->str is aligned
2778 (DBUS_GENERIC_STRING_PREAMBLE): len must be less than allocated,
2779 to allow a nul byte plus align offset
2780 (_dbus_string_lock): fix overflow issue
2781 (_dbus_string_init_const_len): add assertions on sanity of len,
2782 assign allocated to be ALLOCATION_PADDING larger than len
2783 (set_length): fixup the overflow handling
2784 (_dbus_string_get_data_len): fix overflow in assertion
2785 (open_gap): detect overflow in size of gap to be opened
2786 (_dbus_string_lengthen): add overflow check
2787 (_dbus_string_align_length): fix overflow with _DBUS_ALIGN_VALUE
2788 (_dbus_string_append): add overflow check
2789 (_dbus_string_append_unichar): overflow
2790 (_dbus_string_delete): fix overflow in assertion
2791 (_dbus_string_copy_len): overflow in assertion
2792 (_dbus_string_replace_len): overflows in assertions
2793 (_dbus_string_find): change to implement in terms of
2794 _dbus_string_find_to
2795 (_dbus_string_find_to): assorted fixage
2796 (_dbus_string_equal_c_str): assert c_str != NULL,
2797 fix logic so the function works
2798 (_dbus_string_ends_with_c_str): fix overflow thingy
2799 (_dbus_string_base64_encode): overflow fix
2800 (_dbus_string_validate_ascii): overflow
2801 (_dbus_string_validate_nul): overflow
2803 2003-02-26 Havoc Pennington <hp@redhat.com>
2805 * dbus/dbus-marshal.c (_dbus_marshal_test): fix to work with DISABLE_ASSERTS
2807 2003-02-26 Alexander Larsson <alexl@redhat.com>
2810 Set DBUS_GLIB_THREADS_LIBS for apps using gthread-2.0
2812 * dbus/dbus-connection.c:
2813 * dbus/dbus-connection.h:
2814 Fix _dbus_connection_acquire_io_path and _dbus_connection_acquire_dispatch.
2815 Add dbus_connection_set_wakeup_main_function and use it when queueing
2816 incoming and outgoing messages.
2819 * dbus/dbus-dataslot.c:
2820 Threadsafe usage of DBusDataSlotAllocator
2822 * dbus/dbus-message.c: (dbus_message_get_args_iter):
2825 * dbus/dbus-server-unix.c:
2828 * glib/dbus-gmain.c:
2829 Implement the new wakeup functions for glib.
2832 * glib/test-thread-client.c:
2833 * glib/test-thread-server.c:
2834 * glib/test-thread.h:
2835 Initial cut at some thread test code. Not really done yet.
2837 2003-02-26 Havoc Pennington <hp@pobox.com>
2839 * dbus/dbus-connection.c
2840 (dbus_connection_send_message_with_reply_and_block): fix crash
2841 where we ref'd the outgoing message instead of the returned reply
2843 * dbus/dbus-transport-unix.c (do_authentication): check read watch
2844 at the end of this function, so if we didn't need to read for
2845 authentication, we reinstall it for receiving messages
2847 * dbus/dbus-message.c (dbus_message_new_reply): allow replies to
2848 a NULL sender for peer-to-peer case
2850 * dbus/dbus-transport-unix.c (check_read_watch): handle
2851 !authenticated case correctly
2853 * glib/dbus-gmain.c: add support for DBusServer
2855 * dbus/dbus-server.c: add data slot support
2857 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): check
2858 return values and handle errors
2860 * dbus/dbus-dataslot.c: factor out the data slot stuff from
2863 * Doxyfile.in (INPUT): add glib subdir
2865 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): rename
2866 setup_with_g_main instead of hookup_with_g_main; write docs
2868 2003-02-24 Anders Carlsson <andersca@codefactory.se>
2870 * dbus/dbus-marshal.c: (_dbus_marshal_validate_arg):
2871 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
2872 * dbus/dbus-message.c: (dbus_message_append_boolean),
2873 (dbus_message_append_boolean_array),
2874 (dbus_message_get_args_valist), (_dbus_message_test):
2875 * dbus/dbus-message.h:
2876 * doc/dbus-specification.sgml:
2877 Various fixes as pointed out by Havoc.
2879 * test/data/invalid-messages/bad-boolean-array.message:
2880 * test/data/invalid-messages/bad-boolean.message:
2881 Add invalid boolean value test cases.
2883 2003-02-24 Anders Carlsson <andersca@codefactory.se>
2885 * dbus/dbus-internals.c: (_dbus_type_to_string):
2886 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
2887 (_dbus_marshal_validate_arg):
2888 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
2889 * dbus/dbus-message.c: (dbus_message_append_args_valist),
2890 (dbus_message_append_boolean), (dbus_message_append_boolean_array),
2891 (dbus_message_get_args_valist), (dbus_message_iter_get_boolean),
2892 (dbus_message_iter_get_int32), (dbus_message_iter_get_uint32),
2893 (dbus_message_iter_get_double),
2894 (dbus_message_iter_get_boolean_array), (message_iter_test):
2895 * dbus/dbus-message.h:
2896 * dbus/dbus-protocol.h:
2897 * doc/dbus-specification.sgml:
2898 * test/data/valid-messages/lots-of-arguments.message:
2899 Add support for boolean and boolean array types.
2901 2003-02-23 Havoc Pennington <hp@pobox.com>
2903 * dbus/dbus-keyring.c: finish most of this implementation and
2906 * dbus/dbus-errors.c (dbus_set_error_const, dbus_set_error): make
2907 these barf if the error isn't cleared to NULL
2909 * dbus/dbus-sysdeps.c (_dbus_delete_file): set error on failure
2910 (_dbus_create_directory): new function
2912 * dbus/dbus-errors.c (dbus_set_error): fix warning
2914 * dbus/dbus-string.c (_dbus_string_hex_encode): new function
2915 (_dbus_string_hex_decode): new function
2916 (test_hex_roundtrip): test code
2918 * dbus/dbus-sha.c (_dbus_sha_compute): use dbus_string_hex_encode
2920 * dbus/dbus-md5.c (_dbus_md5_compute): use dbus_string_hex_encode
2922 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): make this use
2923 the save-to-temp/rename trick to atomically write the new file
2924 (_dbus_string_parse_uint): new function
2926 2003-02-22 Havoc Pennington <hp@pobox.com>
2928 * test/Makefile.am (dist-hook): fix dist for test/data/sha-1
2930 2003-02-22 Havoc Pennington <hp@pobox.com>
2932 * dbus/dbus-message.c (dbus_message_iter_get_string_array):
2933 (dbus_message_iter_get_byte_array): Fix up doxygen warnings
2935 * dbus/dbus-sha.c: add implementation of SHA-1 algorithm
2937 * dbus/test/data/sha-1: add US government test suite for SHA-1
2939 2003-02-21 Anders Carlsson <andersca@codefactory.se>
2941 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
2942 Make string arrays NULL-terminated.
2944 * dbus/dbus-memory.c: (dbus_free_string_array):
2945 * dbus/dbus-memory.h:
2946 New function for freeing NULL-terminated string arrays.
2948 * dbus/dbus-message-builder.c: (append_quoted_string),
2949 (_dbus_message_data_load):
2950 Add support for array types.
2952 * dbus/dbus-message.c: (check_message_handling):
2953 Add more types as test cases.
2955 * dbus/dbus-sysdeps.c: (_dbus_string_parse_int),
2956 (_dbus_string_parse_double):
2957 Add the start offset to the end offset.
2959 * test/data/valid-messages/lots-of-arguments.message:
2960 New test message with lots of arguments.
2962 2003-02-21 Anders Carlsson <andersca@codefactory.se>
2964 * dbus/dbus-message.c: (dbus_message_append_nil),
2965 (dbus_message_append_int32), (dbus_message_append_uint32),
2966 (dbus_message_append_double), (dbus_message_append_string),
2967 (dbus_message_append_int32_array),
2968 (dbus_message_append_uint32_array),
2969 (dbus_message_append_double_array),
2970 (dbus_message_append_byte_array),
2971 (dbus_message_append_string_array):
2972 Fix all out-of-memory handling in these functions.
2974 2003-02-21 Anders Carlsson <andersca@codefactory.se>
2976 * dbus/dbus-message.c: (dbus_message_append_nil):
2979 2003-02-21 Anders Carlsson <andersca@codefactory.se>
2981 * dbus/dbus-message.c: (dbus_message_append_args_valist),
2982 (dbus_message_append_nil), (dbus_message_append_int32_array),
2983 (dbus_message_append_uint32_array),
2984 (dbus_message_append_double_array),
2985 (dbus_message_append_byte_array),
2986 (dbus_message_append_string_array), (dbus_message_get_args_valist),
2987 (dbus_message_iter_get_int32_array),
2988 (dbus_message_iter_get_uint32_array),
2989 (dbus_message_iter_get_double_array),
2990 (dbus_message_iter_get_byte_array),
2991 (dbus_message_iter_get_string_array):
2993 * dbus/dbus-message.h:
2994 Add functions for appending and getting arrays.
2996 2003-02-21 Anders Carlsson <andersca@codefactory.se>
2998 * dbus/dbus-mempool.c (_dbus_mem_pool_new): Make the
2999 element size at least 8 bytes, fixes mempool tests on
3002 2003-02-20 Alexander Larsson <alexl@redhat.com>
3004 * dbus/dbus-transport-unix.c (unix_do_iteration):
3005 Unlock the connection mutex during a blocking select call.
3006 Add todo about how we need a way to wake up the select.
3008 * dbus/dbus-connection-internal.h:
3009 * dbus/dbus-connection.c:
3010 Add _dbus_connection_lock and _dbus_connection_unlock.
3012 2003-02-19 Havoc Pennington <hp@pobox.com>
3014 * Doxyfile.in (PREDEFINED): put DOXYGEN_SHOULD_SKIP_THIS in
3015 Doxyfile.in, not Doxyfile
3017 * dbus/dbus-keyring.c: do some hacking on this
3019 * dbus/dbus-sysdeps.c (_dbus_delete_file): new
3021 * dbus/dbus-errors.c (dbus_set_error_const): do not call
3023 (dbus_set_error): remove dbus_error_init, check for message ==
3024 NULL *before* we sprintf into it, and add @todo about including
3025 system headers in this file
3027 * dbus/dbus-sysdeps.c (_dbus_create_file_exclusively): new
3029 * dbus/dbus-errors.h (DBUS_ERROR_FAILED): add
3031 * dbus/dbus-sysdeps.c (get_user_info): break this function out to
3032 get various bits of user information based on either username
3034 (_dbus_homedir_from_username): new function
3036 2003-02-19 Anders Carlsson <andersca@codefactory.se>
3039 Add check for nonposix getpwnam_r
3041 * dbus/dbus-mempool.c: (_dbus_mem_pool_new):
3042 Align the pool element size to a sizeof (void *) boundary.
3044 * dbus/dbus-sysdeps.c: (_dbus_setenv), (_dbus_connect_unix_socket),
3045 (_dbus_listen_unix_socket), (_dbus_credentials_from_username):
3046 General Solaris fixes.
3048 * test/data/valid-messages/simplest-manual.message:
3049 Explicitly state that we want little-endian packing.
3051 2003-02-19 Mikael Hallendal <micke@codefactory.se>
3053 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
3055 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_tcp_socket):
3056 Added to create a transport connecting using a tcp/ip socket.
3058 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): Added to connect
3059 to a tcp socket at given host and port.
3060 (_dbus_listen_tcp_socket): added to listen on tcp socket for given
3063 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
3065 * dbus/dbus-server-unix.c (_dbus_server_new_for_tcp_socket):
3066 Added to create a server listening on a TCP/IP socket.
3068 2003-02-19 Havoc Pennington <hp@pobox.com>
3070 Throughout: mop up all the Doxygen warnings and undocumented
3073 * dbus/dbus-sysdeps.c (do_exec): do not use execvp, we don't want
3074 to search any paths.
3076 * dbus/dbus-threads.c: move global mutex initializers to
3077 dbus-internals.h, multiple prototypes was confusing doxygen
3078 besides being kind of ugly
3080 * Doxyfile (PREDEFINED): have Doxygen define
3081 DOXYGEN_SHOULD_SKIP_THIS so we can exclude things from
3082 docs with #ifndef DOXYGEN_SHOULD_SKIP_THIS
3083 (do not abuse the feature! it's for stuff like the autogenerated
3084 macros in dbus-md5.c, not just for things you don't feel like
3087 2003-02-18 Havoc Pennington <hp@pobox.com>
3089 * dbus/dbus-string.c (_dbus_string_zero): new function
3091 * dbus/dbus-md5.c: include MD5 implementation by L. Peter Deutsch,
3092 wrap it in some dbus-friendly API
3094 * dbus/dbus-types.h: add 16-bit types
3096 2003-02-18 Joe Shaw <joe@assbarn.com>
3098 * dbus/dbus-auth.c (handle_server_data_stupid_test_mech): Just get
3099 credentials from our currently running process.
3100 (get_word): Fix a buglet where we were copying the entire length
3101 instead of relative to our position.
3103 * dbus/dbus-hash.c (_dbus_hash_test): Don't try to allocate the
3104 keys on the stack... it's 640k of data.
3106 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): Always
3107 read the credentials byte off the socket, even if we don't have
3109 (_dbus_poll): Implement poll() using select() for systems which
3112 * glib/test-dbus-glib.c (main): Print out an error if no
3113 parameters are given.
3115 * test/data/auth/fallback.auth-script: Added. Tests that a client
3116 can fallback to a secondary auth mechanism if the first fails.
3118 2003-02-18 Havoc Pennington <hp@pobox.com>
3122 2003-02-17 Havoc Pennington <hp@pobox.com>
3124 * doc/dbus-specification.sgml: lots of cosmetic
3125 cleanups/rearrangement, add assorted FIXME, change DBUS_ADDRESS
3126 env variable to DBUS_BUS_ADDRESS, s/client/application/,
3127 s/server/bus/ (except in authentication section). Add a section
3128 "Message Bus Message Routing"
3130 2003-02-17 Anders Carlsson <andersca@codefactory.se.>
3136 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3138 * doc/dbus-specification.sgml:
3139 Specification updates.
3141 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3143 * bus/activation.c: (bus_activation_init), (child_setup),
3144 (bus_activation_activate_service):
3146 * bus/main.c: (main):
3147 Set DBUS_ADDRESS environment variable.
3149 * dbus/dbus-errors.c: (dbus_set_error):
3150 Don't use va_copy since that's a C99 feature.
3152 * dbus/dbus-sysdeps.c: (_dbus_setenv), (do_exec),
3153 (_dbus_spawn_async):
3154 * dbus/dbus-sysdeps.h:
3155 Add child_setup_func to _dbus_spawn_async.
3157 * doc/dbus-specification.sgml:
3158 Update specification.
3160 * test/spawn-test.c: (setup_func), (main):
3163 2003-02-17 Alexander Larsson <alexl@redhat.com>
3165 * dbus/dbus-connection.c (_dbus_connection_handler_destroyed_locked):
3168 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3172 * doc/dbus-test-plan.sgml:
3173 Add test plan document.
3178 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3180 * dbus/dbus-message.c: (decode_header_data),
3181 (_dbus_message_loader_return_buffer):
3182 Set the header padding amount when loading a message.
3184 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3186 * bus/dispatch.c: (send_one_message):
3187 Only send broadcast messages to registered connections.
3189 * dbus/dbus-message.c: (dbus_message_name_is):
3190 * dbus/dbus-message.h:
3191 New convenience function.
3193 * dbus/dbus-transport-debug.c: (do_reading):
3194 Only dispatch one message per run.
3197 * test/bus-test.c: (new_connection_callback), (die),
3198 (test_hello_client1_handler), (test_hello_client2_handler),
3199 (test_hello_replies), (main):
3201 * test/bus-test-loop.[ch]:
3204 2003-02-16 Havoc Pennington <hp@pobox.com>
3206 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
3207 backward conditional
3209 2003-02-16 Alexander Larsson <alexl@redhat.com>
3211 * dbus/dbus-connection.c:
3212 Implement sent_message_with_reply. (with_reply_and block is still
3214 Made dispatch_message not lose message if OOM.
3216 * dbus/dbus-errors.h:
3217 Add NoReply error (for reply timeouts).
3219 2003-02-16 Alexander Larsson <alexl@redhat.com>
3221 * dbus/dbus-hash.c (_dbus_hash_table_unref):
3222 Actually free keys and values when destroying hashtable.
3224 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3226 * dbus/dbus-auth.c: (client_try_next_mechanism):
3229 * dbus/dbus-threads.c: (dbus_condvar_wait_timeout):
3230 Return TRUE if there's no thread implementation around.
3232 * glib/dbus-gmain.c: (free_source),
3233 (dbus_connection_hookup_with_g_main):
3234 Make sure to remove the GSource when the connection is finalized.
3236 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3238 * bus/dispatch.c: (bus_dispatch_message_handler):
3239 * dbus/dbus-errors.h:
3240 Return an error if someone tries to send a message to a service
3243 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3245 * bus/activation.c: (load_directory), (bus_activation_init),
3246 (bus_activation_activate_service):
3249 (bus_driver_handle_activate_service), (bus_driver_handle_message):
3250 More work on the activation handling.
3252 * dbus/dbus-errors.h:
3253 Add some error messages
3255 * dbus/dbus-message.c: (dbus_message_new_error_reply):
3256 * dbus/dbus-message.h:
3257 New function that creates an error message.
3259 * dbus/dbus-protocol.h:
3260 Add ACTIVATE_SERVER message.
3262 * dbus/dbus-server-unix.c: (unix_handle_watch),
3263 (_dbus_server_new_for_domain_socket):
3264 Call _dbus_fd_set_close_on_exec.
3266 * dbus/dbus-sysdeps.c: (make_pipe), (do_exec),
3267 (_dbus_spawn_async), (_dbus_disable_sigpipe),
3268 (_dbus_fd_set_close_on_exec):
3269 * dbus/dbus-sysdeps.h:
3270 Add _dbus_fd_set_close_on exec function. Also add function that checks
3271 that all open fds are set to close-on-exec and warns otherwise.
3273 * dbus/dbus-transport-unix.c:
3274 (_dbus_transport_new_for_domain_socket):
3275 Call _dbus_fd_set_close_on_exec.
3277 2003-02-16 Havoc Pennington <hp@pobox.com>
3279 * dbus/dbus-connection.c (dbus_connection_set_change_sigpipe):
3280 allow people to avoid setting SIGPIPE to SIG_IGN
3281 (_dbus_connection_new_for_transport): disable SIGPIPE unless
3282 we've been asked not to
3284 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3286 * dbus/dbus-list.c: (_dbus_list_append_link),
3287 (_dbus_list_prepend_link):
3288 * dbus/dbus-memory.c: (dbus_malloc), (dbus_malloc0),
3292 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3295 * bus/activation.c: (bus_activation_entry_free),
3296 (add_desktop_file_entry), (load_directory), (bus_activation_init):
3298 * bus/main.c: (main):
3299 Add simple activation support, doesn't work yet though.
3301 2003-02-15 Zack Rusin <zack@kde.org>
3303 * qt/dbus-qthread.cpp: small casting fix
3305 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3307 * dbus/dbus-errors.c: (dbus_set_error):
3308 * dbus/dbus-errors.h:
3309 Add a few errors and make dbus_set_error void.
3311 * dbus/dbus-sysdeps.c:
3312 (_dbus_errno_to_string), (close_and_invalidate), (make_pipe),
3313 (write_err_and_exit), (read_ints), (do_exec), (_dbus_spawn_async):
3314 * dbus/dbus-sysdeps.h:
3315 Add _dbus_spawn_async.
3317 * test/spawn-test.c: (main):
3318 Test for _dbus_spawn_async.
3320 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3322 * dbus/dbus-internals.h:
3323 Fix build without tests.
3325 * dbus/dbus-list.c: (alloc_link):
3326 Fix a segfault when a malloc fails.
3328 * dbus/dbus-memory.c: (initialize_malloc_debug), (dbus_malloc),
3329 (dbus_malloc0), (dbus_realloc):
3330 Add support for malloc debugging.
3332 2003-02-15 Alexander Larsson <alexl@redhat.com>
3334 * dbus/dbus-threads.c:
3335 * dbus/dbus-threads.h:
3336 Add condvars. Remove static mutext from API.
3337 Implement static mutexes by initializing them from threads_init.
3339 * glib/dbus-gthread.c:
3340 * qt/dbus-qthread.cpp:
3341 Update with the thread api changes.
3346 Turn StaticMutex into normal mutex + init function.
3347 Export new functions _dbus_list_alloc_link, _dbus_list_free_link,
3348 _dbus_list_append_link, _dbus_list_prepend_link
3351 * dbus/dbus-sysdeps.c:
3352 * dbus/dbus-sysdeps.h:
3353 New type dbus_atomic_t, and new functions _dbus_atomic_inc,
3354 _dbus_atomic_dec. Only slow fallback implementation at the moment.
3356 * dbus/dbus-protocol.h:
3357 Add DBUS_MESSAGE_LOCAL_DISCONNECT define
3359 * dbus/dbus-message.c:
3360 Make ref/unref atomic.
3363 * dbus/dbus-connection-internal.h:
3364 * dbus/dbus-connection.c:
3365 * dbus/dbus-connection.h:
3367 Change _peek to _borrow,_return & _steal_borrowed.
3368 Change disconnect callback to event.
3369 Make dbus_connection_dispatch_messages reentrant.
3371 * dbus/dbus-transport.c:
3372 Don't ref the connection on calls to the transport
3375 * dbus/dbus-message-handler.c:
3378 * glib/dbus-gmain.c:
3379 Don't use peek_message anymore
3382 * test/debug-thread.c:
3383 * test/debug-thread.h:
3384 Simple thread implementation that asserts() on deadlocks in
3385 single-threaded code.
3388 (main) Call debug_threads_init.
3391 Use disconnect message instead of disconnect callback.
3395 Don't call dbus_connection_set_disconnect_function. Instead export
3396 bus_connection_disconnect.
3399 Call bus_connection_disconnect when we get a disconnected message.
3401 2003-02-15 Havoc Pennington <hp@pobox.com>
3403 * dbus/dbus-message.c (dbus_message_new): fool around with the
3406 2003-02-14 Havoc Pennington <hp@pobox.com>
3408 * dbus/dbus-mempool.c: fail if the debug functions so indicate
3410 * dbus/dbus-memory.c: fail if the debug functions indicate we
3413 * dbus/dbus-internals.c (_dbus_set_fail_alloc_counter)
3414 (_dbus_decrement_fail_alloc_counter): debug functions to
3415 simulate memory allocation failures
3417 2003-02-14 Havoc Pennington <hp@pobox.com>
3419 * dbus/dbus-errors.h (struct DBusError): add a word of padding
3422 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3424 * bus/driver.c: (bus_driver_handle_hello):
3426 * bus/services.c: (bus_service_lookup):
3427 Reorder message sending so we get a more sane order.
3429 * test/bus-test.c: (message_handler):
3432 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3434 * bus/driver.c: (bus_driver_send_service_deleted),
3435 (bus_driver_send_service_created), (bus_driver_send_service_lost),
3436 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
3437 (bus_driver_send_welcome_message),
3438 (bus_driver_handle_list_services),
3439 (bus_driver_handle_acquire_service),
3440 (bus_driver_handle_service_exists):
3441 * dbus/dbus-bus.c: (dbus_bus_register_client),
3442 (dbus_bus_acquire_service), (dbus_bus_service_exists):
3443 * dbus/dbus-errors.c: (dbus_result_to_string):
3444 * dbus/dbus-errors.h:
3445 * dbus/dbus-message.c: (dbus_message_append_args),
3446 (dbus_message_append_args_valist), (dbus_message_get_args),
3447 (dbus_message_get_args_valist), (dbus_message_get_args_iter),
3448 (dbus_message_iter_get_arg_type), (dbus_message_iter_get_string),
3449 (dbus_message_iter_get_byte_array),
3450 (dbus_message_iter_get_string_array), (message_iter_test),
3451 (check_message_handling), (_dbus_message_test):
3452 * dbus/dbus-message.h:
3453 * test/bus-test.c: (main):
3454 Change fields to arguments in messages, so that they won't be
3455 confused with header fields.
3457 * glib/test-dbus-glib.c: (main):
3458 Remove append_fields from hello message.
3460 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3462 * dbus/dbus-errors.c:
3463 * dbus/dbus-message.c:
3464 * dbus/dbus-string.c:
3465 Documentation fixes.
3467 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3469 * glib/dbus-gmain.c: (timeout_handler), (add_timeout),
3471 Implement support for timeouts in dbus-glib.
3473 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3475 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
3476 * dbus/dbus-message.c: (process_test_subdir):
3477 * test/break-loader.c: (find_breaks_based_on):
3478 Plug some memory leaks.
3480 2003-02-13 Richard Hult <rhult@codefactory.se>
3482 * bus/main.c: Fix build.
3484 * dbus/dbus-errors.h:
3485 * dbus/dbus-errors.c: Fix copyright for Anders.
3487 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3492 * bus/connection.c: (bus_connection_foreach):
3495 * bus/desktop-file.c: (grow_lines_in_section), (grow_sections),
3496 (unescape_string), (new_section), (parse_section_start),
3497 (parse_key_value), (report_error), (bus_desktop_file_load),
3498 (bus_desktop_file_get_string):
3499 * bus/desktop-file.h:
3500 Use DBusError for error reporting.
3502 * bus/dispatch.c: (send_one_message),
3503 (bus_dispatch_message_handler):
3504 * bus/driver.c: (bus_driver_send_service_deleted),
3505 (bus_driver_send_service_created), (bus_driver_send_service_lost),
3506 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
3507 (bus_driver_send_welcome_message),
3508 (bus_driver_handle_list_services),
3509 (bus_driver_handle_acquire_service),
3510 (bus_driver_handle_service_exists):
3511 * bus/loop.c: (bus_loop_run):
3513 Use BUS_HANDLE_OOM instead of _DBUS_HANDLE_OOM.
3515 * bus/utils.c: (bus_wait_for_memory):
3517 New files with general utility functions.
3519 * dbus/dbus-internals.h:
3520 Remove _DBUS_HANDLE_OOM.
3522 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3524 * dbus/dbus-errors.c: (dbus_result_to_string), (dbus_error_init),
3525 (dbus_error_free), (dbus_set_error_const), (dbus_set_error):
3526 * dbus/dbus-errors.h:
3527 Add DBusError structure.
3529 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3531 * test/data/valid-messages/standard-acquire-service.message:
3532 * test/data/valid-messages/standard-hello.message:
3533 * test/data/valid-messages/standard-list-services.message:
3534 * test/data/valid-messages/standard-service-exists.message:
3535 Add some standard messages.
3537 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3539 * bus/driver.c: (bus_driver_send_welcome_message),
3540 (bus_driver_handle_list_services),
3541 (bus_driver_handle_acquire_service),
3542 (bus_driver_handle_service_exists), (bus_driver_handle_message):
3543 Update for API changes in libdbus.
3545 * dbus/dbus-message.c: (dbus_message_new_reply):
3546 * dbus/dbus-message.h:
3547 Remove the name argument. The spec states that replies shouldn't
3550 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3552 * bus/desktop-file.c: (parse_section_start), (parse_key_value),
3553 (report_error), (bus_desktop_file_load), (lookup_section),
3554 (lookup_line), (bus_desktop_file_get_raw),
3555 (bus_desktop_file_get_string):
3556 * bus/desktop-file.h:
3557 Some fixes, and new functions for getting a key value from a section.
3559 2003-02-13 Havoc Pennington <hp@pobox.com>
3561 * test/data/auth/fail-after-n-attempts.auth-script: new test
3563 * dbus/dbus-auth.c (send_rejected): shutdown_mech() when we
3566 2003-02-13 Havoc Pennington <hp@pobox.com>
3568 * dbus/dbus-auth.c (handle_server_data_external_mech): args to
3569 dbus_credentials_match were backward
3571 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support
3572 NO_CREDENTIALS and ROOT_CREDENTIALS
3574 * dbus/dbus-auth.c (_dbus_auth_do_work): move get_state() routine
3575 into here. Never process more commands after we've reached an
3576 end state; store further data as unused bytes.
3578 * test/data/auth/*: add more auth tests
3580 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support EXPECT
3581 command to match exact string and EXPECT_UNUSED to match unused
3584 * test/Makefile.am (dist-hook): fix to dist all the test stuff
3586 2003-02-12 Havoc Pennington <hp@pobox.com>
3588 * dbus/dbus-string.c (_dbus_string_pop_line): fix to also strip
3589 \r off of popped lines
3591 * dbus/dbus-auth.c (_dbus_auth_test): write code to run auth
3594 * dbus/dbus-auth-script.c (_dbus_auth_script_run): when doing a
3597 2003-02-12 Havoc Pennington <hp@pobox.com>
3599 * dbus/Makefile.am: remove break-loader from the build, since it
3602 * configure.in: add --enable-gcov to turn on coverage profiling
3603 flags and disable optimization
3605 2003-02-10 Havoc Pennington <hp@pobox.com>
3607 * dbus/dbus-auth-script.c, dbus/dbus-auth-script.h: sync
3608 initial cut at test framework for DBusAuth from laptop.
3609 Doesn't quite work yet but it compiles and I need to get
3610 it off the 266mhz laptop. ;-)
3612 * dbus/dbus-server-debug.c (_dbus_server_debug_accept_transport):
3613 fix a memleak in error case
3615 2003-02-12 Anders Carlsson <andersca@codefactory.se>
3618 * bus/desktop-file.c:
3619 * bus/desktop-file.h:
3620 Add a desktop file parser.
3622 2003-02-11 Zack Rusin <zack@kde.org>
3624 * qt/message.[h|cpp]: sample implementation
3625 of the KDE wrapper for DBusMessage
3627 2003-02-09 Zack Rusin <zack@kde.org>
3629 * test/bus-test.c: make_it_compile
3630 * doc/dbus-specification.sgml: minimal semantic fix
3632 2003-02-06 Anders Carlsson <andersca@codefactory.se>
3638 2003-02-06 Anders Carlsson <andersca@codefactory.se>
3641 * dbus/dbus-break-loader.c:
3643 * test/break-loader.c:
3644 Move dbus-break-loader to test/ and rename it to break-loader.
3646 2003-02-02 Havoc Pennington <hp@pobox.com>
3648 * dbus/dbus-keyring.c, dbus/dbus-keyring.h: template files
3649 for code to manage cookies in your home directory
3651 * dbus/dbus-sysdeps.c (_dbus_generate_random_bytes): new function
3653 * dbus/dbus-auth.c (get_state): impose a maximum number of tries
3654 to authenticate, then disconnect the client.
3656 2003-02-03 Alexander Larsson <alexl@redhat.com>
3658 * dbus/dbus-message.c (dbus_message_append_fields):
3661 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3663 * doc/dbus-specification.sgml:
3664 Update address format section.
3666 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3669 * test/bus-test.c: (get_time), (add_timeout), (remove_timeout),
3670 (message_handler), (new_connection_callback), (loop_quit),
3674 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3676 * bus/driver.c: (bus_driver_handle_service_exists):
3677 Simplify the code a bit.
3679 * dbus/dbus-bus.c: (dbus_bus_service_exists):
3682 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3685 Add libdbus-daemon.la and link to it.
3687 2003-02-01 James Willcox <jwillcox@gnome.org>
3689 * bus/driver.c: (bus_driver_handle_own_service):
3690 Actually include the service reply code in the message.
3692 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3694 * bus/driver.c: (bus_driver_handle_service_exists):
3695 Don't unref the incoming message.
3697 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3699 * dbus/dbus.h: Add dbus-address.h and dbus-bus.h
3701 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3703 * dbus/dbus-server.c: (dbus_server_listen):
3704 * dbus/dbus-transport.c: (_dbus_transport_open):
3705 ifdef out the calls to the debug transport and server.
3707 2003-02-02 Alexander Larsson <alexl@redhat.com>
3709 * dbus/dbus-watch.c (dbus_watch_get_flags):
3710 Add note in the docs that ERROR or HANGUP won't be returned
3711 and are assumed always on.
3713 * glib/dbus-gmain.c (add_watch):
3714 Always add IO_ERR | IO_HUP
3716 * dbus/dbus-message.h:
3717 Add semicolon after dbus_message_iter_get_string_array().
3718 Makes qt code build again
3720 2003-02-01 Anders Carlsson <andersca@codefactory.se>
3722 * bus/driver.c: (create_unique_client_name),
3723 (bus_driver_handle_hello):
3724 Don't take a name, just use a numeric id to identify
3728 * dbus/dbus-bus.c: (dbus_bus_register_client),
3729 (dbus_bus_acquire_service), (dbus_bus_service_exists):
3731 Add new convenience functions for communicating with the bus.
3733 * dbus/dbus-message.h:
3735 * dbus/dbus-protocol.h:
3738 2003-02-01 Alexander Larsson <alexl@redhat.com>
3740 * dbus/dbus-message.c (dbus_message_append_fields):
3741 Add some more doc comments.
3743 2003-02-01 Havoc Pennington <hp@pobox.com>
3745 * dbus/dbus-break-loader.c (randomly_modify_length): change
3746 a 4-byte value in the message as if it were a length
3748 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): don't set
3749 execute bit on saved files
3751 2003-02-01 Havoc Pennington <hp@pobox.com>
3753 * dbus/dbus-break-loader.c (main): new program to find messages
3754 that break the loader.
3756 * dbus/dbus-sysdeps.c (_dbus_string_append_uint): new function
3757 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): new function
3759 * dbus/dbus-string.c (_dbus_string_set_byte): new
3761 2003-01-31 Havoc Pennington <hp@pobox.com>
3763 * dbus/dbus-message.c: refactor the test code to be more general,
3764 in preparation for writing a "randomly permute test cases to
3765 try to break the loader" program.
3767 2003-01-31 Havoc Pennington <hp@pobox.com>
3769 * doc/dbus-specification.sgml: work on the specification
3771 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): check
3772 the protocol version of the message.
3774 * dbus/dbus-protocol.h: drop special _REPLY names, the spec
3775 no longer specifies that.
3776 (DBUS_SERVICE_REPLY_SERVICE_EXISTS): fix flags (1/2/4/8 not
3779 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos): add missing
3780 "break" for DBUS_TYPE_NIL, remove @todo
3782 2003-01-31 Havoc Pennington <hp@pobox.com>
3784 * dbus/dbus-message.c (dbus_message_set_is_error_reply): rename
3785 just set_is_error/get_is_error as this is a commonly-used
3786 function, and write docs.
3788 2003-01-31 Anders Carlsson <andersca@codefactory.se>
3790 * dbus/dbus-address.c: (dbus_address_entry_free):
3791 Free key and value lists.
3793 * dbus/dbus-internals.c: (_dbus_type_to_string):
3794 Add the types we didn't have.
3796 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
3797 (_dbus_marshal_validate_arg):
3800 * dbus/dbus-message.c: (dbus_message_set_sender):
3801 Remove todo about being able to set sender to NULL.
3803 (dbus_message_set_is_error_reply),
3804 (dbus_message_get_is_error_reply):
3805 * dbus/dbus-message.h:
3808 * dbus/dbus-protocol.h:
3809 Add error reply flag.
3811 * test/data/valid-messages/opposite-endian.message:
3812 Add NIL type to test.
3814 2003-01-31 Havoc Pennington <hp@pobox.com>
3816 * doc/dbus-specification.sgml: fully specify the header. Add
3817 flags and major protocol version, and change header/body len to
3820 * dbus/dbus-message-builder.c (append_saved_length): append length
3823 * dbus/dbus-message.c (dbus_message_create_header): change header
3824 length and body length to unsigned. Add the new fields from the
3826 (_dbus_message_loader_return_buffer): unsigned header/body len
3828 2003-01-30 Havoc Pennington <hp@pobox.com>
3830 * dbus/dbus-auth.c: rework to use only REJECTED, no
3833 * doc/dbus-sasl-profile.txt: drop MECHANISMS and just
3834 use REJECTED, suggested by Mark McLoughlin
3836 2003-01-30 Havoc Pennington <hp@pobox.com>
3838 * dbus/dbus-server.c (dbus_server_listen): @todo about how we need
3839 a better way to report errors here. e.g. "unix address lacks
3840 path" or something. also "no such file" when the path doesn't
3843 * dbus/dbus-address.c (dbus_address_entries_free): add @todo about
3845 (dbus_parse_address): add @todo about documenting address format,
3846 and allowing , and ; to be escaped
3848 2003-01-30 Anders Carlsson <andersca@codefactory.se>
3851 Add dbus-address.[ch]
3853 * dbus/dbus-address.c: (dbus_address_entry_free),
3854 (dbus_address_entries_free), (create_entry),
3855 (dbus_address_entry_get_method), (dbus_address_entry_get_value),
3856 (dbus_parse_address), (_dbus_address_test):
3857 * dbus/dbus-address.h:
3858 New files for dealing with address parsing.
3860 * dbus/dbus-connection.c:
3861 Document timeout functions.
3863 * dbus/dbus-message.c:
3864 Document dbus_message_new_from_message.
3866 * dbus/dbus-server-debug.c:
3869 * dbus/dbus-server.c: (dbus_server_listen):
3870 Parse address and use correct server implementation.
3872 * dbus/dbus-string.c: (_dbus_string_find_to), (_dbus_string_test):
3873 * dbus/dbus-string.h:
3874 New function with test.
3876 * dbus/dbus-test.c: (dbus_internal_symbol_do_not_use_run_tests):
3880 * dbus/dbus-transport-debug.c:
3883 * dbus/dbus-transport.c: (_dbus_transport_open):
3884 Parse address and use correct transport implementation.
3886 2003-01-30 Havoc Pennington <hp@pobox.com>
3888 * dbus/dbus-message.c: use message->byte_order instead of
3889 DBUS_COMPILER_BYTE_ORDER throughout.
3890 (dbus_message_create_header): pad header to align the
3891 start of the body of the message to 8-byte boundary
3893 * dbus/dbus-marshal.h: make all the demarshalers take const
3894 DBusString arguments.
3896 * dbus/dbus-message.c (_dbus_message_loader_return_buffer):
3897 validate message args here, so we don't have to do slow validation
3898 later, and so we catch bad messages as they are incoming. Also add
3899 better checks on header_len and body_len. Also fill in
3902 * dbus/dbus-string.c (_dbus_string_validate_utf8): new (not
3903 implemented properly)
3904 (_dbus_string_validate_nul): new function to check all-nul
3906 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): rename
3907 get_arg_end_pos and remove all validation
3908 (_dbus_marshal_validate_arg): actually do validation here.
3910 2003-01-29 Havoc Pennington <hp@pobox.com>
3912 * dbus/dbus-message.c (check_message_handling): fix assertion
3913 failure on set_client_serial
3915 2003-01-28 Havoc Pennington <hp@pobox.com>
3917 * dbus/dbus-server-debug.c: Add doc section comments
3919 * dbus/dbus-transport-debug.c: add doc section comments
3921 2003-01-28 Havoc Pennington <hp@redhat.com>
3923 * dbus/dbus-string.c (_dbus_string_base64_decode): append bytes in
3924 the reverse order from how I had it
3925 (_dbus_string_base64_encode): reverse encoding order. I was
3926 basically byteswapping everything during encoding.
3928 2003-01-28 Anders Carlsson <andersca@codefactory.se>
3930 * dbus/dbus-connection-internal.h:
3931 * dbus/dbus-connection.c: (_dbus_connection_add_timeout),
3932 (_dbus_connection_remove_timeout):
3933 Add functions for adding and removing timeouts.
3935 * dbus/dbus-message.c: (dbus_message_new_from_message):
3936 Add new function that takes a message and creates an exact
3937 copy of it, but with the refcount set to 1.
3938 (check_message_handling):
3941 * dbus/dbus-server-protected.h:
3942 * dbus/dbus-server.c: (_dbus_server_init_base),
3943 (_dbus_server_finalize_base), (_dbus_server_add_timeout),
3944 (dbus_server_set_timeout_functions):
3945 (_dbus_server_remove_timeout):
3946 New functions so that a server can add and remove timeouts.
3948 (dbus_server_listen):
3949 Add commented out call to dbus_server_debug_new.
3951 * dbus/dbus-timeout.c: (_dbus_timeout_new):
3952 Actually set the handler, doh.
3954 * dbus/dbus-transport.c: (_dbus_transport_open):
3955 Add commented out call to dbus_transport_debug_client_new.
3958 Add dbus-transport-debug.[ch] and dbus-server-debug.[ch]
3960 2003-01-28 Havoc Pennington <hp@pobox.com>
3962 * dbus/dbus-message.c (check_message_handling): function to check
3963 on the loaded message, iterates over it etc.
3965 2003-01-28 Havoc Pennington <hp@pobox.com>
3967 * test/Makefile.am (dist-hook): fix make distdir
3969 * dbus/Makefile.am (TESTS_ENVIRONMENT): fix make check
3971 2003-01-27 Havoc Pennington <hp@pobox.com>
3973 * dbus/dbus-mempool.c (time_for_size): replace printf with
3976 * dbus/dbus-message-builder.c (_dbus_message_data_load): allow
3977 empty lines; fix the SAVE_LENGTH stuff to be
3978 START_LENGTH/END_LENGTH so it actually works; couple other
3981 * test/Makefile.am (dist-hook): add dist-hook for .message files
3983 * dbus/dbus-string.c (DBUS_STRING_COPY_PREAMBLE): source of a copy
3984 can be constant or locked.
3985 (_dbus_string_free): allow freeing a const string as
3988 * dbus/dbus-sysdeps.c (_dbus_concat_dir_and_file): utility
3990 * dbus/dbus-test-main.c (main): take an argument which is the
3991 directory containing test data
3993 * dbus/dbus-message.c (_dbus_message_test): pass a test_data_dir
3994 argument to this and load all the messages in test/data/
3995 checking that they can be loaded or not loaded as appropriate.
3997 2003-01-27 Anders Carlsson <andersca@codefactory.se>
3999 * bus/dispatch.c: (bus_dispatch_message_handler):
4000 Dispatch messages sent to services.
4002 * bus/driver.c: (bus_driver_send_service_deleted),
4003 (bus_driver_send_service_created), (bus_driver_send_service_lost),
4004 (bus_driver_send_service_acquired):
4005 Add helper functions for sending service related messages.
4007 (bus_driver_send_welcome_message):
4008 Send HELLO_REPLY instead of WELCOME.
4010 (bus_driver_handle_list_services):
4011 Send LIST_SERVICES_REPLY instead of SERVICES.
4013 (bus_driver_handle_own_service),
4014 (bus_driver_handle_service_exists):
4015 New message handlers.
4017 (bus_driver_handle_message):
4018 Invoke new message handlers.
4020 (bus_driver_remove_connection):
4021 Don't remove any services here since that's done automatically
4022 by bus_service_remove_owner now.
4025 New function signatures.
4027 * bus/services.c: (bus_service_add_owner):
4028 Send ServiceAcquired message if we're the only primary owner.
4030 (bus_service_remove_owner):
4031 Send ServiceAcquired/ServiceLost messages.
4033 (bus_service_set_prohibit_replacement),
4034 (bus_service_get_prohibit_replacement):
4035 Functions for setting prohibit replacement.
4037 (bus_service_has_owner):
4038 New function that checks if a connection is in the owner queue of
4042 Add new function signatures.
4044 * dbus/dbus-list.c: (_dbus_list_test):
4045 Add tests for _dbus_list_remove_last and traversing the list backwards.
4048 Fix a typo in _dbus_list_get_prev_link, if we're at the first element we can't
4049 go any further, so return NULL then.
4051 * dbus/dbus-protocol.h:
4052 Add new messages, service flags and service replies.
4054 2003-01-26 Havoc Pennington <hp@pobox.com>
4056 * dbus/dbus-message-builder.c: implement, completely untested.
4058 * test/data/*: add data to be used in testing.
4059 ".message" files are our simple loadable text format.
4060 ".message-raw" will be binary dumps of messages.
4062 * dbus/dbus-string.c (_dbus_string_starts_with_c_str): new
4064 2003-01-26 Havoc Pennington <hp@pobox.com>
4066 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): new function
4068 * dbus/dbus-errors.c (dbus_result_to_string): add
4071 * dbus/dbus-message-builder.c: new file, will contain code to load
4072 up messages from files. Not implemented yet.
4074 2003-01-26 Havoc Pennington <hp@pobox.com>
4076 * dbus/dbus-message.c (dbus_message_set_sender): support deleting
4077 the sender by setting to NULL
4079 2003-01-26 Havoc Pennington <hp@pobox.com>
4081 The unit tests pass, but otherwise untested. If it breaks, the
4082 tests should have been better. ;-)
4084 * bus/driver.c (bus_driver_handle_hello): return if we disconnect
4087 * dbus/dbus-message.c: redo everything so we maintain
4088 message->header as the only copy of the various fields.
4089 This avoids the possibility of out-of-memory in some cases,
4090 for example dbus_message_lock() can't run out of memory anymore,
4091 and avoids extra copying. Figured I may as well go ahead and do
4092 this since it was busted for dbus_message_lock to not return
4093 failure on OOM, and dbus_message_write_header was totally
4094 unchecked for OOM. Also fixed some random other bugs.
4096 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): verify
4097 that strings are nul-terminated. Also, end_pos can be equal
4098 to string length just not greater than, I think.
4099 (_dbus_marshal_set_int32): new function
4100 (_dbus_marshal_set_uint32): new function
4101 (_dbus_marshal_set_string): new function
4103 * dbus/dbus-connection.c (_dbus_connection_new_for_transport): fix
4104 a warning, init timeout_list to NULL
4105 (dbus_connection_send_message): don't use uninitialized variable
4108 * dbus/dbus-string.c (_dbus_string_replace_len): new function
4110 2003-01-26 Anders Carlsson <andersca@codefactory.se>
4112 * bus/driver.c: (bus_driver_handle_hello),
4113 (bus_driver_send_welcome_message):
4116 2003-01-26 Anders Carlsson <andersca@codefactory.se>
4118 * dbus/dbus-auth.c: (process_auth), (_dbus_auth_unref):
4119 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
4120 (dbus_connection_unref):
4121 * dbus/dbus-marshal.c: (_dbus_marshal_test):
4122 * dbus/dbus-message.c: (dbus_message_unref),
4125 (dbus_message_get_fields):
4126 Remove debugging printout.
4128 (_dbus_message_loader_return_buffer):
4129 Don't store the header string.
4131 (_dbus_message_test):
4134 2003-01-26 Richard Hult <rhult@codefactory.se>
4136 * glib/dbus-gmain.c (dbus_connection_dispatch): Traverse a copy of
4137 the file descriptor list, since it can change under us.
4139 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4141 * glib/dbus-gmain.c: (dbus_connection_prepare),
4142 (dbus_connection_check), (dbus_connection_dispatch), (add_watch),
4143 (remove_watch), (dbus_connection_hookup_with_g_main):
4144 Rewrite the glib handling to use its own GSource instead of a
4145 GIOChannel so we can catch messages put in the queue while waiting
4148 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4151 * bus/connection.c: (connection_disconnect_handler),
4152 (connection_watch_callback), (bus_connection_setup):
4153 * bus/dispatch.c: (send_one_message),
4154 (bus_dispatch_broadcast_message), (bus_dispatch_message_handler),
4155 (bus_dispatch_add_connection), (bus_dispatch_remove_connection):
4157 * bus/driver.c: (bus_driver_send_service_deleted),
4158 (bus_driver_send_service_created), (bus_driver_handle_hello),
4159 (bus_driver_send_welcome_message),
4160 (bus_driver_handle_list_services), (bus_driver_remove_connection),
4161 (bus_driver_handle_message):
4163 Refactor code, put the message dispatching in its own file. Use
4164 _DBUS_HANDLE_OOM. Also send ServiceDeleted messages when a client
4167 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4169 * dbus/dbus-internals.h:
4170 Add _DBUS_HANDLE_OOM macro, it doesn't do anything currently.
4172 * dbus/dbus-message.c: (dbus_message_get_sender):
4173 * dbus/dbus-message.h:
4174 Implement dbus_message_get_sender.
4176 * dbus/dbus-protocol.h:
4177 Add message and service defines.
4179 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4181 * dbus/dbus-connection.c: (dbus_connection_send_message):
4182 * dbus/dbus-message-internal.h:
4183 * dbus/dbus-message.c: (_dbus_message_get_client_serial),
4184 (dbus_message_write_header):
4185 Remove _dbus_messag_unlock and don't set the client serial on a
4186 message if one already exists.
4188 2003-01-24 Havoc Pennington <hp@pobox.com>
4190 * dbus/dbus-list.c (alloc_link): put a thread lock on the global
4193 * bus/driver.c (bus_driver_handle_list_services): fix a leak
4196 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4198 * dbus/dbus-list.c: (alloc_link), (free_link):
4199 Use a memory pool for the links.
4201 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4203 * bus/connection.c: (bus_connection_foreach):
4205 Add new bus_connection_foreach function.
4207 * bus/driver.c: (send_one_message), (bus_driver_broadcast_message):
4208 Add function that broadcasts a message to all clients.
4210 (bus_driver_send_service_created), (bus_driver_handle_hello),
4211 (bus_driver_send_welcome_message),
4212 (bus_driver_handle_list_services), (bus_driver_message_handler):
4213 Implement functions that take care of listing services, and notifying
4214 clients when new services are created.
4216 * bus/services.c: (bus_services_list):
4218 Add new function that returns an array of strings with the currently
4219 registered services.
4222 * glib/dbus-gmain.c:
4223 Update copyright year.
4225 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4227 * dbus/dbus-connection.c: (dbus_connection_send_message):
4228 Unlock the message in case it was sent earlier.
4230 (dbus_connection_send_message_with_reply_and_block):
4231 Remove the reply message from the list.
4233 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
4234 Set array_len and new_pos correctly.
4236 (_dbus_marshal_test):
4237 Remove debug output.
4239 * dbus/dbus-message-internal.h:
4240 * dbus/dbus-message.c: (_dbus_message_get_reply_serial):
4241 New function that returns the reply serial.
4243 (_dbus_message_unlock):
4244 New function that unlocks a message and resets its header.
4246 (dbus_message_append_string_array),
4247 (dbus_message_get_fields_valist),
4248 (dbus_message_iter_get_field_type),
4249 (dbus_message_iter_get_string_array),
4250 (dbus_message_get_fields),
4251 (dbus_message_append_fields_valist):
4252 Handle string arrays.
4254 (dbus_message_set_sender):
4255 Make this function public since the bus daemon needs it.
4257 (decode_header_data):
4258 Set the reply serial to -1 initially.
4260 * dbus/dbus-message.h:
4261 Add dbus_message_set_sender.
4263 2003-01-24 Havoc Pennington <hp@pobox.com>
4265 * doc/dbus-specification.sgml: add some stuff
4267 2003-01-22 Havoc Pennington <hp@pobox.com>
4269 * doc/dbus-specification.sgml: Start to document the protocol.
4271 2003-01-22 Havoc Pennington <hp@pobox.com>
4273 * dbus/dbus-connection.c
4274 (dbus_connection_send_message_with_reply_and_block): add some @todo
4276 * bus/driver.c (bus_driver_add_connection): add a FIXME about memleak
4278 2003-01-21 Havoc Pennington <hp@pobox.com>
4280 (patch untested because can't compile)
4282 * bus/driver.c (create_unique_client_name): make this function
4283 never recycle client names. Also, caller should initialize
4286 * dbus/dbus-sysdeps.c (_dbus_get_current_time): new function
4288 2003-01-21 Anders Carlsson <andersca@codefactory.se>
4290 * dbus/dbus-marshal.c: (_dbus_marshal_double),
4291 (_dbus_marshal_int32), (_dbus_marshal_uint32),
4292 (_dbus_marshal_int32_array), (_dbus_marshal_uint32_array),
4293 (_dbus_marshal_double_array), (_dbus_marshal_string_array),
4294 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
4295 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
4296 (_dbus_marshal_get_field_end_pos), (_dbus_marshal_test):
4297 * dbus/dbus-marshal.h:
4298 * dbus/dbus-protocol.h:
4299 Add support for marshalling and demarshalling integer, double
4302 2003-01-21 Anders Carlsson <andersca@codefactory.se>
4307 * bus/connection.c: (connection_disconnect_handler):
4308 Remove the connection from the bus driver's list.
4310 (connection_watch_callback): Dispatch messages.
4312 (free_connection_data): Free connection name.
4314 (bus_connection_setup): Add connection to the bus driver's list.
4315 (bus_connection_remove_owned_service):
4316 (bus_connection_set_name), (bus_connection_get_name):
4317 Add functions for setting and getting the connection's name.
4320 Add function headers.
4322 * bus/driver.c: (create_unique_client_name),
4323 (bus_driver_handle_hello_message),
4324 (bus_driver_send_welcome_message), (bus_driver_message_handler),
4325 (bus_driver_add_connection), (bus_driver_remove_connection):
4328 * bus/services.c: (bus_service_free):
4330 New file that handles communication and registreation with the bus
4333 2003-01-21 Anders Carlsson <andersca@codefactory.se>
4335 * dbus/dbus-connection.c: (dbus_connection_send_message):
4336 Add a new client_serial parameter.
4338 (dbus_connection_send_message_with_reply):
4339 Remove a @todo since we've implemented the blocking function.
4341 (dbus_connection_send_message_with_reply_and_block):
4342 New function that sends a message and waits for a reply and
4343 then returns the reply.
4345 * dbus/dbus-connection.h:
4348 * dbus/dbus-errors.c: (dbus_result_to_string):
4349 * dbus/dbus-errors.h:
4350 Add new DBUS_RESULT.
4352 * dbus/dbus-message-internal.h:
4353 * dbus/dbus-message.c: (_dbus_message_get_reply_serial),
4354 (_dbus_message_set_sender), (dbus_message_write_header),
4355 (dbus_message_new_reply), (decode_header_data),
4356 (_dbus_message_loader_return_buffer), (_dbus_message_test):
4357 * dbus/dbus-message.h:
4358 Add new functions that set the reply serial and sender.
4359 Also marshal and demarshal them correctly and add test.
4361 * dbus/dbus-protocol.h:
4362 Add new DBUS_MESSAGE_TYPE_SENDER.
4365 * glib/dbus-gmain.c: (watch_callback), (free_callback_data),
4366 (add_watch), (remove_watch), (add_timeout), (remove_timeout),
4367 (dbus_connection_hookup_with_g_main):
4368 * glib/test-dbus-glib.c: (main):
4369 Rewrite to use GIOChannel and remove the GSource crack.
4371 * test/echo-client.c: (main):
4372 * test/watch.c: (check_messages):
4373 Update for changed APIs
4375 2003-01-19 Anders Carlsson <andersca@codefactory.se>
4377 * dbus/Makefile.am: Add dbus-timeout.[cħ]
4379 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport):
4380 Create a DBusTimeoutList.
4381 (dbus_connection_set_timeout_functions): Add new function to
4382 set timeout callbacks
4384 * dbus/dbus-connection.h: Add public DBusTimeout API.
4386 * dbus/dbus-message.c: (dbus_message_get_service):
4387 * dbus/dbus-message.h: New function.
4389 * dbus/dbus-server.c: Fix small doc typo.
4391 * dbus/dbus-timeout.[ch]: New files for mainloop timeouts.
4393 2003-01-19 Anders Carlsson <andersca@codefactory.se>
4395 * dbus/dbus-string.c (_dbus_string_move_len): Don't delete all
4396 of the string, just as long as specified.
4398 2003-01-19 Havoc Pennington <hp@pobox.com>
4400 * dbus/dbus-connection.c (dbus_connection_get_is_authenticated):
4403 * dbus/dbus-server.c (dbus_server_set_max_connections)
4404 (dbus_server_get_max_connections, dbus_server_get_n_connections):
4405 keep track of current number of connections, and add API for
4406 setting a max (but haven't implemented enforcing the max yet)
4408 2003-01-18 Havoc Pennington <hp@pobox.com>
4410 * dbus/dbus-transport-unix.c (unix_do_iteration): only do the
4411 reading/writing if read_watch != NULL or write_watch != NULL.
4413 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): fix
4414 the message loader code to actually load message->header and
4415 message->body into the newly-created message.
4417 * dbus/dbus-transport-unix.c (check_write_watch): fix a mem leak
4420 * dbus/dbus-connection.c (dbus_connection_set_max_message_size)
4421 (dbus_connection_get_max_message_size)
4422 (dbus_connection_set_max_live_messages_size)
4423 (dbus_connection_get_max_live_messages_size): implement some
4424 resource limitation functions
4426 * dbus/dbus-resources.c: new file implementing some of the
4427 resource limits stuff
4429 * dbus/dbus-message.c (dbus_message_iter_get_byte_array): add
4430 missing docs, add @todo to handle OOM etc.
4432 * dbus/dbus-marshal.c (_dbus_demarshal_byte_array): add missing
4435 2003-01-18 Havoc Pennington <hp@pobox.com>
4437 * dbus/dbus-connection.c (dbus_connection_unref): disconnect the
4438 connection if it hasn't been already.
4440 * dbus/dbus-connection.h: kill off the idea of an ErrorFunction,
4441 replace with DisconnectFunction.
4443 2003-01-18 Havoc Pennington <hp@pobox.com>
4445 Building --disable-verbose-mode --disable-asserts --disable-tests
4446 cuts the library from 112K to 45K or so
4448 * configure.in: check for varargs macro support,
4449 add --enable-verbose-mode, --enable-asserts.
4451 * dbus/dbus-internals.h (_dbus_assert): support
4453 (_dbus_verbose): support DBUS_ENABLE_VERBOSE_MODE
4455 2003-01-18 Havoc Pennington <hp@pobox.com>
4457 * dbus/dbus-test.c: include config.h so that tests actually run
4459 * dbus/dbus-string.c: add assertions that stuff is 8-byte aligned,
4460 so the failure mode when that assumption fails will be plenty
4463 2003-01-18 Havoc Pennington <hp@pobox.com>
4465 * configure.in: default --enable-tests to $USE_MAINTAINER_MODE
4467 * dbus/Makefile.am: fix it up so dubs-test-main.c is included in
4470 * test/Makefile.am: don't use special variable "TESTS" for echo-*
4471 since we don't want to use those in make check
4473 2003-01-15 Havoc Pennington <hp@redhat.com>
4479 2003-01-15 Havoc Pennington <hp@redhat.com>
4481 * test/Makefile.am: fix so that test source code ends up in the
4482 distribution on make distcheck
4484 2003-01-15 Havoc Pennington <hp@redhat.com>
4490 2003-01-15 Havoc Pennington <hp@redhat.com>
4492 * dbus/dbus-test.c (dbus_internal_symbol_do_not_use_run_tests):
4493 fix build when --disable-tests
4495 * Makefile.am (EXTRA_DIST): put HACKING in here
4497 * HACKING: document procedure for making a tarball release.
4499 2003-01-14 Anders Carlsson <andersca@codefactory.se>
4501 * bus/connection.c: (connection_error_handler),
4502 (bus_connection_setup):
4503 * bus/main.c: (main):
4504 Make sure that the DBusConnectionData struct is NULLed
4505 out to prevent a segfault.
4507 * dbus/dbus-errors.c: (dbus_result_to_string):
4508 * dbus/dbus-errors.h:
4509 * dbus/dbus-message.c: (dbus_message_get_fields),
4510 (dbus_message_get_fields_valist), (_dbus_message_test):
4511 * dbus/dbus-message.h:
4512 Make dbus_message_get_fields return a result code so we can
4513 track invalid fields as well as oom.
4515 2003-01-11 Havoc Pennington <hp@pobox.com>
4517 * configure.in: change --enable-test/--enable-ansi action-if-given
4518 to enable_foo=$enableval instead of enable_foo=yes
4520 2003-01-08 Havoc Pennington <hp@pobox.com>
4522 * dbus/dbus-string.c (_dbus_string_align_length): new function
4524 * dbus/dbus-test-main.c: move main() for test app here
4526 (dbus_internal_symbol_do_not_use_run_tests): we have to export a
4527 symbol to run tests, because dbus-test isn't in the main
4530 Code review nitpicks.
4532 * dbus/dbus-message.c (dbus_message_write_header): add newlines
4533 for people with narrow emacs ;-). Assert client_serial was filled
4534 in. Assert message->name != NULL.
4535 (dbus_message_append_fields): have "first_field_type" arg separate
4536 from va list, needed for C++ binding that also uses varargs IIRC
4537 and helps with type safety
4538 (dbus_message_new): add @todo about using DBusString to store
4539 service/name internally
4540 (dbus_message_new): don't leak ->service and ->name on OOM later
4542 (dbus_message_unref): free the service name
4543 (dbus_message_get_fields): same change to varargs
4544 i.e. first_field_type
4545 (_dbus_message_loader_return_buffer): assert that the message data
4546 is aligned (if not it's a bug in our code). Put in verbose griping
4547 about why we set corrupted = TRUE.
4548 (decode_header_data): add FIXME that char* is evil. Was going to
4549 add FIXME about evil locale-specific string.h strncmp, but just
4550 switched to wacky string-as-uint32 optimization. Move check for
4551 "no room for field name" above get_const_data_len() to avoid
4552 assertion failure in get_const_data_len if we have trailing 2
4553 bytes or the like. Check for service and name fields being
4554 provided twice. Don't leak service/name on error. Require field
4555 names to be aligned to 4 bytes.
4557 * dbus/dbus-marshal.c: move byte swap stuff to header
4558 (_dbus_pack_int32): uscore-prefix
4559 (_dbus_unpack_int32): uscore-prefix
4560 (_dbus_unpack_uint32): export
4561 (_dbus_demarshal_string): add @todo complaining about use of
4563 (_dbus_marshal_get_field_end_pos): add @todo about bad error
4564 handling allowing corrupt data to go unchecked
4566 2003-01-08 Havoc Pennington <hp@redhat.com>
4568 * dbus/dbus-transport-unix.c (unix_do_iteration): add read/write
4569 to the select() as needed for authentication. (should be using
4570 _dbus_poll() not select, but for another day)
4572 * dbus/dbus.h: include dbus/dbus-protocol.h
4574 2003-01-08 Anders Carlsson <andersca@codefactory.se>
4576 * dbus/Makefile.am (dbusinclude_HEADERS): Install
4579 2003-01-08 Anders Carlsson <andersca@codefactory.se>
4581 * dbus/dbus-internals.c: (_dbus_type_to_string):
4582 New function that returns a string describing a type.
4584 * dbus/dbus-marshal.c: (_dbus_demarshal_byte_array):
4585 * dbus/dbus-marshal.h:
4586 * dbus/dbus-message.c: (dbus_message_get_fields_valist),
4587 (dbus_message_iter_get_field_type), (dbus_message_iter_get_double),
4588 (dbus_message_iter_get_byte_array):
4589 * dbus/dbus-message.h:
4590 Add new convenience functions for appending and getting message fields.
4591 Also add demarshalling routines for byte arrays.
4593 2003-01-07 Anders Carlsson <andersca@codefactory.se>
4595 * dbus/dbus-connection-internal.h:
4596 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
4597 (_dbus_connection_get_next_client_serial),
4598 (dbus_connection_send_message):
4599 * dbus/dbus-internals.h:
4600 * dbus/dbus-marshal.c: (unpack_uint32), (dbus_unpack_int32),
4601 (dbus_pack_int32), (_dbus_marshal_double), (_dbus_marshal_int32),
4602 (_dbus_marshal_uint32), (_dbus_demarshal_double),
4603 (_dbus_demarshal_int32), (_dbus_demarshal_uint32),
4604 (_dbus_demarshal_string), (_dbus_marshal_get_field_end_pos),
4605 (_dbus_verbose_bytes), (_dbus_marshal_test):
4606 * dbus/dbus-marshal.h:
4607 * dbus/dbus-message-internal.h:
4608 * dbus/dbus-message.c: (_dbus_message_set_client_serial),
4609 (dbus_message_write_header), (_dbus_message_lock),
4610 (dbus_message_new), (dbus_message_ref), (dbus_message_unref),
4611 (dbus_message_get_name), (dbus_message_append_int32),
4612 (dbus_message_append_uint32), (dbus_message_append_double),
4613 (dbus_message_append_string), (dbus_message_append_byte_array),
4614 (dbus_message_get_fields_iter), (dbus_message_iter_ref),
4615 (dbus_message_iter_unref), (dbus_message_iter_has_next),
4616 (dbus_message_iter_next), (dbus_message_iter_get_field_type),
4617 (dbus_message_iter_get_string), (dbus_message_iter_get_int32),
4618 (dbus_message_iter_get_uint32), (dbus_message_iter_get_double),
4619 (decode_header_data), (_dbus_message_loader_return_buffer),
4620 (message_iter_test), (_dbus_message_test):
4621 * dbus/dbus-message.h:
4622 * dbus/dbus-protocol.h:
4623 * dbus/dbus-test.c: (main):
4625 * glib/test-dbus-glib.c: (message_handler), (main):
4626 * test/echo-client.c: (main):
4627 * test/watch.c: (check_messages):
4628 Make messages sendable and receivable for real.
4630 2003-01-07 Anders Carlsson <andersca@codefactory.se>
4632 * dbus/dbus-marshal.c: (_dbus_marshal_double),
4633 (_dbus_marshal_string), (_dbus_marshal_byte_array):
4634 * dbus/dbus-message.c: (dbus_message_append_int32),
4635 (dbus_message_append_uint32), (dbus_message_append_double),
4636 (dbus_message_append_string), (dbus_message_append_byte_array):
4637 Handle OOM restoration.
4639 2003-01-07 Anders Carlsson <andersca@codefactory.se>
4641 * dbus/dbus-marshal.c: (_dbus_marshal_string),
4642 (_dbus_demarshal_string), (_dbus_marshal_test):
4643 * dbus/dbus-marshal.h:
4644 * dbus/dbus-message.c: (dbus_message_get_name),
4645 Document these functions.
4647 (dbus_message_append_int32), (dbus_message_append_uint32),
4648 (dbus_message_append_double), (dbus_message_append_string),
4649 (dbus_message_append_byte_array):
4650 * dbus/dbus-message.h:
4651 Add functions for adding message fields of different types.
4653 * dbus/dbus-protocol.h:
4654 Add the different types.
4656 2003-01-05 Havoc Pennington <hp@pobox.com>
4658 * bus/connection.c: implement routines for handling connections,
4659 first thing is keeping a list of owned services on each connection
4660 and setting up watches etc.
4662 * bus/services.c: implement a mapping from service names to lists
4665 * dbus/dbus-hash.c: add DBUS_HASH_POINTER
4667 * dbus/dbus-threads.c (dbus_static_mutex_lock): add functions
4668 to use static mutexes for global data
4670 * dbus/dbus-connection.c (dbus_connection_set_data): add new
4671 collection of functions to set/get application-specific data
4672 on the DBusConnection.
4674 2003-01-04 Havoc Pennington <hp@pobox.com>
4676 * dbus/dbus-sysdeps.c (_dbus_sleep_milliseconds): new function
4677 (_dbus_poll): new function
4679 * dbus/dbus-internals.h (_DBUS_STRUCT_OFFSET): new macro
4682 * bus/loop.c: initial code for the daemon main loop
4684 2003-01-04 Havoc Pennington <hp@pobox.com>
4686 * test/watch.c (error_handler): make it safe if the error handler
4687 is called multiple times (if we s/error handler/disconnect
4688 handler/ we should just guarantee it's called only once)
4690 * dbus/dbus-transport.c (_dbus_transport_disconnect): call the
4691 error handler on disconnect (it's quite possible we should
4692 just change the error handler to a "disconnect handler," I'm
4693 not sure we have any other meaningful errors)
4695 * configure.in: check for getpwnam_r
4697 * dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
4698 dbus/dbus-auth.c: add credentials support, add EXTERNAL auth
4699 mechanism as in SASL spec, using socket credentials
4701 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): new function
4702 (_dbus_send_credentials_unix_socket): new function
4704 * dbus/dbus-sysdeps.c (_dbus_accept_unix_socket): rename just
4706 (_dbus_write): only check errno if <0 returned
4707 (_dbus_write_two): ditto
4709 2003-01-02 Anders Carlsson <andersca@codefactory.se>
4711 * dbus/dbus-marshal.c: (_dbus_marshal_utf8_string),
4712 (_dbus_marshal_byte_array), (_dbus_demarshal_utf8_string),
4713 (_dbus_marshal_test):
4714 * dbus/dbus-marshal.h:
4715 Add _dbus_marshal_byte_array and rename _dbus_marshal_string
4716 to _dbus_marshal_utf8_string. Also fix some tests.
4718 2002-12-28 Harri Porten <porten@kde.org>
4720 * configure.in: added check for C++ compiler and a very cheesy
4721 check for the Qt integration
4723 * Makefile.am (SUBDIRS): compile qt subdir if support is enabled
4725 * qt/Makefile.am: added
4727 * qt/.cvsignore: added
4729 * qt/dbus-qthread.cc, qt/dbus-qthread.cpp: renamed former to
4730 latter, added #ifdef QT_THREAD_SUPPORT guard.
4732 * dbus/Makefile.am: added missing headers for make dist
4734 2002-12-28 Kristian Rietveld <kris@gtk.org>
4736 * dbus/Makefile.am: fixup export-symbols-regex.
4738 2002-12-27 Anders Carlsson <andersca@codefactory.se>
4740 * acinclude.m4: Add this file and put the
4741 PKG_CHECK_MODULE macro in it.
4743 2002-12-27 Anders Carlsson <andersca@codefactory.se>
4745 * dbus/dbus-marshal.c: (_dbus_marshal_string),
4746 (_dbus_demarshal_double), (_dbus_demarshal_int32),
4747 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
4748 (_dbus_marshal_test):
4749 Make the demarshalling routines align the pos argument.
4750 Add string marshalling tests and fix the obvious bugs
4753 2002-12-26 Havoc Pennington <hp@pobox.com>
4755 * dbus/dbus-auth.c: fixes fixes fixes
4757 * dbus/dbus-transport-unix.c: wire up support for
4758 encoding/decoding data on the wire
4760 * dbus/dbus-auth.c (_dbus_auth_encode_data)
4761 (_dbus_auth_decode_data): append to target string
4762 instead of nuking it.
4764 2002-12-26 Havoc Pennington <hp@pobox.com>
4766 * dbus/dbus-marshal.h (DBUS_COMPILER_BYTE_ORDER): #ifdef
4767 WORDS_BIGENDIAN then compiler byte order is DBUS_BIG_ENDIAN,
4770 * dbus/dbus-marshal.c: Add macros to do int swapping in-place and
4771 avoid swap_bytes() overhead (ignoring possible assembly stuff for
4772 now). Main point is because I wanted unpack_uint32 to implement
4774 (_dbus_verbose_bytes): new function
4776 * dbus/dbus-string.c (_dbus_string_validate_ascii): new function
4778 * dbus/dbus-message.c (_dbus_message_loader_get_is_corrupted): add
4779 mechanism to handle a corrupt message stream
4780 (_dbus_message_loader_new): fix preallocation to only prealloc,
4783 * dbus/dbus-string.c (_dbus_string_skip_blank): fix this function
4784 (_dbus_string_test): enhance tests for copy/move and fix the
4787 * dbus/dbus-transport-unix.c: Hold references in more places to
4788 avoid reentrancy problems
4790 * dbus/dbus-transport.c: ditto
4792 * dbus/dbus-connection.c (dbus_connection_dispatch_message): don't
4793 leak reference count in no-message case
4795 * test/watch.c (do_mainloop): handle adding/removing watches
4796 during iteration over the watches. Also, ref the connection/server
4797 stored on a watch, so we don't try to mangle a destroyed one.
4799 * dbus/dbus-transport-unix.c (do_authentication): perform
4802 * dbus/dbus-auth.c (get_state): add a state
4803 AUTHENTICATED_WITH_UNUSED_BYTES and return it if required
4804 (_dbus_auth_get_unused_bytes): append the unused bytes
4805 to the passed in string, rather than prepend
4807 * dbus/dbus-transport.c (_dbus_transport_init_base): create
4808 the auth conversation DBusAuth
4810 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd)
4811 (_dbus_transport_new_for_domain_socket): when creating a
4812 transport, pass in whether it's a client-side or server-side
4813 transport so we know which DBusAuth to create
4815 2002-12-03 Havoc Pennington <hp@pobox.com>
4817 * dbus/dbus-transport-unix.c (unix_finalize): finalize base
4818 _after_ finalizing the derived members
4819 (unix_connection_set): unref watch if we fail to add it
4821 * dbus/dbus-connection.c (dbus_connection_unref): delete the
4822 transport first, so that the connection owned by the
4823 transport will be valid as the transport finalizes.
4825 * dbus/dbus-transport-unix.c (unix_finalize): free the write_watch
4826 if necessary, and remove watches from the connection.
4828 * dbus/dbus-watch.c (_dbus_watch_list_free): improve a comment
4830 2002-12-26 Anders Carlsson <andersca@codefactory.se>
4832 * dbus/dbus-marshal.c: (_dbus_marshal_string),
4833 (_dbus_demarshal_double), (_dbus_demarshal_int32),
4834 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
4835 (_dbus_marshal_test):
4836 * dbus/dbus-marshal.h:
4837 Add string marshal functions and have the demarshal functions
4838 return the new position.
4840 2002-12-25 Havoc Pennington <hp@pobox.com>
4842 * doc/dbus-sasl-profile.txt: docs on the authentication protocol,
4843 it is a simple protocol that just maps directly to SASL.
4845 * dbus/dbus-auth.h, dbus/dbus-auth.c: authentication protocol
4846 initial implementation, not actually used yet.
4848 * dbus/dbus-string.c (_dbus_string_find): new function
4849 (_dbus_string_equal): new function
4850 (_dbus_string_base64_encode): new function
4851 (_dbus_string_base64_decode): new function
4853 2002-12-25 Anders Carlsson <andersca@codefactory.se>
4856 * dbus/dbus-marshal.c: (swap_bytes), (_dbus_marshal_double),
4857 (_dbus_marshal_int32), (_dbus_marshal_uint32),
4858 (_dbus_demarshal_double), (_dbus_demarshal_int32),
4859 (_dbus_demarshal_uint32), (_dbus_marshal_test):
4860 * dbus/dbus-marshal.h:
4861 * dbus/dbus-protocol.h:
4862 * dbus/dbus-test.c: (main):
4864 Add un-optimized marshalling/demarshalling routines.
4866 2002-12-25 Harri Porten <porten@kde.org>
4868 * qt/dbus-qt.h: adjusted ctor and getter to KDE/Qt conventions
4870 2002-12-24 Zack Rusin <zack@kde.org>
4872 * qt/dbus-qthread.cc: adding - integrates QMutex into Dbus
4873 * qt/dbus-qt.h: skeleton with two sample implemenatation of the
4876 2002-12-24 Havoc Pennington <hp@pobox.com>
4878 * glib/dbus-gthread.c: fix include
4880 * glib/dbus-glib.h: rename DBusMessageHandler for now.
4881 I think glib API needs to change, though, as you don't
4882 want to use DBusMessageFunction, you want to use the
4883 DBusMessageHandler object. Probably
4884 dbus_connection_open_with_g_main_loop()
4885 and dbus_connection_setup_g_main_loop() or something like that
4886 (but think of better names...) that just create a connection
4887 that has watch/timeout functions etc. already set up.
4889 * dbus/dbus-connection.c
4890 (dbus_connection_send_message_with_reply): new function just to
4891 show how the message handler helps us deal with replies.
4893 * dbus/dbus-list.c (_dbus_list_remove_last): new function
4895 * dbus/dbus-string.c (_dbus_string_test): free a string that
4898 * dbus/dbus-hash.c: use memory pools for the hash entries
4899 (rebuild_table): be more paranoid about overflow, and
4900 shrink table when we can
4901 (_dbus_hash_test): reduce number of sprintfs and write
4902 valid C89. Add tests for case where we grow and then
4903 shrink the hash table.
4905 * dbus/dbus-mempool.h, dbus/dbus-mempool.c: memory pools
4907 * dbus/dbus-connection.c (dbus_connection_register_handler)
4908 (dbus_connection_unregister_handler): new functions
4910 * dbus/dbus-message.c (dbus_message_get_name): new
4912 * dbus/dbus-list.c: fix docs typo
4914 * dbus/dbus-message-handler.h, dbus/dbus-message-handler.c:
4915 an object representing a handler for messages.
4917 2002-12-16 Anders Carlsson <andersca@codefactory.se>
4920 * glib/dbus-gthread.c: (dbus_gthread_init):
4921 Don't use the gdbus prefix for public functions.
4923 2002-12-16 Anders Carlsson <andersca@codefactory.se>
4927 Add GLib checks and fixup .pc files
4931 * glib/dbus-gmain.c: (gdbus_connection_prepare),
4932 (gdbus_connection_check), (gdbus_connection_dispatch),
4933 (gdbus_add_connection_watch), (gdbus_remove_connection_watch),
4934 (dbus_connection_gsource_new):
4935 * glib/dbus-gthread.c: (dbus_gmutex_new), (dbus_gmutex_free),
4936 (dbus_gmutex_lock), (dbus_gmutex_unlock), (dbus_gthread_init):
4937 * glib/test-dbus-glib.c: (message_handler), (main):
4940 2002-12-15 Harri Porten <porten@kde.org>
4942 * autogen.sh: check for libtoolize before attempting to use it
4944 * dbus/dbus-transport-unix.c: include <sys/time.h> for timeval
4947 * .cvsignore: ignore more stamp files
4949 * dbus/dbus-watch.c (_dbus_watch_list_new): fixed doc error
4951 * test/Makefile.am: added -I$(top_srcdir) to be able to compile
4952 without make install.
4954 2002-12-15 Havoc Pennington <hp@pobox.com>
4956 * dbus/dbus-threads.c: add thread stubs that a higher library
4957 layer can fill in. e.g. the GLib wrapper might fill them in with
4958 GThread stuff. We still need to use this thread API to
4959 thread-safe-ize the library.
4961 2002-12-12 Havoc Pennington <hp@pobox.com>
4963 * dbus/dbus-transport-unix.c, dbus/dbus-server-unix.c: use the
4964 below new interfaces and include fewer system headers.
4966 * dbus/dbus-sysdeps.c (_dbus_read): new function
4967 (_dbus_write): new function
4968 (_dbus_write_two): new function
4969 (_dbus_connect_unix_socket): new function
4970 (_dbus_listen_unix_socket): new function
4972 * dbus/dbus-message-internal.h: change interfaces to use
4975 2002-12-11 Havoc Pennington <hp@pobox.com>
4977 * dbus/dbus-types.h: add dbus_unichar
4979 * dbus/dbus-internals.c (_dbus_verbose): use _dbus_getenv
4981 * dbus/dbus-connection.c (dbus_connection_send_message): return
4984 * dbus/dbus-transport.c: include dbus-watch.h
4986 * dbus/dbus-connection.c: include dbus-message-internal.h
4988 * HACKING: add file with coding guidelines stuff.
4990 * dbus/dbus-string.h, dbus/dbus-string.c: Encapsulate all string
4991 handling here, for security purposes (as in vsftpd). Not actually
4992 using this class yet.
4994 * dbus/dbus-sysdeps.h, dbus/dbus-sysdeps.c: Encapsulate all
4995 system/libc usage here, as in vsftpd, for ease of auditing (and
4996 should also simplify portability). Haven't actually moved all the
4997 system/libc usage into here yet.
4999 2002-11-25 Havoc Pennington <hp@pobox.com>
5001 * dbus/dbus-internals.c (_dbus_verbose): fix to not
5002 always print the first verbose message.
5004 2002-11-24 Havoc Pennington <hp@pobox.com>
5006 * test/echo-client.c, test/echo-server.c: cheesy test
5009 * configure.in (AC_CHECK_FUNCS): check for writev
5011 * dbus/dbus-message.c (_dbus_message_get_network_data): new
5014 * dbus/dbus-list.c (_dbus_list_foreach): new function
5016 * dbus/dbus-internals.c (_dbus_verbose): new function
5018 * dbus/dbus-server.c, dbus/dbus-server.h: public object
5019 representing a server that listens for connections.
5021 * dbus/.cvsignore: create
5023 * dbus/dbus-errors.h, dbus/dbus-errors.c:
5024 public API for reporting errors
5026 * dbus/dbus-connection.h, dbus/dbus-connection.c:
5027 public object representing a connection that
5028 sends/receives messages. (Same object used for
5029 both client and server.)
5031 * dbus/dbus-transport.h, dbus/dbus-transport.c:
5032 Basic abstraction for different kinds of stream
5033 that we might read/write messages from.
5035 2002-11-23 Havoc Pennington <hp@pobox.com>
5037 * dbus/dbus-internals.h (_DBUS_INT_MAX): add _DBUS_INT_MIN
5040 * dbus/dbus-test.c (main): add list test, and include
5041 dbus-test.h as intended
5043 * dbus/dbus-hash.c (_dbus_hash_table_remove_string)
5044 (_dbus_hash_table_remove_int): return value indicates
5045 whether the entry existed to remove
5047 * dbus/dbus-list.c: add linked list utility class,
5050 * dbus/dbus-hash.c: add TODO item about shrinking the hash bucket
5053 2002-11-23 Havoc Pennington <hp@pobox.com>
5055 * Doxyfile.in (INCLUDE_FILE_PATTERNS): expand DBUS_BEGIN_DECLS/
5056 DBUS_END_DECLS to nothing, that should fix this once and for all
5058 * Doxyfile.in (JAVADOC_AUTOBRIEF): set to YES
5060 * dbus/dbus-message.c, dbus/dbus-hash.c:
5061 add some missing @brief
5063 2002-11-23 Havoc Pennington <hp@pobox.com>
5065 * dbus/dbus-message.h: put semicolons after DEBUG_BEGIN_DECLS
5066 to avoid confusing Doxygen
5068 * dbus/dbus-hash.c: @} not }@
5070 * dbus/dbus-message.c (struct DBusMessage): split out
5073 2002-11-23 Havoc Pennington <hp@pobox.com>
5075 * configure.in: pile on more warning flags if using gcc
5077 * Doxyfile.in (EXTRACT_STATIC): set to NO, so we don't have
5078 to document static functions
5080 * configure.in: add summary to end of configure so it
5081 looks nice and attractive
5083 * dbus/dbus-hash.c: finish implementation and write unit
5086 * configure.in: add --enable-tests to enable unit tests
5088 * dbus/dbus-test.c: test program to run unit tests
5089 for all files in dbus/*, initially runs a test for
5092 * dbus/dbus-internals.h: file to hold some internal utility stuff
5094 2002-11-22 Havoc Pennington <hp@redhat.com>
5096 * dbus/dbus-hash.c: copy in Tcl hash table, not yet
5097 "ported" away from Tcl
5099 * dbus/dbus-types.h: header for types such as dbus_bool_t
5101 2002-11-22 Havoc Pennington <hp@redhat.com>
5103 * dbus/dbus.h: fixups for doc warnings
5105 * Doxyfile.in (FILE_PATTERNS): we need to scan .h to pick up
5107 (QUIET): make it quiet so we can see warnings
5109 * dbus/dbus-memory.c: teach D-BUS to allocate and free memory
5111 2002-11-22 Havoc Pennington <hp@redhat.com>
5113 * Makefile.am: include "Doxyfile" target in all-local
5115 * configure.in: generate the Doxyfile
5117 * Doxyfile.in: move Doxyfile here, so we can use
5118 configure to generate a Doxyfile with the right
5121 2002-11-22 Havoc Pennington <hp@redhat.com>
5123 * dbus/dbus-message.c: move inline docs into .c file
5125 * Doxyfile (OUTPUT_DIRECTORY): move output to doc/api
5126 so all docs are under doc/
5127 (MAN_EXTENSION): generate man pages. Use extension
5128 ".3dbus" which matches ".3qt" on my system,
5129 I guess this is OK, I don't know really.
5130 (FILE_PATTERNS): look for .c files not .h, makes sense
5133 2002-11-22 Havoc Pennington <hp@pobox.com>
5135 * Makefile.am (SUBDIRS): rename subdir "server" to "bus"
5136 because any app can be a server, and any app can be a client,
5137 the bus is a special kind of server.
5139 Thu Nov 21 23:35:31 2002 Zack Rusin <zack@kde.org>
5141 * Doxyfile : adding. Still needs Makefile rules to be generated
5142 automatically (just run "doxygen" in the toplevel dir for now to
5145 * dbus/dbus-message.h : Adding sample docs (javadoc since
5146 resembles gtk-doc a little more)
5148 * dbus/dbus.h : Adding sample docs
5150 2002-11-21 Havoc Pennington <hp@redhat.com>
5152 * dbus/Makefile.am (INCLUDES): define DBUS_COMPILATION
5153 so we can allow ourselves to include files directly,
5154 instead of having to use dbus.h
5156 * dbus/dbus.h: fill in
5158 * dbus/dbus-message.h: sketch out a sample header file.
5159 Include griping if you include it directly instead of
5162 * dbus/dbus-macros.h: new file with macros for extern "C",
5163 TRUE/FALSE, NULL, etc.
5165 * doc/file-boilerplate.c: put include guards in here
5167 2002-11-21 Havoc Pennington <hp@redhat.com>
5169 * doc/file-boilerplate.c: include both AFL and GPL boilerplate.
5171 * COPYING: include the GPL as well, and license code
5172 under both AFL and GPL.
5174 2002-11-21 Havoc Pennington <hp@redhat.com>
5176 * acconfig.h: get rid of this
5178 * autogen.sh (run_configure): add --no-configure option
5180 * configure.in: remove AC_ARG_PROGRAM to make
5181 autoconf complain less. add AC_PREREQ.
5182 add AC_DEFINE third arg.
5184 2002-11-21 Anders Carlsson <andersca@codefactory.se>
5187 Fix references so we can distcheck.
5189 2002-11-21 Havoc Pennington <hp@redhat.com>
5191 * Initial module creation