1 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
5 * tests/cp/fail-perm: source lang-default.
6 * tests/rm/inaccessible: Likewise.
8 2006-05-28 Jim Meyering <jim@meyering.net>
10 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
11 Recognize it, too. Reported by Ralf Wildenhues, in
12 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
14 2006-05-27 Jim Meyering <jim@meyering.net>
16 * src/chgrp.c: Support new options: --preserve-root and
17 --no-preserve-root. Somehow this program was skipped when those
18 options were added to chown, chmod, and rm. Reported by
19 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
22 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
24 * NEWS: Remove mention of --seed. We'll replace it with something
25 better, and don't want to indicate that it is supported.
26 * src/sort.c (usage): Likewise.
28 2006-05-20 Jim Meyering <jim@meyering.net>
30 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
32 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
33 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
34 FTS_COMFOLLOW. Spotted by Justin Pryzby.
36 * gnupload: Merge changes from automake, retaining the ""--to...
37 kludge to placate overzealous `make distcheck' check.
39 2006-05-19 Jim Meyering <jim@meyering.net>
41 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
42 FTS_TIGHT_CYCLE_CHECK directory traversal option.
43 Reported by Justin Pryzby in http://bugs.debian.org/367691
45 2006-05-15 Jim Meyering <jim@meyering.net>
47 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
50 2006-05-13 Jim Meyering <jim@meyering.net>
52 * tests/mv/no-target-dir: Test two more cases.
54 2006-05-11 Jim Meyering <jim@meyering.net>
56 mv -T DIR EMPTY_DIR no longer fails unconditionally
57 * src/copy.c (copy_internal): Don't manually prohibit a move where
58 the destination is an existing directory. Sometimes doing that is
59 valid. Let the rename system call enforce the rules. That is
60 allowed only when the source is a directory and the destination
61 directory (to be replaced) is empty. Reported by Eric Blake.
62 * tests/mv/no-target-dir: New file/test for this.
63 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
66 * tests/mv/atomic: New file/test for yesterday's fix.
67 * tests/mv/Makefile.am (TESTS): Add atomic.
69 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
71 2006-05-10 Jim Meyering <jim@meyering.net>
73 * src/copy.c (copy_internal): Don't explicitly unlink the destination
74 when moving a symlink into the place of an existing non-directory.
75 Reported by Joshua Hudson.
78 2006-05-07 Jim Meyering <jim@meyering.net>
80 * Makefile.maint (patch-check): Fail if patch generates any output,
81 even merely for changed offsets.
83 * src/c99-to-c89.diff: Adjust to reflect new offsets.
85 * NEWS: Mention changes affecting df, pwd, shred.
87 2006-05-06 Jim Meyering <jim@meyering.net>
89 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
90 system condition where dirent.d_ino != stat.st_ino.
91 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
93 2006-05-06 Eric Blake <ebb9@byu.net>
95 * tests/ls/inode: Expand to test inode from readdir case.
96 * tests/ls/follow-slink: Expand to test broken links encountered
97 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
99 2006-05-06 Eric Blake <ebb9@byu.net>
101 * tests/mv/leak-fd: Work even on case-insensitive file system.
103 2006-05-04 Jim Meyering <jim@meyering.net>
105 * NEWS: Mention the 2006-03-19 pwd-related change that makes
106 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
108 2006-05-03 Jim Meyering <jim@meyering.net>
110 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
111 Use better macro parameter names: s/basename/key_name/,
112 s/basefunc/key_cmp_func. Fix typo in comment.
114 2006-04-29 Eric Blake <ebb9@byu.net>
116 * src/ls.c (main): On systems with d_type, directories_first only
117 implies format_needs_type, not format_needs_stat.
119 2006-05-03 Jim Meyering <jim@meyering.net>
121 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
122 after comma in arg list, from Eric Blake.
124 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
126 * tests/misc/date (relative-3): New test, derived from a bug
127 report by John Thomas McDole.
129 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
131 New option for ls: --group-directories-first.
132 It makes ls list directories before files.
133 * NEWS [New features]: Mention it.
134 * src/ls.c (sort_type): Rearrange to use as an array index when
135 choosing sort function; added new sort_numtypes member for
137 (time_type): Add new time_numtypes member for compile-time check.
138 (directories_first): New global variable.
139 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
140 (long_options): Add --directories-first.
141 (main): Support new option.
142 (is_directory): New function.
143 (extract_dirs_from_files): Use it.
144 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
145 (LIST_SORTFUNCTION_VARIANTS): New macros.
146 (sort_functions): New global variable.
147 (sort_files): Use it.
148 (usage): Document new option.
150 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
152 * src/shred.c (fillrand): The assertion was way too weak, due to
153 what must be a typo. Strengthen it to its intended value.
154 (dopass): Don't use alloca; it's not worth the aggravation here,
155 since it's used only to get a page-aligned buffer, and page
156 alignment doesn't buy us much here. I'm suspicious that alloca
157 causes problems on some hosts, due to a recent bug report by Adam
158 Waltman: http://bugs.gentoo.org/130246.
160 2006-04-18 Jim Meyering <jim@meyering.net>
162 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
163 sha384sum, sha512sum.
165 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
167 * src/chmod.c (describe_change): Adjust to filemode changes.
168 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
169 (print_long_format): Use (new) filemodestring rather than
170 (old) mode_string, so that we get more file types right, at least
171 in theory. Adjust to filemode changes.
172 * src/stat.c (human_access): Likewise.
174 2006-04-18 Jim Meyering <jim@meyering.net>
176 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
177 ignore file. This has never been enabled. Reported by Eric Blake.
179 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
181 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
182 bug in Interix. Just call symlink or link directly. All uses changed.
183 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
184 * src/stat.c (USE_STATVFS): New macro.
185 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
186 (NAMEMAX_FORMAT): define a bit more clearly, now that the
187 statvfs-using code is a bit more regular.
188 * src/system.h (sync) [!HAVE_SYNC]: New macro.
190 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
192 * NEWS: csplit, nl, expr now conform to POSIX better, and are
193 more-compatible with traditional Unix, with respect to regular
195 * src/csplit.c (extract_regexp): Set re_syntax_options to a
196 value that is compatible with what POSIX requires.
197 * src/nl.c (build_type_arg): Likewise.
198 * src/expr.c (docolon): Likewise. Also, don't let anchors match
199 newline; this fixes an incompatibility with tradition and with POSIX.
200 Don't warn about leading ^. POSIX says it is unspecified whether
201 ^ is a special character, which means that implementations can
202 either treat it as special or not, but either way a warning is not
203 allowed (unless the regexp is otherwise invalid). Instead, anchor
204 the expression but treat ^ as an anchor; this is the traditional
205 behavior (e.g., Solaris 10).
206 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
207 and the like as invalid expressions (exit status 2), not as
208 failure of 'expr' (exit status 3). This is more consistent with
210 * tests/expr/basic (fail-a): Adjust exit status to match new expr
211 behavior, for status 2 versus 3.
213 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
214 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
215 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
216 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
217 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
218 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
219 (bre61, bre62): New tests.
220 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
224 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
225 "if !". Do not assume that 'sed' can handle long, newline-free input.
226 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
228 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
230 Adjust to new regex.h API (with new fastmap type), and clean
231 up the regex storage allocation a bit.
233 * src/csplit.c (struct control): Put re_compiled member at the
234 end, since it's large. Change regexpr member from char * to bool;
235 all uses changed. Add new member fastmap.
236 (extract_regexp): regexp arg is now char const *, not char *.
237 Don't bother duplicating the regular expression; it's not needed.
238 Set fastmap from new fastmap member. Don't bother allocating
239 a buffer, as the regexp code does a better job than we do.
240 * src/expr.c (docolon): Allocate and use a fastmap.
241 Don't bother allocating a buffer.
242 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
244 (build_type_arg): New fastmap arg. All uses changed.
245 Don't bother allocating a buffer, but set a fastmap.
246 * src/ptx.c (context_regex_string, word_regex_string): Remove.
247 (context_regex, word_regex): New vars, replacing the above.
249 (struct regex_data): New type.
250 (compile_regex): Renamed from alloc_and_compile_regex, since
251 we no longer allocate storage. Arg is now a struct regex_data *,
252 not a const char *. All uses changed. Don't allocate the fastmap;
253 instead, take it from the caller. Don't convert size_t to int,
254 to avoid arithmetic overflow problems. Don't bother freeing
255 storage afterwards; it's not worth the aggravation.
256 * src/tac.c (compiled_separator_fastmap): New ver.
257 (main): Use it. Don't bother allocating a buffer.
259 2006-03-30 Jim Meyering <jim@meyering.net>
261 * src/dd.c (iwrite): Remove assignment without effect.
262 Reported by Felix Rauch Valenti.
264 2006-03-22 Eric Blake <ebb9@byu.net>
266 * src/ptx.c (usage): Remove mention of --copyright/-C.
267 (main): Alias --copyright to --version plus a deprecation warning.
268 * NEWS: Mention this.
270 2006-03-27 Jim Meyering <jim@meyering.net>
272 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
273 use of strtod. Tiny patch from Nickolai Zeldovich.
275 2006-03-11 Eric Blake <ebb9@byu.net>
277 * tests/misc/dirname: New file.
278 * tests/basename/Makefile.am: Delete.
279 * tests/basename/basic: Move to...
280 * tests/misc/basename: ... this new file. Add some tests,
281 including fixed behavior for //.
282 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
283 * tests/Makefile.am (SUBDIRS): Remove basename.
284 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
286 Improvements to dirname/basename handling on platforms like
287 cygwin with distinct // and with drive letters.
288 * NEWS: Document new behavior.
289 * src/basename.c (main): Don't strip suffix from file system
291 * src/cp.c (target_directory_operand): Use new last_component.
292 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
293 traversing the string.
294 * src/dircolors.c (guess_shell_syntax): Use new last_component.
295 * src/install.c (target_directory_operand, install_file_in_dir):
297 * src/ln.c (target_directory_operand, main): Likewise.
298 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
299 * src/mv.c (target_directory_operand, movefile): Likewise.
300 * src/remove.c (rm_1): Likewise.
301 * src/shred.c (wipename): Likewise.
302 * src/split.c (next_file_name): Likewise.
303 * src/su.c (log_su, run_shell): Likewise.
305 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
307 * NEWS: nohup diagnostics are now more precise, and nohup now
308 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
309 * src/nohup.c (main): Implement this.
310 * tests/misc/nohup: Test the new behavior.
312 2006-03-12 Jim Meyering <jim@meyering.net>
314 * src/copy.c (set_author): Rename function, from preserve_author.
316 * src/remove.c (AD_pop_and_chdir): Use new macro,
317 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
319 * src/system.h (SAME_INODE): Remove definition.
320 Include "same-inode.h", instead.
322 2006-03-11 Eric Blake <ebb9@byu.net>
324 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
326 2006-03-10 Jim Meyering <jim@meyering.net>
328 Fix a bug whereby a user with write access to a directory being removed
329 could cause the removal of that directory to fail with an erroneous
330 diagnostic about a directory cycle. Reported by Vineet Chadha.
332 * NEWS: Mention this.
333 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
334 leave (and try to rmdir) is the one whose dev_ino is being used to
335 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
337 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
339 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
340 * src/dd.c (set_fd_flags): Handle file-creation flags on file
341 descriptors, rather than ignoring them.
342 * tests/dd/misc: Add test cases for append, nofollow, directory,
343 and nolinks flags. Simplify redirection to /dev/null in some cases.
345 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
346 noatime test never tested anything.
348 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
350 * src/dd.c (flags, usage): New flags directory, nolinks.
351 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
353 * src/ls.c (usage): Mention that -f disables --color.
354 Problem reported by Niels Möller.
356 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
358 * man/*.x: Add references to syscalls from utilities of the same name.
360 2006-03-05 Jim Meyering <jim@meyering.net>
362 * tests/help-version: Set SHELL, if not already set, in order to
363 avoid failure when `make check' is run through debuild; dircolors
364 would fail due to lack of $SHELL. Reported by Sven Joachim.
366 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
367 * src/base64.c (wrap_write, do_encode, main): Change type of
368 parameters and locals, wrap_column, form size_t to uintmax_t.
369 (main): Adjust to use xstrtoumax, accordingly.
371 2006-03-03 Jim Meyering <jim@meyering.net>
373 Don't fail when run from an environment with SHELL not a Bourne
374 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
375 * tests/dircolors/simple: Invoke each non-failing test with -b.
376 Reported by Michael Stone.
378 2006-02-27 Jim Meyering <jim@meyering.net>
380 * tests/misc/base64: Derive --decode-using tests from the
383 * tests/misc/base64: Factor out a long constant string.
384 Split lines to stay within 80 columns.
386 * tests/misc/Makefile.am (TESTS): Add base64.
387 * tests/misc/base64: Test base64. From Simon Josefsson.
389 * src/base64.c (do_decode): Use correct type for parameter,
390 ignore_garbage: s/size_t/bool/.
392 * src/base64.c: Don't include .h files already included by system.h:
393 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
394 Include "system.h" before the other lib/*.h header files.
395 Include <sys/types.h> before "system.h".
396 (wrap_write): Remove declaration of unused local, initial_column.
397 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
399 * README: Add base64 to the list.
401 2006-02-17 Simon Josefsson <jas@extundo.com>
404 * AUTHORS: Mention base64.
406 * man/Makefile.am: Build base64.1.
407 * man/base64.x: New file.
408 * src/Makefile.am (bin_PROGRAMS): Add base64.
409 * src/base64.c: New file.
411 2006-02-25 Eric Blake <ebb9@byu.net>
413 In ls, avoid calling stat for --inode (-i), when possible.
414 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
415 * src/system.h: ... here, for use in ...
416 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
418 (gobble_file): Add inode argument.
419 (print_dir): Pass inode if available.
420 (usage): Remove inaccuracy.
422 2006-02-23 Jim Meyering <jim@meyering.net>
424 * TODO: Update/correct some obsolete entries.
426 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
428 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
429 * src/join.c (usage): Likewise.
430 Documentation problem reported by Philip Kensche.
432 2006-02-20 Eric Blake <ebb9@byu.net>
434 * man/rm.x: Update documentation to match previous patch.
436 2006-02-18 Eric Blake <ebb9@byu.net>
438 New option for rm: --interactive=once (-I).
439 * NEWS: Document it, along with change to rm --interactive.
440 * TODO: Remove entry for implementing rm -I
441 * src/rm.c (INTERACTIVE_OPTION): New enum value.
442 (interactive_type): New enum.
443 (long_opts): Let interactive take an optional argument.
444 (interactive_args, interactive_types): New option arguments.
445 (usage): Document -I, --interactive=WHEN. Use program_name
446 instead of a basename.
447 (main): New -I option, new behavior to --interactive.
448 * tests/rm/interactive-once: New tests.
449 * tests/rm/interactive-always: Ditto.
450 * tests/rm/Makefile.am (TESTS): Run them.
452 2006-02-18 Jim Meyering <jim@meyering.net>
454 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
455 expression match more of the target lines, e.g., those that start with
456 `-S,' (short option followed by a comma) or that include `=[...]'.
457 Patch by Nicolas François.
458 Fix the four offenders thus exposed:
459 * src/join.c (usage): Use two spaces (not one) to separate the
460 --first-only option string from its description, so help2man formats
461 the derived man page properly.
462 * src/pr.c (usage): Likewise.
463 * src/uniq.c (usage): Likewise.
464 * src/install.c (usage): Likewise.
466 2006-02-15 Jim Meyering <jim@meyering.net>
468 * Makefile.maint (alpha beta major): For `make major', ensure that the
469 version string is of the form N.N[.N]*, where N is one or more digits.
471 2006-02-14 Jim Meyering <jim@meyering.net>
473 * INSTALL: Update from gnulib.
475 2006-02-13 Jim Meyering <jim@meyering.net>
477 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
479 2006-02-12 Jim Meyering <jim@meyering.net>
481 * Makefile.maint (patch-check): New target.
482 (local-checks-available): Add to the list.
484 2006-02-11 Jim Meyering <jim@meyering.net>
486 * src/c99-to-c89.diff: New file.
487 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
489 * .x-po-check: New file, with exclusions so that `make distcheck'
491 * Makefile.am (EXTRA_DIST): Add .x-po-check.
493 rm -r must remove an empty directory, even if it is inaccessible.
494 * src/remove.c (close_preserve_errno): New function.
495 (fd_to_subdirp): Don't print a diagnostic in this function.
496 Do it from the callers instead, unless rmdir succeeds.
497 (remove_cwd_entries, remove_dir): Adjust callers.
498 * tests/rm/empty-inacc: New test for the above.
499 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
500 * NEWS: Mention this bug fix.
501 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
502 a tiny bit less precise: cannot remove `a/1': ... instead of
503 cannot open directory `a/1': ...
505 * Makefile.maint (syntax-check-rules): Automatically derive this
506 list of sc_-prefixed rule names.
508 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
510 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
511 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
512 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
513 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
514 go away? was that an accident?)
515 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
516 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
517 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
518 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
519 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
520 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
521 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
522 (author_mark_check, makefile_path_separator_check):
523 Output line numbers, to simplify navigation of Emacs *compilation*
525 (sc_prohibit_atoi_atof, sc_file_system):
526 Rework slightly so that Makefile.maint doesn't get reported as a
527 violation of its own syntax rules.
528 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
529 it at run-time (which didn't work with Bison). Fix a makefile typo,
530 caught by Makefile.maint itself: spaces where a tab should be.
531 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
532 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
533 Ignore djgpp and man subdirectories, to avoid false matches with
534 Bison and coreutils, respectively. Use sort -u to remove the
535 resulting duplicates.
536 * gnupload: Rework slightly to avoid bogus warning from
537 sc_two_space_separator_in_usage.
539 2006-02-10 Jim Meyering <jim@meyering.net>
541 Use gzip's --rsyncable option only if it's available.
542 * Makefile.maint (gzip_rsyncable): New variable.
545 2006-02-08 Jim Meyering <jim@meyering.net>
547 * Makefile.maint (local-checks-available): Define in terms of
548 the expansion, $(syntax-check-rules), rather than the single,
549 top-level target `syntax-check', so that it's easier to exclude
550 individual rules (via $(local-checks-to-skip)).
551 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
553 2006-02-07 Jim Meyering <jim@meyering.net>
555 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
556 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
558 * tests/help-version (expected_failure_status_vdir):
559 Redirect an expected disk-full diagnostic to /dev/null.
561 2006-02-06 Jim Meyering <jim@meyering.net>
563 * src/unexpand.c (usage): Use two spaces (not one) to separate the
564 --first-only option string from its description, so help2man formats
565 the derived man page properly.
566 * src/rm.c (usage): Likewise for --no-preserve-root.
567 * src/chown.c (usage): Likewise.
568 * src/chgrp.c (usage): Likewise.
570 Add a rule to ensure that the above doesn't happen again.
571 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
572 (syntax-check-rules): Add it.
573 * .x-sc_two_space_separator_in_usage: New empty file.
574 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
576 2006-02-06 Jim Meyering <jim@meyering.net>
578 * src/cp.c (usage): Use two spaces (not one) to separate each
579 option string from its description, so help2man formats the
580 derived man page properly.
581 * src/mv.c (usage): Likewise.
582 Patch from Nicolas François in http://bugs.debian.org/351601.
584 2006-02-04 Jim Meyering <jim@meyering.net>
586 * src/copy.c (copy_internal): cp -RL would fail when encountering
587 the same directory more than once in the hierarchy beneath a single
588 command-line argument. That is legitimate, e.g. when there are
589 two or more symbolic links, each pointing to some directory that
590 would not otherwise be copied. Reported by Christophe LYON.
591 * tests/cp/cp-deref: New file. Test for today's fix.
592 * tests/cp/Makefile.am (TESTS): Add cp-deref.
593 * NEWS: Document this.
595 2006-02-03 Jim Meyering <jim@meyering.net>
597 * configure.ac: Require automake-1.9.6, not 1.8.3.
599 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
601 * src/od.c (usage): Mention that -t a ignores high order bit.
602 Documentation problem reported by Ed Avis.
604 2006-02-01 Jim Meyering <jim@meyering.net>
606 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
608 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
610 * src/head.c (main): Use a better diagnostic when someone uses a
611 trailing numeric option in an invalid way. Problem reported by
613 * src/tail.c (parse_options): Likewise.
615 2006-01-30 Jim Meyering <jim@meyering.net>
617 * man/wc.x: Include `count' keyword in man page synopsis,
618 per suggestion from http://bugs.debian.org/181585.
620 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
622 * src/df.c (show_dev): If the file system claims to have
623 more available than total blocks, report the number of used
624 blocks as being total - available (a negative number) rather
625 than as garbage. Problem reported by Toralf Foerster.
627 2006-01-24 Jim Meyering <jim@meyering.net>
629 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
630 to put a regular file in O_NONBLOCK mode fails with EPERM.
631 That happens on Linux (up to 2.6.15) when using tail -f on a file with
632 the append-only attribute. Reported by Dean Gaudet. For details,
633 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
634 * NEWS: Mention this fix.
635 * tests/tail-2/append-only: New file. Test for the above.
636 * tests/tail-2/Makefile.am (TESTS): Add append-only.
637 * tests/Makefile.am (check-root): Add tail-2/append-only
639 2006-01-21 Jim Meyering <jim@meyering.net>
641 * NEWS: Mention fts-related improvements and bug fixes.
643 2006-01-19 Jim Meyering <jim@meyering.net>
645 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
646 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
648 2006-01-18 Jim Meyering <jim@meyering.net>
650 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
652 2006-01-17 Jim Meyering <jim@meyering.net>
654 Now that fts no longer changes the current working directory, adjust
655 its clients accordingly -- note that du.c uses fts but doesn't need
656 any adjustment, since it doesn't operate on the actual files,
657 but rather just uses the stat buffers provided by fts.
659 * src/chown-core.c: Include "openat.h".
660 Don't include "lchown.h".
661 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
662 calling openat, lchownat, chownat, rather than open, lchown, chown.
664 * src/chmod.c: Include "openat.h".
665 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
667 * tests/du/long-from-unreadable: New test, to exercise one small
670 2006-01-13 Jim Meyering <jim@meyering.net>
672 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
673 addition of new directories under tests/.
675 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
678 2006-01-12 Jim Meyering <jim@meyering.net>
680 * tests/du/long-sloop: Adjust not to hard-code the expected
681 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
682 from that of GNU libc. Reported by Paul Eggert.
684 * tests/du/long-sloop: Create file at end of symlink chain.
686 * tests/misc/test: New file, with a test for one of the
687 bugs fixed by yesterday's test.c changes.
688 * tests/misc/Makefile.am (TESTS): Add test.
690 2006-01-11 Jim Meyering <jim@meyering.net>
692 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
693 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
694 a very long sequence of symbolic links (not necessarily a loop).
695 * tests/du/Makefile.am (TESTS): Add long-sloop.
697 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
699 * src/test.c (test_syntax_error): Append a newline. All callers
700 changed, except for the ones that didn't already append a newline.
701 Bug reported by Eric Blake.
703 2006-01-11 Jim Meyering <jim@meyering.net>
705 * src/system.h (X2NREALLOC): Now that verify_true is no longer
706 void, cast its result to void, to avoid gcc's warning that
707 ``left-hand operand of comma expression has no effect''.
708 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
710 2006-01-10 Jim Meyering <jim@meyering.net>
712 * tests/chmod/no-x: Add a test for today's fts.c fix.
714 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
716 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
717 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
719 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
721 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
722 Use verify_true instead of verify_expr, to sync with gnulib.
724 2006-01-08 Jim Meyering <jim@meyering.net>
726 * src/date.c (usage): Adjust the formatting of the entries for
727 %::z and %:::z (separate with two spaces, not one) so that help2man
728 formats them properly. Reported by Philip Rowlands.
730 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
732 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
734 2006-01-06 Jim Meyering <jim@meyering.net>
736 * Makefile.maint (copyright-check): Use date +%Y in place of
739 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
740 First off, the attribute should have been `volatile' (not static)
741 to avoid longjmp-related risk of clobber. Secondly, now there is
742 no longer any risk of a local variable being clobbered, so there's
743 no need for any attribute at all.
745 2006-01-05 Jim Meyering <jim@meyering.net>
747 * src/remove.c: Give a few functions the inline attribute.
748 (AD_pop_and_chdir): Use gotos to avoid some duplication.
749 (AD_push): Rewrite an assertion so that the entire computation
750 goes away when assertions are turned off.
752 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
753 It's already defined in "system.h".
754 * Makefile.maint: Add a FIXME comment.
756 2006-01-04 Jim Meyering <jim@meyering.net>
758 * ChangeLog: Remove entries from 2005-10-22 and earlier.
759 * ChangeLog-2005: New file, for entries up to version 5.92.
761 2006-01-03 Jim Meyering <jim@meyering.net>
763 * tests/du/no-x: Also allow a slightly different diagnostic -- the
764 one you get when using openat-enabled fts.c and du (coming soon).
765 * tests/chmod/no-x: Likewise.
766 * tests/chgrp/no-x: Likewise.
768 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
770 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
772 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
773 (restricted_chown): Return it, if the file cannot be accessed due
774 to EPERM, or if no uid or gid are required, or if the file is
775 neither a directory nor a regular file. Rewrite to avoid gotos.
776 (change_file_owner): Handle RC_do_ordinary_chown case.
777 Rewrite to avoid gotos.
778 * tests/chgrp/basic: Make sure we can change the group of
781 * src/date.c (usage): Explain %g, %G, and %V a bit better.
783 2006-01-02 Jim Meyering <jim@meyering.net>
785 * src/copy.c (set_owner): Correct a comment.
787 * src/tail.c (parse_options): Change warning to say that --retry
788 is useful `mainly' (not `only') when following by name.
789 Reported here: http://bugs.debian.org/273781
791 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
793 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
794 * src/copy.c: Include lchmod.h.
795 (copy_internal): Use lchmod rather than chmod.
796 * src/cp.c: Include lchmod.h.
797 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
798 * src/mkdir.c: Include lchmod.h.
799 (usage): Clarify -m's operation.
800 (main): Use lchmod rather than chmod. Don't use lchmod unless the
801 new mode contains bits outside the 777 range.
802 * src/mkfifo.c (usage): Clarify -m's operation.
803 (main): If -m is given, don't invoke chmod; use umask 0 instead.
804 Report an error if -m asks for bits outside the 777 range.
805 * src/mknod.c (usage, main): Likewise.
807 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
809 2005-12-27 Jim Meyering <jim@meyering.net>
811 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
812 (sc_prohibit_assert_without_use): New rule.
813 (syntax-check-rules): Add it to the list.
814 * .x-sc_prohibit_assert_without_use: New empty file.
815 * Makefile.am (EXTRA_DIST): Add it.
817 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
819 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
820 Don't include <assert.h>; it wasn't used.
822 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
824 * src/chown-core.c (restricted_chown):
825 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
826 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
827 | O_NOFOLLOW too, for consistency with other dir-openers.
828 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
829 (is_empty_dir): Likewise.
830 * src/shred.c (wipename): Likewise. Don't bother trying to open
831 dir for writing, since POSIX prohibits it.
833 2005-12-22 Jim Meyering <jim@meyering.net>
835 * tests/help-version: Redirect stderr to /dev/full, to suppress
836 write error diagnostic.
838 2005-12-19 Jim Meyering <jim@meyering.net>
840 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
841 Avoid a minor race condition when `-m MODE' is specified, by using
842 open, fchown, and close rather than just chown. To do that reliably --
843 even with an overly restrictive umask -- ensure that each mkdir,
844 mknod and mkfifo call uses a mode including at least owner-read access.
845 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
846 the subsequent chown (or equivalent open,fchown,close) fails.
847 * tests/misc/mknod: New tests.
848 * tests/misc/Makefile.am (TESTS): Add mknod.
850 2005-12-17 Jim Meyering <jim@meyering.net>
852 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
853 e.g., on a named pipe.
854 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
855 place of all uses, since it is guaranteed (system.h) to be defined.
857 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
859 Add POSIX ACL support
860 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
861 is no requirement for ACL support; particularly, it does not exist
862 on systems that have POSIX ACLs.
863 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
864 * src/cp.c (umask_kill): With default acls, the umask is not to be
865 applied. Remove umask_kill, don't change the process umask, and let
866 the kernel apply the umask where appropriate.
867 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
868 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
870 (copy_reg, copy_internal): Use copy_acl and set_acl
871 instead of fchown/chown. Fix the logic for POSIX ACLs.
872 (chown_succeded): Remove; we now always copy acls and
873 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
874 did a chown before or not.
875 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
876 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
877 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
878 to link with it via $(LIB_ACL), for the utilities that need it.
880 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
882 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
883 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
884 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
885 value is now signified by whether cwd_errno is null.
886 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
887 pointer-to-bool to pointer-to-errno-value. All callers changed.
888 (rm_1): Don't bother setting a local cwd failure flag and then
889 ORing it into the caller's. Just set the caller's.
890 (rm): Use cwd failure errno value to print a slightly-better
893 2005-12-15 Jim Meyering <jim@meyering.net>
895 * src/stat.c (print_it): Properly handle a backslash at the
896 end of a --printf format string. Reported by Paul Eggert.
897 * tests/misc/stat-printf (end-bs): Add a test for the above.
899 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
901 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
902 Don't assume /etc/passwd contains user names; use 'id' instead.
904 2005-12-15 Jim Meyering <jim@meyering.net>
906 stat: revert behavior of --format=FMT (-c)
907 stat: add new option: --printf=FMT
908 * NEWS: Mention this.
909 * src/stat.c (isodigit, octtobin, hextobin): Define.
910 (PRINTF_OPTION): Define.
911 (interpret_backslash_escapes, trailing_delim): New globals.
912 (usage): Document them. Alphabetize on long option names.
913 (print_esc_char): New function.
914 (print_it): Rewrite, in order to handle backslash escapes.
915 (main): Handle new option. Set globals for --format, too.
917 * tests/misc/stat-printf: Test --printf and --format.
918 * tests/misc/Makefile.am (TESTS): Add stat-printf.
920 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
922 * NEWS: sort now reports incompatible options.
923 * src/sort.c (incompatible_options, check_ordering_compatibility):
925 (main): Use them. Don't bother with a usage message for
926 "sort -c a b", for consistency with other error diagnostics.
927 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
930 * src/cat.c (main): Undo previous change. close_stdout already
931 does the check, so the previous change wasn't necessary.
933 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
935 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
937 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
939 Install a more-conservative approach for sort -R. It's the
940 same basic idea as the existing code, except it uses the full ISAAC
941 approach (called the "more kosher" approach in the existing comments).
942 This makes "sort -R" quite a bit slower (about a factor of 2 on my
943 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
944 better to be conservative here at first, and review any performance
945 improvements carefully.
946 * .x-sc_require_config_h: Add src/rand-isaac.c.
947 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
948 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
949 (shred_SOURCES, sort_SOURCES): Remove.
950 (EXTRA_DIST): Add rand-isaac.c.
951 * src/rand-isaac.c: Revert to what used to be in shred.c, without
952 changing it to allow for varying numbers of words in the state.
953 Alter so that we include rand-isaac.c directly rather than
954 compiling it and linking to it. Don't include config.h or
955 system.h; that's the includer's responsibility.
956 Omit functions that are specific to shred.
957 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
958 (isaac_step, struct irand_state):
959 Resurrect these, with the same defns that used to be in shred.c.
960 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
961 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
963 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
964 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
965 (irand_init, irand32, irand_mod):
966 Number of words is constant again.
967 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
968 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
969 * src/sort.c: Likewise.
970 * src/shred.c (fillrand, dopass, main): Undo previous change.
971 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
973 * src/sort.c: Don't include md5.h; it wasn't needed.
974 (struct keyfield): Rename random_hash to random, for consistency
975 with the other member names. All uses changed.
976 (usage): Tweak wording to mention STRING for --seed option.
977 (short_options): Rorder for consistency with other programs.
978 (rand_state): Now a struct, not a pointer to one. All uses changed.
979 (HASH_WORDS, HASH_SIZE): Remove.
980 (get_hash): Remove comments around resbuf size, since we can assume C89.
981 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
982 (keycompare): Adjust to the new get_hash.
984 (badfieldspec): Omit recently-introduced comment; it isn't needed.
985 (main): Don't set need_random simply because gkey has it set; that
986 doesn't necessarily mean we'll need random numbers.
987 Redo seeding to match new get_hash approach.
989 2005-12-10 Jim Meyering <jim@meyering.net>
991 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
993 Avoid shred segfault on 64-bit systems.
994 * src/rand-isaac.c (isaac_refill): Don't try to negate a
995 local of type uint32_t. Make the local an `int' instead.
997 * NEWS: Mention sort's new options.
999 * src/rand-isaac.c (isaac_mix): Declare to be static.
1000 Mark all other functions as `extern' so the tight-scope
1001 part of `make distcheck' passes once again.
1002 * src/rand-isaac.h (isaac_mix): Remove declaration.
1004 * src/sort.c (get_hash): Change position of `*' in parameter
1005 type to conform with convention.
1006 (main): Split a long line so it fits in 80 columns.
1007 (keycompare): Remove stray SPACE before TAB that was
1008 causing `make distcheck' to fail.
1010 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1012 * tests/misc/sort-rand: New file: basic tests for the new options.
1013 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1015 2005-12-10 Frederik Eaton <frederik@ofb.net>
1017 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1018 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1019 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1020 Make state size runtime-configurable.
1021 (isaac_new, isaac_copy): New functions.
1022 * src/rand-isaac.h: New file.
1023 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1024 (fillrand, main): Adjust to the fact that the state size is now
1025 runtime-configurable.
1026 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1027 (usage): Add options --random-sort and --seed to implement a random
1029 Include md5.h and rand-isaac.h.
1030 (get_hash): New function.
1031 (rand_state): New var.
1032 (HASH_WORDS, HASH_SIZE): New macros.
1034 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1036 * tests/dd/misc: Add test for dd iflags=noatime.
1038 2005-12-09 Jim Meyering <jim@meyering.net>
1040 * src/sort.c (usage): Mention white space vs -b and -t options.
1043 2005-12-09 Eric Blake <ebb9@byu.net>
1045 * src/test.c (main): Fix misleading comment.
1047 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1049 * NEWS: Mention dd's new noatime flag.
1050 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1051 * src/dd.c (flags, usage): Add support for noatime flag.
1053 2005-12-07 Jim Meyering <jim@meyering.net>
1055 Distribute the cvsu script, used only by `make syntax-check'.
1056 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1057 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1058 distribute a copy of this script.
1059 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1061 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1062 to create a temporary directory on another partition.
1063 From Andreas Gruenbacher.
1065 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1067 * man/basename.x: Cross-reference to dirname and readlink.
1068 * man/dirname.x: Cross-reference to basename and readlink.
1070 2005-12-05 Andreas Gruenbacher
1072 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1073 (set_owner, preserve_author): New functions, factored out of copy_reg.
1074 (copy_reg): Use them.
1075 (copy_internal): Use them here, too.
1077 2005-12-04 Jim Meyering <jim@meyering.net>
1079 * src/sleep.c (usage): Say what happens with two or more arguments.
1080 Suggested by Justin Pryzby.
1082 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1085 2005-12-03 Jim Meyering <jim@meyering.net>
1087 * src/rm.c (long_opts): Change the name of each undocumented, for-
1088 testing-only option to start with `-', so that it cannot render
1089 ambiguous any prefix it happens to share with some other option name.
1090 Problem reported by Eric Blake.
1091 * src/head.c (long_options): Likewise.
1092 * src/tail.c (long_options): Likewise.
1094 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1095 testing-only --presume* options to start with `---'.
1096 * tests/rm/dangling-symlink: Likewise.
1097 * tests/rm/dir-no-w: Likewise.
1098 * tests/rm/isatty: Likewise.
1100 2005-11-30 Jim Meyering <jim@meyering.net>
1102 * Makefile.maint: Add a comment about cvsu.
1104 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1106 * NEWS: df updates for "none", "proc", inaccessible file systems.
1107 * src/df.c (show_point): Ignore inaccessible file systems.
1108 (usage): -a includes dummy file systems, not size-0 file systems.
1110 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1111 to avoid collision with POSIX name space. All uses changed.
1113 2005-11-24 Jim Meyering <jim@meyering.net>
1115 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1116 * tests/acl: Add `$0: ' prefix to diagnostics.
1118 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1120 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1122 * src/copy.c: Improve performance a bit by optimizing away
1123 unnecessary system calls and going to a block size of at least
1124 8192 (on normal hosts, anyway). This improved performance 5% on my
1125 Debian stable host (2.4.27 kernel, x86, copying from root
1126 ext3 file system to itself).
1127 Include "buffer-lcm.h".
1128 (copy_reg): Omit last argument. All callers changed.
1129 Use xmalloc to allocate rather than trusting alloca
1130 (which is unwise with large block sizes).
1131 Declare locals more locally, if possible.
1132 Use uintptr_t words instead of int words, for a bit more speed
1133 when looking for null blocks on 64-bit hosts.
1134 Optimize away reads of zero bytes on regular files.
1135 In the typical case, insist on 8 KiB buffers, at least.
1136 Avoid unnecessary extra call to fstat when checking for sparse files.
1137 Avoid now-unnecessary cast to off_t, and "0L".
1138 Avoid unnecessary test of *new_dst when checking for same owner
1141 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1143 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1145 2005-11-22 Jim Meyering <jim@meyering.net>
1147 * src/remove.c (AD_push): Remove debugging cruft.
1149 * tests/rm/unread2 (rm): Change expected diagnostic,
1150 `cannot open directory' to `cannot remove', to align with
1152 * tests/rm/rm2: Ensure that rm now continues removing entries
1153 even after certain types of failure.
1155 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1156 that provide openat (Solaris), and on systems like Linux+procfs
1157 where our openat emulation code is reentrant. This also fixes a
1158 few low-probability leaks and eliminates some code that could,
1159 in very unusual circumstances, cause rm() (via a callee) to exit.
1160 * NEWS: Mention this.
1162 * configure.ac: Put copyright dates all on one line so the
1163 emacs function that updates them works properly.
1165 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1167 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1168 Problem reported by Eric Blake.
1169 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1170 we get a standard-conforming compiler. This relies on the new
1171 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1172 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1173 m4/c.m4 can go away with Autoconf 2.60 comes out.
1175 2005-11-17 Jim Meyering <jim@meyering.net>
1177 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1178 (AD_mark_current_as_unremovable): Likewise, but for a local.
1181 * tests/mv/acl: Let traps handle removing temporary directories.
1183 Expect acl-related tests to fail, until the corresponding
1184 patches are committed.
1185 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1186 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1188 ACL tests, from Andreas Gruenbacher.
1189 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1190 * tests/mv/Makefile.am (TESTS): Add acl.
1191 * tests/cp/Makefile.am (TESTS): Add acl.
1193 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1195 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1197 * NEWS: Improve quality of ln's diagnostics.
1198 * src/ln.c (do_link, usage): Likewise.
1199 (do_link): Don't use alloca on a buffer of unbounded size.
1201 2005-11-16 Jim Meyering <jim@meyering.net>
1203 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1204 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1205 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1206 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1207 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1209 2005-11-14 Jim Meyering <jim@meyering.net>
1211 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1213 2005-11-13 Jim Meyering <jim@meyering.net>
1215 * announce-gen: Accept new option, --gpg-key-id=ID and
1216 emit a blurb telling how to use the .sig files.
1217 * Makefile.cfg (gpg_key_ID): Define.
1218 * Makefile.maint (announcement): Use new option and key.
1220 Require that most .c files include <config.h>.
1221 * Makefile.maint (sc_require_config_h): New rule.
1222 (syntax-check-rules): Add it.
1223 * .x-sc_require_config_h: New file listing exceptions to the
1224 above rule. Some are legit, others are simply grandfathered in.
1225 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1227 2005-11-12 Jim Meyering <jim@meyering.net>
1229 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1231 2005-11-11 Jim Meyering <jim@meyering.net>
1233 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1234 Mention new readlink options in 5.3.0's `New features' section.
1235 Spotted by Thomas Hood.
1237 2005-11-08 Jim Meyering <jim@meyering.net>
1239 * NEWS: Merge in changes from b5_9x branch.
1241 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1243 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1244 like --time-style='posix-long-iso' if the locale settings are messed up.
1245 * src/ls.c (decode_switches): Implement this.
1247 2005-11-08 Jim Meyering <jim@meyering.net>
1249 * tests/du/2g: s/expensive/very expensive/ in a comment.
1252 2005-10-17 Eric Blake <ebb9@byu.net>
1254 * src/ls.c (usage): Fix descriptions of --sort, --time.
1255 Reported by Vitaly A. Ostanin.
1257 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1259 * src/ln.c: Include filenamecat.c.
1260 (FILE_BASENAME_CONCAT): Remove.
1261 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1262 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1263 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1266 2005-11-04 Jim Meyering <jim@meyering.net>
1268 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1269 on systems with stat.st_blocks of a signed 32-bit type.
1270 This bug causes trouble on some AIX 5.1 systems.
1271 Report and trivial patch from Paul Townsend:
1272 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1273 * NEWS: Mention this.
1275 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1276 * tests/du/Makefile.am (TESTS): Add it here.
1277 * tests/very-expensive: New file.
1278 * tests/Makefile.am (EXTRA_DIST): Add it here.
1279 * tests/cp/perm: Mark this test as `very-expensive', too.
1281 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1283 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1285 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1287 * src/rm.c (usage): Don't mention rm -d.
1289 2005-11-02 Jim Meyering <jim@meyering.net>
1291 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1292 From Andreas Schwab.
1294 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1295 `M+N records in/out' lines don't pollute `make check' output.
1297 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1298 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1299 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1300 to indicate that the input file should be piped into the command
1301 under test (via `cat FILE | $prog ...').
1303 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1304 (without -r) fails to remove a directory on a non-Linux system.
1305 This change affects only newer Solaris systems (with priv_*
1306 functions like priv_allocset). Reported by Keith Thompson.
1308 * tests/rm/dir-nonrecur: New file/test for the above fix.
1309 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1311 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1313 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1314 POSIX 1002.1-2001 requires.
1315 * src/tail.c (parse_obsolete_option): Implement this.
1316 Problem reported by Vincent Lefevre.
1317 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1318 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1319 (test_vector): Add special cases for _POSIX2_VERSION, and
1320 regularize the old ones a bit.
1321 * tests/touch/obsolescent: Add y2000 test.
1323 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1325 * src/dd.c (skip): Fix off-by-one error reported by
1326 Theodoros V. Kalamatianos.
1328 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1330 * tests/mkdir/p-3: Require that the test be run as non-root.
1331 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1333 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1335 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1336 boundary between DEST and SOURCE in the result.
1338 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1340 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1341 back to text, to sync with documentation and for backwards
1344 2005-10-25 Jim Meyering <jim@meyering.net>
1346 * tests/dircolors/simple (other-wr): Add an explicit test for
1347 the dircolors bug (NULL-dereference) fixed yesterday.
1349 2005-10-24 Jim Meyering <jim@meyering.net>
1351 * src/tac.c (tac_file): When determining whether a file is seekable,
1352 also test whether it is a tty. Using only the lseek-based test would
1353 give a false positive on Solaris. Reported by Peter Fales.
1355 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1357 * tests/install/d-slashdot: New test, for "install -d" failure.
1358 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1359 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1360 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1362 2005-10-24 Jim Meyering <jim@meyering.net>
1364 * src/dircolors.c (ls_codes): Add missing comma.
1365 Anonymous report and patch from
1366 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1368 * src/dircolors.c: Add compile-time assertion that the slack_codes
1369 and ls_codes arrays have the same number of elements. This would
1370 have prevented the above-fixed bug.
1372 * src/expand.c (parse_tab_stops): Add a comment to make this function
1373 identical to the one in unexpand.c.
1374 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1375 identical to the one in expand.c.
1377 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1379 2005-10-23 Jim Meyering <jim@meyering.net>
1381 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1382 a dangerous pointer-value-to-`unsigned' cast.
1383 * NEWS: mention the new sha* programs.
1384 * AUTHORS: Add new sha* programs.
1386 2005-08-28 David Madore <david.madore@ens.fr>
1388 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1389 * README: Add their names to the list.
1390 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1391 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1392 Rules for compiling sha-2 utilities
1393 (noinst_HEADERS): Remove checksum.h.
1394 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1396 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1397 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1398 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1399 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1400 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1401 sha384sum, sha512sum test scripts here rather that each in its
1404 2005-08-28 David Madore <david.madore@ens.fr>
1406 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1407 of the FIPS test vectors).
1409 2005-10-23 Jim Meyering <jim@meyering.net>
1411 * configure.ac: Use 6.0-cvs as the version string.
1412 * NEWS: Adjust accordingly.