1 2005-01-20 Havoc Pennington <hp@redhat.com>
3 * dbus/dbus-sysdeps.c (_dbus_poll): amazingly, trying to compile
4 code can reveal bugs in it
6 2005-01-20 Havoc Pennington <hp@redhat.com>
8 * dbus/dbus-sysdeps.c (_dbus_poll): fix several bugs in the
9 select() version, patches from Tor Lillqvist
11 2005-01-20 Havoc Pennington <hp@redhat.com>
13 * doc/dbus-tutorial.xml: replace > with >
15 * bus/services.c (bus_registry_acquire_service): validate the name
16 and return a better error if it's no good.
18 * doc/dbus-specification.xml: note NO_AUTO_START change
20 * dbus/dbus-protocol.h (DBUS_HEADER_FLAG_NO_AUTO_START): change
21 from AUTO_START, we're toggling the default
23 * bus/dispatch.c: adapt the tests to change of auto-start default
25 2005-01-18 Havoc Pennington <hp@redhat.com>
27 * rename dbus-daemon-1 to dbus-daemon throughout
29 2005-01-18 Havoc Pennington <hp@redhat.com>
31 * Throughout, grand renaming to strip out the use of "service",
32 just say "name" instead (or "bus name" when ambiguous). Did not
33 change the internal code of the message bus itself, only the
34 programmer-facing API and messages.
36 * doc/dbus-specification.xml: further update the message bus section
38 * bus/config-parser.c (all_are_equiv): fix bug using freed string
41 2005-01-17 Havoc Pennington <hp@redhat.com>
43 * dbus/dbus-types.h: remove 16-bit types since we don't use them
46 * dbus/dbus-marshal-validate.c (_dbus_validate_path): disallow any
47 "invalid name character" not only non-ASCII
49 * doc/dbus-specification.xml: further update spec, message bus
50 parts are still out-of-date but the marshaling etc. stuff is now
53 2005-01-17 Havoc Pennington <hp@redhat.com>
55 * doc/dbus-specification.xml: partially update spec
57 2005-01-17 Havoc Pennington <hp@redhat.com>
59 * Throughout, align variant bodies according to the contained
60 type, rather than always to 8. Should save a fair bit of space in
63 * dbus/dbus-marshal-validate.c (_dbus_validate_body_with_reason):
64 fix handling of case where p == end
66 * doc/TODO: remove the dbus_bool_t item and variant alignment items
68 2005-01-17 Havoc Pennington <hp@redhat.com>
70 * dbus/dbus-types.h: hardcode dbus_bool_t to 32 bits
72 * Throughout: modify DBUS_TYPE_BOOLEAN to be a 32-bit type instead
73 of an 8-bit type. Now dbus_bool_t is the type to use whenever you
74 are marshaling/unmarshaling a boolean.
76 2005-01-16 Havoc Pennington <hp@redhat.com>
78 This is about it on what can be disabled/deleted from libdbus
79 easily, back below 150K anyhow. Deeper cuts are more work than
80 just turning the code off as I've done here.
82 * dbus/dbus-marshal-basic.c (_dbus_pack_int32): we don't need the
83 signed int convenience funcs
85 * dbus/dbus-internals.c (_dbus_verbose_real): omit when not in
88 * dbus/dbus-string-util.c, dbus/dbus-string.c: more breaking
91 * dbus/dbus-sysdeps.c, dbus/dbus-sysdeps-util.c: same
93 * dbus/dbus-hash.c: purge the TWO_STRINGS crap (well, make it
94 tests-enabled-only, though it should probably be deleted)
96 * dbus/dbus-message-util.c: same stuff
98 * dbus/dbus-auth-util.c: same stuff
100 2005-01-16 Havoc Pennington <hp@redhat.com>
102 * dbus/dbus-userdb-util.c: split out part of dbus-userdb.c
104 * dbus/dbus-sysdeps.c (_dbus_uid_from_string): move here to pave
105 way for stripping down dbus-userdb.c stuff included in libdbus.
106 Rename _dbus_parse_uid for consistency.
108 2005-01-16 Havoc Pennington <hp@redhat.com>
110 * dbus/dbus-internals.c (_dbus_real_assert): print the function
111 name the assertion failed in
113 * dbus/dbus-internals.h (_dbus_return_if_fail)
114 (_dbus_return_val_if_fail): assert that the name of the function
115 containing the check doesn't start with '_', since we only want to
116 use checks on public functions
118 * dbus/dbus-connection.c (_dbus_connection_ref_unlocked): change
121 * dbus/dbus-marshal-header.c (_dbus_header_set_field_basic):
122 change checks to asserts for private function
124 * dbus/dbus-message.c (_dbus_message_set_serial): checks
125 to asserts for private function
127 * dbus/dbus-marshal-recursive.c (skip_one_complete_type): remove
128 broken assertion that was breaking make check
129 (_dbus_type_reader_array_is_empty): remove this rather than fix
130 it, was only used in assertions
132 2005-01-16 Havoc Pennington <hp@redhat.com>
134 * test/unused-code-gc.py: hacky script to find code that's used
135 only by the bus (not libdbus) or used only by tests or not used at
136 all. It has some false alarms, but looks like we can clean up a
137 lot of size from libdbus.
139 * dbus/dbus-sysdeps.c, dbus/dbus-sysdeps-utils.c,
140 dbus/Makefile.am: initially move 10K of binary size out of libdbus
142 2005-01-16 Havoc Pennington <hp@redhat.com>
144 * Add and fix docs according to Doxygen warnings throughout
147 * dbus/dbus-marshal-recursive.c
148 (_dbus_type_reader_array_is_empty): change this to just call
149 array_reader_get_array_len() and make it static
151 * dbus/dbus-message.c (dbus_message_iter_get_element_type): rename
153 (dbus_message_iter_init_append): rename from append_iter_init
155 * dbus/dbus-marshal-recursive.c
156 (_dbus_type_reader_get_element_type): rename from
157 _dbus_type_reader_get_array_type
159 2005-01-15 Havoc Pennington <hp@redhat.com>
161 * test/glib/test-profile.c (with_bus_server_filter): fix crash
163 * dbus/dbus-marshal-basic.c (_dbus_unpack_uint32): inline as macro
164 when DBUS_DISABLE_ASSERT
165 (_dbus_marshal_set_basic): be sure we align for the string length
167 * dbus/dbus-marshal-recursive.c (skip_one_complete_type): make
170 * dbus/dbus-string.c (_dbus_string_get_const_data_len): add an
172 (_dbus_string_set_byte): provide inline macro version
174 2005-01-15 Havoc Pennington <hp@redhat.com>
176 * Land the new message args API and type system.
178 This patch is huge, but the public API change is not
179 really large. The set of D-BUS types has changed somewhat,
180 and the arg "getters" are more geared toward language bindings;
181 they don't make a copy, etc.
183 There are also some known issues. See these emails for details
185 http://lists.freedesktop.org/archives/dbus/2004-December/001836.html
186 http://lists.freedesktop.org/archives/dbus/2005-January/001922.html
188 * dbus/dbus-marshal-*: all the new stuff
190 * dbus/dbus-message.c: basically rewritten
192 * dbus/dbus-memory.c (check_guards): with "guards" enabled, init
193 freed blocks to be all non-nul bytes so using freed memory is less
196 * dbus/dbus-internals.c (_dbus_test_oom_handling): add
197 DBUS_FAIL_MALLOC=N environment variable, so you can do
198 DBUS_FAIL_MALLOC=0 to skip the out-of-memory checking, or
199 DBUS_FAIL_MALLOC=10 to make it really, really, really slow and
202 * qt/message.cpp: port to the new message args API
203 (operator<<): use str.utf8() rather than str.unicode()
204 (pretty sure this is right from the Qt docs?)
206 * glib/dbus-gvalue.c: port to the new message args API
208 * bus/dispatch.c, bus/driver.c: port to the new message args API
210 * dbus/dbus-string.c (_dbus_string_init_const_len): initialize the
211 "locked" flag to TRUE and align_offset to 0; I guess we never
212 looked at these anyhow, but seems cleaner.
214 * dbus/dbus-string.h (_DBUS_STRING_ALLOCATION_PADDING):
215 move allocation padding macro to this header; use it to implement
216 (_DBUS_STRING_STATIC): ability to declare a static string.
218 * dbus/dbus-message.c (_dbus_message_has_type_interface_member):
219 change to return TRUE if the interface is not set.
221 * dbus/dbus-string.[hc]: move the D-BUS specific validation stuff
222 to dbus-marshal-validate.[hc]
224 * dbus/dbus-marshal-basic.c (_dbus_type_to_string): move here from
227 * dbus/Makefile.am: cut over from dbus-marshal.[hc]
228 to dbus-marshal-*.[hc]
230 * dbus/dbus-object-tree.c (_dbus_decompose_path): move this
231 function here from dbus-marshal.c
233 2005-01-12 Joe Shaw <joeshaw@novell.com>
235 * NEWS: Update for 0.23.
237 * configure.in: Release 0.23.
239 2005-01-12 Joe Shaw <joeshaw@novell.com>
241 * mono/Makefile.am, mono/example/Makefile.am: Always build the
242 dbus DLL with --debug. Clean up after the .mdb files this leaves
245 * mono/doc/Makefile.am: Need to uninstall the docs on "make
248 * mono/Arguments.cs (GetDBusTypeConstructor): If the type
249 is an enum, get the enum's underlying type. Another mono
252 2005-01-11 Joe Shaw <joeshaw@novell.com>
254 Patch from Sjoerd Simons <sjoerd@luon.net>
256 * mono/Makefile.am, mono/example/Makefile.am: Don't redefine
257 DESTDIR. It breaks stuff.
259 2005-01-11 Joe Shaw <joeshaw@novell.com>
261 Patch from Tambet Ingo <tambet@ximian.com>
263 * mono/DBusType/Array.cs (Get): Get the underlying element type by
264 calling type.GetElementType(). The code previously depended on
265 broken Mono behavior, which was fixed in Mono 1.1.3.
267 * mono/DBusType/Dict.cs (constructor): Fix the parameters for
268 Activator.CreateInstance() so that the class's constructor is
269 called with the right parameters.
271 2005-01-11 Joe Shaw <joeshaw@novell.com>
273 Patch from Timo Teräs <ext-timo.teras@nokia.com>
275 * dbus/dbus-connection.c
276 (_dbus_connection_queue_received_message_link): Call
277 _dbus_connection_remove_timeout() instead of the _locked()
278 variant, since it's always called from
279 _dbus_connection_handle_watch(), which handles the locking.
280 Removed the _locked() variant since it's no longer used.
282 2005-01-03 Havoc Pennington <hp@redhat.com>
284 * dbus/dbus-internals.h: I'm an idiot, _dbus_assert certainly can
287 2004-12-26 Havoc Pennington <hp@redhat.com>
289 * dbus/dbus-internals.h: add _DBUS_GNUC_NORETURN to _dbus_assert
291 2005-01-03 Havoc Pennington <hp@redhat.com>
293 * dbus/dbus-sysdeps.c (_dbus_sysdeps_test): fix using == on
296 * dbus/dbus-string.c (_dbus_string_insert_alignment): new function
298 2005-01-02 Havoc Pennington <hp@redhat.com>
300 * dbus/dbus-internals.h (_DBUS_ALIGN_OFFSET): new macro
302 2005-01-01 Havoc Pennington <hp@redhat.com>
304 * configure.in: add -Wfloat-equal
306 2005-01-01 Havoc Pennington <hp@redhat.com>
308 * dbus/dbus-sysdeps.h: add _DBUS_DOUBLES_BITWISE_EQUAL macro,
309 for a variety of reasons '==' doesn't do this.
311 2004-12-31 Havoc Pennington <hp@redhat.com>
313 * dbus/dbus-string.c (_dbus_string_equal_substrings): new function
316 2004-12-30 John (J5) Palmieri <johnp@redhat.com>
318 * python/dbus.py: s/ACTIVATION_REPLY_ACTIVE/ACTIVATION_REPLY_ACTIVATED
320 2004-12-30 John (J5) Palmieri <johnp@redhat.com>
322 * python/dbus_bindings.pyx.in: Change DBUS_ACTIVATION_REPLY_ACTIVATED
323 and DBUS_ACTIVATION_REPLY_ALREADY_ACTIVE to match the values in
324 dbus-protocol.h. Because they are defines and not enums they are not
327 2004-12-26 John (J5) Palmieri <johnp@redhat.com>
329 * python/dbus_bindings.pyx.in (bus_activate_service): Bind
330 dbus_bus_activate_service
332 * python/dbus.py (Bus.activate_service): activate a service on the
335 2004-12-24 Havoc Pennington <hp@redhat.com>
337 * test/decode-gcov.c: change to use .gcno and .gcda files, but the
338 file format has also changed and I haven't adapted to that yet
340 * Makefile.am: load .gcno files from latest gcc
342 2004-12-23 John (J5) Palmieri <johnp@redhat.com>
343 * Patch from Rob Taylor <robtaylor@fastmail.fm>
345 * python/dbus_bindings.pyx.in (bus_get_unix_user): New
348 * python/dbus.py (get_unix_user): Added binding to
349 call dbus_bindings.bus_get_unix_user
351 * python/extract.py: Modified the proto_pat regex to
354 2004-12-21 Olivier Andrieu <oliv__a@users.sourceforge.net>
356 * dbus/make-dbus-glib-error-enum.sh: omit the function keyword for
357 better POSIX compliance.
359 2004-12-19 Havoc Pennington <hp@redhat.com>
361 * dbus/dbus-string.c (_dbus_string_insert_4_aligned)
362 (_dbus_string_insert_8_aligned): new functions
364 * dbus/dbus-string.c (_dbus_string_alloc_space): new function
366 2004-12-18 Havoc Pennington <hp@redhat.com>
368 * dbus/dbus-string.c (_dbus_string_validate_ascii): use ISASCII
371 * dbus/dbus-message.c: fix a comment, and add a still-unused
372 not-implemented function
374 * dbus/dbus-marshal.h: fix comment
376 * dbus/dbus-internals.h (_DBUS_ISASCII): new macro
378 2004-12-17 Joe Shaw <joeshaw@novell.com>
380 * mono/DBusType/Byte.cs, mono/DBusType/Int32.cs,
381 mono/DBusType/Int64.cs, mono/DBusType/UInt32.cs,
382 mono/DBusType/UInt64.cs: Use Enum.GetUnderlyingType() instead of
383 Type.UnderlyingSystemType to get the actual system type
384 underneath. This code previously depended on the broken Mono
385 behavior, which was fixed in 1.1.3.
387 2004-11-27 Havoc Pennington <hp@redhat.com>
389 * dbus/dbus-string.h (_dbus_string_get_byte): inline when asserts
391 (_dbus_string_get_const_data): inline when asserts are disabled
393 * dbus/dbus-message.c: record the _dbus_current_generation of
394 creation so we can complain if dbus_shutdown() is used improperly.
395 Do this only if checks are enabled.
397 * dbus/dbus-connection.c: ditto
399 2004-11-26 Havoc Pennington <hp@redhat.com>
401 * test/glib/test-profile.c: add with_bus mode to profile echoes
402 that go through the bus.
404 * test/glib/run-test.sh: add ability to run test-profile
406 * bus/dbus-daemon-1.1.in: fix to say that SIGHUP causes partial
409 2004-11-26 Havoc Pennington <hp@redhat.com>
411 * test/glib/test-profile.c: clean up how the fake_malloc_overhead
412 thing was implemented
414 2004-11-26 Havoc Pennington <hp@redhat.com>
416 * test/glib/test-profile.c: tweak a bit, add support for some
417 made-up minimal malloc overhead with plain sockets, since in
418 real life some sort of buffers are unavoidable thus we could
419 count them in the theoretical best case
421 2004-11-26 Havoc Pennington <hp@redhat.com>
423 * dbus/dbus-message.c (dbus_message_cache_or_finalize): fix bug
424 where I was trying to cache one too many messages
426 2004-11-26 Havoc Pennington <hp@redhat.com>
428 * dbus/dbus-message.c: reimplement message cache as an array which
429 makes the cache about twice as fast and saves maybe 1.5% overall
431 2004-11-26 Havoc Pennington <hp@redhat.com>
433 * dbus/dbus-threads.c (init_global_locks): forgot to put the
434 message cache lock here
436 2004-11-26 Havoc Pennington <hp@redhat.com>
438 * dbus/dbus-message.c (struct DBusMessage): put the locked bit and
439 the "char byte_order" next to each other to save 4 bytes
440 (dbus_message_new_empty_header): reduce preallocation, since the
441 message cache should achieve a similar effect
442 (dbus_message_cache_or_finalize, dbus_message_get_cached): add a
443 message cache that keeps a few DBusMessage around in a pool,
444 another 8% speedup or so.
446 * dbus/dbus-dataslot.c (_dbus_data_slot_list_clear): new function
448 2004-11-25 Havoc Pennington <hp@redhat.com>
450 * dbus/dbus-transport-unix.c (unix_do_iteration): if we're going
451 to write, without reading or blocking, try it before the poll()
452 and skip the poll() if nothing remains to write. This is about a
453 3% speedup in the echo client/server
455 2004-11-25 Havoc Pennington <hp@redhat.com>
457 The primary change here is to always write() once before adding
458 the write watch, which gives us about a 10% performance increase.
460 * dbus/dbus-transport-unix.c: a number of modifications to cope
461 with removing messages_pending
462 (check_write_watch): properly handle
463 DBUS_AUTH_STATE_WAITING_FOR_MEMORY; adapt to removal of
464 messages_pending stuff
465 (check_read_watch): properly handle WAITING_FOR_MEMORY and
467 (unix_handle_watch): after writing, see if the write watch can be
469 (unix_do_iteration): assert that write_watch/read_watch are
470 non-NULL rather than testing that they aren't, since they
471 aren't allowed to be NULL. check_write_watch() at the end so
472 we add the watch if we did not finish writing (e.g. got EAGAIN)
474 * dbus/dbus-transport-protected.h: remove messages_pending call,
475 since it resulted in too much inefficient watch adding/removing;
476 instead we now require that the transport user does an iteration
477 after queueing outgoing messages, and after trying the first
478 write() we add a write watch if we got EAGAIN or exceeded our
479 max bytes to write per iteration setting
481 * dbus/dbus-string.c (_dbus_string_validate_signature): add this
484 * dbus/dbus-server-unix.c (unix_finalize): the socket name was
485 freed and then accessed, valgrind flagged this bug, fix it
487 * dbus/dbus-message.c: fix several bugs where HEADER_FIELD_LAST was taken
488 as the last valid field plus 1, where really it is equal to the
489 last valid field. Corrects some message corruption issues.
491 * dbus/dbus-mainloop.c: verbosity changes
493 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): handle OOM
494 instead of aborting in one of the test codepaths
496 * dbus/dbus-internals.c (_dbus_verbose_real): fix a bug that
497 caused not printing the pid ever again if a verbose was missing
498 the newline at the end
499 (_dbus_header_field_to_string): add HEADER_FIELD_SIGNATURE
501 * dbus/dbus-connection.c: verbosity changes;
502 (dbus_connection_has_messages_to_send): new function
503 (_dbus_connection_message_sent): no longer call transport->messages_pending
504 (_dbus_connection_send_preallocated_unlocked): do one iteration to
505 try to write() immediately, so we can avoid the write watch. This
506 is the core purpose of this patchset
507 (_dbus_connection_get_dispatch_status_unlocked): if disconnected,
508 dump the outgoing message queue, so nobody will get confused
509 trying to send them or thinking stuff is pending to be sent
511 * bus/test.c: verbosity changes
513 * bus/driver.c: verbosity/assertion changes
515 * bus/dispatch.c: a bunch of little tweaks to get it working again
516 because this patchset changes when/where you need to block.
518 2004-11-23 Havoc Pennington <hp@redhat.com>
520 * test/glib/test-profile.c: modify to accept a plain_sockets
521 argument in which case it will bench plain sockets instead of
522 libdbus, for comparison purposes.
524 2004-11-22 Havoc Pennington <hp@redhat.com>
526 * test/glib/test-profile.c (N_CLIENT_THREADS): run multiple
527 threads for more time, so sysprof can get a grip on it.
529 * dbus/dbus-string.c (_dbus_string_validate_utf8): remove
532 2004-11-13 Havoc Pennington <hp@redhat.com>
534 * test/glib/test-profile.c: fix this thing up a bit
536 * dbus/dbus-message.c (dbus_message_new_empty_header): increase
537 preallocation sizes by a fair bit; not sure if this will be an
538 overall performance win or not, but it does reduce reallocs.
540 * dbus/dbus-string.c (set_length, reallocate_for_length): ignore
541 the test hack that forced constant realloc if asserts are
542 disabled, so we can profile sanely. Sprinkle in some
543 _DBUS_UNLIKELY() which are probably pointless, but before I
544 noticed the real performance problem I put them in.
545 (_dbus_string_validate_utf8): micro-optimize this thing a little
546 bit, though callgrind says it didn't help; then special-case
547 ascii, which did help a lot; then be sure we detect nul bytes as
548 invalid, which is a bugfix.
549 (align_length_then_lengthen): add some more _DBUS_UNLIKELY
550 superstition; use memset to nul the padding instead of a manual
552 (_dbus_string_get_length): inline this as a
553 macro; it showed up in the profile because it's used for loop
556 2004-11-10 Colin Walters <walters@verbum.org>
558 * dbus/dbus-spawn.c (check_babysit_events): Handle EINTR,
561 2004-11-09 Colin Walters <walters@verbum.org>
563 * dbus/dbus-string.c (_dbus_string_get_length): New
564 function, writes DBusString to C buffer.
566 * dbus/dbus-string.h: Prototype it.
568 * dbus/dbus-message.c (dbus_message_type_to_string): New
569 function, converts message type into C string.
571 * dbus/dbus-message.h: Prototype it.
573 * bus/selinux.c (bus_selinux_check): Take source pid,
574 target pid, and audit data. Pass audit data to
576 (log_audit_callback): New function, appends extra
578 (bus_selinux_allows_acquire_service): Also take
579 service name, add it to audit data.
580 (bus_selinux_allows_send): Also take message
581 type, interface, method member, error name,
582 and destination, and add them to audit data.
583 (log_cb): Initialize func_audit.
585 * bus/selinux.h (bus_selinux_allows_acquire_service)
586 (bus_selinux_allows_send): Update prototypes
588 * bus/services.c (bus_registry_acquire_service): Pass
589 service name to bus_selinux_allows_acquire_service.
591 * bus/bus.c (bus_context_check_security_policy): Pass
592 additional audit data. Move assignment of dest
595 2004-11-07 Colin Walters <walters@verbum.org>
597 * dbus/dbus-transport-unix.c (do_authentication): Always
598 initialize auth_completed.
600 2004-11-07 Colin Walters <walters@verbum.org>
602 * bus/bus.c (load_config): Break into three
603 separate functions: process_config_first_time_only,
604 process_config_every_time, and process_config_postinit.
605 (process_config_every_time): Move call of
606 bus_registry_set_service_context_table into
607 process_config_postinit.
608 (process_config_postinit): New function, does
609 any processing that needs to happen late
610 in initialization (and also on reload).
611 (bus_context_new): Instead of calling load_config,
612 open config parser here and call process_config_first_time_only
613 and process_config_every_time directly. Later, after
614 we have forked but before changing UID,
615 invoke bus_selinux_full_init, and then call
616 process_config_postinit.
617 (bus_context_reload_config): As in bus_context_new,
618 load parse file inside here, and call process_config_every_time
619 and process_config_postinit.
621 * bus/services.h, bus/services.c
622 (bus_registry_set_service_context_table): Rename
623 from bus_registry_set_sid_table. Take string hash from config
624 parser, and convert them here into SIDs.
626 * bus/config-parser.c (struct BusConfigParser): Have
627 config parser only store a mapping of service->context
629 (merge_service_context_hash): New function.
630 (merge_included): Merge context string hashes instead
631 of using bus_selinux_id_table_union.
632 (bus_config_parser_new): Don't use bus_selinux_id_table_new;
633 simply create a new string hash.
634 (bus_config_parser_unref): Unref it.
635 (start_selinux_child): Simply insert strings into hash,
636 don't call bus_selinux_id_table_copy_over.
638 * bus/selinux.h, bus/selinux.c (bus_selinux_id_table_union)
639 (bus_selinux_id_table_copy_over): Delete.
641 2004-11-03 Colin Walters <walters@verbum.org>
643 * bus/selinux.c (bus_selinux_pre_init): Kill some unused
646 2004-11-03 Colin Walters <walters@verbum.org>
648 * bus/test-main.c (test_pre_hook): Fix test logic,
649 thanks Joerg Barfurth <Joerg.Barfurth@Sun.COM>.
651 2004-11-02 Colin Walters <walters@redhat.com>
653 * bus/selinux.c (bus_selinux_init): Split into two functions,
654 bus_selinux_pre_init and bus_selinux_post_init.
655 (bus_selinux_pre_init): Just determine whether SELinux is
657 (bus_selinux_post_init): Do everything else.
659 * bus/main.c (main): Call bus_selinux_pre_init before parsing
660 config file, and bus_selinux_post_init after. This ensures that
661 we don't lose the policyreload notification thread that
662 bus_selinux_init created before forking previously.
664 * bus/test-main.c (test_pre_hook): Update for split.
666 2004-10-31 Owen Fraser-Green <owen@discobabe.net>
668 Patch from Johan Fischer <linux@fischaz.com>
670 * mono/doc/Makefile.am (install-data-local): Added directory
673 2004-10-29 Colin Walters <walters@redhat.com>
675 * dbus/dbus-sysdeps.h (_dbus_become_daemon): Also take
676 parameter for fd to write pid to.
678 * dbus/dbus-sysdeps.c (_dbus_become_daemon): Implement it.
680 * bus/bus.c (bus_context_new): Pass print_pid_fd
681 to _dbus_become_daemon (bug #1720)
683 2004-10-29 Colin Walters <walters@redhat.com>
685 Patch from Ed Catmur <ed@catmur.co.uk>
687 * mono/doc/Makefile.am (install-data-local): Handle
690 2004-10-29 Colin Walters <walters@redhat.com>
692 * bus/.cvsignore, qt/.cvsignore: Update.
694 2004-10-29 Colin Walters <walters@redhat.com>
696 Patch from Kristof Vansant <de_lupus@pandora.be>
698 * configure.in: Detect Slackware.
699 * bus/Makefile.am (SCRIPT_IN_FILES): Add rc.messagebus.in.
700 * bus/rc.messagebus.in: New file.
702 2004-10-29 Colin Walters <walters@redhat.com>
704 * tools/dbus-monitor.c (filter_func): Return
705 DBUS_HANDLER_RESULT_HANDLED in filter function
707 http://freedesktop.org/pipermail/dbus/2004-August/001433.html
709 2004-10-29 Colin Walters <walters@redhat.com>
711 Patch from Matthew Rickard <mjricka@epoch.ncsc.mil>
713 * bus/services.c (bus_registry_acquire_service):
714 Correctly retrieve service name from DBusString
717 2004-10-29 Colin Walters <walters@redhat.com>
719 * dbus/dbus-glib.h: Update documentation to not
720 refer to internal APIs.
722 2004-10-27 Joe Shaw <joeshaw@novell.com>
724 * mono/Arguments.cs (GetDBusTypeConstructor):
725 type.UnderlyingSystemType will return "System.Byte" if you do it
726 on "byte[]", which is not what we want. So check the type.IsArray
727 property and use System.Array instead.
729 2004-10-25 John (J5) Palmieri <johnp@redhat.com>
731 * dbus/dbus-sysdeps.c (fill_user_info): On errors do not free
732 the DBusUserInfo structure since this is passed into the function.
733 This would cause a double free when the function that allocated
734 the structure would try to free it when an error occured.
736 * (bus/session.conf.in, bus/Makefile.am, dbus/configure.in):
737 use /usr/share/dbus-1/services instead of /usr/lib/dbus-1.0/services
738 for service activation to avoid 32bit/64bit parallel install issues
740 2004-10-21 Colin Walters <walters@verbum.org>
742 * AUTHORS: Fix my email address, the @gnu.org one
743 has been bouncing for some time. Also add J5.
745 2004-10-21 Colin Walters <walters@verbum.org>
747 * dbus/dbus-transport-unix.c (do_authentication): Return
748 authentication status to callers.
749 (unix_handle_watch): If we completed authentication this round,
750 don't do another read. Instead wait until the next iteration,
751 after we've read any pending data in the auth buffer.
752 (unix_do_iteration): Ditto.
753 (unix_handle_watch): Updated for new do_authentication prototype.
755 2004-10-18 Colin Walters <walters@verbum.org>
757 * bus/selinux.c (bus_selinux_enabled): Handle
758 --disable-selinux case.
760 2004-10-18 Colin Walters <walters@verbum.org>
762 * bus/selinux.h: Add bus_selinux_enabled.
764 * bus/selinux.c (bus_selinux_enabled): Implement it.
766 * bus/config-parser.c (struct include): Add
767 if_selinux_enabled member.
768 (start_busconfig_child): Parse if_selinux_enabled
769 attribute for include.
770 (bus_config_parser_content): Handle it.
772 * bus/session.conf.in, bus/system.conf.in: Add
773 inclusion of context mapping to default config files;
774 conditional on SELinux being enabled.
776 * doc/busconfig.dtd: Add to if_selinux_enabled to default DTD.
778 * test/data/invalid-config-files/badselinux-1.conf,
779 test/data/invalid-config-files/badselinux-2.conf:
780 Test files for bad syntax.
782 2004-10-17 Colin Walters <walters@verbum.org>
784 * dbus/dbus-memory.c (_dbus_initialize_malloc_debug, check_guards)
785 (dbus_malloc, dbus_malloc0, dbus_realloc): Fix up printf
786 format specifier mismatches.
788 2004-10-07 Olivier Andrieu <oliv__a@users.sourceforge.net>
790 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): fix an incorrect
793 * glib/dbus-dbus-gmain.c (dbus_g_bus_get): do not mangle NULL
794 pointer (bug #1540, Leonardo Boiko).
796 2004-09-28 Jon Trowbridge <trow@ximian.com>
798 * mono/BusDriver.cs: Changed BusDriver struct to remove
799 the ServiceCreated and ServiceDeleted events and replace them
800 with the new ServiceOwnerChanged event.
802 * mono/example/BusListener.cs: Added a new example program,
803 which listens for and reports any ServiceOwnerChanged events
806 * mono/example/Makefile.am (DESTDIR): Build changes for the
807 new BusListener.cs example.
809 2004-09-27 Olivier Andrieu <oliv__a@users.sourceforge.net>
811 * bus/signals.c (bus_match_rule_parse): validate the components of
812 match rules (bug #1439).
814 * dbus/dbus-bus.c (dbus_bus_add_match): add a missing OOM test.
816 2004-09-24 Olivier Andrieu <oliv__a@users.sourceforge.net>
818 * doc/dbus-specification.xml: document ServiceOwnerChanged
821 * bus/driver.c, bus/driver.h, bus/services.c: Use
822 ServiceOwnerChanged signal instead of ServiceCreated and
825 * bus/dispatch.c: update testcase for the new signal.
827 2004-09-20 Jon Trowbridge <trow@ximian.com>
829 Patch from Nat Friedman <nat@novell.com>
831 * mono/Makefile.am: A number of small build fixes to allow "make
832 distcheck" to succeed.
834 * mono/example/Makefile.am: "make distcheck" fixes.
836 * mono/AssemblyInfo.cs.in: When signing the assembly, look for the
839 * test/Makefile.am: "make distcheck" fixes.
841 2004-09-17 Olivier Andrieu <oliv__a@users.sourceforge.net>
843 * dbus/dbus-sysdeps.c (_dbus_user_at_console): fix memleak in OOM.
845 * doc/busconfig.dtd: update the DTD for the at_console attribute.
847 * bus/driver.c (bus_driver_handle_hello): correctly handle Hello
848 messages after the first one (bug #1389).
850 * bus/dispatch.c (check_double_hello_message): add a test case for
851 the double hello message bug.
852 (check_existent_service_activation): fix check of spawning error.
854 2004-09-16 David Zeuthen <david@fubar.dk>
856 * python/dbus_bindings.pyx.in: Add support for int64 and uint64
858 2004-09-12 David Zeuthen <david@fubar.dk>
860 Patch from Kay Sievers <kay.sievers@vrfy.org>
862 * bus/bus.c (bus_context_new):
866 Add commandline option --nofork to override configuration file
869 2004-09-09 Olivier Andrieu <oliv__a@users.sourceforge.net>
871 * dbus/dbus-*.h: remove the ; after DBUS_(BEGIN|END)_DECLS. Some C
872 compilers don't like it (bug #974).
874 2004-09-04 Harald Fernengel <harry@kdevelop.org>
876 * qt/connection.*: Applied patch by Jérôme Lodewyck
877 <lodewyck@clipper.ens.fr> to integrate an existing
878 connection into the Qt eventloop
880 2004-08-30 Jon Trowbridge <trow@ximian.com>
882 * mono/BusDriver.cs: Added. This is a class for interacting with
883 the org.freedesktop.DBus service.
885 * mono/Message.cs: Added a mechanism to expose the message that is
886 currently being dispatched via the static Message.Current
887 property. Added Message.Sender and Message.Destination
890 * mono/Handler.cs: Expose the dispatched message via
891 Message.Current when handling method calls.
893 * mono/Service.cs: Expose the dispatched message via
894 Message.Current when handling signal emissions.
896 * mono/Connection.cs: Bind dbus_bus_get_base_service via the
897 Connection.BaseService property.
899 2004-08-28 Havoc Pennington <hp@redhat.com>
901 * dbus/dbus-userdb.c (_dbus_is_console_user): remove unused variable
903 More fixes from Steve Grubb
905 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): fix fd leak
906 (_dbus_listen_tcp_socket): fix fd leak
908 * dbus/dbus-spawn.c (read_pid, read_ints): move the "again:" for
909 EINTR to a bit lower in the code
911 2004-08-26 Jon Trowbridge <trow@ximian.com>
913 * bus/driver.c (bus_driver_handle_service_exists): Respond with
914 TRUE if we are inquiring about the existence of the built-in
915 org.freedesktop.DBus service.
917 2004-08-25 John Palmieri <johnp@redhat.com>
918 * bus/config-parser.c:
919 (struct PolicyType): Add POLICY_CONSOLE
920 (struct Element.d.policy): s/gid_or_uid/gid_uid_or_at_console
921 (start_busconfig_child): Sets up console element when
922 <policy at_console=""> is encountered in a policy file
923 (append_rule_from_element): Convert console elements to console
927 (bus_policy_create_client_policy): Add console rules to the client
928 policy based on if the client is at the console
929 (bus_policy_append_console_rule): New function for adding a
930 console rule to a policy
931 (bus_policy_merge): Handle console rule merging
933 * dbus/dbus-sysdeps.h: Added the DBUS_CONSOLE_DIR constant
934 where we check for console user files
936 * dbus/dbus-sysdeps.c:
937 (_dbus_file_exists): New function which checks if the given
939 (_dbus_user_at_console): New function which does the system
940 specific process of checking if the user is at the console
942 * dbus/dbus-userdb.c:
943 (_dbus_is_console_user): New function converts a UID to user name
944 and then calls the system specific _dbus_user_at_console to
945 see if the user is at the console and therefor a console user
947 2004-08-25 Olivier Andrieu <oliv__a@users.sourceforge.net>
949 * bus/config-parser.c (set_limit):
950 * bus/dbus-daemon-1.1.in:
951 * test/data/valid-config-files/many-rules.conf: set the
952 max_match_rules_per_connection limt from the config file.
954 * doc/busconfig.dtd: update the DTD.
956 * bus/driver.c: remove some unused variables.
958 2004-08-24 Mikael Hallendal <micke@imendio.com>
960 * dbus/dbus-glib-lowlevel.h: Removed dbus_bus_get_with_g_main since
961 it's been replaced by dbus_g_bus_get
963 2004-08-23 Colin Walters <walters@redhat.com>
965 Updated SELinux support from Matthew Rickard <mjricka@epoch.ncsc.mil>
967 * bus/selinux.h: Prototype bus_selinux_get_policy_root.
969 * bus/selinux.c: Create a thread for policy reload notification.
970 (bus_selinux_get_policy_root): Implement.
972 * bus/config-parser.c (start_busconfig_child)
973 (bus_config_parser_content): Support SELinux-root relative
976 * configure.in <HAVE_SELINUX>: Add -lpthread.
978 * bus/test-main.c (test_pre_hook, test_post_hook): New.
979 (test_post_hook): Move memory checking into here.
980 (test_pre_hook, test_post_hook): Move SELinux checks in
981 here, but conditional on a DBUS_TEST_SELINUX environment
982 variable. Unfortunately we can't run the SELinux checks
983 as a normal user, since they won't have any permissions
984 for /selinux. So this will have to be tested manually
985 for now, until we have virtualization for most of
988 2004-08-23 Havoc Pennington <hp@redhat.com>
990 * dbus/dbus-sysdeps.c (_dbus_change_identity): add setgroups() to
991 drop supplementary groups, suggested by Steve Grubb
993 2004-08-20 Colin Walters <walters@redhat.com>
995 * bus/config-parser.c (start_busconfig_child): Remove some unused
998 * bus/selinux.c (bus_selinux_id_table_insert): Avoid compiler
1001 2004-08-17 Joe Shaw <joeshaw@novell.com>
1003 * configure.in: If --enable-mono is passed in, if we can't find
1006 * mono/Makefile.am: Use /gacutil to install assemblies into the
1009 2004-08-12 Havoc Pennington <hp@redhat.com>
1011 * NEWS: update for 0.22
1013 * configure.in: release 0.22
1015 2004-08-11 Colin Walters <walters@redhat.com>
1017 * tools/dbus-send.c (main, usage): Add --reply-timeout
1020 2004-08-10 Olivier Andrieu <oliv__a@users.sourceforge.net>
1022 * bus/bus.c (process_config_first_time_only): get rid of an unused
1023 DBusError that was causing a memoy leak (bug #989).
1025 * dbus/dbus-keyring.c, dbus/dbus-message.c:
1026 fix compilation on Solaris/Forte C (bug #974)
1028 * bus/main.c (main): plug two minuscule memleaks.
1030 2004-08-10 Havoc Pennington <hp@redhat.com>
1032 * doc/dbus-tutorial.xml: add some more info on GLib bindings
1034 2004-08-09 Havoc Pennington <hp@redhat.com>
1036 * COPYING: switch to Academic Free License version 2.1 instead of
1037 2.0, to resolve complaints about patent termination clause.
1039 2004-07-31 John (J5) Palmieri <johnp@redhat.com>
1041 * README: added documentation for the --enable-python
1044 2004-07-31 Olivier Andrieu <oliv__a@users.sourceforge.net>
1046 * bus/config-parser.c (bus_config_parser_new): fix an invalid
1047 _unref in the SELinux support.
1049 * doc/busconfig.dtd: update DTD for SELinux support.
1051 * bus/config-loader-libxml.c: fix error handler and parser
1052 initialisation/cleanup. OOM test now works with libxml2 HEAD.
1054 * configure.in: remove the warning about libxml2.
1056 * dbus/dbus-bus.c: silence doxygen warning.
1058 2004-07-31 Colin Walters <walters@redhat.com>
1060 * configure.in: Move #error in SELinux check to its own line.
1062 2004-07-31 Olivier Andrieu <oliv__a@users.sourceforge.net>
1064 * dbus/dbus-internals.h (_DBUS_SET_OOM):
1065 * bus/utils.h (BUS_SET_OOM): use dbus_error_set_const instead of
1068 * bus/dispatch.c (check_send_exit_to_service): fix the test case,
1069 broken by the change in the _SET_OOM macros.
1071 2004-07-31 Colin Walters <walters@redhat.com>
1073 * bus/selinux.c <HAVE_SELINUX>: Include utils.h to get
1076 2004-07-31 Colin Walters <walters@redhat.com>
1078 * configure.in: Use AC_TRY_COMPILE instead of AC_EGREP_HEADER
1079 to correctly detect DBUS__ACQUIRE_SVC. Also add an
1082 2004-07-24 Havoc Pennington <hp@redhat.com>
1084 SELinux support from Matthew Rickard <mjricka@epoch.ncsc.mil>
1086 * bus/selinux.c, bus/selinux.h: new file encapsulating selinux
1089 * configure.in: add --enable-selinux
1091 * bus/policy.c (bus_policy_merge): add FIXME to a comment
1093 * bus/main.c (main): initialize and shut down selinux
1095 * bus/connection.c: store SELinux ID on each connection, to avoid
1096 repeated getting of the string context and converting it into
1099 * bus/bus.c (bus_context_get_policy): new accessor, though it
1101 (bus_context_check_security_policy): check whether the security
1102 context of sender connection can send to the security context of
1103 recipient connection
1105 * bus/config-parser.c: add parsing for <selinux> and <associate>
1107 * dbus/dbus-transport.c (_dbus_transport_get_unix_fd): to
1108 implement dbus_connection_get_unix_fd()
1110 * dbus/dbus-connection.c (dbus_connection_get_unix_fd): new
1111 function, used by the selinux stuff
1113 2004-07-29 Olivier Andrieu <oliv__a@users.sourceforge.net>
1115 * bus/config-loader-libxml.c: complete the implementation of
1116 libxml backend for config file loader. Doesn't work with full OOM
1119 * configure.in: change error when selecting libxml into a warning.
1121 * test/data/invalid-config-files: add two non-well-formed XML
1124 * glib/Makefile.am: libdbus_gtool always uses expat, not libxml.
1126 * dbus/dbus-transport-unix.c (unix_handle_watch): do not
1127 disconnect in case of DBUS_WATCH_HANGUP, several do_reading() may
1128 be necessary to read all the buffer. (bug #894)
1130 * bus/activation.c (bus_activation_activate_service): fix a
1131 potential assertion failure (bug #896). Small optimization in the
1132 case of auto-activation messages.
1134 * dbus/dbus-message.c (verify_test_message, _dbus_message_test):
1135 add test case for byte-through-vararg bug (#901). patch by Kimmo
1138 2004-07-28 Anders Carlsson <andersca@gnome.org>
1141 * python/dbus_bindings.pyx.in:
1142 Add dbus.init_gthreads (), allow emit_signal to pass
1143 arguments to the signal.
1145 2004-07-24 Havoc Pennington <hp@redhat.com>
1147 * AUTHORS: add some people, not really comprehensively, let me
1148 know if I missed you
1150 2004-07-24 Havoc Pennington <hp@redhat.com>
1152 * Makefile.am (DIST_SUBDIRS): add DIST_SUBDIRS, problem solved by
1155 * test/Makefile.am (DIST_SUBDIRS): here also
1157 2004-07-22 Olivier Andrieu <oliv__a@users.sourceforge.net>
1159 * dbus/dbus-sysdeps.c (fill_user_info): fix inexistent label name,
1160 breaking build on Solaris, reported by Farhad Saberi on the ML.
1162 * dbus/dbus-message.c (dbus_message_append_args_valist): fix the
1163 va_arg invocation to account for integer promotion in the case of
1164 DBUS_TYPE_BYTE (unsigned char is promoted to int). (bug #901)
1166 * bus/services.c (bus_service_remove_owner): fix bug #902, use
1167 _dbus_list_get_first_link, not _dbus_list_get_first.
1169 * dbus/dbus-bus.c (dbus_bus_service_exists): plug a memory leak.
1171 * dbus/dbus-object-tree.c (free_subtree_recurse): always null
1172 handler functions so that the asserts in _dbus_object_subtree_unref
1175 * dbus/dbus-transport-unix.c (do_reading):
1176 _dbus_transport_queue_messages return value is of type
1177 dbus_bool_t, not DBusDispatchStatus.
1179 2004-07-19 David Zeuthen <david@fubar.dk>
1181 * dbus/dbus-protocol.h: Add DBUS_ERROR_UNIX_PROCESS_ID_UNKNOWN
1184 (check_get_connection_unix_user): Debug says GetProperty; but the
1185 method is called GetConnectionUnixUser
1186 (check_get_connection_unix_process_id): New function
1187 (bus_dispatch_test): Actually call check_get_connection_unix_user();
1188 also call check_get_connection_unix_process_id()
1191 (bus_driver_handle_get_connection_unix_process_id): New function,
1192 handles GetConnectionUnixProcessID on the org.freedesktop.DBus
1196 (handle_server_data_external_mech): Set pid from the credentials
1197 obtained from the socket
1199 * dbus/dbus-connection.c:
1200 (dbus_connection_get_unix_process_id): New function
1202 * dbus/dbus-connection.h:
1203 Add prototype for dbus_connection_get_unix_process_id
1205 * dbus/dbus-transport.c:
1206 (_dbus_transport_get_unix_process_id): New function
1208 * dbus/dbus-transport.h:
1209 Add prototype for _dbus_transport_get_unix_process_id
1211 2004-07-19 Olivier Andrieu <oliv__a@users.sourceforge.net>
1213 * dbus/dbus-message.c: Message counter fix, patch by Christian
1214 Hammond <chipx86@gnupdate.org>
1216 2004-07-18 Seth Nickell <seth@gnome.org>
1219 * python/dbus_bindings.pyx.in:
1220 * python/tests/test-client.py:
1222 Add dbus.ByteArray and dbus_bindings.ByteArray
1223 types so that byte streams can be passed back.
1225 Give jdahlin the heaps of credit that are so
1228 2004-07-12 Seth Nickell <seth@gnome.org>
1232 Add message argument to the default object_method_handler
1235 * python/dbus_bindings.pyx.in:
1237 Automatically return NIL when passed an empty list
1238 (we can't pass back a list since lists are typed
1239 and we don't have any idea what type the the client
1240 intended the list to be... :-( )
1242 2004-07-10 Seth Nickell <seth@gnome.org>
1244 * python/examples/Makefile.am:
1246 Fix distcheck breakage caused by new examples.
1248 2004-07-10 Seth Nickell <seth@gnome.org>
1252 Add "message" argument to service-side dbus.Object
1253 methods. This will break existing services written
1254 using the python bindings, but will allow extraction
1255 of all the message information (e.g. who its from).
1257 Add improved "object oriented" signal handling/emission.
1259 * python/examples/example-service.py:
1263 * python/examples/example-signal-emitter.py:
1264 * python/examples/example-signal-recipient.py:
1266 Two new examples that show how to emit and receive
1267 signals using the new APIs.
1269 * python/examples/example-signals.py:
1270 * python/examples/gconf-proxy-service.py:
1271 * python/examples/gconf-proxy-service2.py:
1273 Add "message" argument to service methods.
1275 2004-06-28 Kay Sievers <kay.sievers@vrfy.org>
1277 * bus/driver.c (bus_driver_handle_get_connection_unix_user)
1278 * dbus/bus.c (dbus_bus_get_unix_user)
1279 * doc/dbus-specification.xml: implement GetConnectionUnixUser
1280 method of org.freedesktop.DBus interface.
1282 * bus/dispatch.c: test case
1284 2004-06-23 John (J5) Palmieri <johnp@redhat.com>
1286 * python/Makefile.am: switched include directory from glib/ to dbus/
1287 since dbus-glib.h moved
1289 2004-06-22 Olivier Andrieu <oliv__a@users.sourceforge.net>
1291 * configure.in: prevent building the gcj stuff and libxml loader
1292 since they are broken.
1294 2004-06-20 Havoc Pennington <hp@redhat.com>
1296 * dbus/dbus-glib-error-enum.h: autogenerate the GError enum
1297 codes from the dbus error names
1299 * glib/dbus-glib.h: move to subdir dbus/ since it's included
1300 as dbus/dbus-glib.h and that breakage is now visible due to
1301 including dbus/dbus-glib.h in dbus-glib-lowlevel.h
1303 * glib/dbus-glib.h: s/gproxy/g_proxy/
1305 * dbus/dbus-shared.h: new header to hold stuff shared with
1308 * dbus/dbus-protocol.h (DBUS_ERROR_*): move errors here rather
1311 * glib/dbus-glib.h (dbus_set_g_error): move to
1312 dbus-glib-lowlevel.h
1314 * glib/dbus-glib.h: remove dbus/dbus.h from here; change a bunch
1315 of stuff to enable this
1317 * dbus/dbus-glib-lowlevel.h: put dbus/dbus.h here
1319 * a bunch of other changes with the same basic "separate glib
1320 bindings from dbus.h" theme
1322 2004-06-10 Owen Fraser-Green <owen@discobabe.net>
1324 * dbus-sharp.pc.in: Removed glib-sharp inclusion in Libs.
1326 * python/examples/Makefile.am: Fixed typo in EXTRA_DIST.
1328 2004-06-09 Olivier Andrieu <oliv__a@users.sourceforge.net>
1330 * bus/driver.c, dbus/dbus-bus.c: use BOOLEAN instead of UINT32 for
1331 the reply value of the ServiceExists message.
1333 2004-06-07 John (J5) Palmieri <johnp@redhat.com>
1335 * python/dbus_bindings.pyx.in: No longer need to parse path
1336 elements and pass them as arrays of strings. The C API now
1337 accepts plain path strings.
1338 (_build_parsed_path): removed
1340 2004-06-07 Havoc Pennington <hp@redhat.com>
1342 * doc/TODO: remove auto-activation item since it's done; sort
1343 items by importance/milestone
1345 2004-06-07 Havoc Pennington <hp@redhat.com>
1347 * dbus/dbus-message-builder.c (_dbus_message_data_load): append
1348 random signature when using REQUIRED_FIELDS (this hack won't work
1351 * dbus/dbus-message.c: change the signature to be a header field,
1352 instead of message->signature special-case string. Incremental
1353 step forward. Then we can fix up code to send the signature in the
1354 message, then fix up code to validate said signature, then fix up
1355 code to not put the typecodes inline, etc.
1356 (load_one_message): don't make up the signature after the fact
1357 (decode_header_data): require signature field for the known
1360 * dbus/dbus-marshal.c (_dbus_marshal_string_len): new
1362 * dbus/dbus-protocol.h: add DBUS_HEADER_FIELD_SIGNATURE
1364 2004-06-07 Owen Fraser-Green <owen@discobabe.net>
1366 * mono/DBusType/ObjectPath.cs: Renamed PathName argument to Path
1368 * mono/Handler.cs: Updated to follow new path argument for
1369 (un-)registering objects.
1371 * mono/example/Makefile.am:
1373 * configure.in: Bumped required version for mono and use new -pkg
1376 2004-06-05 Olivier Andrieu <oliv__a@users.sourceforge.net>
1378 * dbus/dbus-connection.h, dbus/dbus-connection.c: have object path
1379 registration functions take the path argument as char* instead of
1382 * dbus/dbus-marshal.h, dbus/dbus-marshal.c (_dbus_decompose_path):
1383 split off the path decompostion part of
1384 _dbus_demarshal_object_path. Some misc. fixes to silence compiler
1387 * glib/dbus-gobject.c, test/test-service.c: update accordingly.
1389 2004-06-02 Kristian Høgsberg <krh@redhat.com>
1391 * dbus/dbus-auth.c: Rewrite auth protocol handling to use a state
1392 machine approach. A state is implemented as a function that
1393 handles incoming events as specified for that state.
1395 * doc/dbus-specification.xml: Update auth protocol state machine
1396 specification to match implementation. Remove some leftover
1399 2004-06-02 Kristian Høgsberg <krh@redhat.com>
1401 * glib/dbus-gproxy.c, glib/dbus-gmain.c, dbus/dbus-string.c,
1402 dbus/dbus-object-tree.c, dbus/dbus-message.c: add comments to
1405 * Doxyfile.in: remove deprecated options.
1407 * dbus/dbus-message-handler.c, dbus/dbus-message-handler.h,
1408 glib/test-thread.h, glib/test-thread-client.c,
1409 glib/test-thread-server.c, glib/test-profile.c,
1410 glib/test-dbus-glib.c: remove these unused files.
1412 2004-06-01 Olivier Andrieu <oliv__a@users.sourceforge.net>
1414 * dbus/dbus-object-tree.c
1415 (_dbus_object_tree_dispatch_and_unlock): fix dispatch for
1416 non-fallback handlers (bug #684).
1417 (_dbus_object_subtree_new): initialize invoke_as_fallback field.
1418 (find_subtree_recurse): report wether the returned subtree is an
1419 exact match or a "fallback" match higher up in the tree.
1420 (object_tree_test_iteration): update test case.
1422 2004-06-01 Seth Nickell <seth@gnome.org>
1424 * python/dbus_bindings.pyx.in:
1425 * python/tests/test-client.py:
1427 Round off basic type support. Add dicts (yay!), and
1428 remaining array types.
1430 Make MessageIter more general so it works for dicts too.
1432 Mark all loop variables as C integers.
1434 2004-05-31 Havoc Pennington <hp@redhat.com>
1436 * glib/dbus-gidl.c (method_info_add_arg): keep args sorted with
1439 * glib/dbus-gobject.c (dbus_type_to_string): move to dbus-gutils.c
1441 * glib/dbus-glib-tool.c (main): set up to have a --self-test
1442 option that runs the tests, and start filling in some code
1443 including for starters just dumping the interfaces to stdout
1445 * glib/Makefile.am (INCLUDES): define DBUS_LOCALEDIR
1447 * test/data/valid-introspection-files/lots-of-types.xml: test of
1448 an example introspection file
1450 * glib/dbus-gparser.c (parser_check_doctype): doctype should be
1453 2004-05-31 Seth Nickell <seth@gnome.org>
1455 * python/dbus_bindings.pyx.in:
1456 * python/tests/test-client.py:
1461 Fix string array memory trashing bug... oops...
1463 2004-05-30 Seth Nickell <seth@gnome.org>
1467 Add a nicer-but-less-flexible alternate API for handling
1468 calls to virtual objects in dbus.ObjectTree.
1470 Screw up the argument order to the dbus.Object constructor
1471 for consistency with dbus.ObjectTree (and to make dbus_methods
1472 optional for future extension)
1474 * python/examples/Makefile.am:
1475 * python/examples/gconf-proxy-service.py:
1476 * python/examples/gconf-proxy-service2.py:
1478 Alternate implementation of gconf-proxy-service using the
1479 nicer dbus.ObjectTree API.
1481 * python/examples/example-service.py:
1482 * python/tests/test-server.py
1484 Reverse the argument order to deal with dbus.Object constructor
1487 2004-05-30 Seth Nickell <seth@gnome.org>
1489 * python/examples/example-client.py:
1490 * python/examples/example-service.py:
1492 Take it back. Lists seem to work but they're broken
1493 in the test suite. Make the base examples use
1496 2004-05-30 Seth Nickell <seth@gnome.org>
1498 * python/dbus_bindings.pyx.in:
1499 * python/tests/test-client.py:
1501 Add some more tests and fix errors that crop up.
1502 Unfortunately, currently it seems like marshalling
1503 and unmarshalling of lists is completely broken :-(
1505 2004-05-30 Seth Nickell <seth@gnome.org>
1507 * python/dbus_bindings.pyx.in:
1509 Add support for ObjectPath type.
1513 Refactor message handling code to a common function.
1515 * python/tests/test-client.py:
1516 * python/tests/test-server.py:
1518 Add tests that check to make sure values of all types
1519 can be echoed from a service w/o mangling.
1521 2004-05-29 Seth Nickell <seth@gnome.org>
1525 Add ObjectTree class which allows implementation
1526 of trees of "virtual" objects. Basically the python
1527 wrapper for "register_fallback".
1529 * python/examples/Makefile.am
1530 * python/examples/gconf-proxy-client.py:
1531 * python/examples/gconf-proxy-service.py:
1533 Implement a simple GConf proxy service that supports
1534 get/set on string and int GConf keys using the ObjectTree.
1536 2004-05-29 Seth Nickell <seth@gnome.org>
1539 * python/examples/example-client.py:
1540 * python/examples/example-service.py:
1541 * python/examples/list-system-services.py:
1543 Add SessionBus, SystemBus and ActivationBus classes
1544 so you don't need to know the special little BUS_TYPE
1547 2004-05-29 Havoc Pennington <hp@redhat.com>
1549 * bus/config-parser.c (process_test_valid_subdir): temporarily
1550 stop testing config parser OOM handling, since expat has issues
1551 http://freedesktop.org/pipermail/dbus/2004-May/001153.html
1553 * bus/dbus-daemon-1.1.in: change requested_reply to
1554 send_requested_reply/receive_requested_reply so we can send the
1555 replies, not just receive them.
1557 * bus/config-parser.c: parse the new
1558 send_requested_reply/receive_requested_reply
1560 * bus/policy.c (bus_client_policy_check_can_send): add
1561 requested_reply argument and use it
1563 * bus/bus.c (bus_context_check_security_policy): pass through
1564 requested_reply status to message send check
1566 * bus/system.conf.in: adapt to requested_reply change
1568 2004-05-28 Havoc Pennington <hp@redhat.com>
1570 * test/glib/test-service-glib.c (main): remove unused variable
1572 * glib/dbus-gidl.c (base_info_ref): fix a silly compiler warning
1574 * dbus/dbus-auth.h (enum): remove AUTHENTICATED_WITH_UNUSED_BYTES
1575 from the enum, no longer in use.
1577 * dbus/dbus-sysdeps.h: include config.h so DBUS_VA_COPY actually
1580 * dbus/dbus-message.c: add various _dbus_return_val_if_fail for
1581 whether error_name passed in is a valid error name.
1583 2004-05-28 John (J5) Palmieri <johnp@redhat.com>
1585 * dbus/dbus-message.c (dbus_message_get_args): Added support for
1586 OBJECT_PATH and OBJECT_PATH_ARRAY
1588 2004-05-28 Seth Nickell <seth@gnome.org>
1590 * python/examples/Makefile.am:
1592 Forget to add Makefile.am. Do not pass go.
1594 2004-05-28 Michael Meeks <michael@ximian.com>
1596 * glib/dbus-gvalue.c (dbus_gvalue_marshal, dbus_gvalue_demarshal):
1599 * dbus/dbus-string.c (_dbus_string_parse_basic_type): impl.
1601 * dbus/dbus-message.c (_dbus_message_iter_get_basic_type),
1602 (_dbus_message_iter_get_basic_type_array): impl.
1603 drastically simplify ~all relevant _get methods to use these.
1604 (_dbus_message_iter_append_basic_array),
1605 (dbus_message_iter_append_basic): impl
1606 drastically simplify ~all relevant _append methods to use these.
1608 * dbus/dbus-message-builder.c (parse_basic_type)
1609 (parse_basic_array, lookup_basic_type): impl.
1610 (_dbus_message_data_load): prune scads of duplicate /
1613 * dbus/dbus-marshal.c (_dbus_demarshal_basic_type_array)
1614 (_dbus_demarshal_basic_type): implement,
1615 (demarshal_and_validate_len/arg): beef up debug.
1616 (_dbus_marshal_basic_type, _dbus_marshal_basic_type_array): impl.
1618 2004-05-27 Seth Nickell <seth@gnome.org>
1621 * python/Makefile.am:
1623 Include the example python apps in the tarball.
1625 * python/examples/list-system-services.py
1627 Add a python new example that fetches the list of services
1628 from the system bus.
1630 2004-05-27 Seth Nickell <seth@gnome.org>
1633 * python/dbus_bindings.pyx.in:
1635 Fix failure to notify that a signal was not handled,
1636 resulted in hung functions.
1638 2004-05-25 Colin Walters <walters@redhat.com>
1640 * tools/dbus-monitor.c (main): Monitor all types of messages.
1642 2004-05-23 Owen Fraser-Green <owen@discobabe.net>
1644 * mono/Handler.cs, mono/Service.cs: Added UnregisterObject method
1645 which unregisters the object path and disposes the handler.
1647 2004-05-23 Kristian Høgsberg <krh@redhat.com>
1649 Patch from Timo Teräs <ext-timo.teras@nokia.com> (#614):
1651 * dbus/dbus-message.c (dbus_message_iter_get_args_valist): Swap
1652 operands to && so we call dbus_message_iter_next () for the last
1655 2004-05-21 Olivier Andrieu <oliv__a@users.sourceforge.net>
1657 * dbus/dbus-object-tree.c
1658 (_dbus_object_tree_list_registered_unlock, lookup_subtree): return
1659 children even if the requested path isn't registered.
1660 (object_tree_test_iteration): test object_tree_list_registered.
1662 * configure.in: undefine HAVE_ABSTRACT_SOCKETS instead of defining
1665 2004-05-20 Kristian Høgsberg <krh@redhat.com>
1667 * doc/TODO: Remove resolved items.
1669 * bus/expirelist.h (struct BusExpireList): remove unused n_items
1672 * bus/connection.c (bus_connections_expect_reply): Enforce the
1673 per-connection limit on pending replies.
1675 Patch from Jon Trowbridge <trow@ximian.com>:
1677 * bus/main.c (setup_reload_pipe): Added. Creates a pipe and sets
1678 up a watch that triggers a config reload when one end of the pipe
1680 (signal_handler): Instead of doing the config reload in our SIGHUP
1681 handler, just write to the reload pipe and let the associated
1682 watch handle the reload when control returns to the main loop.
1684 * bus/driver.c (bus_driver_handle_reload_config): Added.
1685 Implements a ReloadConfig method for requesting a configuration
1686 file reload via the bus driver.
1688 2004-05-19 Owen Fraser-Green <owen@discobabe.net>
1690 * HACKING: Updated release instructions concerning the wiki page.
1692 2004-05-18 Kristian Høgsberg <krh@redhat.com>
1694 * dbus/dbus-auth.c (client_try_next_mechanism): Remove logic to
1695 filter against auth->allowed_mechs; we only add allowed mechs in
1696 record_mechanisms().
1698 * dbus/dbus-auth-script.c (_dbus_auth_script_run): Add an
1699 ALLOWED_MECHS to auth-script format so we can set the list of
1702 * data/auth/client-out-of-mechanisms.auth-script: New test to
1703 check client disconnects when it is out of mechanisms to try.
1705 * dbus/dbus-auth.c (process_command): Remove check for lines
1706 longer that 1 MB; we only buffer up maximum 16 kB.
1708 * dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
1709 dbus/dbus-auth-script.c, dbus/dbus-auth.c, dbus/dbus-auth.h:
1710 Remove auth state AUTHENTICATED_WITH_UNUSED_BYTES, instead always
1711 assume there might be unused bytes.
1713 * dbus/dbus-auth.c (_dbus_auth_do_work): Remove check for
1714 client-out-of-mechs, it is handled in process_reject(). Move check
1715 for max failures to send_rejected(), as it's a server-only thing.
1717 * dbus/dbus-auth.c: Factor out protocol reply code into functions
1718 send_auth(), send_data(), send_rejected(), send_error(),
1719 send_ok(), send_begin() and send_cancel().
1721 2004-05-17 Kristian Høgsberg <krh@redhat.com>
1723 Remove base64 encoding, replace with hex encoding. Original patch
1724 from trow@ximian.com, added error handling.
1726 * dbus/dbus-string.c (_dbus_string_base64_encode)
1727 (_dbus_string_base64_decode): Remove.
1728 (_dbus_string_hex_decode): Add end_return argument so we can
1729 distinguish between OOM and invalid hex encoding.
1730 (_dbus_string_test): Remove base64 tests and add test case for
1733 * dbus/dbus-keyring.c, dbus/dbus-auth-script.c, dbus/dbus-auth.c:
1734 Replace base64 with hex.
1736 * test/data/auth/invalid-hex-encoding.auth-script: New test case
1737 for invalid hex encoded data in auth protocol.
1739 2004-05-17 Olivier Andrieu <oliv__a@users.sourceforge.net>
1741 * dbus/dbus-connection.c (check_for_reply_unlocked): plug a memory
1744 2004-05-15 Owen Fraser-Green <owen@discobabe.net>
1746 * mono/dbus-sharp.dll.config.in: Added for GAC
1747 * mono/dbus-sharp.snk: Added for GAC
1748 * mono/Assembly.cs.in: Added for GAC
1749 * mono/Makefile.am: Changes for GAC installation
1750 * configure.in: Added refs for dbus-sharp.dll.config.in and
1751 Assembly.cs.in. More fixes for mono testing
1752 * mono/example/Makefile.am: Changed var to CSC
1753 * Makefile.am: Changed flag name to DBUS_USE_CSC
1755 2004-05-15 Owen Fraser-Green <owen@discobabe.net>
1757 * mono/Makefile.am: Added SUBDIRS for docs. Changed SUBDIRS order
1758 * mono/doc/*: Added documentation framework
1759 * configure.in: Added monodoc check
1760 * README: Added description of mono configure flags
1762 2004-05-11 John (J5) Palmieri <johnp@redhat.com>:
1764 * doc/dbus-specification.xml: Added a "Required" column to the
1765 header fields table and changed the "zero or more" verbage in
1766 the above paragraph to read "The header must contain the required
1767 named header fields and zero or more of the optional named header
1769 * test/data/invalid-messages/*.message: Added the required PATH
1770 named header field to the tests so that they don't fail on
1771 'Missing path field'
1773 2004-05-07 John (J5) Palmieri <johnp@redhat.com>
1775 * python/dbus-bindings.pyx.in: Stopped the bindings from trashing
1776 the stack by implicitly defining variable and parameter types and
1777 removing the hack of defining C pointers as python objects and later
1780 2004-05-02 Owen Fraser-Green <owen@discobabe.net>
1782 * mono/Makefile.am: Removed test-dbus-sharp.exe from all target
1784 2004-05-01 Owen Fraser-Green <owen@discobabe.net>
1786 * mono/DBusType/Dict.cs: Handle empty dicts
1787 * mono/DBusType/Array.cs: Handle empty arrays
1788 * mono/Arguments.cs: Handle empty arguments
1790 2004-04-30 Owen Fraser-Green <owen@discobabe.net>
1792 * dbus-sharp.pc.in: Modified to include include Libs and Requires
1795 2004-04-25 Kristian Høgsberg <krh@redhat.com>
1797 * test/data/valid-messages/standard-*.message: Update message
1798 test scripts to new header field names.
1800 2004-04-22 John (J5) Palmieri <johnp@redhat.com>
1802 * test/break-loader.c (randomly_do_n_things): tracked down buffer
1803 overflow to times_we_did_each_thing array which would chop off the
1804 first character of the failure_dir string. Increased the size of
1805 the array to 7 to reflect the number of random mutation functions
1808 2004-04-21 Kristian Høgsberg <krh@redhat.com>
1810 * dbus/dbus-server-unix.c (unix_finalize): Don't unref
1811 unix_server->watch here, it is unreffed in disconnect.
1812 (_dbus_server_new_for_tcp_socket): convert NULL host to
1813 "localhost" here so we don't append NULL to address.
1815 * dbus/dbus-server.c (_dbus_server_test): Add test case for
1816 various addresses, including tcp with no explicit host.
1818 2004-04-21 Olivier Andrieu <oliv__a@users.sourceforge.net>
1820 * dbus/dbus-message.c (decode_header_data, decode_string_field):
1821 fix incorrect setting of .name_offset in the HeaderField (it was
1822 off by two bytes, positioned right after the name and typecode)
1824 * bus/bus.c (bus_context_new, bus_context_unref): test before
1825 calling dbus_server_free_data_slot and _dbus_user_database_unref
1826 in case of an error.
1828 * tools/Makefile.am: add $(DBUS_GLIB_TOOL_LIBS), xml libs needed
1831 2004-04-19 Kristian Høgsberg <krh@redhat.com>
1833 * dbus/dbus-transport-unix.c (unix_do_iteration): Rewrite to use
1834 _dbus_poll() instead of select().
1836 2004-04-15 Jon Trowbridge <trow@ximian.com>
1838 * bus/main.c (signal_handler): Reload the configuration files
1840 (main): Set up our SIGHUP handler.
1842 * bus/bus.c (struct BusContext): Store the config file, user and
1843 fork flag in the BusContext.
1844 (process_config_first_time_only): Added. Contains the code
1845 (previously in bus_context_new) for setting up the BusContext from
1846 the BusConfigParser that should only be run the first time the
1847 config files are read.
1848 (process_config_every_time): Added. Contains the code (previously
1849 in bus_context_new) for setting up the BusContext from the
1850 BusConfigParser that should be run every time the config files are
1852 (load_config): Added. Builds a BusConfigParser from the config
1853 files and passes the resulting structure off to
1854 process_config_first_time_only (assuming this is the first time)
1855 and process_config_every_time.
1856 (bus_context_new): All of the config-related code has been moved
1857 to process_config_first_time_only and process_config_every_time.
1858 Now this function just does the non-config-related initializations
1859 and calls load_config.
1860 (bus_context_reload_config): Added.
1862 2004-04-15 Olivier Andrieu <oliv__a@users.sourceforge.net>
1864 * bus/driver.c (bus_driver_handle_get_service_owner):
1865 implement a GetServiceOwner method.
1866 * doc/dbus-specification.xml: document it.
1867 * dbus/dbus-errors.h: add a 'ServiceHasNoOwner' error.
1869 * glib/dbus-gproxy.c (dbus_gproxy_new_for_service_owner):
1870 implement, using the bus GetServiceOwner method.
1872 * test/glib/test-dbus-glib.c:
1873 use dbus_gproxy_new_for_service_owner so that we can receive the
1876 2004-04-15 John (J5) Palmieri <johnp@redhat.com>
1878 * dbus/dbus-internals.c, dbus/dbus-message-builder.c,
1879 dbus/dbus-message.c, dbus/dbus-protocol.h
1880 (DBUS_HEADER_FIELD_SERVICE): renamed DBUS_HEADER_FIELD_DESTINATION
1882 * dbus/dbus-internals.c, dbus/dbus-message-builder.c,
1883 dbus/dbus-message.c, dbus/dbus-protocol.h
1884 (DBUS_HEADER_FIELD_SENDER_SERVICE): renamed DBUS_HEADER_FIELD_SENDER
1886 * dbus/dbus-internals.c (_dbus_header_field_to_string):
1887 DBUS_HEADER_FIELD_DESTINATION resolves to "destination"
1888 DBUS_HEADER_FIELD_SENDER resolves to "sender"
1890 * doc/dbus-specification.xml (Header Fields Table):
1891 s/SERVICE/DESTINATION
1892 s/SENDER_SERVICE/SENDER
1895 2004-04-14 Olivier Andrieu <oliv__a@users.sourceforge.net>
1897 * test/glib/test-dbus-glib.c (timed_exit): fail the test after
1900 2004-04-13 Michael Meeks <michael@ximian.com>
1902 * glib/dbus-gobject.c (handle_introspect): split out
1903 (introspect_properties): this.
1904 (handle_introspect): implement this.
1906 * test/glib/Makefile.am: use the absolute path so the bus
1907 daemon's chdir ("/") doesn't kill us dead.
1909 * configure.in: subst ABSOLUTE_TOP_BUILDDIR
1911 2004-04-12 Jon Trowbridge <trow@ximian.com>
1913 * bus/config-parser.c (struct BusConfigParser): Added
1914 included_files field.
1915 (seen_include): Added. Checks whether or not a file has already
1916 been included by any parent BusConfigParser.
1917 (bus_config_parser_new): Copy the parent's included_files.
1918 (include_file): Track which files have been included, and fail on
1919 circular inclusions.
1920 (process_test_valid_subdir): Changed printf to report if we are
1921 testing valid or invalid conf files.
1922 (all_are_equiv): Changed printf to be a bit clearer about
1923 what we are actually doing.
1924 (bus_config_parser_test): Test invalid configuration files.
1926 2004-04-09 Jon Trowbridge <trow@ximian.com>
1928 * bus/config-parser.c (bus_config_parser_new): Added a 'parent'
1929 argument. If non-null, the newly-constructed BusConfigParser will
1930 be initialized with the parent's BusLimits instead of the default
1932 (include_file): When including a config file, pass in
1933 the current parser as the parent and then copy the BusLimits
1934 from the included BusConfigParser pack to the current parser.
1935 (process_test_valid_subdir): Renamed from process_test_subdir.
1936 (process_test_equiv_subdir): Added. Walks through a directory,
1937 descending into each subdirectory and loading the config files
1938 it finds there. If any subdirectory contains two config files
1939 that don't produce identical BusConfigParser structs, fail.
1940 For now, the BusConfigParser's BusPolicies are not compared.
1941 (bus_config_parser_test): Call both process_test_valid_subdir and
1942 process_test_equiv_subdir.
1944 * bus/config-loader-libxml.c (bus_config_load): Take a parent
1945 argument and pass it along to the call to bus_config_parser_new.
1946 Also made a few small changes to allow this code to compile.
1948 * bus/config-loader-expat.c (bus_config_load): Take a parent
1949 argument and pass it along to the call to bus_config_parser_new.
1951 * bus/bus.c (bus_context_new): Load the config file
1952 with a NULL parent argument.
1954 2004-03-29 Michael Meeks <michael@ximian.com>
1956 * glib/dbus-gobject.c (introspect_properties): split
1957 out, fix mangled 'while' flow control.
1958 (introspect_signals): implement.
1959 (handle_introspect): update.
1961 2004-03-29 Michael Meeks <michael@ximian.com>
1963 * glib/dbus-gobject.c (set_object_property): split out /
1964 re-work, use the property type, and not the message type(!)
1965 (get_object_property): ditto.
1967 * glib/dbus-gvalue.c (dbus_gvalue_demarshal),
1968 (dbus_gvalue_marshal): make this code re-usable, needed
1969 for signals too, also on both proxy and server side.
1970 Re-write for more efficiency / readability.
1972 2004-03-29 Michael Meeks <michael@ximian.com>
1974 * dbus/dbus-message.c
1975 (dbus_message_new_error_printf): impl.
1977 * dbus/dbus-connection.c
1978 (dbus_connection_unregister_object_path): fix warning.
1980 * configure.in: fix no-mono-installed situation.
1982 2004-03-27 Havoc Pennington <hp@redhat.com>
1984 Patch from Timo Teräs:
1986 * tools/dbus-send.c (main): if --print-reply, assume type is
1987 method call; support boolean type args
1989 * dbus/dbus-connection.c (dbus_connection_send_with_reply): fix a
1990 bunch of memleak and logic bugs
1992 2004-03-23 Owen Fraser-Green <owen@discobabe.net>
1994 * mono/Arguments.cs:
1995 * mono/Introspector.cs:
1997 * mono/InterfaceProxy.cs:
1999 * mono/ProxyBuilder.cs:
2001 Added InterfaceProxy class to avoid building proxies for every
2005 * dbus-message.c (dbus_message_append_args_valist)
2006 (dbus_message_iter_get_object_path)
2007 (dbus_message_iter_get_object_path_array)
2008 (dbus_message_iter_append_object_path)
2009 (dbus_message_iter_append_object_path_array):
2010 Added object_path iter functions to handle OBJECT_PATH arguments
2012 2004-03-23 Owen Fraser-Green <owen@discobabe.net>
2014 First checkin of mono bindings.
2017 Build stuff for the bindings
2018 * dbus-sharp.pc.in: Added for pkgconfig
2020 2004-03-21 Havoc Pennington <hp@redhat.com>
2022 * test/test-service.c (main): remove debug spew
2024 2004-03-21 Olivier Andrieu <oliv__a@users.sourceforge.net>
2026 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): accept empty
2029 * dbus/dbus-message.h, bus/dbus-message.c (dbus_message_iter_init)
2030 (dbus_message_iter_init_array_iterator)
2031 (dbus_message_iter_init_dict_iterator): return a dbus_bool_t to
2032 indicate whether the iterator is empty
2034 * dbus/dbus-pending-call.c, dbus/dbus-server.c: silence compiler
2037 2004-03-19 Havoc Pennington <hp@redhat.com>
2039 * NEWS: 0.21 updates
2041 * configure.in: 0.21
2043 * doc/Makefile.am: add all XMLTO usage to DBUS_XML_DOCS_ENABLED
2045 * python/Makefile.am: change to avoid dist of dbus_bindings.c so
2046 you don't need pyrex to make dist
2048 * qt/Makefile.am (libdbus_qt_1_la_SOURCES): add integrator.h to
2051 2004-03-18 Richard Hult <richard@imendio.com>
2053 * dbus/dbus-message.c (dbus_message_get_auto_activation)
2054 (dbus_message_set_auto_activation): Add doxygen docs.
2056 2004-03-16 Richard Hult <richard@imendio.com>
2058 * bus/activation.c: (bus_activation_service_created),
2059 (bus_activation_send_pending_auto_activation_messages),
2060 (bus_activation_activate_service):
2062 * bus/dispatch.c: (bus_dispatch),
2063 (check_nonexistent_service_auto_activation),
2064 (check_service_auto_activated),
2065 (check_segfault_service_auto_activation),
2066 (check_existent_service_auto_activation), (bus_dispatch_test):
2067 * bus/driver.c: (bus_driver_handle_activate_service):
2068 * bus/services.c: (bus_registry_acquire_service):
2069 * dbus/dbus-message.c: (dbus_message_set_auto_activation),
2070 (dbus_message_get_auto_activation):
2071 * dbus/dbus-message.h:
2072 * dbus/dbus-protocol.h: Implement auto-activation.
2074 * doc/dbus-specification.xml: Add auto-activation to the spec.
2076 2004-03-12 Olivier Andrieu <oliv__a@users.sourceforge.net>
2078 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos):
2079 fix a bug with CUSTOM types.
2081 * dbus/dbus-message.c (message_iter_test, _dbus_message_test): add
2082 a unit test for this bug (used to fail).
2084 2004-03-12 Mikael Hallendal <micke@imendio.com>
2087 (babysitter_watch_callback): notify all pending activations waiting for
2088 the same exec that the activation failed.
2089 (bus_activation_activate_service): shortcut the activation if we
2090 already waiting for the same executable to start up.
2092 2004-03-12 Mikael Hallendal <micke@imendio.com>
2095 - Added service file reloading.
2096 Each service files directory is kept in an hash table in
2097 BusActivation and each BusActivationEntry knows what .service-file it
2098 was read from. So when you try to activate a service the bus will
2099 check if it's been updated, removed or if new .service-files has
2101 - Test code at the bottom for the service file reloading.
2102 * bus/test-main.c: (main):
2104 - added service reloading test.
2105 * dbus/dbus-sysdeps.c:
2106 * dbus/dbus-sysdeps.h: (_dbus_delete_directory): Added.
2108 2004-03-08 Michael Meeks <michael@ximian.com>
2110 * dbus/dbus-connection.c (_dbus_connection_block_for_reply):
2111 bail immediately if disconnected, to avoid busy loop.
2113 * dbus/dbus-message.c (dbus_message_iter_get_args_valist):
2114 cleanup cut/paste/inefficiency.
2116 2004-03-01 David Zeuthen <david@fubar.dk>
2118 * dbus/dbus-string.c (_dbus_string_append_printf_valist): Fix a
2119 bug where args were used twice. This bug resulted in a segfault
2120 on a Debian/PPC system when starting the messagebus daemon. Include
2121 dbus-sysdeps.h for DBUS_VA_COPY
2123 * dbus/dbus-sysdeps.h: Define DBUS_VA_COPY if neccessary. From GLib
2125 * configure.in: Check for va_copy; define DBUS_VA_COPY to the
2126 appropriate va_copy implementation. From GLib
2128 2004-02-24 Joe Shaw <joe@ximian.com>
2130 * bus/services.c (bus_registry_acquire_service): We need to pass
2131 in the service name to dbus_set_error() to prevent a crash.
2133 2003-12-26 Anders Carlsson <andersca@gnome.org>
2135 * AUTHORS: Reveal my True identity.
2137 2003-12-17 Mikael Hallendal <micke@imendio.com>
2139 * dbus/dbus-message.c: (dbus_message_append_args_valist):
2140 - Added case for DBUS_TYPE_BYTE, patch from Johan Hedberg.
2142 2003-12-13 Mikael Hallendal <micke@imendio.com>
2144 * doc/TODO: Added not about better error check of configuration files.
2146 2003-12-02 Richard Hult <richard@imendio.com>
2148 * Update AFL version to 2.0 throughout the source files to reflect
2149 the update that was done a while ago.
2151 2003-12-02 Richard Hult <richard@imendio.com>
2153 * dbus/dbus-message.c (dbus_message_iter_append_dict): Set
2154 wrote_dict_key to FALSE on the iter that the dict is appended to,
2155 just like when appending other types. Fixes a bug where a dict
2156 couldn't be put inside a dict.
2157 (dbus_message_iter_append_dict_key): Fix typo in warning message.
2158 (message_iter_test, _dbus_message_test): Add test case for dict
2161 2003-12-01 David Zeuthen <david@fubar.dk>
2163 * python/dbus.py: Add the actual message when calling the reciever
2164 of a signal such that parameters can be inspected. Add the method
2165 remove_signal_receiver
2167 2003-11-26 Mikael Hallendal <micke@imendio.com>
2171 * glib/*.[ch]: Made ref functions return the pointer
2173 2003-11-25 Zack Rusin <zack@kde.org>
2175 * qt/integrator.h, qt/integrator.cpp: Adding handling of DBusServer,
2177 * qt/server.h, qt/server.cpp, qt/Makefile.am: Adding DBusServer
2180 * qt/connection.h, qt/connection.cpp: Adjusting to changes in
2181 the Integrator and to better fit with the server,
2183 2003-11-24 Zack Rusin <zack@kde.org>
2185 * qt/connection.h, qt/connection.cpp: removing initDbus method since
2186 the integrator handles it now
2188 * qt/integrator.h, qt/integrator.cpp: reworking handling of timeouts,
2189 since QTimer wasn't really meant to be used the way DBusTimeout is
2191 2003-11-24 Zack Rusin <zack@kde.org>
2193 * qt/integrator.h, qt/integrator.cpp, Makefile.am: Adding
2194 Integrator class which integrates D-BUS with the Qt event loop,
2196 * qt/connection.h, qt/connection.cpp: Move all the code which
2197 was dealing with D-BUS integration to the Integrator class,
2198 and start using Integrator,
2200 2003-11-23 Zack Rusin <zack@kde.org>
2202 * qt/connection.h, qt/connection.cpp: Adding the DBusConnection
2205 * qt/message.h, qt/message.cpp: updating to the current D-BUS api,
2206 switching namespaces to DBusQt, reworking the class,
2208 * Makefile.cvs: switching dependencies so that it matches KDE
2211 * qt/Makefile.am: adding connection.{h,cpp} and message.{h,cpp} to
2214 2003-11-19 Havoc Pennington <hp@redhat.com>
2218 * configure.in: bump version to 0.20
2220 * configure.in (have_qt): add yet another place to look for qt
2221 (someone hand trolltech a .pc file...)
2223 2003-11-01 Havoc Pennington <hp@redhat.com>
2225 * doc/dbus-specification.xml: add state machine docs on the auth
2226 protocol; just a first draft, I'm sure it's wrong.
2228 2003-10-28 David Zeuthen <david@fubar.dk>
2230 * python/dbus_bindings.pyx.in: add get_dict to handle dictionaries
2231 return types. Fixup TYPE_* to reflect changes in dbus/dbus-protocol.h
2233 2003-10-28 Havoc Pennington <hp@redhat.com>
2235 * dbus/dbus-message.c (get_next_field): delete unused function
2237 2003-10-28 Havoc Pennington <hp@redhat.com>
2239 * bus/expirelist.c (do_expiration_with_current_time): detect
2240 failure of the expire_func due to OOM
2242 * bus/connection.c (bus_pending_reply_expired): return FALSE on OOM
2244 * bus/dispatch.c (check_send_exit_to_service): fix to handle the
2245 NoReply error that's now created by the bus when the service exits
2247 2003-10-28 Havoc Pennington <hp@redhat.com>
2249 * dbus/dbus-message.c (_dbus_message_test): enable and fix the
2250 tests for set_path, set_interface, set_member, etc.
2252 * dbus/dbus-string.c (_dbus_string_insert_bytes): allow 0 bytes
2254 * dbus/dbus-message.c (set_string_field): always just delete and
2255 re-append the field; accept NULL for deletion
2256 (re_align_fields_recurse): reimplement
2258 2003-10-26 Havoc Pennington <hp@redhat.com>
2260 * dbus/dbus-connection.c: fix docs to properly describe the
2261 disconnected message
2262 (_dbus_connection_notify_disconnected): remove this function;
2263 we can't synchronously add the disconnected message, we have to
2264 do it after we've queued any remaining real messages
2265 (_dbus_connection_get_dispatch_status_unlocked): queue the
2266 disconnect message only if the transport has finished queueing all
2267 its real messages and is disconnected.
2268 (dbus_connection_disconnect): update the dispatch status here
2270 2003-10-22 Havoc Pennington <hp@redhat.com>
2272 * bus/bus.c (bus_context_check_security_policy): fix up assertion
2274 * bus/connection.c (bus_transaction_send_from_driver): set the
2275 destination to the connection's base service
2277 2003-10-20 Havoc Pennington <hp@redhat.com>
2279 hmm, make check is currently not passing.
2281 * doc/dbus-specification.xml: add requirement that custom type
2282 names follow the same rules as interface names.
2284 * dbus/dbus-protocol.h: change some of the byte codes, to avoid
2285 duplication and allow 'c' to be 'custom'; dict is now 'm' for
2288 * doc/dbus-specification.xml: update type codes to match
2289 dbus-protocol.h, using the ASCII byte values. Rename type NAMED to
2290 CUSTOM. Add type OBJECT_PATH to the spec.
2292 2003-10-17 Havoc Pennington <hp@redhat.com>
2294 * bus/driver.c (create_unique_client_name): use "." as separator
2295 in base service names instead of '-'
2297 * dbus/dbus-string.c (_dbus_string_get_byte): allow getting nul
2298 byte at the end of the string
2300 * dbus/dbus-internals.h (_DBUS_LIKELY, _DBUS_UNLIKELY): add
2301 optimization macros since string validation seems to be a slow
2304 * doc/dbus-specification.xml: restrict valid
2305 service/interface/member/error names. Add test suite code for the
2308 * dbus/dbus-string.c: limit service/interface/member/error names
2311 * dbus/dbus-connection.c (dbus_connection_dispatch): add missing
2312 format arg to verbose spew
2314 * glib/dbus-gproxy.c (dbus_gproxy_call_no_reply): if not out of
2315 memory, return instead of g_error
2317 * test/test-service.c (path_message_func): support emitting a
2320 * dbus/dbus-bus.c (init_connections_unlocked): only fill in
2321 activation bus type if DBUS_BUS_ACTIVATION was set; default to
2322 assuming the activation bus was the session bus so that services
2323 started manually will still register.
2324 (init_connections_unlocked): fix so that in OOM situation we get
2325 the same semantics when retrying the function
2327 * test/test-service.c (main): change to use path registration, to
2328 test those codepaths; register with DBUS_BUS_ACTIVATION rather
2329 than DBUS_BUS_SESSION
2331 2003-10-16 Havoc Pennington <hp@redhat.com>
2333 * glib/dbus-gtest-main.c: bracket with #ifdef DBUS_BUILD_TESTS
2335 * Makefile.am (GCOV_DIRS): remove "test", we don't care about test
2336 coverage of the tests
2337 (coverage-report.txt): don't move the .da and .bbg files around
2339 2003-10-16 Havoc Pennington <hp@redhat.com>
2341 * bus/bus.c (struct BusContext): remove struct field I didn't mean
2344 2003-10-16 Havoc Pennington <hp@redhat.com>
2346 * bus/connection.c (bus_pending_reply_expired): either cancel or
2348 (bus_connections_check_reply): use unlink, not remove_link, as we
2349 don't want to free the link; fixes double free mess
2351 * dbus/dbus-pending-call.c (dbus_pending_call_block): fix in case
2352 where no reply was received
2354 * dbus/dbus-connection.c (_dbus_pending_call_complete_and_unlock):
2357 * bus/signals.c (match_rule_matches): add special cases for the
2358 bus driver, so you can match on sender/destination for it.
2360 * dbus/dbus-sysdeps.c (_dbus_abort): print backtrace if
2361 DBUS_PRINT_BACKTRACE is set
2363 * dbus/dbus-internals.c: add pid to assertion failure messages
2365 * dbus/dbus-connection.c: add message type code to the debug spew
2367 * glib/dbus-gproxy.c (gproxy_get_match_rule): match rules want
2368 sender=foo not service=foo
2370 * dbus/dbus-bus.c (dbus_bus_get): if the activation bus is the
2371 session bus but DBUS_SESSION_BUS_ADDRESS isn't set, use
2372 DBUS_ACTIVATION_ADDRESS instead
2374 * bus/activation.c: set DBUS_SESSION_BUS_ADDRESS,
2375 DBUS_SYSTEM_BUS_ADDRESS if appropriate
2377 * bus/bus.c (bus_context_new): handle OOM copying bus type into
2380 * dbus/dbus-message.c (dbus_message_iter_get_object_path): new function
2381 (dbus_message_iter_get_object_path_array): new function (half
2382 finished, disabled for the moment)
2384 * glib/dbus-gproxy.c (dbus_gproxy_end_call): properly handle
2385 DBUS_MESSAGE_TYPE_ERROR
2387 * tools/dbus-launch.c (babysit): support DBUS_DEBUG_OUTPUT to
2388 avoid redirecting stderr to /dev/null
2389 (babysit): close stdin if not doing the "exit_with_session" thing
2391 * dbus/dbus-sysdeps.c (_dbus_become_daemon): delete some leftover
2392 debug code; change DBUS_DEBUG_OUTPUT to only enable stderr, not
2393 stdout/stdin, so things don't get confused
2395 * bus/system.conf.in: fix to allow replies, I modified .conf
2396 instead of .conf.in again.
2398 2003-10-14 David Zeuthen <david@fubar.dk>
2400 * python/dbus_bindings.pyx.in (MessageIter.get): fixed typo in
2401 argtype to arg_type when raising unknown arg type exception.
2402 Changed type list to reflect the changes in dbus-protocol.h so
2403 the bindings actually work.
2405 2003-10-14 Havoc Pennington <hp@redhat.com>
2407 * test/decode-gcov.c: support gcc 3.3 also, though gcc 3.3 seems
2408 to have a bug keeping it from outputting the .da files sometimes
2409 (string_get_string): don't append garbage nul bytes to the string.
2411 2003-10-15 Seth Nickell <seth@gnome.org>
2413 * python/Makefile.am:
2415 Include dbus_h_wrapper.h in the dist tarball.
2417 2003-10-14 Havoc Pennington <hp@redhat.com>
2419 * bus/bus.c (bus_context_check_security_policy): revamp this to
2420 work more sanely with new policy-based requested reply setup
2422 * bus/connection.c (bus_transaction_send_from_driver): set bus
2423 driver messages as no reply
2425 * bus/policy.c (bus_client_policy_check_can_receive): handle a
2426 requested_reply attribute on allow/deny rules
2428 * bus/system.conf: add <allow requested_reply="true"/>
2430 * bus/driver.c (bus_driver_handle_message): fix check for replies
2431 sent to the bus driver, which was backward. How did this ever work
2432 at all though? I think I'm missing something.
2434 * dbus/dbus-message.c (decode_header_data): require error and
2435 method return messages to have a reply serial field to be valid
2436 (_dbus_message_loader_queue_messages): break up this function;
2437 validate that reply serial and plain serial are nonzero;
2438 clean up the OOM/error handling.
2439 (get_uint_field): don't return -1 from this
2440 (dbus_message_create_header): fix signed/unsigned bug
2442 * bus/connection.c (bus_connections_expect_reply): save serial of
2443 the incoming message, not reply serial
2445 2003-10-14 Havoc Pennington <hp@redhat.com>
2447 * bus/connection.c: implement pending reply tracking using
2450 * bus/bus.c (bus_context_check_security_policy): verify that a
2451 reply is pending in order to allow a reply to be sent. Deny
2452 messages of unknown type.
2454 * bus/dbus-daemon-1.1.in: update to mention new resource limits
2456 * bus/bus.c (bus_context_get_max_replies_per_connection): new
2457 (bus_context_get_reply_timeout): new
2459 2003-10-13 Seth Nickell <seth@gnome.org>
2461 * python/Makefile.am:
2463 Pass "make distcheck": remove a couple files from DIST_FILES
2464 that weren't included in the final version.
2466 2003-10-12 Havoc Pennington <hp@pobox.com>
2468 Added test code that 1) starts an actual bus daemon and 2) uses
2469 DBusGProxy; fixed bugs that were revealed by the test. Lots
2470 more testing possible, but this is the basic framework.
2472 * glib/dbus-gproxy.c (dbus_gproxy_manager_unregister): remove
2473 empty proxy lists from the proxy list hash
2475 * dbus/dbus-message.c (dbus_message_iter_get_args_valist): add a
2476 couple of return_if_fail checks
2478 * dbus/dbus-pending-call.c (_dbus_pending_call_new): use dbus_new0
2479 to allocate, so everything is cleared to NULL as it should be.
2481 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): pass
2482 source as data to dbus_connection_set_timeout_functions() as the
2483 timeout functions expected
2485 * test/glib/run-test.sh: add a little script to start up a message
2486 bus and run tests using it
2488 * tools/dbus-launch.1: updates
2490 * tools/dbus-launch.c (main): add --config-file option
2492 * tools/dbus-launch.c (main): remove confusing else if (runprog)
2493 that could never be reached.
2495 * dbus/dbus-message.c (dbus_message_new_method_return)
2496 (dbus_message_new_error, dbus_message_new_signal): set the
2497 no-reply-expected flag on all these. Redundant, but may
2498 as well be consistent.
2500 2003-10-11 Havoc Pennington <hp@pobox.com>
2502 * test/decode-gcov.c (function_solve_graph): make broken block
2503 graph a nonfatal error since it seems to be broken. Need to debug
2506 * dbus/dbus-marshal.c (_dbus_type_is_valid): new function since we
2507 can't just check type > INVALID < LAST anymore
2509 * dbus/dbus-message.c (dbus_message_get_signature): new function
2510 (dbus_message_has_signature): new function
2511 (struct DBusMessage): add signature field (right now it isn't sent
2512 over the wire, just generated on the fly)
2513 (dbus_message_copy): copy the signature, and init strings to
2514 proper length to avoid some reallocs
2515 (dbus_message_iter_init_array_iterator): return void, since it
2517 (dbus_message_iter_init_dict_iterator): return void since it can't fail
2518 (_dbus_message_loader_queue_messages): add silly temporary hack to
2519 fill in message->signature on load
2521 * dbus/dbus-protocol.h: change DBUS_TYPE_* values to be ASCII
2522 characters, so they are relatively human-readable.
2524 2003-10-11 Havoc Pennington <hp@pobox.com>
2526 * dbus/dbus-message.c (_dbus_message_test): add more test
2527 coverage, but #if 0 for now since they uncover a bug
2528 not fixed yet; I think in re_align_field_recurse()
2529 (re_align_field_recurse): add FIXME about broken assertion
2531 * dbus/dbus-sysdeps.c (_dbus_sysdeps_test): add more test coverage
2533 * bus/connection.c: share a couple code bits with expirelist.c
2535 * bus/expirelist.h, bus/expirelist.c: implement a generic
2536 expire-items-after-N-seconds facility, was going to share between
2537 expiring connections and replies, decided not to use for expiring
2538 connections for now.
2540 * COPYING: include AFL 2.0 (still need to change all the file headers)
2542 2003-10-09 Havoc Pennington <hp@redhat.com>
2544 * configure.in: define DBUS_HAVE_GCC33_GCOV if we have
2545 gcc 3.3. Not that we do anything about it yet.
2547 * bus/signals.c (bus_match_rule_parse): impose max length on the
2550 * dbus/dbus-protocol.h: add DBUS_MAXIMUM_MATCH_RULE_LENGTH
2552 2003-10-09 Havoc Pennington <hp@redhat.com>
2554 Make matching rules theoretically work (add parser).
2556 * bus/bus.c (bus_context_check_security_policy): fix up to handle
2557 the case where destination is explicitly specified as bus driver
2558 and someone else is eavesdropping.
2560 * bus/policy.c (bus_client_policy_check_can_receive): fix up
2561 definition of eavesdropping and assertion
2563 * tools/dbus-send.c (main): use dbus_message_type_from_string
2565 * bus/signals.c (bus_match_rule_parse): implement
2567 * dbus/dbus-message.c (dbus_message_type_from_string): new
2569 * dbus/dbus-errors.h (DBUS_ERROR_MATCH_RULE_INVALID): add
2571 2003-10-02 Havoc Pennington <hp@pobox.com>
2573 * glib/dbus-gproxy.c (dbus_gproxy_call_no_reply): rename from
2574 dbus_gproxy_oneway_call
2576 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main)
2577 (dbus_server_setup_with_g_main): fix to allow calling them more
2578 than once on the same args
2579 (dbus_bus_get_with_g_main): new function
2581 2003-10-02 Havoc Pennington <hp@redhat.com>
2583 * doc/dbus-tutorial.xml: write some stuff
2585 2003-09-29 Havoc Pennington <hp@pobox.com>
2587 * configure.in: split checks for Doxygen from XML docs, check for
2590 * doc/Makefile.am: XML-ify all the docs, and add a blank
2593 2003-09-29 Havoc Pennington <hp@pobox.com>
2595 * Merge dbus-object-names branch. To see the entire patch
2596 do cvs diff -r DBUS_OBJECT_NAMES_BRANCHPOINT -r dbus-object-names,
2597 it's huuuuge though.
2598 To revert, I tagged DBUS_BEFORE_OBJECT_NAMES_MERGE.
2600 2003-09-28 Havoc Pennington <hp@pobox.com>
2602 * HACKING: update to reflect new server
2604 2003-09-26 Seth Nickell <seth@gnome.org>
2607 * python/examples/example-signals.py:
2609 Start implementing some notions of signals. The API
2610 is really terrible, but they sort of work (with the
2611 exception of being able to filter by service, and to
2612 transmit signals *as* a particular service). Need to
2613 figure out how to make messages come from the service
2616 * python/dbus_bindings.pyx.in:
2618 Removed duplicate message_handler callbacks.
2620 2003-09-25 Havoc Pennington <hp@redhat.com>
2622 * bus/session.conf.in: fix my mess
2624 2003-09-25 Havoc Pennington <hp@pobox.com>
2626 * bus/session.conf.in: fix security policy, reported by Seth Nickell
2628 2003-09-25 Seth Nickell <seth@gnome.org>
2630 * python/examples/example-service.py:
2632 Johan notices complete wrong code in example-service, but
2633 completely wrong in a way that works exactly the same (!).
2634 Johan is confused, how could this possibly work? Example
2635 code fails to serve purpose of making things clear.
2638 2003-09-25 Mark McLoughlin <mark@skynet.ie>
2640 * doc/dbus-specification.sgml: don't require header fields
2641 to be 4-byte aligned and specify that fields should be
2642 distinguished from padding by the fact that zero is not
2645 * doc/TODO: remove re-alignment item and add item to doc
2646 the OBJECT_PATH type.
2648 * dbus/dbus-message.c:
2649 (HeaderField): rename the original member to value_offset
2650 and introduce a name_offset member to keep track of where
2651 the field actually begins.
2652 (adjust_field_offsets): remove.
2653 (append_int_field), (append_uint_field),
2654 (append_string_field): don't align the start of the header
2655 field to a 4-byte boundary.
2656 (get_next_field): impl finding the next marhsalled field
2657 after a given field.
2658 (re_align_field_recurse): impl re-aligning a number of
2659 already marshalled fields.
2660 (delete_field): impl deleting a field of any type and
2661 re-aligning any following fields.
2662 (delete_int_or_uint_field), (delete_string_field): remove.
2663 (set_int_field), (set_uint_field): no need to re-check
2664 that we have the correct type for the field.
2665 (set_string_field): ditto and impl re-aligning any
2667 (decode_header_data): update to take into account that
2668 the fields aren't 4-byte aligned any more and the new
2669 way to distinguish padding from header fields. Also,
2670 don't exit when there is too much header padding.
2671 (process_test_subdir): print the directory.
2672 (_dbus_message_test): add test to make sure a following
2673 field is re-aligned correctly after field deletion.
2675 * dbus/dbus-string.[ch]:
2676 (_dbus_string_insert_bytes): rename from insert_byte and
2677 allow the insert of multiple bytes.
2678 (_dbus_string_test): test inserting multiple bytes.
2680 * dbus/dbus-marshal.c: (_dbus_marshal_set_string): add
2681 warning note to docs about having to re-align any
2682 marshalled values following the string.
2684 * dbus/dbus-message-builder.c:
2685 (append_string_field), (_dbus_message_data_load):
2686 don't align the header field.
2688 * dbus/dbus-auth.c: (process_test_subdir): print the
2691 * test/break-loader.c: (randomly_add_one_byte): upd. for
2694 * test/data/invalid-messages/bad-header-field-alignment.message:
2697 * test/data/valid-messages/unknown-header-field.message: shove
2698 a dict in the unknown field.
2700 2003-09-25 Seth Nickell <seth@gnome.org>
2703 * python/dbus_bindings.pyx.in:
2705 Handle return values.
2707 * python/examples/example-client.py:
2708 * python/examples/example-service.py:
2710 Pass back return values from the service to the client.
2712 2003-09-24 Seth Nickell <seth@gnome.org>
2716 Connect Object methods (when you are sharing an object) up... pass
2717 in a list of methods to be shared. Sharing all the methods just
2718 worked out too weird. You can now create nice Services over the
2721 * python/dbus_bindings.pyx.in:
2723 Keep references to user_data tuples passed into C functions so
2724 Python doesn't garbage collect on us.
2726 Implement MethodReturn and Error subclasses of Message for creating
2727 DBusMessage's of those types.
2729 * python/examples/example-client.py:
2730 * python/examples/example-service.py:
2732 Simple example code showing both how create DBus services and objects,
2733 and how to use them.
2735 2003-09-23 Havoc Pennington <hp@pobox.com>
2737 * glib/dbus-gproxy.c (dbus_gproxy_manager_filter): implement
2739 2003-09-23 Havoc Pennington <hp@redhat.com>
2741 * glib/dbus-gproxy.c (dbus_gproxy_connect_signal): implement
2742 (dbus_gproxy_disconnect_signal): implement
2743 (dbus_gproxy_manager_remove_signal_match): implement
2744 (dbus_gproxy_manager_add_signal_match): implement
2745 (dbus_gproxy_oneway_call): implement
2747 2003-09-23 Havoc Pennington <hp@pobox.com>
2749 * glib/dbus-gproxy.c (struct DBusGProxy): convert to a GObject
2750 subclass. This means dropping the transparent thread safety of the
2751 proxy; you now need a separate proxy per-thread, or your own
2752 locking on the proxy. Probably right anyway.
2753 (dbus_gproxy_ref, dbus_gproxy_unref): nuke, just use g_object_ref
2755 2003-09-22 Havoc Pennington <hp@redhat.com>
2757 * glib/dbus-gproxy.c (dbus_gproxy_manager_get): implement
2759 2003-09-21 Seth Nickell <seth@gnome.org>
2761 First checkin of the Python bindings.
2763 * python/.cvsignore:
2764 * python/Makefile.am:
2765 * python/dbus_bindings.pyx.in:
2766 * python/dbus_h_wrapper.h:
2768 Pieces for Pyrex to operate on, building a dbus_bindings.so
2769 python module for low-level access to the DBus APIs.
2773 High-level Python module for accessing DBus objects.
2778 Build stuff for the python bindings.
2782 Extra macro needed for finding the Python C header files.
2784 2003-09-21 Havoc Pennington <hp@pobox.com>
2786 * glib/dbus-gproxy.c (dbus_gproxy_manager_new): start
2787 implementing the proxy manager, didn't get very far.
2789 * dbus/dbus-bus.c (dbus_bus_add_match): new
2790 (dbus_bus_remove_match): new
2792 * glib/dbus-gproxy.c (dbus_gproxy_new_for_service): add a
2793 path_name argument; adjust the other not-yet-implemented
2794 gproxy constructors to be what I think they should be.
2796 2003-09-21 Havoc Pennington <hp@pobox.com>
2798 * dbus/dbus-bus.c (dbus_bus_get): set exit_on_disconnect to TRUE
2799 by default for message bus connections.
2801 * dbus/dbus-connection.c (dbus_connection_dispatch): exit if
2802 exit_on_disconnect flag is set and we process the disconnected
2804 (dbus_connection_set_exit_on_disconnect): new function
2806 2003-09-21 Havoc Pennington <hp@pobox.com>
2808 Get matching rules mostly working in the bus; only actually
2809 parsing the rule text remains. However, the client side of
2810 "signal connections" hasn't been started, this patch is only the
2813 * dbus/dispatch.c: fix for the matching rules changes
2815 * bus/driver.c (bus_driver_handle_remove_match)
2816 (bus_driver_handle_add_match): send an ack reply from these
2819 * glib/dbus-gproxy.c (dbus_gproxy_begin_call): fix order of
2820 arguments, reported by Seth Nickell
2822 * bus/config-parser.c (append_rule_from_element): support
2823 eavesdrop=true|false attribute on policies so match rules
2824 can be prevented from snooping on the system bus.
2826 * bus/dbus-daemon-1.1.in: consistently use terminology "sender"
2827 and "destination" in attribute names; fix some docs bugs;
2828 add eavesdrop=true|false attribute
2830 * bus/driver.c (bus_driver_handle_add_match)
2831 (bus_driver_handle_remove_match): handle AddMatch, RemoveMatch
2834 * dbus/dbus-protocol.h (DBUS_SERVICE_ORG_FREEDESKTOP_BROADCAST): get
2835 rid of broadcast service concept, signals are just always broadcast
2837 * bus/signals.c, bus/dispatch.c, bus/connection.c, bus/bus.c:
2838 mostly implement matching rules stuff (currently only exposed as signal
2841 2003-09-21 Mark McLoughlin <mark@skynet.ie>
2843 * doc/dbus-specification.sgml: Change the header field name
2844 to be an enum and update the rest of the spec to reference
2845 the fields using the conventinal name.
2847 * dbus/dbus-protocol.h: update to reflect the spec.
2849 * doc/TODO: add item to remove the 4 byte alignment requirement.
2851 * dbus/dbus-message.c: Remove the code to generalise the
2852 header/body length and serial number header fields as named
2853 header fields so we can reference field names using the
2855 (append_int_field), (append_uint_field), (append_string_field):
2856 Append the field name as a byte rather than four chars.
2857 (delete_int_or_uint_field), (delete_string_field): reflect the
2858 fact that the field name and typecode now occupy 4 bytes instead
2860 (decode_string_field), (decode_header_data): update to reflect
2861 protocol changes and move the field specific encoding from
2862 decode_string_field() back into decode_header_data().
2864 * dbus/dbus-internals.[ch]: (_dbus_header_field_to_string):
2865 Add utility to aid debugging.
2867 * dbus/dbus-message-builder.c:
2868 (append_string_field), (_dbus_message_data_load): Update to
2869 reflect protocol changes; Change the FIELD_NAME directive
2870 to HEADER_FIELD and allow it to take the field's conventional
2871 name rather than the actual value.
2873 * test/data/*/*.message: Update to use HEADER_FIELD instead
2874 of FIELD_NAME; Always align the header on an 8 byte boundary
2875 *before* updating the header length.
2877 2003-09-15 Havoc Pennington <hp@pobox.com>
2879 * dbus/dbus-pending-call.c: add the get/set object data
2880 boilerplate as for DBusConnection, etc. Use generic object data
2881 for the notify callback.
2883 * glib/dbus-gparser.c (parse_node): parse child nodes
2885 * tools/dbus-viewer.c: more hacking on the dbus-viewer
2887 * glib/dbus-gutils.c (_dbus_gutils_split_path): add a file to
2888 contain functions shared between the convenience lib and the
2891 * glib/Makefile.am (libdbus_glib_1_la_LDFLAGS): add
2892 -export-symbols-regex to the GLib library
2894 * dbus/dbus-object-tree.c (_dbus_object_tree_dispatch_and_unlock):
2895 fix the locking in here, and add a default handler for
2896 Introspect() that just returns sub-nodes.
2898 2003-09-14 Havoc Pennington <hp@pobox.com>
2900 * glib/dbus-gthread.c (dbus_g_thread_init): rename to make g_foo
2901 rather than gfoo consistent
2903 * glib/dbus-gproxy.h: delete for now, move contents to
2904 dbus-glib.h, because the include files don't work right since we
2905 aren't in the dbus/ subdir.
2907 * glib/dbus-gproxy.c (dbus_gproxy_send): finish implementing
2908 (dbus_gproxy_end_call): finish
2909 (dbus_gproxy_begin_call): finish
2911 * glib/dbus-gmain.c (dbus_set_g_error): new
2913 * glib/dbus-gobject.c (handle_introspect): include information
2914 about child nodes in the introspection
2916 * dbus/dbus-connection.c (dbus_connection_list_registered): new
2917 function to help in implementation of introspection
2919 * dbus/dbus-object-tree.c
2920 (_dbus_object_tree_list_registered_and_unlock): new function
2922 2003-09-12 Havoc Pennington <hp@pobox.com>
2924 * glib/dbus-gidl.h: add common base class for all the foo_info
2927 * tools/dbus-viewer.c: add GTK-based introspection UI thingy
2930 * test/Makefile.am: try test srcdir -ef . in addition to test
2931 srcdir = ., one of them should work (yeah lame)
2933 * glib/Makefile.am: build the "idl" parser stuff as a convenience
2936 * glib/dbus-gparser.h: make description_load routines return
2937 NodeInfo* not Parser*
2939 * Makefile.am (SUBDIRS): build test dir after all library dirs
2941 * configure.in: add GTK+ detection
2943 2003-09-07 Havoc Pennington <hp@pobox.com>
2945 * Make Doxygen contented.
2947 2003-09-07 Havoc Pennington <hp@pobox.com>
2949 * doc/dbus-specification.sgml: more updates
2951 2003-09-06 Havoc Pennington <hp@pobox.com>
2953 * doc/dbus-specification.sgml: partial updates
2955 * bus/dbus-daemon-1.1.in: fix the config file docs for the
2956 zillionth time; hopefully I edited the right file this time.
2958 * bus/config-parser.c (append_rule_from_element): support
2959 send_type, send_path, receive_type, receive_path
2961 * bus/policy.c: add message type and path to the list of things
2962 that can be "firewalled"
2964 2003-09-06 Havoc Pennington <hp@pobox.com>
2966 * dbus/dbus-connection.c (dbus_connection_register_fallback): add this
2967 (dbus_connection_register_object_path): make this not handle
2968 messages to paths below the given path
2970 2003-09-03 Havoc Pennington <hp@pobox.com>
2972 * test/glib/Makefile.am: add this with random glib-linked test
2975 * glib/Makefile.am: remove the random test programs from here,
2976 leave only the unit tests
2978 * glib/dbus-gobject.c (_dbus_gobject_test): add test for
2979 uscore/javacaps conversion, and fix
2980 (get_object_property, set_object_property): change to .NET
2981 convention for mapping props to methods, set_FooBar/get_FooBar,
2982 since one language has such a convention we may as well copy it.
2983 Plus real methods in either getFooBar or get_foo_bar style won't
2984 collide with this convention.
2986 2003-09-01 Havoc Pennington <hp@pobox.com>
2988 * glib/dbus-gparser.c: implement
2990 * glib/dbus-gobject.c: start implementing skeletons support
2992 * configure.in: when disabling checks/assert, also define
2993 G_DISABLE_ASSERT and G_DISABLE_CHECKS
2995 2003-09-01 Havoc Pennington <hp@pobox.com>
2997 * glib/Makefile.am: rearrange a bunch of files and get "make
2998 check" framework set up
3000 2003-08-31 Havoc Pennington <hp@pobox.com>
3002 * fix build with --disable-tests
3004 2003-08-30 Havoc Pennington <hp@pobox.com>
3006 * dbus/dbus-connection.c: purge DBusMessageHandler
3008 * dbus/dbus-message-handler.c: remove DBusMessageHandler, just
3009 use callbacks everywhere
3011 2003-08-30 Havoc Pennington <hp@pobox.com>
3013 * test/data/valid-config-files/system.d/test.conf: change to
3014 root for the user so warnings don't get printed
3016 * dbus/dbus-message.c: add dbus_message_get_path,
3017 dbus_message_set_path
3019 * dbus/dbus-object-tree.c (do_test_dispatch): add test of
3020 dispatching to a path
3022 * dbus/dbus-string.c (_dbus_string_validate_path): add
3024 * dbus/dbus-marshal.c (_dbus_demarshal_object_path): implement
3025 (_dbus_marshal_object_path): implement
3027 * dbus/dbus-protocol.h (DBUS_HEADER_FIELD_PATH): new header field
3028 to contain the path to the target object
3029 (DBUS_HEADER_FIELD_SENDER_SERVICE): rename
3030 DBUS_HEADER_FIELD_SENDER to explicitly say it's the sender service
3032 2003-08-30 Havoc Pennington <hp@pobox.com>
3034 * dbus/dbus-object-tree.c: write tests and fix the discovered bugs
3036 2003-08-29 Havoc Pennington <hp@pobox.com>
3038 * dbus/dbus-object-tree.c: modify to allow overlapping paths to be
3040 (struct DBusObjectSubtree): shrink this
3041 a lot, since we may have a lot of them
3042 (_dbus_object_tree_free_all_unlocked): implement
3043 (_dbus_object_tree_dispatch_and_unlock): implement
3045 2003-08-29 Havoc Pennington <hp@pobox.com>
3047 * dbus/dbus-internals.h: fix _DBUS_N_GLOBAL_LOCKS
3049 2003-08-28 Havoc Pennington <hp@pobox.com>
3053 * dbus/dbus-connection.c: port to no ObjectID, create a
3054 DBusObjectTree, rename ObjectTree to ObjectPath in public API
3056 * dbus/dbus-connection.h (struct DBusObjectTreeVTable): delete
3057 everything except UnregisterFunction and MessageFunction
3059 * dbus/dbus-marshal.c: port away from DBusObjectID,
3060 add DBUS_TYPE_OBJECT_PATH
3062 * dbus/dbus-object-registry.[hc], dbus/dbus-object.[hc],
3063 dbus/dbus-objectid.[hc]: remove these, we are moving to
3064 path-based object IDs
3066 2003-08-25 Havoc Pennington <hp@pobox.com>
3068 Just noticed that dbus_message_test is hosed, I wonder when I
3069 broke that. I thought make check was passing earlier...
3071 * dbus/dbus-object-tree.c: add new "object tree" to match DCOP
3072 container tree, will replace most of dbus-object-registry
3074 * dbus/dbus-string.c (_dbus_string_append_printf_valist): fix C99
3077 2003-08-19 Havoc Pennington <hp@pobox.com>
3079 * dbus/dbus-message.c (decode_string_field): support FIELD_SENDER
3080 (dbus_message_is_error): fix this function
3082 * bus/dbus-daemon-1.1: clarify logic on when <deny>/<allow> rules
3085 * bus/policy.c (bus_client_policy_check_can_receive): fix code to
3086 reflect clarified man page
3087 (bus_client_policy_check_can_send): ditto
3089 * bus/session.conf.in: fixup
3091 * bus/system.conf.in: fixup
3093 2003-08-18 Havoc Pennington <hp@redhat.com>
3095 * dbus/dbus-hash.c (_dbus_hash_table_insert_two_strings): fix
3097 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
3098 dumb bug created earlier (wrong order of args to
3099 decode_header_data())
3101 * tools/dbus-send.c: port
3103 * tools/dbus-print-message.c (print_message): port
3105 * test/data/*messages: port all messages over
3107 * dbus/dbus-message-builder.c: support including
3110 * bus/driver.c: port over
3112 * bus/dispatch.c: port over to new stuff
3114 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
3115 rename disconnect signal to "Disconnected"
3117 2003-08-17 Havoc Pennington <hp@pobox.com>
3119 This doesn't compile yet, but syncing up so I can hack on it from
3120 work. What are branches for if not broken code? ;-)
3122 * dbus/dbus-protocol.h: remove DBUS_HEADER_FIELD_NAME, add
3123 DBUS_HEADER_FIELD_INTERFACE, DBUS_HEADER_FIELD_MEMBER,
3124 DBUS_HEADER_FIELD_ERROR_NAME
3126 * dbus/dbus-hash.c: Introduce DBUS_HASH_TWO_STRINGS as hack to use
3127 for the interface+member pairs
3128 (string_hash): change to use g_str_hash algorithm
3129 (find_direct_function, find_string_function): refactor these to
3132 * dbus/dbus-message.c: port all of this over to support
3133 interface/member fields instead of name field
3135 * dbus/dbus-object-registry.c: port over
3137 * dbus/dbus-string.c (_dbus_string_validate_interface): rename
3138 from _dbus_string_validate_name
3140 * bus/dbus-daemon-1.1: change file format for the
3141 <deny>/<allow> stuff to match new message naming scheme
3143 * bus/policy.c: port over
3145 * bus/config-parser.c: parse new format
3147 2003-08-16 Havoc Pennington <hp@pobox.com>
3149 * dbus/dbus-object-registry.c (add_and_remove_objects): remove
3152 * glib/dbus-gproxy.c: some hacking
3154 2003-08-15 Havoc Pennington <hp@redhat.com>
3156 * dbus/dbus-pending-call.c (dbus_pending_call_block): implement
3158 * dbus/dbus-connection.c
3159 (dbus_connection_send_with_reply_and_block): factor out internals;
3160 change to convert any error replies to DBusError instead of
3161 returning them as a message
3163 2003-08-15 Havoc Pennington <hp@pobox.com>
3165 * dbus/dbus-connection.c,
3166 dbus/dbus-pending-call.c: Finish the pending call stuff
3168 2003-08-14 Havoc Pennington <hp@redhat.com>
3170 * dbus/dbus-pending-call.c: start on new object that will replace
3171 DBusMessageHandler and ReplyHandlerData for tracking outstanding
3174 * dbus/dbus-gproxy.c: start on proxy object used to communicate
3175 with remote interfaces
3177 * dbus/dbus-gidl.c: do the boring boilerplate in here
3179 2003-08-12 Havoc Pennington <hp@pobox.com>
3181 * bus/dispatch.c (bus_dispatch): make this return proper
3182 DBusHandlerResult to avoid DBUS_ERROR_UNKNOWN_METHOD
3184 * dbus/dbus-errors.c (dbus_set_error): use
3185 _dbus_string_append_printf_valist
3187 * dbus/dbus-string.c (_dbus_string_append_printf_valist)
3188 (_dbus_string_append_printf): new
3190 * dbus/dbus-errors.h (DBUS_ERROR_UNKNOWN_MESSAGE): change to
3193 * dbus/dbus-connection.c (dbus_connection_dispatch): handle
3194 DBUS_HANDLER_RESULT_NEED_MEMORY; send default error reply if a
3195 message is unhandled.
3197 2003-08-11 Havoc Pennington <hp@pobox.com>
3199 * bus/test.c (client_disconnect_handler): change to return
3200 HANDLED (would have been REMOVE_MESSAGE)
3202 * dbus/dbus-object.h (enum DBusHandlerResult): rename to
3203 HANDLED/NOT_YET_HANDLED instead of
3204 REMOVE_MESSAGE/ALLOW_MORE_HANDLERS to make it clearer how it
3207 2003-08-10 Havoc Pennington <hp@pobox.com>
3209 * tools/dbus-send.c (main): add --type argument, for now
3210 supporting only method_call and signal types.
3212 * tools/dbus-print-message.c: print message type
3214 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
3215 init connection->objects
3217 * doc/dbus-specification.sgml: fix sgml
3219 * bus/*.c: port over to object-instance API changes
3221 * test/test-service.c: ditto
3223 * dbus/dbus-message.c (dbus_message_create_header): allow #NULL
3224 name, we will have to fix up the rest of the code to also handle
3226 (dbus_message_new): generic message-creation call
3227 (set_string_field): allow appending name field
3229 2003-08-06 Havoc Pennington <hp@pobox.com>
3231 * dbus/dbus-object-registry.c: implement signal connection
3234 * dbus/dbus-connection.c (_dbus_connection_unref_unlocked): new
3236 * dbus/dbus-internals.c (_dbus_memdup): new function
3238 2003-08-02 Havoc Pennington <hp@pobox.com>
3240 * dbus/dbus-message.c (dbus_message_get_no_reply)
3241 (dbus_message_set_no_reply): add these and remove
3242 set_is_error/get_is_error
3244 * dbus/dbus-protocol.h, doc/dbus-specification.sgml:
3245 remove the ERROR flag, since there's now an ERROR type
3247 2003-08-01 Havoc Pennington <hp@pobox.com>
3249 * dbus/dbus-object-registry.c (_dbus_object_registry_handle_and_unlock):
3252 * dbus/dbus-message.c (dbus_message_get_type): new function
3254 * doc/dbus-specification.sgml: add "type" byte to messages
3256 2003-08-01 Havoc Pennington <hp@pobox.com>
3258 * dbus/dbus-protocol.h (DBUS_MESSAGE_TYPE_*): introduce
3259 a message type enum to distinguish kinds of message
3260 (DBUS_HEADER_FLAG_NO_REPLY_EXPECTED): flag for a message
3261 that need not be replied to
3263 2003-08-01 Havoc Pennington <hp@pobox.com>
3265 * dbus/dbus-marshal.c: adapt to DBusObjectID changes
3266 (unpack_8_octets): fix no-64-bit-int bug
3268 * dbus/dbus-object-registry.c (validate_id): validate the
3269 connection ID bits, not just the instance ID.
3271 * dbus/dbus-connection.c (_dbus_connection_init_id): initialize
3272 the connection-global 33 bits of the object ID
3274 * dbus/dbus-object-registry.c (info_from_entry): fill in
3275 object ID in the new way
3277 * dbus/dbus-objectid.h: rather than high/low bits, specifically
3278 define server/client/instance bits.
3280 2003-07-30 Havoc Pennington <hp@pobox.com>
3282 * dbus/dbus-connection.c (dbus_connection_register_object): fix
3285 2003-07-13 Havoc Pennington <hp@pobox.com>
3287 * dbus/dbus-object.h (struct DBusObjectVTable): add padding
3288 fields to DBusObjectVTable and DBusObjectInfo
3290 2003-07-12 Havoc Pennington <hp@pobox.com>
3292 * dbus/dbus-object-registry.c: implement unit test,
3293 fix bugs discovered in process
3295 * dbus/dbus-connection.c: remove handler_table and
3296 register_handler(), add DBusObjectRegistry usage
3298 * dbus/dbus-objectid.c (dbus_object_id_is_null)
3299 (dbus_object_id_set_null): new functions
3301 2003-07-08 Havoc Pennington <hp@pobox.com>
3303 * dbus/dbus-object.c: implement some of this
3305 * dbus/dbus-object-registry.c
3306 (_dbus_object_registry_add_and_unlock): fill in the object_id out
3308 (_dbus_object_registry_new): handle OOM
3310 2003-07-08 Havoc Pennington <hp@pobox.com>
3312 * dbus/dbus-object.h: sketch out an API for registering objects
3313 with a connection, that allows us to use as little as 24 bytes
3314 per object and lets application code represent an object in
3315 any conceivable way.
3317 * dbus/dbus-object-registry.c: implement the hard bits of the
3318 DBusConnection aspect of object API. Not yet wired up.
3320 2003-07-06 Havoc Pennington <hp@pobox.com>
3322 * dbus/dbus-marshal.c (_dbus_marshal_set_object_id): new function
3323 (_dbus_marshal_object_id): new
3324 (_dbus_demarshal_object_id): new
3325 (_dbus_marshal_get_arg_end_pos): support object ID type, and
3326 consolidate identical switch cases. Don't conditionalize handling
3327 of DBUS_TYPE_UINT64, need to handle the type always.
3328 (_dbus_marshal_validate_arg): consolidate identical cases, and
3329 handle DBUS_TYPE_OBJECT_ID
3331 * dbus/dbus-objectid.c: new file with DBusObjectID data type.
3333 * dbus/dbus-protocol.h: add DBUS_TYPE_OBJECT_ID
3335 2003-09-28 Havoc Pennington <hp@pobox.com>
3339 2003-09-28 Havoc Pennington <hp@pobox.com>
3341 * doc/Makefile.am (dbus-specification.html): testing a funky hack
3342 to work with Debian db2html
3344 2003-09-28 Havoc Pennington <hp@pobox.com>
3346 * configure.in: 0.13
3348 * doc/Makefile.am (dbus-test-plan.html): accept nonexistence of
3349 stylesheet-images for benefit of Debian
3351 Change back to using filesystem-linked sockets for the system
3352 bus, so only root can create the default system bus address.
3354 * bus/system.conf.in: change to use
3355 DBUS_SYSTEM_BUS_DEFAULT_ADDRESS
3357 * dbus/Makefile.am (INCLUDES): remove DBUS_SYSTEM_BUS_PATH define
3360 * configure.in: define DBUS_SYSTEM_BUS_DEFAULT_ADDRESS
3361 here, and AC_DEFINE DBUS_SYSTEM_PATH
3363 2003-08-09 Anders Carlsson <andersca@codefactory.se>
3366 * doc/busconfig.dtd:
3369 2003-08-09 Anders Carlsson <andersca@codefactory.se>
3371 * doc/dbus-specification.sgml:
3372 Add activation reply values.
3374 2003-08-05 Havoc Pennington <hp@redhat.com>
3376 * configure.in: 0.12
3378 2003-08-05 Anders Carlsson <andersca@codefactory.se>
3380 * glib/dbus-gmain.c: (watch_fd_new), (watch_fd_ref),
3381 (watch_fd_unref), (dbus_gsource_check), (dbus_gsource_dispatch),
3382 (add_watch), (remove_watch), (create_source):
3383 Refcount fds, fixes some reentrancy issues.
3385 2003-07-30 Havoc Pennington <hp@redhat.com>
3387 * dbus/dbus-bus.c (init_connections_unlocked): fix default system
3388 bus address to be abstract if we have abstract sockets
3392 2003-07-28 Havoc Pennington <hp@redhat.com>
3394 * bus/messagebus.in: fix to avoid processname/servicename
3395 confusion, from Michael Kearey
3396 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=100965
3398 2003-07-23 Havoc Pennington <hp@pobox.com>
3400 * dbus/dbus-message.c (dbus_message_iter_get_named):
3401 fix from Andy Hanton to remove broken "+1"
3403 2003-07-16 Havoc Pennington <hp@pobox.com>
3405 * tools/dbus-launch.c (babysit): close stdout/stderr in the
3406 babysitter process, as suggested by Thomas Leonard, so
3407 an "eval `dbus-launch --exit-with-session`" will actually
3410 2003-07-16 Havoc Pennington <hp@pobox.com>
3412 * configure.in: print out EXPANDED_* variables in the summary at
3413 the end; clean up the code that computes EXPANDED_ variables and
3414 get the ones using exec_prefix right. Should make things work
3415 when you build without --prefix
3417 2003-06-29 Havoc Pennington <hp@pobox.com>
3419 * mono/Test.cs (class Test): fire up a main loop and run it
3421 * mono/DBus.cs (DBus): don't g_thread_init since it can only be
3422 done once, the app has to do it
3424 2003-06-26 Havoc Pennington <hp@pobox.com>
3426 * mono/Connection.cs: set up connection with the glib main loop
3428 2003-07-01 Havoc Pennington <hp@redhat.com>
3430 * doc/dbus-specification.sgml: clarify the format of a type code,
3431 change suggested by Jim Blandy
3433 2003-06-29 Miloslav Trmac <mitr@volny.cz>
3436 * tools/Makefile.am: Don't assume srcdir == builddir.
3438 * dbus/dbus-memory.c (dbus_realloc): Don't check guards after shrinking
3439 the allocated block.
3440 (_dbus_memory_test): New function.
3441 * dbus/dbus-test.h: Add _dbus_memory_test ().
3442 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): Call it.
3444 * dbus/dbus-message.c (decode_header_data): Use %.4s instead
3446 (dbus_message_new): Remove obsolete @todo.
3448 * dbus/dbus-marshal.c (_dbus_marshal_set_int64)
3449 (_dbus_marshal_set_uint64): Fix comment.
3451 * dbus/dbus-message.c (append_int_field, append_uint_field): Don't
3452 hardcode FIELD_REPLY_SERIAL.
3454 * dbus/dbus-mainloop.c (_dbus_loop_remove_watch)
3455 (_dbus_loop_remove_timeout): Cast function pointers to (void *) for %p
3457 * configure.in: Add -D_POSIX_C_SOURCE=199309L -DBSD_SOURCE to CFLAGS
3458 and disable DBUS_USE_ATOMIC_INT_486 when --enable-ansi is used
3460 2003-06-24 Havoc Pennington <hp@pobox.com>
3462 * mono/*.cs: Use IntPtr.Zero instead of ((IntPtr) 0)
3464 2003-06-23 Anders Carlsson <andersca@codefactory.se>
3470 * gcj/TestMessage.java: (TestMessage), (TestMessage.main):
3471 * gcj/org/.cvsignore:
3472 * gcj/org/Makefile.am:
3473 * gcj/org/freedesktop/.cvsignore:
3474 * gcj/org/freedesktop/Makefile.am:
3475 * gcj/org/freedesktop/dbus/.cvsignore:
3476 * gcj/org/freedesktop/dbus/Makefile.am:
3477 * gcj/org/freedesktop/dbus/Message.java: (Message),
3479 * gcj/org/freedesktop/dbus/natMessage.cc:
3480 Fix the build system.
3482 2003-06-22 Havoc Pennington <hp@pobox.com>
3484 * mono/Connection.cs: add more bindings
3486 * dbus/dbus-threads.c (dbus_threads_init): allow calling this
3489 2003-06-22 Havoc Pennington <hp@pobox.com>
3491 * mono/Connection.cs, mono/DBus.cs, mono/Error.cs:
3492 Start wrapping more stuff.
3494 2003-06-22 Havoc Pennington <hp@pobox.com>
3496 * mono/Message.cs: implement Message.Wrap() that ensures we only
3497 have a single C# wrapper per DBusMessage, assuming it works which
3498 it probably doesn't.
3500 * dbus/dbus-message.c (dbus_message_allocate_data_slot): new
3501 (dbus_message_free_data_slot): new
3502 (dbus_message_set_data): new
3503 (dbus_message_get_data): new
3505 2003-06-22 Havoc Pennington <hp@pobox.com>
3507 * dbus/dbus-dataslot.c (_dbus_data_slot_allocator_unref)
3508 (_dbus_data_slot_allocator_alloc): rework these to keep a
3509 reference count on each slot and automatically manage a global
3510 slot ID variable passed in by address
3512 * bus/bus.c: convert to new dataslot API
3514 * dbus/dbus-bus.c: convert to new dataslot API
3516 * dbus/dbus-connection.c: convert to new dataslot API
3518 * dbus/dbus-server.c: convert to new dataslot API
3520 * glib/dbus-gmain.c: ditto
3524 * bus/connection.c: ditto
3526 2003-06-22 Anders Carlsson <andersca@codefactory.se>
3528 * configure.in: Add AM_PROG_GCJ and move AM_PROG_LIBTOOL
3529 after the gcj checks so that the correct configuration tags
3530 will be added to libtool.
3532 * dbus-glib-1.pc.in: No need to specify any includes since
3533 dbus-1.pc.in has those.
3535 2003-06-22 Havoc Pennington <hp@pobox.com>
3537 * mono/*, gcj/*, configure.in, Makefile.am:
3538 Check in makefiles and subdirs for mono and gcj bindings.
3539 Neither binding actually exists, just trying to get through
3540 all the build and other boring bits.
3542 2003-06-21 Philip Blundell <philb@gnu.org>
3544 * tools/dbus-monitor.1: Updated.
3546 * tools/dbus-send.1: Likewise.
3548 2003-06-20 Anders Carlsson <andersca@codefactory.se>
3550 * dbus/dbus-transport-unix.c (unix_handle_watch): Check
3551 for hangup and error after checking read so we won't discard
3552 pending data if both hangup and read are set.
3554 2003-06-19 Philip Blundell <philb@gnu.org>
3556 * tools/dbus-print-message.c (print_message): Handle BOOLEAN.
3558 * tools/dbus-send.c: Accept both --system and --session.
3560 * tools/dbus-monitor.c: Same here.
3562 2003-06-19 Anders Carlsson <andersca@codefactory.se>
3564 * glib/dbus-glib.h: Fix so that dbus-glib.h can be used
3565 from C++ (Patch by Miloslav Trmac).
3567 2003-06-15 Joe Shaw <joe@assbarn.com>
3569 * configure.in: Check for socklen_t.
3571 * dbus/dbus-sysdeps.c: Define socklen_t if it's not defined.
3573 * test/test-segfault.c: Add #include <sys/time.h>
3575 * tools/Makefile.am: Add DBUS_X_CFLAGS to the INCLUDES since
3576 dbus-launch needs it.
3578 2003-06-09 Havoc Pennington <hp@redhat.com>
3580 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): don't use
3581 SUN_LEN, it breaks abstract socket usage
3583 * dbus/dbus-internals.c (_dbus_verbose_real): only print PID at
3586 2003-06-04 Havoc Pennington <hp@pobox.com>
3588 * dbus/dbus-server.c (dbus_server_listen): allow abstract sockets
3589 using unix:abstract=/foo, and when listening in a tmpdir
3590 i.e. unix:tmpdir=/tmp, always use abstract sockets if we can.
3592 * dbus/dbus-transport.c (_dbus_transport_open): support
3595 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
3596 support abstract sockets
3598 * dbus/dbus-transport-unix.c
3599 (_dbus_transport_new_for_domain_socket): support abstract sockets
3601 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket): add "abstract"
3602 toggle as an argument, implement abstract namespace support
3603 (_dbus_listen_unix_socket): ditto
3605 * configure.in: add --enable-abstract-sockets and implement
3606 a configure check for autodetection of the right value.
3608 2003-06-01 Havoc Pennington <hp@pobox.com>
3610 * tools/dbus-cleanup-sockets.c: add utility to clean up sockets
3611 in /tmp (though on Linux this will end up being useless,
3612 when we add abstract namespace support)
3614 * configure.in: define DBUS_SESSION_SOCKET_DIR in addition to
3617 2003-05-28 Colin Walters <walters@verbum.org>
3619 * tools/dbus-monitor.c (main): Fix silly typo (s/--session/--system/).
3621 2003-05-18 Anders Carlsson <andersca@codefactory.se>
3623 * dbus/dbus-message.c (dbus_message_new): Remove @todo.
3625 2003-05-17 Colin Walters <walters@gnu.org>
3627 * tools/dbus-send.c: Don't exit with an error code if --help was
3628 passed. Default to using the session bus instead of the system
3631 * tools/dbus-launch.c: Ditto.
3633 * tools/dbus-monitor.c: Ditto.
3635 * tools/dbus-send.1: Update with new arguments.
3637 * tools/dbus-launch.c: Emit code to export variables. New
3638 arguments -s and -c to specify shell syntax, and a bit of code to
3639 autodetect syntax. Also, allow specifying a program to run.
3641 * tools/dbus-launch.1: Update with new arguments.
3643 * tools/dbus-send.1: Ditto.
3645 * tools/dbus-monitor.1: Ditto.
3647 2003-05-17 Havoc Pennington <hp@pobox.com>
3649 * bus/config-parser.c (merge_included): merge in policies from
3650 child configuration file.
3652 * bus/policy.c (bus_policy_merge): function to merge two policies
3655 2003-05-16 Havoc Pennington <hp@redhat.com>
3657 * dbus/dbus-connection.c: disable verbose lock spew
3659 * tools/dbus-send.c: add --print-reply command line option
3661 * tools/dbus-print-message.h (print_message): new util function
3662 shared by dbus-send and dbus-monitor
3664 * tools/dbus-monitor.c (handler_func): exit on disconnect
3666 * dbus/dbus-transport-unix.c (do_reading): if the transport is
3667 disconnected, don't try to use the read_watch
3669 * dbus/dbus-watch.c (dbus_watch_get_enabled): assert watch != NULL
3670 so we can find this bug more easily
3672 2003-05-16 Havoc Pennington <hp@redhat.com>
3674 * bus/policy.c (free_rule_list_func): avoid a crash when passed
3675 NULL as DBusHashTable is annoyingly likely to do.
3677 2003-05-16 Colin Walters <walters@verbum.org>
3679 * tools/dbus-monitor.c: Add --session argument and usage()
3682 * tools/dbus-monitor.1: Update with new --session arg.
3684 * bus/Makefile.am (install-data-hook): Create
3685 $(libdir)/dbus-1.0/services so that the session bus is happy.
3687 2003-05-15 Havoc Pennington <hp@redhat.com>
3689 * dbus/dbus-sysdeps.c (_dbus_atomic_dec, _dbus_atomic_inc): work
3690 on non-x86. ifdef's are evil.
3692 2003-05-15 Havoc Pennington <hp@redhat.com>
3694 * configure.in: 0.11
3698 * bus/Makefile.am (initddir): apparently we are supposed to put
3699 init scripts in /etc/rc.d/init.d not /etc/init.d
3701 * bus/Makefile.am: remove the "you must --enable-tests to make
3702 check" as it broke distcheck
3704 * bus/Makefile.am (install-data-hook): create /etc/dbus-1/system.d
3706 2003-05-13 James Willcox <jwillcox@gnome.org>
3709 * bus/activation.c: (bus_activation_service_created),
3710 (bus_activation_activate_service):
3711 * bus/driver.c: (bus_driver_send_service_deleted),
3712 (bus_driver_send_service_created), (bus_driver_send_service_lost),
3713 (bus_driver_send_service_acquired),
3714 (bus_driver_send_welcome_message),
3715 (bus_driver_handle_list_services):
3716 * bus/session.conf.in:
3717 * dbus/dbus-bus.c: (dbus_bus_acquire_service),
3718 (dbus_bus_service_exists), (dbus_bus_activate_service):
3721 Add some convenience API which lets you activate a service, and did a
3722 bunch of s/0/DBUS_TYPE_INVALID/ in calls to dbus_message_append_args()
3723 and dbus_message_get_args()
3725 2003-05-11 Havoc Pennington <hp@pobox.com>
3727 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix to avoid
3728 calling _dbus_marshal_validate_arg() for every byte in a byte
3731 * dbus/dbus-message-handler.c: use atomic reference counting to
3732 reduce number of locks slightly; the global lock in here sucks
3734 * dbus/dbus-connection.c
3735 (_dbus_connection_update_dispatch_status_and_unlock): variant of
3736 update_dispatch_status that can be called with lock held; then use
3737 in a couple places to reduce locking/unlocking
3738 (dbus_connection_send): hold the lock over the whole function
3739 instead of acquiring it twice.
3741 * dbus/dbus-timeout.c (_dbus_timeout_new): handle OOM
3743 * bus/connection.c (bus_connections_setup_connection): fix access
3744 to already-freed memory.
3746 * dbus/dbus-connection.c: keep a little cache of linked list
3747 nodes, to avoid using the global linked list alloc lock in the
3748 normal send-message case. Instead we just use the connection lock
3749 that we already have to take.
3751 * dbus/dbus-list.c (_dbus_list_find_last): new function
3753 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec):
3754 change to use a struct for the atomic type; fix docs,
3755 they return value before increment, not after increment.
3757 * dbus/dbus-string.c (_dbus_string_append_4_aligned)
3758 (_dbus_string_append_8_aligned): new functions to try to
3759 microoptimize this operation.
3760 (reallocate_for_length): break this out of set_length(), to
3761 improve profile info, and also so we can consider inlining the
3764 * dbus/dbus-message.c (dbus_message_new_empty_header): init data
3765 strings with some preallocation, cuts down on our calls to realloc
3766 a fair bit. Though if we can get the "move entire string to empty
3767 string" optimization below to kick in here, it would be better.
3769 * dbus/dbus-string.c (_dbus_string_move): just call
3770 _dbus_string_move_len
3771 (_dbus_string_move_len): add a special case for moving
3772 an entire string into an empty string; we can just
3773 swap the string data instead of doing any reallocs.
3774 (_dbus_string_init_preallocated): new function
3776 2003-05-11 Havoc Pennington <hp@pobox.com>
3778 Write a "test-profile" that does echo client-server with threads;
3779 profile reveals lock contention, memcpy/realloc of buffers, and
3780 UTF-8 validation as hot spots. 20% of lock contention eliminated
3781 with dbus_atomic_inc/dec implementation on x86. Much remaining
3782 contention is global mempool locks for GList and DBusList.
3784 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec): add
3787 * dbus/dbus-connection.c (struct DBusConnection): use
3788 dbus_atomic_t for the reference count
3790 * dbus/dbus-message.c (struct DBusMessage): declare
3791 dbus_atomic_t values as volatile
3793 * configure.in: code to detect ability to use atomic integer
3794 operations in assembly, from GLib patch
3796 * dbus/dbus-internals.c (_dbus_verbose_real): call getpid every
3797 time, tired of it being wrong in threads and forked processes
3799 * glib/test-profile.c: a little program to bounce messages back
3800 and forth between threads and eat CPU
3802 * dbus/dbus-connection.c: add debug spew macros for debugging
3803 thread locks; include config.h at top; fix deadlock in
3804 dbus_connection_flush()
3806 2003-05-08 Havoc Pennington <hp@pobox.com>
3808 * dbus/dbus-spawn.c: s/_exit/exit/ because it was keeping gcov
3809 data from getting written, and there wasn't a good reason to
3812 * test/decode-gcov.c (mark_inside_dbus_build_tests): don't count
3813 dbus_verbose lines in test coverage
3814 (main): add list of functions sorted by # of untested blocks
3815 to the coverage report
3817 * dbus/dbus-mempool.c: put some test-only code in DBUS_BUILD_TESTS
3819 * dbus/dbus-marshal.c (_dbus_marshal_test): extend test coverage
3821 * dbus/dbus-message-handler.c (_dbus_message_handler_test):
3822 extend test coverage
3824 * test/data/auth/cancel.auth-script: test canceling an
3827 * dbus/Makefile.am: remove dbus-server-debug.[hc] for now, as they
3828 aren't used. in CVS history if we end up needing them.
3830 2003-05-04 Havoc Pennington <hp@pobox.com>
3832 * dbus/dbus-message-handler.c (_dbus_message_handler_test): add
3835 * dbus/dbus-marshal.c (_dbus_demarshal_string_array): fix this
3836 function, which assumed length was in # of strings, not bytes
3838 * dbus/dbus-message.c (_dbus_message_test): add tests for some
3841 * dbus/dbus-connection.c
3842 (_dbus_connection_queue_received_message): disable function for
3843 now, we are only using it in test mode
3845 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
3846 remove a mistaken FIXME
3848 2003-05-04 Havoc Pennington <hp@pobox.com>
3850 * dbus/dbus-connection.c (dbus_connection_preallocate_send):
3851 unlock mutex on successful return, patch from Anders Gustafsson
3853 2003-05-04 Havoc Pennington <hp@pobox.com>
3855 * dbus-glib-1.pc.in (Requires): fix dependencies, from
3858 2003-05-04 Havoc Pennington <hp@pobox.com>
3860 * tools/dbus-launch.c: implement
3862 * bus/main.c (main), bus/bus.c (bus_context_new):
3863 implement --print-pid and --fork
3865 2003-05-03 Havoc Pennington <hp@redhat.com>
3867 * dbus/dbus-address.c (dbus_parse_address): fix bug when a key in
3868 the address had no value, and add to test suite. Fix and
3869 regression test from Miloslav Trmac
3871 2003-05-03 Havoc Pennington <hp@pobox.com>
3873 * dbus/dbus-watch.c (dbus_watch_handle): warn and return if a
3874 watch is invalid when handled
3876 * tools/Makefile.am, tools/dbus-launch.c, tools/dbus-launch.1: add
3877 dbus-launch utility to launch the bus from a shell script. Didn't
3878 actually implement dbus-launch yet, it's just a placeholder still.
3880 2003-05-03 Havoc Pennington <hp@pobox.com>
3882 * bus/Makefile.am, bus/dbus-daemon-1.1.in: man page for the
3883 daemon; also documents daemon config file, so replaces
3884 doc/config-file.txt. Corrected some stuff from config-file.txt in
3885 the process of moving it.
3887 2003-05-03 Havoc Pennington <hp@pobox.com>
3889 * tools/Makefile.am, tools/dbus-send.1, tools/dbus-monitor.1:
3892 2003-05-03 Colin Walters <walters@verbum.org>
3894 * dbus/dbus-sysdeps.c (fill_user_info): Test against
3895 DBUS_UID_UNSET to determine whether to do a uid lookup or not.
3897 * Makefile.am: Update to use new .pc versioning scheme.
3899 2003-05-02 Havoc Pennington <hp@redhat.com>
3901 * bus/system.conf.in: allow send/receive to/from message bus
3904 2003-04-30 Havoc Pennington <hp@redhat.com>
3906 * configure.in: print a note when building with unit tests and
3909 2003-04-30 Havoc Pennington <hp@redhat.com>
3911 * Makefile.am: add a check-local that complains if you didn't
3912 configure with --enable-tests
3914 2003-04-29 Havoc Pennington <hp@redhat.com>
3916 * glib/dbus-gmain.c: docs cleanups
3918 * dbus/dbus-types.h: add docs on int64 types
3920 * dbus/dbus-memory.c: fix docs to avoid putting private API in
3921 public API docs section
3923 2003-04-29 Havoc Pennington <hp@redhat.com>
3925 * dbus-1.pc.in, dbus-glib-1.pc.in: rename these from
3926 dbus-1.0.pc.in, dbus-glib-1.0.pc.in. As these change with the
3927 parallel install API version, not with the D-BUS package version.
3929 * HACKING: move some of README over here
3931 * README: updates, and document API/ABI policy
3933 * configure.in: reindentation
3935 2003-04-29 Havoc Pennington <hp@redhat.com>
3937 * dbus/dbus.h: add "you have to define DBUS_API_SUBJECT_TO_CHANGE
3938 to use this library" to be sure people have the right
3941 2003-04-28 Havoc Pennington <hp@redhat.com>
3943 * configure.in: add --enable-docs which by default is auto yes if
3944 doxygen and db2html found, no otherwise; but can be forced on/off
3946 * doc/Makefile.am: conditionalize whether to build docs on
3949 2003-04-28 Havoc Pennington <hp@redhat.com>
3951 * configure.in: 0.10
3955 * bus/system.conf.in: add <includedir>system.d</includedir>
3957 * dbus/dbus-userdb.c (_dbus_user_database_lookup): fix bug when
3958 username was provided but not uid
3960 * bus/config-parser.c (struct BusConfigParser): keep track of
3961 whether the parser is toplevel or was included; change some
3962 of the error handling if it's included.
3964 2003-04-27 Havoc Pennington <hp@pobox.com>
3968 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
3969 report correct status if we finish processing authentication
3970 inside this function.
3972 * bus/activation.c (try_send_activation_failure): use
3973 bus_transaction_send_error_reply
3975 * bus/connection.c (bus_connection_get_groups): return an error
3976 explaining the problem
3978 * bus/bus.c (bus_context_check_security_policy): implement
3979 restriction here that inactive connections can only send the
3980 hello message. Also, allow bus driver to send anything to
3983 * bus/connection.c (bus_connection_complete): create the
3984 BusClientPolicy here instead of on-demand.
3985 (bus_connection_get_policy): don't return an error
3987 * dbus/dbus-message.c (dbus_message_new_error_reply): allow NULL
3988 sender field in message being replied to
3990 * bus/bus.c (bus_context_check_security_policy): fix silly typo
3991 causing it to return FALSE always
3993 * bus/policy.c (bus_client_policy_check_can_send): fix bug where
3994 we checked sender rather than destination
3996 2003-04-25 Havoc Pennington <hp@redhat.com>
3998 test suite is slightly hosed at the moment, will fix soon
4000 * bus/connection.c (bus_connections_expire_incomplete): fix to
4001 properly disable the timeout when required
4002 (bus_connection_set_name): check whether we can remove incomplete
4003 connections timeout after we complete each connection.
4005 * dbus/dbus-mainloop.c (check_timeout): fix this up a bit,
4006 probably still broken.
4008 * bus/services.c (bus_registry_acquire_service): implement max
4009 number of services owned, and honor allow/deny rules on which
4010 services a connection can own.
4012 * bus/connection.c (bus_connection_get_policy): report errors here
4014 * bus/activation.c: implement limit on number of pending
4017 2003-04-25 Havoc Pennington <hp@redhat.com>
4019 * dbus/dbus-transport.c (_dbus_transport_get_unix_user): fix bug
4020 where we used >= 0 instead of != DBUS_UID_UNSET.
4022 2003-04-25 Havoc Pennington <hp@redhat.com>
4024 * glib/dbus-gmain.c (remove_watch): fix for a crash when watches
4025 were toggled without add/remove, fix from Anders Gustafsson
4027 2003-04-24 Havoc Pennington <hp@redhat.com>
4029 * test/data/valid-config-files/basic.conf: add <limit> tags to
4032 * bus/config-parser.h, bus/config-parser.c, bus/bus.c: Implement
4033 <limit> tag in configuration file.
4035 2003-04-24 Havoc Pennington <hp@redhat.com>
4037 * bus/dispatch.c: somehow missed some name_is
4039 * dbus/dbus-timeout.c (_dbus_timeout_set_enabled)
4040 (_dbus_timeout_set_interval): new
4042 * bus/connection.c (bus_connections_setup_connection): record time
4043 when each connection is first set up, and expire them after the
4044 auth timeout passes.
4046 2003-04-24 Havoc Pennington <hp@redhat.com>
4048 * dbus/dbus-message.c (dbus_message_name_is): rename
4049 (dbus_message_service_is): rename
4050 (dbus_message_sender_is): rename
4051 (dbus_message_get_service): rename
4053 2003-04-24 Havoc Pennington <hp@redhat.com>
4055 * configure.in: add --enable-checks
4057 * dbus/dbus-message.c (dbus_message_new): reverse name/service arguments
4059 * dbus/dbus-connection.c (dbus_connection_preallocate_send): fix
4060 to use thread locks.
4061 (_dbus_connection_handler_destroyed_locked): move some private
4062 functions into proper docs group
4064 * dbus/dbus-internals.h: add _dbus_return_if_fail,
4065 _dbus_return_val_if_fail
4067 Throughout: use dbus_return_if_fail
4069 2003-04-23 James Willcox <jwillcox@gnome.org>
4072 * glib/dbus-gmain.c: (add_timeout), (wakeup_main), (create_source),
4073 (dbus_connection_setup_with_g_main),
4074 (dbus_server_setup_with_g_main):
4075 * glib/test-dbus-glib.c: (main):
4076 * glib/test-thread-client.c: (main):
4077 * glib/test-thread-server.c: (new_connection_callback), (main):
4078 * tools/dbus-monitor.c: (main):
4080 Added a GMainContext argument to dbus_connection_setup_with_g_main()
4081 and dbus_server_setup_with_g_main().
4083 2003-04-20 Havoc Pennington <hp@pobox.com>
4085 * doc/dbus-specification.sgml: document the restrictions on
4086 message and service names
4088 2003-04-22 Havoc Pennington <hp@redhat.com>
4090 * dbus/dbus-message.c, dbus/dbus-marshal.c: add 64-bit integer
4091 support, and do some code cleanups to share more code and
4092 speed up array marshal/demarshal.
4094 * dbus-1.0.pc.in (Cflags): put libdir include file in cflags
4096 * configure.in: generate dbus-arch-deps.h
4098 * dbus/dbus-protocol.h (DBUS_TYPE_INT64, DBUS_TYPE_UINT64): add
4101 2003-04-22 Havoc Pennington <hp@redhat.com>
4103 * test/data/valid-messages/opposite-endian.message: fix test
4104 to use proper type for rply field
4106 * test/data/invalid-messages: add tests for below validation
4108 * dbus/dbus-message.c (decode_header_data): validate field types,
4109 and validate that named fields are valid names
4110 (decode_name_field): consider messages in the
4111 org.freedesktop.Local. namespace to be invalid.
4113 * dbus/dbus-string.c (_dbus_string_validate_name): new
4115 2003-04-19 Havoc Pennington <hp@pobox.com>
4117 * bus/driver.c (bus_driver_handle_hello): check limits and
4118 return an error if they are exceeded.
4120 * bus/connection.c: maintain separate lists of active and inactive
4121 connections, and a count of each. Maintain count of completed
4122 connections per user. Implement code to check connection limits.
4124 * dbus/dbus-list.c (_dbus_list_unlink): export
4126 * bus/bus.c (bus_context_check_security_policy): enforce a maximum
4127 number of bytes in the message queue for a connection
4129 2003-04-18 Havoc Pennington <hp@pobox.com>
4131 * dbus/dbus-auth.c (record_mechanisms): memleak fixes
4133 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): fix some
4136 * dbus/dbus-keyring.c (add_new_key): fix a memleak, and
4137 on realloc be sure to update the pointer in the keyring
4139 * dbus/dbus-string.c (_dbus_string_zero): compensate for align
4140 offset to avoid writing to unallocated memory
4142 * dbus/dbus-auth.c (process_rejected): return FALSE if we fail to
4143 try the next mechanism, so we properly handle OOM
4145 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): fix double-free
4147 (_dbus_keyring_new): fix OOM bug
4148 (_dbus_keyring_new_homedir): always set error; impose a maximum
4149 number of keys we'll load from the file, mostly to speed up the
4150 test suite and make its OOM checks more useful, but also for
4153 * dbus/dbus-auth.c (process_error_server): reject authentication
4154 if we get an error from the client
4155 (process_cancel): on cancel, send REJECTED, per the spec
4156 (process_error_client): send CANCEL if we get an error from the
4159 2003-04-18 Havoc Pennington <hp@pobox.com>
4161 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix UMR in verbose
4164 * dbus/dbus-auth.c (handle_client_data_cookie_sha1_mech): fix OOM
4167 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): only whine
4168 about DBUS_TEST_HOMEDIR once
4170 * bus/Makefile.am (TESTS_ENVIRONMENT): put DBUS_TEST_HOMEDIR in
4173 * bus/dispatch.c (bus_dispatch_sha1_test): actually load sha1
4174 config file so we test the right thing
4176 Throughout: assorted docs improvements
4178 2003-04-18 Havoc Pennington <hp@pobox.com>
4180 * glib/dbus-gmain.c: adapt to watch changes
4182 * bus/bus.c, bus/activation.c, etc.: adjust to watch changes
4184 * dbus/dbus-server.h: remove dbus_server_handle_watch
4186 * dbus/dbus-connection.h: remove dbus_connection_handle_watch
4188 * dbus/dbus-watch.c (dbus_watch_handle): change DBusWatch to work
4189 like DBusTimeout, so we don't need dbus_connection_handle_watch
4192 2003-04-17 Havoc Pennington <hp@redhat.com>
4194 * dbus/dbus-userdb.c, dbus/dbus-sysdeps.c: redo all the passwd
4195 database usage so it all goes via the DBusUserDatabase cache.
4197 2003-04-17 Havoc Pennington <hp@redhat.com>
4199 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix logic so that if
4200 there was an OOM watch we skipped, we always return TRUE so we
4201 iterate again to have a look at it again. Fixes test suite hang.
4202 Code rearrangement also lets us lose some memset and only iterate
4203 over callbacks once.
4205 * bus/driver.c (bus_driver_handle_message): sense of test for
4208 2003-04-16 Havoc Pennington <hp@pobox.com>
4210 * doc/dbus-specification.sgml: make spec say serials are unsigned
4212 * dbus/dbus-message.h: change message serials to unsigned
4214 * dbus/dbus-connection.c: adapt to message serials being unsigned
4216 2003-04-15 Havoc Pennington <hp@pobox.com>
4218 * bus/bus.c: create and keep around a shared DBusUserDatabase
4221 * bus/connection.c (bus_connection_get_groups): don't cache
4222 groups for user in the connection object, since user database
4223 object now does that.
4225 2003-04-16 Havoc Pennington <hp@redhat.com>
4227 * dbus/dbus-message.c (_dbus_message_add_size_counter): keep a
4228 list of size counters
4229 (_dbus_message_loader_putback_message_link): put back a popped link
4231 * dbus/dbus-connection.c
4232 (dbus_connection_set_max_live_messages_size): rename
4234 (dbus_connection_get_outgoing_size): get size of outgoing
4236 (_dbus_connection_set_connection_counter): remove this cruft
4238 2003-04-14 Havoc Pennington <hp@redhat.com>
4240 * dbus/dbus-userdb.c: user database abstraction, mostly to get
4241 caching, but at some point we might want to be able to use a
4244 * bus/dispatch.c (bus_dispatch_sha1_test): add a test that uses
4245 SHA1 conf file to test the sha1 auth mechanism, since the regular
4246 test always uses EXTERNAL when available.
4249 test/data/valid-config-files/debug-allow-all-sha1.conf.in:
4250 add conf file that requires use of sha1 auth
4252 2003-04-13 Havoc Pennington <hp@pobox.com>
4254 * tools/dbus-send.c, tools/dbus-monitor.c: two utility programs
4255 from Philip Blundell to send messages and monitor them.
4257 2003-04-13 Havoc Pennington <hp@pobox.com>
4259 * dbus/dbus-mainloop.c: fix some reentrancy issues by refcounting
4262 * test/data/valid-config-files/debug-allow-all.conf.in: allow all
4265 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
4266 fix to only recover unused bytes if we're already authenticated
4267 (_dbus_transport_get_is_authenticated): fix to still mark us
4268 authenticated if there are unused bytes.
4270 * bus/dispatch.c: implement security policy checking
4272 * bus/connection.c (bus_transaction_send_from_driver): new
4274 * bus/bus.c (bus_context_check_security_policy): new
4276 * bus/dispatch.c (send_service_nonexistent_error): delete this,
4277 now we just set the DBusError and it gets converted to an error
4280 * bus/connection.c (allow_user_function): enable code using actual
4281 data from the config file
4283 * bus/policy.c (list_allows_user): handle wildcard rules for
4284 user/group connection perms
4286 2003-04-13 Havoc Pennington <hp@pobox.com>
4288 * bus/config-parser.c: Load up the BusPolicy and BusPolicyRules
4290 * dbus/dbus-sysdeps.c (_dbus_get_user_id): new function
4292 * bus/policy.c (bus_policy_append_mandatory_rule)
4293 (bus_policy_append_default_rule, bus_policy_append_user_rule)
4294 (bus_policy_append_group_rule): new functions
4296 2003-04-12 Havoc Pennington <hp@pobox.com>
4298 * bus/config-parser.c (bus_config_parser_new): fix a memleak
4300 * dbus/dbus-sysdeps.c: change DBusCredentials to use longs for
4301 the pid/gid/uid, just for paranoia.
4303 * test/break-loader.c (randomly_do_n_things): find a byte
4304 containing a type code, and randomly change it to a different
4307 2003-04-12 Havoc Pennington <hp@pobox.com>
4309 * bus/policy.h: change BusPolicy to be the thing from the config
4310 file, and rename old BusPolicy to BusClientPolicy
4312 * bus/bus.c, bus/connection.c, bus/config-parser.c: change to
4313 match change in how policy works
4315 * dbus/dbus-internals.h: mark assert_not_reached as
4316 __attribute((noreturn))__
4318 2003-04-11 Havoc Pennington <hp@redhat.com>
4320 * doc/dbus-specification.sgml: fix a spot with the wrong name for
4321 the broadcast service. Use boolean return for ServiceExists.
4323 2003-04-11 Havoc Pennington <hp@redhat.com>
4325 * configure.in: add another directory to look for qt in.
4327 2003-04-11 Havoc Pennington <hp@redhat.com>
4329 * AUTHORS: add Colin Walters
4331 2003-04-11 Havoc Pennington <hp@redhat.com>
4337 2003-04-11 Havoc Pennington <hp@redhat.com>
4339 * bus/messagebus.in: remove pid file when stopping the
4340 message bus, since the bus won't have privileges to remove it
4343 2003-04-11 Havoc Pennington <hp@redhat.com>
4345 * bus/bus.c (bus_context_new): move credentials change after
4348 2003-04-11 Havoc Pennington <hp@pobox.com>
4350 * test/decode-gcov.c: add "below average functions" to the
4351 coverage report, and change how some of the code works.
4353 * bus/test-main.c: bracket some stuff in DBUS_BUILD_TESTS so it's
4354 not in the coverage stats.
4356 * test/test-service.c (main): use _dbus_verbose not fprintf in a
4357 couple places so running the test suite doesn't result in megaspam.
4359 2003-04-11 Havoc Pennington <hp@pobox.com>
4361 * bus/dispatch.c (check_existent_service_activation): accept a no
4362 memory error in a place we didn't before
4364 * bus/test.c (bus_test_run_everything): remove hacky "do it twice
4365 in case the first one failed," since the test suite is less
4368 2003-04-10 Havoc Pennington <hp@pobox.com>
4370 * bus/dispatch.c (check_segfault_service_activation): add test
4371 for launching an executable that just crashes.
4373 * test/test-segfault.c (main): try setting coredumpsize to 0 so we
4374 don't leave a million cores. We'll see how portable this is.
4376 2003-04-10 Havoc Pennington <hp@pobox.com>
4378 * dbus/dbus-spawn.c (_dbus_spawn_async_with_babysitter): move all
4379 the possible parent failures before we fork, so that we don't
4380 fail to create a babysitter after creating the child.
4382 * bus/activation.c (bus_activation_activate_service): kill child
4383 if we don't successfully complete the activation.
4385 2003-04-10 Havoc Pennington <hp@redhat.com>
4387 * dbus/dbus-connection.c (dbus_connection_flush): don't spin on
4388 the connection if it's disconnected
4390 * bus/activation.c (bus_activation_service_created): use new
4391 transaction features to roll back removal of pending activation if
4392 we don't successfully create the service after all. Don't remove
4393 pending activation if the function fails.
4395 * dbus/dbus-list.c (_dbus_list_insert_before_link)
4396 (_dbus_list_insert_after_link): new code to facilitate
4399 * dbus/dbus-hash.c (_dbus_hash_table_insert_string_preallocated):
4400 new functionality, so we can preallocate the ability to insert
4403 * bus/connection.c (bus_transaction_add_cancel_hook): new function
4404 allowing us to put custom hooks in a transaction to be used for
4405 cancelling said transaction
4407 * doc/dbus-specification.sgml: add some discussion of secondary
4408 service owners, and disallow zero-length service names
4410 * bus/services.c (bus_registry_acquire_service): new function,
4411 splits out part of bus_driver_handle_acquire_service() and fixes
4412 a bug where we didn't remove the service doing the acquiring
4413 from the secondary queue if we failed to remove the current owner
4414 from the front of the queue.
4416 2003-04-10 Alexander Larsson <alexl@redhat.com>
4418 * doc/dbus-specification.sgml:
4419 s/org.freedesktop.Broadcast/org.freedesktop.DBus.Broadcast/
4421 2003-04-10 Alexander Larsson <alexl@redhat.com>
4426 Added files to cvsignore
4428 * dbus/dbus-message.h:
4429 * dbus/dbus-message.c: (dbus_message_iter_get_named):
4430 Make get_named() take two out argument and return a boolean.
4431 (dbus_message_iter_get_args_valist):
4432 Update usage of get_named().
4433 (dbus_message_iter_append_byte):
4435 (dbus_message_iter_append_named)
4437 (message_iter_test), (check_message_handling_type), (_dbus_message_test):
4440 2003-04-10 Alexander Larsson <alexl@redhat.com>
4442 * dbus/dbus-marshal.[ch]:
4443 Add array_type_pos argument to _dbus_marshal_validate_arg.
4444 Let you pass a NULL end_pos to _dbus_marshal_validate_type.
4446 * dbus/dbus-message.[ch]:
4447 Multi-dimensional arrays have full type specification in the
4448 outermost array. Iter code re-arranged to handle this.
4449 Added some more iter tests.
4451 * doc/dbus-specification.sgml:
4454 Update new array encoding description.
4455 Correct DBUS_SERVICE_FLAGS_REPLACE_EXISTING description.
4457 * test/data/invalid-messages/array-with-mixed-types.message:
4458 * test/data/valid-messages/array-of-array-of-uint32.message:
4459 Change to the new array format.
4461 * test/data/invalid-messages/too-short-dict.message:
4464 * test/data/valid-messages/recursive-types.message:
4465 Fix up and extend test.
4467 2003-04-10 Havoc Pennington <hp@pobox.com>
4469 * bus/dispatch.c: lots of fixes
4471 * dbus/dbus-mainloop.c (_dbus_loop_dispatch): export
4472 (_dbus_loop_iterate): remove old "quit if no callbacks" code,
4473 that was crack, broke the test service.
4475 * dbus/dbus-transport.c (_dbus_transport_open): fix error
4476 handling to avoid piling up errors if we get a failure on the
4479 * dbus/dbus-internals.c (_dbus_real_assert_not_reached): include
4480 pid in assertion failures.
4482 * dbus/dbus-mainloop.c (_dbus_loop_iterate): use static arrays up
4483 to some fixed size of file descriptor array. Don't return TRUE
4484 anytime a timeout exists, that led to lots of busy loop silliness
4487 2003-04-09 Havoc Pennington <hp@redhat.com>
4489 * dbus/dbus-mainloop.c (check_timeout): fix timeouts, I thought
4490 I'd checked this in earlier but hadn't.
4492 2003-04-09 Havoc Pennington <hp@redhat.com>
4494 * bus/dispatch.c (bus_dispatch_test): get a bit further through
4495 the activation test (man this is getting old!)
4497 2003-04-09 Havoc Pennington <hp@redhat.com>
4499 * test/test-utils.c: use dispatch status function to fix this up
4501 * bus/connection.c (connection_watch_callback): don't dispatch
4503 (connection_timeout_callback): don't dispatch from here
4504 (bus_connections_setup_connection): set the dispatch status function
4505 (bus_connection_disconnected): unset it
4507 * dbus/dbus-mainloop.c (_dbus_loop_queue_dispatch): new function
4508 used to add a connection to be dispatched
4509 (_dbus_loop_iterate): do the dispatching at the end of each
4512 * dbus/dbus-connection.c
4513 (dbus_connection_set_dispatch_status_function): new function
4514 allowing us to fix up main loop usage
4515 (_dbus_connection_last_unref): free all the various function
4517 (dbus_connection_dispatch): call the DispatchStatusFunction
4518 whenever this function returns
4519 (dbus_connection_handle_watch): call DispatchStatusFunction
4520 (dbus_connection_send_with_reply_and_block): call DispatchStatusFunction
4521 (reply_handler_timeout): call DispatchStatusFunction
4522 (dbus_connection_flush): call DispatchStatusFunction
4524 2003-04-09 Havoc Pennington <hp@redhat.com>
4526 * dbus/dbus-bus.c (dbus_bus_register): fix up error handling and
4529 * bus/dispatch.c (check_service_activated): fix bug in test
4531 * dbus/dbus-mainloop.c (check_timeout): fix this up
4533 * dbus/dbus-internals.c (_dbus_verbose_real): include PID in
4534 verbose output so we can sort out output from different processes,
4535 e.g. in the activation case.
4537 2003-04-08 Colin Walters <walters@gnu.org>
4539 * bus/bus.c (struct BusContext) [pidfile]: New member, to store
4541 (bus_context_new): Set it.
4542 (bus_context_unref): Use it to delete the pid file.
4544 2003-04-08 Havoc Pennington <hp@redhat.com>
4546 * test/data/invalid-messages/array-with-mixed-types.message:
4547 regression test that fails for the moment
4549 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): reorder
4550 tests for convenience
4552 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): don't allow
4553 array of nil, it broke things.
4555 * test/data/invalid-messages/array-of-nil.message: regression test
4557 * test/data/valid-messages/array-of-array-of-uint32.message:
4558 happened to write this so added it to suite
4560 2003-04-08 Havoc Pennington <hp@redhat.com>
4562 * bus/driver.c (bus_driver_handle_acquire_service): init
4563 retval/reply before checking name
4565 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add a
4566 recursion depth argument
4568 * dbus/dbus-message.h (struct DBusMessageIter): put some padding
4569 in the public struct for future extension
4571 * dbus/dbus-message-builder.c (_dbus_message_data_load): fix
4574 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix a verbose
4577 * doc/dbus-specification.sgml: fix typo
4579 2003-04-08 Alexander Larsson <alexl@redhat.com>
4581 Implemented recursive types, named types and new-style iters
4584 * glib/test-thread-client.c: (thread_func):
4585 * glib/test-thread-server.c: (handle_test_message):
4586 * test/test-service.c: (handle_echo):
4595 * dbus/dbus-internals.c: (_dbus_type_to_string):
4596 Update for new types.
4598 * dbus/dbus-marshal.[ch]:
4599 Implement recursive types and the new marshalling format.
4600 Remove hardcoded dict marshalling.
4601 Marshal named types.
4603 * dbus/dbus-message-builder.c:
4605 Remove references to old types
4607 * dbus/dbus-message.[ch]:
4608 New non-refcounted iter API that supports recursive iters.
4609 Use iters for appending, including support for recursive
4611 Add byte and named type support.
4612 Update everything to new marshalling formats.
4613 Add tests for new API.
4615 * dbus/dbus-protocol.h:
4616 Remove old array types.
4617 Add types: BYTE, ARRAY, DICT, NAMED
4619 * dbus/dbus-string.c:
4620 * dbus/dbus-sysdeps.c:
4621 Make parse_double locale safe.
4623 * dbus/dbus-test-main.c:
4629 * doc/dbus-specification.sgml:
4632 * test/data/incomplete-messages/missing-body.message:
4633 * test/data/invalid-messages/bad-boolean.message:
4634 * test/data/invalid-messages/bad-boolean-array.message:
4635 * test/data/invalid-messages/boolean-array-length-too-long.message-raw:
4636 * test/data/invalid-messages/boolean-has-no-value.message-raw:
4637 * test/data/invalid-messages/too-short-dict.message:
4638 * test/data/valid-messages/dict-simple.message:
4639 * test/data/valid-messages/dict.message:
4640 * test/data/valid-messages/emptiness.message:
4641 * test/data/valid-messages/lots-of-arguments.message:
4642 * test/data/valid-messages/no-padding.message:
4643 * test/data/valid-messages/recursive-types.message:
4644 Add missing NAME fields
4645 Fix up dicts & arrays
4647 * test/data/invalid-messages/dict-with-nil-value.message:
4648 Removed, this is not invalid anymore.
4650 * test/data/valid-messages/recursive-types.message:
4651 Add new test for deeply recursive types.
4653 2003-04-07 Havoc Pennington <hp@pobox.com>
4655 * bus/driver.c (bus_driver_handle_acquire_service): return an
4656 error if you try to acquire a service that starts with ':'
4658 2003-04-07 Havoc Pennington <hp@redhat.com>
4660 * doc/dbus-specification.sgml: require that base service names
4661 start with ':' and that the base service is created/deleted
4662 as first and last things a connection does on the bus
4664 * bus/dispatch.c (check_existent_service_activation): lots more
4665 work on the activation test; it doesn't fully pass yet...
4667 * test/test-service.c (main): fix so we don't memleak the
4668 connection to the message bus
4669 (filter_func): accept a message asking us to exit
4671 2003-04-06 Havoc Pennington <hp@pobox.com>
4673 * qt/Makefile.am (dbusinclude_HEADERS): install dbus-qt.h,
4676 * configure.in: fixes to Qt detection from Colin Walters
4678 * doc/Makefile.am: Only remove generated docbook dirs if they
4679 exist, from Colin Walters
4681 * dbus/dbus-bus.c: change how we set well-known connections to
4682 NULL, so that it works if a single connection is stored in
4683 two well-known array slots.
4685 * test/Makefile.am: remove a lot of stuff that isn't immediately
4686 useful, it's in CVS history if we want it.
4688 * test/test-service.c: use dbus-mainloop instead of that
4691 2003-04-06 Havoc Pennington <hp@pobox.com>
4693 * dbus/Makefile.am: split lists of sources into stuff that goes in
4694 the library, util functions that go in the lib and are also used
4695 elsewhere, and util functions that are used in tests/daemon but
4696 don't go in the lib.
4698 * dbus/dbus-mainloop.h, dbus/dbus-mainloop.c: move bus/loop.[hc]
4699 here so it can be used in test binaries also
4701 2003-04-06 Havoc Pennington <hp@pobox.com>
4703 * dbus/dbus-sysdeps.c (_dbus_become_daemon): write the pidfile
4704 here in the parent process, so we can return an error if it
4705 fails. Also, move some of the code into the child so the parent
4706 is less hosed if we fail midway through.
4708 * bus/bus.c (bus_context_new): move pidfile detection further up
4709 in the function, before we start overwriting sockets and such.
4711 * bus/messagebus.in: adjust this a bit, not sure if it will work.
4713 * configure.in: add --with-system-pid-file and --with-system-socket
4715 2003-04-06 Colin Walters <walters@verbum.org>
4717 * configure.in (DBUS_SYSTEM_PID_FILE): New variable.
4719 * bus/system.conf.in: Declare a pidfile.
4721 * bus/bus.c (bus_context_new): Test for an existing pid file, and
4722 create one (if appropriate).
4724 * bus/config-parser.c (enum ElementType) [ELEMENT_PIDFILE]: New.
4725 (struct BusConfigParser) [pidfile]: New.
4726 (element_type_to_name, merge_included, start_busconfig_child)
4727 (bus_config_parser_end_element, bus_config_parser_content): Handle it.
4728 (bus_config_parser_unref): Free it.
4729 (bus_config_parser_get_pidfile): New function.
4731 * bus/config-parser.h (_dbus_write_pid_file): Prototype.
4733 * dbus/dbus-errors.h (DBUS_ERROR_PIDFILE_EXISTS): New error.
4735 * dbus/dbus-sysdeps.c (_dbus_write_pid_file): New function.
4737 * dbus/dbus-sysdeps.h: Prototype it.
4739 2003-04-06 Havoc Pennington <hp@pobox.com>
4741 * bus/bus.c (bus_context_new): print the address in here, rather
4742 than in main(), because we need to do it before forking the daemon
4744 * bus/dispatch.c (send_service_nonexistent_error): set the sender
4745 on the service nonexistent error
4747 * bus/driver.c (bus_driver_handle_acquire_service): set the
4748 sender on the AcquireService reply
4750 * test/data/valid-config-files/debug-allow-all.conf.in: Make test
4751 server also listen on a UNIX socket so services can connect to it.
4753 2003-04-06 Havoc Pennington <hp@pobox.com>
4755 * dbus/dbus-threads.c: Redo how the fake debug mutexes are done
4756 so it detects deadlocks and also we actually init threads when
4759 2003-04-06 Havoc Pennington <hp@pobox.com>
4761 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
4762 save the domain socket name, and unlink it when we disconnect the
4763 server. Means that at least when we exit normally, we won't leave
4764 a bunch of junk in /tmp
4766 * dbus/dbus-transport-unix.c
4767 (_dbus_transport_new_for_domain_socket): code cleanup (nicer
4768 memory management). (I was making a real change here but then
4771 2003-04-06 Havoc Pennington <hp@pobox.com>
4773 * bus/bus.c (bus_context_new): fix wrong handling of
4774 server_data_slot_unref() in the error case.
4776 * dbus/dbus-internals.h (_dbus_assert): change so it passes
4777 "(condition) != 0" to _dbus_real_assert so that
4778 "_dbus_assert (pointer)" doesn't cause a warning
4780 * bus/main.c (main): accept --print-address option to print out
4781 the message bus address
4783 * dbus/dbus-sysdeps.c (_dbus_generate_random_ascii): export this
4785 * dbus/dbus-transport.c (_dbus_transport_open): special error for
4786 "tmpdir" option to unix: address on client side
4788 * dbus/dbus-server.c (dbus_server_listen): handle "tmpdir" option
4791 * configure.in (TEST_SOCKET_DIR): locate a temporary directory
4792 we can use to create sockets in the test suite.
4794 * bus/main.c (signal_handler): on SIGTERM, exit the daemon
4795 cleanly. To be used for testing.
4797 * dbus/dbus-spawn.c (babysit): use _dbus_set_signal_handler()
4799 * dbus/dbus-sysdeps.c (_dbus_set_signal_handler): new
4801 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
4802 handle trying to call this when there's no servers active
4804 2003-04-05 Havoc Pennington <hp@pobox.com>
4810 2003-04-05 Havoc Pennington <hp@pobox.com>
4812 * bus/bus.c (setup_server): fix this so dbus-daemon-1 doesn't
4813 crash on startup. Need to get "try starting the daemon"
4814 in the test suite I guess. ;-)
4816 * dbus/dbus-server.h, dbus/dbus-server.c: remove the stuff that
4817 tracked the number of open connections; it's better done in
4818 application-specific code as you want it to span all servers etc.
4820 2003-04-05 Havoc Pennington <hp@pobox.com>
4822 * bus/Makefile.am (install-data-hook): add missing DESTDIR,
4823 patch from Colin Walters
4825 2003-04-05 Havoc Pennington <hp@pobox.com>
4827 * doc/config-file.txt (Elements): fix docs of <auth> to reflect
4828 reality; in fact multiple mechanisms are allowed.
4830 * dbus/dbus-internals.c (_dbus_real_assert)
4831 (_dbus_real_assert_not_reached): move guts of _dbus_assert() and
4832 _dbus_assert_not_reached() into functions, so that they don't show
4833 up in basic block counts for test coverage, and don't use up as
4834 much disk space. Does mean slower execution speed though, so
4835 assumes --disable-asserts is the normal production case.
4837 2003-04-05 Havoc Pennington <hp@pobox.com>
4839 * test/Makefile.am (dist-hook): also dist *.in files
4845 2003-04-05 Havoc Pennington <hp@pobox.com>
4847 * dbus/dbus-string.c: docs warning
4849 * dbus/dbus-spawn.c: missing docs
4851 * dbus/dbus-memory.c (struct ShutdownClosure): missing docs
4853 2003-04-05 Havoc Pennington <hp@pobox.com>
4855 * bus/loop.c (bus_loop_iterate): fix the timeout code, using
4858 * dbus/dbus-spawn.c (_dbus_babysitter_unref): set sitter_pid
4859 to -1 once we've reaped the babysitter
4860 (_dbus_babysitter_handle_watch): do as much work as we can, not
4863 * bus/activation.c: add code using DBusBabysitter so that we
4864 handle it when a service fails to start up properly.
4865 (bus_activation_service_created): don't remove the activation
4866 entries as we go, just let them get removed when we free the pending
4867 activation. Unref reply messages after sending them.
4869 2003-04-05 Havoc Pennington <hp@pobox.com>
4871 * test/decode-gcov.c (main): print per-directory stats in the report
4873 * Makefile.am (coverage-report.txt): don't include test/* in gcov stats
4875 2003-04-05 Havoc Pennington <hp@pobox.com>
4877 * Makefile.am (coverage-report.txt): add target "coverage-report.txt"
4879 * test/decode-gcov.c: hack up a little program to suck data
4880 out of gcov files. Yes this is sort of silly.
4882 * configure.in: define something in config.h and do an
4883 AM_CONDITIONAL when gcov is enabled
4885 2003-04-04 Havoc Pennington <hp@redhat.com>
4887 * dbus/dbus-spawn.c, dbus/dbus-spawn.h: Change dbus_spawn to
4888 return a "babysitter" object that is used to monitor the status of
4889 the spawned process and reap it when required.
4891 * test/test-segfault.c, test/test-exit.c,
4892 test/test-sleep-forever.c: binaries that do various lame things,
4893 used in the test suite.
4895 * dbus/dbus-sysdeps.c: kill _dbus_errno_to_string()
4897 2003-04-03 Havoc Pennington <hp@pobox.com>
4899 * dbus/dbus-spawn.c: Move dbus-spawn into a separate file
4900 in preparation for modifying it, dbus-sysdeps is getting
4903 2003-04-03 Havoc Pennington <hp@redhat.com>
4905 * bus/loop.h, bus/loop.c: make the mainloop an object so we can
4908 * bus/*.[hc]: adapt to mainloop change
4910 2003-04-03 Havoc Pennington <hp@redhat.com>
4912 * bus/activation.c (load_directory): fix up memleaks
4913 (bus_activation_entry_free): free the entry
4915 * dbus/dbus-bus.c (dbus_bus_acquire_service): return an error if
4916 we get one from the message bus; fix memleaks.
4918 * dbus/dbus-message.c (dbus_set_error_from_message): new function
4920 2003-04-03 Havoc Pennington <hp@pobox.com>
4922 * bus/config-parser.c (bus_config_parser_unref): free
4923 list of mechanisms, bug discovered by test suite enhancements
4924 (putting system.conf and session.conf into suite)
4926 * test/Makefile.am, test/test-service.c: add placeholder for a
4927 test service that we'll activate as part of test suite. Doesn't
4930 * dbus/dbus-sysdeps.c (_dbus_setenv): support unsetenv by
4931 setting NULL value, and use system malloc not dbus_malloc()
4932 when we have unavoidable memleakage.
4934 * dbus/dbus-bus.c (dbus_bus_get): fix bug where bus type of 0
4935 didn't work, and support DBUS_BUS_ACTIVATION.
4937 * bus/activation.c (child_setup): pass our well-known bus type to
4940 * bus/config-parser.c: support <type> to specify well-known type
4942 * doc/dbus-specification.sgml: document the env variables to
4943 locate well-known buses and find service activator
4945 2003-04-02 Havoc Pennington <hp@redhat.com>
4947 * test/Makefile.am (all-local): add a rule to copy tests to
4948 builddir, so we can have generated tests. Use this to remove the
4949 silly hack for testing system.conf and session.conf. Will use this
4950 shortly to generate .service files pointing to test binaries.
4952 2003-04-02 Havoc Pennington <hp@redhat.com>
4954 * dbus/dbus-string.c (set_length): fix a bug - we allocated max of
4955 current alloc and needed new length, not max of the doubled
4956 allocation and needed new length. Also, when building tests,
4957 don't do the double-allocation stuff, just realloc every time.
4959 2003-04-02 Havoc Pennington <hp@redhat.com>
4961 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): include filenames
4963 (_dbus_string_get_dirname): new
4964 (_dbus_sysdeps_test): new
4965 (_dbus_directory_open): include dirnames in error messages
4967 * bus/config-parser.c: interpret <include> and <includedir> and
4968 <servicedir> relative to config file location if the given
4969 filename is not absolute.
4971 * dbus/dbus-string.c (_dbus_string_find_byte_backward): new
4973 2003-04-02 Havoc Pennington <hp@redhat.com>
4975 * bus/connection.c (bus_transaction_send_error_reply): set sender
4976 service for the error, and unref the reply on success
4978 * bus/activation.c: convert to use BusTransaction so OOM can be
4980 (bus_activation_service_created): set sender of the message
4982 2003-04-01 Havoc Pennington <hp@redhat.com>
4984 * bus/config-parser.c, bus/bus.c: implement <servicedir> and
4985 <includedir> (at least mostly)
4987 * dbus/dbus-sysdeps.c (_dbus_change_identity): set the group ID
4988 first, then the user ID
4990 2003-04-01 Havoc Pennington <hp@pobox.com>
4992 * dbus/dbus-server.c (dbus_server_set_auth_mechanisms): new
4995 * dbus/dbus-auth.c (_dbus_auth_set_mechanisms): new
4997 * dbus/dbus-internals.c (_dbus_dup_string_array): new function
4999 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): chmod the
5000 socket 0777, and unlink any existing socket.
5002 * bus/bus.c (bus_context_new): change our UID/GID and fork if
5003 the configuration file so specifies; set up auth mechanism
5006 * bus/config-parser.c (bus_config_parser_content): add support
5007 for <fork> option and fill in code for <auth>
5009 * bus/system.conf.in: add <fork/> to default configuration,
5010 and limit auth mechanisms to EXTERNAL
5012 * doc/config-file.txt (Elements): add <fork>
5014 * dbus/dbus-sysdeps.c (_dbus_become_daemon): new function
5015 (_dbus_change_identity): new function
5017 2003-03-31 Havoc Pennington <hp@redhat.com>
5019 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket)
5020 (_dbus_listen_unix_socket): fix off-by-one error in null
5021 termination spotted by Nalin
5023 2003-03-31 Havoc Pennington <hp@redhat.com>
5025 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): allow setting
5026 DBUS_TEST_HOMEDIR when tests are enabled, so we can test without
5027 having a real home directory available.
5029 2003-03-31 Havoc Pennington <hp@redhat.com>
5031 * bus/Makefile.am (install-data-hook): create /var/run/dbus
5033 * bus/messagebus.in: add init script for Red Hat /etc/init.d
5035 * configure.in: add support for specifying a style of init script
5038 2003-03-31 Havoc Pennington <hp@redhat.com>
5040 Fix some annoying DBusString API and fix all affected code.
5042 * dbus/dbus-string.c (_dbus_string_init): get rid of annoying
5044 (_dbus_string_get_data): change to return string instead of using
5046 (_dbus_string_get_const_data): ditto
5047 (_dbus_string_get_data_len): ditto
5048 (_dbus_string_get_const_data_len): ditto
5050 2003-03-31 Havoc Pennington <hp@redhat.com>
5052 * bus/main.c (main): fix up the command line arguments to be nicer
5054 2003-03-31 Havoc Pennington <hp@redhat.com>
5056 * dbus/Makefile.am (INCLUDES): use EXPANDED_LOCALSTATEDIR to
5057 define DBUS_SYSTEM_BUS_PATH as we want to compile in the same
5058 final location that lands in the config file
5060 * bus/config-loader-expat.c (bus_config_load): fix type of
5063 * doc/TODO: remove TODO item for dbus_bus_get()
5065 * dbus/dbus-bus.c (bus_data_free): add missing lock/unlock
5067 2003-03-31 Havoc Pennington <hp@pobox.com>
5069 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_domain_socket)
5070 (_dbus_transport_new_for_tcp_socket): these didn't need the "server"
5071 argument since they are always client side
5073 * dbus/dbus-server.c (dbus_server_get_address): new function
5075 * bus/main.c (main): take the configuration file as an argument.
5077 * test/data/valid-config-files/debug-allow-all.conf: new file to
5078 use with dispatch.c tests for example
5080 * bus/test-main.c (main): require test data dir
5082 * bus/bus.c (bus_context_new): change this to take a
5083 configuration file name as argument
5085 * doc/config-file.txt (Elements): add <servicedir>
5087 * bus/system.conf, bus/session.conf: new files
5089 * dbus/dbus-bus.c (dbus_bus_get): look for system bus on
5090 well-known socket if none set
5092 * configure.in: create system.conf and session.conf
5094 2003-03-30 Havoc Pennington <hp@pobox.com>
5096 * bus/config-parser.c: hacking
5098 * dbus/dbus-memory.c: don't use DBusList for the list of stuff
5099 to shut down, since it could cause weirdness with the DBusList
5102 * dbus/dbus-list.c (_dbus_list_test): add tests for the
5103 link-oriented stack routines
5104 (alloc_link): free the mempool if the first alloc from it fails
5106 * dbus/dbus-mempool.c (struct DBusMemBlock): fix alignment issue
5108 * dbus/dbus-string.c (UNICODE_VALID): sync new version of this
5110 (_dbus_string_skip_white): new
5112 * doc/config-file.txt (Elements): add <includedir>
5114 2003-03-28 Havoc Pennington <hp@pobox.com>
5116 * dbus/dbus-string.c (_dbus_string_copy_data_len)
5117 (_dbus_string_copy_data): new functions
5119 2003-03-28 Anders Carlsson <andersca@codefactory.se>
5121 * dbus/dbus-bus.c: (bus_data_free), (dbus_bus_get):
5125 * dbus/dbus-memory.c:
5128 2003-03-28 Havoc Pennington <hp@pobox.com>
5130 * bus/test.c (bus_test_flush_bus): remove the sleep from here,
5131 I think it may have just been superstition. Not sure.
5133 * dbus/dbus-string.c (_dbus_string_base64_decode): catch some OOM
5134 failures that were not being handled.
5136 * dbus/dbus-auth.c (process_auth): fix a memleak in OOM handling
5138 * dbus/dbus-memory.c: add ability to set number of mallocs in a
5139 row that will fail on out-of-memory.
5141 * dbus/dbus-internals.c (_dbus_test_oom_handling): convenience
5142 function for testing out-of-memory handling.
5144 * bus/config-loader-expat.c (memsuite): don't wrap the dbus
5145 allocation functions, they do map exactly to the expat ones.
5147 2003-03-27 Havoc Pennington <hp@redhat.com>
5149 * bus/config-loader-libxml.c (bus_config_load): add another error
5152 2003-03-26 Anders Carlsson <andersca@codefactory.se>
5155 Add note about automatic service activation.
5157 * doc/dbus-specification.sgml:
5158 Rename the specification and clarify a few things.
5160 2003-03-26 Anders Carlsson <andersca@codefactory.se>
5163 * dbus/dbus-address.c:
5165 * dbus/dbus-marshal.c:
5166 * dbus/dbus-server-debug-pipe.c:
5167 * dbus/dbus-transport-unix.c:
5168 Fix documentation warnings.
5170 2003-03-26 Havoc Pennington <hp@pobox.com>
5172 * bus/test-main.c, dbus/dbus-test.c (main): check memleaks
5173 after every test so it's quick and easy to see which leaked, and
5174 so we test multiple dbus_shutdown() calls
5176 * configure.in: change configure.in XML stuff to also support
5179 * config-loader-libxml.c: some hacking
5181 * config-loader-expat.c: some hacking
5183 * config-parser.c: some hacking, plus tests
5185 2003-03-25 Havoc Pennington <hp@redhat.com>
5187 * throughout - add more _DBUS_ASSERT_ERROR_IS_CLEAR
5189 * configure.in: add --with-xml option to specify XML library,
5190 right now only libxml is supported.
5192 * bus/config-loader-libxml.c, config-parser.c: sync some minor
5193 nonworking code between home and work, still just stubs
5195 2003-03-24 Havoc Pennington <hp@redhat.com>
5197 * dbus/dbus-sysdeps.c (_dbus_set_fd_nonblocking): move to this
5200 * dbus/dbus-errors.c (dbus_set_error, dbus_set_error_const): allow
5201 NULL argument for "message" if the error is a well-known one,
5202 fill in a generic message in this case.
5204 * dbus/dbus-errors.h (DBusResultCode): Kill DBusResultCode in
5207 * bus/test.c (bus_test_flush_bus): add
5209 * bus/policy.c (bus_policy_test): test code stub
5211 2003-03-24 Havoc Pennington <hp@pobox.com>
5213 * bus/connection.c (bus_connections_setup_connection): set up
5214 the "can this user connect" function, but it always returns
5215 TRUE until we have a config file parser so we can have a config
5216 file that allows connections.
5218 2003-03-23 Havoc Pennington <hp@pobox.com>
5220 * dbus/dbus-threads.c (dbus_mutex_new, dbus_condvar_new): with
5221 DBUS_BUILD_TESTS, actually alloc/free a block of memory for
5222 the mutex, so we can check for proper memory management
5225 * dbus/dbus-dataslot.c: remove the mutex from
5226 DBusDataSlotAllocator and lock it manually when using it,
5227 to simplify fitting it into the global slots framework.
5229 * dbus/dbus-threads.c (init_static_locks): rework how we're
5230 handling global locks so they are easily shut down.
5232 * bus/policy.c (bus_policy_append_rule): fix
5234 * bus/test-main.c (main): check for memleaks
5236 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): make
5237 test suite check for memleaks
5239 * dbus/dbus-memory.c: add support in test mode for tracking
5240 number of outstanding blocks
5242 2003-03-23 Havoc Pennington <hp@pobox.com>
5244 * bus/policy.c, bus/bus.c, bus/connection.c: implement allow/deny
5247 * dbus/dbus-hash.h: add ULONG hash keys
5249 * dbus/dbus-sysdeps.c (_dbus_get_groups): new
5250 (_dbus_get_group_id): new function
5252 2003-03-20 Havoc Pennington <hp@redhat.com>
5254 * dbus/dbus-connection.c (dbus_connection_set_unix_user_function):
5256 (dbus_connection_get_unix_user): new function
5258 2003-03-20 Havoc Pennington <hp@pobox.com>
5260 * bus/connection.c (bus_connection_send_oom_error): assert that
5261 message has a sender
5262 (connection_execute_transaction): ditto
5263 (bus_connection_preallocate_oom_error): fix to set the sender, and
5264 set recipient to the destination service, not the bus driver
5266 * bus/policy.c: hacking
5268 * dbus/dbus-message.c (dbus_message_service_is): new function
5269 (dbus_message_sender_is): new
5271 2003-03-19 Havoc Pennington <hp@redhat.com>
5273 * bus/policy.c: start sketching code for policy restrictions on
5274 what connections can do.
5276 2003-03-18 Havoc Pennington <hp@redhat.com>
5278 * doc/TODO: some notes on high-level todo items. Little nitpick
5279 stuff is all in @todo, so no need to add it here.
5281 * doc/config-file.txt: some notes on how config file might look
5283 2003-03-18 Anders Carlsson <andersca@codefactory.se>
5289 2003-03-17 Havoc Pennington <hp@redhat.com>
5291 * dbus/dbus-internals.h: add gcc attributes so that
5292 our printf-style functions warn on bad arguments to
5295 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): fix printf
5298 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
5301 2003-03-17 Havoc Pennington <hp@redhat.com>
5303 * bus/test-main.c (main): make it print something as it runs
5304 so make check doesn't look stuck
5306 * doc/negotiation.txt, doc/dbus-sasl-profile.txt: remove
5307 from CVS, now obsolete
5309 2003-03-17 Anders Carlsson <andersca@codefactory.se>
5311 * bus/dispatch.c: (bus_dispatch):
5312 Refetch the service name since it may have been reallocated
5313 when dbus_message_set_sender was called.
5315 * dbus/dbus-sysdeps.c: (_dbus_accept):
5316 Add address and address length variables and use them to stop
5317 valgrind from complaining.
5319 2003-03-17 Havoc Pennington <hp@pobox.com>
5321 All tests pass, no memleaks, no valgrind complaints.
5323 * bus/test.c: refcount handler_slot
5325 * bus/connection.c (bus_connections_new): refcount
5326 connection_data_slot
5328 * dbus/dbus-auth-script.c (_dbus_auth_script_run): delete unused
5329 bytes so that auth scripts pass.
5331 * bus/dispatch.c: init message_handler_slot so it gets allocated
5334 * bus/dispatch.c (message_handler_slot_ref): fix memleak
5336 * dbus/dbus-server-debug-pipe.c (_dbus_server_debug_pipe_new):
5337 dealloc server_pipe_hash when no longer used for benefit of
5340 * dbus/dbus-auth.c (process_command): memleak fix
5342 * bus/dispatch.c (check_hello_message): memleak fix
5344 2003-03-16 Havoc Pennington <hp@pobox.com>
5346 * dbus/dbus-bus.c (ensure_bus_data): fix double-unref of the data slot
5348 2003-03-17 Anders Carlsson <andersca@codefactory.se>
5350 * bus/activation.c (bus_activation_activate_service): Append
5351 the pending activation entry to the list of pending activations.
5353 2003-03-16 Havoc Pennington <hp@pobox.com>
5355 * bus/dispatch.c (bus_dispatch_test): remove double-unrefs of
5358 * dbus/dbus-address.c (create_entry): fix OOM handling when
5359 failing to alloc entry->method
5361 2003-03-16 Havoc Pennington <hp@pobox.com>
5363 * dbus/dbus-watch.c (_dbus_watch_new): handle failure to malloc
5366 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
5367 add some missing dbus_set_result
5369 * bus/dispatch.c (bus_dispatch_add_connection): handle failure to
5370 alloc the DBusMessageHandler
5372 * dbus/dbus-transport.c (_dbus_transport_disconnect): don't ref
5373 the transport here, since we call this from the finalizer; it
5374 resulted in a double-finalize.
5376 * dbus/dbus-transport.c (_dbus_transport_disconnect): fix a bug
5377 where we tried to use transport->connection that was NULL,
5378 happened when transport was disconnected early on due to OOM
5380 * bus/*.c: adapt to handle OOM for watches/timeouts
5382 * dbus/dbus-transport-unix.c: port to handle OOM during
5385 * dbus/dbus-auth.c (_dbus_auth_get_unused_bytes): return a
5386 reference to unused bytes instead of a copy
5388 * dbus/dbus-server.c (dbus_server_handle_watch): return FALSE for
5391 * dbus/dbus-connection.c (dbus_connection_handle_watch): return
5394 * dbus/dbus-timeout.c (dbus_timeout_handle): return FALSE for out
5397 2003-03-16 Anders Carlsson <andersca@codefactory.se>
5399 * doc/dbus-specification.sgml:
5400 Document reply message for ActivateService.
5402 2003-03-16 Anders Carlsson <andersca@codefactory.se>
5404 * bus/activation.c: (bus_pending_activation_entry_free),
5405 (bus_pending_activation_free), (bus_activation_new),
5406 (bus_activation_unref), (bus_activation_service_created),
5407 (bus_activation_activate_service):
5409 * bus/bus.c: (bus_context_new):
5410 * bus/desktop-file.c: (new_section):
5411 * bus/driver.c: (bus_driver_send_service_deleted),
5412 (bus_driver_handle_activate_service):
5413 * bus/services.c: (bus_registry_new), (bus_registry_ensure):
5415 * dbus/dbus-connection.c:
5416 (dbus_connection_send_with_reply_and_block):
5417 * dbus/dbus-message.c: (dbus_message_append_args_valist):
5418 * dbus/dbus-protocol.h:
5419 Make activation work better. Now pending activations will be queued
5420 and the daemon won't try to activate services that are already registered.
5422 2003-03-16 Havoc Pennington <hp@pobox.com>
5424 * dbus/dbus-bus.c (ensure_bus_data): handle failure to set
5427 * dbus/dbus-memory.c (_dbus_initialize_malloc_debug): support
5428 DBUS_MALLOC_BACKTRACES to print trace when failing an alloc
5430 2003-03-16 Havoc Pennington <hp@pobox.com>
5432 * dbus/dbus-string.c (_dbus_string_validate_utf8): oops, unbreak
5433 this. always run the test suite before commit...
5435 * bus/*: adapt to DBusConnection API changes
5437 * glib/dbus-gmain.c: adapt to DBusConnection API changes,
5438 requires renaming stuff to avoid dbus_connection_dispatch name
5441 * dbus/dbus-transport.c (_dbus_transport_queue_messages): new
5444 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
5445 separate from _dbus_message_loader_return_buffer()
5447 * dbus/dbus-connection.c (dbus_connection_get_n_messages): remove
5448 this, because it's now always broken to use; the number of
5449 messages in queue vs. the number still buffered by the message
5450 loader is undefined/meaningless. Should use
5451 dbus_connection_get_dispatch_state().
5452 (dbus_connection_dispatch): rename from
5453 dbus_connection_dispatch_message
5455 2003-03-16 Havoc Pennington <hp@pobox.com>
5457 * dbus/dbus-string.c (_dbus_string_validate_utf8): copy in a real
5460 2003-03-16 Anders Carlsson <andersca@codefactory.se>
5462 * dbus/dbus-connection.c:
5463 (dbus_connection_send_with_reply_and_block):
5464 Decrease connection->n_incoming when removing an entry
5466 * dbus/dbus-dict.c: (dbus_dict_entry_free),
5467 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
5468 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
5469 (dbus_dict_set_byte_array), (dbus_dict_set_string_array),
5470 (dbus_dict_get_boolean_array), (dbus_dict_get_double_array),
5471 (dbus_dict_get_byte_array):
5472 Handle NULL arrays and strings. Also add support for byte arrays.
5474 * dbus/dbus-marshal.c: (_dbus_marshal_byte_array),
5475 (_dbus_marshal_dict), (_dbus_demarshal_byte_array),
5476 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
5477 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
5478 (_dbus_demarshal_dict), (demarshal_and_validate_len),
5479 (_dbus_marshal_validate_arg), (_dbus_marshal_test):
5480 * dbus/dbus-marshal.h:
5481 Add support for marshalling and demarshalling empty arrays and strings.
5483 * dbus/dbus-message.c: (dbus_message_append_args_valist),
5484 (dbus_message_append_string_array),
5485 (dbus_message_iter_get_boolean),
5486 (dbus_message_iter_get_boolean_array),
5487 (dbus_message_iter_get_int32_array),
5488 (dbus_message_iter_get_uint32_array),
5489 (dbus_message_iter_get_double_array),
5490 (dbus_message_iter_get_byte_array),
5491 (dbus_message_iter_get_string_array), (dbus_message_iter_get_dict),
5492 (check_message_handling):
5493 Add support for getting empty arrays and dicts.
5495 * dbus/dbus-string.c: (_dbus_string_validate_utf8):
5496 Don't do any validation at all for now, that's better than just checking
5499 * test/data/valid-messages/emptiness.message:
5500 New test message with lots of empty arrays.
5502 2003-03-16 Havoc Pennington <hp@pobox.com>
5504 * dbus/dbus-connection.c
5505 (_dbus_connection_queue_received_message_link): new function that
5506 can't fail due to OOM
5508 * dbus/dbus-message.c (_dbus_message_loader_pop_message_link):
5509 new function pops a message together with a list link
5512 * dbus/dbus-transport-unix.c (queue_messages): use new link-based
5513 message queuing functions to avoid needing to alloc memory
5515 2003-03-16 Havoc Pennington <hp@pobox.com>
5517 Oops - test code was only testing failure of around 30 of the
5518 mallocs in the test path, but it turns out there are 500+
5519 mallocs. I believe this was due to misguided linking setup such
5520 that there was one copy of dbus_malloc etc. in the daemon and one
5521 in the shared lib, and only daemon mallocs were tested. In any
5522 case, the test case now tests all 500+ mallocs, and doesn't pass
5523 yet, though there are lots of fixes in this patch.
5525 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
5526 this so that it doesn't need to allocate memory, since it
5527 has no way of indicating failure due to OOM (and would be
5528 annoying if it did).
5530 * dbus/dbus-list.c (_dbus_list_pop_first_link): new function
5532 * bus/Makefile.am: rearrange to create two self-contained
5533 libraries, to avoid having libraries with overlapping symbols.
5534 that was resulting in weirdness, e.g. I'm pretty sure there
5535 were two copies of global static variables.
5537 * dbus/dbus-internals.c: move the malloc debug stuff to
5540 * dbus/dbus-list.c (free_link): free list mempool if it becomes
5543 * dbus/dbus-memory.c (_dbus_disable_mem_pools): new function
5545 * dbus/dbus-address.c (dbus_parse_address): free list nodes
5548 * bus/dispatch.c (bus_dispatch_add_connection): free
5549 message_handler_slot when no longer using it, so
5550 memory leak checkers are happy for the test suite.
5552 * dbus/dbus-server-debug-pipe.c (debug_finalize): free server name
5554 * bus/bus.c (new_connection_callback): disconnect in here if
5555 bus_connections_setup_connection fails.
5557 * bus/connection.c (bus_connections_unref): fix to free the
5559 (bus_connections_setup_connection): if this fails, don't
5560 disconnect the connection, just be sure there are no side
5563 * dbus/dbus-string.c (undo_alignment): unbreak this
5565 * dbus/dbus-auth.c (_dbus_auth_unref): free some stuff we were
5567 (_dbus_auth_new): fix the order in which we free strings
5570 * bus/connection.c (bus_connection_disconnected): fix to
5571 not send ServiceDeleted multiple times in case of memory
5574 * dbus/dbus-bus.c (dbus_bus_get_base_service): new function to
5575 get the base service name
5576 (dbus_bus_register_client): don't return base service name,
5577 instead store it on the DBusConnection and have an accessor
5579 (dbus_bus_register_client): rename dbus_bus_register()
5581 * bus/dispatch.c (check_hello_message): verify that other
5582 connections on the bus also got the correct results, not
5583 just the one sending hello
5585 2003-03-15 Havoc Pennington <hp@pobox.com>
5587 Make it pass the Hello handling test including all OOM codepaths.
5588 Now to do other messages...
5590 * bus/services.c (bus_service_remove_owner): fix crash when
5591 removing owner from an empty list of owners
5592 (bus_registry_ensure): don't leave service in the list of
5593 a connection's owned services if we fail to put the service
5596 * bus/connection.c (bus_connection_preallocate_oom_error): set
5597 error flag on the OOM error.
5599 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
5600 handle _dbus_transport_set_connection failure
5602 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd): modify
5603 to create watches up front and simply enable/disable them as
5605 (unix_connection_set): this can now fail on OOM
5607 * dbus/dbus-timeout.c, dbus/dbus-watch.c: add concept
5608 of enabling/disabling a watch or timeout.
5610 * bus/loop.c (bus_loop_iterate): don't touch disabled
5613 * glib/dbus-gmain.c: adapt to enable/disable watches and timeouts
5615 2003-03-15 Havoc Pennington <hp@pobox.com>
5617 * bus/dispatch.c (bus_dispatch_test): OK, now finally actually
5618 write useful test code, after all that futzing around ;-)
5620 Test does not yet pass because we can't handle OOM in
5621 _dbus_transport_messages_pending (basically,
5622 dbus_connection_preallocate_send() does not prealloc the write
5623 watch). To fix this, I think we need to add new stuff to
5624 set_watch_functions, namely a SetEnabled function so we can alloc
5625 the watch earlier, then enable it later.
5627 * dbus/Makefile.am (libdbus_convenience_la_SOURCES): move
5628 dbus-memory.c to the convenience lib
5630 * bus/test.c: rename some static functions to keep them clearly
5631 distinct from stuff in connection.c. Handle client disconnection.
5633 2003-03-14 Havoc Pennington <hp@pobox.com>
5635 * bus/dispatch.c (bus_dispatch_test): do test using debug-pipe
5636 transport, tests more of the real codepath. Set up clients
5637 with bus_setup_debug_client.
5639 * bus/test.c (bus_setup_debug_client): function to set up debug
5640 "clients" on the main loop
5642 * dbus/dbus-transport.c (_dbus_transport_open): add debug-pipe
5645 * dbus/dbus-server.c (dbus_server_listen): add debug-pipe
5648 * dbus/dbus-server-debug.c: support a debug server based on pipes
5650 * dbus/dbus-sysdeps.c (_dbus_full_duplex_pipe): new function
5651 (_dbus_close): new function
5653 * configure.in: check for socketpair
5655 2003-03-14 Havoc Pennington <hp@redhat.com>
5657 * dbus/dbus-memory.c: add a "detect buffer overwrites on free"
5660 * dbus/dbus-transport-debug.c: rework this a good bit to be
5661 less complicated. hopefully still works.
5663 * dbus/dbus-server-debug.c (handle_new_client): remove timeout
5666 * glib/dbus-gmain.c (timeout_handler): don't remove timeout
5669 * dbus/dbus-message.c (dbus_message_copy): rename from
5670 dbus_message_new_from_message, fix it up to copy
5671 all the message fields, add test case
5673 * bus/dispatch.c (bus_dispatch_test): add some more test code,
5674 not quite passing yet
5676 2003-03-14 Havoc Pennington <hp@pobox.com>
5678 * bus/loop.c (bus_loop_iterate): add this so we can "run loop
5679 until no work remains" in test code. (the large diff here
5680 is just code movement, no actual changes)
5682 * dbus/dbus-server-debug.c (DEFAULT_INTERVAL): change interval to
5683 1, no point waiting around for test code.
5684 (_dbus_server_debug_accept_transport): unref the timeout
5685 after adding it (right?)
5687 * dbus/dbus-transport-debug.c (DEFAULT_INTERVAL): ditto
5689 2003-03-13 Havoc Pennington <hp@redhat.com>
5691 * dbus/dbus-timeout.c (_dbus_timeout_list_set_functions): handle
5694 * dbus/dbus-watch.c (_dbus_watch_list_set_functions): handle out
5697 * dbus/dbus-connection.h: Make AddWatchFunction and
5698 AddTimeoutFunction return a bool so they can fail on out-of-memory
5700 * bus/bus.c (bus_context_new): set up timeout handlers
5702 * bus/connection.c (bus_connections_setup_connection): set up
5705 * glib/dbus-gmain.c: adapt to the fact that set_functions stuff
5708 * bus/bus.c (bus_context_new): adapt to changes
5710 * bus/connection.c: adapt to changes
5712 * test/watch.c: adapt to DBusWatch changes
5714 * bus/dispatch.c (bus_dispatch_test): started adding this but
5717 2003-03-14 Anders Carlsson <andersca@codefactory.se>
5719 * bus/dispatch.c (send_service_nonexistent_error): Fix typo.
5721 2003-03-13 Havoc Pennington <hp@pobox.com>
5723 * bus/test.c, bus/test.h, bus/Makefile.am, bus/test-main.c:
5724 set up a test framework as for the library
5726 2003-03-12 Havoc Pennington <hp@pobox.com>
5728 Throughout: purge global variables, introduce BusActivation,
5729 BusConnections, BusRegistry, etc. objects instead.
5731 * bus/bus.h, bus/bus.c: introduce BusContext as a global
5734 * test/Makefile.am (TEST_BINARIES): disable bus-test for now,
5735 going to redo this a bit differently I think
5737 2003-03-12 Havoc Pennington <hp@redhat.com>
5739 Mega-patch that gets the message bus daemon initially handling
5740 out-of-memory. Work still needed. Also lots of random
5741 moving stuff to DBusError instead of ResultCode.
5743 * dbus/dbus-list.c (_dbus_list_length_is_one): new function
5745 * dbus/dbus-connection.c
5746 (dbus_connection_send_with_reply_and_block): use DBusError
5748 * dbus/dbus-bus.c: adapt to API changes, make it use DBusError not
5751 * dbus/dbus-connection.c (dbus_connection_send): drop the result
5752 code here, as the only failure possible is OOM.
5754 * bus/connection.c (bus_connection_disconnect):
5755 rename bus_connection_disconnected as it's a notification only
5757 * bus/driver.c (bus_driver_handle_acquire_service): don't free
5758 "name" on get_args failure, should be done by get_args;
5759 don't disconnect client for bad args, just return an error.
5760 (bus_driver_handle_service_exists): ditto
5762 * bus/services.c (bus_services_list): NULL-terminate returned array
5764 * bus/driver.c (bus_driver_send_service_lost)
5765 (bus_driver_send_service_acquired): send messages from driver to a
5766 specific client to the client's unique name, not to the broadcast
5769 * dbus/dbus-message.c (decode_header_data): reject messages that
5770 contain no name field
5771 (_dbus_message_get_client_serial): rename to
5772 dbus_message_get_serial and make public
5773 (_dbus_message_set_serial): rename from set_client_serial
5774 (_dbus_message_set_reply_serial): make public
5775 (_dbus_message_get_reply_serial): make public
5777 * bus/connection.c (bus_connection_foreach): allow stopping
5778 iteration by returning FALSE from foreach function.
5780 * dbus/dbus-connection.c (dbus_connection_send_preallocated)
5781 (dbus_connection_free_preallocated_send)
5782 (dbus_connection_preallocate_send): new API for sending a message
5783 without possibility of malloc failure.
5784 (dbus_connection_send_message): rename to just
5785 dbus_connection_send (and same for whole function family)
5787 * dbus/dbus-errors.c (dbus_error_free): make this reinit the error
5789 * dbus/dbus-sysdeps.c (_dbus_exit): new function
5791 * bus/activation.c: handle/return errors
5793 * dbus/dbus-errors.h: add more DBUS_ERROR #define
5795 * dbus/dbus-sysdeps.c (_dbus_directory_open) (_dbus_file_get_contents)
5796 (_dbus_directory_get_next_file): use DBusError instead of DBusResultCode
5797 (_dbus_result_from_errno): move to this file
5799 2003-03-10 Anders Carlsson <andersca@codefactory.se>
5801 * dbus/dbus-marshal.c:
5802 (_dbus_marshal_set_string):
5803 Take a length argument so we can marshal the correct string
5806 (_dbus_marshal_dict), (_dbus_demarshal_dict),
5807 (_dbus_marshal_get_arg_end_pos), (_dbus_marshal_validate_arg),
5808 (_dbus_marshal_test):
5809 * dbus/dbus-marshal.h:
5810 Add support for marshalling and demarshalling dicts.
5812 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
5813 Add support for TYPE DICT.
5815 * dbus/dbus-message.c: (set_string_field):
5816 Adjust header padding.
5818 (dbus_message_append_args_valist), (dbus_message_append_dict),
5819 (dbus_message_get_args_valist), (dbus_message_iter_get_arg_type),
5820 (dbus_message_iter_get_dict), (_dbus_message_loader_return_buffer),
5821 (check_message_handling), (check_have_valid_message):
5822 * dbus/dbus-message.h:
5823 Add functions for setting and getting dicts.
5825 * dbus/dbus-protocol.h:
5831 * doc/dbus-specification.sgml:
5832 Add information about how dicts are marshalled.
5834 * test/data/invalid-messages/dict-with-nil-value.message:
5835 * test/data/invalid-messages/too-short-dict.message:
5836 * test/data/valid-messages/dict-simple.message:
5837 * test/data/valid-messages/dict.message:
5838 Add sample messages containing dicts.
5840 2003-03-08 Anders Carlsson <andersca@codefactory.se>
5842 * dbus/dbus-dict.h: Add DBUS_END_DECLS.
5844 2003-03-07 Anders Carlsson <andersca@codefactory.se>
5847 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
5848 (dbus_dict_get_keys), (insert_entry), (dbus_dict_set_boolean),
5849 (dbus_dict_set_int32), (dbus_dict_set_uint32),
5850 (dbus_dict_set_double), (dbus_dict_set_string),
5851 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
5852 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
5853 (dbus_dict_set_string_array), (_dbus_dict_test):
5855 Fix according to comments from Havoc.
5857 2003-03-06 Michael Meeks <michael@server.home>
5859 * configure.in: if we don't have kde-config, disable have_qt.
5861 2003-03-07 Anders Carlsson <andersca@codefactory.se>
5866 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
5867 (dbus_dict_ref), (dbus_dict_unref), (dbus_dict_contains),
5868 (dbus_dict_remove), (dbus_dict_get_value_type),
5869 (dbus_dict_get_keys), (dbus_dict_put_boolean),
5870 (dbus_dict_put_int32), (dbus_dict_put_uint32),
5871 (dbus_dict_put_double), (dbus_dict_put_string),
5872 (dbus_dict_put_boolean_array), (dbus_dict_put_int32_array),
5873 (dbus_dict_put_uint32_array), (dbus_dict_put_double_array),
5874 (dbus_dict_put_string_array), (dbus_dict_get_boolean),
5875 (dbus_dict_get_int32), (dbus_dict_get_uint32),
5876 (dbus_dict_get_double), (dbus_dict_get_string),
5877 (dbus_dict_get_boolean_array), (dbus_dict_get_int32_array),
5878 (dbus_dict_get_uint32_array), (dbus_dict_get_double_array),
5879 (dbus_dict_get_string_array), (_dbus_dict_test):
5881 Add DBusDict implementation
5883 * dbus/dbus-test.c: (dbus_internal_do_not_use_run_tests):
5887 2003-03-04 Havoc Pennington <hp@pobox.com>
5889 * test/data/auth/*: adapt to changes
5891 * dbus/dbus-auth-script.c (_dbus_auth_script_run): add
5892 USERID_BASE64 and change USERNAME_BASE64 to put in username not
5895 * dbus/dbus-keyring.c (_dbus_keyring_validate_context): prevent
5896 more stuff from being in a context name, to make the protocol
5897 simpler to deal with
5899 * dbus/dbus-errors.c (dbus_error_has_name): new function
5900 (dbus_error_is_set): new function
5902 * dbus/dbus-auth.c: replace DBUS_STUPID_TEST_MECH auth
5903 with DBUS_COOKIE_SHA1, implement DBUS_COOKIE_SHA1
5905 * dbus/dbus-connection.c (dbus_connection_flush): also read
5906 messages during a flush operation
5908 * dbus/Makefile.am: remove dbus-md5 since it isn't currently used.
5910 2003-03-05 Anders Carlsson <andersca@codefactory.se>
5912 * configure.in: Check for gethostbyname on Solaris.
5914 * dbus/dbus-transport.c: (_dbus_transport_open):
5915 Remove duplicate "tcp" entry.
5917 * doc/dbus-specification.sgml:
5918 Clarify some things.
5920 2003-03-05 Anders Carlsson <andersca@codefactory.se>
5922 * dbus/dbus-auth.c: (send_rejected), (process_test_subdir):
5923 * dbus/dbus-keyring.c: (_dbus_keyring_new_homedir),
5924 (_dbus_keyring_test):
5925 * dbus/dbus-md5.c: (_dbus_md5_compute):
5926 * dbus/dbus-sha.c: (_dbus_sha_compute):
5929 2003-03-05 Anders Carlsson <andersca@codefactory.se>
5931 * README: Add some things.
5933 2003-03-04 Anders Carlsson <andersca@codefactory.se>
5935 * dbus/dbus-message.c (dbus_message_append_args_valist): Add a break;
5936 after case DBUS_TYPE_BOOELAN.
5938 2003-03-02 Havoc Pennington <hp@pobox.com>
5940 * test/break-loader.c (randomly_set_extreme_ints): add test that
5941 sets really huge and small integers
5943 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add check
5944 that length of boolean array fits in the string, and that
5945 string has room for boolean value in single-bool case.
5947 * dbus/dbus-message-builder.c (_dbus_message_data_load): add
5948 optional value to "ALIGN" command which is what to fill the
5951 * test/data/valid-messages/no-padding.message: add regression
5952 test for the message padding problem
5954 2003-03-02 Havoc Pennington <hp@pobox.com>
5956 * dbus/dbus-message.c (decode_header_data): fix to always init
5957 message_padding, from Benjamin Dauvergne
5959 2003-03-02 Havoc Pennington <hp@pobox.com>
5965 2003-03-01 Joe Shaw <joe@assbarn.com>
5967 * configure.in: Check for "struct cmsgcred" and try to access its
5968 members for BSD-like unices.
5970 * dbus/dbus-sysdeps.c (read_credentials_byte): Fold this back into
5971 _dbus_read_credentials_unix_socket().
5972 (_dbus_read_credentials_unix_socket): Use recvmsg() instead of
5973 read() for reading the credential byte off the unix socket. Use
5974 struct cmsgcred on systems that support it.
5976 2003-02-27 Alexander Larsson <alexl@redhat.com>
5980 Make gthreads-2.0 dependency optional. Don't build thread test if
5983 2003-02-27 Havoc Pennington <hp@pobox.com>
5985 * dbus/dbus-connection.c
5986 (dbus_connection_send_message_with_reply_and_block): fix doh!
5987 doh! doh! bug that resulted in never removing a reply from the
5988 queue, no wonder we called get_reply_serial so much ;-)
5990 * dbus/dbus-message.c (struct DBusMessage): cache reply serial
5991 and client serial instead of demarshaling them every time
5993 2003-02-27 Havoc Pennington <hp@pobox.com>
5995 * dbus/dbus-marshal.c (_dbus_demarshal_int32): rewrite to be much
5996 more inlined, using dbus-string-private.h, speeds things up
5999 * dbus/dbus-string.c (_dbus_string_free): apply align offset
6000 when freeing the string
6001 (_dbus_string_steal_data): fix for align offset
6002 (undo_alignment): new function
6004 2003-02-26 Havoc Pennington <hp@redhat.com>
6006 All kinds of audit fixes from Owen, plus initial attempt to
6007 handle unaligned memory returned from malloc.
6009 * dbus/dbus-string.c (_dbus_string_init): clamp max length to
6010 leave room for align_offset and nul byte
6011 (fixup_alignment): function to track an align_offset and
6012 ensure real->str is aligned
6013 (DBUS_GENERIC_STRING_PREAMBLE): len must be less than allocated,
6014 to allow a nul byte plus align offset
6015 (_dbus_string_lock): fix overflow issue
6016 (_dbus_string_init_const_len): add assertions on sanity of len,
6017 assign allocated to be ALLOCATION_PADDING larger than len
6018 (set_length): fixup the overflow handling
6019 (_dbus_string_get_data_len): fix overflow in assertion
6020 (open_gap): detect overflow in size of gap to be opened
6021 (_dbus_string_lengthen): add overflow check
6022 (_dbus_string_align_length): fix overflow with _DBUS_ALIGN_VALUE
6023 (_dbus_string_append): add overflow check
6024 (_dbus_string_append_unichar): overflow
6025 (_dbus_string_delete): fix overflow in assertion
6026 (_dbus_string_copy_len): overflow in assertion
6027 (_dbus_string_replace_len): overflows in assertions
6028 (_dbus_string_find): change to implement in terms of
6029 _dbus_string_find_to
6030 (_dbus_string_find_to): assorted fixage
6031 (_dbus_string_equal_c_str): assert c_str != NULL,
6032 fix logic so the function works
6033 (_dbus_string_ends_with_c_str): fix overflow thingy
6034 (_dbus_string_base64_encode): overflow fix
6035 (_dbus_string_validate_ascii): overflow
6036 (_dbus_string_validate_nul): overflow
6038 2003-02-26 Havoc Pennington <hp@redhat.com>
6040 * dbus/dbus-marshal.c (_dbus_marshal_test): fix to work with DISABLE_ASSERTS
6042 2003-02-26 Alexander Larsson <alexl@redhat.com>
6045 Set DBUS_GLIB_THREADS_LIBS for apps using gthread-2.0
6047 * dbus/dbus-connection.c:
6048 * dbus/dbus-connection.h:
6049 Fix _dbus_connection_acquire_io_path and _dbus_connection_acquire_dispatch.
6050 Add dbus_connection_set_wakeup_main_function and use it when queueing
6051 incoming and outgoing messages.
6054 * dbus/dbus-dataslot.c:
6055 Threadsafe usage of DBusDataSlotAllocator
6057 * dbus/dbus-message.c: (dbus_message_get_args_iter):
6060 * dbus/dbus-server-unix.c:
6063 * glib/dbus-gmain.c:
6064 Implement the new wakeup functions for glib.
6067 * glib/test-thread-client.c:
6068 * glib/test-thread-server.c:
6069 * glib/test-thread.h:
6070 Initial cut at some thread test code. Not really done yet.
6072 2003-02-26 Havoc Pennington <hp@pobox.com>
6074 * dbus/dbus-connection.c
6075 (dbus_connection_send_message_with_reply_and_block): fix crash
6076 where we ref'd the outgoing message instead of the returned reply
6078 * dbus/dbus-transport-unix.c (do_authentication): check read watch
6079 at the end of this function, so if we didn't need to read for
6080 authentication, we reinstall it for receiving messages
6082 * dbus/dbus-message.c (dbus_message_new_reply): allow replies to
6083 a NULL sender for peer-to-peer case
6085 * dbus/dbus-transport-unix.c (check_read_watch): handle
6086 !authenticated case correctly
6088 * glib/dbus-gmain.c: add support for DBusServer
6090 * dbus/dbus-server.c: add data slot support
6092 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): check
6093 return values and handle errors
6095 * dbus/dbus-dataslot.c: factor out the data slot stuff from
6098 * Doxyfile.in (INPUT): add glib subdir
6100 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): rename
6101 setup_with_g_main instead of hookup_with_g_main; write docs
6103 2003-02-24 Anders Carlsson <andersca@codefactory.se>
6105 * dbus/dbus-marshal.c: (_dbus_marshal_validate_arg):
6106 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
6107 * dbus/dbus-message.c: (dbus_message_append_boolean),
6108 (dbus_message_append_boolean_array),
6109 (dbus_message_get_args_valist), (_dbus_message_test):
6110 * dbus/dbus-message.h:
6111 * doc/dbus-specification.sgml:
6112 Various fixes as pointed out by Havoc.
6114 * test/data/invalid-messages/bad-boolean-array.message:
6115 * test/data/invalid-messages/bad-boolean.message:
6116 Add invalid boolean value test cases.
6118 2003-02-24 Anders Carlsson <andersca@codefactory.se>
6120 * dbus/dbus-internals.c: (_dbus_type_to_string):
6121 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
6122 (_dbus_marshal_validate_arg):
6123 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
6124 * dbus/dbus-message.c: (dbus_message_append_args_valist),
6125 (dbus_message_append_boolean), (dbus_message_append_boolean_array),
6126 (dbus_message_get_args_valist), (dbus_message_iter_get_boolean),
6127 (dbus_message_iter_get_int32), (dbus_message_iter_get_uint32),
6128 (dbus_message_iter_get_double),
6129 (dbus_message_iter_get_boolean_array), (message_iter_test):
6130 * dbus/dbus-message.h:
6131 * dbus/dbus-protocol.h:
6132 * doc/dbus-specification.sgml:
6133 * test/data/valid-messages/lots-of-arguments.message:
6134 Add support for boolean and boolean array types.
6136 2003-02-23 Havoc Pennington <hp@pobox.com>
6138 * dbus/dbus-keyring.c: finish most of this implementation and
6141 * dbus/dbus-errors.c (dbus_set_error_const, dbus_set_error): make
6142 these barf if the error isn't cleared to NULL
6144 * dbus/dbus-sysdeps.c (_dbus_delete_file): set error on failure
6145 (_dbus_create_directory): new function
6147 * dbus/dbus-errors.c (dbus_set_error): fix warning
6149 * dbus/dbus-string.c (_dbus_string_hex_encode): new function
6150 (_dbus_string_hex_decode): new function
6151 (test_hex_roundtrip): test code
6153 * dbus/dbus-sha.c (_dbus_sha_compute): use dbus_string_hex_encode
6155 * dbus/dbus-md5.c (_dbus_md5_compute): use dbus_string_hex_encode
6157 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): make this use
6158 the save-to-temp/rename trick to atomically write the new file
6159 (_dbus_string_parse_uint): new function
6161 2003-02-22 Havoc Pennington <hp@pobox.com>
6163 * test/Makefile.am (dist-hook): fix dist for test/data/sha-1
6165 2003-02-22 Havoc Pennington <hp@pobox.com>
6167 * dbus/dbus-message.c (dbus_message_iter_get_string_array):
6168 (dbus_message_iter_get_byte_array): Fix up doxygen warnings
6170 * dbus/dbus-sha.c: add implementation of SHA-1 algorithm
6172 * dbus/test/data/sha-1: add US government test suite for SHA-1
6174 2003-02-21 Anders Carlsson <andersca@codefactory.se>
6176 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
6177 Make string arrays NULL-terminated.
6179 * dbus/dbus-memory.c: (dbus_free_string_array):
6180 * dbus/dbus-memory.h:
6181 New function for freeing NULL-terminated string arrays.
6183 * dbus/dbus-message-builder.c: (append_quoted_string),
6184 (_dbus_message_data_load):
6185 Add support for array types.
6187 * dbus/dbus-message.c: (check_message_handling):
6188 Add more types as test cases.
6190 * dbus/dbus-sysdeps.c: (_dbus_string_parse_int),
6191 (_dbus_string_parse_double):
6192 Add the start offset to the end offset.
6194 * test/data/valid-messages/lots-of-arguments.message:
6195 New test message with lots of arguments.
6197 2003-02-21 Anders Carlsson <andersca@codefactory.se>
6199 * dbus/dbus-message.c: (dbus_message_append_nil),
6200 (dbus_message_append_int32), (dbus_message_append_uint32),
6201 (dbus_message_append_double), (dbus_message_append_string),
6202 (dbus_message_append_int32_array),
6203 (dbus_message_append_uint32_array),
6204 (dbus_message_append_double_array),
6205 (dbus_message_append_byte_array),
6206 (dbus_message_append_string_array):
6207 Fix all out-of-memory handling in these functions.
6209 2003-02-21 Anders Carlsson <andersca@codefactory.se>
6211 * dbus/dbus-message.c: (dbus_message_append_nil):
6214 2003-02-21 Anders Carlsson <andersca@codefactory.se>
6216 * dbus/dbus-message.c: (dbus_message_append_args_valist),
6217 (dbus_message_append_nil), (dbus_message_append_int32_array),
6218 (dbus_message_append_uint32_array),
6219 (dbus_message_append_double_array),
6220 (dbus_message_append_byte_array),
6221 (dbus_message_append_string_array), (dbus_message_get_args_valist),
6222 (dbus_message_iter_get_int32_array),
6223 (dbus_message_iter_get_uint32_array),
6224 (dbus_message_iter_get_double_array),
6225 (dbus_message_iter_get_byte_array),
6226 (dbus_message_iter_get_string_array):
6228 * dbus/dbus-message.h:
6229 Add functions for appending and getting arrays.
6231 2003-02-21 Anders Carlsson <andersca@codefactory.se>
6233 * dbus/dbus-mempool.c (_dbus_mem_pool_new): Make the
6234 element size at least 8 bytes, fixes mempool tests on
6237 2003-02-20 Alexander Larsson <alexl@redhat.com>
6239 * dbus/dbus-transport-unix.c (unix_do_iteration):
6240 Unlock the connection mutex during a blocking select call.
6241 Add todo about how we need a way to wake up the select.
6243 * dbus/dbus-connection-internal.h:
6244 * dbus/dbus-connection.c:
6245 Add _dbus_connection_lock and _dbus_connection_unlock.
6247 2003-02-19 Havoc Pennington <hp@pobox.com>
6249 * Doxyfile.in (PREDEFINED): put DOXYGEN_SHOULD_SKIP_THIS in
6250 Doxyfile.in, not Doxyfile
6252 * dbus/dbus-keyring.c: do some hacking on this
6254 * dbus/dbus-sysdeps.c (_dbus_delete_file): new
6256 * dbus/dbus-errors.c (dbus_set_error_const): do not call
6258 (dbus_set_error): remove dbus_error_init, check for message ==
6259 NULL *before* we sprintf into it, and add @todo about including
6260 system headers in this file
6262 * dbus/dbus-sysdeps.c (_dbus_create_file_exclusively): new
6264 * dbus/dbus-errors.h (DBUS_ERROR_FAILED): add
6266 * dbus/dbus-sysdeps.c (get_user_info): break this function out to
6267 get various bits of user information based on either username
6269 (_dbus_homedir_from_username): new function
6271 2003-02-19 Anders Carlsson <andersca@codefactory.se>
6274 Add check for nonposix getpwnam_r
6276 * dbus/dbus-mempool.c: (_dbus_mem_pool_new):
6277 Align the pool element size to a sizeof (void *) boundary.
6279 * dbus/dbus-sysdeps.c: (_dbus_setenv), (_dbus_connect_unix_socket),
6280 (_dbus_listen_unix_socket), (_dbus_credentials_from_username):
6281 General Solaris fixes.
6283 * test/data/valid-messages/simplest-manual.message:
6284 Explicitly state that we want little-endian packing.
6286 2003-02-19 Mikael Hallendal <micke@codefactory.se>
6288 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
6290 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_tcp_socket):
6291 Added to create a transport connecting using a tcp/ip socket.
6293 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): Added to connect
6294 to a tcp socket at given host and port.
6295 (_dbus_listen_tcp_socket): added to listen on tcp socket for given
6298 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
6300 * dbus/dbus-server-unix.c (_dbus_server_new_for_tcp_socket):
6301 Added to create a server listening on a TCP/IP socket.
6303 2003-02-19 Havoc Pennington <hp@pobox.com>
6305 Throughout: mop up all the Doxygen warnings and undocumented
6308 * dbus/dbus-sysdeps.c (do_exec): do not use execvp, we don't want
6309 to search any paths.
6311 * dbus/dbus-threads.c: move global mutex initializers to
6312 dbus-internals.h, multiple prototypes was confusing doxygen
6313 besides being kind of ugly
6315 * Doxyfile (PREDEFINED): have Doxygen define
6316 DOXYGEN_SHOULD_SKIP_THIS so we can exclude things from
6317 docs with #ifndef DOXYGEN_SHOULD_SKIP_THIS
6318 (do not abuse the feature! it's for stuff like the autogenerated
6319 macros in dbus-md5.c, not just for things you don't feel like
6322 2003-02-18 Havoc Pennington <hp@pobox.com>
6324 * dbus/dbus-string.c (_dbus_string_zero): new function
6326 * dbus/dbus-md5.c: include MD5 implementation by L. Peter Deutsch,
6327 wrap it in some dbus-friendly API
6329 * dbus/dbus-types.h: add 16-bit types
6331 2003-02-18 Joe Shaw <joe@assbarn.com>
6333 * dbus/dbus-auth.c (handle_server_data_stupid_test_mech): Just get
6334 credentials from our currently running process.
6335 (get_word): Fix a buglet where we were copying the entire length
6336 instead of relative to our position.
6338 * dbus/dbus-hash.c (_dbus_hash_test): Don't try to allocate the
6339 keys on the stack... it's 640k of data.
6341 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): Always
6342 read the credentials byte off the socket, even if we don't have
6344 (_dbus_poll): Implement poll() using select() for systems which
6347 * glib/test-dbus-glib.c (main): Print out an error if no
6348 parameters are given.
6350 * test/data/auth/fallback.auth-script: Added. Tests that a client
6351 can fallback to a secondary auth mechanism if the first fails.
6353 2003-02-18 Havoc Pennington <hp@pobox.com>
6357 2003-02-17 Havoc Pennington <hp@pobox.com>
6359 * doc/dbus-specification.sgml: lots of cosmetic
6360 cleanups/rearrangement, add assorted FIXME, change DBUS_ADDRESS
6361 env variable to DBUS_BUS_ADDRESS, s/client/application/,
6362 s/server/bus/ (except in authentication section). Add a section
6363 "Message Bus Message Routing"
6365 2003-02-17 Anders Carlsson <andersca@codefactory.se.>
6371 2003-02-17 Anders Carlsson <andersca@codefactory.se>
6373 * doc/dbus-specification.sgml:
6374 Specification updates.
6376 2003-02-17 Anders Carlsson <andersca@codefactory.se>
6378 * bus/activation.c: (bus_activation_init), (child_setup),
6379 (bus_activation_activate_service):
6381 * bus/main.c: (main):
6382 Set DBUS_ADDRESS environment variable.
6384 * dbus/dbus-errors.c: (dbus_set_error):
6385 Don't use va_copy since that's a C99 feature.
6387 * dbus/dbus-sysdeps.c: (_dbus_setenv), (do_exec),
6388 (_dbus_spawn_async):
6389 * dbus/dbus-sysdeps.h:
6390 Add child_setup_func to _dbus_spawn_async.
6392 * doc/dbus-specification.sgml:
6393 Update specification.
6395 * test/spawn-test.c: (setup_func), (main):
6398 2003-02-17 Alexander Larsson <alexl@redhat.com>
6400 * dbus/dbus-connection.c (_dbus_connection_handler_destroyed_locked):
6403 2003-02-17 Anders Carlsson <andersca@codefactory.se>
6407 * doc/dbus-test-plan.sgml:
6408 Add test plan document.
6413 2003-02-17 Anders Carlsson <andersca@codefactory.se>
6415 * dbus/dbus-message.c: (decode_header_data),
6416 (_dbus_message_loader_return_buffer):
6417 Set the header padding amount when loading a message.
6419 2003-02-16 Anders Carlsson <andersca@codefactory.se>
6421 * bus/dispatch.c: (send_one_message):
6422 Only send broadcast messages to registered connections.
6424 * dbus/dbus-message.c: (dbus_message_name_is):
6425 * dbus/dbus-message.h:
6426 New convenience function.
6428 * dbus/dbus-transport-debug.c: (do_reading):
6429 Only dispatch one message per run.
6432 * test/bus-test.c: (new_connection_callback), (die),
6433 (test_hello_client1_handler), (test_hello_client2_handler),
6434 (test_hello_replies), (main):
6436 * test/bus-test-loop.[ch]:
6439 2003-02-16 Havoc Pennington <hp@pobox.com>
6441 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
6442 backward conditional
6444 2003-02-16 Alexander Larsson <alexl@redhat.com>
6446 * dbus/dbus-connection.c:
6447 Implement sent_message_with_reply. (with_reply_and block is still
6449 Made dispatch_message not lose message if OOM.
6451 * dbus/dbus-errors.h:
6452 Add NoReply error (for reply timeouts).
6454 2003-02-16 Alexander Larsson <alexl@redhat.com>
6456 * dbus/dbus-hash.c (_dbus_hash_table_unref):
6457 Actually free keys and values when destroying hashtable.
6459 2003-02-16 Anders Carlsson <andersca@codefactory.se>
6461 * dbus/dbus-auth.c: (client_try_next_mechanism):
6464 * dbus/dbus-threads.c: (dbus_condvar_wait_timeout):
6465 Return TRUE if there's no thread implementation around.
6467 * glib/dbus-gmain.c: (free_source),
6468 (dbus_connection_hookup_with_g_main):
6469 Make sure to remove the GSource when the connection is finalized.
6471 2003-02-16 Anders Carlsson <andersca@codefactory.se>
6473 * bus/dispatch.c: (bus_dispatch_message_handler):
6474 * dbus/dbus-errors.h:
6475 Return an error if someone tries to send a message to a service
6478 2003-02-16 Anders Carlsson <andersca@codefactory.se>
6480 * bus/activation.c: (load_directory), (bus_activation_init),
6481 (bus_activation_activate_service):
6484 (bus_driver_handle_activate_service), (bus_driver_handle_message):
6485 More work on the activation handling.
6487 * dbus/dbus-errors.h:
6488 Add some error messages
6490 * dbus/dbus-message.c: (dbus_message_new_error_reply):
6491 * dbus/dbus-message.h:
6492 New function that creates an error message.
6494 * dbus/dbus-protocol.h:
6495 Add ACTIVATE_SERVER message.
6497 * dbus/dbus-server-unix.c: (unix_handle_watch),
6498 (_dbus_server_new_for_domain_socket):
6499 Call _dbus_fd_set_close_on_exec.
6501 * dbus/dbus-sysdeps.c: (make_pipe), (do_exec),
6502 (_dbus_spawn_async), (_dbus_disable_sigpipe),
6503 (_dbus_fd_set_close_on_exec):
6504 * dbus/dbus-sysdeps.h:
6505 Add _dbus_fd_set_close_on exec function. Also add function that checks
6506 that all open fds are set to close-on-exec and warns otherwise.
6508 * dbus/dbus-transport-unix.c:
6509 (_dbus_transport_new_for_domain_socket):
6510 Call _dbus_fd_set_close_on_exec.
6512 2003-02-16 Havoc Pennington <hp@pobox.com>
6514 * dbus/dbus-connection.c (dbus_connection_set_change_sigpipe):
6515 allow people to avoid setting SIGPIPE to SIG_IGN
6516 (_dbus_connection_new_for_transport): disable SIGPIPE unless
6517 we've been asked not to
6519 2003-02-15 Anders Carlsson <andersca@codefactory.se>
6521 * dbus/dbus-list.c: (_dbus_list_append_link),
6522 (_dbus_list_prepend_link):
6523 * dbus/dbus-memory.c: (dbus_malloc), (dbus_malloc0),
6527 2003-02-15 Anders Carlsson <andersca@codefactory.se>
6530 * bus/activation.c: (bus_activation_entry_free),
6531 (add_desktop_file_entry), (load_directory), (bus_activation_init):
6533 * bus/main.c: (main):
6534 Add simple activation support, doesn't work yet though.
6536 2003-02-15 Zack Rusin <zack@kde.org>
6538 * qt/dbus-qthread.cpp: small casting fix
6540 2003-02-15 Anders Carlsson <andersca@codefactory.se>
6542 * dbus/dbus-errors.c: (dbus_set_error):
6543 * dbus/dbus-errors.h:
6544 Add a few errors and make dbus_set_error void.
6546 * dbus/dbus-sysdeps.c:
6547 (_dbus_errno_to_string), (close_and_invalidate), (make_pipe),
6548 (write_err_and_exit), (read_ints), (do_exec), (_dbus_spawn_async):
6549 * dbus/dbus-sysdeps.h:
6550 Add _dbus_spawn_async.
6552 * test/spawn-test.c: (main):
6553 Test for _dbus_spawn_async.
6555 2003-02-15 Anders Carlsson <andersca@codefactory.se>
6557 * dbus/dbus-internals.h:
6558 Fix build without tests.
6560 * dbus/dbus-list.c: (alloc_link):
6561 Fix a segfault when a malloc fails.
6563 * dbus/dbus-memory.c: (initialize_malloc_debug), (dbus_malloc),
6564 (dbus_malloc0), (dbus_realloc):
6565 Add support for malloc debugging.
6567 2003-02-15 Alexander Larsson <alexl@redhat.com>
6569 * dbus/dbus-threads.c:
6570 * dbus/dbus-threads.h:
6571 Add condvars. Remove static mutext from API.
6572 Implement static mutexes by initializing them from threads_init.
6574 * glib/dbus-gthread.c:
6575 * qt/dbus-qthread.cpp:
6576 Update with the thread api changes.
6581 Turn StaticMutex into normal mutex + init function.
6582 Export new functions _dbus_list_alloc_link, _dbus_list_free_link,
6583 _dbus_list_append_link, _dbus_list_prepend_link
6586 * dbus/dbus-sysdeps.c:
6587 * dbus/dbus-sysdeps.h:
6588 New type dbus_atomic_t, and new functions _dbus_atomic_inc,
6589 _dbus_atomic_dec. Only slow fallback implementation at the moment.
6591 * dbus/dbus-protocol.h:
6592 Add DBUS_MESSAGE_LOCAL_DISCONNECT define
6594 * dbus/dbus-message.c:
6595 Make ref/unref atomic.
6598 * dbus/dbus-connection-internal.h:
6599 * dbus/dbus-connection.c:
6600 * dbus/dbus-connection.h:
6602 Change _peek to _borrow,_return & _steal_borrowed.
6603 Change disconnect callback to event.
6604 Make dbus_connection_dispatch_messages reentrant.
6606 * dbus/dbus-transport.c:
6607 Don't ref the connection on calls to the transport
6610 * dbus/dbus-message-handler.c:
6613 * glib/dbus-gmain.c:
6614 Don't use peek_message anymore
6617 * test/debug-thread.c:
6618 * test/debug-thread.h:
6619 Simple thread implementation that asserts() on deadlocks in
6620 single-threaded code.
6623 (main) Call debug_threads_init.
6626 Use disconnect message instead of disconnect callback.
6630 Don't call dbus_connection_set_disconnect_function. Instead export
6631 bus_connection_disconnect.
6634 Call bus_connection_disconnect when we get a disconnected message.
6636 2003-02-15 Havoc Pennington <hp@pobox.com>
6638 * dbus/dbus-message.c (dbus_message_new): fool around with the
6641 2003-02-14 Havoc Pennington <hp@pobox.com>
6643 * dbus/dbus-mempool.c: fail if the debug functions so indicate
6645 * dbus/dbus-memory.c: fail if the debug functions indicate we
6648 * dbus/dbus-internals.c (_dbus_set_fail_alloc_counter)
6649 (_dbus_decrement_fail_alloc_counter): debug functions to
6650 simulate memory allocation failures
6652 2003-02-14 Havoc Pennington <hp@pobox.com>
6654 * dbus/dbus-errors.h (struct DBusError): add a word of padding
6657 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6659 * bus/driver.c: (bus_driver_handle_hello):
6661 * bus/services.c: (bus_service_lookup):
6662 Reorder message sending so we get a more sane order.
6664 * test/bus-test.c: (message_handler):
6667 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6669 * bus/driver.c: (bus_driver_send_service_deleted),
6670 (bus_driver_send_service_created), (bus_driver_send_service_lost),
6671 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
6672 (bus_driver_send_welcome_message),
6673 (bus_driver_handle_list_services),
6674 (bus_driver_handle_acquire_service),
6675 (bus_driver_handle_service_exists):
6676 * dbus/dbus-bus.c: (dbus_bus_register_client),
6677 (dbus_bus_acquire_service), (dbus_bus_service_exists):
6678 * dbus/dbus-errors.c: (dbus_result_to_string):
6679 * dbus/dbus-errors.h:
6680 * dbus/dbus-message.c: (dbus_message_append_args),
6681 (dbus_message_append_args_valist), (dbus_message_get_args),
6682 (dbus_message_get_args_valist), (dbus_message_get_args_iter),
6683 (dbus_message_iter_get_arg_type), (dbus_message_iter_get_string),
6684 (dbus_message_iter_get_byte_array),
6685 (dbus_message_iter_get_string_array), (message_iter_test),
6686 (check_message_handling), (_dbus_message_test):
6687 * dbus/dbus-message.h:
6688 * test/bus-test.c: (main):
6689 Change fields to arguments in messages, so that they won't be
6690 confused with header fields.
6692 * glib/test-dbus-glib.c: (main):
6693 Remove append_fields from hello message.
6695 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6697 * dbus/dbus-errors.c:
6698 * dbus/dbus-message.c:
6699 * dbus/dbus-string.c:
6700 Documentation fixes.
6702 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6704 * glib/dbus-gmain.c: (timeout_handler), (add_timeout),
6706 Implement support for timeouts in dbus-glib.
6708 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6710 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
6711 * dbus/dbus-message.c: (process_test_subdir):
6712 * test/break-loader.c: (find_breaks_based_on):
6713 Plug some memory leaks.
6715 2003-02-13 Richard Hult <rhult@codefactory.se>
6717 * bus/main.c: Fix build.
6719 * dbus/dbus-errors.h:
6720 * dbus/dbus-errors.c: Fix copyright for Anders.
6722 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6727 * bus/connection.c: (bus_connection_foreach):
6730 * bus/desktop-file.c: (grow_lines_in_section), (grow_sections),
6731 (unescape_string), (new_section), (parse_section_start),
6732 (parse_key_value), (report_error), (bus_desktop_file_load),
6733 (bus_desktop_file_get_string):
6734 * bus/desktop-file.h:
6735 Use DBusError for error reporting.
6737 * bus/dispatch.c: (send_one_message),
6738 (bus_dispatch_message_handler):
6739 * bus/driver.c: (bus_driver_send_service_deleted),
6740 (bus_driver_send_service_created), (bus_driver_send_service_lost),
6741 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
6742 (bus_driver_send_welcome_message),
6743 (bus_driver_handle_list_services),
6744 (bus_driver_handle_acquire_service),
6745 (bus_driver_handle_service_exists):
6746 * bus/loop.c: (bus_loop_run):
6748 Use BUS_HANDLE_OOM instead of _DBUS_HANDLE_OOM.
6750 * bus/utils.c: (bus_wait_for_memory):
6752 New files with general utility functions.
6754 * dbus/dbus-internals.h:
6755 Remove _DBUS_HANDLE_OOM.
6757 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6759 * dbus/dbus-errors.c: (dbus_result_to_string), (dbus_error_init),
6760 (dbus_error_free), (dbus_set_error_const), (dbus_set_error):
6761 * dbus/dbus-errors.h:
6762 Add DBusError structure.
6764 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6766 * test/data/valid-messages/standard-acquire-service.message:
6767 * test/data/valid-messages/standard-hello.message:
6768 * test/data/valid-messages/standard-list-services.message:
6769 * test/data/valid-messages/standard-service-exists.message:
6770 Add some standard messages.
6772 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6774 * bus/driver.c: (bus_driver_send_welcome_message),
6775 (bus_driver_handle_list_services),
6776 (bus_driver_handle_acquire_service),
6777 (bus_driver_handle_service_exists), (bus_driver_handle_message):
6778 Update for API changes in libdbus.
6780 * dbus/dbus-message.c: (dbus_message_new_reply):
6781 * dbus/dbus-message.h:
6782 Remove the name argument. The spec states that replies shouldn't
6785 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6787 * bus/desktop-file.c: (parse_section_start), (parse_key_value),
6788 (report_error), (bus_desktop_file_load), (lookup_section),
6789 (lookup_line), (bus_desktop_file_get_raw),
6790 (bus_desktop_file_get_string):
6791 * bus/desktop-file.h:
6792 Some fixes, and new functions for getting a key value from a section.
6794 2003-02-13 Havoc Pennington <hp@pobox.com>
6796 * test/data/auth/fail-after-n-attempts.auth-script: new test
6798 * dbus/dbus-auth.c (send_rejected): shutdown_mech() when we
6801 2003-02-13 Havoc Pennington <hp@pobox.com>
6803 * dbus/dbus-auth.c (handle_server_data_external_mech): args to
6804 dbus_credentials_match were backward
6806 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support
6807 NO_CREDENTIALS and ROOT_CREDENTIALS
6809 * dbus/dbus-auth.c (_dbus_auth_do_work): move get_state() routine
6810 into here. Never process more commands after we've reached an
6811 end state; store further data as unused bytes.
6813 * test/data/auth/*: add more auth tests
6815 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support EXPECT
6816 command to match exact string and EXPECT_UNUSED to match unused
6819 * test/Makefile.am (dist-hook): fix to dist all the test stuff
6821 2003-02-12 Havoc Pennington <hp@pobox.com>
6823 * dbus/dbus-string.c (_dbus_string_pop_line): fix to also strip
6824 \r off of popped lines
6826 * dbus/dbus-auth.c (_dbus_auth_test): write code to run auth
6829 * dbus/dbus-auth-script.c (_dbus_auth_script_run): when doing a
6832 2003-02-12 Havoc Pennington <hp@pobox.com>
6834 * dbus/Makefile.am: remove break-loader from the build, since it
6837 * configure.in: add --enable-gcov to turn on coverage profiling
6838 flags and disable optimization
6840 2003-02-10 Havoc Pennington <hp@pobox.com>
6842 * dbus/dbus-auth-script.c, dbus/dbus-auth-script.h: sync
6843 initial cut at test framework for DBusAuth from laptop.
6844 Doesn't quite work yet but it compiles and I need to get
6845 it off the 266mhz laptop. ;-)
6847 * dbus/dbus-server-debug.c (_dbus_server_debug_accept_transport):
6848 fix a memleak in error case
6850 2003-02-12 Anders Carlsson <andersca@codefactory.se>
6853 * bus/desktop-file.c:
6854 * bus/desktop-file.h:
6855 Add a desktop file parser.
6857 2003-02-11 Zack Rusin <zack@kde.org>
6859 * qt/message.[h|cpp]: sample implementation
6860 of the KDE wrapper for DBusMessage
6862 2003-02-09 Zack Rusin <zack@kde.org>
6864 * test/bus-test.c: make_it_compile
6865 * doc/dbus-specification.sgml: minimal semantic fix
6867 2003-02-06 Anders Carlsson <andersca@codefactory.se>
6873 2003-02-06 Anders Carlsson <andersca@codefactory.se>
6876 * dbus/dbus-break-loader.c:
6878 * test/break-loader.c:
6879 Move dbus-break-loader to test/ and rename it to break-loader.
6881 2003-02-02 Havoc Pennington <hp@pobox.com>
6883 * dbus/dbus-keyring.c, dbus/dbus-keyring.h: template files
6884 for code to manage cookies in your home directory
6886 * dbus/dbus-sysdeps.c (_dbus_generate_random_bytes): new function
6888 * dbus/dbus-auth.c (get_state): impose a maximum number of tries
6889 to authenticate, then disconnect the client.
6891 2003-02-03 Alexander Larsson <alexl@redhat.com>
6893 * dbus/dbus-message.c (dbus_message_append_fields):
6896 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6898 * doc/dbus-specification.sgml:
6899 Update address format section.
6901 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6904 * test/bus-test.c: (get_time), (add_timeout), (remove_timeout),
6905 (message_handler), (new_connection_callback), (loop_quit),
6909 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6911 * bus/driver.c: (bus_driver_handle_service_exists):
6912 Simplify the code a bit.
6914 * dbus/dbus-bus.c: (dbus_bus_service_exists):
6917 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6920 Add libdbus-daemon.la and link to it.
6922 2003-02-01 James Willcox <jwillcox@gnome.org>
6924 * bus/driver.c: (bus_driver_handle_own_service):
6925 Actually include the service reply code in the message.
6927 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6929 * bus/driver.c: (bus_driver_handle_service_exists):
6930 Don't unref the incoming message.
6932 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6934 * dbus/dbus.h: Add dbus-address.h and dbus-bus.h
6936 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6938 * dbus/dbus-server.c: (dbus_server_listen):
6939 * dbus/dbus-transport.c: (_dbus_transport_open):
6940 ifdef out the calls to the debug transport and server.
6942 2003-02-02 Alexander Larsson <alexl@redhat.com>
6944 * dbus/dbus-watch.c (dbus_watch_get_flags):
6945 Add note in the docs that ERROR or HANGUP won't be returned
6946 and are assumed always on.
6948 * glib/dbus-gmain.c (add_watch):
6949 Always add IO_ERR | IO_HUP
6951 * dbus/dbus-message.h:
6952 Add semicolon after dbus_message_iter_get_string_array().
6953 Makes qt code build again
6955 2003-02-01 Anders Carlsson <andersca@codefactory.se>
6957 * bus/driver.c: (create_unique_client_name),
6958 (bus_driver_handle_hello):
6959 Don't take a name, just use a numeric id to identify
6963 * dbus/dbus-bus.c: (dbus_bus_register_client),
6964 (dbus_bus_acquire_service), (dbus_bus_service_exists):
6966 Add new convenience functions for communicating with the bus.
6968 * dbus/dbus-message.h:
6970 * dbus/dbus-protocol.h:
6973 2003-02-01 Alexander Larsson <alexl@redhat.com>
6975 * dbus/dbus-message.c (dbus_message_append_fields):
6976 Add some more doc comments.
6978 2003-02-01 Havoc Pennington <hp@pobox.com>
6980 * dbus/dbus-break-loader.c (randomly_modify_length): change
6981 a 4-byte value in the message as if it were a length
6983 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): don't set
6984 execute bit on saved files
6986 2003-02-01 Havoc Pennington <hp@pobox.com>
6988 * dbus/dbus-break-loader.c (main): new program to find messages
6989 that break the loader.
6991 * dbus/dbus-sysdeps.c (_dbus_string_append_uint): new function
6992 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): new function
6994 * dbus/dbus-string.c (_dbus_string_set_byte): new
6996 2003-01-31 Havoc Pennington <hp@pobox.com>
6998 * dbus/dbus-message.c: refactor the test code to be more general,
6999 in preparation for writing a "randomly permute test cases to
7000 try to break the loader" program.
7002 2003-01-31 Havoc Pennington <hp@pobox.com>
7004 * doc/dbus-specification.sgml: work on the specification
7006 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): check
7007 the protocol version of the message.
7009 * dbus/dbus-protocol.h: drop special _REPLY names, the spec
7010 no longer specifies that.
7011 (DBUS_SERVICE_REPLY_SERVICE_EXISTS): fix flags (1/2/4/8 not
7014 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos): add missing
7015 "break" for DBUS_TYPE_NIL, remove @todo
7017 2003-01-31 Havoc Pennington <hp@pobox.com>
7019 * dbus/dbus-message.c (dbus_message_set_is_error_reply): rename
7020 just set_is_error/get_is_error as this is a commonly-used
7021 function, and write docs.
7023 2003-01-31 Anders Carlsson <andersca@codefactory.se>
7025 * dbus/dbus-address.c: (dbus_address_entry_free):
7026 Free key and value lists.
7028 * dbus/dbus-internals.c: (_dbus_type_to_string):
7029 Add the types we didn't have.
7031 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
7032 (_dbus_marshal_validate_arg):
7035 * dbus/dbus-message.c: (dbus_message_set_sender):
7036 Remove todo about being able to set sender to NULL.
7038 (dbus_message_set_is_error_reply),
7039 (dbus_message_get_is_error_reply):
7040 * dbus/dbus-message.h:
7043 * dbus/dbus-protocol.h:
7044 Add error reply flag.
7046 * test/data/valid-messages/opposite-endian.message:
7047 Add NIL type to test.
7049 2003-01-31 Havoc Pennington <hp@pobox.com>
7051 * doc/dbus-specification.sgml: fully specify the header. Add
7052 flags and major protocol version, and change header/body len to
7055 * dbus/dbus-message-builder.c (append_saved_length): append length
7058 * dbus/dbus-message.c (dbus_message_create_header): change header
7059 length and body length to unsigned. Add the new fields from the
7061 (_dbus_message_loader_return_buffer): unsigned header/body len
7063 2003-01-30 Havoc Pennington <hp@pobox.com>
7065 * dbus/dbus-auth.c: rework to use only REJECTED, no
7068 * doc/dbus-sasl-profile.txt: drop MECHANISMS and just
7069 use REJECTED, suggested by Mark McLoughlin
7071 2003-01-30 Havoc Pennington <hp@pobox.com>
7073 * dbus/dbus-server.c (dbus_server_listen): @todo about how we need
7074 a better way to report errors here. e.g. "unix address lacks
7075 path" or something. also "no such file" when the path doesn't
7078 * dbus/dbus-address.c (dbus_address_entries_free): add @todo about
7080 (dbus_parse_address): add @todo about documenting address format,
7081 and allowing , and ; to be escaped
7083 2003-01-30 Anders Carlsson <andersca@codefactory.se>
7086 Add dbus-address.[ch]
7088 * dbus/dbus-address.c: (dbus_address_entry_free),
7089 (dbus_address_entries_free), (create_entry),
7090 (dbus_address_entry_get_method), (dbus_address_entry_get_value),
7091 (dbus_parse_address), (_dbus_address_test):
7092 * dbus/dbus-address.h:
7093 New files for dealing with address parsing.
7095 * dbus/dbus-connection.c:
7096 Document timeout functions.
7098 * dbus/dbus-message.c:
7099 Document dbus_message_new_from_message.
7101 * dbus/dbus-server-debug.c:
7104 * dbus/dbus-server.c: (dbus_server_listen):
7105 Parse address and use correct server implementation.
7107 * dbus/dbus-string.c: (_dbus_string_find_to), (_dbus_string_test):
7108 * dbus/dbus-string.h:
7109 New function with test.
7111 * dbus/dbus-test.c: (dbus_internal_symbol_do_not_use_run_tests):
7115 * dbus/dbus-transport-debug.c:
7118 * dbus/dbus-transport.c: (_dbus_transport_open):
7119 Parse address and use correct transport implementation.
7121 2003-01-30 Havoc Pennington <hp@pobox.com>
7123 * dbus/dbus-message.c: use message->byte_order instead of
7124 DBUS_COMPILER_BYTE_ORDER throughout.
7125 (dbus_message_create_header): pad header to align the
7126 start of the body of the message to 8-byte boundary
7128 * dbus/dbus-marshal.h: make all the demarshalers take const
7129 DBusString arguments.
7131 * dbus/dbus-message.c (_dbus_message_loader_return_buffer):
7132 validate message args here, so we don't have to do slow validation
7133 later, and so we catch bad messages as they are incoming. Also add
7134 better checks on header_len and body_len. Also fill in
7137 * dbus/dbus-string.c (_dbus_string_validate_utf8): new (not
7138 implemented properly)
7139 (_dbus_string_validate_nul): new function to check all-nul
7141 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): rename
7142 get_arg_end_pos and remove all validation
7143 (_dbus_marshal_validate_arg): actually do validation here.
7145 2003-01-29 Havoc Pennington <hp@pobox.com>
7147 * dbus/dbus-message.c (check_message_handling): fix assertion
7148 failure on set_client_serial
7150 2003-01-28 Havoc Pennington <hp@pobox.com>
7152 * dbus/dbus-server-debug.c: Add doc section comments
7154 * dbus/dbus-transport-debug.c: add doc section comments
7156 2003-01-28 Havoc Pennington <hp@redhat.com>
7158 * dbus/dbus-string.c (_dbus_string_base64_decode): append bytes in
7159 the reverse order from how I had it
7160 (_dbus_string_base64_encode): reverse encoding order. I was
7161 basically byteswapping everything during encoding.
7163 2003-01-28 Anders Carlsson <andersca@codefactory.se>
7165 * dbus/dbus-connection-internal.h:
7166 * dbus/dbus-connection.c: (_dbus_connection_add_timeout),
7167 (_dbus_connection_remove_timeout):
7168 Add functions for adding and removing timeouts.
7170 * dbus/dbus-message.c: (dbus_message_new_from_message):
7171 Add new function that takes a message and creates an exact
7172 copy of it, but with the refcount set to 1.
7173 (check_message_handling):
7176 * dbus/dbus-server-protected.h:
7177 * dbus/dbus-server.c: (_dbus_server_init_base),
7178 (_dbus_server_finalize_base), (_dbus_server_add_timeout),
7179 (dbus_server_set_timeout_functions):
7180 (_dbus_server_remove_timeout):
7181 New functions so that a server can add and remove timeouts.
7183 (dbus_server_listen):
7184 Add commented out call to dbus_server_debug_new.
7186 * dbus/dbus-timeout.c: (_dbus_timeout_new):
7187 Actually set the handler, doh.
7189 * dbus/dbus-transport.c: (_dbus_transport_open):
7190 Add commented out call to dbus_transport_debug_client_new.
7193 Add dbus-transport-debug.[ch] and dbus-server-debug.[ch]
7195 2003-01-28 Havoc Pennington <hp@pobox.com>
7197 * dbus/dbus-message.c (check_message_handling): function to check
7198 on the loaded message, iterates over it etc.
7200 2003-01-28 Havoc Pennington <hp@pobox.com>
7202 * test/Makefile.am (dist-hook): fix make distdir
7204 * dbus/Makefile.am (TESTS_ENVIRONMENT): fix make check
7206 2003-01-27 Havoc Pennington <hp@pobox.com>
7208 * dbus/dbus-mempool.c (time_for_size): replace printf with
7211 * dbus/dbus-message-builder.c (_dbus_message_data_load): allow
7212 empty lines; fix the SAVE_LENGTH stuff to be
7213 START_LENGTH/END_LENGTH so it actually works; couple other
7216 * test/Makefile.am (dist-hook): add dist-hook for .message files
7218 * dbus/dbus-string.c (DBUS_STRING_COPY_PREAMBLE): source of a copy
7219 can be constant or locked.
7220 (_dbus_string_free): allow freeing a const string as
7223 * dbus/dbus-sysdeps.c (_dbus_concat_dir_and_file): utility
7225 * dbus/dbus-test-main.c (main): take an argument which is the
7226 directory containing test data
7228 * dbus/dbus-message.c (_dbus_message_test): pass a test_data_dir
7229 argument to this and load all the messages in test/data/
7230 checking that they can be loaded or not loaded as appropriate.
7232 2003-01-27 Anders Carlsson <andersca@codefactory.se>
7234 * bus/dispatch.c: (bus_dispatch_message_handler):
7235 Dispatch messages sent to services.
7237 * bus/driver.c: (bus_driver_send_service_deleted),
7238 (bus_driver_send_service_created), (bus_driver_send_service_lost),
7239 (bus_driver_send_service_acquired):
7240 Add helper functions for sending service related messages.
7242 (bus_driver_send_welcome_message):
7243 Send HELLO_REPLY instead of WELCOME.
7245 (bus_driver_handle_list_services):
7246 Send LIST_SERVICES_REPLY instead of SERVICES.
7248 (bus_driver_handle_own_service),
7249 (bus_driver_handle_service_exists):
7250 New message handlers.
7252 (bus_driver_handle_message):
7253 Invoke new message handlers.
7255 (bus_driver_remove_connection):
7256 Don't remove any services here since that's done automatically
7257 by bus_service_remove_owner now.
7260 New function signatures.
7262 * bus/services.c: (bus_service_add_owner):
7263 Send ServiceAcquired message if we're the only primary owner.
7265 (bus_service_remove_owner):
7266 Send ServiceAcquired/ServiceLost messages.
7268 (bus_service_set_prohibit_replacement),
7269 (bus_service_get_prohibit_replacement):
7270 Functions for setting prohibit replacement.
7272 (bus_service_has_owner):
7273 New function that checks if a connection is in the owner queue of
7277 Add new function signatures.
7279 * dbus/dbus-list.c: (_dbus_list_test):
7280 Add tests for _dbus_list_remove_last and traversing the list backwards.
7283 Fix a typo in _dbus_list_get_prev_link, if we're at the first element we can't
7284 go any further, so return NULL then.
7286 * dbus/dbus-protocol.h:
7287 Add new messages, service flags and service replies.
7289 2003-01-26 Havoc Pennington <hp@pobox.com>
7291 * dbus/dbus-message-builder.c: implement, completely untested.
7293 * test/data/*: add data to be used in testing.
7294 ".message" files are our simple loadable text format.
7295 ".message-raw" will be binary dumps of messages.
7297 * dbus/dbus-string.c (_dbus_string_starts_with_c_str): new
7299 2003-01-26 Havoc Pennington <hp@pobox.com>
7301 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): new function
7303 * dbus/dbus-errors.c (dbus_result_to_string): add
7306 * dbus/dbus-message-builder.c: new file, will contain code to load
7307 up messages from files. Not implemented yet.
7309 2003-01-26 Havoc Pennington <hp@pobox.com>
7311 * dbus/dbus-message.c (dbus_message_set_sender): support deleting
7312 the sender by setting to NULL
7314 2003-01-26 Havoc Pennington <hp@pobox.com>
7316 The unit tests pass, but otherwise untested. If it breaks, the
7317 tests should have been better. ;-)
7319 * bus/driver.c (bus_driver_handle_hello): return if we disconnect
7322 * dbus/dbus-message.c: redo everything so we maintain
7323 message->header as the only copy of the various fields.
7324 This avoids the possibility of out-of-memory in some cases,
7325 for example dbus_message_lock() can't run out of memory anymore,
7326 and avoids extra copying. Figured I may as well go ahead and do
7327 this since it was busted for dbus_message_lock to not return
7328 failure on OOM, and dbus_message_write_header was totally
7329 unchecked for OOM. Also fixed some random other bugs.
7331 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): verify
7332 that strings are nul-terminated. Also, end_pos can be equal
7333 to string length just not greater than, I think.
7334 (_dbus_marshal_set_int32): new function
7335 (_dbus_marshal_set_uint32): new function
7336 (_dbus_marshal_set_string): new function
7338 * dbus/dbus-connection.c (_dbus_connection_new_for_transport): fix
7339 a warning, init timeout_list to NULL
7340 (dbus_connection_send_message): don't use uninitialized variable
7343 * dbus/dbus-string.c (_dbus_string_replace_len): new function
7345 2003-01-26 Anders Carlsson <andersca@codefactory.se>
7347 * bus/driver.c: (bus_driver_handle_hello),
7348 (bus_driver_send_welcome_message):
7351 2003-01-26 Anders Carlsson <andersca@codefactory.se>
7353 * dbus/dbus-auth.c: (process_auth), (_dbus_auth_unref):
7354 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
7355 (dbus_connection_unref):
7356 * dbus/dbus-marshal.c: (_dbus_marshal_test):
7357 * dbus/dbus-message.c: (dbus_message_unref),
7360 (dbus_message_get_fields):
7361 Remove debugging printout.
7363 (_dbus_message_loader_return_buffer):
7364 Don't store the header string.
7366 (_dbus_message_test):
7369 2003-01-26 Richard Hult <rhult@codefactory.se>
7371 * glib/dbus-gmain.c (dbus_connection_dispatch): Traverse a copy of
7372 the file descriptor list, since it can change under us.
7374 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7376 * glib/dbus-gmain.c: (dbus_connection_prepare),
7377 (dbus_connection_check), (dbus_connection_dispatch), (add_watch),
7378 (remove_watch), (dbus_connection_hookup_with_g_main):
7379 Rewrite the glib handling to use its own GSource instead of a
7380 GIOChannel so we can catch messages put in the queue while waiting
7383 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7386 * bus/connection.c: (connection_disconnect_handler),
7387 (connection_watch_callback), (bus_connection_setup):
7388 * bus/dispatch.c: (send_one_message),
7389 (bus_dispatch_broadcast_message), (bus_dispatch_message_handler),
7390 (bus_dispatch_add_connection), (bus_dispatch_remove_connection):
7392 * bus/driver.c: (bus_driver_send_service_deleted),
7393 (bus_driver_send_service_created), (bus_driver_handle_hello),
7394 (bus_driver_send_welcome_message),
7395 (bus_driver_handle_list_services), (bus_driver_remove_connection),
7396 (bus_driver_handle_message):
7398 Refactor code, put the message dispatching in its own file. Use
7399 _DBUS_HANDLE_OOM. Also send ServiceDeleted messages when a client
7402 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7404 * dbus/dbus-internals.h:
7405 Add _DBUS_HANDLE_OOM macro, it doesn't do anything currently.
7407 * dbus/dbus-message.c: (dbus_message_get_sender):
7408 * dbus/dbus-message.h:
7409 Implement dbus_message_get_sender.
7411 * dbus/dbus-protocol.h:
7412 Add message and service defines.
7414 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7416 * dbus/dbus-connection.c: (dbus_connection_send_message):
7417 * dbus/dbus-message-internal.h:
7418 * dbus/dbus-message.c: (_dbus_message_get_client_serial),
7419 (dbus_message_write_header):
7420 Remove _dbus_messag_unlock and don't set the client serial on a
7421 message if one already exists.
7423 2003-01-24 Havoc Pennington <hp@pobox.com>
7425 * dbus/dbus-list.c (alloc_link): put a thread lock on the global
7428 * bus/driver.c (bus_driver_handle_list_services): fix a leak
7431 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7433 * dbus/dbus-list.c: (alloc_link), (free_link):
7434 Use a memory pool for the links.
7436 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7438 * bus/connection.c: (bus_connection_foreach):
7440 Add new bus_connection_foreach function.
7442 * bus/driver.c: (send_one_message), (bus_driver_broadcast_message):
7443 Add function that broadcasts a message to all clients.
7445 (bus_driver_send_service_created), (bus_driver_handle_hello),
7446 (bus_driver_send_welcome_message),
7447 (bus_driver_handle_list_services), (bus_driver_message_handler):
7448 Implement functions that take care of listing services, and notifying
7449 clients when new services are created.
7451 * bus/services.c: (bus_services_list):
7453 Add new function that returns an array of strings with the currently
7454 registered services.
7457 * glib/dbus-gmain.c:
7458 Update copyright year.
7460 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7462 * dbus/dbus-connection.c: (dbus_connection_send_message):
7463 Unlock the message in case it was sent earlier.
7465 (dbus_connection_send_message_with_reply_and_block):
7466 Remove the reply message from the list.
7468 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
7469 Set array_len and new_pos correctly.
7471 (_dbus_marshal_test):
7472 Remove debug output.
7474 * dbus/dbus-message-internal.h:
7475 * dbus/dbus-message.c: (_dbus_message_get_reply_serial):
7476 New function that returns the reply serial.
7478 (_dbus_message_unlock):
7479 New function that unlocks a message and resets its header.
7481 (dbus_message_append_string_array),
7482 (dbus_message_get_fields_valist),
7483 (dbus_message_iter_get_field_type),
7484 (dbus_message_iter_get_string_array),
7485 (dbus_message_get_fields),
7486 (dbus_message_append_fields_valist):
7487 Handle string arrays.
7489 (dbus_message_set_sender):
7490 Make this function public since the bus daemon needs it.
7492 (decode_header_data):
7493 Set the reply serial to -1 initially.
7495 * dbus/dbus-message.h:
7496 Add dbus_message_set_sender.
7498 2003-01-24 Havoc Pennington <hp@pobox.com>
7500 * doc/dbus-specification.sgml: add some stuff
7502 2003-01-22 Havoc Pennington <hp@pobox.com>
7504 * doc/dbus-specification.sgml: Start to document the protocol.
7506 2003-01-22 Havoc Pennington <hp@pobox.com>
7508 * dbus/dbus-connection.c
7509 (dbus_connection_send_message_with_reply_and_block): add some @todo
7511 * bus/driver.c (bus_driver_add_connection): add a FIXME about memleak
7513 2003-01-21 Havoc Pennington <hp@pobox.com>
7515 (patch untested because can't compile)
7517 * bus/driver.c (create_unique_client_name): make this function
7518 never recycle client names. Also, caller should initialize
7521 * dbus/dbus-sysdeps.c (_dbus_get_current_time): new function
7523 2003-01-21 Anders Carlsson <andersca@codefactory.se>
7525 * dbus/dbus-marshal.c: (_dbus_marshal_double),
7526 (_dbus_marshal_int32), (_dbus_marshal_uint32),
7527 (_dbus_marshal_int32_array), (_dbus_marshal_uint32_array),
7528 (_dbus_marshal_double_array), (_dbus_marshal_string_array),
7529 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
7530 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
7531 (_dbus_marshal_get_field_end_pos), (_dbus_marshal_test):
7532 * dbus/dbus-marshal.h:
7533 * dbus/dbus-protocol.h:
7534 Add support for marshalling and demarshalling integer, double
7537 2003-01-21 Anders Carlsson <andersca@codefactory.se>
7542 * bus/connection.c: (connection_disconnect_handler):
7543 Remove the connection from the bus driver's list.
7545 (connection_watch_callback): Dispatch messages.
7547 (free_connection_data): Free connection name.
7549 (bus_connection_setup): Add connection to the bus driver's list.
7550 (bus_connection_remove_owned_service):
7551 (bus_connection_set_name), (bus_connection_get_name):
7552 Add functions for setting and getting the connection's name.
7555 Add function headers.
7557 * bus/driver.c: (create_unique_client_name),
7558 (bus_driver_handle_hello_message),
7559 (bus_driver_send_welcome_message), (bus_driver_message_handler),
7560 (bus_driver_add_connection), (bus_driver_remove_connection):
7563 * bus/services.c: (bus_service_free):
7565 New file that handles communication and registreation with the bus
7568 2003-01-21 Anders Carlsson <andersca@codefactory.se>
7570 * dbus/dbus-connection.c: (dbus_connection_send_message):
7571 Add a new client_serial parameter.
7573 (dbus_connection_send_message_with_reply):
7574 Remove a @todo since we've implemented the blocking function.
7576 (dbus_connection_send_message_with_reply_and_block):
7577 New function that sends a message and waits for a reply and
7578 then returns the reply.
7580 * dbus/dbus-connection.h:
7583 * dbus/dbus-errors.c: (dbus_result_to_string):
7584 * dbus/dbus-errors.h:
7585 Add new DBUS_RESULT.
7587 * dbus/dbus-message-internal.h:
7588 * dbus/dbus-message.c: (_dbus_message_get_reply_serial),
7589 (_dbus_message_set_sender), (dbus_message_write_header),
7590 (dbus_message_new_reply), (decode_header_data),
7591 (_dbus_message_loader_return_buffer), (_dbus_message_test):
7592 * dbus/dbus-message.h:
7593 Add new functions that set the reply serial and sender.
7594 Also marshal and demarshal them correctly and add test.
7596 * dbus/dbus-protocol.h:
7597 Add new DBUS_MESSAGE_TYPE_SENDER.
7600 * glib/dbus-gmain.c: (watch_callback), (free_callback_data),
7601 (add_watch), (remove_watch), (add_timeout), (remove_timeout),
7602 (dbus_connection_hookup_with_g_main):
7603 * glib/test-dbus-glib.c: (main):
7604 Rewrite to use GIOChannel and remove the GSource crack.
7606 * test/echo-client.c: (main):
7607 * test/watch.c: (check_messages):
7608 Update for changed APIs
7610 2003-01-19 Anders Carlsson <andersca@codefactory.se>
7612 * dbus/Makefile.am: Add dbus-timeout.[cħ]
7614 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport):
7615 Create a DBusTimeoutList.
7616 (dbus_connection_set_timeout_functions): Add new function to
7617 set timeout callbacks
7619 * dbus/dbus-connection.h: Add public DBusTimeout API.
7621 * dbus/dbus-message.c: (dbus_message_get_service):
7622 * dbus/dbus-message.h: New function.
7624 * dbus/dbus-server.c: Fix small doc typo.
7626 * dbus/dbus-timeout.[ch]: New files for mainloop timeouts.
7628 2003-01-19 Anders Carlsson <andersca@codefactory.se>
7630 * dbus/dbus-string.c (_dbus_string_move_len): Don't delete all
7631 of the string, just as long as specified.
7633 2003-01-19 Havoc Pennington <hp@pobox.com>
7635 * dbus/dbus-connection.c (dbus_connection_get_is_authenticated):
7638 * dbus/dbus-server.c (dbus_server_set_max_connections)
7639 (dbus_server_get_max_connections, dbus_server_get_n_connections):
7640 keep track of current number of connections, and add API for
7641 setting a max (but haven't implemented enforcing the max yet)
7643 2003-01-18 Havoc Pennington <hp@pobox.com>
7645 * dbus/dbus-transport-unix.c (unix_do_iteration): only do the
7646 reading/writing if read_watch != NULL or write_watch != NULL.
7648 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): fix
7649 the message loader code to actually load message->header and
7650 message->body into the newly-created message.
7652 * dbus/dbus-transport-unix.c (check_write_watch): fix a mem leak
7655 * dbus/dbus-connection.c (dbus_connection_set_max_message_size)
7656 (dbus_connection_get_max_message_size)
7657 (dbus_connection_set_max_live_messages_size)
7658 (dbus_connection_get_max_live_messages_size): implement some
7659 resource limitation functions
7661 * dbus/dbus-resources.c: new file implementing some of the
7662 resource limits stuff
7664 * dbus/dbus-message.c (dbus_message_iter_get_byte_array): add
7665 missing docs, add @todo to handle OOM etc.
7667 * dbus/dbus-marshal.c (_dbus_demarshal_byte_array): add missing
7670 2003-01-18 Havoc Pennington <hp@pobox.com>
7672 * dbus/dbus-connection.c (dbus_connection_unref): disconnect the
7673 connection if it hasn't been already.
7675 * dbus/dbus-connection.h: kill off the idea of an ErrorFunction,
7676 replace with DisconnectFunction.
7678 2003-01-18 Havoc Pennington <hp@pobox.com>
7680 Building --disable-verbose-mode --disable-asserts --disable-tests
7681 cuts the library from 112K to 45K or so
7683 * configure.in: check for varargs macro support,
7684 add --enable-verbose-mode, --enable-asserts.
7686 * dbus/dbus-internals.h (_dbus_assert): support
7688 (_dbus_verbose): support DBUS_ENABLE_VERBOSE_MODE
7690 2003-01-18 Havoc Pennington <hp@pobox.com>
7692 * dbus/dbus-test.c: include config.h so that tests actually run
7694 * dbus/dbus-string.c: add assertions that stuff is 8-byte aligned,
7695 so the failure mode when that assumption fails will be plenty
7698 2003-01-18 Havoc Pennington <hp@pobox.com>
7700 * configure.in: default --enable-tests to $USE_MAINTAINER_MODE
7702 * dbus/Makefile.am: fix it up so dubs-test-main.c is included in
7705 * test/Makefile.am: don't use special variable "TESTS" for echo-*
7706 since we don't want to use those in make check
7708 2003-01-15 Havoc Pennington <hp@redhat.com>
7714 2003-01-15 Havoc Pennington <hp@redhat.com>
7716 * test/Makefile.am: fix so that test source code ends up in the
7717 distribution on make distcheck
7719 2003-01-15 Havoc Pennington <hp@redhat.com>
7725 2003-01-15 Havoc Pennington <hp@redhat.com>
7727 * dbus/dbus-test.c (dbus_internal_symbol_do_not_use_run_tests):
7728 fix build when --disable-tests
7730 * Makefile.am (EXTRA_DIST): put HACKING in here
7732 * HACKING: document procedure for making a tarball release.
7734 2003-01-14 Anders Carlsson <andersca@codefactory.se>
7736 * bus/connection.c: (connection_error_handler),
7737 (bus_connection_setup):
7738 * bus/main.c: (main):
7739 Make sure that the DBusConnectionData struct is NULLed
7740 out to prevent a segfault.
7742 * dbus/dbus-errors.c: (dbus_result_to_string):
7743 * dbus/dbus-errors.h:
7744 * dbus/dbus-message.c: (dbus_message_get_fields),
7745 (dbus_message_get_fields_valist), (_dbus_message_test):
7746 * dbus/dbus-message.h:
7747 Make dbus_message_get_fields return a result code so we can
7748 track invalid fields as well as oom.
7750 2003-01-11 Havoc Pennington <hp@pobox.com>
7752 * configure.in: change --enable-test/--enable-ansi action-if-given
7753 to enable_foo=$enableval instead of enable_foo=yes
7755 2003-01-08 Havoc Pennington <hp@pobox.com>
7757 * dbus/dbus-string.c (_dbus_string_align_length): new function
7759 * dbus/dbus-test-main.c: move main() for test app here
7761 (dbus_internal_symbol_do_not_use_run_tests): we have to export a
7762 symbol to run tests, because dbus-test isn't in the main
7765 Code review nitpicks.
7767 * dbus/dbus-message.c (dbus_message_write_header): add newlines
7768 for people with narrow emacs ;-). Assert client_serial was filled
7769 in. Assert message->name != NULL.
7770 (dbus_message_append_fields): have "first_field_type" arg separate
7771 from va list, needed for C++ binding that also uses varargs IIRC
7772 and helps with type safety
7773 (dbus_message_new): add @todo about using DBusString to store
7774 service/name internally
7775 (dbus_message_new): don't leak ->service and ->name on OOM later
7777 (dbus_message_unref): free the service name
7778 (dbus_message_get_fields): same change to varargs
7779 i.e. first_field_type
7780 (_dbus_message_loader_return_buffer): assert that the message data
7781 is aligned (if not it's a bug in our code). Put in verbose griping
7782 about why we set corrupted = TRUE.
7783 (decode_header_data): add FIXME that char* is evil. Was going to
7784 add FIXME about evil locale-specific string.h strncmp, but just
7785 switched to wacky string-as-uint32 optimization. Move check for
7786 "no room for field name" above get_const_data_len() to avoid
7787 assertion failure in get_const_data_len if we have trailing 2
7788 bytes or the like. Check for service and name fields being
7789 provided twice. Don't leak service/name on error. Require field
7790 names to be aligned to 4 bytes.
7792 * dbus/dbus-marshal.c: move byte swap stuff to header
7793 (_dbus_pack_int32): uscore-prefix
7794 (_dbus_unpack_int32): uscore-prefix
7795 (_dbus_unpack_uint32): export
7796 (_dbus_demarshal_string): add @todo complaining about use of
7798 (_dbus_marshal_get_field_end_pos): add @todo about bad error
7799 handling allowing corrupt data to go unchecked
7801 2003-01-08 Havoc Pennington <hp@redhat.com>
7803 * dbus/dbus-transport-unix.c (unix_do_iteration): add read/write
7804 to the select() as needed for authentication. (should be using
7805 _dbus_poll() not select, but for another day)
7807 * dbus/dbus.h: include dbus/dbus-protocol.h
7809 2003-01-08 Anders Carlsson <andersca@codefactory.se>
7811 * dbus/Makefile.am (dbusinclude_HEADERS): Install
7814 2003-01-08 Anders Carlsson <andersca@codefactory.se>
7816 * dbus/dbus-internals.c: (_dbus_type_to_string):
7817 New function that returns a string describing a type.
7819 * dbus/dbus-marshal.c: (_dbus_demarshal_byte_array):
7820 * dbus/dbus-marshal.h:
7821 * dbus/dbus-message.c: (dbus_message_get_fields_valist),
7822 (dbus_message_iter_get_field_type), (dbus_message_iter_get_double),
7823 (dbus_message_iter_get_byte_array):
7824 * dbus/dbus-message.h:
7825 Add new convenience functions for appending and getting message fields.
7826 Also add demarshalling routines for byte arrays.
7828 2003-01-07 Anders Carlsson <andersca@codefactory.se>
7830 * dbus/dbus-connection-internal.h:
7831 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
7832 (_dbus_connection_get_next_client_serial),
7833 (dbus_connection_send_message):
7834 * dbus/dbus-internals.h:
7835 * dbus/dbus-marshal.c: (unpack_uint32), (dbus_unpack_int32),
7836 (dbus_pack_int32), (_dbus_marshal_double), (_dbus_marshal_int32),
7837 (_dbus_marshal_uint32), (_dbus_demarshal_double),
7838 (_dbus_demarshal_int32), (_dbus_demarshal_uint32),
7839 (_dbus_demarshal_string), (_dbus_marshal_get_field_end_pos),
7840 (_dbus_verbose_bytes), (_dbus_marshal_test):
7841 * dbus/dbus-marshal.h:
7842 * dbus/dbus-message-internal.h:
7843 * dbus/dbus-message.c: (_dbus_message_set_client_serial),
7844 (dbus_message_write_header), (_dbus_message_lock),
7845 (dbus_message_new), (dbus_message_ref), (dbus_message_unref),
7846 (dbus_message_get_name), (dbus_message_append_int32),
7847 (dbus_message_append_uint32), (dbus_message_append_double),
7848 (dbus_message_append_string), (dbus_message_append_byte_array),
7849 (dbus_message_get_fields_iter), (dbus_message_iter_ref),
7850 (dbus_message_iter_unref), (dbus_message_iter_has_next),
7851 (dbus_message_iter_next), (dbus_message_iter_get_field_type),
7852 (dbus_message_iter_get_string), (dbus_message_iter_get_int32),
7853 (dbus_message_iter_get_uint32), (dbus_message_iter_get_double),
7854 (decode_header_data), (_dbus_message_loader_return_buffer),
7855 (message_iter_test), (_dbus_message_test):
7856 * dbus/dbus-message.h:
7857 * dbus/dbus-protocol.h:
7858 * dbus/dbus-test.c: (main):
7860 * glib/test-dbus-glib.c: (message_handler), (main):
7861 * test/echo-client.c: (main):
7862 * test/watch.c: (check_messages):
7863 Make messages sendable and receivable for real.
7865 2003-01-07 Anders Carlsson <andersca@codefactory.se>
7867 * dbus/dbus-marshal.c: (_dbus_marshal_double),
7868 (_dbus_marshal_string), (_dbus_marshal_byte_array):
7869 * dbus/dbus-message.c: (dbus_message_append_int32),
7870 (dbus_message_append_uint32), (dbus_message_append_double),
7871 (dbus_message_append_string), (dbus_message_append_byte_array):
7872 Handle OOM restoration.
7874 2003-01-07 Anders Carlsson <andersca@codefactory.se>
7876 * dbus/dbus-marshal.c: (_dbus_marshal_string),
7877 (_dbus_demarshal_string), (_dbus_marshal_test):
7878 * dbus/dbus-marshal.h:
7879 * dbus/dbus-message.c: (dbus_message_get_name),
7880 Document these functions.
7882 (dbus_message_append_int32), (dbus_message_append_uint32),
7883 (dbus_message_append_double), (dbus_message_append_string),
7884 (dbus_message_append_byte_array):
7885 * dbus/dbus-message.h:
7886 Add functions for adding message fields of different types.
7888 * dbus/dbus-protocol.h:
7889 Add the different types.
7891 2003-01-05 Havoc Pennington <hp@pobox.com>
7893 * bus/connection.c: implement routines for handling connections,
7894 first thing is keeping a list of owned services on each connection
7895 and setting up watches etc.
7897 * bus/services.c: implement a mapping from service names to lists
7900 * dbus/dbus-hash.c: add DBUS_HASH_POINTER
7902 * dbus/dbus-threads.c (dbus_static_mutex_lock): add functions
7903 to use static mutexes for global data
7905 * dbus/dbus-connection.c (dbus_connection_set_data): add new
7906 collection of functions to set/get application-specific data
7907 on the DBusConnection.
7909 2003-01-04 Havoc Pennington <hp@pobox.com>
7911 * dbus/dbus-sysdeps.c (_dbus_sleep_milliseconds): new function
7912 (_dbus_poll): new function
7914 * dbus/dbus-internals.h (_DBUS_STRUCT_OFFSET): new macro
7917 * bus/loop.c: initial code for the daemon main loop
7919 2003-01-04 Havoc Pennington <hp@pobox.com>
7921 * test/watch.c (error_handler): make it safe if the error handler
7922 is called multiple times (if we s/error handler/disconnect
7923 handler/ we should just guarantee it's called only once)
7925 * dbus/dbus-transport.c (_dbus_transport_disconnect): call the
7926 error handler on disconnect (it's quite possible we should
7927 just change the error handler to a "disconnect handler," I'm
7928 not sure we have any other meaningful errors)
7930 * configure.in: check for getpwnam_r
7932 * dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
7933 dbus/dbus-auth.c: add credentials support, add EXTERNAL auth
7934 mechanism as in SASL spec, using socket credentials
7936 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): new function
7937 (_dbus_send_credentials_unix_socket): new function
7939 * dbus/dbus-sysdeps.c (_dbus_accept_unix_socket): rename just
7941 (_dbus_write): only check errno if <0 returned
7942 (_dbus_write_two): ditto
7944 2003-01-02 Anders Carlsson <andersca@codefactory.se>
7946 * dbus/dbus-marshal.c: (_dbus_marshal_utf8_string),
7947 (_dbus_marshal_byte_array), (_dbus_demarshal_utf8_string),
7948 (_dbus_marshal_test):
7949 * dbus/dbus-marshal.h:
7950 Add _dbus_marshal_byte_array and rename _dbus_marshal_string
7951 to _dbus_marshal_utf8_string. Also fix some tests.
7953 2002-12-28 Harri Porten <porten@kde.org>
7955 * configure.in: added check for C++ compiler and a very cheesy
7956 check for the Qt integration
7958 * Makefile.am (SUBDIRS): compile qt subdir if support is enabled
7960 * qt/Makefile.am: added
7962 * qt/.cvsignore: added
7964 * qt/dbus-qthread.cc, qt/dbus-qthread.cpp: renamed former to
7965 latter, added #ifdef QT_THREAD_SUPPORT guard.
7967 * dbus/Makefile.am: added missing headers for make dist
7969 2002-12-28 Kristian Rietveld <kris@gtk.org>
7971 * dbus/Makefile.am: fixup export-symbols-regex.
7973 2002-12-27 Anders Carlsson <andersca@codefactory.se>
7975 * acinclude.m4: Add this file and put the
7976 PKG_CHECK_MODULE macro in it.
7978 2002-12-27 Anders Carlsson <andersca@codefactory.se>
7980 * dbus/dbus-marshal.c: (_dbus_marshal_string),
7981 (_dbus_demarshal_double), (_dbus_demarshal_int32),
7982 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
7983 (_dbus_marshal_test):
7984 Make the demarshalling routines align the pos argument.
7985 Add string marshalling tests and fix the obvious bugs
7988 2002-12-26 Havoc Pennington <hp@pobox.com>
7990 * dbus/dbus-auth.c: fixes fixes fixes
7992 * dbus/dbus-transport-unix.c: wire up support for
7993 encoding/decoding data on the wire
7995 * dbus/dbus-auth.c (_dbus_auth_encode_data)
7996 (_dbus_auth_decode_data): append to target string
7997 instead of nuking it.
7999 2002-12-26 Havoc Pennington <hp@pobox.com>
8001 * dbus/dbus-marshal.h (DBUS_COMPILER_BYTE_ORDER): #ifdef
8002 WORDS_BIGENDIAN then compiler byte order is DBUS_BIG_ENDIAN,
8005 * dbus/dbus-marshal.c: Add macros to do int swapping in-place and
8006 avoid swap_bytes() overhead (ignoring possible assembly stuff for
8007 now). Main point is because I wanted unpack_uint32 to implement
8009 (_dbus_verbose_bytes): new function
8011 * dbus/dbus-string.c (_dbus_string_validate_ascii): new function
8013 * dbus/dbus-message.c (_dbus_message_loader_get_is_corrupted): add
8014 mechanism to handle a corrupt message stream
8015 (_dbus_message_loader_new): fix preallocation to only prealloc,
8018 * dbus/dbus-string.c (_dbus_string_skip_blank): fix this function
8019 (_dbus_string_test): enhance tests for copy/move and fix the
8022 * dbus/dbus-transport-unix.c: Hold references in more places to
8023 avoid reentrancy problems
8025 * dbus/dbus-transport.c: ditto
8027 * dbus/dbus-connection.c (dbus_connection_dispatch_message): don't
8028 leak reference count in no-message case
8030 * test/watch.c (do_mainloop): handle adding/removing watches
8031 during iteration over the watches. Also, ref the connection/server
8032 stored on a watch, so we don't try to mangle a destroyed one.
8034 * dbus/dbus-transport-unix.c (do_authentication): perform
8037 * dbus/dbus-auth.c (get_state): add a state
8038 AUTHENTICATED_WITH_UNUSED_BYTES and return it if required
8039 (_dbus_auth_get_unused_bytes): append the unused bytes
8040 to the passed in string, rather than prepend
8042 * dbus/dbus-transport.c (_dbus_transport_init_base): create
8043 the auth conversation DBusAuth
8045 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd)
8046 (_dbus_transport_new_for_domain_socket): when creating a
8047 transport, pass in whether it's a client-side or server-side
8048 transport so we know which DBusAuth to create
8050 2002-12-03 Havoc Pennington <hp@pobox.com>
8052 * dbus/dbus-transport-unix.c (unix_finalize): finalize base
8053 _after_ finalizing the derived members
8054 (unix_connection_set): unref watch if we fail to add it
8056 * dbus/dbus-connection.c (dbus_connection_unref): delete the
8057 transport first, so that the connection owned by the
8058 transport will be valid as the transport finalizes.
8060 * dbus/dbus-transport-unix.c (unix_finalize): free the write_watch
8061 if necessary, and remove watches from the connection.
8063 * dbus/dbus-watch.c (_dbus_watch_list_free): improve a comment
8065 2002-12-26 Anders Carlsson <andersca@codefactory.se>
8067 * dbus/dbus-marshal.c: (_dbus_marshal_string),
8068 (_dbus_demarshal_double), (_dbus_demarshal_int32),
8069 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
8070 (_dbus_marshal_test):
8071 * dbus/dbus-marshal.h:
8072 Add string marshal functions and have the demarshal functions
8073 return the new position.
8075 2002-12-25 Havoc Pennington <hp@pobox.com>
8077 * doc/dbus-sasl-profile.txt: docs on the authentication protocol,
8078 it is a simple protocol that just maps directly to SASL.
8080 * dbus/dbus-auth.h, dbus/dbus-auth.c: authentication protocol
8081 initial implementation, not actually used yet.
8083 * dbus/dbus-string.c (_dbus_string_find): new function
8084 (_dbus_string_equal): new function
8085 (_dbus_string_base64_encode): new function
8086 (_dbus_string_base64_decode): new function
8088 2002-12-25 Anders Carlsson <andersca@codefactory.se>
8091 * dbus/dbus-marshal.c: (swap_bytes), (_dbus_marshal_double),
8092 (_dbus_marshal_int32), (_dbus_marshal_uint32),
8093 (_dbus_demarshal_double), (_dbus_demarshal_int32),
8094 (_dbus_demarshal_uint32), (_dbus_marshal_test):
8095 * dbus/dbus-marshal.h:
8096 * dbus/dbus-protocol.h:
8097 * dbus/dbus-test.c: (main):
8099 Add un-optimized marshalling/demarshalling routines.
8101 2002-12-25 Harri Porten <porten@kde.org>
8103 * qt/dbus-qt.h: adjusted ctor and getter to KDE/Qt conventions
8105 2002-12-24 Zack Rusin <zack@kde.org>
8107 * qt/dbus-qthread.cc: adding - integrates QMutex into Dbus
8108 * qt/dbus-qt.h: skeleton with two sample implemenatation of the
8111 2002-12-24 Havoc Pennington <hp@pobox.com>
8113 * glib/dbus-gthread.c: fix include
8115 * glib/dbus-glib.h: rename DBusMessageHandler for now.
8116 I think glib API needs to change, though, as you don't
8117 want to use DBusMessageFunction, you want to use the
8118 DBusMessageHandler object. Probably
8119 dbus_connection_open_with_g_main_loop()
8120 and dbus_connection_setup_g_main_loop() or something like that
8121 (but think of better names...) that just create a connection
8122 that has watch/timeout functions etc. already set up.
8124 * dbus/dbus-connection.c
8125 (dbus_connection_send_message_with_reply): new function just to
8126 show how the message handler helps us deal with replies.
8128 * dbus/dbus-list.c (_dbus_list_remove_last): new function
8130 * dbus/dbus-string.c (_dbus_string_test): free a string that
8133 * dbus/dbus-hash.c: use memory pools for the hash entries
8134 (rebuild_table): be more paranoid about overflow, and
8135 shrink table when we can
8136 (_dbus_hash_test): reduce number of sprintfs and write
8137 valid C89. Add tests for case where we grow and then
8138 shrink the hash table.
8140 * dbus/dbus-mempool.h, dbus/dbus-mempool.c: memory pools
8142 * dbus/dbus-connection.c (dbus_connection_register_handler)
8143 (dbus_connection_unregister_handler): new functions
8145 * dbus/dbus-message.c (dbus_message_get_name): new
8147 * dbus/dbus-list.c: fix docs typo
8149 * dbus/dbus-message-handler.h, dbus/dbus-message-handler.c:
8150 an object representing a handler for messages.
8152 2002-12-16 Anders Carlsson <andersca@codefactory.se>
8155 * glib/dbus-gthread.c: (dbus_gthread_init):
8156 Don't use the gdbus prefix for public functions.
8158 2002-12-16 Anders Carlsson <andersca@codefactory.se>
8162 Add GLib checks and fixup .pc files
8166 * glib/dbus-gmain.c: (gdbus_connection_prepare),
8167 (gdbus_connection_check), (gdbus_connection_dispatch),
8168 (gdbus_add_connection_watch), (gdbus_remove_connection_watch),
8169 (dbus_connection_gsource_new):
8170 * glib/dbus-gthread.c: (dbus_gmutex_new), (dbus_gmutex_free),
8171 (dbus_gmutex_lock), (dbus_gmutex_unlock), (dbus_gthread_init):
8172 * glib/test-dbus-glib.c: (message_handler), (main):
8175 2002-12-15 Harri Porten <porten@kde.org>
8177 * autogen.sh: check for libtoolize before attempting to use it
8179 * dbus/dbus-transport-unix.c: include <sys/time.h> for timeval
8182 * .cvsignore: ignore more stamp files
8184 * dbus/dbus-watch.c (_dbus_watch_list_new): fixed doc error
8186 * test/Makefile.am: added -I$(top_srcdir) to be able to compile
8187 without make install.
8189 2002-12-15 Havoc Pennington <hp@pobox.com>
8191 * dbus/dbus-threads.c: add thread stubs that a higher library
8192 layer can fill in. e.g. the GLib wrapper might fill them in with
8193 GThread stuff. We still need to use this thread API to
8194 thread-safe-ize the library.
8196 2002-12-12 Havoc Pennington <hp@pobox.com>
8198 * dbus/dbus-transport-unix.c, dbus/dbus-server-unix.c: use the
8199 below new interfaces and include fewer system headers.
8201 * dbus/dbus-sysdeps.c (_dbus_read): new function
8202 (_dbus_write): new function
8203 (_dbus_write_two): new function
8204 (_dbus_connect_unix_socket): new function
8205 (_dbus_listen_unix_socket): new function
8207 * dbus/dbus-message-internal.h: change interfaces to use
8210 2002-12-11 Havoc Pennington <hp@pobox.com>
8212 * dbus/dbus-types.h: add dbus_unichar
8214 * dbus/dbus-internals.c (_dbus_verbose): use _dbus_getenv
8216 * dbus/dbus-connection.c (dbus_connection_send_message): return
8219 * dbus/dbus-transport.c: include dbus-watch.h
8221 * dbus/dbus-connection.c: include dbus-message-internal.h
8223 * HACKING: add file with coding guidelines stuff.
8225 * dbus/dbus-string.h, dbus/dbus-string.c: Encapsulate all string
8226 handling here, for security purposes (as in vsftpd). Not actually
8227 using this class yet.
8229 * dbus/dbus-sysdeps.h, dbus/dbus-sysdeps.c: Encapsulate all
8230 system/libc usage here, as in vsftpd, for ease of auditing (and
8231 should also simplify portability). Haven't actually moved all the
8232 system/libc usage into here yet.
8234 2002-11-25 Havoc Pennington <hp@pobox.com>
8236 * dbus/dbus-internals.c (_dbus_verbose): fix to not
8237 always print the first verbose message.
8239 2002-11-24 Havoc Pennington <hp@pobox.com>
8241 * test/echo-client.c, test/echo-server.c: cheesy test
8244 * configure.in (AC_CHECK_FUNCS): check for writev
8246 * dbus/dbus-message.c (_dbus_message_get_network_data): new
8249 * dbus/dbus-list.c (_dbus_list_foreach): new function
8251 * dbus/dbus-internals.c (_dbus_verbose): new function
8253 * dbus/dbus-server.c, dbus/dbus-server.h: public object
8254 representing a server that listens for connections.
8256 * dbus/.cvsignore: create
8258 * dbus/dbus-errors.h, dbus/dbus-errors.c:
8259 public API for reporting errors
8261 * dbus/dbus-connection.h, dbus/dbus-connection.c:
8262 public object representing a connection that
8263 sends/receives messages. (Same object used for
8264 both client and server.)
8266 * dbus/dbus-transport.h, dbus/dbus-transport.c:
8267 Basic abstraction for different kinds of stream
8268 that we might read/write messages from.
8270 2002-11-23 Havoc Pennington <hp@pobox.com>
8272 * dbus/dbus-internals.h (_DBUS_INT_MAX): add _DBUS_INT_MIN
8275 * dbus/dbus-test.c (main): add list test, and include
8276 dbus-test.h as intended
8278 * dbus/dbus-hash.c (_dbus_hash_table_remove_string)
8279 (_dbus_hash_table_remove_int): return value indicates
8280 whether the entry existed to remove
8282 * dbus/dbus-list.c: add linked list utility class,
8285 * dbus/dbus-hash.c: add TODO item about shrinking the hash bucket
8288 2002-11-23 Havoc Pennington <hp@pobox.com>
8290 * Doxyfile.in (INCLUDE_FILE_PATTERNS): expand DBUS_BEGIN_DECLS/
8291 DBUS_END_DECLS to nothing, that should fix this once and for all
8293 * Doxyfile.in (JAVADOC_AUTOBRIEF): set to YES
8295 * dbus/dbus-message.c, dbus/dbus-hash.c:
8296 add some missing @brief
8298 2002-11-23 Havoc Pennington <hp@pobox.com>
8300 * dbus/dbus-message.h: put semicolons after DEBUG_BEGIN_DECLS
8301 to avoid confusing Doxygen
8303 * dbus/dbus-hash.c: @} not }@
8305 * dbus/dbus-message.c (struct DBusMessage): split out
8308 2002-11-23 Havoc Pennington <hp@pobox.com>
8310 * configure.in: pile on more warning flags if using gcc
8312 * Doxyfile.in (EXTRACT_STATIC): set to NO, so we don't have
8313 to document static functions
8315 * configure.in: add summary to end of configure so it
8316 looks nice and attractive
8318 * dbus/dbus-hash.c: finish implementation and write unit
8321 * configure.in: add --enable-tests to enable unit tests
8323 * dbus/dbus-test.c: test program to run unit tests
8324 for all files in dbus/*, initially runs a test for
8327 * dbus/dbus-internals.h: file to hold some internal utility stuff
8329 2002-11-22 Havoc Pennington <hp@redhat.com>
8331 * dbus/dbus-hash.c: copy in Tcl hash table, not yet
8332 "ported" away from Tcl
8334 * dbus/dbus-types.h: header for types such as dbus_bool_t
8336 2002-11-22 Havoc Pennington <hp@redhat.com>
8338 * dbus/dbus.h: fixups for doc warnings
8340 * Doxyfile.in (FILE_PATTERNS): we need to scan .h to pick up
8342 (QUIET): make it quiet so we can see warnings
8344 * dbus/dbus-memory.c: teach D-BUS to allocate and free memory
8346 2002-11-22 Havoc Pennington <hp@redhat.com>
8348 * Makefile.am: include "Doxyfile" target in all-local
8350 * configure.in: generate the Doxyfile
8352 * Doxyfile.in: move Doxyfile here, so we can use
8353 configure to generate a Doxyfile with the right
8356 2002-11-22 Havoc Pennington <hp@redhat.com>
8358 * dbus/dbus-message.c: move inline docs into .c file
8360 * Doxyfile (OUTPUT_DIRECTORY): move output to doc/api
8361 so all docs are under doc/
8362 (MAN_EXTENSION): generate man pages. Use extension
8363 ".3dbus" which matches ".3qt" on my system,
8364 I guess this is OK, I don't know really.
8365 (FILE_PATTERNS): look for .c files not .h, makes sense
8368 2002-11-22 Havoc Pennington <hp@pobox.com>
8370 * Makefile.am (SUBDIRS): rename subdir "server" to "bus"
8371 because any app can be a server, and any app can be a client,
8372 the bus is a special kind of server.
8374 Thu Nov 21 23:35:31 2002 Zack Rusin <zack@kde.org>
8376 * Doxyfile : adding. Still needs Makefile rules to be generated
8377 automatically (just run "doxygen" in the toplevel dir for now to
8380 * dbus/dbus-message.h : Adding sample docs (javadoc since
8381 resembles gtk-doc a little more)
8383 * dbus/dbus.h : Adding sample docs
8385 2002-11-21 Havoc Pennington <hp@redhat.com>
8387 * dbus/Makefile.am (INCLUDES): define DBUS_COMPILATION
8388 so we can allow ourselves to include files directly,
8389 instead of having to use dbus.h
8391 * dbus/dbus.h: fill in
8393 * dbus/dbus-message.h: sketch out a sample header file.
8394 Include griping if you include it directly instead of
8397 * dbus/dbus-macros.h: new file with macros for extern "C",
8398 TRUE/FALSE, NULL, etc.
8400 * doc/file-boilerplate.c: put include guards in here
8402 2002-11-21 Havoc Pennington <hp@redhat.com>
8404 * doc/file-boilerplate.c: include both AFL and GPL boilerplate.
8406 * COPYING: include the GPL as well, and license code
8407 under both AFL and GPL.
8409 2002-11-21 Havoc Pennington <hp@redhat.com>
8411 * acconfig.h: get rid of this
8413 * autogen.sh (run_configure): add --no-configure option
8415 * configure.in: remove AC_ARG_PROGRAM to make
8416 autoconf complain less. add AC_PREREQ.
8417 add AC_DEFINE third arg.
8419 2002-11-21 Anders Carlsson <andersca@codefactory.se>
8422 Fix references so we can distcheck.
8424 2002-11-21 Havoc Pennington <hp@redhat.com>
8426 * Initial module creation