1 2005-01-20 Havoc Pennington <hp@redhat.com>
3 * dbus/dbus-sysdeps.c (_dbus_poll): fix several bugs in the
4 select() version, patches from Tor Lillqvist
6 2005-01-20 Havoc Pennington <hp@redhat.com>
8 * doc/dbus-tutorial.xml: replace > with >
10 * bus/services.c (bus_registry_acquire_service): validate the name
11 and return a better error if it's no good.
13 * doc/dbus-specification.xml: note NO_AUTO_START change
15 * dbus/dbus-protocol.h (DBUS_HEADER_FLAG_NO_AUTO_START): change
16 from AUTO_START, we're toggling the default
18 * bus/dispatch.c: adapt the tests to change of auto-start default
20 2005-01-18 Havoc Pennington <hp@redhat.com>
22 * rename dbus-daemon-1 to dbus-daemon throughout
24 2005-01-18 Havoc Pennington <hp@redhat.com>
26 * Throughout, grand renaming to strip out the use of "service",
27 just say "name" instead (or "bus name" when ambiguous). Did not
28 change the internal code of the message bus itself, only the
29 programmer-facing API and messages.
31 * doc/dbus-specification.xml: further update the message bus section
33 * bus/config-parser.c (all_are_equiv): fix bug using freed string
36 2005-01-17 Havoc Pennington <hp@redhat.com>
38 * dbus/dbus-types.h: remove 16-bit types since we don't use them
41 * dbus/dbus-marshal-validate.c (_dbus_validate_path): disallow any
42 "invalid name character" not only non-ASCII
44 * doc/dbus-specification.xml: further update spec, message bus
45 parts are still out-of-date but the marshaling etc. stuff is now
48 2005-01-17 Havoc Pennington <hp@redhat.com>
50 * doc/dbus-specification.xml: partially update spec
52 2005-01-17 Havoc Pennington <hp@redhat.com>
54 * Throughout, align variant bodies according to the contained
55 type, rather than always to 8. Should save a fair bit of space in
58 * dbus/dbus-marshal-validate.c (_dbus_validate_body_with_reason):
59 fix handling of case where p == end
61 * doc/TODO: remove the dbus_bool_t item and variant alignment items
63 2005-01-17 Havoc Pennington <hp@redhat.com>
65 * dbus/dbus-types.h: hardcode dbus_bool_t to 32 bits
67 * Throughout: modify DBUS_TYPE_BOOLEAN to be a 32-bit type instead
68 of an 8-bit type. Now dbus_bool_t is the type to use whenever you
69 are marshaling/unmarshaling a boolean.
71 2005-01-16 Havoc Pennington <hp@redhat.com>
73 This is about it on what can be disabled/deleted from libdbus
74 easily, back below 150K anyhow. Deeper cuts are more work than
75 just turning the code off as I've done here.
77 * dbus/dbus-marshal-basic.c (_dbus_pack_int32): we don't need the
78 signed int convenience funcs
80 * dbus/dbus-internals.c (_dbus_verbose_real): omit when not in
83 * dbus/dbus-string-util.c, dbus/dbus-string.c: more breaking
86 * dbus/dbus-sysdeps.c, dbus/dbus-sysdeps-util.c: same
88 * dbus/dbus-hash.c: purge the TWO_STRINGS crap (well, make it
89 tests-enabled-only, though it should probably be deleted)
91 * dbus/dbus-message-util.c: same stuff
93 * dbus/dbus-auth-util.c: same stuff
95 2005-01-16 Havoc Pennington <hp@redhat.com>
97 * dbus/dbus-userdb-util.c: split out part of dbus-userdb.c
99 * dbus/dbus-sysdeps.c (_dbus_uid_from_string): move here to pave
100 way for stripping down dbus-userdb.c stuff included in libdbus.
101 Rename _dbus_parse_uid for consistency.
103 2005-01-16 Havoc Pennington <hp@redhat.com>
105 * dbus/dbus-internals.c (_dbus_real_assert): print the function
106 name the assertion failed in
108 * dbus/dbus-internals.h (_dbus_return_if_fail)
109 (_dbus_return_val_if_fail): assert that the name of the function
110 containing the check doesn't start with '_', since we only want to
111 use checks on public functions
113 * dbus/dbus-connection.c (_dbus_connection_ref_unlocked): change
116 * dbus/dbus-marshal-header.c (_dbus_header_set_field_basic):
117 change checks to asserts for private function
119 * dbus/dbus-message.c (_dbus_message_set_serial): checks
120 to asserts for private function
122 * dbus/dbus-marshal-recursive.c (skip_one_complete_type): remove
123 broken assertion that was breaking make check
124 (_dbus_type_reader_array_is_empty): remove this rather than fix
125 it, was only used in assertions
127 2005-01-16 Havoc Pennington <hp@redhat.com>
129 * test/unused-code-gc.py: hacky script to find code that's used
130 only by the bus (not libdbus) or used only by tests or not used at
131 all. It has some false alarms, but looks like we can clean up a
132 lot of size from libdbus.
134 * dbus/dbus-sysdeps.c, dbus/dbus-sysdeps-utils.c,
135 dbus/Makefile.am: initially move 10K of binary size out of libdbus
137 2005-01-16 Havoc Pennington <hp@redhat.com>
139 * Add and fix docs according to Doxygen warnings throughout
142 * dbus/dbus-marshal-recursive.c
143 (_dbus_type_reader_array_is_empty): change this to just call
144 array_reader_get_array_len() and make it static
146 * dbus/dbus-message.c (dbus_message_iter_get_element_type): rename
148 (dbus_message_iter_init_append): rename from append_iter_init
150 * dbus/dbus-marshal-recursive.c
151 (_dbus_type_reader_get_element_type): rename from
152 _dbus_type_reader_get_array_type
154 2005-01-15 Havoc Pennington <hp@redhat.com>
156 * test/glib/test-profile.c (with_bus_server_filter): fix crash
158 * dbus/dbus-marshal-basic.c (_dbus_unpack_uint32): inline as macro
159 when DBUS_DISABLE_ASSERT
160 (_dbus_marshal_set_basic): be sure we align for the string length
162 * dbus/dbus-marshal-recursive.c (skip_one_complete_type): make
165 * dbus/dbus-string.c (_dbus_string_get_const_data_len): add an
167 (_dbus_string_set_byte): provide inline macro version
169 2005-01-15 Havoc Pennington <hp@redhat.com>
171 * Land the new message args API and type system.
173 This patch is huge, but the public API change is not
174 really large. The set of D-BUS types has changed somewhat,
175 and the arg "getters" are more geared toward language bindings;
176 they don't make a copy, etc.
178 There are also some known issues. See these emails for details
180 http://lists.freedesktop.org/archives/dbus/2004-December/001836.html
181 http://lists.freedesktop.org/archives/dbus/2005-January/001922.html
183 * dbus/dbus-marshal-*: all the new stuff
185 * dbus/dbus-message.c: basically rewritten
187 * dbus/dbus-memory.c (check_guards): with "guards" enabled, init
188 freed blocks to be all non-nul bytes so using freed memory is less
191 * dbus/dbus-internals.c (_dbus_test_oom_handling): add
192 DBUS_FAIL_MALLOC=N environment variable, so you can do
193 DBUS_FAIL_MALLOC=0 to skip the out-of-memory checking, or
194 DBUS_FAIL_MALLOC=10 to make it really, really, really slow and
197 * qt/message.cpp: port to the new message args API
198 (operator<<): use str.utf8() rather than str.unicode()
199 (pretty sure this is right from the Qt docs?)
201 * glib/dbus-gvalue.c: port to the new message args API
203 * bus/dispatch.c, bus/driver.c: port to the new message args API
205 * dbus/dbus-string.c (_dbus_string_init_const_len): initialize the
206 "locked" flag to TRUE and align_offset to 0; I guess we never
207 looked at these anyhow, but seems cleaner.
209 * dbus/dbus-string.h (_DBUS_STRING_ALLOCATION_PADDING):
210 move allocation padding macro to this header; use it to implement
211 (_DBUS_STRING_STATIC): ability to declare a static string.
213 * dbus/dbus-message.c (_dbus_message_has_type_interface_member):
214 change to return TRUE if the interface is not set.
216 * dbus/dbus-string.[hc]: move the D-BUS specific validation stuff
217 to dbus-marshal-validate.[hc]
219 * dbus/dbus-marshal-basic.c (_dbus_type_to_string): move here from
222 * dbus/Makefile.am: cut over from dbus-marshal.[hc]
223 to dbus-marshal-*.[hc]
225 * dbus/dbus-object-tree.c (_dbus_decompose_path): move this
226 function here from dbus-marshal.c
228 2005-01-12 Joe Shaw <joeshaw@novell.com>
230 * NEWS: Update for 0.23.
232 * configure.in: Release 0.23.
234 2005-01-12 Joe Shaw <joeshaw@novell.com>
236 * mono/Makefile.am, mono/example/Makefile.am: Always build the
237 dbus DLL with --debug. Clean up after the .mdb files this leaves
240 * mono/doc/Makefile.am: Need to uninstall the docs on "make
243 * mono/Arguments.cs (GetDBusTypeConstructor): If the type
244 is an enum, get the enum's underlying type. Another mono
247 2005-01-11 Joe Shaw <joeshaw@novell.com>
249 Patch from Sjoerd Simons <sjoerd@luon.net>
251 * mono/Makefile.am, mono/example/Makefile.am: Don't redefine
252 DESTDIR. It breaks stuff.
254 2005-01-11 Joe Shaw <joeshaw@novell.com>
256 Patch from Tambet Ingo <tambet@ximian.com>
258 * mono/DBusType/Array.cs (Get): Get the underlying element type by
259 calling type.GetElementType(). The code previously depended on
260 broken Mono behavior, which was fixed in Mono 1.1.3.
262 * mono/DBusType/Dict.cs (constructor): Fix the parameters for
263 Activator.CreateInstance() so that the class's constructor is
264 called with the right parameters.
266 2005-01-11 Joe Shaw <joeshaw@novell.com>
268 Patch from Timo Teräs <ext-timo.teras@nokia.com>
270 * dbus/dbus-connection.c
271 (_dbus_connection_queue_received_message_link): Call
272 _dbus_connection_remove_timeout() instead of the _locked()
273 variant, since it's always called from
274 _dbus_connection_handle_watch(), which handles the locking.
275 Removed the _locked() variant since it's no longer used.
277 2005-01-03 Havoc Pennington <hp@redhat.com>
279 * dbus/dbus-internals.h: I'm an idiot, _dbus_assert certainly can
282 2004-12-26 Havoc Pennington <hp@redhat.com>
284 * dbus/dbus-internals.h: add _DBUS_GNUC_NORETURN to _dbus_assert
286 2005-01-03 Havoc Pennington <hp@redhat.com>
288 * dbus/dbus-sysdeps.c (_dbus_sysdeps_test): fix using == on
291 * dbus/dbus-string.c (_dbus_string_insert_alignment): new function
293 2005-01-02 Havoc Pennington <hp@redhat.com>
295 * dbus/dbus-internals.h (_DBUS_ALIGN_OFFSET): new macro
297 2005-01-01 Havoc Pennington <hp@redhat.com>
299 * configure.in: add -Wfloat-equal
301 2005-01-01 Havoc Pennington <hp@redhat.com>
303 * dbus/dbus-sysdeps.h: add _DBUS_DOUBLES_BITWISE_EQUAL macro,
304 for a variety of reasons '==' doesn't do this.
306 2004-12-31 Havoc Pennington <hp@redhat.com>
308 * dbus/dbus-string.c (_dbus_string_equal_substrings): new function
311 2004-12-30 John (J5) Palmieri <johnp@redhat.com>
313 * python/dbus.py: s/ACTIVATION_REPLY_ACTIVE/ACTIVATION_REPLY_ACTIVATED
315 2004-12-30 John (J5) Palmieri <johnp@redhat.com>
317 * python/dbus_bindings.pyx.in: Change DBUS_ACTIVATION_REPLY_ACTIVATED
318 and DBUS_ACTIVATION_REPLY_ALREADY_ACTIVE to match the values in
319 dbus-protocol.h. Because they are defines and not enums they are not
322 2004-12-26 John (J5) Palmieri <johnp@redhat.com>
324 * python/dbus_bindings.pyx.in (bus_activate_service): Bind
325 dbus_bus_activate_service
327 * python/dbus.py (Bus.activate_service): activate a service on the
330 2004-12-24 Havoc Pennington <hp@redhat.com>
332 * test/decode-gcov.c: change to use .gcno and .gcda files, but the
333 file format has also changed and I haven't adapted to that yet
335 * Makefile.am: load .gcno files from latest gcc
337 2004-12-23 John (J5) Palmieri <johnp@redhat.com>
338 * Patch from Rob Taylor <robtaylor@fastmail.fm>
340 * python/dbus_bindings.pyx.in (bus_get_unix_user): New
343 * python/dbus.py (get_unix_user): Added binding to
344 call dbus_bindings.bus_get_unix_user
346 * python/extract.py: Modified the proto_pat regex to
349 2004-12-21 Olivier Andrieu <oliv__a@users.sourceforge.net>
351 * dbus/make-dbus-glib-error-enum.sh: omit the function keyword for
352 better POSIX compliance.
354 2004-12-19 Havoc Pennington <hp@redhat.com>
356 * dbus/dbus-string.c (_dbus_string_insert_4_aligned)
357 (_dbus_string_insert_8_aligned): new functions
359 * dbus/dbus-string.c (_dbus_string_alloc_space): new function
361 2004-12-18 Havoc Pennington <hp@redhat.com>
363 * dbus/dbus-string.c (_dbus_string_validate_ascii): use ISASCII
366 * dbus/dbus-message.c: fix a comment, and add a still-unused
367 not-implemented function
369 * dbus/dbus-marshal.h: fix comment
371 * dbus/dbus-internals.h (_DBUS_ISASCII): new macro
373 2004-12-17 Joe Shaw <joeshaw@novell.com>
375 * mono/DBusType/Byte.cs, mono/DBusType/Int32.cs,
376 mono/DBusType/Int64.cs, mono/DBusType/UInt32.cs,
377 mono/DBusType/UInt64.cs: Use Enum.GetUnderlyingType() instead of
378 Type.UnderlyingSystemType to get the actual system type
379 underneath. This code previously depended on the broken Mono
380 behavior, which was fixed in 1.1.3.
382 2004-11-27 Havoc Pennington <hp@redhat.com>
384 * dbus/dbus-string.h (_dbus_string_get_byte): inline when asserts
386 (_dbus_string_get_const_data): inline when asserts are disabled
388 * dbus/dbus-message.c: record the _dbus_current_generation of
389 creation so we can complain if dbus_shutdown() is used improperly.
390 Do this only if checks are enabled.
392 * dbus/dbus-connection.c: ditto
394 2004-11-26 Havoc Pennington <hp@redhat.com>
396 * test/glib/test-profile.c: add with_bus mode to profile echoes
397 that go through the bus.
399 * test/glib/run-test.sh: add ability to run test-profile
401 * bus/dbus-daemon-1.1.in: fix to say that SIGHUP causes partial
404 2004-11-26 Havoc Pennington <hp@redhat.com>
406 * test/glib/test-profile.c: clean up how the fake_malloc_overhead
407 thing was implemented
409 2004-11-26 Havoc Pennington <hp@redhat.com>
411 * test/glib/test-profile.c: tweak a bit, add support for some
412 made-up minimal malloc overhead with plain sockets, since in
413 real life some sort of buffers are unavoidable thus we could
414 count them in the theoretical best case
416 2004-11-26 Havoc Pennington <hp@redhat.com>
418 * dbus/dbus-message.c (dbus_message_cache_or_finalize): fix bug
419 where I was trying to cache one too many messages
421 2004-11-26 Havoc Pennington <hp@redhat.com>
423 * dbus/dbus-message.c: reimplement message cache as an array which
424 makes the cache about twice as fast and saves maybe 1.5% overall
426 2004-11-26 Havoc Pennington <hp@redhat.com>
428 * dbus/dbus-threads.c (init_global_locks): forgot to put the
429 message cache lock here
431 2004-11-26 Havoc Pennington <hp@redhat.com>
433 * dbus/dbus-message.c (struct DBusMessage): put the locked bit and
434 the "char byte_order" next to each other to save 4 bytes
435 (dbus_message_new_empty_header): reduce preallocation, since the
436 message cache should achieve a similar effect
437 (dbus_message_cache_or_finalize, dbus_message_get_cached): add a
438 message cache that keeps a few DBusMessage around in a pool,
439 another 8% speedup or so.
441 * dbus/dbus-dataslot.c (_dbus_data_slot_list_clear): new function
443 2004-11-25 Havoc Pennington <hp@redhat.com>
445 * dbus/dbus-transport-unix.c (unix_do_iteration): if we're going
446 to write, without reading or blocking, try it before the poll()
447 and skip the poll() if nothing remains to write. This is about a
448 3% speedup in the echo client/server
450 2004-11-25 Havoc Pennington <hp@redhat.com>
452 The primary change here is to always write() once before adding
453 the write watch, which gives us about a 10% performance increase.
455 * dbus/dbus-transport-unix.c: a number of modifications to cope
456 with removing messages_pending
457 (check_write_watch): properly handle
458 DBUS_AUTH_STATE_WAITING_FOR_MEMORY; adapt to removal of
459 messages_pending stuff
460 (check_read_watch): properly handle WAITING_FOR_MEMORY and
462 (unix_handle_watch): after writing, see if the write watch can be
464 (unix_do_iteration): assert that write_watch/read_watch are
465 non-NULL rather than testing that they aren't, since they
466 aren't allowed to be NULL. check_write_watch() at the end so
467 we add the watch if we did not finish writing (e.g. got EAGAIN)
469 * dbus/dbus-transport-protected.h: remove messages_pending call,
470 since it resulted in too much inefficient watch adding/removing;
471 instead we now require that the transport user does an iteration
472 after queueing outgoing messages, and after trying the first
473 write() we add a write watch if we got EAGAIN or exceeded our
474 max bytes to write per iteration setting
476 * dbus/dbus-string.c (_dbus_string_validate_signature): add this
479 * dbus/dbus-server-unix.c (unix_finalize): the socket name was
480 freed and then accessed, valgrind flagged this bug, fix it
482 * dbus/dbus-message.c: fix several bugs where HEADER_FIELD_LAST was taken
483 as the last valid field plus 1, where really it is equal to the
484 last valid field. Corrects some message corruption issues.
486 * dbus/dbus-mainloop.c: verbosity changes
488 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): handle OOM
489 instead of aborting in one of the test codepaths
491 * dbus/dbus-internals.c (_dbus_verbose_real): fix a bug that
492 caused not printing the pid ever again if a verbose was missing
493 the newline at the end
494 (_dbus_header_field_to_string): add HEADER_FIELD_SIGNATURE
496 * dbus/dbus-connection.c: verbosity changes;
497 (dbus_connection_has_messages_to_send): new function
498 (_dbus_connection_message_sent): no longer call transport->messages_pending
499 (_dbus_connection_send_preallocated_unlocked): do one iteration to
500 try to write() immediately, so we can avoid the write watch. This
501 is the core purpose of this patchset
502 (_dbus_connection_get_dispatch_status_unlocked): if disconnected,
503 dump the outgoing message queue, so nobody will get confused
504 trying to send them or thinking stuff is pending to be sent
506 * bus/test.c: verbosity changes
508 * bus/driver.c: verbosity/assertion changes
510 * bus/dispatch.c: a bunch of little tweaks to get it working again
511 because this patchset changes when/where you need to block.
513 2004-11-23 Havoc Pennington <hp@redhat.com>
515 * test/glib/test-profile.c: modify to accept a plain_sockets
516 argument in which case it will bench plain sockets instead of
517 libdbus, for comparison purposes.
519 2004-11-22 Havoc Pennington <hp@redhat.com>
521 * test/glib/test-profile.c (N_CLIENT_THREADS): run multiple
522 threads for more time, so sysprof can get a grip on it.
524 * dbus/dbus-string.c (_dbus_string_validate_utf8): remove
527 2004-11-13 Havoc Pennington <hp@redhat.com>
529 * test/glib/test-profile.c: fix this thing up a bit
531 * dbus/dbus-message.c (dbus_message_new_empty_header): increase
532 preallocation sizes by a fair bit; not sure if this will be an
533 overall performance win or not, but it does reduce reallocs.
535 * dbus/dbus-string.c (set_length, reallocate_for_length): ignore
536 the test hack that forced constant realloc if asserts are
537 disabled, so we can profile sanely. Sprinkle in some
538 _DBUS_UNLIKELY() which are probably pointless, but before I
539 noticed the real performance problem I put them in.
540 (_dbus_string_validate_utf8): micro-optimize this thing a little
541 bit, though callgrind says it didn't help; then special-case
542 ascii, which did help a lot; then be sure we detect nul bytes as
543 invalid, which is a bugfix.
544 (align_length_then_lengthen): add some more _DBUS_UNLIKELY
545 superstition; use memset to nul the padding instead of a manual
547 (_dbus_string_get_length): inline this as a
548 macro; it showed up in the profile because it's used for loop
551 2004-11-10 Colin Walters <walters@verbum.org>
553 * dbus/dbus-spawn.c (check_babysit_events): Handle EINTR,
556 2004-11-09 Colin Walters <walters@verbum.org>
558 * dbus/dbus-string.c (_dbus_string_get_length): New
559 function, writes DBusString to C buffer.
561 * dbus/dbus-string.h: Prototype it.
563 * dbus/dbus-message.c (dbus_message_type_to_string): New
564 function, converts message type into C string.
566 * dbus/dbus-message.h: Prototype it.
568 * bus/selinux.c (bus_selinux_check): Take source pid,
569 target pid, and audit data. Pass audit data to
571 (log_audit_callback): New function, appends extra
573 (bus_selinux_allows_acquire_service): Also take
574 service name, add it to audit data.
575 (bus_selinux_allows_send): Also take message
576 type, interface, method member, error name,
577 and destination, and add them to audit data.
578 (log_cb): Initialize func_audit.
580 * bus/selinux.h (bus_selinux_allows_acquire_service)
581 (bus_selinux_allows_send): Update prototypes
583 * bus/services.c (bus_registry_acquire_service): Pass
584 service name to bus_selinux_allows_acquire_service.
586 * bus/bus.c (bus_context_check_security_policy): Pass
587 additional audit data. Move assignment of dest
590 2004-11-07 Colin Walters <walters@verbum.org>
592 * dbus/dbus-transport-unix.c (do_authentication): Always
593 initialize auth_completed.
595 2004-11-07 Colin Walters <walters@verbum.org>
597 * bus/bus.c (load_config): Break into three
598 separate functions: process_config_first_time_only,
599 process_config_every_time, and process_config_postinit.
600 (process_config_every_time): Move call of
601 bus_registry_set_service_context_table into
602 process_config_postinit.
603 (process_config_postinit): New function, does
604 any processing that needs to happen late
605 in initialization (and also on reload).
606 (bus_context_new): Instead of calling load_config,
607 open config parser here and call process_config_first_time_only
608 and process_config_every_time directly. Later, after
609 we have forked but before changing UID,
610 invoke bus_selinux_full_init, and then call
611 process_config_postinit.
612 (bus_context_reload_config): As in bus_context_new,
613 load parse file inside here, and call process_config_every_time
614 and process_config_postinit.
616 * bus/services.h, bus/services.c
617 (bus_registry_set_service_context_table): Rename
618 from bus_registry_set_sid_table. Take string hash from config
619 parser, and convert them here into SIDs.
621 * bus/config-parser.c (struct BusConfigParser): Have
622 config parser only store a mapping of service->context
624 (merge_service_context_hash): New function.
625 (merge_included): Merge context string hashes instead
626 of using bus_selinux_id_table_union.
627 (bus_config_parser_new): Don't use bus_selinux_id_table_new;
628 simply create a new string hash.
629 (bus_config_parser_unref): Unref it.
630 (start_selinux_child): Simply insert strings into hash,
631 don't call bus_selinux_id_table_copy_over.
633 * bus/selinux.h, bus/selinux.c (bus_selinux_id_table_union)
634 (bus_selinux_id_table_copy_over): Delete.
636 2004-11-03 Colin Walters <walters@verbum.org>
638 * bus/selinux.c (bus_selinux_pre_init): Kill some unused
641 2004-11-03 Colin Walters <walters@verbum.org>
643 * bus/test-main.c (test_pre_hook): Fix test logic,
644 thanks Joerg Barfurth <Joerg.Barfurth@Sun.COM>.
646 2004-11-02 Colin Walters <walters@redhat.com>
648 * bus/selinux.c (bus_selinux_init): Split into two functions,
649 bus_selinux_pre_init and bus_selinux_post_init.
650 (bus_selinux_pre_init): Just determine whether SELinux is
652 (bus_selinux_post_init): Do everything else.
654 * bus/main.c (main): Call bus_selinux_pre_init before parsing
655 config file, and bus_selinux_post_init after. This ensures that
656 we don't lose the policyreload notification thread that
657 bus_selinux_init created before forking previously.
659 * bus/test-main.c (test_pre_hook): Update for split.
661 2004-10-31 Owen Fraser-Green <owen@discobabe.net>
663 Patch from Johan Fischer <linux@fischaz.com>
665 * mono/doc/Makefile.am (install-data-local): Added directory
668 2004-10-29 Colin Walters <walters@redhat.com>
670 * dbus/dbus-sysdeps.h (_dbus_become_daemon): Also take
671 parameter for fd to write pid to.
673 * dbus/dbus-sysdeps.c (_dbus_become_daemon): Implement it.
675 * bus/bus.c (bus_context_new): Pass print_pid_fd
676 to _dbus_become_daemon (bug #1720)
678 2004-10-29 Colin Walters <walters@redhat.com>
680 Patch from Ed Catmur <ed@catmur.co.uk>
682 * mono/doc/Makefile.am (install-data-local): Handle
685 2004-10-29 Colin Walters <walters@redhat.com>
687 * bus/.cvsignore, qt/.cvsignore: Update.
689 2004-10-29 Colin Walters <walters@redhat.com>
691 Patch from Kristof Vansant <de_lupus@pandora.be>
693 * configure.in: Detect Slackware.
694 * bus/Makefile.am (SCRIPT_IN_FILES): Add rc.messagebus.in.
695 * bus/rc.messagebus.in: New file.
697 2004-10-29 Colin Walters <walters@redhat.com>
699 * tools/dbus-monitor.c (filter_func): Return
700 DBUS_HANDLER_RESULT_HANDLED in filter function
702 http://freedesktop.org/pipermail/dbus/2004-August/001433.html
704 2004-10-29 Colin Walters <walters@redhat.com>
706 Patch from Matthew Rickard <mjricka@epoch.ncsc.mil>
708 * bus/services.c (bus_registry_acquire_service):
709 Correctly retrieve service name from DBusString
712 2004-10-29 Colin Walters <walters@redhat.com>
714 * dbus/dbus-glib.h: Update documentation to not
715 refer to internal APIs.
717 2004-10-27 Joe Shaw <joeshaw@novell.com>
719 * mono/Arguments.cs (GetDBusTypeConstructor):
720 type.UnderlyingSystemType will return "System.Byte" if you do it
721 on "byte[]", which is not what we want. So check the type.IsArray
722 property and use System.Array instead.
724 2004-10-25 John (J5) Palmieri <johnp@redhat.com>
726 * dbus/dbus-sysdeps.c (fill_user_info): On errors do not free
727 the DBusUserInfo structure since this is passed into the function.
728 This would cause a double free when the function that allocated
729 the structure would try to free it when an error occured.
731 * (bus/session.conf.in, bus/Makefile.am, dbus/configure.in):
732 use /usr/share/dbus-1/services instead of /usr/lib/dbus-1.0/services
733 for service activation to avoid 32bit/64bit parallel install issues
735 2004-10-21 Colin Walters <walters@verbum.org>
737 * AUTHORS: Fix my email address, the @gnu.org one
738 has been bouncing for some time. Also add J5.
740 2004-10-21 Colin Walters <walters@verbum.org>
742 * dbus/dbus-transport-unix.c (do_authentication): Return
743 authentication status to callers.
744 (unix_handle_watch): If we completed authentication this round,
745 don't do another read. Instead wait until the next iteration,
746 after we've read any pending data in the auth buffer.
747 (unix_do_iteration): Ditto.
748 (unix_handle_watch): Updated for new do_authentication prototype.
750 2004-10-18 Colin Walters <walters@verbum.org>
752 * bus/selinux.c (bus_selinux_enabled): Handle
753 --disable-selinux case.
755 2004-10-18 Colin Walters <walters@verbum.org>
757 * bus/selinux.h: Add bus_selinux_enabled.
759 * bus/selinux.c (bus_selinux_enabled): Implement it.
761 * bus/config-parser.c (struct include): Add
762 if_selinux_enabled member.
763 (start_busconfig_child): Parse if_selinux_enabled
764 attribute for include.
765 (bus_config_parser_content): Handle it.
767 * bus/session.conf.in, bus/system.conf.in: Add
768 inclusion of context mapping to default config files;
769 conditional on SELinux being enabled.
771 * doc/busconfig.dtd: Add to if_selinux_enabled to default DTD.
773 * test/data/invalid-config-files/badselinux-1.conf,
774 test/data/invalid-config-files/badselinux-2.conf:
775 Test files for bad syntax.
777 2004-10-17 Colin Walters <walters@verbum.org>
779 * dbus/dbus-memory.c (_dbus_initialize_malloc_debug, check_guards)
780 (dbus_malloc, dbus_malloc0, dbus_realloc): Fix up printf
781 format specifier mismatches.
783 2004-10-07 Olivier Andrieu <oliv__a@users.sourceforge.net>
785 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): fix an incorrect
788 * glib/dbus-dbus-gmain.c (dbus_g_bus_get): do not mangle NULL
789 pointer (bug #1540, Leonardo Boiko).
791 2004-09-28 Jon Trowbridge <trow@ximian.com>
793 * mono/BusDriver.cs: Changed BusDriver struct to remove
794 the ServiceCreated and ServiceDeleted events and replace them
795 with the new ServiceOwnerChanged event.
797 * mono/example/BusListener.cs: Added a new example program,
798 which listens for and reports any ServiceOwnerChanged events
801 * mono/example/Makefile.am (DESTDIR): Build changes for the
802 new BusListener.cs example.
804 2004-09-27 Olivier Andrieu <oliv__a@users.sourceforge.net>
806 * bus/signals.c (bus_match_rule_parse): validate the components of
807 match rules (bug #1439).
809 * dbus/dbus-bus.c (dbus_bus_add_match): add a missing OOM test.
811 2004-09-24 Olivier Andrieu <oliv__a@users.sourceforge.net>
813 * doc/dbus-specification.xml: document ServiceOwnerChanged
816 * bus/driver.c, bus/driver.h, bus/services.c: Use
817 ServiceOwnerChanged signal instead of ServiceCreated and
820 * bus/dispatch.c: update testcase for the new signal.
822 2004-09-20 Jon Trowbridge <trow@ximian.com>
824 Patch from Nat Friedman <nat@novell.com>
826 * mono/Makefile.am: A number of small build fixes to allow "make
827 distcheck" to succeed.
829 * mono/example/Makefile.am: "make distcheck" fixes.
831 * mono/AssemblyInfo.cs.in: When signing the assembly, look for the
834 * test/Makefile.am: "make distcheck" fixes.
836 2004-09-17 Olivier Andrieu <oliv__a@users.sourceforge.net>
838 * dbus/dbus-sysdeps.c (_dbus_user_at_console): fix memleak in OOM.
840 * doc/busconfig.dtd: update the DTD for the at_console attribute.
842 * bus/driver.c (bus_driver_handle_hello): correctly handle Hello
843 messages after the first one (bug #1389).
845 * bus/dispatch.c (check_double_hello_message): add a test case for
846 the double hello message bug.
847 (check_existent_service_activation): fix check of spawning error.
849 2004-09-16 David Zeuthen <david@fubar.dk>
851 * python/dbus_bindings.pyx.in: Add support for int64 and uint64
853 2004-09-12 David Zeuthen <david@fubar.dk>
855 Patch from Kay Sievers <kay.sievers@vrfy.org>
857 * bus/bus.c (bus_context_new):
861 Add commandline option --nofork to override configuration file
864 2004-09-09 Olivier Andrieu <oliv__a@users.sourceforge.net>
866 * dbus/dbus-*.h: remove the ; after DBUS_(BEGIN|END)_DECLS. Some C
867 compilers don't like it (bug #974).
869 2004-09-04 Harald Fernengel <harry@kdevelop.org>
871 * qt/connection.*: Applied patch by Jérôme Lodewyck
872 <lodewyck@clipper.ens.fr> to integrate an existing
873 connection into the Qt eventloop
875 2004-08-30 Jon Trowbridge <trow@ximian.com>
877 * mono/BusDriver.cs: Added. This is a class for interacting with
878 the org.freedesktop.DBus service.
880 * mono/Message.cs: Added a mechanism to expose the message that is
881 currently being dispatched via the static Message.Current
882 property. Added Message.Sender and Message.Destination
885 * mono/Handler.cs: Expose the dispatched message via
886 Message.Current when handling method calls.
888 * mono/Service.cs: Expose the dispatched message via
889 Message.Current when handling signal emissions.
891 * mono/Connection.cs: Bind dbus_bus_get_base_service via the
892 Connection.BaseService property.
894 2004-08-28 Havoc Pennington <hp@redhat.com>
896 * dbus/dbus-userdb.c (_dbus_is_console_user): remove unused variable
898 More fixes from Steve Grubb
900 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): fix fd leak
901 (_dbus_listen_tcp_socket): fix fd leak
903 * dbus/dbus-spawn.c (read_pid, read_ints): move the "again:" for
904 EINTR to a bit lower in the code
906 2004-08-26 Jon Trowbridge <trow@ximian.com>
908 * bus/driver.c (bus_driver_handle_service_exists): Respond with
909 TRUE if we are inquiring about the existence of the built-in
910 org.freedesktop.DBus service.
912 2004-08-25 John Palmieri <johnp@redhat.com>
913 * bus/config-parser.c:
914 (struct PolicyType): Add POLICY_CONSOLE
915 (struct Element.d.policy): s/gid_or_uid/gid_uid_or_at_console
916 (start_busconfig_child): Sets up console element when
917 <policy at_console=""> is encountered in a policy file
918 (append_rule_from_element): Convert console elements to console
922 (bus_policy_create_client_policy): Add console rules to the client
923 policy based on if the client is at the console
924 (bus_policy_append_console_rule): New function for adding a
925 console rule to a policy
926 (bus_policy_merge): Handle console rule merging
928 * dbus/dbus-sysdeps.h: Added the DBUS_CONSOLE_DIR constant
929 where we check for console user files
931 * dbus/dbus-sysdeps.c:
932 (_dbus_file_exists): New function which checks if the given
934 (_dbus_user_at_console): New function which does the system
935 specific process of checking if the user is at the console
937 * dbus/dbus-userdb.c:
938 (_dbus_is_console_user): New function converts a UID to user name
939 and then calls the system specific _dbus_user_at_console to
940 see if the user is at the console and therefor a console user
942 2004-08-25 Olivier Andrieu <oliv__a@users.sourceforge.net>
944 * bus/config-parser.c (set_limit):
945 * bus/dbus-daemon-1.1.in:
946 * test/data/valid-config-files/many-rules.conf: set the
947 max_match_rules_per_connection limt from the config file.
949 * doc/busconfig.dtd: update the DTD.
951 * bus/driver.c: remove some unused variables.
953 2004-08-24 Mikael Hallendal <micke@imendio.com>
955 * dbus/dbus-glib-lowlevel.h: Removed dbus_bus_get_with_g_main since
956 it's been replaced by dbus_g_bus_get
958 2004-08-23 Colin Walters <walters@redhat.com>
960 Updated SELinux support from Matthew Rickard <mjricka@epoch.ncsc.mil>
962 * bus/selinux.h: Prototype bus_selinux_get_policy_root.
964 * bus/selinux.c: Create a thread for policy reload notification.
965 (bus_selinux_get_policy_root): Implement.
967 * bus/config-parser.c (start_busconfig_child)
968 (bus_config_parser_content): Support SELinux-root relative
971 * configure.in <HAVE_SELINUX>: Add -lpthread.
973 * bus/test-main.c (test_pre_hook, test_post_hook): New.
974 (test_post_hook): Move memory checking into here.
975 (test_pre_hook, test_post_hook): Move SELinux checks in
976 here, but conditional on a DBUS_TEST_SELINUX environment
977 variable. Unfortunately we can't run the SELinux checks
978 as a normal user, since they won't have any permissions
979 for /selinux. So this will have to be tested manually
980 for now, until we have virtualization for most of
983 2004-08-23 Havoc Pennington <hp@redhat.com>
985 * dbus/dbus-sysdeps.c (_dbus_change_identity): add setgroups() to
986 drop supplementary groups, suggested by Steve Grubb
988 2004-08-20 Colin Walters <walters@redhat.com>
990 * bus/config-parser.c (start_busconfig_child): Remove some unused
993 * bus/selinux.c (bus_selinux_id_table_insert): Avoid compiler
996 2004-08-17 Joe Shaw <joeshaw@novell.com>
998 * configure.in: If --enable-mono is passed in, if we can't find
1001 * mono/Makefile.am: Use /gacutil to install assemblies into the
1004 2004-08-12 Havoc Pennington <hp@redhat.com>
1006 * NEWS: update for 0.22
1008 * configure.in: release 0.22
1010 2004-08-11 Colin Walters <walters@redhat.com>
1012 * tools/dbus-send.c (main, usage): Add --reply-timeout
1015 2004-08-10 Olivier Andrieu <oliv__a@users.sourceforge.net>
1017 * bus/bus.c (process_config_first_time_only): get rid of an unused
1018 DBusError that was causing a memoy leak (bug #989).
1020 * dbus/dbus-keyring.c, dbus/dbus-message.c:
1021 fix compilation on Solaris/Forte C (bug #974)
1023 * bus/main.c (main): plug two minuscule memleaks.
1025 2004-08-10 Havoc Pennington <hp@redhat.com>
1027 * doc/dbus-tutorial.xml: add some more info on GLib bindings
1029 2004-08-09 Havoc Pennington <hp@redhat.com>
1031 * COPYING: switch to Academic Free License version 2.1 instead of
1032 2.0, to resolve complaints about patent termination clause.
1034 2004-07-31 John (J5) Palmieri <johnp@redhat.com>
1036 * README: added documentation for the --enable-python
1039 2004-07-31 Olivier Andrieu <oliv__a@users.sourceforge.net>
1041 * bus/config-parser.c (bus_config_parser_new): fix an invalid
1042 _unref in the SELinux support.
1044 * doc/busconfig.dtd: update DTD for SELinux support.
1046 * bus/config-loader-libxml.c: fix error handler and parser
1047 initialisation/cleanup. OOM test now works with libxml2 HEAD.
1049 * configure.in: remove the warning about libxml2.
1051 * dbus/dbus-bus.c: silence doxygen warning.
1053 2004-07-31 Colin Walters <walters@redhat.com>
1055 * configure.in: Move #error in SELinux check to its own line.
1057 2004-07-31 Olivier Andrieu <oliv__a@users.sourceforge.net>
1059 * dbus/dbus-internals.h (_DBUS_SET_OOM):
1060 * bus/utils.h (BUS_SET_OOM): use dbus_error_set_const instead of
1063 * bus/dispatch.c (check_send_exit_to_service): fix the test case,
1064 broken by the change in the _SET_OOM macros.
1066 2004-07-31 Colin Walters <walters@redhat.com>
1068 * bus/selinux.c <HAVE_SELINUX>: Include utils.h to get
1071 2004-07-31 Colin Walters <walters@redhat.com>
1073 * configure.in: Use AC_TRY_COMPILE instead of AC_EGREP_HEADER
1074 to correctly detect DBUS__ACQUIRE_SVC. Also add an
1077 2004-07-24 Havoc Pennington <hp@redhat.com>
1079 SELinux support from Matthew Rickard <mjricka@epoch.ncsc.mil>
1081 * bus/selinux.c, bus/selinux.h: new file encapsulating selinux
1084 * configure.in: add --enable-selinux
1086 * bus/policy.c (bus_policy_merge): add FIXME to a comment
1088 * bus/main.c (main): initialize and shut down selinux
1090 * bus/connection.c: store SELinux ID on each connection, to avoid
1091 repeated getting of the string context and converting it into
1094 * bus/bus.c (bus_context_get_policy): new accessor, though it
1096 (bus_context_check_security_policy): check whether the security
1097 context of sender connection can send to the security context of
1098 recipient connection
1100 * bus/config-parser.c: add parsing for <selinux> and <associate>
1102 * dbus/dbus-transport.c (_dbus_transport_get_unix_fd): to
1103 implement dbus_connection_get_unix_fd()
1105 * dbus/dbus-connection.c (dbus_connection_get_unix_fd): new
1106 function, used by the selinux stuff
1108 2004-07-29 Olivier Andrieu <oliv__a@users.sourceforge.net>
1110 * bus/config-loader-libxml.c: complete the implementation of
1111 libxml backend for config file loader. Doesn't work with full OOM
1114 * configure.in: change error when selecting libxml into a warning.
1116 * test/data/invalid-config-files: add two non-well-formed XML
1119 * glib/Makefile.am: libdbus_gtool always uses expat, not libxml.
1121 * dbus/dbus-transport-unix.c (unix_handle_watch): do not
1122 disconnect in case of DBUS_WATCH_HANGUP, several do_reading() may
1123 be necessary to read all the buffer. (bug #894)
1125 * bus/activation.c (bus_activation_activate_service): fix a
1126 potential assertion failure (bug #896). Small optimization in the
1127 case of auto-activation messages.
1129 * dbus/dbus-message.c (verify_test_message, _dbus_message_test):
1130 add test case for byte-through-vararg bug (#901). patch by Kimmo
1133 2004-07-28 Anders Carlsson <andersca@gnome.org>
1136 * python/dbus_bindings.pyx.in:
1137 Add dbus.init_gthreads (), allow emit_signal to pass
1138 arguments to the signal.
1140 2004-07-24 Havoc Pennington <hp@redhat.com>
1142 * AUTHORS: add some people, not really comprehensively, let me
1143 know if I missed you
1145 2004-07-24 Havoc Pennington <hp@redhat.com>
1147 * Makefile.am (DIST_SUBDIRS): add DIST_SUBDIRS, problem solved by
1150 * test/Makefile.am (DIST_SUBDIRS): here also
1152 2004-07-22 Olivier Andrieu <oliv__a@users.sourceforge.net>
1154 * dbus/dbus-sysdeps.c (fill_user_info): fix inexistent label name,
1155 breaking build on Solaris, reported by Farhad Saberi on the ML.
1157 * dbus/dbus-message.c (dbus_message_append_args_valist): fix the
1158 va_arg invocation to account for integer promotion in the case of
1159 DBUS_TYPE_BYTE (unsigned char is promoted to int). (bug #901)
1161 * bus/services.c (bus_service_remove_owner): fix bug #902, use
1162 _dbus_list_get_first_link, not _dbus_list_get_first.
1164 * dbus/dbus-bus.c (dbus_bus_service_exists): plug a memory leak.
1166 * dbus/dbus-object-tree.c (free_subtree_recurse): always null
1167 handler functions so that the asserts in _dbus_object_subtree_unref
1170 * dbus/dbus-transport-unix.c (do_reading):
1171 _dbus_transport_queue_messages return value is of type
1172 dbus_bool_t, not DBusDispatchStatus.
1174 2004-07-19 David Zeuthen <david@fubar.dk>
1176 * dbus/dbus-protocol.h: Add DBUS_ERROR_UNIX_PROCESS_ID_UNKNOWN
1179 (check_get_connection_unix_user): Debug says GetProperty; but the
1180 method is called GetConnectionUnixUser
1181 (check_get_connection_unix_process_id): New function
1182 (bus_dispatch_test): Actually call check_get_connection_unix_user();
1183 also call check_get_connection_unix_process_id()
1186 (bus_driver_handle_get_connection_unix_process_id): New function,
1187 handles GetConnectionUnixProcessID on the org.freedesktop.DBus
1191 (handle_server_data_external_mech): Set pid from the credentials
1192 obtained from the socket
1194 * dbus/dbus-connection.c:
1195 (dbus_connection_get_unix_process_id): New function
1197 * dbus/dbus-connection.h:
1198 Add prototype for dbus_connection_get_unix_process_id
1200 * dbus/dbus-transport.c:
1201 (_dbus_transport_get_unix_process_id): New function
1203 * dbus/dbus-transport.h:
1204 Add prototype for _dbus_transport_get_unix_process_id
1206 2004-07-19 Olivier Andrieu <oliv__a@users.sourceforge.net>
1208 * dbus/dbus-message.c: Message counter fix, patch by Christian
1209 Hammond <chipx86@gnupdate.org>
1211 2004-07-18 Seth Nickell <seth@gnome.org>
1214 * python/dbus_bindings.pyx.in:
1215 * python/tests/test-client.py:
1217 Add dbus.ByteArray and dbus_bindings.ByteArray
1218 types so that byte streams can be passed back.
1220 Give jdahlin the heaps of credit that are so
1223 2004-07-12 Seth Nickell <seth@gnome.org>
1227 Add message argument to the default object_method_handler
1230 * python/dbus_bindings.pyx.in:
1232 Automatically return NIL when passed an empty list
1233 (we can't pass back a list since lists are typed
1234 and we don't have any idea what type the the client
1235 intended the list to be... :-( )
1237 2004-07-10 Seth Nickell <seth@gnome.org>
1239 * python/examples/Makefile.am:
1241 Fix distcheck breakage caused by new examples.
1243 2004-07-10 Seth Nickell <seth@gnome.org>
1247 Add "message" argument to service-side dbus.Object
1248 methods. This will break existing services written
1249 using the python bindings, but will allow extraction
1250 of all the message information (e.g. who its from).
1252 Add improved "object oriented" signal handling/emission.
1254 * python/examples/example-service.py:
1258 * python/examples/example-signal-emitter.py:
1259 * python/examples/example-signal-recipient.py:
1261 Two new examples that show how to emit and receive
1262 signals using the new APIs.
1264 * python/examples/example-signals.py:
1265 * python/examples/gconf-proxy-service.py:
1266 * python/examples/gconf-proxy-service2.py:
1268 Add "message" argument to service methods.
1270 2004-06-28 Kay Sievers <kay.sievers@vrfy.org>
1272 * bus/driver.c (bus_driver_handle_get_connection_unix_user)
1273 * dbus/bus.c (dbus_bus_get_unix_user)
1274 * doc/dbus-specification.xml: implement GetConnectionUnixUser
1275 method of org.freedesktop.DBus interface.
1277 * bus/dispatch.c: test case
1279 2004-06-23 John (J5) Palmieri <johnp@redhat.com>
1281 * python/Makefile.am: switched include directory from glib/ to dbus/
1282 since dbus-glib.h moved
1284 2004-06-22 Olivier Andrieu <oliv__a@users.sourceforge.net>
1286 * configure.in: prevent building the gcj stuff and libxml loader
1287 since they are broken.
1289 2004-06-20 Havoc Pennington <hp@redhat.com>
1291 * dbus/dbus-glib-error-enum.h: autogenerate the GError enum
1292 codes from the dbus error names
1294 * glib/dbus-glib.h: move to subdir dbus/ since it's included
1295 as dbus/dbus-glib.h and that breakage is now visible due to
1296 including dbus/dbus-glib.h in dbus-glib-lowlevel.h
1298 * glib/dbus-glib.h: s/gproxy/g_proxy/
1300 * dbus/dbus-shared.h: new header to hold stuff shared with
1303 * dbus/dbus-protocol.h (DBUS_ERROR_*): move errors here rather
1306 * glib/dbus-glib.h (dbus_set_g_error): move to
1307 dbus-glib-lowlevel.h
1309 * glib/dbus-glib.h: remove dbus/dbus.h from here; change a bunch
1310 of stuff to enable this
1312 * dbus/dbus-glib-lowlevel.h: put dbus/dbus.h here
1314 * a bunch of other changes with the same basic "separate glib
1315 bindings from dbus.h" theme
1317 2004-06-10 Owen Fraser-Green <owen@discobabe.net>
1319 * dbus-sharp.pc.in: Removed glib-sharp inclusion in Libs.
1321 * python/examples/Makefile.am: Fixed typo in EXTRA_DIST.
1323 2004-06-09 Olivier Andrieu <oliv__a@users.sourceforge.net>
1325 * bus/driver.c, dbus/dbus-bus.c: use BOOLEAN instead of UINT32 for
1326 the reply value of the ServiceExists message.
1328 2004-06-07 John (J5) Palmieri <johnp@redhat.com>
1330 * python/dbus_bindings.pyx.in: No longer need to parse path
1331 elements and pass them as arrays of strings. The C API now
1332 accepts plain path strings.
1333 (_build_parsed_path): removed
1335 2004-06-07 Havoc Pennington <hp@redhat.com>
1337 * doc/TODO: remove auto-activation item since it's done; sort
1338 items by importance/milestone
1340 2004-06-07 Havoc Pennington <hp@redhat.com>
1342 * dbus/dbus-message-builder.c (_dbus_message_data_load): append
1343 random signature when using REQUIRED_FIELDS (this hack won't work
1346 * dbus/dbus-message.c: change the signature to be a header field,
1347 instead of message->signature special-case string. Incremental
1348 step forward. Then we can fix up code to send the signature in the
1349 message, then fix up code to validate said signature, then fix up
1350 code to not put the typecodes inline, etc.
1351 (load_one_message): don't make up the signature after the fact
1352 (decode_header_data): require signature field for the known
1355 * dbus/dbus-marshal.c (_dbus_marshal_string_len): new
1357 * dbus/dbus-protocol.h: add DBUS_HEADER_FIELD_SIGNATURE
1359 2004-06-07 Owen Fraser-Green <owen@discobabe.net>
1361 * mono/DBusType/ObjectPath.cs: Renamed PathName argument to Path
1363 * mono/Handler.cs: Updated to follow new path argument for
1364 (un-)registering objects.
1366 * mono/example/Makefile.am:
1368 * configure.in: Bumped required version for mono and use new -pkg
1371 2004-06-05 Olivier Andrieu <oliv__a@users.sourceforge.net>
1373 * dbus/dbus-connection.h, dbus/dbus-connection.c: have object path
1374 registration functions take the path argument as char* instead of
1377 * dbus/dbus-marshal.h, dbus/dbus-marshal.c (_dbus_decompose_path):
1378 split off the path decompostion part of
1379 _dbus_demarshal_object_path. Some misc. fixes to silence compiler
1382 * glib/dbus-gobject.c, test/test-service.c: update accordingly.
1384 2004-06-02 Kristian Høgsberg <krh@redhat.com>
1386 * dbus/dbus-auth.c: Rewrite auth protocol handling to use a state
1387 machine approach. A state is implemented as a function that
1388 handles incoming events as specified for that state.
1390 * doc/dbus-specification.xml: Update auth protocol state machine
1391 specification to match implementation. Remove some leftover
1394 2004-06-02 Kristian Høgsberg <krh@redhat.com>
1396 * glib/dbus-gproxy.c, glib/dbus-gmain.c, dbus/dbus-string.c,
1397 dbus/dbus-object-tree.c, dbus/dbus-message.c: add comments to
1400 * Doxyfile.in: remove deprecated options.
1402 * dbus/dbus-message-handler.c, dbus/dbus-message-handler.h,
1403 glib/test-thread.h, glib/test-thread-client.c,
1404 glib/test-thread-server.c, glib/test-profile.c,
1405 glib/test-dbus-glib.c: remove these unused files.
1407 2004-06-01 Olivier Andrieu <oliv__a@users.sourceforge.net>
1409 * dbus/dbus-object-tree.c
1410 (_dbus_object_tree_dispatch_and_unlock): fix dispatch for
1411 non-fallback handlers (bug #684).
1412 (_dbus_object_subtree_new): initialize invoke_as_fallback field.
1413 (find_subtree_recurse): report wether the returned subtree is an
1414 exact match or a "fallback" match higher up in the tree.
1415 (object_tree_test_iteration): update test case.
1417 2004-06-01 Seth Nickell <seth@gnome.org>
1419 * python/dbus_bindings.pyx.in:
1420 * python/tests/test-client.py:
1422 Round off basic type support. Add dicts (yay!), and
1423 remaining array types.
1425 Make MessageIter more general so it works for dicts too.
1427 Mark all loop variables as C integers.
1429 2004-05-31 Havoc Pennington <hp@redhat.com>
1431 * glib/dbus-gidl.c (method_info_add_arg): keep args sorted with
1434 * glib/dbus-gobject.c (dbus_type_to_string): move to dbus-gutils.c
1436 * glib/dbus-glib-tool.c (main): set up to have a --self-test
1437 option that runs the tests, and start filling in some code
1438 including for starters just dumping the interfaces to stdout
1440 * glib/Makefile.am (INCLUDES): define DBUS_LOCALEDIR
1442 * test/data/valid-introspection-files/lots-of-types.xml: test of
1443 an example introspection file
1445 * glib/dbus-gparser.c (parser_check_doctype): doctype should be
1448 2004-05-31 Seth Nickell <seth@gnome.org>
1450 * python/dbus_bindings.pyx.in:
1451 * python/tests/test-client.py:
1456 Fix string array memory trashing bug... oops...
1458 2004-05-30 Seth Nickell <seth@gnome.org>
1462 Add a nicer-but-less-flexible alternate API for handling
1463 calls to virtual objects in dbus.ObjectTree.
1465 Screw up the argument order to the dbus.Object constructor
1466 for consistency with dbus.ObjectTree (and to make dbus_methods
1467 optional for future extension)
1469 * python/examples/Makefile.am:
1470 * python/examples/gconf-proxy-service.py:
1471 * python/examples/gconf-proxy-service2.py:
1473 Alternate implementation of gconf-proxy-service using the
1474 nicer dbus.ObjectTree API.
1476 * python/examples/example-service.py:
1477 * python/tests/test-server.py
1479 Reverse the argument order to deal with dbus.Object constructor
1482 2004-05-30 Seth Nickell <seth@gnome.org>
1484 * python/examples/example-client.py:
1485 * python/examples/example-service.py:
1487 Take it back. Lists seem to work but they're broken
1488 in the test suite. Make the base examples use
1491 2004-05-30 Seth Nickell <seth@gnome.org>
1493 * python/dbus_bindings.pyx.in:
1494 * python/tests/test-client.py:
1496 Add some more tests and fix errors that crop up.
1497 Unfortunately, currently it seems like marshalling
1498 and unmarshalling of lists is completely broken :-(
1500 2004-05-30 Seth Nickell <seth@gnome.org>
1502 * python/dbus_bindings.pyx.in:
1504 Add support for ObjectPath type.
1508 Refactor message handling code to a common function.
1510 * python/tests/test-client.py:
1511 * python/tests/test-server.py:
1513 Add tests that check to make sure values of all types
1514 can be echoed from a service w/o mangling.
1516 2004-05-29 Seth Nickell <seth@gnome.org>
1520 Add ObjectTree class which allows implementation
1521 of trees of "virtual" objects. Basically the python
1522 wrapper for "register_fallback".
1524 * python/examples/Makefile.am
1525 * python/examples/gconf-proxy-client.py:
1526 * python/examples/gconf-proxy-service.py:
1528 Implement a simple GConf proxy service that supports
1529 get/set on string and int GConf keys using the ObjectTree.
1531 2004-05-29 Seth Nickell <seth@gnome.org>
1534 * python/examples/example-client.py:
1535 * python/examples/example-service.py:
1536 * python/examples/list-system-services.py:
1538 Add SessionBus, SystemBus and ActivationBus classes
1539 so you don't need to know the special little BUS_TYPE
1542 2004-05-29 Havoc Pennington <hp@redhat.com>
1544 * bus/config-parser.c (process_test_valid_subdir): temporarily
1545 stop testing config parser OOM handling, since expat has issues
1546 http://freedesktop.org/pipermail/dbus/2004-May/001153.html
1548 * bus/dbus-daemon-1.1.in: change requested_reply to
1549 send_requested_reply/receive_requested_reply so we can send the
1550 replies, not just receive them.
1552 * bus/config-parser.c: parse the new
1553 send_requested_reply/receive_requested_reply
1555 * bus/policy.c (bus_client_policy_check_can_send): add
1556 requested_reply argument and use it
1558 * bus/bus.c (bus_context_check_security_policy): pass through
1559 requested_reply status to message send check
1561 * bus/system.conf.in: adapt to requested_reply change
1563 2004-05-28 Havoc Pennington <hp@redhat.com>
1565 * test/glib/test-service-glib.c (main): remove unused variable
1567 * glib/dbus-gidl.c (base_info_ref): fix a silly compiler warning
1569 * dbus/dbus-auth.h (enum): remove AUTHENTICATED_WITH_UNUSED_BYTES
1570 from the enum, no longer in use.
1572 * dbus/dbus-sysdeps.h: include config.h so DBUS_VA_COPY actually
1575 * dbus/dbus-message.c: add various _dbus_return_val_if_fail for
1576 whether error_name passed in is a valid error name.
1578 2004-05-28 John (J5) Palmieri <johnp@redhat.com>
1580 * dbus/dbus-message.c (dbus_message_get_args): Added support for
1581 OBJECT_PATH and OBJECT_PATH_ARRAY
1583 2004-05-28 Seth Nickell <seth@gnome.org>
1585 * python/examples/Makefile.am:
1587 Forget to add Makefile.am. Do not pass go.
1589 2004-05-28 Michael Meeks <michael@ximian.com>
1591 * glib/dbus-gvalue.c (dbus_gvalue_marshal, dbus_gvalue_demarshal):
1594 * dbus/dbus-string.c (_dbus_string_parse_basic_type): impl.
1596 * dbus/dbus-message.c (_dbus_message_iter_get_basic_type),
1597 (_dbus_message_iter_get_basic_type_array): impl.
1598 drastically simplify ~all relevant _get methods to use these.
1599 (_dbus_message_iter_append_basic_array),
1600 (dbus_message_iter_append_basic): impl
1601 drastically simplify ~all relevant _append methods to use these.
1603 * dbus/dbus-message-builder.c (parse_basic_type)
1604 (parse_basic_array, lookup_basic_type): impl.
1605 (_dbus_message_data_load): prune scads of duplicate /
1608 * dbus/dbus-marshal.c (_dbus_demarshal_basic_type_array)
1609 (_dbus_demarshal_basic_type): implement,
1610 (demarshal_and_validate_len/arg): beef up debug.
1611 (_dbus_marshal_basic_type, _dbus_marshal_basic_type_array): impl.
1613 2004-05-27 Seth Nickell <seth@gnome.org>
1616 * python/Makefile.am:
1618 Include the example python apps in the tarball.
1620 * python/examples/list-system-services.py
1622 Add a python new example that fetches the list of services
1623 from the system bus.
1625 2004-05-27 Seth Nickell <seth@gnome.org>
1628 * python/dbus_bindings.pyx.in:
1630 Fix failure to notify that a signal was not handled,
1631 resulted in hung functions.
1633 2004-05-25 Colin Walters <walters@redhat.com>
1635 * tools/dbus-monitor.c (main): Monitor all types of messages.
1637 2004-05-23 Owen Fraser-Green <owen@discobabe.net>
1639 * mono/Handler.cs, mono/Service.cs: Added UnregisterObject method
1640 which unregisters the object path and disposes the handler.
1642 2004-05-23 Kristian Høgsberg <krh@redhat.com>
1644 Patch from Timo Teräs <ext-timo.teras@nokia.com> (#614):
1646 * dbus/dbus-message.c (dbus_message_iter_get_args_valist): Swap
1647 operands to && so we call dbus_message_iter_next () for the last
1650 2004-05-21 Olivier Andrieu <oliv__a@users.sourceforge.net>
1652 * dbus/dbus-object-tree.c
1653 (_dbus_object_tree_list_registered_unlock, lookup_subtree): return
1654 children even if the requested path isn't registered.
1655 (object_tree_test_iteration): test object_tree_list_registered.
1657 * configure.in: undefine HAVE_ABSTRACT_SOCKETS instead of defining
1660 2004-05-20 Kristian Høgsberg <krh@redhat.com>
1662 * doc/TODO: Remove resolved items.
1664 * bus/expirelist.h (struct BusExpireList): remove unused n_items
1667 * bus/connection.c (bus_connections_expect_reply): Enforce the
1668 per-connection limit on pending replies.
1670 Patch from Jon Trowbridge <trow@ximian.com>:
1672 * bus/main.c (setup_reload_pipe): Added. Creates a pipe and sets
1673 up a watch that triggers a config reload when one end of the pipe
1675 (signal_handler): Instead of doing the config reload in our SIGHUP
1676 handler, just write to the reload pipe and let the associated
1677 watch handle the reload when control returns to the main loop.
1679 * bus/driver.c (bus_driver_handle_reload_config): Added.
1680 Implements a ReloadConfig method for requesting a configuration
1681 file reload via the bus driver.
1683 2004-05-19 Owen Fraser-Green <owen@discobabe.net>
1685 * HACKING: Updated release instructions concerning the wiki page.
1687 2004-05-18 Kristian Høgsberg <krh@redhat.com>
1689 * dbus/dbus-auth.c (client_try_next_mechanism): Remove logic to
1690 filter against auth->allowed_mechs; we only add allowed mechs in
1691 record_mechanisms().
1693 * dbus/dbus-auth-script.c (_dbus_auth_script_run): Add an
1694 ALLOWED_MECHS to auth-script format so we can set the list of
1697 * data/auth/client-out-of-mechanisms.auth-script: New test to
1698 check client disconnects when it is out of mechanisms to try.
1700 * dbus/dbus-auth.c (process_command): Remove check for lines
1701 longer that 1 MB; we only buffer up maximum 16 kB.
1703 * dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
1704 dbus/dbus-auth-script.c, dbus/dbus-auth.c, dbus/dbus-auth.h:
1705 Remove auth state AUTHENTICATED_WITH_UNUSED_BYTES, instead always
1706 assume there might be unused bytes.
1708 * dbus/dbus-auth.c (_dbus_auth_do_work): Remove check for
1709 client-out-of-mechs, it is handled in process_reject(). Move check
1710 for max failures to send_rejected(), as it's a server-only thing.
1712 * dbus/dbus-auth.c: Factor out protocol reply code into functions
1713 send_auth(), send_data(), send_rejected(), send_error(),
1714 send_ok(), send_begin() and send_cancel().
1716 2004-05-17 Kristian Høgsberg <krh@redhat.com>
1718 Remove base64 encoding, replace with hex encoding. Original patch
1719 from trow@ximian.com, added error handling.
1721 * dbus/dbus-string.c (_dbus_string_base64_encode)
1722 (_dbus_string_base64_decode): Remove.
1723 (_dbus_string_hex_decode): Add end_return argument so we can
1724 distinguish between OOM and invalid hex encoding.
1725 (_dbus_string_test): Remove base64 tests and add test case for
1728 * dbus/dbus-keyring.c, dbus/dbus-auth-script.c, dbus/dbus-auth.c:
1729 Replace base64 with hex.
1731 * test/data/auth/invalid-hex-encoding.auth-script: New test case
1732 for invalid hex encoded data in auth protocol.
1734 2004-05-17 Olivier Andrieu <oliv__a@users.sourceforge.net>
1736 * dbus/dbus-connection.c (check_for_reply_unlocked): plug a memory
1739 2004-05-15 Owen Fraser-Green <owen@discobabe.net>
1741 * mono/dbus-sharp.dll.config.in: Added for GAC
1742 * mono/dbus-sharp.snk: Added for GAC
1743 * mono/Assembly.cs.in: Added for GAC
1744 * mono/Makefile.am: Changes for GAC installation
1745 * configure.in: Added refs for dbus-sharp.dll.config.in and
1746 Assembly.cs.in. More fixes for mono testing
1747 * mono/example/Makefile.am: Changed var to CSC
1748 * Makefile.am: Changed flag name to DBUS_USE_CSC
1750 2004-05-15 Owen Fraser-Green <owen@discobabe.net>
1752 * mono/Makefile.am: Added SUBDIRS for docs. Changed SUBDIRS order
1753 * mono/doc/*: Added documentation framework
1754 * configure.in: Added monodoc check
1755 * README: Added description of mono configure flags
1757 2004-05-11 John (J5) Palmieri <johnp@redhat.com>:
1759 * doc/dbus-specification.xml: Added a "Required" column to the
1760 header fields table and changed the "zero or more" verbage in
1761 the above paragraph to read "The header must contain the required
1762 named header fields and zero or more of the optional named header
1764 * test/data/invalid-messages/*.message: Added the required PATH
1765 named header field to the tests so that they don't fail on
1766 'Missing path field'
1768 2004-05-07 John (J5) Palmieri <johnp@redhat.com>
1770 * python/dbus-bindings.pyx.in: Stopped the bindings from trashing
1771 the stack by implicitly defining variable and parameter types and
1772 removing the hack of defining C pointers as python objects and later
1775 2004-05-02 Owen Fraser-Green <owen@discobabe.net>
1777 * mono/Makefile.am: Removed test-dbus-sharp.exe from all target
1779 2004-05-01 Owen Fraser-Green <owen@discobabe.net>
1781 * mono/DBusType/Dict.cs: Handle empty dicts
1782 * mono/DBusType/Array.cs: Handle empty arrays
1783 * mono/Arguments.cs: Handle empty arguments
1785 2004-04-30 Owen Fraser-Green <owen@discobabe.net>
1787 * dbus-sharp.pc.in: Modified to include include Libs and Requires
1790 2004-04-25 Kristian Høgsberg <krh@redhat.com>
1792 * test/data/valid-messages/standard-*.message: Update message
1793 test scripts to new header field names.
1795 2004-04-22 John (J5) Palmieri <johnp@redhat.com>
1797 * test/break-loader.c (randomly_do_n_things): tracked down buffer
1798 overflow to times_we_did_each_thing array which would chop off the
1799 first character of the failure_dir string. Increased the size of
1800 the array to 7 to reflect the number of random mutation functions
1803 2004-04-21 Kristian Høgsberg <krh@redhat.com>
1805 * dbus/dbus-server-unix.c (unix_finalize): Don't unref
1806 unix_server->watch here, it is unreffed in disconnect.
1807 (_dbus_server_new_for_tcp_socket): convert NULL host to
1808 "localhost" here so we don't append NULL to address.
1810 * dbus/dbus-server.c (_dbus_server_test): Add test case for
1811 various addresses, including tcp with no explicit host.
1813 2004-04-21 Olivier Andrieu <oliv__a@users.sourceforge.net>
1815 * dbus/dbus-message.c (decode_header_data, decode_string_field):
1816 fix incorrect setting of .name_offset in the HeaderField (it was
1817 off by two bytes, positioned right after the name and typecode)
1819 * bus/bus.c (bus_context_new, bus_context_unref): test before
1820 calling dbus_server_free_data_slot and _dbus_user_database_unref
1821 in case of an error.
1823 * tools/Makefile.am: add $(DBUS_GLIB_TOOL_LIBS), xml libs needed
1826 2004-04-19 Kristian Høgsberg <krh@redhat.com>
1828 * dbus/dbus-transport-unix.c (unix_do_iteration): Rewrite to use
1829 _dbus_poll() instead of select().
1831 2004-04-15 Jon Trowbridge <trow@ximian.com>
1833 * bus/main.c (signal_handler): Reload the configuration files
1835 (main): Set up our SIGHUP handler.
1837 * bus/bus.c (struct BusContext): Store the config file, user and
1838 fork flag in the BusContext.
1839 (process_config_first_time_only): Added. Contains the code
1840 (previously in bus_context_new) for setting up the BusContext from
1841 the BusConfigParser that should only be run the first time the
1842 config files are read.
1843 (process_config_every_time): Added. Contains the code (previously
1844 in bus_context_new) for setting up the BusContext from the
1845 BusConfigParser that should be run every time the config files are
1847 (load_config): Added. Builds a BusConfigParser from the config
1848 files and passes the resulting structure off to
1849 process_config_first_time_only (assuming this is the first time)
1850 and process_config_every_time.
1851 (bus_context_new): All of the config-related code has been moved
1852 to process_config_first_time_only and process_config_every_time.
1853 Now this function just does the non-config-related initializations
1854 and calls load_config.
1855 (bus_context_reload_config): Added.
1857 2004-04-15 Olivier Andrieu <oliv__a@users.sourceforge.net>
1859 * bus/driver.c (bus_driver_handle_get_service_owner):
1860 implement a GetServiceOwner method.
1861 * doc/dbus-specification.xml: document it.
1862 * dbus/dbus-errors.h: add a 'ServiceHasNoOwner' error.
1864 * glib/dbus-gproxy.c (dbus_gproxy_new_for_service_owner):
1865 implement, using the bus GetServiceOwner method.
1867 * test/glib/test-dbus-glib.c:
1868 use dbus_gproxy_new_for_service_owner so that we can receive the
1871 2004-04-15 John (J5) Palmieri <johnp@redhat.com>
1873 * dbus/dbus-internals.c, dbus/dbus-message-builder.c,
1874 dbus/dbus-message.c, dbus/dbus-protocol.h
1875 (DBUS_HEADER_FIELD_SERVICE): renamed DBUS_HEADER_FIELD_DESTINATION
1877 * dbus/dbus-internals.c, dbus/dbus-message-builder.c,
1878 dbus/dbus-message.c, dbus/dbus-protocol.h
1879 (DBUS_HEADER_FIELD_SENDER_SERVICE): renamed DBUS_HEADER_FIELD_SENDER
1881 * dbus/dbus-internals.c (_dbus_header_field_to_string):
1882 DBUS_HEADER_FIELD_DESTINATION resolves to "destination"
1883 DBUS_HEADER_FIELD_SENDER resolves to "sender"
1885 * doc/dbus-specification.xml (Header Fields Table):
1886 s/SERVICE/DESTINATION
1887 s/SENDER_SERVICE/SENDER
1890 2004-04-14 Olivier Andrieu <oliv__a@users.sourceforge.net>
1892 * test/glib/test-dbus-glib.c (timed_exit): fail the test after
1895 2004-04-13 Michael Meeks <michael@ximian.com>
1897 * glib/dbus-gobject.c (handle_introspect): split out
1898 (introspect_properties): this.
1899 (handle_introspect): implement this.
1901 * test/glib/Makefile.am: use the absolute path so the bus
1902 daemon's chdir ("/") doesn't kill us dead.
1904 * configure.in: subst ABSOLUTE_TOP_BUILDDIR
1906 2004-04-12 Jon Trowbridge <trow@ximian.com>
1908 * bus/config-parser.c (struct BusConfigParser): Added
1909 included_files field.
1910 (seen_include): Added. Checks whether or not a file has already
1911 been included by any parent BusConfigParser.
1912 (bus_config_parser_new): Copy the parent's included_files.
1913 (include_file): Track which files have been included, and fail on
1914 circular inclusions.
1915 (process_test_valid_subdir): Changed printf to report if we are
1916 testing valid or invalid conf files.
1917 (all_are_equiv): Changed printf to be a bit clearer about
1918 what we are actually doing.
1919 (bus_config_parser_test): Test invalid configuration files.
1921 2004-04-09 Jon Trowbridge <trow@ximian.com>
1923 * bus/config-parser.c (bus_config_parser_new): Added a 'parent'
1924 argument. If non-null, the newly-constructed BusConfigParser will
1925 be initialized with the parent's BusLimits instead of the default
1927 (include_file): When including a config file, pass in
1928 the current parser as the parent and then copy the BusLimits
1929 from the included BusConfigParser pack to the current parser.
1930 (process_test_valid_subdir): Renamed from process_test_subdir.
1931 (process_test_equiv_subdir): Added. Walks through a directory,
1932 descending into each subdirectory and loading the config files
1933 it finds there. If any subdirectory contains two config files
1934 that don't produce identical BusConfigParser structs, fail.
1935 For now, the BusConfigParser's BusPolicies are not compared.
1936 (bus_config_parser_test): Call both process_test_valid_subdir and
1937 process_test_equiv_subdir.
1939 * bus/config-loader-libxml.c (bus_config_load): Take a parent
1940 argument and pass it along to the call to bus_config_parser_new.
1941 Also made a few small changes to allow this code to compile.
1943 * bus/config-loader-expat.c (bus_config_load): Take a parent
1944 argument and pass it along to the call to bus_config_parser_new.
1946 * bus/bus.c (bus_context_new): Load the config file
1947 with a NULL parent argument.
1949 2004-03-29 Michael Meeks <michael@ximian.com>
1951 * glib/dbus-gobject.c (introspect_properties): split
1952 out, fix mangled 'while' flow control.
1953 (introspect_signals): implement.
1954 (handle_introspect): update.
1956 2004-03-29 Michael Meeks <michael@ximian.com>
1958 * glib/dbus-gobject.c (set_object_property): split out /
1959 re-work, use the property type, and not the message type(!)
1960 (get_object_property): ditto.
1962 * glib/dbus-gvalue.c (dbus_gvalue_demarshal),
1963 (dbus_gvalue_marshal): make this code re-usable, needed
1964 for signals too, also on both proxy and server side.
1965 Re-write for more efficiency / readability.
1967 2004-03-29 Michael Meeks <michael@ximian.com>
1969 * dbus/dbus-message.c
1970 (dbus_message_new_error_printf): impl.
1972 * dbus/dbus-connection.c
1973 (dbus_connection_unregister_object_path): fix warning.
1975 * configure.in: fix no-mono-installed situation.
1977 2004-03-27 Havoc Pennington <hp@redhat.com>
1979 Patch from Timo Teräs:
1981 * tools/dbus-send.c (main): if --print-reply, assume type is
1982 method call; support boolean type args
1984 * dbus/dbus-connection.c (dbus_connection_send_with_reply): fix a
1985 bunch of memleak and logic bugs
1987 2004-03-23 Owen Fraser-Green <owen@discobabe.net>
1989 * mono/Arguments.cs:
1990 * mono/Introspector.cs:
1992 * mono/InterfaceProxy.cs:
1994 * mono/ProxyBuilder.cs:
1996 Added InterfaceProxy class to avoid building proxies for every
2000 * dbus-message.c (dbus_message_append_args_valist)
2001 (dbus_message_iter_get_object_path)
2002 (dbus_message_iter_get_object_path_array)
2003 (dbus_message_iter_append_object_path)
2004 (dbus_message_iter_append_object_path_array):
2005 Added object_path iter functions to handle OBJECT_PATH arguments
2007 2004-03-23 Owen Fraser-Green <owen@discobabe.net>
2009 First checkin of mono bindings.
2012 Build stuff for the bindings
2013 * dbus-sharp.pc.in: Added for pkgconfig
2015 2004-03-21 Havoc Pennington <hp@redhat.com>
2017 * test/test-service.c (main): remove debug spew
2019 2004-03-21 Olivier Andrieu <oliv__a@users.sourceforge.net>
2021 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): accept empty
2024 * dbus/dbus-message.h, bus/dbus-message.c (dbus_message_iter_init)
2025 (dbus_message_iter_init_array_iterator)
2026 (dbus_message_iter_init_dict_iterator): return a dbus_bool_t to
2027 indicate whether the iterator is empty
2029 * dbus/dbus-pending-call.c, dbus/dbus-server.c: silence compiler
2032 2004-03-19 Havoc Pennington <hp@redhat.com>
2034 * NEWS: 0.21 updates
2036 * configure.in: 0.21
2038 * doc/Makefile.am: add all XMLTO usage to DBUS_XML_DOCS_ENABLED
2040 * python/Makefile.am: change to avoid dist of dbus_bindings.c so
2041 you don't need pyrex to make dist
2043 * qt/Makefile.am (libdbus_qt_1_la_SOURCES): add integrator.h to
2046 2004-03-18 Richard Hult <richard@imendio.com>
2048 * dbus/dbus-message.c (dbus_message_get_auto_activation)
2049 (dbus_message_set_auto_activation): Add doxygen docs.
2051 2004-03-16 Richard Hult <richard@imendio.com>
2053 * bus/activation.c: (bus_activation_service_created),
2054 (bus_activation_send_pending_auto_activation_messages),
2055 (bus_activation_activate_service):
2057 * bus/dispatch.c: (bus_dispatch),
2058 (check_nonexistent_service_auto_activation),
2059 (check_service_auto_activated),
2060 (check_segfault_service_auto_activation),
2061 (check_existent_service_auto_activation), (bus_dispatch_test):
2062 * bus/driver.c: (bus_driver_handle_activate_service):
2063 * bus/services.c: (bus_registry_acquire_service):
2064 * dbus/dbus-message.c: (dbus_message_set_auto_activation),
2065 (dbus_message_get_auto_activation):
2066 * dbus/dbus-message.h:
2067 * dbus/dbus-protocol.h: Implement auto-activation.
2069 * doc/dbus-specification.xml: Add auto-activation to the spec.
2071 2004-03-12 Olivier Andrieu <oliv__a@users.sourceforge.net>
2073 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos):
2074 fix a bug with CUSTOM types.
2076 * dbus/dbus-message.c (message_iter_test, _dbus_message_test): add
2077 a unit test for this bug (used to fail).
2079 2004-03-12 Mikael Hallendal <micke@imendio.com>
2082 (babysitter_watch_callback): notify all pending activations waiting for
2083 the same exec that the activation failed.
2084 (bus_activation_activate_service): shortcut the activation if we
2085 already waiting for the same executable to start up.
2087 2004-03-12 Mikael Hallendal <micke@imendio.com>
2090 - Added service file reloading.
2091 Each service files directory is kept in an hash table in
2092 BusActivation and each BusActivationEntry knows what .service-file it
2093 was read from. So when you try to activate a service the bus will
2094 check if it's been updated, removed or if new .service-files has
2096 - Test code at the bottom for the service file reloading.
2097 * bus/test-main.c: (main):
2099 - added service reloading test.
2100 * dbus/dbus-sysdeps.c:
2101 * dbus/dbus-sysdeps.h: (_dbus_delete_directory): Added.
2103 2004-03-08 Michael Meeks <michael@ximian.com>
2105 * dbus/dbus-connection.c (_dbus_connection_block_for_reply):
2106 bail immediately if disconnected, to avoid busy loop.
2108 * dbus/dbus-message.c (dbus_message_iter_get_args_valist):
2109 cleanup cut/paste/inefficiency.
2111 2004-03-01 David Zeuthen <david@fubar.dk>
2113 * dbus/dbus-string.c (_dbus_string_append_printf_valist): Fix a
2114 bug where args were used twice. This bug resulted in a segfault
2115 on a Debian/PPC system when starting the messagebus daemon. Include
2116 dbus-sysdeps.h for DBUS_VA_COPY
2118 * dbus/dbus-sysdeps.h: Define DBUS_VA_COPY if neccessary. From GLib
2120 * configure.in: Check for va_copy; define DBUS_VA_COPY to the
2121 appropriate va_copy implementation. From GLib
2123 2004-02-24 Joe Shaw <joe@ximian.com>
2125 * bus/services.c (bus_registry_acquire_service): We need to pass
2126 in the service name to dbus_set_error() to prevent a crash.
2128 2003-12-26 Anders Carlsson <andersca@gnome.org>
2130 * AUTHORS: Reveal my True identity.
2132 2003-12-17 Mikael Hallendal <micke@imendio.com>
2134 * dbus/dbus-message.c: (dbus_message_append_args_valist):
2135 - Added case for DBUS_TYPE_BYTE, patch from Johan Hedberg.
2137 2003-12-13 Mikael Hallendal <micke@imendio.com>
2139 * doc/TODO: Added not about better error check of configuration files.
2141 2003-12-02 Richard Hult <richard@imendio.com>
2143 * Update AFL version to 2.0 throughout the source files to reflect
2144 the update that was done a while ago.
2146 2003-12-02 Richard Hult <richard@imendio.com>
2148 * dbus/dbus-message.c (dbus_message_iter_append_dict): Set
2149 wrote_dict_key to FALSE on the iter that the dict is appended to,
2150 just like when appending other types. Fixes a bug where a dict
2151 couldn't be put inside a dict.
2152 (dbus_message_iter_append_dict_key): Fix typo in warning message.
2153 (message_iter_test, _dbus_message_test): Add test case for dict
2156 2003-12-01 David Zeuthen <david@fubar.dk>
2158 * python/dbus.py: Add the actual message when calling the reciever
2159 of a signal such that parameters can be inspected. Add the method
2160 remove_signal_receiver
2162 2003-11-26 Mikael Hallendal <micke@imendio.com>
2166 * glib/*.[ch]: Made ref functions return the pointer
2168 2003-11-25 Zack Rusin <zack@kde.org>
2170 * qt/integrator.h, qt/integrator.cpp: Adding handling of DBusServer,
2172 * qt/server.h, qt/server.cpp, qt/Makefile.am: Adding DBusServer
2175 * qt/connection.h, qt/connection.cpp: Adjusting to changes in
2176 the Integrator and to better fit with the server,
2178 2003-11-24 Zack Rusin <zack@kde.org>
2180 * qt/connection.h, qt/connection.cpp: removing initDbus method since
2181 the integrator handles it now
2183 * qt/integrator.h, qt/integrator.cpp: reworking handling of timeouts,
2184 since QTimer wasn't really meant to be used the way DBusTimeout is
2186 2003-11-24 Zack Rusin <zack@kde.org>
2188 * qt/integrator.h, qt/integrator.cpp, Makefile.am: Adding
2189 Integrator class which integrates D-BUS with the Qt event loop,
2191 * qt/connection.h, qt/connection.cpp: Move all the code which
2192 was dealing with D-BUS integration to the Integrator class,
2193 and start using Integrator,
2195 2003-11-23 Zack Rusin <zack@kde.org>
2197 * qt/connection.h, qt/connection.cpp: Adding the DBusConnection
2200 * qt/message.h, qt/message.cpp: updating to the current D-BUS api,
2201 switching namespaces to DBusQt, reworking the class,
2203 * Makefile.cvs: switching dependencies so that it matches KDE
2206 * qt/Makefile.am: adding connection.{h,cpp} and message.{h,cpp} to
2209 2003-11-19 Havoc Pennington <hp@redhat.com>
2213 * configure.in: bump version to 0.20
2215 * configure.in (have_qt): add yet another place to look for qt
2216 (someone hand trolltech a .pc file...)
2218 2003-11-01 Havoc Pennington <hp@redhat.com>
2220 * doc/dbus-specification.xml: add state machine docs on the auth
2221 protocol; just a first draft, I'm sure it's wrong.
2223 2003-10-28 David Zeuthen <david@fubar.dk>
2225 * python/dbus_bindings.pyx.in: add get_dict to handle dictionaries
2226 return types. Fixup TYPE_* to reflect changes in dbus/dbus-protocol.h
2228 2003-10-28 Havoc Pennington <hp@redhat.com>
2230 * dbus/dbus-message.c (get_next_field): delete unused function
2232 2003-10-28 Havoc Pennington <hp@redhat.com>
2234 * bus/expirelist.c (do_expiration_with_current_time): detect
2235 failure of the expire_func due to OOM
2237 * bus/connection.c (bus_pending_reply_expired): return FALSE on OOM
2239 * bus/dispatch.c (check_send_exit_to_service): fix to handle the
2240 NoReply error that's now created by the bus when the service exits
2242 2003-10-28 Havoc Pennington <hp@redhat.com>
2244 * dbus/dbus-message.c (_dbus_message_test): enable and fix the
2245 tests for set_path, set_interface, set_member, etc.
2247 * dbus/dbus-string.c (_dbus_string_insert_bytes): allow 0 bytes
2249 * dbus/dbus-message.c (set_string_field): always just delete and
2250 re-append the field; accept NULL for deletion
2251 (re_align_fields_recurse): reimplement
2253 2003-10-26 Havoc Pennington <hp@redhat.com>
2255 * dbus/dbus-connection.c: fix docs to properly describe the
2256 disconnected message
2257 (_dbus_connection_notify_disconnected): remove this function;
2258 we can't synchronously add the disconnected message, we have to
2259 do it after we've queued any remaining real messages
2260 (_dbus_connection_get_dispatch_status_unlocked): queue the
2261 disconnect message only if the transport has finished queueing all
2262 its real messages and is disconnected.
2263 (dbus_connection_disconnect): update the dispatch status here
2265 2003-10-22 Havoc Pennington <hp@redhat.com>
2267 * bus/bus.c (bus_context_check_security_policy): fix up assertion
2269 * bus/connection.c (bus_transaction_send_from_driver): set the
2270 destination to the connection's base service
2272 2003-10-20 Havoc Pennington <hp@redhat.com>
2274 hmm, make check is currently not passing.
2276 * doc/dbus-specification.xml: add requirement that custom type
2277 names follow the same rules as interface names.
2279 * dbus/dbus-protocol.h: change some of the byte codes, to avoid
2280 duplication and allow 'c' to be 'custom'; dict is now 'm' for
2283 * doc/dbus-specification.xml: update type codes to match
2284 dbus-protocol.h, using the ASCII byte values. Rename type NAMED to
2285 CUSTOM. Add type OBJECT_PATH to the spec.
2287 2003-10-17 Havoc Pennington <hp@redhat.com>
2289 * bus/driver.c (create_unique_client_name): use "." as separator
2290 in base service names instead of '-'
2292 * dbus/dbus-string.c (_dbus_string_get_byte): allow getting nul
2293 byte at the end of the string
2295 * dbus/dbus-internals.h (_DBUS_LIKELY, _DBUS_UNLIKELY): add
2296 optimization macros since string validation seems to be a slow
2299 * doc/dbus-specification.xml: restrict valid
2300 service/interface/member/error names. Add test suite code for the
2303 * dbus/dbus-string.c: limit service/interface/member/error names
2306 * dbus/dbus-connection.c (dbus_connection_dispatch): add missing
2307 format arg to verbose spew
2309 * glib/dbus-gproxy.c (dbus_gproxy_call_no_reply): if not out of
2310 memory, return instead of g_error
2312 * test/test-service.c (path_message_func): support emitting a
2315 * dbus/dbus-bus.c (init_connections_unlocked): only fill in
2316 activation bus type if DBUS_BUS_ACTIVATION was set; default to
2317 assuming the activation bus was the session bus so that services
2318 started manually will still register.
2319 (init_connections_unlocked): fix so that in OOM situation we get
2320 the same semantics when retrying the function
2322 * test/test-service.c (main): change to use path registration, to
2323 test those codepaths; register with DBUS_BUS_ACTIVATION rather
2324 than DBUS_BUS_SESSION
2326 2003-10-16 Havoc Pennington <hp@redhat.com>
2328 * glib/dbus-gtest-main.c: bracket with #ifdef DBUS_BUILD_TESTS
2330 * Makefile.am (GCOV_DIRS): remove "test", we don't care about test
2331 coverage of the tests
2332 (coverage-report.txt): don't move the .da and .bbg files around
2334 2003-10-16 Havoc Pennington <hp@redhat.com>
2336 * bus/bus.c (struct BusContext): remove struct field I didn't mean
2339 2003-10-16 Havoc Pennington <hp@redhat.com>
2341 * bus/connection.c (bus_pending_reply_expired): either cancel or
2343 (bus_connections_check_reply): use unlink, not remove_link, as we
2344 don't want to free the link; fixes double free mess
2346 * dbus/dbus-pending-call.c (dbus_pending_call_block): fix in case
2347 where no reply was received
2349 * dbus/dbus-connection.c (_dbus_pending_call_complete_and_unlock):
2352 * bus/signals.c (match_rule_matches): add special cases for the
2353 bus driver, so you can match on sender/destination for it.
2355 * dbus/dbus-sysdeps.c (_dbus_abort): print backtrace if
2356 DBUS_PRINT_BACKTRACE is set
2358 * dbus/dbus-internals.c: add pid to assertion failure messages
2360 * dbus/dbus-connection.c: add message type code to the debug spew
2362 * glib/dbus-gproxy.c (gproxy_get_match_rule): match rules want
2363 sender=foo not service=foo
2365 * dbus/dbus-bus.c (dbus_bus_get): if the activation bus is the
2366 session bus but DBUS_SESSION_BUS_ADDRESS isn't set, use
2367 DBUS_ACTIVATION_ADDRESS instead
2369 * bus/activation.c: set DBUS_SESSION_BUS_ADDRESS,
2370 DBUS_SYSTEM_BUS_ADDRESS if appropriate
2372 * bus/bus.c (bus_context_new): handle OOM copying bus type into
2375 * dbus/dbus-message.c (dbus_message_iter_get_object_path): new function
2376 (dbus_message_iter_get_object_path_array): new function (half
2377 finished, disabled for the moment)
2379 * glib/dbus-gproxy.c (dbus_gproxy_end_call): properly handle
2380 DBUS_MESSAGE_TYPE_ERROR
2382 * tools/dbus-launch.c (babysit): support DBUS_DEBUG_OUTPUT to
2383 avoid redirecting stderr to /dev/null
2384 (babysit): close stdin if not doing the "exit_with_session" thing
2386 * dbus/dbus-sysdeps.c (_dbus_become_daemon): delete some leftover
2387 debug code; change DBUS_DEBUG_OUTPUT to only enable stderr, not
2388 stdout/stdin, so things don't get confused
2390 * bus/system.conf.in: fix to allow replies, I modified .conf
2391 instead of .conf.in again.
2393 2003-10-14 David Zeuthen <david@fubar.dk>
2395 * python/dbus_bindings.pyx.in (MessageIter.get): fixed typo in
2396 argtype to arg_type when raising unknown arg type exception.
2397 Changed type list to reflect the changes in dbus-protocol.h so
2398 the bindings actually work.
2400 2003-10-14 Havoc Pennington <hp@redhat.com>
2402 * test/decode-gcov.c: support gcc 3.3 also, though gcc 3.3 seems
2403 to have a bug keeping it from outputting the .da files sometimes
2404 (string_get_string): don't append garbage nul bytes to the string.
2406 2003-10-15 Seth Nickell <seth@gnome.org>
2408 * python/Makefile.am:
2410 Include dbus_h_wrapper.h in the dist tarball.
2412 2003-10-14 Havoc Pennington <hp@redhat.com>
2414 * bus/bus.c (bus_context_check_security_policy): revamp this to
2415 work more sanely with new policy-based requested reply setup
2417 * bus/connection.c (bus_transaction_send_from_driver): set bus
2418 driver messages as no reply
2420 * bus/policy.c (bus_client_policy_check_can_receive): handle a
2421 requested_reply attribute on allow/deny rules
2423 * bus/system.conf: add <allow requested_reply="true"/>
2425 * bus/driver.c (bus_driver_handle_message): fix check for replies
2426 sent to the bus driver, which was backward. How did this ever work
2427 at all though? I think I'm missing something.
2429 * dbus/dbus-message.c (decode_header_data): require error and
2430 method return messages to have a reply serial field to be valid
2431 (_dbus_message_loader_queue_messages): break up this function;
2432 validate that reply serial and plain serial are nonzero;
2433 clean up the OOM/error handling.
2434 (get_uint_field): don't return -1 from this
2435 (dbus_message_create_header): fix signed/unsigned bug
2437 * bus/connection.c (bus_connections_expect_reply): save serial of
2438 the incoming message, not reply serial
2440 2003-10-14 Havoc Pennington <hp@redhat.com>
2442 * bus/connection.c: implement pending reply tracking using
2445 * bus/bus.c (bus_context_check_security_policy): verify that a
2446 reply is pending in order to allow a reply to be sent. Deny
2447 messages of unknown type.
2449 * bus/dbus-daemon-1.1.in: update to mention new resource limits
2451 * bus/bus.c (bus_context_get_max_replies_per_connection): new
2452 (bus_context_get_reply_timeout): new
2454 2003-10-13 Seth Nickell <seth@gnome.org>
2456 * python/Makefile.am:
2458 Pass "make distcheck": remove a couple files from DIST_FILES
2459 that weren't included in the final version.
2461 2003-10-12 Havoc Pennington <hp@pobox.com>
2463 Added test code that 1) starts an actual bus daemon and 2) uses
2464 DBusGProxy; fixed bugs that were revealed by the test. Lots
2465 more testing possible, but this is the basic framework.
2467 * glib/dbus-gproxy.c (dbus_gproxy_manager_unregister): remove
2468 empty proxy lists from the proxy list hash
2470 * dbus/dbus-message.c (dbus_message_iter_get_args_valist): add a
2471 couple of return_if_fail checks
2473 * dbus/dbus-pending-call.c (_dbus_pending_call_new): use dbus_new0
2474 to allocate, so everything is cleared to NULL as it should be.
2476 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): pass
2477 source as data to dbus_connection_set_timeout_functions() as the
2478 timeout functions expected
2480 * test/glib/run-test.sh: add a little script to start up a message
2481 bus and run tests using it
2483 * tools/dbus-launch.1: updates
2485 * tools/dbus-launch.c (main): add --config-file option
2487 * tools/dbus-launch.c (main): remove confusing else if (runprog)
2488 that could never be reached.
2490 * dbus/dbus-message.c (dbus_message_new_method_return)
2491 (dbus_message_new_error, dbus_message_new_signal): set the
2492 no-reply-expected flag on all these. Redundant, but may
2493 as well be consistent.
2495 2003-10-11 Havoc Pennington <hp@pobox.com>
2497 * test/decode-gcov.c (function_solve_graph): make broken block
2498 graph a nonfatal error since it seems to be broken. Need to debug
2501 * dbus/dbus-marshal.c (_dbus_type_is_valid): new function since we
2502 can't just check type > INVALID < LAST anymore
2504 * dbus/dbus-message.c (dbus_message_get_signature): new function
2505 (dbus_message_has_signature): new function
2506 (struct DBusMessage): add signature field (right now it isn't sent
2507 over the wire, just generated on the fly)
2508 (dbus_message_copy): copy the signature, and init strings to
2509 proper length to avoid some reallocs
2510 (dbus_message_iter_init_array_iterator): return void, since it
2512 (dbus_message_iter_init_dict_iterator): return void since it can't fail
2513 (_dbus_message_loader_queue_messages): add silly temporary hack to
2514 fill in message->signature on load
2516 * dbus/dbus-protocol.h: change DBUS_TYPE_* values to be ASCII
2517 characters, so they are relatively human-readable.
2519 2003-10-11 Havoc Pennington <hp@pobox.com>
2521 * dbus/dbus-message.c (_dbus_message_test): add more test
2522 coverage, but #if 0 for now since they uncover a bug
2523 not fixed yet; I think in re_align_field_recurse()
2524 (re_align_field_recurse): add FIXME about broken assertion
2526 * dbus/dbus-sysdeps.c (_dbus_sysdeps_test): add more test coverage
2528 * bus/connection.c: share a couple code bits with expirelist.c
2530 * bus/expirelist.h, bus/expirelist.c: implement a generic
2531 expire-items-after-N-seconds facility, was going to share between
2532 expiring connections and replies, decided not to use for expiring
2533 connections for now.
2535 * COPYING: include AFL 2.0 (still need to change all the file headers)
2537 2003-10-09 Havoc Pennington <hp@redhat.com>
2539 * configure.in: define DBUS_HAVE_GCC33_GCOV if we have
2540 gcc 3.3. Not that we do anything about it yet.
2542 * bus/signals.c (bus_match_rule_parse): impose max length on the
2545 * dbus/dbus-protocol.h: add DBUS_MAXIMUM_MATCH_RULE_LENGTH
2547 2003-10-09 Havoc Pennington <hp@redhat.com>
2549 Make matching rules theoretically work (add parser).
2551 * bus/bus.c (bus_context_check_security_policy): fix up to handle
2552 the case where destination is explicitly specified as bus driver
2553 and someone else is eavesdropping.
2555 * bus/policy.c (bus_client_policy_check_can_receive): fix up
2556 definition of eavesdropping and assertion
2558 * tools/dbus-send.c (main): use dbus_message_type_from_string
2560 * bus/signals.c (bus_match_rule_parse): implement
2562 * dbus/dbus-message.c (dbus_message_type_from_string): new
2564 * dbus/dbus-errors.h (DBUS_ERROR_MATCH_RULE_INVALID): add
2566 2003-10-02 Havoc Pennington <hp@pobox.com>
2568 * glib/dbus-gproxy.c (dbus_gproxy_call_no_reply): rename from
2569 dbus_gproxy_oneway_call
2571 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main)
2572 (dbus_server_setup_with_g_main): fix to allow calling them more
2573 than once on the same args
2574 (dbus_bus_get_with_g_main): new function
2576 2003-10-02 Havoc Pennington <hp@redhat.com>
2578 * doc/dbus-tutorial.xml: write some stuff
2580 2003-09-29 Havoc Pennington <hp@pobox.com>
2582 * configure.in: split checks for Doxygen from XML docs, check for
2585 * doc/Makefile.am: XML-ify all the docs, and add a blank
2588 2003-09-29 Havoc Pennington <hp@pobox.com>
2590 * Merge dbus-object-names branch. To see the entire patch
2591 do cvs diff -r DBUS_OBJECT_NAMES_BRANCHPOINT -r dbus-object-names,
2592 it's huuuuge though.
2593 To revert, I tagged DBUS_BEFORE_OBJECT_NAMES_MERGE.
2595 2003-09-28 Havoc Pennington <hp@pobox.com>
2597 * HACKING: update to reflect new server
2599 2003-09-26 Seth Nickell <seth@gnome.org>
2602 * python/examples/example-signals.py:
2604 Start implementing some notions of signals. The API
2605 is really terrible, but they sort of work (with the
2606 exception of being able to filter by service, and to
2607 transmit signals *as* a particular service). Need to
2608 figure out how to make messages come from the service
2611 * python/dbus_bindings.pyx.in:
2613 Removed duplicate message_handler callbacks.
2615 2003-09-25 Havoc Pennington <hp@redhat.com>
2617 * bus/session.conf.in: fix my mess
2619 2003-09-25 Havoc Pennington <hp@pobox.com>
2621 * bus/session.conf.in: fix security policy, reported by Seth Nickell
2623 2003-09-25 Seth Nickell <seth@gnome.org>
2625 * python/examples/example-service.py:
2627 Johan notices complete wrong code in example-service, but
2628 completely wrong in a way that works exactly the same (!).
2629 Johan is confused, how could this possibly work? Example
2630 code fails to serve purpose of making things clear.
2633 2003-09-25 Mark McLoughlin <mark@skynet.ie>
2635 * doc/dbus-specification.sgml: don't require header fields
2636 to be 4-byte aligned and specify that fields should be
2637 distinguished from padding by the fact that zero is not
2640 * doc/TODO: remove re-alignment item and add item to doc
2641 the OBJECT_PATH type.
2643 * dbus/dbus-message.c:
2644 (HeaderField): rename the original member to value_offset
2645 and introduce a name_offset member to keep track of where
2646 the field actually begins.
2647 (adjust_field_offsets): remove.
2648 (append_int_field), (append_uint_field),
2649 (append_string_field): don't align the start of the header
2650 field to a 4-byte boundary.
2651 (get_next_field): impl finding the next marhsalled field
2652 after a given field.
2653 (re_align_field_recurse): impl re-aligning a number of
2654 already marshalled fields.
2655 (delete_field): impl deleting a field of any type and
2656 re-aligning any following fields.
2657 (delete_int_or_uint_field), (delete_string_field): remove.
2658 (set_int_field), (set_uint_field): no need to re-check
2659 that we have the correct type for the field.
2660 (set_string_field): ditto and impl re-aligning any
2662 (decode_header_data): update to take into account that
2663 the fields aren't 4-byte aligned any more and the new
2664 way to distinguish padding from header fields. Also,
2665 don't exit when there is too much header padding.
2666 (process_test_subdir): print the directory.
2667 (_dbus_message_test): add test to make sure a following
2668 field is re-aligned correctly after field deletion.
2670 * dbus/dbus-string.[ch]:
2671 (_dbus_string_insert_bytes): rename from insert_byte and
2672 allow the insert of multiple bytes.
2673 (_dbus_string_test): test inserting multiple bytes.
2675 * dbus/dbus-marshal.c: (_dbus_marshal_set_string): add
2676 warning note to docs about having to re-align any
2677 marshalled values following the string.
2679 * dbus/dbus-message-builder.c:
2680 (append_string_field), (_dbus_message_data_load):
2681 don't align the header field.
2683 * dbus/dbus-auth.c: (process_test_subdir): print the
2686 * test/break-loader.c: (randomly_add_one_byte): upd. for
2689 * test/data/invalid-messages/bad-header-field-alignment.message:
2692 * test/data/valid-messages/unknown-header-field.message: shove
2693 a dict in the unknown field.
2695 2003-09-25 Seth Nickell <seth@gnome.org>
2698 * python/dbus_bindings.pyx.in:
2700 Handle return values.
2702 * python/examples/example-client.py:
2703 * python/examples/example-service.py:
2705 Pass back return values from the service to the client.
2707 2003-09-24 Seth Nickell <seth@gnome.org>
2711 Connect Object methods (when you are sharing an object) up... pass
2712 in a list of methods to be shared. Sharing all the methods just
2713 worked out too weird. You can now create nice Services over the
2716 * python/dbus_bindings.pyx.in:
2718 Keep references to user_data tuples passed into C functions so
2719 Python doesn't garbage collect on us.
2721 Implement MethodReturn and Error subclasses of Message for creating
2722 DBusMessage's of those types.
2724 * python/examples/example-client.py:
2725 * python/examples/example-service.py:
2727 Simple example code showing both how create DBus services and objects,
2728 and how to use them.
2730 2003-09-23 Havoc Pennington <hp@pobox.com>
2732 * glib/dbus-gproxy.c (dbus_gproxy_manager_filter): implement
2734 2003-09-23 Havoc Pennington <hp@redhat.com>
2736 * glib/dbus-gproxy.c (dbus_gproxy_connect_signal): implement
2737 (dbus_gproxy_disconnect_signal): implement
2738 (dbus_gproxy_manager_remove_signal_match): implement
2739 (dbus_gproxy_manager_add_signal_match): implement
2740 (dbus_gproxy_oneway_call): implement
2742 2003-09-23 Havoc Pennington <hp@pobox.com>
2744 * glib/dbus-gproxy.c (struct DBusGProxy): convert to a GObject
2745 subclass. This means dropping the transparent thread safety of the
2746 proxy; you now need a separate proxy per-thread, or your own
2747 locking on the proxy. Probably right anyway.
2748 (dbus_gproxy_ref, dbus_gproxy_unref): nuke, just use g_object_ref
2750 2003-09-22 Havoc Pennington <hp@redhat.com>
2752 * glib/dbus-gproxy.c (dbus_gproxy_manager_get): implement
2754 2003-09-21 Seth Nickell <seth@gnome.org>
2756 First checkin of the Python bindings.
2758 * python/.cvsignore:
2759 * python/Makefile.am:
2760 * python/dbus_bindings.pyx.in:
2761 * python/dbus_h_wrapper.h:
2763 Pieces for Pyrex to operate on, building a dbus_bindings.so
2764 python module for low-level access to the DBus APIs.
2768 High-level Python module for accessing DBus objects.
2773 Build stuff for the python bindings.
2777 Extra macro needed for finding the Python C header files.
2779 2003-09-21 Havoc Pennington <hp@pobox.com>
2781 * glib/dbus-gproxy.c (dbus_gproxy_manager_new): start
2782 implementing the proxy manager, didn't get very far.
2784 * dbus/dbus-bus.c (dbus_bus_add_match): new
2785 (dbus_bus_remove_match): new
2787 * glib/dbus-gproxy.c (dbus_gproxy_new_for_service): add a
2788 path_name argument; adjust the other not-yet-implemented
2789 gproxy constructors to be what I think they should be.
2791 2003-09-21 Havoc Pennington <hp@pobox.com>
2793 * dbus/dbus-bus.c (dbus_bus_get): set exit_on_disconnect to TRUE
2794 by default for message bus connections.
2796 * dbus/dbus-connection.c (dbus_connection_dispatch): exit if
2797 exit_on_disconnect flag is set and we process the disconnected
2799 (dbus_connection_set_exit_on_disconnect): new function
2801 2003-09-21 Havoc Pennington <hp@pobox.com>
2803 Get matching rules mostly working in the bus; only actually
2804 parsing the rule text remains. However, the client side of
2805 "signal connections" hasn't been started, this patch is only the
2808 * dbus/dispatch.c: fix for the matching rules changes
2810 * bus/driver.c (bus_driver_handle_remove_match)
2811 (bus_driver_handle_add_match): send an ack reply from these
2814 * glib/dbus-gproxy.c (dbus_gproxy_begin_call): fix order of
2815 arguments, reported by Seth Nickell
2817 * bus/config-parser.c (append_rule_from_element): support
2818 eavesdrop=true|false attribute on policies so match rules
2819 can be prevented from snooping on the system bus.
2821 * bus/dbus-daemon-1.1.in: consistently use terminology "sender"
2822 and "destination" in attribute names; fix some docs bugs;
2823 add eavesdrop=true|false attribute
2825 * bus/driver.c (bus_driver_handle_add_match)
2826 (bus_driver_handle_remove_match): handle AddMatch, RemoveMatch
2829 * dbus/dbus-protocol.h (DBUS_SERVICE_ORG_FREEDESKTOP_BROADCAST): get
2830 rid of broadcast service concept, signals are just always broadcast
2832 * bus/signals.c, bus/dispatch.c, bus/connection.c, bus/bus.c:
2833 mostly implement matching rules stuff (currently only exposed as signal
2836 2003-09-21 Mark McLoughlin <mark@skynet.ie>
2838 * doc/dbus-specification.sgml: Change the header field name
2839 to be an enum and update the rest of the spec to reference
2840 the fields using the conventinal name.
2842 * dbus/dbus-protocol.h: update to reflect the spec.
2844 * doc/TODO: add item to remove the 4 byte alignment requirement.
2846 * dbus/dbus-message.c: Remove the code to generalise the
2847 header/body length and serial number header fields as named
2848 header fields so we can reference field names using the
2850 (append_int_field), (append_uint_field), (append_string_field):
2851 Append the field name as a byte rather than four chars.
2852 (delete_int_or_uint_field), (delete_string_field): reflect the
2853 fact that the field name and typecode now occupy 4 bytes instead
2855 (decode_string_field), (decode_header_data): update to reflect
2856 protocol changes and move the field specific encoding from
2857 decode_string_field() back into decode_header_data().
2859 * dbus/dbus-internals.[ch]: (_dbus_header_field_to_string):
2860 Add utility to aid debugging.
2862 * dbus/dbus-message-builder.c:
2863 (append_string_field), (_dbus_message_data_load): Update to
2864 reflect protocol changes; Change the FIELD_NAME directive
2865 to HEADER_FIELD and allow it to take the field's conventional
2866 name rather than the actual value.
2868 * test/data/*/*.message: Update to use HEADER_FIELD instead
2869 of FIELD_NAME; Always align the header on an 8 byte boundary
2870 *before* updating the header length.
2872 2003-09-15 Havoc Pennington <hp@pobox.com>
2874 * dbus/dbus-pending-call.c: add the get/set object data
2875 boilerplate as for DBusConnection, etc. Use generic object data
2876 for the notify callback.
2878 * glib/dbus-gparser.c (parse_node): parse child nodes
2880 * tools/dbus-viewer.c: more hacking on the dbus-viewer
2882 * glib/dbus-gutils.c (_dbus_gutils_split_path): add a file to
2883 contain functions shared between the convenience lib and the
2886 * glib/Makefile.am (libdbus_glib_1_la_LDFLAGS): add
2887 -export-symbols-regex to the GLib library
2889 * dbus/dbus-object-tree.c (_dbus_object_tree_dispatch_and_unlock):
2890 fix the locking in here, and add a default handler for
2891 Introspect() that just returns sub-nodes.
2893 2003-09-14 Havoc Pennington <hp@pobox.com>
2895 * glib/dbus-gthread.c (dbus_g_thread_init): rename to make g_foo
2896 rather than gfoo consistent
2898 * glib/dbus-gproxy.h: delete for now, move contents to
2899 dbus-glib.h, because the include files don't work right since we
2900 aren't in the dbus/ subdir.
2902 * glib/dbus-gproxy.c (dbus_gproxy_send): finish implementing
2903 (dbus_gproxy_end_call): finish
2904 (dbus_gproxy_begin_call): finish
2906 * glib/dbus-gmain.c (dbus_set_g_error): new
2908 * glib/dbus-gobject.c (handle_introspect): include information
2909 about child nodes in the introspection
2911 * dbus/dbus-connection.c (dbus_connection_list_registered): new
2912 function to help in implementation of introspection
2914 * dbus/dbus-object-tree.c
2915 (_dbus_object_tree_list_registered_and_unlock): new function
2917 2003-09-12 Havoc Pennington <hp@pobox.com>
2919 * glib/dbus-gidl.h: add common base class for all the foo_info
2922 * tools/dbus-viewer.c: add GTK-based introspection UI thingy
2925 * test/Makefile.am: try test srcdir -ef . in addition to test
2926 srcdir = ., one of them should work (yeah lame)
2928 * glib/Makefile.am: build the "idl" parser stuff as a convenience
2931 * glib/dbus-gparser.h: make description_load routines return
2932 NodeInfo* not Parser*
2934 * Makefile.am (SUBDIRS): build test dir after all library dirs
2936 * configure.in: add GTK+ detection
2938 2003-09-07 Havoc Pennington <hp@pobox.com>
2940 * Make Doxygen contented.
2942 2003-09-07 Havoc Pennington <hp@pobox.com>
2944 * doc/dbus-specification.sgml: more updates
2946 2003-09-06 Havoc Pennington <hp@pobox.com>
2948 * doc/dbus-specification.sgml: partial updates
2950 * bus/dbus-daemon-1.1.in: fix the config file docs for the
2951 zillionth time; hopefully I edited the right file this time.
2953 * bus/config-parser.c (append_rule_from_element): support
2954 send_type, send_path, receive_type, receive_path
2956 * bus/policy.c: add message type and path to the list of things
2957 that can be "firewalled"
2959 2003-09-06 Havoc Pennington <hp@pobox.com>
2961 * dbus/dbus-connection.c (dbus_connection_register_fallback): add this
2962 (dbus_connection_register_object_path): make this not handle
2963 messages to paths below the given path
2965 2003-09-03 Havoc Pennington <hp@pobox.com>
2967 * test/glib/Makefile.am: add this with random glib-linked test
2970 * glib/Makefile.am: remove the random test programs from here,
2971 leave only the unit tests
2973 * glib/dbus-gobject.c (_dbus_gobject_test): add test for
2974 uscore/javacaps conversion, and fix
2975 (get_object_property, set_object_property): change to .NET
2976 convention for mapping props to methods, set_FooBar/get_FooBar,
2977 since one language has such a convention we may as well copy it.
2978 Plus real methods in either getFooBar or get_foo_bar style won't
2979 collide with this convention.
2981 2003-09-01 Havoc Pennington <hp@pobox.com>
2983 * glib/dbus-gparser.c: implement
2985 * glib/dbus-gobject.c: start implementing skeletons support
2987 * configure.in: when disabling checks/assert, also define
2988 G_DISABLE_ASSERT and G_DISABLE_CHECKS
2990 2003-09-01 Havoc Pennington <hp@pobox.com>
2992 * glib/Makefile.am: rearrange a bunch of files and get "make
2993 check" framework set up
2995 2003-08-31 Havoc Pennington <hp@pobox.com>
2997 * fix build with --disable-tests
2999 2003-08-30 Havoc Pennington <hp@pobox.com>
3001 * dbus/dbus-connection.c: purge DBusMessageHandler
3003 * dbus/dbus-message-handler.c: remove DBusMessageHandler, just
3004 use callbacks everywhere
3006 2003-08-30 Havoc Pennington <hp@pobox.com>
3008 * test/data/valid-config-files/system.d/test.conf: change to
3009 root for the user so warnings don't get printed
3011 * dbus/dbus-message.c: add dbus_message_get_path,
3012 dbus_message_set_path
3014 * dbus/dbus-object-tree.c (do_test_dispatch): add test of
3015 dispatching to a path
3017 * dbus/dbus-string.c (_dbus_string_validate_path): add
3019 * dbus/dbus-marshal.c (_dbus_demarshal_object_path): implement
3020 (_dbus_marshal_object_path): implement
3022 * dbus/dbus-protocol.h (DBUS_HEADER_FIELD_PATH): new header field
3023 to contain the path to the target object
3024 (DBUS_HEADER_FIELD_SENDER_SERVICE): rename
3025 DBUS_HEADER_FIELD_SENDER to explicitly say it's the sender service
3027 2003-08-30 Havoc Pennington <hp@pobox.com>
3029 * dbus/dbus-object-tree.c: write tests and fix the discovered bugs
3031 2003-08-29 Havoc Pennington <hp@pobox.com>
3033 * dbus/dbus-object-tree.c: modify to allow overlapping paths to be
3035 (struct DBusObjectSubtree): shrink this
3036 a lot, since we may have a lot of them
3037 (_dbus_object_tree_free_all_unlocked): implement
3038 (_dbus_object_tree_dispatch_and_unlock): implement
3040 2003-08-29 Havoc Pennington <hp@pobox.com>
3042 * dbus/dbus-internals.h: fix _DBUS_N_GLOBAL_LOCKS
3044 2003-08-28 Havoc Pennington <hp@pobox.com>
3048 * dbus/dbus-connection.c: port to no ObjectID, create a
3049 DBusObjectTree, rename ObjectTree to ObjectPath in public API
3051 * dbus/dbus-connection.h (struct DBusObjectTreeVTable): delete
3052 everything except UnregisterFunction and MessageFunction
3054 * dbus/dbus-marshal.c: port away from DBusObjectID,
3055 add DBUS_TYPE_OBJECT_PATH
3057 * dbus/dbus-object-registry.[hc], dbus/dbus-object.[hc],
3058 dbus/dbus-objectid.[hc]: remove these, we are moving to
3059 path-based object IDs
3061 2003-08-25 Havoc Pennington <hp@pobox.com>
3063 Just noticed that dbus_message_test is hosed, I wonder when I
3064 broke that. I thought make check was passing earlier...
3066 * dbus/dbus-object-tree.c: add new "object tree" to match DCOP
3067 container tree, will replace most of dbus-object-registry
3069 * dbus/dbus-string.c (_dbus_string_append_printf_valist): fix C99
3072 2003-08-19 Havoc Pennington <hp@pobox.com>
3074 * dbus/dbus-message.c (decode_string_field): support FIELD_SENDER
3075 (dbus_message_is_error): fix this function
3077 * bus/dbus-daemon-1.1: clarify logic on when <deny>/<allow> rules
3080 * bus/policy.c (bus_client_policy_check_can_receive): fix code to
3081 reflect clarified man page
3082 (bus_client_policy_check_can_send): ditto
3084 * bus/session.conf.in: fixup
3086 * bus/system.conf.in: fixup
3088 2003-08-18 Havoc Pennington <hp@redhat.com>
3090 * dbus/dbus-hash.c (_dbus_hash_table_insert_two_strings): fix
3092 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
3093 dumb bug created earlier (wrong order of args to
3094 decode_header_data())
3096 * tools/dbus-send.c: port
3098 * tools/dbus-print-message.c (print_message): port
3100 * test/data/*messages: port all messages over
3102 * dbus/dbus-message-builder.c: support including
3105 * bus/driver.c: port over
3107 * bus/dispatch.c: port over to new stuff
3109 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
3110 rename disconnect signal to "Disconnected"
3112 2003-08-17 Havoc Pennington <hp@pobox.com>
3114 This doesn't compile yet, but syncing up so I can hack on it from
3115 work. What are branches for if not broken code? ;-)
3117 * dbus/dbus-protocol.h: remove DBUS_HEADER_FIELD_NAME, add
3118 DBUS_HEADER_FIELD_INTERFACE, DBUS_HEADER_FIELD_MEMBER,
3119 DBUS_HEADER_FIELD_ERROR_NAME
3121 * dbus/dbus-hash.c: Introduce DBUS_HASH_TWO_STRINGS as hack to use
3122 for the interface+member pairs
3123 (string_hash): change to use g_str_hash algorithm
3124 (find_direct_function, find_string_function): refactor these to
3127 * dbus/dbus-message.c: port all of this over to support
3128 interface/member fields instead of name field
3130 * dbus/dbus-object-registry.c: port over
3132 * dbus/dbus-string.c (_dbus_string_validate_interface): rename
3133 from _dbus_string_validate_name
3135 * bus/dbus-daemon-1.1: change file format for the
3136 <deny>/<allow> stuff to match new message naming scheme
3138 * bus/policy.c: port over
3140 * bus/config-parser.c: parse new format
3142 2003-08-16 Havoc Pennington <hp@pobox.com>
3144 * dbus/dbus-object-registry.c (add_and_remove_objects): remove
3147 * glib/dbus-gproxy.c: some hacking
3149 2003-08-15 Havoc Pennington <hp@redhat.com>
3151 * dbus/dbus-pending-call.c (dbus_pending_call_block): implement
3153 * dbus/dbus-connection.c
3154 (dbus_connection_send_with_reply_and_block): factor out internals;
3155 change to convert any error replies to DBusError instead of
3156 returning them as a message
3158 2003-08-15 Havoc Pennington <hp@pobox.com>
3160 * dbus/dbus-connection.c,
3161 dbus/dbus-pending-call.c: Finish the pending call stuff
3163 2003-08-14 Havoc Pennington <hp@redhat.com>
3165 * dbus/dbus-pending-call.c: start on new object that will replace
3166 DBusMessageHandler and ReplyHandlerData for tracking outstanding
3169 * dbus/dbus-gproxy.c: start on proxy object used to communicate
3170 with remote interfaces
3172 * dbus/dbus-gidl.c: do the boring boilerplate in here
3174 2003-08-12 Havoc Pennington <hp@pobox.com>
3176 * bus/dispatch.c (bus_dispatch): make this return proper
3177 DBusHandlerResult to avoid DBUS_ERROR_UNKNOWN_METHOD
3179 * dbus/dbus-errors.c (dbus_set_error): use
3180 _dbus_string_append_printf_valist
3182 * dbus/dbus-string.c (_dbus_string_append_printf_valist)
3183 (_dbus_string_append_printf): new
3185 * dbus/dbus-errors.h (DBUS_ERROR_UNKNOWN_MESSAGE): change to
3188 * dbus/dbus-connection.c (dbus_connection_dispatch): handle
3189 DBUS_HANDLER_RESULT_NEED_MEMORY; send default error reply if a
3190 message is unhandled.
3192 2003-08-11 Havoc Pennington <hp@pobox.com>
3194 * bus/test.c (client_disconnect_handler): change to return
3195 HANDLED (would have been REMOVE_MESSAGE)
3197 * dbus/dbus-object.h (enum DBusHandlerResult): rename to
3198 HANDLED/NOT_YET_HANDLED instead of
3199 REMOVE_MESSAGE/ALLOW_MORE_HANDLERS to make it clearer how it
3202 2003-08-10 Havoc Pennington <hp@pobox.com>
3204 * tools/dbus-send.c (main): add --type argument, for now
3205 supporting only method_call and signal types.
3207 * tools/dbus-print-message.c: print message type
3209 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
3210 init connection->objects
3212 * doc/dbus-specification.sgml: fix sgml
3214 * bus/*.c: port over to object-instance API changes
3216 * test/test-service.c: ditto
3218 * dbus/dbus-message.c (dbus_message_create_header): allow #NULL
3219 name, we will have to fix up the rest of the code to also handle
3221 (dbus_message_new): generic message-creation call
3222 (set_string_field): allow appending name field
3224 2003-08-06 Havoc Pennington <hp@pobox.com>
3226 * dbus/dbus-object-registry.c: implement signal connection
3229 * dbus/dbus-connection.c (_dbus_connection_unref_unlocked): new
3231 * dbus/dbus-internals.c (_dbus_memdup): new function
3233 2003-08-02 Havoc Pennington <hp@pobox.com>
3235 * dbus/dbus-message.c (dbus_message_get_no_reply)
3236 (dbus_message_set_no_reply): add these and remove
3237 set_is_error/get_is_error
3239 * dbus/dbus-protocol.h, doc/dbus-specification.sgml:
3240 remove the ERROR flag, since there's now an ERROR type
3242 2003-08-01 Havoc Pennington <hp@pobox.com>
3244 * dbus/dbus-object-registry.c (_dbus_object_registry_handle_and_unlock):
3247 * dbus/dbus-message.c (dbus_message_get_type): new function
3249 * doc/dbus-specification.sgml: add "type" byte to messages
3251 2003-08-01 Havoc Pennington <hp@pobox.com>
3253 * dbus/dbus-protocol.h (DBUS_MESSAGE_TYPE_*): introduce
3254 a message type enum to distinguish kinds of message
3255 (DBUS_HEADER_FLAG_NO_REPLY_EXPECTED): flag for a message
3256 that need not be replied to
3258 2003-08-01 Havoc Pennington <hp@pobox.com>
3260 * dbus/dbus-marshal.c: adapt to DBusObjectID changes
3261 (unpack_8_octets): fix no-64-bit-int bug
3263 * dbus/dbus-object-registry.c (validate_id): validate the
3264 connection ID bits, not just the instance ID.
3266 * dbus/dbus-connection.c (_dbus_connection_init_id): initialize
3267 the connection-global 33 bits of the object ID
3269 * dbus/dbus-object-registry.c (info_from_entry): fill in
3270 object ID in the new way
3272 * dbus/dbus-objectid.h: rather than high/low bits, specifically
3273 define server/client/instance bits.
3275 2003-07-30 Havoc Pennington <hp@pobox.com>
3277 * dbus/dbus-connection.c (dbus_connection_register_object): fix
3280 2003-07-13 Havoc Pennington <hp@pobox.com>
3282 * dbus/dbus-object.h (struct DBusObjectVTable): add padding
3283 fields to DBusObjectVTable and DBusObjectInfo
3285 2003-07-12 Havoc Pennington <hp@pobox.com>
3287 * dbus/dbus-object-registry.c: implement unit test,
3288 fix bugs discovered in process
3290 * dbus/dbus-connection.c: remove handler_table and
3291 register_handler(), add DBusObjectRegistry usage
3293 * dbus/dbus-objectid.c (dbus_object_id_is_null)
3294 (dbus_object_id_set_null): new functions
3296 2003-07-08 Havoc Pennington <hp@pobox.com>
3298 * dbus/dbus-object.c: implement some of this
3300 * dbus/dbus-object-registry.c
3301 (_dbus_object_registry_add_and_unlock): fill in the object_id out
3303 (_dbus_object_registry_new): handle OOM
3305 2003-07-08 Havoc Pennington <hp@pobox.com>
3307 * dbus/dbus-object.h: sketch out an API for registering objects
3308 with a connection, that allows us to use as little as 24 bytes
3309 per object and lets application code represent an object in
3310 any conceivable way.
3312 * dbus/dbus-object-registry.c: implement the hard bits of the
3313 DBusConnection aspect of object API. Not yet wired up.
3315 2003-07-06 Havoc Pennington <hp@pobox.com>
3317 * dbus/dbus-marshal.c (_dbus_marshal_set_object_id): new function
3318 (_dbus_marshal_object_id): new
3319 (_dbus_demarshal_object_id): new
3320 (_dbus_marshal_get_arg_end_pos): support object ID type, and
3321 consolidate identical switch cases. Don't conditionalize handling
3322 of DBUS_TYPE_UINT64, need to handle the type always.
3323 (_dbus_marshal_validate_arg): consolidate identical cases, and
3324 handle DBUS_TYPE_OBJECT_ID
3326 * dbus/dbus-objectid.c: new file with DBusObjectID data type.
3328 * dbus/dbus-protocol.h: add DBUS_TYPE_OBJECT_ID
3330 2003-09-28 Havoc Pennington <hp@pobox.com>
3334 2003-09-28 Havoc Pennington <hp@pobox.com>
3336 * doc/Makefile.am (dbus-specification.html): testing a funky hack
3337 to work with Debian db2html
3339 2003-09-28 Havoc Pennington <hp@pobox.com>
3341 * configure.in: 0.13
3343 * doc/Makefile.am (dbus-test-plan.html): accept nonexistence of
3344 stylesheet-images for benefit of Debian
3346 Change back to using filesystem-linked sockets for the system
3347 bus, so only root can create the default system bus address.
3349 * bus/system.conf.in: change to use
3350 DBUS_SYSTEM_BUS_DEFAULT_ADDRESS
3352 * dbus/Makefile.am (INCLUDES): remove DBUS_SYSTEM_BUS_PATH define
3355 * configure.in: define DBUS_SYSTEM_BUS_DEFAULT_ADDRESS
3356 here, and AC_DEFINE DBUS_SYSTEM_PATH
3358 2003-08-09 Anders Carlsson <andersca@codefactory.se>
3361 * doc/busconfig.dtd:
3364 2003-08-09 Anders Carlsson <andersca@codefactory.se>
3366 * doc/dbus-specification.sgml:
3367 Add activation reply values.
3369 2003-08-05 Havoc Pennington <hp@redhat.com>
3371 * configure.in: 0.12
3373 2003-08-05 Anders Carlsson <andersca@codefactory.se>
3375 * glib/dbus-gmain.c: (watch_fd_new), (watch_fd_ref),
3376 (watch_fd_unref), (dbus_gsource_check), (dbus_gsource_dispatch),
3377 (add_watch), (remove_watch), (create_source):
3378 Refcount fds, fixes some reentrancy issues.
3380 2003-07-30 Havoc Pennington <hp@redhat.com>
3382 * dbus/dbus-bus.c (init_connections_unlocked): fix default system
3383 bus address to be abstract if we have abstract sockets
3387 2003-07-28 Havoc Pennington <hp@redhat.com>
3389 * bus/messagebus.in: fix to avoid processname/servicename
3390 confusion, from Michael Kearey
3391 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=100965
3393 2003-07-23 Havoc Pennington <hp@pobox.com>
3395 * dbus/dbus-message.c (dbus_message_iter_get_named):
3396 fix from Andy Hanton to remove broken "+1"
3398 2003-07-16 Havoc Pennington <hp@pobox.com>
3400 * tools/dbus-launch.c (babysit): close stdout/stderr in the
3401 babysitter process, as suggested by Thomas Leonard, so
3402 an "eval `dbus-launch --exit-with-session`" will actually
3405 2003-07-16 Havoc Pennington <hp@pobox.com>
3407 * configure.in: print out EXPANDED_* variables in the summary at
3408 the end; clean up the code that computes EXPANDED_ variables and
3409 get the ones using exec_prefix right. Should make things work
3410 when you build without --prefix
3412 2003-06-29 Havoc Pennington <hp@pobox.com>
3414 * mono/Test.cs (class Test): fire up a main loop and run it
3416 * mono/DBus.cs (DBus): don't g_thread_init since it can only be
3417 done once, the app has to do it
3419 2003-06-26 Havoc Pennington <hp@pobox.com>
3421 * mono/Connection.cs: set up connection with the glib main loop
3423 2003-07-01 Havoc Pennington <hp@redhat.com>
3425 * doc/dbus-specification.sgml: clarify the format of a type code,
3426 change suggested by Jim Blandy
3428 2003-06-29 Miloslav Trmac <mitr@volny.cz>
3431 * tools/Makefile.am: Don't assume srcdir == builddir.
3433 * dbus/dbus-memory.c (dbus_realloc): Don't check guards after shrinking
3434 the allocated block.
3435 (_dbus_memory_test): New function.
3436 * dbus/dbus-test.h: Add _dbus_memory_test ().
3437 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): Call it.
3439 * dbus/dbus-message.c (decode_header_data): Use %.4s instead
3441 (dbus_message_new): Remove obsolete @todo.
3443 * dbus/dbus-marshal.c (_dbus_marshal_set_int64)
3444 (_dbus_marshal_set_uint64): Fix comment.
3446 * dbus/dbus-message.c (append_int_field, append_uint_field): Don't
3447 hardcode FIELD_REPLY_SERIAL.
3449 * dbus/dbus-mainloop.c (_dbus_loop_remove_watch)
3450 (_dbus_loop_remove_timeout): Cast function pointers to (void *) for %p
3452 * configure.in: Add -D_POSIX_C_SOURCE=199309L -DBSD_SOURCE to CFLAGS
3453 and disable DBUS_USE_ATOMIC_INT_486 when --enable-ansi is used
3455 2003-06-24 Havoc Pennington <hp@pobox.com>
3457 * mono/*.cs: Use IntPtr.Zero instead of ((IntPtr) 0)
3459 2003-06-23 Anders Carlsson <andersca@codefactory.se>
3465 * gcj/TestMessage.java: (TestMessage), (TestMessage.main):
3466 * gcj/org/.cvsignore:
3467 * gcj/org/Makefile.am:
3468 * gcj/org/freedesktop/.cvsignore:
3469 * gcj/org/freedesktop/Makefile.am:
3470 * gcj/org/freedesktop/dbus/.cvsignore:
3471 * gcj/org/freedesktop/dbus/Makefile.am:
3472 * gcj/org/freedesktop/dbus/Message.java: (Message),
3474 * gcj/org/freedesktop/dbus/natMessage.cc:
3475 Fix the build system.
3477 2003-06-22 Havoc Pennington <hp@pobox.com>
3479 * mono/Connection.cs: add more bindings
3481 * dbus/dbus-threads.c (dbus_threads_init): allow calling this
3484 2003-06-22 Havoc Pennington <hp@pobox.com>
3486 * mono/Connection.cs, mono/DBus.cs, mono/Error.cs:
3487 Start wrapping more stuff.
3489 2003-06-22 Havoc Pennington <hp@pobox.com>
3491 * mono/Message.cs: implement Message.Wrap() that ensures we only
3492 have a single C# wrapper per DBusMessage, assuming it works which
3493 it probably doesn't.
3495 * dbus/dbus-message.c (dbus_message_allocate_data_slot): new
3496 (dbus_message_free_data_slot): new
3497 (dbus_message_set_data): new
3498 (dbus_message_get_data): new
3500 2003-06-22 Havoc Pennington <hp@pobox.com>
3502 * dbus/dbus-dataslot.c (_dbus_data_slot_allocator_unref)
3503 (_dbus_data_slot_allocator_alloc): rework these to keep a
3504 reference count on each slot and automatically manage a global
3505 slot ID variable passed in by address
3507 * bus/bus.c: convert to new dataslot API
3509 * dbus/dbus-bus.c: convert to new dataslot API
3511 * dbus/dbus-connection.c: convert to new dataslot API
3513 * dbus/dbus-server.c: convert to new dataslot API
3515 * glib/dbus-gmain.c: ditto
3519 * bus/connection.c: ditto
3521 2003-06-22 Anders Carlsson <andersca@codefactory.se>
3523 * configure.in: Add AM_PROG_GCJ and move AM_PROG_LIBTOOL
3524 after the gcj checks so that the correct configuration tags
3525 will be added to libtool.
3527 * dbus-glib-1.pc.in: No need to specify any includes since
3528 dbus-1.pc.in has those.
3530 2003-06-22 Havoc Pennington <hp@pobox.com>
3532 * mono/*, gcj/*, configure.in, Makefile.am:
3533 Check in makefiles and subdirs for mono and gcj bindings.
3534 Neither binding actually exists, just trying to get through
3535 all the build and other boring bits.
3537 2003-06-21 Philip Blundell <philb@gnu.org>
3539 * tools/dbus-monitor.1: Updated.
3541 * tools/dbus-send.1: Likewise.
3543 2003-06-20 Anders Carlsson <andersca@codefactory.se>
3545 * dbus/dbus-transport-unix.c (unix_handle_watch): Check
3546 for hangup and error after checking read so we won't discard
3547 pending data if both hangup and read are set.
3549 2003-06-19 Philip Blundell <philb@gnu.org>
3551 * tools/dbus-print-message.c (print_message): Handle BOOLEAN.
3553 * tools/dbus-send.c: Accept both --system and --session.
3555 * tools/dbus-monitor.c: Same here.
3557 2003-06-19 Anders Carlsson <andersca@codefactory.se>
3559 * glib/dbus-glib.h: Fix so that dbus-glib.h can be used
3560 from C++ (Patch by Miloslav Trmac).
3562 2003-06-15 Joe Shaw <joe@assbarn.com>
3564 * configure.in: Check for socklen_t.
3566 * dbus/dbus-sysdeps.c: Define socklen_t if it's not defined.
3568 * test/test-segfault.c: Add #include <sys/time.h>
3570 * tools/Makefile.am: Add DBUS_X_CFLAGS to the INCLUDES since
3571 dbus-launch needs it.
3573 2003-06-09 Havoc Pennington <hp@redhat.com>
3575 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): don't use
3576 SUN_LEN, it breaks abstract socket usage
3578 * dbus/dbus-internals.c (_dbus_verbose_real): only print PID at
3581 2003-06-04 Havoc Pennington <hp@pobox.com>
3583 * dbus/dbus-server.c (dbus_server_listen): allow abstract sockets
3584 using unix:abstract=/foo, and when listening in a tmpdir
3585 i.e. unix:tmpdir=/tmp, always use abstract sockets if we can.
3587 * dbus/dbus-transport.c (_dbus_transport_open): support
3590 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
3591 support abstract sockets
3593 * dbus/dbus-transport-unix.c
3594 (_dbus_transport_new_for_domain_socket): support abstract sockets
3596 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket): add "abstract"
3597 toggle as an argument, implement abstract namespace support
3598 (_dbus_listen_unix_socket): ditto
3600 * configure.in: add --enable-abstract-sockets and implement
3601 a configure check for autodetection of the right value.
3603 2003-06-01 Havoc Pennington <hp@pobox.com>
3605 * tools/dbus-cleanup-sockets.c: add utility to clean up sockets
3606 in /tmp (though on Linux this will end up being useless,
3607 when we add abstract namespace support)
3609 * configure.in: define DBUS_SESSION_SOCKET_DIR in addition to
3612 2003-05-28 Colin Walters <walters@verbum.org>
3614 * tools/dbus-monitor.c (main): Fix silly typo (s/--session/--system/).
3616 2003-05-18 Anders Carlsson <andersca@codefactory.se>
3618 * dbus/dbus-message.c (dbus_message_new): Remove @todo.
3620 2003-05-17 Colin Walters <walters@gnu.org>
3622 * tools/dbus-send.c: Don't exit with an error code if --help was
3623 passed. Default to using the session bus instead of the system
3626 * tools/dbus-launch.c: Ditto.
3628 * tools/dbus-monitor.c: Ditto.
3630 * tools/dbus-send.1: Update with new arguments.
3632 * tools/dbus-launch.c: Emit code to export variables. New
3633 arguments -s and -c to specify shell syntax, and a bit of code to
3634 autodetect syntax. Also, allow specifying a program to run.
3636 * tools/dbus-launch.1: Update with new arguments.
3638 * tools/dbus-send.1: Ditto.
3640 * tools/dbus-monitor.1: Ditto.
3642 2003-05-17 Havoc Pennington <hp@pobox.com>
3644 * bus/config-parser.c (merge_included): merge in policies from
3645 child configuration file.
3647 * bus/policy.c (bus_policy_merge): function to merge two policies
3650 2003-05-16 Havoc Pennington <hp@redhat.com>
3652 * dbus/dbus-connection.c: disable verbose lock spew
3654 * tools/dbus-send.c: add --print-reply command line option
3656 * tools/dbus-print-message.h (print_message): new util function
3657 shared by dbus-send and dbus-monitor
3659 * tools/dbus-monitor.c (handler_func): exit on disconnect
3661 * dbus/dbus-transport-unix.c (do_reading): if the transport is
3662 disconnected, don't try to use the read_watch
3664 * dbus/dbus-watch.c (dbus_watch_get_enabled): assert watch != NULL
3665 so we can find this bug more easily
3667 2003-05-16 Havoc Pennington <hp@redhat.com>
3669 * bus/policy.c (free_rule_list_func): avoid a crash when passed
3670 NULL as DBusHashTable is annoyingly likely to do.
3672 2003-05-16 Colin Walters <walters@verbum.org>
3674 * tools/dbus-monitor.c: Add --session argument and usage()
3677 * tools/dbus-monitor.1: Update with new --session arg.
3679 * bus/Makefile.am (install-data-hook): Create
3680 $(libdir)/dbus-1.0/services so that the session bus is happy.
3682 2003-05-15 Havoc Pennington <hp@redhat.com>
3684 * dbus/dbus-sysdeps.c (_dbus_atomic_dec, _dbus_atomic_inc): work
3685 on non-x86. ifdef's are evil.
3687 2003-05-15 Havoc Pennington <hp@redhat.com>
3689 * configure.in: 0.11
3693 * bus/Makefile.am (initddir): apparently we are supposed to put
3694 init scripts in /etc/rc.d/init.d not /etc/init.d
3696 * bus/Makefile.am: remove the "you must --enable-tests to make
3697 check" as it broke distcheck
3699 * bus/Makefile.am (install-data-hook): create /etc/dbus-1/system.d
3701 2003-05-13 James Willcox <jwillcox@gnome.org>
3704 * bus/activation.c: (bus_activation_service_created),
3705 (bus_activation_activate_service):
3706 * bus/driver.c: (bus_driver_send_service_deleted),
3707 (bus_driver_send_service_created), (bus_driver_send_service_lost),
3708 (bus_driver_send_service_acquired),
3709 (bus_driver_send_welcome_message),
3710 (bus_driver_handle_list_services):
3711 * bus/session.conf.in:
3712 * dbus/dbus-bus.c: (dbus_bus_acquire_service),
3713 (dbus_bus_service_exists), (dbus_bus_activate_service):
3716 Add some convenience API which lets you activate a service, and did a
3717 bunch of s/0/DBUS_TYPE_INVALID/ in calls to dbus_message_append_args()
3718 and dbus_message_get_args()
3720 2003-05-11 Havoc Pennington <hp@pobox.com>
3722 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix to avoid
3723 calling _dbus_marshal_validate_arg() for every byte in a byte
3726 * dbus/dbus-message-handler.c: use atomic reference counting to
3727 reduce number of locks slightly; the global lock in here sucks
3729 * dbus/dbus-connection.c
3730 (_dbus_connection_update_dispatch_status_and_unlock): variant of
3731 update_dispatch_status that can be called with lock held; then use
3732 in a couple places to reduce locking/unlocking
3733 (dbus_connection_send): hold the lock over the whole function
3734 instead of acquiring it twice.
3736 * dbus/dbus-timeout.c (_dbus_timeout_new): handle OOM
3738 * bus/connection.c (bus_connections_setup_connection): fix access
3739 to already-freed memory.
3741 * dbus/dbus-connection.c: keep a little cache of linked list
3742 nodes, to avoid using the global linked list alloc lock in the
3743 normal send-message case. Instead we just use the connection lock
3744 that we already have to take.
3746 * dbus/dbus-list.c (_dbus_list_find_last): new function
3748 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec):
3749 change to use a struct for the atomic type; fix docs,
3750 they return value before increment, not after increment.
3752 * dbus/dbus-string.c (_dbus_string_append_4_aligned)
3753 (_dbus_string_append_8_aligned): new functions to try to
3754 microoptimize this operation.
3755 (reallocate_for_length): break this out of set_length(), to
3756 improve profile info, and also so we can consider inlining the
3759 * dbus/dbus-message.c (dbus_message_new_empty_header): init data
3760 strings with some preallocation, cuts down on our calls to realloc
3761 a fair bit. Though if we can get the "move entire string to empty
3762 string" optimization below to kick in here, it would be better.
3764 * dbus/dbus-string.c (_dbus_string_move): just call
3765 _dbus_string_move_len
3766 (_dbus_string_move_len): add a special case for moving
3767 an entire string into an empty string; we can just
3768 swap the string data instead of doing any reallocs.
3769 (_dbus_string_init_preallocated): new function
3771 2003-05-11 Havoc Pennington <hp@pobox.com>
3773 Write a "test-profile" that does echo client-server with threads;
3774 profile reveals lock contention, memcpy/realloc of buffers, and
3775 UTF-8 validation as hot spots. 20% of lock contention eliminated
3776 with dbus_atomic_inc/dec implementation on x86. Much remaining
3777 contention is global mempool locks for GList and DBusList.
3779 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec): add
3782 * dbus/dbus-connection.c (struct DBusConnection): use
3783 dbus_atomic_t for the reference count
3785 * dbus/dbus-message.c (struct DBusMessage): declare
3786 dbus_atomic_t values as volatile
3788 * configure.in: code to detect ability to use atomic integer
3789 operations in assembly, from GLib patch
3791 * dbus/dbus-internals.c (_dbus_verbose_real): call getpid every
3792 time, tired of it being wrong in threads and forked processes
3794 * glib/test-profile.c: a little program to bounce messages back
3795 and forth between threads and eat CPU
3797 * dbus/dbus-connection.c: add debug spew macros for debugging
3798 thread locks; include config.h at top; fix deadlock in
3799 dbus_connection_flush()
3801 2003-05-08 Havoc Pennington <hp@pobox.com>
3803 * dbus/dbus-spawn.c: s/_exit/exit/ because it was keeping gcov
3804 data from getting written, and there wasn't a good reason to
3807 * test/decode-gcov.c (mark_inside_dbus_build_tests): don't count
3808 dbus_verbose lines in test coverage
3809 (main): add list of functions sorted by # of untested blocks
3810 to the coverage report
3812 * dbus/dbus-mempool.c: put some test-only code in DBUS_BUILD_TESTS
3814 * dbus/dbus-marshal.c (_dbus_marshal_test): extend test coverage
3816 * dbus/dbus-message-handler.c (_dbus_message_handler_test):
3817 extend test coverage
3819 * test/data/auth/cancel.auth-script: test canceling an
3822 * dbus/Makefile.am: remove dbus-server-debug.[hc] for now, as they
3823 aren't used. in CVS history if we end up needing them.
3825 2003-05-04 Havoc Pennington <hp@pobox.com>
3827 * dbus/dbus-message-handler.c (_dbus_message_handler_test): add
3830 * dbus/dbus-marshal.c (_dbus_demarshal_string_array): fix this
3831 function, which assumed length was in # of strings, not bytes
3833 * dbus/dbus-message.c (_dbus_message_test): add tests for some
3836 * dbus/dbus-connection.c
3837 (_dbus_connection_queue_received_message): disable function for
3838 now, we are only using it in test mode
3840 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
3841 remove a mistaken FIXME
3843 2003-05-04 Havoc Pennington <hp@pobox.com>
3845 * dbus/dbus-connection.c (dbus_connection_preallocate_send):
3846 unlock mutex on successful return, patch from Anders Gustafsson
3848 2003-05-04 Havoc Pennington <hp@pobox.com>
3850 * dbus-glib-1.pc.in (Requires): fix dependencies, from
3853 2003-05-04 Havoc Pennington <hp@pobox.com>
3855 * tools/dbus-launch.c: implement
3857 * bus/main.c (main), bus/bus.c (bus_context_new):
3858 implement --print-pid and --fork
3860 2003-05-03 Havoc Pennington <hp@redhat.com>
3862 * dbus/dbus-address.c (dbus_parse_address): fix bug when a key in
3863 the address had no value, and add to test suite. Fix and
3864 regression test from Miloslav Trmac
3866 2003-05-03 Havoc Pennington <hp@pobox.com>
3868 * dbus/dbus-watch.c (dbus_watch_handle): warn and return if a
3869 watch is invalid when handled
3871 * tools/Makefile.am, tools/dbus-launch.c, tools/dbus-launch.1: add
3872 dbus-launch utility to launch the bus from a shell script. Didn't
3873 actually implement dbus-launch yet, it's just a placeholder still.
3875 2003-05-03 Havoc Pennington <hp@pobox.com>
3877 * bus/Makefile.am, bus/dbus-daemon-1.1.in: man page for the
3878 daemon; also documents daemon config file, so replaces
3879 doc/config-file.txt. Corrected some stuff from config-file.txt in
3880 the process of moving it.
3882 2003-05-03 Havoc Pennington <hp@pobox.com>
3884 * tools/Makefile.am, tools/dbus-send.1, tools/dbus-monitor.1:
3887 2003-05-03 Colin Walters <walters@verbum.org>
3889 * dbus/dbus-sysdeps.c (fill_user_info): Test against
3890 DBUS_UID_UNSET to determine whether to do a uid lookup or not.
3892 * Makefile.am: Update to use new .pc versioning scheme.
3894 2003-05-02 Havoc Pennington <hp@redhat.com>
3896 * bus/system.conf.in: allow send/receive to/from message bus
3899 2003-04-30 Havoc Pennington <hp@redhat.com>
3901 * configure.in: print a note when building with unit tests and
3904 2003-04-30 Havoc Pennington <hp@redhat.com>
3906 * Makefile.am: add a check-local that complains if you didn't
3907 configure with --enable-tests
3909 2003-04-29 Havoc Pennington <hp@redhat.com>
3911 * glib/dbus-gmain.c: docs cleanups
3913 * dbus/dbus-types.h: add docs on int64 types
3915 * dbus/dbus-memory.c: fix docs to avoid putting private API in
3916 public API docs section
3918 2003-04-29 Havoc Pennington <hp@redhat.com>
3920 * dbus-1.pc.in, dbus-glib-1.pc.in: rename these from
3921 dbus-1.0.pc.in, dbus-glib-1.0.pc.in. As these change with the
3922 parallel install API version, not with the D-BUS package version.
3924 * HACKING: move some of README over here
3926 * README: updates, and document API/ABI policy
3928 * configure.in: reindentation
3930 2003-04-29 Havoc Pennington <hp@redhat.com>
3932 * dbus/dbus.h: add "you have to define DBUS_API_SUBJECT_TO_CHANGE
3933 to use this library" to be sure people have the right
3936 2003-04-28 Havoc Pennington <hp@redhat.com>
3938 * configure.in: add --enable-docs which by default is auto yes if
3939 doxygen and db2html found, no otherwise; but can be forced on/off
3941 * doc/Makefile.am: conditionalize whether to build docs on
3944 2003-04-28 Havoc Pennington <hp@redhat.com>
3946 * configure.in: 0.10
3950 * bus/system.conf.in: add <includedir>system.d</includedir>
3952 * dbus/dbus-userdb.c (_dbus_user_database_lookup): fix bug when
3953 username was provided but not uid
3955 * bus/config-parser.c (struct BusConfigParser): keep track of
3956 whether the parser is toplevel or was included; change some
3957 of the error handling if it's included.
3959 2003-04-27 Havoc Pennington <hp@pobox.com>
3963 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
3964 report correct status if we finish processing authentication
3965 inside this function.
3967 * bus/activation.c (try_send_activation_failure): use
3968 bus_transaction_send_error_reply
3970 * bus/connection.c (bus_connection_get_groups): return an error
3971 explaining the problem
3973 * bus/bus.c (bus_context_check_security_policy): implement
3974 restriction here that inactive connections can only send the
3975 hello message. Also, allow bus driver to send anything to
3978 * bus/connection.c (bus_connection_complete): create the
3979 BusClientPolicy here instead of on-demand.
3980 (bus_connection_get_policy): don't return an error
3982 * dbus/dbus-message.c (dbus_message_new_error_reply): allow NULL
3983 sender field in message being replied to
3985 * bus/bus.c (bus_context_check_security_policy): fix silly typo
3986 causing it to return FALSE always
3988 * bus/policy.c (bus_client_policy_check_can_send): fix bug where
3989 we checked sender rather than destination
3991 2003-04-25 Havoc Pennington <hp@redhat.com>
3993 test suite is slightly hosed at the moment, will fix soon
3995 * bus/connection.c (bus_connections_expire_incomplete): fix to
3996 properly disable the timeout when required
3997 (bus_connection_set_name): check whether we can remove incomplete
3998 connections timeout after we complete each connection.
4000 * dbus/dbus-mainloop.c (check_timeout): fix this up a bit,
4001 probably still broken.
4003 * bus/services.c (bus_registry_acquire_service): implement max
4004 number of services owned, and honor allow/deny rules on which
4005 services a connection can own.
4007 * bus/connection.c (bus_connection_get_policy): report errors here
4009 * bus/activation.c: implement limit on number of pending
4012 2003-04-25 Havoc Pennington <hp@redhat.com>
4014 * dbus/dbus-transport.c (_dbus_transport_get_unix_user): fix bug
4015 where we used >= 0 instead of != DBUS_UID_UNSET.
4017 2003-04-25 Havoc Pennington <hp@redhat.com>
4019 * glib/dbus-gmain.c (remove_watch): fix for a crash when watches
4020 were toggled without add/remove, fix from Anders Gustafsson
4022 2003-04-24 Havoc Pennington <hp@redhat.com>
4024 * test/data/valid-config-files/basic.conf: add <limit> tags to
4027 * bus/config-parser.h, bus/config-parser.c, bus/bus.c: Implement
4028 <limit> tag in configuration file.
4030 2003-04-24 Havoc Pennington <hp@redhat.com>
4032 * bus/dispatch.c: somehow missed some name_is
4034 * dbus/dbus-timeout.c (_dbus_timeout_set_enabled)
4035 (_dbus_timeout_set_interval): new
4037 * bus/connection.c (bus_connections_setup_connection): record time
4038 when each connection is first set up, and expire them after the
4039 auth timeout passes.
4041 2003-04-24 Havoc Pennington <hp@redhat.com>
4043 * dbus/dbus-message.c (dbus_message_name_is): rename
4044 (dbus_message_service_is): rename
4045 (dbus_message_sender_is): rename
4046 (dbus_message_get_service): rename
4048 2003-04-24 Havoc Pennington <hp@redhat.com>
4050 * configure.in: add --enable-checks
4052 * dbus/dbus-message.c (dbus_message_new): reverse name/service arguments
4054 * dbus/dbus-connection.c (dbus_connection_preallocate_send): fix
4055 to use thread locks.
4056 (_dbus_connection_handler_destroyed_locked): move some private
4057 functions into proper docs group
4059 * dbus/dbus-internals.h: add _dbus_return_if_fail,
4060 _dbus_return_val_if_fail
4062 Throughout: use dbus_return_if_fail
4064 2003-04-23 James Willcox <jwillcox@gnome.org>
4067 * glib/dbus-gmain.c: (add_timeout), (wakeup_main), (create_source),
4068 (dbus_connection_setup_with_g_main),
4069 (dbus_server_setup_with_g_main):
4070 * glib/test-dbus-glib.c: (main):
4071 * glib/test-thread-client.c: (main):
4072 * glib/test-thread-server.c: (new_connection_callback), (main):
4073 * tools/dbus-monitor.c: (main):
4075 Added a GMainContext argument to dbus_connection_setup_with_g_main()
4076 and dbus_server_setup_with_g_main().
4078 2003-04-20 Havoc Pennington <hp@pobox.com>
4080 * doc/dbus-specification.sgml: document the restrictions on
4081 message and service names
4083 2003-04-22 Havoc Pennington <hp@redhat.com>
4085 * dbus/dbus-message.c, dbus/dbus-marshal.c: add 64-bit integer
4086 support, and do some code cleanups to share more code and
4087 speed up array marshal/demarshal.
4089 * dbus-1.0.pc.in (Cflags): put libdir include file in cflags
4091 * configure.in: generate dbus-arch-deps.h
4093 * dbus/dbus-protocol.h (DBUS_TYPE_INT64, DBUS_TYPE_UINT64): add
4096 2003-04-22 Havoc Pennington <hp@redhat.com>
4098 * test/data/valid-messages/opposite-endian.message: fix test
4099 to use proper type for rply field
4101 * test/data/invalid-messages: add tests for below validation
4103 * dbus/dbus-message.c (decode_header_data): validate field types,
4104 and validate that named fields are valid names
4105 (decode_name_field): consider messages in the
4106 org.freedesktop.Local. namespace to be invalid.
4108 * dbus/dbus-string.c (_dbus_string_validate_name): new
4110 2003-04-19 Havoc Pennington <hp@pobox.com>
4112 * bus/driver.c (bus_driver_handle_hello): check limits and
4113 return an error if they are exceeded.
4115 * bus/connection.c: maintain separate lists of active and inactive
4116 connections, and a count of each. Maintain count of completed
4117 connections per user. Implement code to check connection limits.
4119 * dbus/dbus-list.c (_dbus_list_unlink): export
4121 * bus/bus.c (bus_context_check_security_policy): enforce a maximum
4122 number of bytes in the message queue for a connection
4124 2003-04-18 Havoc Pennington <hp@pobox.com>
4126 * dbus/dbus-auth.c (record_mechanisms): memleak fixes
4128 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): fix some
4131 * dbus/dbus-keyring.c (add_new_key): fix a memleak, and
4132 on realloc be sure to update the pointer in the keyring
4134 * dbus/dbus-string.c (_dbus_string_zero): compensate for align
4135 offset to avoid writing to unallocated memory
4137 * dbus/dbus-auth.c (process_rejected): return FALSE if we fail to
4138 try the next mechanism, so we properly handle OOM
4140 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): fix double-free
4142 (_dbus_keyring_new): fix OOM bug
4143 (_dbus_keyring_new_homedir): always set error; impose a maximum
4144 number of keys we'll load from the file, mostly to speed up the
4145 test suite and make its OOM checks more useful, but also for
4148 * dbus/dbus-auth.c (process_error_server): reject authentication
4149 if we get an error from the client
4150 (process_cancel): on cancel, send REJECTED, per the spec
4151 (process_error_client): send CANCEL if we get an error from the
4154 2003-04-18 Havoc Pennington <hp@pobox.com>
4156 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix UMR in verbose
4159 * dbus/dbus-auth.c (handle_client_data_cookie_sha1_mech): fix OOM
4162 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): only whine
4163 about DBUS_TEST_HOMEDIR once
4165 * bus/Makefile.am (TESTS_ENVIRONMENT): put DBUS_TEST_HOMEDIR in
4168 * bus/dispatch.c (bus_dispatch_sha1_test): actually load sha1
4169 config file so we test the right thing
4171 Throughout: assorted docs improvements
4173 2003-04-18 Havoc Pennington <hp@pobox.com>
4175 * glib/dbus-gmain.c: adapt to watch changes
4177 * bus/bus.c, bus/activation.c, etc.: adjust to watch changes
4179 * dbus/dbus-server.h: remove dbus_server_handle_watch
4181 * dbus/dbus-connection.h: remove dbus_connection_handle_watch
4183 * dbus/dbus-watch.c (dbus_watch_handle): change DBusWatch to work
4184 like DBusTimeout, so we don't need dbus_connection_handle_watch
4187 2003-04-17 Havoc Pennington <hp@redhat.com>
4189 * dbus/dbus-userdb.c, dbus/dbus-sysdeps.c: redo all the passwd
4190 database usage so it all goes via the DBusUserDatabase cache.
4192 2003-04-17 Havoc Pennington <hp@redhat.com>
4194 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix logic so that if
4195 there was an OOM watch we skipped, we always return TRUE so we
4196 iterate again to have a look at it again. Fixes test suite hang.
4197 Code rearrangement also lets us lose some memset and only iterate
4198 over callbacks once.
4200 * bus/driver.c (bus_driver_handle_message): sense of test for
4203 2003-04-16 Havoc Pennington <hp@pobox.com>
4205 * doc/dbus-specification.sgml: make spec say serials are unsigned
4207 * dbus/dbus-message.h: change message serials to unsigned
4209 * dbus/dbus-connection.c: adapt to message serials being unsigned
4211 2003-04-15 Havoc Pennington <hp@pobox.com>
4213 * bus/bus.c: create and keep around a shared DBusUserDatabase
4216 * bus/connection.c (bus_connection_get_groups): don't cache
4217 groups for user in the connection object, since user database
4218 object now does that.
4220 2003-04-16 Havoc Pennington <hp@redhat.com>
4222 * dbus/dbus-message.c (_dbus_message_add_size_counter): keep a
4223 list of size counters
4224 (_dbus_message_loader_putback_message_link): put back a popped link
4226 * dbus/dbus-connection.c
4227 (dbus_connection_set_max_live_messages_size): rename
4229 (dbus_connection_get_outgoing_size): get size of outgoing
4231 (_dbus_connection_set_connection_counter): remove this cruft
4233 2003-04-14 Havoc Pennington <hp@redhat.com>
4235 * dbus/dbus-userdb.c: user database abstraction, mostly to get
4236 caching, but at some point we might want to be able to use a
4239 * bus/dispatch.c (bus_dispatch_sha1_test): add a test that uses
4240 SHA1 conf file to test the sha1 auth mechanism, since the regular
4241 test always uses EXTERNAL when available.
4244 test/data/valid-config-files/debug-allow-all-sha1.conf.in:
4245 add conf file that requires use of sha1 auth
4247 2003-04-13 Havoc Pennington <hp@pobox.com>
4249 * tools/dbus-send.c, tools/dbus-monitor.c: two utility programs
4250 from Philip Blundell to send messages and monitor them.
4252 2003-04-13 Havoc Pennington <hp@pobox.com>
4254 * dbus/dbus-mainloop.c: fix some reentrancy issues by refcounting
4257 * test/data/valid-config-files/debug-allow-all.conf.in: allow all
4260 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
4261 fix to only recover unused bytes if we're already authenticated
4262 (_dbus_transport_get_is_authenticated): fix to still mark us
4263 authenticated if there are unused bytes.
4265 * bus/dispatch.c: implement security policy checking
4267 * bus/connection.c (bus_transaction_send_from_driver): new
4269 * bus/bus.c (bus_context_check_security_policy): new
4271 * bus/dispatch.c (send_service_nonexistent_error): delete this,
4272 now we just set the DBusError and it gets converted to an error
4275 * bus/connection.c (allow_user_function): enable code using actual
4276 data from the config file
4278 * bus/policy.c (list_allows_user): handle wildcard rules for
4279 user/group connection perms
4281 2003-04-13 Havoc Pennington <hp@pobox.com>
4283 * bus/config-parser.c: Load up the BusPolicy and BusPolicyRules
4285 * dbus/dbus-sysdeps.c (_dbus_get_user_id): new function
4287 * bus/policy.c (bus_policy_append_mandatory_rule)
4288 (bus_policy_append_default_rule, bus_policy_append_user_rule)
4289 (bus_policy_append_group_rule): new functions
4291 2003-04-12 Havoc Pennington <hp@pobox.com>
4293 * bus/config-parser.c (bus_config_parser_new): fix a memleak
4295 * dbus/dbus-sysdeps.c: change DBusCredentials to use longs for
4296 the pid/gid/uid, just for paranoia.
4298 * test/break-loader.c (randomly_do_n_things): find a byte
4299 containing a type code, and randomly change it to a different
4302 2003-04-12 Havoc Pennington <hp@pobox.com>
4304 * bus/policy.h: change BusPolicy to be the thing from the config
4305 file, and rename old BusPolicy to BusClientPolicy
4307 * bus/bus.c, bus/connection.c, bus/config-parser.c: change to
4308 match change in how policy works
4310 * dbus/dbus-internals.h: mark assert_not_reached as
4311 __attribute((noreturn))__
4313 2003-04-11 Havoc Pennington <hp@redhat.com>
4315 * doc/dbus-specification.sgml: fix a spot with the wrong name for
4316 the broadcast service. Use boolean return for ServiceExists.
4318 2003-04-11 Havoc Pennington <hp@redhat.com>
4320 * configure.in: add another directory to look for qt in.
4322 2003-04-11 Havoc Pennington <hp@redhat.com>
4324 * AUTHORS: add Colin Walters
4326 2003-04-11 Havoc Pennington <hp@redhat.com>
4332 2003-04-11 Havoc Pennington <hp@redhat.com>
4334 * bus/messagebus.in: remove pid file when stopping the
4335 message bus, since the bus won't have privileges to remove it
4338 2003-04-11 Havoc Pennington <hp@redhat.com>
4340 * bus/bus.c (bus_context_new): move credentials change after
4343 2003-04-11 Havoc Pennington <hp@pobox.com>
4345 * test/decode-gcov.c: add "below average functions" to the
4346 coverage report, and change how some of the code works.
4348 * bus/test-main.c: bracket some stuff in DBUS_BUILD_TESTS so it's
4349 not in the coverage stats.
4351 * test/test-service.c (main): use _dbus_verbose not fprintf in a
4352 couple places so running the test suite doesn't result in megaspam.
4354 2003-04-11 Havoc Pennington <hp@pobox.com>
4356 * bus/dispatch.c (check_existent_service_activation): accept a no
4357 memory error in a place we didn't before
4359 * bus/test.c (bus_test_run_everything): remove hacky "do it twice
4360 in case the first one failed," since the test suite is less
4363 2003-04-10 Havoc Pennington <hp@pobox.com>
4365 * bus/dispatch.c (check_segfault_service_activation): add test
4366 for launching an executable that just crashes.
4368 * test/test-segfault.c (main): try setting coredumpsize to 0 so we
4369 don't leave a million cores. We'll see how portable this is.
4371 2003-04-10 Havoc Pennington <hp@pobox.com>
4373 * dbus/dbus-spawn.c (_dbus_spawn_async_with_babysitter): move all
4374 the possible parent failures before we fork, so that we don't
4375 fail to create a babysitter after creating the child.
4377 * bus/activation.c (bus_activation_activate_service): kill child
4378 if we don't successfully complete the activation.
4380 2003-04-10 Havoc Pennington <hp@redhat.com>
4382 * dbus/dbus-connection.c (dbus_connection_flush): don't spin on
4383 the connection if it's disconnected
4385 * bus/activation.c (bus_activation_service_created): use new
4386 transaction features to roll back removal of pending activation if
4387 we don't successfully create the service after all. Don't remove
4388 pending activation if the function fails.
4390 * dbus/dbus-list.c (_dbus_list_insert_before_link)
4391 (_dbus_list_insert_after_link): new code to facilitate
4394 * dbus/dbus-hash.c (_dbus_hash_table_insert_string_preallocated):
4395 new functionality, so we can preallocate the ability to insert
4398 * bus/connection.c (bus_transaction_add_cancel_hook): new function
4399 allowing us to put custom hooks in a transaction to be used for
4400 cancelling said transaction
4402 * doc/dbus-specification.sgml: add some discussion of secondary
4403 service owners, and disallow zero-length service names
4405 * bus/services.c (bus_registry_acquire_service): new function,
4406 splits out part of bus_driver_handle_acquire_service() and fixes
4407 a bug where we didn't remove the service doing the acquiring
4408 from the secondary queue if we failed to remove the current owner
4409 from the front of the queue.
4411 2003-04-10 Alexander Larsson <alexl@redhat.com>
4413 * doc/dbus-specification.sgml:
4414 s/org.freedesktop.Broadcast/org.freedesktop.DBus.Broadcast/
4416 2003-04-10 Alexander Larsson <alexl@redhat.com>
4421 Added files to cvsignore
4423 * dbus/dbus-message.h:
4424 * dbus/dbus-message.c: (dbus_message_iter_get_named):
4425 Make get_named() take two out argument and return a boolean.
4426 (dbus_message_iter_get_args_valist):
4427 Update usage of get_named().
4428 (dbus_message_iter_append_byte):
4430 (dbus_message_iter_append_named)
4432 (message_iter_test), (check_message_handling_type), (_dbus_message_test):
4435 2003-04-10 Alexander Larsson <alexl@redhat.com>
4437 * dbus/dbus-marshal.[ch]:
4438 Add array_type_pos argument to _dbus_marshal_validate_arg.
4439 Let you pass a NULL end_pos to _dbus_marshal_validate_type.
4441 * dbus/dbus-message.[ch]:
4442 Multi-dimensional arrays have full type specification in the
4443 outermost array. Iter code re-arranged to handle this.
4444 Added some more iter tests.
4446 * doc/dbus-specification.sgml:
4449 Update new array encoding description.
4450 Correct DBUS_SERVICE_FLAGS_REPLACE_EXISTING description.
4452 * test/data/invalid-messages/array-with-mixed-types.message:
4453 * test/data/valid-messages/array-of-array-of-uint32.message:
4454 Change to the new array format.
4456 * test/data/invalid-messages/too-short-dict.message:
4459 * test/data/valid-messages/recursive-types.message:
4460 Fix up and extend test.
4462 2003-04-10 Havoc Pennington <hp@pobox.com>
4464 * bus/dispatch.c: lots of fixes
4466 * dbus/dbus-mainloop.c (_dbus_loop_dispatch): export
4467 (_dbus_loop_iterate): remove old "quit if no callbacks" code,
4468 that was crack, broke the test service.
4470 * dbus/dbus-transport.c (_dbus_transport_open): fix error
4471 handling to avoid piling up errors if we get a failure on the
4474 * dbus/dbus-internals.c (_dbus_real_assert_not_reached): include
4475 pid in assertion failures.
4477 * dbus/dbus-mainloop.c (_dbus_loop_iterate): use static arrays up
4478 to some fixed size of file descriptor array. Don't return TRUE
4479 anytime a timeout exists, that led to lots of busy loop silliness
4482 2003-04-09 Havoc Pennington <hp@redhat.com>
4484 * dbus/dbus-mainloop.c (check_timeout): fix timeouts, I thought
4485 I'd checked this in earlier but hadn't.
4487 2003-04-09 Havoc Pennington <hp@redhat.com>
4489 * bus/dispatch.c (bus_dispatch_test): get a bit further through
4490 the activation test (man this is getting old!)
4492 2003-04-09 Havoc Pennington <hp@redhat.com>
4494 * test/test-utils.c: use dispatch status function to fix this up
4496 * bus/connection.c (connection_watch_callback): don't dispatch
4498 (connection_timeout_callback): don't dispatch from here
4499 (bus_connections_setup_connection): set the dispatch status function
4500 (bus_connection_disconnected): unset it
4502 * dbus/dbus-mainloop.c (_dbus_loop_queue_dispatch): new function
4503 used to add a connection to be dispatched
4504 (_dbus_loop_iterate): do the dispatching at the end of each
4507 * dbus/dbus-connection.c
4508 (dbus_connection_set_dispatch_status_function): new function
4509 allowing us to fix up main loop usage
4510 (_dbus_connection_last_unref): free all the various function
4512 (dbus_connection_dispatch): call the DispatchStatusFunction
4513 whenever this function returns
4514 (dbus_connection_handle_watch): call DispatchStatusFunction
4515 (dbus_connection_send_with_reply_and_block): call DispatchStatusFunction
4516 (reply_handler_timeout): call DispatchStatusFunction
4517 (dbus_connection_flush): call DispatchStatusFunction
4519 2003-04-09 Havoc Pennington <hp@redhat.com>
4521 * dbus/dbus-bus.c (dbus_bus_register): fix up error handling and
4524 * bus/dispatch.c (check_service_activated): fix bug in test
4526 * dbus/dbus-mainloop.c (check_timeout): fix this up
4528 * dbus/dbus-internals.c (_dbus_verbose_real): include PID in
4529 verbose output so we can sort out output from different processes,
4530 e.g. in the activation case.
4532 2003-04-08 Colin Walters <walters@gnu.org>
4534 * bus/bus.c (struct BusContext) [pidfile]: New member, to store
4536 (bus_context_new): Set it.
4537 (bus_context_unref): Use it to delete the pid file.
4539 2003-04-08 Havoc Pennington <hp@redhat.com>
4541 * test/data/invalid-messages/array-with-mixed-types.message:
4542 regression test that fails for the moment
4544 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): reorder
4545 tests for convenience
4547 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): don't allow
4548 array of nil, it broke things.
4550 * test/data/invalid-messages/array-of-nil.message: regression test
4552 * test/data/valid-messages/array-of-array-of-uint32.message:
4553 happened to write this so added it to suite
4555 2003-04-08 Havoc Pennington <hp@redhat.com>
4557 * bus/driver.c (bus_driver_handle_acquire_service): init
4558 retval/reply before checking name
4560 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add a
4561 recursion depth argument
4563 * dbus/dbus-message.h (struct DBusMessageIter): put some padding
4564 in the public struct for future extension
4566 * dbus/dbus-message-builder.c (_dbus_message_data_load): fix
4569 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix a verbose
4572 * doc/dbus-specification.sgml: fix typo
4574 2003-04-08 Alexander Larsson <alexl@redhat.com>
4576 Implemented recursive types, named types and new-style iters
4579 * glib/test-thread-client.c: (thread_func):
4580 * glib/test-thread-server.c: (handle_test_message):
4581 * test/test-service.c: (handle_echo):
4590 * dbus/dbus-internals.c: (_dbus_type_to_string):
4591 Update for new types.
4593 * dbus/dbus-marshal.[ch]:
4594 Implement recursive types and the new marshalling format.
4595 Remove hardcoded dict marshalling.
4596 Marshal named types.
4598 * dbus/dbus-message-builder.c:
4600 Remove references to old types
4602 * dbus/dbus-message.[ch]:
4603 New non-refcounted iter API that supports recursive iters.
4604 Use iters for appending, including support for recursive
4606 Add byte and named type support.
4607 Update everything to new marshalling formats.
4608 Add tests for new API.
4610 * dbus/dbus-protocol.h:
4611 Remove old array types.
4612 Add types: BYTE, ARRAY, DICT, NAMED
4614 * dbus/dbus-string.c:
4615 * dbus/dbus-sysdeps.c:
4616 Make parse_double locale safe.
4618 * dbus/dbus-test-main.c:
4624 * doc/dbus-specification.sgml:
4627 * test/data/incomplete-messages/missing-body.message:
4628 * test/data/invalid-messages/bad-boolean.message:
4629 * test/data/invalid-messages/bad-boolean-array.message:
4630 * test/data/invalid-messages/boolean-array-length-too-long.message-raw:
4631 * test/data/invalid-messages/boolean-has-no-value.message-raw:
4632 * test/data/invalid-messages/too-short-dict.message:
4633 * test/data/valid-messages/dict-simple.message:
4634 * test/data/valid-messages/dict.message:
4635 * test/data/valid-messages/emptiness.message:
4636 * test/data/valid-messages/lots-of-arguments.message:
4637 * test/data/valid-messages/no-padding.message:
4638 * test/data/valid-messages/recursive-types.message:
4639 Add missing NAME fields
4640 Fix up dicts & arrays
4642 * test/data/invalid-messages/dict-with-nil-value.message:
4643 Removed, this is not invalid anymore.
4645 * test/data/valid-messages/recursive-types.message:
4646 Add new test for deeply recursive types.
4648 2003-04-07 Havoc Pennington <hp@pobox.com>
4650 * bus/driver.c (bus_driver_handle_acquire_service): return an
4651 error if you try to acquire a service that starts with ':'
4653 2003-04-07 Havoc Pennington <hp@redhat.com>
4655 * doc/dbus-specification.sgml: require that base service names
4656 start with ':' and that the base service is created/deleted
4657 as first and last things a connection does on the bus
4659 * bus/dispatch.c (check_existent_service_activation): lots more
4660 work on the activation test; it doesn't fully pass yet...
4662 * test/test-service.c (main): fix so we don't memleak the
4663 connection to the message bus
4664 (filter_func): accept a message asking us to exit
4666 2003-04-06 Havoc Pennington <hp@pobox.com>
4668 * qt/Makefile.am (dbusinclude_HEADERS): install dbus-qt.h,
4671 * configure.in: fixes to Qt detection from Colin Walters
4673 * doc/Makefile.am: Only remove generated docbook dirs if they
4674 exist, from Colin Walters
4676 * dbus/dbus-bus.c: change how we set well-known connections to
4677 NULL, so that it works if a single connection is stored in
4678 two well-known array slots.
4680 * test/Makefile.am: remove a lot of stuff that isn't immediately
4681 useful, it's in CVS history if we want it.
4683 * test/test-service.c: use dbus-mainloop instead of that
4686 2003-04-06 Havoc Pennington <hp@pobox.com>
4688 * dbus/Makefile.am: split lists of sources into stuff that goes in
4689 the library, util functions that go in the lib and are also used
4690 elsewhere, and util functions that are used in tests/daemon but
4691 don't go in the lib.
4693 * dbus/dbus-mainloop.h, dbus/dbus-mainloop.c: move bus/loop.[hc]
4694 here so it can be used in test binaries also
4696 2003-04-06 Havoc Pennington <hp@pobox.com>
4698 * dbus/dbus-sysdeps.c (_dbus_become_daemon): write the pidfile
4699 here in the parent process, so we can return an error if it
4700 fails. Also, move some of the code into the child so the parent
4701 is less hosed if we fail midway through.
4703 * bus/bus.c (bus_context_new): move pidfile detection further up
4704 in the function, before we start overwriting sockets and such.
4706 * bus/messagebus.in: adjust this a bit, not sure if it will work.
4708 * configure.in: add --with-system-pid-file and --with-system-socket
4710 2003-04-06 Colin Walters <walters@verbum.org>
4712 * configure.in (DBUS_SYSTEM_PID_FILE): New variable.
4714 * bus/system.conf.in: Declare a pidfile.
4716 * bus/bus.c (bus_context_new): Test for an existing pid file, and
4717 create one (if appropriate).
4719 * bus/config-parser.c (enum ElementType) [ELEMENT_PIDFILE]: New.
4720 (struct BusConfigParser) [pidfile]: New.
4721 (element_type_to_name, merge_included, start_busconfig_child)
4722 (bus_config_parser_end_element, bus_config_parser_content): Handle it.
4723 (bus_config_parser_unref): Free it.
4724 (bus_config_parser_get_pidfile): New function.
4726 * bus/config-parser.h (_dbus_write_pid_file): Prototype.
4728 * dbus/dbus-errors.h (DBUS_ERROR_PIDFILE_EXISTS): New error.
4730 * dbus/dbus-sysdeps.c (_dbus_write_pid_file): New function.
4732 * dbus/dbus-sysdeps.h: Prototype it.
4734 2003-04-06 Havoc Pennington <hp@pobox.com>
4736 * bus/bus.c (bus_context_new): print the address in here, rather
4737 than in main(), because we need to do it before forking the daemon
4739 * bus/dispatch.c (send_service_nonexistent_error): set the sender
4740 on the service nonexistent error
4742 * bus/driver.c (bus_driver_handle_acquire_service): set the
4743 sender on the AcquireService reply
4745 * test/data/valid-config-files/debug-allow-all.conf.in: Make test
4746 server also listen on a UNIX socket so services can connect to it.
4748 2003-04-06 Havoc Pennington <hp@pobox.com>
4750 * dbus/dbus-threads.c: Redo how the fake debug mutexes are done
4751 so it detects deadlocks and also we actually init threads when
4754 2003-04-06 Havoc Pennington <hp@pobox.com>
4756 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
4757 save the domain socket name, and unlink it when we disconnect the
4758 server. Means that at least when we exit normally, we won't leave
4759 a bunch of junk in /tmp
4761 * dbus/dbus-transport-unix.c
4762 (_dbus_transport_new_for_domain_socket): code cleanup (nicer
4763 memory management). (I was making a real change here but then
4766 2003-04-06 Havoc Pennington <hp@pobox.com>
4768 * bus/bus.c (bus_context_new): fix wrong handling of
4769 server_data_slot_unref() in the error case.
4771 * dbus/dbus-internals.h (_dbus_assert): change so it passes
4772 "(condition) != 0" to _dbus_real_assert so that
4773 "_dbus_assert (pointer)" doesn't cause a warning
4775 * bus/main.c (main): accept --print-address option to print out
4776 the message bus address
4778 * dbus/dbus-sysdeps.c (_dbus_generate_random_ascii): export this
4780 * dbus/dbus-transport.c (_dbus_transport_open): special error for
4781 "tmpdir" option to unix: address on client side
4783 * dbus/dbus-server.c (dbus_server_listen): handle "tmpdir" option
4786 * configure.in (TEST_SOCKET_DIR): locate a temporary directory
4787 we can use to create sockets in the test suite.
4789 * bus/main.c (signal_handler): on SIGTERM, exit the daemon
4790 cleanly. To be used for testing.
4792 * dbus/dbus-spawn.c (babysit): use _dbus_set_signal_handler()
4794 * dbus/dbus-sysdeps.c (_dbus_set_signal_handler): new
4796 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
4797 handle trying to call this when there's no servers active
4799 2003-04-05 Havoc Pennington <hp@pobox.com>
4805 2003-04-05 Havoc Pennington <hp@pobox.com>
4807 * bus/bus.c (setup_server): fix this so dbus-daemon-1 doesn't
4808 crash on startup. Need to get "try starting the daemon"
4809 in the test suite I guess. ;-)
4811 * dbus/dbus-server.h, dbus/dbus-server.c: remove the stuff that
4812 tracked the number of open connections; it's better done in
4813 application-specific code as you want it to span all servers etc.
4815 2003-04-05 Havoc Pennington <hp@pobox.com>
4817 * bus/Makefile.am (install-data-hook): add missing DESTDIR,
4818 patch from Colin Walters
4820 2003-04-05 Havoc Pennington <hp@pobox.com>
4822 * doc/config-file.txt (Elements): fix docs of <auth> to reflect
4823 reality; in fact multiple mechanisms are allowed.
4825 * dbus/dbus-internals.c (_dbus_real_assert)
4826 (_dbus_real_assert_not_reached): move guts of _dbus_assert() and
4827 _dbus_assert_not_reached() into functions, so that they don't show
4828 up in basic block counts for test coverage, and don't use up as
4829 much disk space. Does mean slower execution speed though, so
4830 assumes --disable-asserts is the normal production case.
4832 2003-04-05 Havoc Pennington <hp@pobox.com>
4834 * test/Makefile.am (dist-hook): also dist *.in files
4840 2003-04-05 Havoc Pennington <hp@pobox.com>
4842 * dbus/dbus-string.c: docs warning
4844 * dbus/dbus-spawn.c: missing docs
4846 * dbus/dbus-memory.c (struct ShutdownClosure): missing docs
4848 2003-04-05 Havoc Pennington <hp@pobox.com>
4850 * bus/loop.c (bus_loop_iterate): fix the timeout code, using
4853 * dbus/dbus-spawn.c (_dbus_babysitter_unref): set sitter_pid
4854 to -1 once we've reaped the babysitter
4855 (_dbus_babysitter_handle_watch): do as much work as we can, not
4858 * bus/activation.c: add code using DBusBabysitter so that we
4859 handle it when a service fails to start up properly.
4860 (bus_activation_service_created): don't remove the activation
4861 entries as we go, just let them get removed when we free the pending
4862 activation. Unref reply messages after sending them.
4864 2003-04-05 Havoc Pennington <hp@pobox.com>
4866 * test/decode-gcov.c (main): print per-directory stats in the report
4868 * Makefile.am (coverage-report.txt): don't include test/* in gcov stats
4870 2003-04-05 Havoc Pennington <hp@pobox.com>
4872 * Makefile.am (coverage-report.txt): add target "coverage-report.txt"
4874 * test/decode-gcov.c: hack up a little program to suck data
4875 out of gcov files. Yes this is sort of silly.
4877 * configure.in: define something in config.h and do an
4878 AM_CONDITIONAL when gcov is enabled
4880 2003-04-04 Havoc Pennington <hp@redhat.com>
4882 * dbus/dbus-spawn.c, dbus/dbus-spawn.h: Change dbus_spawn to
4883 return a "babysitter" object that is used to monitor the status of
4884 the spawned process and reap it when required.
4886 * test/test-segfault.c, test/test-exit.c,
4887 test/test-sleep-forever.c: binaries that do various lame things,
4888 used in the test suite.
4890 * dbus/dbus-sysdeps.c: kill _dbus_errno_to_string()
4892 2003-04-03 Havoc Pennington <hp@pobox.com>
4894 * dbus/dbus-spawn.c: Move dbus-spawn into a separate file
4895 in preparation for modifying it, dbus-sysdeps is getting
4898 2003-04-03 Havoc Pennington <hp@redhat.com>
4900 * bus/loop.h, bus/loop.c: make the mainloop an object so we can
4903 * bus/*.[hc]: adapt to mainloop change
4905 2003-04-03 Havoc Pennington <hp@redhat.com>
4907 * bus/activation.c (load_directory): fix up memleaks
4908 (bus_activation_entry_free): free the entry
4910 * dbus/dbus-bus.c (dbus_bus_acquire_service): return an error if
4911 we get one from the message bus; fix memleaks.
4913 * dbus/dbus-message.c (dbus_set_error_from_message): new function
4915 2003-04-03 Havoc Pennington <hp@pobox.com>
4917 * bus/config-parser.c (bus_config_parser_unref): free
4918 list of mechanisms, bug discovered by test suite enhancements
4919 (putting system.conf and session.conf into suite)
4921 * test/Makefile.am, test/test-service.c: add placeholder for a
4922 test service that we'll activate as part of test suite. Doesn't
4925 * dbus/dbus-sysdeps.c (_dbus_setenv): support unsetenv by
4926 setting NULL value, and use system malloc not dbus_malloc()
4927 when we have unavoidable memleakage.
4929 * dbus/dbus-bus.c (dbus_bus_get): fix bug where bus type of 0
4930 didn't work, and support DBUS_BUS_ACTIVATION.
4932 * bus/activation.c (child_setup): pass our well-known bus type to
4935 * bus/config-parser.c: support <type> to specify well-known type
4937 * doc/dbus-specification.sgml: document the env variables to
4938 locate well-known buses and find service activator
4940 2003-04-02 Havoc Pennington <hp@redhat.com>
4942 * test/Makefile.am (all-local): add a rule to copy tests to
4943 builddir, so we can have generated tests. Use this to remove the
4944 silly hack for testing system.conf and session.conf. Will use this
4945 shortly to generate .service files pointing to test binaries.
4947 2003-04-02 Havoc Pennington <hp@redhat.com>
4949 * dbus/dbus-string.c (set_length): fix a bug - we allocated max of
4950 current alloc and needed new length, not max of the doubled
4951 allocation and needed new length. Also, when building tests,
4952 don't do the double-allocation stuff, just realloc every time.
4954 2003-04-02 Havoc Pennington <hp@redhat.com>
4956 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): include filenames
4958 (_dbus_string_get_dirname): new
4959 (_dbus_sysdeps_test): new
4960 (_dbus_directory_open): include dirnames in error messages
4962 * bus/config-parser.c: interpret <include> and <includedir> and
4963 <servicedir> relative to config file location if the given
4964 filename is not absolute.
4966 * dbus/dbus-string.c (_dbus_string_find_byte_backward): new
4968 2003-04-02 Havoc Pennington <hp@redhat.com>
4970 * bus/connection.c (bus_transaction_send_error_reply): set sender
4971 service for the error, and unref the reply on success
4973 * bus/activation.c: convert to use BusTransaction so OOM can be
4975 (bus_activation_service_created): set sender of the message
4977 2003-04-01 Havoc Pennington <hp@redhat.com>
4979 * bus/config-parser.c, bus/bus.c: implement <servicedir> and
4980 <includedir> (at least mostly)
4982 * dbus/dbus-sysdeps.c (_dbus_change_identity): set the group ID
4983 first, then the user ID
4985 2003-04-01 Havoc Pennington <hp@pobox.com>
4987 * dbus/dbus-server.c (dbus_server_set_auth_mechanisms): new
4990 * dbus/dbus-auth.c (_dbus_auth_set_mechanisms): new
4992 * dbus/dbus-internals.c (_dbus_dup_string_array): new function
4994 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): chmod the
4995 socket 0777, and unlink any existing socket.
4997 * bus/bus.c (bus_context_new): change our UID/GID and fork if
4998 the configuration file so specifies; set up auth mechanism
5001 * bus/config-parser.c (bus_config_parser_content): add support
5002 for <fork> option and fill in code for <auth>
5004 * bus/system.conf.in: add <fork/> to default configuration,
5005 and limit auth mechanisms to EXTERNAL
5007 * doc/config-file.txt (Elements): add <fork>
5009 * dbus/dbus-sysdeps.c (_dbus_become_daemon): new function
5010 (_dbus_change_identity): new function
5012 2003-03-31 Havoc Pennington <hp@redhat.com>
5014 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket)
5015 (_dbus_listen_unix_socket): fix off-by-one error in null
5016 termination spotted by Nalin
5018 2003-03-31 Havoc Pennington <hp@redhat.com>
5020 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): allow setting
5021 DBUS_TEST_HOMEDIR when tests are enabled, so we can test without
5022 having a real home directory available.
5024 2003-03-31 Havoc Pennington <hp@redhat.com>
5026 * bus/Makefile.am (install-data-hook): create /var/run/dbus
5028 * bus/messagebus.in: add init script for Red Hat /etc/init.d
5030 * configure.in: add support for specifying a style of init script
5033 2003-03-31 Havoc Pennington <hp@redhat.com>
5035 Fix some annoying DBusString API and fix all affected code.
5037 * dbus/dbus-string.c (_dbus_string_init): get rid of annoying
5039 (_dbus_string_get_data): change to return string instead of using
5041 (_dbus_string_get_const_data): ditto
5042 (_dbus_string_get_data_len): ditto
5043 (_dbus_string_get_const_data_len): ditto
5045 2003-03-31 Havoc Pennington <hp@redhat.com>
5047 * bus/main.c (main): fix up the command line arguments to be nicer
5049 2003-03-31 Havoc Pennington <hp@redhat.com>
5051 * dbus/Makefile.am (INCLUDES): use EXPANDED_LOCALSTATEDIR to
5052 define DBUS_SYSTEM_BUS_PATH as we want to compile in the same
5053 final location that lands in the config file
5055 * bus/config-loader-expat.c (bus_config_load): fix type of
5058 * doc/TODO: remove TODO item for dbus_bus_get()
5060 * dbus/dbus-bus.c (bus_data_free): add missing lock/unlock
5062 2003-03-31 Havoc Pennington <hp@pobox.com>
5064 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_domain_socket)
5065 (_dbus_transport_new_for_tcp_socket): these didn't need the "server"
5066 argument since they are always client side
5068 * dbus/dbus-server.c (dbus_server_get_address): new function
5070 * bus/main.c (main): take the configuration file as an argument.
5072 * test/data/valid-config-files/debug-allow-all.conf: new file to
5073 use with dispatch.c tests for example
5075 * bus/test-main.c (main): require test data dir
5077 * bus/bus.c (bus_context_new): change this to take a
5078 configuration file name as argument
5080 * doc/config-file.txt (Elements): add <servicedir>
5082 * bus/system.conf, bus/session.conf: new files
5084 * dbus/dbus-bus.c (dbus_bus_get): look for system bus on
5085 well-known socket if none set
5087 * configure.in: create system.conf and session.conf
5089 2003-03-30 Havoc Pennington <hp@pobox.com>
5091 * bus/config-parser.c: hacking
5093 * dbus/dbus-memory.c: don't use DBusList for the list of stuff
5094 to shut down, since it could cause weirdness with the DBusList
5097 * dbus/dbus-list.c (_dbus_list_test): add tests for the
5098 link-oriented stack routines
5099 (alloc_link): free the mempool if the first alloc from it fails
5101 * dbus/dbus-mempool.c (struct DBusMemBlock): fix alignment issue
5103 * dbus/dbus-string.c (UNICODE_VALID): sync new version of this
5105 (_dbus_string_skip_white): new
5107 * doc/config-file.txt (Elements): add <includedir>
5109 2003-03-28 Havoc Pennington <hp@pobox.com>
5111 * dbus/dbus-string.c (_dbus_string_copy_data_len)
5112 (_dbus_string_copy_data): new functions
5114 2003-03-28 Anders Carlsson <andersca@codefactory.se>
5116 * dbus/dbus-bus.c: (bus_data_free), (dbus_bus_get):
5120 * dbus/dbus-memory.c:
5123 2003-03-28 Havoc Pennington <hp@pobox.com>
5125 * bus/test.c (bus_test_flush_bus): remove the sleep from here,
5126 I think it may have just been superstition. Not sure.
5128 * dbus/dbus-string.c (_dbus_string_base64_decode): catch some OOM
5129 failures that were not being handled.
5131 * dbus/dbus-auth.c (process_auth): fix a memleak in OOM handling
5133 * dbus/dbus-memory.c: add ability to set number of mallocs in a
5134 row that will fail on out-of-memory.
5136 * dbus/dbus-internals.c (_dbus_test_oom_handling): convenience
5137 function for testing out-of-memory handling.
5139 * bus/config-loader-expat.c (memsuite): don't wrap the dbus
5140 allocation functions, they do map exactly to the expat ones.
5142 2003-03-27 Havoc Pennington <hp@redhat.com>
5144 * bus/config-loader-libxml.c (bus_config_load): add another error
5147 2003-03-26 Anders Carlsson <andersca@codefactory.se>
5150 Add note about automatic service activation.
5152 * doc/dbus-specification.sgml:
5153 Rename the specification and clarify a few things.
5155 2003-03-26 Anders Carlsson <andersca@codefactory.se>
5158 * dbus/dbus-address.c:
5160 * dbus/dbus-marshal.c:
5161 * dbus/dbus-server-debug-pipe.c:
5162 * dbus/dbus-transport-unix.c:
5163 Fix documentation warnings.
5165 2003-03-26 Havoc Pennington <hp@pobox.com>
5167 * bus/test-main.c, dbus/dbus-test.c (main): check memleaks
5168 after every test so it's quick and easy to see which leaked, and
5169 so we test multiple dbus_shutdown() calls
5171 * configure.in: change configure.in XML stuff to also support
5174 * config-loader-libxml.c: some hacking
5176 * config-loader-expat.c: some hacking
5178 * config-parser.c: some hacking, plus tests
5180 2003-03-25 Havoc Pennington <hp@redhat.com>
5182 * throughout - add more _DBUS_ASSERT_ERROR_IS_CLEAR
5184 * configure.in: add --with-xml option to specify XML library,
5185 right now only libxml is supported.
5187 * bus/config-loader-libxml.c, config-parser.c: sync some minor
5188 nonworking code between home and work, still just stubs
5190 2003-03-24 Havoc Pennington <hp@redhat.com>
5192 * dbus/dbus-sysdeps.c (_dbus_set_fd_nonblocking): move to this
5195 * dbus/dbus-errors.c (dbus_set_error, dbus_set_error_const): allow
5196 NULL argument for "message" if the error is a well-known one,
5197 fill in a generic message in this case.
5199 * dbus/dbus-errors.h (DBusResultCode): Kill DBusResultCode in
5202 * bus/test.c (bus_test_flush_bus): add
5204 * bus/policy.c (bus_policy_test): test code stub
5206 2003-03-24 Havoc Pennington <hp@pobox.com>
5208 * bus/connection.c (bus_connections_setup_connection): set up
5209 the "can this user connect" function, but it always returns
5210 TRUE until we have a config file parser so we can have a config
5211 file that allows connections.
5213 2003-03-23 Havoc Pennington <hp@pobox.com>
5215 * dbus/dbus-threads.c (dbus_mutex_new, dbus_condvar_new): with
5216 DBUS_BUILD_TESTS, actually alloc/free a block of memory for
5217 the mutex, so we can check for proper memory management
5220 * dbus/dbus-dataslot.c: remove the mutex from
5221 DBusDataSlotAllocator and lock it manually when using it,
5222 to simplify fitting it into the global slots framework.
5224 * dbus/dbus-threads.c (init_static_locks): rework how we're
5225 handling global locks so they are easily shut down.
5227 * bus/policy.c (bus_policy_append_rule): fix
5229 * bus/test-main.c (main): check for memleaks
5231 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): make
5232 test suite check for memleaks
5234 * dbus/dbus-memory.c: add support in test mode for tracking
5235 number of outstanding blocks
5237 2003-03-23 Havoc Pennington <hp@pobox.com>
5239 * bus/policy.c, bus/bus.c, bus/connection.c: implement allow/deny
5242 * dbus/dbus-hash.h: add ULONG hash keys
5244 * dbus/dbus-sysdeps.c (_dbus_get_groups): new
5245 (_dbus_get_group_id): new function
5247 2003-03-20 Havoc Pennington <hp@redhat.com>
5249 * dbus/dbus-connection.c (dbus_connection_set_unix_user_function):
5251 (dbus_connection_get_unix_user): new function
5253 2003-03-20 Havoc Pennington <hp@pobox.com>
5255 * bus/connection.c (bus_connection_send_oom_error): assert that
5256 message has a sender
5257 (connection_execute_transaction): ditto
5258 (bus_connection_preallocate_oom_error): fix to set the sender, and
5259 set recipient to the destination service, not the bus driver
5261 * bus/policy.c: hacking
5263 * dbus/dbus-message.c (dbus_message_service_is): new function
5264 (dbus_message_sender_is): new
5266 2003-03-19 Havoc Pennington <hp@redhat.com>
5268 * bus/policy.c: start sketching code for policy restrictions on
5269 what connections can do.
5271 2003-03-18 Havoc Pennington <hp@redhat.com>
5273 * doc/TODO: some notes on high-level todo items. Little nitpick
5274 stuff is all in @todo, so no need to add it here.
5276 * doc/config-file.txt: some notes on how config file might look
5278 2003-03-18 Anders Carlsson <andersca@codefactory.se>
5284 2003-03-17 Havoc Pennington <hp@redhat.com>
5286 * dbus/dbus-internals.h: add gcc attributes so that
5287 our printf-style functions warn on bad arguments to
5290 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): fix printf
5293 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
5296 2003-03-17 Havoc Pennington <hp@redhat.com>
5298 * bus/test-main.c (main): make it print something as it runs
5299 so make check doesn't look stuck
5301 * doc/negotiation.txt, doc/dbus-sasl-profile.txt: remove
5302 from CVS, now obsolete
5304 2003-03-17 Anders Carlsson <andersca@codefactory.se>
5306 * bus/dispatch.c: (bus_dispatch):
5307 Refetch the service name since it may have been reallocated
5308 when dbus_message_set_sender was called.
5310 * dbus/dbus-sysdeps.c: (_dbus_accept):
5311 Add address and address length variables and use them to stop
5312 valgrind from complaining.
5314 2003-03-17 Havoc Pennington <hp@pobox.com>
5316 All tests pass, no memleaks, no valgrind complaints.
5318 * bus/test.c: refcount handler_slot
5320 * bus/connection.c (bus_connections_new): refcount
5321 connection_data_slot
5323 * dbus/dbus-auth-script.c (_dbus_auth_script_run): delete unused
5324 bytes so that auth scripts pass.
5326 * bus/dispatch.c: init message_handler_slot so it gets allocated
5329 * bus/dispatch.c (message_handler_slot_ref): fix memleak
5331 * dbus/dbus-server-debug-pipe.c (_dbus_server_debug_pipe_new):
5332 dealloc server_pipe_hash when no longer used for benefit of
5335 * dbus/dbus-auth.c (process_command): memleak fix
5337 * bus/dispatch.c (check_hello_message): memleak fix
5339 2003-03-16 Havoc Pennington <hp@pobox.com>
5341 * dbus/dbus-bus.c (ensure_bus_data): fix double-unref of the data slot
5343 2003-03-17 Anders Carlsson <andersca@codefactory.se>
5345 * bus/activation.c (bus_activation_activate_service): Append
5346 the pending activation entry to the list of pending activations.
5348 2003-03-16 Havoc Pennington <hp@pobox.com>
5350 * bus/dispatch.c (bus_dispatch_test): remove double-unrefs of
5353 * dbus/dbus-address.c (create_entry): fix OOM handling when
5354 failing to alloc entry->method
5356 2003-03-16 Havoc Pennington <hp@pobox.com>
5358 * dbus/dbus-watch.c (_dbus_watch_new): handle failure to malloc
5361 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
5362 add some missing dbus_set_result
5364 * bus/dispatch.c (bus_dispatch_add_connection): handle failure to
5365 alloc the DBusMessageHandler
5367 * dbus/dbus-transport.c (_dbus_transport_disconnect): don't ref
5368 the transport here, since we call this from the finalizer; it
5369 resulted in a double-finalize.
5371 * dbus/dbus-transport.c (_dbus_transport_disconnect): fix a bug
5372 where we tried to use transport->connection that was NULL,
5373 happened when transport was disconnected early on due to OOM
5375 * bus/*.c: adapt to handle OOM for watches/timeouts
5377 * dbus/dbus-transport-unix.c: port to handle OOM during
5380 * dbus/dbus-auth.c (_dbus_auth_get_unused_bytes): return a
5381 reference to unused bytes instead of a copy
5383 * dbus/dbus-server.c (dbus_server_handle_watch): return FALSE for
5386 * dbus/dbus-connection.c (dbus_connection_handle_watch): return
5389 * dbus/dbus-timeout.c (dbus_timeout_handle): return FALSE for out
5392 2003-03-16 Anders Carlsson <andersca@codefactory.se>
5394 * doc/dbus-specification.sgml:
5395 Document reply message for ActivateService.
5397 2003-03-16 Anders Carlsson <andersca@codefactory.se>
5399 * bus/activation.c: (bus_pending_activation_entry_free),
5400 (bus_pending_activation_free), (bus_activation_new),
5401 (bus_activation_unref), (bus_activation_service_created),
5402 (bus_activation_activate_service):
5404 * bus/bus.c: (bus_context_new):
5405 * bus/desktop-file.c: (new_section):
5406 * bus/driver.c: (bus_driver_send_service_deleted),
5407 (bus_driver_handle_activate_service):
5408 * bus/services.c: (bus_registry_new), (bus_registry_ensure):
5410 * dbus/dbus-connection.c:
5411 (dbus_connection_send_with_reply_and_block):
5412 * dbus/dbus-message.c: (dbus_message_append_args_valist):
5413 * dbus/dbus-protocol.h:
5414 Make activation work better. Now pending activations will be queued
5415 and the daemon won't try to activate services that are already registered.
5417 2003-03-16 Havoc Pennington <hp@pobox.com>
5419 * dbus/dbus-bus.c (ensure_bus_data): handle failure to set
5422 * dbus/dbus-memory.c (_dbus_initialize_malloc_debug): support
5423 DBUS_MALLOC_BACKTRACES to print trace when failing an alloc
5425 2003-03-16 Havoc Pennington <hp@pobox.com>
5427 * dbus/dbus-string.c (_dbus_string_validate_utf8): oops, unbreak
5428 this. always run the test suite before commit...
5430 * bus/*: adapt to DBusConnection API changes
5432 * glib/dbus-gmain.c: adapt to DBusConnection API changes,
5433 requires renaming stuff to avoid dbus_connection_dispatch name
5436 * dbus/dbus-transport.c (_dbus_transport_queue_messages): new
5439 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
5440 separate from _dbus_message_loader_return_buffer()
5442 * dbus/dbus-connection.c (dbus_connection_get_n_messages): remove
5443 this, because it's now always broken to use; the number of
5444 messages in queue vs. the number still buffered by the message
5445 loader is undefined/meaningless. Should use
5446 dbus_connection_get_dispatch_state().
5447 (dbus_connection_dispatch): rename from
5448 dbus_connection_dispatch_message
5450 2003-03-16 Havoc Pennington <hp@pobox.com>
5452 * dbus/dbus-string.c (_dbus_string_validate_utf8): copy in a real
5455 2003-03-16 Anders Carlsson <andersca@codefactory.se>
5457 * dbus/dbus-connection.c:
5458 (dbus_connection_send_with_reply_and_block):
5459 Decrease connection->n_incoming when removing an entry
5461 * dbus/dbus-dict.c: (dbus_dict_entry_free),
5462 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
5463 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
5464 (dbus_dict_set_byte_array), (dbus_dict_set_string_array),
5465 (dbus_dict_get_boolean_array), (dbus_dict_get_double_array),
5466 (dbus_dict_get_byte_array):
5467 Handle NULL arrays and strings. Also add support for byte arrays.
5469 * dbus/dbus-marshal.c: (_dbus_marshal_byte_array),
5470 (_dbus_marshal_dict), (_dbus_demarshal_byte_array),
5471 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
5472 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
5473 (_dbus_demarshal_dict), (demarshal_and_validate_len),
5474 (_dbus_marshal_validate_arg), (_dbus_marshal_test):
5475 * dbus/dbus-marshal.h:
5476 Add support for marshalling and demarshalling empty arrays and strings.
5478 * dbus/dbus-message.c: (dbus_message_append_args_valist),
5479 (dbus_message_append_string_array),
5480 (dbus_message_iter_get_boolean),
5481 (dbus_message_iter_get_boolean_array),
5482 (dbus_message_iter_get_int32_array),
5483 (dbus_message_iter_get_uint32_array),
5484 (dbus_message_iter_get_double_array),
5485 (dbus_message_iter_get_byte_array),
5486 (dbus_message_iter_get_string_array), (dbus_message_iter_get_dict),
5487 (check_message_handling):
5488 Add support for getting empty arrays and dicts.
5490 * dbus/dbus-string.c: (_dbus_string_validate_utf8):
5491 Don't do any validation at all for now, that's better than just checking
5494 * test/data/valid-messages/emptiness.message:
5495 New test message with lots of empty arrays.
5497 2003-03-16 Havoc Pennington <hp@pobox.com>
5499 * dbus/dbus-connection.c
5500 (_dbus_connection_queue_received_message_link): new function that
5501 can't fail due to OOM
5503 * dbus/dbus-message.c (_dbus_message_loader_pop_message_link):
5504 new function pops a message together with a list link
5507 * dbus/dbus-transport-unix.c (queue_messages): use new link-based
5508 message queuing functions to avoid needing to alloc memory
5510 2003-03-16 Havoc Pennington <hp@pobox.com>
5512 Oops - test code was only testing failure of around 30 of the
5513 mallocs in the test path, but it turns out there are 500+
5514 mallocs. I believe this was due to misguided linking setup such
5515 that there was one copy of dbus_malloc etc. in the daemon and one
5516 in the shared lib, and only daemon mallocs were tested. In any
5517 case, the test case now tests all 500+ mallocs, and doesn't pass
5518 yet, though there are lots of fixes in this patch.
5520 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
5521 this so that it doesn't need to allocate memory, since it
5522 has no way of indicating failure due to OOM (and would be
5523 annoying if it did).
5525 * dbus/dbus-list.c (_dbus_list_pop_first_link): new function
5527 * bus/Makefile.am: rearrange to create two self-contained
5528 libraries, to avoid having libraries with overlapping symbols.
5529 that was resulting in weirdness, e.g. I'm pretty sure there
5530 were two copies of global static variables.
5532 * dbus/dbus-internals.c: move the malloc debug stuff to
5535 * dbus/dbus-list.c (free_link): free list mempool if it becomes
5538 * dbus/dbus-memory.c (_dbus_disable_mem_pools): new function
5540 * dbus/dbus-address.c (dbus_parse_address): free list nodes
5543 * bus/dispatch.c (bus_dispatch_add_connection): free
5544 message_handler_slot when no longer using it, so
5545 memory leak checkers are happy for the test suite.
5547 * dbus/dbus-server-debug-pipe.c (debug_finalize): free server name
5549 * bus/bus.c (new_connection_callback): disconnect in here if
5550 bus_connections_setup_connection fails.
5552 * bus/connection.c (bus_connections_unref): fix to free the
5554 (bus_connections_setup_connection): if this fails, don't
5555 disconnect the connection, just be sure there are no side
5558 * dbus/dbus-string.c (undo_alignment): unbreak this
5560 * dbus/dbus-auth.c (_dbus_auth_unref): free some stuff we were
5562 (_dbus_auth_new): fix the order in which we free strings
5565 * bus/connection.c (bus_connection_disconnected): fix to
5566 not send ServiceDeleted multiple times in case of memory
5569 * dbus/dbus-bus.c (dbus_bus_get_base_service): new function to
5570 get the base service name
5571 (dbus_bus_register_client): don't return base service name,
5572 instead store it on the DBusConnection and have an accessor
5574 (dbus_bus_register_client): rename dbus_bus_register()
5576 * bus/dispatch.c (check_hello_message): verify that other
5577 connections on the bus also got the correct results, not
5578 just the one sending hello
5580 2003-03-15 Havoc Pennington <hp@pobox.com>
5582 Make it pass the Hello handling test including all OOM codepaths.
5583 Now to do other messages...
5585 * bus/services.c (bus_service_remove_owner): fix crash when
5586 removing owner from an empty list of owners
5587 (bus_registry_ensure): don't leave service in the list of
5588 a connection's owned services if we fail to put the service
5591 * bus/connection.c (bus_connection_preallocate_oom_error): set
5592 error flag on the OOM error.
5594 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
5595 handle _dbus_transport_set_connection failure
5597 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd): modify
5598 to create watches up front and simply enable/disable them as
5600 (unix_connection_set): this can now fail on OOM
5602 * dbus/dbus-timeout.c, dbus/dbus-watch.c: add concept
5603 of enabling/disabling a watch or timeout.
5605 * bus/loop.c (bus_loop_iterate): don't touch disabled
5608 * glib/dbus-gmain.c: adapt to enable/disable watches and timeouts
5610 2003-03-15 Havoc Pennington <hp@pobox.com>
5612 * bus/dispatch.c (bus_dispatch_test): OK, now finally actually
5613 write useful test code, after all that futzing around ;-)
5615 Test does not yet pass because we can't handle OOM in
5616 _dbus_transport_messages_pending (basically,
5617 dbus_connection_preallocate_send() does not prealloc the write
5618 watch). To fix this, I think we need to add new stuff to
5619 set_watch_functions, namely a SetEnabled function so we can alloc
5620 the watch earlier, then enable it later.
5622 * dbus/Makefile.am (libdbus_convenience_la_SOURCES): move
5623 dbus-memory.c to the convenience lib
5625 * bus/test.c: rename some static functions to keep them clearly
5626 distinct from stuff in connection.c. Handle client disconnection.
5628 2003-03-14 Havoc Pennington <hp@pobox.com>
5630 * bus/dispatch.c (bus_dispatch_test): do test using debug-pipe
5631 transport, tests more of the real codepath. Set up clients
5632 with bus_setup_debug_client.
5634 * bus/test.c (bus_setup_debug_client): function to set up debug
5635 "clients" on the main loop
5637 * dbus/dbus-transport.c (_dbus_transport_open): add debug-pipe
5640 * dbus/dbus-server.c (dbus_server_listen): add debug-pipe
5643 * dbus/dbus-server-debug.c: support a debug server based on pipes
5645 * dbus/dbus-sysdeps.c (_dbus_full_duplex_pipe): new function
5646 (_dbus_close): new function
5648 * configure.in: check for socketpair
5650 2003-03-14 Havoc Pennington <hp@redhat.com>
5652 * dbus/dbus-memory.c: add a "detect buffer overwrites on free"
5655 * dbus/dbus-transport-debug.c: rework this a good bit to be
5656 less complicated. hopefully still works.
5658 * dbus/dbus-server-debug.c (handle_new_client): remove timeout
5661 * glib/dbus-gmain.c (timeout_handler): don't remove timeout
5664 * dbus/dbus-message.c (dbus_message_copy): rename from
5665 dbus_message_new_from_message, fix it up to copy
5666 all the message fields, add test case
5668 * bus/dispatch.c (bus_dispatch_test): add some more test code,
5669 not quite passing yet
5671 2003-03-14 Havoc Pennington <hp@pobox.com>
5673 * bus/loop.c (bus_loop_iterate): add this so we can "run loop
5674 until no work remains" in test code. (the large diff here
5675 is just code movement, no actual changes)
5677 * dbus/dbus-server-debug.c (DEFAULT_INTERVAL): change interval to
5678 1, no point waiting around for test code.
5679 (_dbus_server_debug_accept_transport): unref the timeout
5680 after adding it (right?)
5682 * dbus/dbus-transport-debug.c (DEFAULT_INTERVAL): ditto
5684 2003-03-13 Havoc Pennington <hp@redhat.com>
5686 * dbus/dbus-timeout.c (_dbus_timeout_list_set_functions): handle
5689 * dbus/dbus-watch.c (_dbus_watch_list_set_functions): handle out
5692 * dbus/dbus-connection.h: Make AddWatchFunction and
5693 AddTimeoutFunction return a bool so they can fail on out-of-memory
5695 * bus/bus.c (bus_context_new): set up timeout handlers
5697 * bus/connection.c (bus_connections_setup_connection): set up
5700 * glib/dbus-gmain.c: adapt to the fact that set_functions stuff
5703 * bus/bus.c (bus_context_new): adapt to changes
5705 * bus/connection.c: adapt to changes
5707 * test/watch.c: adapt to DBusWatch changes
5709 * bus/dispatch.c (bus_dispatch_test): started adding this but
5712 2003-03-14 Anders Carlsson <andersca@codefactory.se>
5714 * bus/dispatch.c (send_service_nonexistent_error): Fix typo.
5716 2003-03-13 Havoc Pennington <hp@pobox.com>
5718 * bus/test.c, bus/test.h, bus/Makefile.am, bus/test-main.c:
5719 set up a test framework as for the library
5721 2003-03-12 Havoc Pennington <hp@pobox.com>
5723 Throughout: purge global variables, introduce BusActivation,
5724 BusConnections, BusRegistry, etc. objects instead.
5726 * bus/bus.h, bus/bus.c: introduce BusContext as a global
5729 * test/Makefile.am (TEST_BINARIES): disable bus-test for now,
5730 going to redo this a bit differently I think
5732 2003-03-12 Havoc Pennington <hp@redhat.com>
5734 Mega-patch that gets the message bus daemon initially handling
5735 out-of-memory. Work still needed. Also lots of random
5736 moving stuff to DBusError instead of ResultCode.
5738 * dbus/dbus-list.c (_dbus_list_length_is_one): new function
5740 * dbus/dbus-connection.c
5741 (dbus_connection_send_with_reply_and_block): use DBusError
5743 * dbus/dbus-bus.c: adapt to API changes, make it use DBusError not
5746 * dbus/dbus-connection.c (dbus_connection_send): drop the result
5747 code here, as the only failure possible is OOM.
5749 * bus/connection.c (bus_connection_disconnect):
5750 rename bus_connection_disconnected as it's a notification only
5752 * bus/driver.c (bus_driver_handle_acquire_service): don't free
5753 "name" on get_args failure, should be done by get_args;
5754 don't disconnect client for bad args, just return an error.
5755 (bus_driver_handle_service_exists): ditto
5757 * bus/services.c (bus_services_list): NULL-terminate returned array
5759 * bus/driver.c (bus_driver_send_service_lost)
5760 (bus_driver_send_service_acquired): send messages from driver to a
5761 specific client to the client's unique name, not to the broadcast
5764 * dbus/dbus-message.c (decode_header_data): reject messages that
5765 contain no name field
5766 (_dbus_message_get_client_serial): rename to
5767 dbus_message_get_serial and make public
5768 (_dbus_message_set_serial): rename from set_client_serial
5769 (_dbus_message_set_reply_serial): make public
5770 (_dbus_message_get_reply_serial): make public
5772 * bus/connection.c (bus_connection_foreach): allow stopping
5773 iteration by returning FALSE from foreach function.
5775 * dbus/dbus-connection.c (dbus_connection_send_preallocated)
5776 (dbus_connection_free_preallocated_send)
5777 (dbus_connection_preallocate_send): new API for sending a message
5778 without possibility of malloc failure.
5779 (dbus_connection_send_message): rename to just
5780 dbus_connection_send (and same for whole function family)
5782 * dbus/dbus-errors.c (dbus_error_free): make this reinit the error
5784 * dbus/dbus-sysdeps.c (_dbus_exit): new function
5786 * bus/activation.c: handle/return errors
5788 * dbus/dbus-errors.h: add more DBUS_ERROR #define
5790 * dbus/dbus-sysdeps.c (_dbus_directory_open) (_dbus_file_get_contents)
5791 (_dbus_directory_get_next_file): use DBusError instead of DBusResultCode
5792 (_dbus_result_from_errno): move to this file
5794 2003-03-10 Anders Carlsson <andersca@codefactory.se>
5796 * dbus/dbus-marshal.c:
5797 (_dbus_marshal_set_string):
5798 Take a length argument so we can marshal the correct string
5801 (_dbus_marshal_dict), (_dbus_demarshal_dict),
5802 (_dbus_marshal_get_arg_end_pos), (_dbus_marshal_validate_arg),
5803 (_dbus_marshal_test):
5804 * dbus/dbus-marshal.h:
5805 Add support for marshalling and demarshalling dicts.
5807 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
5808 Add support for TYPE DICT.
5810 * dbus/dbus-message.c: (set_string_field):
5811 Adjust header padding.
5813 (dbus_message_append_args_valist), (dbus_message_append_dict),
5814 (dbus_message_get_args_valist), (dbus_message_iter_get_arg_type),
5815 (dbus_message_iter_get_dict), (_dbus_message_loader_return_buffer),
5816 (check_message_handling), (check_have_valid_message):
5817 * dbus/dbus-message.h:
5818 Add functions for setting and getting dicts.
5820 * dbus/dbus-protocol.h:
5826 * doc/dbus-specification.sgml:
5827 Add information about how dicts are marshalled.
5829 * test/data/invalid-messages/dict-with-nil-value.message:
5830 * test/data/invalid-messages/too-short-dict.message:
5831 * test/data/valid-messages/dict-simple.message:
5832 * test/data/valid-messages/dict.message:
5833 Add sample messages containing dicts.
5835 2003-03-08 Anders Carlsson <andersca@codefactory.se>
5837 * dbus/dbus-dict.h: Add DBUS_END_DECLS.
5839 2003-03-07 Anders Carlsson <andersca@codefactory.se>
5842 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
5843 (dbus_dict_get_keys), (insert_entry), (dbus_dict_set_boolean),
5844 (dbus_dict_set_int32), (dbus_dict_set_uint32),
5845 (dbus_dict_set_double), (dbus_dict_set_string),
5846 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
5847 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
5848 (dbus_dict_set_string_array), (_dbus_dict_test):
5850 Fix according to comments from Havoc.
5852 2003-03-06 Michael Meeks <michael@server.home>
5854 * configure.in: if we don't have kde-config, disable have_qt.
5856 2003-03-07 Anders Carlsson <andersca@codefactory.se>
5861 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
5862 (dbus_dict_ref), (dbus_dict_unref), (dbus_dict_contains),
5863 (dbus_dict_remove), (dbus_dict_get_value_type),
5864 (dbus_dict_get_keys), (dbus_dict_put_boolean),
5865 (dbus_dict_put_int32), (dbus_dict_put_uint32),
5866 (dbus_dict_put_double), (dbus_dict_put_string),
5867 (dbus_dict_put_boolean_array), (dbus_dict_put_int32_array),
5868 (dbus_dict_put_uint32_array), (dbus_dict_put_double_array),
5869 (dbus_dict_put_string_array), (dbus_dict_get_boolean),
5870 (dbus_dict_get_int32), (dbus_dict_get_uint32),
5871 (dbus_dict_get_double), (dbus_dict_get_string),
5872 (dbus_dict_get_boolean_array), (dbus_dict_get_int32_array),
5873 (dbus_dict_get_uint32_array), (dbus_dict_get_double_array),
5874 (dbus_dict_get_string_array), (_dbus_dict_test):
5876 Add DBusDict implementation
5878 * dbus/dbus-test.c: (dbus_internal_do_not_use_run_tests):
5882 2003-03-04 Havoc Pennington <hp@pobox.com>
5884 * test/data/auth/*: adapt to changes
5886 * dbus/dbus-auth-script.c (_dbus_auth_script_run): add
5887 USERID_BASE64 and change USERNAME_BASE64 to put in username not
5890 * dbus/dbus-keyring.c (_dbus_keyring_validate_context): prevent
5891 more stuff from being in a context name, to make the protocol
5892 simpler to deal with
5894 * dbus/dbus-errors.c (dbus_error_has_name): new function
5895 (dbus_error_is_set): new function
5897 * dbus/dbus-auth.c: replace DBUS_STUPID_TEST_MECH auth
5898 with DBUS_COOKIE_SHA1, implement DBUS_COOKIE_SHA1
5900 * dbus/dbus-connection.c (dbus_connection_flush): also read
5901 messages during a flush operation
5903 * dbus/Makefile.am: remove dbus-md5 since it isn't currently used.
5905 2003-03-05 Anders Carlsson <andersca@codefactory.se>
5907 * configure.in: Check for gethostbyname on Solaris.
5909 * dbus/dbus-transport.c: (_dbus_transport_open):
5910 Remove duplicate "tcp" entry.
5912 * doc/dbus-specification.sgml:
5913 Clarify some things.
5915 2003-03-05 Anders Carlsson <andersca@codefactory.se>
5917 * dbus/dbus-auth.c: (send_rejected), (process_test_subdir):
5918 * dbus/dbus-keyring.c: (_dbus_keyring_new_homedir),
5919 (_dbus_keyring_test):
5920 * dbus/dbus-md5.c: (_dbus_md5_compute):
5921 * dbus/dbus-sha.c: (_dbus_sha_compute):
5924 2003-03-05 Anders Carlsson <andersca@codefactory.se>
5926 * README: Add some things.
5928 2003-03-04 Anders Carlsson <andersca@codefactory.se>
5930 * dbus/dbus-message.c (dbus_message_append_args_valist): Add a break;
5931 after case DBUS_TYPE_BOOELAN.
5933 2003-03-02 Havoc Pennington <hp@pobox.com>
5935 * test/break-loader.c (randomly_set_extreme_ints): add test that
5936 sets really huge and small integers
5938 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add check
5939 that length of boolean array fits in the string, and that
5940 string has room for boolean value in single-bool case.
5942 * dbus/dbus-message-builder.c (_dbus_message_data_load): add
5943 optional value to "ALIGN" command which is what to fill the
5946 * test/data/valid-messages/no-padding.message: add regression
5947 test for the message padding problem
5949 2003-03-02 Havoc Pennington <hp@pobox.com>
5951 * dbus/dbus-message.c (decode_header_data): fix to always init
5952 message_padding, from Benjamin Dauvergne
5954 2003-03-02 Havoc Pennington <hp@pobox.com>
5960 2003-03-01 Joe Shaw <joe@assbarn.com>
5962 * configure.in: Check for "struct cmsgcred" and try to access its
5963 members for BSD-like unices.
5965 * dbus/dbus-sysdeps.c (read_credentials_byte): Fold this back into
5966 _dbus_read_credentials_unix_socket().
5967 (_dbus_read_credentials_unix_socket): Use recvmsg() instead of
5968 read() for reading the credential byte off the unix socket. Use
5969 struct cmsgcred on systems that support it.
5971 2003-02-27 Alexander Larsson <alexl@redhat.com>
5975 Make gthreads-2.0 dependency optional. Don't build thread test if
5978 2003-02-27 Havoc Pennington <hp@pobox.com>
5980 * dbus/dbus-connection.c
5981 (dbus_connection_send_message_with_reply_and_block): fix doh!
5982 doh! doh! bug that resulted in never removing a reply from the
5983 queue, no wonder we called get_reply_serial so much ;-)
5985 * dbus/dbus-message.c (struct DBusMessage): cache reply serial
5986 and client serial instead of demarshaling them every time
5988 2003-02-27 Havoc Pennington <hp@pobox.com>
5990 * dbus/dbus-marshal.c (_dbus_demarshal_int32): rewrite to be much
5991 more inlined, using dbus-string-private.h, speeds things up
5994 * dbus/dbus-string.c (_dbus_string_free): apply align offset
5995 when freeing the string
5996 (_dbus_string_steal_data): fix for align offset
5997 (undo_alignment): new function
5999 2003-02-26 Havoc Pennington <hp@redhat.com>
6001 All kinds of audit fixes from Owen, plus initial attempt to
6002 handle unaligned memory returned from malloc.
6004 * dbus/dbus-string.c (_dbus_string_init): clamp max length to
6005 leave room for align_offset and nul byte
6006 (fixup_alignment): function to track an align_offset and
6007 ensure real->str is aligned
6008 (DBUS_GENERIC_STRING_PREAMBLE): len must be less than allocated,
6009 to allow a nul byte plus align offset
6010 (_dbus_string_lock): fix overflow issue
6011 (_dbus_string_init_const_len): add assertions on sanity of len,
6012 assign allocated to be ALLOCATION_PADDING larger than len
6013 (set_length): fixup the overflow handling
6014 (_dbus_string_get_data_len): fix overflow in assertion
6015 (open_gap): detect overflow in size of gap to be opened
6016 (_dbus_string_lengthen): add overflow check
6017 (_dbus_string_align_length): fix overflow with _DBUS_ALIGN_VALUE
6018 (_dbus_string_append): add overflow check
6019 (_dbus_string_append_unichar): overflow
6020 (_dbus_string_delete): fix overflow in assertion
6021 (_dbus_string_copy_len): overflow in assertion
6022 (_dbus_string_replace_len): overflows in assertions
6023 (_dbus_string_find): change to implement in terms of
6024 _dbus_string_find_to
6025 (_dbus_string_find_to): assorted fixage
6026 (_dbus_string_equal_c_str): assert c_str != NULL,
6027 fix logic so the function works
6028 (_dbus_string_ends_with_c_str): fix overflow thingy
6029 (_dbus_string_base64_encode): overflow fix
6030 (_dbus_string_validate_ascii): overflow
6031 (_dbus_string_validate_nul): overflow
6033 2003-02-26 Havoc Pennington <hp@redhat.com>
6035 * dbus/dbus-marshal.c (_dbus_marshal_test): fix to work with DISABLE_ASSERTS
6037 2003-02-26 Alexander Larsson <alexl@redhat.com>
6040 Set DBUS_GLIB_THREADS_LIBS for apps using gthread-2.0
6042 * dbus/dbus-connection.c:
6043 * dbus/dbus-connection.h:
6044 Fix _dbus_connection_acquire_io_path and _dbus_connection_acquire_dispatch.
6045 Add dbus_connection_set_wakeup_main_function and use it when queueing
6046 incoming and outgoing messages.
6049 * dbus/dbus-dataslot.c:
6050 Threadsafe usage of DBusDataSlotAllocator
6052 * dbus/dbus-message.c: (dbus_message_get_args_iter):
6055 * dbus/dbus-server-unix.c:
6058 * glib/dbus-gmain.c:
6059 Implement the new wakeup functions for glib.
6062 * glib/test-thread-client.c:
6063 * glib/test-thread-server.c:
6064 * glib/test-thread.h:
6065 Initial cut at some thread test code. Not really done yet.
6067 2003-02-26 Havoc Pennington <hp@pobox.com>
6069 * dbus/dbus-connection.c
6070 (dbus_connection_send_message_with_reply_and_block): fix crash
6071 where we ref'd the outgoing message instead of the returned reply
6073 * dbus/dbus-transport-unix.c (do_authentication): check read watch
6074 at the end of this function, so if we didn't need to read for
6075 authentication, we reinstall it for receiving messages
6077 * dbus/dbus-message.c (dbus_message_new_reply): allow replies to
6078 a NULL sender for peer-to-peer case
6080 * dbus/dbus-transport-unix.c (check_read_watch): handle
6081 !authenticated case correctly
6083 * glib/dbus-gmain.c: add support for DBusServer
6085 * dbus/dbus-server.c: add data slot support
6087 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): check
6088 return values and handle errors
6090 * dbus/dbus-dataslot.c: factor out the data slot stuff from
6093 * Doxyfile.in (INPUT): add glib subdir
6095 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): rename
6096 setup_with_g_main instead of hookup_with_g_main; write docs
6098 2003-02-24 Anders Carlsson <andersca@codefactory.se>
6100 * dbus/dbus-marshal.c: (_dbus_marshal_validate_arg):
6101 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
6102 * dbus/dbus-message.c: (dbus_message_append_boolean),
6103 (dbus_message_append_boolean_array),
6104 (dbus_message_get_args_valist), (_dbus_message_test):
6105 * dbus/dbus-message.h:
6106 * doc/dbus-specification.sgml:
6107 Various fixes as pointed out by Havoc.
6109 * test/data/invalid-messages/bad-boolean-array.message:
6110 * test/data/invalid-messages/bad-boolean.message:
6111 Add invalid boolean value test cases.
6113 2003-02-24 Anders Carlsson <andersca@codefactory.se>
6115 * dbus/dbus-internals.c: (_dbus_type_to_string):
6116 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
6117 (_dbus_marshal_validate_arg):
6118 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
6119 * dbus/dbus-message.c: (dbus_message_append_args_valist),
6120 (dbus_message_append_boolean), (dbus_message_append_boolean_array),
6121 (dbus_message_get_args_valist), (dbus_message_iter_get_boolean),
6122 (dbus_message_iter_get_int32), (dbus_message_iter_get_uint32),
6123 (dbus_message_iter_get_double),
6124 (dbus_message_iter_get_boolean_array), (message_iter_test):
6125 * dbus/dbus-message.h:
6126 * dbus/dbus-protocol.h:
6127 * doc/dbus-specification.sgml:
6128 * test/data/valid-messages/lots-of-arguments.message:
6129 Add support for boolean and boolean array types.
6131 2003-02-23 Havoc Pennington <hp@pobox.com>
6133 * dbus/dbus-keyring.c: finish most of this implementation and
6136 * dbus/dbus-errors.c (dbus_set_error_const, dbus_set_error): make
6137 these barf if the error isn't cleared to NULL
6139 * dbus/dbus-sysdeps.c (_dbus_delete_file): set error on failure
6140 (_dbus_create_directory): new function
6142 * dbus/dbus-errors.c (dbus_set_error): fix warning
6144 * dbus/dbus-string.c (_dbus_string_hex_encode): new function
6145 (_dbus_string_hex_decode): new function
6146 (test_hex_roundtrip): test code
6148 * dbus/dbus-sha.c (_dbus_sha_compute): use dbus_string_hex_encode
6150 * dbus/dbus-md5.c (_dbus_md5_compute): use dbus_string_hex_encode
6152 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): make this use
6153 the save-to-temp/rename trick to atomically write the new file
6154 (_dbus_string_parse_uint): new function
6156 2003-02-22 Havoc Pennington <hp@pobox.com>
6158 * test/Makefile.am (dist-hook): fix dist for test/data/sha-1
6160 2003-02-22 Havoc Pennington <hp@pobox.com>
6162 * dbus/dbus-message.c (dbus_message_iter_get_string_array):
6163 (dbus_message_iter_get_byte_array): Fix up doxygen warnings
6165 * dbus/dbus-sha.c: add implementation of SHA-1 algorithm
6167 * dbus/test/data/sha-1: add US government test suite for SHA-1
6169 2003-02-21 Anders Carlsson <andersca@codefactory.se>
6171 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
6172 Make string arrays NULL-terminated.
6174 * dbus/dbus-memory.c: (dbus_free_string_array):
6175 * dbus/dbus-memory.h:
6176 New function for freeing NULL-terminated string arrays.
6178 * dbus/dbus-message-builder.c: (append_quoted_string),
6179 (_dbus_message_data_load):
6180 Add support for array types.
6182 * dbus/dbus-message.c: (check_message_handling):
6183 Add more types as test cases.
6185 * dbus/dbus-sysdeps.c: (_dbus_string_parse_int),
6186 (_dbus_string_parse_double):
6187 Add the start offset to the end offset.
6189 * test/data/valid-messages/lots-of-arguments.message:
6190 New test message with lots of arguments.
6192 2003-02-21 Anders Carlsson <andersca@codefactory.se>
6194 * dbus/dbus-message.c: (dbus_message_append_nil),
6195 (dbus_message_append_int32), (dbus_message_append_uint32),
6196 (dbus_message_append_double), (dbus_message_append_string),
6197 (dbus_message_append_int32_array),
6198 (dbus_message_append_uint32_array),
6199 (dbus_message_append_double_array),
6200 (dbus_message_append_byte_array),
6201 (dbus_message_append_string_array):
6202 Fix all out-of-memory handling in these functions.
6204 2003-02-21 Anders Carlsson <andersca@codefactory.se>
6206 * dbus/dbus-message.c: (dbus_message_append_nil):
6209 2003-02-21 Anders Carlsson <andersca@codefactory.se>
6211 * dbus/dbus-message.c: (dbus_message_append_args_valist),
6212 (dbus_message_append_nil), (dbus_message_append_int32_array),
6213 (dbus_message_append_uint32_array),
6214 (dbus_message_append_double_array),
6215 (dbus_message_append_byte_array),
6216 (dbus_message_append_string_array), (dbus_message_get_args_valist),
6217 (dbus_message_iter_get_int32_array),
6218 (dbus_message_iter_get_uint32_array),
6219 (dbus_message_iter_get_double_array),
6220 (dbus_message_iter_get_byte_array),
6221 (dbus_message_iter_get_string_array):
6223 * dbus/dbus-message.h:
6224 Add functions for appending and getting arrays.
6226 2003-02-21 Anders Carlsson <andersca@codefactory.se>
6228 * dbus/dbus-mempool.c (_dbus_mem_pool_new): Make the
6229 element size at least 8 bytes, fixes mempool tests on
6232 2003-02-20 Alexander Larsson <alexl@redhat.com>
6234 * dbus/dbus-transport-unix.c (unix_do_iteration):
6235 Unlock the connection mutex during a blocking select call.
6236 Add todo about how we need a way to wake up the select.
6238 * dbus/dbus-connection-internal.h:
6239 * dbus/dbus-connection.c:
6240 Add _dbus_connection_lock and _dbus_connection_unlock.
6242 2003-02-19 Havoc Pennington <hp@pobox.com>
6244 * Doxyfile.in (PREDEFINED): put DOXYGEN_SHOULD_SKIP_THIS in
6245 Doxyfile.in, not Doxyfile
6247 * dbus/dbus-keyring.c: do some hacking on this
6249 * dbus/dbus-sysdeps.c (_dbus_delete_file): new
6251 * dbus/dbus-errors.c (dbus_set_error_const): do not call
6253 (dbus_set_error): remove dbus_error_init, check for message ==
6254 NULL *before* we sprintf into it, and add @todo about including
6255 system headers in this file
6257 * dbus/dbus-sysdeps.c (_dbus_create_file_exclusively): new
6259 * dbus/dbus-errors.h (DBUS_ERROR_FAILED): add
6261 * dbus/dbus-sysdeps.c (get_user_info): break this function out to
6262 get various bits of user information based on either username
6264 (_dbus_homedir_from_username): new function
6266 2003-02-19 Anders Carlsson <andersca@codefactory.se>
6269 Add check for nonposix getpwnam_r
6271 * dbus/dbus-mempool.c: (_dbus_mem_pool_new):
6272 Align the pool element size to a sizeof (void *) boundary.
6274 * dbus/dbus-sysdeps.c: (_dbus_setenv), (_dbus_connect_unix_socket),
6275 (_dbus_listen_unix_socket), (_dbus_credentials_from_username):
6276 General Solaris fixes.
6278 * test/data/valid-messages/simplest-manual.message:
6279 Explicitly state that we want little-endian packing.
6281 2003-02-19 Mikael Hallendal <micke@codefactory.se>
6283 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
6285 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_tcp_socket):
6286 Added to create a transport connecting using a tcp/ip socket.
6288 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): Added to connect
6289 to a tcp socket at given host and port.
6290 (_dbus_listen_tcp_socket): added to listen on tcp socket for given
6293 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
6295 * dbus/dbus-server-unix.c (_dbus_server_new_for_tcp_socket):
6296 Added to create a server listening on a TCP/IP socket.
6298 2003-02-19 Havoc Pennington <hp@pobox.com>
6300 Throughout: mop up all the Doxygen warnings and undocumented
6303 * dbus/dbus-sysdeps.c (do_exec): do not use execvp, we don't want
6304 to search any paths.
6306 * dbus/dbus-threads.c: move global mutex initializers to
6307 dbus-internals.h, multiple prototypes was confusing doxygen
6308 besides being kind of ugly
6310 * Doxyfile (PREDEFINED): have Doxygen define
6311 DOXYGEN_SHOULD_SKIP_THIS so we can exclude things from
6312 docs with #ifndef DOXYGEN_SHOULD_SKIP_THIS
6313 (do not abuse the feature! it's for stuff like the autogenerated
6314 macros in dbus-md5.c, not just for things you don't feel like
6317 2003-02-18 Havoc Pennington <hp@pobox.com>
6319 * dbus/dbus-string.c (_dbus_string_zero): new function
6321 * dbus/dbus-md5.c: include MD5 implementation by L. Peter Deutsch,
6322 wrap it in some dbus-friendly API
6324 * dbus/dbus-types.h: add 16-bit types
6326 2003-02-18 Joe Shaw <joe@assbarn.com>
6328 * dbus/dbus-auth.c (handle_server_data_stupid_test_mech): Just get
6329 credentials from our currently running process.
6330 (get_word): Fix a buglet where we were copying the entire length
6331 instead of relative to our position.
6333 * dbus/dbus-hash.c (_dbus_hash_test): Don't try to allocate the
6334 keys on the stack... it's 640k of data.
6336 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): Always
6337 read the credentials byte off the socket, even if we don't have
6339 (_dbus_poll): Implement poll() using select() for systems which
6342 * glib/test-dbus-glib.c (main): Print out an error if no
6343 parameters are given.
6345 * test/data/auth/fallback.auth-script: Added. Tests that a client
6346 can fallback to a secondary auth mechanism if the first fails.
6348 2003-02-18 Havoc Pennington <hp@pobox.com>
6352 2003-02-17 Havoc Pennington <hp@pobox.com>
6354 * doc/dbus-specification.sgml: lots of cosmetic
6355 cleanups/rearrangement, add assorted FIXME, change DBUS_ADDRESS
6356 env variable to DBUS_BUS_ADDRESS, s/client/application/,
6357 s/server/bus/ (except in authentication section). Add a section
6358 "Message Bus Message Routing"
6360 2003-02-17 Anders Carlsson <andersca@codefactory.se.>
6366 2003-02-17 Anders Carlsson <andersca@codefactory.se>
6368 * doc/dbus-specification.sgml:
6369 Specification updates.
6371 2003-02-17 Anders Carlsson <andersca@codefactory.se>
6373 * bus/activation.c: (bus_activation_init), (child_setup),
6374 (bus_activation_activate_service):
6376 * bus/main.c: (main):
6377 Set DBUS_ADDRESS environment variable.
6379 * dbus/dbus-errors.c: (dbus_set_error):
6380 Don't use va_copy since that's a C99 feature.
6382 * dbus/dbus-sysdeps.c: (_dbus_setenv), (do_exec),
6383 (_dbus_spawn_async):
6384 * dbus/dbus-sysdeps.h:
6385 Add child_setup_func to _dbus_spawn_async.
6387 * doc/dbus-specification.sgml:
6388 Update specification.
6390 * test/spawn-test.c: (setup_func), (main):
6393 2003-02-17 Alexander Larsson <alexl@redhat.com>
6395 * dbus/dbus-connection.c (_dbus_connection_handler_destroyed_locked):
6398 2003-02-17 Anders Carlsson <andersca@codefactory.se>
6402 * doc/dbus-test-plan.sgml:
6403 Add test plan document.
6408 2003-02-17 Anders Carlsson <andersca@codefactory.se>
6410 * dbus/dbus-message.c: (decode_header_data),
6411 (_dbus_message_loader_return_buffer):
6412 Set the header padding amount when loading a message.
6414 2003-02-16 Anders Carlsson <andersca@codefactory.se>
6416 * bus/dispatch.c: (send_one_message):
6417 Only send broadcast messages to registered connections.
6419 * dbus/dbus-message.c: (dbus_message_name_is):
6420 * dbus/dbus-message.h:
6421 New convenience function.
6423 * dbus/dbus-transport-debug.c: (do_reading):
6424 Only dispatch one message per run.
6427 * test/bus-test.c: (new_connection_callback), (die),
6428 (test_hello_client1_handler), (test_hello_client2_handler),
6429 (test_hello_replies), (main):
6431 * test/bus-test-loop.[ch]:
6434 2003-02-16 Havoc Pennington <hp@pobox.com>
6436 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
6437 backward conditional
6439 2003-02-16 Alexander Larsson <alexl@redhat.com>
6441 * dbus/dbus-connection.c:
6442 Implement sent_message_with_reply. (with_reply_and block is still
6444 Made dispatch_message not lose message if OOM.
6446 * dbus/dbus-errors.h:
6447 Add NoReply error (for reply timeouts).
6449 2003-02-16 Alexander Larsson <alexl@redhat.com>
6451 * dbus/dbus-hash.c (_dbus_hash_table_unref):
6452 Actually free keys and values when destroying hashtable.
6454 2003-02-16 Anders Carlsson <andersca@codefactory.se>
6456 * dbus/dbus-auth.c: (client_try_next_mechanism):
6459 * dbus/dbus-threads.c: (dbus_condvar_wait_timeout):
6460 Return TRUE if there's no thread implementation around.
6462 * glib/dbus-gmain.c: (free_source),
6463 (dbus_connection_hookup_with_g_main):
6464 Make sure to remove the GSource when the connection is finalized.
6466 2003-02-16 Anders Carlsson <andersca@codefactory.se>
6468 * bus/dispatch.c: (bus_dispatch_message_handler):
6469 * dbus/dbus-errors.h:
6470 Return an error if someone tries to send a message to a service
6473 2003-02-16 Anders Carlsson <andersca@codefactory.se>
6475 * bus/activation.c: (load_directory), (bus_activation_init),
6476 (bus_activation_activate_service):
6479 (bus_driver_handle_activate_service), (bus_driver_handle_message):
6480 More work on the activation handling.
6482 * dbus/dbus-errors.h:
6483 Add some error messages
6485 * dbus/dbus-message.c: (dbus_message_new_error_reply):
6486 * dbus/dbus-message.h:
6487 New function that creates an error message.
6489 * dbus/dbus-protocol.h:
6490 Add ACTIVATE_SERVER message.
6492 * dbus/dbus-server-unix.c: (unix_handle_watch),
6493 (_dbus_server_new_for_domain_socket):
6494 Call _dbus_fd_set_close_on_exec.
6496 * dbus/dbus-sysdeps.c: (make_pipe), (do_exec),
6497 (_dbus_spawn_async), (_dbus_disable_sigpipe),
6498 (_dbus_fd_set_close_on_exec):
6499 * dbus/dbus-sysdeps.h:
6500 Add _dbus_fd_set_close_on exec function. Also add function that checks
6501 that all open fds are set to close-on-exec and warns otherwise.
6503 * dbus/dbus-transport-unix.c:
6504 (_dbus_transport_new_for_domain_socket):
6505 Call _dbus_fd_set_close_on_exec.
6507 2003-02-16 Havoc Pennington <hp@pobox.com>
6509 * dbus/dbus-connection.c (dbus_connection_set_change_sigpipe):
6510 allow people to avoid setting SIGPIPE to SIG_IGN
6511 (_dbus_connection_new_for_transport): disable SIGPIPE unless
6512 we've been asked not to
6514 2003-02-15 Anders Carlsson <andersca@codefactory.se>
6516 * dbus/dbus-list.c: (_dbus_list_append_link),
6517 (_dbus_list_prepend_link):
6518 * dbus/dbus-memory.c: (dbus_malloc), (dbus_malloc0),
6522 2003-02-15 Anders Carlsson <andersca@codefactory.se>
6525 * bus/activation.c: (bus_activation_entry_free),
6526 (add_desktop_file_entry), (load_directory), (bus_activation_init):
6528 * bus/main.c: (main):
6529 Add simple activation support, doesn't work yet though.
6531 2003-02-15 Zack Rusin <zack@kde.org>
6533 * qt/dbus-qthread.cpp: small casting fix
6535 2003-02-15 Anders Carlsson <andersca@codefactory.se>
6537 * dbus/dbus-errors.c: (dbus_set_error):
6538 * dbus/dbus-errors.h:
6539 Add a few errors and make dbus_set_error void.
6541 * dbus/dbus-sysdeps.c:
6542 (_dbus_errno_to_string), (close_and_invalidate), (make_pipe),
6543 (write_err_and_exit), (read_ints), (do_exec), (_dbus_spawn_async):
6544 * dbus/dbus-sysdeps.h:
6545 Add _dbus_spawn_async.
6547 * test/spawn-test.c: (main):
6548 Test for _dbus_spawn_async.
6550 2003-02-15 Anders Carlsson <andersca@codefactory.se>
6552 * dbus/dbus-internals.h:
6553 Fix build without tests.
6555 * dbus/dbus-list.c: (alloc_link):
6556 Fix a segfault when a malloc fails.
6558 * dbus/dbus-memory.c: (initialize_malloc_debug), (dbus_malloc),
6559 (dbus_malloc0), (dbus_realloc):
6560 Add support for malloc debugging.
6562 2003-02-15 Alexander Larsson <alexl@redhat.com>
6564 * dbus/dbus-threads.c:
6565 * dbus/dbus-threads.h:
6566 Add condvars. Remove static mutext from API.
6567 Implement static mutexes by initializing them from threads_init.
6569 * glib/dbus-gthread.c:
6570 * qt/dbus-qthread.cpp:
6571 Update with the thread api changes.
6576 Turn StaticMutex into normal mutex + init function.
6577 Export new functions _dbus_list_alloc_link, _dbus_list_free_link,
6578 _dbus_list_append_link, _dbus_list_prepend_link
6581 * dbus/dbus-sysdeps.c:
6582 * dbus/dbus-sysdeps.h:
6583 New type dbus_atomic_t, and new functions _dbus_atomic_inc,
6584 _dbus_atomic_dec. Only slow fallback implementation at the moment.
6586 * dbus/dbus-protocol.h:
6587 Add DBUS_MESSAGE_LOCAL_DISCONNECT define
6589 * dbus/dbus-message.c:
6590 Make ref/unref atomic.
6593 * dbus/dbus-connection-internal.h:
6594 * dbus/dbus-connection.c:
6595 * dbus/dbus-connection.h:
6597 Change _peek to _borrow,_return & _steal_borrowed.
6598 Change disconnect callback to event.
6599 Make dbus_connection_dispatch_messages reentrant.
6601 * dbus/dbus-transport.c:
6602 Don't ref the connection on calls to the transport
6605 * dbus/dbus-message-handler.c:
6608 * glib/dbus-gmain.c:
6609 Don't use peek_message anymore
6612 * test/debug-thread.c:
6613 * test/debug-thread.h:
6614 Simple thread implementation that asserts() on deadlocks in
6615 single-threaded code.
6618 (main) Call debug_threads_init.
6621 Use disconnect message instead of disconnect callback.
6625 Don't call dbus_connection_set_disconnect_function. Instead export
6626 bus_connection_disconnect.
6629 Call bus_connection_disconnect when we get a disconnected message.
6631 2003-02-15 Havoc Pennington <hp@pobox.com>
6633 * dbus/dbus-message.c (dbus_message_new): fool around with the
6636 2003-02-14 Havoc Pennington <hp@pobox.com>
6638 * dbus/dbus-mempool.c: fail if the debug functions so indicate
6640 * dbus/dbus-memory.c: fail if the debug functions indicate we
6643 * dbus/dbus-internals.c (_dbus_set_fail_alloc_counter)
6644 (_dbus_decrement_fail_alloc_counter): debug functions to
6645 simulate memory allocation failures
6647 2003-02-14 Havoc Pennington <hp@pobox.com>
6649 * dbus/dbus-errors.h (struct DBusError): add a word of padding
6652 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6654 * bus/driver.c: (bus_driver_handle_hello):
6656 * bus/services.c: (bus_service_lookup):
6657 Reorder message sending so we get a more sane order.
6659 * test/bus-test.c: (message_handler):
6662 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6664 * bus/driver.c: (bus_driver_send_service_deleted),
6665 (bus_driver_send_service_created), (bus_driver_send_service_lost),
6666 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
6667 (bus_driver_send_welcome_message),
6668 (bus_driver_handle_list_services),
6669 (bus_driver_handle_acquire_service),
6670 (bus_driver_handle_service_exists):
6671 * dbus/dbus-bus.c: (dbus_bus_register_client),
6672 (dbus_bus_acquire_service), (dbus_bus_service_exists):
6673 * dbus/dbus-errors.c: (dbus_result_to_string):
6674 * dbus/dbus-errors.h:
6675 * dbus/dbus-message.c: (dbus_message_append_args),
6676 (dbus_message_append_args_valist), (dbus_message_get_args),
6677 (dbus_message_get_args_valist), (dbus_message_get_args_iter),
6678 (dbus_message_iter_get_arg_type), (dbus_message_iter_get_string),
6679 (dbus_message_iter_get_byte_array),
6680 (dbus_message_iter_get_string_array), (message_iter_test),
6681 (check_message_handling), (_dbus_message_test):
6682 * dbus/dbus-message.h:
6683 * test/bus-test.c: (main):
6684 Change fields to arguments in messages, so that they won't be
6685 confused with header fields.
6687 * glib/test-dbus-glib.c: (main):
6688 Remove append_fields from hello message.
6690 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6692 * dbus/dbus-errors.c:
6693 * dbus/dbus-message.c:
6694 * dbus/dbus-string.c:
6695 Documentation fixes.
6697 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6699 * glib/dbus-gmain.c: (timeout_handler), (add_timeout),
6701 Implement support for timeouts in dbus-glib.
6703 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6705 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
6706 * dbus/dbus-message.c: (process_test_subdir):
6707 * test/break-loader.c: (find_breaks_based_on):
6708 Plug some memory leaks.
6710 2003-02-13 Richard Hult <rhult@codefactory.se>
6712 * bus/main.c: Fix build.
6714 * dbus/dbus-errors.h:
6715 * dbus/dbus-errors.c: Fix copyright for Anders.
6717 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6722 * bus/connection.c: (bus_connection_foreach):
6725 * bus/desktop-file.c: (grow_lines_in_section), (grow_sections),
6726 (unescape_string), (new_section), (parse_section_start),
6727 (parse_key_value), (report_error), (bus_desktop_file_load),
6728 (bus_desktop_file_get_string):
6729 * bus/desktop-file.h:
6730 Use DBusError for error reporting.
6732 * bus/dispatch.c: (send_one_message),
6733 (bus_dispatch_message_handler):
6734 * bus/driver.c: (bus_driver_send_service_deleted),
6735 (bus_driver_send_service_created), (bus_driver_send_service_lost),
6736 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
6737 (bus_driver_send_welcome_message),
6738 (bus_driver_handle_list_services),
6739 (bus_driver_handle_acquire_service),
6740 (bus_driver_handle_service_exists):
6741 * bus/loop.c: (bus_loop_run):
6743 Use BUS_HANDLE_OOM instead of _DBUS_HANDLE_OOM.
6745 * bus/utils.c: (bus_wait_for_memory):
6747 New files with general utility functions.
6749 * dbus/dbus-internals.h:
6750 Remove _DBUS_HANDLE_OOM.
6752 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6754 * dbus/dbus-errors.c: (dbus_result_to_string), (dbus_error_init),
6755 (dbus_error_free), (dbus_set_error_const), (dbus_set_error):
6756 * dbus/dbus-errors.h:
6757 Add DBusError structure.
6759 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6761 * test/data/valid-messages/standard-acquire-service.message:
6762 * test/data/valid-messages/standard-hello.message:
6763 * test/data/valid-messages/standard-list-services.message:
6764 * test/data/valid-messages/standard-service-exists.message:
6765 Add some standard messages.
6767 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6769 * bus/driver.c: (bus_driver_send_welcome_message),
6770 (bus_driver_handle_list_services),
6771 (bus_driver_handle_acquire_service),
6772 (bus_driver_handle_service_exists), (bus_driver_handle_message):
6773 Update for API changes in libdbus.
6775 * dbus/dbus-message.c: (dbus_message_new_reply):
6776 * dbus/dbus-message.h:
6777 Remove the name argument. The spec states that replies shouldn't
6780 2003-02-13 Anders Carlsson <andersca@codefactory.se>
6782 * bus/desktop-file.c: (parse_section_start), (parse_key_value),
6783 (report_error), (bus_desktop_file_load), (lookup_section),
6784 (lookup_line), (bus_desktop_file_get_raw),
6785 (bus_desktop_file_get_string):
6786 * bus/desktop-file.h:
6787 Some fixes, and new functions for getting a key value from a section.
6789 2003-02-13 Havoc Pennington <hp@pobox.com>
6791 * test/data/auth/fail-after-n-attempts.auth-script: new test
6793 * dbus/dbus-auth.c (send_rejected): shutdown_mech() when we
6796 2003-02-13 Havoc Pennington <hp@pobox.com>
6798 * dbus/dbus-auth.c (handle_server_data_external_mech): args to
6799 dbus_credentials_match were backward
6801 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support
6802 NO_CREDENTIALS and ROOT_CREDENTIALS
6804 * dbus/dbus-auth.c (_dbus_auth_do_work): move get_state() routine
6805 into here. Never process more commands after we've reached an
6806 end state; store further data as unused bytes.
6808 * test/data/auth/*: add more auth tests
6810 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support EXPECT
6811 command to match exact string and EXPECT_UNUSED to match unused
6814 * test/Makefile.am (dist-hook): fix to dist all the test stuff
6816 2003-02-12 Havoc Pennington <hp@pobox.com>
6818 * dbus/dbus-string.c (_dbus_string_pop_line): fix to also strip
6819 \r off of popped lines
6821 * dbus/dbus-auth.c (_dbus_auth_test): write code to run auth
6824 * dbus/dbus-auth-script.c (_dbus_auth_script_run): when doing a
6827 2003-02-12 Havoc Pennington <hp@pobox.com>
6829 * dbus/Makefile.am: remove break-loader from the build, since it
6832 * configure.in: add --enable-gcov to turn on coverage profiling
6833 flags and disable optimization
6835 2003-02-10 Havoc Pennington <hp@pobox.com>
6837 * dbus/dbus-auth-script.c, dbus/dbus-auth-script.h: sync
6838 initial cut at test framework for DBusAuth from laptop.
6839 Doesn't quite work yet but it compiles and I need to get
6840 it off the 266mhz laptop. ;-)
6842 * dbus/dbus-server-debug.c (_dbus_server_debug_accept_transport):
6843 fix a memleak in error case
6845 2003-02-12 Anders Carlsson <andersca@codefactory.se>
6848 * bus/desktop-file.c:
6849 * bus/desktop-file.h:
6850 Add a desktop file parser.
6852 2003-02-11 Zack Rusin <zack@kde.org>
6854 * qt/message.[h|cpp]: sample implementation
6855 of the KDE wrapper for DBusMessage
6857 2003-02-09 Zack Rusin <zack@kde.org>
6859 * test/bus-test.c: make_it_compile
6860 * doc/dbus-specification.sgml: minimal semantic fix
6862 2003-02-06 Anders Carlsson <andersca@codefactory.se>
6868 2003-02-06 Anders Carlsson <andersca@codefactory.se>
6871 * dbus/dbus-break-loader.c:
6873 * test/break-loader.c:
6874 Move dbus-break-loader to test/ and rename it to break-loader.
6876 2003-02-02 Havoc Pennington <hp@pobox.com>
6878 * dbus/dbus-keyring.c, dbus/dbus-keyring.h: template files
6879 for code to manage cookies in your home directory
6881 * dbus/dbus-sysdeps.c (_dbus_generate_random_bytes): new function
6883 * dbus/dbus-auth.c (get_state): impose a maximum number of tries
6884 to authenticate, then disconnect the client.
6886 2003-02-03 Alexander Larsson <alexl@redhat.com>
6888 * dbus/dbus-message.c (dbus_message_append_fields):
6891 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6893 * doc/dbus-specification.sgml:
6894 Update address format section.
6896 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6899 * test/bus-test.c: (get_time), (add_timeout), (remove_timeout),
6900 (message_handler), (new_connection_callback), (loop_quit),
6904 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6906 * bus/driver.c: (bus_driver_handle_service_exists):
6907 Simplify the code a bit.
6909 * dbus/dbus-bus.c: (dbus_bus_service_exists):
6912 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6915 Add libdbus-daemon.la and link to it.
6917 2003-02-01 James Willcox <jwillcox@gnome.org>
6919 * bus/driver.c: (bus_driver_handle_own_service):
6920 Actually include the service reply code in the message.
6922 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6924 * bus/driver.c: (bus_driver_handle_service_exists):
6925 Don't unref the incoming message.
6927 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6929 * dbus/dbus.h: Add dbus-address.h and dbus-bus.h
6931 2003-02-02 Anders Carlsson <andersca@codefactory.se>
6933 * dbus/dbus-server.c: (dbus_server_listen):
6934 * dbus/dbus-transport.c: (_dbus_transport_open):
6935 ifdef out the calls to the debug transport and server.
6937 2003-02-02 Alexander Larsson <alexl@redhat.com>
6939 * dbus/dbus-watch.c (dbus_watch_get_flags):
6940 Add note in the docs that ERROR or HANGUP won't be returned
6941 and are assumed always on.
6943 * glib/dbus-gmain.c (add_watch):
6944 Always add IO_ERR | IO_HUP
6946 * dbus/dbus-message.h:
6947 Add semicolon after dbus_message_iter_get_string_array().
6948 Makes qt code build again
6950 2003-02-01 Anders Carlsson <andersca@codefactory.se>
6952 * bus/driver.c: (create_unique_client_name),
6953 (bus_driver_handle_hello):
6954 Don't take a name, just use a numeric id to identify
6958 * dbus/dbus-bus.c: (dbus_bus_register_client),
6959 (dbus_bus_acquire_service), (dbus_bus_service_exists):
6961 Add new convenience functions for communicating with the bus.
6963 * dbus/dbus-message.h:
6965 * dbus/dbus-protocol.h:
6968 2003-02-01 Alexander Larsson <alexl@redhat.com>
6970 * dbus/dbus-message.c (dbus_message_append_fields):
6971 Add some more doc comments.
6973 2003-02-01 Havoc Pennington <hp@pobox.com>
6975 * dbus/dbus-break-loader.c (randomly_modify_length): change
6976 a 4-byte value in the message as if it were a length
6978 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): don't set
6979 execute bit on saved files
6981 2003-02-01 Havoc Pennington <hp@pobox.com>
6983 * dbus/dbus-break-loader.c (main): new program to find messages
6984 that break the loader.
6986 * dbus/dbus-sysdeps.c (_dbus_string_append_uint): new function
6987 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): new function
6989 * dbus/dbus-string.c (_dbus_string_set_byte): new
6991 2003-01-31 Havoc Pennington <hp@pobox.com>
6993 * dbus/dbus-message.c: refactor the test code to be more general,
6994 in preparation for writing a "randomly permute test cases to
6995 try to break the loader" program.
6997 2003-01-31 Havoc Pennington <hp@pobox.com>
6999 * doc/dbus-specification.sgml: work on the specification
7001 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): check
7002 the protocol version of the message.
7004 * dbus/dbus-protocol.h: drop special _REPLY names, the spec
7005 no longer specifies that.
7006 (DBUS_SERVICE_REPLY_SERVICE_EXISTS): fix flags (1/2/4/8 not
7009 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos): add missing
7010 "break" for DBUS_TYPE_NIL, remove @todo
7012 2003-01-31 Havoc Pennington <hp@pobox.com>
7014 * dbus/dbus-message.c (dbus_message_set_is_error_reply): rename
7015 just set_is_error/get_is_error as this is a commonly-used
7016 function, and write docs.
7018 2003-01-31 Anders Carlsson <andersca@codefactory.se>
7020 * dbus/dbus-address.c: (dbus_address_entry_free):
7021 Free key and value lists.
7023 * dbus/dbus-internals.c: (_dbus_type_to_string):
7024 Add the types we didn't have.
7026 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
7027 (_dbus_marshal_validate_arg):
7030 * dbus/dbus-message.c: (dbus_message_set_sender):
7031 Remove todo about being able to set sender to NULL.
7033 (dbus_message_set_is_error_reply),
7034 (dbus_message_get_is_error_reply):
7035 * dbus/dbus-message.h:
7038 * dbus/dbus-protocol.h:
7039 Add error reply flag.
7041 * test/data/valid-messages/opposite-endian.message:
7042 Add NIL type to test.
7044 2003-01-31 Havoc Pennington <hp@pobox.com>
7046 * doc/dbus-specification.sgml: fully specify the header. Add
7047 flags and major protocol version, and change header/body len to
7050 * dbus/dbus-message-builder.c (append_saved_length): append length
7053 * dbus/dbus-message.c (dbus_message_create_header): change header
7054 length and body length to unsigned. Add the new fields from the
7056 (_dbus_message_loader_return_buffer): unsigned header/body len
7058 2003-01-30 Havoc Pennington <hp@pobox.com>
7060 * dbus/dbus-auth.c: rework to use only REJECTED, no
7063 * doc/dbus-sasl-profile.txt: drop MECHANISMS and just
7064 use REJECTED, suggested by Mark McLoughlin
7066 2003-01-30 Havoc Pennington <hp@pobox.com>
7068 * dbus/dbus-server.c (dbus_server_listen): @todo about how we need
7069 a better way to report errors here. e.g. "unix address lacks
7070 path" or something. also "no such file" when the path doesn't
7073 * dbus/dbus-address.c (dbus_address_entries_free): add @todo about
7075 (dbus_parse_address): add @todo about documenting address format,
7076 and allowing , and ; to be escaped
7078 2003-01-30 Anders Carlsson <andersca@codefactory.se>
7081 Add dbus-address.[ch]
7083 * dbus/dbus-address.c: (dbus_address_entry_free),
7084 (dbus_address_entries_free), (create_entry),
7085 (dbus_address_entry_get_method), (dbus_address_entry_get_value),
7086 (dbus_parse_address), (_dbus_address_test):
7087 * dbus/dbus-address.h:
7088 New files for dealing with address parsing.
7090 * dbus/dbus-connection.c:
7091 Document timeout functions.
7093 * dbus/dbus-message.c:
7094 Document dbus_message_new_from_message.
7096 * dbus/dbus-server-debug.c:
7099 * dbus/dbus-server.c: (dbus_server_listen):
7100 Parse address and use correct server implementation.
7102 * dbus/dbus-string.c: (_dbus_string_find_to), (_dbus_string_test):
7103 * dbus/dbus-string.h:
7104 New function with test.
7106 * dbus/dbus-test.c: (dbus_internal_symbol_do_not_use_run_tests):
7110 * dbus/dbus-transport-debug.c:
7113 * dbus/dbus-transport.c: (_dbus_transport_open):
7114 Parse address and use correct transport implementation.
7116 2003-01-30 Havoc Pennington <hp@pobox.com>
7118 * dbus/dbus-message.c: use message->byte_order instead of
7119 DBUS_COMPILER_BYTE_ORDER throughout.
7120 (dbus_message_create_header): pad header to align the
7121 start of the body of the message to 8-byte boundary
7123 * dbus/dbus-marshal.h: make all the demarshalers take const
7124 DBusString arguments.
7126 * dbus/dbus-message.c (_dbus_message_loader_return_buffer):
7127 validate message args here, so we don't have to do slow validation
7128 later, and so we catch bad messages as they are incoming. Also add
7129 better checks on header_len and body_len. Also fill in
7132 * dbus/dbus-string.c (_dbus_string_validate_utf8): new (not
7133 implemented properly)
7134 (_dbus_string_validate_nul): new function to check all-nul
7136 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): rename
7137 get_arg_end_pos and remove all validation
7138 (_dbus_marshal_validate_arg): actually do validation here.
7140 2003-01-29 Havoc Pennington <hp@pobox.com>
7142 * dbus/dbus-message.c (check_message_handling): fix assertion
7143 failure on set_client_serial
7145 2003-01-28 Havoc Pennington <hp@pobox.com>
7147 * dbus/dbus-server-debug.c: Add doc section comments
7149 * dbus/dbus-transport-debug.c: add doc section comments
7151 2003-01-28 Havoc Pennington <hp@redhat.com>
7153 * dbus/dbus-string.c (_dbus_string_base64_decode): append bytes in
7154 the reverse order from how I had it
7155 (_dbus_string_base64_encode): reverse encoding order. I was
7156 basically byteswapping everything during encoding.
7158 2003-01-28 Anders Carlsson <andersca@codefactory.se>
7160 * dbus/dbus-connection-internal.h:
7161 * dbus/dbus-connection.c: (_dbus_connection_add_timeout),
7162 (_dbus_connection_remove_timeout):
7163 Add functions for adding and removing timeouts.
7165 * dbus/dbus-message.c: (dbus_message_new_from_message):
7166 Add new function that takes a message and creates an exact
7167 copy of it, but with the refcount set to 1.
7168 (check_message_handling):
7171 * dbus/dbus-server-protected.h:
7172 * dbus/dbus-server.c: (_dbus_server_init_base),
7173 (_dbus_server_finalize_base), (_dbus_server_add_timeout),
7174 (dbus_server_set_timeout_functions):
7175 (_dbus_server_remove_timeout):
7176 New functions so that a server can add and remove timeouts.
7178 (dbus_server_listen):
7179 Add commented out call to dbus_server_debug_new.
7181 * dbus/dbus-timeout.c: (_dbus_timeout_new):
7182 Actually set the handler, doh.
7184 * dbus/dbus-transport.c: (_dbus_transport_open):
7185 Add commented out call to dbus_transport_debug_client_new.
7188 Add dbus-transport-debug.[ch] and dbus-server-debug.[ch]
7190 2003-01-28 Havoc Pennington <hp@pobox.com>
7192 * dbus/dbus-message.c (check_message_handling): function to check
7193 on the loaded message, iterates over it etc.
7195 2003-01-28 Havoc Pennington <hp@pobox.com>
7197 * test/Makefile.am (dist-hook): fix make distdir
7199 * dbus/Makefile.am (TESTS_ENVIRONMENT): fix make check
7201 2003-01-27 Havoc Pennington <hp@pobox.com>
7203 * dbus/dbus-mempool.c (time_for_size): replace printf with
7206 * dbus/dbus-message-builder.c (_dbus_message_data_load): allow
7207 empty lines; fix the SAVE_LENGTH stuff to be
7208 START_LENGTH/END_LENGTH so it actually works; couple other
7211 * test/Makefile.am (dist-hook): add dist-hook for .message files
7213 * dbus/dbus-string.c (DBUS_STRING_COPY_PREAMBLE): source of a copy
7214 can be constant or locked.
7215 (_dbus_string_free): allow freeing a const string as
7218 * dbus/dbus-sysdeps.c (_dbus_concat_dir_and_file): utility
7220 * dbus/dbus-test-main.c (main): take an argument which is the
7221 directory containing test data
7223 * dbus/dbus-message.c (_dbus_message_test): pass a test_data_dir
7224 argument to this and load all the messages in test/data/
7225 checking that they can be loaded or not loaded as appropriate.
7227 2003-01-27 Anders Carlsson <andersca@codefactory.se>
7229 * bus/dispatch.c: (bus_dispatch_message_handler):
7230 Dispatch messages sent to services.
7232 * bus/driver.c: (bus_driver_send_service_deleted),
7233 (bus_driver_send_service_created), (bus_driver_send_service_lost),
7234 (bus_driver_send_service_acquired):
7235 Add helper functions for sending service related messages.
7237 (bus_driver_send_welcome_message):
7238 Send HELLO_REPLY instead of WELCOME.
7240 (bus_driver_handle_list_services):
7241 Send LIST_SERVICES_REPLY instead of SERVICES.
7243 (bus_driver_handle_own_service),
7244 (bus_driver_handle_service_exists):
7245 New message handlers.
7247 (bus_driver_handle_message):
7248 Invoke new message handlers.
7250 (bus_driver_remove_connection):
7251 Don't remove any services here since that's done automatically
7252 by bus_service_remove_owner now.
7255 New function signatures.
7257 * bus/services.c: (bus_service_add_owner):
7258 Send ServiceAcquired message if we're the only primary owner.
7260 (bus_service_remove_owner):
7261 Send ServiceAcquired/ServiceLost messages.
7263 (bus_service_set_prohibit_replacement),
7264 (bus_service_get_prohibit_replacement):
7265 Functions for setting prohibit replacement.
7267 (bus_service_has_owner):
7268 New function that checks if a connection is in the owner queue of
7272 Add new function signatures.
7274 * dbus/dbus-list.c: (_dbus_list_test):
7275 Add tests for _dbus_list_remove_last and traversing the list backwards.
7278 Fix a typo in _dbus_list_get_prev_link, if we're at the first element we can't
7279 go any further, so return NULL then.
7281 * dbus/dbus-protocol.h:
7282 Add new messages, service flags and service replies.
7284 2003-01-26 Havoc Pennington <hp@pobox.com>
7286 * dbus/dbus-message-builder.c: implement, completely untested.
7288 * test/data/*: add data to be used in testing.
7289 ".message" files are our simple loadable text format.
7290 ".message-raw" will be binary dumps of messages.
7292 * dbus/dbus-string.c (_dbus_string_starts_with_c_str): new
7294 2003-01-26 Havoc Pennington <hp@pobox.com>
7296 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): new function
7298 * dbus/dbus-errors.c (dbus_result_to_string): add
7301 * dbus/dbus-message-builder.c: new file, will contain code to load
7302 up messages from files. Not implemented yet.
7304 2003-01-26 Havoc Pennington <hp@pobox.com>
7306 * dbus/dbus-message.c (dbus_message_set_sender): support deleting
7307 the sender by setting to NULL
7309 2003-01-26 Havoc Pennington <hp@pobox.com>
7311 The unit tests pass, but otherwise untested. If it breaks, the
7312 tests should have been better. ;-)
7314 * bus/driver.c (bus_driver_handle_hello): return if we disconnect
7317 * dbus/dbus-message.c: redo everything so we maintain
7318 message->header as the only copy of the various fields.
7319 This avoids the possibility of out-of-memory in some cases,
7320 for example dbus_message_lock() can't run out of memory anymore,
7321 and avoids extra copying. Figured I may as well go ahead and do
7322 this since it was busted for dbus_message_lock to not return
7323 failure on OOM, and dbus_message_write_header was totally
7324 unchecked for OOM. Also fixed some random other bugs.
7326 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): verify
7327 that strings are nul-terminated. Also, end_pos can be equal
7328 to string length just not greater than, I think.
7329 (_dbus_marshal_set_int32): new function
7330 (_dbus_marshal_set_uint32): new function
7331 (_dbus_marshal_set_string): new function
7333 * dbus/dbus-connection.c (_dbus_connection_new_for_transport): fix
7334 a warning, init timeout_list to NULL
7335 (dbus_connection_send_message): don't use uninitialized variable
7338 * dbus/dbus-string.c (_dbus_string_replace_len): new function
7340 2003-01-26 Anders Carlsson <andersca@codefactory.se>
7342 * bus/driver.c: (bus_driver_handle_hello),
7343 (bus_driver_send_welcome_message):
7346 2003-01-26 Anders Carlsson <andersca@codefactory.se>
7348 * dbus/dbus-auth.c: (process_auth), (_dbus_auth_unref):
7349 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
7350 (dbus_connection_unref):
7351 * dbus/dbus-marshal.c: (_dbus_marshal_test):
7352 * dbus/dbus-message.c: (dbus_message_unref),
7355 (dbus_message_get_fields):
7356 Remove debugging printout.
7358 (_dbus_message_loader_return_buffer):
7359 Don't store the header string.
7361 (_dbus_message_test):
7364 2003-01-26 Richard Hult <rhult@codefactory.se>
7366 * glib/dbus-gmain.c (dbus_connection_dispatch): Traverse a copy of
7367 the file descriptor list, since it can change under us.
7369 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7371 * glib/dbus-gmain.c: (dbus_connection_prepare),
7372 (dbus_connection_check), (dbus_connection_dispatch), (add_watch),
7373 (remove_watch), (dbus_connection_hookup_with_g_main):
7374 Rewrite the glib handling to use its own GSource instead of a
7375 GIOChannel so we can catch messages put in the queue while waiting
7378 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7381 * bus/connection.c: (connection_disconnect_handler),
7382 (connection_watch_callback), (bus_connection_setup):
7383 * bus/dispatch.c: (send_one_message),
7384 (bus_dispatch_broadcast_message), (bus_dispatch_message_handler),
7385 (bus_dispatch_add_connection), (bus_dispatch_remove_connection):
7387 * bus/driver.c: (bus_driver_send_service_deleted),
7388 (bus_driver_send_service_created), (bus_driver_handle_hello),
7389 (bus_driver_send_welcome_message),
7390 (bus_driver_handle_list_services), (bus_driver_remove_connection),
7391 (bus_driver_handle_message):
7393 Refactor code, put the message dispatching in its own file. Use
7394 _DBUS_HANDLE_OOM. Also send ServiceDeleted messages when a client
7397 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7399 * dbus/dbus-internals.h:
7400 Add _DBUS_HANDLE_OOM macro, it doesn't do anything currently.
7402 * dbus/dbus-message.c: (dbus_message_get_sender):
7403 * dbus/dbus-message.h:
7404 Implement dbus_message_get_sender.
7406 * dbus/dbus-protocol.h:
7407 Add message and service defines.
7409 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7411 * dbus/dbus-connection.c: (dbus_connection_send_message):
7412 * dbus/dbus-message-internal.h:
7413 * dbus/dbus-message.c: (_dbus_message_get_client_serial),
7414 (dbus_message_write_header):
7415 Remove _dbus_messag_unlock and don't set the client serial on a
7416 message if one already exists.
7418 2003-01-24 Havoc Pennington <hp@pobox.com>
7420 * dbus/dbus-list.c (alloc_link): put a thread lock on the global
7423 * bus/driver.c (bus_driver_handle_list_services): fix a leak
7426 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7428 * dbus/dbus-list.c: (alloc_link), (free_link):
7429 Use a memory pool for the links.
7431 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7433 * bus/connection.c: (bus_connection_foreach):
7435 Add new bus_connection_foreach function.
7437 * bus/driver.c: (send_one_message), (bus_driver_broadcast_message):
7438 Add function that broadcasts a message to all clients.
7440 (bus_driver_send_service_created), (bus_driver_handle_hello),
7441 (bus_driver_send_welcome_message),
7442 (bus_driver_handle_list_services), (bus_driver_message_handler):
7443 Implement functions that take care of listing services, and notifying
7444 clients when new services are created.
7446 * bus/services.c: (bus_services_list):
7448 Add new function that returns an array of strings with the currently
7449 registered services.
7452 * glib/dbus-gmain.c:
7453 Update copyright year.
7455 2003-01-25 Anders Carlsson <andersca@codefactory.se>
7457 * dbus/dbus-connection.c: (dbus_connection_send_message):
7458 Unlock the message in case it was sent earlier.
7460 (dbus_connection_send_message_with_reply_and_block):
7461 Remove the reply message from the list.
7463 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
7464 Set array_len and new_pos correctly.
7466 (_dbus_marshal_test):
7467 Remove debug output.
7469 * dbus/dbus-message-internal.h:
7470 * dbus/dbus-message.c: (_dbus_message_get_reply_serial):
7471 New function that returns the reply serial.
7473 (_dbus_message_unlock):
7474 New function that unlocks a message and resets its header.
7476 (dbus_message_append_string_array),
7477 (dbus_message_get_fields_valist),
7478 (dbus_message_iter_get_field_type),
7479 (dbus_message_iter_get_string_array),
7480 (dbus_message_get_fields),
7481 (dbus_message_append_fields_valist):
7482 Handle string arrays.
7484 (dbus_message_set_sender):
7485 Make this function public since the bus daemon needs it.
7487 (decode_header_data):
7488 Set the reply serial to -1 initially.
7490 * dbus/dbus-message.h:
7491 Add dbus_message_set_sender.
7493 2003-01-24 Havoc Pennington <hp@pobox.com>
7495 * doc/dbus-specification.sgml: add some stuff
7497 2003-01-22 Havoc Pennington <hp@pobox.com>
7499 * doc/dbus-specification.sgml: Start to document the protocol.
7501 2003-01-22 Havoc Pennington <hp@pobox.com>
7503 * dbus/dbus-connection.c
7504 (dbus_connection_send_message_with_reply_and_block): add some @todo
7506 * bus/driver.c (bus_driver_add_connection): add a FIXME about memleak
7508 2003-01-21 Havoc Pennington <hp@pobox.com>
7510 (patch untested because can't compile)
7512 * bus/driver.c (create_unique_client_name): make this function
7513 never recycle client names. Also, caller should initialize
7516 * dbus/dbus-sysdeps.c (_dbus_get_current_time): new function
7518 2003-01-21 Anders Carlsson <andersca@codefactory.se>
7520 * dbus/dbus-marshal.c: (_dbus_marshal_double),
7521 (_dbus_marshal_int32), (_dbus_marshal_uint32),
7522 (_dbus_marshal_int32_array), (_dbus_marshal_uint32_array),
7523 (_dbus_marshal_double_array), (_dbus_marshal_string_array),
7524 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
7525 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
7526 (_dbus_marshal_get_field_end_pos), (_dbus_marshal_test):
7527 * dbus/dbus-marshal.h:
7528 * dbus/dbus-protocol.h:
7529 Add support for marshalling and demarshalling integer, double
7532 2003-01-21 Anders Carlsson <andersca@codefactory.se>
7537 * bus/connection.c: (connection_disconnect_handler):
7538 Remove the connection from the bus driver's list.
7540 (connection_watch_callback): Dispatch messages.
7542 (free_connection_data): Free connection name.
7544 (bus_connection_setup): Add connection to the bus driver's list.
7545 (bus_connection_remove_owned_service):
7546 (bus_connection_set_name), (bus_connection_get_name):
7547 Add functions for setting and getting the connection's name.
7550 Add function headers.
7552 * bus/driver.c: (create_unique_client_name),
7553 (bus_driver_handle_hello_message),
7554 (bus_driver_send_welcome_message), (bus_driver_message_handler),
7555 (bus_driver_add_connection), (bus_driver_remove_connection):
7558 * bus/services.c: (bus_service_free):
7560 New file that handles communication and registreation with the bus
7563 2003-01-21 Anders Carlsson <andersca@codefactory.se>
7565 * dbus/dbus-connection.c: (dbus_connection_send_message):
7566 Add a new client_serial parameter.
7568 (dbus_connection_send_message_with_reply):
7569 Remove a @todo since we've implemented the blocking function.
7571 (dbus_connection_send_message_with_reply_and_block):
7572 New function that sends a message and waits for a reply and
7573 then returns the reply.
7575 * dbus/dbus-connection.h:
7578 * dbus/dbus-errors.c: (dbus_result_to_string):
7579 * dbus/dbus-errors.h:
7580 Add new DBUS_RESULT.
7582 * dbus/dbus-message-internal.h:
7583 * dbus/dbus-message.c: (_dbus_message_get_reply_serial),
7584 (_dbus_message_set_sender), (dbus_message_write_header),
7585 (dbus_message_new_reply), (decode_header_data),
7586 (_dbus_message_loader_return_buffer), (_dbus_message_test):
7587 * dbus/dbus-message.h:
7588 Add new functions that set the reply serial and sender.
7589 Also marshal and demarshal them correctly and add test.
7591 * dbus/dbus-protocol.h:
7592 Add new DBUS_MESSAGE_TYPE_SENDER.
7595 * glib/dbus-gmain.c: (watch_callback), (free_callback_data),
7596 (add_watch), (remove_watch), (add_timeout), (remove_timeout),
7597 (dbus_connection_hookup_with_g_main):
7598 * glib/test-dbus-glib.c: (main):
7599 Rewrite to use GIOChannel and remove the GSource crack.
7601 * test/echo-client.c: (main):
7602 * test/watch.c: (check_messages):
7603 Update for changed APIs
7605 2003-01-19 Anders Carlsson <andersca@codefactory.se>
7607 * dbus/Makefile.am: Add dbus-timeout.[cħ]
7609 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport):
7610 Create a DBusTimeoutList.
7611 (dbus_connection_set_timeout_functions): Add new function to
7612 set timeout callbacks
7614 * dbus/dbus-connection.h: Add public DBusTimeout API.
7616 * dbus/dbus-message.c: (dbus_message_get_service):
7617 * dbus/dbus-message.h: New function.
7619 * dbus/dbus-server.c: Fix small doc typo.
7621 * dbus/dbus-timeout.[ch]: New files for mainloop timeouts.
7623 2003-01-19 Anders Carlsson <andersca@codefactory.se>
7625 * dbus/dbus-string.c (_dbus_string_move_len): Don't delete all
7626 of the string, just as long as specified.
7628 2003-01-19 Havoc Pennington <hp@pobox.com>
7630 * dbus/dbus-connection.c (dbus_connection_get_is_authenticated):
7633 * dbus/dbus-server.c (dbus_server_set_max_connections)
7634 (dbus_server_get_max_connections, dbus_server_get_n_connections):
7635 keep track of current number of connections, and add API for
7636 setting a max (but haven't implemented enforcing the max yet)
7638 2003-01-18 Havoc Pennington <hp@pobox.com>
7640 * dbus/dbus-transport-unix.c (unix_do_iteration): only do the
7641 reading/writing if read_watch != NULL or write_watch != NULL.
7643 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): fix
7644 the message loader code to actually load message->header and
7645 message->body into the newly-created message.
7647 * dbus/dbus-transport-unix.c (check_write_watch): fix a mem leak
7650 * dbus/dbus-connection.c (dbus_connection_set_max_message_size)
7651 (dbus_connection_get_max_message_size)
7652 (dbus_connection_set_max_live_messages_size)
7653 (dbus_connection_get_max_live_messages_size): implement some
7654 resource limitation functions
7656 * dbus/dbus-resources.c: new file implementing some of the
7657 resource limits stuff
7659 * dbus/dbus-message.c (dbus_message_iter_get_byte_array): add
7660 missing docs, add @todo to handle OOM etc.
7662 * dbus/dbus-marshal.c (_dbus_demarshal_byte_array): add missing
7665 2003-01-18 Havoc Pennington <hp@pobox.com>
7667 * dbus/dbus-connection.c (dbus_connection_unref): disconnect the
7668 connection if it hasn't been already.
7670 * dbus/dbus-connection.h: kill off the idea of an ErrorFunction,
7671 replace with DisconnectFunction.
7673 2003-01-18 Havoc Pennington <hp@pobox.com>
7675 Building --disable-verbose-mode --disable-asserts --disable-tests
7676 cuts the library from 112K to 45K or so
7678 * configure.in: check for varargs macro support,
7679 add --enable-verbose-mode, --enable-asserts.
7681 * dbus/dbus-internals.h (_dbus_assert): support
7683 (_dbus_verbose): support DBUS_ENABLE_VERBOSE_MODE
7685 2003-01-18 Havoc Pennington <hp@pobox.com>
7687 * dbus/dbus-test.c: include config.h so that tests actually run
7689 * dbus/dbus-string.c: add assertions that stuff is 8-byte aligned,
7690 so the failure mode when that assumption fails will be plenty
7693 2003-01-18 Havoc Pennington <hp@pobox.com>
7695 * configure.in: default --enable-tests to $USE_MAINTAINER_MODE
7697 * dbus/Makefile.am: fix it up so dubs-test-main.c is included in
7700 * test/Makefile.am: don't use special variable "TESTS" for echo-*
7701 since we don't want to use those in make check
7703 2003-01-15 Havoc Pennington <hp@redhat.com>
7709 2003-01-15 Havoc Pennington <hp@redhat.com>
7711 * test/Makefile.am: fix so that test source code ends up in the
7712 distribution on make distcheck
7714 2003-01-15 Havoc Pennington <hp@redhat.com>
7720 2003-01-15 Havoc Pennington <hp@redhat.com>
7722 * dbus/dbus-test.c (dbus_internal_symbol_do_not_use_run_tests):
7723 fix build when --disable-tests
7725 * Makefile.am (EXTRA_DIST): put HACKING in here
7727 * HACKING: document procedure for making a tarball release.
7729 2003-01-14 Anders Carlsson <andersca@codefactory.se>
7731 * bus/connection.c: (connection_error_handler),
7732 (bus_connection_setup):
7733 * bus/main.c: (main):
7734 Make sure that the DBusConnectionData struct is NULLed
7735 out to prevent a segfault.
7737 * dbus/dbus-errors.c: (dbus_result_to_string):
7738 * dbus/dbus-errors.h:
7739 * dbus/dbus-message.c: (dbus_message_get_fields),
7740 (dbus_message_get_fields_valist), (_dbus_message_test):
7741 * dbus/dbus-message.h:
7742 Make dbus_message_get_fields return a result code so we can
7743 track invalid fields as well as oom.
7745 2003-01-11 Havoc Pennington <hp@pobox.com>
7747 * configure.in: change --enable-test/--enable-ansi action-if-given
7748 to enable_foo=$enableval instead of enable_foo=yes
7750 2003-01-08 Havoc Pennington <hp@pobox.com>
7752 * dbus/dbus-string.c (_dbus_string_align_length): new function
7754 * dbus/dbus-test-main.c: move main() for test app here
7756 (dbus_internal_symbol_do_not_use_run_tests): we have to export a
7757 symbol to run tests, because dbus-test isn't in the main
7760 Code review nitpicks.
7762 * dbus/dbus-message.c (dbus_message_write_header): add newlines
7763 for people with narrow emacs ;-). Assert client_serial was filled
7764 in. Assert message->name != NULL.
7765 (dbus_message_append_fields): have "first_field_type" arg separate
7766 from va list, needed for C++ binding that also uses varargs IIRC
7767 and helps with type safety
7768 (dbus_message_new): add @todo about using DBusString to store
7769 service/name internally
7770 (dbus_message_new): don't leak ->service and ->name on OOM later
7772 (dbus_message_unref): free the service name
7773 (dbus_message_get_fields): same change to varargs
7774 i.e. first_field_type
7775 (_dbus_message_loader_return_buffer): assert that the message data
7776 is aligned (if not it's a bug in our code). Put in verbose griping
7777 about why we set corrupted = TRUE.
7778 (decode_header_data): add FIXME that char* is evil. Was going to
7779 add FIXME about evil locale-specific string.h strncmp, but just
7780 switched to wacky string-as-uint32 optimization. Move check for
7781 "no room for field name" above get_const_data_len() to avoid
7782 assertion failure in get_const_data_len if we have trailing 2
7783 bytes or the like. Check for service and name fields being
7784 provided twice. Don't leak service/name on error. Require field
7785 names to be aligned to 4 bytes.
7787 * dbus/dbus-marshal.c: move byte swap stuff to header
7788 (_dbus_pack_int32): uscore-prefix
7789 (_dbus_unpack_int32): uscore-prefix
7790 (_dbus_unpack_uint32): export
7791 (_dbus_demarshal_string): add @todo complaining about use of
7793 (_dbus_marshal_get_field_end_pos): add @todo about bad error
7794 handling allowing corrupt data to go unchecked
7796 2003-01-08 Havoc Pennington <hp@redhat.com>
7798 * dbus/dbus-transport-unix.c (unix_do_iteration): add read/write
7799 to the select() as needed for authentication. (should be using
7800 _dbus_poll() not select, but for another day)
7802 * dbus/dbus.h: include dbus/dbus-protocol.h
7804 2003-01-08 Anders Carlsson <andersca@codefactory.se>
7806 * dbus/Makefile.am (dbusinclude_HEADERS): Install
7809 2003-01-08 Anders Carlsson <andersca@codefactory.se>
7811 * dbus/dbus-internals.c: (_dbus_type_to_string):
7812 New function that returns a string describing a type.
7814 * dbus/dbus-marshal.c: (_dbus_demarshal_byte_array):
7815 * dbus/dbus-marshal.h:
7816 * dbus/dbus-message.c: (dbus_message_get_fields_valist),
7817 (dbus_message_iter_get_field_type), (dbus_message_iter_get_double),
7818 (dbus_message_iter_get_byte_array):
7819 * dbus/dbus-message.h:
7820 Add new convenience functions for appending and getting message fields.
7821 Also add demarshalling routines for byte arrays.
7823 2003-01-07 Anders Carlsson <andersca@codefactory.se>
7825 * dbus/dbus-connection-internal.h:
7826 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
7827 (_dbus_connection_get_next_client_serial),
7828 (dbus_connection_send_message):
7829 * dbus/dbus-internals.h:
7830 * dbus/dbus-marshal.c: (unpack_uint32), (dbus_unpack_int32),
7831 (dbus_pack_int32), (_dbus_marshal_double), (_dbus_marshal_int32),
7832 (_dbus_marshal_uint32), (_dbus_demarshal_double),
7833 (_dbus_demarshal_int32), (_dbus_demarshal_uint32),
7834 (_dbus_demarshal_string), (_dbus_marshal_get_field_end_pos),
7835 (_dbus_verbose_bytes), (_dbus_marshal_test):
7836 * dbus/dbus-marshal.h:
7837 * dbus/dbus-message-internal.h:
7838 * dbus/dbus-message.c: (_dbus_message_set_client_serial),
7839 (dbus_message_write_header), (_dbus_message_lock),
7840 (dbus_message_new), (dbus_message_ref), (dbus_message_unref),
7841 (dbus_message_get_name), (dbus_message_append_int32),
7842 (dbus_message_append_uint32), (dbus_message_append_double),
7843 (dbus_message_append_string), (dbus_message_append_byte_array),
7844 (dbus_message_get_fields_iter), (dbus_message_iter_ref),
7845 (dbus_message_iter_unref), (dbus_message_iter_has_next),
7846 (dbus_message_iter_next), (dbus_message_iter_get_field_type),
7847 (dbus_message_iter_get_string), (dbus_message_iter_get_int32),
7848 (dbus_message_iter_get_uint32), (dbus_message_iter_get_double),
7849 (decode_header_data), (_dbus_message_loader_return_buffer),
7850 (message_iter_test), (_dbus_message_test):
7851 * dbus/dbus-message.h:
7852 * dbus/dbus-protocol.h:
7853 * dbus/dbus-test.c: (main):
7855 * glib/test-dbus-glib.c: (message_handler), (main):
7856 * test/echo-client.c: (main):
7857 * test/watch.c: (check_messages):
7858 Make messages sendable and receivable for real.
7860 2003-01-07 Anders Carlsson <andersca@codefactory.se>
7862 * dbus/dbus-marshal.c: (_dbus_marshal_double),
7863 (_dbus_marshal_string), (_dbus_marshal_byte_array):
7864 * dbus/dbus-message.c: (dbus_message_append_int32),
7865 (dbus_message_append_uint32), (dbus_message_append_double),
7866 (dbus_message_append_string), (dbus_message_append_byte_array):
7867 Handle OOM restoration.
7869 2003-01-07 Anders Carlsson <andersca@codefactory.se>
7871 * dbus/dbus-marshal.c: (_dbus_marshal_string),
7872 (_dbus_demarshal_string), (_dbus_marshal_test):
7873 * dbus/dbus-marshal.h:
7874 * dbus/dbus-message.c: (dbus_message_get_name),
7875 Document these functions.
7877 (dbus_message_append_int32), (dbus_message_append_uint32),
7878 (dbus_message_append_double), (dbus_message_append_string),
7879 (dbus_message_append_byte_array):
7880 * dbus/dbus-message.h:
7881 Add functions for adding message fields of different types.
7883 * dbus/dbus-protocol.h:
7884 Add the different types.
7886 2003-01-05 Havoc Pennington <hp@pobox.com>
7888 * bus/connection.c: implement routines for handling connections,
7889 first thing is keeping a list of owned services on each connection
7890 and setting up watches etc.
7892 * bus/services.c: implement a mapping from service names to lists
7895 * dbus/dbus-hash.c: add DBUS_HASH_POINTER
7897 * dbus/dbus-threads.c (dbus_static_mutex_lock): add functions
7898 to use static mutexes for global data
7900 * dbus/dbus-connection.c (dbus_connection_set_data): add new
7901 collection of functions to set/get application-specific data
7902 on the DBusConnection.
7904 2003-01-04 Havoc Pennington <hp@pobox.com>
7906 * dbus/dbus-sysdeps.c (_dbus_sleep_milliseconds): new function
7907 (_dbus_poll): new function
7909 * dbus/dbus-internals.h (_DBUS_STRUCT_OFFSET): new macro
7912 * bus/loop.c: initial code for the daemon main loop
7914 2003-01-04 Havoc Pennington <hp@pobox.com>
7916 * test/watch.c (error_handler): make it safe if the error handler
7917 is called multiple times (if we s/error handler/disconnect
7918 handler/ we should just guarantee it's called only once)
7920 * dbus/dbus-transport.c (_dbus_transport_disconnect): call the
7921 error handler on disconnect (it's quite possible we should
7922 just change the error handler to a "disconnect handler," I'm
7923 not sure we have any other meaningful errors)
7925 * configure.in: check for getpwnam_r
7927 * dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
7928 dbus/dbus-auth.c: add credentials support, add EXTERNAL auth
7929 mechanism as in SASL spec, using socket credentials
7931 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): new function
7932 (_dbus_send_credentials_unix_socket): new function
7934 * dbus/dbus-sysdeps.c (_dbus_accept_unix_socket): rename just
7936 (_dbus_write): only check errno if <0 returned
7937 (_dbus_write_two): ditto
7939 2003-01-02 Anders Carlsson <andersca@codefactory.se>
7941 * dbus/dbus-marshal.c: (_dbus_marshal_utf8_string),
7942 (_dbus_marshal_byte_array), (_dbus_demarshal_utf8_string),
7943 (_dbus_marshal_test):
7944 * dbus/dbus-marshal.h:
7945 Add _dbus_marshal_byte_array and rename _dbus_marshal_string
7946 to _dbus_marshal_utf8_string. Also fix some tests.
7948 2002-12-28 Harri Porten <porten@kde.org>
7950 * configure.in: added check for C++ compiler and a very cheesy
7951 check for the Qt integration
7953 * Makefile.am (SUBDIRS): compile qt subdir if support is enabled
7955 * qt/Makefile.am: added
7957 * qt/.cvsignore: added
7959 * qt/dbus-qthread.cc, qt/dbus-qthread.cpp: renamed former to
7960 latter, added #ifdef QT_THREAD_SUPPORT guard.
7962 * dbus/Makefile.am: added missing headers for make dist
7964 2002-12-28 Kristian Rietveld <kris@gtk.org>
7966 * dbus/Makefile.am: fixup export-symbols-regex.
7968 2002-12-27 Anders Carlsson <andersca@codefactory.se>
7970 * acinclude.m4: Add this file and put the
7971 PKG_CHECK_MODULE macro in it.
7973 2002-12-27 Anders Carlsson <andersca@codefactory.se>
7975 * dbus/dbus-marshal.c: (_dbus_marshal_string),
7976 (_dbus_demarshal_double), (_dbus_demarshal_int32),
7977 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
7978 (_dbus_marshal_test):
7979 Make the demarshalling routines align the pos argument.
7980 Add string marshalling tests and fix the obvious bugs
7983 2002-12-26 Havoc Pennington <hp@pobox.com>
7985 * dbus/dbus-auth.c: fixes fixes fixes
7987 * dbus/dbus-transport-unix.c: wire up support for
7988 encoding/decoding data on the wire
7990 * dbus/dbus-auth.c (_dbus_auth_encode_data)
7991 (_dbus_auth_decode_data): append to target string
7992 instead of nuking it.
7994 2002-12-26 Havoc Pennington <hp@pobox.com>
7996 * dbus/dbus-marshal.h (DBUS_COMPILER_BYTE_ORDER): #ifdef
7997 WORDS_BIGENDIAN then compiler byte order is DBUS_BIG_ENDIAN,
8000 * dbus/dbus-marshal.c: Add macros to do int swapping in-place and
8001 avoid swap_bytes() overhead (ignoring possible assembly stuff for
8002 now). Main point is because I wanted unpack_uint32 to implement
8004 (_dbus_verbose_bytes): new function
8006 * dbus/dbus-string.c (_dbus_string_validate_ascii): new function
8008 * dbus/dbus-message.c (_dbus_message_loader_get_is_corrupted): add
8009 mechanism to handle a corrupt message stream
8010 (_dbus_message_loader_new): fix preallocation to only prealloc,
8013 * dbus/dbus-string.c (_dbus_string_skip_blank): fix this function
8014 (_dbus_string_test): enhance tests for copy/move and fix the
8017 * dbus/dbus-transport-unix.c: Hold references in more places to
8018 avoid reentrancy problems
8020 * dbus/dbus-transport.c: ditto
8022 * dbus/dbus-connection.c (dbus_connection_dispatch_message): don't
8023 leak reference count in no-message case
8025 * test/watch.c (do_mainloop): handle adding/removing watches
8026 during iteration over the watches. Also, ref the connection/server
8027 stored on a watch, so we don't try to mangle a destroyed one.
8029 * dbus/dbus-transport-unix.c (do_authentication): perform
8032 * dbus/dbus-auth.c (get_state): add a state
8033 AUTHENTICATED_WITH_UNUSED_BYTES and return it if required
8034 (_dbus_auth_get_unused_bytes): append the unused bytes
8035 to the passed in string, rather than prepend
8037 * dbus/dbus-transport.c (_dbus_transport_init_base): create
8038 the auth conversation DBusAuth
8040 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd)
8041 (_dbus_transport_new_for_domain_socket): when creating a
8042 transport, pass in whether it's a client-side or server-side
8043 transport so we know which DBusAuth to create
8045 2002-12-03 Havoc Pennington <hp@pobox.com>
8047 * dbus/dbus-transport-unix.c (unix_finalize): finalize base
8048 _after_ finalizing the derived members
8049 (unix_connection_set): unref watch if we fail to add it
8051 * dbus/dbus-connection.c (dbus_connection_unref): delete the
8052 transport first, so that the connection owned by the
8053 transport will be valid as the transport finalizes.
8055 * dbus/dbus-transport-unix.c (unix_finalize): free the write_watch
8056 if necessary, and remove watches from the connection.
8058 * dbus/dbus-watch.c (_dbus_watch_list_free): improve a comment
8060 2002-12-26 Anders Carlsson <andersca@codefactory.se>
8062 * dbus/dbus-marshal.c: (_dbus_marshal_string),
8063 (_dbus_demarshal_double), (_dbus_demarshal_int32),
8064 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
8065 (_dbus_marshal_test):
8066 * dbus/dbus-marshal.h:
8067 Add string marshal functions and have the demarshal functions
8068 return the new position.
8070 2002-12-25 Havoc Pennington <hp@pobox.com>
8072 * doc/dbus-sasl-profile.txt: docs on the authentication protocol,
8073 it is a simple protocol that just maps directly to SASL.
8075 * dbus/dbus-auth.h, dbus/dbus-auth.c: authentication protocol
8076 initial implementation, not actually used yet.
8078 * dbus/dbus-string.c (_dbus_string_find): new function
8079 (_dbus_string_equal): new function
8080 (_dbus_string_base64_encode): new function
8081 (_dbus_string_base64_decode): new function
8083 2002-12-25 Anders Carlsson <andersca@codefactory.se>
8086 * dbus/dbus-marshal.c: (swap_bytes), (_dbus_marshal_double),
8087 (_dbus_marshal_int32), (_dbus_marshal_uint32),
8088 (_dbus_demarshal_double), (_dbus_demarshal_int32),
8089 (_dbus_demarshal_uint32), (_dbus_marshal_test):
8090 * dbus/dbus-marshal.h:
8091 * dbus/dbus-protocol.h:
8092 * dbus/dbus-test.c: (main):
8094 Add un-optimized marshalling/demarshalling routines.
8096 2002-12-25 Harri Porten <porten@kde.org>
8098 * qt/dbus-qt.h: adjusted ctor and getter to KDE/Qt conventions
8100 2002-12-24 Zack Rusin <zack@kde.org>
8102 * qt/dbus-qthread.cc: adding - integrates QMutex into Dbus
8103 * qt/dbus-qt.h: skeleton with two sample implemenatation of the
8106 2002-12-24 Havoc Pennington <hp@pobox.com>
8108 * glib/dbus-gthread.c: fix include
8110 * glib/dbus-glib.h: rename DBusMessageHandler for now.
8111 I think glib API needs to change, though, as you don't
8112 want to use DBusMessageFunction, you want to use the
8113 DBusMessageHandler object. Probably
8114 dbus_connection_open_with_g_main_loop()
8115 and dbus_connection_setup_g_main_loop() or something like that
8116 (but think of better names...) that just create a connection
8117 that has watch/timeout functions etc. already set up.
8119 * dbus/dbus-connection.c
8120 (dbus_connection_send_message_with_reply): new function just to
8121 show how the message handler helps us deal with replies.
8123 * dbus/dbus-list.c (_dbus_list_remove_last): new function
8125 * dbus/dbus-string.c (_dbus_string_test): free a string that
8128 * dbus/dbus-hash.c: use memory pools for the hash entries
8129 (rebuild_table): be more paranoid about overflow, and
8130 shrink table when we can
8131 (_dbus_hash_test): reduce number of sprintfs and write
8132 valid C89. Add tests for case where we grow and then
8133 shrink the hash table.
8135 * dbus/dbus-mempool.h, dbus/dbus-mempool.c: memory pools
8137 * dbus/dbus-connection.c (dbus_connection_register_handler)
8138 (dbus_connection_unregister_handler): new functions
8140 * dbus/dbus-message.c (dbus_message_get_name): new
8142 * dbus/dbus-list.c: fix docs typo
8144 * dbus/dbus-message-handler.h, dbus/dbus-message-handler.c:
8145 an object representing a handler for messages.
8147 2002-12-16 Anders Carlsson <andersca@codefactory.se>
8150 * glib/dbus-gthread.c: (dbus_gthread_init):
8151 Don't use the gdbus prefix for public functions.
8153 2002-12-16 Anders Carlsson <andersca@codefactory.se>
8157 Add GLib checks and fixup .pc files
8161 * glib/dbus-gmain.c: (gdbus_connection_prepare),
8162 (gdbus_connection_check), (gdbus_connection_dispatch),
8163 (gdbus_add_connection_watch), (gdbus_remove_connection_watch),
8164 (dbus_connection_gsource_new):
8165 * glib/dbus-gthread.c: (dbus_gmutex_new), (dbus_gmutex_free),
8166 (dbus_gmutex_lock), (dbus_gmutex_unlock), (dbus_gthread_init):
8167 * glib/test-dbus-glib.c: (message_handler), (main):
8170 2002-12-15 Harri Porten <porten@kde.org>
8172 * autogen.sh: check for libtoolize before attempting to use it
8174 * dbus/dbus-transport-unix.c: include <sys/time.h> for timeval
8177 * .cvsignore: ignore more stamp files
8179 * dbus/dbus-watch.c (_dbus_watch_list_new): fixed doc error
8181 * test/Makefile.am: added -I$(top_srcdir) to be able to compile
8182 without make install.
8184 2002-12-15 Havoc Pennington <hp@pobox.com>
8186 * dbus/dbus-threads.c: add thread stubs that a higher library
8187 layer can fill in. e.g. the GLib wrapper might fill them in with
8188 GThread stuff. We still need to use this thread API to
8189 thread-safe-ize the library.
8191 2002-12-12 Havoc Pennington <hp@pobox.com>
8193 * dbus/dbus-transport-unix.c, dbus/dbus-server-unix.c: use the
8194 below new interfaces and include fewer system headers.
8196 * dbus/dbus-sysdeps.c (_dbus_read): new function
8197 (_dbus_write): new function
8198 (_dbus_write_two): new function
8199 (_dbus_connect_unix_socket): new function
8200 (_dbus_listen_unix_socket): new function
8202 * dbus/dbus-message-internal.h: change interfaces to use
8205 2002-12-11 Havoc Pennington <hp@pobox.com>
8207 * dbus/dbus-types.h: add dbus_unichar
8209 * dbus/dbus-internals.c (_dbus_verbose): use _dbus_getenv
8211 * dbus/dbus-connection.c (dbus_connection_send_message): return
8214 * dbus/dbus-transport.c: include dbus-watch.h
8216 * dbus/dbus-connection.c: include dbus-message-internal.h
8218 * HACKING: add file with coding guidelines stuff.
8220 * dbus/dbus-string.h, dbus/dbus-string.c: Encapsulate all string
8221 handling here, for security purposes (as in vsftpd). Not actually
8222 using this class yet.
8224 * dbus/dbus-sysdeps.h, dbus/dbus-sysdeps.c: Encapsulate all
8225 system/libc usage here, as in vsftpd, for ease of auditing (and
8226 should also simplify portability). Haven't actually moved all the
8227 system/libc usage into here yet.
8229 2002-11-25 Havoc Pennington <hp@pobox.com>
8231 * dbus/dbus-internals.c (_dbus_verbose): fix to not
8232 always print the first verbose message.
8234 2002-11-24 Havoc Pennington <hp@pobox.com>
8236 * test/echo-client.c, test/echo-server.c: cheesy test
8239 * configure.in (AC_CHECK_FUNCS): check for writev
8241 * dbus/dbus-message.c (_dbus_message_get_network_data): new
8244 * dbus/dbus-list.c (_dbus_list_foreach): new function
8246 * dbus/dbus-internals.c (_dbus_verbose): new function
8248 * dbus/dbus-server.c, dbus/dbus-server.h: public object
8249 representing a server that listens for connections.
8251 * dbus/.cvsignore: create
8253 * dbus/dbus-errors.h, dbus/dbus-errors.c:
8254 public API for reporting errors
8256 * dbus/dbus-connection.h, dbus/dbus-connection.c:
8257 public object representing a connection that
8258 sends/receives messages. (Same object used for
8259 both client and server.)
8261 * dbus/dbus-transport.h, dbus/dbus-transport.c:
8262 Basic abstraction for different kinds of stream
8263 that we might read/write messages from.
8265 2002-11-23 Havoc Pennington <hp@pobox.com>
8267 * dbus/dbus-internals.h (_DBUS_INT_MAX): add _DBUS_INT_MIN
8270 * dbus/dbus-test.c (main): add list test, and include
8271 dbus-test.h as intended
8273 * dbus/dbus-hash.c (_dbus_hash_table_remove_string)
8274 (_dbus_hash_table_remove_int): return value indicates
8275 whether the entry existed to remove
8277 * dbus/dbus-list.c: add linked list utility class,
8280 * dbus/dbus-hash.c: add TODO item about shrinking the hash bucket
8283 2002-11-23 Havoc Pennington <hp@pobox.com>
8285 * Doxyfile.in (INCLUDE_FILE_PATTERNS): expand DBUS_BEGIN_DECLS/
8286 DBUS_END_DECLS to nothing, that should fix this once and for all
8288 * Doxyfile.in (JAVADOC_AUTOBRIEF): set to YES
8290 * dbus/dbus-message.c, dbus/dbus-hash.c:
8291 add some missing @brief
8293 2002-11-23 Havoc Pennington <hp@pobox.com>
8295 * dbus/dbus-message.h: put semicolons after DEBUG_BEGIN_DECLS
8296 to avoid confusing Doxygen
8298 * dbus/dbus-hash.c: @} not }@
8300 * dbus/dbus-message.c (struct DBusMessage): split out
8303 2002-11-23 Havoc Pennington <hp@pobox.com>
8305 * configure.in: pile on more warning flags if using gcc
8307 * Doxyfile.in (EXTRACT_STATIC): set to NO, so we don't have
8308 to document static functions
8310 * configure.in: add summary to end of configure so it
8311 looks nice and attractive
8313 * dbus/dbus-hash.c: finish implementation and write unit
8316 * configure.in: add --enable-tests to enable unit tests
8318 * dbus/dbus-test.c: test program to run unit tests
8319 for all files in dbus/*, initially runs a test for
8322 * dbus/dbus-internals.h: file to hold some internal utility stuff
8324 2002-11-22 Havoc Pennington <hp@redhat.com>
8326 * dbus/dbus-hash.c: copy in Tcl hash table, not yet
8327 "ported" away from Tcl
8329 * dbus/dbus-types.h: header for types such as dbus_bool_t
8331 2002-11-22 Havoc Pennington <hp@redhat.com>
8333 * dbus/dbus.h: fixups for doc warnings
8335 * Doxyfile.in (FILE_PATTERNS): we need to scan .h to pick up
8337 (QUIET): make it quiet so we can see warnings
8339 * dbus/dbus-memory.c: teach D-BUS to allocate and free memory
8341 2002-11-22 Havoc Pennington <hp@redhat.com>
8343 * Makefile.am: include "Doxyfile" target in all-local
8345 * configure.in: generate the Doxyfile
8347 * Doxyfile.in: move Doxyfile here, so we can use
8348 configure to generate a Doxyfile with the right
8351 2002-11-22 Havoc Pennington <hp@redhat.com>
8353 * dbus/dbus-message.c: move inline docs into .c file
8355 * Doxyfile (OUTPUT_DIRECTORY): move output to doc/api
8356 so all docs are under doc/
8357 (MAN_EXTENSION): generate man pages. Use extension
8358 ".3dbus" which matches ".3qt" on my system,
8359 I guess this is OK, I don't know really.
8360 (FILE_PATTERNS): look for .c files not .h, makes sense
8363 2002-11-22 Havoc Pennington <hp@pobox.com>
8365 * Makefile.am (SUBDIRS): rename subdir "server" to "bus"
8366 because any app can be a server, and any app can be a client,
8367 the bus is a special kind of server.
8369 Thu Nov 21 23:35:31 2002 Zack Rusin <zack@kde.org>
8371 * Doxyfile : adding. Still needs Makefile rules to be generated
8372 automatically (just run "doxygen" in the toplevel dir for now to
8375 * dbus/dbus-message.h : Adding sample docs (javadoc since
8376 resembles gtk-doc a little more)
8378 * dbus/dbus.h : Adding sample docs
8380 2002-11-21 Havoc Pennington <hp@redhat.com>
8382 * dbus/Makefile.am (INCLUDES): define DBUS_COMPILATION
8383 so we can allow ourselves to include files directly,
8384 instead of having to use dbus.h
8386 * dbus/dbus.h: fill in
8388 * dbus/dbus-message.h: sketch out a sample header file.
8389 Include griping if you include it directly instead of
8392 * dbus/dbus-macros.h: new file with macros for extern "C",
8393 TRUE/FALSE, NULL, etc.
8395 * doc/file-boilerplate.c: put include guards in here
8397 2002-11-21 Havoc Pennington <hp@redhat.com>
8399 * doc/file-boilerplate.c: include both AFL and GPL boilerplate.
8401 * COPYING: include the GPL as well, and license code
8402 under both AFL and GPL.
8404 2002-11-21 Havoc Pennington <hp@redhat.com>
8406 * acconfig.h: get rid of this
8408 * autogen.sh (run_configure): add --no-configure option
8410 * configure.in: remove AC_ARG_PROGRAM to make
8411 autoconf complain less. add AC_PREREQ.
8412 add AC_DEFINE third arg.
8414 2002-11-21 Anders Carlsson <andersca@codefactory.se>
8417 Fix references so we can distcheck.
8419 2002-11-21 Havoc Pennington <hp@redhat.com>
8421 * Initial module creation