1 2006-06-24 Jim Meyering <jim@meyering.net>
3 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
5 2006-06-22 Jim Meyering <jim@meyering.net>
7 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
8 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
10 2006-06-19 Jim Meyering <jim@meyering.net>
12 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
13 so this check is not run as part of "make distcheck".
15 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
17 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
19 2006-06-18 Jim Meyering <jim@meyering.net>
21 * tests/misc/pwd-long: Make error output a little clearer.
23 2006-06-17 Jim Meyering <jim@meyering.net>
25 * tests/rm/inaccessible: Skip this test on systems without openat
26 support. Reported by Bob Proulx.
28 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
30 * tests/misc/mknod: Improve permission checks to handle
31 running mkdir test in set-gid directories.
33 2006-06-14 Jim Meyering <jim@meyering.net>
35 * tests/du/basic: Revamp not to hard-code file system block sizes.
37 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
39 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
42 2006-06-11 Jim Meyering <jim@meyering.net>
44 * .gitignore: New file.
45 * Makefile.am (EXTRA_DIST): Add .gitignore.
47 Setting TIME_STYLE=long-iso in the environment would make the
48 cp/same-file test fail.
49 * tests/envvar-check (vars): Add TIME_STYLE to the list.
50 * tests/cp/same-file: Revert last change.
51 Source the envvar-check script, to ensure that TIME_STYLE
52 settings don't affect these tests.
54 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
56 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
57 uses POSIX time stamp formats. Problem reported by John Nixon in
58 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
60 2006-06-10 Jim Meyering <jim@meyering.net>
62 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
64 Require a "Version N.M" line at the top of the ChangeLog
65 file only when making the actual release, not when running
67 * Makefile.maint (maintainer-distcheck): Don't depend on
69 (alpha beta major): Depend on it here, instead.
71 2006-06-08 Jim Meyering <jim@meyering.net>
73 Ensure that cat works with any of the options, -A -v -e -E -T,
74 when applied to files in /proc and /sys, even when the FIONREAD
75 ioctl produces nonsensical results. Before this change, cat would
76 produce no output (or truncated output), for some linux kernels.
78 * src/cat.c (write_pending): New function, factored out of cat.
79 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
80 that there are bytes to read. Some versions of linux-2.6.16 do that.
81 Write any pending output before returning.
82 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
83 * NEWS: Mention this bug fix.
84 * tests/misc/cat-proc: New file. Test for the above.
85 * tests/misc/Makefile.am (TESTS): Add cat-proc.
87 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
89 * src/expr.c (eval4): Detect overflow properly when multiplying
92 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
94 * NEWS: The 'expr' command now detects and reports integer overflow.
95 (It would be better to use extended precision instead, but that
97 * src/expr.c (integer_overflow): New function.
98 (eval4, eval3): Check for integer overflow.
100 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
102 Fix problems when building with Solaris/SVR4/etc. make, which uses a
103 different and somewhat bogus implementation of VPATH. In the
104 directory tests/misc, rename tests whose names might appear in the
105 Automake-generated rules. For example, we can't use a test named
106 'test', since Automake generates a rule that contains the text
107 "if test -f ./$$tst; ...", and this might expand to something like
108 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
109 which executes the 'test' script rather than the 'test' command.
110 * tests/misc/false-status: Renamed from tests/misc/false.
111 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
112 * tests/misc/sort-merge: Renamed from tests/misc/sort.
113 ($prog): Set to 'sort' rather than to $PROG.
114 * tests/misc/test-diag: Renamed from tests/misc/test.
115 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
116 in case Solaris make has prepended the directory.
117 (TESTS): Adjust to above renamings.
118 * tests/misc/expand: Don't assign to PROG; no longer needed
119 now that Makefile.am sets PROG to the basename.
120 * tests/misc/fold: Likewise.
122 2006-06-03 Jim Meyering <jim@meyering.net>
124 Make `cp --link --no-dereference' work also on systems where the
125 link system call cannot create a hard link to a symbolic link.
126 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
127 the link syscall on a symlink when it would do the wrong thing.
128 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
129 * tests/cp/link-no-deref: New file/test for the above.
130 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
131 * NEWS: Mention the change (doesn't affect Linux).
133 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
135 Fix some porting problems in the test cases reported by
136 Ralf Wildenhues for HP-UX 11.23 in:
137 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
138 * tests/help-version: Don't assume that \< \> works in sed.
139 * tests/misc/close-stdout: Don't assume that >&- works.
140 Add a /dev/full test.
141 * tests/touch/no-create-missing: Don't assume that >&- works.
143 2006-05-30 Jim Meyering <jim@meyering.net>
145 * src/ls.c (usage): Add `v' to the list of sorting-related options.
148 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
150 * tests/cp/fail-perm: source lang-default.
151 * tests/rm/inaccessible: Likewise.
153 2006-05-28 Jim Meyering <jim@meyering.net>
155 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
156 Recognize it, too. Reported by Ralf Wildenhues, in
157 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
159 2006-05-27 Jim Meyering <jim@meyering.net>
161 * src/chgrp.c: Support new options: --preserve-root and
162 --no-preserve-root. Somehow this program was skipped when those
163 options were added to chown, chmod, and rm. Reported by
164 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
165 * NEWS: Mention this.
167 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
169 * NEWS: Remove mention of --seed. We'll replace it with something
170 better, and don't want to indicate that it is supported.
171 * src/sort.c (usage): Likewise.
173 2006-05-20 Jim Meyering <jim@meyering.net>
175 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
177 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
178 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
179 FTS_COMFOLLOW. Spotted by Justin Pryzby.
181 * gnupload: Merge changes from automake, retaining the ""--to...
182 kludge to placate overzealous `make distcheck' check.
184 2006-05-19 Jim Meyering <jim@meyering.net>
186 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
187 FTS_TIGHT_CYCLE_CHECK directory traversal option.
188 Reported by Justin Pryzby in http://bugs.debian.org/367691
190 2006-05-15 Jim Meyering <jim@meyering.net>
192 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
195 2006-05-13 Jim Meyering <jim@meyering.net>
197 * tests/mv/no-target-dir: Test two more cases.
199 2006-05-11 Jim Meyering <jim@meyering.net>
201 mv -T DIR EMPTY_DIR no longer fails unconditionally
202 * src/copy.c (copy_internal): Don't manually prohibit a move where
203 the destination is an existing directory. Sometimes doing that is
204 valid. Let the rename system call enforce the rules. That is
205 allowed only when the source is a directory and the destination
206 directory (to be replaced) is empty. Reported by Eric Blake.
207 * tests/mv/no-target-dir: New file/test for this.
208 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
209 * NEWS: Mention this.
211 * tests/mv/atomic: New file/test for yesterday's fix.
212 * tests/mv/Makefile.am (TESTS): Add atomic.
214 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
216 2006-05-10 Jim Meyering <jim@meyering.net>
218 * src/copy.c (copy_internal): Don't explicitly unlink the destination
219 when moving a symlink into the place of an existing non-directory.
220 Reported by Joshua Hudson.
221 * NEWS: mention this.
223 2006-05-07 Jim Meyering <jim@meyering.net>
225 * Makefile.maint (patch-check): Fail if patch generates any output,
226 even merely for changed offsets.
228 * src/c99-to-c89.diff: Adjust to reflect new offsets.
230 * NEWS: Mention changes affecting df, pwd, shred.
232 2006-05-06 Jim Meyering <jim@meyering.net>
234 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
235 system condition where dirent.d_ino != stat.st_ino.
236 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
238 2006-05-06 Eric Blake <ebb9@byu.net>
240 * tests/ls/inode: Expand to test inode from readdir case.
241 * tests/ls/follow-slink: Expand to test broken links encountered
242 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
244 2006-05-06 Eric Blake <ebb9@byu.net>
246 * tests/mv/leak-fd: Work even on case-insensitive file system.
248 2006-05-04 Jim Meyering <jim@meyering.net>
250 * NEWS: Mention the 2006-03-19 pwd-related change that makes
251 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
253 2006-05-03 Jim Meyering <jim@meyering.net>
255 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
256 Use better macro parameter names: s/basename/key_name/,
257 s/basefunc/key_cmp_func. Fix typo in comment.
259 2006-04-29 Eric Blake <ebb9@byu.net>
261 * src/ls.c (main): On systems with d_type, directories_first only
262 implies format_needs_type, not format_needs_stat.
264 2006-05-03 Jim Meyering <jim@meyering.net>
266 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
267 after comma in arg list, from Eric Blake.
269 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
271 * tests/misc/date (relative-3): New test, derived from a bug
272 report by John Thomas McDole.
274 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
276 New option for ls: --group-directories-first.
277 It makes ls list directories before files.
278 * NEWS [New features]: Mention it.
279 * src/ls.c (sort_type): Rearrange to use as an array index when
280 choosing sort function; added new sort_numtypes member for
282 (time_type): Add new time_numtypes member for compile-time check.
283 (directories_first): New global variable.
284 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
285 (long_options): Add --directories-first.
286 (main): Support new option.
287 (is_directory): New function.
288 (extract_dirs_from_files): Use it.
289 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
290 (LIST_SORTFUNCTION_VARIANTS): New macros.
291 (sort_functions): New global variable.
292 (sort_files): Use it.
293 (usage): Document new option.
295 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
297 * src/shred.c (fillrand): The assertion was way too weak, due to
298 what must be a typo. Strengthen it to its intended value.
299 (dopass): Don't use alloca; it's not worth the aggravation here,
300 since it's used only to get a page-aligned buffer, and page
301 alignment doesn't buy us much here. I'm suspicious that alloca
302 causes problems on some hosts, due to a recent bug report by Adam
303 Waltman: http://bugs.gentoo.org/130246.
305 2006-04-18 Jim Meyering <jim@meyering.net>
307 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
308 sha384sum, sha512sum.
310 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
312 * src/chmod.c (describe_change): Adjust to filemode changes.
313 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
314 (print_long_format): Use (new) filemodestring rather than
315 (old) mode_string, so that we get more file types right, at least
316 in theory. Adjust to filemode changes.
317 * src/stat.c (human_access): Likewise.
319 2006-04-18 Jim Meyering <jim@meyering.net>
321 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
322 ignore file. This has never been enabled. Reported by Eric Blake.
324 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
326 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
327 bug in Interix. Just call symlink or link directly. All uses changed.
328 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
329 * src/stat.c (USE_STATVFS): New macro.
330 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
331 (NAMEMAX_FORMAT): define a bit more clearly, now that the
332 statvfs-using code is a bit more regular.
333 * src/system.h (sync) [!HAVE_SYNC]: New macro.
335 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
337 * NEWS: csplit, nl, expr now conform to POSIX better, and are
338 more-compatible with traditional Unix, with respect to regular
340 * src/csplit.c (extract_regexp): Set re_syntax_options to a
341 value that is compatible with what POSIX requires.
342 * src/nl.c (build_type_arg): Likewise.
343 * src/expr.c (docolon): Likewise. Also, don't let anchors match
344 newline; this fixes an incompatibility with tradition and with POSIX.
345 Don't warn about leading ^. POSIX says it is unspecified whether
346 ^ is a special character, which means that implementations can
347 either treat it as special or not, but either way a warning is not
348 allowed (unless the regexp is otherwise invalid). Instead, anchor
349 the expression but treat ^ as an anchor; this is the traditional
350 behavior (e.g., Solaris 10).
351 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
352 and the like as invalid expressions (exit status 2), not as
353 failure of 'expr' (exit status 3). This is more consistent with
355 * tests/expr/basic (fail-a): Adjust exit status to match new expr
356 behavior, for status 2 versus 3.
358 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
359 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
360 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
361 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
362 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
363 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
364 (bre61, bre62): New tests.
365 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
369 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
370 "if !". Do not assume that 'sed' can handle long, newline-free input.
371 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
373 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
375 Adjust to new regex.h API (with new fastmap type), and clean
376 up the regex storage allocation a bit.
378 * src/csplit.c (struct control): Put re_compiled member at the
379 end, since it's large. Change regexpr member from char * to bool;
380 all uses changed. Add new member fastmap.
381 (extract_regexp): regexp arg is now char const *, not char *.
382 Don't bother duplicating the regular expression; it's not needed.
383 Set fastmap from new fastmap member. Don't bother allocating
384 a buffer, as the regexp code does a better job than we do.
385 * src/expr.c (docolon): Allocate and use a fastmap.
386 Don't bother allocating a buffer.
387 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
389 (build_type_arg): New fastmap arg. All uses changed.
390 Don't bother allocating a buffer, but set a fastmap.
391 * src/ptx.c (context_regex_string, word_regex_string): Remove.
392 (context_regex, word_regex): New vars, replacing the above.
394 (struct regex_data): New type.
395 (compile_regex): Renamed from alloc_and_compile_regex, since
396 we no longer allocate storage. Arg is now a struct regex_data *,
397 not a const char *. All uses changed. Don't allocate the fastmap;
398 instead, take it from the caller. Don't convert size_t to int,
399 to avoid arithmetic overflow problems. Don't bother freeing
400 storage afterwards; it's not worth the aggravation.
401 * src/tac.c (compiled_separator_fastmap): New ver.
402 (main): Use it. Don't bother allocating a buffer.
404 2006-03-30 Jim Meyering <jim@meyering.net>
406 * src/dd.c (iwrite): Remove assignment without effect.
407 Reported by Felix Rauch Valenti.
409 2006-03-22 Eric Blake <ebb9@byu.net>
411 * src/ptx.c (usage): Remove mention of --copyright/-C.
412 (main): Alias --copyright to --version plus a deprecation warning.
413 * NEWS: Mention this.
415 2006-03-27 Jim Meyering <jim@meyering.net>
417 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
418 use of strtod. Tiny patch from Nickolai Zeldovich.
420 2006-03-11 Eric Blake <ebb9@byu.net>
422 * tests/misc/dirname: New file.
423 * tests/basename/Makefile.am: Delete.
424 * tests/basename/basic: Move to...
425 * tests/misc/basename: ... this new file. Add some tests,
426 including fixed behavior for //.
427 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
428 * tests/Makefile.am (SUBDIRS): Remove basename.
429 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
431 Improvements to dirname/basename handling on platforms like
432 cygwin with distinct // and with drive letters.
433 * NEWS: Document new behavior.
434 * src/basename.c (main): Don't strip suffix from file system
436 * src/cp.c (target_directory_operand): Use new last_component.
437 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
438 traversing the string.
439 * src/dircolors.c (guess_shell_syntax): Use new last_component.
440 * src/install.c (target_directory_operand, install_file_in_dir):
442 * src/ln.c (target_directory_operand, main): Likewise.
443 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
444 * src/mv.c (target_directory_operand, movefile): Likewise.
445 * src/remove.c (rm_1): Likewise.
446 * src/shred.c (wipename): Likewise.
447 * src/split.c (next_file_name): Likewise.
448 * src/su.c (log_su, run_shell): Likewise.
450 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
452 * NEWS: nohup diagnostics are now more precise, and nohup now
453 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
454 * src/nohup.c (main): Implement this.
455 * tests/misc/nohup: Test the new behavior.
457 2006-03-12 Jim Meyering <jim@meyering.net>
459 * src/copy.c (set_author): Rename function, from preserve_author.
461 * src/remove.c (AD_pop_and_chdir): Use new macro,
462 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
464 * src/system.h (SAME_INODE): Remove definition.
465 Include "same-inode.h", instead.
467 2006-03-11 Eric Blake <ebb9@byu.net>
469 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
471 2006-03-10 Jim Meyering <jim@meyering.net>
473 Fix a bug whereby a user with write access to a directory being removed
474 could cause the removal of that directory to fail with an erroneous
475 diagnostic about a directory cycle. Reported by Vineet Chadha.
477 * NEWS: Mention this.
478 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
479 leave (and try to rmdir) is the one whose dev_ino is being used to
480 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
482 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
484 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
485 * src/dd.c (set_fd_flags): Handle file-creation flags on file
486 descriptors, rather than ignoring them.
487 * tests/dd/misc: Add test cases for append, nofollow, directory,
488 and nolinks flags. Simplify redirection to /dev/null in some cases.
490 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
491 noatime test never tested anything.
493 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
495 * src/dd.c (flags, usage): New flags directory, nolinks.
496 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
498 * src/ls.c (usage): Mention that -f disables --color.
499 Problem reported by Niels Möller.
501 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
503 * man/*.x: Add references to syscalls from utilities of the same name.
505 2006-03-05 Jim Meyering <jim@meyering.net>
507 * tests/help-version: Set SHELL, if not already set, in order to
508 avoid failure when `make check' is run through debuild; dircolors
509 would fail due to lack of $SHELL. Reported by Sven Joachim.
511 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
512 * src/base64.c (wrap_write, do_encode, main): Change type of
513 parameters and locals, wrap_column, form size_t to uintmax_t.
514 (main): Adjust to use xstrtoumax, accordingly.
516 2006-03-03 Jim Meyering <jim@meyering.net>
518 Don't fail when run from an environment with SHELL not a Bourne
519 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
520 * tests/dircolors/simple: Invoke each non-failing test with -b.
521 Reported by Michael Stone.
523 2006-02-27 Jim Meyering <jim@meyering.net>
525 * tests/misc/base64: Derive --decode-using tests from the
528 * tests/misc/base64: Factor out a long constant string.
529 Split lines to stay within 80 columns.
531 * tests/misc/Makefile.am (TESTS): Add base64.
532 * tests/misc/base64: Test base64. From Simon Josefsson.
534 * src/base64.c (do_decode): Use correct type for parameter,
535 ignore_garbage: s/size_t/bool/.
537 * src/base64.c: Don't include .h files already included by system.h:
538 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
539 Include "system.h" before the other lib/*.h header files.
540 Include <sys/types.h> before "system.h".
541 (wrap_write): Remove declaration of unused local, initial_column.
542 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
544 * README: Add base64 to the list.
546 2006-02-17 Simon Josefsson <jas@extundo.com>
549 * AUTHORS: Mention base64.
551 * man/Makefile.am: Build base64.1.
552 * man/base64.x: New file.
553 * src/Makefile.am (bin_PROGRAMS): Add base64.
554 * src/base64.c: New file.
556 2006-02-25 Eric Blake <ebb9@byu.net>
558 In ls, avoid calling stat for --inode (-i), when possible.
559 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
560 * src/system.h: ... here, for use in ...
561 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
563 (gobble_file): Add inode argument.
564 (print_dir): Pass inode if available.
565 (usage): Remove inaccuracy.
567 2006-02-23 Jim Meyering <jim@meyering.net>
569 * TODO: Update/correct some obsolete entries.
571 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
573 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
574 * src/join.c (usage): Likewise.
575 Documentation problem reported by Philip Kensche.
577 2006-02-20 Eric Blake <ebb9@byu.net>
579 * man/rm.x: Update documentation to match previous patch.
581 2006-02-18 Eric Blake <ebb9@byu.net>
583 New option for rm: --interactive=once (-I).
584 * NEWS: Document it, along with change to rm --interactive.
585 * TODO: Remove entry for implementing rm -I
586 * src/rm.c (INTERACTIVE_OPTION): New enum value.
587 (interactive_type): New enum.
588 (long_opts): Let interactive take an optional argument.
589 (interactive_args, interactive_types): New option arguments.
590 (usage): Document -I, --interactive=WHEN. Use program_name
591 instead of a basename.
592 (main): New -I option, new behavior to --interactive.
593 * tests/rm/interactive-once: New tests.
594 * tests/rm/interactive-always: Ditto.
595 * tests/rm/Makefile.am (TESTS): Run them.
597 2006-02-18 Jim Meyering <jim@meyering.net>
599 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
600 expression match more of the target lines, e.g., those that start with
601 `-S,' (short option followed by a comma) or that include `=[...]'.
602 Patch by Nicolas François.
603 Fix the four offenders thus exposed:
604 * src/join.c (usage): Use two spaces (not one) to separate the
605 --first-only option string from its description, so help2man formats
606 the derived man page properly.
607 * src/pr.c (usage): Likewise.
608 * src/uniq.c (usage): Likewise.
609 * src/install.c (usage): Likewise.
611 2006-02-15 Jim Meyering <jim@meyering.net>
613 * Makefile.maint (alpha beta major): For `make major', ensure that the
614 version string is of the form N.N[.N]*, where N is one or more digits.
616 2006-02-14 Jim Meyering <jim@meyering.net>
618 * INSTALL: Update from gnulib.
620 2006-02-13 Jim Meyering <jim@meyering.net>
622 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
624 2006-02-12 Jim Meyering <jim@meyering.net>
626 * Makefile.maint (patch-check): New target.
627 (local-checks-available): Add to the list.
629 2006-02-11 Jim Meyering <jim@meyering.net>
631 * src/c99-to-c89.diff: New file.
632 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
634 * .x-po-check: New file, with exclusions so that `make distcheck'
636 * Makefile.am (EXTRA_DIST): Add .x-po-check.
638 rm -r must remove an empty directory, even if it is inaccessible.
639 * src/remove.c (close_preserve_errno): New function.
640 (fd_to_subdirp): Don't print a diagnostic in this function.
641 Do it from the callers instead, unless rmdir succeeds.
642 (remove_cwd_entries, remove_dir): Adjust callers.
643 * tests/rm/empty-inacc: New test for the above.
644 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
645 * NEWS: Mention this bug fix.
646 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
647 a tiny bit less precise: cannot remove `a/1': ... instead of
648 cannot open directory `a/1': ...
650 * Makefile.maint (syntax-check-rules): Automatically derive this
651 list of sc_-prefixed rule names.
653 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
655 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
656 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
657 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
658 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
659 go away? was that an accident?)
660 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
661 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
662 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
663 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
664 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
665 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
666 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
667 (author_mark_check, makefile_path_separator_check):
668 Output line numbers, to simplify navigation of Emacs *compilation*
670 (sc_prohibit_atoi_atof, sc_file_system):
671 Rework slightly so that Makefile.maint doesn't get reported as a
672 violation of its own syntax rules.
673 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
674 it at run-time (which didn't work with Bison). Fix a makefile typo,
675 caught by Makefile.maint itself: spaces where a tab should be.
676 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
677 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
678 Ignore djgpp and man subdirectories, to avoid false matches with
679 Bison and coreutils, respectively. Use sort -u to remove the
680 resulting duplicates.
681 * gnupload: Rework slightly to avoid bogus warning from
682 sc_two_space_separator_in_usage.
684 2006-02-10 Jim Meyering <jim@meyering.net>
686 Use gzip's --rsyncable option only if it's available.
687 * Makefile.maint (gzip_rsyncable): New variable.
690 2006-02-08 Jim Meyering <jim@meyering.net>
692 * Makefile.maint (local-checks-available): Define in terms of
693 the expansion, $(syntax-check-rules), rather than the single,
694 top-level target `syntax-check', so that it's easier to exclude
695 individual rules (via $(local-checks-to-skip)).
696 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
698 2006-02-07 Jim Meyering <jim@meyering.net>
700 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
701 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
703 * tests/help-version (expected_failure_status_vdir):
704 Redirect an expected disk-full diagnostic to /dev/null.
706 2006-02-06 Jim Meyering <jim@meyering.net>
708 * src/unexpand.c (usage): Use two spaces (not one) to separate the
709 --first-only option string from its description, so help2man formats
710 the derived man page properly.
711 * src/rm.c (usage): Likewise for --no-preserve-root.
712 * src/chown.c (usage): Likewise.
713 * src/chgrp.c (usage): Likewise.
715 Add a rule to ensure that the above doesn't happen again.
716 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
717 (syntax-check-rules): Add it.
718 * .x-sc_two_space_separator_in_usage: New empty file.
719 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
721 2006-02-06 Jim Meyering <jim@meyering.net>
723 * src/cp.c (usage): Use two spaces (not one) to separate each
724 option string from its description, so help2man formats the
725 derived man page properly.
726 * src/mv.c (usage): Likewise.
727 Patch from Nicolas François in http://bugs.debian.org/351601.
729 2006-02-04 Jim Meyering <jim@meyering.net>
731 * src/copy.c (copy_internal): cp -RL would fail when encountering
732 the same directory more than once in the hierarchy beneath a single
733 command-line argument. That is legitimate, e.g. when there are
734 two or more symbolic links, each pointing to some directory that
735 would not otherwise be copied. Reported by Christophe LYON.
736 * tests/cp/cp-deref: New file. Test for today's fix.
737 * tests/cp/Makefile.am (TESTS): Add cp-deref.
738 * NEWS: Document this.
740 2006-02-03 Jim Meyering <jim@meyering.net>
742 * configure.ac: Require automake-1.9.6, not 1.8.3.
744 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
746 * src/od.c (usage): Mention that -t a ignores high order bit.
747 Documentation problem reported by Ed Avis.
749 2006-02-01 Jim Meyering <jim@meyering.net>
751 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
753 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
755 * src/head.c (main): Use a better diagnostic when someone uses a
756 trailing numeric option in an invalid way. Problem reported by
758 * src/tail.c (parse_options): Likewise.
760 2006-01-30 Jim Meyering <jim@meyering.net>
762 * man/wc.x: Include `count' keyword in man page synopsis,
763 per suggestion from http://bugs.debian.org/181585.
765 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
767 * src/df.c (show_dev): If the file system claims to have
768 more available than total blocks, report the number of used
769 blocks as being total - available (a negative number) rather
770 than as garbage. Problem reported by Toralf Foerster.
772 2006-01-24 Jim Meyering <jim@meyering.net>
774 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
775 to put a regular file in O_NONBLOCK mode fails with EPERM.
776 That happens on Linux (up to 2.6.15) when using tail -f on a file with
777 the append-only attribute. Reported by Dean Gaudet. For details,
778 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
779 * NEWS: Mention this fix.
780 * tests/tail-2/append-only: New file. Test for the above.
781 * tests/tail-2/Makefile.am (TESTS): Add append-only.
782 * tests/Makefile.am (check-root): Add tail-2/append-only
784 2006-01-21 Jim Meyering <jim@meyering.net>
786 * NEWS: Mention fts-related improvements and bug fixes.
788 2006-01-19 Jim Meyering <jim@meyering.net>
790 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
791 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
793 2006-01-18 Jim Meyering <jim@meyering.net>
795 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
797 2006-01-17 Jim Meyering <jim@meyering.net>
799 Now that fts no longer changes the current working directory, adjust
800 its clients accordingly -- note that du.c uses fts but doesn't need
801 any adjustment, since it doesn't operate on the actual files,
802 but rather just uses the stat buffers provided by fts.
804 * src/chown-core.c: Include "openat.h".
805 Don't include "lchown.h".
806 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
807 calling openat, lchownat, chownat, rather than open, lchown, chown.
809 * src/chmod.c: Include "openat.h".
810 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
812 * tests/du/long-from-unreadable: New test, to exercise one small
815 2006-01-13 Jim Meyering <jim@meyering.net>
817 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
818 addition of new directories under tests/.
820 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
823 2006-01-12 Jim Meyering <jim@meyering.net>
825 * tests/du/long-sloop: Adjust not to hard-code the expected
826 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
827 from that of GNU libc. Reported by Paul Eggert.
829 * tests/du/long-sloop: Create file at end of symlink chain.
831 * tests/misc/test: New file, with a test for one of the
832 bugs fixed by yesterday's test.c changes.
833 * tests/misc/Makefile.am (TESTS): Add test.
835 2006-01-11 Jim Meyering <jim@meyering.net>
837 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
838 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
839 a very long sequence of symbolic links (not necessarily a loop).
840 * tests/du/Makefile.am (TESTS): Add long-sloop.
842 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
844 * src/test.c (test_syntax_error): Append a newline. All callers
845 changed, except for the ones that didn't already append a newline.
846 Bug reported by Eric Blake.
848 2006-01-11 Jim Meyering <jim@meyering.net>
850 * src/system.h (X2NREALLOC): Now that verify_true is no longer
851 void, cast its result to void, to avoid gcc's warning that
852 ``left-hand operand of comma expression has no effect''.
853 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
855 2006-01-10 Jim Meyering <jim@meyering.net>
857 * tests/chmod/no-x: Add a test for today's fts.c fix.
859 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
861 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
862 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
864 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
866 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
867 Use verify_true instead of verify_expr, to sync with gnulib.
869 2006-01-08 Jim Meyering <jim@meyering.net>
871 * src/date.c (usage): Adjust the formatting of the entries for
872 %::z and %:::z (separate with two spaces, not one) so that help2man
873 formats them properly. Reported by Philip Rowlands.
875 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
877 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
879 2006-01-06 Jim Meyering <jim@meyering.net>
881 * Makefile.maint (copyright-check): Use date +%Y in place of
884 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
885 First off, the attribute should have been `volatile' (not static)
886 to avoid longjmp-related risk of clobber. Secondly, now there is
887 no longer any risk of a local variable being clobbered, so there's
888 no need for any attribute at all.
890 2006-01-05 Jim Meyering <jim@meyering.net>
892 * src/remove.c: Give a few functions the inline attribute.
893 (AD_pop_and_chdir): Use gotos to avoid some duplication.
894 (AD_push): Rewrite an assertion so that the entire computation
895 goes away when assertions are turned off.
897 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
898 It's already defined in "system.h".
899 * Makefile.maint: Add a FIXME comment.
901 2006-01-04 Jim Meyering <jim@meyering.net>
903 * ChangeLog: Remove entries from 2005-10-22 and earlier.
904 * ChangeLog-2005: New file, for entries up to version 5.92.
906 2006-01-03 Jim Meyering <jim@meyering.net>
908 * tests/du/no-x: Also allow a slightly different diagnostic -- the
909 one you get when using openat-enabled fts.c and du (coming soon).
910 * tests/chmod/no-x: Likewise.
911 * tests/chgrp/no-x: Likewise.
913 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
915 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
917 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
918 (restricted_chown): Return it, if the file cannot be accessed due
919 to EPERM, or if no uid or gid are required, or if the file is
920 neither a directory nor a regular file. Rewrite to avoid gotos.
921 (change_file_owner): Handle RC_do_ordinary_chown case.
922 Rewrite to avoid gotos.
923 * tests/chgrp/basic: Make sure we can change the group of
926 * src/date.c (usage): Explain %g, %G, and %V a bit better.
928 2006-01-02 Jim Meyering <jim@meyering.net>
930 * src/copy.c (set_owner): Correct a comment.
932 * src/tail.c (parse_options): Change warning to say that --retry
933 is useful `mainly' (not `only') when following by name.
934 Reported here: http://bugs.debian.org/273781
936 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
938 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
939 * src/copy.c: Include lchmod.h.
940 (copy_internal): Use lchmod rather than chmod.
941 * src/cp.c: Include lchmod.h.
942 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
943 * src/mkdir.c: Include lchmod.h.
944 (usage): Clarify -m's operation.
945 (main): Use lchmod rather than chmod. Don't use lchmod unless the
946 new mode contains bits outside the 777 range.
947 * src/mkfifo.c (usage): Clarify -m's operation.
948 (main): If -m is given, don't invoke chmod; use umask 0 instead.
949 Report an error if -m asks for bits outside the 777 range.
950 * src/mknod.c (usage, main): Likewise.
952 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
954 2005-12-27 Jim Meyering <jim@meyering.net>
956 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
957 (sc_prohibit_assert_without_use): New rule.
958 (syntax-check-rules): Add it to the list.
959 * .x-sc_prohibit_assert_without_use: New empty file.
960 * Makefile.am (EXTRA_DIST): Add it.
962 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
964 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
965 Don't include <assert.h>; it wasn't used.
967 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
969 * src/chown-core.c (restricted_chown):
970 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
971 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
972 | O_NOFOLLOW too, for consistency with other dir-openers.
973 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
974 (is_empty_dir): Likewise.
975 * src/shred.c (wipename): Likewise. Don't bother trying to open
976 dir for writing, since POSIX prohibits it.
978 2005-12-22 Jim Meyering <jim@meyering.net>
980 * tests/help-version: Redirect stderr to /dev/full, to suppress
981 write error diagnostic.
983 2005-12-19 Jim Meyering <jim@meyering.net>
985 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
986 Avoid a minor race condition when `-m MODE' is specified, by using
987 open, fchown, and close rather than just chown. To do that reliably --
988 even with an overly restrictive umask -- ensure that each mkdir,
989 mknod and mkfifo call uses a mode including at least owner-read access.
990 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
991 the subsequent chown (or equivalent open,fchown,close) fails.
992 * tests/misc/mknod: New tests.
993 * tests/misc/Makefile.am (TESTS): Add mknod.
995 2005-12-17 Jim Meyering <jim@meyering.net>
997 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
998 e.g., on a named pipe.
999 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
1000 place of all uses, since it is guaranteed (system.h) to be defined.
1002 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
1004 Add POSIX ACL support
1005 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
1006 is no requirement for ACL support; particularly, it does not exist
1007 on systems that have POSIX ACLs.
1008 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1009 * src/cp.c (umask_kill): With default acls, the umask is not to be
1010 applied. Remove umask_kill, don't change the process umask, and let
1011 the kernel apply the umask where appropriate.
1012 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1013 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1015 (copy_reg, copy_internal): Use copy_acl and set_acl
1016 instead of fchown/chown. Fix the logic for POSIX ACLs.
1017 (chown_succeded): Remove; we now always copy acls and
1018 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1019 did a chown before or not.
1020 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1021 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1022 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1023 to link with it via $(LIB_ACL), for the utilities that need it.
1025 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1027 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1028 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1029 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1030 value is now signified by whether cwd_errno is null.
1031 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1032 pointer-to-bool to pointer-to-errno-value. All callers changed.
1033 (rm_1): Don't bother setting a local cwd failure flag and then
1034 ORing it into the caller's. Just set the caller's.
1035 (rm): Use cwd failure errno value to print a slightly-better
1038 2005-12-15 Jim Meyering <jim@meyering.net>
1040 * src/stat.c (print_it): Properly handle a backslash at the
1041 end of a --printf format string. Reported by Paul Eggert.
1042 * tests/misc/stat-printf (end-bs): Add a test for the above.
1044 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1046 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1047 Don't assume /etc/passwd contains user names; use 'id' instead.
1049 2005-12-15 Jim Meyering <jim@meyering.net>
1051 stat: revert behavior of --format=FMT (-c)
1052 stat: add new option: --printf=FMT
1053 * NEWS: Mention this.
1054 * src/stat.c (isodigit, octtobin, hextobin): Define.
1055 (PRINTF_OPTION): Define.
1056 (interpret_backslash_escapes, trailing_delim): New globals.
1057 (usage): Document them. Alphabetize on long option names.
1058 (print_esc_char): New function.
1059 (print_it): Rewrite, in order to handle backslash escapes.
1060 (main): Handle new option. Set globals for --format, too.
1062 * tests/misc/stat-printf: Test --printf and --format.
1063 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1065 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1067 * NEWS: sort now reports incompatible options.
1068 * src/sort.c (incompatible_options, check_ordering_compatibility):
1070 (main): Use them. Don't bother with a usage message for
1071 "sort -c a b", for consistency with other error diagnostics.
1072 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1075 * src/cat.c (main): Undo previous change. close_stdout already
1076 does the check, so the previous change wasn't necessary.
1078 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1080 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1082 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1084 Install a more-conservative approach for sort -R. It's the
1085 same basic idea as the existing code, except it uses the full ISAAC
1086 approach (called the "more kosher" approach in the existing comments).
1087 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1088 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1089 better to be conservative here at first, and review any performance
1090 improvements carefully.
1091 * .x-sc_require_config_h: Add src/rand-isaac.c.
1092 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1093 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1094 (shred_SOURCES, sort_SOURCES): Remove.
1095 (EXTRA_DIST): Add rand-isaac.c.
1096 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1097 changing it to allow for varying numbers of words in the state.
1098 Alter so that we include rand-isaac.c directly rather than
1099 compiling it and linking to it. Don't include config.h or
1100 system.h; that's the includer's responsibility.
1101 Omit functions that are specific to shred.
1102 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1103 (isaac_step, struct irand_state):
1104 Resurrect these, with the same defns that used to be in shred.c.
1105 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1106 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1108 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1109 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1110 (irand_init, irand32, irand_mod):
1111 Number of words is constant again.
1112 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1113 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1114 * src/sort.c: Likewise.
1115 * src/shred.c (fillrand, dopass, main): Undo previous change.
1116 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1118 * src/sort.c: Don't include md5.h; it wasn't needed.
1119 (struct keyfield): Rename random_hash to random, for consistency
1120 with the other member names. All uses changed.
1121 (usage): Tweak wording to mention STRING for --seed option.
1122 (short_options): Rorder for consistency with other programs.
1123 (rand_state): Now a struct, not a pointer to one. All uses changed.
1124 (HASH_WORDS, HASH_SIZE): Remove.
1125 (get_hash): Remove comments around resbuf size, since we can assume C89.
1126 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1127 (keycompare): Adjust to the new get_hash.
1129 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1130 (main): Don't set need_random simply because gkey has it set; that
1131 doesn't necessarily mean we'll need random numbers.
1132 Redo seeding to match new get_hash approach.
1134 2005-12-10 Jim Meyering <jim@meyering.net>
1136 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1138 Avoid shred segfault on 64-bit systems.
1139 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1140 local of type uint32_t. Make the local an `int' instead.
1142 * NEWS: Mention sort's new options.
1144 * src/rand-isaac.c (isaac_mix): Declare to be static.
1145 Mark all other functions as `extern' so the tight-scope
1146 part of `make distcheck' passes once again.
1147 * src/rand-isaac.h (isaac_mix): Remove declaration.
1149 * src/sort.c (get_hash): Change position of `*' in parameter
1150 type to conform with convention.
1151 (main): Split a long line so it fits in 80 columns.
1152 (keycompare): Remove stray SPACE before TAB that was
1153 causing `make distcheck' to fail.
1155 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1157 * tests/misc/sort-rand: New file: basic tests for the new options.
1158 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1160 2005-12-10 Frederik Eaton <frederik@ofb.net>
1162 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1163 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1164 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1165 Make state size runtime-configurable.
1166 (isaac_new, isaac_copy): New functions.
1167 * src/rand-isaac.h: New file.
1168 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1169 (fillrand, main): Adjust to the fact that the state size is now
1170 runtime-configurable.
1171 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1172 (usage): Add options --random-sort and --seed to implement a random
1174 Include md5.h and rand-isaac.h.
1175 (get_hash): New function.
1176 (rand_state): New var.
1177 (HASH_WORDS, HASH_SIZE): New macros.
1179 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1181 * tests/dd/misc: Add test for dd iflags=noatime.
1183 2005-12-09 Jim Meyering <jim@meyering.net>
1185 * src/sort.c (usage): Mention white space vs -b and -t options.
1188 2005-12-09 Eric Blake <ebb9@byu.net>
1190 * src/test.c (main): Fix misleading comment.
1192 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1194 * NEWS: Mention dd's new noatime flag.
1195 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1196 * src/dd.c (flags, usage): Add support for noatime flag.
1198 2005-12-07 Jim Meyering <jim@meyering.net>
1200 Distribute the cvsu script, used only by `make syntax-check'.
1201 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1202 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1203 distribute a copy of this script.
1204 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1206 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1207 to create a temporary directory on another partition.
1208 From Andreas Gruenbacher.
1210 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1212 * man/basename.x: Cross-reference to dirname and readlink.
1213 * man/dirname.x: Cross-reference to basename and readlink.
1215 2005-12-05 Andreas Gruenbacher
1217 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1218 (set_owner, preserve_author): New functions, factored out of copy_reg.
1219 (copy_reg): Use them.
1220 (copy_internal): Use them here, too.
1222 2005-12-04 Jim Meyering <jim@meyering.net>
1224 * src/sleep.c (usage): Say what happens with two or more arguments.
1225 Suggested by Justin Pryzby.
1227 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1230 2005-12-03 Jim Meyering <jim@meyering.net>
1232 * src/rm.c (long_opts): Change the name of each undocumented, for-
1233 testing-only option to start with `-', so that it cannot render
1234 ambiguous any prefix it happens to share with some other option name.
1235 Problem reported by Eric Blake.
1236 * src/head.c (long_options): Likewise.
1237 * src/tail.c (long_options): Likewise.
1239 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1240 testing-only --presume* options to start with `---'.
1241 * tests/rm/dangling-symlink: Likewise.
1242 * tests/rm/dir-no-w: Likewise.
1243 * tests/rm/isatty: Likewise.
1245 2005-11-30 Jim Meyering <jim@meyering.net>
1247 * Makefile.maint: Add a comment about cvsu.
1249 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1251 * NEWS: df updates for "none", "proc", inaccessible file systems.
1252 * src/df.c (show_point): Ignore inaccessible file systems.
1253 (usage): -a includes dummy file systems, not size-0 file systems.
1255 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1256 to avoid collision with POSIX name space. All uses changed.
1258 2005-11-24 Jim Meyering <jim@meyering.net>
1260 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1261 * tests/acl: Add `$0: ' prefix to diagnostics.
1263 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1265 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1267 * src/copy.c: Improve performance a bit by optimizing away
1268 unnecessary system calls and going to a block size of at least
1269 8192 (on normal hosts, anyway). This improved performance 5% on my
1270 Debian stable host (2.4.27 kernel, x86, copying from root
1271 ext3 file system to itself).
1272 Include "buffer-lcm.h".
1273 (copy_reg): Omit last argument. All callers changed.
1274 Use xmalloc to allocate rather than trusting alloca
1275 (which is unwise with large block sizes).
1276 Declare locals more locally, if possible.
1277 Use uintptr_t words instead of int words, for a bit more speed
1278 when looking for null blocks on 64-bit hosts.
1279 Optimize away reads of zero bytes on regular files.
1280 In the typical case, insist on 8 KiB buffers, at least.
1281 Avoid unnecessary extra call to fstat when checking for sparse files.
1282 Avoid now-unnecessary cast to off_t, and "0L".
1283 Avoid unnecessary test of *new_dst when checking for same owner
1286 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1288 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1290 2005-11-22 Jim Meyering <jim@meyering.net>
1292 * src/remove.c (AD_push): Remove debugging cruft.
1294 * tests/rm/unread2 (rm): Change expected diagnostic,
1295 `cannot open directory' to `cannot remove', to align with
1297 * tests/rm/rm2: Ensure that rm now continues removing entries
1298 even after certain types of failure.
1300 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1301 that provide openat (Solaris), and on systems like Linux+procfs
1302 where our openat emulation code is reentrant. This also fixes a
1303 few low-probability leaks and eliminates some code that could,
1304 in very unusual circumstances, cause rm() (via a callee) to exit.
1305 * NEWS: Mention this.
1307 * configure.ac: Put copyright dates all on one line so the
1308 emacs function that updates them works properly.
1310 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1312 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1313 Problem reported by Eric Blake.
1314 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1315 we get a standard-conforming compiler. This relies on the new
1316 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1317 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1318 m4/c.m4 can go away with Autoconf 2.60 comes out.
1320 2005-11-17 Jim Meyering <jim@meyering.net>
1322 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1323 (AD_mark_current_as_unremovable): Likewise, but for a local.
1326 * tests/mv/acl: Let traps handle removing temporary directories.
1328 Expect acl-related tests to fail, until the corresponding
1329 patches are committed.
1330 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1331 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1333 ACL tests, from Andreas Gruenbacher.
1334 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1335 * tests/mv/Makefile.am (TESTS): Add acl.
1336 * tests/cp/Makefile.am (TESTS): Add acl.
1338 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1340 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1342 * NEWS: Improve quality of ln's diagnostics.
1343 * src/ln.c (do_link, usage): Likewise.
1344 (do_link): Don't use alloca on a buffer of unbounded size.
1346 2005-11-16 Jim Meyering <jim@meyering.net>
1348 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1349 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1350 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1351 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1352 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1354 2005-11-14 Jim Meyering <jim@meyering.net>
1356 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1358 2005-11-13 Jim Meyering <jim@meyering.net>
1360 * announce-gen: Accept new option, --gpg-key-id=ID and
1361 emit a blurb telling how to use the .sig files.
1362 * Makefile.cfg (gpg_key_ID): Define.
1363 * Makefile.maint (announcement): Use new option and key.
1365 Require that most .c files include <config.h>.
1366 * Makefile.maint (sc_require_config_h): New rule.
1367 (syntax-check-rules): Add it.
1368 * .x-sc_require_config_h: New file listing exceptions to the
1369 above rule. Some are legit, others are simply grandfathered in.
1370 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1372 2005-11-12 Jim Meyering <jim@meyering.net>
1374 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1376 2005-11-11 Jim Meyering <jim@meyering.net>
1378 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1379 Mention new readlink options in 5.3.0's `New features' section.
1380 Spotted by Thomas Hood.
1382 2005-11-08 Jim Meyering <jim@meyering.net>
1384 * NEWS: Merge in changes from b5_9x branch.
1386 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1388 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1389 like --time-style='posix-long-iso' if the locale settings are messed up.
1390 * src/ls.c (decode_switches): Implement this.
1392 2005-11-08 Jim Meyering <jim@meyering.net>
1394 * tests/du/2g: s/expensive/very expensive/ in a comment.
1397 2005-10-17 Eric Blake <ebb9@byu.net>
1399 * src/ls.c (usage): Fix descriptions of --sort, --time.
1400 Reported by Vitaly A. Ostanin.
1402 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1404 * src/ln.c: Include filenamecat.c.
1405 (FILE_BASENAME_CONCAT): Remove.
1406 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1407 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1408 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1411 2005-11-04 Jim Meyering <jim@meyering.net>
1413 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1414 on systems with stat.st_blocks of a signed 32-bit type.
1415 This bug causes trouble on some AIX 5.1 systems.
1416 Report and trivial patch from Paul Townsend:
1417 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1418 * NEWS: Mention this.
1420 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1421 * tests/du/Makefile.am (TESTS): Add it here.
1422 * tests/very-expensive: New file.
1423 * tests/Makefile.am (EXTRA_DIST): Add it here.
1424 * tests/cp/perm: Mark this test as `very-expensive', too.
1426 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1428 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1430 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1432 * src/rm.c (usage): Don't mention rm -d.
1434 2005-11-02 Jim Meyering <jim@meyering.net>
1436 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1437 From Andreas Schwab.
1439 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1440 `M+N records in/out' lines don't pollute `make check' output.
1442 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1443 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1444 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1445 to indicate that the input file should be piped into the command
1446 under test (via `cat FILE | $prog ...').
1448 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1449 (without -r) fails to remove a directory on a non-Linux system.
1450 This change affects only newer Solaris systems (with priv_*
1451 functions like priv_allocset). Reported by Keith Thompson.
1453 * tests/rm/dir-nonrecur: New file/test for the above fix.
1454 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1456 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1458 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1459 POSIX 1002.1-2001 requires.
1460 * src/tail.c (parse_obsolete_option): Implement this.
1461 Problem reported by Vincent Lefevre.
1462 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1463 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1464 (test_vector): Add special cases for _POSIX2_VERSION, and
1465 regularize the old ones a bit.
1466 * tests/touch/obsolescent: Add y2000 test.
1468 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1470 * src/dd.c (skip): Fix off-by-one error reported by
1471 Theodoros V. Kalamatianos.
1473 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1475 * tests/mkdir/p-3: Require that the test be run as non-root.
1476 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1478 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1480 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1481 boundary between DEST and SOURCE in the result.
1483 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1485 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1486 back to text, to sync with documentation and for backwards
1489 2005-10-25 Jim Meyering <jim@meyering.net>
1491 * tests/dircolors/simple (other-wr): Add an explicit test for
1492 the dircolors bug (NULL-dereference) fixed yesterday.
1494 2005-10-24 Jim Meyering <jim@meyering.net>
1496 * src/tac.c (tac_file): When determining whether a file is seekable,
1497 also test whether it is a tty. Using only the lseek-based test would
1498 give a false positive on Solaris. Reported by Peter Fales.
1500 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1502 * tests/install/d-slashdot: New test, for "install -d" failure.
1503 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1504 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1505 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1507 2005-10-24 Jim Meyering <jim@meyering.net>
1509 * src/dircolors.c (ls_codes): Add missing comma.
1510 Anonymous report and patch from
1511 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1513 * src/dircolors.c: Add compile-time assertion that the slack_codes
1514 and ls_codes arrays have the same number of elements. This would
1515 have prevented the above-fixed bug.
1517 * src/expand.c (parse_tab_stops): Add a comment to make this function
1518 identical to the one in unexpand.c.
1519 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1520 identical to the one in expand.c.
1522 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1524 2005-10-23 Jim Meyering <jim@meyering.net>
1526 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1527 a dangerous pointer-value-to-`unsigned' cast.
1528 * NEWS: mention the new sha* programs.
1529 * AUTHORS: Add new sha* programs.
1531 2005-08-28 David Madore <david.madore@ens.fr>
1533 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1534 * README: Add their names to the list.
1535 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1536 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1537 Rules for compiling sha-2 utilities
1538 (noinst_HEADERS): Remove checksum.h.
1539 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1541 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1542 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1543 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1544 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1545 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1546 sha384sum, sha512sum test scripts here rather that each in its
1549 2005-08-28 David Madore <david.madore@ens.fr>
1551 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1552 of the FIPS test vectors).
1554 2005-10-23 Jim Meyering <jim@meyering.net>
1556 * configure.ac: Use 6.0-cvs as the version string.
1557 * NEWS: Adjust accordingly.