1 2006-07-25 Jim Meyering <jim@meyering.net>
3 * src/ls.c: Add parens around the new uses of ?: ternary operator.
5 * src/dircolors.hin: Mention that ORPHAN refers not just to dangling
8 Get --dired offsets right when handling stat-failed entries.
9 * src/ls.c (print_long_format): Be careful to increment P by the
10 appropriate amount, even when inode_number_width and nlink_width
12 * tests/ls/stat-failed: Test for the above.
14 * src/ls.c (gobble_file) [USE_ACL]: Don't use-uninitialized the
15 have_acl member. That would happen for a directory with both a
16 non-stat'able entry and one with an ACL.
18 * src/ls.c (gobble_file): Make it so failure to stat a
19 non-command-line file provokes an exit status of 1, not 0.
20 Say "cannot access" rather than "cannot stat".
21 * tests/ls/stat-failed: New file/test, for the above.
22 * tests/ls/Makefile.am (TESTS): Add stat-failed.
23 * tests/ls-2/tests (no-a-isdir-b): Update to reflect addition
24 of "cannot access " to diagnostic.
26 * src/ls.c: Declare stat_failed to be "bool", not "int" everywhere.
28 * src/ls.c [enum filetype] (command_line): Remove member. Not needed.
29 Replace all occurrences of "type == command_line" with the
30 equivalent, "command_line_arg".
32 * src/ls.c: Apply the stat-failed parts of Red Hat's
33 coreutils-selinux.patch. From Ulrich Drepper.
34 This makes it so files not mentioned on the command line (e.g.,
35 names read from a directory that *is* mentioned on the command
36 line) for which stat fails are still listed. With --color,
37 such files are colored just like ORPHANs (aka dangling symlinks).
39 * src/df.c (n_valid_args): Declare global to be static.
41 2006-07-24 Jim Meyering <jim@meyering.net>
43 * tests/ls/stat-dtype: Skip this test on reiserfs, since that file
44 system lacks d_type support.
46 2006-07-22 Paul Eggert <eggert@cs.ucla.edu>
48 * man/chmod.x: Update to reflect recent changes to coreutils.texi.
50 2006-07-21 Jim Meyering <jim@meyering.net>
52 * src/su.c (usage): Correct typo in --help output: s/commmand/command/
53 Reported by Tim Waugh.
54 Also remove the comment duplicating much of --help output.
56 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): Reposition this new
57 name so the list remains alphabetized.
59 Fix another bug: ls --indicator-style=file-type would call
60 stat for a symlink, even though it wasn't always needed.
61 In some cases, that unnecessary stat would cause ls to fail.
62 * src/ls.c (gobble_file): Don't treat symlinks specially (in
63 requiring a stat syscall). Remove the offending exclusion.
65 * NEWS: Mention the fix.
67 * tests/ls/stat-dtype: New file/test, for the above fix.
68 Also exercises the new df feature, below.
70 * src/df.c (main): Fail and don't print the headers if no
71 file system is processed. This makes it easy to test whether
72 a specified directory is on a file system of a given type or types.
73 Otherwise, applications would have had to parse df's output.
74 E.g., is "." either ext3 or reiserfs: df -t ext3 -t reiserfs .
76 Fix a bug: ls --file-type worked like --indicator-style=slash,
77 rather than like --indicator-style=file-type.
78 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): New enum member.
79 (long_options): Map "file-type" to FILE_TYPE_INDICATOR_OPTION,
81 (decode_switches): Handle new case: FILE_TYPE_INDICATOR_OPTION.
82 * NEWS: Mention the fix.
83 * tests/ls-2/tests (file-type): New test, for the above fix.
85 2006-07-19 Jim Meyering <jim@meyering.net>
87 * src/ls.c (print_dir): Give a better diagnostic for failed opendir.
89 * Makefile.am (EXTRA_DIST): Add build-aux/vc-list-files.
91 2006-07-16 Paul Eggert <eggert@cs.ucla.edu>
93 * NEWS: chmod, install, and mkdir now leave setgid and setuid bits
94 of directories alone unless you specify them explicitly.
95 install and mkdir now implement X correctly.
96 install now creates parent directories with mode 755, without
97 changing their owner or group.
98 * src/chmod.c (process_file): Adjust to mode_adjust API change.
99 * src/install.c: Include mkancesdirs.h.
100 (announce_mkdir, make_ancestor): New functions.
101 (DEFAULT_MODE): New macro, specifying initial value of 'mode'.
103 (dir_mode, dir_mode_bits): New vars.
104 (main): Set dir modes separately from nondir, so that the X
105 op of -m works correctly.
106 (main): Remove cwd_errno cruft, since make_dir_parents no longer
107 affects cwd. Adjust to new make_dir_parents API.
108 (install_file_in_file_parents): 2nd arg is now char *, not char
109 const *. Use mkancesdirs instead of rolling our own code.
110 (change_attributes): Don't worry about AFS, since that kludge
111 should not be needed any more.
112 * src/mkdir.c (struct mkdir_options): New struct.
113 (announce_mkdir, make_ancestor): New functions.
114 (main): Use them. Adjust to mode_adjust API change. Stick with
115 umask 0. Use make_dir_parents for all the work.
116 * src/mkfifo.c (main): Adjust to new mode_adjust API.
117 * src/mknod.c (main): Likewise.
118 * tests/chmod/setgid: Do the setgid test instead of bailing.
119 * tests/mkdir/p-3: Remove re_protect case that no longer applies.
120 GNU chmod now behaves like other versions of chmod.
121 * tests/mkdir/perm: Add a test for the X bug.
123 2006-07-14 Paul Eggert <eggert@cs.ucla.edu>
125 * src/base64.c (do_decode): Output to parameter OUT, not to stdout.
126 This doesn't fix any bugs, since OUT always equals stdout, but it
127 makes the code easier to understand.
129 2006-07-14 Jim Meyering <jim@meyering.net>
131 * Makefile.maint (CVS_LIST): Use new file, build-aux/vc-list-files,
132 rather than open-coding it. Now supports mercurial, too.
133 * .hgignore: New file.
134 * Makefile.am (EXTRA_DIST): Add .hgignore, which ignores nearly
135 all generated files, including ones like configure and po/*.po
136 that are currently version-controlled in cvs.
138 * Makefile.am (EXTRA_DIST): Add a few more .??* files.
139 They've been in CVS, just haven't been distributed before this.
140 Distribute ChangeLog-2005, too.
141 (MAINTAINERCLEANFILES): Add THANKS-to-translators.
143 2006-07-11 Paul Eggert <eggert@cs.ucla.edu>
145 * src/system.h: Assume <dirent.h> exists, since gnulib assumes
148 2006-07-09 Jim Meyering <jim@meyering.net>
150 * tests/mv/dir2dir: Adjust so failing with ENOTEMPTY is ok, too.
151 That happens with Linux/tmpfs.
152 * tests/mv/Makefile.am (TESTS): Add dir2dir.
154 2006-07-09 Paul Eggert <eggert@cs.ucla.edu>
156 Adjust to recent updates from gnulib.
157 * src/dd.c (apply_translations): Use toupper rather than
158 islower followed by toupper; it's simpler and typically
159 faster now that we assume at least C89 semantics. Similarly
161 * src/sort.c (inittables): Likewise.
162 * src/expand.c (expand): Don't assume that isprint etc. return
163 booleans (needed for pre-C99 hosts).
164 * src/fmt.c (check_punctuation): Likewise.
165 * src/ptx.c (initialize_regex, fix_output_parameters): Likewise.
166 * src/tr.c (is_char_class_member): Likewise.
167 * src/unexpand.c (unexpand): Likewise.
168 * src/join.c (is_blank): Remove; no longer needed. All uses
169 replaced by isblank (to_uchar (...)).
170 * src/pinky.c (create_fullname): Don't assume char is unsigned.
171 * src/printf.c (print_esc): Likewise.
172 * src/ptx.c (SKIP_NON_WHITE, SKIP_WHITE, SKIP_WHITE_BACKWARDS):
173 (copy_unescaped_string): Likewise.
174 * src/stat.c (print_it): Likewise.
175 * src/system.h (_D_EXACT_NAMELEN): Renamed from NLENGTH, for
176 convenience on GNU systems. All uses changed. Don't bother
177 looking for any dirent.h substitute other than ndir.h.
178 (D_INO): Remove unnecessary parentheses.
179 (IN_CTYPE_DOMAIN, ISGRAPH, ISPRINT, ISALNUM, ISALPHA):
180 (ISCNTRL, ISLOWER, ISPUNCT, ISSPACE, ISUPPER, ISXDIGIT):
181 (ISDIGIT_LOCALE, TOLOWER, TOUPPER): Remove. All uses changed
182 to ctype.h equivalents.
183 (isblank): Renamed from ISBLANK. Check for HAVE_DECL_ISBLANK too.
186 2006-07-08 Jim Meyering <jim@meyering.net>
188 * tests/mv/dir2dir: New file, test for 2006-07-05 fix in copy.c.
190 * Makefile.maint (sc_the_the): New rule.
192 * src/dd.c (skip): Remove one of two adjacent "the"s in a comment.
193 * tests/Coreutils.pm (run_tests): Remove one of two adjacent "then"s
196 2006-07-07 Jim Meyering <jim@meyering.net>
198 * NEWS: Mention that mv can now remove an empty destination directory,
199 and give an example. Prompted by a report from Florent Bayle.
201 2006-07-05 Jim Meyering <jim@meyering.net>
203 * src/ls.c (usage): Correct the description of -G: it is useful
204 only in a long listing. Reported by Martin Pool in
205 <https://launchpad.net/distros/ubuntu/+source/coreutils/+bug/51653>.
207 * man/chmod.x: Correct the description of the sticky bit. Reported
208 by Chris Moore via Ian Jackson in <http://bugs.debian.org/376745>.
210 * src/copy.c (copy_internal): Don't work around old NFS clients like
211 SunOS-4.1.4 and Irix 5.3 that set errno to values like EIO and
212 ENOTEMPTY upon failed rename. Otherwise, we risk misinterpreting
213 a banal failure as a recursive move-into-self failure.
214 Reported by Florent Bayle in <http://bugs.debian.org/376749>.
216 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
218 2006-07-03 Jim Meyering <jim@meyering.net>
220 Plug another unusual leak.
221 (AD_mark_helper): Free malloc'd filename if hash_insert says
222 that string is already in the hash table.
224 The dev/inode of the topmost directory in each hierarchy were not
226 * src/remove.c (remove_cwd_entries): Don't call cycle_check here.
227 (AD_push): Call it from here instead.
230 * src/remove.c (AD_stack_clear): New function.
232 (AD_pop_and_chdir): Free *prev_dir just before longjmp.
234 * tests/Makefile.am, tests/*/Makefile.am: (TESTS_ENVIRONMENT):
235 Add $VG_PATH_PREFIX as a prefix to $PATH
237 * tests/envvar-check (vars): Add CDPATH and POSIXLY_CORRECT.
238 * tests/Makefile.am (evar-check): Remove rule.
239 (EXTRA_DIST): Remove .env-warn.
240 * tests/.env-warn: Remove file. No longer used.
241 Suggestion from Eric Blake.
243 2006-07-02 Paul Eggert <eggert@cs.ucla.edu>
245 * src/system.h: Include <stdint.h> unconditionally, since we
246 now assume the stdint module.
248 2006-07-01 Paul Eggert <eggert@cs.ucla.edu>
250 * NEWS: With no operand, 'tail -f' now silently ignores the '-f'
251 only if standard input is a FIFO or pipe and POSIXLY_CORRECT is set.
252 * src/tail.c (main): Implement this.
253 * tests/tail/Test.pm (f-pipe-1): Renamed from f-1.
254 (test_vector): Set POSIXLY_CORRECT for the f-pipe-* tests.
256 2006-07-01 Jim Meyering <jim@meyering.net>
258 * src/ln.c (do_link): Use new, shorter URL, for ag-review link.
260 * .x-sc_require_config_h: Add ^lib/xstrtold\.c$, so make distcheck
263 2006-06-30 Paul Eggert <eggert@cs.ucla.edu>
265 * NEWS: seq now uses long double internally rather than double.
266 It now defaults to a minimal fixed point format if possible.
267 It lets you use %a, %A, %E, %F, %G.
268 * src/Makefile.am (seq_LDADD): Remove $(SEQ_LIBM); add $(POW_LIB).
269 * src/seq.c: Don't include <math.h> or <xstrtol.h>; no longer needed.
270 (isfinite) [!defined isfinite]: New macro.
271 (separator, terminator): Now points to const.
272 (first, step, last): Remove.
273 (usage): Update to match new behavior.
274 (struct operand, operand): New type.
275 (scan_arg): Renamed from scan_double_arg, since we no longer use double.
277 Compute and return a value of type operand, not double.
278 (long_double_format): Renamed from valid_format, and now returns a
279 new format with an "L" added if needed, if the original format was
280 valid. Allow %a, %A, %E, %F, and %G formats.
281 (print_numbers): Take numeric values as args rather than from globals.
282 Print long double, not double.
283 (get_width_format): Remove.
284 (get_default_format): New function.
285 (main): Implement new way of calculating default format.
286 Don't worry about locale's representation of the decimal point, since
287 the arguments are always processed in the C locale.
288 * tests/seq/basic (neg-2): Adjust to new default format.
289 (eq-wid-1, eq-wid-2): Resurrect these tests, since the new
290 implementation should do the right thing.
292 2006-06-30 Jim Meyering <jim@meyering.net>
294 * tests/stty/basic-1: Work around an intermittent test failure
295 on HP-UX 11.11. Report and analysis from Bob Proulx.
296 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7475
298 2006-06-28 Paul Eggert <eggert@cs.ucla.edu>
300 * NEWS: Support obsolete usages like "sort +1 -2" even when
301 conforming to POSIX 1003.1-2001, since this is a pure extension to
302 POSIX. Problem reported by Christian in:
303 http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00220.html
304 * src/sort.c (main): Implement this.
306 * src/system.h (CLOSEDIR): Remove. All uses changed to closedir.
307 Autoconf 2.60 says this stuff was obsolete.
309 2006-06-28 Jim Meyering <jim@meyering.net>
311 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
313 2006-06-28 Bob Proulx <bob@proulx.com> (tiny change)
315 * tests/mv/i-link-no: Work around HP-UX /bin/sh tracing problem
316 (set -x when VERBOSE=yes) when stderr is redirected before stdout
317 causing shell tracing of the stdout redirection to be written to
318 the stderr file. Avoid problem and test failure on HP-UX by
319 redirecting stderr last.
320 * tests/dd/unblock-sync: Order shell file redirections for
321 stderr and stdout in the common style.
324 2006-06-27 Jim Meyering <jim@meyering.net>
326 * tests/misc/cat-proc: Try to avoid any spurious numeric
327 differences in frequently-changing /proc/cpuinfo.
328 Reported by Nelson Beebe.
330 2006-06-26 Jim Meyering <jim@meyering.net>
332 Attempt rmdir (actually, unlinkat-with-AT_REMOVEDIR) upon any
333 fd_to_subdirp failure, not just when errno == EACCES.
334 * src/remove.c (remove_dir): Use unlinkat-with-AT_REMOVEDIR, not
335 rmdir, here, even though rmdir may happen to be adequate.
337 * NEWS: rm no longer fails to remove an empty, unreadable directory
338 * src/remove.c (remove_cwd_entries): If we can't open a directory,
339 and the failure is not being ignored, try to remove the directory
340 with rmdir (aka unlinkat-with-AT_REMOVEDIR), in case it's empty.
341 Problem report and test case from Paul Eggert in
342 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7425>.
344 * tests/rm/empty-inacc: New test, for the above.
346 Avoid a segfault for wc --files0=- < /dev/null.
347 * src/wc.c (compute_number_width): Return right away if nfiles == 0.
349 2006-06-25 Jim Meyering <jim@meyering.net>
351 * NEWS: wc accepts a new option --files0-from=FILE, where FILE
352 contains a list of NUL-separated file names.
354 * src/wc.c: Include "readtokens.h".
355 (usage): Describe the new option, and adjust the `Usage':
356 with this option, no FILE may be specified on the command line.
357 (main): Handle the new option.
358 * tests/misc/wc-files0: New tests, for the above.
359 * tests/misc/wc-files0-from: Likewise.
360 * tests/misc/Makefile.am (TESTS): Add wc-files0.
362 2006-06-24 Jim Meyering <jim@meyering.net>
364 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
366 2006-06-22 Jim Meyering <jim@meyering.net>
368 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
369 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
371 2006-06-19 Jim Meyering <jim@meyering.net>
373 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
374 so this check is not run as part of "make distcheck".
376 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
378 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
380 2006-06-18 Jim Meyering <jim@meyering.net>
382 * tests/misc/pwd-long: Make error output a little clearer.
384 2006-06-17 Jim Meyering <jim@meyering.net>
386 * tests/rm/inaccessible: Skip this test on systems without openat
387 support. Reported by Bob Proulx.
389 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
391 * tests/misc/mknod: Improve permission checks to handle
392 running mkdir test in set-gid directories.
394 2006-06-14 Jim Meyering <jim@meyering.net>
396 * tests/du/basic: Revamp not to hard-code file system block sizes.
398 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
400 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
403 2006-06-11 Jim Meyering <jim@meyering.net>
405 * .gitignore: New file.
406 * Makefile.am (EXTRA_DIST): Add .gitignore.
408 Setting TIME_STYLE=long-iso in the environment would make the
409 cp/same-file test fail.
410 * tests/envvar-check (vars): Add TIME_STYLE to the list.
411 * tests/cp/same-file: Revert last change.
412 Source the envvar-check script, to ensure that TIME_STYLE
413 settings don't affect these tests.
415 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
417 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
418 uses POSIX time stamp formats. Problem reported by John Nixon in
419 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
421 2006-06-10 Jim Meyering <jim@meyering.net>
423 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
425 Require a "Version N.M" line at the top of the ChangeLog
426 file only when making the actual release, not when running
428 * Makefile.maint (maintainer-distcheck): Don't depend on
430 (alpha beta major): Depend on it here, instead.
432 2006-06-08 Jim Meyering <jim@meyering.net>
434 Ensure that cat works with any of the options, -A -v -e -E -T,
435 when applied to files in /proc and /sys, even when the FIONREAD
436 ioctl produces nonsensical results. Before this change, cat would
437 produce no output (or truncated output), for some linux kernels.
439 * src/cat.c (write_pending): New function, factored out of cat.
440 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
441 that there are bytes to read. Some versions of linux-2.6.16 do that.
442 Write any pending output before returning.
443 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
444 * NEWS: Mention this bug fix.
445 * tests/misc/cat-proc: New file. Test for the above.
446 * tests/misc/Makefile.am (TESTS): Add cat-proc.
448 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
450 * src/expr.c (eval4): Detect overflow properly when multiplying
453 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
455 * NEWS: The 'expr' command now detects and reports integer overflow.
456 (It would be better to use extended precision instead, but that
458 * src/expr.c (integer_overflow): New function.
459 (eval4, eval3): Check for integer overflow.
461 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
463 Fix problems when building with Solaris/SVR4/etc. make, which uses a
464 different and somewhat bogus implementation of VPATH. In the
465 directory tests/misc, rename tests whose names might appear in the
466 Automake-generated rules. For example, we can't use a test named
467 'test', since Automake generates a rule that contains the text
468 "if test -f ./$$tst; ...", and this might expand to something like
469 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
470 which executes the 'test' script rather than the 'test' command.
471 * tests/misc/false-status: Renamed from tests/misc/false.
472 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
473 * tests/misc/sort-merge: Renamed from tests/misc/sort.
474 ($prog): Set to 'sort' rather than to $PROG.
475 * tests/misc/test-diag: Renamed from tests/misc/test.
476 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
477 in case Solaris make has prepended the directory.
478 (TESTS): Adjust to above renamings.
479 * tests/misc/expand: Don't assign to PROG; no longer needed
480 now that Makefile.am sets PROG to the basename.
481 * tests/misc/fold: Likewise.
483 2006-06-03 Jim Meyering <jim@meyering.net>
485 Make `cp --link --no-dereference' work also on systems where the
486 link system call cannot create a hard link to a symbolic link.
487 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
488 the link syscall on a symlink when it would do the wrong thing.
489 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
490 * tests/cp/link-no-deref: New file/test for the above.
491 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
492 * NEWS: Mention the change (doesn't affect Linux).
494 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
496 Fix some porting problems in the test cases reported by
497 Ralf Wildenhues for HP-UX 11.23 in:
498 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
499 * tests/help-version: Don't assume that \< \> works in sed.
500 * tests/misc/close-stdout: Don't assume that >&- works.
501 Add a /dev/full test.
502 * tests/touch/no-create-missing: Don't assume that >&- works.
504 2006-05-30 Jim Meyering <jim@meyering.net>
506 * src/ls.c (usage): Add `v' to the list of sorting-related options.
509 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
511 * tests/cp/fail-perm: source lang-default.
512 * tests/rm/inaccessible: Likewise.
514 2006-05-28 Jim Meyering <jim@meyering.net>
516 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
517 Recognize it, too. Reported by Ralf Wildenhues, in
518 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
520 2006-05-27 Jim Meyering <jim@meyering.net>
522 * src/chgrp.c: Support new options: --preserve-root and
523 --no-preserve-root. Somehow this program was skipped when those
524 options were added to chown, chmod, and rm. Reported by
525 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
526 * NEWS: Mention this.
528 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
530 * NEWS: Remove mention of --seed. We'll replace it with something
531 better, and don't want to indicate that it is supported.
532 * src/sort.c (usage): Likewise.
534 2006-05-20 Jim Meyering <jim@meyering.net>
536 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
538 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
539 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
540 FTS_COMFOLLOW. Spotted by Justin Pryzby.
542 * gnupload: Merge changes from automake, retaining the ""--to...
543 kludge to placate overzealous `make distcheck' check.
545 2006-05-19 Jim Meyering <jim@meyering.net>
547 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
548 FTS_TIGHT_CYCLE_CHECK directory traversal option.
549 Reported by Justin Pryzby in http://bugs.debian.org/367691
551 2006-05-15 Jim Meyering <jim@meyering.net>
553 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
556 2006-05-13 Jim Meyering <jim@meyering.net>
558 * tests/mv/no-target-dir: Test two more cases.
560 2006-05-11 Jim Meyering <jim@meyering.net>
562 mv -T DIR EMPTY_DIR no longer fails unconditionally
563 * src/copy.c (copy_internal): Don't manually prohibit a move where
564 the destination is an existing directory. Sometimes doing that is
565 valid. Let the rename system call enforce the rules. That is
566 allowed only when the source is a directory and the destination
567 directory (to be replaced) is empty. Reported by Eric Blake.
568 * tests/mv/no-target-dir: New file/test for this.
569 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
570 * NEWS: Mention this.
572 * tests/mv/atomic: New file/test for yesterday's fix.
573 * tests/mv/Makefile.am (TESTS): Add atomic.
575 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
577 2006-05-10 Jim Meyering <jim@meyering.net>
579 * src/copy.c (copy_internal): Don't explicitly unlink the destination
580 when moving a symlink into the place of an existing non-directory.
581 Reported by Joshua Hudson.
582 * NEWS: mention this.
584 2006-05-07 Jim Meyering <jim@meyering.net>
586 * Makefile.maint (patch-check): Fail if patch generates any output,
587 even merely for changed offsets.
589 * src/c99-to-c89.diff: Adjust to reflect new offsets.
591 * NEWS: Mention changes affecting df, pwd, shred.
593 2006-05-06 Jim Meyering <jim@meyering.net>
595 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
596 system condition where dirent.d_ino != stat.st_ino.
597 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
599 2006-05-06 Eric Blake <ebb9@byu.net>
601 * tests/ls/inode: Expand to test inode from readdir case.
602 * tests/ls/follow-slink: Expand to test broken links encountered
603 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
605 2006-05-06 Eric Blake <ebb9@byu.net>
607 * tests/mv/leak-fd: Work even on case-insensitive file system.
609 2006-05-04 Jim Meyering <jim@meyering.net>
611 * NEWS: Mention the 2006-03-19 pwd-related change that makes
612 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
614 2006-05-03 Jim Meyering <jim@meyering.net>
616 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
617 Use better macro parameter names: s/basename/key_name/,
618 s/basefunc/key_cmp_func. Fix typo in comment.
620 2006-04-29 Eric Blake <ebb9@byu.net>
622 * src/ls.c (main): On systems with d_type, directories_first only
623 implies format_needs_type, not format_needs_stat.
625 2006-05-03 Jim Meyering <jim@meyering.net>
627 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
628 after comma in arg list, from Eric Blake.
630 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
632 * tests/misc/date (relative-3): New test, derived from a bug
633 report by John Thomas McDole.
635 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
637 New option for ls: --group-directories-first.
638 It makes ls list directories before files.
639 * NEWS [New features]: Mention it.
640 * src/ls.c (sort_type): Rearrange to use as an array index when
641 choosing sort function; added new sort_numtypes member for
643 (time_type): Add new time_numtypes member for compile-time check.
644 (directories_first): New global variable.
645 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
646 (long_options): Add --directories-first.
647 (main): Support new option.
648 (is_directory): New function.
649 (extract_dirs_from_files): Use it.
650 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
651 (LIST_SORTFUNCTION_VARIANTS): New macros.
652 (sort_functions): New global variable.
653 (sort_files): Use it.
654 (usage): Document new option.
656 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
658 * src/shred.c (fillrand): The assertion was way too weak, due to
659 what must be a typo. Strengthen it to its intended value.
660 (dopass): Don't use alloca; it's not worth the aggravation here,
661 since it's used only to get a page-aligned buffer, and page
662 alignment doesn't buy us much here. I'm suspicious that alloca
663 causes problems on some hosts, due to a recent bug report by Adam
664 Waltman: http://bugs.gentoo.org/130246.
666 2006-04-18 Jim Meyering <jim@meyering.net>
668 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
669 sha384sum, sha512sum.
671 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
673 * src/chmod.c (describe_change): Adjust to filemode changes.
674 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
675 (print_long_format): Use (new) filemodestring rather than
676 (old) mode_string, so that we get more file types right, at least
677 in theory. Adjust to filemode changes.
678 * src/stat.c (human_access): Likewise.
680 2006-04-18 Jim Meyering <jim@meyering.net>
682 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
683 ignore file. This has never been enabled. Reported by Eric Blake.
685 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
687 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
688 bug in Interix. Just call symlink or link directly. All uses changed.
689 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
690 * src/stat.c (USE_STATVFS): New macro.
691 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
692 (NAMEMAX_FORMAT): define a bit more clearly, now that the
693 statvfs-using code is a bit more regular.
694 * src/system.h (sync) [!HAVE_SYNC]: New macro.
696 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
698 * NEWS: csplit, nl, expr now conform to POSIX better, and are
699 more-compatible with traditional Unix, with respect to regular
701 * src/csplit.c (extract_regexp): Set re_syntax_options to a
702 value that is compatible with what POSIX requires.
703 * src/nl.c (build_type_arg): Likewise.
704 * src/expr.c (docolon): Likewise. Also, don't let anchors match
705 newline; this fixes an incompatibility with tradition and with POSIX.
706 Don't warn about leading ^. POSIX says it is unspecified whether
707 ^ is a special character, which means that implementations can
708 either treat it as special or not, but either way a warning is not
709 allowed (unless the regexp is otherwise invalid). Instead, anchor
710 the expression but treat ^ as an anchor; this is the traditional
711 behavior (e.g., Solaris 10).
712 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
713 and the like as invalid expressions (exit status 2), not as
714 failure of 'expr' (exit status 3). This is more consistent with
716 * tests/expr/basic (fail-a): Adjust exit status to match new expr
717 behavior, for status 2 versus 3.
719 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
720 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
721 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
722 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
723 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
724 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
725 (bre61, bre62): New tests.
726 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
730 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
731 "if !". Do not assume that 'sed' can handle long, newline-free input.
732 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
734 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
736 Adjust to new regex.h API (with new fastmap type), and clean
737 up the regex storage allocation a bit.
739 * src/csplit.c (struct control): Put re_compiled member at the
740 end, since it's large. Change regexpr member from char * to bool;
741 all uses changed. Add new member fastmap.
742 (extract_regexp): regexp arg is now char const *, not char *.
743 Don't bother duplicating the regular expression; it's not needed.
744 Set fastmap from new fastmap member. Don't bother allocating
745 a buffer, as the regexp code does a better job than we do.
746 * src/expr.c (docolon): Allocate and use a fastmap.
747 Don't bother allocating a buffer.
748 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
750 (build_type_arg): New fastmap arg. All uses changed.
751 Don't bother allocating a buffer, but set a fastmap.
752 * src/ptx.c (context_regex_string, word_regex_string): Remove.
753 (context_regex, word_regex): New vars, replacing the above.
755 (struct regex_data): New type.
756 (compile_regex): Renamed from alloc_and_compile_regex, since
757 we no longer allocate storage. Arg is now a struct regex_data *,
758 not a const char *. All uses changed. Don't allocate the fastmap;
759 instead, take it from the caller. Don't convert size_t to int,
760 to avoid arithmetic overflow problems. Don't bother freeing
761 storage afterwards; it's not worth the aggravation.
762 * src/tac.c (compiled_separator_fastmap): New ver.
763 (main): Use it. Don't bother allocating a buffer.
765 2006-03-30 Jim Meyering <jim@meyering.net>
767 * src/dd.c (iwrite): Remove assignment without effect.
768 Reported by Felix Rauch Valenti.
770 2006-03-22 Eric Blake <ebb9@byu.net>
772 * src/ptx.c (usage): Remove mention of --copyright/-C.
773 (main): Alias --copyright to --version plus a deprecation warning.
774 * NEWS: Mention this.
776 2006-03-27 Jim Meyering <jim@meyering.net>
778 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
779 use of strtod. Tiny patch from Nickolai Zeldovich.
781 2006-03-11 Eric Blake <ebb9@byu.net>
783 * tests/misc/dirname: New file.
784 * tests/basename/Makefile.am: Delete.
785 * tests/basename/basic: Move to...
786 * tests/misc/basename: ... this new file. Add some tests,
787 including fixed behavior for //.
788 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
789 * tests/Makefile.am (SUBDIRS): Remove basename.
790 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
792 Improvements to dirname/basename handling on platforms like
793 cygwin with distinct // and with drive letters.
794 * NEWS: Document new behavior.
795 * src/basename.c (main): Don't strip suffix from file system
797 * src/cp.c (target_directory_operand): Use new last_component.
798 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
799 traversing the string.
800 * src/dircolors.c (guess_shell_syntax): Use new last_component.
801 * src/install.c (target_directory_operand, install_file_in_dir):
803 * src/ln.c (target_directory_operand, main): Likewise.
804 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
805 * src/mv.c (target_directory_operand, movefile): Likewise.
806 * src/remove.c (rm_1): Likewise.
807 * src/shred.c (wipename): Likewise.
808 * src/split.c (next_file_name): Likewise.
809 * src/su.c (log_su, run_shell): Likewise.
811 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
813 * NEWS: nohup diagnostics are now more precise, and nohup now
814 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
815 * src/nohup.c (main): Implement this.
816 * tests/misc/nohup: Test the new behavior.
818 2006-03-12 Jim Meyering <jim@meyering.net>
820 * src/copy.c (set_author): Rename function, from preserve_author.
822 * src/remove.c (AD_pop_and_chdir): Use new macro,
823 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
825 * src/system.h (SAME_INODE): Remove definition.
826 Include "same-inode.h", instead.
828 2006-03-11 Eric Blake <ebb9@byu.net>
830 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
832 2006-03-10 Jim Meyering <jim@meyering.net>
834 Fix a bug whereby a user with write access to a directory being removed
835 could cause the removal of that directory to fail with an erroneous
836 diagnostic about a directory cycle. Reported by Vineet Chadha.
838 * NEWS: Mention this.
839 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
840 leave (and try to rmdir) is the one whose dev_ino is being used to
841 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
843 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
845 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
846 * src/dd.c (set_fd_flags): Handle file-creation flags on file
847 descriptors, rather than ignoring them.
848 * tests/dd/misc: Add test cases for append, nofollow, directory,
849 and nolinks flags. Simplify redirection to /dev/null in some cases.
851 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
852 noatime test never tested anything.
854 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
856 * src/dd.c (flags, usage): New flags directory, nolinks.
857 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
859 * src/ls.c (usage): Mention that -f disables --color.
860 Problem reported by Niels Möller.
862 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
864 * man/*.x: Add references to syscalls from utilities of the same name.
866 2006-03-05 Jim Meyering <jim@meyering.net>
868 * tests/help-version: Set SHELL, if not already set, in order to
869 avoid failure when `make check' is run through debuild; dircolors
870 would fail due to lack of $SHELL. Reported by Sven Joachim.
872 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
873 * src/base64.c (wrap_write, do_encode, main): Change type of
874 parameters and locals, wrap_column, form size_t to uintmax_t.
875 (main): Adjust to use xstrtoumax, accordingly.
877 2006-03-03 Jim Meyering <jim@meyering.net>
879 Don't fail when run from an environment with SHELL not a Bourne
880 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
881 * tests/dircolors/simple: Invoke each non-failing test with -b.
882 Reported by Michael Stone.
884 2006-02-27 Jim Meyering <jim@meyering.net>
886 * tests/misc/base64: Derive --decode-using tests from the
889 * tests/misc/base64: Factor out a long constant string.
890 Split lines to stay within 80 columns.
892 * tests/misc/Makefile.am (TESTS): Add base64.
893 * tests/misc/base64: Test base64. From Simon Josefsson.
895 * src/base64.c (do_decode): Use correct type for parameter,
896 ignore_garbage: s/size_t/bool/.
898 * src/base64.c: Don't include .h files already included by system.h:
899 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
900 Include "system.h" before the other lib/*.h header files.
901 Include <sys/types.h> before "system.h".
902 (wrap_write): Remove declaration of unused local, initial_column.
903 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
905 * README: Add base64 to the list.
907 2006-02-17 Simon Josefsson <jas@extundo.com>
910 * AUTHORS: Mention base64.
912 * man/Makefile.am: Build base64.1.
913 * man/base64.x: New file.
914 * src/Makefile.am (bin_PROGRAMS): Add base64.
915 * src/base64.c: New file.
917 2006-02-25 Eric Blake <ebb9@byu.net>
919 In ls, avoid calling stat for --inode (-i), when possible.
920 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
921 * src/system.h: ... here, for use in ...
922 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
924 (gobble_file): Add inode argument.
925 (print_dir): Pass inode if available.
926 (usage): Remove inaccuracy.
928 2006-02-23 Jim Meyering <jim@meyering.net>
930 * TODO: Update/correct some obsolete entries.
932 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
934 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
935 * src/join.c (usage): Likewise.
936 Documentation problem reported by Philip Kensche.
938 2006-02-20 Eric Blake <ebb9@byu.net>
940 * man/rm.x: Update documentation to match previous patch.
942 2006-02-18 Eric Blake <ebb9@byu.net>
944 New option for rm: --interactive=once (-I).
945 * NEWS: Document it, along with change to rm --interactive.
946 * TODO: Remove entry for implementing rm -I
947 * src/rm.c (INTERACTIVE_OPTION): New enum value.
948 (interactive_type): New enum.
949 (long_opts): Let interactive take an optional argument.
950 (interactive_args, interactive_types): New option arguments.
951 (usage): Document -I, --interactive=WHEN. Use program_name
952 instead of a basename.
953 (main): New -I option, new behavior to --interactive.
954 * tests/rm/interactive-once: New tests.
955 * tests/rm/interactive-always: Ditto.
956 * tests/rm/Makefile.am (TESTS): Run them.
958 2006-02-18 Jim Meyering <jim@meyering.net>
960 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
961 expression match more of the target lines, e.g., those that start with
962 `-S,' (short option followed by a comma) or that include `=[...]'.
963 Patch by Nicolas François.
964 Fix the four offenders thus exposed:
965 * src/join.c (usage): Use two spaces (not one) to separate the
966 --first-only option string from its description, so help2man formats
967 the derived man page properly.
968 * src/pr.c (usage): Likewise.
969 * src/uniq.c (usage): Likewise.
970 * src/install.c (usage): Likewise.
972 2006-02-15 Jim Meyering <jim@meyering.net>
974 * Makefile.maint (alpha beta major): For `make major', ensure that the
975 version string is of the form N.N[.N]*, where N is one or more digits.
977 2006-02-14 Jim Meyering <jim@meyering.net>
979 * INSTALL: Update from gnulib.
981 2006-02-13 Jim Meyering <jim@meyering.net>
983 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
985 2006-02-12 Jim Meyering <jim@meyering.net>
987 * Makefile.maint (patch-check): New target.
988 (local-checks-available): Add to the list.
990 2006-02-11 Jim Meyering <jim@meyering.net>
992 * src/c99-to-c89.diff: New file.
993 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
995 * .x-po-check: New file, with exclusions so that `make distcheck'
997 * Makefile.am (EXTRA_DIST): Add .x-po-check.
999 rm -r must remove an empty directory, even if it is inaccessible.
1000 * src/remove.c (close_preserve_errno): New function.
1001 (fd_to_subdirp): Don't print a diagnostic in this function.
1002 Do it from the callers instead, unless rmdir succeeds.
1003 (remove_cwd_entries, remove_dir): Adjust callers.
1004 * tests/rm/empty-inacc: New test for the above.
1005 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
1006 * NEWS: Mention this bug fix.
1007 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
1008 a tiny bit less precise: cannot remove `a/1': ... instead of
1009 cannot open directory `a/1': ...
1011 * Makefile.maint (syntax-check-rules): Automatically derive this
1012 list of sc_-prefixed rule names.
1014 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
1016 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
1017 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
1018 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
1019 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
1020 go away? was that an accident?)
1021 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
1022 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
1023 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
1024 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
1025 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
1026 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
1027 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
1028 (author_mark_check, makefile_path_separator_check):
1029 Output line numbers, to simplify navigation of Emacs *compilation*
1031 (sc_prohibit_atoi_atof, sc_file_system):
1032 Rework slightly so that Makefile.maint doesn't get reported as a
1033 violation of its own syntax rules.
1034 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
1035 it at run-time (which didn't work with Bison). Fix a makefile typo,
1036 caught by Makefile.maint itself: spaces where a tab should be.
1037 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
1038 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
1039 Ignore djgpp and man subdirectories, to avoid false matches with
1040 Bison and coreutils, respectively. Use sort -u to remove the
1041 resulting duplicates.
1042 * gnupload: Rework slightly to avoid bogus warning from
1043 sc_two_space_separator_in_usage.
1045 2006-02-10 Jim Meyering <jim@meyering.net>
1047 Use gzip's --rsyncable option only if it's available.
1048 * Makefile.maint (gzip_rsyncable): New variable.
1051 2006-02-08 Jim Meyering <jim@meyering.net>
1053 * Makefile.maint (local-checks-available): Define in terms of
1054 the expansion, $(syntax-check-rules), rather than the single,
1055 top-level target `syntax-check', so that it's easier to exclude
1056 individual rules (via $(local-checks-to-skip)).
1057 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
1059 2006-02-07 Jim Meyering <jim@meyering.net>
1061 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
1062 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
1064 * tests/help-version (expected_failure_status_vdir):
1065 Redirect an expected disk-full diagnostic to /dev/null.
1067 2006-02-06 Jim Meyering <jim@meyering.net>
1069 * src/unexpand.c (usage): Use two spaces (not one) to separate the
1070 --first-only option string from its description, so help2man formats
1071 the derived man page properly.
1072 * src/rm.c (usage): Likewise for --no-preserve-root.
1073 * src/chown.c (usage): Likewise.
1074 * src/chgrp.c (usage): Likewise.
1076 Add a rule to ensure that the above doesn't happen again.
1077 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
1078 (syntax-check-rules): Add it.
1079 * .x-sc_two_space_separator_in_usage: New empty file.
1080 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
1082 2006-02-06 Jim Meyering <jim@meyering.net>
1084 * src/cp.c (usage): Use two spaces (not one) to separate each
1085 option string from its description, so help2man formats the
1086 derived man page properly.
1087 * src/mv.c (usage): Likewise.
1088 Patch from Nicolas François in http://bugs.debian.org/351601.
1090 2006-02-04 Jim Meyering <jim@meyering.net>
1092 * src/copy.c (copy_internal): cp -RL would fail when encountering
1093 the same directory more than once in the hierarchy beneath a single
1094 command-line argument. That is legitimate, e.g. when there are
1095 two or more symbolic links, each pointing to some directory that
1096 would not otherwise be copied. Reported by Christophe LYON.
1097 * tests/cp/cp-deref: New file. Test for today's fix.
1098 * tests/cp/Makefile.am (TESTS): Add cp-deref.
1099 * NEWS: Document this.
1101 2006-02-03 Jim Meyering <jim@meyering.net>
1103 * configure.ac: Require automake-1.9.6, not 1.8.3.
1105 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
1107 * src/od.c (usage): Mention that -t a ignores high order bit.
1108 Documentation problem reported by Ed Avis.
1110 2006-02-01 Jim Meyering <jim@meyering.net>
1112 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
1114 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
1116 * src/head.c (main): Use a better diagnostic when someone uses a
1117 trailing numeric option in an invalid way. Problem reported by
1119 * src/tail.c (parse_options): Likewise.
1121 2006-01-30 Jim Meyering <jim@meyering.net>
1123 * man/wc.x: Include `count' keyword in man page synopsis,
1124 per suggestion from http://bugs.debian.org/181585.
1126 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
1128 * src/df.c (show_dev): If the file system claims to have
1129 more available than total blocks, report the number of used
1130 blocks as being total - available (a negative number) rather
1131 than as garbage. Problem reported by Toralf Foerster.
1133 2006-01-24 Jim Meyering <jim@meyering.net>
1135 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
1136 to put a regular file in O_NONBLOCK mode fails with EPERM.
1137 That happens on Linux (up to 2.6.15) when using tail -f on a file with
1138 the append-only attribute. Reported by Dean Gaudet. For details,
1139 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
1140 * NEWS: Mention this fix.
1141 * tests/tail-2/append-only: New file. Test for the above.
1142 * tests/tail-2/Makefile.am (TESTS): Add append-only.
1143 * tests/Makefile.am (check-root): Add tail-2/append-only
1145 2006-01-21 Jim Meyering <jim@meyering.net>
1147 * NEWS: Mention fts-related improvements and bug fixes.
1149 2006-01-19 Jim Meyering <jim@meyering.net>
1151 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
1152 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
1154 2006-01-18 Jim Meyering <jim@meyering.net>
1156 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
1158 2006-01-17 Jim Meyering <jim@meyering.net>
1160 Now that fts no longer changes the current working directory, adjust
1161 its clients accordingly -- note that du.c uses fts but doesn't need
1162 any adjustment, since it doesn't operate on the actual files,
1163 but rather just uses the stat buffers provided by fts.
1165 * src/chown-core.c: Include "openat.h".
1166 Don't include "lchown.h".
1167 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
1168 calling openat, lchownat, chownat, rather than open, lchown, chown.
1170 * src/chmod.c: Include "openat.h".
1171 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
1173 * tests/du/long-from-unreadable: New test, to exercise one small
1176 2006-01-13 Jim Meyering <jim@meyering.net>
1178 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
1179 addition of new directories under tests/.
1181 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
1184 2006-01-12 Jim Meyering <jim@meyering.net>
1186 * tests/du/long-sloop: Adjust not to hard-code the expected
1187 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
1188 from that of GNU libc. Reported by Paul Eggert.
1190 * tests/du/long-sloop: Create file at end of symlink chain.
1192 * tests/misc/test: New file, with a test for one of the
1193 bugs fixed by yesterday's test.c changes.
1194 * tests/misc/Makefile.am (TESTS): Add test.
1196 2006-01-11 Jim Meyering <jim@meyering.net>
1198 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
1199 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
1200 a very long sequence of symbolic links (not necessarily a loop).
1201 * tests/du/Makefile.am (TESTS): Add long-sloop.
1203 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
1205 * src/test.c (test_syntax_error): Append a newline. All callers
1206 changed, except for the ones that didn't already append a newline.
1207 Bug reported by Eric Blake.
1209 2006-01-11 Jim Meyering <jim@meyering.net>
1211 * src/system.h (X2NREALLOC): Now that verify_true is no longer
1212 void, cast its result to void, to avoid gcc's warning that
1213 ``left-hand operand of comma expression has no effect''.
1214 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
1216 2006-01-10 Jim Meyering <jim@meyering.net>
1218 * tests/chmod/no-x: Add a test for today's fts.c fix.
1220 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
1222 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
1223 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
1225 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
1227 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
1228 Use verify_true instead of verify_expr, to sync with gnulib.
1230 2006-01-08 Jim Meyering <jim@meyering.net>
1232 * src/date.c (usage): Adjust the formatting of the entries for
1233 %::z and %:::z (separate with two spaces, not one) so that help2man
1234 formats them properly. Reported by Philip Rowlands.
1236 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
1238 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
1240 2006-01-06 Jim Meyering <jim@meyering.net>
1242 * Makefile.maint (copyright-check): Use date +%Y in place of
1245 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
1246 First off, the attribute should have been `volatile' (not static)
1247 to avoid longjmp-related risk of clobber. Secondly, now there is
1248 no longer any risk of a local variable being clobbered, so there's
1249 no need for any attribute at all.
1251 2006-01-05 Jim Meyering <jim@meyering.net>
1253 * src/remove.c: Give a few functions the inline attribute.
1254 (AD_pop_and_chdir): Use gotos to avoid some duplication.
1255 (AD_push): Rewrite an assertion so that the entire computation
1256 goes away when assertions are turned off.
1258 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
1259 It's already defined in "system.h".
1260 * Makefile.maint: Add a FIXME comment.
1262 2006-01-04 Jim Meyering <jim@meyering.net>
1264 * ChangeLog: Remove entries from 2005-10-22 and earlier.
1265 * ChangeLog-2005: New file, for entries up to version 5.92.
1267 2006-01-03 Jim Meyering <jim@meyering.net>
1269 * tests/du/no-x: Also allow a slightly different diagnostic -- the
1270 one you get when using openat-enabled fts.c and du (coming soon).
1271 * tests/chmod/no-x: Likewise.
1272 * tests/chgrp/no-x: Likewise.
1274 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
1276 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
1278 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
1279 (restricted_chown): Return it, if the file cannot be accessed due
1280 to EPERM, or if no uid or gid are required, or if the file is
1281 neither a directory nor a regular file. Rewrite to avoid gotos.
1282 (change_file_owner): Handle RC_do_ordinary_chown case.
1283 Rewrite to avoid gotos.
1284 * tests/chgrp/basic: Make sure we can change the group of
1287 * src/date.c (usage): Explain %g, %G, and %V a bit better.
1289 2006-01-02 Jim Meyering <jim@meyering.net>
1291 * src/copy.c (set_owner): Correct a comment.
1293 * src/tail.c (parse_options): Change warning to say that --retry
1294 is useful `mainly' (not `only') when following by name.
1295 Reported here: http://bugs.debian.org/273781
1297 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
1299 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
1300 * src/copy.c: Include lchmod.h.
1301 (copy_internal): Use lchmod rather than chmod.
1302 * src/cp.c: Include lchmod.h.
1303 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
1304 * src/mkdir.c: Include lchmod.h.
1305 (usage): Clarify -m's operation.
1306 (main): Use lchmod rather than chmod. Don't use lchmod unless the
1307 new mode contains bits outside the 777 range.
1308 * src/mkfifo.c (usage): Clarify -m's operation.
1309 (main): If -m is given, don't invoke chmod; use umask 0 instead.
1310 Report an error if -m asks for bits outside the 777 range.
1311 * src/mknod.c (usage, main): Likewise.
1313 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
1315 2005-12-27 Jim Meyering <jim@meyering.net>
1317 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
1318 (sc_prohibit_assert_without_use): New rule.
1319 (syntax-check-rules): Add it to the list.
1320 * .x-sc_prohibit_assert_without_use: New empty file.
1321 * Makefile.am (EXTRA_DIST): Add it.
1323 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
1325 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
1326 Don't include <assert.h>; it wasn't used.
1328 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
1330 * src/chown-core.c (restricted_chown):
1331 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
1332 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
1333 | O_NOFOLLOW too, for consistency with other dir-openers.
1334 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
1335 (is_empty_dir): Likewise.
1336 * src/shred.c (wipename): Likewise. Don't bother trying to open
1337 dir for writing, since POSIX prohibits it.
1339 2005-12-22 Jim Meyering <jim@meyering.net>
1341 * tests/help-version: Redirect stderr to /dev/full, to suppress
1342 write error diagnostic.
1344 2005-12-19 Jim Meyering <jim@meyering.net>
1346 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
1347 Avoid a minor race condition when `-m MODE' is specified, by using
1348 open, fchown, and close rather than just chown. To do that reliably --
1349 even with an overly restrictive umask -- ensure that each mkdir,
1350 mknod and mkfifo call uses a mode including at least owner-read access.
1351 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
1352 the subsequent chown (or equivalent open,fchown,close) fails.
1353 * tests/misc/mknod: New tests.
1354 * tests/misc/Makefile.am (TESTS): Add mknod.
1356 2005-12-17 Jim Meyering <jim@meyering.net>
1358 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
1359 e.g., on a named pipe.
1360 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
1361 place of all uses, since it is guaranteed (system.h) to be defined.
1363 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
1365 Add POSIX ACL support
1366 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
1367 is no requirement for ACL support; particularly, it does not exist
1368 on systems that have POSIX ACLs.
1369 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1370 * src/cp.c (umask_kill): With default acls, the umask is not to be
1371 applied. Remove umask_kill, don't change the process umask, and let
1372 the kernel apply the umask where appropriate.
1373 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1374 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1376 (copy_reg, copy_internal): Use copy_acl and set_acl
1377 instead of fchown/chown. Fix the logic for POSIX ACLs.
1378 (chown_succeded): Remove; we now always copy acls and
1379 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1380 did a chown before or not.
1381 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1382 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1383 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1384 to link with it via $(LIB_ACL), for the utilities that need it.
1386 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1388 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1389 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1390 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1391 value is now signified by whether cwd_errno is null.
1392 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1393 pointer-to-bool to pointer-to-errno-value. All callers changed.
1394 (rm_1): Don't bother setting a local cwd failure flag and then
1395 ORing it into the caller's. Just set the caller's.
1396 (rm): Use cwd failure errno value to print a slightly-better
1399 2005-12-15 Jim Meyering <jim@meyering.net>
1401 * src/stat.c (print_it): Properly handle a backslash at the
1402 end of a --printf format string. Reported by Paul Eggert.
1403 * tests/misc/stat-printf (end-bs): Add a test for the above.
1405 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1407 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1408 Don't assume /etc/passwd contains user names; use 'id' instead.
1410 2005-12-15 Jim Meyering <jim@meyering.net>
1412 stat: revert behavior of --format=FMT (-c)
1413 stat: add new option: --printf=FMT
1414 * NEWS: Mention this.
1415 * src/stat.c (isodigit, octtobin, hextobin): Define.
1416 (PRINTF_OPTION): Define.
1417 (interpret_backslash_escapes, trailing_delim): New globals.
1418 (usage): Document them. Alphabetize on long option names.
1419 (print_esc_char): New function.
1420 (print_it): Rewrite, in order to handle backslash escapes.
1421 (main): Handle new option. Set globals for --format, too.
1423 * tests/misc/stat-printf: Test --printf and --format.
1424 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1426 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1428 * NEWS: sort now reports incompatible options.
1429 * src/sort.c (incompatible_options, check_ordering_compatibility):
1431 (main): Use them. Don't bother with a usage message for
1432 "sort -c a b", for consistency with other error diagnostics.
1433 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1436 * src/cat.c (main): Undo previous change. close_stdout already
1437 does the check, so the previous change wasn't necessary.
1439 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1441 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1443 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1445 Install a more-conservative approach for sort -R. It's the
1446 same basic idea as the existing code, except it uses the full ISAAC
1447 approach (called the "more kosher" approach in the existing comments).
1448 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1449 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1450 better to be conservative here at first, and review any performance
1451 improvements carefully.
1452 * .x-sc_require_config_h: Add src/rand-isaac.c.
1453 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1454 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1455 (shred_SOURCES, sort_SOURCES): Remove.
1456 (EXTRA_DIST): Add rand-isaac.c.
1457 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1458 changing it to allow for varying numbers of words in the state.
1459 Alter so that we include rand-isaac.c directly rather than
1460 compiling it and linking to it. Don't include config.h or
1461 system.h; that's the includer's responsibility.
1462 Omit functions that are specific to shred.
1463 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1464 (isaac_step, struct irand_state):
1465 Resurrect these, with the same defns that used to be in shred.c.
1466 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1467 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1469 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1470 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1471 (irand_init, irand32, irand_mod):
1472 Number of words is constant again.
1473 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1474 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1475 * src/sort.c: Likewise.
1476 * src/shred.c (fillrand, dopass, main): Undo previous change.
1477 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1479 * src/sort.c: Don't include md5.h; it wasn't needed.
1480 (struct keyfield): Rename random_hash to random, for consistency
1481 with the other member names. All uses changed.
1482 (usage): Tweak wording to mention STRING for --seed option.
1483 (short_options): Rorder for consistency with other programs.
1484 (rand_state): Now a struct, not a pointer to one. All uses changed.
1485 (HASH_WORDS, HASH_SIZE): Remove.
1486 (get_hash): Remove comments around resbuf size, since we can assume C89.
1487 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1488 (keycompare): Adjust to the new get_hash.
1490 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1491 (main): Don't set need_random simply because gkey has it set; that
1492 doesn't necessarily mean we'll need random numbers.
1493 Redo seeding to match new get_hash approach.
1495 2005-12-10 Jim Meyering <jim@meyering.net>
1497 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1499 Avoid shred segfault on 64-bit systems.
1500 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1501 local of type uint32_t. Make the local an `int' instead.
1503 * NEWS: Mention sort's new options.
1505 * src/rand-isaac.c (isaac_mix): Declare to be static.
1506 Mark all other functions as `extern' so the tight-scope
1507 part of `make distcheck' passes once again.
1508 * src/rand-isaac.h (isaac_mix): Remove declaration.
1510 * src/sort.c (get_hash): Change position of `*' in parameter
1511 type to conform with convention.
1512 (main): Split a long line so it fits in 80 columns.
1513 (keycompare): Remove stray SPACE before TAB that was
1514 causing `make distcheck' to fail.
1516 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1518 * tests/misc/sort-rand: New file: basic tests for the new options.
1519 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1521 2005-12-10 Frederik Eaton <frederik@ofb.net>
1523 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1524 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1525 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1526 Make state size runtime-configurable.
1527 (isaac_new, isaac_copy): New functions.
1528 * src/rand-isaac.h: New file.
1529 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1530 (fillrand, main): Adjust to the fact that the state size is now
1531 runtime-configurable.
1532 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1533 (usage): Add options --random-sort and --seed to implement a random
1535 Include md5.h and rand-isaac.h.
1536 (get_hash): New function.
1537 (rand_state): New var.
1538 (HASH_WORDS, HASH_SIZE): New macros.
1540 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1542 * tests/dd/misc: Add test for dd iflags=noatime.
1544 2005-12-09 Jim Meyering <jim@meyering.net>
1546 * src/sort.c (usage): Mention white space vs -b and -t options.
1549 2005-12-09 Eric Blake <ebb9@byu.net>
1551 * src/test.c (main): Fix misleading comment.
1553 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1555 * NEWS: Mention dd's new noatime flag.
1556 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1557 * src/dd.c (flags, usage): Add support for noatime flag.
1559 2005-12-07 Jim Meyering <jim@meyering.net>
1561 Distribute the cvsu script, used only by `make syntax-check'.
1562 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1563 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1564 distribute a copy of this script.
1565 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1567 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1568 to create a temporary directory on another partition.
1569 From Andreas Gruenbacher.
1571 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1573 * man/basename.x: Cross-reference to dirname and readlink.
1574 * man/dirname.x: Cross-reference to basename and readlink.
1576 2005-12-05 Andreas Gruenbacher
1578 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1579 (set_owner, preserve_author): New functions, factored out of copy_reg.
1580 (copy_reg): Use them.
1581 (copy_internal): Use them here, too.
1583 2005-12-04 Jim Meyering <jim@meyering.net>
1585 * src/sleep.c (usage): Say what happens with two or more arguments.
1586 Suggested by Justin Pryzby.
1588 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1591 2005-12-03 Jim Meyering <jim@meyering.net>
1593 * src/rm.c (long_opts): Change the name of each undocumented, for-
1594 testing-only option to start with `-', so that it cannot render
1595 ambiguous any prefix it happens to share with some other option name.
1596 Problem reported by Eric Blake.
1597 * src/head.c (long_options): Likewise.
1598 * src/tail.c (long_options): Likewise.
1600 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1601 testing-only --presume* options to start with `---'.
1602 * tests/rm/dangling-symlink: Likewise.
1603 * tests/rm/dir-no-w: Likewise.
1604 * tests/rm/isatty: Likewise.
1606 2005-11-30 Jim Meyering <jim@meyering.net>
1608 * Makefile.maint: Add a comment about cvsu.
1610 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1612 * NEWS: df updates for "none", "proc", inaccessible file systems.
1613 * src/df.c (show_point): Ignore inaccessible file systems.
1614 (usage): -a includes dummy file systems, not size-0 file systems.
1616 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1617 to avoid collision with POSIX name space. All uses changed.
1619 2005-11-24 Jim Meyering <jim@meyering.net>
1621 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1622 * tests/acl: Add `$0: ' prefix to diagnostics.
1624 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1626 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1628 * src/copy.c: Improve performance a bit by optimizing away
1629 unnecessary system calls and going to a block size of at least
1630 8192 (on normal hosts, anyway). This improved performance 5% on my
1631 Debian stable host (2.4.27 kernel, x86, copying from root
1632 ext3 file system to itself).
1633 Include "buffer-lcm.h".
1634 (copy_reg): Omit last argument. All callers changed.
1635 Use xmalloc to allocate rather than trusting alloca
1636 (which is unwise with large block sizes).
1637 Declare locals more locally, if possible.
1638 Use uintptr_t words instead of int words, for a bit more speed
1639 when looking for null blocks on 64-bit hosts.
1640 Optimize away reads of zero bytes on regular files.
1641 In the typical case, insist on 8 KiB buffers, at least.
1642 Avoid unnecessary extra call to fstat when checking for sparse files.
1643 Avoid now-unnecessary cast to off_t, and "0L".
1644 Avoid unnecessary test of *new_dst when checking for same owner
1647 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1649 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1651 2005-11-22 Jim Meyering <jim@meyering.net>
1653 * src/remove.c (AD_push): Remove debugging cruft.
1655 * tests/rm/unread2 (rm): Change expected diagnostic,
1656 `cannot open directory' to `cannot remove', to align with
1658 * tests/rm/rm2: Ensure that rm now continues removing entries
1659 even after certain types of failure.
1661 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1662 that provide openat (Solaris), and on systems like Linux+procfs
1663 where our openat emulation code is reentrant. This also fixes a
1664 few low-probability leaks and eliminates some code that could,
1665 in very unusual circumstances, cause rm() (via a callee) to exit.
1666 * NEWS: Mention this.
1668 * configure.ac: Put copyright dates all on one line so the
1669 emacs function that updates them works properly.
1671 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1673 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1674 Problem reported by Eric Blake.
1675 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1676 we get a standard-conforming compiler. This relies on the new
1677 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1678 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1679 m4/c.m4 can go away with Autoconf 2.60 comes out.
1681 2005-11-17 Jim Meyering <jim@meyering.net>
1683 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1684 (AD_mark_current_as_unremovable): Likewise, but for a local.
1687 * tests/mv/acl: Let traps handle removing temporary directories.
1689 Expect acl-related tests to fail, until the corresponding
1690 patches are committed.
1691 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1692 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1694 ACL tests, from Andreas Gruenbacher.
1695 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1696 * tests/mv/Makefile.am (TESTS): Add acl.
1697 * tests/cp/Makefile.am (TESTS): Add acl.
1699 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1701 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1703 * NEWS: Improve quality of ln's diagnostics.
1704 * src/ln.c (do_link, usage): Likewise.
1705 (do_link): Don't use alloca on a buffer of unbounded size.
1707 2005-11-16 Jim Meyering <jim@meyering.net>
1709 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1710 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1711 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1712 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1713 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1715 2005-11-14 Jim Meyering <jim@meyering.net>
1717 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1719 2005-11-13 Jim Meyering <jim@meyering.net>
1721 * announce-gen: Accept new option, --gpg-key-id=ID and
1722 emit a blurb telling how to use the .sig files.
1723 * Makefile.cfg (gpg_key_ID): Define.
1724 * Makefile.maint (announcement): Use new option and key.
1726 Require that most .c files include <config.h>.
1727 * Makefile.maint (sc_require_config_h): New rule.
1728 (syntax-check-rules): Add it.
1729 * .x-sc_require_config_h: New file listing exceptions to the
1730 above rule. Some are legit, others are simply grandfathered in.
1731 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1733 2005-11-12 Jim Meyering <jim@meyering.net>
1735 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1737 2005-11-11 Jim Meyering <jim@meyering.net>
1739 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1740 Mention new readlink options in 5.3.0's `New features' section.
1741 Spotted by Thomas Hood.
1743 2005-11-08 Jim Meyering <jim@meyering.net>
1745 * NEWS: Merge in changes from b5_9x branch.
1747 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1749 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1750 like --time-style='posix-long-iso' if the locale settings are messed up.
1751 * src/ls.c (decode_switches): Implement this.
1753 2005-11-08 Jim Meyering <jim@meyering.net>
1755 * tests/du/2g: s/expensive/very expensive/ in a comment.
1758 2005-10-17 Eric Blake <ebb9@byu.net>
1760 * src/ls.c (usage): Fix descriptions of --sort, --time.
1761 Reported by Vitaly A. Ostanin.
1763 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1765 * src/ln.c: Include filenamecat.c.
1766 (FILE_BASENAME_CONCAT): Remove.
1767 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1768 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1769 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1772 2005-11-04 Jim Meyering <jim@meyering.net>
1774 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1775 on systems with stat.st_blocks of a signed 32-bit type.
1776 This bug causes trouble on some AIX 5.1 systems.
1777 Report and trivial patch from Paul Townsend:
1778 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1779 * NEWS: Mention this.
1781 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1782 * tests/du/Makefile.am (TESTS): Add it here.
1783 * tests/very-expensive: New file.
1784 * tests/Makefile.am (EXTRA_DIST): Add it here.
1785 * tests/cp/perm: Mark this test as `very-expensive', too.
1787 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1789 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1791 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1793 * src/rm.c (usage): Don't mention rm -d.
1795 2005-11-02 Jim Meyering <jim@meyering.net>
1797 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1798 From Andreas Schwab.
1800 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1801 `M+N records in/out' lines don't pollute `make check' output.
1803 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1804 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1805 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1806 to indicate that the input file should be piped into the command
1807 under test (via `cat FILE | $prog ...').
1809 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1810 (without -r) fails to remove a directory on a non-Linux system.
1811 This change affects only newer Solaris systems (with priv_*
1812 functions like priv_allocset). Reported by Keith Thompson.
1814 * tests/rm/dir-nonrecur: New file/test for the above fix.
1815 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1817 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1819 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1820 POSIX 1002.1-2001 requires.
1821 * src/tail.c (parse_obsolete_option): Implement this.
1822 Problem reported by Vincent Lefevre.
1823 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1824 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1825 (test_vector): Add special cases for _POSIX2_VERSION, and
1826 regularize the old ones a bit.
1827 * tests/touch/obsolescent: Add y2000 test.
1829 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1831 * src/dd.c (skip): Fix off-by-one error reported by
1832 Theodoros V. Kalamatianos.
1834 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1836 * tests/mkdir/p-3: Require that the test be run as non-root.
1837 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1839 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1841 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1842 boundary between DEST and SOURCE in the result.
1844 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1846 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1847 back to text, to sync with documentation and for backwards
1850 2005-10-25 Jim Meyering <jim@meyering.net>
1852 * tests/dircolors/simple (other-wr): Add an explicit test for
1853 the dircolors bug (NULL-dereference) fixed yesterday.
1855 2005-10-24 Jim Meyering <jim@meyering.net>
1857 * src/tac.c (tac_file): When determining whether a file is seekable,
1858 also test whether it is a tty. Using only the lseek-based test would
1859 give a false positive on Solaris. Reported by Peter Fales.
1861 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1863 * tests/install/d-slashdot: New test, for "install -d" failure.
1864 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1865 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1866 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1868 2005-10-24 Jim Meyering <jim@meyering.net>
1870 * src/dircolors.c (ls_codes): Add missing comma.
1871 Anonymous report and patch from
1872 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1874 * src/dircolors.c: Add compile-time assertion that the slack_codes
1875 and ls_codes arrays have the same number of elements. This would
1876 have prevented the above-fixed bug.
1878 * src/expand.c (parse_tab_stops): Add a comment to make this function
1879 identical to the one in unexpand.c.
1880 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1881 identical to the one in expand.c.
1883 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1885 2005-10-23 Jim Meyering <jim@meyering.net>
1887 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1888 a dangerous pointer-value-to-`unsigned' cast.
1889 * NEWS: mention the new sha* programs.
1890 * AUTHORS: Add new sha* programs.
1892 2005-08-28 David Madore <david.madore@ens.fr>
1894 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1895 * README: Add their names to the list.
1896 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1897 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1898 Rules for compiling sha-2 utilities
1899 (noinst_HEADERS): Remove checksum.h.
1900 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1902 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1903 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1904 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1905 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1906 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1907 sha384sum, sha512sum test scripts here rather that each in its
1910 2005-08-28 David Madore <david.madore@ens.fr>
1912 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1913 of the FIPS test vectors).
1915 2005-10-23 Jim Meyering <jim@meyering.net>
1917 * configure.ac: Use 6.0-cvs as the version string.
1918 * NEWS: Adjust accordingly.