1 2006-02-27 Jim Meyering <jim@meyering.net>
5 * src/base64.c (do_decode): Use correct type for parameter,
6 ignore_garbage: s/size_t/bool/.
8 * src/base64.c: Don't include .h files already included by system.h:
9 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
10 Include "system.h" before the other lib/*.h header files.
11 Include <sys/types.h> before "system.h".
12 (wrap_write): Remove declaration of unused local, initial_column.
13 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
15 * README: Add base64 to the list.
17 2006-02-17 Simon Josefsson <jas@extundo.com>
20 * AUTHORS: Mention base64.
22 * man/Makefile.am: Build base64.1.
23 * man/base64.x: New file.
24 * src/Makefile.am (bin_PROGRAMS): Add base64.
25 * src/base64.c: New file.
27 2006-02-25 Eric Blake <ebb9@byu.net>
29 In ls, avoid calling stat for --inode (-i), when possible.
30 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
31 * src/system.h: ... here, for use in ...
32 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
34 (gobble_file): Add inode argument.
35 (print_dir): Pass inode if available.
36 (usage): Remove inaccuracy.
38 2006-02-23 Jim Meyering <jim@meyering.net>
40 * TODO: Update/correct some obsolete entries.
42 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
44 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
45 * src/join.c (usage): Likewise.
46 Documentation problem reported by Philip Kensche.
48 2006-02-20 Eric Blake <ebb9@byu.net>
50 * man/rm.x: Update documentation to match previous patch.
52 2006-02-18 Eric Blake <ebb9@byu.net>
54 New option for rm: --interactive=once (-I).
55 * NEWS: Document it, along with change to rm --interactive.
56 * TODO: Remove entry for implementing rm -I
57 * src/rm.c (INTERACTIVE_OPTION): New enum value.
58 (interactive_type): New enum.
59 (long_opts): Let interactive take an optional argument.
60 (interactive_args, interactive_types): New option arguments.
61 (usage): Document -I, --interactive=WHEN. Use program_name
62 instead of a basename.
63 (main): New -I option, new behavior to --interactive.
64 * tests/rm/interactive-once: New tests.
65 * tests/rm/interactive-always: Ditto.
66 * tests/rm/Makefile.am (TESTS): Run them.
68 2006-02-18 Jim Meyering <jim@meyering.net>
70 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
71 expression match more of the target lines, e.g., those that start with
72 `-S,' (short option followed by a comma) or that include `=[...]'.
73 Patch by Nicolas François.
74 Fix the four offenders thus exposed:
75 * src/join.c (usage): Use two spaces (not one) to separate the
76 --first-only option string from its description, so help2man formats
77 the derived man page properly.
78 * src/pr.c (usage): Likewise.
79 * src/uniq.c (usage): Likewise.
80 * src/install.c (usage): Likewise.
82 2006-02-15 Jim Meyering <jim@meyering.net>
84 * Makefile.maint (alpha beta major): For `make major', ensure that the
85 version string is of the form N.N[.N]*, where N is one or more digits.
87 2006-02-14 Jim Meyering <jim@meyering.net>
89 * INSTALL: Update from gnulib.
91 2006-02-13 Jim Meyering <jim@meyering.net>
93 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
95 2006-02-12 Jim Meyering <jim@meyering.net>
97 * Makefile.maint (patch-check): New target.
98 (local-checks-available): Add to the list.
100 2006-02-11 Jim Meyering <jim@meyering.net>
102 * src/c99-to-c89.diff: New file.
103 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
105 * .x-po-check: New file, with exclusions so that `make distcheck'
107 * Makefile.am (EXTRA_DIST): Add .x-po-check.
109 rm -r must remove an empty directory, even if it is inaccessible.
110 * src/remove.c (close_preserve_errno): New function.
111 (fd_to_subdirp): Don't print a diagnostic in this function.
112 Do it from the callers instead, unless rmdir succeeds.
113 (remove_cwd_entries, remove_dir): Adjust callers.
114 * tests/rm/empty-inacc: New test for the above.
115 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
116 * NEWS: Mention this bug fix.
117 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
118 a tiny bit less precise: cannot remove `a/1': ... instead of
119 cannot open directory `a/1': ...
121 * Makefile.maint (syntax-check-rules): Automatically derive this
122 list of sc_-prefixed rule names.
124 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
126 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
127 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
128 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
129 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
130 go away? was that an accident?)
131 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
132 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
133 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
134 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
135 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
136 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
137 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
138 (author_mark_check, makefile_path_separator_check):
139 Output line numbers, to simplify navigation of Emacs *compilation*
141 (sc_prohibit_atoi_atof, sc_file_system):
142 Rework slightly so that Makefile.maint doesn't get reported as a
143 violation of its own syntax rules.
144 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
145 it at run-time (which didn't work with Bison). Fix a makefile typo,
146 caught by Makefile.maint itself: spaces where a tab should be.
147 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
148 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
149 Ignore djgpp and man subdirectories, to avoid false matches with
150 Bison and coreutils, respectively. Use sort -u to remove the
151 resulting duplicates.
152 * gnupload: Rework slightly to avoid bogus warning from
153 sc_two_space_separator_in_usage.
155 2006-02-10 Jim Meyering <jim@meyering.net>
157 Use gzip's --rsyncable option only if it's available.
158 * Makefile.maint (gzip_rsyncable): New variable.
161 2006-02-08 Jim Meyering <jim@meyering.net>
163 * Makefile.maint (local-checks-available): Define in terms of
164 the expansion, $(syntax-check-rules), rather than the single,
165 top-level target `syntax-check', so that it's easier to exclude
166 individual rules (via $(local-checks-to-skip)).
167 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
169 2006-02-07 Jim Meyering <jim@meyering.net>
171 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
172 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
174 * tests/help-version (expected_failure_status_vdir):
175 Redirect an expected disk-full diagnostic to /dev/null.
177 2006-02-06 Jim Meyering <jim@meyering.net>
179 * src/unexpand.c (usage): Use two spaces (not one) to separate the
180 --first-only option string from its description, so help2man formats
181 the derived man page properly.
182 * src/rm.c (usage): Likewise for --no-preserve-root.
183 * src/chown.c (usage): Likewise.
184 * src/chgrp.c (usage): Likewise.
186 Add a rule to ensure that the above doesn't happen again.
187 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
188 (syntax-check-rules): Add it.
189 * .x-sc_two_space_separator_in_usage: New empty file.
190 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
192 2006-02-06 Jim Meyering <jim@meyering.net>
194 * src/cp.c (usage): Use two spaces (not one) to separate each
195 option string from its description, so help2man formats the
196 derived man page properly.
197 * src/mv.c (usage): Likewise.
198 Patch from Nicolas François in http://bugs.debian.org/351601.
200 2006-02-04 Jim Meyering <jim@meyering.net>
202 * src/copy.c (copy_internal): cp -RL would fail when encountering
203 the same directory more than once in the hierarchy beneath a single
204 command-line argument. That is legitimate, e.g. when there are
205 two or more symbolic links, each pointing to some directory that
206 would not otherwise be copied. Reported by Christophe LYON.
207 * tests/cp/cp-deref: New file. Test for today's fix.
208 * tests/cp/Makefile.am (TESTS): Add cp-deref.
209 * NEWS: Document this.
211 2006-02-03 Jim Meyering <jim@meyering.net>
213 * configure.ac: Require automake-1.9.6, not 1.8.3.
215 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
217 * src/od.c (usage): Mention that -t a ignores high order bit.
218 Documentation problem reported by Ed Avis.
220 2006-02-01 Jim Meyering <jim@meyering.net>
222 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
224 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
226 * src/head.c (main): Use a better diagnostic when someone uses a
227 trailing numeric option in an invalid way. Problem reported by
229 * src/tail.c (parse_options): Likewise.
231 2006-01-30 Jim Meyering <jim@meyering.net>
233 * man/wc.x: Include `count' keyword in man page synopsis,
234 per suggestion from http://bugs.debian.org/181585.
236 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
238 * src/df.c (show_dev): If the file system claims to have
239 more available than total blocks, report the number of used
240 blocks as being total - available (a negative number) rather
241 than as garbage. Problem reported by Toralf Foerster.
243 2006-01-24 Jim Meyering <jim@meyering.net>
245 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
246 to put a regular file in O_NONBLOCK mode fails with EPERM.
247 That happens on Linux (up to 2.6.15) when using tail -f on a file with
248 the append-only attribute. Reported by Dean Gaudet. For details,
249 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
250 * NEWS: Mention this fix.
251 * tests/tail-2/append-only: New file. Test for the above.
252 * tests/tail-2/Makefile.am (TESTS): Add append-only.
253 * tests/Makefile.am (check-root): Add tail-2/append-only
255 2006-01-21 Jim Meyering <jim@meyering.net>
257 * NEWS: Mention fts-related improvements and bug fixes.
259 2006-01-19 Jim Meyering <jim@meyering.net>
261 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
262 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
264 2006-01-18 Jim Meyering <jim@meyering.net>
266 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
268 2006-01-17 Jim Meyering <jim@meyering.net>
270 Now that fts no longer changes the current working directory, adjust
271 its clients accordingly -- note that du.c uses fts but doesn't need
272 any adjustment, since it doesn't operate on the actual files,
273 but rather just uses the stat buffers provided by fts.
275 * src/chown-core.c: Include "openat.h".
276 Don't include "lchown.h".
277 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
278 calling openat, lchownat, chownat, rather than open, lchown, chown.
280 * src/chmod.c: Include "openat.h".
281 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
283 * tests/du/long-from-unreadable: New test, to exercise one small
286 2006-01-13 Jim Meyering <jim@meyering.net>
288 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
289 addition of new directories under tests/.
291 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
294 2006-01-12 Jim Meyering <jim@meyering.net>
296 * tests/du/long-sloop: Adjust not to hard-code the expected
297 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
298 from that of GNU libc. Reported by Paul Eggert.
300 * tests/du/long-sloop: Create file at end of symlink chain.
302 * tests/misc/test: New file, with a test for one of the
303 bugs fixed by yesterday's test.c changes.
304 * tests/misc/Makefile.am (TESTS): Add test.
306 2006-01-11 Jim Meyering <jim@meyering.net>
308 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
309 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
310 a very long sequence of symbolic links (not necessarily a loop).
311 * tests/du/Makefile.am (TESTS): Add long-sloop.
313 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
315 * src/test.c (test_syntax_error): Append a newline. All callers
316 changed, except for the ones that didn't already append a newline.
317 Bug reported by Eric Blake.
319 2006-01-11 Jim Meyering <jim@meyering.net>
321 * src/system.h (X2NREALLOC): Now that verify_true is no longer
322 void, cast its result to void, to avoid gcc's warning that
323 ``left-hand operand of comma expression has no effect''.
324 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
326 2006-01-10 Jim Meyering <jim@meyering.net>
328 * tests/chmod/no-x: Add a test for today's fts.c fix.
330 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
332 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
333 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
335 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
337 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
338 Use verify_true instead of verify_expr, to sync with gnulib.
340 2006-01-08 Jim Meyering <jim@meyering.net>
342 * src/date.c (usage): Adjust the formatting of the entries for
343 %::z and %:::z (separate with two spaces, not one) so that help2man
344 formats them properly. Reported by Philip Rowlands.
346 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
348 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
350 2006-01-06 Jim Meyering <jim@meyering.net>
352 * Makefile.maint (copyright-check): Use date +%Y in place of
355 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
356 First off, the attribute should have been `volatile' (not static)
357 to avoid longjmp-related risk of clobber. Secondly, now there is
358 no longer any risk of a local variable being clobbered, so there's
359 no need for any attribute at all.
361 2006-01-05 Jim Meyering <jim@meyering.net>
363 * src/remove.c: Give a few functions the inline attribute.
364 (AD_pop_and_chdir): Use gotos to avoid some duplication.
365 (AD_push): Rewrite an assertion so that the entire computation
366 goes away when assertions are turned off.
368 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
369 It's already defined in "system.h".
370 * Makefile.maint: Add a FIXME comment.
372 2006-01-04 Jim Meyering <jim@meyering.net>
374 * ChangeLog: Remove entries from 2005-10-22 and earlier.
375 * ChangeLog-2005: New file, for entries up to version 5.92.
377 2006-01-03 Jim Meyering <jim@meyering.net>
379 * tests/du/no-x: Also allow a slightly different diagnostic -- the
380 one you get when using openat-enabled fts.c and du (coming soon).
381 * tests/chmod/no-x: Likewise.
382 * tests/chgrp/no-x: Likewise.
384 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
386 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
388 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
389 (restricted_chown): Return it, if the file cannot be accessed due
390 to EPERM, or if no uid or gid are required, or if the file is
391 neither a directory nor a regular file. Rewrite to avoid gotos.
392 (change_file_owner): Handle RC_do_ordinary_chown case.
393 Rewrite to avoid gotos.
394 * tests/chgrp/basic: Make sure we can change the group of
397 * src/date.c (usage): Explain %g, %G, and %V a bit better.
399 2006-01-02 Jim Meyering <jim@meyering.net>
401 * src/copy.c (set_owner): Correct a comment.
403 * src/tail.c (parse_options): Change warning to say that --retry
404 is useful `mainly' (not `only') when following by name.
405 Reported here: http://bugs.debian.org/273781
407 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
409 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
410 * src/copy.c: Include lchmod.h.
411 (copy_internal): Use lchmod rather than chmod.
412 * src/cp.c: Include lchmod.h.
413 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
414 * src/mkdir.c: Include lchmod.h.
415 (usage): Clarify -m's operation.
416 (main): Use lchmod rather than chmod. Don't use lchmod unless the
417 new mode contains bits outside the 777 range.
418 * src/mkfifo.c (usage): Clarify -m's operation.
419 (main): If -m is given, don't invoke chmod; use umask 0 instead.
420 Report an error if -m asks for bits outside the 777 range.
421 * src/mknod.c (usage, main): Likewise.
423 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
425 2005-12-27 Jim Meyering <jim@meyering.net>
427 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
428 (sc_prohibit_assert_without_use): New rule.
429 (syntax-check-rules): Add it to the list.
430 * .x-sc_prohibit_assert_without_use: New empty file.
431 * Makefile.am (EXTRA_DIST): Add it.
433 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
435 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
436 Don't include <assert.h>; it wasn't used.
438 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
440 * src/chown-core.c (restricted_chown):
441 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
442 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
443 | O_NOFOLLOW too, for consistency with other dir-openers.
444 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
445 (is_empty_dir): Likewise.
446 * src/shred.c (wipename): Likewise. Don't bother trying to open
447 dir for writing, since POSIX prohibits it.
449 2005-12-22 Jim Meyering <jim@meyering.net>
451 * tests/help-version: Redirect stderr to /dev/full, to suppress
452 write error diagnostic.
454 2005-12-19 Jim Meyering <jim@meyering.net>
456 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
457 Avoid a minor race condition when `-m MODE' is specified, by using
458 open, fchown, and close rather than just chown. To do that reliably --
459 even with an overly restrictive umask -- ensure that each mkdir,
460 mknod and mkfifo call uses a mode including at least owner-read access.
461 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
462 the subsequent chown (or equivalent open,fchown,close) fails.
463 * tests/misc/mknod: New tests.
464 * tests/misc/Makefile.am (TESTS): Add mknod.
466 2005-12-17 Jim Meyering <jim@meyering.net>
468 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
469 e.g., on a named pipe.
470 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
471 place of all uses, since it is guaranteed (system.h) to be defined.
473 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
475 Add POSIX ACL support
476 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
477 is no requirement for ACL support; particularly, it does not exist
478 on systems that have POSIX ACLs.
479 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
480 * src/cp.c (umask_kill): With default acls, the umask is not to be
481 applied. Remove umask_kill, don't change the process umask, and let
482 the kernel apply the umask where appropriate.
483 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
484 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
486 (copy_reg, copy_internal): Use copy_acl and set_acl
487 instead of fchown/chown. Fix the logic for POSIX ACLs.
488 (chown_succeded): Remove; we now always copy acls and
489 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
490 did a chown before or not.
491 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
492 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
493 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
494 to link with it via $(LIB_ACL), for the utilities that need it.
496 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
498 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
499 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
500 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
501 value is now signified by whether cwd_errno is null.
502 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
503 pointer-to-bool to pointer-to-errno-value. All callers changed.
504 (rm_1): Don't bother setting a local cwd failure flag and then
505 ORing it into the caller's. Just set the caller's.
506 (rm): Use cwd failure errno value to print a slightly-better
509 2005-12-15 Jim Meyering <jim@meyering.net>
511 * src/stat.c (print_it): Properly handle a backslash at the
512 end of a --printf format string. Reported by Paul Eggert.
513 * tests/misc/stat-printf (end-bs): Add a test for the above.
515 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
517 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
518 Don't assume /etc/passwd contains user names; use 'id' instead.
520 2005-12-15 Jim Meyering <jim@meyering.net>
522 stat: revert behavior of --format=FMT (-c)
523 stat: add new option: --printf=FMT
524 * NEWS: Mention this.
525 * src/stat.c (isodigit, octtobin, hextobin): Define.
526 (PRINTF_OPTION): Define.
527 (interpret_backslash_escapes, trailing_delim): New globals.
528 (usage): Document them. Alphabetize on long option names.
529 (print_esc_char): New function.
530 (print_it): Rewrite, in order to handle backslash escapes.
531 (main): Handle new option. Set globals for --format, too.
533 * tests/misc/stat-printf: Test --printf and --format.
534 * tests/misc/Makefile.am (TESTS): Add stat-printf.
536 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
538 * NEWS: sort now reports incompatible options.
539 * src/sort.c (incompatible_options, check_ordering_compatibility):
541 (main): Use them. Don't bother with a usage message for
542 "sort -c a b", for consistency with other error diagnostics.
543 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
546 * src/cat.c (main): Undo previous change. close_stdout already
547 does the check, so the previous change wasn't necessary.
549 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
551 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
553 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
555 Install a more-conservative approach for sort -R. It's the
556 same basic idea as the existing code, except it uses the full ISAAC
557 approach (called the "more kosher" approach in the existing comments).
558 This makes "sort -R" quite a bit slower (about a factor of 2 on my
559 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
560 better to be conservative here at first, and review any performance
561 improvements carefully.
562 * .x-sc_require_config_h: Add src/rand-isaac.c.
563 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
564 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
565 (shred_SOURCES, sort_SOURCES): Remove.
566 (EXTRA_DIST): Add rand-isaac.c.
567 * src/rand-isaac.c: Revert to what used to be in shred.c, without
568 changing it to allow for varying numbers of words in the state.
569 Alter so that we include rand-isaac.c directly rather than
570 compiling it and linking to it. Don't include config.h or
571 system.h; that's the includer's responsibility.
572 Omit functions that are specific to shred.
573 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
574 (isaac_step, struct irand_state):
575 Resurrect these, with the same defns that used to be in shred.c.
576 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
577 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
579 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
580 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
581 (irand_init, irand32, irand_mod):
582 Number of words is constant again.
583 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
584 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
585 * src/sort.c: Likewise.
586 * src/shred.c (fillrand, dopass, main): Undo previous change.
587 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
589 * src/sort.c: Don't include md5.h; it wasn't needed.
590 (struct keyfield): Rename random_hash to random, for consistency
591 with the other member names. All uses changed.
592 (usage): Tweak wording to mention STRING for --seed option.
593 (short_options): Rorder for consistency with other programs.
594 (rand_state): Now a struct, not a pointer to one. All uses changed.
595 (HASH_WORDS, HASH_SIZE): Remove.
596 (get_hash): Remove comments around resbuf size, since we can assume C89.
597 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
598 (keycompare): Adjust to the new get_hash.
600 (badfieldspec): Omit recently-introduced comment; it isn't needed.
601 (main): Don't set need_random simply because gkey has it set; that
602 doesn't necessarily mean we'll need random numbers.
603 Redo seeding to match new get_hash approach.
605 2005-12-10 Jim Meyering <jim@meyering.net>
607 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
609 Avoid shred segfault on 64-bit systems.
610 * src/rand-isaac.c (isaac_refill): Don't try to negate a
611 local of type uint32_t. Make the local an `int' instead.
613 * NEWS: Mention sort's new options.
615 * src/rand-isaac.c (isaac_mix): Declare to be static.
616 Mark all other functions as `extern' so the tight-scope
617 part of `make distcheck' passes once again.
618 * src/rand-isaac.h (isaac_mix): Remove declaration.
620 * src/sort.c (get_hash): Change position of `*' in parameter
621 type to conform with convention.
622 (main): Split a long line so it fits in 80 columns.
623 (keycompare): Remove stray SPACE before TAB that was
624 causing `make distcheck' to fail.
626 * src/shred.c: Don't include gethrxtime.h. No longer needed.
628 * tests/misc/sort-rand: New file: basic tests for the new options.
629 * tests/misc/Makefile.am (TESTS): Add sort-rand.
631 2005-12-10 Frederik Eaton <frederik@ofb.net>
633 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
634 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
635 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
636 Make state size runtime-configurable.
637 (isaac_new, isaac_copy): New functions.
638 * src/rand-isaac.h: New file.
639 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
640 (fillrand, main): Adjust to the fact that the state size is now
641 runtime-configurable.
642 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
643 (usage): Add options --random-sort and --seed to implement a random
645 Include md5.h and rand-isaac.h.
646 (get_hash): New function.
647 (rand_state): New var.
648 (HASH_WORDS, HASH_SIZE): New macros.
650 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
652 * tests/dd/misc: Add test for dd iflags=noatime.
654 2005-12-09 Jim Meyering <jim@meyering.net>
656 * src/sort.c (usage): Mention white space vs -b and -t options.
659 2005-12-09 Eric Blake <ebb9@byu.net>
661 * src/test.c (main): Fix misleading comment.
663 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
665 * NEWS: Mention dd's new noatime flag.
666 * src/system.h (O_NOATIME): Define to 0 if not already defined.
667 * src/dd.c (flags, usage): Add support for noatime flag.
669 2005-12-07 Jim Meyering <jim@meyering.net>
671 Distribute the cvsu script, used only by `make syntax-check'.
672 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
673 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
674 distribute a copy of this script.
675 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
677 * tests/mv/acl: exit-77 before the trap, not after, if we fail
678 to create a temporary directory on another partition.
679 From Andreas Gruenbacher.
681 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
683 * man/basename.x: Cross-reference to dirname and readlink.
684 * man/dirname.x: Cross-reference to basename and readlink.
686 2005-12-05 Andreas Gruenbacher
688 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
689 (set_owner, preserve_author): New functions, factored out of copy_reg.
690 (copy_reg): Use them.
691 (copy_internal): Use them here, too.
693 2005-12-04 Jim Meyering <jim@meyering.net>
695 * src/sleep.c (usage): Say what happens with two or more arguments.
696 Suggested by Justin Pryzby.
698 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
701 2005-12-03 Jim Meyering <jim@meyering.net>
703 * src/rm.c (long_opts): Change the name of each undocumented, for-
704 testing-only option to start with `-', so that it cannot render
705 ambiguous any prefix it happens to share with some other option name.
706 Problem reported by Eric Blake.
707 * src/head.c (long_options): Likewise.
708 * src/tail.c (long_options): Likewise.
710 * tests/misc/head-elide-tail: Update uses of undocumented, for-
711 testing-only --presume* options to start with `---'.
712 * tests/rm/dangling-symlink: Likewise.
713 * tests/rm/dir-no-w: Likewise.
714 * tests/rm/isatty: Likewise.
716 2005-11-30 Jim Meyering <jim@meyering.net>
718 * Makefile.maint: Add a comment about cvsu.
720 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
722 * NEWS: df updates for "none", "proc", inaccessible file systems.
723 * src/df.c (show_point): Ignore inaccessible file systems.
724 (usage): -a includes dummy file systems, not size-0 file systems.
726 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
727 to avoid collision with POSIX name space. All uses changed.
729 2005-11-24 Jim Meyering <jim@meyering.net>
731 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
732 * tests/acl: Add `$0: ' prefix to diagnostics.
734 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
736 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
738 * src/copy.c: Improve performance a bit by optimizing away
739 unnecessary system calls and going to a block size of at least
740 8192 (on normal hosts, anyway). This improved performance 5% on my
741 Debian stable host (2.4.27 kernel, x86, copying from root
742 ext3 file system to itself).
743 Include "buffer-lcm.h".
744 (copy_reg): Omit last argument. All callers changed.
745 Use xmalloc to allocate rather than trusting alloca
746 (which is unwise with large block sizes).
747 Declare locals more locally, if possible.
748 Use uintptr_t words instead of int words, for a bit more speed
749 when looking for null blocks on 64-bit hosts.
750 Optimize away reads of zero bytes on regular files.
751 In the typical case, insist on 8 KiB buffers, at least.
752 Avoid unnecessary extra call to fstat when checking for sparse files.
753 Avoid now-unnecessary cast to off_t, and "0L".
754 Avoid unnecessary test of *new_dst when checking for same owner
757 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
759 * src/remove.c (rm): Don't assume C99 for-loop syntax.
761 2005-11-22 Jim Meyering <jim@meyering.net>
763 * src/remove.c (AD_push): Remove debugging cruft.
765 * tests/rm/unread2 (rm): Change expected diagnostic,
766 `cannot open directory' to `cannot remove', to align with
768 * tests/rm/rm2: Ensure that rm now continues removing entries
769 even after certain types of failure.
771 * src/remove.c: Rewrite. Now, this module is reentrant on systems
772 that provide openat (Solaris), and on systems like Linux+procfs
773 where our openat emulation code is reentrant. This also fixes a
774 few low-probability leaks and eliminates some code that could,
775 in very unusual circumstances, cause rm() (via a callee) to exit.
776 * NEWS: Mention this.
778 * configure.ac: Put copyright dates all on one line so the
779 emacs function that updates them works properly.
781 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
783 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
784 Problem reported by Eric Blake.
785 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
786 we get a standard-conforming compiler. This relies on the new
787 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
788 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
789 m4/c.m4 can go away with Autoconf 2.60 comes out.
791 2005-11-17 Jim Meyering <jim@meyering.net>
793 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
794 (AD_mark_current_as_unremovable): Likewise, but for a local.
797 * tests/mv/acl: Let traps handle removing temporary directories.
799 Expect acl-related tests to fail, until the corresponding
800 patches are committed.
801 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
802 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
804 ACL tests, from Andreas Gruenbacher.
805 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
806 * tests/mv/Makefile.am (TESTS): Add acl.
807 * tests/cp/Makefile.am (TESTS): Add acl.
809 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
811 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
813 * NEWS: Improve quality of ln's diagnostics.
814 * src/ln.c (do_link, usage): Likewise.
815 (do_link): Don't use alloca on a buffer of unbounded size.
817 2005-11-16 Jim Meyering <jim@meyering.net>
819 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
820 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
821 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
823 2005-11-14 Jim Meyering <jim@meyering.net>
825 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
827 2005-11-13 Jim Meyering <jim@meyering.net>
829 * announce-gen: Accept new option, --gpg-key-id=ID and
830 emit a blurb telling how to use the .sig files.
831 * Makefile.cfg (gpg_key_ID): Define.
832 * Makefile.maint (announcement): Use new option and key.
834 Require that most .c files include <config.h>.
835 * Makefile.maint (sc_require_config_h): New rule.
836 (syntax-check-rules): Add it.
837 * .x-sc_require_config_h: New file listing exceptions to the
838 above rule. Some are legit, others are simply grandfathered in.
839 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
841 2005-11-12 Jim Meyering <jim@meyering.net>
843 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
845 2005-11-11 Jim Meyering <jim@meyering.net>
847 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
848 Mention new readlink options in 5.3.0's `New features' section.
849 Spotted by Thomas Hood.
851 2005-11-08 Jim Meyering <jim@meyering.net>
853 * NEWS: Merge in changes from b5_9x branch.
855 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
857 * NEWS: ls now defaults to --time-style='locale', which in turn acts
858 like --time-style='posix-long-iso' if the locale settings are messed up.
859 * src/ls.c (decode_switches): Implement this.
861 2005-11-08 Jim Meyering <jim@meyering.net>
863 * tests/du/2g: s/expensive/very expensive/ in a comment.
866 2005-10-17 Eric Blake <ebb9@byu.net>
868 * src/ls.c (usage): Fix descriptions of --sort, --time.
869 Reported by Vitaly A. Ostanin.
871 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
873 * src/ln.c: Include filenamecat.c.
874 (FILE_BASENAME_CONCAT): Remove.
875 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
876 (main): Use file_name_concat, base_name, and strip_trailing_slashes
877 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
880 2005-11-04 Jim Meyering <jim@meyering.net>
882 * src/du.c (process_file): Don't overflow for files of size >= 2^31
883 on systems with stat.st_blocks of a signed 32-bit type.
884 This bug causes trouble on some AIX 5.1 systems.
885 Report and trivial patch from Paul Townsend:
886 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
887 * NEWS: Mention this.
889 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
890 * tests/du/Makefile.am (TESTS): Add it here.
891 * tests/very-expensive: New file.
892 * tests/Makefile.am (EXTRA_DIST): Add it here.
893 * tests/cp/perm: Mark this test as `very-expensive', too.
895 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
897 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
899 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
901 * src/rm.c (usage): Don't mention rm -d.
903 2005-11-02 Jim Meyering <jim@meyering.net>
905 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
908 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
909 `M+N records in/out' lines don't pollute `make check' output.
911 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
912 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
913 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
914 to indicate that the input file should be piped into the command
915 under test (via `cat FILE | $prog ...').
917 * src/remove.c (remove_entry): Emit a better diagnostic when rm
918 (without -r) fails to remove a directory on a non-Linux system.
919 This change affects only newer Solaris systems (with priv_*
920 functions like priv_allocset). Reported by Keith Thompson.
922 * tests/rm/dir-nonrecur: New file/test for the above fix.
923 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
925 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
927 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
928 POSIX 1002.1-2001 requires.
929 * src/tail.c (parse_obsolete_option): Implement this.
930 Problem reported by Vincent Lefevre.
931 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
932 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
933 (test_vector): Add special cases for _POSIX2_VERSION, and
934 regularize the old ones a bit.
935 * tests/touch/obsolescent: Add y2000 test.
937 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
939 * src/dd.c (skip): Fix off-by-one error reported by
940 Theodoros V. Kalamatianos.
942 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
944 * tests/mkdir/p-3: Require that the test be run as non-root.
945 Problem and trivial fix reported by Theodoros V. Kalamatianos.
947 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
949 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
950 boundary between DEST and SOURCE in the result.
952 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
954 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
955 back to text, to sync with documentation and for backwards
958 2005-10-25 Jim Meyering <jim@meyering.net>
960 * tests/dircolors/simple (other-wr): Add an explicit test for
961 the dircolors bug (NULL-dereference) fixed yesterday.
963 2005-10-24 Jim Meyering <jim@meyering.net>
965 * src/tac.c (tac_file): When determining whether a file is seekable,
966 also test whether it is a tty. Using only the lseek-based test would
967 give a false positive on Solaris. Reported by Peter Fales.
969 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
971 * tests/install/d-slashdot: New test, for "install -d" failure.
972 * tests/install/Makefile.am (TESTS): Add d-slashdot.
973 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
974 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
976 2005-10-24 Jim Meyering <jim@meyering.net>
978 * src/dircolors.c (ls_codes): Add missing comma.
979 Anonymous report and patch from
980 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
982 * src/dircolors.c: Add compile-time assertion that the slack_codes
983 and ls_codes arrays have the same number of elements. This would
984 have prevented the above-fixed bug.
986 * src/expand.c (parse_tab_stops): Add a comment to make this function
987 identical to the one in unexpand.c.
988 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
989 identical to the one in expand.c.
991 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
993 2005-10-23 Jim Meyering <jim@meyering.net>
995 * src/md5sum.c (digest_check, main): Use ptr_align rather than
996 a dangerous pointer-value-to-`unsigned' cast.
997 * NEWS: mention the new sha* programs.
998 * AUTHORS: Add new sha* programs.
1000 2005-08-28 David Madore <david.madore@ens.fr>
1002 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1003 * README: Add their names to the list.
1004 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1005 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1006 Rules for compiling sha-2 utilities
1007 (noinst_HEADERS): Remove checksum.h.
1008 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1010 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1011 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1012 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1013 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1014 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1015 sha384sum, sha512sum test scripts here rather that each in its
1018 2005-08-28 David Madore <david.madore@ens.fr>
1020 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1021 of the FIPS test vectors).
1023 2005-10-23 Jim Meyering <jim@meyering.net>
1025 * configure.ac: Use 6.0-cvs as the version string.
1026 * NEWS: Adjust accordingly.