1 2006-06-11 Jim Meyering <jim@meyering.net>
3 * .gitignore: New file.
5 Setting TIME_STYLE=long-iso in the environment would make the
6 cp/same-file test fail.
7 * tests/envvar-check (vars): Add TIME_STYLE to the list.
8 * tests/cp/same-file: Revert last change.
9 Source the envvar-check script, to ensure that TIME_STYLE
10 settings don't affect these tests.
12 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
14 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
15 uses POSIX time stamp formats. Problem reported by John Nixon in
16 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
18 2006-06-10 Jim Meyering <jim@meyering.net>
20 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
22 Require a "Version N.M" line at the top of the ChangeLog
23 file only when making the actual release, not when running
25 * Makefile.maint (maintainer-distcheck): Don't depend on
27 (alpha beta major): Depend on it here, instead.
29 2006-06-08 Jim Meyering <jim@meyering.net>
31 Ensure that cat works with any of the options, -A -v -e -E -T,
32 when applied to files in /proc and /sys, even when the FIONREAD
33 ioctl produces nonsensical results. Before this change, cat would
34 produce no output (or truncated output), for some linux kernels.
36 * src/cat.c (write_pending): New function, factored out of cat.
37 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
38 that there are bytes to read. Some versions of linux-2.6.16 do that.
39 Write any pending output before returning.
40 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
41 * NEWS: Mention this bug fix.
42 * tests/misc/cat-proc: New file. Test for the above.
43 * tests/misc/Makefile.am (TESTS): Add cat-proc.
45 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
47 * src/expr.c (eval4): Detect overflow properly when multiplying
50 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
52 * NEWS: The 'expr' command now detects and reports integer overflow.
53 (It would be better to use extended precision instead, but that
55 * src/expr.c (integer_overflow): New function.
56 (eval4, eval3): Check for integer overflow.
58 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
60 Fix problems when building with Solaris/SVR4/etc. make, which uses a
61 different and somewhat bogus implementation of VPATH. In the
62 directory tests/misc, rename tests whose names might appear in the
63 Automake-generated rules. For example, we can't use a test named
64 'test', since Automake generates a rule that contains the text
65 "if test -f ./$$tst; ...", and this might expand to something like
66 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
67 which executes the 'test' script rather than the 'test' command.
68 * tests/misc/false-status: Renamed from tests/misc/false.
69 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
70 * tests/misc/sort-merge: Renamed from tests/misc/sort.
71 ($prog): Set to 'sort' rather than to $PROG.
72 * tests/misc/test-diag: Renamed from tests/misc/test.
73 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
74 in case Solaris make has prepended the directory.
75 (TESTS): Adjust to above renamings.
76 * tests/misc/expand: Don't assign to PROG; no longer needed
77 now that Makefile.am sets PROG to the basename.
78 * tests/misc/fold: Likewise.
80 2006-06-03 Jim Meyering <jim@meyering.net>
82 Make `cp --link --no-dereference' work also on systems where the
83 link system call cannot create a hard link to a symbolic link.
84 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
85 the link syscall on a symlink when it would do the wrong thing.
86 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
87 * tests/cp/link-no-deref: New file/test for the above.
88 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
89 * NEWS: Mention the change (doesn't affect Linux).
91 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
93 Fix some porting problems in the test cases reported by
94 Ralf Wildenhues for HP-UX 11.23 in:
95 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
96 * tests/help-version: Don't assume that \< \> works in sed.
97 * tests/misc/close-stdout: Don't assume that >&- works.
99 * tests/touch/no-create-missing: Don't assume that >&- works.
101 2006-05-30 Jim Meyering <jim@meyering.net>
103 * src/ls.c (usage): Add `v' to the list of sorting-related options.
106 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
108 * tests/cp/fail-perm: source lang-default.
109 * tests/rm/inaccessible: Likewise.
111 2006-05-28 Jim Meyering <jim@meyering.net>
113 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
114 Recognize it, too. Reported by Ralf Wildenhues, in
115 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
117 2006-05-27 Jim Meyering <jim@meyering.net>
119 * src/chgrp.c: Support new options: --preserve-root and
120 --no-preserve-root. Somehow this program was skipped when those
121 options were added to chown, chmod, and rm. Reported by
122 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
123 * NEWS: Mention this.
125 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
127 * NEWS: Remove mention of --seed. We'll replace it with something
128 better, and don't want to indicate that it is supported.
129 * src/sort.c (usage): Likewise.
131 2006-05-20 Jim Meyering <jim@meyering.net>
133 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
135 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
136 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
137 FTS_COMFOLLOW. Spotted by Justin Pryzby.
139 * gnupload: Merge changes from automake, retaining the ""--to...
140 kludge to placate overzealous `make distcheck' check.
142 2006-05-19 Jim Meyering <jim@meyering.net>
144 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
145 FTS_TIGHT_CYCLE_CHECK directory traversal option.
146 Reported by Justin Pryzby in http://bugs.debian.org/367691
148 2006-05-15 Jim Meyering <jim@meyering.net>
150 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
153 2006-05-13 Jim Meyering <jim@meyering.net>
155 * tests/mv/no-target-dir: Test two more cases.
157 2006-05-11 Jim Meyering <jim@meyering.net>
159 mv -T DIR EMPTY_DIR no longer fails unconditionally
160 * src/copy.c (copy_internal): Don't manually prohibit a move where
161 the destination is an existing directory. Sometimes doing that is
162 valid. Let the rename system call enforce the rules. That is
163 allowed only when the source is a directory and the destination
164 directory (to be replaced) is empty. Reported by Eric Blake.
165 * tests/mv/no-target-dir: New file/test for this.
166 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
167 * NEWS: Mention this.
169 * tests/mv/atomic: New file/test for yesterday's fix.
170 * tests/mv/Makefile.am (TESTS): Add atomic.
172 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
174 2006-05-10 Jim Meyering <jim@meyering.net>
176 * src/copy.c (copy_internal): Don't explicitly unlink the destination
177 when moving a symlink into the place of an existing non-directory.
178 Reported by Joshua Hudson.
179 * NEWS: mention this.
181 2006-05-07 Jim Meyering <jim@meyering.net>
183 * Makefile.maint (patch-check): Fail if patch generates any output,
184 even merely for changed offsets.
186 * src/c99-to-c89.diff: Adjust to reflect new offsets.
188 * NEWS: Mention changes affecting df, pwd, shred.
190 2006-05-06 Jim Meyering <jim@meyering.net>
192 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
193 system condition where dirent.d_ino != stat.st_ino.
194 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
196 2006-05-06 Eric Blake <ebb9@byu.net>
198 * tests/ls/inode: Expand to test inode from readdir case.
199 * tests/ls/follow-slink: Expand to test broken links encountered
200 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
202 2006-05-06 Eric Blake <ebb9@byu.net>
204 * tests/mv/leak-fd: Work even on case-insensitive file system.
206 2006-05-04 Jim Meyering <jim@meyering.net>
208 * NEWS: Mention the 2006-03-19 pwd-related change that makes
209 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
211 2006-05-03 Jim Meyering <jim@meyering.net>
213 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
214 Use better macro parameter names: s/basename/key_name/,
215 s/basefunc/key_cmp_func. Fix typo in comment.
217 2006-04-29 Eric Blake <ebb9@byu.net>
219 * src/ls.c (main): On systems with d_type, directories_first only
220 implies format_needs_type, not format_needs_stat.
222 2006-05-03 Jim Meyering <jim@meyering.net>
224 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
225 after comma in arg list, from Eric Blake.
227 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
229 * tests/misc/date (relative-3): New test, derived from a bug
230 report by John Thomas McDole.
232 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
234 New option for ls: --group-directories-first.
235 It makes ls list directories before files.
236 * NEWS [New features]: Mention it.
237 * src/ls.c (sort_type): Rearrange to use as an array index when
238 choosing sort function; added new sort_numtypes member for
240 (time_type): Add new time_numtypes member for compile-time check.
241 (directories_first): New global variable.
242 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
243 (long_options): Add --directories-first.
244 (main): Support new option.
245 (is_directory): New function.
246 (extract_dirs_from_files): Use it.
247 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
248 (LIST_SORTFUNCTION_VARIANTS): New macros.
249 (sort_functions): New global variable.
250 (sort_files): Use it.
251 (usage): Document new option.
253 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
255 * src/shred.c (fillrand): The assertion was way too weak, due to
256 what must be a typo. Strengthen it to its intended value.
257 (dopass): Don't use alloca; it's not worth the aggravation here,
258 since it's used only to get a page-aligned buffer, and page
259 alignment doesn't buy us much here. I'm suspicious that alloca
260 causes problems on some hosts, due to a recent bug report by Adam
261 Waltman: http://bugs.gentoo.org/130246.
263 2006-04-18 Jim Meyering <jim@meyering.net>
265 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
266 sha384sum, sha512sum.
268 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
270 * src/chmod.c (describe_change): Adjust to filemode changes.
271 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
272 (print_long_format): Use (new) filemodestring rather than
273 (old) mode_string, so that we get more file types right, at least
274 in theory. Adjust to filemode changes.
275 * src/stat.c (human_access): Likewise.
277 2006-04-18 Jim Meyering <jim@meyering.net>
279 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
280 ignore file. This has never been enabled. Reported by Eric Blake.
282 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
284 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
285 bug in Interix. Just call symlink or link directly. All uses changed.
286 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
287 * src/stat.c (USE_STATVFS): New macro.
288 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
289 (NAMEMAX_FORMAT): define a bit more clearly, now that the
290 statvfs-using code is a bit more regular.
291 * src/system.h (sync) [!HAVE_SYNC]: New macro.
293 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
295 * NEWS: csplit, nl, expr now conform to POSIX better, and are
296 more-compatible with traditional Unix, with respect to regular
298 * src/csplit.c (extract_regexp): Set re_syntax_options to a
299 value that is compatible with what POSIX requires.
300 * src/nl.c (build_type_arg): Likewise.
301 * src/expr.c (docolon): Likewise. Also, don't let anchors match
302 newline; this fixes an incompatibility with tradition and with POSIX.
303 Don't warn about leading ^. POSIX says it is unspecified whether
304 ^ is a special character, which means that implementations can
305 either treat it as special or not, but either way a warning is not
306 allowed (unless the regexp is otherwise invalid). Instead, anchor
307 the expression but treat ^ as an anchor; this is the traditional
308 behavior (e.g., Solaris 10).
309 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
310 and the like as invalid expressions (exit status 2), not as
311 failure of 'expr' (exit status 3). This is more consistent with
313 * tests/expr/basic (fail-a): Adjust exit status to match new expr
314 behavior, for status 2 versus 3.
316 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
317 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
318 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
319 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
320 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
321 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
322 (bre61, bre62): New tests.
323 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
327 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
328 "if !". Do not assume that 'sed' can handle long, newline-free input.
329 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
331 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
333 Adjust to new regex.h API (with new fastmap type), and clean
334 up the regex storage allocation a bit.
336 * src/csplit.c (struct control): Put re_compiled member at the
337 end, since it's large. Change regexpr member from char * to bool;
338 all uses changed. Add new member fastmap.
339 (extract_regexp): regexp arg is now char const *, not char *.
340 Don't bother duplicating the regular expression; it's not needed.
341 Set fastmap from new fastmap member. Don't bother allocating
342 a buffer, as the regexp code does a better job than we do.
343 * src/expr.c (docolon): Allocate and use a fastmap.
344 Don't bother allocating a buffer.
345 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
347 (build_type_arg): New fastmap arg. All uses changed.
348 Don't bother allocating a buffer, but set a fastmap.
349 * src/ptx.c (context_regex_string, word_regex_string): Remove.
350 (context_regex, word_regex): New vars, replacing the above.
352 (struct regex_data): New type.
353 (compile_regex): Renamed from alloc_and_compile_regex, since
354 we no longer allocate storage. Arg is now a struct regex_data *,
355 not a const char *. All uses changed. Don't allocate the fastmap;
356 instead, take it from the caller. Don't convert size_t to int,
357 to avoid arithmetic overflow problems. Don't bother freeing
358 storage afterwards; it's not worth the aggravation.
359 * src/tac.c (compiled_separator_fastmap): New ver.
360 (main): Use it. Don't bother allocating a buffer.
362 2006-03-30 Jim Meyering <jim@meyering.net>
364 * src/dd.c (iwrite): Remove assignment without effect.
365 Reported by Felix Rauch Valenti.
367 2006-03-22 Eric Blake <ebb9@byu.net>
369 * src/ptx.c (usage): Remove mention of --copyright/-C.
370 (main): Alias --copyright to --version plus a deprecation warning.
371 * NEWS: Mention this.
373 2006-03-27 Jim Meyering <jim@meyering.net>
375 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
376 use of strtod. Tiny patch from Nickolai Zeldovich.
378 2006-03-11 Eric Blake <ebb9@byu.net>
380 * tests/misc/dirname: New file.
381 * tests/basename/Makefile.am: Delete.
382 * tests/basename/basic: Move to...
383 * tests/misc/basename: ... this new file. Add some tests,
384 including fixed behavior for //.
385 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
386 * tests/Makefile.am (SUBDIRS): Remove basename.
387 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
389 Improvements to dirname/basename handling on platforms like
390 cygwin with distinct // and with drive letters.
391 * NEWS: Document new behavior.
392 * src/basename.c (main): Don't strip suffix from file system
394 * src/cp.c (target_directory_operand): Use new last_component.
395 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
396 traversing the string.
397 * src/dircolors.c (guess_shell_syntax): Use new last_component.
398 * src/install.c (target_directory_operand, install_file_in_dir):
400 * src/ln.c (target_directory_operand, main): Likewise.
401 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
402 * src/mv.c (target_directory_operand, movefile): Likewise.
403 * src/remove.c (rm_1): Likewise.
404 * src/shred.c (wipename): Likewise.
405 * src/split.c (next_file_name): Likewise.
406 * src/su.c (log_su, run_shell): Likewise.
408 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
410 * NEWS: nohup diagnostics are now more precise, and nohup now
411 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
412 * src/nohup.c (main): Implement this.
413 * tests/misc/nohup: Test the new behavior.
415 2006-03-12 Jim Meyering <jim@meyering.net>
417 * src/copy.c (set_author): Rename function, from preserve_author.
419 * src/remove.c (AD_pop_and_chdir): Use new macro,
420 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
422 * src/system.h (SAME_INODE): Remove definition.
423 Include "same-inode.h", instead.
425 2006-03-11 Eric Blake <ebb9@byu.net>
427 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
429 2006-03-10 Jim Meyering <jim@meyering.net>
431 Fix a bug whereby a user with write access to a directory being removed
432 could cause the removal of that directory to fail with an erroneous
433 diagnostic about a directory cycle. Reported by Vineet Chadha.
435 * NEWS: Mention this.
436 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
437 leave (and try to rmdir) is the one whose dev_ino is being used to
438 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
440 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
442 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
443 * src/dd.c (set_fd_flags): Handle file-creation flags on file
444 descriptors, rather than ignoring them.
445 * tests/dd/misc: Add test cases for append, nofollow, directory,
446 and nolinks flags. Simplify redirection to /dev/null in some cases.
448 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
449 noatime test never tested anything.
451 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
453 * src/dd.c (flags, usage): New flags directory, nolinks.
454 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
456 * src/ls.c (usage): Mention that -f disables --color.
457 Problem reported by Niels Möller.
459 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
461 * man/*.x: Add references to syscalls from utilities of the same name.
463 2006-03-05 Jim Meyering <jim@meyering.net>
465 * tests/help-version: Set SHELL, if not already set, in order to
466 avoid failure when `make check' is run through debuild; dircolors
467 would fail due to lack of $SHELL. Reported by Sven Joachim.
469 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
470 * src/base64.c (wrap_write, do_encode, main): Change type of
471 parameters and locals, wrap_column, form size_t to uintmax_t.
472 (main): Adjust to use xstrtoumax, accordingly.
474 2006-03-03 Jim Meyering <jim@meyering.net>
476 Don't fail when run from an environment with SHELL not a Bourne
477 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
478 * tests/dircolors/simple: Invoke each non-failing test with -b.
479 Reported by Michael Stone.
481 2006-02-27 Jim Meyering <jim@meyering.net>
483 * tests/misc/base64: Derive --decode-using tests from the
486 * tests/misc/base64: Factor out a long constant string.
487 Split lines to stay within 80 columns.
489 * tests/misc/Makefile.am (TESTS): Add base64.
490 * tests/misc/base64: Test base64. From Simon Josefsson.
492 * src/base64.c (do_decode): Use correct type for parameter,
493 ignore_garbage: s/size_t/bool/.
495 * src/base64.c: Don't include .h files already included by system.h:
496 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
497 Include "system.h" before the other lib/*.h header files.
498 Include <sys/types.h> before "system.h".
499 (wrap_write): Remove declaration of unused local, initial_column.
500 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
502 * README: Add base64 to the list.
504 2006-02-17 Simon Josefsson <jas@extundo.com>
507 * AUTHORS: Mention base64.
509 * man/Makefile.am: Build base64.1.
510 * man/base64.x: New file.
511 * src/Makefile.am (bin_PROGRAMS): Add base64.
512 * src/base64.c: New file.
514 2006-02-25 Eric Blake <ebb9@byu.net>
516 In ls, avoid calling stat for --inode (-i), when possible.
517 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
518 * src/system.h: ... here, for use in ...
519 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
521 (gobble_file): Add inode argument.
522 (print_dir): Pass inode if available.
523 (usage): Remove inaccuracy.
525 2006-02-23 Jim Meyering <jim@meyering.net>
527 * TODO: Update/correct some obsolete entries.
529 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
531 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
532 * src/join.c (usage): Likewise.
533 Documentation problem reported by Philip Kensche.
535 2006-02-20 Eric Blake <ebb9@byu.net>
537 * man/rm.x: Update documentation to match previous patch.
539 2006-02-18 Eric Blake <ebb9@byu.net>
541 New option for rm: --interactive=once (-I).
542 * NEWS: Document it, along with change to rm --interactive.
543 * TODO: Remove entry for implementing rm -I
544 * src/rm.c (INTERACTIVE_OPTION): New enum value.
545 (interactive_type): New enum.
546 (long_opts): Let interactive take an optional argument.
547 (interactive_args, interactive_types): New option arguments.
548 (usage): Document -I, --interactive=WHEN. Use program_name
549 instead of a basename.
550 (main): New -I option, new behavior to --interactive.
551 * tests/rm/interactive-once: New tests.
552 * tests/rm/interactive-always: Ditto.
553 * tests/rm/Makefile.am (TESTS): Run them.
555 2006-02-18 Jim Meyering <jim@meyering.net>
557 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
558 expression match more of the target lines, e.g., those that start with
559 `-S,' (short option followed by a comma) or that include `=[...]'.
560 Patch by Nicolas François.
561 Fix the four offenders thus exposed:
562 * src/join.c (usage): Use two spaces (not one) to separate the
563 --first-only option string from its description, so help2man formats
564 the derived man page properly.
565 * src/pr.c (usage): Likewise.
566 * src/uniq.c (usage): Likewise.
567 * src/install.c (usage): Likewise.
569 2006-02-15 Jim Meyering <jim@meyering.net>
571 * Makefile.maint (alpha beta major): For `make major', ensure that the
572 version string is of the form N.N[.N]*, where N is one or more digits.
574 2006-02-14 Jim Meyering <jim@meyering.net>
576 * INSTALL: Update from gnulib.
578 2006-02-13 Jim Meyering <jim@meyering.net>
580 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
582 2006-02-12 Jim Meyering <jim@meyering.net>
584 * Makefile.maint (patch-check): New target.
585 (local-checks-available): Add to the list.
587 2006-02-11 Jim Meyering <jim@meyering.net>
589 * src/c99-to-c89.diff: New file.
590 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
592 * .x-po-check: New file, with exclusions so that `make distcheck'
594 * Makefile.am (EXTRA_DIST): Add .x-po-check.
596 rm -r must remove an empty directory, even if it is inaccessible.
597 * src/remove.c (close_preserve_errno): New function.
598 (fd_to_subdirp): Don't print a diagnostic in this function.
599 Do it from the callers instead, unless rmdir succeeds.
600 (remove_cwd_entries, remove_dir): Adjust callers.
601 * tests/rm/empty-inacc: New test for the above.
602 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
603 * NEWS: Mention this bug fix.
604 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
605 a tiny bit less precise: cannot remove `a/1': ... instead of
606 cannot open directory `a/1': ...
608 * Makefile.maint (syntax-check-rules): Automatically derive this
609 list of sc_-prefixed rule names.
611 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
613 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
614 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
615 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
616 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
617 go away? was that an accident?)
618 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
619 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
620 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
621 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
622 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
623 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
624 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
625 (author_mark_check, makefile_path_separator_check):
626 Output line numbers, to simplify navigation of Emacs *compilation*
628 (sc_prohibit_atoi_atof, sc_file_system):
629 Rework slightly so that Makefile.maint doesn't get reported as a
630 violation of its own syntax rules.
631 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
632 it at run-time (which didn't work with Bison). Fix a makefile typo,
633 caught by Makefile.maint itself: spaces where a tab should be.
634 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
635 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
636 Ignore djgpp and man subdirectories, to avoid false matches with
637 Bison and coreutils, respectively. Use sort -u to remove the
638 resulting duplicates.
639 * gnupload: Rework slightly to avoid bogus warning from
640 sc_two_space_separator_in_usage.
642 2006-02-10 Jim Meyering <jim@meyering.net>
644 Use gzip's --rsyncable option only if it's available.
645 * Makefile.maint (gzip_rsyncable): New variable.
648 2006-02-08 Jim Meyering <jim@meyering.net>
650 * Makefile.maint (local-checks-available): Define in terms of
651 the expansion, $(syntax-check-rules), rather than the single,
652 top-level target `syntax-check', so that it's easier to exclude
653 individual rules (via $(local-checks-to-skip)).
654 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
656 2006-02-07 Jim Meyering <jim@meyering.net>
658 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
659 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
661 * tests/help-version (expected_failure_status_vdir):
662 Redirect an expected disk-full diagnostic to /dev/null.
664 2006-02-06 Jim Meyering <jim@meyering.net>
666 * src/unexpand.c (usage): Use two spaces (not one) to separate the
667 --first-only option string from its description, so help2man formats
668 the derived man page properly.
669 * src/rm.c (usage): Likewise for --no-preserve-root.
670 * src/chown.c (usage): Likewise.
671 * src/chgrp.c (usage): Likewise.
673 Add a rule to ensure that the above doesn't happen again.
674 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
675 (syntax-check-rules): Add it.
676 * .x-sc_two_space_separator_in_usage: New empty file.
677 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
679 2006-02-06 Jim Meyering <jim@meyering.net>
681 * src/cp.c (usage): Use two spaces (not one) to separate each
682 option string from its description, so help2man formats the
683 derived man page properly.
684 * src/mv.c (usage): Likewise.
685 Patch from Nicolas François in http://bugs.debian.org/351601.
687 2006-02-04 Jim Meyering <jim@meyering.net>
689 * src/copy.c (copy_internal): cp -RL would fail when encountering
690 the same directory more than once in the hierarchy beneath a single
691 command-line argument. That is legitimate, e.g. when there are
692 two or more symbolic links, each pointing to some directory that
693 would not otherwise be copied. Reported by Christophe LYON.
694 * tests/cp/cp-deref: New file. Test for today's fix.
695 * tests/cp/Makefile.am (TESTS): Add cp-deref.
696 * NEWS: Document this.
698 2006-02-03 Jim Meyering <jim@meyering.net>
700 * configure.ac: Require automake-1.9.6, not 1.8.3.
702 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
704 * src/od.c (usage): Mention that -t a ignores high order bit.
705 Documentation problem reported by Ed Avis.
707 2006-02-01 Jim Meyering <jim@meyering.net>
709 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
711 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
713 * src/head.c (main): Use a better diagnostic when someone uses a
714 trailing numeric option in an invalid way. Problem reported by
716 * src/tail.c (parse_options): Likewise.
718 2006-01-30 Jim Meyering <jim@meyering.net>
720 * man/wc.x: Include `count' keyword in man page synopsis,
721 per suggestion from http://bugs.debian.org/181585.
723 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
725 * src/df.c (show_dev): If the file system claims to have
726 more available than total blocks, report the number of used
727 blocks as being total - available (a negative number) rather
728 than as garbage. Problem reported by Toralf Foerster.
730 2006-01-24 Jim Meyering <jim@meyering.net>
732 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
733 to put a regular file in O_NONBLOCK mode fails with EPERM.
734 That happens on Linux (up to 2.6.15) when using tail -f on a file with
735 the append-only attribute. Reported by Dean Gaudet. For details,
736 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
737 * NEWS: Mention this fix.
738 * tests/tail-2/append-only: New file. Test for the above.
739 * tests/tail-2/Makefile.am (TESTS): Add append-only.
740 * tests/Makefile.am (check-root): Add tail-2/append-only
742 2006-01-21 Jim Meyering <jim@meyering.net>
744 * NEWS: Mention fts-related improvements and bug fixes.
746 2006-01-19 Jim Meyering <jim@meyering.net>
748 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
749 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
751 2006-01-18 Jim Meyering <jim@meyering.net>
753 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
755 2006-01-17 Jim Meyering <jim@meyering.net>
757 Now that fts no longer changes the current working directory, adjust
758 its clients accordingly -- note that du.c uses fts but doesn't need
759 any adjustment, since it doesn't operate on the actual files,
760 but rather just uses the stat buffers provided by fts.
762 * src/chown-core.c: Include "openat.h".
763 Don't include "lchown.h".
764 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
765 calling openat, lchownat, chownat, rather than open, lchown, chown.
767 * src/chmod.c: Include "openat.h".
768 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
770 * tests/du/long-from-unreadable: New test, to exercise one small
773 2006-01-13 Jim Meyering <jim@meyering.net>
775 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
776 addition of new directories under tests/.
778 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
781 2006-01-12 Jim Meyering <jim@meyering.net>
783 * tests/du/long-sloop: Adjust not to hard-code the expected
784 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
785 from that of GNU libc. Reported by Paul Eggert.
787 * tests/du/long-sloop: Create file at end of symlink chain.
789 * tests/misc/test: New file, with a test for one of the
790 bugs fixed by yesterday's test.c changes.
791 * tests/misc/Makefile.am (TESTS): Add test.
793 2006-01-11 Jim Meyering <jim@meyering.net>
795 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
796 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
797 a very long sequence of symbolic links (not necessarily a loop).
798 * tests/du/Makefile.am (TESTS): Add long-sloop.
800 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
802 * src/test.c (test_syntax_error): Append a newline. All callers
803 changed, except for the ones that didn't already append a newline.
804 Bug reported by Eric Blake.
806 2006-01-11 Jim Meyering <jim@meyering.net>
808 * src/system.h (X2NREALLOC): Now that verify_true is no longer
809 void, cast its result to void, to avoid gcc's warning that
810 ``left-hand operand of comma expression has no effect''.
811 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
813 2006-01-10 Jim Meyering <jim@meyering.net>
815 * tests/chmod/no-x: Add a test for today's fts.c fix.
817 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
819 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
820 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
822 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
824 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
825 Use verify_true instead of verify_expr, to sync with gnulib.
827 2006-01-08 Jim Meyering <jim@meyering.net>
829 * src/date.c (usage): Adjust the formatting of the entries for
830 %::z and %:::z (separate with two spaces, not one) so that help2man
831 formats them properly. Reported by Philip Rowlands.
833 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
835 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
837 2006-01-06 Jim Meyering <jim@meyering.net>
839 * Makefile.maint (copyright-check): Use date +%Y in place of
842 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
843 First off, the attribute should have been `volatile' (not static)
844 to avoid longjmp-related risk of clobber. Secondly, now there is
845 no longer any risk of a local variable being clobbered, so there's
846 no need for any attribute at all.
848 2006-01-05 Jim Meyering <jim@meyering.net>
850 * src/remove.c: Give a few functions the inline attribute.
851 (AD_pop_and_chdir): Use gotos to avoid some duplication.
852 (AD_push): Rewrite an assertion so that the entire computation
853 goes away when assertions are turned off.
855 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
856 It's already defined in "system.h".
857 * Makefile.maint: Add a FIXME comment.
859 2006-01-04 Jim Meyering <jim@meyering.net>
861 * ChangeLog: Remove entries from 2005-10-22 and earlier.
862 * ChangeLog-2005: New file, for entries up to version 5.92.
864 2006-01-03 Jim Meyering <jim@meyering.net>
866 * tests/du/no-x: Also allow a slightly different diagnostic -- the
867 one you get when using openat-enabled fts.c and du (coming soon).
868 * tests/chmod/no-x: Likewise.
869 * tests/chgrp/no-x: Likewise.
871 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
873 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
875 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
876 (restricted_chown): Return it, if the file cannot be accessed due
877 to EPERM, or if no uid or gid are required, or if the file is
878 neither a directory nor a regular file. Rewrite to avoid gotos.
879 (change_file_owner): Handle RC_do_ordinary_chown case.
880 Rewrite to avoid gotos.
881 * tests/chgrp/basic: Make sure we can change the group of
884 * src/date.c (usage): Explain %g, %G, and %V a bit better.
886 2006-01-02 Jim Meyering <jim@meyering.net>
888 * src/copy.c (set_owner): Correct a comment.
890 * src/tail.c (parse_options): Change warning to say that --retry
891 is useful `mainly' (not `only') when following by name.
892 Reported here: http://bugs.debian.org/273781
894 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
896 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
897 * src/copy.c: Include lchmod.h.
898 (copy_internal): Use lchmod rather than chmod.
899 * src/cp.c: Include lchmod.h.
900 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
901 * src/mkdir.c: Include lchmod.h.
902 (usage): Clarify -m's operation.
903 (main): Use lchmod rather than chmod. Don't use lchmod unless the
904 new mode contains bits outside the 777 range.
905 * src/mkfifo.c (usage): Clarify -m's operation.
906 (main): If -m is given, don't invoke chmod; use umask 0 instead.
907 Report an error if -m asks for bits outside the 777 range.
908 * src/mknod.c (usage, main): Likewise.
910 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
912 2005-12-27 Jim Meyering <jim@meyering.net>
914 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
915 (sc_prohibit_assert_without_use): New rule.
916 (syntax-check-rules): Add it to the list.
917 * .x-sc_prohibit_assert_without_use: New empty file.
918 * Makefile.am (EXTRA_DIST): Add it.
920 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
922 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
923 Don't include <assert.h>; it wasn't used.
925 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
927 * src/chown-core.c (restricted_chown):
928 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
929 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
930 | O_NOFOLLOW too, for consistency with other dir-openers.
931 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
932 (is_empty_dir): Likewise.
933 * src/shred.c (wipename): Likewise. Don't bother trying to open
934 dir for writing, since POSIX prohibits it.
936 2005-12-22 Jim Meyering <jim@meyering.net>
938 * tests/help-version: Redirect stderr to /dev/full, to suppress
939 write error diagnostic.
941 2005-12-19 Jim Meyering <jim@meyering.net>
943 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
944 Avoid a minor race condition when `-m MODE' is specified, by using
945 open, fchown, and close rather than just chown. To do that reliably --
946 even with an overly restrictive umask -- ensure that each mkdir,
947 mknod and mkfifo call uses a mode including at least owner-read access.
948 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
949 the subsequent chown (or equivalent open,fchown,close) fails.
950 * tests/misc/mknod: New tests.
951 * tests/misc/Makefile.am (TESTS): Add mknod.
953 2005-12-17 Jim Meyering <jim@meyering.net>
955 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
956 e.g., on a named pipe.
957 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
958 place of all uses, since it is guaranteed (system.h) to be defined.
960 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
962 Add POSIX ACL support
963 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
964 is no requirement for ACL support; particularly, it does not exist
965 on systems that have POSIX ACLs.
966 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
967 * src/cp.c (umask_kill): With default acls, the umask is not to be
968 applied. Remove umask_kill, don't change the process umask, and let
969 the kernel apply the umask where appropriate.
970 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
971 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
973 (copy_reg, copy_internal): Use copy_acl and set_acl
974 instead of fchown/chown. Fix the logic for POSIX ACLs.
975 (chown_succeded): Remove; we now always copy acls and
976 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
977 did a chown before or not.
978 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
979 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
980 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
981 to link with it via $(LIB_ACL), for the utilities that need it.
983 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
985 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
986 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
987 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
988 value is now signified by whether cwd_errno is null.
989 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
990 pointer-to-bool to pointer-to-errno-value. All callers changed.
991 (rm_1): Don't bother setting a local cwd failure flag and then
992 ORing it into the caller's. Just set the caller's.
993 (rm): Use cwd failure errno value to print a slightly-better
996 2005-12-15 Jim Meyering <jim@meyering.net>
998 * src/stat.c (print_it): Properly handle a backslash at the
999 end of a --printf format string. Reported by Paul Eggert.
1000 * tests/misc/stat-printf (end-bs): Add a test for the above.
1002 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1004 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1005 Don't assume /etc/passwd contains user names; use 'id' instead.
1007 2005-12-15 Jim Meyering <jim@meyering.net>
1009 stat: revert behavior of --format=FMT (-c)
1010 stat: add new option: --printf=FMT
1011 * NEWS: Mention this.
1012 * src/stat.c (isodigit, octtobin, hextobin): Define.
1013 (PRINTF_OPTION): Define.
1014 (interpret_backslash_escapes, trailing_delim): New globals.
1015 (usage): Document them. Alphabetize on long option names.
1016 (print_esc_char): New function.
1017 (print_it): Rewrite, in order to handle backslash escapes.
1018 (main): Handle new option. Set globals for --format, too.
1020 * tests/misc/stat-printf: Test --printf and --format.
1021 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1023 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1025 * NEWS: sort now reports incompatible options.
1026 * src/sort.c (incompatible_options, check_ordering_compatibility):
1028 (main): Use them. Don't bother with a usage message for
1029 "sort -c a b", for consistency with other error diagnostics.
1030 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1033 * src/cat.c (main): Undo previous change. close_stdout already
1034 does the check, so the previous change wasn't necessary.
1036 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1038 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1040 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1042 Install a more-conservative approach for sort -R. It's the
1043 same basic idea as the existing code, except it uses the full ISAAC
1044 approach (called the "more kosher" approach in the existing comments).
1045 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1046 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1047 better to be conservative here at first, and review any performance
1048 improvements carefully.
1049 * .x-sc_require_config_h: Add src/rand-isaac.c.
1050 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1051 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1052 (shred_SOURCES, sort_SOURCES): Remove.
1053 (EXTRA_DIST): Add rand-isaac.c.
1054 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1055 changing it to allow for varying numbers of words in the state.
1056 Alter so that we include rand-isaac.c directly rather than
1057 compiling it and linking to it. Don't include config.h or
1058 system.h; that's the includer's responsibility.
1059 Omit functions that are specific to shred.
1060 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1061 (isaac_step, struct irand_state):
1062 Resurrect these, with the same defns that used to be in shred.c.
1063 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1064 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1066 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1067 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1068 (irand_init, irand32, irand_mod):
1069 Number of words is constant again.
1070 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1071 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1072 * src/sort.c: Likewise.
1073 * src/shred.c (fillrand, dopass, main): Undo previous change.
1074 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1076 * src/sort.c: Don't include md5.h; it wasn't needed.
1077 (struct keyfield): Rename random_hash to random, for consistency
1078 with the other member names. All uses changed.
1079 (usage): Tweak wording to mention STRING for --seed option.
1080 (short_options): Rorder for consistency with other programs.
1081 (rand_state): Now a struct, not a pointer to one. All uses changed.
1082 (HASH_WORDS, HASH_SIZE): Remove.
1083 (get_hash): Remove comments around resbuf size, since we can assume C89.
1084 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1085 (keycompare): Adjust to the new get_hash.
1087 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1088 (main): Don't set need_random simply because gkey has it set; that
1089 doesn't necessarily mean we'll need random numbers.
1090 Redo seeding to match new get_hash approach.
1092 2005-12-10 Jim Meyering <jim@meyering.net>
1094 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1096 Avoid shred segfault on 64-bit systems.
1097 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1098 local of type uint32_t. Make the local an `int' instead.
1100 * NEWS: Mention sort's new options.
1102 * src/rand-isaac.c (isaac_mix): Declare to be static.
1103 Mark all other functions as `extern' so the tight-scope
1104 part of `make distcheck' passes once again.
1105 * src/rand-isaac.h (isaac_mix): Remove declaration.
1107 * src/sort.c (get_hash): Change position of `*' in parameter
1108 type to conform with convention.
1109 (main): Split a long line so it fits in 80 columns.
1110 (keycompare): Remove stray SPACE before TAB that was
1111 causing `make distcheck' to fail.
1113 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1115 * tests/misc/sort-rand: New file: basic tests for the new options.
1116 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1118 2005-12-10 Frederik Eaton <frederik@ofb.net>
1120 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1121 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1122 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1123 Make state size runtime-configurable.
1124 (isaac_new, isaac_copy): New functions.
1125 * src/rand-isaac.h: New file.
1126 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1127 (fillrand, main): Adjust to the fact that the state size is now
1128 runtime-configurable.
1129 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1130 (usage): Add options --random-sort and --seed to implement a random
1132 Include md5.h and rand-isaac.h.
1133 (get_hash): New function.
1134 (rand_state): New var.
1135 (HASH_WORDS, HASH_SIZE): New macros.
1137 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1139 * tests/dd/misc: Add test for dd iflags=noatime.
1141 2005-12-09 Jim Meyering <jim@meyering.net>
1143 * src/sort.c (usage): Mention white space vs -b and -t options.
1146 2005-12-09 Eric Blake <ebb9@byu.net>
1148 * src/test.c (main): Fix misleading comment.
1150 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1152 * NEWS: Mention dd's new noatime flag.
1153 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1154 * src/dd.c (flags, usage): Add support for noatime flag.
1156 2005-12-07 Jim Meyering <jim@meyering.net>
1158 Distribute the cvsu script, used only by `make syntax-check'.
1159 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1160 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1161 distribute a copy of this script.
1162 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1164 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1165 to create a temporary directory on another partition.
1166 From Andreas Gruenbacher.
1168 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1170 * man/basename.x: Cross-reference to dirname and readlink.
1171 * man/dirname.x: Cross-reference to basename and readlink.
1173 2005-12-05 Andreas Gruenbacher
1175 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1176 (set_owner, preserve_author): New functions, factored out of copy_reg.
1177 (copy_reg): Use them.
1178 (copy_internal): Use them here, too.
1180 2005-12-04 Jim Meyering <jim@meyering.net>
1182 * src/sleep.c (usage): Say what happens with two or more arguments.
1183 Suggested by Justin Pryzby.
1185 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1188 2005-12-03 Jim Meyering <jim@meyering.net>
1190 * src/rm.c (long_opts): Change the name of each undocumented, for-
1191 testing-only option to start with `-', so that it cannot render
1192 ambiguous any prefix it happens to share with some other option name.
1193 Problem reported by Eric Blake.
1194 * src/head.c (long_options): Likewise.
1195 * src/tail.c (long_options): Likewise.
1197 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1198 testing-only --presume* options to start with `---'.
1199 * tests/rm/dangling-symlink: Likewise.
1200 * tests/rm/dir-no-w: Likewise.
1201 * tests/rm/isatty: Likewise.
1203 2005-11-30 Jim Meyering <jim@meyering.net>
1205 * Makefile.maint: Add a comment about cvsu.
1207 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1209 * NEWS: df updates for "none", "proc", inaccessible file systems.
1210 * src/df.c (show_point): Ignore inaccessible file systems.
1211 (usage): -a includes dummy file systems, not size-0 file systems.
1213 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1214 to avoid collision with POSIX name space. All uses changed.
1216 2005-11-24 Jim Meyering <jim@meyering.net>
1218 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1219 * tests/acl: Add `$0: ' prefix to diagnostics.
1221 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1223 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1225 * src/copy.c: Improve performance a bit by optimizing away
1226 unnecessary system calls and going to a block size of at least
1227 8192 (on normal hosts, anyway). This improved performance 5% on my
1228 Debian stable host (2.4.27 kernel, x86, copying from root
1229 ext3 file system to itself).
1230 Include "buffer-lcm.h".
1231 (copy_reg): Omit last argument. All callers changed.
1232 Use xmalloc to allocate rather than trusting alloca
1233 (which is unwise with large block sizes).
1234 Declare locals more locally, if possible.
1235 Use uintptr_t words instead of int words, for a bit more speed
1236 when looking for null blocks on 64-bit hosts.
1237 Optimize away reads of zero bytes on regular files.
1238 In the typical case, insist on 8 KiB buffers, at least.
1239 Avoid unnecessary extra call to fstat when checking for sparse files.
1240 Avoid now-unnecessary cast to off_t, and "0L".
1241 Avoid unnecessary test of *new_dst when checking for same owner
1244 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1246 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1248 2005-11-22 Jim Meyering <jim@meyering.net>
1250 * src/remove.c (AD_push): Remove debugging cruft.
1252 * tests/rm/unread2 (rm): Change expected diagnostic,
1253 `cannot open directory' to `cannot remove', to align with
1255 * tests/rm/rm2: Ensure that rm now continues removing entries
1256 even after certain types of failure.
1258 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1259 that provide openat (Solaris), and on systems like Linux+procfs
1260 where our openat emulation code is reentrant. This also fixes a
1261 few low-probability leaks and eliminates some code that could,
1262 in very unusual circumstances, cause rm() (via a callee) to exit.
1263 * NEWS: Mention this.
1265 * configure.ac: Put copyright dates all on one line so the
1266 emacs function that updates them works properly.
1268 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1270 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1271 Problem reported by Eric Blake.
1272 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1273 we get a standard-conforming compiler. This relies on the new
1274 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1275 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1276 m4/c.m4 can go away with Autoconf 2.60 comes out.
1278 2005-11-17 Jim Meyering <jim@meyering.net>
1280 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1281 (AD_mark_current_as_unremovable): Likewise, but for a local.
1284 * tests/mv/acl: Let traps handle removing temporary directories.
1286 Expect acl-related tests to fail, until the corresponding
1287 patches are committed.
1288 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1289 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1291 ACL tests, from Andreas Gruenbacher.
1292 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1293 * tests/mv/Makefile.am (TESTS): Add acl.
1294 * tests/cp/Makefile.am (TESTS): Add acl.
1296 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1298 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1300 * NEWS: Improve quality of ln's diagnostics.
1301 * src/ln.c (do_link, usage): Likewise.
1302 (do_link): Don't use alloca on a buffer of unbounded size.
1304 2005-11-16 Jim Meyering <jim@meyering.net>
1306 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1307 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1308 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1309 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1310 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1312 2005-11-14 Jim Meyering <jim@meyering.net>
1314 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1316 2005-11-13 Jim Meyering <jim@meyering.net>
1318 * announce-gen: Accept new option, --gpg-key-id=ID and
1319 emit a blurb telling how to use the .sig files.
1320 * Makefile.cfg (gpg_key_ID): Define.
1321 * Makefile.maint (announcement): Use new option and key.
1323 Require that most .c files include <config.h>.
1324 * Makefile.maint (sc_require_config_h): New rule.
1325 (syntax-check-rules): Add it.
1326 * .x-sc_require_config_h: New file listing exceptions to the
1327 above rule. Some are legit, others are simply grandfathered in.
1328 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1330 2005-11-12 Jim Meyering <jim@meyering.net>
1332 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1334 2005-11-11 Jim Meyering <jim@meyering.net>
1336 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1337 Mention new readlink options in 5.3.0's `New features' section.
1338 Spotted by Thomas Hood.
1340 2005-11-08 Jim Meyering <jim@meyering.net>
1342 * NEWS: Merge in changes from b5_9x branch.
1344 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1346 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1347 like --time-style='posix-long-iso' if the locale settings are messed up.
1348 * src/ls.c (decode_switches): Implement this.
1350 2005-11-08 Jim Meyering <jim@meyering.net>
1352 * tests/du/2g: s/expensive/very expensive/ in a comment.
1355 2005-10-17 Eric Blake <ebb9@byu.net>
1357 * src/ls.c (usage): Fix descriptions of --sort, --time.
1358 Reported by Vitaly A. Ostanin.
1360 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1362 * src/ln.c: Include filenamecat.c.
1363 (FILE_BASENAME_CONCAT): Remove.
1364 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1365 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1366 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1369 2005-11-04 Jim Meyering <jim@meyering.net>
1371 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1372 on systems with stat.st_blocks of a signed 32-bit type.
1373 This bug causes trouble on some AIX 5.1 systems.
1374 Report and trivial patch from Paul Townsend:
1375 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1376 * NEWS: Mention this.
1378 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1379 * tests/du/Makefile.am (TESTS): Add it here.
1380 * tests/very-expensive: New file.
1381 * tests/Makefile.am (EXTRA_DIST): Add it here.
1382 * tests/cp/perm: Mark this test as `very-expensive', too.
1384 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1386 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1388 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1390 * src/rm.c (usage): Don't mention rm -d.
1392 2005-11-02 Jim Meyering <jim@meyering.net>
1394 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1395 From Andreas Schwab.
1397 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1398 `M+N records in/out' lines don't pollute `make check' output.
1400 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1401 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1402 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1403 to indicate that the input file should be piped into the command
1404 under test (via `cat FILE | $prog ...').
1406 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1407 (without -r) fails to remove a directory on a non-Linux system.
1408 This change affects only newer Solaris systems (with priv_*
1409 functions like priv_allocset). Reported by Keith Thompson.
1411 * tests/rm/dir-nonrecur: New file/test for the above fix.
1412 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1414 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1416 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1417 POSIX 1002.1-2001 requires.
1418 * src/tail.c (parse_obsolete_option): Implement this.
1419 Problem reported by Vincent Lefevre.
1420 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1421 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1422 (test_vector): Add special cases for _POSIX2_VERSION, and
1423 regularize the old ones a bit.
1424 * tests/touch/obsolescent: Add y2000 test.
1426 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1428 * src/dd.c (skip): Fix off-by-one error reported by
1429 Theodoros V. Kalamatianos.
1431 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1433 * tests/mkdir/p-3: Require that the test be run as non-root.
1434 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1436 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1438 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1439 boundary between DEST and SOURCE in the result.
1441 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1443 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1444 back to text, to sync with documentation and for backwards
1447 2005-10-25 Jim Meyering <jim@meyering.net>
1449 * tests/dircolors/simple (other-wr): Add an explicit test for
1450 the dircolors bug (NULL-dereference) fixed yesterday.
1452 2005-10-24 Jim Meyering <jim@meyering.net>
1454 * src/tac.c (tac_file): When determining whether a file is seekable,
1455 also test whether it is a tty. Using only the lseek-based test would
1456 give a false positive on Solaris. Reported by Peter Fales.
1458 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1460 * tests/install/d-slashdot: New test, for "install -d" failure.
1461 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1462 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1463 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1465 2005-10-24 Jim Meyering <jim@meyering.net>
1467 * src/dircolors.c (ls_codes): Add missing comma.
1468 Anonymous report and patch from
1469 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1471 * src/dircolors.c: Add compile-time assertion that the slack_codes
1472 and ls_codes arrays have the same number of elements. This would
1473 have prevented the above-fixed bug.
1475 * src/expand.c (parse_tab_stops): Add a comment to make this function
1476 identical to the one in unexpand.c.
1477 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1478 identical to the one in expand.c.
1480 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1482 2005-10-23 Jim Meyering <jim@meyering.net>
1484 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1485 a dangerous pointer-value-to-`unsigned' cast.
1486 * NEWS: mention the new sha* programs.
1487 * AUTHORS: Add new sha* programs.
1489 2005-08-28 David Madore <david.madore@ens.fr>
1491 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1492 * README: Add their names to the list.
1493 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1494 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1495 Rules for compiling sha-2 utilities
1496 (noinst_HEADERS): Remove checksum.h.
1497 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1499 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1500 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1501 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1502 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1503 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1504 sha384sum, sha512sum test scripts here rather that each in its
1507 2005-08-28 David Madore <david.madore@ens.fr>
1509 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1510 of the FIPS test vectors).
1512 2005-10-23 Jim Meyering <jim@meyering.net>
1514 * configure.ac: Use 6.0-cvs as the version string.
1515 * NEWS: Adjust accordingly.