1 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
5 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
6 * src/dd.c (set_fd_flags): Handle file-creation flags on file
7 descriptors, rather than ignoring them.
8 * tests/dd/misc: Add test cases for append, nofollow, directory,
9 and nolinks flags. Simplify redirection to /dev/null in some cases.
11 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
12 noatime test never tested anything.
14 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
16 * src/dd.c (flags, usage): New flags directory, nolinks.
17 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
19 * src/ls.c (usage): Mention that -f disables --color.
20 Problem reported by Niels Möller.
22 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
24 * man/*.x: Add references to syscalls from utilities of the same name.
26 2006-03-05 Jim Meyering <jim@meyering.net>
28 * tests/help-version: Set SHELL, if not already set, in order to
29 avoid failure when `make check' is run through debuild; dircolors
30 would fail due to lack of $SHELL. Reported by Sven Joachim.
32 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
33 * src/base64.c (wrap_write, do_encode, main): Change type of
34 parameters and locals, wrap_column, form size_t to uintmax_t.
35 (main): Adjust to use xstrtoumax, accordingly.
37 2006-03-03 Jim Meyering <jim@meyering.net>
39 Don't fail when run from an environment with SHELL not a Bourne
40 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
41 * tests/dircolors/simple: Invoke each non-failing test with -b.
42 Reported by Michael Stone.
44 2006-02-27 Jim Meyering <jim@meyering.net>
46 * tests/misc/base64: Derive --decode-using tests from the
49 * tests/misc/base64: Factor out a long constant string.
50 Split lines to stay within 80 columns.
52 * tests/misc/Makefile.am (TESTS): Add base64.
53 * tests/misc/base64: Test base64. From Simon Josefsson.
55 * src/base64.c (do_decode): Use correct type for parameter,
56 ignore_garbage: s/size_t/bool/.
58 * src/base64.c: Don't include .h files already included by system.h:
59 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
60 Include "system.h" before the other lib/*.h header files.
61 Include <sys/types.h> before "system.h".
62 (wrap_write): Remove declaration of unused local, initial_column.
63 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
65 * README: Add base64 to the list.
67 2006-02-17 Simon Josefsson <jas@extundo.com>
70 * AUTHORS: Mention base64.
72 * man/Makefile.am: Build base64.1.
73 * man/base64.x: New file.
74 * src/Makefile.am (bin_PROGRAMS): Add base64.
75 * src/base64.c: New file.
77 2006-02-25 Eric Blake <ebb9@byu.net>
79 In ls, avoid calling stat for --inode (-i), when possible.
80 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
81 * src/system.h: ... here, for use in ...
82 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
84 (gobble_file): Add inode argument.
85 (print_dir): Pass inode if available.
86 (usage): Remove inaccuracy.
88 2006-02-23 Jim Meyering <jim@meyering.net>
90 * TODO: Update/correct some obsolete entries.
92 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
94 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
95 * src/join.c (usage): Likewise.
96 Documentation problem reported by Philip Kensche.
98 2006-02-20 Eric Blake <ebb9@byu.net>
100 * man/rm.x: Update documentation to match previous patch.
102 2006-02-18 Eric Blake <ebb9@byu.net>
104 New option for rm: --interactive=once (-I).
105 * NEWS: Document it, along with change to rm --interactive.
106 * TODO: Remove entry for implementing rm -I
107 * src/rm.c (INTERACTIVE_OPTION): New enum value.
108 (interactive_type): New enum.
109 (long_opts): Let interactive take an optional argument.
110 (interactive_args, interactive_types): New option arguments.
111 (usage): Document -I, --interactive=WHEN. Use program_name
112 instead of a basename.
113 (main): New -I option, new behavior to --interactive.
114 * tests/rm/interactive-once: New tests.
115 * tests/rm/interactive-always: Ditto.
116 * tests/rm/Makefile.am (TESTS): Run them.
118 2006-02-18 Jim Meyering <jim@meyering.net>
120 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
121 expression match more of the target lines, e.g., those that start with
122 `-S,' (short option followed by a comma) or that include `=[...]'.
123 Patch by Nicolas François.
124 Fix the four offenders thus exposed:
125 * src/join.c (usage): Use two spaces (not one) to separate the
126 --first-only option string from its description, so help2man formats
127 the derived man page properly.
128 * src/pr.c (usage): Likewise.
129 * src/uniq.c (usage): Likewise.
130 * src/install.c (usage): Likewise.
132 2006-02-15 Jim Meyering <jim@meyering.net>
134 * Makefile.maint (alpha beta major): For `make major', ensure that the
135 version string is of the form N.N[.N]*, where N is one or more digits.
137 2006-02-14 Jim Meyering <jim@meyering.net>
139 * INSTALL: Update from gnulib.
141 2006-02-13 Jim Meyering <jim@meyering.net>
143 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
145 2006-02-12 Jim Meyering <jim@meyering.net>
147 * Makefile.maint (patch-check): New target.
148 (local-checks-available): Add to the list.
150 2006-02-11 Jim Meyering <jim@meyering.net>
152 * src/c99-to-c89.diff: New file.
153 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
155 * .x-po-check: New file, with exclusions so that `make distcheck'
157 * Makefile.am (EXTRA_DIST): Add .x-po-check.
159 rm -r must remove an empty directory, even if it is inaccessible.
160 * src/remove.c (close_preserve_errno): New function.
161 (fd_to_subdirp): Don't print a diagnostic in this function.
162 Do it from the callers instead, unless rmdir succeeds.
163 (remove_cwd_entries, remove_dir): Adjust callers.
164 * tests/rm/empty-inacc: New test for the above.
165 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
166 * NEWS: Mention this bug fix.
167 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
168 a tiny bit less precise: cannot remove `a/1': ... instead of
169 cannot open directory `a/1': ...
171 * Makefile.maint (syntax-check-rules): Automatically derive this
172 list of sc_-prefixed rule names.
174 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
176 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
177 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
178 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
179 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
180 go away? was that an accident?)
181 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
182 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
183 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
184 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
185 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
186 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
187 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
188 (author_mark_check, makefile_path_separator_check):
189 Output line numbers, to simplify navigation of Emacs *compilation*
191 (sc_prohibit_atoi_atof, sc_file_system):
192 Rework slightly so that Makefile.maint doesn't get reported as a
193 violation of its own syntax rules.
194 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
195 it at run-time (which didn't work with Bison). Fix a makefile typo,
196 caught by Makefile.maint itself: spaces where a tab should be.
197 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
198 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
199 Ignore djgpp and man subdirectories, to avoid false matches with
200 Bison and coreutils, respectively. Use sort -u to remove the
201 resulting duplicates.
202 * gnupload: Rework slightly to avoid bogus warning from
203 sc_two_space_separator_in_usage.
205 2006-02-10 Jim Meyering <jim@meyering.net>
207 Use gzip's --rsyncable option only if it's available.
208 * Makefile.maint (gzip_rsyncable): New variable.
211 2006-02-08 Jim Meyering <jim@meyering.net>
213 * Makefile.maint (local-checks-available): Define in terms of
214 the expansion, $(syntax-check-rules), rather than the single,
215 top-level target `syntax-check', so that it's easier to exclude
216 individual rules (via $(local-checks-to-skip)).
217 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
219 2006-02-07 Jim Meyering <jim@meyering.net>
221 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
222 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
224 * tests/help-version (expected_failure_status_vdir):
225 Redirect an expected disk-full diagnostic to /dev/null.
227 2006-02-06 Jim Meyering <jim@meyering.net>
229 * src/unexpand.c (usage): Use two spaces (not one) to separate the
230 --first-only option string from its description, so help2man formats
231 the derived man page properly.
232 * src/rm.c (usage): Likewise for --no-preserve-root.
233 * src/chown.c (usage): Likewise.
234 * src/chgrp.c (usage): Likewise.
236 Add a rule to ensure that the above doesn't happen again.
237 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
238 (syntax-check-rules): Add it.
239 * .x-sc_two_space_separator_in_usage: New empty file.
240 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
242 2006-02-06 Jim Meyering <jim@meyering.net>
244 * src/cp.c (usage): Use two spaces (not one) to separate each
245 option string from its description, so help2man formats the
246 derived man page properly.
247 * src/mv.c (usage): Likewise.
248 Patch from Nicolas François in http://bugs.debian.org/351601.
250 2006-02-04 Jim Meyering <jim@meyering.net>
252 * src/copy.c (copy_internal): cp -RL would fail when encountering
253 the same directory more than once in the hierarchy beneath a single
254 command-line argument. That is legitimate, e.g. when there are
255 two or more symbolic links, each pointing to some directory that
256 would not otherwise be copied. Reported by Christophe LYON.
257 * tests/cp/cp-deref: New file. Test for today's fix.
258 * tests/cp/Makefile.am (TESTS): Add cp-deref.
259 * NEWS: Document this.
261 2006-02-03 Jim Meyering <jim@meyering.net>
263 * configure.ac: Require automake-1.9.6, not 1.8.3.
265 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
267 * src/od.c (usage): Mention that -t a ignores high order bit.
268 Documentation problem reported by Ed Avis.
270 2006-02-01 Jim Meyering <jim@meyering.net>
272 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
274 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
276 * src/head.c (main): Use a better diagnostic when someone uses a
277 trailing numeric option in an invalid way. Problem reported by
279 * src/tail.c (parse_options): Likewise.
281 2006-01-30 Jim Meyering <jim@meyering.net>
283 * man/wc.x: Include `count' keyword in man page synopsis,
284 per suggestion from http://bugs.debian.org/181585.
286 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
288 * src/df.c (show_dev): If the file system claims to have
289 more available than total blocks, report the number of used
290 blocks as being total - available (a negative number) rather
291 than as garbage. Problem reported by Toralf Foerster.
293 2006-01-24 Jim Meyering <jim@meyering.net>
295 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
296 to put a regular file in O_NONBLOCK mode fails with EPERM.
297 That happens on Linux (up to 2.6.15) when using tail -f on a file with
298 the append-only attribute. Reported by Dean Gaudet. For details,
299 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
300 * NEWS: Mention this fix.
301 * tests/tail-2/append-only: New file. Test for the above.
302 * tests/tail-2/Makefile.am (TESTS): Add append-only.
303 * tests/Makefile.am (check-root): Add tail-2/append-only
305 2006-01-21 Jim Meyering <jim@meyering.net>
307 * NEWS: Mention fts-related improvements and bug fixes.
309 2006-01-19 Jim Meyering <jim@meyering.net>
311 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
312 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
314 2006-01-18 Jim Meyering <jim@meyering.net>
316 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
318 2006-01-17 Jim Meyering <jim@meyering.net>
320 Now that fts no longer changes the current working directory, adjust
321 its clients accordingly -- note that du.c uses fts but doesn't need
322 any adjustment, since it doesn't operate on the actual files,
323 but rather just uses the stat buffers provided by fts.
325 * src/chown-core.c: Include "openat.h".
326 Don't include "lchown.h".
327 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
328 calling openat, lchownat, chownat, rather than open, lchown, chown.
330 * src/chmod.c: Include "openat.h".
331 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
333 * tests/du/long-from-unreadable: New test, to exercise one small
336 2006-01-13 Jim Meyering <jim@meyering.net>
338 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
339 addition of new directories under tests/.
341 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
344 2006-01-12 Jim Meyering <jim@meyering.net>
346 * tests/du/long-sloop: Adjust not to hard-code the expected
347 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
348 from that of GNU libc. Reported by Paul Eggert.
350 * tests/du/long-sloop: Create file at end of symlink chain.
352 * tests/misc/test: New file, with a test for one of the
353 bugs fixed by yesterday's test.c changes.
354 * tests/misc/Makefile.am (TESTS): Add test.
356 2006-01-11 Jim Meyering <jim@meyering.net>
358 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
359 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
360 a very long sequence of symbolic links (not necessarily a loop).
361 * tests/du/Makefile.am (TESTS): Add long-sloop.
363 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
365 * src/test.c (test_syntax_error): Append a newline. All callers
366 changed, except for the ones that didn't already append a newline.
367 Bug reported by Eric Blake.
369 2006-01-11 Jim Meyering <jim@meyering.net>
371 * src/system.h (X2NREALLOC): Now that verify_true is no longer
372 void, cast its result to void, to avoid gcc's warning that
373 ``left-hand operand of comma expression has no effect''.
374 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
376 2006-01-10 Jim Meyering <jim@meyering.net>
378 * tests/chmod/no-x: Add a test for today's fts.c fix.
380 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
382 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
383 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
385 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
387 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
388 Use verify_true instead of verify_expr, to sync with gnulib.
390 2006-01-08 Jim Meyering <jim@meyering.net>
392 * src/date.c (usage): Adjust the formatting of the entries for
393 %::z and %:::z (separate with two spaces, not one) so that help2man
394 formats them properly. Reported by Philip Rowlands.
396 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
398 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
400 2006-01-06 Jim Meyering <jim@meyering.net>
402 * Makefile.maint (copyright-check): Use date +%Y in place of
405 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
406 First off, the attribute should have been `volatile' (not static)
407 to avoid longjmp-related risk of clobber. Secondly, now there is
408 no longer any risk of a local variable being clobbered, so there's
409 no need for any attribute at all.
411 2006-01-05 Jim Meyering <jim@meyering.net>
413 * src/remove.c: Give a few functions the inline attribute.
414 (AD_pop_and_chdir): Use gotos to avoid some duplication.
415 (AD_push): Rewrite an assertion so that the entire computation
416 goes away when assertions are turned off.
418 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
419 It's already defined in "system.h".
420 * Makefile.maint: Add a FIXME comment.
422 2006-01-04 Jim Meyering <jim@meyering.net>
424 * ChangeLog: Remove entries from 2005-10-22 and earlier.
425 * ChangeLog-2005: New file, for entries up to version 5.92.
427 2006-01-03 Jim Meyering <jim@meyering.net>
429 * tests/du/no-x: Also allow a slightly different diagnostic -- the
430 one you get when using openat-enabled fts.c and du (coming soon).
431 * tests/chmod/no-x: Likewise.
432 * tests/chgrp/no-x: Likewise.
434 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
436 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
438 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
439 (restricted_chown): Return it, if the file cannot be accessed due
440 to EPERM, or if no uid or gid are required, or if the file is
441 neither a directory nor a regular file. Rewrite to avoid gotos.
442 (change_file_owner): Handle RC_do_ordinary_chown case.
443 Rewrite to avoid gotos.
444 * tests/chgrp/basic: Make sure we can change the group of
447 * src/date.c (usage): Explain %g, %G, and %V a bit better.
449 2006-01-02 Jim Meyering <jim@meyering.net>
451 * src/copy.c (set_owner): Correct a comment.
453 * src/tail.c (parse_options): Change warning to say that --retry
454 is useful `mainly' (not `only') when following by name.
455 Reported here: http://bugs.debian.org/273781
457 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
459 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
460 * src/copy.c: Include lchmod.h.
461 (copy_internal): Use lchmod rather than chmod.
462 * src/cp.c: Include lchmod.h.
463 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
464 * src/mkdir.c: Include lchmod.h.
465 (usage): Clarify -m's operation.
466 (main): Use lchmod rather than chmod. Don't use lchmod unless the
467 new mode contains bits outside the 777 range.
468 * src/mkfifo.c (usage): Clarify -m's operation.
469 (main): If -m is given, don't invoke chmod; use umask 0 instead.
470 Report an error if -m asks for bits outside the 777 range.
471 * src/mknod.c (usage, main): Likewise.
473 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
475 2005-12-27 Jim Meyering <jim@meyering.net>
477 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
478 (sc_prohibit_assert_without_use): New rule.
479 (syntax-check-rules): Add it to the list.
480 * .x-sc_prohibit_assert_without_use: New empty file.
481 * Makefile.am (EXTRA_DIST): Add it.
483 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
485 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
486 Don't include <assert.h>; it wasn't used.
488 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
490 * src/chown-core.c (restricted_chown):
491 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
492 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
493 | O_NOFOLLOW too, for consistency with other dir-openers.
494 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
495 (is_empty_dir): Likewise.
496 * src/shred.c (wipename): Likewise. Don't bother trying to open
497 dir for writing, since POSIX prohibits it.
499 2005-12-22 Jim Meyering <jim@meyering.net>
501 * tests/help-version: Redirect stderr to /dev/full, to suppress
502 write error diagnostic.
504 2005-12-19 Jim Meyering <jim@meyering.net>
506 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
507 Avoid a minor race condition when `-m MODE' is specified, by using
508 open, fchown, and close rather than just chown. To do that reliably --
509 even with an overly restrictive umask -- ensure that each mkdir,
510 mknod and mkfifo call uses a mode including at least owner-read access.
511 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
512 the subsequent chown (or equivalent open,fchown,close) fails.
513 * tests/misc/mknod: New tests.
514 * tests/misc/Makefile.am (TESTS): Add mknod.
516 2005-12-17 Jim Meyering <jim@meyering.net>
518 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
519 e.g., on a named pipe.
520 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
521 place of all uses, since it is guaranteed (system.h) to be defined.
523 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
525 Add POSIX ACL support
526 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
527 is no requirement for ACL support; particularly, it does not exist
528 on systems that have POSIX ACLs.
529 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
530 * src/cp.c (umask_kill): With default acls, the umask is not to be
531 applied. Remove umask_kill, don't change the process umask, and let
532 the kernel apply the umask where appropriate.
533 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
534 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
536 (copy_reg, copy_internal): Use copy_acl and set_acl
537 instead of fchown/chown. Fix the logic for POSIX ACLs.
538 (chown_succeded): Remove; we now always copy acls and
539 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
540 did a chown before or not.
541 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
542 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
543 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
544 to link with it via $(LIB_ACL), for the utilities that need it.
546 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
548 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
549 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
550 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
551 value is now signified by whether cwd_errno is null.
552 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
553 pointer-to-bool to pointer-to-errno-value. All callers changed.
554 (rm_1): Don't bother setting a local cwd failure flag and then
555 ORing it into the caller's. Just set the caller's.
556 (rm): Use cwd failure errno value to print a slightly-better
559 2005-12-15 Jim Meyering <jim@meyering.net>
561 * src/stat.c (print_it): Properly handle a backslash at the
562 end of a --printf format string. Reported by Paul Eggert.
563 * tests/misc/stat-printf (end-bs): Add a test for the above.
565 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
567 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
568 Don't assume /etc/passwd contains user names; use 'id' instead.
570 2005-12-15 Jim Meyering <jim@meyering.net>
572 stat: revert behavior of --format=FMT (-c)
573 stat: add new option: --printf=FMT
574 * NEWS: Mention this.
575 * src/stat.c (isodigit, octtobin, hextobin): Define.
576 (PRINTF_OPTION): Define.
577 (interpret_backslash_escapes, trailing_delim): New globals.
578 (usage): Document them. Alphabetize on long option names.
579 (print_esc_char): New function.
580 (print_it): Rewrite, in order to handle backslash escapes.
581 (main): Handle new option. Set globals for --format, too.
583 * tests/misc/stat-printf: Test --printf and --format.
584 * tests/misc/Makefile.am (TESTS): Add stat-printf.
586 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
588 * NEWS: sort now reports incompatible options.
589 * src/sort.c (incompatible_options, check_ordering_compatibility):
591 (main): Use them. Don't bother with a usage message for
592 "sort -c a b", for consistency with other error diagnostics.
593 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
596 * src/cat.c (main): Undo previous change. close_stdout already
597 does the check, so the previous change wasn't necessary.
599 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
601 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
603 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
605 Install a more-conservative approach for sort -R. It's the
606 same basic idea as the existing code, except it uses the full ISAAC
607 approach (called the "more kosher" approach in the existing comments).
608 This makes "sort -R" quite a bit slower (about a factor of 2 on my
609 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
610 better to be conservative here at first, and review any performance
611 improvements carefully.
612 * .x-sc_require_config_h: Add src/rand-isaac.c.
613 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
614 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
615 (shred_SOURCES, sort_SOURCES): Remove.
616 (EXTRA_DIST): Add rand-isaac.c.
617 * src/rand-isaac.c: Revert to what used to be in shred.c, without
618 changing it to allow for varying numbers of words in the state.
619 Alter so that we include rand-isaac.c directly rather than
620 compiling it and linking to it. Don't include config.h or
621 system.h; that's the includer's responsibility.
622 Omit functions that are specific to shred.
623 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
624 (isaac_step, struct irand_state):
625 Resurrect these, with the same defns that used to be in shred.c.
626 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
627 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
629 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
630 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
631 (irand_init, irand32, irand_mod):
632 Number of words is constant again.
633 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
634 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
635 * src/sort.c: Likewise.
636 * src/shred.c (fillrand, dopass, main): Undo previous change.
637 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
639 * src/sort.c: Don't include md5.h; it wasn't needed.
640 (struct keyfield): Rename random_hash to random, for consistency
641 with the other member names. All uses changed.
642 (usage): Tweak wording to mention STRING for --seed option.
643 (short_options): Rorder for consistency with other programs.
644 (rand_state): Now a struct, not a pointer to one. All uses changed.
645 (HASH_WORDS, HASH_SIZE): Remove.
646 (get_hash): Remove comments around resbuf size, since we can assume C89.
647 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
648 (keycompare): Adjust to the new get_hash.
650 (badfieldspec): Omit recently-introduced comment; it isn't needed.
651 (main): Don't set need_random simply because gkey has it set; that
652 doesn't necessarily mean we'll need random numbers.
653 Redo seeding to match new get_hash approach.
655 2005-12-10 Jim Meyering <jim@meyering.net>
657 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
659 Avoid shred segfault on 64-bit systems.
660 * src/rand-isaac.c (isaac_refill): Don't try to negate a
661 local of type uint32_t. Make the local an `int' instead.
663 * NEWS: Mention sort's new options.
665 * src/rand-isaac.c (isaac_mix): Declare to be static.
666 Mark all other functions as `extern' so the tight-scope
667 part of `make distcheck' passes once again.
668 * src/rand-isaac.h (isaac_mix): Remove declaration.
670 * src/sort.c (get_hash): Change position of `*' in parameter
671 type to conform with convention.
672 (main): Split a long line so it fits in 80 columns.
673 (keycompare): Remove stray SPACE before TAB that was
674 causing `make distcheck' to fail.
676 * src/shred.c: Don't include gethrxtime.h. No longer needed.
678 * tests/misc/sort-rand: New file: basic tests for the new options.
679 * tests/misc/Makefile.am (TESTS): Add sort-rand.
681 2005-12-10 Frederik Eaton <frederik@ofb.net>
683 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
684 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
685 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
686 Make state size runtime-configurable.
687 (isaac_new, isaac_copy): New functions.
688 * src/rand-isaac.h: New file.
689 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
690 (fillrand, main): Adjust to the fact that the state size is now
691 runtime-configurable.
692 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
693 (usage): Add options --random-sort and --seed to implement a random
695 Include md5.h and rand-isaac.h.
696 (get_hash): New function.
697 (rand_state): New var.
698 (HASH_WORDS, HASH_SIZE): New macros.
700 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
702 * tests/dd/misc: Add test for dd iflags=noatime.
704 2005-12-09 Jim Meyering <jim@meyering.net>
706 * src/sort.c (usage): Mention white space vs -b and -t options.
709 2005-12-09 Eric Blake <ebb9@byu.net>
711 * src/test.c (main): Fix misleading comment.
713 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
715 * NEWS: Mention dd's new noatime flag.
716 * src/system.h (O_NOATIME): Define to 0 if not already defined.
717 * src/dd.c (flags, usage): Add support for noatime flag.
719 2005-12-07 Jim Meyering <jim@meyering.net>
721 Distribute the cvsu script, used only by `make syntax-check'.
722 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
723 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
724 distribute a copy of this script.
725 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
727 * tests/mv/acl: exit-77 before the trap, not after, if we fail
728 to create a temporary directory on another partition.
729 From Andreas Gruenbacher.
731 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
733 * man/basename.x: Cross-reference to dirname and readlink.
734 * man/dirname.x: Cross-reference to basename and readlink.
736 2005-12-05 Andreas Gruenbacher
738 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
739 (set_owner, preserve_author): New functions, factored out of copy_reg.
740 (copy_reg): Use them.
741 (copy_internal): Use them here, too.
743 2005-12-04 Jim Meyering <jim@meyering.net>
745 * src/sleep.c (usage): Say what happens with two or more arguments.
746 Suggested by Justin Pryzby.
748 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
751 2005-12-03 Jim Meyering <jim@meyering.net>
753 * src/rm.c (long_opts): Change the name of each undocumented, for-
754 testing-only option to start with `-', so that it cannot render
755 ambiguous any prefix it happens to share with some other option name.
756 Problem reported by Eric Blake.
757 * src/head.c (long_options): Likewise.
758 * src/tail.c (long_options): Likewise.
760 * tests/misc/head-elide-tail: Update uses of undocumented, for-
761 testing-only --presume* options to start with `---'.
762 * tests/rm/dangling-symlink: Likewise.
763 * tests/rm/dir-no-w: Likewise.
764 * tests/rm/isatty: Likewise.
766 2005-11-30 Jim Meyering <jim@meyering.net>
768 * Makefile.maint: Add a comment about cvsu.
770 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
772 * NEWS: df updates for "none", "proc", inaccessible file systems.
773 * src/df.c (show_point): Ignore inaccessible file systems.
774 (usage): -a includes dummy file systems, not size-0 file systems.
776 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
777 to avoid collision with POSIX name space. All uses changed.
779 2005-11-24 Jim Meyering <jim@meyering.net>
781 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
782 * tests/acl: Add `$0: ' prefix to diagnostics.
784 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
786 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
788 * src/copy.c: Improve performance a bit by optimizing away
789 unnecessary system calls and going to a block size of at least
790 8192 (on normal hosts, anyway). This improved performance 5% on my
791 Debian stable host (2.4.27 kernel, x86, copying from root
792 ext3 file system to itself).
793 Include "buffer-lcm.h".
794 (copy_reg): Omit last argument. All callers changed.
795 Use xmalloc to allocate rather than trusting alloca
796 (which is unwise with large block sizes).
797 Declare locals more locally, if possible.
798 Use uintptr_t words instead of int words, for a bit more speed
799 when looking for null blocks on 64-bit hosts.
800 Optimize away reads of zero bytes on regular files.
801 In the typical case, insist on 8 KiB buffers, at least.
802 Avoid unnecessary extra call to fstat when checking for sparse files.
803 Avoid now-unnecessary cast to off_t, and "0L".
804 Avoid unnecessary test of *new_dst when checking for same owner
807 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
809 * src/remove.c (rm): Don't assume C99 for-loop syntax.
811 2005-11-22 Jim Meyering <jim@meyering.net>
813 * src/remove.c (AD_push): Remove debugging cruft.
815 * tests/rm/unread2 (rm): Change expected diagnostic,
816 `cannot open directory' to `cannot remove', to align with
818 * tests/rm/rm2: Ensure that rm now continues removing entries
819 even after certain types of failure.
821 * src/remove.c: Rewrite. Now, this module is reentrant on systems
822 that provide openat (Solaris), and on systems like Linux+procfs
823 where our openat emulation code is reentrant. This also fixes a
824 few low-probability leaks and eliminates some code that could,
825 in very unusual circumstances, cause rm() (via a callee) to exit.
826 * NEWS: Mention this.
828 * configure.ac: Put copyright dates all on one line so the
829 emacs function that updates them works properly.
831 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
833 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
834 Problem reported by Eric Blake.
835 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
836 we get a standard-conforming compiler. This relies on the new
837 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
838 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
839 m4/c.m4 can go away with Autoconf 2.60 comes out.
841 2005-11-17 Jim Meyering <jim@meyering.net>
843 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
844 (AD_mark_current_as_unremovable): Likewise, but for a local.
847 * tests/mv/acl: Let traps handle removing temporary directories.
849 Expect acl-related tests to fail, until the corresponding
850 patches are committed.
851 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
852 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
854 ACL tests, from Andreas Gruenbacher.
855 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
856 * tests/mv/Makefile.am (TESTS): Add acl.
857 * tests/cp/Makefile.am (TESTS): Add acl.
859 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
861 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
863 * NEWS: Improve quality of ln's diagnostics.
864 * src/ln.c (do_link, usage): Likewise.
865 (do_link): Don't use alloca on a buffer of unbounded size.
867 2005-11-16 Jim Meyering <jim@meyering.net>
869 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
870 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
871 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
873 2005-11-14 Jim Meyering <jim@meyering.net>
875 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
877 2005-11-13 Jim Meyering <jim@meyering.net>
879 * announce-gen: Accept new option, --gpg-key-id=ID and
880 emit a blurb telling how to use the .sig files.
881 * Makefile.cfg (gpg_key_ID): Define.
882 * Makefile.maint (announcement): Use new option and key.
884 Require that most .c files include <config.h>.
885 * Makefile.maint (sc_require_config_h): New rule.
886 (syntax-check-rules): Add it.
887 * .x-sc_require_config_h: New file listing exceptions to the
888 above rule. Some are legit, others are simply grandfathered in.
889 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
891 2005-11-12 Jim Meyering <jim@meyering.net>
893 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
895 2005-11-11 Jim Meyering <jim@meyering.net>
897 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
898 Mention new readlink options in 5.3.0's `New features' section.
899 Spotted by Thomas Hood.
901 2005-11-08 Jim Meyering <jim@meyering.net>
903 * NEWS: Merge in changes from b5_9x branch.
905 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
907 * NEWS: ls now defaults to --time-style='locale', which in turn acts
908 like --time-style='posix-long-iso' if the locale settings are messed up.
909 * src/ls.c (decode_switches): Implement this.
911 2005-11-08 Jim Meyering <jim@meyering.net>
913 * tests/du/2g: s/expensive/very expensive/ in a comment.
916 2005-10-17 Eric Blake <ebb9@byu.net>
918 * src/ls.c (usage): Fix descriptions of --sort, --time.
919 Reported by Vitaly A. Ostanin.
921 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
923 * src/ln.c: Include filenamecat.c.
924 (FILE_BASENAME_CONCAT): Remove.
925 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
926 (main): Use file_name_concat, base_name, and strip_trailing_slashes
927 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
930 2005-11-04 Jim Meyering <jim@meyering.net>
932 * src/du.c (process_file): Don't overflow for files of size >= 2^31
933 on systems with stat.st_blocks of a signed 32-bit type.
934 This bug causes trouble on some AIX 5.1 systems.
935 Report and trivial patch from Paul Townsend:
936 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
937 * NEWS: Mention this.
939 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
940 * tests/du/Makefile.am (TESTS): Add it here.
941 * tests/very-expensive: New file.
942 * tests/Makefile.am (EXTRA_DIST): Add it here.
943 * tests/cp/perm: Mark this test as `very-expensive', too.
945 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
947 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
949 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
951 * src/rm.c (usage): Don't mention rm -d.
953 2005-11-02 Jim Meyering <jim@meyering.net>
955 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
958 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
959 `M+N records in/out' lines don't pollute `make check' output.
961 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
962 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
963 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
964 to indicate that the input file should be piped into the command
965 under test (via `cat FILE | $prog ...').
967 * src/remove.c (remove_entry): Emit a better diagnostic when rm
968 (without -r) fails to remove a directory on a non-Linux system.
969 This change affects only newer Solaris systems (with priv_*
970 functions like priv_allocset). Reported by Keith Thompson.
972 * tests/rm/dir-nonrecur: New file/test for the above fix.
973 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
975 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
977 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
978 POSIX 1002.1-2001 requires.
979 * src/tail.c (parse_obsolete_option): Implement this.
980 Problem reported by Vincent Lefevre.
981 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
982 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
983 (test_vector): Add special cases for _POSIX2_VERSION, and
984 regularize the old ones a bit.
985 * tests/touch/obsolescent: Add y2000 test.
987 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
989 * src/dd.c (skip): Fix off-by-one error reported by
990 Theodoros V. Kalamatianos.
992 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
994 * tests/mkdir/p-3: Require that the test be run as non-root.
995 Problem and trivial fix reported by Theodoros V. Kalamatianos.
997 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
999 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1000 boundary between DEST and SOURCE in the result.
1002 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1004 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1005 back to text, to sync with documentation and for backwards
1008 2005-10-25 Jim Meyering <jim@meyering.net>
1010 * tests/dircolors/simple (other-wr): Add an explicit test for
1011 the dircolors bug (NULL-dereference) fixed yesterday.
1013 2005-10-24 Jim Meyering <jim@meyering.net>
1015 * src/tac.c (tac_file): When determining whether a file is seekable,
1016 also test whether it is a tty. Using only the lseek-based test would
1017 give a false positive on Solaris. Reported by Peter Fales.
1019 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1021 * tests/install/d-slashdot: New test, for "install -d" failure.
1022 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1023 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1024 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1026 2005-10-24 Jim Meyering <jim@meyering.net>
1028 * src/dircolors.c (ls_codes): Add missing comma.
1029 Anonymous report and patch from
1030 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1032 * src/dircolors.c: Add compile-time assertion that the slack_codes
1033 and ls_codes arrays have the same number of elements. This would
1034 have prevented the above-fixed bug.
1036 * src/expand.c (parse_tab_stops): Add a comment to make this function
1037 identical to the one in unexpand.c.
1038 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1039 identical to the one in expand.c.
1041 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1043 2005-10-23 Jim Meyering <jim@meyering.net>
1045 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1046 a dangerous pointer-value-to-`unsigned' cast.
1047 * NEWS: mention the new sha* programs.
1048 * AUTHORS: Add new sha* programs.
1050 2005-08-28 David Madore <david.madore@ens.fr>
1052 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1053 * README: Add their names to the list.
1054 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1055 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1056 Rules for compiling sha-2 utilities
1057 (noinst_HEADERS): Remove checksum.h.
1058 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1060 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1061 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1062 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1063 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1064 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1065 sha384sum, sha512sum test scripts here rather that each in its
1068 2005-08-28 David Madore <david.madore@ens.fr>
1070 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1071 of the FIPS test vectors).
1073 2005-10-23 Jim Meyering <jim@meyering.net>
1075 * configure.ac: Use 6.0-cvs as the version string.
1076 * NEWS: Adjust accordingly.