1 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
5 Fix problems when building with Solaris/SVR4/etc. make, which uses a
6 different and somewhat bogus implementation of VPATH. In the
7 directory tests/misc, rename tests whose names might appear in the
8 Automake-generated rules. For example, we can't use a test named
9 'test', since Automake generates a rule that contains the text
10 "if test -f ./$$tst; ...", and this might expand to something like
11 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
12 which executes the 'test' script rather than the 'test' command.
13 * tests/misc/false-status: Renamed from tests/misc/false.
14 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
15 * tests/misc/sort-merge: Renamed from tests/misc/sort.
16 ($prog): Set to 'sort' rather than to $PROG.
17 * tests/misc/test-diag: Renamed from tests/misc/test.
18 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
19 in case Solaris make has prepended the directory.
20 (TESTS): Adjust to above renamings.
21 * tests/misc/expand: Don't assign to PROG; no longer needed
22 now that Makefile.am sets PROG to the basename.
23 * tests/misc/fold: Likewise.
25 2006-06-03 Jim Meyering <jim@meyering.net>
27 Make `cp --link --no-dereference' work also on systems where the
28 link system call cannot create a hard link to a symbolic link.
29 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
30 the link syscall on a symlink when it would do the wrong thing.
31 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
32 * tests/cp/link-no-deref: New file/test for the above.
33 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
34 * NEWS: Mention the change (doesn't affect Linux).
36 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
38 Fix some porting problems in the test cases reported by
39 Ralf Wildenhues for HP-UX 11.23 in:
40 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
41 * tests/help-version: Don't assume that \< \> works in sed.
42 * tests/misc/close-stdout: Don't assume that >&- works.
44 * tests/touch/no-create-missing: Don't assume that >&- works.
46 2006-05-30 Jim Meyering <jim@meyering.net>
48 * src/ls.c (usage): Add `v' to the list of sorting-related options.
51 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
53 * tests/cp/fail-perm: source lang-default.
54 * tests/rm/inaccessible: Likewise.
56 2006-05-28 Jim Meyering <jim@meyering.net>
58 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
59 Recognize it, too. Reported by Ralf Wildenhues, in
60 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
62 2006-05-27 Jim Meyering <jim@meyering.net>
64 * src/chgrp.c: Support new options: --preserve-root and
65 --no-preserve-root. Somehow this program was skipped when those
66 options were added to chown, chmod, and rm. Reported by
67 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
70 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
72 * NEWS: Remove mention of --seed. We'll replace it with something
73 better, and don't want to indicate that it is supported.
74 * src/sort.c (usage): Likewise.
76 2006-05-20 Jim Meyering <jim@meyering.net>
78 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
80 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
81 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
82 FTS_COMFOLLOW. Spotted by Justin Pryzby.
84 * gnupload: Merge changes from automake, retaining the ""--to...
85 kludge to placate overzealous `make distcheck' check.
87 2006-05-19 Jim Meyering <jim@meyering.net>
89 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
90 FTS_TIGHT_CYCLE_CHECK directory traversal option.
91 Reported by Justin Pryzby in http://bugs.debian.org/367691
93 2006-05-15 Jim Meyering <jim@meyering.net>
95 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
98 2006-05-13 Jim Meyering <jim@meyering.net>
100 * tests/mv/no-target-dir: Test two more cases.
102 2006-05-11 Jim Meyering <jim@meyering.net>
104 mv -T DIR EMPTY_DIR no longer fails unconditionally
105 * src/copy.c (copy_internal): Don't manually prohibit a move where
106 the destination is an existing directory. Sometimes doing that is
107 valid. Let the rename system call enforce the rules. That is
108 allowed only when the source is a directory and the destination
109 directory (to be replaced) is empty. Reported by Eric Blake.
110 * tests/mv/no-target-dir: New file/test for this.
111 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
112 * NEWS: Mention this.
114 * tests/mv/atomic: New file/test for yesterday's fix.
115 * tests/mv/Makefile.am (TESTS): Add atomic.
117 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
119 2006-05-10 Jim Meyering <jim@meyering.net>
121 * src/copy.c (copy_internal): Don't explicitly unlink the destination
122 when moving a symlink into the place of an existing non-directory.
123 Reported by Joshua Hudson.
124 * NEWS: mention this.
126 2006-05-07 Jim Meyering <jim@meyering.net>
128 * Makefile.maint (patch-check): Fail if patch generates any output,
129 even merely for changed offsets.
131 * src/c99-to-c89.diff: Adjust to reflect new offsets.
133 * NEWS: Mention changes affecting df, pwd, shred.
135 2006-05-06 Jim Meyering <jim@meyering.net>
137 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
138 system condition where dirent.d_ino != stat.st_ino.
139 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
141 2006-05-06 Eric Blake <ebb9@byu.net>
143 * tests/ls/inode: Expand to test inode from readdir case.
144 * tests/ls/follow-slink: Expand to test broken links encountered
145 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
147 2006-05-06 Eric Blake <ebb9@byu.net>
149 * tests/mv/leak-fd: Work even on case-insensitive file system.
151 2006-05-04 Jim Meyering <jim@meyering.net>
153 * NEWS: Mention the 2006-03-19 pwd-related change that makes
154 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
156 2006-05-03 Jim Meyering <jim@meyering.net>
158 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
159 Use better macro parameter names: s/basename/key_name/,
160 s/basefunc/key_cmp_func. Fix typo in comment.
162 2006-04-29 Eric Blake <ebb9@byu.net>
164 * src/ls.c (main): On systems with d_type, directories_first only
165 implies format_needs_type, not format_needs_stat.
167 2006-05-03 Jim Meyering <jim@meyering.net>
169 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
170 after comma in arg list, from Eric Blake.
172 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
174 * tests/misc/date (relative-3): New test, derived from a bug
175 report by John Thomas McDole.
177 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
179 New option for ls: --group-directories-first.
180 It makes ls list directories before files.
181 * NEWS [New features]: Mention it.
182 * src/ls.c (sort_type): Rearrange to use as an array index when
183 choosing sort function; added new sort_numtypes member for
185 (time_type): Add new time_numtypes member for compile-time check.
186 (directories_first): New global variable.
187 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
188 (long_options): Add --directories-first.
189 (main): Support new option.
190 (is_directory): New function.
191 (extract_dirs_from_files): Use it.
192 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
193 (LIST_SORTFUNCTION_VARIANTS): New macros.
194 (sort_functions): New global variable.
195 (sort_files): Use it.
196 (usage): Document new option.
198 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
200 * src/shred.c (fillrand): The assertion was way too weak, due to
201 what must be a typo. Strengthen it to its intended value.
202 (dopass): Don't use alloca; it's not worth the aggravation here,
203 since it's used only to get a page-aligned buffer, and page
204 alignment doesn't buy us much here. I'm suspicious that alloca
205 causes problems on some hosts, due to a recent bug report by Adam
206 Waltman: http://bugs.gentoo.org/130246.
208 2006-04-18 Jim Meyering <jim@meyering.net>
210 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
211 sha384sum, sha512sum.
213 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
215 * src/chmod.c (describe_change): Adjust to filemode changes.
216 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
217 (print_long_format): Use (new) filemodestring rather than
218 (old) mode_string, so that we get more file types right, at least
219 in theory. Adjust to filemode changes.
220 * src/stat.c (human_access): Likewise.
222 2006-04-18 Jim Meyering <jim@meyering.net>
224 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
225 ignore file. This has never been enabled. Reported by Eric Blake.
227 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
229 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
230 bug in Interix. Just call symlink or link directly. All uses changed.
231 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
232 * src/stat.c (USE_STATVFS): New macro.
233 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
234 (NAMEMAX_FORMAT): define a bit more clearly, now that the
235 statvfs-using code is a bit more regular.
236 * src/system.h (sync) [!HAVE_SYNC]: New macro.
238 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
240 * NEWS: csplit, nl, expr now conform to POSIX better, and are
241 more-compatible with traditional Unix, with respect to regular
243 * src/csplit.c (extract_regexp): Set re_syntax_options to a
244 value that is compatible with what POSIX requires.
245 * src/nl.c (build_type_arg): Likewise.
246 * src/expr.c (docolon): Likewise. Also, don't let anchors match
247 newline; this fixes an incompatibility with tradition and with POSIX.
248 Don't warn about leading ^. POSIX says it is unspecified whether
249 ^ is a special character, which means that implementations can
250 either treat it as special or not, but either way a warning is not
251 allowed (unless the regexp is otherwise invalid). Instead, anchor
252 the expression but treat ^ as an anchor; this is the traditional
253 behavior (e.g., Solaris 10).
254 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
255 and the like as invalid expressions (exit status 2), not as
256 failure of 'expr' (exit status 3). This is more consistent with
258 * tests/expr/basic (fail-a): Adjust exit status to match new expr
259 behavior, for status 2 versus 3.
261 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
262 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
263 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
264 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
265 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
266 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
267 (bre61, bre62): New tests.
268 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
272 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
273 "if !". Do not assume that 'sed' can handle long, newline-free input.
274 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
276 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
278 Adjust to new regex.h API (with new fastmap type), and clean
279 up the regex storage allocation a bit.
281 * src/csplit.c (struct control): Put re_compiled member at the
282 end, since it's large. Change regexpr member from char * to bool;
283 all uses changed. Add new member fastmap.
284 (extract_regexp): regexp arg is now char const *, not char *.
285 Don't bother duplicating the regular expression; it's not needed.
286 Set fastmap from new fastmap member. Don't bother allocating
287 a buffer, as the regexp code does a better job than we do.
288 * src/expr.c (docolon): Allocate and use a fastmap.
289 Don't bother allocating a buffer.
290 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
292 (build_type_arg): New fastmap arg. All uses changed.
293 Don't bother allocating a buffer, but set a fastmap.
294 * src/ptx.c (context_regex_string, word_regex_string): Remove.
295 (context_regex, word_regex): New vars, replacing the above.
297 (struct regex_data): New type.
298 (compile_regex): Renamed from alloc_and_compile_regex, since
299 we no longer allocate storage. Arg is now a struct regex_data *,
300 not a const char *. All uses changed. Don't allocate the fastmap;
301 instead, take it from the caller. Don't convert size_t to int,
302 to avoid arithmetic overflow problems. Don't bother freeing
303 storage afterwards; it's not worth the aggravation.
304 * src/tac.c (compiled_separator_fastmap): New ver.
305 (main): Use it. Don't bother allocating a buffer.
307 2006-03-30 Jim Meyering <jim@meyering.net>
309 * src/dd.c (iwrite): Remove assignment without effect.
310 Reported by Felix Rauch Valenti.
312 2006-03-22 Eric Blake <ebb9@byu.net>
314 * src/ptx.c (usage): Remove mention of --copyright/-C.
315 (main): Alias --copyright to --version plus a deprecation warning.
316 * NEWS: Mention this.
318 2006-03-27 Jim Meyering <jim@meyering.net>
320 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
321 use of strtod. Tiny patch from Nickolai Zeldovich.
323 2006-03-11 Eric Blake <ebb9@byu.net>
325 * tests/misc/dirname: New file.
326 * tests/basename/Makefile.am: Delete.
327 * tests/basename/basic: Move to...
328 * tests/misc/basename: ... this new file. Add some tests,
329 including fixed behavior for //.
330 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
331 * tests/Makefile.am (SUBDIRS): Remove basename.
332 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
334 Improvements to dirname/basename handling on platforms like
335 cygwin with distinct // and with drive letters.
336 * NEWS: Document new behavior.
337 * src/basename.c (main): Don't strip suffix from file system
339 * src/cp.c (target_directory_operand): Use new last_component.
340 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
341 traversing the string.
342 * src/dircolors.c (guess_shell_syntax): Use new last_component.
343 * src/install.c (target_directory_operand, install_file_in_dir):
345 * src/ln.c (target_directory_operand, main): Likewise.
346 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
347 * src/mv.c (target_directory_operand, movefile): Likewise.
348 * src/remove.c (rm_1): Likewise.
349 * src/shred.c (wipename): Likewise.
350 * src/split.c (next_file_name): Likewise.
351 * src/su.c (log_su, run_shell): Likewise.
353 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
355 * NEWS: nohup diagnostics are now more precise, and nohup now
356 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
357 * src/nohup.c (main): Implement this.
358 * tests/misc/nohup: Test the new behavior.
360 2006-03-12 Jim Meyering <jim@meyering.net>
362 * src/copy.c (set_author): Rename function, from preserve_author.
364 * src/remove.c (AD_pop_and_chdir): Use new macro,
365 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
367 * src/system.h (SAME_INODE): Remove definition.
368 Include "same-inode.h", instead.
370 2006-03-11 Eric Blake <ebb9@byu.net>
372 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
374 2006-03-10 Jim Meyering <jim@meyering.net>
376 Fix a bug whereby a user with write access to a directory being removed
377 could cause the removal of that directory to fail with an erroneous
378 diagnostic about a directory cycle. Reported by Vineet Chadha.
380 * NEWS: Mention this.
381 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
382 leave (and try to rmdir) is the one whose dev_ino is being used to
383 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
385 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
387 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
388 * src/dd.c (set_fd_flags): Handle file-creation flags on file
389 descriptors, rather than ignoring them.
390 * tests/dd/misc: Add test cases for append, nofollow, directory,
391 and nolinks flags. Simplify redirection to /dev/null in some cases.
393 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
394 noatime test never tested anything.
396 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
398 * src/dd.c (flags, usage): New flags directory, nolinks.
399 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
401 * src/ls.c (usage): Mention that -f disables --color.
402 Problem reported by Niels Möller.
404 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
406 * man/*.x: Add references to syscalls from utilities of the same name.
408 2006-03-05 Jim Meyering <jim@meyering.net>
410 * tests/help-version: Set SHELL, if not already set, in order to
411 avoid failure when `make check' is run through debuild; dircolors
412 would fail due to lack of $SHELL. Reported by Sven Joachim.
414 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
415 * src/base64.c (wrap_write, do_encode, main): Change type of
416 parameters and locals, wrap_column, form size_t to uintmax_t.
417 (main): Adjust to use xstrtoumax, accordingly.
419 2006-03-03 Jim Meyering <jim@meyering.net>
421 Don't fail when run from an environment with SHELL not a Bourne
422 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
423 * tests/dircolors/simple: Invoke each non-failing test with -b.
424 Reported by Michael Stone.
426 2006-02-27 Jim Meyering <jim@meyering.net>
428 * tests/misc/base64: Derive --decode-using tests from the
431 * tests/misc/base64: Factor out a long constant string.
432 Split lines to stay within 80 columns.
434 * tests/misc/Makefile.am (TESTS): Add base64.
435 * tests/misc/base64: Test base64. From Simon Josefsson.
437 * src/base64.c (do_decode): Use correct type for parameter,
438 ignore_garbage: s/size_t/bool/.
440 * src/base64.c: Don't include .h files already included by system.h:
441 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
442 Include "system.h" before the other lib/*.h header files.
443 Include <sys/types.h> before "system.h".
444 (wrap_write): Remove declaration of unused local, initial_column.
445 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
447 * README: Add base64 to the list.
449 2006-02-17 Simon Josefsson <jas@extundo.com>
452 * AUTHORS: Mention base64.
454 * man/Makefile.am: Build base64.1.
455 * man/base64.x: New file.
456 * src/Makefile.am (bin_PROGRAMS): Add base64.
457 * src/base64.c: New file.
459 2006-02-25 Eric Blake <ebb9@byu.net>
461 In ls, avoid calling stat for --inode (-i), when possible.
462 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
463 * src/system.h: ... here, for use in ...
464 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
466 (gobble_file): Add inode argument.
467 (print_dir): Pass inode if available.
468 (usage): Remove inaccuracy.
470 2006-02-23 Jim Meyering <jim@meyering.net>
472 * TODO: Update/correct some obsolete entries.
474 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
476 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
477 * src/join.c (usage): Likewise.
478 Documentation problem reported by Philip Kensche.
480 2006-02-20 Eric Blake <ebb9@byu.net>
482 * man/rm.x: Update documentation to match previous patch.
484 2006-02-18 Eric Blake <ebb9@byu.net>
486 New option for rm: --interactive=once (-I).
487 * NEWS: Document it, along with change to rm --interactive.
488 * TODO: Remove entry for implementing rm -I
489 * src/rm.c (INTERACTIVE_OPTION): New enum value.
490 (interactive_type): New enum.
491 (long_opts): Let interactive take an optional argument.
492 (interactive_args, interactive_types): New option arguments.
493 (usage): Document -I, --interactive=WHEN. Use program_name
494 instead of a basename.
495 (main): New -I option, new behavior to --interactive.
496 * tests/rm/interactive-once: New tests.
497 * tests/rm/interactive-always: Ditto.
498 * tests/rm/Makefile.am (TESTS): Run them.
500 2006-02-18 Jim Meyering <jim@meyering.net>
502 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
503 expression match more of the target lines, e.g., those that start with
504 `-S,' (short option followed by a comma) or that include `=[...]'.
505 Patch by Nicolas François.
506 Fix the four offenders thus exposed:
507 * src/join.c (usage): Use two spaces (not one) to separate the
508 --first-only option string from its description, so help2man formats
509 the derived man page properly.
510 * src/pr.c (usage): Likewise.
511 * src/uniq.c (usage): Likewise.
512 * src/install.c (usage): Likewise.
514 2006-02-15 Jim Meyering <jim@meyering.net>
516 * Makefile.maint (alpha beta major): For `make major', ensure that the
517 version string is of the form N.N[.N]*, where N is one or more digits.
519 2006-02-14 Jim Meyering <jim@meyering.net>
521 * INSTALL: Update from gnulib.
523 2006-02-13 Jim Meyering <jim@meyering.net>
525 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
527 2006-02-12 Jim Meyering <jim@meyering.net>
529 * Makefile.maint (patch-check): New target.
530 (local-checks-available): Add to the list.
532 2006-02-11 Jim Meyering <jim@meyering.net>
534 * src/c99-to-c89.diff: New file.
535 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
537 * .x-po-check: New file, with exclusions so that `make distcheck'
539 * Makefile.am (EXTRA_DIST): Add .x-po-check.
541 rm -r must remove an empty directory, even if it is inaccessible.
542 * src/remove.c (close_preserve_errno): New function.
543 (fd_to_subdirp): Don't print a diagnostic in this function.
544 Do it from the callers instead, unless rmdir succeeds.
545 (remove_cwd_entries, remove_dir): Adjust callers.
546 * tests/rm/empty-inacc: New test for the above.
547 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
548 * NEWS: Mention this bug fix.
549 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
550 a tiny bit less precise: cannot remove `a/1': ... instead of
551 cannot open directory `a/1': ...
553 * Makefile.maint (syntax-check-rules): Automatically derive this
554 list of sc_-prefixed rule names.
556 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
558 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
559 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
560 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
561 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
562 go away? was that an accident?)
563 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
564 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
565 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
566 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
567 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
568 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
569 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
570 (author_mark_check, makefile_path_separator_check):
571 Output line numbers, to simplify navigation of Emacs *compilation*
573 (sc_prohibit_atoi_atof, sc_file_system):
574 Rework slightly so that Makefile.maint doesn't get reported as a
575 violation of its own syntax rules.
576 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
577 it at run-time (which didn't work with Bison). Fix a makefile typo,
578 caught by Makefile.maint itself: spaces where a tab should be.
579 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
580 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
581 Ignore djgpp and man subdirectories, to avoid false matches with
582 Bison and coreutils, respectively. Use sort -u to remove the
583 resulting duplicates.
584 * gnupload: Rework slightly to avoid bogus warning from
585 sc_two_space_separator_in_usage.
587 2006-02-10 Jim Meyering <jim@meyering.net>
589 Use gzip's --rsyncable option only if it's available.
590 * Makefile.maint (gzip_rsyncable): New variable.
593 2006-02-08 Jim Meyering <jim@meyering.net>
595 * Makefile.maint (local-checks-available): Define in terms of
596 the expansion, $(syntax-check-rules), rather than the single,
597 top-level target `syntax-check', so that it's easier to exclude
598 individual rules (via $(local-checks-to-skip)).
599 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
601 2006-02-07 Jim Meyering <jim@meyering.net>
603 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
604 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
606 * tests/help-version (expected_failure_status_vdir):
607 Redirect an expected disk-full diagnostic to /dev/null.
609 2006-02-06 Jim Meyering <jim@meyering.net>
611 * src/unexpand.c (usage): Use two spaces (not one) to separate the
612 --first-only option string from its description, so help2man formats
613 the derived man page properly.
614 * src/rm.c (usage): Likewise for --no-preserve-root.
615 * src/chown.c (usage): Likewise.
616 * src/chgrp.c (usage): Likewise.
618 Add a rule to ensure that the above doesn't happen again.
619 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
620 (syntax-check-rules): Add it.
621 * .x-sc_two_space_separator_in_usage: New empty file.
622 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
624 2006-02-06 Jim Meyering <jim@meyering.net>
626 * src/cp.c (usage): Use two spaces (not one) to separate each
627 option string from its description, so help2man formats the
628 derived man page properly.
629 * src/mv.c (usage): Likewise.
630 Patch from Nicolas François in http://bugs.debian.org/351601.
632 2006-02-04 Jim Meyering <jim@meyering.net>
634 * src/copy.c (copy_internal): cp -RL would fail when encountering
635 the same directory more than once in the hierarchy beneath a single
636 command-line argument. That is legitimate, e.g. when there are
637 two or more symbolic links, each pointing to some directory that
638 would not otherwise be copied. Reported by Christophe LYON.
639 * tests/cp/cp-deref: New file. Test for today's fix.
640 * tests/cp/Makefile.am (TESTS): Add cp-deref.
641 * NEWS: Document this.
643 2006-02-03 Jim Meyering <jim@meyering.net>
645 * configure.ac: Require automake-1.9.6, not 1.8.3.
647 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
649 * src/od.c (usage): Mention that -t a ignores high order bit.
650 Documentation problem reported by Ed Avis.
652 2006-02-01 Jim Meyering <jim@meyering.net>
654 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
656 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
658 * src/head.c (main): Use a better diagnostic when someone uses a
659 trailing numeric option in an invalid way. Problem reported by
661 * src/tail.c (parse_options): Likewise.
663 2006-01-30 Jim Meyering <jim@meyering.net>
665 * man/wc.x: Include `count' keyword in man page synopsis,
666 per suggestion from http://bugs.debian.org/181585.
668 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
670 * src/df.c (show_dev): If the file system claims to have
671 more available than total blocks, report the number of used
672 blocks as being total - available (a negative number) rather
673 than as garbage. Problem reported by Toralf Foerster.
675 2006-01-24 Jim Meyering <jim@meyering.net>
677 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
678 to put a regular file in O_NONBLOCK mode fails with EPERM.
679 That happens on Linux (up to 2.6.15) when using tail -f on a file with
680 the append-only attribute. Reported by Dean Gaudet. For details,
681 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
682 * NEWS: Mention this fix.
683 * tests/tail-2/append-only: New file. Test for the above.
684 * tests/tail-2/Makefile.am (TESTS): Add append-only.
685 * tests/Makefile.am (check-root): Add tail-2/append-only
687 2006-01-21 Jim Meyering <jim@meyering.net>
689 * NEWS: Mention fts-related improvements and bug fixes.
691 2006-01-19 Jim Meyering <jim@meyering.net>
693 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
694 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
696 2006-01-18 Jim Meyering <jim@meyering.net>
698 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
700 2006-01-17 Jim Meyering <jim@meyering.net>
702 Now that fts no longer changes the current working directory, adjust
703 its clients accordingly -- note that du.c uses fts but doesn't need
704 any adjustment, since it doesn't operate on the actual files,
705 but rather just uses the stat buffers provided by fts.
707 * src/chown-core.c: Include "openat.h".
708 Don't include "lchown.h".
709 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
710 calling openat, lchownat, chownat, rather than open, lchown, chown.
712 * src/chmod.c: Include "openat.h".
713 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
715 * tests/du/long-from-unreadable: New test, to exercise one small
718 2006-01-13 Jim Meyering <jim@meyering.net>
720 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
721 addition of new directories under tests/.
723 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
726 2006-01-12 Jim Meyering <jim@meyering.net>
728 * tests/du/long-sloop: Adjust not to hard-code the expected
729 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
730 from that of GNU libc. Reported by Paul Eggert.
732 * tests/du/long-sloop: Create file at end of symlink chain.
734 * tests/misc/test: New file, with a test for one of the
735 bugs fixed by yesterday's test.c changes.
736 * tests/misc/Makefile.am (TESTS): Add test.
738 2006-01-11 Jim Meyering <jim@meyering.net>
740 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
741 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
742 a very long sequence of symbolic links (not necessarily a loop).
743 * tests/du/Makefile.am (TESTS): Add long-sloop.
745 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
747 * src/test.c (test_syntax_error): Append a newline. All callers
748 changed, except for the ones that didn't already append a newline.
749 Bug reported by Eric Blake.
751 2006-01-11 Jim Meyering <jim@meyering.net>
753 * src/system.h (X2NREALLOC): Now that verify_true is no longer
754 void, cast its result to void, to avoid gcc's warning that
755 ``left-hand operand of comma expression has no effect''.
756 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
758 2006-01-10 Jim Meyering <jim@meyering.net>
760 * tests/chmod/no-x: Add a test for today's fts.c fix.
762 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
764 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
765 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
767 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
769 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
770 Use verify_true instead of verify_expr, to sync with gnulib.
772 2006-01-08 Jim Meyering <jim@meyering.net>
774 * src/date.c (usage): Adjust the formatting of the entries for
775 %::z and %:::z (separate with two spaces, not one) so that help2man
776 formats them properly. Reported by Philip Rowlands.
778 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
780 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
782 2006-01-06 Jim Meyering <jim@meyering.net>
784 * Makefile.maint (copyright-check): Use date +%Y in place of
787 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
788 First off, the attribute should have been `volatile' (not static)
789 to avoid longjmp-related risk of clobber. Secondly, now there is
790 no longer any risk of a local variable being clobbered, so there's
791 no need for any attribute at all.
793 2006-01-05 Jim Meyering <jim@meyering.net>
795 * src/remove.c: Give a few functions the inline attribute.
796 (AD_pop_and_chdir): Use gotos to avoid some duplication.
797 (AD_push): Rewrite an assertion so that the entire computation
798 goes away when assertions are turned off.
800 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
801 It's already defined in "system.h".
802 * Makefile.maint: Add a FIXME comment.
804 2006-01-04 Jim Meyering <jim@meyering.net>
806 * ChangeLog: Remove entries from 2005-10-22 and earlier.
807 * ChangeLog-2005: New file, for entries up to version 5.92.
809 2006-01-03 Jim Meyering <jim@meyering.net>
811 * tests/du/no-x: Also allow a slightly different diagnostic -- the
812 one you get when using openat-enabled fts.c and du (coming soon).
813 * tests/chmod/no-x: Likewise.
814 * tests/chgrp/no-x: Likewise.
816 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
818 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
820 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
821 (restricted_chown): Return it, if the file cannot be accessed due
822 to EPERM, or if no uid or gid are required, or if the file is
823 neither a directory nor a regular file. Rewrite to avoid gotos.
824 (change_file_owner): Handle RC_do_ordinary_chown case.
825 Rewrite to avoid gotos.
826 * tests/chgrp/basic: Make sure we can change the group of
829 * src/date.c (usage): Explain %g, %G, and %V a bit better.
831 2006-01-02 Jim Meyering <jim@meyering.net>
833 * src/copy.c (set_owner): Correct a comment.
835 * src/tail.c (parse_options): Change warning to say that --retry
836 is useful `mainly' (not `only') when following by name.
837 Reported here: http://bugs.debian.org/273781
839 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
841 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
842 * src/copy.c: Include lchmod.h.
843 (copy_internal): Use lchmod rather than chmod.
844 * src/cp.c: Include lchmod.h.
845 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
846 * src/mkdir.c: Include lchmod.h.
847 (usage): Clarify -m's operation.
848 (main): Use lchmod rather than chmod. Don't use lchmod unless the
849 new mode contains bits outside the 777 range.
850 * src/mkfifo.c (usage): Clarify -m's operation.
851 (main): If -m is given, don't invoke chmod; use umask 0 instead.
852 Report an error if -m asks for bits outside the 777 range.
853 * src/mknod.c (usage, main): Likewise.
855 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
857 2005-12-27 Jim Meyering <jim@meyering.net>
859 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
860 (sc_prohibit_assert_without_use): New rule.
861 (syntax-check-rules): Add it to the list.
862 * .x-sc_prohibit_assert_without_use: New empty file.
863 * Makefile.am (EXTRA_DIST): Add it.
865 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
867 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
868 Don't include <assert.h>; it wasn't used.
870 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
872 * src/chown-core.c (restricted_chown):
873 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
874 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
875 | O_NOFOLLOW too, for consistency with other dir-openers.
876 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
877 (is_empty_dir): Likewise.
878 * src/shred.c (wipename): Likewise. Don't bother trying to open
879 dir for writing, since POSIX prohibits it.
881 2005-12-22 Jim Meyering <jim@meyering.net>
883 * tests/help-version: Redirect stderr to /dev/full, to suppress
884 write error diagnostic.
886 2005-12-19 Jim Meyering <jim@meyering.net>
888 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
889 Avoid a minor race condition when `-m MODE' is specified, by using
890 open, fchown, and close rather than just chown. To do that reliably --
891 even with an overly restrictive umask -- ensure that each mkdir,
892 mknod and mkfifo call uses a mode including at least owner-read access.
893 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
894 the subsequent chown (or equivalent open,fchown,close) fails.
895 * tests/misc/mknod: New tests.
896 * tests/misc/Makefile.am (TESTS): Add mknod.
898 2005-12-17 Jim Meyering <jim@meyering.net>
900 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
901 e.g., on a named pipe.
902 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
903 place of all uses, since it is guaranteed (system.h) to be defined.
905 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
907 Add POSIX ACL support
908 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
909 is no requirement for ACL support; particularly, it does not exist
910 on systems that have POSIX ACLs.
911 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
912 * src/cp.c (umask_kill): With default acls, the umask is not to be
913 applied. Remove umask_kill, don't change the process umask, and let
914 the kernel apply the umask where appropriate.
915 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
916 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
918 (copy_reg, copy_internal): Use copy_acl and set_acl
919 instead of fchown/chown. Fix the logic for POSIX ACLs.
920 (chown_succeded): Remove; we now always copy acls and
921 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
922 did a chown before or not.
923 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
924 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
925 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
926 to link with it via $(LIB_ACL), for the utilities that need it.
928 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
930 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
931 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
932 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
933 value is now signified by whether cwd_errno is null.
934 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
935 pointer-to-bool to pointer-to-errno-value. All callers changed.
936 (rm_1): Don't bother setting a local cwd failure flag and then
937 ORing it into the caller's. Just set the caller's.
938 (rm): Use cwd failure errno value to print a slightly-better
941 2005-12-15 Jim Meyering <jim@meyering.net>
943 * src/stat.c (print_it): Properly handle a backslash at the
944 end of a --printf format string. Reported by Paul Eggert.
945 * tests/misc/stat-printf (end-bs): Add a test for the above.
947 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
949 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
950 Don't assume /etc/passwd contains user names; use 'id' instead.
952 2005-12-15 Jim Meyering <jim@meyering.net>
954 stat: revert behavior of --format=FMT (-c)
955 stat: add new option: --printf=FMT
956 * NEWS: Mention this.
957 * src/stat.c (isodigit, octtobin, hextobin): Define.
958 (PRINTF_OPTION): Define.
959 (interpret_backslash_escapes, trailing_delim): New globals.
960 (usage): Document them. Alphabetize on long option names.
961 (print_esc_char): New function.
962 (print_it): Rewrite, in order to handle backslash escapes.
963 (main): Handle new option. Set globals for --format, too.
965 * tests/misc/stat-printf: Test --printf and --format.
966 * tests/misc/Makefile.am (TESTS): Add stat-printf.
968 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
970 * NEWS: sort now reports incompatible options.
971 * src/sort.c (incompatible_options, check_ordering_compatibility):
973 (main): Use them. Don't bother with a usage message for
974 "sort -c a b", for consistency with other error diagnostics.
975 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
978 * src/cat.c (main): Undo previous change. close_stdout already
979 does the check, so the previous change wasn't necessary.
981 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
983 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
985 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
987 Install a more-conservative approach for sort -R. It's the
988 same basic idea as the existing code, except it uses the full ISAAC
989 approach (called the "more kosher" approach in the existing comments).
990 This makes "sort -R" quite a bit slower (about a factor of 2 on my
991 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
992 better to be conservative here at first, and review any performance
993 improvements carefully.
994 * .x-sc_require_config_h: Add src/rand-isaac.c.
995 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
996 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
997 (shred_SOURCES, sort_SOURCES): Remove.
998 (EXTRA_DIST): Add rand-isaac.c.
999 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1000 changing it to allow for varying numbers of words in the state.
1001 Alter so that we include rand-isaac.c directly rather than
1002 compiling it and linking to it. Don't include config.h or
1003 system.h; that's the includer's responsibility.
1004 Omit functions that are specific to shred.
1005 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1006 (isaac_step, struct irand_state):
1007 Resurrect these, with the same defns that used to be in shred.c.
1008 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1009 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1011 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1012 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1013 (irand_init, irand32, irand_mod):
1014 Number of words is constant again.
1015 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1016 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1017 * src/sort.c: Likewise.
1018 * src/shred.c (fillrand, dopass, main): Undo previous change.
1019 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1021 * src/sort.c: Don't include md5.h; it wasn't needed.
1022 (struct keyfield): Rename random_hash to random, for consistency
1023 with the other member names. All uses changed.
1024 (usage): Tweak wording to mention STRING for --seed option.
1025 (short_options): Rorder for consistency with other programs.
1026 (rand_state): Now a struct, not a pointer to one. All uses changed.
1027 (HASH_WORDS, HASH_SIZE): Remove.
1028 (get_hash): Remove comments around resbuf size, since we can assume C89.
1029 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1030 (keycompare): Adjust to the new get_hash.
1032 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1033 (main): Don't set need_random simply because gkey has it set; that
1034 doesn't necessarily mean we'll need random numbers.
1035 Redo seeding to match new get_hash approach.
1037 2005-12-10 Jim Meyering <jim@meyering.net>
1039 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1041 Avoid shred segfault on 64-bit systems.
1042 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1043 local of type uint32_t. Make the local an `int' instead.
1045 * NEWS: Mention sort's new options.
1047 * src/rand-isaac.c (isaac_mix): Declare to be static.
1048 Mark all other functions as `extern' so the tight-scope
1049 part of `make distcheck' passes once again.
1050 * src/rand-isaac.h (isaac_mix): Remove declaration.
1052 * src/sort.c (get_hash): Change position of `*' in parameter
1053 type to conform with convention.
1054 (main): Split a long line so it fits in 80 columns.
1055 (keycompare): Remove stray SPACE before TAB that was
1056 causing `make distcheck' to fail.
1058 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1060 * tests/misc/sort-rand: New file: basic tests for the new options.
1061 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1063 2005-12-10 Frederik Eaton <frederik@ofb.net>
1065 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1066 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1067 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1068 Make state size runtime-configurable.
1069 (isaac_new, isaac_copy): New functions.
1070 * src/rand-isaac.h: New file.
1071 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1072 (fillrand, main): Adjust to the fact that the state size is now
1073 runtime-configurable.
1074 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1075 (usage): Add options --random-sort and --seed to implement a random
1077 Include md5.h and rand-isaac.h.
1078 (get_hash): New function.
1079 (rand_state): New var.
1080 (HASH_WORDS, HASH_SIZE): New macros.
1082 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1084 * tests/dd/misc: Add test for dd iflags=noatime.
1086 2005-12-09 Jim Meyering <jim@meyering.net>
1088 * src/sort.c (usage): Mention white space vs -b and -t options.
1091 2005-12-09 Eric Blake <ebb9@byu.net>
1093 * src/test.c (main): Fix misleading comment.
1095 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1097 * NEWS: Mention dd's new noatime flag.
1098 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1099 * src/dd.c (flags, usage): Add support for noatime flag.
1101 2005-12-07 Jim Meyering <jim@meyering.net>
1103 Distribute the cvsu script, used only by `make syntax-check'.
1104 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1105 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1106 distribute a copy of this script.
1107 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1109 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1110 to create a temporary directory on another partition.
1111 From Andreas Gruenbacher.
1113 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1115 * man/basename.x: Cross-reference to dirname and readlink.
1116 * man/dirname.x: Cross-reference to basename and readlink.
1118 2005-12-05 Andreas Gruenbacher
1120 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1121 (set_owner, preserve_author): New functions, factored out of copy_reg.
1122 (copy_reg): Use them.
1123 (copy_internal): Use them here, too.
1125 2005-12-04 Jim Meyering <jim@meyering.net>
1127 * src/sleep.c (usage): Say what happens with two or more arguments.
1128 Suggested by Justin Pryzby.
1130 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1133 2005-12-03 Jim Meyering <jim@meyering.net>
1135 * src/rm.c (long_opts): Change the name of each undocumented, for-
1136 testing-only option to start with `-', so that it cannot render
1137 ambiguous any prefix it happens to share with some other option name.
1138 Problem reported by Eric Blake.
1139 * src/head.c (long_options): Likewise.
1140 * src/tail.c (long_options): Likewise.
1142 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1143 testing-only --presume* options to start with `---'.
1144 * tests/rm/dangling-symlink: Likewise.
1145 * tests/rm/dir-no-w: Likewise.
1146 * tests/rm/isatty: Likewise.
1148 2005-11-30 Jim Meyering <jim@meyering.net>
1150 * Makefile.maint: Add a comment about cvsu.
1152 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1154 * NEWS: df updates for "none", "proc", inaccessible file systems.
1155 * src/df.c (show_point): Ignore inaccessible file systems.
1156 (usage): -a includes dummy file systems, not size-0 file systems.
1158 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1159 to avoid collision with POSIX name space. All uses changed.
1161 2005-11-24 Jim Meyering <jim@meyering.net>
1163 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1164 * tests/acl: Add `$0: ' prefix to diagnostics.
1166 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1168 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1170 * src/copy.c: Improve performance a bit by optimizing away
1171 unnecessary system calls and going to a block size of at least
1172 8192 (on normal hosts, anyway). This improved performance 5% on my
1173 Debian stable host (2.4.27 kernel, x86, copying from root
1174 ext3 file system to itself).
1175 Include "buffer-lcm.h".
1176 (copy_reg): Omit last argument. All callers changed.
1177 Use xmalloc to allocate rather than trusting alloca
1178 (which is unwise with large block sizes).
1179 Declare locals more locally, if possible.
1180 Use uintptr_t words instead of int words, for a bit more speed
1181 when looking for null blocks on 64-bit hosts.
1182 Optimize away reads of zero bytes on regular files.
1183 In the typical case, insist on 8 KiB buffers, at least.
1184 Avoid unnecessary extra call to fstat when checking for sparse files.
1185 Avoid now-unnecessary cast to off_t, and "0L".
1186 Avoid unnecessary test of *new_dst when checking for same owner
1189 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1191 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1193 2005-11-22 Jim Meyering <jim@meyering.net>
1195 * src/remove.c (AD_push): Remove debugging cruft.
1197 * tests/rm/unread2 (rm): Change expected diagnostic,
1198 `cannot open directory' to `cannot remove', to align with
1200 * tests/rm/rm2: Ensure that rm now continues removing entries
1201 even after certain types of failure.
1203 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1204 that provide openat (Solaris), and on systems like Linux+procfs
1205 where our openat emulation code is reentrant. This also fixes a
1206 few low-probability leaks and eliminates some code that could,
1207 in very unusual circumstances, cause rm() (via a callee) to exit.
1208 * NEWS: Mention this.
1210 * configure.ac: Put copyright dates all on one line so the
1211 emacs function that updates them works properly.
1213 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1215 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1216 Problem reported by Eric Blake.
1217 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1218 we get a standard-conforming compiler. This relies on the new
1219 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1220 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1221 m4/c.m4 can go away with Autoconf 2.60 comes out.
1223 2005-11-17 Jim Meyering <jim@meyering.net>
1225 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1226 (AD_mark_current_as_unremovable): Likewise, but for a local.
1229 * tests/mv/acl: Let traps handle removing temporary directories.
1231 Expect acl-related tests to fail, until the corresponding
1232 patches are committed.
1233 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1234 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1236 ACL tests, from Andreas Gruenbacher.
1237 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1238 * tests/mv/Makefile.am (TESTS): Add acl.
1239 * tests/cp/Makefile.am (TESTS): Add acl.
1241 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1243 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1245 * NEWS: Improve quality of ln's diagnostics.
1246 * src/ln.c (do_link, usage): Likewise.
1247 (do_link): Don't use alloca on a buffer of unbounded size.
1249 2005-11-16 Jim Meyering <jim@meyering.net>
1251 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1252 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1253 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1254 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1255 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1257 2005-11-14 Jim Meyering <jim@meyering.net>
1259 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1261 2005-11-13 Jim Meyering <jim@meyering.net>
1263 * announce-gen: Accept new option, --gpg-key-id=ID and
1264 emit a blurb telling how to use the .sig files.
1265 * Makefile.cfg (gpg_key_ID): Define.
1266 * Makefile.maint (announcement): Use new option and key.
1268 Require that most .c files include <config.h>.
1269 * Makefile.maint (sc_require_config_h): New rule.
1270 (syntax-check-rules): Add it.
1271 * .x-sc_require_config_h: New file listing exceptions to the
1272 above rule. Some are legit, others are simply grandfathered in.
1273 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1275 2005-11-12 Jim Meyering <jim@meyering.net>
1277 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1279 2005-11-11 Jim Meyering <jim@meyering.net>
1281 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1282 Mention new readlink options in 5.3.0's `New features' section.
1283 Spotted by Thomas Hood.
1285 2005-11-08 Jim Meyering <jim@meyering.net>
1287 * NEWS: Merge in changes from b5_9x branch.
1289 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1291 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1292 like --time-style='posix-long-iso' if the locale settings are messed up.
1293 * src/ls.c (decode_switches): Implement this.
1295 2005-11-08 Jim Meyering <jim@meyering.net>
1297 * tests/du/2g: s/expensive/very expensive/ in a comment.
1300 2005-10-17 Eric Blake <ebb9@byu.net>
1302 * src/ls.c (usage): Fix descriptions of --sort, --time.
1303 Reported by Vitaly A. Ostanin.
1305 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1307 * src/ln.c: Include filenamecat.c.
1308 (FILE_BASENAME_CONCAT): Remove.
1309 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1310 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1311 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1314 2005-11-04 Jim Meyering <jim@meyering.net>
1316 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1317 on systems with stat.st_blocks of a signed 32-bit type.
1318 This bug causes trouble on some AIX 5.1 systems.
1319 Report and trivial patch from Paul Townsend:
1320 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1321 * NEWS: Mention this.
1323 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1324 * tests/du/Makefile.am (TESTS): Add it here.
1325 * tests/very-expensive: New file.
1326 * tests/Makefile.am (EXTRA_DIST): Add it here.
1327 * tests/cp/perm: Mark this test as `very-expensive', too.
1329 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1331 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1333 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1335 * src/rm.c (usage): Don't mention rm -d.
1337 2005-11-02 Jim Meyering <jim@meyering.net>
1339 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1340 From Andreas Schwab.
1342 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1343 `M+N records in/out' lines don't pollute `make check' output.
1345 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1346 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1347 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1348 to indicate that the input file should be piped into the command
1349 under test (via `cat FILE | $prog ...').
1351 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1352 (without -r) fails to remove a directory on a non-Linux system.
1353 This change affects only newer Solaris systems (with priv_*
1354 functions like priv_allocset). Reported by Keith Thompson.
1356 * tests/rm/dir-nonrecur: New file/test for the above fix.
1357 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1359 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1361 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1362 POSIX 1002.1-2001 requires.
1363 * src/tail.c (parse_obsolete_option): Implement this.
1364 Problem reported by Vincent Lefevre.
1365 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1366 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1367 (test_vector): Add special cases for _POSIX2_VERSION, and
1368 regularize the old ones a bit.
1369 * tests/touch/obsolescent: Add y2000 test.
1371 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1373 * src/dd.c (skip): Fix off-by-one error reported by
1374 Theodoros V. Kalamatianos.
1376 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1378 * tests/mkdir/p-3: Require that the test be run as non-root.
1379 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1381 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1383 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1384 boundary between DEST and SOURCE in the result.
1386 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1388 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1389 back to text, to sync with documentation and for backwards
1392 2005-10-25 Jim Meyering <jim@meyering.net>
1394 * tests/dircolors/simple (other-wr): Add an explicit test for
1395 the dircolors bug (NULL-dereference) fixed yesterday.
1397 2005-10-24 Jim Meyering <jim@meyering.net>
1399 * src/tac.c (tac_file): When determining whether a file is seekable,
1400 also test whether it is a tty. Using only the lseek-based test would
1401 give a false positive on Solaris. Reported by Peter Fales.
1403 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1405 * tests/install/d-slashdot: New test, for "install -d" failure.
1406 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1407 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1408 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1410 2005-10-24 Jim Meyering <jim@meyering.net>
1412 * src/dircolors.c (ls_codes): Add missing comma.
1413 Anonymous report and patch from
1414 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1416 * src/dircolors.c: Add compile-time assertion that the slack_codes
1417 and ls_codes arrays have the same number of elements. This would
1418 have prevented the above-fixed bug.
1420 * src/expand.c (parse_tab_stops): Add a comment to make this function
1421 identical to the one in unexpand.c.
1422 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1423 identical to the one in expand.c.
1425 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1427 2005-10-23 Jim Meyering <jim@meyering.net>
1429 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1430 a dangerous pointer-value-to-`unsigned' cast.
1431 * NEWS: mention the new sha* programs.
1432 * AUTHORS: Add new sha* programs.
1434 2005-08-28 David Madore <david.madore@ens.fr>
1436 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1437 * README: Add their names to the list.
1438 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1439 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1440 Rules for compiling sha-2 utilities
1441 (noinst_HEADERS): Remove checksum.h.
1442 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1444 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1445 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1446 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1447 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1448 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1449 sha384sum, sha512sum test scripts here rather that each in its
1452 2005-08-28 David Madore <david.madore@ens.fr>
1454 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1455 of the FIPS test vectors).
1457 2005-10-23 Jim Meyering <jim@meyering.net>
1459 * configure.ac: Use 6.0-cvs as the version string.
1460 * NEWS: Adjust accordingly.