1 2003-08-28 Havoc Pennington <hp@pobox.com>
5 * dbus/dbus-connection.c: port to no ObjectID, create a
6 DBusObjectTree, rename ObjectTree to ObjectPath in public API
8 * dbus/dbus-connection.h (struct DBusObjectTreeVTable): delete
9 everything except UnregisterFunction and MessageFunction
11 * dbus/dbus-marshal.c: port away from DBusObjectID,
12 add DBUS_TYPE_OBJECT_PATH
14 * dbus/dbus-object-registry.[hc], dbus/dbus-object.[hc],
15 dbus/dbus-objectid.[hc]: remove these, we are moving to
18 2003-08-25 Havoc Pennington <hp@pobox.com>
20 Just noticed that dbus_message_test is hosed, I wonder when I
21 broke that. I thought make check was passing earlier...
23 * dbus/dbus-object-tree.c: add new "object tree" to match DCOP
24 container tree, will replace most of dbus-object-registry
26 * dbus/dbus-string.c (_dbus_string_append_printf_valist): fix C99
29 2003-08-19 Havoc Pennington <hp@pobox.com>
31 * dbus/dbus-message.c (decode_string_field): support FIELD_SENDER
32 (dbus_message_is_error): fix this function
34 * bus/dbus-daemon-1.1: clarify logic on when <deny>/<allow> rules
37 * bus/policy.c (bus_client_policy_check_can_receive): fix code to
38 reflect clarified man page
39 (bus_client_policy_check_can_send): ditto
41 * bus/session.conf.in: fixup
43 * bus/system.conf.in: fixup
45 2003-08-18 Havoc Pennington <hp@redhat.com>
47 * dbus/dbus-hash.c (_dbus_hash_table_insert_two_strings): fix
49 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
50 dumb bug created earlier (wrong order of args to
53 * tools/dbus-send.c: port
55 * tools/dbus-print-message.c (print_message): port
57 * test/data/*messages: port all messages over
59 * dbus/dbus-message-builder.c: support including
62 * bus/driver.c: port over
64 * bus/dispatch.c: port over to new stuff
66 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
67 rename disconnect signal to "Disconnected"
69 2003-08-17 Havoc Pennington <hp@pobox.com>
71 This doesn't compile yet, but syncing up so I can hack on it from
72 work. What are branches for if not broken code? ;-)
74 * dbus/dbus-protocol.h: remove DBUS_HEADER_FIELD_NAME, add
75 DBUS_HEADER_FIELD_INTERFACE, DBUS_HEADER_FIELD_MEMBER,
76 DBUS_HEADER_FIELD_ERROR_NAME
78 * dbus/dbus-hash.c: Introduce DBUS_HASH_TWO_STRINGS as hack to use
79 for the interface+member pairs
80 (string_hash): change to use g_str_hash algorithm
81 (find_direct_function, find_string_function): refactor these to
84 * dbus/dbus-message.c: port all of this over to support
85 interface/member fields instead of name field
87 * dbus/dbus-object-registry.c: port over
89 * dbus/dbus-string.c (_dbus_string_validate_interface): rename
90 from _dbus_string_validate_name
92 * bus/dbus-daemon-1.1: change file format for the
93 <deny>/<allow> stuff to match new message naming scheme
95 * bus/policy.c: port over
97 * bus/config-parser.c: parse new format
99 2003-08-16 Havoc Pennington <hp@pobox.com>
101 * dbus/dbus-object-registry.c (add_and_remove_objects): remove
104 * glib/dbus-gproxy.c: some hacking
106 2003-08-15 Havoc Pennington <hp@redhat.com>
108 * dbus/dbus-pending-call.c (dbus_pending_call_block): implement
110 * dbus/dbus-connection.c
111 (dbus_connection_send_with_reply_and_block): factor out internals;
112 change to convert any error replies to DBusError instead of
113 returning them as a message
115 2003-08-15 Havoc Pennington <hp@pobox.com>
117 * dbus/dbus-connection.c,
118 dbus/dbus-pending-call.c: Finish the pending call stuff
120 2003-08-14 Havoc Pennington <hp@redhat.com>
122 * dbus/dbus-pending-call.c: start on new object that will replace
123 DBusMessageHandler and ReplyHandlerData for tracking outstanding
126 * dbus/dbus-gproxy.c: start on proxy object used to communicate
127 with remote interfaces
129 * dbus/dbus-gidl.c: do the boring boilerplate in here
131 2003-08-12 Havoc Pennington <hp@pobox.com>
133 * bus/dispatch.c (bus_dispatch): make this return proper
134 DBusHandlerResult to avoid DBUS_ERROR_UNKNOWN_METHOD
136 * dbus/dbus-errors.c (dbus_set_error): use
137 _dbus_string_append_printf_valist
139 * dbus/dbus-string.c (_dbus_string_append_printf_valist)
140 (_dbus_string_append_printf): new
142 * dbus/dbus-errors.h (DBUS_ERROR_UNKNOWN_MESSAGE): change to
145 * dbus/dbus-connection.c (dbus_connection_dispatch): handle
146 DBUS_HANDLER_RESULT_NEED_MEMORY; send default error reply if a
147 message is unhandled.
149 2003-08-11 Havoc Pennington <hp@pobox.com>
151 * bus/test.c (client_disconnect_handler): change to return
152 HANDLED (would have been REMOVE_MESSAGE)
154 * dbus/dbus-object.h (enum DBusHandlerResult): rename to
155 HANDLED/NOT_YET_HANDLED instead of
156 REMOVE_MESSAGE/ALLOW_MORE_HANDLERS to make it clearer how it
159 2003-08-10 Havoc Pennington <hp@pobox.com>
161 * tools/dbus-send.c (main): add --type argument, for now
162 supporting only method_call and signal types.
164 * tools/dbus-print-message.c: print message type
166 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
167 init connection->objects
169 * doc/dbus-specification.sgml: fix sgml
171 * bus/*.c: port over to object-instance API changes
173 * test/test-service.c: ditto
175 * dbus/dbus-message.c (dbus_message_create_header): allow #NULL
176 name, we will have to fix up the rest of the code to also handle
178 (dbus_message_new): generic message-creation call
179 (set_string_field): allow appending name field
181 2003-08-06 Havoc Pennington <hp@pobox.com>
183 * dbus/dbus-object-registry.c: implement signal connection
186 * dbus/dbus-connection.c (_dbus_connection_unref_unlocked): new
188 * dbus/dbus-internals.c (_dbus_memdup): new function
190 2003-08-02 Havoc Pennington <hp@pobox.com>
192 * dbus/dbus-message.c (dbus_message_get_no_reply)
193 (dbus_message_set_no_reply): add these and remove
194 set_is_error/get_is_error
196 * dbus/dbus-protocol.h, doc/dbus-specification.sgml:
197 remove the ERROR flag, since there's now an ERROR type
199 2003-08-01 Havoc Pennington <hp@pobox.com>
201 * dbus/dbus-object-registry.c (_dbus_object_registry_handle_and_unlock):
204 * dbus/dbus-message.c (dbus_message_get_type): new function
206 * doc/dbus-specification.sgml: add "type" byte to messages
208 2003-08-01 Havoc Pennington <hp@pobox.com>
210 * dbus/dbus-protocol.h (DBUS_MESSAGE_TYPE_*): introduce
211 a message type enum to distinguish kinds of message
212 (DBUS_HEADER_FLAG_NO_REPLY_EXPECTED): flag for a message
213 that need not be replied to
215 2003-08-01 Havoc Pennington <hp@pobox.com>
217 * dbus/dbus-marshal.c: adapt to DBusObjectID changes
218 (unpack_8_octets): fix no-64-bit-int bug
220 * dbus/dbus-object-registry.c (validate_id): validate the
221 connection ID bits, not just the instance ID.
223 * dbus/dbus-connection.c (_dbus_connection_init_id): initialize
224 the connection-global 33 bits of the object ID
226 * dbus/dbus-object-registry.c (info_from_entry): fill in
227 object ID in the new way
229 * dbus/dbus-objectid.h: rather than high/low bits, specifically
230 define server/client/instance bits.
232 2003-07-30 Havoc Pennington <hp@pobox.com>
234 * dbus/dbus-connection.c (dbus_connection_register_object): fix
237 2003-07-13 Havoc Pennington <hp@pobox.com>
239 * dbus/dbus-object.h (struct DBusObjectVTable): add padding
240 fields to DBusObjectVTable and DBusObjectInfo
242 2003-07-12 Havoc Pennington <hp@pobox.com>
244 * dbus/dbus-object-registry.c: implement unit test,
245 fix bugs discovered in process
247 * dbus/dbus-connection.c: remove handler_table and
248 register_handler(), add DBusObjectRegistry usage
250 * dbus/dbus-objectid.c (dbus_object_id_is_null)
251 (dbus_object_id_set_null): new functions
253 2003-07-08 Havoc Pennington <hp@pobox.com>
255 * dbus/dbus-object.c: implement some of this
257 * dbus/dbus-object-registry.c
258 (_dbus_object_registry_add_and_unlock): fill in the object_id out
260 (_dbus_object_registry_new): handle OOM
262 2003-07-08 Havoc Pennington <hp@pobox.com>
264 * dbus/dbus-object.h: sketch out an API for registering objects
265 with a connection, that allows us to use as little as 24 bytes
266 per object and lets application code represent an object in
269 * dbus/dbus-object-registry.c: implement the hard bits of the
270 DBusConnection aspect of object API. Not yet wired up.
272 2003-07-06 Havoc Pennington <hp@pobox.com>
274 * dbus/dbus-marshal.c (_dbus_marshal_set_object_id): new function
275 (_dbus_marshal_object_id): new
276 (_dbus_demarshal_object_id): new
277 (_dbus_marshal_get_arg_end_pos): support object ID type, and
278 consolidate identical switch cases. Don't conditionalize handling
279 of DBUS_TYPE_UINT64, need to handle the type always.
280 (_dbus_marshal_validate_arg): consolidate identical cases, and
281 handle DBUS_TYPE_OBJECT_ID
283 * dbus/dbus-objectid.c: new file with DBusObjectID data type.
285 * dbus/dbus-protocol.h: add DBUS_TYPE_OBJECT_ID
287 2003-06-29 Havoc Pennington <hp@pobox.com>
289 * mono/Test.cs (class Test): fire up a main loop and run it
291 * mono/DBus.cs (DBus): don't g_thread_init since it can only be
292 done once, the app has to do it
294 2003-06-26 Havoc Pennington <hp@pobox.com>
296 * mono/Connection.cs: set up connection with the glib main loop
298 2003-07-01 Havoc Pennington <hp@redhat.com>
300 * doc/dbus-specification.sgml: clarify the format of a type code,
301 change suggested by Jim Blandy
303 2003-06-29 Miloslav Trmac <mitr@volny.cz>
306 * tools/Makefile.am: Don't assume srcdir == builddir.
308 * dbus/dbus-memory.c (dbus_realloc): Don't check guards after shrinking
310 (_dbus_memory_test): New function.
311 * dbus/dbus-test.h: Add _dbus_memory_test ().
312 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): Call it.
314 * dbus/dbus-message.c (decode_header_data): Use %.4s instead
316 (dbus_message_new): Remove obsolete @todo.
318 * dbus/dbus-marshal.c (_dbus_marshal_set_int64)
319 (_dbus_marshal_set_uint64): Fix comment.
321 * dbus/dbus-message.c (append_int_field, append_uint_field): Don't
322 hardcode FIELD_REPLY_SERIAL.
324 * dbus/dbus-mainloop.c (_dbus_loop_remove_watch)
325 (_dbus_loop_remove_timeout): Cast function pointers to (void *) for %p
327 * configure.in: Add -D_POSIX_C_SOURCE=199309L -DBSD_SOURCE to CFLAGS
328 and disable DBUS_USE_ATOMIC_INT_486 when --enable-ansi is used
330 2003-06-24 Havoc Pennington <hp@pobox.com>
332 * mono/*.cs: Use IntPtr.Zero instead of ((IntPtr) 0)
334 2003-06-23 Anders Carlsson <andersca@codefactory.se>
340 * gcj/TestMessage.java: (TestMessage), (TestMessage.main):
341 * gcj/org/.cvsignore:
342 * gcj/org/Makefile.am:
343 * gcj/org/freedesktop/.cvsignore:
344 * gcj/org/freedesktop/Makefile.am:
345 * gcj/org/freedesktop/dbus/.cvsignore:
346 * gcj/org/freedesktop/dbus/Makefile.am:
347 * gcj/org/freedesktop/dbus/Message.java: (Message),
349 * gcj/org/freedesktop/dbus/natMessage.cc:
350 Fix the build system.
352 2003-06-22 Havoc Pennington <hp@pobox.com>
354 * mono/Connection.cs: add more bindings
356 * dbus/dbus-threads.c (dbus_threads_init): allow calling this
359 2003-06-22 Havoc Pennington <hp@pobox.com>
361 * mono/Connection.cs, mono/DBus.cs, mono/Error.cs:
362 Start wrapping more stuff.
364 2003-06-22 Havoc Pennington <hp@pobox.com>
366 * mono/Message.cs: implement Message.Wrap() that ensures we only
367 have a single C# wrapper per DBusMessage, assuming it works which
370 * dbus/dbus-message.c (dbus_message_allocate_data_slot): new
371 (dbus_message_free_data_slot): new
372 (dbus_message_set_data): new
373 (dbus_message_get_data): new
375 2003-06-22 Havoc Pennington <hp@pobox.com>
377 * dbus/dbus-dataslot.c (_dbus_data_slot_allocator_unref)
378 (_dbus_data_slot_allocator_alloc): rework these to keep a
379 reference count on each slot and automatically manage a global
380 slot ID variable passed in by address
382 * bus/bus.c: convert to new dataslot API
384 * dbus/dbus-bus.c: convert to new dataslot API
386 * dbus/dbus-connection.c: convert to new dataslot API
388 * dbus/dbus-server.c: convert to new dataslot API
390 * glib/dbus-gmain.c: ditto
394 * bus/connection.c: ditto
396 2003-06-22 Anders Carlsson <andersca@codefactory.se>
398 * configure.in: Add AM_PROG_GCJ and move AM_PROG_LIBTOOL
399 after the gcj checks so that the correct configuration tags
400 will be added to libtool.
402 * dbus-glib-1.pc.in: No need to specify any includes since
403 dbus-1.pc.in has those.
405 2003-06-22 Havoc Pennington <hp@pobox.com>
407 * mono/*, gcj/*, configure.in, Makefile.am:
408 Check in makefiles and subdirs for mono and gcj bindings.
409 Neither binding actually exists, just trying to get through
410 all the build and other boring bits.
412 2003-06-21 Philip Blundell <philb@gnu.org>
414 * tools/dbus-monitor.1: Updated.
416 * tools/dbus-send.1: Likewise.
418 2003-06-20 Anders Carlsson <andersca@codefactory.se>
420 * dbus/dbus-transport-unix.c (unix_handle_watch): Check
421 for hangup and error after checking read so we won't discard
422 pending data if both hangup and read are set.
424 2003-06-19 Philip Blundell <philb@gnu.org>
426 * tools/dbus-print-message.c (print_message): Handle BOOLEAN.
428 * tools/dbus-send.c: Accept both --system and --session.
430 * tools/dbus-monitor.c: Same here.
432 2003-06-19 Anders Carlsson <andersca@codefactory.se>
434 * glib/dbus-glib.h: Fix so that dbus-glib.h can be used
435 from C++ (Patch by Miloslav Trmac).
437 2003-06-15 Joe Shaw <joe@assbarn.com>
439 * configure.in: Check for socklen_t.
441 * dbus/dbus-sysdeps.c: Define socklen_t if it's not defined.
443 * test/test-segfault.c: Add #include <sys/time.h>
445 * tools/Makefile.am: Add DBUS_X_CFLAGS to the INCLUDES since
446 dbus-launch needs it.
448 2003-06-09 Havoc Pennington <hp@redhat.com>
450 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): don't use
451 SUN_LEN, it breaks abstract socket usage
453 * dbus/dbus-internals.c (_dbus_verbose_real): only print PID at
456 2003-06-04 Havoc Pennington <hp@pobox.com>
458 * dbus/dbus-server.c (dbus_server_listen): allow abstract sockets
459 using unix:abstract=/foo, and when listening in a tmpdir
460 i.e. unix:tmpdir=/tmp, always use abstract sockets if we can.
462 * dbus/dbus-transport.c (_dbus_transport_open): support
465 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
466 support abstract sockets
468 * dbus/dbus-transport-unix.c
469 (_dbus_transport_new_for_domain_socket): support abstract sockets
471 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket): add "abstract"
472 toggle as an argument, implement abstract namespace support
473 (_dbus_listen_unix_socket): ditto
475 * configure.in: add --enable-abstract-sockets and implement
476 a configure check for autodetection of the right value.
478 2003-06-01 Havoc Pennington <hp@pobox.com>
480 * tools/dbus-cleanup-sockets.c: add utility to clean up sockets
481 in /tmp (though on Linux this will end up being useless,
482 when we add abstract namespace support)
484 * configure.in: define DBUS_SESSION_SOCKET_DIR in addition to
487 2003-05-28 Colin Walters <walters@verbum.org>
489 * tools/dbus-monitor.c (main): Fix silly typo (s/--session/--system/).
491 2003-05-18 Anders Carlsson <andersca@codefactory.se>
493 * dbus/dbus-message.c (dbus_message_new): Remove @todo.
495 2003-05-17 Colin Walters <walters@gnu.org>
497 * tools/dbus-send.c: Don't exit with an error code if --help was
498 passed. Default to using the session bus instead of the system
501 * tools/dbus-launch.c: Ditto.
503 * tools/dbus-monitor.c: Ditto.
505 * tools/dbus-send.1: Update with new arguments.
507 * tools/dbus-launch.c: Emit code to export variables. New
508 arguments -s and -c to specify shell syntax, and a bit of code to
509 autodetect syntax. Also, allow specifying a program to run.
511 * tools/dbus-launch.1: Update with new arguments.
513 * tools/dbus-send.1: Ditto.
515 * tools/dbus-monitor.1: Ditto.
517 2003-05-17 Havoc Pennington <hp@pobox.com>
519 * bus/config-parser.c (merge_included): merge in policies from
520 child configuration file.
522 * bus/policy.c (bus_policy_merge): function to merge two policies
525 2003-05-16 Havoc Pennington <hp@redhat.com>
527 * dbus/dbus-connection.c: disable verbose lock spew
529 * tools/dbus-send.c: add --print-reply command line option
531 * tools/dbus-print-message.h (print_message): new util function
532 shared by dbus-send and dbus-monitor
534 * tools/dbus-monitor.c (handler_func): exit on disconnect
536 * dbus/dbus-transport-unix.c (do_reading): if the transport is
537 disconnected, don't try to use the read_watch
539 * dbus/dbus-watch.c (dbus_watch_get_enabled): assert watch != NULL
540 so we can find this bug more easily
542 2003-05-16 Havoc Pennington <hp@redhat.com>
544 * bus/policy.c (free_rule_list_func): avoid a crash when passed
545 NULL as DBusHashTable is annoyingly likely to do.
547 2003-05-16 Colin Walters <walters@verbum.org>
549 * tools/dbus-monitor.c: Add --session argument and usage()
552 * tools/dbus-monitor.1: Update with new --session arg.
554 * bus/Makefile.am (install-data-hook): Create
555 $(libdir)/dbus-1.0/services so that the session bus is happy.
557 2003-05-15 Havoc Pennington <hp@redhat.com>
559 * dbus/dbus-sysdeps.c (_dbus_atomic_dec, _dbus_atomic_inc): work
560 on non-x86. ifdef's are evil.
562 2003-05-15 Havoc Pennington <hp@redhat.com>
568 * bus/Makefile.am (initddir): apparently we are supposed to put
569 init scripts in /etc/rc.d/init.d not /etc/init.d
571 * bus/Makefile.am: remove the "you must --enable-tests to make
572 check" as it broke distcheck
574 * bus/Makefile.am (install-data-hook): create /etc/dbus-1/system.d
576 2003-05-13 James Willcox <jwillcox@gnome.org>
579 * bus/activation.c: (bus_activation_service_created),
580 (bus_activation_activate_service):
581 * bus/driver.c: (bus_driver_send_service_deleted),
582 (bus_driver_send_service_created), (bus_driver_send_service_lost),
583 (bus_driver_send_service_acquired),
584 (bus_driver_send_welcome_message),
585 (bus_driver_handle_list_services):
586 * bus/session.conf.in:
587 * dbus/dbus-bus.c: (dbus_bus_acquire_service),
588 (dbus_bus_service_exists), (dbus_bus_activate_service):
591 Add some convenience API which lets you activate a service, and did a
592 bunch of s/0/DBUS_TYPE_INVALID/ in calls to dbus_message_append_args()
593 and dbus_message_get_args()
595 2003-05-11 Havoc Pennington <hp@pobox.com>
597 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix to avoid
598 calling _dbus_marshal_validate_arg() for every byte in a byte
601 * dbus/dbus-message-handler.c: use atomic reference counting to
602 reduce number of locks slightly; the global lock in here sucks
604 * dbus/dbus-connection.c
605 (_dbus_connection_update_dispatch_status_and_unlock): variant of
606 update_dispatch_status that can be called with lock held; then use
607 in a couple places to reduce locking/unlocking
608 (dbus_connection_send): hold the lock over the whole function
609 instead of acquiring it twice.
611 * dbus/dbus-timeout.c (_dbus_timeout_new): handle OOM
613 * bus/connection.c (bus_connections_setup_connection): fix access
614 to already-freed memory.
616 * dbus/dbus-connection.c: keep a little cache of linked list
617 nodes, to avoid using the global linked list alloc lock in the
618 normal send-message case. Instead we just use the connection lock
619 that we already have to take.
621 * dbus/dbus-list.c (_dbus_list_find_last): new function
623 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec):
624 change to use a struct for the atomic type; fix docs,
625 they return value before increment, not after increment.
627 * dbus/dbus-string.c (_dbus_string_append_4_aligned)
628 (_dbus_string_append_8_aligned): new functions to try to
629 microoptimize this operation.
630 (reallocate_for_length): break this out of set_length(), to
631 improve profile info, and also so we can consider inlining the
634 * dbus/dbus-message.c (dbus_message_new_empty_header): init data
635 strings with some preallocation, cuts down on our calls to realloc
636 a fair bit. Though if we can get the "move entire string to empty
637 string" optimization below to kick in here, it would be better.
639 * dbus/dbus-string.c (_dbus_string_move): just call
640 _dbus_string_move_len
641 (_dbus_string_move_len): add a special case for moving
642 an entire string into an empty string; we can just
643 swap the string data instead of doing any reallocs.
644 (_dbus_string_init_preallocated): new function
646 2003-05-11 Havoc Pennington <hp@pobox.com>
648 Write a "test-profile" that does echo client-server with threads;
649 profile reveals lock contention, memcpy/realloc of buffers, and
650 UTF-8 validation as hot spots. 20% of lock contention eliminated
651 with dbus_atomic_inc/dec implementation on x86. Much remaining
652 contention is global mempool locks for GList and DBusList.
654 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec): add
657 * dbus/dbus-connection.c (struct DBusConnection): use
658 dbus_atomic_t for the reference count
660 * dbus/dbus-message.c (struct DBusMessage): declare
661 dbus_atomic_t values as volatile
663 * configure.in: code to detect ability to use atomic integer
664 operations in assembly, from GLib patch
666 * dbus/dbus-internals.c (_dbus_verbose_real): call getpid every
667 time, tired of it being wrong in threads and forked processes
669 * glib/test-profile.c: a little program to bounce messages back
670 and forth between threads and eat CPU
672 * dbus/dbus-connection.c: add debug spew macros for debugging
673 thread locks; include config.h at top; fix deadlock in
674 dbus_connection_flush()
676 2003-05-08 Havoc Pennington <hp@pobox.com>
678 * dbus/dbus-spawn.c: s/_exit/exit/ because it was keeping gcov
679 data from getting written, and there wasn't a good reason to
682 * test/decode-gcov.c (mark_inside_dbus_build_tests): don't count
683 dbus_verbose lines in test coverage
684 (main): add list of functions sorted by # of untested blocks
685 to the coverage report
687 * dbus/dbus-mempool.c: put some test-only code in DBUS_BUILD_TESTS
689 * dbus/dbus-marshal.c (_dbus_marshal_test): extend test coverage
691 * dbus/dbus-message-handler.c (_dbus_message_handler_test):
694 * test/data/auth/cancel.auth-script: test canceling an
697 * dbus/Makefile.am: remove dbus-server-debug.[hc] for now, as they
698 aren't used. in CVS history if we end up needing them.
700 2003-05-04 Havoc Pennington <hp@pobox.com>
702 * dbus/dbus-message-handler.c (_dbus_message_handler_test): add
705 * dbus/dbus-marshal.c (_dbus_demarshal_string_array): fix this
706 function, which assumed length was in # of strings, not bytes
708 * dbus/dbus-message.c (_dbus_message_test): add tests for some
711 * dbus/dbus-connection.c
712 (_dbus_connection_queue_received_message): disable function for
713 now, we are only using it in test mode
715 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
716 remove a mistaken FIXME
718 2003-05-04 Havoc Pennington <hp@pobox.com>
720 * dbus/dbus-connection.c (dbus_connection_preallocate_send):
721 unlock mutex on successful return, patch from Anders Gustafsson
723 2003-05-04 Havoc Pennington <hp@pobox.com>
725 * dbus-glib-1.pc.in (Requires): fix dependencies, from
728 2003-05-04 Havoc Pennington <hp@pobox.com>
730 * tools/dbus-launch.c: implement
732 * bus/main.c (main), bus/bus.c (bus_context_new):
733 implement --print-pid and --fork
735 2003-05-03 Havoc Pennington <hp@redhat.com>
737 * dbus/dbus-address.c (dbus_parse_address): fix bug when a key in
738 the address had no value, and add to test suite. Fix and
739 regression test from Miloslav Trmac
741 2003-05-03 Havoc Pennington <hp@pobox.com>
743 * dbus/dbus-watch.c (dbus_watch_handle): warn and return if a
744 watch is invalid when handled
746 * tools/Makefile.am, tools/dbus-launch.c, tools/dbus-launch.1: add
747 dbus-launch utility to launch the bus from a shell script. Didn't
748 actually implement dbus-launch yet, it's just a placeholder still.
750 2003-05-03 Havoc Pennington <hp@pobox.com>
752 * bus/Makefile.am, bus/dbus-daemon-1.1.in: man page for the
753 daemon; also documents daemon config file, so replaces
754 doc/config-file.txt. Corrected some stuff from config-file.txt in
755 the process of moving it.
757 2003-05-03 Havoc Pennington <hp@pobox.com>
759 * tools/Makefile.am, tools/dbus-send.1, tools/dbus-monitor.1:
762 2003-05-03 Colin Walters <walters@verbum.org>
764 * dbus/dbus-sysdeps.c (fill_user_info): Test against
765 DBUS_UID_UNSET to determine whether to do a uid lookup or not.
767 * Makefile.am: Update to use new .pc versioning scheme.
769 2003-05-02 Havoc Pennington <hp@redhat.com>
771 * bus/system.conf.in: allow send/receive to/from message bus
774 2003-04-30 Havoc Pennington <hp@redhat.com>
776 * configure.in: print a note when building with unit tests and
779 2003-04-30 Havoc Pennington <hp@redhat.com>
781 * Makefile.am: add a check-local that complains if you didn't
782 configure with --enable-tests
784 2003-04-29 Havoc Pennington <hp@redhat.com>
786 * glib/dbus-gmain.c: docs cleanups
788 * dbus/dbus-types.h: add docs on int64 types
790 * dbus/dbus-memory.c: fix docs to avoid putting private API in
791 public API docs section
793 2003-04-29 Havoc Pennington <hp@redhat.com>
795 * dbus-1.pc.in, dbus-glib-1.pc.in: rename these from
796 dbus-1.0.pc.in, dbus-glib-1.0.pc.in. As these change with the
797 parallel install API version, not with the D-BUS package version.
799 * HACKING: move some of README over here
801 * README: updates, and document API/ABI policy
803 * configure.in: reindentation
805 2003-04-29 Havoc Pennington <hp@redhat.com>
807 * dbus/dbus.h: add "you have to define DBUS_API_SUBJECT_TO_CHANGE
808 to use this library" to be sure people have the right
811 2003-04-28 Havoc Pennington <hp@redhat.com>
813 * configure.in: add --enable-docs which by default is auto yes if
814 doxygen and db2html found, no otherwise; but can be forced on/off
816 * doc/Makefile.am: conditionalize whether to build docs on
819 2003-04-28 Havoc Pennington <hp@redhat.com>
825 * bus/system.conf.in: add <includedir>system.d</includedir>
827 * dbus/dbus-userdb.c (_dbus_user_database_lookup): fix bug when
828 username was provided but not uid
830 * bus/config-parser.c (struct BusConfigParser): keep track of
831 whether the parser is toplevel or was included; change some
832 of the error handling if it's included.
834 2003-04-27 Havoc Pennington <hp@pobox.com>
838 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
839 report correct status if we finish processing authentication
840 inside this function.
842 * bus/activation.c (try_send_activation_failure): use
843 bus_transaction_send_error_reply
845 * bus/connection.c (bus_connection_get_groups): return an error
846 explaining the problem
848 * bus/bus.c (bus_context_check_security_policy): implement
849 restriction here that inactive connections can only send the
850 hello message. Also, allow bus driver to send anything to
853 * bus/connection.c (bus_connection_complete): create the
854 BusClientPolicy here instead of on-demand.
855 (bus_connection_get_policy): don't return an error
857 * dbus/dbus-message.c (dbus_message_new_error_reply): allow NULL
858 sender field in message being replied to
860 * bus/bus.c (bus_context_check_security_policy): fix silly typo
861 causing it to return FALSE always
863 * bus/policy.c (bus_client_policy_check_can_send): fix bug where
864 we checked sender rather than destination
866 2003-04-25 Havoc Pennington <hp@redhat.com>
868 test suite is slightly hosed at the moment, will fix soon
870 * bus/connection.c (bus_connections_expire_incomplete): fix to
871 properly disable the timeout when required
872 (bus_connection_set_name): check whether we can remove incomplete
873 connections timeout after we complete each connection.
875 * dbus/dbus-mainloop.c (check_timeout): fix this up a bit,
876 probably still broken.
878 * bus/services.c (bus_registry_acquire_service): implement max
879 number of services owned, and honor allow/deny rules on which
880 services a connection can own.
882 * bus/connection.c (bus_connection_get_policy): report errors here
884 * bus/activation.c: implement limit on number of pending
887 2003-04-25 Havoc Pennington <hp@redhat.com>
889 * dbus/dbus-transport.c (_dbus_transport_get_unix_user): fix bug
890 where we used >= 0 instead of != DBUS_UID_UNSET.
892 2003-04-25 Havoc Pennington <hp@redhat.com>
894 * glib/dbus-gmain.c (remove_watch): fix for a crash when watches
895 were toggled without add/remove, fix from Anders Gustafsson
897 2003-04-24 Havoc Pennington <hp@redhat.com>
899 * test/data/valid-config-files/basic.conf: add <limit> tags to
902 * bus/config-parser.h, bus/config-parser.c, bus/bus.c: Implement
903 <limit> tag in configuration file.
905 2003-04-24 Havoc Pennington <hp@redhat.com>
907 * bus/dispatch.c: somehow missed some name_is
909 * dbus/dbus-timeout.c (_dbus_timeout_set_enabled)
910 (_dbus_timeout_set_interval): new
912 * bus/connection.c (bus_connections_setup_connection): record time
913 when each connection is first set up, and expire them after the
916 2003-04-24 Havoc Pennington <hp@redhat.com>
918 * dbus/dbus-message.c (dbus_message_name_is): rename
919 (dbus_message_service_is): rename
920 (dbus_message_sender_is): rename
921 (dbus_message_get_service): rename
923 2003-04-24 Havoc Pennington <hp@redhat.com>
925 * configure.in: add --enable-checks
927 * dbus/dbus-message.c (dbus_message_new): reverse name/service arguments
929 * dbus/dbus-connection.c (dbus_connection_preallocate_send): fix
931 (_dbus_connection_handler_destroyed_locked): move some private
932 functions into proper docs group
934 * dbus/dbus-internals.h: add _dbus_return_if_fail,
935 _dbus_return_val_if_fail
937 Throughout: use dbus_return_if_fail
939 2003-04-23 James Willcox <jwillcox@gnome.org>
942 * glib/dbus-gmain.c: (add_timeout), (wakeup_main), (create_source),
943 (dbus_connection_setup_with_g_main),
944 (dbus_server_setup_with_g_main):
945 * glib/test-dbus-glib.c: (main):
946 * glib/test-thread-client.c: (main):
947 * glib/test-thread-server.c: (new_connection_callback), (main):
948 * tools/dbus-monitor.c: (main):
950 Added a GMainContext argument to dbus_connection_setup_with_g_main()
951 and dbus_server_setup_with_g_main().
953 2003-04-20 Havoc Pennington <hp@pobox.com>
955 * doc/dbus-specification.sgml: document the restrictions on
956 message and service names
958 2003-04-22 Havoc Pennington <hp@redhat.com>
960 * dbus/dbus-message.c, dbus/dbus-marshal.c: add 64-bit integer
961 support, and do some code cleanups to share more code and
962 speed up array marshal/demarshal.
964 * dbus-1.0.pc.in (Cflags): put libdir include file in cflags
966 * configure.in: generate dbus-arch-deps.h
968 * dbus/dbus-protocol.h (DBUS_TYPE_INT64, DBUS_TYPE_UINT64): add
971 2003-04-22 Havoc Pennington <hp@redhat.com>
973 * test/data/valid-messages/opposite-endian.message: fix test
974 to use proper type for rply field
976 * test/data/invalid-messages: add tests for below validation
978 * dbus/dbus-message.c (decode_header_data): validate field types,
979 and validate that named fields are valid names
980 (decode_name_field): consider messages in the
981 org.freedesktop.Local. namespace to be invalid.
983 * dbus/dbus-string.c (_dbus_string_validate_name): new
985 2003-04-19 Havoc Pennington <hp@pobox.com>
987 * bus/driver.c (bus_driver_handle_hello): check limits and
988 return an error if they are exceeded.
990 * bus/connection.c: maintain separate lists of active and inactive
991 connections, and a count of each. Maintain count of completed
992 connections per user. Implement code to check connection limits.
994 * dbus/dbus-list.c (_dbus_list_unlink): export
996 * bus/bus.c (bus_context_check_security_policy): enforce a maximum
997 number of bytes in the message queue for a connection
999 2003-04-18 Havoc Pennington <hp@pobox.com>
1001 * dbus/dbus-auth.c (record_mechanisms): memleak fixes
1003 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): fix some
1006 * dbus/dbus-keyring.c (add_new_key): fix a memleak, and
1007 on realloc be sure to update the pointer in the keyring
1009 * dbus/dbus-string.c (_dbus_string_zero): compensate for align
1010 offset to avoid writing to unallocated memory
1012 * dbus/dbus-auth.c (process_rejected): return FALSE if we fail to
1013 try the next mechanism, so we properly handle OOM
1015 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): fix double-free
1017 (_dbus_keyring_new): fix OOM bug
1018 (_dbus_keyring_new_homedir): always set error; impose a maximum
1019 number of keys we'll load from the file, mostly to speed up the
1020 test suite and make its OOM checks more useful, but also for
1023 * dbus/dbus-auth.c (process_error_server): reject authentication
1024 if we get an error from the client
1025 (process_cancel): on cancel, send REJECTED, per the spec
1026 (process_error_client): send CANCEL if we get an error from the
1029 2003-04-18 Havoc Pennington <hp@pobox.com>
1031 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix UMR in verbose
1034 * dbus/dbus-auth.c (handle_client_data_cookie_sha1_mech): fix OOM
1037 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): only whine
1038 about DBUS_TEST_HOMEDIR once
1040 * bus/Makefile.am (TESTS_ENVIRONMENT): put DBUS_TEST_HOMEDIR in
1043 * bus/dispatch.c (bus_dispatch_sha1_test): actually load sha1
1044 config file so we test the right thing
1046 Throughout: assorted docs improvements
1048 2003-04-18 Havoc Pennington <hp@pobox.com>
1050 * glib/dbus-gmain.c: adapt to watch changes
1052 * bus/bus.c, bus/activation.c, etc.: adjust to watch changes
1054 * dbus/dbus-server.h: remove dbus_server_handle_watch
1056 * dbus/dbus-connection.h: remove dbus_connection_handle_watch
1058 * dbus/dbus-watch.c (dbus_watch_handle): change DBusWatch to work
1059 like DBusTimeout, so we don't need dbus_connection_handle_watch
1062 2003-04-17 Havoc Pennington <hp@redhat.com>
1064 * dbus/dbus-userdb.c, dbus/dbus-sysdeps.c: redo all the passwd
1065 database usage so it all goes via the DBusUserDatabase cache.
1067 2003-04-17 Havoc Pennington <hp@redhat.com>
1069 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix logic so that if
1070 there was an OOM watch we skipped, we always return TRUE so we
1071 iterate again to have a look at it again. Fixes test suite hang.
1072 Code rearrangement also lets us lose some memset and only iterate
1073 over callbacks once.
1075 * bus/driver.c (bus_driver_handle_message): sense of test for
1078 2003-04-16 Havoc Pennington <hp@pobox.com>
1080 * doc/dbus-specification.sgml: make spec say serials are unsigned
1082 * dbus/dbus-message.h: change message serials to unsigned
1084 * dbus/dbus-connection.c: adapt to message serials being unsigned
1086 2003-04-15 Havoc Pennington <hp@pobox.com>
1088 * bus/bus.c: create and keep around a shared DBusUserDatabase
1091 * bus/connection.c (bus_connection_get_groups): don't cache
1092 groups for user in the connection object, since user database
1093 object now does that.
1095 2003-04-16 Havoc Pennington <hp@redhat.com>
1097 * dbus/dbus-message.c (_dbus_message_add_size_counter): keep a
1098 list of size counters
1099 (_dbus_message_loader_putback_message_link): put back a popped link
1101 * dbus/dbus-connection.c
1102 (dbus_connection_set_max_live_messages_size): rename
1104 (dbus_connection_get_outgoing_size): get size of outgoing
1106 (_dbus_connection_set_connection_counter): remove this cruft
1108 2003-04-14 Havoc Pennington <hp@redhat.com>
1110 * dbus/dbus-userdb.c: user database abstraction, mostly to get
1111 caching, but at some point we might want to be able to use a
1114 * bus/dispatch.c (bus_dispatch_sha1_test): add a test that uses
1115 SHA1 conf file to test the sha1 auth mechanism, since the regular
1116 test always uses EXTERNAL when available.
1119 test/data/valid-config-files/debug-allow-all-sha1.conf.in:
1120 add conf file that requires use of sha1 auth
1122 2003-04-13 Havoc Pennington <hp@pobox.com>
1124 * tools/dbus-send.c, tools/dbus-monitor.c: two utility programs
1125 from Philip Blundell to send messages and monitor them.
1127 2003-04-13 Havoc Pennington <hp@pobox.com>
1129 * dbus/dbus-mainloop.c: fix some reentrancy issues by refcounting
1132 * test/data/valid-config-files/debug-allow-all.conf.in: allow all
1135 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
1136 fix to only recover unused bytes if we're already authenticated
1137 (_dbus_transport_get_is_authenticated): fix to still mark us
1138 authenticated if there are unused bytes.
1140 * bus/dispatch.c: implement security policy checking
1142 * bus/connection.c (bus_transaction_send_from_driver): new
1144 * bus/bus.c (bus_context_check_security_policy): new
1146 * bus/dispatch.c (send_service_nonexistent_error): delete this,
1147 now we just set the DBusError and it gets converted to an error
1150 * bus/connection.c (allow_user_function): enable code using actual
1151 data from the config file
1153 * bus/policy.c (list_allows_user): handle wildcard rules for
1154 user/group connection perms
1156 2003-04-13 Havoc Pennington <hp@pobox.com>
1158 * bus/config-parser.c: Load up the BusPolicy and BusPolicyRules
1160 * dbus/dbus-sysdeps.c (_dbus_get_user_id): new function
1162 * bus/policy.c (bus_policy_append_mandatory_rule)
1163 (bus_policy_append_default_rule, bus_policy_append_user_rule)
1164 (bus_policy_append_group_rule): new functions
1166 2003-04-12 Havoc Pennington <hp@pobox.com>
1168 * bus/config-parser.c (bus_config_parser_new): fix a memleak
1170 * dbus/dbus-sysdeps.c: change DBusCredentials to use longs for
1171 the pid/gid/uid, just for paranoia.
1173 * test/break-loader.c (randomly_do_n_things): find a byte
1174 containing a type code, and randomly change it to a different
1177 2003-04-12 Havoc Pennington <hp@pobox.com>
1179 * bus/policy.h: change BusPolicy to be the thing from the config
1180 file, and rename old BusPolicy to BusClientPolicy
1182 * bus/bus.c, bus/connection.c, bus/config-parser.c: change to
1183 match change in how policy works
1185 * dbus/dbus-internals.h: mark assert_not_reached as
1186 __attribute((noreturn))__
1188 2003-04-11 Havoc Pennington <hp@redhat.com>
1190 * doc/dbus-specification.sgml: fix a spot with the wrong name for
1191 the broadcast service. Use boolean return for ServiceExists.
1193 2003-04-11 Havoc Pennington <hp@redhat.com>
1195 * configure.in: add another directory to look for qt in.
1197 2003-04-11 Havoc Pennington <hp@redhat.com>
1199 * AUTHORS: add Colin Walters
1201 2003-04-11 Havoc Pennington <hp@redhat.com>
1207 2003-04-11 Havoc Pennington <hp@redhat.com>
1209 * bus/messagebus.in: remove pid file when stopping the
1210 message bus, since the bus won't have privileges to remove it
1213 2003-04-11 Havoc Pennington <hp@redhat.com>
1215 * bus/bus.c (bus_context_new): move credentials change after
1218 2003-04-11 Havoc Pennington <hp@pobox.com>
1220 * test/decode-gcov.c: add "below average functions" to the
1221 coverage report, and change how some of the code works.
1223 * bus/test-main.c: bracket some stuff in DBUS_BUILD_TESTS so it's
1224 not in the coverage stats.
1226 * test/test-service.c (main): use _dbus_verbose not fprintf in a
1227 couple places so running the test suite doesn't result in megaspam.
1229 2003-04-11 Havoc Pennington <hp@pobox.com>
1231 * bus/dispatch.c (check_existent_service_activation): accept a no
1232 memory error in a place we didn't before
1234 * bus/test.c (bus_test_run_everything): remove hacky "do it twice
1235 in case the first one failed," since the test suite is less
1238 2003-04-10 Havoc Pennington <hp@pobox.com>
1240 * bus/dispatch.c (check_segfault_service_activation): add test
1241 for launching an executable that just crashes.
1243 * test/test-segfault.c (main): try setting coredumpsize to 0 so we
1244 don't leave a million cores. We'll see how portable this is.
1246 2003-04-10 Havoc Pennington <hp@pobox.com>
1248 * dbus/dbus-spawn.c (_dbus_spawn_async_with_babysitter): move all
1249 the possible parent failures before we fork, so that we don't
1250 fail to create a babysitter after creating the child.
1252 * bus/activation.c (bus_activation_activate_service): kill child
1253 if we don't successfully complete the activation.
1255 2003-04-10 Havoc Pennington <hp@redhat.com>
1257 * dbus/dbus-connection.c (dbus_connection_flush): don't spin on
1258 the connection if it's disconnected
1260 * bus/activation.c (bus_activation_service_created): use new
1261 transaction features to roll back removal of pending activation if
1262 we don't successfully create the service after all. Don't remove
1263 pending activation if the function fails.
1265 * dbus/dbus-list.c (_dbus_list_insert_before_link)
1266 (_dbus_list_insert_after_link): new code to facilitate
1269 * dbus/dbus-hash.c (_dbus_hash_table_insert_string_preallocated):
1270 new functionality, so we can preallocate the ability to insert
1273 * bus/connection.c (bus_transaction_add_cancel_hook): new function
1274 allowing us to put custom hooks in a transaction to be used for
1275 cancelling said transaction
1277 * doc/dbus-specification.sgml: add some discussion of secondary
1278 service owners, and disallow zero-length service names
1280 * bus/services.c (bus_registry_acquire_service): new function,
1281 splits out part of bus_driver_handle_acquire_service() and fixes
1282 a bug where we didn't remove the service doing the acquiring
1283 from the secondary queue if we failed to remove the current owner
1284 from the front of the queue.
1286 2003-04-10 Alexander Larsson <alexl@redhat.com>
1288 * doc/dbus-specification.sgml:
1289 s/org.freedesktop.Broadcast/org.freedesktop.DBus.Broadcast/
1291 2003-04-10 Alexander Larsson <alexl@redhat.com>
1296 Added files to cvsignore
1298 * dbus/dbus-message.h:
1299 * dbus/dbus-message.c: (dbus_message_iter_get_named):
1300 Make get_named() take two out argument and return a boolean.
1301 (dbus_message_iter_get_args_valist):
1302 Update usage of get_named().
1303 (dbus_message_iter_append_byte):
1305 (dbus_message_iter_append_named)
1307 (message_iter_test), (check_message_handling_type), (_dbus_message_test):
1310 2003-04-10 Alexander Larsson <alexl@redhat.com>
1312 * dbus/dbus-marshal.[ch]:
1313 Add array_type_pos argument to _dbus_marshal_validate_arg.
1314 Let you pass a NULL end_pos to _dbus_marshal_validate_type.
1316 * dbus/dbus-message.[ch]:
1317 Multi-dimensional arrays have full type specification in the
1318 outermost array. Iter code re-arranged to handle this.
1319 Added some more iter tests.
1321 * doc/dbus-specification.sgml:
1324 Update new array encoding description.
1325 Correct DBUS_SERVICE_FLAGS_REPLACE_EXISTING description.
1327 * test/data/invalid-messages/array-with-mixed-types.message:
1328 * test/data/valid-messages/array-of-array-of-uint32.message:
1329 Change to the new array format.
1331 * test/data/invalid-messages/too-short-dict.message:
1334 * test/data/valid-messages/recursive-types.message:
1335 Fix up and extend test.
1337 2003-04-10 Havoc Pennington <hp@pobox.com>
1339 * bus/dispatch.c: lots of fixes
1341 * dbus/dbus-mainloop.c (_dbus_loop_dispatch): export
1342 (_dbus_loop_iterate): remove old "quit if no callbacks" code,
1343 that was crack, broke the test service.
1345 * dbus/dbus-transport.c (_dbus_transport_open): fix error
1346 handling to avoid piling up errors if we get a failure on the
1349 * dbus/dbus-internals.c (_dbus_real_assert_not_reached): include
1350 pid in assertion failures.
1352 * dbus/dbus-mainloop.c (_dbus_loop_iterate): use static arrays up
1353 to some fixed size of file descriptor array. Don't return TRUE
1354 anytime a timeout exists, that led to lots of busy loop silliness
1357 2003-04-09 Havoc Pennington <hp@redhat.com>
1359 * dbus/dbus-mainloop.c (check_timeout): fix timeouts, I thought
1360 I'd checked this in earlier but hadn't.
1362 2003-04-09 Havoc Pennington <hp@redhat.com>
1364 * bus/dispatch.c (bus_dispatch_test): get a bit further through
1365 the activation test (man this is getting old!)
1367 2003-04-09 Havoc Pennington <hp@redhat.com>
1369 * test/test-utils.c: use dispatch status function to fix this up
1371 * bus/connection.c (connection_watch_callback): don't dispatch
1373 (connection_timeout_callback): don't dispatch from here
1374 (bus_connections_setup_connection): set the dispatch status function
1375 (bus_connection_disconnected): unset it
1377 * dbus/dbus-mainloop.c (_dbus_loop_queue_dispatch): new function
1378 used to add a connection to be dispatched
1379 (_dbus_loop_iterate): do the dispatching at the end of each
1382 * dbus/dbus-connection.c
1383 (dbus_connection_set_dispatch_status_function): new function
1384 allowing us to fix up main loop usage
1385 (_dbus_connection_last_unref): free all the various function
1387 (dbus_connection_dispatch): call the DispatchStatusFunction
1388 whenever this function returns
1389 (dbus_connection_handle_watch): call DispatchStatusFunction
1390 (dbus_connection_send_with_reply_and_block): call DispatchStatusFunction
1391 (reply_handler_timeout): call DispatchStatusFunction
1392 (dbus_connection_flush): call DispatchStatusFunction
1394 2003-04-09 Havoc Pennington <hp@redhat.com>
1396 * dbus/dbus-bus.c (dbus_bus_register): fix up error handling and
1399 * bus/dispatch.c (check_service_activated): fix bug in test
1401 * dbus/dbus-mainloop.c (check_timeout): fix this up
1403 * dbus/dbus-internals.c (_dbus_verbose_real): include PID in
1404 verbose output so we can sort out output from different processes,
1405 e.g. in the activation case.
1407 2003-04-08 Colin Walters <walters@gnu.org>
1409 * bus/bus.c (struct BusContext) [pidfile]: New member, to store
1411 (bus_context_new): Set it.
1412 (bus_context_unref): Use it to delete the pid file.
1414 2003-04-08 Havoc Pennington <hp@redhat.com>
1416 * test/data/invalid-messages/array-with-mixed-types.message:
1417 regression test that fails for the moment
1419 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): reorder
1420 tests for convenience
1422 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): don't allow
1423 array of nil, it broke things.
1425 * test/data/invalid-messages/array-of-nil.message: regression test
1427 * test/data/valid-messages/array-of-array-of-uint32.message:
1428 happened to write this so added it to suite
1430 2003-04-08 Havoc Pennington <hp@redhat.com>
1432 * bus/driver.c (bus_driver_handle_acquire_service): init
1433 retval/reply before checking name
1435 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add a
1436 recursion depth argument
1438 * dbus/dbus-message.h (struct DBusMessageIter): put some padding
1439 in the public struct for future extension
1441 * dbus/dbus-message-builder.c (_dbus_message_data_load): fix
1444 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix a verbose
1447 * doc/dbus-specification.sgml: fix typo
1449 2003-04-08 Alexander Larsson <alexl@redhat.com>
1451 Implemented recursive types, named types and new-style iters
1454 * glib/test-thread-client.c: (thread_func):
1455 * glib/test-thread-server.c: (handle_test_message):
1456 * test/test-service.c: (handle_echo):
1465 * dbus/dbus-internals.c: (_dbus_type_to_string):
1466 Update for new types.
1468 * dbus/dbus-marshal.[ch]:
1469 Implement recursive types and the new marshalling format.
1470 Remove hardcoded dict marshalling.
1471 Marshal named types.
1473 * dbus/dbus-message-builder.c:
1475 Remove references to old types
1477 * dbus/dbus-message.[ch]:
1478 New non-refcounted iter API that supports recursive iters.
1479 Use iters for appending, including support for recursive
1481 Add byte and named type support.
1482 Update everything to new marshalling formats.
1483 Add tests for new API.
1485 * dbus/dbus-protocol.h:
1486 Remove old array types.
1487 Add types: BYTE, ARRAY, DICT, NAMED
1489 * dbus/dbus-string.c:
1490 * dbus/dbus-sysdeps.c:
1491 Make parse_double locale safe.
1493 * dbus/dbus-test-main.c:
1499 * doc/dbus-specification.sgml:
1502 * test/data/incomplete-messages/missing-body.message:
1503 * test/data/invalid-messages/bad-boolean.message:
1504 * test/data/invalid-messages/bad-boolean-array.message:
1505 * test/data/invalid-messages/boolean-array-length-too-long.message-raw:
1506 * test/data/invalid-messages/boolean-has-no-value.message-raw:
1507 * test/data/invalid-messages/too-short-dict.message:
1508 * test/data/valid-messages/dict-simple.message:
1509 * test/data/valid-messages/dict.message:
1510 * test/data/valid-messages/emptiness.message:
1511 * test/data/valid-messages/lots-of-arguments.message:
1512 * test/data/valid-messages/no-padding.message:
1513 * test/data/valid-messages/recursive-types.message:
1514 Add missing NAME fields
1515 Fix up dicts & arrays
1517 * test/data/invalid-messages/dict-with-nil-value.message:
1518 Removed, this is not invalid anymore.
1520 * test/data/valid-messages/recursive-types.message:
1521 Add new test for deeply recursive types.
1523 2003-04-07 Havoc Pennington <hp@pobox.com>
1525 * bus/driver.c (bus_driver_handle_acquire_service): return an
1526 error if you try to acquire a service that starts with ':'
1528 2003-04-07 Havoc Pennington <hp@redhat.com>
1530 * doc/dbus-specification.sgml: require that base service names
1531 start with ':' and that the base service is created/deleted
1532 as first and last things a connection does on the bus
1534 * bus/dispatch.c (check_existent_service_activation): lots more
1535 work on the activation test; it doesn't fully pass yet...
1537 * test/test-service.c (main): fix so we don't memleak the
1538 connection to the message bus
1539 (filter_func): accept a message asking us to exit
1541 2003-04-06 Havoc Pennington <hp@pobox.com>
1543 * qt/Makefile.am (dbusinclude_HEADERS): install dbus-qt.h,
1546 * configure.in: fixes to Qt detection from Colin Walters
1548 * doc/Makefile.am: Only remove generated docbook dirs if they
1549 exist, from Colin Walters
1551 * dbus/dbus-bus.c: change how we set well-known connections to
1552 NULL, so that it works if a single connection is stored in
1553 two well-known array slots.
1555 * test/Makefile.am: remove a lot of stuff that isn't immediately
1556 useful, it's in CVS history if we want it.
1558 * test/test-service.c: use dbus-mainloop instead of that
1561 2003-04-06 Havoc Pennington <hp@pobox.com>
1563 * dbus/Makefile.am: split lists of sources into stuff that goes in
1564 the library, util functions that go in the lib and are also used
1565 elsewhere, and util functions that are used in tests/daemon but
1566 don't go in the lib.
1568 * dbus/dbus-mainloop.h, dbus/dbus-mainloop.c: move bus/loop.[hc]
1569 here so it can be used in test binaries also
1571 2003-04-06 Havoc Pennington <hp@pobox.com>
1573 * dbus/dbus-sysdeps.c (_dbus_become_daemon): write the pidfile
1574 here in the parent process, so we can return an error if it
1575 fails. Also, move some of the code into the child so the parent
1576 is less hosed if we fail midway through.
1578 * bus/bus.c (bus_context_new): move pidfile detection further up
1579 in the function, before we start overwriting sockets and such.
1581 * bus/messagebus.in: adjust this a bit, not sure if it will work.
1583 * configure.in: add --with-system-pid-file and --with-system-socket
1585 2003-04-06 Colin Walters <walters@verbum.org>
1587 * configure.in (DBUS_SYSTEM_PID_FILE): New variable.
1589 * bus/system.conf.in: Declare a pidfile.
1591 * bus/bus.c (bus_context_new): Test for an existing pid file, and
1592 create one (if appropriate).
1594 * bus/config-parser.c (enum ElementType) [ELEMENT_PIDFILE]: New.
1595 (struct BusConfigParser) [pidfile]: New.
1596 (element_type_to_name, merge_included, start_busconfig_child)
1597 (bus_config_parser_end_element, bus_config_parser_content): Handle it.
1598 (bus_config_parser_unref): Free it.
1599 (bus_config_parser_get_pidfile): New function.
1601 * bus/config-parser.h (_dbus_write_pid_file): Prototype.
1603 * dbus/dbus-errors.h (DBUS_ERROR_PIDFILE_EXISTS): New error.
1605 * dbus/dbus-sysdeps.c (_dbus_write_pid_file): New function.
1607 * dbus/dbus-sysdeps.h: Prototype it.
1609 2003-04-06 Havoc Pennington <hp@pobox.com>
1611 * bus/bus.c (bus_context_new): print the address in here, rather
1612 than in main(), because we need to do it before forking the daemon
1614 * bus/dispatch.c (send_service_nonexistent_error): set the sender
1615 on the service nonexistent error
1617 * bus/driver.c (bus_driver_handle_acquire_service): set the
1618 sender on the AcquireService reply
1620 * test/data/valid-config-files/debug-allow-all.conf.in: Make test
1621 server also listen on a UNIX socket so services can connect to it.
1623 2003-04-06 Havoc Pennington <hp@pobox.com>
1625 * dbus/dbus-threads.c: Redo how the fake debug mutexes are done
1626 so it detects deadlocks and also we actually init threads when
1629 2003-04-06 Havoc Pennington <hp@pobox.com>
1631 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
1632 save the domain socket name, and unlink it when we disconnect the
1633 server. Means that at least when we exit normally, we won't leave
1634 a bunch of junk in /tmp
1636 * dbus/dbus-transport-unix.c
1637 (_dbus_transport_new_for_domain_socket): code cleanup (nicer
1638 memory management). (I was making a real change here but then
1641 2003-04-06 Havoc Pennington <hp@pobox.com>
1643 * bus/bus.c (bus_context_new): fix wrong handling of
1644 server_data_slot_unref() in the error case.
1646 * dbus/dbus-internals.h (_dbus_assert): change so it passes
1647 "(condition) != 0" to _dbus_real_assert so that
1648 "_dbus_assert (pointer)" doesn't cause a warning
1650 * bus/main.c (main): accept --print-address option to print out
1651 the message bus address
1653 * dbus/dbus-sysdeps.c (_dbus_generate_random_ascii): export this
1655 * dbus/dbus-transport.c (_dbus_transport_open): special error for
1656 "tmpdir" option to unix: address on client side
1658 * dbus/dbus-server.c (dbus_server_listen): handle "tmpdir" option
1661 * configure.in (TEST_SOCKET_DIR): locate a temporary directory
1662 we can use to create sockets in the test suite.
1664 * bus/main.c (signal_handler): on SIGTERM, exit the daemon
1665 cleanly. To be used for testing.
1667 * dbus/dbus-spawn.c (babysit): use _dbus_set_signal_handler()
1669 * dbus/dbus-sysdeps.c (_dbus_set_signal_handler): new
1671 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
1672 handle trying to call this when there's no servers active
1674 2003-04-05 Havoc Pennington <hp@pobox.com>
1680 2003-04-05 Havoc Pennington <hp@pobox.com>
1682 * bus/bus.c (setup_server): fix this so dbus-daemon-1 doesn't
1683 crash on startup. Need to get "try starting the daemon"
1684 in the test suite I guess. ;-)
1686 * dbus/dbus-server.h, dbus/dbus-server.c: remove the stuff that
1687 tracked the number of open connections; it's better done in
1688 application-specific code as you want it to span all servers etc.
1690 2003-04-05 Havoc Pennington <hp@pobox.com>
1692 * bus/Makefile.am (install-data-hook): add missing DESTDIR,
1693 patch from Colin Walters
1695 2003-04-05 Havoc Pennington <hp@pobox.com>
1697 * doc/config-file.txt (Elements): fix docs of <auth> to reflect
1698 reality; in fact multiple mechanisms are allowed.
1700 * dbus/dbus-internals.c (_dbus_real_assert)
1701 (_dbus_real_assert_not_reached): move guts of _dbus_assert() and
1702 _dbus_assert_not_reached() into functions, so that they don't show
1703 up in basic block counts for test coverage, and don't use up as
1704 much disk space. Does mean slower execution speed though, so
1705 assumes --disable-asserts is the normal production case.
1707 2003-04-05 Havoc Pennington <hp@pobox.com>
1709 * test/Makefile.am (dist-hook): also dist *.in files
1715 2003-04-05 Havoc Pennington <hp@pobox.com>
1717 * dbus/dbus-string.c: docs warning
1719 * dbus/dbus-spawn.c: missing docs
1721 * dbus/dbus-memory.c (struct ShutdownClosure): missing docs
1723 2003-04-05 Havoc Pennington <hp@pobox.com>
1725 * bus/loop.c (bus_loop_iterate): fix the timeout code, using
1728 * dbus/dbus-spawn.c (_dbus_babysitter_unref): set sitter_pid
1729 to -1 once we've reaped the babysitter
1730 (_dbus_babysitter_handle_watch): do as much work as we can, not
1733 * bus/activation.c: add code using DBusBabysitter so that we
1734 handle it when a service fails to start up properly.
1735 (bus_activation_service_created): don't remove the activation
1736 entries as we go, just let them get removed when we free the pending
1737 activation. Unref reply messages after sending them.
1739 2003-04-05 Havoc Pennington <hp@pobox.com>
1741 * test/decode-gcov.c (main): print per-directory stats in the report
1743 * Makefile.am (coverage-report.txt): don't include test/* in gcov stats
1745 2003-04-05 Havoc Pennington <hp@pobox.com>
1747 * Makefile.am (coverage-report.txt): add target "coverage-report.txt"
1749 * test/decode-gcov.c: hack up a little program to suck data
1750 out of gcov files. Yes this is sort of silly.
1752 * configure.in: define something in config.h and do an
1753 AM_CONDITIONAL when gcov is enabled
1755 2003-04-04 Havoc Pennington <hp@redhat.com>
1757 * dbus/dbus-spawn.c, dbus/dbus-spawn.h: Change dbus_spawn to
1758 return a "babysitter" object that is used to monitor the status of
1759 the spawned process and reap it when required.
1761 * test/test-segfault.c, test/test-exit.c,
1762 test/test-sleep-forever.c: binaries that do various lame things,
1763 used in the test suite.
1765 * dbus/dbus-sysdeps.c: kill _dbus_errno_to_string()
1767 2003-04-03 Havoc Pennington <hp@pobox.com>
1769 * dbus/dbus-spawn.c: Move dbus-spawn into a separate file
1770 in preparation for modifying it, dbus-sysdeps is getting
1773 2003-04-03 Havoc Pennington <hp@redhat.com>
1775 * bus/loop.h, bus/loop.c: make the mainloop an object so we can
1778 * bus/*.[hc]: adapt to mainloop change
1780 2003-04-03 Havoc Pennington <hp@redhat.com>
1782 * bus/activation.c (load_directory): fix up memleaks
1783 (bus_activation_entry_free): free the entry
1785 * dbus/dbus-bus.c (dbus_bus_acquire_service): return an error if
1786 we get one from the message bus; fix memleaks.
1788 * dbus/dbus-message.c (dbus_set_error_from_message): new function
1790 2003-04-03 Havoc Pennington <hp@pobox.com>
1792 * bus/config-parser.c (bus_config_parser_unref): free
1793 list of mechanisms, bug discovered by test suite enhancements
1794 (putting system.conf and session.conf into suite)
1796 * test/Makefile.am, test/test-service.c: add placeholder for a
1797 test service that we'll activate as part of test suite. Doesn't
1800 * dbus/dbus-sysdeps.c (_dbus_setenv): support unsetenv by
1801 setting NULL value, and use system malloc not dbus_malloc()
1802 when we have unavoidable memleakage.
1804 * dbus/dbus-bus.c (dbus_bus_get): fix bug where bus type of 0
1805 didn't work, and support DBUS_BUS_ACTIVATION.
1807 * bus/activation.c (child_setup): pass our well-known bus type to
1810 * bus/config-parser.c: support <type> to specify well-known type
1812 * doc/dbus-specification.sgml: document the env variables to
1813 locate well-known buses and find service activator
1815 2003-04-02 Havoc Pennington <hp@redhat.com>
1817 * test/Makefile.am (all-local): add a rule to copy tests to
1818 builddir, so we can have generated tests. Use this to remove the
1819 silly hack for testing system.conf and session.conf. Will use this
1820 shortly to generate .service files pointing to test binaries.
1822 2003-04-02 Havoc Pennington <hp@redhat.com>
1824 * dbus/dbus-string.c (set_length): fix a bug - we allocated max of
1825 current alloc and needed new length, not max of the doubled
1826 allocation and needed new length. Also, when building tests,
1827 don't do the double-allocation stuff, just realloc every time.
1829 2003-04-02 Havoc Pennington <hp@redhat.com>
1831 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): include filenames
1833 (_dbus_string_get_dirname): new
1834 (_dbus_sysdeps_test): new
1835 (_dbus_directory_open): include dirnames in error messages
1837 * bus/config-parser.c: interpret <include> and <includedir> and
1838 <servicedir> relative to config file location if the given
1839 filename is not absolute.
1841 * dbus/dbus-string.c (_dbus_string_find_byte_backward): new
1843 2003-04-02 Havoc Pennington <hp@redhat.com>
1845 * bus/connection.c (bus_transaction_send_error_reply): set sender
1846 service for the error, and unref the reply on success
1848 * bus/activation.c: convert to use BusTransaction so OOM can be
1850 (bus_activation_service_created): set sender of the message
1852 2003-04-01 Havoc Pennington <hp@redhat.com>
1854 * bus/config-parser.c, bus/bus.c: implement <servicedir> and
1855 <includedir> (at least mostly)
1857 * dbus/dbus-sysdeps.c (_dbus_change_identity): set the group ID
1858 first, then the user ID
1860 2003-04-01 Havoc Pennington <hp@pobox.com>
1862 * dbus/dbus-server.c (dbus_server_set_auth_mechanisms): new
1865 * dbus/dbus-auth.c (_dbus_auth_set_mechanisms): new
1867 * dbus/dbus-internals.c (_dbus_dup_string_array): new function
1869 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): chmod the
1870 socket 0777, and unlink any existing socket.
1872 * bus/bus.c (bus_context_new): change our UID/GID and fork if
1873 the configuration file so specifies; set up auth mechanism
1876 * bus/config-parser.c (bus_config_parser_content): add support
1877 for <fork> option and fill in code for <auth>
1879 * bus/system.conf.in: add <fork/> to default configuration,
1880 and limit auth mechanisms to EXTERNAL
1882 * doc/config-file.txt (Elements): add <fork>
1884 * dbus/dbus-sysdeps.c (_dbus_become_daemon): new function
1885 (_dbus_change_identity): new function
1887 2003-03-31 Havoc Pennington <hp@redhat.com>
1889 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket)
1890 (_dbus_listen_unix_socket): fix off-by-one error in null
1891 termination spotted by Nalin
1893 2003-03-31 Havoc Pennington <hp@redhat.com>
1895 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): allow setting
1896 DBUS_TEST_HOMEDIR when tests are enabled, so we can test without
1897 having a real home directory available.
1899 2003-03-31 Havoc Pennington <hp@redhat.com>
1901 * bus/Makefile.am (install-data-hook): create /var/run/dbus
1903 * bus/messagebus.in: add init script for Red Hat /etc/init.d
1905 * configure.in: add support for specifying a style of init script
1908 2003-03-31 Havoc Pennington <hp@redhat.com>
1910 Fix some annoying DBusString API and fix all affected code.
1912 * dbus/dbus-string.c (_dbus_string_init): get rid of annoying
1914 (_dbus_string_get_data): change to return string instead of using
1916 (_dbus_string_get_const_data): ditto
1917 (_dbus_string_get_data_len): ditto
1918 (_dbus_string_get_const_data_len): ditto
1920 2003-03-31 Havoc Pennington <hp@redhat.com>
1922 * bus/main.c (main): fix up the command line arguments to be nicer
1924 2003-03-31 Havoc Pennington <hp@redhat.com>
1926 * dbus/Makefile.am (INCLUDES): use EXPANDED_LOCALSTATEDIR to
1927 define DBUS_SYSTEM_BUS_PATH as we want to compile in the same
1928 final location that lands in the config file
1930 * bus/config-loader-expat.c (bus_config_load): fix type of
1933 * doc/TODO: remove TODO item for dbus_bus_get()
1935 * dbus/dbus-bus.c (bus_data_free): add missing lock/unlock
1937 2003-03-31 Havoc Pennington <hp@pobox.com>
1939 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_domain_socket)
1940 (_dbus_transport_new_for_tcp_socket): these didn't need the "server"
1941 argument since they are always client side
1943 * dbus/dbus-server.c (dbus_server_get_address): new function
1945 * bus/main.c (main): take the configuration file as an argument.
1947 * test/data/valid-config-files/debug-allow-all.conf: new file to
1948 use with dispatch.c tests for example
1950 * bus/test-main.c (main): require test data dir
1952 * bus/bus.c (bus_context_new): change this to take a
1953 configuration file name as argument
1955 * doc/config-file.txt (Elements): add <servicedir>
1957 * bus/system.conf, bus/session.conf: new files
1959 * dbus/dbus-bus.c (dbus_bus_get): look for system bus on
1960 well-known socket if none set
1962 * configure.in: create system.conf and session.conf
1964 2003-03-30 Havoc Pennington <hp@pobox.com>
1966 * bus/config-parser.c: hacking
1968 * dbus/dbus-memory.c: don't use DBusList for the list of stuff
1969 to shut down, since it could cause weirdness with the DBusList
1972 * dbus/dbus-list.c (_dbus_list_test): add tests for the
1973 link-oriented stack routines
1974 (alloc_link): free the mempool if the first alloc from it fails
1976 * dbus/dbus-mempool.c (struct DBusMemBlock): fix alignment issue
1978 * dbus/dbus-string.c (UNICODE_VALID): sync new version of this
1980 (_dbus_string_skip_white): new
1982 * doc/config-file.txt (Elements): add <includedir>
1984 2003-03-28 Havoc Pennington <hp@pobox.com>
1986 * dbus/dbus-string.c (_dbus_string_copy_data_len)
1987 (_dbus_string_copy_data): new functions
1989 2003-03-28 Anders Carlsson <andersca@codefactory.se>
1991 * dbus/dbus-bus.c: (bus_data_free), (dbus_bus_get):
1995 * dbus/dbus-memory.c:
1998 2003-03-28 Havoc Pennington <hp@pobox.com>
2000 * bus/test.c (bus_test_flush_bus): remove the sleep from here,
2001 I think it may have just been superstition. Not sure.
2003 * dbus/dbus-string.c (_dbus_string_base64_decode): catch some OOM
2004 failures that were not being handled.
2006 * dbus/dbus-auth.c (process_auth): fix a memleak in OOM handling
2008 * dbus/dbus-memory.c: add ability to set number of mallocs in a
2009 row that will fail on out-of-memory.
2011 * dbus/dbus-internals.c (_dbus_test_oom_handling): convenience
2012 function for testing out-of-memory handling.
2014 * bus/config-loader-expat.c (memsuite): don't wrap the dbus
2015 allocation functions, they do map exactly to the expat ones.
2017 2003-03-27 Havoc Pennington <hp@redhat.com>
2019 * bus/config-loader-libxml.c (bus_config_load): add another error
2022 2003-03-26 Anders Carlsson <andersca@codefactory.se>
2025 Add note about automatic service activation.
2027 * doc/dbus-specification.sgml:
2028 Rename the specification and clarify a few things.
2030 2003-03-26 Anders Carlsson <andersca@codefactory.se>
2033 * dbus/dbus-address.c:
2035 * dbus/dbus-marshal.c:
2036 * dbus/dbus-server-debug-pipe.c:
2037 * dbus/dbus-transport-unix.c:
2038 Fix documentation warnings.
2040 2003-03-26 Havoc Pennington <hp@pobox.com>
2042 * bus/test-main.c, dbus/dbus-test.c (main): check memleaks
2043 after every test so it's quick and easy to see which leaked, and
2044 so we test multiple dbus_shutdown() calls
2046 * configure.in: change configure.in XML stuff to also support
2049 * config-loader-libxml.c: some hacking
2051 * config-loader-expat.c: some hacking
2053 * config-parser.c: some hacking, plus tests
2055 2003-03-25 Havoc Pennington <hp@redhat.com>
2057 * throughout - add more _DBUS_ASSERT_ERROR_IS_CLEAR
2059 * configure.in: add --with-xml option to specify XML library,
2060 right now only libxml is supported.
2062 * bus/config-loader-libxml.c, config-parser.c: sync some minor
2063 nonworking code between home and work, still just stubs
2065 2003-03-24 Havoc Pennington <hp@redhat.com>
2067 * dbus/dbus-sysdeps.c (_dbus_set_fd_nonblocking): move to this
2070 * dbus/dbus-errors.c (dbus_set_error, dbus_set_error_const): allow
2071 NULL argument for "message" if the error is a well-known one,
2072 fill in a generic message in this case.
2074 * dbus/dbus-errors.h (DBusResultCode): Kill DBusResultCode in
2077 * bus/test.c (bus_test_flush_bus): add
2079 * bus/policy.c (bus_policy_test): test code stub
2081 2003-03-24 Havoc Pennington <hp@pobox.com>
2083 * bus/connection.c (bus_connections_setup_connection): set up
2084 the "can this user connect" function, but it always returns
2085 TRUE until we have a config file parser so we can have a config
2086 file that allows connections.
2088 2003-03-23 Havoc Pennington <hp@pobox.com>
2090 * dbus/dbus-threads.c (dbus_mutex_new, dbus_condvar_new): with
2091 DBUS_BUILD_TESTS, actually alloc/free a block of memory for
2092 the mutex, so we can check for proper memory management
2095 * dbus/dbus-dataslot.c: remove the mutex from
2096 DBusDataSlotAllocator and lock it manually when using it,
2097 to simplify fitting it into the global slots framework.
2099 * dbus/dbus-threads.c (init_static_locks): rework how we're
2100 handling global locks so they are easily shut down.
2102 * bus/policy.c (bus_policy_append_rule): fix
2104 * bus/test-main.c (main): check for memleaks
2106 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): make
2107 test suite check for memleaks
2109 * dbus/dbus-memory.c: add support in test mode for tracking
2110 number of outstanding blocks
2112 2003-03-23 Havoc Pennington <hp@pobox.com>
2114 * bus/policy.c, bus/bus.c, bus/connection.c: implement allow/deny
2117 * dbus/dbus-hash.h: add ULONG hash keys
2119 * dbus/dbus-sysdeps.c (_dbus_get_groups): new
2120 (_dbus_get_group_id): new function
2122 2003-03-20 Havoc Pennington <hp@redhat.com>
2124 * dbus/dbus-connection.c (dbus_connection_set_unix_user_function):
2126 (dbus_connection_get_unix_user): new function
2128 2003-03-20 Havoc Pennington <hp@pobox.com>
2130 * bus/connection.c (bus_connection_send_oom_error): assert that
2131 message has a sender
2132 (connection_execute_transaction): ditto
2133 (bus_connection_preallocate_oom_error): fix to set the sender, and
2134 set recipient to the destination service, not the bus driver
2136 * bus/policy.c: hacking
2138 * dbus/dbus-message.c (dbus_message_service_is): new function
2139 (dbus_message_sender_is): new
2141 2003-03-19 Havoc Pennington <hp@redhat.com>
2143 * bus/policy.c: start sketching code for policy restrictions on
2144 what connections can do.
2146 2003-03-18 Havoc Pennington <hp@redhat.com>
2148 * doc/TODO: some notes on high-level todo items. Little nitpick
2149 stuff is all in @todo, so no need to add it here.
2151 * doc/config-file.txt: some notes on how config file might look
2153 2003-03-18 Anders Carlsson <andersca@codefactory.se>
2159 2003-03-17 Havoc Pennington <hp@redhat.com>
2161 * dbus/dbus-internals.h: add gcc attributes so that
2162 our printf-style functions warn on bad arguments to
2165 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): fix printf
2168 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
2171 2003-03-17 Havoc Pennington <hp@redhat.com>
2173 * bus/test-main.c (main): make it print something as it runs
2174 so make check doesn't look stuck
2176 * doc/negotiation.txt, doc/dbus-sasl-profile.txt: remove
2177 from CVS, now obsolete
2179 2003-03-17 Anders Carlsson <andersca@codefactory.se>
2181 * bus/dispatch.c: (bus_dispatch):
2182 Refetch the service name since it may have been reallocated
2183 when dbus_message_set_sender was called.
2185 * dbus/dbus-sysdeps.c: (_dbus_accept):
2186 Add address and address length variables and use them to stop
2187 valgrind from complaining.
2189 2003-03-17 Havoc Pennington <hp@pobox.com>
2191 All tests pass, no memleaks, no valgrind complaints.
2193 * bus/test.c: refcount handler_slot
2195 * bus/connection.c (bus_connections_new): refcount
2196 connection_data_slot
2198 * dbus/dbus-auth-script.c (_dbus_auth_script_run): delete unused
2199 bytes so that auth scripts pass.
2201 * bus/dispatch.c: init message_handler_slot so it gets allocated
2204 * bus/dispatch.c (message_handler_slot_ref): fix memleak
2206 * dbus/dbus-server-debug-pipe.c (_dbus_server_debug_pipe_new):
2207 dealloc server_pipe_hash when no longer used for benefit of
2210 * dbus/dbus-auth.c (process_command): memleak fix
2212 * bus/dispatch.c (check_hello_message): memleak fix
2214 2003-03-16 Havoc Pennington <hp@pobox.com>
2216 * dbus/dbus-bus.c (ensure_bus_data): fix double-unref of the data slot
2218 2003-03-17 Anders Carlsson <andersca@codefactory.se>
2220 * bus/activation.c (bus_activation_activate_service): Append
2221 the pending activation entry to the list of pending activations.
2223 2003-03-16 Havoc Pennington <hp@pobox.com>
2225 * bus/dispatch.c (bus_dispatch_test): remove double-unrefs of
2228 * dbus/dbus-address.c (create_entry): fix OOM handling when
2229 failing to alloc entry->method
2231 2003-03-16 Havoc Pennington <hp@pobox.com>
2233 * dbus/dbus-watch.c (_dbus_watch_new): handle failure to malloc
2236 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
2237 add some missing dbus_set_result
2239 * bus/dispatch.c (bus_dispatch_add_connection): handle failure to
2240 alloc the DBusMessageHandler
2242 * dbus/dbus-transport.c (_dbus_transport_disconnect): don't ref
2243 the transport here, since we call this from the finalizer; it
2244 resulted in a double-finalize.
2246 * dbus/dbus-transport.c (_dbus_transport_disconnect): fix a bug
2247 where we tried to use transport->connection that was NULL,
2248 happened when transport was disconnected early on due to OOM
2250 * bus/*.c: adapt to handle OOM for watches/timeouts
2252 * dbus/dbus-transport-unix.c: port to handle OOM during
2255 * dbus/dbus-auth.c (_dbus_auth_get_unused_bytes): return a
2256 reference to unused bytes instead of a copy
2258 * dbus/dbus-server.c (dbus_server_handle_watch): return FALSE for
2261 * dbus/dbus-connection.c (dbus_connection_handle_watch): return
2264 * dbus/dbus-timeout.c (dbus_timeout_handle): return FALSE for out
2267 2003-03-16 Anders Carlsson <andersca@codefactory.se>
2269 * doc/dbus-specification.sgml:
2270 Document reply message for ActivateService.
2272 2003-03-16 Anders Carlsson <andersca@codefactory.se>
2274 * bus/activation.c: (bus_pending_activation_entry_free),
2275 (bus_pending_activation_free), (bus_activation_new),
2276 (bus_activation_unref), (bus_activation_service_created),
2277 (bus_activation_activate_service):
2279 * bus/bus.c: (bus_context_new):
2280 * bus/desktop-file.c: (new_section):
2281 * bus/driver.c: (bus_driver_send_service_deleted),
2282 (bus_driver_handle_activate_service):
2283 * bus/services.c: (bus_registry_new), (bus_registry_ensure):
2285 * dbus/dbus-connection.c:
2286 (dbus_connection_send_with_reply_and_block):
2287 * dbus/dbus-message.c: (dbus_message_append_args_valist):
2288 * dbus/dbus-protocol.h:
2289 Make activation work better. Now pending activations will be queued
2290 and the daemon won't try to activate services that are already registered.
2292 2003-03-16 Havoc Pennington <hp@pobox.com>
2294 * dbus/dbus-bus.c (ensure_bus_data): handle failure to set
2297 * dbus/dbus-memory.c (_dbus_initialize_malloc_debug): support
2298 DBUS_MALLOC_BACKTRACES to print trace when failing an alloc
2300 2003-03-16 Havoc Pennington <hp@pobox.com>
2302 * dbus/dbus-string.c (_dbus_string_validate_utf8): oops, unbreak
2303 this. always run the test suite before commit...
2305 * bus/*: adapt to DBusConnection API changes
2307 * glib/dbus-gmain.c: adapt to DBusConnection API changes,
2308 requires renaming stuff to avoid dbus_connection_dispatch name
2311 * dbus/dbus-transport.c (_dbus_transport_queue_messages): new
2314 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
2315 separate from _dbus_message_loader_return_buffer()
2317 * dbus/dbus-connection.c (dbus_connection_get_n_messages): remove
2318 this, because it's now always broken to use; the number of
2319 messages in queue vs. the number still buffered by the message
2320 loader is undefined/meaningless. Should use
2321 dbus_connection_get_dispatch_state().
2322 (dbus_connection_dispatch): rename from
2323 dbus_connection_dispatch_message
2325 2003-03-16 Havoc Pennington <hp@pobox.com>
2327 * dbus/dbus-string.c (_dbus_string_validate_utf8): copy in a real
2330 2003-03-16 Anders Carlsson <andersca@codefactory.se>
2332 * dbus/dbus-connection.c:
2333 (dbus_connection_send_with_reply_and_block):
2334 Decrease connection->n_incoming when removing an entry
2336 * dbus/dbus-dict.c: (dbus_dict_entry_free),
2337 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
2338 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
2339 (dbus_dict_set_byte_array), (dbus_dict_set_string_array),
2340 (dbus_dict_get_boolean_array), (dbus_dict_get_double_array),
2341 (dbus_dict_get_byte_array):
2342 Handle NULL arrays and strings. Also add support for byte arrays.
2344 * dbus/dbus-marshal.c: (_dbus_marshal_byte_array),
2345 (_dbus_marshal_dict), (_dbus_demarshal_byte_array),
2346 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
2347 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
2348 (_dbus_demarshal_dict), (demarshal_and_validate_len),
2349 (_dbus_marshal_validate_arg), (_dbus_marshal_test):
2350 * dbus/dbus-marshal.h:
2351 Add support for marshalling and demarshalling empty arrays and strings.
2353 * dbus/dbus-message.c: (dbus_message_append_args_valist),
2354 (dbus_message_append_string_array),
2355 (dbus_message_iter_get_boolean),
2356 (dbus_message_iter_get_boolean_array),
2357 (dbus_message_iter_get_int32_array),
2358 (dbus_message_iter_get_uint32_array),
2359 (dbus_message_iter_get_double_array),
2360 (dbus_message_iter_get_byte_array),
2361 (dbus_message_iter_get_string_array), (dbus_message_iter_get_dict),
2362 (check_message_handling):
2363 Add support for getting empty arrays and dicts.
2365 * dbus/dbus-string.c: (_dbus_string_validate_utf8):
2366 Don't do any validation at all for now, that's better than just checking
2369 * test/data/valid-messages/emptiness.message:
2370 New test message with lots of empty arrays.
2372 2003-03-16 Havoc Pennington <hp@pobox.com>
2374 * dbus/dbus-connection.c
2375 (_dbus_connection_queue_received_message_link): new function that
2376 can't fail due to OOM
2378 * dbus/dbus-message.c (_dbus_message_loader_pop_message_link):
2379 new function pops a message together with a list link
2382 * dbus/dbus-transport-unix.c (queue_messages): use new link-based
2383 message queuing functions to avoid needing to alloc memory
2385 2003-03-16 Havoc Pennington <hp@pobox.com>
2387 Oops - test code was only testing failure of around 30 of the
2388 mallocs in the test path, but it turns out there are 500+
2389 mallocs. I believe this was due to misguided linking setup such
2390 that there was one copy of dbus_malloc etc. in the daemon and one
2391 in the shared lib, and only daemon mallocs were tested. In any
2392 case, the test case now tests all 500+ mallocs, and doesn't pass
2393 yet, though there are lots of fixes in this patch.
2395 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
2396 this so that it doesn't need to allocate memory, since it
2397 has no way of indicating failure due to OOM (and would be
2398 annoying if it did).
2400 * dbus/dbus-list.c (_dbus_list_pop_first_link): new function
2402 * bus/Makefile.am: rearrange to create two self-contained
2403 libraries, to avoid having libraries with overlapping symbols.
2404 that was resulting in weirdness, e.g. I'm pretty sure there
2405 were two copies of global static variables.
2407 * dbus/dbus-internals.c: move the malloc debug stuff to
2410 * dbus/dbus-list.c (free_link): free list mempool if it becomes
2413 * dbus/dbus-memory.c (_dbus_disable_mem_pools): new function
2415 * dbus/dbus-address.c (dbus_parse_address): free list nodes
2418 * bus/dispatch.c (bus_dispatch_add_connection): free
2419 message_handler_slot when no longer using it, so
2420 memory leak checkers are happy for the test suite.
2422 * dbus/dbus-server-debug-pipe.c (debug_finalize): free server name
2424 * bus/bus.c (new_connection_callback): disconnect in here if
2425 bus_connections_setup_connection fails.
2427 * bus/connection.c (bus_connections_unref): fix to free the
2429 (bus_connections_setup_connection): if this fails, don't
2430 disconnect the connection, just be sure there are no side
2433 * dbus/dbus-string.c (undo_alignment): unbreak this
2435 * dbus/dbus-auth.c (_dbus_auth_unref): free some stuff we were
2437 (_dbus_auth_new): fix the order in which we free strings
2440 * bus/connection.c (bus_connection_disconnected): fix to
2441 not send ServiceDeleted multiple times in case of memory
2444 * dbus/dbus-bus.c (dbus_bus_get_base_service): new function to
2445 get the base service name
2446 (dbus_bus_register_client): don't return base service name,
2447 instead store it on the DBusConnection and have an accessor
2449 (dbus_bus_register_client): rename dbus_bus_register()
2451 * bus/dispatch.c (check_hello_message): verify that other
2452 connections on the bus also got the correct results, not
2453 just the one sending hello
2455 2003-03-15 Havoc Pennington <hp@pobox.com>
2457 Make it pass the Hello handling test including all OOM codepaths.
2458 Now to do other messages...
2460 * bus/services.c (bus_service_remove_owner): fix crash when
2461 removing owner from an empty list of owners
2462 (bus_registry_ensure): don't leave service in the list of
2463 a connection's owned services if we fail to put the service
2466 * bus/connection.c (bus_connection_preallocate_oom_error): set
2467 error flag on the OOM error.
2469 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
2470 handle _dbus_transport_set_connection failure
2472 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd): modify
2473 to create watches up front and simply enable/disable them as
2475 (unix_connection_set): this can now fail on OOM
2477 * dbus/dbus-timeout.c, dbus/dbus-watch.c: add concept
2478 of enabling/disabling a watch or timeout.
2480 * bus/loop.c (bus_loop_iterate): don't touch disabled
2483 * glib/dbus-gmain.c: adapt to enable/disable watches and timeouts
2485 2003-03-15 Havoc Pennington <hp@pobox.com>
2487 * bus/dispatch.c (bus_dispatch_test): OK, now finally actually
2488 write useful test code, after all that futzing around ;-)
2490 Test does not yet pass because we can't handle OOM in
2491 _dbus_transport_messages_pending (basically,
2492 dbus_connection_preallocate_send() does not prealloc the write
2493 watch). To fix this, I think we need to add new stuff to
2494 set_watch_functions, namely a SetEnabled function so we can alloc
2495 the watch earlier, then enable it later.
2497 * dbus/Makefile.am (libdbus_convenience_la_SOURCES): move
2498 dbus-memory.c to the convenience lib
2500 * bus/test.c: rename some static functions to keep them clearly
2501 distinct from stuff in connection.c. Handle client disconnection.
2503 2003-03-14 Havoc Pennington <hp@pobox.com>
2505 * bus/dispatch.c (bus_dispatch_test): do test using debug-pipe
2506 transport, tests more of the real codepath. Set up clients
2507 with bus_setup_debug_client.
2509 * bus/test.c (bus_setup_debug_client): function to set up debug
2510 "clients" on the main loop
2512 * dbus/dbus-transport.c (_dbus_transport_open): add debug-pipe
2515 * dbus/dbus-server.c (dbus_server_listen): add debug-pipe
2518 * dbus/dbus-server-debug.c: support a debug server based on pipes
2520 * dbus/dbus-sysdeps.c (_dbus_full_duplex_pipe): new function
2521 (_dbus_close): new function
2523 * configure.in: check for socketpair
2525 2003-03-14 Havoc Pennington <hp@redhat.com>
2527 * dbus/dbus-memory.c: add a "detect buffer overwrites on free"
2530 * dbus/dbus-transport-debug.c: rework this a good bit to be
2531 less complicated. hopefully still works.
2533 * dbus/dbus-server-debug.c (handle_new_client): remove timeout
2536 * glib/dbus-gmain.c (timeout_handler): don't remove timeout
2539 * dbus/dbus-message.c (dbus_message_copy): rename from
2540 dbus_message_new_from_message, fix it up to copy
2541 all the message fields, add test case
2543 * bus/dispatch.c (bus_dispatch_test): add some more test code,
2544 not quite passing yet
2546 2003-03-14 Havoc Pennington <hp@pobox.com>
2548 * bus/loop.c (bus_loop_iterate): add this so we can "run loop
2549 until no work remains" in test code. (the large diff here
2550 is just code movement, no actual changes)
2552 * dbus/dbus-server-debug.c (DEFAULT_INTERVAL): change interval to
2553 1, no point waiting around for test code.
2554 (_dbus_server_debug_accept_transport): unref the timeout
2555 after adding it (right?)
2557 * dbus/dbus-transport-debug.c (DEFAULT_INTERVAL): ditto
2559 2003-03-13 Havoc Pennington <hp@redhat.com>
2561 * dbus/dbus-timeout.c (_dbus_timeout_list_set_functions): handle
2564 * dbus/dbus-watch.c (_dbus_watch_list_set_functions): handle out
2567 * dbus/dbus-connection.h: Make AddWatchFunction and
2568 AddTimeoutFunction return a bool so they can fail on out-of-memory
2570 * bus/bus.c (bus_context_new): set up timeout handlers
2572 * bus/connection.c (bus_connections_setup_connection): set up
2575 * glib/dbus-gmain.c: adapt to the fact that set_functions stuff
2578 * bus/bus.c (bus_context_new): adapt to changes
2580 * bus/connection.c: adapt to changes
2582 * test/watch.c: adapt to DBusWatch changes
2584 * bus/dispatch.c (bus_dispatch_test): started adding this but
2587 2003-03-14 Anders Carlsson <andersca@codefactory.se>
2589 * bus/dispatch.c (send_service_nonexistent_error): Fix typo.
2591 2003-03-13 Havoc Pennington <hp@pobox.com>
2593 * bus/test.c, bus/test.h, bus/Makefile.am, bus/test-main.c:
2594 set up a test framework as for the library
2596 2003-03-12 Havoc Pennington <hp@pobox.com>
2598 Throughout: purge global variables, introduce BusActivation,
2599 BusConnections, BusRegistry, etc. objects instead.
2601 * bus/bus.h, bus/bus.c: introduce BusContext as a global
2604 * test/Makefile.am (TEST_BINARIES): disable bus-test for now,
2605 going to redo this a bit differently I think
2607 2003-03-12 Havoc Pennington <hp@redhat.com>
2609 Mega-patch that gets the message bus daemon initially handling
2610 out-of-memory. Work still needed. Also lots of random
2611 moving stuff to DBusError instead of ResultCode.
2613 * dbus/dbus-list.c (_dbus_list_length_is_one): new function
2615 * dbus/dbus-connection.c
2616 (dbus_connection_send_with_reply_and_block): use DBusError
2618 * dbus/dbus-bus.c: adapt to API changes, make it use DBusError not
2621 * dbus/dbus-connection.c (dbus_connection_send): drop the result
2622 code here, as the only failure possible is OOM.
2624 * bus/connection.c (bus_connection_disconnect):
2625 rename bus_connection_disconnected as it's a notification only
2627 * bus/driver.c (bus_driver_handle_acquire_service): don't free
2628 "name" on get_args failure, should be done by get_args;
2629 don't disconnect client for bad args, just return an error.
2630 (bus_driver_handle_service_exists): ditto
2632 * bus/services.c (bus_services_list): NULL-terminate returned array
2634 * bus/driver.c (bus_driver_send_service_lost)
2635 (bus_driver_send_service_acquired): send messages from driver to a
2636 specific client to the client's unique name, not to the broadcast
2639 * dbus/dbus-message.c (decode_header_data): reject messages that
2640 contain no name field
2641 (_dbus_message_get_client_serial): rename to
2642 dbus_message_get_serial and make public
2643 (_dbus_message_set_serial): rename from set_client_serial
2644 (_dbus_message_set_reply_serial): make public
2645 (_dbus_message_get_reply_serial): make public
2647 * bus/connection.c (bus_connection_foreach): allow stopping
2648 iteration by returning FALSE from foreach function.
2650 * dbus/dbus-connection.c (dbus_connection_send_preallocated)
2651 (dbus_connection_free_preallocated_send)
2652 (dbus_connection_preallocate_send): new API for sending a message
2653 without possibility of malloc failure.
2654 (dbus_connection_send_message): rename to just
2655 dbus_connection_send (and same for whole function family)
2657 * dbus/dbus-errors.c (dbus_error_free): make this reinit the error
2659 * dbus/dbus-sysdeps.c (_dbus_exit): new function
2661 * bus/activation.c: handle/return errors
2663 * dbus/dbus-errors.h: add more DBUS_ERROR #define
2665 * dbus/dbus-sysdeps.c (_dbus_directory_open) (_dbus_file_get_contents)
2666 (_dbus_directory_get_next_file): use DBusError instead of DBusResultCode
2667 (_dbus_result_from_errno): move to this file
2669 2003-03-10 Anders Carlsson <andersca@codefactory.se>
2671 * dbus/dbus-marshal.c:
2672 (_dbus_marshal_set_string):
2673 Take a length argument so we can marshal the correct string
2676 (_dbus_marshal_dict), (_dbus_demarshal_dict),
2677 (_dbus_marshal_get_arg_end_pos), (_dbus_marshal_validate_arg),
2678 (_dbus_marshal_test):
2679 * dbus/dbus-marshal.h:
2680 Add support for marshalling and demarshalling dicts.
2682 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
2683 Add support for TYPE DICT.
2685 * dbus/dbus-message.c: (set_string_field):
2686 Adjust header padding.
2688 (dbus_message_append_args_valist), (dbus_message_append_dict),
2689 (dbus_message_get_args_valist), (dbus_message_iter_get_arg_type),
2690 (dbus_message_iter_get_dict), (_dbus_message_loader_return_buffer),
2691 (check_message_handling), (check_have_valid_message):
2692 * dbus/dbus-message.h:
2693 Add functions for setting and getting dicts.
2695 * dbus/dbus-protocol.h:
2701 * doc/dbus-specification.sgml:
2702 Add information about how dicts are marshalled.
2704 * test/data/invalid-messages/dict-with-nil-value.message:
2705 * test/data/invalid-messages/too-short-dict.message:
2706 * test/data/valid-messages/dict-simple.message:
2707 * test/data/valid-messages/dict.message:
2708 Add sample messages containing dicts.
2710 2003-03-08 Anders Carlsson <andersca@codefactory.se>
2712 * dbus/dbus-dict.h: Add DBUS_END_DECLS.
2714 2003-03-07 Anders Carlsson <andersca@codefactory.se>
2717 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
2718 (dbus_dict_get_keys), (insert_entry), (dbus_dict_set_boolean),
2719 (dbus_dict_set_int32), (dbus_dict_set_uint32),
2720 (dbus_dict_set_double), (dbus_dict_set_string),
2721 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
2722 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
2723 (dbus_dict_set_string_array), (_dbus_dict_test):
2725 Fix according to comments from Havoc.
2727 2003-03-06 Michael Meeks <michael@server.home>
2729 * configure.in: if we don't have kde-config, disable have_qt.
2731 2003-03-07 Anders Carlsson <andersca@codefactory.se>
2736 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
2737 (dbus_dict_ref), (dbus_dict_unref), (dbus_dict_contains),
2738 (dbus_dict_remove), (dbus_dict_get_value_type),
2739 (dbus_dict_get_keys), (dbus_dict_put_boolean),
2740 (dbus_dict_put_int32), (dbus_dict_put_uint32),
2741 (dbus_dict_put_double), (dbus_dict_put_string),
2742 (dbus_dict_put_boolean_array), (dbus_dict_put_int32_array),
2743 (dbus_dict_put_uint32_array), (dbus_dict_put_double_array),
2744 (dbus_dict_put_string_array), (dbus_dict_get_boolean),
2745 (dbus_dict_get_int32), (dbus_dict_get_uint32),
2746 (dbus_dict_get_double), (dbus_dict_get_string),
2747 (dbus_dict_get_boolean_array), (dbus_dict_get_int32_array),
2748 (dbus_dict_get_uint32_array), (dbus_dict_get_double_array),
2749 (dbus_dict_get_string_array), (_dbus_dict_test):
2751 Add DBusDict implementation
2753 * dbus/dbus-test.c: (dbus_internal_do_not_use_run_tests):
2757 2003-03-04 Havoc Pennington <hp@pobox.com>
2759 * test/data/auth/*: adapt to changes
2761 * dbus/dbus-auth-script.c (_dbus_auth_script_run): add
2762 USERID_BASE64 and change USERNAME_BASE64 to put in username not
2765 * dbus/dbus-keyring.c (_dbus_keyring_validate_context): prevent
2766 more stuff from being in a context name, to make the protocol
2767 simpler to deal with
2769 * dbus/dbus-errors.c (dbus_error_has_name): new function
2770 (dbus_error_is_set): new function
2772 * dbus/dbus-auth.c: replace DBUS_STUPID_TEST_MECH auth
2773 with DBUS_COOKIE_SHA1, implement DBUS_COOKIE_SHA1
2775 * dbus/dbus-connection.c (dbus_connection_flush): also read
2776 messages during a flush operation
2778 * dbus/Makefile.am: remove dbus-md5 since it isn't currently used.
2780 2003-03-05 Anders Carlsson <andersca@codefactory.se>
2782 * configure.in: Check for gethostbyname on Solaris.
2784 * dbus/dbus-transport.c: (_dbus_transport_open):
2785 Remove duplicate "tcp" entry.
2787 * doc/dbus-specification.sgml:
2788 Clarify some things.
2790 2003-03-05 Anders Carlsson <andersca@codefactory.se>
2792 * dbus/dbus-auth.c: (send_rejected), (process_test_subdir):
2793 * dbus/dbus-keyring.c: (_dbus_keyring_new_homedir),
2794 (_dbus_keyring_test):
2795 * dbus/dbus-md5.c: (_dbus_md5_compute):
2796 * dbus/dbus-sha.c: (_dbus_sha_compute):
2799 2003-03-05 Anders Carlsson <andersca@codefactory.se>
2801 * README: Add some things.
2803 2003-03-04 Anders Carlsson <andersca@codefactory.se>
2805 * dbus/dbus-message.c (dbus_message_append_args_valist): Add a break;
2806 after case DBUS_TYPE_BOOELAN.
2808 2003-03-02 Havoc Pennington <hp@pobox.com>
2810 * test/break-loader.c (randomly_set_extreme_ints): add test that
2811 sets really huge and small integers
2813 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add check
2814 that length of boolean array fits in the string, and that
2815 string has room for boolean value in single-bool case.
2817 * dbus/dbus-message-builder.c (_dbus_message_data_load): add
2818 optional value to "ALIGN" command which is what to fill the
2821 * test/data/valid-messages/no-padding.message: add regression
2822 test for the message padding problem
2824 2003-03-02 Havoc Pennington <hp@pobox.com>
2826 * dbus/dbus-message.c (decode_header_data): fix to always init
2827 message_padding, from Benjamin Dauvergne
2829 2003-03-02 Havoc Pennington <hp@pobox.com>
2835 2003-03-01 Joe Shaw <joe@assbarn.com>
2837 * configure.in: Check for "struct cmsgcred" and try to access its
2838 members for BSD-like unices.
2840 * dbus/dbus-sysdeps.c (read_credentials_byte): Fold this back into
2841 _dbus_read_credentials_unix_socket().
2842 (_dbus_read_credentials_unix_socket): Use recvmsg() instead of
2843 read() for reading the credential byte off the unix socket. Use
2844 struct cmsgcred on systems that support it.
2846 2003-02-27 Alexander Larsson <alexl@redhat.com>
2850 Make gthreads-2.0 dependency optional. Don't build thread test if
2853 2003-02-27 Havoc Pennington <hp@pobox.com>
2855 * dbus/dbus-connection.c
2856 (dbus_connection_send_message_with_reply_and_block): fix doh!
2857 doh! doh! bug that resulted in never removing a reply from the
2858 queue, no wonder we called get_reply_serial so much ;-)
2860 * dbus/dbus-message.c (struct DBusMessage): cache reply serial
2861 and client serial instead of demarshaling them every time
2863 2003-02-27 Havoc Pennington <hp@pobox.com>
2865 * dbus/dbus-marshal.c (_dbus_demarshal_int32): rewrite to be much
2866 more inlined, using dbus-string-private.h, speeds things up
2869 * dbus/dbus-string.c (_dbus_string_free): apply align offset
2870 when freeing the string
2871 (_dbus_string_steal_data): fix for align offset
2872 (undo_alignment): new function
2874 2003-02-26 Havoc Pennington <hp@redhat.com>
2876 All kinds of audit fixes from Owen, plus initial attempt to
2877 handle unaligned memory returned from malloc.
2879 * dbus/dbus-string.c (_dbus_string_init): clamp max length to
2880 leave room for align_offset and nul byte
2881 (fixup_alignment): function to track an align_offset and
2882 ensure real->str is aligned
2883 (DBUS_GENERIC_STRING_PREAMBLE): len must be less than allocated,
2884 to allow a nul byte plus align offset
2885 (_dbus_string_lock): fix overflow issue
2886 (_dbus_string_init_const_len): add assertions on sanity of len,
2887 assign allocated to be ALLOCATION_PADDING larger than len
2888 (set_length): fixup the overflow handling
2889 (_dbus_string_get_data_len): fix overflow in assertion
2890 (open_gap): detect overflow in size of gap to be opened
2891 (_dbus_string_lengthen): add overflow check
2892 (_dbus_string_align_length): fix overflow with _DBUS_ALIGN_VALUE
2893 (_dbus_string_append): add overflow check
2894 (_dbus_string_append_unichar): overflow
2895 (_dbus_string_delete): fix overflow in assertion
2896 (_dbus_string_copy_len): overflow in assertion
2897 (_dbus_string_replace_len): overflows in assertions
2898 (_dbus_string_find): change to implement in terms of
2899 _dbus_string_find_to
2900 (_dbus_string_find_to): assorted fixage
2901 (_dbus_string_equal_c_str): assert c_str != NULL,
2902 fix logic so the function works
2903 (_dbus_string_ends_with_c_str): fix overflow thingy
2904 (_dbus_string_base64_encode): overflow fix
2905 (_dbus_string_validate_ascii): overflow
2906 (_dbus_string_validate_nul): overflow
2908 2003-02-26 Havoc Pennington <hp@redhat.com>
2910 * dbus/dbus-marshal.c (_dbus_marshal_test): fix to work with DISABLE_ASSERTS
2912 2003-02-26 Alexander Larsson <alexl@redhat.com>
2915 Set DBUS_GLIB_THREADS_LIBS for apps using gthread-2.0
2917 * dbus/dbus-connection.c:
2918 * dbus/dbus-connection.h:
2919 Fix _dbus_connection_acquire_io_path and _dbus_connection_acquire_dispatch.
2920 Add dbus_connection_set_wakeup_main_function and use it when queueing
2921 incoming and outgoing messages.
2924 * dbus/dbus-dataslot.c:
2925 Threadsafe usage of DBusDataSlotAllocator
2927 * dbus/dbus-message.c: (dbus_message_get_args_iter):
2930 * dbus/dbus-server-unix.c:
2933 * glib/dbus-gmain.c:
2934 Implement the new wakeup functions for glib.
2937 * glib/test-thread-client.c:
2938 * glib/test-thread-server.c:
2939 * glib/test-thread.h:
2940 Initial cut at some thread test code. Not really done yet.
2942 2003-02-26 Havoc Pennington <hp@pobox.com>
2944 * dbus/dbus-connection.c
2945 (dbus_connection_send_message_with_reply_and_block): fix crash
2946 where we ref'd the outgoing message instead of the returned reply
2948 * dbus/dbus-transport-unix.c (do_authentication): check read watch
2949 at the end of this function, so if we didn't need to read for
2950 authentication, we reinstall it for receiving messages
2952 * dbus/dbus-message.c (dbus_message_new_reply): allow replies to
2953 a NULL sender for peer-to-peer case
2955 * dbus/dbus-transport-unix.c (check_read_watch): handle
2956 !authenticated case correctly
2958 * glib/dbus-gmain.c: add support for DBusServer
2960 * dbus/dbus-server.c: add data slot support
2962 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): check
2963 return values and handle errors
2965 * dbus/dbus-dataslot.c: factor out the data slot stuff from
2968 * Doxyfile.in (INPUT): add glib subdir
2970 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): rename
2971 setup_with_g_main instead of hookup_with_g_main; write docs
2973 2003-02-24 Anders Carlsson <andersca@codefactory.se>
2975 * dbus/dbus-marshal.c: (_dbus_marshal_validate_arg):
2976 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
2977 * dbus/dbus-message.c: (dbus_message_append_boolean),
2978 (dbus_message_append_boolean_array),
2979 (dbus_message_get_args_valist), (_dbus_message_test):
2980 * dbus/dbus-message.h:
2981 * doc/dbus-specification.sgml:
2982 Various fixes as pointed out by Havoc.
2984 * test/data/invalid-messages/bad-boolean-array.message:
2985 * test/data/invalid-messages/bad-boolean.message:
2986 Add invalid boolean value test cases.
2988 2003-02-24 Anders Carlsson <andersca@codefactory.se>
2990 * dbus/dbus-internals.c: (_dbus_type_to_string):
2991 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
2992 (_dbus_marshal_validate_arg):
2993 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
2994 * dbus/dbus-message.c: (dbus_message_append_args_valist),
2995 (dbus_message_append_boolean), (dbus_message_append_boolean_array),
2996 (dbus_message_get_args_valist), (dbus_message_iter_get_boolean),
2997 (dbus_message_iter_get_int32), (dbus_message_iter_get_uint32),
2998 (dbus_message_iter_get_double),
2999 (dbus_message_iter_get_boolean_array), (message_iter_test):
3000 * dbus/dbus-message.h:
3001 * dbus/dbus-protocol.h:
3002 * doc/dbus-specification.sgml:
3003 * test/data/valid-messages/lots-of-arguments.message:
3004 Add support for boolean and boolean array types.
3006 2003-02-23 Havoc Pennington <hp@pobox.com>
3008 * dbus/dbus-keyring.c: finish most of this implementation and
3011 * dbus/dbus-errors.c (dbus_set_error_const, dbus_set_error): make
3012 these barf if the error isn't cleared to NULL
3014 * dbus/dbus-sysdeps.c (_dbus_delete_file): set error on failure
3015 (_dbus_create_directory): new function
3017 * dbus/dbus-errors.c (dbus_set_error): fix warning
3019 * dbus/dbus-string.c (_dbus_string_hex_encode): new function
3020 (_dbus_string_hex_decode): new function
3021 (test_hex_roundtrip): test code
3023 * dbus/dbus-sha.c (_dbus_sha_compute): use dbus_string_hex_encode
3025 * dbus/dbus-md5.c (_dbus_md5_compute): use dbus_string_hex_encode
3027 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): make this use
3028 the save-to-temp/rename trick to atomically write the new file
3029 (_dbus_string_parse_uint): new function
3031 2003-02-22 Havoc Pennington <hp@pobox.com>
3033 * test/Makefile.am (dist-hook): fix dist for test/data/sha-1
3035 2003-02-22 Havoc Pennington <hp@pobox.com>
3037 * dbus/dbus-message.c (dbus_message_iter_get_string_array):
3038 (dbus_message_iter_get_byte_array): Fix up doxygen warnings
3040 * dbus/dbus-sha.c: add implementation of SHA-1 algorithm
3042 * dbus/test/data/sha-1: add US government test suite for SHA-1
3044 2003-02-21 Anders Carlsson <andersca@codefactory.se>
3046 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
3047 Make string arrays NULL-terminated.
3049 * dbus/dbus-memory.c: (dbus_free_string_array):
3050 * dbus/dbus-memory.h:
3051 New function for freeing NULL-terminated string arrays.
3053 * dbus/dbus-message-builder.c: (append_quoted_string),
3054 (_dbus_message_data_load):
3055 Add support for array types.
3057 * dbus/dbus-message.c: (check_message_handling):
3058 Add more types as test cases.
3060 * dbus/dbus-sysdeps.c: (_dbus_string_parse_int),
3061 (_dbus_string_parse_double):
3062 Add the start offset to the end offset.
3064 * test/data/valid-messages/lots-of-arguments.message:
3065 New test message with lots of arguments.
3067 2003-02-21 Anders Carlsson <andersca@codefactory.se>
3069 * dbus/dbus-message.c: (dbus_message_append_nil),
3070 (dbus_message_append_int32), (dbus_message_append_uint32),
3071 (dbus_message_append_double), (dbus_message_append_string),
3072 (dbus_message_append_int32_array),
3073 (dbus_message_append_uint32_array),
3074 (dbus_message_append_double_array),
3075 (dbus_message_append_byte_array),
3076 (dbus_message_append_string_array):
3077 Fix all out-of-memory handling in these functions.
3079 2003-02-21 Anders Carlsson <andersca@codefactory.se>
3081 * dbus/dbus-message.c: (dbus_message_append_nil):
3084 2003-02-21 Anders Carlsson <andersca@codefactory.se>
3086 * dbus/dbus-message.c: (dbus_message_append_args_valist),
3087 (dbus_message_append_nil), (dbus_message_append_int32_array),
3088 (dbus_message_append_uint32_array),
3089 (dbus_message_append_double_array),
3090 (dbus_message_append_byte_array),
3091 (dbus_message_append_string_array), (dbus_message_get_args_valist),
3092 (dbus_message_iter_get_int32_array),
3093 (dbus_message_iter_get_uint32_array),
3094 (dbus_message_iter_get_double_array),
3095 (dbus_message_iter_get_byte_array),
3096 (dbus_message_iter_get_string_array):
3098 * dbus/dbus-message.h:
3099 Add functions for appending and getting arrays.
3101 2003-02-21 Anders Carlsson <andersca@codefactory.se>
3103 * dbus/dbus-mempool.c (_dbus_mem_pool_new): Make the
3104 element size at least 8 bytes, fixes mempool tests on
3107 2003-02-20 Alexander Larsson <alexl@redhat.com>
3109 * dbus/dbus-transport-unix.c (unix_do_iteration):
3110 Unlock the connection mutex during a blocking select call.
3111 Add todo about how we need a way to wake up the select.
3113 * dbus/dbus-connection-internal.h:
3114 * dbus/dbus-connection.c:
3115 Add _dbus_connection_lock and _dbus_connection_unlock.
3117 2003-02-19 Havoc Pennington <hp@pobox.com>
3119 * Doxyfile.in (PREDEFINED): put DOXYGEN_SHOULD_SKIP_THIS in
3120 Doxyfile.in, not Doxyfile
3122 * dbus/dbus-keyring.c: do some hacking on this
3124 * dbus/dbus-sysdeps.c (_dbus_delete_file): new
3126 * dbus/dbus-errors.c (dbus_set_error_const): do not call
3128 (dbus_set_error): remove dbus_error_init, check for message ==
3129 NULL *before* we sprintf into it, and add @todo about including
3130 system headers in this file
3132 * dbus/dbus-sysdeps.c (_dbus_create_file_exclusively): new
3134 * dbus/dbus-errors.h (DBUS_ERROR_FAILED): add
3136 * dbus/dbus-sysdeps.c (get_user_info): break this function out to
3137 get various bits of user information based on either username
3139 (_dbus_homedir_from_username): new function
3141 2003-02-19 Anders Carlsson <andersca@codefactory.se>
3144 Add check for nonposix getpwnam_r
3146 * dbus/dbus-mempool.c: (_dbus_mem_pool_new):
3147 Align the pool element size to a sizeof (void *) boundary.
3149 * dbus/dbus-sysdeps.c: (_dbus_setenv), (_dbus_connect_unix_socket),
3150 (_dbus_listen_unix_socket), (_dbus_credentials_from_username):
3151 General Solaris fixes.
3153 * test/data/valid-messages/simplest-manual.message:
3154 Explicitly state that we want little-endian packing.
3156 2003-02-19 Mikael Hallendal <micke@codefactory.se>
3158 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
3160 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_tcp_socket):
3161 Added to create a transport connecting using a tcp/ip socket.
3163 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): Added to connect
3164 to a tcp socket at given host and port.
3165 (_dbus_listen_tcp_socket): added to listen on tcp socket for given
3168 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
3170 * dbus/dbus-server-unix.c (_dbus_server_new_for_tcp_socket):
3171 Added to create a server listening on a TCP/IP socket.
3173 2003-02-19 Havoc Pennington <hp@pobox.com>
3175 Throughout: mop up all the Doxygen warnings and undocumented
3178 * dbus/dbus-sysdeps.c (do_exec): do not use execvp, we don't want
3179 to search any paths.
3181 * dbus/dbus-threads.c: move global mutex initializers to
3182 dbus-internals.h, multiple prototypes was confusing doxygen
3183 besides being kind of ugly
3185 * Doxyfile (PREDEFINED): have Doxygen define
3186 DOXYGEN_SHOULD_SKIP_THIS so we can exclude things from
3187 docs with #ifndef DOXYGEN_SHOULD_SKIP_THIS
3188 (do not abuse the feature! it's for stuff like the autogenerated
3189 macros in dbus-md5.c, not just for things you don't feel like
3192 2003-02-18 Havoc Pennington <hp@pobox.com>
3194 * dbus/dbus-string.c (_dbus_string_zero): new function
3196 * dbus/dbus-md5.c: include MD5 implementation by L. Peter Deutsch,
3197 wrap it in some dbus-friendly API
3199 * dbus/dbus-types.h: add 16-bit types
3201 2003-02-18 Joe Shaw <joe@assbarn.com>
3203 * dbus/dbus-auth.c (handle_server_data_stupid_test_mech): Just get
3204 credentials from our currently running process.
3205 (get_word): Fix a buglet where we were copying the entire length
3206 instead of relative to our position.
3208 * dbus/dbus-hash.c (_dbus_hash_test): Don't try to allocate the
3209 keys on the stack... it's 640k of data.
3211 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): Always
3212 read the credentials byte off the socket, even if we don't have
3214 (_dbus_poll): Implement poll() using select() for systems which
3217 * glib/test-dbus-glib.c (main): Print out an error if no
3218 parameters are given.
3220 * test/data/auth/fallback.auth-script: Added. Tests that a client
3221 can fallback to a secondary auth mechanism if the first fails.
3223 2003-02-18 Havoc Pennington <hp@pobox.com>
3227 2003-02-17 Havoc Pennington <hp@pobox.com>
3229 * doc/dbus-specification.sgml: lots of cosmetic
3230 cleanups/rearrangement, add assorted FIXME, change DBUS_ADDRESS
3231 env variable to DBUS_BUS_ADDRESS, s/client/application/,
3232 s/server/bus/ (except in authentication section). Add a section
3233 "Message Bus Message Routing"
3235 2003-02-17 Anders Carlsson <andersca@codefactory.se.>
3241 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3243 * doc/dbus-specification.sgml:
3244 Specification updates.
3246 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3248 * bus/activation.c: (bus_activation_init), (child_setup),
3249 (bus_activation_activate_service):
3251 * bus/main.c: (main):
3252 Set DBUS_ADDRESS environment variable.
3254 * dbus/dbus-errors.c: (dbus_set_error):
3255 Don't use va_copy since that's a C99 feature.
3257 * dbus/dbus-sysdeps.c: (_dbus_setenv), (do_exec),
3258 (_dbus_spawn_async):
3259 * dbus/dbus-sysdeps.h:
3260 Add child_setup_func to _dbus_spawn_async.
3262 * doc/dbus-specification.sgml:
3263 Update specification.
3265 * test/spawn-test.c: (setup_func), (main):
3268 2003-02-17 Alexander Larsson <alexl@redhat.com>
3270 * dbus/dbus-connection.c (_dbus_connection_handler_destroyed_locked):
3273 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3277 * doc/dbus-test-plan.sgml:
3278 Add test plan document.
3283 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3285 * dbus/dbus-message.c: (decode_header_data),
3286 (_dbus_message_loader_return_buffer):
3287 Set the header padding amount when loading a message.
3289 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3291 * bus/dispatch.c: (send_one_message):
3292 Only send broadcast messages to registered connections.
3294 * dbus/dbus-message.c: (dbus_message_name_is):
3295 * dbus/dbus-message.h:
3296 New convenience function.
3298 * dbus/dbus-transport-debug.c: (do_reading):
3299 Only dispatch one message per run.
3302 * test/bus-test.c: (new_connection_callback), (die),
3303 (test_hello_client1_handler), (test_hello_client2_handler),
3304 (test_hello_replies), (main):
3306 * test/bus-test-loop.[ch]:
3309 2003-02-16 Havoc Pennington <hp@pobox.com>
3311 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
3312 backward conditional
3314 2003-02-16 Alexander Larsson <alexl@redhat.com>
3316 * dbus/dbus-connection.c:
3317 Implement sent_message_with_reply. (with_reply_and block is still
3319 Made dispatch_message not lose message if OOM.
3321 * dbus/dbus-errors.h:
3322 Add NoReply error (for reply timeouts).
3324 2003-02-16 Alexander Larsson <alexl@redhat.com>
3326 * dbus/dbus-hash.c (_dbus_hash_table_unref):
3327 Actually free keys and values when destroying hashtable.
3329 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3331 * dbus/dbus-auth.c: (client_try_next_mechanism):
3334 * dbus/dbus-threads.c: (dbus_condvar_wait_timeout):
3335 Return TRUE if there's no thread implementation around.
3337 * glib/dbus-gmain.c: (free_source),
3338 (dbus_connection_hookup_with_g_main):
3339 Make sure to remove the GSource when the connection is finalized.
3341 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3343 * bus/dispatch.c: (bus_dispatch_message_handler):
3344 * dbus/dbus-errors.h:
3345 Return an error if someone tries to send a message to a service
3348 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3350 * bus/activation.c: (load_directory), (bus_activation_init),
3351 (bus_activation_activate_service):
3354 (bus_driver_handle_activate_service), (bus_driver_handle_message):
3355 More work on the activation handling.
3357 * dbus/dbus-errors.h:
3358 Add some error messages
3360 * dbus/dbus-message.c: (dbus_message_new_error_reply):
3361 * dbus/dbus-message.h:
3362 New function that creates an error message.
3364 * dbus/dbus-protocol.h:
3365 Add ACTIVATE_SERVER message.
3367 * dbus/dbus-server-unix.c: (unix_handle_watch),
3368 (_dbus_server_new_for_domain_socket):
3369 Call _dbus_fd_set_close_on_exec.
3371 * dbus/dbus-sysdeps.c: (make_pipe), (do_exec),
3372 (_dbus_spawn_async), (_dbus_disable_sigpipe),
3373 (_dbus_fd_set_close_on_exec):
3374 * dbus/dbus-sysdeps.h:
3375 Add _dbus_fd_set_close_on exec function. Also add function that checks
3376 that all open fds are set to close-on-exec and warns otherwise.
3378 * dbus/dbus-transport-unix.c:
3379 (_dbus_transport_new_for_domain_socket):
3380 Call _dbus_fd_set_close_on_exec.
3382 2003-02-16 Havoc Pennington <hp@pobox.com>
3384 * dbus/dbus-connection.c (dbus_connection_set_change_sigpipe):
3385 allow people to avoid setting SIGPIPE to SIG_IGN
3386 (_dbus_connection_new_for_transport): disable SIGPIPE unless
3387 we've been asked not to
3389 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3391 * dbus/dbus-list.c: (_dbus_list_append_link),
3392 (_dbus_list_prepend_link):
3393 * dbus/dbus-memory.c: (dbus_malloc), (dbus_malloc0),
3397 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3400 * bus/activation.c: (bus_activation_entry_free),
3401 (add_desktop_file_entry), (load_directory), (bus_activation_init):
3403 * bus/main.c: (main):
3404 Add simple activation support, doesn't work yet though.
3406 2003-02-15 Zack Rusin <zack@kde.org>
3408 * qt/dbus-qthread.cpp: small casting fix
3410 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3412 * dbus/dbus-errors.c: (dbus_set_error):
3413 * dbus/dbus-errors.h:
3414 Add a few errors and make dbus_set_error void.
3416 * dbus/dbus-sysdeps.c:
3417 (_dbus_errno_to_string), (close_and_invalidate), (make_pipe),
3418 (write_err_and_exit), (read_ints), (do_exec), (_dbus_spawn_async):
3419 * dbus/dbus-sysdeps.h:
3420 Add _dbus_spawn_async.
3422 * test/spawn-test.c: (main):
3423 Test for _dbus_spawn_async.
3425 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3427 * dbus/dbus-internals.h:
3428 Fix build without tests.
3430 * dbus/dbus-list.c: (alloc_link):
3431 Fix a segfault when a malloc fails.
3433 * dbus/dbus-memory.c: (initialize_malloc_debug), (dbus_malloc),
3434 (dbus_malloc0), (dbus_realloc):
3435 Add support for malloc debugging.
3437 2003-02-15 Alexander Larsson <alexl@redhat.com>
3439 * dbus/dbus-threads.c:
3440 * dbus/dbus-threads.h:
3441 Add condvars. Remove static mutext from API.
3442 Implement static mutexes by initializing them from threads_init.
3444 * glib/dbus-gthread.c:
3445 * qt/dbus-qthread.cpp:
3446 Update with the thread api changes.
3451 Turn StaticMutex into normal mutex + init function.
3452 Export new functions _dbus_list_alloc_link, _dbus_list_free_link,
3453 _dbus_list_append_link, _dbus_list_prepend_link
3456 * dbus/dbus-sysdeps.c:
3457 * dbus/dbus-sysdeps.h:
3458 New type dbus_atomic_t, and new functions _dbus_atomic_inc,
3459 _dbus_atomic_dec. Only slow fallback implementation at the moment.
3461 * dbus/dbus-protocol.h:
3462 Add DBUS_MESSAGE_LOCAL_DISCONNECT define
3464 * dbus/dbus-message.c:
3465 Make ref/unref atomic.
3468 * dbus/dbus-connection-internal.h:
3469 * dbus/dbus-connection.c:
3470 * dbus/dbus-connection.h:
3472 Change _peek to _borrow,_return & _steal_borrowed.
3473 Change disconnect callback to event.
3474 Make dbus_connection_dispatch_messages reentrant.
3476 * dbus/dbus-transport.c:
3477 Don't ref the connection on calls to the transport
3480 * dbus/dbus-message-handler.c:
3483 * glib/dbus-gmain.c:
3484 Don't use peek_message anymore
3487 * test/debug-thread.c:
3488 * test/debug-thread.h:
3489 Simple thread implementation that asserts() on deadlocks in
3490 single-threaded code.
3493 (main) Call debug_threads_init.
3496 Use disconnect message instead of disconnect callback.
3500 Don't call dbus_connection_set_disconnect_function. Instead export
3501 bus_connection_disconnect.
3504 Call bus_connection_disconnect when we get a disconnected message.
3506 2003-02-15 Havoc Pennington <hp@pobox.com>
3508 * dbus/dbus-message.c (dbus_message_new): fool around with the
3511 2003-02-14 Havoc Pennington <hp@pobox.com>
3513 * dbus/dbus-mempool.c: fail if the debug functions so indicate
3515 * dbus/dbus-memory.c: fail if the debug functions indicate we
3518 * dbus/dbus-internals.c (_dbus_set_fail_alloc_counter)
3519 (_dbus_decrement_fail_alloc_counter): debug functions to
3520 simulate memory allocation failures
3522 2003-02-14 Havoc Pennington <hp@pobox.com>
3524 * dbus/dbus-errors.h (struct DBusError): add a word of padding
3527 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3529 * bus/driver.c: (bus_driver_handle_hello):
3531 * bus/services.c: (bus_service_lookup):
3532 Reorder message sending so we get a more sane order.
3534 * test/bus-test.c: (message_handler):
3537 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3539 * bus/driver.c: (bus_driver_send_service_deleted),
3540 (bus_driver_send_service_created), (bus_driver_send_service_lost),
3541 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
3542 (bus_driver_send_welcome_message),
3543 (bus_driver_handle_list_services),
3544 (bus_driver_handle_acquire_service),
3545 (bus_driver_handle_service_exists):
3546 * dbus/dbus-bus.c: (dbus_bus_register_client),
3547 (dbus_bus_acquire_service), (dbus_bus_service_exists):
3548 * dbus/dbus-errors.c: (dbus_result_to_string):
3549 * dbus/dbus-errors.h:
3550 * dbus/dbus-message.c: (dbus_message_append_args),
3551 (dbus_message_append_args_valist), (dbus_message_get_args),
3552 (dbus_message_get_args_valist), (dbus_message_get_args_iter),
3553 (dbus_message_iter_get_arg_type), (dbus_message_iter_get_string),
3554 (dbus_message_iter_get_byte_array),
3555 (dbus_message_iter_get_string_array), (message_iter_test),
3556 (check_message_handling), (_dbus_message_test):
3557 * dbus/dbus-message.h:
3558 * test/bus-test.c: (main):
3559 Change fields to arguments in messages, so that they won't be
3560 confused with header fields.
3562 * glib/test-dbus-glib.c: (main):
3563 Remove append_fields from hello message.
3565 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3567 * dbus/dbus-errors.c:
3568 * dbus/dbus-message.c:
3569 * dbus/dbus-string.c:
3570 Documentation fixes.
3572 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3574 * glib/dbus-gmain.c: (timeout_handler), (add_timeout),
3576 Implement support for timeouts in dbus-glib.
3578 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3580 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
3581 * dbus/dbus-message.c: (process_test_subdir):
3582 * test/break-loader.c: (find_breaks_based_on):
3583 Plug some memory leaks.
3585 2003-02-13 Richard Hult <rhult@codefactory.se>
3587 * bus/main.c: Fix build.
3589 * dbus/dbus-errors.h:
3590 * dbus/dbus-errors.c: Fix copyright for Anders.
3592 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3597 * bus/connection.c: (bus_connection_foreach):
3600 * bus/desktop-file.c: (grow_lines_in_section), (grow_sections),
3601 (unescape_string), (new_section), (parse_section_start),
3602 (parse_key_value), (report_error), (bus_desktop_file_load),
3603 (bus_desktop_file_get_string):
3604 * bus/desktop-file.h:
3605 Use DBusError for error reporting.
3607 * bus/dispatch.c: (send_one_message),
3608 (bus_dispatch_message_handler):
3609 * bus/driver.c: (bus_driver_send_service_deleted),
3610 (bus_driver_send_service_created), (bus_driver_send_service_lost),
3611 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
3612 (bus_driver_send_welcome_message),
3613 (bus_driver_handle_list_services),
3614 (bus_driver_handle_acquire_service),
3615 (bus_driver_handle_service_exists):
3616 * bus/loop.c: (bus_loop_run):
3618 Use BUS_HANDLE_OOM instead of _DBUS_HANDLE_OOM.
3620 * bus/utils.c: (bus_wait_for_memory):
3622 New files with general utility functions.
3624 * dbus/dbus-internals.h:
3625 Remove _DBUS_HANDLE_OOM.
3627 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3629 * dbus/dbus-errors.c: (dbus_result_to_string), (dbus_error_init),
3630 (dbus_error_free), (dbus_set_error_const), (dbus_set_error):
3631 * dbus/dbus-errors.h:
3632 Add DBusError structure.
3634 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3636 * test/data/valid-messages/standard-acquire-service.message:
3637 * test/data/valid-messages/standard-hello.message:
3638 * test/data/valid-messages/standard-list-services.message:
3639 * test/data/valid-messages/standard-service-exists.message:
3640 Add some standard messages.
3642 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3644 * bus/driver.c: (bus_driver_send_welcome_message),
3645 (bus_driver_handle_list_services),
3646 (bus_driver_handle_acquire_service),
3647 (bus_driver_handle_service_exists), (bus_driver_handle_message):
3648 Update for API changes in libdbus.
3650 * dbus/dbus-message.c: (dbus_message_new_reply):
3651 * dbus/dbus-message.h:
3652 Remove the name argument. The spec states that replies shouldn't
3655 2003-02-13 Anders Carlsson <andersca@codefactory.se>
3657 * bus/desktop-file.c: (parse_section_start), (parse_key_value),
3658 (report_error), (bus_desktop_file_load), (lookup_section),
3659 (lookup_line), (bus_desktop_file_get_raw),
3660 (bus_desktop_file_get_string):
3661 * bus/desktop-file.h:
3662 Some fixes, and new functions for getting a key value from a section.
3664 2003-02-13 Havoc Pennington <hp@pobox.com>
3666 * test/data/auth/fail-after-n-attempts.auth-script: new test
3668 * dbus/dbus-auth.c (send_rejected): shutdown_mech() when we
3671 2003-02-13 Havoc Pennington <hp@pobox.com>
3673 * dbus/dbus-auth.c (handle_server_data_external_mech): args to
3674 dbus_credentials_match were backward
3676 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support
3677 NO_CREDENTIALS and ROOT_CREDENTIALS
3679 * dbus/dbus-auth.c (_dbus_auth_do_work): move get_state() routine
3680 into here. Never process more commands after we've reached an
3681 end state; store further data as unused bytes.
3683 * test/data/auth/*: add more auth tests
3685 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support EXPECT
3686 command to match exact string and EXPECT_UNUSED to match unused
3689 * test/Makefile.am (dist-hook): fix to dist all the test stuff
3691 2003-02-12 Havoc Pennington <hp@pobox.com>
3693 * dbus/dbus-string.c (_dbus_string_pop_line): fix to also strip
3694 \r off of popped lines
3696 * dbus/dbus-auth.c (_dbus_auth_test): write code to run auth
3699 * dbus/dbus-auth-script.c (_dbus_auth_script_run): when doing a
3702 2003-02-12 Havoc Pennington <hp@pobox.com>
3704 * dbus/Makefile.am: remove break-loader from the build, since it
3707 * configure.in: add --enable-gcov to turn on coverage profiling
3708 flags and disable optimization
3710 2003-02-10 Havoc Pennington <hp@pobox.com>
3712 * dbus/dbus-auth-script.c, dbus/dbus-auth-script.h: sync
3713 initial cut at test framework for DBusAuth from laptop.
3714 Doesn't quite work yet but it compiles and I need to get
3715 it off the 266mhz laptop. ;-)
3717 * dbus/dbus-server-debug.c (_dbus_server_debug_accept_transport):
3718 fix a memleak in error case
3720 2003-02-12 Anders Carlsson <andersca@codefactory.se>
3723 * bus/desktop-file.c:
3724 * bus/desktop-file.h:
3725 Add a desktop file parser.
3727 2003-02-11 Zack Rusin <zack@kde.org>
3729 * qt/message.[h|cpp]: sample implementation
3730 of the KDE wrapper for DBusMessage
3732 2003-02-09 Zack Rusin <zack@kde.org>
3734 * test/bus-test.c: make_it_compile
3735 * doc/dbus-specification.sgml: minimal semantic fix
3737 2003-02-06 Anders Carlsson <andersca@codefactory.se>
3743 2003-02-06 Anders Carlsson <andersca@codefactory.se>
3746 * dbus/dbus-break-loader.c:
3748 * test/break-loader.c:
3749 Move dbus-break-loader to test/ and rename it to break-loader.
3751 2003-02-02 Havoc Pennington <hp@pobox.com>
3753 * dbus/dbus-keyring.c, dbus/dbus-keyring.h: template files
3754 for code to manage cookies in your home directory
3756 * dbus/dbus-sysdeps.c (_dbus_generate_random_bytes): new function
3758 * dbus/dbus-auth.c (get_state): impose a maximum number of tries
3759 to authenticate, then disconnect the client.
3761 2003-02-03 Alexander Larsson <alexl@redhat.com>
3763 * dbus/dbus-message.c (dbus_message_append_fields):
3766 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3768 * doc/dbus-specification.sgml:
3769 Update address format section.
3771 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3774 * test/bus-test.c: (get_time), (add_timeout), (remove_timeout),
3775 (message_handler), (new_connection_callback), (loop_quit),
3779 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3781 * bus/driver.c: (bus_driver_handle_service_exists):
3782 Simplify the code a bit.
3784 * dbus/dbus-bus.c: (dbus_bus_service_exists):
3787 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3790 Add libdbus-daemon.la and link to it.
3792 2003-02-01 James Willcox <jwillcox@gnome.org>
3794 * bus/driver.c: (bus_driver_handle_own_service):
3795 Actually include the service reply code in the message.
3797 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3799 * bus/driver.c: (bus_driver_handle_service_exists):
3800 Don't unref the incoming message.
3802 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3804 * dbus/dbus.h: Add dbus-address.h and dbus-bus.h
3806 2003-02-02 Anders Carlsson <andersca@codefactory.se>
3808 * dbus/dbus-server.c: (dbus_server_listen):
3809 * dbus/dbus-transport.c: (_dbus_transport_open):
3810 ifdef out the calls to the debug transport and server.
3812 2003-02-02 Alexander Larsson <alexl@redhat.com>
3814 * dbus/dbus-watch.c (dbus_watch_get_flags):
3815 Add note in the docs that ERROR or HANGUP won't be returned
3816 and are assumed always on.
3818 * glib/dbus-gmain.c (add_watch):
3819 Always add IO_ERR | IO_HUP
3821 * dbus/dbus-message.h:
3822 Add semicolon after dbus_message_iter_get_string_array().
3823 Makes qt code build again
3825 2003-02-01 Anders Carlsson <andersca@codefactory.se>
3827 * bus/driver.c: (create_unique_client_name),
3828 (bus_driver_handle_hello):
3829 Don't take a name, just use a numeric id to identify
3833 * dbus/dbus-bus.c: (dbus_bus_register_client),
3834 (dbus_bus_acquire_service), (dbus_bus_service_exists):
3836 Add new convenience functions for communicating with the bus.
3838 * dbus/dbus-message.h:
3840 * dbus/dbus-protocol.h:
3843 2003-02-01 Alexander Larsson <alexl@redhat.com>
3845 * dbus/dbus-message.c (dbus_message_append_fields):
3846 Add some more doc comments.
3848 2003-02-01 Havoc Pennington <hp@pobox.com>
3850 * dbus/dbus-break-loader.c (randomly_modify_length): change
3851 a 4-byte value in the message as if it were a length
3853 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): don't set
3854 execute bit on saved files
3856 2003-02-01 Havoc Pennington <hp@pobox.com>
3858 * dbus/dbus-break-loader.c (main): new program to find messages
3859 that break the loader.
3861 * dbus/dbus-sysdeps.c (_dbus_string_append_uint): new function
3862 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): new function
3864 * dbus/dbus-string.c (_dbus_string_set_byte): new
3866 2003-01-31 Havoc Pennington <hp@pobox.com>
3868 * dbus/dbus-message.c: refactor the test code to be more general,
3869 in preparation for writing a "randomly permute test cases to
3870 try to break the loader" program.
3872 2003-01-31 Havoc Pennington <hp@pobox.com>
3874 * doc/dbus-specification.sgml: work on the specification
3876 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): check
3877 the protocol version of the message.
3879 * dbus/dbus-protocol.h: drop special _REPLY names, the spec
3880 no longer specifies that.
3881 (DBUS_SERVICE_REPLY_SERVICE_EXISTS): fix flags (1/2/4/8 not
3884 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos): add missing
3885 "break" for DBUS_TYPE_NIL, remove @todo
3887 2003-01-31 Havoc Pennington <hp@pobox.com>
3889 * dbus/dbus-message.c (dbus_message_set_is_error_reply): rename
3890 just set_is_error/get_is_error as this is a commonly-used
3891 function, and write docs.
3893 2003-01-31 Anders Carlsson <andersca@codefactory.se>
3895 * dbus/dbus-address.c: (dbus_address_entry_free):
3896 Free key and value lists.
3898 * dbus/dbus-internals.c: (_dbus_type_to_string):
3899 Add the types we didn't have.
3901 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
3902 (_dbus_marshal_validate_arg):
3905 * dbus/dbus-message.c: (dbus_message_set_sender):
3906 Remove todo about being able to set sender to NULL.
3908 (dbus_message_set_is_error_reply),
3909 (dbus_message_get_is_error_reply):
3910 * dbus/dbus-message.h:
3913 * dbus/dbus-protocol.h:
3914 Add error reply flag.
3916 * test/data/valid-messages/opposite-endian.message:
3917 Add NIL type to test.
3919 2003-01-31 Havoc Pennington <hp@pobox.com>
3921 * doc/dbus-specification.sgml: fully specify the header. Add
3922 flags and major protocol version, and change header/body len to
3925 * dbus/dbus-message-builder.c (append_saved_length): append length
3928 * dbus/dbus-message.c (dbus_message_create_header): change header
3929 length and body length to unsigned. Add the new fields from the
3931 (_dbus_message_loader_return_buffer): unsigned header/body len
3933 2003-01-30 Havoc Pennington <hp@pobox.com>
3935 * dbus/dbus-auth.c: rework to use only REJECTED, no
3938 * doc/dbus-sasl-profile.txt: drop MECHANISMS and just
3939 use REJECTED, suggested by Mark McLoughlin
3941 2003-01-30 Havoc Pennington <hp@pobox.com>
3943 * dbus/dbus-server.c (dbus_server_listen): @todo about how we need
3944 a better way to report errors here. e.g. "unix address lacks
3945 path" or something. also "no such file" when the path doesn't
3948 * dbus/dbus-address.c (dbus_address_entries_free): add @todo about
3950 (dbus_parse_address): add @todo about documenting address format,
3951 and allowing , and ; to be escaped
3953 2003-01-30 Anders Carlsson <andersca@codefactory.se>
3956 Add dbus-address.[ch]
3958 * dbus/dbus-address.c: (dbus_address_entry_free),
3959 (dbus_address_entries_free), (create_entry),
3960 (dbus_address_entry_get_method), (dbus_address_entry_get_value),
3961 (dbus_parse_address), (_dbus_address_test):
3962 * dbus/dbus-address.h:
3963 New files for dealing with address parsing.
3965 * dbus/dbus-connection.c:
3966 Document timeout functions.
3968 * dbus/dbus-message.c:
3969 Document dbus_message_new_from_message.
3971 * dbus/dbus-server-debug.c:
3974 * dbus/dbus-server.c: (dbus_server_listen):
3975 Parse address and use correct server implementation.
3977 * dbus/dbus-string.c: (_dbus_string_find_to), (_dbus_string_test):
3978 * dbus/dbus-string.h:
3979 New function with test.
3981 * dbus/dbus-test.c: (dbus_internal_symbol_do_not_use_run_tests):
3985 * dbus/dbus-transport-debug.c:
3988 * dbus/dbus-transport.c: (_dbus_transport_open):
3989 Parse address and use correct transport implementation.
3991 2003-01-30 Havoc Pennington <hp@pobox.com>
3993 * dbus/dbus-message.c: use message->byte_order instead of
3994 DBUS_COMPILER_BYTE_ORDER throughout.
3995 (dbus_message_create_header): pad header to align the
3996 start of the body of the message to 8-byte boundary
3998 * dbus/dbus-marshal.h: make all the demarshalers take const
3999 DBusString arguments.
4001 * dbus/dbus-message.c (_dbus_message_loader_return_buffer):
4002 validate message args here, so we don't have to do slow validation
4003 later, and so we catch bad messages as they are incoming. Also add
4004 better checks on header_len and body_len. Also fill in
4007 * dbus/dbus-string.c (_dbus_string_validate_utf8): new (not
4008 implemented properly)
4009 (_dbus_string_validate_nul): new function to check all-nul
4011 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): rename
4012 get_arg_end_pos and remove all validation
4013 (_dbus_marshal_validate_arg): actually do validation here.
4015 2003-01-29 Havoc Pennington <hp@pobox.com>
4017 * dbus/dbus-message.c (check_message_handling): fix assertion
4018 failure on set_client_serial
4020 2003-01-28 Havoc Pennington <hp@pobox.com>
4022 * dbus/dbus-server-debug.c: Add doc section comments
4024 * dbus/dbus-transport-debug.c: add doc section comments
4026 2003-01-28 Havoc Pennington <hp@redhat.com>
4028 * dbus/dbus-string.c (_dbus_string_base64_decode): append bytes in
4029 the reverse order from how I had it
4030 (_dbus_string_base64_encode): reverse encoding order. I was
4031 basically byteswapping everything during encoding.
4033 2003-01-28 Anders Carlsson <andersca@codefactory.se>
4035 * dbus/dbus-connection-internal.h:
4036 * dbus/dbus-connection.c: (_dbus_connection_add_timeout),
4037 (_dbus_connection_remove_timeout):
4038 Add functions for adding and removing timeouts.
4040 * dbus/dbus-message.c: (dbus_message_new_from_message):
4041 Add new function that takes a message and creates an exact
4042 copy of it, but with the refcount set to 1.
4043 (check_message_handling):
4046 * dbus/dbus-server-protected.h:
4047 * dbus/dbus-server.c: (_dbus_server_init_base),
4048 (_dbus_server_finalize_base), (_dbus_server_add_timeout),
4049 (dbus_server_set_timeout_functions):
4050 (_dbus_server_remove_timeout):
4051 New functions so that a server can add and remove timeouts.
4053 (dbus_server_listen):
4054 Add commented out call to dbus_server_debug_new.
4056 * dbus/dbus-timeout.c: (_dbus_timeout_new):
4057 Actually set the handler, doh.
4059 * dbus/dbus-transport.c: (_dbus_transport_open):
4060 Add commented out call to dbus_transport_debug_client_new.
4063 Add dbus-transport-debug.[ch] and dbus-server-debug.[ch]
4065 2003-01-28 Havoc Pennington <hp@pobox.com>
4067 * dbus/dbus-message.c (check_message_handling): function to check
4068 on the loaded message, iterates over it etc.
4070 2003-01-28 Havoc Pennington <hp@pobox.com>
4072 * test/Makefile.am (dist-hook): fix make distdir
4074 * dbus/Makefile.am (TESTS_ENVIRONMENT): fix make check
4076 2003-01-27 Havoc Pennington <hp@pobox.com>
4078 * dbus/dbus-mempool.c (time_for_size): replace printf with
4081 * dbus/dbus-message-builder.c (_dbus_message_data_load): allow
4082 empty lines; fix the SAVE_LENGTH stuff to be
4083 START_LENGTH/END_LENGTH so it actually works; couple other
4086 * test/Makefile.am (dist-hook): add dist-hook for .message files
4088 * dbus/dbus-string.c (DBUS_STRING_COPY_PREAMBLE): source of a copy
4089 can be constant or locked.
4090 (_dbus_string_free): allow freeing a const string as
4093 * dbus/dbus-sysdeps.c (_dbus_concat_dir_and_file): utility
4095 * dbus/dbus-test-main.c (main): take an argument which is the
4096 directory containing test data
4098 * dbus/dbus-message.c (_dbus_message_test): pass a test_data_dir
4099 argument to this and load all the messages in test/data/
4100 checking that they can be loaded or not loaded as appropriate.
4102 2003-01-27 Anders Carlsson <andersca@codefactory.se>
4104 * bus/dispatch.c: (bus_dispatch_message_handler):
4105 Dispatch messages sent to services.
4107 * bus/driver.c: (bus_driver_send_service_deleted),
4108 (bus_driver_send_service_created), (bus_driver_send_service_lost),
4109 (bus_driver_send_service_acquired):
4110 Add helper functions for sending service related messages.
4112 (bus_driver_send_welcome_message):
4113 Send HELLO_REPLY instead of WELCOME.
4115 (bus_driver_handle_list_services):
4116 Send LIST_SERVICES_REPLY instead of SERVICES.
4118 (bus_driver_handle_own_service),
4119 (bus_driver_handle_service_exists):
4120 New message handlers.
4122 (bus_driver_handle_message):
4123 Invoke new message handlers.
4125 (bus_driver_remove_connection):
4126 Don't remove any services here since that's done automatically
4127 by bus_service_remove_owner now.
4130 New function signatures.
4132 * bus/services.c: (bus_service_add_owner):
4133 Send ServiceAcquired message if we're the only primary owner.
4135 (bus_service_remove_owner):
4136 Send ServiceAcquired/ServiceLost messages.
4138 (bus_service_set_prohibit_replacement),
4139 (bus_service_get_prohibit_replacement):
4140 Functions for setting prohibit replacement.
4142 (bus_service_has_owner):
4143 New function that checks if a connection is in the owner queue of
4147 Add new function signatures.
4149 * dbus/dbus-list.c: (_dbus_list_test):
4150 Add tests for _dbus_list_remove_last and traversing the list backwards.
4153 Fix a typo in _dbus_list_get_prev_link, if we're at the first element we can't
4154 go any further, so return NULL then.
4156 * dbus/dbus-protocol.h:
4157 Add new messages, service flags and service replies.
4159 2003-01-26 Havoc Pennington <hp@pobox.com>
4161 * dbus/dbus-message-builder.c: implement, completely untested.
4163 * test/data/*: add data to be used in testing.
4164 ".message" files are our simple loadable text format.
4165 ".message-raw" will be binary dumps of messages.
4167 * dbus/dbus-string.c (_dbus_string_starts_with_c_str): new
4169 2003-01-26 Havoc Pennington <hp@pobox.com>
4171 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): new function
4173 * dbus/dbus-errors.c (dbus_result_to_string): add
4176 * dbus/dbus-message-builder.c: new file, will contain code to load
4177 up messages from files. Not implemented yet.
4179 2003-01-26 Havoc Pennington <hp@pobox.com>
4181 * dbus/dbus-message.c (dbus_message_set_sender): support deleting
4182 the sender by setting to NULL
4184 2003-01-26 Havoc Pennington <hp@pobox.com>
4186 The unit tests pass, but otherwise untested. If it breaks, the
4187 tests should have been better. ;-)
4189 * bus/driver.c (bus_driver_handle_hello): return if we disconnect
4192 * dbus/dbus-message.c: redo everything so we maintain
4193 message->header as the only copy of the various fields.
4194 This avoids the possibility of out-of-memory in some cases,
4195 for example dbus_message_lock() can't run out of memory anymore,
4196 and avoids extra copying. Figured I may as well go ahead and do
4197 this since it was busted for dbus_message_lock to not return
4198 failure on OOM, and dbus_message_write_header was totally
4199 unchecked for OOM. Also fixed some random other bugs.
4201 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): verify
4202 that strings are nul-terminated. Also, end_pos can be equal
4203 to string length just not greater than, I think.
4204 (_dbus_marshal_set_int32): new function
4205 (_dbus_marshal_set_uint32): new function
4206 (_dbus_marshal_set_string): new function
4208 * dbus/dbus-connection.c (_dbus_connection_new_for_transport): fix
4209 a warning, init timeout_list to NULL
4210 (dbus_connection_send_message): don't use uninitialized variable
4213 * dbus/dbus-string.c (_dbus_string_replace_len): new function
4215 2003-01-26 Anders Carlsson <andersca@codefactory.se>
4217 * bus/driver.c: (bus_driver_handle_hello),
4218 (bus_driver_send_welcome_message):
4221 2003-01-26 Anders Carlsson <andersca@codefactory.se>
4223 * dbus/dbus-auth.c: (process_auth), (_dbus_auth_unref):
4224 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
4225 (dbus_connection_unref):
4226 * dbus/dbus-marshal.c: (_dbus_marshal_test):
4227 * dbus/dbus-message.c: (dbus_message_unref),
4230 (dbus_message_get_fields):
4231 Remove debugging printout.
4233 (_dbus_message_loader_return_buffer):
4234 Don't store the header string.
4236 (_dbus_message_test):
4239 2003-01-26 Richard Hult <rhult@codefactory.se>
4241 * glib/dbus-gmain.c (dbus_connection_dispatch): Traverse a copy of
4242 the file descriptor list, since it can change under us.
4244 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4246 * glib/dbus-gmain.c: (dbus_connection_prepare),
4247 (dbus_connection_check), (dbus_connection_dispatch), (add_watch),
4248 (remove_watch), (dbus_connection_hookup_with_g_main):
4249 Rewrite the glib handling to use its own GSource instead of a
4250 GIOChannel so we can catch messages put in the queue while waiting
4253 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4256 * bus/connection.c: (connection_disconnect_handler),
4257 (connection_watch_callback), (bus_connection_setup):
4258 * bus/dispatch.c: (send_one_message),
4259 (bus_dispatch_broadcast_message), (bus_dispatch_message_handler),
4260 (bus_dispatch_add_connection), (bus_dispatch_remove_connection):
4262 * bus/driver.c: (bus_driver_send_service_deleted),
4263 (bus_driver_send_service_created), (bus_driver_handle_hello),
4264 (bus_driver_send_welcome_message),
4265 (bus_driver_handle_list_services), (bus_driver_remove_connection),
4266 (bus_driver_handle_message):
4268 Refactor code, put the message dispatching in its own file. Use
4269 _DBUS_HANDLE_OOM. Also send ServiceDeleted messages when a client
4272 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4274 * dbus/dbus-internals.h:
4275 Add _DBUS_HANDLE_OOM macro, it doesn't do anything currently.
4277 * dbus/dbus-message.c: (dbus_message_get_sender):
4278 * dbus/dbus-message.h:
4279 Implement dbus_message_get_sender.
4281 * dbus/dbus-protocol.h:
4282 Add message and service defines.
4284 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4286 * dbus/dbus-connection.c: (dbus_connection_send_message):
4287 * dbus/dbus-message-internal.h:
4288 * dbus/dbus-message.c: (_dbus_message_get_client_serial),
4289 (dbus_message_write_header):
4290 Remove _dbus_messag_unlock and don't set the client serial on a
4291 message if one already exists.
4293 2003-01-24 Havoc Pennington <hp@pobox.com>
4295 * dbus/dbus-list.c (alloc_link): put a thread lock on the global
4298 * bus/driver.c (bus_driver_handle_list_services): fix a leak
4301 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4303 * dbus/dbus-list.c: (alloc_link), (free_link):
4304 Use a memory pool for the links.
4306 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4308 * bus/connection.c: (bus_connection_foreach):
4310 Add new bus_connection_foreach function.
4312 * bus/driver.c: (send_one_message), (bus_driver_broadcast_message):
4313 Add function that broadcasts a message to all clients.
4315 (bus_driver_send_service_created), (bus_driver_handle_hello),
4316 (bus_driver_send_welcome_message),
4317 (bus_driver_handle_list_services), (bus_driver_message_handler):
4318 Implement functions that take care of listing services, and notifying
4319 clients when new services are created.
4321 * bus/services.c: (bus_services_list):
4323 Add new function that returns an array of strings with the currently
4324 registered services.
4327 * glib/dbus-gmain.c:
4328 Update copyright year.
4330 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4332 * dbus/dbus-connection.c: (dbus_connection_send_message):
4333 Unlock the message in case it was sent earlier.
4335 (dbus_connection_send_message_with_reply_and_block):
4336 Remove the reply message from the list.
4338 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
4339 Set array_len and new_pos correctly.
4341 (_dbus_marshal_test):
4342 Remove debug output.
4344 * dbus/dbus-message-internal.h:
4345 * dbus/dbus-message.c: (_dbus_message_get_reply_serial):
4346 New function that returns the reply serial.
4348 (_dbus_message_unlock):
4349 New function that unlocks a message and resets its header.
4351 (dbus_message_append_string_array),
4352 (dbus_message_get_fields_valist),
4353 (dbus_message_iter_get_field_type),
4354 (dbus_message_iter_get_string_array),
4355 (dbus_message_get_fields),
4356 (dbus_message_append_fields_valist):
4357 Handle string arrays.
4359 (dbus_message_set_sender):
4360 Make this function public since the bus daemon needs it.
4362 (decode_header_data):
4363 Set the reply serial to -1 initially.
4365 * dbus/dbus-message.h:
4366 Add dbus_message_set_sender.
4368 2003-01-24 Havoc Pennington <hp@pobox.com>
4370 * doc/dbus-specification.sgml: add some stuff
4372 2003-01-22 Havoc Pennington <hp@pobox.com>
4374 * doc/dbus-specification.sgml: Start to document the protocol.
4376 2003-01-22 Havoc Pennington <hp@pobox.com>
4378 * dbus/dbus-connection.c
4379 (dbus_connection_send_message_with_reply_and_block): add some @todo
4381 * bus/driver.c (bus_driver_add_connection): add a FIXME about memleak
4383 2003-01-21 Havoc Pennington <hp@pobox.com>
4385 (patch untested because can't compile)
4387 * bus/driver.c (create_unique_client_name): make this function
4388 never recycle client names. Also, caller should initialize
4391 * dbus/dbus-sysdeps.c (_dbus_get_current_time): new function
4393 2003-01-21 Anders Carlsson <andersca@codefactory.se>
4395 * dbus/dbus-marshal.c: (_dbus_marshal_double),
4396 (_dbus_marshal_int32), (_dbus_marshal_uint32),
4397 (_dbus_marshal_int32_array), (_dbus_marshal_uint32_array),
4398 (_dbus_marshal_double_array), (_dbus_marshal_string_array),
4399 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
4400 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
4401 (_dbus_marshal_get_field_end_pos), (_dbus_marshal_test):
4402 * dbus/dbus-marshal.h:
4403 * dbus/dbus-protocol.h:
4404 Add support for marshalling and demarshalling integer, double
4407 2003-01-21 Anders Carlsson <andersca@codefactory.se>
4412 * bus/connection.c: (connection_disconnect_handler):
4413 Remove the connection from the bus driver's list.
4415 (connection_watch_callback): Dispatch messages.
4417 (free_connection_data): Free connection name.
4419 (bus_connection_setup): Add connection to the bus driver's list.
4420 (bus_connection_remove_owned_service):
4421 (bus_connection_set_name), (bus_connection_get_name):
4422 Add functions for setting and getting the connection's name.
4425 Add function headers.
4427 * bus/driver.c: (create_unique_client_name),
4428 (bus_driver_handle_hello_message),
4429 (bus_driver_send_welcome_message), (bus_driver_message_handler),
4430 (bus_driver_add_connection), (bus_driver_remove_connection):
4433 * bus/services.c: (bus_service_free):
4435 New file that handles communication and registreation with the bus
4438 2003-01-21 Anders Carlsson <andersca@codefactory.se>
4440 * dbus/dbus-connection.c: (dbus_connection_send_message):
4441 Add a new client_serial parameter.
4443 (dbus_connection_send_message_with_reply):
4444 Remove a @todo since we've implemented the blocking function.
4446 (dbus_connection_send_message_with_reply_and_block):
4447 New function that sends a message and waits for a reply and
4448 then returns the reply.
4450 * dbus/dbus-connection.h:
4453 * dbus/dbus-errors.c: (dbus_result_to_string):
4454 * dbus/dbus-errors.h:
4455 Add new DBUS_RESULT.
4457 * dbus/dbus-message-internal.h:
4458 * dbus/dbus-message.c: (_dbus_message_get_reply_serial),
4459 (_dbus_message_set_sender), (dbus_message_write_header),
4460 (dbus_message_new_reply), (decode_header_data),
4461 (_dbus_message_loader_return_buffer), (_dbus_message_test):
4462 * dbus/dbus-message.h:
4463 Add new functions that set the reply serial and sender.
4464 Also marshal and demarshal them correctly and add test.
4466 * dbus/dbus-protocol.h:
4467 Add new DBUS_MESSAGE_TYPE_SENDER.
4470 * glib/dbus-gmain.c: (watch_callback), (free_callback_data),
4471 (add_watch), (remove_watch), (add_timeout), (remove_timeout),
4472 (dbus_connection_hookup_with_g_main):
4473 * glib/test-dbus-glib.c: (main):
4474 Rewrite to use GIOChannel and remove the GSource crack.
4476 * test/echo-client.c: (main):
4477 * test/watch.c: (check_messages):
4478 Update for changed APIs
4480 2003-01-19 Anders Carlsson <andersca@codefactory.se>
4482 * dbus/Makefile.am: Add dbus-timeout.[cħ]
4484 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport):
4485 Create a DBusTimeoutList.
4486 (dbus_connection_set_timeout_functions): Add new function to
4487 set timeout callbacks
4489 * dbus/dbus-connection.h: Add public DBusTimeout API.
4491 * dbus/dbus-message.c: (dbus_message_get_service):
4492 * dbus/dbus-message.h: New function.
4494 * dbus/dbus-server.c: Fix small doc typo.
4496 * dbus/dbus-timeout.[ch]: New files for mainloop timeouts.
4498 2003-01-19 Anders Carlsson <andersca@codefactory.se>
4500 * dbus/dbus-string.c (_dbus_string_move_len): Don't delete all
4501 of the string, just as long as specified.
4503 2003-01-19 Havoc Pennington <hp@pobox.com>
4505 * dbus/dbus-connection.c (dbus_connection_get_is_authenticated):
4508 * dbus/dbus-server.c (dbus_server_set_max_connections)
4509 (dbus_server_get_max_connections, dbus_server_get_n_connections):
4510 keep track of current number of connections, and add API for
4511 setting a max (but haven't implemented enforcing the max yet)
4513 2003-01-18 Havoc Pennington <hp@pobox.com>
4515 * dbus/dbus-transport-unix.c (unix_do_iteration): only do the
4516 reading/writing if read_watch != NULL or write_watch != NULL.
4518 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): fix
4519 the message loader code to actually load message->header and
4520 message->body into the newly-created message.
4522 * dbus/dbus-transport-unix.c (check_write_watch): fix a mem leak
4525 * dbus/dbus-connection.c (dbus_connection_set_max_message_size)
4526 (dbus_connection_get_max_message_size)
4527 (dbus_connection_set_max_live_messages_size)
4528 (dbus_connection_get_max_live_messages_size): implement some
4529 resource limitation functions
4531 * dbus/dbus-resources.c: new file implementing some of the
4532 resource limits stuff
4534 * dbus/dbus-message.c (dbus_message_iter_get_byte_array): add
4535 missing docs, add @todo to handle OOM etc.
4537 * dbus/dbus-marshal.c (_dbus_demarshal_byte_array): add missing
4540 2003-01-18 Havoc Pennington <hp@pobox.com>
4542 * dbus/dbus-connection.c (dbus_connection_unref): disconnect the
4543 connection if it hasn't been already.
4545 * dbus/dbus-connection.h: kill off the idea of an ErrorFunction,
4546 replace with DisconnectFunction.
4548 2003-01-18 Havoc Pennington <hp@pobox.com>
4550 Building --disable-verbose-mode --disable-asserts --disable-tests
4551 cuts the library from 112K to 45K or so
4553 * configure.in: check for varargs macro support,
4554 add --enable-verbose-mode, --enable-asserts.
4556 * dbus/dbus-internals.h (_dbus_assert): support
4558 (_dbus_verbose): support DBUS_ENABLE_VERBOSE_MODE
4560 2003-01-18 Havoc Pennington <hp@pobox.com>
4562 * dbus/dbus-test.c: include config.h so that tests actually run
4564 * dbus/dbus-string.c: add assertions that stuff is 8-byte aligned,
4565 so the failure mode when that assumption fails will be plenty
4568 2003-01-18 Havoc Pennington <hp@pobox.com>
4570 * configure.in: default --enable-tests to $USE_MAINTAINER_MODE
4572 * dbus/Makefile.am: fix it up so dubs-test-main.c is included in
4575 * test/Makefile.am: don't use special variable "TESTS" for echo-*
4576 since we don't want to use those in make check
4578 2003-01-15 Havoc Pennington <hp@redhat.com>
4584 2003-01-15 Havoc Pennington <hp@redhat.com>
4586 * test/Makefile.am: fix so that test source code ends up in the
4587 distribution on make distcheck
4589 2003-01-15 Havoc Pennington <hp@redhat.com>
4595 2003-01-15 Havoc Pennington <hp@redhat.com>
4597 * dbus/dbus-test.c (dbus_internal_symbol_do_not_use_run_tests):
4598 fix build when --disable-tests
4600 * Makefile.am (EXTRA_DIST): put HACKING in here
4602 * HACKING: document procedure for making a tarball release.
4604 2003-01-14 Anders Carlsson <andersca@codefactory.se>
4606 * bus/connection.c: (connection_error_handler),
4607 (bus_connection_setup):
4608 * bus/main.c: (main):
4609 Make sure that the DBusConnectionData struct is NULLed
4610 out to prevent a segfault.
4612 * dbus/dbus-errors.c: (dbus_result_to_string):
4613 * dbus/dbus-errors.h:
4614 * dbus/dbus-message.c: (dbus_message_get_fields),
4615 (dbus_message_get_fields_valist), (_dbus_message_test):
4616 * dbus/dbus-message.h:
4617 Make dbus_message_get_fields return a result code so we can
4618 track invalid fields as well as oom.
4620 2003-01-11 Havoc Pennington <hp@pobox.com>
4622 * configure.in: change --enable-test/--enable-ansi action-if-given
4623 to enable_foo=$enableval instead of enable_foo=yes
4625 2003-01-08 Havoc Pennington <hp@pobox.com>
4627 * dbus/dbus-string.c (_dbus_string_align_length): new function
4629 * dbus/dbus-test-main.c: move main() for test app here
4631 (dbus_internal_symbol_do_not_use_run_tests): we have to export a
4632 symbol to run tests, because dbus-test isn't in the main
4635 Code review nitpicks.
4637 * dbus/dbus-message.c (dbus_message_write_header): add newlines
4638 for people with narrow emacs ;-). Assert client_serial was filled
4639 in. Assert message->name != NULL.
4640 (dbus_message_append_fields): have "first_field_type" arg separate
4641 from va list, needed for C++ binding that also uses varargs IIRC
4642 and helps with type safety
4643 (dbus_message_new): add @todo about using DBusString to store
4644 service/name internally
4645 (dbus_message_new): don't leak ->service and ->name on OOM later
4647 (dbus_message_unref): free the service name
4648 (dbus_message_get_fields): same change to varargs
4649 i.e. first_field_type
4650 (_dbus_message_loader_return_buffer): assert that the message data
4651 is aligned (if not it's a bug in our code). Put in verbose griping
4652 about why we set corrupted = TRUE.
4653 (decode_header_data): add FIXME that char* is evil. Was going to
4654 add FIXME about evil locale-specific string.h strncmp, but just
4655 switched to wacky string-as-uint32 optimization. Move check for
4656 "no room for field name" above get_const_data_len() to avoid
4657 assertion failure in get_const_data_len if we have trailing 2
4658 bytes or the like. Check for service and name fields being
4659 provided twice. Don't leak service/name on error. Require field
4660 names to be aligned to 4 bytes.
4662 * dbus/dbus-marshal.c: move byte swap stuff to header
4663 (_dbus_pack_int32): uscore-prefix
4664 (_dbus_unpack_int32): uscore-prefix
4665 (_dbus_unpack_uint32): export
4666 (_dbus_demarshal_string): add @todo complaining about use of
4668 (_dbus_marshal_get_field_end_pos): add @todo about bad error
4669 handling allowing corrupt data to go unchecked
4671 2003-01-08 Havoc Pennington <hp@redhat.com>
4673 * dbus/dbus-transport-unix.c (unix_do_iteration): add read/write
4674 to the select() as needed for authentication. (should be using
4675 _dbus_poll() not select, but for another day)
4677 * dbus/dbus.h: include dbus/dbus-protocol.h
4679 2003-01-08 Anders Carlsson <andersca@codefactory.se>
4681 * dbus/Makefile.am (dbusinclude_HEADERS): Install
4684 2003-01-08 Anders Carlsson <andersca@codefactory.se>
4686 * dbus/dbus-internals.c: (_dbus_type_to_string):
4687 New function that returns a string describing a type.
4689 * dbus/dbus-marshal.c: (_dbus_demarshal_byte_array):
4690 * dbus/dbus-marshal.h:
4691 * dbus/dbus-message.c: (dbus_message_get_fields_valist),
4692 (dbus_message_iter_get_field_type), (dbus_message_iter_get_double),
4693 (dbus_message_iter_get_byte_array):
4694 * dbus/dbus-message.h:
4695 Add new convenience functions for appending and getting message fields.
4696 Also add demarshalling routines for byte arrays.
4698 2003-01-07 Anders Carlsson <andersca@codefactory.se>
4700 * dbus/dbus-connection-internal.h:
4701 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
4702 (_dbus_connection_get_next_client_serial),
4703 (dbus_connection_send_message):
4704 * dbus/dbus-internals.h:
4705 * dbus/dbus-marshal.c: (unpack_uint32), (dbus_unpack_int32),
4706 (dbus_pack_int32), (_dbus_marshal_double), (_dbus_marshal_int32),
4707 (_dbus_marshal_uint32), (_dbus_demarshal_double),
4708 (_dbus_demarshal_int32), (_dbus_demarshal_uint32),
4709 (_dbus_demarshal_string), (_dbus_marshal_get_field_end_pos),
4710 (_dbus_verbose_bytes), (_dbus_marshal_test):
4711 * dbus/dbus-marshal.h:
4712 * dbus/dbus-message-internal.h:
4713 * dbus/dbus-message.c: (_dbus_message_set_client_serial),
4714 (dbus_message_write_header), (_dbus_message_lock),
4715 (dbus_message_new), (dbus_message_ref), (dbus_message_unref),
4716 (dbus_message_get_name), (dbus_message_append_int32),
4717 (dbus_message_append_uint32), (dbus_message_append_double),
4718 (dbus_message_append_string), (dbus_message_append_byte_array),
4719 (dbus_message_get_fields_iter), (dbus_message_iter_ref),
4720 (dbus_message_iter_unref), (dbus_message_iter_has_next),
4721 (dbus_message_iter_next), (dbus_message_iter_get_field_type),
4722 (dbus_message_iter_get_string), (dbus_message_iter_get_int32),
4723 (dbus_message_iter_get_uint32), (dbus_message_iter_get_double),
4724 (decode_header_data), (_dbus_message_loader_return_buffer),
4725 (message_iter_test), (_dbus_message_test):
4726 * dbus/dbus-message.h:
4727 * dbus/dbus-protocol.h:
4728 * dbus/dbus-test.c: (main):
4730 * glib/test-dbus-glib.c: (message_handler), (main):
4731 * test/echo-client.c: (main):
4732 * test/watch.c: (check_messages):
4733 Make messages sendable and receivable for real.
4735 2003-01-07 Anders Carlsson <andersca@codefactory.se>
4737 * dbus/dbus-marshal.c: (_dbus_marshal_double),
4738 (_dbus_marshal_string), (_dbus_marshal_byte_array):
4739 * dbus/dbus-message.c: (dbus_message_append_int32),
4740 (dbus_message_append_uint32), (dbus_message_append_double),
4741 (dbus_message_append_string), (dbus_message_append_byte_array):
4742 Handle OOM restoration.
4744 2003-01-07 Anders Carlsson <andersca@codefactory.se>
4746 * dbus/dbus-marshal.c: (_dbus_marshal_string),
4747 (_dbus_demarshal_string), (_dbus_marshal_test):
4748 * dbus/dbus-marshal.h:
4749 * dbus/dbus-message.c: (dbus_message_get_name),
4750 Document these functions.
4752 (dbus_message_append_int32), (dbus_message_append_uint32),
4753 (dbus_message_append_double), (dbus_message_append_string),
4754 (dbus_message_append_byte_array):
4755 * dbus/dbus-message.h:
4756 Add functions for adding message fields of different types.
4758 * dbus/dbus-protocol.h:
4759 Add the different types.
4761 2003-01-05 Havoc Pennington <hp@pobox.com>
4763 * bus/connection.c: implement routines for handling connections,
4764 first thing is keeping a list of owned services on each connection
4765 and setting up watches etc.
4767 * bus/services.c: implement a mapping from service names to lists
4770 * dbus/dbus-hash.c: add DBUS_HASH_POINTER
4772 * dbus/dbus-threads.c (dbus_static_mutex_lock): add functions
4773 to use static mutexes for global data
4775 * dbus/dbus-connection.c (dbus_connection_set_data): add new
4776 collection of functions to set/get application-specific data
4777 on the DBusConnection.
4779 2003-01-04 Havoc Pennington <hp@pobox.com>
4781 * dbus/dbus-sysdeps.c (_dbus_sleep_milliseconds): new function
4782 (_dbus_poll): new function
4784 * dbus/dbus-internals.h (_DBUS_STRUCT_OFFSET): new macro
4787 * bus/loop.c: initial code for the daemon main loop
4789 2003-01-04 Havoc Pennington <hp@pobox.com>
4791 * test/watch.c (error_handler): make it safe if the error handler
4792 is called multiple times (if we s/error handler/disconnect
4793 handler/ we should just guarantee it's called only once)
4795 * dbus/dbus-transport.c (_dbus_transport_disconnect): call the
4796 error handler on disconnect (it's quite possible we should
4797 just change the error handler to a "disconnect handler," I'm
4798 not sure we have any other meaningful errors)
4800 * configure.in: check for getpwnam_r
4802 * dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
4803 dbus/dbus-auth.c: add credentials support, add EXTERNAL auth
4804 mechanism as in SASL spec, using socket credentials
4806 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): new function
4807 (_dbus_send_credentials_unix_socket): new function
4809 * dbus/dbus-sysdeps.c (_dbus_accept_unix_socket): rename just
4811 (_dbus_write): only check errno if <0 returned
4812 (_dbus_write_two): ditto
4814 2003-01-02 Anders Carlsson <andersca@codefactory.se>
4816 * dbus/dbus-marshal.c: (_dbus_marshal_utf8_string),
4817 (_dbus_marshal_byte_array), (_dbus_demarshal_utf8_string),
4818 (_dbus_marshal_test):
4819 * dbus/dbus-marshal.h:
4820 Add _dbus_marshal_byte_array and rename _dbus_marshal_string
4821 to _dbus_marshal_utf8_string. Also fix some tests.
4823 2002-12-28 Harri Porten <porten@kde.org>
4825 * configure.in: added check for C++ compiler and a very cheesy
4826 check for the Qt integration
4828 * Makefile.am (SUBDIRS): compile qt subdir if support is enabled
4830 * qt/Makefile.am: added
4832 * qt/.cvsignore: added
4834 * qt/dbus-qthread.cc, qt/dbus-qthread.cpp: renamed former to
4835 latter, added #ifdef QT_THREAD_SUPPORT guard.
4837 * dbus/Makefile.am: added missing headers for make dist
4839 2002-12-28 Kristian Rietveld <kris@gtk.org>
4841 * dbus/Makefile.am: fixup export-symbols-regex.
4843 2002-12-27 Anders Carlsson <andersca@codefactory.se>
4845 * acinclude.m4: Add this file and put the
4846 PKG_CHECK_MODULE macro in it.
4848 2002-12-27 Anders Carlsson <andersca@codefactory.se>
4850 * dbus/dbus-marshal.c: (_dbus_marshal_string),
4851 (_dbus_demarshal_double), (_dbus_demarshal_int32),
4852 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
4853 (_dbus_marshal_test):
4854 Make the demarshalling routines align the pos argument.
4855 Add string marshalling tests and fix the obvious bugs
4858 2002-12-26 Havoc Pennington <hp@pobox.com>
4860 * dbus/dbus-auth.c: fixes fixes fixes
4862 * dbus/dbus-transport-unix.c: wire up support for
4863 encoding/decoding data on the wire
4865 * dbus/dbus-auth.c (_dbus_auth_encode_data)
4866 (_dbus_auth_decode_data): append to target string
4867 instead of nuking it.
4869 2002-12-26 Havoc Pennington <hp@pobox.com>
4871 * dbus/dbus-marshal.h (DBUS_COMPILER_BYTE_ORDER): #ifdef
4872 WORDS_BIGENDIAN then compiler byte order is DBUS_BIG_ENDIAN,
4875 * dbus/dbus-marshal.c: Add macros to do int swapping in-place and
4876 avoid swap_bytes() overhead (ignoring possible assembly stuff for
4877 now). Main point is because I wanted unpack_uint32 to implement
4879 (_dbus_verbose_bytes): new function
4881 * dbus/dbus-string.c (_dbus_string_validate_ascii): new function
4883 * dbus/dbus-message.c (_dbus_message_loader_get_is_corrupted): add
4884 mechanism to handle a corrupt message stream
4885 (_dbus_message_loader_new): fix preallocation to only prealloc,
4888 * dbus/dbus-string.c (_dbus_string_skip_blank): fix this function
4889 (_dbus_string_test): enhance tests for copy/move and fix the
4892 * dbus/dbus-transport-unix.c: Hold references in more places to
4893 avoid reentrancy problems
4895 * dbus/dbus-transport.c: ditto
4897 * dbus/dbus-connection.c (dbus_connection_dispatch_message): don't
4898 leak reference count in no-message case
4900 * test/watch.c (do_mainloop): handle adding/removing watches
4901 during iteration over the watches. Also, ref the connection/server
4902 stored on a watch, so we don't try to mangle a destroyed one.
4904 * dbus/dbus-transport-unix.c (do_authentication): perform
4907 * dbus/dbus-auth.c (get_state): add a state
4908 AUTHENTICATED_WITH_UNUSED_BYTES and return it if required
4909 (_dbus_auth_get_unused_bytes): append the unused bytes
4910 to the passed in string, rather than prepend
4912 * dbus/dbus-transport.c (_dbus_transport_init_base): create
4913 the auth conversation DBusAuth
4915 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd)
4916 (_dbus_transport_new_for_domain_socket): when creating a
4917 transport, pass in whether it's a client-side or server-side
4918 transport so we know which DBusAuth to create
4920 2002-12-03 Havoc Pennington <hp@pobox.com>
4922 * dbus/dbus-transport-unix.c (unix_finalize): finalize base
4923 _after_ finalizing the derived members
4924 (unix_connection_set): unref watch if we fail to add it
4926 * dbus/dbus-connection.c (dbus_connection_unref): delete the
4927 transport first, so that the connection owned by the
4928 transport will be valid as the transport finalizes.
4930 * dbus/dbus-transport-unix.c (unix_finalize): free the write_watch
4931 if necessary, and remove watches from the connection.
4933 * dbus/dbus-watch.c (_dbus_watch_list_free): improve a comment
4935 2002-12-26 Anders Carlsson <andersca@codefactory.se>
4937 * dbus/dbus-marshal.c: (_dbus_marshal_string),
4938 (_dbus_demarshal_double), (_dbus_demarshal_int32),
4939 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
4940 (_dbus_marshal_test):
4941 * dbus/dbus-marshal.h:
4942 Add string marshal functions and have the demarshal functions
4943 return the new position.
4945 2002-12-25 Havoc Pennington <hp@pobox.com>
4947 * doc/dbus-sasl-profile.txt: docs on the authentication protocol,
4948 it is a simple protocol that just maps directly to SASL.
4950 * dbus/dbus-auth.h, dbus/dbus-auth.c: authentication protocol
4951 initial implementation, not actually used yet.
4953 * dbus/dbus-string.c (_dbus_string_find): new function
4954 (_dbus_string_equal): new function
4955 (_dbus_string_base64_encode): new function
4956 (_dbus_string_base64_decode): new function
4958 2002-12-25 Anders Carlsson <andersca@codefactory.se>
4961 * dbus/dbus-marshal.c: (swap_bytes), (_dbus_marshal_double),
4962 (_dbus_marshal_int32), (_dbus_marshal_uint32),
4963 (_dbus_demarshal_double), (_dbus_demarshal_int32),
4964 (_dbus_demarshal_uint32), (_dbus_marshal_test):
4965 * dbus/dbus-marshal.h:
4966 * dbus/dbus-protocol.h:
4967 * dbus/dbus-test.c: (main):
4969 Add un-optimized marshalling/demarshalling routines.
4971 2002-12-25 Harri Porten <porten@kde.org>
4973 * qt/dbus-qt.h: adjusted ctor and getter to KDE/Qt conventions
4975 2002-12-24 Zack Rusin <zack@kde.org>
4977 * qt/dbus-qthread.cc: adding - integrates QMutex into Dbus
4978 * qt/dbus-qt.h: skeleton with two sample implemenatation of the
4981 2002-12-24 Havoc Pennington <hp@pobox.com>
4983 * glib/dbus-gthread.c: fix include
4985 * glib/dbus-glib.h: rename DBusMessageHandler for now.
4986 I think glib API needs to change, though, as you don't
4987 want to use DBusMessageFunction, you want to use the
4988 DBusMessageHandler object. Probably
4989 dbus_connection_open_with_g_main_loop()
4990 and dbus_connection_setup_g_main_loop() or something like that
4991 (but think of better names...) that just create a connection
4992 that has watch/timeout functions etc. already set up.
4994 * dbus/dbus-connection.c
4995 (dbus_connection_send_message_with_reply): new function just to
4996 show how the message handler helps us deal with replies.
4998 * dbus/dbus-list.c (_dbus_list_remove_last): new function
5000 * dbus/dbus-string.c (_dbus_string_test): free a string that
5003 * dbus/dbus-hash.c: use memory pools for the hash entries
5004 (rebuild_table): be more paranoid about overflow, and
5005 shrink table when we can
5006 (_dbus_hash_test): reduce number of sprintfs and write
5007 valid C89. Add tests for case where we grow and then
5008 shrink the hash table.
5010 * dbus/dbus-mempool.h, dbus/dbus-mempool.c: memory pools
5012 * dbus/dbus-connection.c (dbus_connection_register_handler)
5013 (dbus_connection_unregister_handler): new functions
5015 * dbus/dbus-message.c (dbus_message_get_name): new
5017 * dbus/dbus-list.c: fix docs typo
5019 * dbus/dbus-message-handler.h, dbus/dbus-message-handler.c:
5020 an object representing a handler for messages.
5022 2002-12-16 Anders Carlsson <andersca@codefactory.se>
5025 * glib/dbus-gthread.c: (dbus_gthread_init):
5026 Don't use the gdbus prefix for public functions.
5028 2002-12-16 Anders Carlsson <andersca@codefactory.se>
5032 Add GLib checks and fixup .pc files
5036 * glib/dbus-gmain.c: (gdbus_connection_prepare),
5037 (gdbus_connection_check), (gdbus_connection_dispatch),
5038 (gdbus_add_connection_watch), (gdbus_remove_connection_watch),
5039 (dbus_connection_gsource_new):
5040 * glib/dbus-gthread.c: (dbus_gmutex_new), (dbus_gmutex_free),
5041 (dbus_gmutex_lock), (dbus_gmutex_unlock), (dbus_gthread_init):
5042 * glib/test-dbus-glib.c: (message_handler), (main):
5045 2002-12-15 Harri Porten <porten@kde.org>
5047 * autogen.sh: check for libtoolize before attempting to use it
5049 * dbus/dbus-transport-unix.c: include <sys/time.h> for timeval
5052 * .cvsignore: ignore more stamp files
5054 * dbus/dbus-watch.c (_dbus_watch_list_new): fixed doc error
5056 * test/Makefile.am: added -I$(top_srcdir) to be able to compile
5057 without make install.
5059 2002-12-15 Havoc Pennington <hp@pobox.com>
5061 * dbus/dbus-threads.c: add thread stubs that a higher library
5062 layer can fill in. e.g. the GLib wrapper might fill them in with
5063 GThread stuff. We still need to use this thread API to
5064 thread-safe-ize the library.
5066 2002-12-12 Havoc Pennington <hp@pobox.com>
5068 * dbus/dbus-transport-unix.c, dbus/dbus-server-unix.c: use the
5069 below new interfaces and include fewer system headers.
5071 * dbus/dbus-sysdeps.c (_dbus_read): new function
5072 (_dbus_write): new function
5073 (_dbus_write_two): new function
5074 (_dbus_connect_unix_socket): new function
5075 (_dbus_listen_unix_socket): new function
5077 * dbus/dbus-message-internal.h: change interfaces to use
5080 2002-12-11 Havoc Pennington <hp@pobox.com>
5082 * dbus/dbus-types.h: add dbus_unichar
5084 * dbus/dbus-internals.c (_dbus_verbose): use _dbus_getenv
5086 * dbus/dbus-connection.c (dbus_connection_send_message): return
5089 * dbus/dbus-transport.c: include dbus-watch.h
5091 * dbus/dbus-connection.c: include dbus-message-internal.h
5093 * HACKING: add file with coding guidelines stuff.
5095 * dbus/dbus-string.h, dbus/dbus-string.c: Encapsulate all string
5096 handling here, for security purposes (as in vsftpd). Not actually
5097 using this class yet.
5099 * dbus/dbus-sysdeps.h, dbus/dbus-sysdeps.c: Encapsulate all
5100 system/libc usage here, as in vsftpd, for ease of auditing (and
5101 should also simplify portability). Haven't actually moved all the
5102 system/libc usage into here yet.
5104 2002-11-25 Havoc Pennington <hp@pobox.com>
5106 * dbus/dbus-internals.c (_dbus_verbose): fix to not
5107 always print the first verbose message.
5109 2002-11-24 Havoc Pennington <hp@pobox.com>
5111 * test/echo-client.c, test/echo-server.c: cheesy test
5114 * configure.in (AC_CHECK_FUNCS): check for writev
5116 * dbus/dbus-message.c (_dbus_message_get_network_data): new
5119 * dbus/dbus-list.c (_dbus_list_foreach): new function
5121 * dbus/dbus-internals.c (_dbus_verbose): new function
5123 * dbus/dbus-server.c, dbus/dbus-server.h: public object
5124 representing a server that listens for connections.
5126 * dbus/.cvsignore: create
5128 * dbus/dbus-errors.h, dbus/dbus-errors.c:
5129 public API for reporting errors
5131 * dbus/dbus-connection.h, dbus/dbus-connection.c:
5132 public object representing a connection that
5133 sends/receives messages. (Same object used for
5134 both client and server.)
5136 * dbus/dbus-transport.h, dbus/dbus-transport.c:
5137 Basic abstraction for different kinds of stream
5138 that we might read/write messages from.
5140 2002-11-23 Havoc Pennington <hp@pobox.com>
5142 * dbus/dbus-internals.h (_DBUS_INT_MAX): add _DBUS_INT_MIN
5145 * dbus/dbus-test.c (main): add list test, and include
5146 dbus-test.h as intended
5148 * dbus/dbus-hash.c (_dbus_hash_table_remove_string)
5149 (_dbus_hash_table_remove_int): return value indicates
5150 whether the entry existed to remove
5152 * dbus/dbus-list.c: add linked list utility class,
5155 * dbus/dbus-hash.c: add TODO item about shrinking the hash bucket
5158 2002-11-23 Havoc Pennington <hp@pobox.com>
5160 * Doxyfile.in (INCLUDE_FILE_PATTERNS): expand DBUS_BEGIN_DECLS/
5161 DBUS_END_DECLS to nothing, that should fix this once and for all
5163 * Doxyfile.in (JAVADOC_AUTOBRIEF): set to YES
5165 * dbus/dbus-message.c, dbus/dbus-hash.c:
5166 add some missing @brief
5168 2002-11-23 Havoc Pennington <hp@pobox.com>
5170 * dbus/dbus-message.h: put semicolons after DEBUG_BEGIN_DECLS
5171 to avoid confusing Doxygen
5173 * dbus/dbus-hash.c: @} not }@
5175 * dbus/dbus-message.c (struct DBusMessage): split out
5178 2002-11-23 Havoc Pennington <hp@pobox.com>
5180 * configure.in: pile on more warning flags if using gcc
5182 * Doxyfile.in (EXTRACT_STATIC): set to NO, so we don't have
5183 to document static functions
5185 * configure.in: add summary to end of configure so it
5186 looks nice and attractive
5188 * dbus/dbus-hash.c: finish implementation and write unit
5191 * configure.in: add --enable-tests to enable unit tests
5193 * dbus/dbus-test.c: test program to run unit tests
5194 for all files in dbus/*, initially runs a test for
5197 * dbus/dbus-internals.h: file to hold some internal utility stuff
5199 2002-11-22 Havoc Pennington <hp@redhat.com>
5201 * dbus/dbus-hash.c: copy in Tcl hash table, not yet
5202 "ported" away from Tcl
5204 * dbus/dbus-types.h: header for types such as dbus_bool_t
5206 2002-11-22 Havoc Pennington <hp@redhat.com>
5208 * dbus/dbus.h: fixups for doc warnings
5210 * Doxyfile.in (FILE_PATTERNS): we need to scan .h to pick up
5212 (QUIET): make it quiet so we can see warnings
5214 * dbus/dbus-memory.c: teach D-BUS to allocate and free memory
5216 2002-11-22 Havoc Pennington <hp@redhat.com>
5218 * Makefile.am: include "Doxyfile" target in all-local
5220 * configure.in: generate the Doxyfile
5222 * Doxyfile.in: move Doxyfile here, so we can use
5223 configure to generate a Doxyfile with the right
5226 2002-11-22 Havoc Pennington <hp@redhat.com>
5228 * dbus/dbus-message.c: move inline docs into .c file
5230 * Doxyfile (OUTPUT_DIRECTORY): move output to doc/api
5231 so all docs are under doc/
5232 (MAN_EXTENSION): generate man pages. Use extension
5233 ".3dbus" which matches ".3qt" on my system,
5234 I guess this is OK, I don't know really.
5235 (FILE_PATTERNS): look for .c files not .h, makes sense
5238 2002-11-22 Havoc Pennington <hp@pobox.com>
5240 * Makefile.am (SUBDIRS): rename subdir "server" to "bus"
5241 because any app can be a server, and any app can be a client,
5242 the bus is a special kind of server.
5244 Thu Nov 21 23:35:31 2002 Zack Rusin <zack@kde.org>
5246 * Doxyfile : adding. Still needs Makefile rules to be generated
5247 automatically (just run "doxygen" in the toplevel dir for now to
5250 * dbus/dbus-message.h : Adding sample docs (javadoc since
5251 resembles gtk-doc a little more)
5253 * dbus/dbus.h : Adding sample docs
5255 2002-11-21 Havoc Pennington <hp@redhat.com>
5257 * dbus/Makefile.am (INCLUDES): define DBUS_COMPILATION
5258 so we can allow ourselves to include files directly,
5259 instead of having to use dbus.h
5261 * dbus/dbus.h: fill in
5263 * dbus/dbus-message.h: sketch out a sample header file.
5264 Include griping if you include it directly instead of
5267 * dbus/dbus-macros.h: new file with macros for extern "C",
5268 TRUE/FALSE, NULL, etc.
5270 * doc/file-boilerplate.c: put include guards in here
5272 2002-11-21 Havoc Pennington <hp@redhat.com>
5274 * doc/file-boilerplate.c: include both AFL and GPL boilerplate.
5276 * COPYING: include the GPL as well, and license code
5277 under both AFL and GPL.
5279 2002-11-21 Havoc Pennington <hp@redhat.com>
5281 * acconfig.h: get rid of this
5283 * autogen.sh (run_configure): add --no-configure option
5285 * configure.in: remove AC_ARG_PROGRAM to make
5286 autoconf complain less. add AC_PREREQ.
5287 add AC_DEFINE third arg.
5289 2002-11-21 Anders Carlsson <andersca@codefactory.se>
5292 Fix references so we can distcheck.
5294 2002-11-21 Havoc Pennington <hp@redhat.com>
5296 * Initial module creation