1 2006-02-11 Jim Meyering <jim@meyering.net>
5 * src/c99-to-c98.diff: New file.
6 * src/Makefile.am (EXTRA_DIST): Add c99-to-c98.diff.
8 * .x-po-check: New file, with exclusions so that `make distcheck'
10 * Makefile.am (EXTRA_DIST): Add .x-po-check.
12 rm -r must remove an empty directory, even if it is inaccessible.
13 * src/remove.c (close_preserve_errno): New function.
14 (fd_to_subdirp): Don't print a diagnostic in this function.
15 Do it from the callers instead, unless rmdir succeeds.
16 (remove_cwd_entries, remove_dir): Adjust callers.
17 * tests/rm/empty-inacc: New test for the above.
18 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
19 * NEWS: Mention this bug fix.
21 * Makefile.maint (syntax-check-rules): Automatically derive this
22 list of sc_-prefixed rule names.
24 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
26 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
27 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
28 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
29 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
30 go away? was that an accident?)
31 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
32 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
33 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
34 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
35 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
36 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
37 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
38 (author_mark_check, makefile_path_separator_check):
39 Output line numbers, to simplify navigation of Emacs *compilation*
41 (sc_prohibit_atoi_atof, sc_file_system):
42 Rework slightly so that Makefile.maint doesn't get reported as a
43 violation of its own syntax rules.
44 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
45 it at run-time (which didn't work with Bison). Fix a makefile typo,
46 caught by Makefile.maint itself: spaces where a tab should be.
47 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
48 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
49 Ignore djgpp and man subdirectories, to avoid false matches with
50 Bison and coreutils, respectively. Use sort -u to remove the
52 * gnupload: Rework slightly to avoid bogus warning from
53 sc_two_space_separator_in_usage.
55 2006-02-10 Jim Meyering <jim@meyering.net>
57 Use gzip's --rsyncable option only if it's available.
58 * Makefile.maint (gzip_rsyncable): New variable.
61 2006-02-08 Jim Meyering <jim@meyering.net>
63 * Makefile.maint (local-checks-available): Define in terms of
64 the expansion, $(syntax-check-rules), rather than the single,
65 top-level target `syntax-check', so that it's easier to exclude
66 individual rules (via $(local-checks-to-skip)).
67 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
69 2006-02-07 Jim Meyering <jim@meyering.net>
71 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
72 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
74 * tests/help-version (expected_failure_status_vdir):
75 Redirect an expected disk-full diagnostic to /dev/null.
77 2006-02-06 Jim Meyering <jim@meyering.net>
79 * src/unexpand.c (usage): Use two spaces (not one) to separate the
80 --first-only option string from its description, so help2man formats
81 the derived man page properly.
82 * src/rm.c (usage): Likewise for --no-preserve-root.
83 * src/chown.c (usage): Likewise.
84 * src/chgrp.c (usage): Likewise.
86 Add a rule to ensure that the above doesn't happen again.
87 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
88 (syntax-check-rules): Add it.
89 * .x-sc_two_space_separator_in_usage: New empty file.
90 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
92 2006-02-06 Jim Meyering <jim@meyering.net>
94 * src/cp.c (usage): Use two spaces (not one) to separate each
95 option string from its description, so help2man formats the
96 derived man page properly.
97 * src/mv.c (usage): Likewise.
98 Patch from Nicolas François in http://bugs.debian.org/351601.
100 2006-02-04 Jim Meyering <jim@meyering.net>
102 * src/copy.c (copy_internal): cp -RL would fail when encountering
103 the same directory more than once in the hierarchy beneath a single
104 command-line argument. That is legitimate, e.g. when there are
105 two or more symbolic links, each pointing to some directory that
106 would not otherwise be copied. Reported by Christophe LYON.
107 * tests/cp/cp-deref: New file. Test for today's fix.
108 * tests/cp/Makefile.am (TESTS): Add cp-deref.
109 * NEWS: Document this.
111 2006-02-03 Jim Meyering <jim@meyering.net>
113 * configure.ac: Require automake-1.9.6, not 1.8.3.
115 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
117 * src/od.c (usage): Mention that -t a ignores high order bit.
118 Documentation problem reported by Ed Avis.
120 2006-02-01 Jim Meyering <jim@meyering.net>
122 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
124 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
126 * src/head.c (main): Use a better diagnostic when someone uses a
127 trailing numeric option in an invalid way. Problem reported by
129 * src/tail.c (parse_options): Likewise.
131 2006-01-30 Jim Meyering <jim@meyering.net>
133 * man/wc.x: Include `count' keyword in man page synopsis,
134 per suggestion from http://bugs.debian.org/181585.
136 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
138 * src/df.c (show_dev): If the file system claims to have
139 more available than total blocks, report the number of used
140 blocks as being total - available (a negative number) rather
141 than as garbage. Problem reported by Toralf Foerster.
143 2006-01-24 Jim Meyering <jim@meyering.net>
145 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
146 to put a regular file in O_NONBLOCK mode fails with EPERM.
147 That happens on Linux (up to 2.6.15) when using tail -f on a file with
148 the append-only attribute. Reported by Dean Gaudet. For details,
149 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
150 * NEWS: Mention this fix.
151 * tests/tail-2/append-only: New file. Test for the above.
152 * tests/tail-2/Makefile.am (TESTS): Add append-only.
153 * tests/Makefile.am (check-root): Add tail-2/append-only
155 2006-01-21 Jim Meyering <jim@meyering.net>
157 * NEWS: Mention fts-related improvements and bug fixes.
159 2006-01-19 Jim Meyering <jim@meyering.net>
161 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
162 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
164 2006-01-18 Jim Meyering <jim@meyering.net>
166 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
168 2006-01-17 Jim Meyering <jim@meyering.net>
170 Now that fts no longer changes the current working directory, adjust
171 its clients accordingly -- note that du.c uses fts but doesn't need
172 any adjustment, since it doesn't operate on the actual files,
173 but rather just uses the stat buffers provided by fts.
175 * src/chown-core.c: Include "openat.h".
176 Don't include "lchown.h".
177 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
178 calling openat, lchownat, chownat, rather than open, lchown, chown.
180 * src/chmod.c: Include "openat.h".
181 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
183 * tests/du/long-from-unreadable: New test, to exercise one small
186 2006-01-13 Jim Meyering <jim@meyering.net>
188 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
189 addition of new directories under tests/.
191 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
194 2006-01-12 Jim Meyering <jim@meyering.net>
196 * tests/du/long-sloop: Adjust not to hard-code the expected
197 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
198 from that of GNU libc. Reported by Paul Eggert.
200 * tests/du/long-sloop: Create file at end of symlink chain.
202 * tests/misc/test: New file, with a test for one of the
203 bugs fixed by yesterday's test.c changes.
204 * tests/misc/Makefile.am (TESTS): Add test.
206 2006-01-11 Jim Meyering <jim@meyering.net>
208 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
209 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
210 a very long sequence of symbolic links (not necessarily a loop).
211 * tests/du/Makefile.am (TESTS): Add long-sloop.
213 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
215 * src/test.c (test_syntax_error): Append a newline. All callers
216 changed, except for the ones that didn't already append a newline.
217 Bug reported by Eric Blake.
219 2006-01-11 Jim Meyering <jim@meyering.net>
221 * src/system.h (X2NREALLOC): Now that verify_true is no longer
222 void, cast its result to void, to avoid gcc's warning that
223 ``left-hand operand of comma expression has no effect''.
224 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
226 2006-01-10 Jim Meyering <jim@meyering.net>
228 * tests/chmod/no-x: Add a test for today's fts.c fix.
230 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
232 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
233 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
235 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
237 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
238 Use verify_true instead of verify_expr, to sync with gnulib.
240 2006-01-08 Jim Meyering <jim@meyering.net>
242 * src/date.c (usage): Adjust the formatting of the entries for
243 %::z and %:::z (separate with two spaces, not one) so that help2man
244 formats them properly. Reported by Philip Rowlands.
246 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
248 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
250 2006-01-06 Jim Meyering <jim@meyering.net>
252 * Makefile.maint (copyright-check): Use date +%Y in place of
255 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
256 First off, the attribute should have been `volatile' (not static)
257 to avoid longjmp-related risk of clobber. Secondly, now there is
258 no longer any risk of a local variable being clobbered, so there's
259 no need for any attribute at all.
261 2006-01-05 Jim Meyering <jim@meyering.net>
263 * src/remove.c: Give a few functions the inline attribute.
264 (AD_pop_and_chdir): Use gotos to avoid some duplication.
265 (AD_push): Rewrite an assertion so that the entire computation
266 goes away when assertions are turned off.
268 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
269 It's already defined in "system.h".
270 * Makefile.maint: Add a FIXME comment.
272 2006-01-04 Jim Meyering <jim@meyering.net>
274 * ChangeLog: Remove entries from 2005-10-22 and earlier.
275 * ChangeLog-2005: New file, for entries up to version 5.92.
277 2006-01-03 Jim Meyering <jim@meyering.net>
279 * tests/du/no-x: Also allow a slightly different diagnostic -- the
280 one you get when using openat-enabled fts.c and du (coming soon).
281 * tests/chmod/no-x: Likewise.
282 * tests/chgrp/no-x: Likewise.
284 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
286 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
288 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
289 (restricted_chown): Return it, if the file cannot be accessed due
290 to EPERM, or if no uid or gid are required, or if the file is
291 neither a directory nor a regular file. Rewrite to avoid gotos.
292 (change_file_owner): Handle RC_do_ordinary_chown case.
293 Rewrite to avoid gotos.
294 * tests/chgrp/basic: Make sure we can change the group of
297 * src/date.c (usage): Explain %g, %G, and %V a bit better.
299 2006-01-02 Jim Meyering <jim@meyering.net>
301 * src/copy.c (set_owner): Correct a comment.
303 * src/tail.c (parse_options): Change warning to say that --retry
304 is useful `mainly' (not `only') when following by name.
305 Reported here: http://bugs.debian.org/273781
307 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
309 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
310 * src/copy.c: Include lchmod.h.
311 (copy_internal): Use lchmod rather than chmod.
312 * src/cp.c: Include lchmod.h.
313 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
314 * src/mkdir.c: Include lchmod.h.
315 (usage): Clarify -m's operation.
316 (main): Use lchmod rather than chmod. Don't use lchmod unless the
317 new mode contains bits outside the 777 range.
318 * src/mkfifo.c (usage): Clarify -m's operation.
319 (main): If -m is given, don't invoke chmod; use umask 0 instead.
320 Report an error if -m asks for bits outside the 777 range.
321 * src/mknod.c (usage, main): Likewise.
323 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
325 2005-12-27 Jim Meyering <jim@meyering.net>
327 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
328 (sc_prohibit_assert_without_use): New rule.
329 (syntax-check-rules): Add it to the list.
330 * .x-sc_prohibit_assert_without_use: New empty file.
331 * Makefile.am (EXTRA_DIST): Add it.
333 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
335 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
336 Don't include <assert.h>; it wasn't used.
338 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
340 * src/chown-core.c (restricted_chown):
341 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
342 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
343 | O_NOFOLLOW too, for consistency with other dir-openers.
344 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
345 (is_empty_dir): Likewise.
346 * src/shred.c (wipename): Likewise. Don't bother trying to open
347 dir for writing, since POSIX prohibits it.
349 2005-12-22 Jim Meyering <jim@meyering.net>
351 * tests/help-version: Redirect stderr to /dev/full, to suppress
352 write error diagnostic.
354 2005-12-19 Jim Meyering <jim@meyering.net>
356 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
357 Avoid a minor race condition when `-m MODE' is specified, by using
358 open, fchown, and close rather than just chown. To do that reliably --
359 even with an overly restrictive umask -- ensure that each mkdir,
360 mknod and mkfifo call uses a mode including at least owner-read access.
361 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
362 the subsequent chown (or equivalent open,fchown,close) fails.
363 * tests/misc/mknod: New tests.
364 * tests/misc/Makefile.am (TESTS): Add mknod.
366 2005-12-17 Jim Meyering <jim@meyering.net>
368 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
369 e.g., on a named pipe.
370 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
371 place of all uses, since it is guaranteed (system.h) to be defined.
373 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
375 Add POSIX ACL support
376 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
377 is no requirement for ACL support; particularly, it does not exist
378 on systems that have POSIX ACLs.
379 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
380 * src/cp.c (umask_kill): With default acls, the umask is not to be
381 applied. Remove umask_kill, don't change the process umask, and let
382 the kernel apply the umask where appropriate.
383 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
384 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
386 (copy_reg, copy_internal): Use copy_acl and set_acl
387 instead of fchown/chown. Fix the logic for POSIX ACLs.
388 (chown_succeded): Remove; we now always copy acls and
389 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
390 did a chown before or not.
391 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
392 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
393 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
394 to link with it via $(LIB_ACL), for the utilities that need it.
396 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
398 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
399 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
400 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
401 value is now signified by whether cwd_errno is null.
402 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
403 pointer-to-bool to pointer-to-errno-value. All callers changed.
404 (rm_1): Don't bother setting a local cwd failure flag and then
405 ORing it into the caller's. Just set the caller's.
406 (rm): Use cwd failure errno value to print a slightly-better
409 2005-12-15 Jim Meyering <jim@meyering.net>
411 * src/stat.c (print_it): Properly handle a backslash at the
412 end of a --printf format string. Reported by Paul Eggert.
413 * tests/misc/stat-printf (end-bs): Add a test for the above.
415 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
417 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
418 Don't assume /etc/passwd contains user names; use 'id' instead.
420 2005-12-15 Jim Meyering <jim@meyering.net>
422 stat: revert behavior of --format=FMT (-c)
423 stat: add new option: --printf=FMT
424 * NEWS: Mention this.
425 * src/stat.c (isodigit, octtobin, hextobin): Define.
426 (PRINTF_OPTION): Define.
427 (interpret_backslash_escapes, trailing_delim): New globals.
428 (usage): Document them. Alphabetize on long option names.
429 (print_esc_char): New function.
430 (print_it): Rewrite, in order to handle backslash escapes.
431 (main): Handle new option. Set globals for --format, too.
433 * tests/misc/stat-printf: Test --printf and --format.
434 * tests/misc/Makefile.am (TESTS): Add stat-printf.
436 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
438 * NEWS: sort now reports incompatible options.
439 * src/sort.c (incompatible_options, check_ordering_compatibility):
441 (main): Use them. Don't bother with a usage message for
442 "sort -c a b", for consistency with other error diagnostics.
443 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
446 * src/cat.c (main): Undo previous change. close_stdout already
447 does the check, so the previous change wasn't necessary.
449 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
451 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
453 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
455 Install a more-conservative approach for sort -R. It's the
456 same basic idea as the existing code, except it uses the full ISAAC
457 approach (called the "more kosher" approach in the existing comments).
458 This makes "sort -R" quite a bit slower (about a factor of 2 on my
459 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
460 better to be conservative here at first, and review any performance
461 improvements carefully.
462 * .x-sc_require_config_h: Add src/rand-isaac.c.
463 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
464 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
465 (shred_SOURCES, sort_SOURCES): Remove.
466 (EXTRA_DIST): Add rand-isaac.c.
467 * src/rand-isaac.c: Revert to what used to be in shred.c, without
468 changing it to allow for varying numbers of words in the state.
469 Alter so that we include rand-isaac.c directly rather than
470 compiling it and linking to it. Don't include config.h or
471 system.h; that's the includer's responsibility.
472 Omit functions that are specific to shred.
473 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
474 (isaac_step, struct irand_state):
475 Resurrect these, with the same defns that used to be in shred.c.
476 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
477 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
479 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
480 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
481 (irand_init, irand32, irand_mod):
482 Number of words is constant again.
483 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
484 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
485 * src/sort.c: Likewise.
486 * src/shred.c (fillrand, dopass, main): Undo previous change.
487 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
489 * src/sort.c: Don't include md5.h; it wasn't needed.
490 (struct keyfield): Rename random_hash to random, for consistency
491 with the other member names. All uses changed.
492 (usage): Tweak wording to mention STRING for --seed option.
493 (short_options): Rorder for consistency with other programs.
494 (rand_state): Now a struct, not a pointer to one. All uses changed.
495 (HASH_WORDS, HASH_SIZE): Remove.
496 (get_hash): Remove comments around resbuf size, since we can assume C89.
497 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
498 (keycompare): Adjust to the new get_hash.
500 (badfieldspec): Omit recently-introduced comment; it isn't needed.
501 (main): Don't set need_random simply because gkey has it set; that
502 doesn't necessarily mean we'll need random numbers.
503 Redo seeding to match new get_hash approach.
505 2005-12-10 Jim Meyering <jim@meyering.net>
507 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
509 Avoid shred segfault on 64-bit systems.
510 * src/rand-isaac.c (isaac_refill): Don't try to negate a
511 local of type uint32_t. Make the local an `int' instead.
513 * NEWS: Mention sort's new options.
515 * src/rand-isaac.c (isaac_mix): Declare to be static.
516 Mark all other functions as `extern' so the tight-scope
517 part of `make distcheck' passes once again.
518 * src/rand-isaac.h (isaac_mix): Remove declaration.
520 * src/sort.c (get_hash): Change position of `*' in parameter
521 type to conform with convention.
522 (main): Split a long line so it fits in 80 columns.
523 (keycompare): Remove stray SPACE before TAB that was
524 causing `make distcheck' to fail.
526 * src/shred.c: Don't include gethrxtime.h. No longer needed.
528 * tests/misc/sort-rand: New file: basic tests for the new options.
529 * tests/misc/Makefile.am (TESTS): Add sort-rand.
531 2005-12-10 Frederik Eaton <frederik@ofb.net>
533 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
534 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
535 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
536 Make state size runtime-configurable.
537 (isaac_new, isaac_copy): New functions.
538 * src/rand-isaac.h: New file.
539 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
540 (fillrand, main): Adjust to the fact that the state size is now
541 runtime-configurable.
542 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
543 (usage): Add options --random-sort and --seed to implement a random
545 Include md5.h and rand-isaac.h.
546 (get_hash): New function.
547 (rand_state): New var.
548 (HASH_WORDS, HASH_SIZE): New macros.
550 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
552 * tests/dd/misc: Add test for dd iflags=noatime.
554 2005-12-09 Jim Meyering <jim@meyering.net>
556 * src/sort.c (usage): Mention white space vs -b and -t options.
559 2005-12-09 Eric Blake <ebb9@byu.net>
561 * src/test.c (main): Fix misleading comment.
563 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
565 * NEWS: Mention dd's new noatime flag.
566 * src/system.h (O_NOATIME): Define to 0 if not already defined.
567 * src/dd.c (flags, usage): Add support for noatime flag.
569 2005-12-07 Jim Meyering <jim@meyering.net>
571 Distribute the cvsu script, used only by `make syntax-check'.
572 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
573 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
574 distribute a copy of this script.
575 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
577 * tests/mv/acl: exit-77 before the trap, not after, if we fail
578 to create a temporary directory on another partition.
579 From Andreas Gruenbacher.
581 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
583 * man/basename.x: Cross-reference to dirname and readlink.
584 * man/dirname.x: Cross-reference to basename and readlink.
586 2005-12-05 Andreas Gruenbacher
588 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
589 (set_owner, preserve_author): New functions, factored out of copy_reg.
590 (copy_reg): Use them.
591 (copy_internal): Use them here, too.
593 2005-12-04 Jim Meyering <jim@meyering.net>
595 * src/sleep.c (usage): Say what happens with two or more arguments.
596 Suggested by Justin Pryzby.
598 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
601 2005-12-03 Jim Meyering <jim@meyering.net>
603 * src/rm.c (long_opts): Change the name of each undocumented, for-
604 testing-only option to start with `-', so that it cannot render
605 ambiguous any prefix it happens to share with some other option name.
606 Problem reported by Eric Blake.
607 * src/head.c (long_options): Likewise.
608 * src/tail.c (long_options): Likewise.
610 * tests/misc/head-elide-tail: Update uses of undocumented, for-
611 testing-only --presume* options to start with `---'.
612 * tests/rm/dangling-symlink: Likewise.
613 * tests/rm/dir-no-w: Likewise.
614 * tests/rm/isatty: Likewise.
616 2005-11-30 Jim Meyering <jim@meyering.net>
618 * Makefile.maint: Add a comment about cvsu.
620 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
622 * NEWS: df updates for "none", "proc", inaccessible file systems.
623 * src/df.c (show_point): Ignore inaccessible file systems.
624 (usage): -a includes dummy file systems, not size-0 file systems.
626 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
627 to avoid collision with POSIX name space. All uses changed.
629 2005-11-24 Jim Meyering <jim@meyering.net>
631 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
632 * tests/acl: Add `$0: ' prefix to diagnostics.
634 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
636 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
638 * src/copy.c: Improve performance a bit by optimizing away
639 unnecessary system calls and going to a block size of at least
640 8192 (on normal hosts, anyway). This improved performance 5% on my
641 Debian stable host (2.4.27 kernel, x86, copying from root
642 ext3 file system to itself).
643 Include "buffer-lcm.h".
644 (copy_reg): Omit last argument. All callers changed.
645 Use xmalloc to allocate rather than trusting alloca
646 (which is unwise with large block sizes).
647 Declare locals more locally, if possible.
648 Use uintptr_t words instead of int words, for a bit more speed
649 when looking for null blocks on 64-bit hosts.
650 Optimize away reads of zero bytes on regular files.
651 In the typical case, insist on 8 KiB buffers, at least.
652 Avoid unnecessary extra call to fstat when checking for sparse files.
653 Avoid now-unnecessary cast to off_t, and "0L".
654 Avoid unnecessary test of *new_dst when checking for same owner
657 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
659 * src/remove.c (rm): Don't assume C99 for-loop syntax.
661 2005-11-22 Jim Meyering <jim@meyering.net>
663 * src/remove.c (AD_push): Remove debugging cruft.
665 * tests/rm/unread2 (rm): Change expected diagnostic,
666 `cannot open directory' to `cannot remove', to align with
668 * tests/rm/rm2: Ensure that rm now continues removing entries
669 even after certain types of failure.
671 * src/remove.c: Rewrite. Now, this module is reentrant on systems
672 that provide openat (Solaris), and on systems like Linux+procfs
673 where our openat emulation code is reentrant. This also fixes a
674 few low-probability leaks and eliminates some code that could,
675 in very unusual circumstances, cause rm() (via a callee) to exit.
676 * NEWS: Mention this.
678 * configure.ac: Put copyright dates all on one line so the
679 emacs function that updates them works properly.
681 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
683 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
684 Problem reported by Eric Blake.
685 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
686 we get a standard-conforming compiler. This relies on the new
687 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
688 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
689 m4/c.m4 can go away with Autoconf 2.60 comes out.
691 2005-11-17 Jim Meyering <jim@meyering.net>
693 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
694 (AD_mark_current_as_unremovable): Likewise, but for a local.
697 * tests/mv/acl: Let traps handle removing temporary directories.
699 Expect acl-related tests to fail, until the corresponding
700 patches are committed.
701 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
702 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
704 ACL tests, from Andreas Gruenbacher.
705 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
706 * tests/mv/Makefile.am (TESTS): Add acl.
707 * tests/cp/Makefile.am (TESTS): Add acl.
709 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
711 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
713 * NEWS: Improve quality of ln's diagnostics.
714 * src/ln.c (do_link, usage): Likewise.
715 (do_link): Don't use alloca on a buffer of unbounded size.
717 2005-11-16 Jim Meyering <jim@meyering.net>
719 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
720 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
721 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
723 2005-11-14 Jim Meyering <jim@meyering.net>
725 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
727 2005-11-13 Jim Meyering <jim@meyering.net>
729 * announce-gen: Accept new option, --gpg-key-id=ID and
730 emit a blurb telling how to use the .sig files.
731 * Makefile.cfg (gpg_key_ID): Define.
732 * Makefile.maint (announcement): Use new option and key.
734 Require that most .c files include <config.h>.
735 * Makefile.maint (sc_require_config_h): New rule.
736 (syntax-check-rules): Add it.
737 * .x-sc_require_config_h: New file listing exceptions to the
738 above rule. Some are legit, others are simply grandfathered in.
739 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
741 2005-11-12 Jim Meyering <jim@meyering.net>
743 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
745 2005-11-11 Jim Meyering <jim@meyering.net>
747 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
748 Mention new readlink options in 5.3.0's `New features' section.
749 Spotted by Thomas Hood.
751 2005-11-08 Jim Meyering <jim@meyering.net>
753 * NEWS: Merge in changes from b5_9x branch.
755 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
757 * NEWS: ls now defaults to --time-style='locale', which in turn acts
758 like --time-style='posix-long-iso' if the locale settings are messed up.
759 * src/ls.c (decode_switches): Implement this.
761 2005-11-08 Jim Meyering <jim@meyering.net>
763 * tests/du/2g: s/expensive/very expensive/ in a comment.
766 2005-10-17 Eric Blake <ebb9@byu.net>
768 * src/ls.c (usage): Fix descriptions of --sort, --time.
769 Reported by Vitaly A. Ostanin.
771 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
773 * src/ln.c: Include filenamecat.c.
774 (FILE_BASENAME_CONCAT): Remove.
775 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
776 (main): Use file_name_concat, base_name, and strip_trailing_slashes
777 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
780 2005-11-04 Jim Meyering <jim@meyering.net>
782 * src/du.c (process_file): Don't overflow for files of size >= 2^31
783 on systems with stat.st_blocks of a signed 32-bit type.
784 This bug causes trouble on some AIX 5.1 systems.
785 Report and trivial patch from Paul Townsend:
786 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
787 * NEWS: Mention this.
789 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
790 * tests/du/Makefile.am (TESTS): Add it here.
791 * tests/very-expensive: New file.
792 * tests/Makefile.am (EXTRA_DIST): Add it here.
793 * tests/cp/perm: Mark this test as `very-expensive', too.
795 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
797 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
799 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
801 * src/rm.c (usage): Don't mention rm -d.
803 2005-11-02 Jim Meyering <jim@meyering.net>
805 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
808 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
809 `M+N records in/out' lines don't pollute `make check' output.
811 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
812 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
813 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
814 to indicate that the input file should be piped into the command
815 under test (via `cat FILE | $prog ...').
817 * src/remove.c (remove_entry): Emit a better diagnostic when rm
818 (without -r) fails to remove a directory on a non-Linux system.
819 This change affects only newer Solaris systems (with priv_*
820 functions like priv_allocset). Reported by Keith Thompson.
822 * tests/rm/dir-nonrecur: New file/test for the above fix.
823 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
825 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
827 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
828 POSIX 1002.1-2001 requires.
829 * src/tail.c (parse_obsolete_option): Implement this.
830 Problem reported by Vincent Lefevre.
831 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
832 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
833 (test_vector): Add special cases for _POSIX2_VERSION, and
834 regularize the old ones a bit.
835 * tests/touch/obsolescent: Add y2000 test.
837 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
839 * src/dd.c (skip): Fix off-by-one error reported by
840 Theodoros V. Kalamatianos.
842 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
844 * tests/mkdir/p-3: Require that the test be run as non-root.
845 Problem and trivial fix reported by Theodoros V. Kalamatianos.
847 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
849 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
850 boundary between DEST and SOURCE in the result.
852 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
854 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
855 back to text, to sync with documentation and for backwards
858 2005-10-25 Jim Meyering <jim@meyering.net>
860 * tests/dircolors/simple (other-wr): Add an explicit test for
861 the dircolors bug (NULL-dereference) fixed yesterday.
863 2005-10-24 Jim Meyering <jim@meyering.net>
865 * src/tac.c (tac_file): When determining whether a file is seekable,
866 also test whether it is a tty. Using only the lseek-based test would
867 give a false positive on Solaris. Reported by Peter Fales.
869 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
871 * tests/install/d-slashdot: New test, for "install -d" failure.
872 * tests/install/Makefile.am (TESTS): Add d-slashdot.
873 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
874 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
876 2005-10-24 Jim Meyering <jim@meyering.net>
878 * src/dircolors.c (ls_codes): Add missing comma.
879 Anonymous report and patch from
880 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
882 * src/dircolors.c: Add compile-time assertion that the slack_codes
883 and ls_codes arrays have the same number of elements. This would
884 have prevented the above-fixed bug.
886 * src/expand.c (parse_tab_stops): Add a comment to make this function
887 identical to the one in unexpand.c.
888 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
889 identical to the one in expand.c.
891 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
893 2005-10-23 Jim Meyering <jim@meyering.net>
895 * src/md5sum.c (digest_check, main): Use ptr_align rather than
896 a dangerous pointer-value-to-`unsigned' cast.
897 * NEWS: mention the new sha* programs.
898 * AUTHORS: Add new sha* programs.
900 2005-08-28 David Madore <david.madore@ens.fr>
902 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
903 * README: Add their names to the list.
904 * src/md5sum.c: Provide framework for computing sha-2 hashes.
905 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
906 Rules for compiling sha-2 utilities
907 (noinst_HEADERS): Remove checksum.h.
908 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
910 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
911 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
912 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
913 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
914 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
915 sha384sum, sha512sum test scripts here rather that each in its
918 2005-08-28 David Madore <david.madore@ens.fr>
920 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
921 of the FIPS test vectors).
923 2005-10-23 Jim Meyering <jim@meyering.net>
925 * configure.ac: Use 6.0-cvs as the version string.
926 * NEWS: Adjust accordingly.