1 2006-02-06 Jim Meyering <jim@meyering.net>
5 * src/cp.c (usage): Use two spaces (not one) to separate the
6 option string from its description, so help2man formats the
7 derived man page properly.
8 * src/mv.c (usage): Likewise.
9 Patch from Nicolas François in http://bugs.debian.org/351601.
11 2006-02-04 Jim Meyering <jim@meyering.net>
13 * src/copy.c (copy_internal): cp -RL no longer fails when encountering
14 the same directory more than once in the hierarchy beneath a single
15 command-line argument. That is legitimate, e.g. when there are
16 two or more symbolic links, each pointing to some directory that
17 would not otherwise be copied. Reported by Christophe LYON.
18 * tests/cp/cp-deref: New file. Test for today's fix.
19 * tests/cp/Makefile.am (TESTS): Add cp-deref.
21 2006-02-03 Jim Meyering <jim@meyering.net>
23 * configure.ac: Require automake-1.9.6, not 1.8.3.
25 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
27 * src/od.c (usage): Mention that -t a ignores high order bit.
28 Documentation problem reported by Ed Avis.
30 2006-02-01 Jim Meyering <jim@meyering.net>
32 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
34 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
36 * src/head.c (main): Use a better diagnostic when someone uses a
37 trailing numeric option in an invalid way. Problem reported by
39 * src/tail.c (parse_options): Likewise.
41 2006-01-30 Jim Meyering <jim@meyering.net>
43 * man/wc.x: Include `count' keyword in man page synopsis,
44 per suggestion from http://bugs.debian.org/181585.
46 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
48 * src/df.c (show_dev): If the file system claims to have
49 more available than total blocks, report the number of used
50 blocks as being total - available (a negative number) rather
51 than as garbage. Problem reported by Toralf Foerster.
53 2006-01-24 Jim Meyering <jim@meyering.net>
55 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
56 to put a regular file in O_NONBLOCK mode fails with EPERM.
57 That happens on Linux when using tail -f on a file with the
58 append-only attribute. Reported by Dean Gaudet. For details,
59 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
60 * NEWS: Mention this fix.
61 * tests/tail-2/append-only: New file. Test for the above.
62 * tests/tail-2/Makefile.am (TESTS): Add append-only.
63 * tests/Makefile.am (check-root): Add tail-2/append-only
65 2006-01-21 Jim Meyering <jim@meyering.net>
67 * NEWS: Mention fts-related improvements and bug fixes.
69 2006-01-19 Jim Meyering <jim@meyering.net>
71 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
72 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
74 2006-01-18 Jim Meyering <jim@meyering.net>
76 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
78 2006-01-17 Jim Meyering <jim@meyering.net>
80 Now that fts no longer changes the current working directory, adjust
81 its clients accordingly -- note that du.c uses fts but doesn't need
82 any adjustment, since it doesn't operate on the actual files,
83 but rather just uses the stat buffers provided by fts.
85 * src/chown-core.c: Include "openat.h".
86 Don't include "lchown.h".
87 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
88 calling openat, lchownat, chownat, rather than open, lchown, chown.
90 * src/chmod.c: Include "openat.h".
91 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
93 * tests/du/long-from-unreadable: New test, to exercise one small
96 2006-01-13 Jim Meyering <jim@meyering.net>
98 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
99 addition of new directories under tests/.
101 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
104 2006-01-12 Jim Meyering <jim@meyering.net>
106 * tests/du/long-sloop: Adjust not to hard-code the expected
107 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
108 from that of GNU libc. Reported by Paul Eggert.
110 * tests/du/long-sloop: Create file at end of symlink chain.
112 * tests/misc/test: New file, with a test for one of the
113 bugs fixed by yesterday's test.c changes.
114 * tests/misc/Makefile.am (TESTS): Add test.
116 2006-01-11 Jim Meyering <jim@meyering.net>
118 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
119 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
120 a very long sequence of symbolic links (not necessarily a loop).
121 * tests/du/Makefile.am (TESTS): Add long-sloop.
123 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
125 * src/test.c (test_syntax_error): Append a newline. All callers
126 changed, except for the ones that didn't already append a newline.
127 Bug reported by Eric Blake.
129 2006-01-11 Jim Meyering <jim@meyering.net>
131 * src/system.h (X2NREALLOC): Now that verify_true is no longer
132 void, cast its result to void, to avoid gcc's warning that
133 ``left-hand operand of comma expression has no effect''.
134 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
136 2006-01-10 Jim Meyering <jim@meyering.net>
138 * tests/chmod/no-x: Add a test for today's fts.c fix.
140 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
142 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
143 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
145 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
147 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
148 Use verify_true instead of verify_expr, to sync with gnulib.
150 2006-01-08 Jim Meyering <jim@meyering.net>
152 * src/date.c (usage): Adjust the formatting of the entries for
153 %::z and %:::z (separate with two spaces, not one) so that help2man
154 formats them properly. Reported by Philip Rowlands.
156 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
158 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
160 2006-01-06 Jim Meyering <jim@meyering.net>
162 * Makefile.maint (copyright-check): Use date +%Y in place of
165 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
166 First off, the attribute should have been `volatile' (not static)
167 to avoid longjmp-related risk of clobber. Secondly, now there is
168 no longer any risk of a local variable being clobbered, so there's
169 no need for any attribute at all.
171 2006-01-05 Jim Meyering <jim@meyering.net>
173 * src/remove.c: Give a few functions the inline attribute.
174 (AD_pop_and_chdir): Use gotos to avoid some duplication.
175 (AD_push): Rewrite an assertion so that the entire computation
176 goes away when assertions are turned off.
178 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
179 It's already defined in "system.h".
180 * Makefile.maint: Add a FIXME comment.
182 2006-01-04 Jim Meyering <jim@meyering.net>
184 * ChangeLog: Remove entries from 2005-10-22 and earlier.
185 * ChangeLog-2005: New file, for entries up to version 5.92.
187 2006-01-03 Jim Meyering <jim@meyering.net>
189 * tests/du/no-x: Also allow a slightly different diagnostic -- the
190 one you get when using openat-enabled fts.c and du (coming soon).
191 * tests/chmod/no-x: Likewise.
192 * tests/chgrp/no-x: Likewise.
194 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
196 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
198 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
199 (restricted_chown): Return it, if the file cannot be accessed due
200 to EPERM, or if no uid or gid are required, or if the file is
201 neither a directory nor a regular file. Rewrite to avoid gotos.
202 (change_file_owner): Handle RC_do_ordinary_chown case.
203 Rewrite to avoid gotos.
204 * tests/chgrp/basic: Make sure we can change the group of
207 * src/date.c (usage): Explain %g, %G, and %V a bit better.
209 2006-01-02 Jim Meyering <jim@meyering.net>
211 * src/copy.c (set_owner): Correct a comment.
213 * src/tail.c (parse_options): Change warning to say that --retry
214 is useful `mainly' (not `only') when following by name.
215 Reported here: http://bugs.debian.org/273781
217 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
219 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
220 * src/copy.c: Include lchmod.h.
221 (copy_internal): Use lchmod rather than chmod.
222 * src/cp.c: Include lchmod.h.
223 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
224 * src/mkdir.c: Include lchmod.h.
225 (usage): Clarify -m's operation.
226 (main): Use lchmod rather than chmod. Don't use lchmod unless the
227 new mode contains bits outside the 777 range.
228 * src/mkfifo.c (usage): Clarify -m's operation.
229 (main): If -m is given, don't invoke chmod; use umask 0 instead.
230 Report an error if -m asks for bits outside the 777 range.
231 * src/mknod.c (usage, main): Likewise.
233 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
235 2005-12-27 Jim Meyering <jim@meyering.net>
237 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
238 (sc_prohibit_assert_without_use): New rule.
239 (syntax-check-rules): Add it to the list.
240 * .x-sc_prohibit_assert_without_use: New empty file.
241 * Makefile.am (EXTRA_DIST): Add it.
243 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
245 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
246 Don't include <assert.h>; it wasn't used.
248 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
250 * src/chown-core.c (restricted_chown):
251 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
252 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
253 | O_NOFOLLOW too, for consistency with other dir-openers.
254 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
255 (is_empty_dir): Likewise.
256 * src/shred.c (wipename): Likewise. Don't bother trying to open
257 dir for writing, since POSIX prohibits it.
259 2005-12-22 Jim Meyering <jim@meyering.net>
261 * tests/help-version: Redirect stderr to /dev/full, to suppress
262 write error diagnostic.
264 2005-12-19 Jim Meyering <jim@meyering.net>
266 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
267 Avoid a minor race condition when `-m MODE' is specified, by using
268 open, fchown, and close rather than just chown. To do that reliably --
269 even with an overly restrictive umask -- ensure that each mkdir,
270 mknod and mkfifo call uses a mode including at least owner-read access.
271 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
272 the subsequent chown (or equivalent open,fchown,close) fails.
273 * tests/misc/mknod: New tests.
274 * tests/misc/Makefile.am (TESTS): Add mknod.
276 2005-12-17 Jim Meyering <jim@meyering.net>
278 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
279 e.g., on a named pipe.
280 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
281 place of all uses, since it is guaranteed (system.h) to be defined.
283 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
285 Add POSIX ACL support
286 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
287 is no requirement for ACL support; particularly, it does not exist
288 on systems that have POSIX ACLs.
289 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
290 * src/cp.c (umask_kill): With default acls, the umask is not to be
291 applied. Remove umask_kill, don't change the process umask, and let
292 the kernel apply the umask where appropriate.
293 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
294 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
296 (copy_reg, copy_internal): Use copy_acl and set_acl
297 instead of fchown/chown. Fix the logic for POSIX ACLs.
298 (chown_succeded): Remove; we now always copy acls and
299 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
300 did a chown before or not.
301 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
302 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
303 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
304 to link with it via $(LIB_ACL), for the utilities that need it.
306 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
308 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
309 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
310 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
311 value is now signified by whether cwd_errno is null.
312 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
313 pointer-to-bool to pointer-to-errno-value. All callers changed.
314 (rm_1): Don't bother setting a local cwd failure flag and then
315 ORing it into the caller's. Just set the caller's.
316 (rm): Use cwd failure errno value to print a slightly-better
319 2005-12-15 Jim Meyering <jim@meyering.net>
321 * src/stat.c (print_it): Properly handle a backslash at the
322 end of a --printf format string. Reported by Paul Eggert.
323 * tests/misc/stat-printf (end-bs): Add a test for the above.
325 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
327 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
328 Don't assume /etc/passwd contains user names; use 'id' instead.
330 2005-12-15 Jim Meyering <jim@meyering.net>
332 stat: revert behavior of --format=FMT (-c)
333 stat: add new option: --printf=FMT
334 * NEWS: Mention this.
335 * src/stat.c (isodigit, octtobin, hextobin): Define.
336 (PRINTF_OPTION): Define.
337 (interpret_backslash_escapes, trailing_delim): New globals.
338 (usage): Document them. Alphabetize on long option names.
339 (print_esc_char): New function.
340 (print_it): Rewrite, in order to handle backslash escapes.
341 (main): Handle new option. Set globals for --format, too.
343 * tests/misc/stat-printf: Test --printf and --format.
344 * tests/misc/Makefile.am (TESTS): Add stat-printf.
346 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
348 * NEWS: sort now reports incompatible options.
349 * src/sort.c (incompatible_options, check_ordering_compatibility):
351 (main): Use them. Don't bother with a usage message for
352 "sort -c a b", for consistency with other error diagnostics.
353 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
356 * src/cat.c (main): Undo previous change. close_stdout already
357 does the check, so the previous change wasn't necessary.
359 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
361 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
363 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
365 Install a more-conservative approach for sort -R. It's the
366 same basic idea as the existing code, except it uses the full ISAAC
367 approach (called the "more kosher" approach in the existing comments).
368 This makes "sort -R" quite a bit slower (about a factor of 2 on my
369 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
370 better to be conservative here at first, and review any performance
371 improvements carefully.
372 * .x-sc_require_config_h: Add src/rand-isaac.c.
373 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
374 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
375 (shred_SOURCES, sort_SOURCES): Remove.
376 (EXTRA_DIST): Add rand-isaac.c.
377 * src/rand-isaac.c: Revert to what used to be in shred.c, without
378 changing it to allow for varying numbers of words in the state.
379 Alter so that we include rand-isaac.c directly rather than
380 compiling it and linking to it. Don't include config.h or
381 system.h; that's the includer's responsibility.
382 Omit functions that are specific to shred.
383 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
384 (isaac_step, struct irand_state):
385 Resurrect these, with the same defns that used to be in shred.c.
386 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
387 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
389 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
390 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
391 (irand_init, irand32, irand_mod):
392 Number of words is constant again.
393 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
394 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
395 * src/sort.c: Likewise.
396 * src/shred.c (fillrand, dopass, main): Undo previous change.
397 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
399 * src/sort.c: Don't include md5.h; it wasn't needed.
400 (struct keyfield): Rename random_hash to random, for consistency
401 with the other member names. All uses changed.
402 (usage): Tweak wording to mention STRING for --seed option.
403 (short_options): Rorder for consistency with other programs.
404 (rand_state): Now a struct, not a pointer to one. All uses changed.
405 (HASH_WORDS, HASH_SIZE): Remove.
406 (get_hash): Remove comments around resbuf size, since we can assume C89.
407 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
408 (keycompare): Adjust to the new get_hash.
410 (badfieldspec): Omit recently-introduced comment; it isn't needed.
411 (main): Don't set need_random simply because gkey has it set; that
412 doesn't necessarily mean we'll need random numbers.
413 Redo seeding to match new get_hash approach.
415 2005-12-10 Jim Meyering <jim@meyering.net>
417 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
419 Avoid shred segfault on 64-bit systems.
420 * src/rand-isaac.c (isaac_refill): Don't try to negate a
421 local of type uint32_t. Make the local an `int' instead.
423 * NEWS: Mention sort's new options.
425 * src/rand-isaac.c (isaac_mix): Declare to be static.
426 Mark all other functions as `extern' so the tight-scope
427 part of `make distcheck' passes once again.
428 * src/rand-isaac.h (isaac_mix): Remove declaration.
430 * src/sort.c (get_hash): Change position of `*' in parameter
431 type to conform with convention.
432 (main): Split a long line so it fits in 80 columns.
433 (keycompare): Remove stray SPACE before TAB that was
434 causing `make distcheck' to fail.
436 * src/shred.c: Don't include gethrxtime.h. No longer needed.
438 * tests/misc/sort-rand: New file: basic tests for the new options.
439 * tests/misc/Makefile.am (TESTS): Add sort-rand.
441 2005-12-10 Frederik Eaton <frederik@ofb.net>
443 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
444 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
445 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
446 Make state size runtime-configurable.
447 (isaac_new, isaac_copy): New functions.
448 * src/rand-isaac.h: New file.
449 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
450 (fillrand, main): Adjust to the fact that the state size is now
451 runtime-configurable.
452 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
453 (usage): Add options --random-sort and --seed to implement a random
455 Include md5.h and rand-isaac.h.
456 (get_hash): New function.
457 (rand_state): New var.
458 (HASH_WORDS, HASH_SIZE): New macros.
460 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
462 * tests/dd/misc: Add test for dd iflags=noatime.
464 2005-12-09 Jim Meyering <jim@meyering.net>
466 * src/sort.c (usage): Mention white space vs -b and -t options.
469 2005-12-09 Eric Blake <ebb9@byu.net>
471 * src/test.c (main): Fix misleading comment.
473 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
475 * NEWS: Mention dd's new noatime flag.
476 * src/system.h (O_NOATIME): Define to 0 if not already defined.
477 * src/dd.c (flags, usage): Add support for noatime flag.
479 2005-12-07 Jim Meyering <jim@meyering.net>
481 Distribute the cvsu script, used only by `make syntax-check'.
482 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
483 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
484 distribute a copy of this script.
485 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
487 * tests/mv/acl: exit-77 before the trap, not after, if we fail
488 to create a temporary directory on another partition.
489 From Andreas Gruenbacher.
491 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
493 * man/basename.x: Cross-reference to dirname and readlink.
494 * man/dirname.x: Cross-reference to basename and readlink.
496 2005-12-05 Andreas Gruenbacher
498 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
499 (set_owner, preserve_author): New functions, factored out of copy_reg.
500 (copy_reg): Use them.
501 (copy_internal): Use them here, too.
503 2005-12-04 Jim Meyering <jim@meyering.net>
505 * src/sleep.c (usage): Say what happens with two or more arguments.
506 Suggested by Justin Pryzby.
508 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
511 2005-12-03 Jim Meyering <jim@meyering.net>
513 * src/rm.c (long_opts): Change the name of each undocumented, for-
514 testing-only option to start with `-', so that it cannot render
515 ambiguous any prefix it happens to share with some other option name.
516 Problem reported by Eric Blake.
517 * src/head.c (long_options): Likewise.
518 * src/tail.c (long_options): Likewise.
520 * tests/misc/head-elide-tail: Update uses of undocumented, for-
521 testing-only --presume* options to start with `---'.
522 * tests/rm/dangling-symlink: Likewise.
523 * tests/rm/dir-no-w: Likewise.
524 * tests/rm/isatty: Likewise.
526 2005-11-30 Jim Meyering <jim@meyering.net>
528 * Makefile.maint: Add a comment about cvsu.
530 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
532 * NEWS: df updates for "none", "proc", inaccessible file systems.
533 * src/df.c (show_point): Ignore inaccessible file systems.
534 (usage): -a includes dummy file systems, not size-0 file systems.
536 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
537 to avoid collision with POSIX name space. All uses changed.
539 2005-11-24 Jim Meyering <jim@meyering.net>
541 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
542 * tests/acl: Add `$0: ' prefix to diagnostics.
544 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
546 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
548 * src/copy.c: Improve performance a bit by optimizing away
549 unnecessary system calls and going to a block size of at least
550 8192 (on normal hosts, anyway). This improved performance 5% on my
551 Debian stable host (2.4.27 kernel, x86, copying from root
552 ext3 file system to itself).
553 Include "buffer-lcm.h".
554 (copy_reg): Omit last argument. All callers changed.
555 Use xmalloc to allocate rather than trusting alloca
556 (which is unwise with large block sizes).
557 Declare locals more locally, if possible.
558 Use uintptr_t words instead of int words, for a bit more speed
559 when looking for null blocks on 64-bit hosts.
560 Optimize away reads of zero bytes on regular files.
561 In the typical case, insist on 8 KiB buffers, at least.
562 Avoid unnecessary extra call to fstat when checking for sparse files.
563 Avoid now-unnecessary cast to off_t, and "0L".
564 Avoid unnecessary test of *new_dst when checking for same owner
567 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
569 * src/remove.c (rm): Don't assume C99 for-loop syntax.
571 2005-11-22 Jim Meyering <jim@meyering.net>
573 * src/remove.c (AD_push): Remove debugging cruft.
575 * tests/rm/unread2 (rm): Change expected diagnostic,
576 `cannot open directory' to `cannot remove', to align with
578 * tests/rm/rm2: Ensure that rm now continues removing entries
579 even after certain types of failure.
581 * src/remove.c: Rewrite. Now, this module is reentrant on systems
582 that provide openat (Solaris), and on systems like Linux+procfs
583 where our openat emulation code is reentrant. This also fixes a
584 few low-probability leaks and eliminates some code that could,
585 in very unusual circumstances, cause rm() (via a callee) to exit.
586 * NEWS: Mention this.
588 * configure.ac: Put copyright dates all on one line so the
589 emacs function that updates them works properly.
591 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
593 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
594 Problem reported by Eric Blake.
595 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
596 we get a standard-conforming compiler. This relies on the new
597 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
598 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
599 m4/c.m4 can go away with Autoconf 2.60 comes out.
601 2005-11-17 Jim Meyering <jim@meyering.net>
603 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
604 (AD_mark_current_as_unremovable): Likewise, but for a local.
607 * tests/mv/acl: Let traps handle removing temporary directories.
609 Expect acl-related tests to fail, until the corresponding
610 patches are committed.
611 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
612 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
614 ACL tests, from Andreas Gruenbacher.
615 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
616 * tests/mv/Makefile.am (TESTS): Add acl.
617 * tests/cp/Makefile.am (TESTS): Add acl.
619 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
621 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
623 * NEWS: Improve quality of ln's diagnostics.
624 * src/ln.c (do_link, usage): Likewise.
625 (do_link): Don't use alloca on a buffer of unbounded size.
627 2005-11-16 Jim Meyering <jim@meyering.net>
629 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
630 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
631 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
633 2005-11-14 Jim Meyering <jim@meyering.net>
635 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
637 2005-11-13 Jim Meyering <jim@meyering.net>
639 * announce-gen: Accept new option, --gpg-key-id=ID and
640 emit a blurb telling how to use the .sig files.
641 * Makefile.cfg (gpg_key_ID): Define.
642 * Makefile.maint (announcement): Use new option and key.
644 Require that most .c files include <config.h>.
645 * Makefile.maint (sc_require_config_h): New rule.
646 (syntax-check-rules): Add it.
647 * .x-sc_require_config_h: New file listing exceptions to the
648 above rule. Some are legit, others are simply grandfathered in.
649 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
651 2005-11-12 Jim Meyering <jim@meyering.net>
653 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
655 2005-11-11 Jim Meyering <jim@meyering.net>
657 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
658 Mention new readlink options in 5.3.0's `New features' section.
659 Spotted by Thomas Hood.
661 2005-11-08 Jim Meyering <jim@meyering.net>
663 * NEWS: Merge in changes from b5_9x branch.
665 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
667 * NEWS: ls now defaults to --time-style='locale', which in turn acts
668 like --time-style='posix-long-iso' if the locale settings are messed up.
669 * src/ls.c (decode_switches): Implement this.
671 2005-11-08 Jim Meyering <jim@meyering.net>
673 * tests/du/2g: s/expensive/very expensive/ in a comment.
676 2005-10-17 Eric Blake <ebb9@byu.net>
678 * src/ls.c (usage): Fix descriptions of --sort, --time.
679 Reported by Vitaly A. Ostanin.
681 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
683 * src/ln.c: Include filenamecat.c.
684 (FILE_BASENAME_CONCAT): Remove.
685 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
686 (main): Use file_name_concat, base_name, and strip_trailing_slashes
687 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
690 2005-11-04 Jim Meyering <jim@meyering.net>
692 * src/du.c (process_file): Don't overflow for files of size >= 2^31
693 on systems with stat.st_blocks of a signed 32-bit type.
694 This bug causes trouble on some AIX 5.1 systems.
695 Report and trivial patch from Paul Townsend:
696 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
697 * NEWS: Mention this.
699 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
700 * tests/du/Makefile.am (TESTS): Add it here.
701 * tests/very-expensive: New file.
702 * tests/Makefile.am (EXTRA_DIST): Add it here.
703 * tests/cp/perm: Mark this test as `very-expensive', too.
705 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
707 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
709 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
711 * src/rm.c (usage): Don't mention rm -d.
713 2005-11-02 Jim Meyering <jim@meyering.net>
715 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
718 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
719 `M+N records in/out' lines don't pollute `make check' output.
721 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
722 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
723 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
724 to indicate that the input file should be piped into the command
725 under test (via `cat FILE | $prog ...').
727 * src/remove.c (remove_entry): Emit a better diagnostic when rm
728 (without -r) fails to remove a directory on a non-Linux system.
729 This change affects only newer Solaris systems (with priv_*
730 functions like priv_allocset). Reported by Keith Thompson.
732 * tests/rm/dir-nonrecur: New file/test for the above fix.
733 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
735 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
737 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
738 POSIX 1002.1-2001 requires.
739 * src/tail.c (parse_obsolete_option): Implement this.
740 Problem reported by Vincent Lefevre.
741 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
742 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
743 (test_vector): Add special cases for _POSIX2_VERSION, and
744 regularize the old ones a bit.
745 * tests/touch/obsolescent: Add y2000 test.
747 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
749 * src/dd.c (skip): Fix off-by-one error reported by
750 Theodoros V. Kalamatianos.
752 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
754 * tests/mkdir/p-3: Require that the test be run as non-root.
755 Problem and trivial fix reported by Theodoros V. Kalamatianos.
757 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
759 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
760 boundary between DEST and SOURCE in the result.
762 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
764 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
765 back to text, to sync with documentation and for backwards
768 2005-10-25 Jim Meyering <jim@meyering.net>
770 * tests/dircolors/simple (other-wr): Add an explicit test for
771 the dircolors bug (NULL-dereference) fixed yesterday.
773 2005-10-24 Jim Meyering <jim@meyering.net>
775 * src/tac.c (tac_file): When determining whether a file is seekable,
776 also test whether it is a tty. Using only the lseek-based test would
777 give a false positive on Solaris. Reported by Peter Fales.
779 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
781 * tests/install/d-slashdot: New test, for "install -d" failure.
782 * tests/install/Makefile.am (TESTS): Add d-slashdot.
783 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
784 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
786 2005-10-24 Jim Meyering <jim@meyering.net>
788 * src/dircolors.c (ls_codes): Add missing comma.
789 Anonymous report and patch from
790 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
792 * src/dircolors.c: Add compile-time assertion that the slack_codes
793 and ls_codes arrays have the same number of elements. This would
794 have prevented the above-fixed bug.
796 * src/expand.c (parse_tab_stops): Add a comment to make this function
797 identical to the one in unexpand.c.
798 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
799 identical to the one in expand.c.
801 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
803 2005-10-23 Jim Meyering <jim@meyering.net>
805 * src/md5sum.c (digest_check, main): Use ptr_align rather than
806 a dangerous pointer-value-to-`unsigned' cast.
807 * NEWS: mention the new sha* programs.
808 * AUTHORS: Add new sha* programs.
810 2005-08-28 David Madore <david.madore@ens.fr>
812 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
813 * README: Add their names to the list.
814 * src/md5sum.c: Provide framework for computing sha-2 hashes.
815 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
816 Rules for compiling sha-2 utilities
817 (noinst_HEADERS): Remove checksum.h.
818 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
820 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
821 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
822 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
823 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
824 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
825 sha384sum, sha512sum test scripts here rather that each in its
828 2005-08-28 David Madore <david.madore@ens.fr>
830 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
831 of the FIPS test vectors).
833 2005-10-23 Jim Meyering <jim@meyering.net>
835 * configure.ac: Use 6.0-cvs as the version string.
836 * NEWS: Adjust accordingly.