1 2006-06-08 Jim Meyering <jim@meyering.net>
5 Ensure that cat works with any of the options, -A -v -e -E -T,
6 when applied to files in /proc and /sys, even when the FIONREAD
7 ioctl produces nonsensical results. Before this change, cat would
8 produce no output (or truncated output), for some linux kernels.
10 * src/cat.c (write_pending): New function, factored out of cat.
11 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
12 that there are bytes to read. Some versions of linux-2.6.16 do that.
13 Write any pending output before returning.
14 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
15 * NEWS: Mention this bug fix.
16 * tests/misc/cat-proc: New file. Test for the above.
17 * tests/misc/Makefile.am (TESTS): Add cat-proc.
19 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
21 * src/expr.c (eval4): Detect overflow properly when multiplying
24 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
26 * NEWS: The 'expr' command now detects and reports integer overflow.
27 (It would be better to use extended precision instead, but that
29 * src/expr.c (integer_overflow): New function.
30 (eval4, eval3): Check for integer overflow.
32 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
34 Fix problems when building with Solaris/SVR4/etc. make, which uses a
35 different and somewhat bogus implementation of VPATH. In the
36 directory tests/misc, rename tests whose names might appear in the
37 Automake-generated rules. For example, we can't use a test named
38 'test', since Automake generates a rule that contains the text
39 "if test -f ./$$tst; ...", and this might expand to something like
40 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
41 which executes the 'test' script rather than the 'test' command.
42 * tests/misc/false-status: Renamed from tests/misc/false.
43 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
44 * tests/misc/sort-merge: Renamed from tests/misc/sort.
45 ($prog): Set to 'sort' rather than to $PROG.
46 * tests/misc/test-diag: Renamed from tests/misc/test.
47 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
48 in case Solaris make has prepended the directory.
49 (TESTS): Adjust to above renamings.
50 * tests/misc/expand: Don't assign to PROG; no longer needed
51 now that Makefile.am sets PROG to the basename.
52 * tests/misc/fold: Likewise.
54 2006-06-03 Jim Meyering <jim@meyering.net>
56 Make `cp --link --no-dereference' work also on systems where the
57 link system call cannot create a hard link to a symbolic link.
58 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
59 the link syscall on a symlink when it would do the wrong thing.
60 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
61 * tests/cp/link-no-deref: New file/test for the above.
62 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
63 * NEWS: Mention the change (doesn't affect Linux).
65 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
67 Fix some porting problems in the test cases reported by
68 Ralf Wildenhues for HP-UX 11.23 in:
69 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
70 * tests/help-version: Don't assume that \< \> works in sed.
71 * tests/misc/close-stdout: Don't assume that >&- works.
73 * tests/touch/no-create-missing: Don't assume that >&- works.
75 2006-05-30 Jim Meyering <jim@meyering.net>
77 * src/ls.c (usage): Add `v' to the list of sorting-related options.
80 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
82 * tests/cp/fail-perm: source lang-default.
83 * tests/rm/inaccessible: Likewise.
85 2006-05-28 Jim Meyering <jim@meyering.net>
87 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
88 Recognize it, too. Reported by Ralf Wildenhues, in
89 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
91 2006-05-27 Jim Meyering <jim@meyering.net>
93 * src/chgrp.c: Support new options: --preserve-root and
94 --no-preserve-root. Somehow this program was skipped when those
95 options were added to chown, chmod, and rm. Reported by
96 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
99 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
101 * NEWS: Remove mention of --seed. We'll replace it with something
102 better, and don't want to indicate that it is supported.
103 * src/sort.c (usage): Likewise.
105 2006-05-20 Jim Meyering <jim@meyering.net>
107 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
109 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
110 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
111 FTS_COMFOLLOW. Spotted by Justin Pryzby.
113 * gnupload: Merge changes from automake, retaining the ""--to...
114 kludge to placate overzealous `make distcheck' check.
116 2006-05-19 Jim Meyering <jim@meyering.net>
118 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
119 FTS_TIGHT_CYCLE_CHECK directory traversal option.
120 Reported by Justin Pryzby in http://bugs.debian.org/367691
122 2006-05-15 Jim Meyering <jim@meyering.net>
124 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
127 2006-05-13 Jim Meyering <jim@meyering.net>
129 * tests/mv/no-target-dir: Test two more cases.
131 2006-05-11 Jim Meyering <jim@meyering.net>
133 mv -T DIR EMPTY_DIR no longer fails unconditionally
134 * src/copy.c (copy_internal): Don't manually prohibit a move where
135 the destination is an existing directory. Sometimes doing that is
136 valid. Let the rename system call enforce the rules. That is
137 allowed only when the source is a directory and the destination
138 directory (to be replaced) is empty. Reported by Eric Blake.
139 * tests/mv/no-target-dir: New file/test for this.
140 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
141 * NEWS: Mention this.
143 * tests/mv/atomic: New file/test for yesterday's fix.
144 * tests/mv/Makefile.am (TESTS): Add atomic.
146 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
148 2006-05-10 Jim Meyering <jim@meyering.net>
150 * src/copy.c (copy_internal): Don't explicitly unlink the destination
151 when moving a symlink into the place of an existing non-directory.
152 Reported by Joshua Hudson.
153 * NEWS: mention this.
155 2006-05-07 Jim Meyering <jim@meyering.net>
157 * Makefile.maint (patch-check): Fail if patch generates any output,
158 even merely for changed offsets.
160 * src/c99-to-c89.diff: Adjust to reflect new offsets.
162 * NEWS: Mention changes affecting df, pwd, shred.
164 2006-05-06 Jim Meyering <jim@meyering.net>
166 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
167 system condition where dirent.d_ino != stat.st_ino.
168 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
170 2006-05-06 Eric Blake <ebb9@byu.net>
172 * tests/ls/inode: Expand to test inode from readdir case.
173 * tests/ls/follow-slink: Expand to test broken links encountered
174 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
176 2006-05-06 Eric Blake <ebb9@byu.net>
178 * tests/mv/leak-fd: Work even on case-insensitive file system.
180 2006-05-04 Jim Meyering <jim@meyering.net>
182 * NEWS: Mention the 2006-03-19 pwd-related change that makes
183 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
185 2006-05-03 Jim Meyering <jim@meyering.net>
187 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
188 Use better macro parameter names: s/basename/key_name/,
189 s/basefunc/key_cmp_func. Fix typo in comment.
191 2006-04-29 Eric Blake <ebb9@byu.net>
193 * src/ls.c (main): On systems with d_type, directories_first only
194 implies format_needs_type, not format_needs_stat.
196 2006-05-03 Jim Meyering <jim@meyering.net>
198 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
199 after comma in arg list, from Eric Blake.
201 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
203 * tests/misc/date (relative-3): New test, derived from a bug
204 report by John Thomas McDole.
206 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
208 New option for ls: --group-directories-first.
209 It makes ls list directories before files.
210 * NEWS [New features]: Mention it.
211 * src/ls.c (sort_type): Rearrange to use as an array index when
212 choosing sort function; added new sort_numtypes member for
214 (time_type): Add new time_numtypes member for compile-time check.
215 (directories_first): New global variable.
216 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
217 (long_options): Add --directories-first.
218 (main): Support new option.
219 (is_directory): New function.
220 (extract_dirs_from_files): Use it.
221 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
222 (LIST_SORTFUNCTION_VARIANTS): New macros.
223 (sort_functions): New global variable.
224 (sort_files): Use it.
225 (usage): Document new option.
227 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
229 * src/shred.c (fillrand): The assertion was way too weak, due to
230 what must be a typo. Strengthen it to its intended value.
231 (dopass): Don't use alloca; it's not worth the aggravation here,
232 since it's used only to get a page-aligned buffer, and page
233 alignment doesn't buy us much here. I'm suspicious that alloca
234 causes problems on some hosts, due to a recent bug report by Adam
235 Waltman: http://bugs.gentoo.org/130246.
237 2006-04-18 Jim Meyering <jim@meyering.net>
239 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
240 sha384sum, sha512sum.
242 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
244 * src/chmod.c (describe_change): Adjust to filemode changes.
245 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
246 (print_long_format): Use (new) filemodestring rather than
247 (old) mode_string, so that we get more file types right, at least
248 in theory. Adjust to filemode changes.
249 * src/stat.c (human_access): Likewise.
251 2006-04-18 Jim Meyering <jim@meyering.net>
253 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
254 ignore file. This has never been enabled. Reported by Eric Blake.
256 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
258 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
259 bug in Interix. Just call symlink or link directly. All uses changed.
260 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
261 * src/stat.c (USE_STATVFS): New macro.
262 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
263 (NAMEMAX_FORMAT): define a bit more clearly, now that the
264 statvfs-using code is a bit more regular.
265 * src/system.h (sync) [!HAVE_SYNC]: New macro.
267 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
269 * NEWS: csplit, nl, expr now conform to POSIX better, and are
270 more-compatible with traditional Unix, with respect to regular
272 * src/csplit.c (extract_regexp): Set re_syntax_options to a
273 value that is compatible with what POSIX requires.
274 * src/nl.c (build_type_arg): Likewise.
275 * src/expr.c (docolon): Likewise. Also, don't let anchors match
276 newline; this fixes an incompatibility with tradition and with POSIX.
277 Don't warn about leading ^. POSIX says it is unspecified whether
278 ^ is a special character, which means that implementations can
279 either treat it as special or not, but either way a warning is not
280 allowed (unless the regexp is otherwise invalid). Instead, anchor
281 the expression but treat ^ as an anchor; this is the traditional
282 behavior (e.g., Solaris 10).
283 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
284 and the like as invalid expressions (exit status 2), not as
285 failure of 'expr' (exit status 3). This is more consistent with
287 * tests/expr/basic (fail-a): Adjust exit status to match new expr
288 behavior, for status 2 versus 3.
290 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
291 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
292 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
293 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
294 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
295 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
296 (bre61, bre62): New tests.
297 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
301 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
302 "if !". Do not assume that 'sed' can handle long, newline-free input.
303 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
305 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
307 Adjust to new regex.h API (with new fastmap type), and clean
308 up the regex storage allocation a bit.
310 * src/csplit.c (struct control): Put re_compiled member at the
311 end, since it's large. Change regexpr member from char * to bool;
312 all uses changed. Add new member fastmap.
313 (extract_regexp): regexp arg is now char const *, not char *.
314 Don't bother duplicating the regular expression; it's not needed.
315 Set fastmap from new fastmap member. Don't bother allocating
316 a buffer, as the regexp code does a better job than we do.
317 * src/expr.c (docolon): Allocate and use a fastmap.
318 Don't bother allocating a buffer.
319 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
321 (build_type_arg): New fastmap arg. All uses changed.
322 Don't bother allocating a buffer, but set a fastmap.
323 * src/ptx.c (context_regex_string, word_regex_string): Remove.
324 (context_regex, word_regex): New vars, replacing the above.
326 (struct regex_data): New type.
327 (compile_regex): Renamed from alloc_and_compile_regex, since
328 we no longer allocate storage. Arg is now a struct regex_data *,
329 not a const char *. All uses changed. Don't allocate the fastmap;
330 instead, take it from the caller. Don't convert size_t to int,
331 to avoid arithmetic overflow problems. Don't bother freeing
332 storage afterwards; it's not worth the aggravation.
333 * src/tac.c (compiled_separator_fastmap): New ver.
334 (main): Use it. Don't bother allocating a buffer.
336 2006-03-30 Jim Meyering <jim@meyering.net>
338 * src/dd.c (iwrite): Remove assignment without effect.
339 Reported by Felix Rauch Valenti.
341 2006-03-22 Eric Blake <ebb9@byu.net>
343 * src/ptx.c (usage): Remove mention of --copyright/-C.
344 (main): Alias --copyright to --version plus a deprecation warning.
345 * NEWS: Mention this.
347 2006-03-27 Jim Meyering <jim@meyering.net>
349 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
350 use of strtod. Tiny patch from Nickolai Zeldovich.
352 2006-03-11 Eric Blake <ebb9@byu.net>
354 * tests/misc/dirname: New file.
355 * tests/basename/Makefile.am: Delete.
356 * tests/basename/basic: Move to...
357 * tests/misc/basename: ... this new file. Add some tests,
358 including fixed behavior for //.
359 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
360 * tests/Makefile.am (SUBDIRS): Remove basename.
361 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
363 Improvements to dirname/basename handling on platforms like
364 cygwin with distinct // and with drive letters.
365 * NEWS: Document new behavior.
366 * src/basename.c (main): Don't strip suffix from file system
368 * src/cp.c (target_directory_operand): Use new last_component.
369 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
370 traversing the string.
371 * src/dircolors.c (guess_shell_syntax): Use new last_component.
372 * src/install.c (target_directory_operand, install_file_in_dir):
374 * src/ln.c (target_directory_operand, main): Likewise.
375 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
376 * src/mv.c (target_directory_operand, movefile): Likewise.
377 * src/remove.c (rm_1): Likewise.
378 * src/shred.c (wipename): Likewise.
379 * src/split.c (next_file_name): Likewise.
380 * src/su.c (log_su, run_shell): Likewise.
382 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
384 * NEWS: nohup diagnostics are now more precise, and nohup now
385 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
386 * src/nohup.c (main): Implement this.
387 * tests/misc/nohup: Test the new behavior.
389 2006-03-12 Jim Meyering <jim@meyering.net>
391 * src/copy.c (set_author): Rename function, from preserve_author.
393 * src/remove.c (AD_pop_and_chdir): Use new macro,
394 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
396 * src/system.h (SAME_INODE): Remove definition.
397 Include "same-inode.h", instead.
399 2006-03-11 Eric Blake <ebb9@byu.net>
401 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
403 2006-03-10 Jim Meyering <jim@meyering.net>
405 Fix a bug whereby a user with write access to a directory being removed
406 could cause the removal of that directory to fail with an erroneous
407 diagnostic about a directory cycle. Reported by Vineet Chadha.
409 * NEWS: Mention this.
410 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
411 leave (and try to rmdir) is the one whose dev_ino is being used to
412 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
414 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
416 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
417 * src/dd.c (set_fd_flags): Handle file-creation flags on file
418 descriptors, rather than ignoring them.
419 * tests/dd/misc: Add test cases for append, nofollow, directory,
420 and nolinks flags. Simplify redirection to /dev/null in some cases.
422 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
423 noatime test never tested anything.
425 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
427 * src/dd.c (flags, usage): New flags directory, nolinks.
428 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
430 * src/ls.c (usage): Mention that -f disables --color.
431 Problem reported by Niels Möller.
433 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
435 * man/*.x: Add references to syscalls from utilities of the same name.
437 2006-03-05 Jim Meyering <jim@meyering.net>
439 * tests/help-version: Set SHELL, if not already set, in order to
440 avoid failure when `make check' is run through debuild; dircolors
441 would fail due to lack of $SHELL. Reported by Sven Joachim.
443 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
444 * src/base64.c (wrap_write, do_encode, main): Change type of
445 parameters and locals, wrap_column, form size_t to uintmax_t.
446 (main): Adjust to use xstrtoumax, accordingly.
448 2006-03-03 Jim Meyering <jim@meyering.net>
450 Don't fail when run from an environment with SHELL not a Bourne
451 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
452 * tests/dircolors/simple: Invoke each non-failing test with -b.
453 Reported by Michael Stone.
455 2006-02-27 Jim Meyering <jim@meyering.net>
457 * tests/misc/base64: Derive --decode-using tests from the
460 * tests/misc/base64: Factor out a long constant string.
461 Split lines to stay within 80 columns.
463 * tests/misc/Makefile.am (TESTS): Add base64.
464 * tests/misc/base64: Test base64. From Simon Josefsson.
466 * src/base64.c (do_decode): Use correct type for parameter,
467 ignore_garbage: s/size_t/bool/.
469 * src/base64.c: Don't include .h files already included by system.h:
470 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
471 Include "system.h" before the other lib/*.h header files.
472 Include <sys/types.h> before "system.h".
473 (wrap_write): Remove declaration of unused local, initial_column.
474 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
476 * README: Add base64 to the list.
478 2006-02-17 Simon Josefsson <jas@extundo.com>
481 * AUTHORS: Mention base64.
483 * man/Makefile.am: Build base64.1.
484 * man/base64.x: New file.
485 * src/Makefile.am (bin_PROGRAMS): Add base64.
486 * src/base64.c: New file.
488 2006-02-25 Eric Blake <ebb9@byu.net>
490 In ls, avoid calling stat for --inode (-i), when possible.
491 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
492 * src/system.h: ... here, for use in ...
493 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
495 (gobble_file): Add inode argument.
496 (print_dir): Pass inode if available.
497 (usage): Remove inaccuracy.
499 2006-02-23 Jim Meyering <jim@meyering.net>
501 * TODO: Update/correct some obsolete entries.
503 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
505 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
506 * src/join.c (usage): Likewise.
507 Documentation problem reported by Philip Kensche.
509 2006-02-20 Eric Blake <ebb9@byu.net>
511 * man/rm.x: Update documentation to match previous patch.
513 2006-02-18 Eric Blake <ebb9@byu.net>
515 New option for rm: --interactive=once (-I).
516 * NEWS: Document it, along with change to rm --interactive.
517 * TODO: Remove entry for implementing rm -I
518 * src/rm.c (INTERACTIVE_OPTION): New enum value.
519 (interactive_type): New enum.
520 (long_opts): Let interactive take an optional argument.
521 (interactive_args, interactive_types): New option arguments.
522 (usage): Document -I, --interactive=WHEN. Use program_name
523 instead of a basename.
524 (main): New -I option, new behavior to --interactive.
525 * tests/rm/interactive-once: New tests.
526 * tests/rm/interactive-always: Ditto.
527 * tests/rm/Makefile.am (TESTS): Run them.
529 2006-02-18 Jim Meyering <jim@meyering.net>
531 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
532 expression match more of the target lines, e.g., those that start with
533 `-S,' (short option followed by a comma) or that include `=[...]'.
534 Patch by Nicolas François.
535 Fix the four offenders thus exposed:
536 * src/join.c (usage): Use two spaces (not one) to separate the
537 --first-only option string from its description, so help2man formats
538 the derived man page properly.
539 * src/pr.c (usage): Likewise.
540 * src/uniq.c (usage): Likewise.
541 * src/install.c (usage): Likewise.
543 2006-02-15 Jim Meyering <jim@meyering.net>
545 * Makefile.maint (alpha beta major): For `make major', ensure that the
546 version string is of the form N.N[.N]*, where N is one or more digits.
548 2006-02-14 Jim Meyering <jim@meyering.net>
550 * INSTALL: Update from gnulib.
552 2006-02-13 Jim Meyering <jim@meyering.net>
554 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
556 2006-02-12 Jim Meyering <jim@meyering.net>
558 * Makefile.maint (patch-check): New target.
559 (local-checks-available): Add to the list.
561 2006-02-11 Jim Meyering <jim@meyering.net>
563 * src/c99-to-c89.diff: New file.
564 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
566 * .x-po-check: New file, with exclusions so that `make distcheck'
568 * Makefile.am (EXTRA_DIST): Add .x-po-check.
570 rm -r must remove an empty directory, even if it is inaccessible.
571 * src/remove.c (close_preserve_errno): New function.
572 (fd_to_subdirp): Don't print a diagnostic in this function.
573 Do it from the callers instead, unless rmdir succeeds.
574 (remove_cwd_entries, remove_dir): Adjust callers.
575 * tests/rm/empty-inacc: New test for the above.
576 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
577 * NEWS: Mention this bug fix.
578 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
579 a tiny bit less precise: cannot remove `a/1': ... instead of
580 cannot open directory `a/1': ...
582 * Makefile.maint (syntax-check-rules): Automatically derive this
583 list of sc_-prefixed rule names.
585 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
587 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
588 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
589 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
590 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
591 go away? was that an accident?)
592 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
593 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
594 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
595 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
596 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
597 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
598 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
599 (author_mark_check, makefile_path_separator_check):
600 Output line numbers, to simplify navigation of Emacs *compilation*
602 (sc_prohibit_atoi_atof, sc_file_system):
603 Rework slightly so that Makefile.maint doesn't get reported as a
604 violation of its own syntax rules.
605 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
606 it at run-time (which didn't work with Bison). Fix a makefile typo,
607 caught by Makefile.maint itself: spaces where a tab should be.
608 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
609 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
610 Ignore djgpp and man subdirectories, to avoid false matches with
611 Bison and coreutils, respectively. Use sort -u to remove the
612 resulting duplicates.
613 * gnupload: Rework slightly to avoid bogus warning from
614 sc_two_space_separator_in_usage.
616 2006-02-10 Jim Meyering <jim@meyering.net>
618 Use gzip's --rsyncable option only if it's available.
619 * Makefile.maint (gzip_rsyncable): New variable.
622 2006-02-08 Jim Meyering <jim@meyering.net>
624 * Makefile.maint (local-checks-available): Define in terms of
625 the expansion, $(syntax-check-rules), rather than the single,
626 top-level target `syntax-check', so that it's easier to exclude
627 individual rules (via $(local-checks-to-skip)).
628 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
630 2006-02-07 Jim Meyering <jim@meyering.net>
632 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
633 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
635 * tests/help-version (expected_failure_status_vdir):
636 Redirect an expected disk-full diagnostic to /dev/null.
638 2006-02-06 Jim Meyering <jim@meyering.net>
640 * src/unexpand.c (usage): Use two spaces (not one) to separate the
641 --first-only option string from its description, so help2man formats
642 the derived man page properly.
643 * src/rm.c (usage): Likewise for --no-preserve-root.
644 * src/chown.c (usage): Likewise.
645 * src/chgrp.c (usage): Likewise.
647 Add a rule to ensure that the above doesn't happen again.
648 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
649 (syntax-check-rules): Add it.
650 * .x-sc_two_space_separator_in_usage: New empty file.
651 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
653 2006-02-06 Jim Meyering <jim@meyering.net>
655 * src/cp.c (usage): Use two spaces (not one) to separate each
656 option string from its description, so help2man formats the
657 derived man page properly.
658 * src/mv.c (usage): Likewise.
659 Patch from Nicolas François in http://bugs.debian.org/351601.
661 2006-02-04 Jim Meyering <jim@meyering.net>
663 * src/copy.c (copy_internal): cp -RL would fail when encountering
664 the same directory more than once in the hierarchy beneath a single
665 command-line argument. That is legitimate, e.g. when there are
666 two or more symbolic links, each pointing to some directory that
667 would not otherwise be copied. Reported by Christophe LYON.
668 * tests/cp/cp-deref: New file. Test for today's fix.
669 * tests/cp/Makefile.am (TESTS): Add cp-deref.
670 * NEWS: Document this.
672 2006-02-03 Jim Meyering <jim@meyering.net>
674 * configure.ac: Require automake-1.9.6, not 1.8.3.
676 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
678 * src/od.c (usage): Mention that -t a ignores high order bit.
679 Documentation problem reported by Ed Avis.
681 2006-02-01 Jim Meyering <jim@meyering.net>
683 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
685 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
687 * src/head.c (main): Use a better diagnostic when someone uses a
688 trailing numeric option in an invalid way. Problem reported by
690 * src/tail.c (parse_options): Likewise.
692 2006-01-30 Jim Meyering <jim@meyering.net>
694 * man/wc.x: Include `count' keyword in man page synopsis,
695 per suggestion from http://bugs.debian.org/181585.
697 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
699 * src/df.c (show_dev): If the file system claims to have
700 more available than total blocks, report the number of used
701 blocks as being total - available (a negative number) rather
702 than as garbage. Problem reported by Toralf Foerster.
704 2006-01-24 Jim Meyering <jim@meyering.net>
706 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
707 to put a regular file in O_NONBLOCK mode fails with EPERM.
708 That happens on Linux (up to 2.6.15) when using tail -f on a file with
709 the append-only attribute. Reported by Dean Gaudet. For details,
710 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
711 * NEWS: Mention this fix.
712 * tests/tail-2/append-only: New file. Test for the above.
713 * tests/tail-2/Makefile.am (TESTS): Add append-only.
714 * tests/Makefile.am (check-root): Add tail-2/append-only
716 2006-01-21 Jim Meyering <jim@meyering.net>
718 * NEWS: Mention fts-related improvements and bug fixes.
720 2006-01-19 Jim Meyering <jim@meyering.net>
722 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
723 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
725 2006-01-18 Jim Meyering <jim@meyering.net>
727 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
729 2006-01-17 Jim Meyering <jim@meyering.net>
731 Now that fts no longer changes the current working directory, adjust
732 its clients accordingly -- note that du.c uses fts but doesn't need
733 any adjustment, since it doesn't operate on the actual files,
734 but rather just uses the stat buffers provided by fts.
736 * src/chown-core.c: Include "openat.h".
737 Don't include "lchown.h".
738 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
739 calling openat, lchownat, chownat, rather than open, lchown, chown.
741 * src/chmod.c: Include "openat.h".
742 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
744 * tests/du/long-from-unreadable: New test, to exercise one small
747 2006-01-13 Jim Meyering <jim@meyering.net>
749 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
750 addition of new directories under tests/.
752 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
755 2006-01-12 Jim Meyering <jim@meyering.net>
757 * tests/du/long-sloop: Adjust not to hard-code the expected
758 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
759 from that of GNU libc. Reported by Paul Eggert.
761 * tests/du/long-sloop: Create file at end of symlink chain.
763 * tests/misc/test: New file, with a test for one of the
764 bugs fixed by yesterday's test.c changes.
765 * tests/misc/Makefile.am (TESTS): Add test.
767 2006-01-11 Jim Meyering <jim@meyering.net>
769 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
770 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
771 a very long sequence of symbolic links (not necessarily a loop).
772 * tests/du/Makefile.am (TESTS): Add long-sloop.
774 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
776 * src/test.c (test_syntax_error): Append a newline. All callers
777 changed, except for the ones that didn't already append a newline.
778 Bug reported by Eric Blake.
780 2006-01-11 Jim Meyering <jim@meyering.net>
782 * src/system.h (X2NREALLOC): Now that verify_true is no longer
783 void, cast its result to void, to avoid gcc's warning that
784 ``left-hand operand of comma expression has no effect''.
785 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
787 2006-01-10 Jim Meyering <jim@meyering.net>
789 * tests/chmod/no-x: Add a test for today's fts.c fix.
791 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
793 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
794 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
796 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
798 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
799 Use verify_true instead of verify_expr, to sync with gnulib.
801 2006-01-08 Jim Meyering <jim@meyering.net>
803 * src/date.c (usage): Adjust the formatting of the entries for
804 %::z and %:::z (separate with two spaces, not one) so that help2man
805 formats them properly. Reported by Philip Rowlands.
807 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
809 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
811 2006-01-06 Jim Meyering <jim@meyering.net>
813 * Makefile.maint (copyright-check): Use date +%Y in place of
816 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
817 First off, the attribute should have been `volatile' (not static)
818 to avoid longjmp-related risk of clobber. Secondly, now there is
819 no longer any risk of a local variable being clobbered, so there's
820 no need for any attribute at all.
822 2006-01-05 Jim Meyering <jim@meyering.net>
824 * src/remove.c: Give a few functions the inline attribute.
825 (AD_pop_and_chdir): Use gotos to avoid some duplication.
826 (AD_push): Rewrite an assertion so that the entire computation
827 goes away when assertions are turned off.
829 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
830 It's already defined in "system.h".
831 * Makefile.maint: Add a FIXME comment.
833 2006-01-04 Jim Meyering <jim@meyering.net>
835 * ChangeLog: Remove entries from 2005-10-22 and earlier.
836 * ChangeLog-2005: New file, for entries up to version 5.92.
838 2006-01-03 Jim Meyering <jim@meyering.net>
840 * tests/du/no-x: Also allow a slightly different diagnostic -- the
841 one you get when using openat-enabled fts.c and du (coming soon).
842 * tests/chmod/no-x: Likewise.
843 * tests/chgrp/no-x: Likewise.
845 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
847 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
849 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
850 (restricted_chown): Return it, if the file cannot be accessed due
851 to EPERM, or if no uid or gid are required, or if the file is
852 neither a directory nor a regular file. Rewrite to avoid gotos.
853 (change_file_owner): Handle RC_do_ordinary_chown case.
854 Rewrite to avoid gotos.
855 * tests/chgrp/basic: Make sure we can change the group of
858 * src/date.c (usage): Explain %g, %G, and %V a bit better.
860 2006-01-02 Jim Meyering <jim@meyering.net>
862 * src/copy.c (set_owner): Correct a comment.
864 * src/tail.c (parse_options): Change warning to say that --retry
865 is useful `mainly' (not `only') when following by name.
866 Reported here: http://bugs.debian.org/273781
868 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
870 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
871 * src/copy.c: Include lchmod.h.
872 (copy_internal): Use lchmod rather than chmod.
873 * src/cp.c: Include lchmod.h.
874 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
875 * src/mkdir.c: Include lchmod.h.
876 (usage): Clarify -m's operation.
877 (main): Use lchmod rather than chmod. Don't use lchmod unless the
878 new mode contains bits outside the 777 range.
879 * src/mkfifo.c (usage): Clarify -m's operation.
880 (main): If -m is given, don't invoke chmod; use umask 0 instead.
881 Report an error if -m asks for bits outside the 777 range.
882 * src/mknod.c (usage, main): Likewise.
884 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
886 2005-12-27 Jim Meyering <jim@meyering.net>
888 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
889 (sc_prohibit_assert_without_use): New rule.
890 (syntax-check-rules): Add it to the list.
891 * .x-sc_prohibit_assert_without_use: New empty file.
892 * Makefile.am (EXTRA_DIST): Add it.
894 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
896 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
897 Don't include <assert.h>; it wasn't used.
899 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
901 * src/chown-core.c (restricted_chown):
902 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
903 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
904 | O_NOFOLLOW too, for consistency with other dir-openers.
905 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
906 (is_empty_dir): Likewise.
907 * src/shred.c (wipename): Likewise. Don't bother trying to open
908 dir for writing, since POSIX prohibits it.
910 2005-12-22 Jim Meyering <jim@meyering.net>
912 * tests/help-version: Redirect stderr to /dev/full, to suppress
913 write error diagnostic.
915 2005-12-19 Jim Meyering <jim@meyering.net>
917 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
918 Avoid a minor race condition when `-m MODE' is specified, by using
919 open, fchown, and close rather than just chown. To do that reliably --
920 even with an overly restrictive umask -- ensure that each mkdir,
921 mknod and mkfifo call uses a mode including at least owner-read access.
922 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
923 the subsequent chown (or equivalent open,fchown,close) fails.
924 * tests/misc/mknod: New tests.
925 * tests/misc/Makefile.am (TESTS): Add mknod.
927 2005-12-17 Jim Meyering <jim@meyering.net>
929 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
930 e.g., on a named pipe.
931 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
932 place of all uses, since it is guaranteed (system.h) to be defined.
934 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
936 Add POSIX ACL support
937 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
938 is no requirement for ACL support; particularly, it does not exist
939 on systems that have POSIX ACLs.
940 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
941 * src/cp.c (umask_kill): With default acls, the umask is not to be
942 applied. Remove umask_kill, don't change the process umask, and let
943 the kernel apply the umask where appropriate.
944 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
945 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
947 (copy_reg, copy_internal): Use copy_acl and set_acl
948 instead of fchown/chown. Fix the logic for POSIX ACLs.
949 (chown_succeded): Remove; we now always copy acls and
950 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
951 did a chown before or not.
952 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
953 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
954 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
955 to link with it via $(LIB_ACL), for the utilities that need it.
957 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
959 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
960 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
961 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
962 value is now signified by whether cwd_errno is null.
963 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
964 pointer-to-bool to pointer-to-errno-value. All callers changed.
965 (rm_1): Don't bother setting a local cwd failure flag and then
966 ORing it into the caller's. Just set the caller's.
967 (rm): Use cwd failure errno value to print a slightly-better
970 2005-12-15 Jim Meyering <jim@meyering.net>
972 * src/stat.c (print_it): Properly handle a backslash at the
973 end of a --printf format string. Reported by Paul Eggert.
974 * tests/misc/stat-printf (end-bs): Add a test for the above.
976 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
978 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
979 Don't assume /etc/passwd contains user names; use 'id' instead.
981 2005-12-15 Jim Meyering <jim@meyering.net>
983 stat: revert behavior of --format=FMT (-c)
984 stat: add new option: --printf=FMT
985 * NEWS: Mention this.
986 * src/stat.c (isodigit, octtobin, hextobin): Define.
987 (PRINTF_OPTION): Define.
988 (interpret_backslash_escapes, trailing_delim): New globals.
989 (usage): Document them. Alphabetize on long option names.
990 (print_esc_char): New function.
991 (print_it): Rewrite, in order to handle backslash escapes.
992 (main): Handle new option. Set globals for --format, too.
994 * tests/misc/stat-printf: Test --printf and --format.
995 * tests/misc/Makefile.am (TESTS): Add stat-printf.
997 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
999 * NEWS: sort now reports incompatible options.
1000 * src/sort.c (incompatible_options, check_ordering_compatibility):
1002 (main): Use them. Don't bother with a usage message for
1003 "sort -c a b", for consistency with other error diagnostics.
1004 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1007 * src/cat.c (main): Undo previous change. close_stdout already
1008 does the check, so the previous change wasn't necessary.
1010 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1012 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1014 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1016 Install a more-conservative approach for sort -R. It's the
1017 same basic idea as the existing code, except it uses the full ISAAC
1018 approach (called the "more kosher" approach in the existing comments).
1019 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1020 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1021 better to be conservative here at first, and review any performance
1022 improvements carefully.
1023 * .x-sc_require_config_h: Add src/rand-isaac.c.
1024 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1025 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1026 (shred_SOURCES, sort_SOURCES): Remove.
1027 (EXTRA_DIST): Add rand-isaac.c.
1028 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1029 changing it to allow for varying numbers of words in the state.
1030 Alter so that we include rand-isaac.c directly rather than
1031 compiling it and linking to it. Don't include config.h or
1032 system.h; that's the includer's responsibility.
1033 Omit functions that are specific to shred.
1034 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1035 (isaac_step, struct irand_state):
1036 Resurrect these, with the same defns that used to be in shred.c.
1037 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1038 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1040 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1041 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1042 (irand_init, irand32, irand_mod):
1043 Number of words is constant again.
1044 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1045 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1046 * src/sort.c: Likewise.
1047 * src/shred.c (fillrand, dopass, main): Undo previous change.
1048 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1050 * src/sort.c: Don't include md5.h; it wasn't needed.
1051 (struct keyfield): Rename random_hash to random, for consistency
1052 with the other member names. All uses changed.
1053 (usage): Tweak wording to mention STRING for --seed option.
1054 (short_options): Rorder for consistency with other programs.
1055 (rand_state): Now a struct, not a pointer to one. All uses changed.
1056 (HASH_WORDS, HASH_SIZE): Remove.
1057 (get_hash): Remove comments around resbuf size, since we can assume C89.
1058 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1059 (keycompare): Adjust to the new get_hash.
1061 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1062 (main): Don't set need_random simply because gkey has it set; that
1063 doesn't necessarily mean we'll need random numbers.
1064 Redo seeding to match new get_hash approach.
1066 2005-12-10 Jim Meyering <jim@meyering.net>
1068 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1070 Avoid shred segfault on 64-bit systems.
1071 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1072 local of type uint32_t. Make the local an `int' instead.
1074 * NEWS: Mention sort's new options.
1076 * src/rand-isaac.c (isaac_mix): Declare to be static.
1077 Mark all other functions as `extern' so the tight-scope
1078 part of `make distcheck' passes once again.
1079 * src/rand-isaac.h (isaac_mix): Remove declaration.
1081 * src/sort.c (get_hash): Change position of `*' in parameter
1082 type to conform with convention.
1083 (main): Split a long line so it fits in 80 columns.
1084 (keycompare): Remove stray SPACE before TAB that was
1085 causing `make distcheck' to fail.
1087 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1089 * tests/misc/sort-rand: New file: basic tests for the new options.
1090 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1092 2005-12-10 Frederik Eaton <frederik@ofb.net>
1094 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1095 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1096 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1097 Make state size runtime-configurable.
1098 (isaac_new, isaac_copy): New functions.
1099 * src/rand-isaac.h: New file.
1100 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1101 (fillrand, main): Adjust to the fact that the state size is now
1102 runtime-configurable.
1103 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1104 (usage): Add options --random-sort and --seed to implement a random
1106 Include md5.h and rand-isaac.h.
1107 (get_hash): New function.
1108 (rand_state): New var.
1109 (HASH_WORDS, HASH_SIZE): New macros.
1111 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1113 * tests/dd/misc: Add test for dd iflags=noatime.
1115 2005-12-09 Jim Meyering <jim@meyering.net>
1117 * src/sort.c (usage): Mention white space vs -b and -t options.
1120 2005-12-09 Eric Blake <ebb9@byu.net>
1122 * src/test.c (main): Fix misleading comment.
1124 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1126 * NEWS: Mention dd's new noatime flag.
1127 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1128 * src/dd.c (flags, usage): Add support for noatime flag.
1130 2005-12-07 Jim Meyering <jim@meyering.net>
1132 Distribute the cvsu script, used only by `make syntax-check'.
1133 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1134 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1135 distribute a copy of this script.
1136 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1138 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1139 to create a temporary directory on another partition.
1140 From Andreas Gruenbacher.
1142 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1144 * man/basename.x: Cross-reference to dirname and readlink.
1145 * man/dirname.x: Cross-reference to basename and readlink.
1147 2005-12-05 Andreas Gruenbacher
1149 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1150 (set_owner, preserve_author): New functions, factored out of copy_reg.
1151 (copy_reg): Use them.
1152 (copy_internal): Use them here, too.
1154 2005-12-04 Jim Meyering <jim@meyering.net>
1156 * src/sleep.c (usage): Say what happens with two or more arguments.
1157 Suggested by Justin Pryzby.
1159 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1162 2005-12-03 Jim Meyering <jim@meyering.net>
1164 * src/rm.c (long_opts): Change the name of each undocumented, for-
1165 testing-only option to start with `-', so that it cannot render
1166 ambiguous any prefix it happens to share with some other option name.
1167 Problem reported by Eric Blake.
1168 * src/head.c (long_options): Likewise.
1169 * src/tail.c (long_options): Likewise.
1171 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1172 testing-only --presume* options to start with `---'.
1173 * tests/rm/dangling-symlink: Likewise.
1174 * tests/rm/dir-no-w: Likewise.
1175 * tests/rm/isatty: Likewise.
1177 2005-11-30 Jim Meyering <jim@meyering.net>
1179 * Makefile.maint: Add a comment about cvsu.
1181 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1183 * NEWS: df updates for "none", "proc", inaccessible file systems.
1184 * src/df.c (show_point): Ignore inaccessible file systems.
1185 (usage): -a includes dummy file systems, not size-0 file systems.
1187 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1188 to avoid collision with POSIX name space. All uses changed.
1190 2005-11-24 Jim Meyering <jim@meyering.net>
1192 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1193 * tests/acl: Add `$0: ' prefix to diagnostics.
1195 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1197 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1199 * src/copy.c: Improve performance a bit by optimizing away
1200 unnecessary system calls and going to a block size of at least
1201 8192 (on normal hosts, anyway). This improved performance 5% on my
1202 Debian stable host (2.4.27 kernel, x86, copying from root
1203 ext3 file system to itself).
1204 Include "buffer-lcm.h".
1205 (copy_reg): Omit last argument. All callers changed.
1206 Use xmalloc to allocate rather than trusting alloca
1207 (which is unwise with large block sizes).
1208 Declare locals more locally, if possible.
1209 Use uintptr_t words instead of int words, for a bit more speed
1210 when looking for null blocks on 64-bit hosts.
1211 Optimize away reads of zero bytes on regular files.
1212 In the typical case, insist on 8 KiB buffers, at least.
1213 Avoid unnecessary extra call to fstat when checking for sparse files.
1214 Avoid now-unnecessary cast to off_t, and "0L".
1215 Avoid unnecessary test of *new_dst when checking for same owner
1218 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1220 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1222 2005-11-22 Jim Meyering <jim@meyering.net>
1224 * src/remove.c (AD_push): Remove debugging cruft.
1226 * tests/rm/unread2 (rm): Change expected diagnostic,
1227 `cannot open directory' to `cannot remove', to align with
1229 * tests/rm/rm2: Ensure that rm now continues removing entries
1230 even after certain types of failure.
1232 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1233 that provide openat (Solaris), and on systems like Linux+procfs
1234 where our openat emulation code is reentrant. This also fixes a
1235 few low-probability leaks and eliminates some code that could,
1236 in very unusual circumstances, cause rm() (via a callee) to exit.
1237 * NEWS: Mention this.
1239 * configure.ac: Put copyright dates all on one line so the
1240 emacs function that updates them works properly.
1242 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1244 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1245 Problem reported by Eric Blake.
1246 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1247 we get a standard-conforming compiler. This relies on the new
1248 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1249 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1250 m4/c.m4 can go away with Autoconf 2.60 comes out.
1252 2005-11-17 Jim Meyering <jim@meyering.net>
1254 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1255 (AD_mark_current_as_unremovable): Likewise, but for a local.
1258 * tests/mv/acl: Let traps handle removing temporary directories.
1260 Expect acl-related tests to fail, until the corresponding
1261 patches are committed.
1262 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1263 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1265 ACL tests, from Andreas Gruenbacher.
1266 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1267 * tests/mv/Makefile.am (TESTS): Add acl.
1268 * tests/cp/Makefile.am (TESTS): Add acl.
1270 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1272 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1274 * NEWS: Improve quality of ln's diagnostics.
1275 * src/ln.c (do_link, usage): Likewise.
1276 (do_link): Don't use alloca on a buffer of unbounded size.
1278 2005-11-16 Jim Meyering <jim@meyering.net>
1280 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1281 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1282 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1283 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1284 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1286 2005-11-14 Jim Meyering <jim@meyering.net>
1288 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1290 2005-11-13 Jim Meyering <jim@meyering.net>
1292 * announce-gen: Accept new option, --gpg-key-id=ID and
1293 emit a blurb telling how to use the .sig files.
1294 * Makefile.cfg (gpg_key_ID): Define.
1295 * Makefile.maint (announcement): Use new option and key.
1297 Require that most .c files include <config.h>.
1298 * Makefile.maint (sc_require_config_h): New rule.
1299 (syntax-check-rules): Add it.
1300 * .x-sc_require_config_h: New file listing exceptions to the
1301 above rule. Some are legit, others are simply grandfathered in.
1302 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1304 2005-11-12 Jim Meyering <jim@meyering.net>
1306 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1308 2005-11-11 Jim Meyering <jim@meyering.net>
1310 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1311 Mention new readlink options in 5.3.0's `New features' section.
1312 Spotted by Thomas Hood.
1314 2005-11-08 Jim Meyering <jim@meyering.net>
1316 * NEWS: Merge in changes from b5_9x branch.
1318 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1320 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1321 like --time-style='posix-long-iso' if the locale settings are messed up.
1322 * src/ls.c (decode_switches): Implement this.
1324 2005-11-08 Jim Meyering <jim@meyering.net>
1326 * tests/du/2g: s/expensive/very expensive/ in a comment.
1329 2005-10-17 Eric Blake <ebb9@byu.net>
1331 * src/ls.c (usage): Fix descriptions of --sort, --time.
1332 Reported by Vitaly A. Ostanin.
1334 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1336 * src/ln.c: Include filenamecat.c.
1337 (FILE_BASENAME_CONCAT): Remove.
1338 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1339 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1340 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1343 2005-11-04 Jim Meyering <jim@meyering.net>
1345 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1346 on systems with stat.st_blocks of a signed 32-bit type.
1347 This bug causes trouble on some AIX 5.1 systems.
1348 Report and trivial patch from Paul Townsend:
1349 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1350 * NEWS: Mention this.
1352 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1353 * tests/du/Makefile.am (TESTS): Add it here.
1354 * tests/very-expensive: New file.
1355 * tests/Makefile.am (EXTRA_DIST): Add it here.
1356 * tests/cp/perm: Mark this test as `very-expensive', too.
1358 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1360 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1362 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1364 * src/rm.c (usage): Don't mention rm -d.
1366 2005-11-02 Jim Meyering <jim@meyering.net>
1368 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1369 From Andreas Schwab.
1371 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1372 `M+N records in/out' lines don't pollute `make check' output.
1374 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1375 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1376 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1377 to indicate that the input file should be piped into the command
1378 under test (via `cat FILE | $prog ...').
1380 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1381 (without -r) fails to remove a directory on a non-Linux system.
1382 This change affects only newer Solaris systems (with priv_*
1383 functions like priv_allocset). Reported by Keith Thompson.
1385 * tests/rm/dir-nonrecur: New file/test for the above fix.
1386 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1388 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1390 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1391 POSIX 1002.1-2001 requires.
1392 * src/tail.c (parse_obsolete_option): Implement this.
1393 Problem reported by Vincent Lefevre.
1394 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1395 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1396 (test_vector): Add special cases for _POSIX2_VERSION, and
1397 regularize the old ones a bit.
1398 * tests/touch/obsolescent: Add y2000 test.
1400 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1402 * src/dd.c (skip): Fix off-by-one error reported by
1403 Theodoros V. Kalamatianos.
1405 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1407 * tests/mkdir/p-3: Require that the test be run as non-root.
1408 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1410 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1412 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1413 boundary between DEST and SOURCE in the result.
1415 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1417 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1418 back to text, to sync with documentation and for backwards
1421 2005-10-25 Jim Meyering <jim@meyering.net>
1423 * tests/dircolors/simple (other-wr): Add an explicit test for
1424 the dircolors bug (NULL-dereference) fixed yesterday.
1426 2005-10-24 Jim Meyering <jim@meyering.net>
1428 * src/tac.c (tac_file): When determining whether a file is seekable,
1429 also test whether it is a tty. Using only the lseek-based test would
1430 give a false positive on Solaris. Reported by Peter Fales.
1432 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1434 * tests/install/d-slashdot: New test, for "install -d" failure.
1435 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1436 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1437 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1439 2005-10-24 Jim Meyering <jim@meyering.net>
1441 * src/dircolors.c (ls_codes): Add missing comma.
1442 Anonymous report and patch from
1443 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1445 * src/dircolors.c: Add compile-time assertion that the slack_codes
1446 and ls_codes arrays have the same number of elements. This would
1447 have prevented the above-fixed bug.
1449 * src/expand.c (parse_tab_stops): Add a comment to make this function
1450 identical to the one in unexpand.c.
1451 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1452 identical to the one in expand.c.
1454 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1456 2005-10-23 Jim Meyering <jim@meyering.net>
1458 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1459 a dangerous pointer-value-to-`unsigned' cast.
1460 * NEWS: mention the new sha* programs.
1461 * AUTHORS: Add new sha* programs.
1463 2005-08-28 David Madore <david.madore@ens.fr>
1465 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1466 * README: Add their names to the list.
1467 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1468 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1469 Rules for compiling sha-2 utilities
1470 (noinst_HEADERS): Remove checksum.h.
1471 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1473 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1474 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1475 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1476 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1477 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1478 sha384sum, sha512sum test scripts here rather that each in its
1481 2005-08-28 David Madore <david.madore@ens.fr>
1483 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1484 of the FIPS test vectors).
1486 2005-10-23 Jim Meyering <jim@meyering.net>
1488 * configure.ac: Use 6.0-cvs as the version string.
1489 * NEWS: Adjust accordingly.