1 2006-06-28 Jim Meyering <jim@meyering.net>
3 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
5 2006-06-28 Bob Proulx <bob@proulx.com> (tiny change)
7 * tests/mv/i-link-no: Work around HP-UX /bin/sh tracing problem
8 (set -x when VERBOSE=yes) when stderr is redirected before stdout
9 causing shell tracing of the stdout redirection to be written to
10 the stderr file. Avoid problem and test failure on HP-UX by
11 redirecting stderr last.
12 * tests/dd/unblock-sync: Order shell file redirections for
13 stderr and stdout in the common style.
16 2006-06-27 Jim Meyering <jim@meyering.net>
18 * tests/misc/cat-proc: Try to avoid any spurious numeric
19 differences in frequently-changing /proc/cpuinfo.
20 Reported by Nelson Beebe.
22 2006-06-26 Jim Meyering <jim@meyering.net>
24 Attempt rmdir (actually, unlinkat-with-AT_REMOVEDIR) upon any
25 fd_to_subdirp failure, not just when errno == EACCES.
26 * src/remove.c (remove_dir): Use unlinkat-with-AT_REMOVEDIR, not
27 rmdir, here, even though rmdir may happen to be adequate.
29 * NEWS: rm no longer fails to remove an empty, unreadable directory
30 * src/remove.c (remove_cwd_entries): If we can't open a directory,
31 and the failure is not being ignored, try to remove the directory
32 with rmdir (aka unlinkat-with-AT_REMOVEDIR), in case it's empty.
33 Problem report and test case from Paul Eggert in
34 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7425>.
36 * tests/rm/empty-inacc: New test, for the above.
38 Avoid a segfault for wc --files0=- < /dev/null.
39 * src/wc.c (compute_number_width): Return right away if nfiles == 0.
41 2006-06-25 Jim Meyering <jim@meyering.net>
43 * NEWS: wc accepts a new option --files0-from=FILE, where FILE
44 contains a list of NUL-separated file names.
46 * src/wc.c: Include "readtokens.h".
47 (usage): Describe the new option, and adjust the `Usage':
48 with this option, no FILE may be specified on the command line.
49 (main): Handle the new option.
50 * tests/misc/wc-files0: New tests, for the above.
51 * tests/misc/wc-files0-from: Likewise.
52 * tests/misc/Makefile.am (TESTS): Add wc-files0.
54 2006-06-24 Jim Meyering <jim@meyering.net>
56 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
58 2006-06-22 Jim Meyering <jim@meyering.net>
60 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
61 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
63 2006-06-19 Jim Meyering <jim@meyering.net>
65 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
66 so this check is not run as part of "make distcheck".
68 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
70 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
72 2006-06-18 Jim Meyering <jim@meyering.net>
74 * tests/misc/pwd-long: Make error output a little clearer.
76 2006-06-17 Jim Meyering <jim@meyering.net>
78 * tests/rm/inaccessible: Skip this test on systems without openat
79 support. Reported by Bob Proulx.
81 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
83 * tests/misc/mknod: Improve permission checks to handle
84 running mkdir test in set-gid directories.
86 2006-06-14 Jim Meyering <jim@meyering.net>
88 * tests/du/basic: Revamp not to hard-code file system block sizes.
90 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
92 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
95 2006-06-11 Jim Meyering <jim@meyering.net>
97 * .gitignore: New file.
98 * Makefile.am (EXTRA_DIST): Add .gitignore.
100 Setting TIME_STYLE=long-iso in the environment would make the
101 cp/same-file test fail.
102 * tests/envvar-check (vars): Add TIME_STYLE to the list.
103 * tests/cp/same-file: Revert last change.
104 Source the envvar-check script, to ensure that TIME_STYLE
105 settings don't affect these tests.
107 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
109 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
110 uses POSIX time stamp formats. Problem reported by John Nixon in
111 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
113 2006-06-10 Jim Meyering <jim@meyering.net>
115 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
117 Require a "Version N.M" line at the top of the ChangeLog
118 file only when making the actual release, not when running
120 * Makefile.maint (maintainer-distcheck): Don't depend on
122 (alpha beta major): Depend on it here, instead.
124 2006-06-08 Jim Meyering <jim@meyering.net>
126 Ensure that cat works with any of the options, -A -v -e -E -T,
127 when applied to files in /proc and /sys, even when the FIONREAD
128 ioctl produces nonsensical results. Before this change, cat would
129 produce no output (or truncated output), for some linux kernels.
131 * src/cat.c (write_pending): New function, factored out of cat.
132 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
133 that there are bytes to read. Some versions of linux-2.6.16 do that.
134 Write any pending output before returning.
135 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
136 * NEWS: Mention this bug fix.
137 * tests/misc/cat-proc: New file. Test for the above.
138 * tests/misc/Makefile.am (TESTS): Add cat-proc.
140 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
142 * src/expr.c (eval4): Detect overflow properly when multiplying
145 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
147 * NEWS: The 'expr' command now detects and reports integer overflow.
148 (It would be better to use extended precision instead, but that
150 * src/expr.c (integer_overflow): New function.
151 (eval4, eval3): Check for integer overflow.
153 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
155 Fix problems when building with Solaris/SVR4/etc. make, which uses a
156 different and somewhat bogus implementation of VPATH. In the
157 directory tests/misc, rename tests whose names might appear in the
158 Automake-generated rules. For example, we can't use a test named
159 'test', since Automake generates a rule that contains the text
160 "if test -f ./$$tst; ...", and this might expand to something like
161 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
162 which executes the 'test' script rather than the 'test' command.
163 * tests/misc/false-status: Renamed from tests/misc/false.
164 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
165 * tests/misc/sort-merge: Renamed from tests/misc/sort.
166 ($prog): Set to 'sort' rather than to $PROG.
167 * tests/misc/test-diag: Renamed from tests/misc/test.
168 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
169 in case Solaris make has prepended the directory.
170 (TESTS): Adjust to above renamings.
171 * tests/misc/expand: Don't assign to PROG; no longer needed
172 now that Makefile.am sets PROG to the basename.
173 * tests/misc/fold: Likewise.
175 2006-06-03 Jim Meyering <jim@meyering.net>
177 Make `cp --link --no-dereference' work also on systems where the
178 link system call cannot create a hard link to a symbolic link.
179 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
180 the link syscall on a symlink when it would do the wrong thing.
181 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
182 * tests/cp/link-no-deref: New file/test for the above.
183 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
184 * NEWS: Mention the change (doesn't affect Linux).
186 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
188 Fix some porting problems in the test cases reported by
189 Ralf Wildenhues for HP-UX 11.23 in:
190 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
191 * tests/help-version: Don't assume that \< \> works in sed.
192 * tests/misc/close-stdout: Don't assume that >&- works.
193 Add a /dev/full test.
194 * tests/touch/no-create-missing: Don't assume that >&- works.
196 2006-05-30 Jim Meyering <jim@meyering.net>
198 * src/ls.c (usage): Add `v' to the list of sorting-related options.
201 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
203 * tests/cp/fail-perm: source lang-default.
204 * tests/rm/inaccessible: Likewise.
206 2006-05-28 Jim Meyering <jim@meyering.net>
208 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
209 Recognize it, too. Reported by Ralf Wildenhues, in
210 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
212 2006-05-27 Jim Meyering <jim@meyering.net>
214 * src/chgrp.c: Support new options: --preserve-root and
215 --no-preserve-root. Somehow this program was skipped when those
216 options were added to chown, chmod, and rm. Reported by
217 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
218 * NEWS: Mention this.
220 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
222 * NEWS: Remove mention of --seed. We'll replace it with something
223 better, and don't want to indicate that it is supported.
224 * src/sort.c (usage): Likewise.
226 2006-05-20 Jim Meyering <jim@meyering.net>
228 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
230 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
231 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
232 FTS_COMFOLLOW. Spotted by Justin Pryzby.
234 * gnupload: Merge changes from automake, retaining the ""--to...
235 kludge to placate overzealous `make distcheck' check.
237 2006-05-19 Jim Meyering <jim@meyering.net>
239 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
240 FTS_TIGHT_CYCLE_CHECK directory traversal option.
241 Reported by Justin Pryzby in http://bugs.debian.org/367691
243 2006-05-15 Jim Meyering <jim@meyering.net>
245 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
248 2006-05-13 Jim Meyering <jim@meyering.net>
250 * tests/mv/no-target-dir: Test two more cases.
252 2006-05-11 Jim Meyering <jim@meyering.net>
254 mv -T DIR EMPTY_DIR no longer fails unconditionally
255 * src/copy.c (copy_internal): Don't manually prohibit a move where
256 the destination is an existing directory. Sometimes doing that is
257 valid. Let the rename system call enforce the rules. That is
258 allowed only when the source is a directory and the destination
259 directory (to be replaced) is empty. Reported by Eric Blake.
260 * tests/mv/no-target-dir: New file/test for this.
261 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
262 * NEWS: Mention this.
264 * tests/mv/atomic: New file/test for yesterday's fix.
265 * tests/mv/Makefile.am (TESTS): Add atomic.
267 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
269 2006-05-10 Jim Meyering <jim@meyering.net>
271 * src/copy.c (copy_internal): Don't explicitly unlink the destination
272 when moving a symlink into the place of an existing non-directory.
273 Reported by Joshua Hudson.
274 * NEWS: mention this.
276 2006-05-07 Jim Meyering <jim@meyering.net>
278 * Makefile.maint (patch-check): Fail if patch generates any output,
279 even merely for changed offsets.
281 * src/c99-to-c89.diff: Adjust to reflect new offsets.
283 * NEWS: Mention changes affecting df, pwd, shred.
285 2006-05-06 Jim Meyering <jim@meyering.net>
287 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
288 system condition where dirent.d_ino != stat.st_ino.
289 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
291 2006-05-06 Eric Blake <ebb9@byu.net>
293 * tests/ls/inode: Expand to test inode from readdir case.
294 * tests/ls/follow-slink: Expand to test broken links encountered
295 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
297 2006-05-06 Eric Blake <ebb9@byu.net>
299 * tests/mv/leak-fd: Work even on case-insensitive file system.
301 2006-05-04 Jim Meyering <jim@meyering.net>
303 * NEWS: Mention the 2006-03-19 pwd-related change that makes
304 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
306 2006-05-03 Jim Meyering <jim@meyering.net>
308 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
309 Use better macro parameter names: s/basename/key_name/,
310 s/basefunc/key_cmp_func. Fix typo in comment.
312 2006-04-29 Eric Blake <ebb9@byu.net>
314 * src/ls.c (main): On systems with d_type, directories_first only
315 implies format_needs_type, not format_needs_stat.
317 2006-05-03 Jim Meyering <jim@meyering.net>
319 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
320 after comma in arg list, from Eric Blake.
322 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
324 * tests/misc/date (relative-3): New test, derived from a bug
325 report by John Thomas McDole.
327 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
329 New option for ls: --group-directories-first.
330 It makes ls list directories before files.
331 * NEWS [New features]: Mention it.
332 * src/ls.c (sort_type): Rearrange to use as an array index when
333 choosing sort function; added new sort_numtypes member for
335 (time_type): Add new time_numtypes member for compile-time check.
336 (directories_first): New global variable.
337 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
338 (long_options): Add --directories-first.
339 (main): Support new option.
340 (is_directory): New function.
341 (extract_dirs_from_files): Use it.
342 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
343 (LIST_SORTFUNCTION_VARIANTS): New macros.
344 (sort_functions): New global variable.
345 (sort_files): Use it.
346 (usage): Document new option.
348 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
350 * src/shred.c (fillrand): The assertion was way too weak, due to
351 what must be a typo. Strengthen it to its intended value.
352 (dopass): Don't use alloca; it's not worth the aggravation here,
353 since it's used only to get a page-aligned buffer, and page
354 alignment doesn't buy us much here. I'm suspicious that alloca
355 causes problems on some hosts, due to a recent bug report by Adam
356 Waltman: http://bugs.gentoo.org/130246.
358 2006-04-18 Jim Meyering <jim@meyering.net>
360 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
361 sha384sum, sha512sum.
363 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
365 * src/chmod.c (describe_change): Adjust to filemode changes.
366 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
367 (print_long_format): Use (new) filemodestring rather than
368 (old) mode_string, so that we get more file types right, at least
369 in theory. Adjust to filemode changes.
370 * src/stat.c (human_access): Likewise.
372 2006-04-18 Jim Meyering <jim@meyering.net>
374 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
375 ignore file. This has never been enabled. Reported by Eric Blake.
377 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
379 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
380 bug in Interix. Just call symlink or link directly. All uses changed.
381 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
382 * src/stat.c (USE_STATVFS): New macro.
383 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
384 (NAMEMAX_FORMAT): define a bit more clearly, now that the
385 statvfs-using code is a bit more regular.
386 * src/system.h (sync) [!HAVE_SYNC]: New macro.
388 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
390 * NEWS: csplit, nl, expr now conform to POSIX better, and are
391 more-compatible with traditional Unix, with respect to regular
393 * src/csplit.c (extract_regexp): Set re_syntax_options to a
394 value that is compatible with what POSIX requires.
395 * src/nl.c (build_type_arg): Likewise.
396 * src/expr.c (docolon): Likewise. Also, don't let anchors match
397 newline; this fixes an incompatibility with tradition and with POSIX.
398 Don't warn about leading ^. POSIX says it is unspecified whether
399 ^ is a special character, which means that implementations can
400 either treat it as special or not, but either way a warning is not
401 allowed (unless the regexp is otherwise invalid). Instead, anchor
402 the expression but treat ^ as an anchor; this is the traditional
403 behavior (e.g., Solaris 10).
404 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
405 and the like as invalid expressions (exit status 2), not as
406 failure of 'expr' (exit status 3). This is more consistent with
408 * tests/expr/basic (fail-a): Adjust exit status to match new expr
409 behavior, for status 2 versus 3.
411 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
412 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
413 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
414 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
415 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
416 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
417 (bre61, bre62): New tests.
418 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
422 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
423 "if !". Do not assume that 'sed' can handle long, newline-free input.
424 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
426 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
428 Adjust to new regex.h API (with new fastmap type), and clean
429 up the regex storage allocation a bit.
431 * src/csplit.c (struct control): Put re_compiled member at the
432 end, since it's large. Change regexpr member from char * to bool;
433 all uses changed. Add new member fastmap.
434 (extract_regexp): regexp arg is now char const *, not char *.
435 Don't bother duplicating the regular expression; it's not needed.
436 Set fastmap from new fastmap member. Don't bother allocating
437 a buffer, as the regexp code does a better job than we do.
438 * src/expr.c (docolon): Allocate and use a fastmap.
439 Don't bother allocating a buffer.
440 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
442 (build_type_arg): New fastmap arg. All uses changed.
443 Don't bother allocating a buffer, but set a fastmap.
444 * src/ptx.c (context_regex_string, word_regex_string): Remove.
445 (context_regex, word_regex): New vars, replacing the above.
447 (struct regex_data): New type.
448 (compile_regex): Renamed from alloc_and_compile_regex, since
449 we no longer allocate storage. Arg is now a struct regex_data *,
450 not a const char *. All uses changed. Don't allocate the fastmap;
451 instead, take it from the caller. Don't convert size_t to int,
452 to avoid arithmetic overflow problems. Don't bother freeing
453 storage afterwards; it's not worth the aggravation.
454 * src/tac.c (compiled_separator_fastmap): New ver.
455 (main): Use it. Don't bother allocating a buffer.
457 2006-03-30 Jim Meyering <jim@meyering.net>
459 * src/dd.c (iwrite): Remove assignment without effect.
460 Reported by Felix Rauch Valenti.
462 2006-03-22 Eric Blake <ebb9@byu.net>
464 * src/ptx.c (usage): Remove mention of --copyright/-C.
465 (main): Alias --copyright to --version plus a deprecation warning.
466 * NEWS: Mention this.
468 2006-03-27 Jim Meyering <jim@meyering.net>
470 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
471 use of strtod. Tiny patch from Nickolai Zeldovich.
473 2006-03-11 Eric Blake <ebb9@byu.net>
475 * tests/misc/dirname: New file.
476 * tests/basename/Makefile.am: Delete.
477 * tests/basename/basic: Move to...
478 * tests/misc/basename: ... this new file. Add some tests,
479 including fixed behavior for //.
480 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
481 * tests/Makefile.am (SUBDIRS): Remove basename.
482 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
484 Improvements to dirname/basename handling on platforms like
485 cygwin with distinct // and with drive letters.
486 * NEWS: Document new behavior.
487 * src/basename.c (main): Don't strip suffix from file system
489 * src/cp.c (target_directory_operand): Use new last_component.
490 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
491 traversing the string.
492 * src/dircolors.c (guess_shell_syntax): Use new last_component.
493 * src/install.c (target_directory_operand, install_file_in_dir):
495 * src/ln.c (target_directory_operand, main): Likewise.
496 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
497 * src/mv.c (target_directory_operand, movefile): Likewise.
498 * src/remove.c (rm_1): Likewise.
499 * src/shred.c (wipename): Likewise.
500 * src/split.c (next_file_name): Likewise.
501 * src/su.c (log_su, run_shell): Likewise.
503 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
505 * NEWS: nohup diagnostics are now more precise, and nohup now
506 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
507 * src/nohup.c (main): Implement this.
508 * tests/misc/nohup: Test the new behavior.
510 2006-03-12 Jim Meyering <jim@meyering.net>
512 * src/copy.c (set_author): Rename function, from preserve_author.
514 * src/remove.c (AD_pop_and_chdir): Use new macro,
515 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
517 * src/system.h (SAME_INODE): Remove definition.
518 Include "same-inode.h", instead.
520 2006-03-11 Eric Blake <ebb9@byu.net>
522 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
524 2006-03-10 Jim Meyering <jim@meyering.net>
526 Fix a bug whereby a user with write access to a directory being removed
527 could cause the removal of that directory to fail with an erroneous
528 diagnostic about a directory cycle. Reported by Vineet Chadha.
530 * NEWS: Mention this.
531 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
532 leave (and try to rmdir) is the one whose dev_ino is being used to
533 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
535 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
537 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
538 * src/dd.c (set_fd_flags): Handle file-creation flags on file
539 descriptors, rather than ignoring them.
540 * tests/dd/misc: Add test cases for append, nofollow, directory,
541 and nolinks flags. Simplify redirection to /dev/null in some cases.
543 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
544 noatime test never tested anything.
546 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
548 * src/dd.c (flags, usage): New flags directory, nolinks.
549 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
551 * src/ls.c (usage): Mention that -f disables --color.
552 Problem reported by Niels Möller.
554 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
556 * man/*.x: Add references to syscalls from utilities of the same name.
558 2006-03-05 Jim Meyering <jim@meyering.net>
560 * tests/help-version: Set SHELL, if not already set, in order to
561 avoid failure when `make check' is run through debuild; dircolors
562 would fail due to lack of $SHELL. Reported by Sven Joachim.
564 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
565 * src/base64.c (wrap_write, do_encode, main): Change type of
566 parameters and locals, wrap_column, form size_t to uintmax_t.
567 (main): Adjust to use xstrtoumax, accordingly.
569 2006-03-03 Jim Meyering <jim@meyering.net>
571 Don't fail when run from an environment with SHELL not a Bourne
572 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
573 * tests/dircolors/simple: Invoke each non-failing test with -b.
574 Reported by Michael Stone.
576 2006-02-27 Jim Meyering <jim@meyering.net>
578 * tests/misc/base64: Derive --decode-using tests from the
581 * tests/misc/base64: Factor out a long constant string.
582 Split lines to stay within 80 columns.
584 * tests/misc/Makefile.am (TESTS): Add base64.
585 * tests/misc/base64: Test base64. From Simon Josefsson.
587 * src/base64.c (do_decode): Use correct type for parameter,
588 ignore_garbage: s/size_t/bool/.
590 * src/base64.c: Don't include .h files already included by system.h:
591 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
592 Include "system.h" before the other lib/*.h header files.
593 Include <sys/types.h> before "system.h".
594 (wrap_write): Remove declaration of unused local, initial_column.
595 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
597 * README: Add base64 to the list.
599 2006-02-17 Simon Josefsson <jas@extundo.com>
602 * AUTHORS: Mention base64.
604 * man/Makefile.am: Build base64.1.
605 * man/base64.x: New file.
606 * src/Makefile.am (bin_PROGRAMS): Add base64.
607 * src/base64.c: New file.
609 2006-02-25 Eric Blake <ebb9@byu.net>
611 In ls, avoid calling stat for --inode (-i), when possible.
612 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
613 * src/system.h: ... here, for use in ...
614 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
616 (gobble_file): Add inode argument.
617 (print_dir): Pass inode if available.
618 (usage): Remove inaccuracy.
620 2006-02-23 Jim Meyering <jim@meyering.net>
622 * TODO: Update/correct some obsolete entries.
624 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
626 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
627 * src/join.c (usage): Likewise.
628 Documentation problem reported by Philip Kensche.
630 2006-02-20 Eric Blake <ebb9@byu.net>
632 * man/rm.x: Update documentation to match previous patch.
634 2006-02-18 Eric Blake <ebb9@byu.net>
636 New option for rm: --interactive=once (-I).
637 * NEWS: Document it, along with change to rm --interactive.
638 * TODO: Remove entry for implementing rm -I
639 * src/rm.c (INTERACTIVE_OPTION): New enum value.
640 (interactive_type): New enum.
641 (long_opts): Let interactive take an optional argument.
642 (interactive_args, interactive_types): New option arguments.
643 (usage): Document -I, --interactive=WHEN. Use program_name
644 instead of a basename.
645 (main): New -I option, new behavior to --interactive.
646 * tests/rm/interactive-once: New tests.
647 * tests/rm/interactive-always: Ditto.
648 * tests/rm/Makefile.am (TESTS): Run them.
650 2006-02-18 Jim Meyering <jim@meyering.net>
652 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
653 expression match more of the target lines, e.g., those that start with
654 `-S,' (short option followed by a comma) or that include `=[...]'.
655 Patch by Nicolas François.
656 Fix the four offenders thus exposed:
657 * src/join.c (usage): Use two spaces (not one) to separate the
658 --first-only option string from its description, so help2man formats
659 the derived man page properly.
660 * src/pr.c (usage): Likewise.
661 * src/uniq.c (usage): Likewise.
662 * src/install.c (usage): Likewise.
664 2006-02-15 Jim Meyering <jim@meyering.net>
666 * Makefile.maint (alpha beta major): For `make major', ensure that the
667 version string is of the form N.N[.N]*, where N is one or more digits.
669 2006-02-14 Jim Meyering <jim@meyering.net>
671 * INSTALL: Update from gnulib.
673 2006-02-13 Jim Meyering <jim@meyering.net>
675 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
677 2006-02-12 Jim Meyering <jim@meyering.net>
679 * Makefile.maint (patch-check): New target.
680 (local-checks-available): Add to the list.
682 2006-02-11 Jim Meyering <jim@meyering.net>
684 * src/c99-to-c89.diff: New file.
685 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
687 * .x-po-check: New file, with exclusions so that `make distcheck'
689 * Makefile.am (EXTRA_DIST): Add .x-po-check.
691 rm -r must remove an empty directory, even if it is inaccessible.
692 * src/remove.c (close_preserve_errno): New function.
693 (fd_to_subdirp): Don't print a diagnostic in this function.
694 Do it from the callers instead, unless rmdir succeeds.
695 (remove_cwd_entries, remove_dir): Adjust callers.
696 * tests/rm/empty-inacc: New test for the above.
697 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
698 * NEWS: Mention this bug fix.
699 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
700 a tiny bit less precise: cannot remove `a/1': ... instead of
701 cannot open directory `a/1': ...
703 * Makefile.maint (syntax-check-rules): Automatically derive this
704 list of sc_-prefixed rule names.
706 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
708 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
709 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
710 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
711 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
712 go away? was that an accident?)
713 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
714 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
715 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
716 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
717 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
718 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
719 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
720 (author_mark_check, makefile_path_separator_check):
721 Output line numbers, to simplify navigation of Emacs *compilation*
723 (sc_prohibit_atoi_atof, sc_file_system):
724 Rework slightly so that Makefile.maint doesn't get reported as a
725 violation of its own syntax rules.
726 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
727 it at run-time (which didn't work with Bison). Fix a makefile typo,
728 caught by Makefile.maint itself: spaces where a tab should be.
729 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
730 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
731 Ignore djgpp and man subdirectories, to avoid false matches with
732 Bison and coreutils, respectively. Use sort -u to remove the
733 resulting duplicates.
734 * gnupload: Rework slightly to avoid bogus warning from
735 sc_two_space_separator_in_usage.
737 2006-02-10 Jim Meyering <jim@meyering.net>
739 Use gzip's --rsyncable option only if it's available.
740 * Makefile.maint (gzip_rsyncable): New variable.
743 2006-02-08 Jim Meyering <jim@meyering.net>
745 * Makefile.maint (local-checks-available): Define in terms of
746 the expansion, $(syntax-check-rules), rather than the single,
747 top-level target `syntax-check', so that it's easier to exclude
748 individual rules (via $(local-checks-to-skip)).
749 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
751 2006-02-07 Jim Meyering <jim@meyering.net>
753 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
754 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
756 * tests/help-version (expected_failure_status_vdir):
757 Redirect an expected disk-full diagnostic to /dev/null.
759 2006-02-06 Jim Meyering <jim@meyering.net>
761 * src/unexpand.c (usage): Use two spaces (not one) to separate the
762 --first-only option string from its description, so help2man formats
763 the derived man page properly.
764 * src/rm.c (usage): Likewise for --no-preserve-root.
765 * src/chown.c (usage): Likewise.
766 * src/chgrp.c (usage): Likewise.
768 Add a rule to ensure that the above doesn't happen again.
769 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
770 (syntax-check-rules): Add it.
771 * .x-sc_two_space_separator_in_usage: New empty file.
772 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
774 2006-02-06 Jim Meyering <jim@meyering.net>
776 * src/cp.c (usage): Use two spaces (not one) to separate each
777 option string from its description, so help2man formats the
778 derived man page properly.
779 * src/mv.c (usage): Likewise.
780 Patch from Nicolas François in http://bugs.debian.org/351601.
782 2006-02-04 Jim Meyering <jim@meyering.net>
784 * src/copy.c (copy_internal): cp -RL would fail when encountering
785 the same directory more than once in the hierarchy beneath a single
786 command-line argument. That is legitimate, e.g. when there are
787 two or more symbolic links, each pointing to some directory that
788 would not otherwise be copied. Reported by Christophe LYON.
789 * tests/cp/cp-deref: New file. Test for today's fix.
790 * tests/cp/Makefile.am (TESTS): Add cp-deref.
791 * NEWS: Document this.
793 2006-02-03 Jim Meyering <jim@meyering.net>
795 * configure.ac: Require automake-1.9.6, not 1.8.3.
797 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
799 * src/od.c (usage): Mention that -t a ignores high order bit.
800 Documentation problem reported by Ed Avis.
802 2006-02-01 Jim Meyering <jim@meyering.net>
804 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
806 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
808 * src/head.c (main): Use a better diagnostic when someone uses a
809 trailing numeric option in an invalid way. Problem reported by
811 * src/tail.c (parse_options): Likewise.
813 2006-01-30 Jim Meyering <jim@meyering.net>
815 * man/wc.x: Include `count' keyword in man page synopsis,
816 per suggestion from http://bugs.debian.org/181585.
818 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
820 * src/df.c (show_dev): If the file system claims to have
821 more available than total blocks, report the number of used
822 blocks as being total - available (a negative number) rather
823 than as garbage. Problem reported by Toralf Foerster.
825 2006-01-24 Jim Meyering <jim@meyering.net>
827 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
828 to put a regular file in O_NONBLOCK mode fails with EPERM.
829 That happens on Linux (up to 2.6.15) when using tail -f on a file with
830 the append-only attribute. Reported by Dean Gaudet. For details,
831 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
832 * NEWS: Mention this fix.
833 * tests/tail-2/append-only: New file. Test for the above.
834 * tests/tail-2/Makefile.am (TESTS): Add append-only.
835 * tests/Makefile.am (check-root): Add tail-2/append-only
837 2006-01-21 Jim Meyering <jim@meyering.net>
839 * NEWS: Mention fts-related improvements and bug fixes.
841 2006-01-19 Jim Meyering <jim@meyering.net>
843 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
844 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
846 2006-01-18 Jim Meyering <jim@meyering.net>
848 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
850 2006-01-17 Jim Meyering <jim@meyering.net>
852 Now that fts no longer changes the current working directory, adjust
853 its clients accordingly -- note that du.c uses fts but doesn't need
854 any adjustment, since it doesn't operate on the actual files,
855 but rather just uses the stat buffers provided by fts.
857 * src/chown-core.c: Include "openat.h".
858 Don't include "lchown.h".
859 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
860 calling openat, lchownat, chownat, rather than open, lchown, chown.
862 * src/chmod.c: Include "openat.h".
863 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
865 * tests/du/long-from-unreadable: New test, to exercise one small
868 2006-01-13 Jim Meyering <jim@meyering.net>
870 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
871 addition of new directories under tests/.
873 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
876 2006-01-12 Jim Meyering <jim@meyering.net>
878 * tests/du/long-sloop: Adjust not to hard-code the expected
879 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
880 from that of GNU libc. Reported by Paul Eggert.
882 * tests/du/long-sloop: Create file at end of symlink chain.
884 * tests/misc/test: New file, with a test for one of the
885 bugs fixed by yesterday's test.c changes.
886 * tests/misc/Makefile.am (TESTS): Add test.
888 2006-01-11 Jim Meyering <jim@meyering.net>
890 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
891 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
892 a very long sequence of symbolic links (not necessarily a loop).
893 * tests/du/Makefile.am (TESTS): Add long-sloop.
895 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
897 * src/test.c (test_syntax_error): Append a newline. All callers
898 changed, except for the ones that didn't already append a newline.
899 Bug reported by Eric Blake.
901 2006-01-11 Jim Meyering <jim@meyering.net>
903 * src/system.h (X2NREALLOC): Now that verify_true is no longer
904 void, cast its result to void, to avoid gcc's warning that
905 ``left-hand operand of comma expression has no effect''.
906 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
908 2006-01-10 Jim Meyering <jim@meyering.net>
910 * tests/chmod/no-x: Add a test for today's fts.c fix.
912 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
914 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
915 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
917 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
919 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
920 Use verify_true instead of verify_expr, to sync with gnulib.
922 2006-01-08 Jim Meyering <jim@meyering.net>
924 * src/date.c (usage): Adjust the formatting of the entries for
925 %::z and %:::z (separate with two spaces, not one) so that help2man
926 formats them properly. Reported by Philip Rowlands.
928 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
930 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
932 2006-01-06 Jim Meyering <jim@meyering.net>
934 * Makefile.maint (copyright-check): Use date +%Y in place of
937 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
938 First off, the attribute should have been `volatile' (not static)
939 to avoid longjmp-related risk of clobber. Secondly, now there is
940 no longer any risk of a local variable being clobbered, so there's
941 no need for any attribute at all.
943 2006-01-05 Jim Meyering <jim@meyering.net>
945 * src/remove.c: Give a few functions the inline attribute.
946 (AD_pop_and_chdir): Use gotos to avoid some duplication.
947 (AD_push): Rewrite an assertion so that the entire computation
948 goes away when assertions are turned off.
950 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
951 It's already defined in "system.h".
952 * Makefile.maint: Add a FIXME comment.
954 2006-01-04 Jim Meyering <jim@meyering.net>
956 * ChangeLog: Remove entries from 2005-10-22 and earlier.
957 * ChangeLog-2005: New file, for entries up to version 5.92.
959 2006-01-03 Jim Meyering <jim@meyering.net>
961 * tests/du/no-x: Also allow a slightly different diagnostic -- the
962 one you get when using openat-enabled fts.c and du (coming soon).
963 * tests/chmod/no-x: Likewise.
964 * tests/chgrp/no-x: Likewise.
966 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
968 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
970 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
971 (restricted_chown): Return it, if the file cannot be accessed due
972 to EPERM, or if no uid or gid are required, or if the file is
973 neither a directory nor a regular file. Rewrite to avoid gotos.
974 (change_file_owner): Handle RC_do_ordinary_chown case.
975 Rewrite to avoid gotos.
976 * tests/chgrp/basic: Make sure we can change the group of
979 * src/date.c (usage): Explain %g, %G, and %V a bit better.
981 2006-01-02 Jim Meyering <jim@meyering.net>
983 * src/copy.c (set_owner): Correct a comment.
985 * src/tail.c (parse_options): Change warning to say that --retry
986 is useful `mainly' (not `only') when following by name.
987 Reported here: http://bugs.debian.org/273781
989 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
991 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
992 * src/copy.c: Include lchmod.h.
993 (copy_internal): Use lchmod rather than chmod.
994 * src/cp.c: Include lchmod.h.
995 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
996 * src/mkdir.c: Include lchmod.h.
997 (usage): Clarify -m's operation.
998 (main): Use lchmod rather than chmod. Don't use lchmod unless the
999 new mode contains bits outside the 777 range.
1000 * src/mkfifo.c (usage): Clarify -m's operation.
1001 (main): If -m is given, don't invoke chmod; use umask 0 instead.
1002 Report an error if -m asks for bits outside the 777 range.
1003 * src/mknod.c (usage, main): Likewise.
1005 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
1007 2005-12-27 Jim Meyering <jim@meyering.net>
1009 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
1010 (sc_prohibit_assert_without_use): New rule.
1011 (syntax-check-rules): Add it to the list.
1012 * .x-sc_prohibit_assert_without_use: New empty file.
1013 * Makefile.am (EXTRA_DIST): Add it.
1015 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
1017 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
1018 Don't include <assert.h>; it wasn't used.
1020 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
1022 * src/chown-core.c (restricted_chown):
1023 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
1024 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
1025 | O_NOFOLLOW too, for consistency with other dir-openers.
1026 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
1027 (is_empty_dir): Likewise.
1028 * src/shred.c (wipename): Likewise. Don't bother trying to open
1029 dir for writing, since POSIX prohibits it.
1031 2005-12-22 Jim Meyering <jim@meyering.net>
1033 * tests/help-version: Redirect stderr to /dev/full, to suppress
1034 write error diagnostic.
1036 2005-12-19 Jim Meyering <jim@meyering.net>
1038 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
1039 Avoid a minor race condition when `-m MODE' is specified, by using
1040 open, fchown, and close rather than just chown. To do that reliably --
1041 even with an overly restrictive umask -- ensure that each mkdir,
1042 mknod and mkfifo call uses a mode including at least owner-read access.
1043 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
1044 the subsequent chown (or equivalent open,fchown,close) fails.
1045 * tests/misc/mknod: New tests.
1046 * tests/misc/Makefile.am (TESTS): Add mknod.
1048 2005-12-17 Jim Meyering <jim@meyering.net>
1050 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
1051 e.g., on a named pipe.
1052 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
1053 place of all uses, since it is guaranteed (system.h) to be defined.
1055 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
1057 Add POSIX ACL support
1058 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
1059 is no requirement for ACL support; particularly, it does not exist
1060 on systems that have POSIX ACLs.
1061 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1062 * src/cp.c (umask_kill): With default acls, the umask is not to be
1063 applied. Remove umask_kill, don't change the process umask, and let
1064 the kernel apply the umask where appropriate.
1065 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1066 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1068 (copy_reg, copy_internal): Use copy_acl and set_acl
1069 instead of fchown/chown. Fix the logic for POSIX ACLs.
1070 (chown_succeded): Remove; we now always copy acls and
1071 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1072 did a chown before or not.
1073 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1074 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1075 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1076 to link with it via $(LIB_ACL), for the utilities that need it.
1078 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1080 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1081 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1082 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1083 value is now signified by whether cwd_errno is null.
1084 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1085 pointer-to-bool to pointer-to-errno-value. All callers changed.
1086 (rm_1): Don't bother setting a local cwd failure flag and then
1087 ORing it into the caller's. Just set the caller's.
1088 (rm): Use cwd failure errno value to print a slightly-better
1091 2005-12-15 Jim Meyering <jim@meyering.net>
1093 * src/stat.c (print_it): Properly handle a backslash at the
1094 end of a --printf format string. Reported by Paul Eggert.
1095 * tests/misc/stat-printf (end-bs): Add a test for the above.
1097 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1099 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1100 Don't assume /etc/passwd contains user names; use 'id' instead.
1102 2005-12-15 Jim Meyering <jim@meyering.net>
1104 stat: revert behavior of --format=FMT (-c)
1105 stat: add new option: --printf=FMT
1106 * NEWS: Mention this.
1107 * src/stat.c (isodigit, octtobin, hextobin): Define.
1108 (PRINTF_OPTION): Define.
1109 (interpret_backslash_escapes, trailing_delim): New globals.
1110 (usage): Document them. Alphabetize on long option names.
1111 (print_esc_char): New function.
1112 (print_it): Rewrite, in order to handle backslash escapes.
1113 (main): Handle new option. Set globals for --format, too.
1115 * tests/misc/stat-printf: Test --printf and --format.
1116 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1118 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1120 * NEWS: sort now reports incompatible options.
1121 * src/sort.c (incompatible_options, check_ordering_compatibility):
1123 (main): Use them. Don't bother with a usage message for
1124 "sort -c a b", for consistency with other error diagnostics.
1125 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1128 * src/cat.c (main): Undo previous change. close_stdout already
1129 does the check, so the previous change wasn't necessary.
1131 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1133 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1135 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1137 Install a more-conservative approach for sort -R. It's the
1138 same basic idea as the existing code, except it uses the full ISAAC
1139 approach (called the "more kosher" approach in the existing comments).
1140 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1141 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1142 better to be conservative here at first, and review any performance
1143 improvements carefully.
1144 * .x-sc_require_config_h: Add src/rand-isaac.c.
1145 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1146 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1147 (shred_SOURCES, sort_SOURCES): Remove.
1148 (EXTRA_DIST): Add rand-isaac.c.
1149 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1150 changing it to allow for varying numbers of words in the state.
1151 Alter so that we include rand-isaac.c directly rather than
1152 compiling it and linking to it. Don't include config.h or
1153 system.h; that's the includer's responsibility.
1154 Omit functions that are specific to shred.
1155 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1156 (isaac_step, struct irand_state):
1157 Resurrect these, with the same defns that used to be in shred.c.
1158 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1159 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1161 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1162 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1163 (irand_init, irand32, irand_mod):
1164 Number of words is constant again.
1165 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1166 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1167 * src/sort.c: Likewise.
1168 * src/shred.c (fillrand, dopass, main): Undo previous change.
1169 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1171 * src/sort.c: Don't include md5.h; it wasn't needed.
1172 (struct keyfield): Rename random_hash to random, for consistency
1173 with the other member names. All uses changed.
1174 (usage): Tweak wording to mention STRING for --seed option.
1175 (short_options): Rorder for consistency with other programs.
1176 (rand_state): Now a struct, not a pointer to one. All uses changed.
1177 (HASH_WORDS, HASH_SIZE): Remove.
1178 (get_hash): Remove comments around resbuf size, since we can assume C89.
1179 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1180 (keycompare): Adjust to the new get_hash.
1182 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1183 (main): Don't set need_random simply because gkey has it set; that
1184 doesn't necessarily mean we'll need random numbers.
1185 Redo seeding to match new get_hash approach.
1187 2005-12-10 Jim Meyering <jim@meyering.net>
1189 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1191 Avoid shred segfault on 64-bit systems.
1192 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1193 local of type uint32_t. Make the local an `int' instead.
1195 * NEWS: Mention sort's new options.
1197 * src/rand-isaac.c (isaac_mix): Declare to be static.
1198 Mark all other functions as `extern' so the tight-scope
1199 part of `make distcheck' passes once again.
1200 * src/rand-isaac.h (isaac_mix): Remove declaration.
1202 * src/sort.c (get_hash): Change position of `*' in parameter
1203 type to conform with convention.
1204 (main): Split a long line so it fits in 80 columns.
1205 (keycompare): Remove stray SPACE before TAB that was
1206 causing `make distcheck' to fail.
1208 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1210 * tests/misc/sort-rand: New file: basic tests for the new options.
1211 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1213 2005-12-10 Frederik Eaton <frederik@ofb.net>
1215 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1216 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1217 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1218 Make state size runtime-configurable.
1219 (isaac_new, isaac_copy): New functions.
1220 * src/rand-isaac.h: New file.
1221 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1222 (fillrand, main): Adjust to the fact that the state size is now
1223 runtime-configurable.
1224 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1225 (usage): Add options --random-sort and --seed to implement a random
1227 Include md5.h and rand-isaac.h.
1228 (get_hash): New function.
1229 (rand_state): New var.
1230 (HASH_WORDS, HASH_SIZE): New macros.
1232 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1234 * tests/dd/misc: Add test for dd iflags=noatime.
1236 2005-12-09 Jim Meyering <jim@meyering.net>
1238 * src/sort.c (usage): Mention white space vs -b and -t options.
1241 2005-12-09 Eric Blake <ebb9@byu.net>
1243 * src/test.c (main): Fix misleading comment.
1245 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1247 * NEWS: Mention dd's new noatime flag.
1248 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1249 * src/dd.c (flags, usage): Add support for noatime flag.
1251 2005-12-07 Jim Meyering <jim@meyering.net>
1253 Distribute the cvsu script, used only by `make syntax-check'.
1254 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1255 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1256 distribute a copy of this script.
1257 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1259 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1260 to create a temporary directory on another partition.
1261 From Andreas Gruenbacher.
1263 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1265 * man/basename.x: Cross-reference to dirname and readlink.
1266 * man/dirname.x: Cross-reference to basename and readlink.
1268 2005-12-05 Andreas Gruenbacher
1270 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1271 (set_owner, preserve_author): New functions, factored out of copy_reg.
1272 (copy_reg): Use them.
1273 (copy_internal): Use them here, too.
1275 2005-12-04 Jim Meyering <jim@meyering.net>
1277 * src/sleep.c (usage): Say what happens with two or more arguments.
1278 Suggested by Justin Pryzby.
1280 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1283 2005-12-03 Jim Meyering <jim@meyering.net>
1285 * src/rm.c (long_opts): Change the name of each undocumented, for-
1286 testing-only option to start with `-', so that it cannot render
1287 ambiguous any prefix it happens to share with some other option name.
1288 Problem reported by Eric Blake.
1289 * src/head.c (long_options): Likewise.
1290 * src/tail.c (long_options): Likewise.
1292 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1293 testing-only --presume* options to start with `---'.
1294 * tests/rm/dangling-symlink: Likewise.
1295 * tests/rm/dir-no-w: Likewise.
1296 * tests/rm/isatty: Likewise.
1298 2005-11-30 Jim Meyering <jim@meyering.net>
1300 * Makefile.maint: Add a comment about cvsu.
1302 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1304 * NEWS: df updates for "none", "proc", inaccessible file systems.
1305 * src/df.c (show_point): Ignore inaccessible file systems.
1306 (usage): -a includes dummy file systems, not size-0 file systems.
1308 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1309 to avoid collision with POSIX name space. All uses changed.
1311 2005-11-24 Jim Meyering <jim@meyering.net>
1313 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1314 * tests/acl: Add `$0: ' prefix to diagnostics.
1316 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1318 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1320 * src/copy.c: Improve performance a bit by optimizing away
1321 unnecessary system calls and going to a block size of at least
1322 8192 (on normal hosts, anyway). This improved performance 5% on my
1323 Debian stable host (2.4.27 kernel, x86, copying from root
1324 ext3 file system to itself).
1325 Include "buffer-lcm.h".
1326 (copy_reg): Omit last argument. All callers changed.
1327 Use xmalloc to allocate rather than trusting alloca
1328 (which is unwise with large block sizes).
1329 Declare locals more locally, if possible.
1330 Use uintptr_t words instead of int words, for a bit more speed
1331 when looking for null blocks on 64-bit hosts.
1332 Optimize away reads of zero bytes on regular files.
1333 In the typical case, insist on 8 KiB buffers, at least.
1334 Avoid unnecessary extra call to fstat when checking for sparse files.
1335 Avoid now-unnecessary cast to off_t, and "0L".
1336 Avoid unnecessary test of *new_dst when checking for same owner
1339 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1341 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1343 2005-11-22 Jim Meyering <jim@meyering.net>
1345 * src/remove.c (AD_push): Remove debugging cruft.
1347 * tests/rm/unread2 (rm): Change expected diagnostic,
1348 `cannot open directory' to `cannot remove', to align with
1350 * tests/rm/rm2: Ensure that rm now continues removing entries
1351 even after certain types of failure.
1353 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1354 that provide openat (Solaris), and on systems like Linux+procfs
1355 where our openat emulation code is reentrant. This also fixes a
1356 few low-probability leaks and eliminates some code that could,
1357 in very unusual circumstances, cause rm() (via a callee) to exit.
1358 * NEWS: Mention this.
1360 * configure.ac: Put copyright dates all on one line so the
1361 emacs function that updates them works properly.
1363 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1365 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1366 Problem reported by Eric Blake.
1367 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1368 we get a standard-conforming compiler. This relies on the new
1369 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1370 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1371 m4/c.m4 can go away with Autoconf 2.60 comes out.
1373 2005-11-17 Jim Meyering <jim@meyering.net>
1375 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1376 (AD_mark_current_as_unremovable): Likewise, but for a local.
1379 * tests/mv/acl: Let traps handle removing temporary directories.
1381 Expect acl-related tests to fail, until the corresponding
1382 patches are committed.
1383 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1384 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1386 ACL tests, from Andreas Gruenbacher.
1387 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1388 * tests/mv/Makefile.am (TESTS): Add acl.
1389 * tests/cp/Makefile.am (TESTS): Add acl.
1391 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1393 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1395 * NEWS: Improve quality of ln's diagnostics.
1396 * src/ln.c (do_link, usage): Likewise.
1397 (do_link): Don't use alloca on a buffer of unbounded size.
1399 2005-11-16 Jim Meyering <jim@meyering.net>
1401 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1402 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1403 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1404 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1405 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1407 2005-11-14 Jim Meyering <jim@meyering.net>
1409 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1411 2005-11-13 Jim Meyering <jim@meyering.net>
1413 * announce-gen: Accept new option, --gpg-key-id=ID and
1414 emit a blurb telling how to use the .sig files.
1415 * Makefile.cfg (gpg_key_ID): Define.
1416 * Makefile.maint (announcement): Use new option and key.
1418 Require that most .c files include <config.h>.
1419 * Makefile.maint (sc_require_config_h): New rule.
1420 (syntax-check-rules): Add it.
1421 * .x-sc_require_config_h: New file listing exceptions to the
1422 above rule. Some are legit, others are simply grandfathered in.
1423 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1425 2005-11-12 Jim Meyering <jim@meyering.net>
1427 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1429 2005-11-11 Jim Meyering <jim@meyering.net>
1431 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1432 Mention new readlink options in 5.3.0's `New features' section.
1433 Spotted by Thomas Hood.
1435 2005-11-08 Jim Meyering <jim@meyering.net>
1437 * NEWS: Merge in changes from b5_9x branch.
1439 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1441 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1442 like --time-style='posix-long-iso' if the locale settings are messed up.
1443 * src/ls.c (decode_switches): Implement this.
1445 2005-11-08 Jim Meyering <jim@meyering.net>
1447 * tests/du/2g: s/expensive/very expensive/ in a comment.
1450 2005-10-17 Eric Blake <ebb9@byu.net>
1452 * src/ls.c (usage): Fix descriptions of --sort, --time.
1453 Reported by Vitaly A. Ostanin.
1455 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1457 * src/ln.c: Include filenamecat.c.
1458 (FILE_BASENAME_CONCAT): Remove.
1459 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1460 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1461 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1464 2005-11-04 Jim Meyering <jim@meyering.net>
1466 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1467 on systems with stat.st_blocks of a signed 32-bit type.
1468 This bug causes trouble on some AIX 5.1 systems.
1469 Report and trivial patch from Paul Townsend:
1470 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1471 * NEWS: Mention this.
1473 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1474 * tests/du/Makefile.am (TESTS): Add it here.
1475 * tests/very-expensive: New file.
1476 * tests/Makefile.am (EXTRA_DIST): Add it here.
1477 * tests/cp/perm: Mark this test as `very-expensive', too.
1479 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1481 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1483 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1485 * src/rm.c (usage): Don't mention rm -d.
1487 2005-11-02 Jim Meyering <jim@meyering.net>
1489 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1490 From Andreas Schwab.
1492 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1493 `M+N records in/out' lines don't pollute `make check' output.
1495 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1496 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1497 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1498 to indicate that the input file should be piped into the command
1499 under test (via `cat FILE | $prog ...').
1501 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1502 (without -r) fails to remove a directory on a non-Linux system.
1503 This change affects only newer Solaris systems (with priv_*
1504 functions like priv_allocset). Reported by Keith Thompson.
1506 * tests/rm/dir-nonrecur: New file/test for the above fix.
1507 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1509 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1511 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1512 POSIX 1002.1-2001 requires.
1513 * src/tail.c (parse_obsolete_option): Implement this.
1514 Problem reported by Vincent Lefevre.
1515 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1516 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1517 (test_vector): Add special cases for _POSIX2_VERSION, and
1518 regularize the old ones a bit.
1519 * tests/touch/obsolescent: Add y2000 test.
1521 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1523 * src/dd.c (skip): Fix off-by-one error reported by
1524 Theodoros V. Kalamatianos.
1526 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1528 * tests/mkdir/p-3: Require that the test be run as non-root.
1529 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1531 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1533 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1534 boundary between DEST and SOURCE in the result.
1536 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1538 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1539 back to text, to sync with documentation and for backwards
1542 2005-10-25 Jim Meyering <jim@meyering.net>
1544 * tests/dircolors/simple (other-wr): Add an explicit test for
1545 the dircolors bug (NULL-dereference) fixed yesterday.
1547 2005-10-24 Jim Meyering <jim@meyering.net>
1549 * src/tac.c (tac_file): When determining whether a file is seekable,
1550 also test whether it is a tty. Using only the lseek-based test would
1551 give a false positive on Solaris. Reported by Peter Fales.
1553 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1555 * tests/install/d-slashdot: New test, for "install -d" failure.
1556 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1557 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1558 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1560 2005-10-24 Jim Meyering <jim@meyering.net>
1562 * src/dircolors.c (ls_codes): Add missing comma.
1563 Anonymous report and patch from
1564 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1566 * src/dircolors.c: Add compile-time assertion that the slack_codes
1567 and ls_codes arrays have the same number of elements. This would
1568 have prevented the above-fixed bug.
1570 * src/expand.c (parse_tab_stops): Add a comment to make this function
1571 identical to the one in unexpand.c.
1572 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1573 identical to the one in expand.c.
1575 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1577 2005-10-23 Jim Meyering <jim@meyering.net>
1579 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1580 a dangerous pointer-value-to-`unsigned' cast.
1581 * NEWS: mention the new sha* programs.
1582 * AUTHORS: Add new sha* programs.
1584 2005-08-28 David Madore <david.madore@ens.fr>
1586 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1587 * README: Add their names to the list.
1588 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1589 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1590 Rules for compiling sha-2 utilities
1591 (noinst_HEADERS): Remove checksum.h.
1592 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1594 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1595 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1596 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1597 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1598 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1599 sha384sum, sha512sum test scripts here rather that each in its
1602 2005-08-28 David Madore <david.madore@ens.fr>
1604 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1605 of the FIPS test vectors).
1607 2005-10-23 Jim Meyering <jim@meyering.net>
1609 * configure.ac: Use 6.0-cvs as the version string.
1610 * NEWS: Adjust accordingly.