1 2003-09-29 Havoc Pennington <hp@pobox.com>
3 * configure.in: split checks for Doxygen from XML docs, check for
6 * doc/Makefile.am: XML-ify all the docs, and add a blank
9 2003-09-29 Havoc Pennington <hp@pobox.com>
11 * Merge dbus-object-names branch. To see the entire patch
12 do cvs diff -r DBUS_OBJECT_NAMES_BRANCHPOINT -r dbus-object-names,
14 To revert, I tagged DBUS_BEFORE_OBJECT_NAMES_MERGE.
16 2003-09-28 Havoc Pennington <hp@pobox.com>
18 * HACKING: update to reflect new server
20 2003-09-26 Seth Nickell <seth@gnome.org>
23 * python/examples/example-signals.py:
25 Start implementing some notions of signals. The API
26 is really terrible, but they sort of work (with the
27 exception of being able to filter by service, and to
28 transmit signals *as* a particular service). Need to
29 figure out how to make messages come from the service
32 * python/dbus_bindings.pyx.in:
34 Removed duplicate message_handler callbacks.
36 2003-09-25 Havoc Pennington <hp@redhat.com>
38 * bus/session.conf.in: fix my mess
40 2003-09-25 Havoc Pennington <hp@pobox.com>
42 * bus/session.conf.in: fix security policy, reported by Seth Nickell
44 2003-09-25 Seth Nickell <seth@gnome.org>
46 * python/examples/example-service.py:
48 Johan notices complete wrong code in example-service, but
49 completely wrong in a way that works exactly the same (!).
50 Johan is confused, how could this possibly work? Example
51 code fails to serve purpose of making things clear.
54 2003-09-25 Mark McLoughlin <mark@skynet.ie>
56 * doc/dbus-specification.sgml: don't require header fields
57 to be 4-byte aligned and specify that fields should be
58 distinguished from padding by the fact that zero is not
61 * doc/TODO: remove re-alignment item and add item to doc
64 * dbus/dbus-message.c:
65 (HeaderField): rename the original member to value_offset
66 and introduce a name_offset member to keep track of where
67 the field actually begins.
68 (adjust_field_offsets): remove.
69 (append_int_field), (append_uint_field),
70 (append_string_field): don't align the start of the header
71 field to a 4-byte boundary.
72 (get_next_field): impl finding the next marhsalled field
74 (re_align_field_recurse): impl re-aligning a number of
75 already marshalled fields.
76 (delete_field): impl deleting a field of any type and
77 re-aligning any following fields.
78 (delete_int_or_uint_field), (delete_string_field): remove.
79 (set_int_field), (set_uint_field): no need to re-check
80 that we have the correct type for the field.
81 (set_string_field): ditto and impl re-aligning any
83 (decode_header_data): update to take into account that
84 the fields aren't 4-byte aligned any more and the new
85 way to distinguish padding from header fields. Also,
86 don't exit when there is too much header padding.
87 (process_test_subdir): print the directory.
88 (_dbus_message_test): add test to make sure a following
89 field is re-aligned correctly after field deletion.
91 * dbus/dbus-string.[ch]:
92 (_dbus_string_insert_bytes): rename from insert_byte and
93 allow the insert of multiple bytes.
94 (_dbus_string_test): test inserting multiple bytes.
96 * dbus/dbus-marshal.c: (_dbus_marshal_set_string): add
97 warning note to docs about having to re-align any
98 marshalled values following the string.
100 * dbus/dbus-message-builder.c:
101 (append_string_field), (_dbus_message_data_load):
102 don't align the header field.
104 * dbus/dbus-auth.c: (process_test_subdir): print the
107 * test/break-loader.c: (randomly_add_one_byte): upd. for
110 * test/data/invalid-messages/bad-header-field-alignment.message:
113 * test/data/valid-messages/unknown-header-field.message: shove
114 a dict in the unknown field.
116 2003-09-25 Seth Nickell <seth@gnome.org>
119 * python/dbus_bindings.pyx.in:
121 Handle return values.
123 * python/examples/example-client.py:
124 * python/examples/example-service.py:
126 Pass back return values from the service to the client.
128 2003-09-24 Seth Nickell <seth@gnome.org>
132 Connect Object methods (when you are sharing an object) up... pass
133 in a list of methods to be shared. Sharing all the methods just
134 worked out too weird. You can now create nice Services over the
137 * python/dbus_bindings.pyx.in:
139 Keep references to user_data tuples passed into C functions so
140 Python doesn't garbage collect on us.
142 Implement MethodReturn and Error subclasses of Message for creating
143 DBusMessage's of those types.
145 * python/examples/example-client.py:
146 * python/examples/example-service.py:
148 Simple example code showing both how create DBus services and objects,
151 2003-09-23 Havoc Pennington <hp@pobox.com>
153 * glib/dbus-gproxy.c (dbus_gproxy_manager_filter): implement
155 2003-09-23 Havoc Pennington <hp@redhat.com>
157 * glib/dbus-gproxy.c (dbus_gproxy_connect_signal): implement
158 (dbus_gproxy_disconnect_signal): implement
159 (dbus_gproxy_manager_remove_signal_match): implement
160 (dbus_gproxy_manager_add_signal_match): implement
161 (dbus_gproxy_oneway_call): implement
163 2003-09-23 Havoc Pennington <hp@pobox.com>
165 * glib/dbus-gproxy.c (struct DBusGProxy): convert to a GObject
166 subclass. This means dropping the transparent thread safety of the
167 proxy; you now need a separate proxy per-thread, or your own
168 locking on the proxy. Probably right anyway.
169 (dbus_gproxy_ref, dbus_gproxy_unref): nuke, just use g_object_ref
171 2003-09-22 Havoc Pennington <hp@redhat.com>
173 * glib/dbus-gproxy.c (dbus_gproxy_manager_get): implement
175 2003-09-21 Seth Nickell <seth@gnome.org>
177 First checkin of the Python bindings.
180 * python/Makefile.am:
181 * python/dbus_bindings.pyx.in:
182 * python/dbus_h_wrapper.h:
184 Pieces for Pyrex to operate on, building a dbus_bindings.so
185 python module for low-level access to the DBus APIs.
189 High-level Python module for accessing DBus objects.
194 Build stuff for the python bindings.
198 Extra macro needed for finding the Python C header files.
200 2003-09-21 Havoc Pennington <hp@pobox.com>
202 * glib/dbus-gproxy.c (dbus_gproxy_manager_new): start
203 implementing the proxy manager, didn't get very far.
205 * dbus/dbus-bus.c (dbus_bus_add_match): new
206 (dbus_bus_remove_match): new
208 * glib/dbus-gproxy.c (dbus_gproxy_new_for_service): add a
209 path_name argument; adjust the other not-yet-implemented
210 gproxy constructors to be what I think they should be.
212 2003-09-21 Havoc Pennington <hp@pobox.com>
214 * dbus/dbus-bus.c (dbus_bus_get): set exit_on_disconnect to TRUE
215 by default for message bus connections.
217 * dbus/dbus-connection.c (dbus_connection_dispatch): exit if
218 exit_on_disconnect flag is set and we process the disconnected
220 (dbus_connection_set_exit_on_disconnect): new function
222 2003-09-21 Havoc Pennington <hp@pobox.com>
224 Get matching rules mostly working in the bus; only actually
225 parsing the rule text remains. However, the client side of
226 "signal connections" hasn't been started, this patch is only the
229 * dbus/dispatch.c: fix for the matching rules changes
231 * bus/driver.c (bus_driver_handle_remove_match)
232 (bus_driver_handle_add_match): send an ack reply from these
235 * glib/dbus-gproxy.c (dbus_gproxy_begin_call): fix order of
236 arguments, reported by Seth Nickell
238 * bus/config-parser.c (append_rule_from_element): support
239 eavesdrop=true|false attribute on policies so match rules
240 can be prevented from snooping on the system bus.
242 * bus/dbus-daemon-1.1.in: consistently use terminology "sender"
243 and "destination" in attribute names; fix some docs bugs;
244 add eavesdrop=true|false attribute
246 * bus/driver.c (bus_driver_handle_add_match)
247 (bus_driver_handle_remove_match): handle AddMatch, RemoveMatch
250 * dbus/dbus-protocol.h (DBUS_SERVICE_ORG_FREEDESKTOP_BROADCAST): get
251 rid of broadcast service concept, signals are just always broadcast
253 * bus/signals.c, bus/dispatch.c, bus/connection.c, bus/bus.c:
254 mostly implement matching rules stuff (currently only exposed as signal
257 2003-09-21 Mark McLoughlin <mark@skynet.ie>
259 * doc/dbus-specification.sgml: Change the header field name
260 to be an enum and update the rest of the spec to reference
261 the fields using the conventinal name.
263 * dbus/dbus-protocol.h: update to reflect the spec.
265 * doc/TODO: add item to remove the 4 byte alignment requirement.
267 * dbus/dbus-message.c: Remove the code to generalise the
268 header/body length and serial number header fields as named
269 header fields so we can reference field names using the
271 (append_int_field), (append_uint_field), (append_string_field):
272 Append the field name as a byte rather than four chars.
273 (delete_int_or_uint_field), (delete_string_field): reflect the
274 fact that the field name and typecode now occupy 4 bytes instead
276 (decode_string_field), (decode_header_data): update to reflect
277 protocol changes and move the field specific encoding from
278 decode_string_field() back into decode_header_data().
280 * dbus/dbus-internals.[ch]: (_dbus_header_field_to_string):
281 Add utility to aid debugging.
283 * dbus/dbus-message-builder.c:
284 (append_string_field), (_dbus_message_data_load): Update to
285 reflect protocol changes; Change the FIELD_NAME directive
286 to HEADER_FIELD and allow it to take the field's conventional
287 name rather than the actual value.
289 * test/data/*/*.message: Update to use HEADER_FIELD instead
290 of FIELD_NAME; Always align the header on an 8 byte boundary
291 *before* updating the header length.
293 2003-09-15 Havoc Pennington <hp@pobox.com>
295 * dbus/dbus-pending-call.c: add the get/set object data
296 boilerplate as for DBusConnection, etc. Use generic object data
297 for the notify callback.
299 * glib/dbus-gparser.c (parse_node): parse child nodes
301 * tools/dbus-viewer.c: more hacking on the dbus-viewer
303 * glib/dbus-gutils.c (_dbus_gutils_split_path): add a file to
304 contain functions shared between the convenience lib and the
307 * glib/Makefile.am (libdbus_glib_1_la_LDFLAGS): add
308 -export-symbols-regex to the GLib library
310 * dbus/dbus-object-tree.c (_dbus_object_tree_dispatch_and_unlock):
311 fix the locking in here, and add a default handler for
312 Introspect() that just returns sub-nodes.
314 2003-09-14 Havoc Pennington <hp@pobox.com>
316 * glib/dbus-gthread.c (dbus_g_thread_init): rename to make g_foo
317 rather than gfoo consistent
319 * glib/dbus-gproxy.h: delete for now, move contents to
320 dbus-glib.h, because the include files don't work right since we
321 aren't in the dbus/ subdir.
323 * glib/dbus-gproxy.c (dbus_gproxy_send): finish implementing
324 (dbus_gproxy_end_call): finish
325 (dbus_gproxy_begin_call): finish
327 * glib/dbus-gmain.c (dbus_set_g_error): new
329 * glib/dbus-gobject.c (handle_introspect): include information
330 about child nodes in the introspection
332 * dbus/dbus-connection.c (dbus_connection_list_registered): new
333 function to help in implementation of introspection
335 * dbus/dbus-object-tree.c
336 (_dbus_object_tree_list_registered_and_unlock): new function
338 2003-09-12 Havoc Pennington <hp@pobox.com>
340 * glib/dbus-gidl.h: add common base class for all the foo_info
343 * tools/dbus-viewer.c: add GTK-based introspection UI thingy
346 * test/Makefile.am: try test srcdir -ef . in addition to test
347 srcdir = ., one of them should work (yeah lame)
349 * glib/Makefile.am: build the "idl" parser stuff as a convenience
352 * glib/dbus-gparser.h: make description_load routines return
353 NodeInfo* not Parser*
355 * Makefile.am (SUBDIRS): build test dir after all library dirs
357 * configure.in: add GTK+ detection
359 2003-09-07 Havoc Pennington <hp@pobox.com>
361 * Make Doxygen contented.
363 2003-09-07 Havoc Pennington <hp@pobox.com>
365 * doc/dbus-specification.sgml: more updates
367 2003-09-06 Havoc Pennington <hp@pobox.com>
369 * doc/dbus-specification.sgml: partial updates
371 * bus/dbus-daemon-1.1.in: fix the config file docs for the
372 zillionth time; hopefully I edited the right file this time.
374 * bus/config-parser.c (append_rule_from_element): support
375 send_type, send_path, receive_type, receive_path
377 * bus/policy.c: add message type and path to the list of things
378 that can be "firewalled"
380 2003-09-06 Havoc Pennington <hp@pobox.com>
382 * dbus/dbus-connection.c (dbus_connection_register_fallback): add this
383 (dbus_connection_register_object_path): make this not handle
384 messages to paths below the given path
386 2003-09-03 Havoc Pennington <hp@pobox.com>
388 * test/glib/Makefile.am: add this with random glib-linked test
391 * glib/Makefile.am: remove the random test programs from here,
392 leave only the unit tests
394 * glib/dbus-gobject.c (_dbus_gobject_test): add test for
395 uscore/javacaps conversion, and fix
396 (get_object_property, set_object_property): change to .NET
397 convention for mapping props to methods, set_FooBar/get_FooBar,
398 since one language has such a convention we may as well copy it.
399 Plus real methods in either getFooBar or get_foo_bar style won't
400 collide with this convention.
402 2003-09-01 Havoc Pennington <hp@pobox.com>
404 * glib/dbus-gparser.c: implement
406 * glib/dbus-gobject.c: start implementing skeletons support
408 * configure.in: when disabling checks/assert, also define
409 G_DISABLE_ASSERT and G_DISABLE_CHECKS
411 2003-09-01 Havoc Pennington <hp@pobox.com>
413 * glib/Makefile.am: rearrange a bunch of files and get "make
414 check" framework set up
416 2003-08-31 Havoc Pennington <hp@pobox.com>
418 * fix build with --disable-tests
420 2003-08-30 Havoc Pennington <hp@pobox.com>
422 * dbus/dbus-connection.c: purge DBusMessageHandler
424 * dbus/dbus-message-handler.c: remove DBusMessageHandler, just
425 use callbacks everywhere
427 2003-08-30 Havoc Pennington <hp@pobox.com>
429 * test/data/valid-config-files/system.d/test.conf: change to
430 root for the user so warnings don't get printed
432 * dbus/dbus-message.c: add dbus_message_get_path,
433 dbus_message_set_path
435 * dbus/dbus-object-tree.c (do_test_dispatch): add test of
436 dispatching to a path
438 * dbus/dbus-string.c (_dbus_string_validate_path): add
440 * dbus/dbus-marshal.c (_dbus_demarshal_object_path): implement
441 (_dbus_marshal_object_path): implement
443 * dbus/dbus-protocol.h (DBUS_HEADER_FIELD_PATH): new header field
444 to contain the path to the target object
445 (DBUS_HEADER_FIELD_SENDER_SERVICE): rename
446 DBUS_HEADER_FIELD_SENDER to explicitly say it's the sender service
448 2003-08-30 Havoc Pennington <hp@pobox.com>
450 * dbus/dbus-object-tree.c: write tests and fix the discovered bugs
452 2003-08-29 Havoc Pennington <hp@pobox.com>
454 * dbus/dbus-object-tree.c: modify to allow overlapping paths to be
456 (struct DBusObjectSubtree): shrink this
457 a lot, since we may have a lot of them
458 (_dbus_object_tree_free_all_unlocked): implement
459 (_dbus_object_tree_dispatch_and_unlock): implement
461 2003-08-29 Havoc Pennington <hp@pobox.com>
463 * dbus/dbus-internals.h: fix _DBUS_N_GLOBAL_LOCKS
465 2003-08-28 Havoc Pennington <hp@pobox.com>
469 * dbus/dbus-connection.c: port to no ObjectID, create a
470 DBusObjectTree, rename ObjectTree to ObjectPath in public API
472 * dbus/dbus-connection.h (struct DBusObjectTreeVTable): delete
473 everything except UnregisterFunction and MessageFunction
475 * dbus/dbus-marshal.c: port away from DBusObjectID,
476 add DBUS_TYPE_OBJECT_PATH
478 * dbus/dbus-object-registry.[hc], dbus/dbus-object.[hc],
479 dbus/dbus-objectid.[hc]: remove these, we are moving to
480 path-based object IDs
482 2003-08-25 Havoc Pennington <hp@pobox.com>
484 Just noticed that dbus_message_test is hosed, I wonder when I
485 broke that. I thought make check was passing earlier...
487 * dbus/dbus-object-tree.c: add new "object tree" to match DCOP
488 container tree, will replace most of dbus-object-registry
490 * dbus/dbus-string.c (_dbus_string_append_printf_valist): fix C99
493 2003-08-19 Havoc Pennington <hp@pobox.com>
495 * dbus/dbus-message.c (decode_string_field): support FIELD_SENDER
496 (dbus_message_is_error): fix this function
498 * bus/dbus-daemon-1.1: clarify logic on when <deny>/<allow> rules
501 * bus/policy.c (bus_client_policy_check_can_receive): fix code to
502 reflect clarified man page
503 (bus_client_policy_check_can_send): ditto
505 * bus/session.conf.in: fixup
507 * bus/system.conf.in: fixup
509 2003-08-18 Havoc Pennington <hp@redhat.com>
511 * dbus/dbus-hash.c (_dbus_hash_table_insert_two_strings): fix
513 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
514 dumb bug created earlier (wrong order of args to
515 decode_header_data())
517 * tools/dbus-send.c: port
519 * tools/dbus-print-message.c (print_message): port
521 * test/data/*messages: port all messages over
523 * dbus/dbus-message-builder.c: support including
526 * bus/driver.c: port over
528 * bus/dispatch.c: port over to new stuff
530 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
531 rename disconnect signal to "Disconnected"
533 2003-08-17 Havoc Pennington <hp@pobox.com>
535 This doesn't compile yet, but syncing up so I can hack on it from
536 work. What are branches for if not broken code? ;-)
538 * dbus/dbus-protocol.h: remove DBUS_HEADER_FIELD_NAME, add
539 DBUS_HEADER_FIELD_INTERFACE, DBUS_HEADER_FIELD_MEMBER,
540 DBUS_HEADER_FIELD_ERROR_NAME
542 * dbus/dbus-hash.c: Introduce DBUS_HASH_TWO_STRINGS as hack to use
543 for the interface+member pairs
544 (string_hash): change to use g_str_hash algorithm
545 (find_direct_function, find_string_function): refactor these to
548 * dbus/dbus-message.c: port all of this over to support
549 interface/member fields instead of name field
551 * dbus/dbus-object-registry.c: port over
553 * dbus/dbus-string.c (_dbus_string_validate_interface): rename
554 from _dbus_string_validate_name
556 * bus/dbus-daemon-1.1: change file format for the
557 <deny>/<allow> stuff to match new message naming scheme
559 * bus/policy.c: port over
561 * bus/config-parser.c: parse new format
563 2003-08-16 Havoc Pennington <hp@pobox.com>
565 * dbus/dbus-object-registry.c (add_and_remove_objects): remove
568 * glib/dbus-gproxy.c: some hacking
570 2003-08-15 Havoc Pennington <hp@redhat.com>
572 * dbus/dbus-pending-call.c (dbus_pending_call_block): implement
574 * dbus/dbus-connection.c
575 (dbus_connection_send_with_reply_and_block): factor out internals;
576 change to convert any error replies to DBusError instead of
577 returning them as a message
579 2003-08-15 Havoc Pennington <hp@pobox.com>
581 * dbus/dbus-connection.c,
582 dbus/dbus-pending-call.c: Finish the pending call stuff
584 2003-08-14 Havoc Pennington <hp@redhat.com>
586 * dbus/dbus-pending-call.c: start on new object that will replace
587 DBusMessageHandler and ReplyHandlerData for tracking outstanding
590 * dbus/dbus-gproxy.c: start on proxy object used to communicate
591 with remote interfaces
593 * dbus/dbus-gidl.c: do the boring boilerplate in here
595 2003-08-12 Havoc Pennington <hp@pobox.com>
597 * bus/dispatch.c (bus_dispatch): make this return proper
598 DBusHandlerResult to avoid DBUS_ERROR_UNKNOWN_METHOD
600 * dbus/dbus-errors.c (dbus_set_error): use
601 _dbus_string_append_printf_valist
603 * dbus/dbus-string.c (_dbus_string_append_printf_valist)
604 (_dbus_string_append_printf): new
606 * dbus/dbus-errors.h (DBUS_ERROR_UNKNOWN_MESSAGE): change to
609 * dbus/dbus-connection.c (dbus_connection_dispatch): handle
610 DBUS_HANDLER_RESULT_NEED_MEMORY; send default error reply if a
611 message is unhandled.
613 2003-08-11 Havoc Pennington <hp@pobox.com>
615 * bus/test.c (client_disconnect_handler): change to return
616 HANDLED (would have been REMOVE_MESSAGE)
618 * dbus/dbus-object.h (enum DBusHandlerResult): rename to
619 HANDLED/NOT_YET_HANDLED instead of
620 REMOVE_MESSAGE/ALLOW_MORE_HANDLERS to make it clearer how it
623 2003-08-10 Havoc Pennington <hp@pobox.com>
625 * tools/dbus-send.c (main): add --type argument, for now
626 supporting only method_call and signal types.
628 * tools/dbus-print-message.c: print message type
630 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
631 init connection->objects
633 * doc/dbus-specification.sgml: fix sgml
635 * bus/*.c: port over to object-instance API changes
637 * test/test-service.c: ditto
639 * dbus/dbus-message.c (dbus_message_create_header): allow #NULL
640 name, we will have to fix up the rest of the code to also handle
642 (dbus_message_new): generic message-creation call
643 (set_string_field): allow appending name field
645 2003-08-06 Havoc Pennington <hp@pobox.com>
647 * dbus/dbus-object-registry.c: implement signal connection
650 * dbus/dbus-connection.c (_dbus_connection_unref_unlocked): new
652 * dbus/dbus-internals.c (_dbus_memdup): new function
654 2003-08-02 Havoc Pennington <hp@pobox.com>
656 * dbus/dbus-message.c (dbus_message_get_no_reply)
657 (dbus_message_set_no_reply): add these and remove
658 set_is_error/get_is_error
660 * dbus/dbus-protocol.h, doc/dbus-specification.sgml:
661 remove the ERROR flag, since there's now an ERROR type
663 2003-08-01 Havoc Pennington <hp@pobox.com>
665 * dbus/dbus-object-registry.c (_dbus_object_registry_handle_and_unlock):
668 * dbus/dbus-message.c (dbus_message_get_type): new function
670 * doc/dbus-specification.sgml: add "type" byte to messages
672 2003-08-01 Havoc Pennington <hp@pobox.com>
674 * dbus/dbus-protocol.h (DBUS_MESSAGE_TYPE_*): introduce
675 a message type enum to distinguish kinds of message
676 (DBUS_HEADER_FLAG_NO_REPLY_EXPECTED): flag for a message
677 that need not be replied to
679 2003-08-01 Havoc Pennington <hp@pobox.com>
681 * dbus/dbus-marshal.c: adapt to DBusObjectID changes
682 (unpack_8_octets): fix no-64-bit-int bug
684 * dbus/dbus-object-registry.c (validate_id): validate the
685 connection ID bits, not just the instance ID.
687 * dbus/dbus-connection.c (_dbus_connection_init_id): initialize
688 the connection-global 33 bits of the object ID
690 * dbus/dbus-object-registry.c (info_from_entry): fill in
691 object ID in the new way
693 * dbus/dbus-objectid.h: rather than high/low bits, specifically
694 define server/client/instance bits.
696 2003-07-30 Havoc Pennington <hp@pobox.com>
698 * dbus/dbus-connection.c (dbus_connection_register_object): fix
701 2003-07-13 Havoc Pennington <hp@pobox.com>
703 * dbus/dbus-object.h (struct DBusObjectVTable): add padding
704 fields to DBusObjectVTable and DBusObjectInfo
706 2003-07-12 Havoc Pennington <hp@pobox.com>
708 * dbus/dbus-object-registry.c: implement unit test,
709 fix bugs discovered in process
711 * dbus/dbus-connection.c: remove handler_table and
712 register_handler(), add DBusObjectRegistry usage
714 * dbus/dbus-objectid.c (dbus_object_id_is_null)
715 (dbus_object_id_set_null): new functions
717 2003-07-08 Havoc Pennington <hp@pobox.com>
719 * dbus/dbus-object.c: implement some of this
721 * dbus/dbus-object-registry.c
722 (_dbus_object_registry_add_and_unlock): fill in the object_id out
724 (_dbus_object_registry_new): handle OOM
726 2003-07-08 Havoc Pennington <hp@pobox.com>
728 * dbus/dbus-object.h: sketch out an API for registering objects
729 with a connection, that allows us to use as little as 24 bytes
730 per object and lets application code represent an object in
733 * dbus/dbus-object-registry.c: implement the hard bits of the
734 DBusConnection aspect of object API. Not yet wired up.
736 2003-07-06 Havoc Pennington <hp@pobox.com>
738 * dbus/dbus-marshal.c (_dbus_marshal_set_object_id): new function
739 (_dbus_marshal_object_id): new
740 (_dbus_demarshal_object_id): new
741 (_dbus_marshal_get_arg_end_pos): support object ID type, and
742 consolidate identical switch cases. Don't conditionalize handling
743 of DBUS_TYPE_UINT64, need to handle the type always.
744 (_dbus_marshal_validate_arg): consolidate identical cases, and
745 handle DBUS_TYPE_OBJECT_ID
747 * dbus/dbus-objectid.c: new file with DBusObjectID data type.
749 * dbus/dbus-protocol.h: add DBUS_TYPE_OBJECT_ID
751 2003-09-28 Havoc Pennington <hp@pobox.com>
755 2003-09-28 Havoc Pennington <hp@pobox.com>
757 * doc/Makefile.am (dbus-specification.html): testing a funky hack
758 to work with Debian db2html
760 2003-09-28 Havoc Pennington <hp@pobox.com>
764 * doc/Makefile.am (dbus-test-plan.html): accept nonexistence of
765 stylesheet-images for benefit of Debian
767 Change back to using filesystem-linked sockets for the system
768 bus, so only root can create the default system bus address.
770 * bus/system.conf.in: change to use
771 DBUS_SYSTEM_BUS_DEFAULT_ADDRESS
773 * dbus/Makefile.am (INCLUDES): remove DBUS_SYSTEM_BUS_PATH define
776 * configure.in: define DBUS_SYSTEM_BUS_DEFAULT_ADDRESS
777 here, and AC_DEFINE DBUS_SYSTEM_PATH
779 2003-08-09 Anders Carlsson <andersca@codefactory.se>
785 2003-08-09 Anders Carlsson <andersca@codefactory.se>
787 * doc/dbus-specification.sgml:
788 Add activation reply values.
790 2003-08-05 Havoc Pennington <hp@redhat.com>
794 2003-08-05 Anders Carlsson <andersca@codefactory.se>
796 * glib/dbus-gmain.c: (watch_fd_new), (watch_fd_ref),
797 (watch_fd_unref), (dbus_gsource_check), (dbus_gsource_dispatch),
798 (add_watch), (remove_watch), (create_source):
799 Refcount fds, fixes some reentrancy issues.
801 2003-07-30 Havoc Pennington <hp@redhat.com>
803 * dbus/dbus-bus.c (init_connections_unlocked): fix default system
804 bus address to be abstract if we have abstract sockets
808 2003-07-28 Havoc Pennington <hp@redhat.com>
810 * bus/messagebus.in: fix to avoid processname/servicename
811 confusion, from Michael Kearey
812 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=100965
814 2003-07-23 Havoc Pennington <hp@pobox.com>
816 * dbus/dbus-message.c (dbus_message_iter_get_named):
817 fix from Andy Hanton to remove broken "+1"
819 2003-07-16 Havoc Pennington <hp@pobox.com>
821 * tools/dbus-launch.c (babysit): close stdout/stderr in the
822 babysitter process, as suggested by Thomas Leonard, so
823 an "eval `dbus-launch --exit-with-session`" will actually
826 2003-07-16 Havoc Pennington <hp@pobox.com>
828 * configure.in: print out EXPANDED_* variables in the summary at
829 the end; clean up the code that computes EXPANDED_ variables and
830 get the ones using exec_prefix right. Should make things work
831 when you build without --prefix
833 2003-06-29 Havoc Pennington <hp@pobox.com>
835 * mono/Test.cs (class Test): fire up a main loop and run it
837 * mono/DBus.cs (DBus): don't g_thread_init since it can only be
838 done once, the app has to do it
840 2003-06-26 Havoc Pennington <hp@pobox.com>
842 * mono/Connection.cs: set up connection with the glib main loop
844 2003-07-01 Havoc Pennington <hp@redhat.com>
846 * doc/dbus-specification.sgml: clarify the format of a type code,
847 change suggested by Jim Blandy
849 2003-06-29 Miloslav Trmac <mitr@volny.cz>
852 * tools/Makefile.am: Don't assume srcdir == builddir.
854 * dbus/dbus-memory.c (dbus_realloc): Don't check guards after shrinking
856 (_dbus_memory_test): New function.
857 * dbus/dbus-test.h: Add _dbus_memory_test ().
858 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): Call it.
860 * dbus/dbus-message.c (decode_header_data): Use %.4s instead
862 (dbus_message_new): Remove obsolete @todo.
864 * dbus/dbus-marshal.c (_dbus_marshal_set_int64)
865 (_dbus_marshal_set_uint64): Fix comment.
867 * dbus/dbus-message.c (append_int_field, append_uint_field): Don't
868 hardcode FIELD_REPLY_SERIAL.
870 * dbus/dbus-mainloop.c (_dbus_loop_remove_watch)
871 (_dbus_loop_remove_timeout): Cast function pointers to (void *) for %p
873 * configure.in: Add -D_POSIX_C_SOURCE=199309L -DBSD_SOURCE to CFLAGS
874 and disable DBUS_USE_ATOMIC_INT_486 when --enable-ansi is used
876 2003-06-24 Havoc Pennington <hp@pobox.com>
878 * mono/*.cs: Use IntPtr.Zero instead of ((IntPtr) 0)
880 2003-06-23 Anders Carlsson <andersca@codefactory.se>
886 * gcj/TestMessage.java: (TestMessage), (TestMessage.main):
887 * gcj/org/.cvsignore:
888 * gcj/org/Makefile.am:
889 * gcj/org/freedesktop/.cvsignore:
890 * gcj/org/freedesktop/Makefile.am:
891 * gcj/org/freedesktop/dbus/.cvsignore:
892 * gcj/org/freedesktop/dbus/Makefile.am:
893 * gcj/org/freedesktop/dbus/Message.java: (Message),
895 * gcj/org/freedesktop/dbus/natMessage.cc:
896 Fix the build system.
898 2003-06-22 Havoc Pennington <hp@pobox.com>
900 * mono/Connection.cs: add more bindings
902 * dbus/dbus-threads.c (dbus_threads_init): allow calling this
905 2003-06-22 Havoc Pennington <hp@pobox.com>
907 * mono/Connection.cs, mono/DBus.cs, mono/Error.cs:
908 Start wrapping more stuff.
910 2003-06-22 Havoc Pennington <hp@pobox.com>
912 * mono/Message.cs: implement Message.Wrap() that ensures we only
913 have a single C# wrapper per DBusMessage, assuming it works which
916 * dbus/dbus-message.c (dbus_message_allocate_data_slot): new
917 (dbus_message_free_data_slot): new
918 (dbus_message_set_data): new
919 (dbus_message_get_data): new
921 2003-06-22 Havoc Pennington <hp@pobox.com>
923 * dbus/dbus-dataslot.c (_dbus_data_slot_allocator_unref)
924 (_dbus_data_slot_allocator_alloc): rework these to keep a
925 reference count on each slot and automatically manage a global
926 slot ID variable passed in by address
928 * bus/bus.c: convert to new dataslot API
930 * dbus/dbus-bus.c: convert to new dataslot API
932 * dbus/dbus-connection.c: convert to new dataslot API
934 * dbus/dbus-server.c: convert to new dataslot API
936 * glib/dbus-gmain.c: ditto
940 * bus/connection.c: ditto
942 2003-06-22 Anders Carlsson <andersca@codefactory.se>
944 * configure.in: Add AM_PROG_GCJ and move AM_PROG_LIBTOOL
945 after the gcj checks so that the correct configuration tags
946 will be added to libtool.
948 * dbus-glib-1.pc.in: No need to specify any includes since
949 dbus-1.pc.in has those.
951 2003-06-22 Havoc Pennington <hp@pobox.com>
953 * mono/*, gcj/*, configure.in, Makefile.am:
954 Check in makefiles and subdirs for mono and gcj bindings.
955 Neither binding actually exists, just trying to get through
956 all the build and other boring bits.
958 2003-06-21 Philip Blundell <philb@gnu.org>
960 * tools/dbus-monitor.1: Updated.
962 * tools/dbus-send.1: Likewise.
964 2003-06-20 Anders Carlsson <andersca@codefactory.se>
966 * dbus/dbus-transport-unix.c (unix_handle_watch): Check
967 for hangup and error after checking read so we won't discard
968 pending data if both hangup and read are set.
970 2003-06-19 Philip Blundell <philb@gnu.org>
972 * tools/dbus-print-message.c (print_message): Handle BOOLEAN.
974 * tools/dbus-send.c: Accept both --system and --session.
976 * tools/dbus-monitor.c: Same here.
978 2003-06-19 Anders Carlsson <andersca@codefactory.se>
980 * glib/dbus-glib.h: Fix so that dbus-glib.h can be used
981 from C++ (Patch by Miloslav Trmac).
983 2003-06-15 Joe Shaw <joe@assbarn.com>
985 * configure.in: Check for socklen_t.
987 * dbus/dbus-sysdeps.c: Define socklen_t if it's not defined.
989 * test/test-segfault.c: Add #include <sys/time.h>
991 * tools/Makefile.am: Add DBUS_X_CFLAGS to the INCLUDES since
992 dbus-launch needs it.
994 2003-06-09 Havoc Pennington <hp@redhat.com>
996 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): don't use
997 SUN_LEN, it breaks abstract socket usage
999 * dbus/dbus-internals.c (_dbus_verbose_real): only print PID at
1002 2003-06-04 Havoc Pennington <hp@pobox.com>
1004 * dbus/dbus-server.c (dbus_server_listen): allow abstract sockets
1005 using unix:abstract=/foo, and when listening in a tmpdir
1006 i.e. unix:tmpdir=/tmp, always use abstract sockets if we can.
1008 * dbus/dbus-transport.c (_dbus_transport_open): support
1011 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
1012 support abstract sockets
1014 * dbus/dbus-transport-unix.c
1015 (_dbus_transport_new_for_domain_socket): support abstract sockets
1017 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket): add "abstract"
1018 toggle as an argument, implement abstract namespace support
1019 (_dbus_listen_unix_socket): ditto
1021 * configure.in: add --enable-abstract-sockets and implement
1022 a configure check for autodetection of the right value.
1024 2003-06-01 Havoc Pennington <hp@pobox.com>
1026 * tools/dbus-cleanup-sockets.c: add utility to clean up sockets
1027 in /tmp (though on Linux this will end up being useless,
1028 when we add abstract namespace support)
1030 * configure.in: define DBUS_SESSION_SOCKET_DIR in addition to
1033 2003-05-28 Colin Walters <walters@verbum.org>
1035 * tools/dbus-monitor.c (main): Fix silly typo (s/--session/--system/).
1037 2003-05-18 Anders Carlsson <andersca@codefactory.se>
1039 * dbus/dbus-message.c (dbus_message_new): Remove @todo.
1041 2003-05-17 Colin Walters <walters@gnu.org>
1043 * tools/dbus-send.c: Don't exit with an error code if --help was
1044 passed. Default to using the session bus instead of the system
1047 * tools/dbus-launch.c: Ditto.
1049 * tools/dbus-monitor.c: Ditto.
1051 * tools/dbus-send.1: Update with new arguments.
1053 * tools/dbus-launch.c: Emit code to export variables. New
1054 arguments -s and -c to specify shell syntax, and a bit of code to
1055 autodetect syntax. Also, allow specifying a program to run.
1057 * tools/dbus-launch.1: Update with new arguments.
1059 * tools/dbus-send.1: Ditto.
1061 * tools/dbus-monitor.1: Ditto.
1063 2003-05-17 Havoc Pennington <hp@pobox.com>
1065 * bus/config-parser.c (merge_included): merge in policies from
1066 child configuration file.
1068 * bus/policy.c (bus_policy_merge): function to merge two policies
1071 2003-05-16 Havoc Pennington <hp@redhat.com>
1073 * dbus/dbus-connection.c: disable verbose lock spew
1075 * tools/dbus-send.c: add --print-reply command line option
1077 * tools/dbus-print-message.h (print_message): new util function
1078 shared by dbus-send and dbus-monitor
1080 * tools/dbus-monitor.c (handler_func): exit on disconnect
1082 * dbus/dbus-transport-unix.c (do_reading): if the transport is
1083 disconnected, don't try to use the read_watch
1085 * dbus/dbus-watch.c (dbus_watch_get_enabled): assert watch != NULL
1086 so we can find this bug more easily
1088 2003-05-16 Havoc Pennington <hp@redhat.com>
1090 * bus/policy.c (free_rule_list_func): avoid a crash when passed
1091 NULL as DBusHashTable is annoyingly likely to do.
1093 2003-05-16 Colin Walters <walters@verbum.org>
1095 * tools/dbus-monitor.c: Add --session argument and usage()
1098 * tools/dbus-monitor.1: Update with new --session arg.
1100 * bus/Makefile.am (install-data-hook): Create
1101 $(libdir)/dbus-1.0/services so that the session bus is happy.
1103 2003-05-15 Havoc Pennington <hp@redhat.com>
1105 * dbus/dbus-sysdeps.c (_dbus_atomic_dec, _dbus_atomic_inc): work
1106 on non-x86. ifdef's are evil.
1108 2003-05-15 Havoc Pennington <hp@redhat.com>
1110 * configure.in: 0.11
1114 * bus/Makefile.am (initddir): apparently we are supposed to put
1115 init scripts in /etc/rc.d/init.d not /etc/init.d
1117 * bus/Makefile.am: remove the "you must --enable-tests to make
1118 check" as it broke distcheck
1120 * bus/Makefile.am (install-data-hook): create /etc/dbus-1/system.d
1122 2003-05-13 James Willcox <jwillcox@gnome.org>
1125 * bus/activation.c: (bus_activation_service_created),
1126 (bus_activation_activate_service):
1127 * bus/driver.c: (bus_driver_send_service_deleted),
1128 (bus_driver_send_service_created), (bus_driver_send_service_lost),
1129 (bus_driver_send_service_acquired),
1130 (bus_driver_send_welcome_message),
1131 (bus_driver_handle_list_services):
1132 * bus/session.conf.in:
1133 * dbus/dbus-bus.c: (dbus_bus_acquire_service),
1134 (dbus_bus_service_exists), (dbus_bus_activate_service):
1137 Add some convenience API which lets you activate a service, and did a
1138 bunch of s/0/DBUS_TYPE_INVALID/ in calls to dbus_message_append_args()
1139 and dbus_message_get_args()
1141 2003-05-11 Havoc Pennington <hp@pobox.com>
1143 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix to avoid
1144 calling _dbus_marshal_validate_arg() for every byte in a byte
1147 * dbus/dbus-message-handler.c: use atomic reference counting to
1148 reduce number of locks slightly; the global lock in here sucks
1150 * dbus/dbus-connection.c
1151 (_dbus_connection_update_dispatch_status_and_unlock): variant of
1152 update_dispatch_status that can be called with lock held; then use
1153 in a couple places to reduce locking/unlocking
1154 (dbus_connection_send): hold the lock over the whole function
1155 instead of acquiring it twice.
1157 * dbus/dbus-timeout.c (_dbus_timeout_new): handle OOM
1159 * bus/connection.c (bus_connections_setup_connection): fix access
1160 to already-freed memory.
1162 * dbus/dbus-connection.c: keep a little cache of linked list
1163 nodes, to avoid using the global linked list alloc lock in the
1164 normal send-message case. Instead we just use the connection lock
1165 that we already have to take.
1167 * dbus/dbus-list.c (_dbus_list_find_last): new function
1169 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec):
1170 change to use a struct for the atomic type; fix docs,
1171 they return value before increment, not after increment.
1173 * dbus/dbus-string.c (_dbus_string_append_4_aligned)
1174 (_dbus_string_append_8_aligned): new functions to try to
1175 microoptimize this operation.
1176 (reallocate_for_length): break this out of set_length(), to
1177 improve profile info, and also so we can consider inlining the
1180 * dbus/dbus-message.c (dbus_message_new_empty_header): init data
1181 strings with some preallocation, cuts down on our calls to realloc
1182 a fair bit. Though if we can get the "move entire string to empty
1183 string" optimization below to kick in here, it would be better.
1185 * dbus/dbus-string.c (_dbus_string_move): just call
1186 _dbus_string_move_len
1187 (_dbus_string_move_len): add a special case for moving
1188 an entire string into an empty string; we can just
1189 swap the string data instead of doing any reallocs.
1190 (_dbus_string_init_preallocated): new function
1192 2003-05-11 Havoc Pennington <hp@pobox.com>
1194 Write a "test-profile" that does echo client-server with threads;
1195 profile reveals lock contention, memcpy/realloc of buffers, and
1196 UTF-8 validation as hot spots. 20% of lock contention eliminated
1197 with dbus_atomic_inc/dec implementation on x86. Much remaining
1198 contention is global mempool locks for GList and DBusList.
1200 * dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec): add
1203 * dbus/dbus-connection.c (struct DBusConnection): use
1204 dbus_atomic_t for the reference count
1206 * dbus/dbus-message.c (struct DBusMessage): declare
1207 dbus_atomic_t values as volatile
1209 * configure.in: code to detect ability to use atomic integer
1210 operations in assembly, from GLib patch
1212 * dbus/dbus-internals.c (_dbus_verbose_real): call getpid every
1213 time, tired of it being wrong in threads and forked processes
1215 * glib/test-profile.c: a little program to bounce messages back
1216 and forth between threads and eat CPU
1218 * dbus/dbus-connection.c: add debug spew macros for debugging
1219 thread locks; include config.h at top; fix deadlock in
1220 dbus_connection_flush()
1222 2003-05-08 Havoc Pennington <hp@pobox.com>
1224 * dbus/dbus-spawn.c: s/_exit/exit/ because it was keeping gcov
1225 data from getting written, and there wasn't a good reason to
1228 * test/decode-gcov.c (mark_inside_dbus_build_tests): don't count
1229 dbus_verbose lines in test coverage
1230 (main): add list of functions sorted by # of untested blocks
1231 to the coverage report
1233 * dbus/dbus-mempool.c: put some test-only code in DBUS_BUILD_TESTS
1235 * dbus/dbus-marshal.c (_dbus_marshal_test): extend test coverage
1237 * dbus/dbus-message-handler.c (_dbus_message_handler_test):
1238 extend test coverage
1240 * test/data/auth/cancel.auth-script: test canceling an
1243 * dbus/Makefile.am: remove dbus-server-debug.[hc] for now, as they
1244 aren't used. in CVS history if we end up needing them.
1246 2003-05-04 Havoc Pennington <hp@pobox.com>
1248 * dbus/dbus-message-handler.c (_dbus_message_handler_test): add
1251 * dbus/dbus-marshal.c (_dbus_demarshal_string_array): fix this
1252 function, which assumed length was in # of strings, not bytes
1254 * dbus/dbus-message.c (_dbus_message_test): add tests for some
1257 * dbus/dbus-connection.c
1258 (_dbus_connection_queue_received_message): disable function for
1259 now, we are only using it in test mode
1261 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
1262 remove a mistaken FIXME
1264 2003-05-04 Havoc Pennington <hp@pobox.com>
1266 * dbus/dbus-connection.c (dbus_connection_preallocate_send):
1267 unlock mutex on successful return, patch from Anders Gustafsson
1269 2003-05-04 Havoc Pennington <hp@pobox.com>
1271 * dbus-glib-1.pc.in (Requires): fix dependencies, from
1274 2003-05-04 Havoc Pennington <hp@pobox.com>
1276 * tools/dbus-launch.c: implement
1278 * bus/main.c (main), bus/bus.c (bus_context_new):
1279 implement --print-pid and --fork
1281 2003-05-03 Havoc Pennington <hp@redhat.com>
1283 * dbus/dbus-address.c (dbus_parse_address): fix bug when a key in
1284 the address had no value, and add to test suite. Fix and
1285 regression test from Miloslav Trmac
1287 2003-05-03 Havoc Pennington <hp@pobox.com>
1289 * dbus/dbus-watch.c (dbus_watch_handle): warn and return if a
1290 watch is invalid when handled
1292 * tools/Makefile.am, tools/dbus-launch.c, tools/dbus-launch.1: add
1293 dbus-launch utility to launch the bus from a shell script. Didn't
1294 actually implement dbus-launch yet, it's just a placeholder still.
1296 2003-05-03 Havoc Pennington <hp@pobox.com>
1298 * bus/Makefile.am, bus/dbus-daemon-1.1.in: man page for the
1299 daemon; also documents daemon config file, so replaces
1300 doc/config-file.txt. Corrected some stuff from config-file.txt in
1301 the process of moving it.
1303 2003-05-03 Havoc Pennington <hp@pobox.com>
1305 * tools/Makefile.am, tools/dbus-send.1, tools/dbus-monitor.1:
1308 2003-05-03 Colin Walters <walters@verbum.org>
1310 * dbus/dbus-sysdeps.c (fill_user_info): Test against
1311 DBUS_UID_UNSET to determine whether to do a uid lookup or not.
1313 * Makefile.am: Update to use new .pc versioning scheme.
1315 2003-05-02 Havoc Pennington <hp@redhat.com>
1317 * bus/system.conf.in: allow send/receive to/from message bus
1320 2003-04-30 Havoc Pennington <hp@redhat.com>
1322 * configure.in: print a note when building with unit tests and
1325 2003-04-30 Havoc Pennington <hp@redhat.com>
1327 * Makefile.am: add a check-local that complains if you didn't
1328 configure with --enable-tests
1330 2003-04-29 Havoc Pennington <hp@redhat.com>
1332 * glib/dbus-gmain.c: docs cleanups
1334 * dbus/dbus-types.h: add docs on int64 types
1336 * dbus/dbus-memory.c: fix docs to avoid putting private API in
1337 public API docs section
1339 2003-04-29 Havoc Pennington <hp@redhat.com>
1341 * dbus-1.pc.in, dbus-glib-1.pc.in: rename these from
1342 dbus-1.0.pc.in, dbus-glib-1.0.pc.in. As these change with the
1343 parallel install API version, not with the D-BUS package version.
1345 * HACKING: move some of README over here
1347 * README: updates, and document API/ABI policy
1349 * configure.in: reindentation
1351 2003-04-29 Havoc Pennington <hp@redhat.com>
1353 * dbus/dbus.h: add "you have to define DBUS_API_SUBJECT_TO_CHANGE
1354 to use this library" to be sure people have the right
1357 2003-04-28 Havoc Pennington <hp@redhat.com>
1359 * configure.in: add --enable-docs which by default is auto yes if
1360 doxygen and db2html found, no otherwise; but can be forced on/off
1362 * doc/Makefile.am: conditionalize whether to build docs on
1365 2003-04-28 Havoc Pennington <hp@redhat.com>
1367 * configure.in: 0.10
1371 * bus/system.conf.in: add <includedir>system.d</includedir>
1373 * dbus/dbus-userdb.c (_dbus_user_database_lookup): fix bug when
1374 username was provided but not uid
1376 * bus/config-parser.c (struct BusConfigParser): keep track of
1377 whether the parser is toplevel or was included; change some
1378 of the error handling if it's included.
1380 2003-04-27 Havoc Pennington <hp@pobox.com>
1384 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
1385 report correct status if we finish processing authentication
1386 inside this function.
1388 * bus/activation.c (try_send_activation_failure): use
1389 bus_transaction_send_error_reply
1391 * bus/connection.c (bus_connection_get_groups): return an error
1392 explaining the problem
1394 * bus/bus.c (bus_context_check_security_policy): implement
1395 restriction here that inactive connections can only send the
1396 hello message. Also, allow bus driver to send anything to
1399 * bus/connection.c (bus_connection_complete): create the
1400 BusClientPolicy here instead of on-demand.
1401 (bus_connection_get_policy): don't return an error
1403 * dbus/dbus-message.c (dbus_message_new_error_reply): allow NULL
1404 sender field in message being replied to
1406 * bus/bus.c (bus_context_check_security_policy): fix silly typo
1407 causing it to return FALSE always
1409 * bus/policy.c (bus_client_policy_check_can_send): fix bug where
1410 we checked sender rather than destination
1412 2003-04-25 Havoc Pennington <hp@redhat.com>
1414 test suite is slightly hosed at the moment, will fix soon
1416 * bus/connection.c (bus_connections_expire_incomplete): fix to
1417 properly disable the timeout when required
1418 (bus_connection_set_name): check whether we can remove incomplete
1419 connections timeout after we complete each connection.
1421 * dbus/dbus-mainloop.c (check_timeout): fix this up a bit,
1422 probably still broken.
1424 * bus/services.c (bus_registry_acquire_service): implement max
1425 number of services owned, and honor allow/deny rules on which
1426 services a connection can own.
1428 * bus/connection.c (bus_connection_get_policy): report errors here
1430 * bus/activation.c: implement limit on number of pending
1433 2003-04-25 Havoc Pennington <hp@redhat.com>
1435 * dbus/dbus-transport.c (_dbus_transport_get_unix_user): fix bug
1436 where we used >= 0 instead of != DBUS_UID_UNSET.
1438 2003-04-25 Havoc Pennington <hp@redhat.com>
1440 * glib/dbus-gmain.c (remove_watch): fix for a crash when watches
1441 were toggled without add/remove, fix from Anders Gustafsson
1443 2003-04-24 Havoc Pennington <hp@redhat.com>
1445 * test/data/valid-config-files/basic.conf: add <limit> tags to
1448 * bus/config-parser.h, bus/config-parser.c, bus/bus.c: Implement
1449 <limit> tag in configuration file.
1451 2003-04-24 Havoc Pennington <hp@redhat.com>
1453 * bus/dispatch.c: somehow missed some name_is
1455 * dbus/dbus-timeout.c (_dbus_timeout_set_enabled)
1456 (_dbus_timeout_set_interval): new
1458 * bus/connection.c (bus_connections_setup_connection): record time
1459 when each connection is first set up, and expire them after the
1460 auth timeout passes.
1462 2003-04-24 Havoc Pennington <hp@redhat.com>
1464 * dbus/dbus-message.c (dbus_message_name_is): rename
1465 (dbus_message_service_is): rename
1466 (dbus_message_sender_is): rename
1467 (dbus_message_get_service): rename
1469 2003-04-24 Havoc Pennington <hp@redhat.com>
1471 * configure.in: add --enable-checks
1473 * dbus/dbus-message.c (dbus_message_new): reverse name/service arguments
1475 * dbus/dbus-connection.c (dbus_connection_preallocate_send): fix
1476 to use thread locks.
1477 (_dbus_connection_handler_destroyed_locked): move some private
1478 functions into proper docs group
1480 * dbus/dbus-internals.h: add _dbus_return_if_fail,
1481 _dbus_return_val_if_fail
1483 Throughout: use dbus_return_if_fail
1485 2003-04-23 James Willcox <jwillcox@gnome.org>
1488 * glib/dbus-gmain.c: (add_timeout), (wakeup_main), (create_source),
1489 (dbus_connection_setup_with_g_main),
1490 (dbus_server_setup_with_g_main):
1491 * glib/test-dbus-glib.c: (main):
1492 * glib/test-thread-client.c: (main):
1493 * glib/test-thread-server.c: (new_connection_callback), (main):
1494 * tools/dbus-monitor.c: (main):
1496 Added a GMainContext argument to dbus_connection_setup_with_g_main()
1497 and dbus_server_setup_with_g_main().
1499 2003-04-20 Havoc Pennington <hp@pobox.com>
1501 * doc/dbus-specification.sgml: document the restrictions on
1502 message and service names
1504 2003-04-22 Havoc Pennington <hp@redhat.com>
1506 * dbus/dbus-message.c, dbus/dbus-marshal.c: add 64-bit integer
1507 support, and do some code cleanups to share more code and
1508 speed up array marshal/demarshal.
1510 * dbus-1.0.pc.in (Cflags): put libdir include file in cflags
1512 * configure.in: generate dbus-arch-deps.h
1514 * dbus/dbus-protocol.h (DBUS_TYPE_INT64, DBUS_TYPE_UINT64): add
1517 2003-04-22 Havoc Pennington <hp@redhat.com>
1519 * test/data/valid-messages/opposite-endian.message: fix test
1520 to use proper type for rply field
1522 * test/data/invalid-messages: add tests for below validation
1524 * dbus/dbus-message.c (decode_header_data): validate field types,
1525 and validate that named fields are valid names
1526 (decode_name_field): consider messages in the
1527 org.freedesktop.Local. namespace to be invalid.
1529 * dbus/dbus-string.c (_dbus_string_validate_name): new
1531 2003-04-19 Havoc Pennington <hp@pobox.com>
1533 * bus/driver.c (bus_driver_handle_hello): check limits and
1534 return an error if they are exceeded.
1536 * bus/connection.c: maintain separate lists of active and inactive
1537 connections, and a count of each. Maintain count of completed
1538 connections per user. Implement code to check connection limits.
1540 * dbus/dbus-list.c (_dbus_list_unlink): export
1542 * bus/bus.c (bus_context_check_security_policy): enforce a maximum
1543 number of bytes in the message queue for a connection
1545 2003-04-18 Havoc Pennington <hp@pobox.com>
1547 * dbus/dbus-auth.c (record_mechanisms): memleak fixes
1549 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): fix some
1552 * dbus/dbus-keyring.c (add_new_key): fix a memleak, and
1553 on realloc be sure to update the pointer in the keyring
1555 * dbus/dbus-string.c (_dbus_string_zero): compensate for align
1556 offset to avoid writing to unallocated memory
1558 * dbus/dbus-auth.c (process_rejected): return FALSE if we fail to
1559 try the next mechanism, so we properly handle OOM
1561 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): fix double-free
1563 (_dbus_keyring_new): fix OOM bug
1564 (_dbus_keyring_new_homedir): always set error; impose a maximum
1565 number of keys we'll load from the file, mostly to speed up the
1566 test suite and make its OOM checks more useful, but also for
1569 * dbus/dbus-auth.c (process_error_server): reject authentication
1570 if we get an error from the client
1571 (process_cancel): on cancel, send REJECTED, per the spec
1572 (process_error_client): send CANCEL if we get an error from the
1575 2003-04-18 Havoc Pennington <hp@pobox.com>
1577 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix UMR in verbose
1580 * dbus/dbus-auth.c (handle_client_data_cookie_sha1_mech): fix OOM
1583 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): only whine
1584 about DBUS_TEST_HOMEDIR once
1586 * bus/Makefile.am (TESTS_ENVIRONMENT): put DBUS_TEST_HOMEDIR in
1589 * bus/dispatch.c (bus_dispatch_sha1_test): actually load sha1
1590 config file so we test the right thing
1592 Throughout: assorted docs improvements
1594 2003-04-18 Havoc Pennington <hp@pobox.com>
1596 * glib/dbus-gmain.c: adapt to watch changes
1598 * bus/bus.c, bus/activation.c, etc.: adjust to watch changes
1600 * dbus/dbus-server.h: remove dbus_server_handle_watch
1602 * dbus/dbus-connection.h: remove dbus_connection_handle_watch
1604 * dbus/dbus-watch.c (dbus_watch_handle): change DBusWatch to work
1605 like DBusTimeout, so we don't need dbus_connection_handle_watch
1608 2003-04-17 Havoc Pennington <hp@redhat.com>
1610 * dbus/dbus-userdb.c, dbus/dbus-sysdeps.c: redo all the passwd
1611 database usage so it all goes via the DBusUserDatabase cache.
1613 2003-04-17 Havoc Pennington <hp@redhat.com>
1615 * dbus/dbus-mainloop.c (_dbus_loop_iterate): fix logic so that if
1616 there was an OOM watch we skipped, we always return TRUE so we
1617 iterate again to have a look at it again. Fixes test suite hang.
1618 Code rearrangement also lets us lose some memset and only iterate
1619 over callbacks once.
1621 * bus/driver.c (bus_driver_handle_message): sense of test for
1624 2003-04-16 Havoc Pennington <hp@pobox.com>
1626 * doc/dbus-specification.sgml: make spec say serials are unsigned
1628 * dbus/dbus-message.h: change message serials to unsigned
1630 * dbus/dbus-connection.c: adapt to message serials being unsigned
1632 2003-04-15 Havoc Pennington <hp@pobox.com>
1634 * bus/bus.c: create and keep around a shared DBusUserDatabase
1637 * bus/connection.c (bus_connection_get_groups): don't cache
1638 groups for user in the connection object, since user database
1639 object now does that.
1641 2003-04-16 Havoc Pennington <hp@redhat.com>
1643 * dbus/dbus-message.c (_dbus_message_add_size_counter): keep a
1644 list of size counters
1645 (_dbus_message_loader_putback_message_link): put back a popped link
1647 * dbus/dbus-connection.c
1648 (dbus_connection_set_max_live_messages_size): rename
1650 (dbus_connection_get_outgoing_size): get size of outgoing
1652 (_dbus_connection_set_connection_counter): remove this cruft
1654 2003-04-14 Havoc Pennington <hp@redhat.com>
1656 * dbus/dbus-userdb.c: user database abstraction, mostly to get
1657 caching, but at some point we might want to be able to use a
1660 * bus/dispatch.c (bus_dispatch_sha1_test): add a test that uses
1661 SHA1 conf file to test the sha1 auth mechanism, since the regular
1662 test always uses EXTERNAL when available.
1665 test/data/valid-config-files/debug-allow-all-sha1.conf.in:
1666 add conf file that requires use of sha1 auth
1668 2003-04-13 Havoc Pennington <hp@pobox.com>
1670 * tools/dbus-send.c, tools/dbus-monitor.c: two utility programs
1671 from Philip Blundell to send messages and monitor them.
1673 2003-04-13 Havoc Pennington <hp@pobox.com>
1675 * dbus/dbus-mainloop.c: fix some reentrancy issues by refcounting
1678 * test/data/valid-config-files/debug-allow-all.conf.in: allow all
1681 * dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
1682 fix to only recover unused bytes if we're already authenticated
1683 (_dbus_transport_get_is_authenticated): fix to still mark us
1684 authenticated if there are unused bytes.
1686 * bus/dispatch.c: implement security policy checking
1688 * bus/connection.c (bus_transaction_send_from_driver): new
1690 * bus/bus.c (bus_context_check_security_policy): new
1692 * bus/dispatch.c (send_service_nonexistent_error): delete this,
1693 now we just set the DBusError and it gets converted to an error
1696 * bus/connection.c (allow_user_function): enable code using actual
1697 data from the config file
1699 * bus/policy.c (list_allows_user): handle wildcard rules for
1700 user/group connection perms
1702 2003-04-13 Havoc Pennington <hp@pobox.com>
1704 * bus/config-parser.c: Load up the BusPolicy and BusPolicyRules
1706 * dbus/dbus-sysdeps.c (_dbus_get_user_id): new function
1708 * bus/policy.c (bus_policy_append_mandatory_rule)
1709 (bus_policy_append_default_rule, bus_policy_append_user_rule)
1710 (bus_policy_append_group_rule): new functions
1712 2003-04-12 Havoc Pennington <hp@pobox.com>
1714 * bus/config-parser.c (bus_config_parser_new): fix a memleak
1716 * dbus/dbus-sysdeps.c: change DBusCredentials to use longs for
1717 the pid/gid/uid, just for paranoia.
1719 * test/break-loader.c (randomly_do_n_things): find a byte
1720 containing a type code, and randomly change it to a different
1723 2003-04-12 Havoc Pennington <hp@pobox.com>
1725 * bus/policy.h: change BusPolicy to be the thing from the config
1726 file, and rename old BusPolicy to BusClientPolicy
1728 * bus/bus.c, bus/connection.c, bus/config-parser.c: change to
1729 match change in how policy works
1731 * dbus/dbus-internals.h: mark assert_not_reached as
1732 __attribute((noreturn))__
1734 2003-04-11 Havoc Pennington <hp@redhat.com>
1736 * doc/dbus-specification.sgml: fix a spot with the wrong name for
1737 the broadcast service. Use boolean return for ServiceExists.
1739 2003-04-11 Havoc Pennington <hp@redhat.com>
1741 * configure.in: add another directory to look for qt in.
1743 2003-04-11 Havoc Pennington <hp@redhat.com>
1745 * AUTHORS: add Colin Walters
1747 2003-04-11 Havoc Pennington <hp@redhat.com>
1753 2003-04-11 Havoc Pennington <hp@redhat.com>
1755 * bus/messagebus.in: remove pid file when stopping the
1756 message bus, since the bus won't have privileges to remove it
1759 2003-04-11 Havoc Pennington <hp@redhat.com>
1761 * bus/bus.c (bus_context_new): move credentials change after
1764 2003-04-11 Havoc Pennington <hp@pobox.com>
1766 * test/decode-gcov.c: add "below average functions" to the
1767 coverage report, and change how some of the code works.
1769 * bus/test-main.c: bracket some stuff in DBUS_BUILD_TESTS so it's
1770 not in the coverage stats.
1772 * test/test-service.c (main): use _dbus_verbose not fprintf in a
1773 couple places so running the test suite doesn't result in megaspam.
1775 2003-04-11 Havoc Pennington <hp@pobox.com>
1777 * bus/dispatch.c (check_existent_service_activation): accept a no
1778 memory error in a place we didn't before
1780 * bus/test.c (bus_test_run_everything): remove hacky "do it twice
1781 in case the first one failed," since the test suite is less
1784 2003-04-10 Havoc Pennington <hp@pobox.com>
1786 * bus/dispatch.c (check_segfault_service_activation): add test
1787 for launching an executable that just crashes.
1789 * test/test-segfault.c (main): try setting coredumpsize to 0 so we
1790 don't leave a million cores. We'll see how portable this is.
1792 2003-04-10 Havoc Pennington <hp@pobox.com>
1794 * dbus/dbus-spawn.c (_dbus_spawn_async_with_babysitter): move all
1795 the possible parent failures before we fork, so that we don't
1796 fail to create a babysitter after creating the child.
1798 * bus/activation.c (bus_activation_activate_service): kill child
1799 if we don't successfully complete the activation.
1801 2003-04-10 Havoc Pennington <hp@redhat.com>
1803 * dbus/dbus-connection.c (dbus_connection_flush): don't spin on
1804 the connection if it's disconnected
1806 * bus/activation.c (bus_activation_service_created): use new
1807 transaction features to roll back removal of pending activation if
1808 we don't successfully create the service after all. Don't remove
1809 pending activation if the function fails.
1811 * dbus/dbus-list.c (_dbus_list_insert_before_link)
1812 (_dbus_list_insert_after_link): new code to facilitate
1815 * dbus/dbus-hash.c (_dbus_hash_table_insert_string_preallocated):
1816 new functionality, so we can preallocate the ability to insert
1819 * bus/connection.c (bus_transaction_add_cancel_hook): new function
1820 allowing us to put custom hooks in a transaction to be used for
1821 cancelling said transaction
1823 * doc/dbus-specification.sgml: add some discussion of secondary
1824 service owners, and disallow zero-length service names
1826 * bus/services.c (bus_registry_acquire_service): new function,
1827 splits out part of bus_driver_handle_acquire_service() and fixes
1828 a bug where we didn't remove the service doing the acquiring
1829 from the secondary queue if we failed to remove the current owner
1830 from the front of the queue.
1832 2003-04-10 Alexander Larsson <alexl@redhat.com>
1834 * doc/dbus-specification.sgml:
1835 s/org.freedesktop.Broadcast/org.freedesktop.DBus.Broadcast/
1837 2003-04-10 Alexander Larsson <alexl@redhat.com>
1842 Added files to cvsignore
1844 * dbus/dbus-message.h:
1845 * dbus/dbus-message.c: (dbus_message_iter_get_named):
1846 Make get_named() take two out argument and return a boolean.
1847 (dbus_message_iter_get_args_valist):
1848 Update usage of get_named().
1849 (dbus_message_iter_append_byte):
1851 (dbus_message_iter_append_named)
1853 (message_iter_test), (check_message_handling_type), (_dbus_message_test):
1856 2003-04-10 Alexander Larsson <alexl@redhat.com>
1858 * dbus/dbus-marshal.[ch]:
1859 Add array_type_pos argument to _dbus_marshal_validate_arg.
1860 Let you pass a NULL end_pos to _dbus_marshal_validate_type.
1862 * dbus/dbus-message.[ch]:
1863 Multi-dimensional arrays have full type specification in the
1864 outermost array. Iter code re-arranged to handle this.
1865 Added some more iter tests.
1867 * doc/dbus-specification.sgml:
1870 Update new array encoding description.
1871 Correct DBUS_SERVICE_FLAGS_REPLACE_EXISTING description.
1873 * test/data/invalid-messages/array-with-mixed-types.message:
1874 * test/data/valid-messages/array-of-array-of-uint32.message:
1875 Change to the new array format.
1877 * test/data/invalid-messages/too-short-dict.message:
1880 * test/data/valid-messages/recursive-types.message:
1881 Fix up and extend test.
1883 2003-04-10 Havoc Pennington <hp@pobox.com>
1885 * bus/dispatch.c: lots of fixes
1887 * dbus/dbus-mainloop.c (_dbus_loop_dispatch): export
1888 (_dbus_loop_iterate): remove old "quit if no callbacks" code,
1889 that was crack, broke the test service.
1891 * dbus/dbus-transport.c (_dbus_transport_open): fix error
1892 handling to avoid piling up errors if we get a failure on the
1895 * dbus/dbus-internals.c (_dbus_real_assert_not_reached): include
1896 pid in assertion failures.
1898 * dbus/dbus-mainloop.c (_dbus_loop_iterate): use static arrays up
1899 to some fixed size of file descriptor array. Don't return TRUE
1900 anytime a timeout exists, that led to lots of busy loop silliness
1903 2003-04-09 Havoc Pennington <hp@redhat.com>
1905 * dbus/dbus-mainloop.c (check_timeout): fix timeouts, I thought
1906 I'd checked this in earlier but hadn't.
1908 2003-04-09 Havoc Pennington <hp@redhat.com>
1910 * bus/dispatch.c (bus_dispatch_test): get a bit further through
1911 the activation test (man this is getting old!)
1913 2003-04-09 Havoc Pennington <hp@redhat.com>
1915 * test/test-utils.c: use dispatch status function to fix this up
1917 * bus/connection.c (connection_watch_callback): don't dispatch
1919 (connection_timeout_callback): don't dispatch from here
1920 (bus_connections_setup_connection): set the dispatch status function
1921 (bus_connection_disconnected): unset it
1923 * dbus/dbus-mainloop.c (_dbus_loop_queue_dispatch): new function
1924 used to add a connection to be dispatched
1925 (_dbus_loop_iterate): do the dispatching at the end of each
1928 * dbus/dbus-connection.c
1929 (dbus_connection_set_dispatch_status_function): new function
1930 allowing us to fix up main loop usage
1931 (_dbus_connection_last_unref): free all the various function
1933 (dbus_connection_dispatch): call the DispatchStatusFunction
1934 whenever this function returns
1935 (dbus_connection_handle_watch): call DispatchStatusFunction
1936 (dbus_connection_send_with_reply_and_block): call DispatchStatusFunction
1937 (reply_handler_timeout): call DispatchStatusFunction
1938 (dbus_connection_flush): call DispatchStatusFunction
1940 2003-04-09 Havoc Pennington <hp@redhat.com>
1942 * dbus/dbus-bus.c (dbus_bus_register): fix up error handling and
1945 * bus/dispatch.c (check_service_activated): fix bug in test
1947 * dbus/dbus-mainloop.c (check_timeout): fix this up
1949 * dbus/dbus-internals.c (_dbus_verbose_real): include PID in
1950 verbose output so we can sort out output from different processes,
1951 e.g. in the activation case.
1953 2003-04-08 Colin Walters <walters@gnu.org>
1955 * bus/bus.c (struct BusContext) [pidfile]: New member, to store
1957 (bus_context_new): Set it.
1958 (bus_context_unref): Use it to delete the pid file.
1960 2003-04-08 Havoc Pennington <hp@redhat.com>
1962 * test/data/invalid-messages/array-with-mixed-types.message:
1963 regression test that fails for the moment
1965 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): reorder
1966 tests for convenience
1968 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): don't allow
1969 array of nil, it broke things.
1971 * test/data/invalid-messages/array-of-nil.message: regression test
1973 * test/data/valid-messages/array-of-array-of-uint32.message:
1974 happened to write this so added it to suite
1976 2003-04-08 Havoc Pennington <hp@redhat.com>
1978 * bus/driver.c (bus_driver_handle_acquire_service): init
1979 retval/reply before checking name
1981 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add a
1982 recursion depth argument
1984 * dbus/dbus-message.h (struct DBusMessageIter): put some padding
1985 in the public struct for future extension
1987 * dbus/dbus-message-builder.c (_dbus_message_data_load): fix
1990 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix a verbose
1993 * doc/dbus-specification.sgml: fix typo
1995 2003-04-08 Alexander Larsson <alexl@redhat.com>
1997 Implemented recursive types, named types and new-style iters
2000 * glib/test-thread-client.c: (thread_func):
2001 * glib/test-thread-server.c: (handle_test_message):
2002 * test/test-service.c: (handle_echo):
2011 * dbus/dbus-internals.c: (_dbus_type_to_string):
2012 Update for new types.
2014 * dbus/dbus-marshal.[ch]:
2015 Implement recursive types and the new marshalling format.
2016 Remove hardcoded dict marshalling.
2017 Marshal named types.
2019 * dbus/dbus-message-builder.c:
2021 Remove references to old types
2023 * dbus/dbus-message.[ch]:
2024 New non-refcounted iter API that supports recursive iters.
2025 Use iters for appending, including support for recursive
2027 Add byte and named type support.
2028 Update everything to new marshalling formats.
2029 Add tests for new API.
2031 * dbus/dbus-protocol.h:
2032 Remove old array types.
2033 Add types: BYTE, ARRAY, DICT, NAMED
2035 * dbus/dbus-string.c:
2036 * dbus/dbus-sysdeps.c:
2037 Make parse_double locale safe.
2039 * dbus/dbus-test-main.c:
2045 * doc/dbus-specification.sgml:
2048 * test/data/incomplete-messages/missing-body.message:
2049 * test/data/invalid-messages/bad-boolean.message:
2050 * test/data/invalid-messages/bad-boolean-array.message:
2051 * test/data/invalid-messages/boolean-array-length-too-long.message-raw:
2052 * test/data/invalid-messages/boolean-has-no-value.message-raw:
2053 * test/data/invalid-messages/too-short-dict.message:
2054 * test/data/valid-messages/dict-simple.message:
2055 * test/data/valid-messages/dict.message:
2056 * test/data/valid-messages/emptiness.message:
2057 * test/data/valid-messages/lots-of-arguments.message:
2058 * test/data/valid-messages/no-padding.message:
2059 * test/data/valid-messages/recursive-types.message:
2060 Add missing NAME fields
2061 Fix up dicts & arrays
2063 * test/data/invalid-messages/dict-with-nil-value.message:
2064 Removed, this is not invalid anymore.
2066 * test/data/valid-messages/recursive-types.message:
2067 Add new test for deeply recursive types.
2069 2003-04-07 Havoc Pennington <hp@pobox.com>
2071 * bus/driver.c (bus_driver_handle_acquire_service): return an
2072 error if you try to acquire a service that starts with ':'
2074 2003-04-07 Havoc Pennington <hp@redhat.com>
2076 * doc/dbus-specification.sgml: require that base service names
2077 start with ':' and that the base service is created/deleted
2078 as first and last things a connection does on the bus
2080 * bus/dispatch.c (check_existent_service_activation): lots more
2081 work on the activation test; it doesn't fully pass yet...
2083 * test/test-service.c (main): fix so we don't memleak the
2084 connection to the message bus
2085 (filter_func): accept a message asking us to exit
2087 2003-04-06 Havoc Pennington <hp@pobox.com>
2089 * qt/Makefile.am (dbusinclude_HEADERS): install dbus-qt.h,
2092 * configure.in: fixes to Qt detection from Colin Walters
2094 * doc/Makefile.am: Only remove generated docbook dirs if they
2095 exist, from Colin Walters
2097 * dbus/dbus-bus.c: change how we set well-known connections to
2098 NULL, so that it works if a single connection is stored in
2099 two well-known array slots.
2101 * test/Makefile.am: remove a lot of stuff that isn't immediately
2102 useful, it's in CVS history if we want it.
2104 * test/test-service.c: use dbus-mainloop instead of that
2107 2003-04-06 Havoc Pennington <hp@pobox.com>
2109 * dbus/Makefile.am: split lists of sources into stuff that goes in
2110 the library, util functions that go in the lib and are also used
2111 elsewhere, and util functions that are used in tests/daemon but
2112 don't go in the lib.
2114 * dbus/dbus-mainloop.h, dbus/dbus-mainloop.c: move bus/loop.[hc]
2115 here so it can be used in test binaries also
2117 2003-04-06 Havoc Pennington <hp@pobox.com>
2119 * dbus/dbus-sysdeps.c (_dbus_become_daemon): write the pidfile
2120 here in the parent process, so we can return an error if it
2121 fails. Also, move some of the code into the child so the parent
2122 is less hosed if we fail midway through.
2124 * bus/bus.c (bus_context_new): move pidfile detection further up
2125 in the function, before we start overwriting sockets and such.
2127 * bus/messagebus.in: adjust this a bit, not sure if it will work.
2129 * configure.in: add --with-system-pid-file and --with-system-socket
2131 2003-04-06 Colin Walters <walters@verbum.org>
2133 * configure.in (DBUS_SYSTEM_PID_FILE): New variable.
2135 * bus/system.conf.in: Declare a pidfile.
2137 * bus/bus.c (bus_context_new): Test for an existing pid file, and
2138 create one (if appropriate).
2140 * bus/config-parser.c (enum ElementType) [ELEMENT_PIDFILE]: New.
2141 (struct BusConfigParser) [pidfile]: New.
2142 (element_type_to_name, merge_included, start_busconfig_child)
2143 (bus_config_parser_end_element, bus_config_parser_content): Handle it.
2144 (bus_config_parser_unref): Free it.
2145 (bus_config_parser_get_pidfile): New function.
2147 * bus/config-parser.h (_dbus_write_pid_file): Prototype.
2149 * dbus/dbus-errors.h (DBUS_ERROR_PIDFILE_EXISTS): New error.
2151 * dbus/dbus-sysdeps.c (_dbus_write_pid_file): New function.
2153 * dbus/dbus-sysdeps.h: Prototype it.
2155 2003-04-06 Havoc Pennington <hp@pobox.com>
2157 * bus/bus.c (bus_context_new): print the address in here, rather
2158 than in main(), because we need to do it before forking the daemon
2160 * bus/dispatch.c (send_service_nonexistent_error): set the sender
2161 on the service nonexistent error
2163 * bus/driver.c (bus_driver_handle_acquire_service): set the
2164 sender on the AcquireService reply
2166 * test/data/valid-config-files/debug-allow-all.conf.in: Make test
2167 server also listen on a UNIX socket so services can connect to it.
2169 2003-04-06 Havoc Pennington <hp@pobox.com>
2171 * dbus/dbus-threads.c: Redo how the fake debug mutexes are done
2172 so it detects deadlocks and also we actually init threads when
2175 2003-04-06 Havoc Pennington <hp@pobox.com>
2177 * dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
2178 save the domain socket name, and unlink it when we disconnect the
2179 server. Means that at least when we exit normally, we won't leave
2180 a bunch of junk in /tmp
2182 * dbus/dbus-transport-unix.c
2183 (_dbus_transport_new_for_domain_socket): code cleanup (nicer
2184 memory management). (I was making a real change here but then
2187 2003-04-06 Havoc Pennington <hp@pobox.com>
2189 * bus/bus.c (bus_context_new): fix wrong handling of
2190 server_data_slot_unref() in the error case.
2192 * dbus/dbus-internals.h (_dbus_assert): change so it passes
2193 "(condition) != 0" to _dbus_real_assert so that
2194 "_dbus_assert (pointer)" doesn't cause a warning
2196 * bus/main.c (main): accept --print-address option to print out
2197 the message bus address
2199 * dbus/dbus-sysdeps.c (_dbus_generate_random_ascii): export this
2201 * dbus/dbus-transport.c (_dbus_transport_open): special error for
2202 "tmpdir" option to unix: address on client side
2204 * dbus/dbus-server.c (dbus_server_listen): handle "tmpdir" option
2207 * configure.in (TEST_SOCKET_DIR): locate a temporary directory
2208 we can use to create sockets in the test suite.
2210 * bus/main.c (signal_handler): on SIGTERM, exit the daemon
2211 cleanly. To be used for testing.
2213 * dbus/dbus-spawn.c (babysit): use _dbus_set_signal_handler()
2215 * dbus/dbus-sysdeps.c (_dbus_set_signal_handler): new
2217 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
2218 handle trying to call this when there's no servers active
2220 2003-04-05 Havoc Pennington <hp@pobox.com>
2226 2003-04-05 Havoc Pennington <hp@pobox.com>
2228 * bus/bus.c (setup_server): fix this so dbus-daemon-1 doesn't
2229 crash on startup. Need to get "try starting the daemon"
2230 in the test suite I guess. ;-)
2232 * dbus/dbus-server.h, dbus/dbus-server.c: remove the stuff that
2233 tracked the number of open connections; it's better done in
2234 application-specific code as you want it to span all servers etc.
2236 2003-04-05 Havoc Pennington <hp@pobox.com>
2238 * bus/Makefile.am (install-data-hook): add missing DESTDIR,
2239 patch from Colin Walters
2241 2003-04-05 Havoc Pennington <hp@pobox.com>
2243 * doc/config-file.txt (Elements): fix docs of <auth> to reflect
2244 reality; in fact multiple mechanisms are allowed.
2246 * dbus/dbus-internals.c (_dbus_real_assert)
2247 (_dbus_real_assert_not_reached): move guts of _dbus_assert() and
2248 _dbus_assert_not_reached() into functions, so that they don't show
2249 up in basic block counts for test coverage, and don't use up as
2250 much disk space. Does mean slower execution speed though, so
2251 assumes --disable-asserts is the normal production case.
2253 2003-04-05 Havoc Pennington <hp@pobox.com>
2255 * test/Makefile.am (dist-hook): also dist *.in files
2261 2003-04-05 Havoc Pennington <hp@pobox.com>
2263 * dbus/dbus-string.c: docs warning
2265 * dbus/dbus-spawn.c: missing docs
2267 * dbus/dbus-memory.c (struct ShutdownClosure): missing docs
2269 2003-04-05 Havoc Pennington <hp@pobox.com>
2271 * bus/loop.c (bus_loop_iterate): fix the timeout code, using
2274 * dbus/dbus-spawn.c (_dbus_babysitter_unref): set sitter_pid
2275 to -1 once we've reaped the babysitter
2276 (_dbus_babysitter_handle_watch): do as much work as we can, not
2279 * bus/activation.c: add code using DBusBabysitter so that we
2280 handle it when a service fails to start up properly.
2281 (bus_activation_service_created): don't remove the activation
2282 entries as we go, just let them get removed when we free the pending
2283 activation. Unref reply messages after sending them.
2285 2003-04-05 Havoc Pennington <hp@pobox.com>
2287 * test/decode-gcov.c (main): print per-directory stats in the report
2289 * Makefile.am (coverage-report.txt): don't include test/* in gcov stats
2291 2003-04-05 Havoc Pennington <hp@pobox.com>
2293 * Makefile.am (coverage-report.txt): add target "coverage-report.txt"
2295 * test/decode-gcov.c: hack up a little program to suck data
2296 out of gcov files. Yes this is sort of silly.
2298 * configure.in: define something in config.h and do an
2299 AM_CONDITIONAL when gcov is enabled
2301 2003-04-04 Havoc Pennington <hp@redhat.com>
2303 * dbus/dbus-spawn.c, dbus/dbus-spawn.h: Change dbus_spawn to
2304 return a "babysitter" object that is used to monitor the status of
2305 the spawned process and reap it when required.
2307 * test/test-segfault.c, test/test-exit.c,
2308 test/test-sleep-forever.c: binaries that do various lame things,
2309 used in the test suite.
2311 * dbus/dbus-sysdeps.c: kill _dbus_errno_to_string()
2313 2003-04-03 Havoc Pennington <hp@pobox.com>
2315 * dbus/dbus-spawn.c: Move dbus-spawn into a separate file
2316 in preparation for modifying it, dbus-sysdeps is getting
2319 2003-04-03 Havoc Pennington <hp@redhat.com>
2321 * bus/loop.h, bus/loop.c: make the mainloop an object so we can
2324 * bus/*.[hc]: adapt to mainloop change
2326 2003-04-03 Havoc Pennington <hp@redhat.com>
2328 * bus/activation.c (load_directory): fix up memleaks
2329 (bus_activation_entry_free): free the entry
2331 * dbus/dbus-bus.c (dbus_bus_acquire_service): return an error if
2332 we get one from the message bus; fix memleaks.
2334 * dbus/dbus-message.c (dbus_set_error_from_message): new function
2336 2003-04-03 Havoc Pennington <hp@pobox.com>
2338 * bus/config-parser.c (bus_config_parser_unref): free
2339 list of mechanisms, bug discovered by test suite enhancements
2340 (putting system.conf and session.conf into suite)
2342 * test/Makefile.am, test/test-service.c: add placeholder for a
2343 test service that we'll activate as part of test suite. Doesn't
2346 * dbus/dbus-sysdeps.c (_dbus_setenv): support unsetenv by
2347 setting NULL value, and use system malloc not dbus_malloc()
2348 when we have unavoidable memleakage.
2350 * dbus/dbus-bus.c (dbus_bus_get): fix bug where bus type of 0
2351 didn't work, and support DBUS_BUS_ACTIVATION.
2353 * bus/activation.c (child_setup): pass our well-known bus type to
2356 * bus/config-parser.c: support <type> to specify well-known type
2358 * doc/dbus-specification.sgml: document the env variables to
2359 locate well-known buses and find service activator
2361 2003-04-02 Havoc Pennington <hp@redhat.com>
2363 * test/Makefile.am (all-local): add a rule to copy tests to
2364 builddir, so we can have generated tests. Use this to remove the
2365 silly hack for testing system.conf and session.conf. Will use this
2366 shortly to generate .service files pointing to test binaries.
2368 2003-04-02 Havoc Pennington <hp@redhat.com>
2370 * dbus/dbus-string.c (set_length): fix a bug - we allocated max of
2371 current alloc and needed new length, not max of the doubled
2372 allocation and needed new length. Also, when building tests,
2373 don't do the double-allocation stuff, just realloc every time.
2375 2003-04-02 Havoc Pennington <hp@redhat.com>
2377 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): include filenames
2379 (_dbus_string_get_dirname): new
2380 (_dbus_sysdeps_test): new
2381 (_dbus_directory_open): include dirnames in error messages
2383 * bus/config-parser.c: interpret <include> and <includedir> and
2384 <servicedir> relative to config file location if the given
2385 filename is not absolute.
2387 * dbus/dbus-string.c (_dbus_string_find_byte_backward): new
2389 2003-04-02 Havoc Pennington <hp@redhat.com>
2391 * bus/connection.c (bus_transaction_send_error_reply): set sender
2392 service for the error, and unref the reply on success
2394 * bus/activation.c: convert to use BusTransaction so OOM can be
2396 (bus_activation_service_created): set sender of the message
2398 2003-04-01 Havoc Pennington <hp@redhat.com>
2400 * bus/config-parser.c, bus/bus.c: implement <servicedir> and
2401 <includedir> (at least mostly)
2403 * dbus/dbus-sysdeps.c (_dbus_change_identity): set the group ID
2404 first, then the user ID
2406 2003-04-01 Havoc Pennington <hp@pobox.com>
2408 * dbus/dbus-server.c (dbus_server_set_auth_mechanisms): new
2411 * dbus/dbus-auth.c (_dbus_auth_set_mechanisms): new
2413 * dbus/dbus-internals.c (_dbus_dup_string_array): new function
2415 * dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): chmod the
2416 socket 0777, and unlink any existing socket.
2418 * bus/bus.c (bus_context_new): change our UID/GID and fork if
2419 the configuration file so specifies; set up auth mechanism
2422 * bus/config-parser.c (bus_config_parser_content): add support
2423 for <fork> option and fill in code for <auth>
2425 * bus/system.conf.in: add <fork/> to default configuration,
2426 and limit auth mechanisms to EXTERNAL
2428 * doc/config-file.txt (Elements): add <fork>
2430 * dbus/dbus-sysdeps.c (_dbus_become_daemon): new function
2431 (_dbus_change_identity): new function
2433 2003-03-31 Havoc Pennington <hp@redhat.com>
2435 * dbus/dbus-sysdeps.c (_dbus_connect_unix_socket)
2436 (_dbus_listen_unix_socket): fix off-by-one error in null
2437 termination spotted by Nalin
2439 2003-03-31 Havoc Pennington <hp@redhat.com>
2441 * dbus/dbus-keyring.c (_dbus_keyring_new_homedir): allow setting
2442 DBUS_TEST_HOMEDIR when tests are enabled, so we can test without
2443 having a real home directory available.
2445 2003-03-31 Havoc Pennington <hp@redhat.com>
2447 * bus/Makefile.am (install-data-hook): create /var/run/dbus
2449 * bus/messagebus.in: add init script for Red Hat /etc/init.d
2451 * configure.in: add support for specifying a style of init script
2454 2003-03-31 Havoc Pennington <hp@redhat.com>
2456 Fix some annoying DBusString API and fix all affected code.
2458 * dbus/dbus-string.c (_dbus_string_init): get rid of annoying
2460 (_dbus_string_get_data): change to return string instead of using
2462 (_dbus_string_get_const_data): ditto
2463 (_dbus_string_get_data_len): ditto
2464 (_dbus_string_get_const_data_len): ditto
2466 2003-03-31 Havoc Pennington <hp@redhat.com>
2468 * bus/main.c (main): fix up the command line arguments to be nicer
2470 2003-03-31 Havoc Pennington <hp@redhat.com>
2472 * dbus/Makefile.am (INCLUDES): use EXPANDED_LOCALSTATEDIR to
2473 define DBUS_SYSTEM_BUS_PATH as we want to compile in the same
2474 final location that lands in the config file
2476 * bus/config-loader-expat.c (bus_config_load): fix type of
2479 * doc/TODO: remove TODO item for dbus_bus_get()
2481 * dbus/dbus-bus.c (bus_data_free): add missing lock/unlock
2483 2003-03-31 Havoc Pennington <hp@pobox.com>
2485 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_domain_socket)
2486 (_dbus_transport_new_for_tcp_socket): these didn't need the "server"
2487 argument since they are always client side
2489 * dbus/dbus-server.c (dbus_server_get_address): new function
2491 * bus/main.c (main): take the configuration file as an argument.
2493 * test/data/valid-config-files/debug-allow-all.conf: new file to
2494 use with dispatch.c tests for example
2496 * bus/test-main.c (main): require test data dir
2498 * bus/bus.c (bus_context_new): change this to take a
2499 configuration file name as argument
2501 * doc/config-file.txt (Elements): add <servicedir>
2503 * bus/system.conf, bus/session.conf: new files
2505 * dbus/dbus-bus.c (dbus_bus_get): look for system bus on
2506 well-known socket if none set
2508 * configure.in: create system.conf and session.conf
2510 2003-03-30 Havoc Pennington <hp@pobox.com>
2512 * bus/config-parser.c: hacking
2514 * dbus/dbus-memory.c: don't use DBusList for the list of stuff
2515 to shut down, since it could cause weirdness with the DBusList
2518 * dbus/dbus-list.c (_dbus_list_test): add tests for the
2519 link-oriented stack routines
2520 (alloc_link): free the mempool if the first alloc from it fails
2522 * dbus/dbus-mempool.c (struct DBusMemBlock): fix alignment issue
2524 * dbus/dbus-string.c (UNICODE_VALID): sync new version of this
2526 (_dbus_string_skip_white): new
2528 * doc/config-file.txt (Elements): add <includedir>
2530 2003-03-28 Havoc Pennington <hp@pobox.com>
2532 * dbus/dbus-string.c (_dbus_string_copy_data_len)
2533 (_dbus_string_copy_data): new functions
2535 2003-03-28 Anders Carlsson <andersca@codefactory.se>
2537 * dbus/dbus-bus.c: (bus_data_free), (dbus_bus_get):
2541 * dbus/dbus-memory.c:
2544 2003-03-28 Havoc Pennington <hp@pobox.com>
2546 * bus/test.c (bus_test_flush_bus): remove the sleep from here,
2547 I think it may have just been superstition. Not sure.
2549 * dbus/dbus-string.c (_dbus_string_base64_decode): catch some OOM
2550 failures that were not being handled.
2552 * dbus/dbus-auth.c (process_auth): fix a memleak in OOM handling
2554 * dbus/dbus-memory.c: add ability to set number of mallocs in a
2555 row that will fail on out-of-memory.
2557 * dbus/dbus-internals.c (_dbus_test_oom_handling): convenience
2558 function for testing out-of-memory handling.
2560 * bus/config-loader-expat.c (memsuite): don't wrap the dbus
2561 allocation functions, they do map exactly to the expat ones.
2563 2003-03-27 Havoc Pennington <hp@redhat.com>
2565 * bus/config-loader-libxml.c (bus_config_load): add another error
2568 2003-03-26 Anders Carlsson <andersca@codefactory.se>
2571 Add note about automatic service activation.
2573 * doc/dbus-specification.sgml:
2574 Rename the specification and clarify a few things.
2576 2003-03-26 Anders Carlsson <andersca@codefactory.se>
2579 * dbus/dbus-address.c:
2581 * dbus/dbus-marshal.c:
2582 * dbus/dbus-server-debug-pipe.c:
2583 * dbus/dbus-transport-unix.c:
2584 Fix documentation warnings.
2586 2003-03-26 Havoc Pennington <hp@pobox.com>
2588 * bus/test-main.c, dbus/dbus-test.c (main): check memleaks
2589 after every test so it's quick and easy to see which leaked, and
2590 so we test multiple dbus_shutdown() calls
2592 * configure.in: change configure.in XML stuff to also support
2595 * config-loader-libxml.c: some hacking
2597 * config-loader-expat.c: some hacking
2599 * config-parser.c: some hacking, plus tests
2601 2003-03-25 Havoc Pennington <hp@redhat.com>
2603 * throughout - add more _DBUS_ASSERT_ERROR_IS_CLEAR
2605 * configure.in: add --with-xml option to specify XML library,
2606 right now only libxml is supported.
2608 * bus/config-loader-libxml.c, config-parser.c: sync some minor
2609 nonworking code between home and work, still just stubs
2611 2003-03-24 Havoc Pennington <hp@redhat.com>
2613 * dbus/dbus-sysdeps.c (_dbus_set_fd_nonblocking): move to this
2616 * dbus/dbus-errors.c (dbus_set_error, dbus_set_error_const): allow
2617 NULL argument for "message" if the error is a well-known one,
2618 fill in a generic message in this case.
2620 * dbus/dbus-errors.h (DBusResultCode): Kill DBusResultCode in
2623 * bus/test.c (bus_test_flush_bus): add
2625 * bus/policy.c (bus_policy_test): test code stub
2627 2003-03-24 Havoc Pennington <hp@pobox.com>
2629 * bus/connection.c (bus_connections_setup_connection): set up
2630 the "can this user connect" function, but it always returns
2631 TRUE until we have a config file parser so we can have a config
2632 file that allows connections.
2634 2003-03-23 Havoc Pennington <hp@pobox.com>
2636 * dbus/dbus-threads.c (dbus_mutex_new, dbus_condvar_new): with
2637 DBUS_BUILD_TESTS, actually alloc/free a block of memory for
2638 the mutex, so we can check for proper memory management
2641 * dbus/dbus-dataslot.c: remove the mutex from
2642 DBusDataSlotAllocator and lock it manually when using it,
2643 to simplify fitting it into the global slots framework.
2645 * dbus/dbus-threads.c (init_static_locks): rework how we're
2646 handling global locks so they are easily shut down.
2648 * bus/policy.c (bus_policy_append_rule): fix
2650 * bus/test-main.c (main): check for memleaks
2652 * dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): make
2653 test suite check for memleaks
2655 * dbus/dbus-memory.c: add support in test mode for tracking
2656 number of outstanding blocks
2658 2003-03-23 Havoc Pennington <hp@pobox.com>
2660 * bus/policy.c, bus/bus.c, bus/connection.c: implement allow/deny
2663 * dbus/dbus-hash.h: add ULONG hash keys
2665 * dbus/dbus-sysdeps.c (_dbus_get_groups): new
2666 (_dbus_get_group_id): new function
2668 2003-03-20 Havoc Pennington <hp@redhat.com>
2670 * dbus/dbus-connection.c (dbus_connection_set_unix_user_function):
2672 (dbus_connection_get_unix_user): new function
2674 2003-03-20 Havoc Pennington <hp@pobox.com>
2676 * bus/connection.c (bus_connection_send_oom_error): assert that
2677 message has a sender
2678 (connection_execute_transaction): ditto
2679 (bus_connection_preallocate_oom_error): fix to set the sender, and
2680 set recipient to the destination service, not the bus driver
2682 * bus/policy.c: hacking
2684 * dbus/dbus-message.c (dbus_message_service_is): new function
2685 (dbus_message_sender_is): new
2687 2003-03-19 Havoc Pennington <hp@redhat.com>
2689 * bus/policy.c: start sketching code for policy restrictions on
2690 what connections can do.
2692 2003-03-18 Havoc Pennington <hp@redhat.com>
2694 * doc/TODO: some notes on high-level todo items. Little nitpick
2695 stuff is all in @todo, so no need to add it here.
2697 * doc/config-file.txt: some notes on how config file might look
2699 2003-03-18 Anders Carlsson <andersca@codefactory.se>
2705 2003-03-17 Havoc Pennington <hp@redhat.com>
2707 * dbus/dbus-internals.h: add gcc attributes so that
2708 our printf-style functions warn on bad arguments to
2711 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): fix printf
2714 * dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
2717 2003-03-17 Havoc Pennington <hp@redhat.com>
2719 * bus/test-main.c (main): make it print something as it runs
2720 so make check doesn't look stuck
2722 * doc/negotiation.txt, doc/dbus-sasl-profile.txt: remove
2723 from CVS, now obsolete
2725 2003-03-17 Anders Carlsson <andersca@codefactory.se>
2727 * bus/dispatch.c: (bus_dispatch):
2728 Refetch the service name since it may have been reallocated
2729 when dbus_message_set_sender was called.
2731 * dbus/dbus-sysdeps.c: (_dbus_accept):
2732 Add address and address length variables and use them to stop
2733 valgrind from complaining.
2735 2003-03-17 Havoc Pennington <hp@pobox.com>
2737 All tests pass, no memleaks, no valgrind complaints.
2739 * bus/test.c: refcount handler_slot
2741 * bus/connection.c (bus_connections_new): refcount
2742 connection_data_slot
2744 * dbus/dbus-auth-script.c (_dbus_auth_script_run): delete unused
2745 bytes so that auth scripts pass.
2747 * bus/dispatch.c: init message_handler_slot so it gets allocated
2750 * bus/dispatch.c (message_handler_slot_ref): fix memleak
2752 * dbus/dbus-server-debug-pipe.c (_dbus_server_debug_pipe_new):
2753 dealloc server_pipe_hash when no longer used for benefit of
2756 * dbus/dbus-auth.c (process_command): memleak fix
2758 * bus/dispatch.c (check_hello_message): memleak fix
2760 2003-03-16 Havoc Pennington <hp@pobox.com>
2762 * dbus/dbus-bus.c (ensure_bus_data): fix double-unref of the data slot
2764 2003-03-17 Anders Carlsson <andersca@codefactory.se>
2766 * bus/activation.c (bus_activation_activate_service): Append
2767 the pending activation entry to the list of pending activations.
2769 2003-03-16 Havoc Pennington <hp@pobox.com>
2771 * bus/dispatch.c (bus_dispatch_test): remove double-unrefs of
2774 * dbus/dbus-address.c (create_entry): fix OOM handling when
2775 failing to alloc entry->method
2777 2003-03-16 Havoc Pennington <hp@pobox.com>
2779 * dbus/dbus-watch.c (_dbus_watch_new): handle failure to malloc
2782 * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
2783 add some missing dbus_set_result
2785 * bus/dispatch.c (bus_dispatch_add_connection): handle failure to
2786 alloc the DBusMessageHandler
2788 * dbus/dbus-transport.c (_dbus_transport_disconnect): don't ref
2789 the transport here, since we call this from the finalizer; it
2790 resulted in a double-finalize.
2792 * dbus/dbus-transport.c (_dbus_transport_disconnect): fix a bug
2793 where we tried to use transport->connection that was NULL,
2794 happened when transport was disconnected early on due to OOM
2796 * bus/*.c: adapt to handle OOM for watches/timeouts
2798 * dbus/dbus-transport-unix.c: port to handle OOM during
2801 * dbus/dbus-auth.c (_dbus_auth_get_unused_bytes): return a
2802 reference to unused bytes instead of a copy
2804 * dbus/dbus-server.c (dbus_server_handle_watch): return FALSE for
2807 * dbus/dbus-connection.c (dbus_connection_handle_watch): return
2810 * dbus/dbus-timeout.c (dbus_timeout_handle): return FALSE for out
2813 2003-03-16 Anders Carlsson <andersca@codefactory.se>
2815 * doc/dbus-specification.sgml:
2816 Document reply message for ActivateService.
2818 2003-03-16 Anders Carlsson <andersca@codefactory.se>
2820 * bus/activation.c: (bus_pending_activation_entry_free),
2821 (bus_pending_activation_free), (bus_activation_new),
2822 (bus_activation_unref), (bus_activation_service_created),
2823 (bus_activation_activate_service):
2825 * bus/bus.c: (bus_context_new):
2826 * bus/desktop-file.c: (new_section):
2827 * bus/driver.c: (bus_driver_send_service_deleted),
2828 (bus_driver_handle_activate_service):
2829 * bus/services.c: (bus_registry_new), (bus_registry_ensure):
2831 * dbus/dbus-connection.c:
2832 (dbus_connection_send_with_reply_and_block):
2833 * dbus/dbus-message.c: (dbus_message_append_args_valist):
2834 * dbus/dbus-protocol.h:
2835 Make activation work better. Now pending activations will be queued
2836 and the daemon won't try to activate services that are already registered.
2838 2003-03-16 Havoc Pennington <hp@pobox.com>
2840 * dbus/dbus-bus.c (ensure_bus_data): handle failure to set
2843 * dbus/dbus-memory.c (_dbus_initialize_malloc_debug): support
2844 DBUS_MALLOC_BACKTRACES to print trace when failing an alloc
2846 2003-03-16 Havoc Pennington <hp@pobox.com>
2848 * dbus/dbus-string.c (_dbus_string_validate_utf8): oops, unbreak
2849 this. always run the test suite before commit...
2851 * bus/*: adapt to DBusConnection API changes
2853 * glib/dbus-gmain.c: adapt to DBusConnection API changes,
2854 requires renaming stuff to avoid dbus_connection_dispatch name
2857 * dbus/dbus-transport.c (_dbus_transport_queue_messages): new
2860 * dbus/dbus-message.c (_dbus_message_loader_queue_messages):
2861 separate from _dbus_message_loader_return_buffer()
2863 * dbus/dbus-connection.c (dbus_connection_get_n_messages): remove
2864 this, because it's now always broken to use; the number of
2865 messages in queue vs. the number still buffered by the message
2866 loader is undefined/meaningless. Should use
2867 dbus_connection_get_dispatch_state().
2868 (dbus_connection_dispatch): rename from
2869 dbus_connection_dispatch_message
2871 2003-03-16 Havoc Pennington <hp@pobox.com>
2873 * dbus/dbus-string.c (_dbus_string_validate_utf8): copy in a real
2876 2003-03-16 Anders Carlsson <andersca@codefactory.se>
2878 * dbus/dbus-connection.c:
2879 (dbus_connection_send_with_reply_and_block):
2880 Decrease connection->n_incoming when removing an entry
2882 * dbus/dbus-dict.c: (dbus_dict_entry_free),
2883 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
2884 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
2885 (dbus_dict_set_byte_array), (dbus_dict_set_string_array),
2886 (dbus_dict_get_boolean_array), (dbus_dict_get_double_array),
2887 (dbus_dict_get_byte_array):
2888 Handle NULL arrays and strings. Also add support for byte arrays.
2890 * dbus/dbus-marshal.c: (_dbus_marshal_byte_array),
2891 (_dbus_marshal_dict), (_dbus_demarshal_byte_array),
2892 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
2893 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
2894 (_dbus_demarshal_dict), (demarshal_and_validate_len),
2895 (_dbus_marshal_validate_arg), (_dbus_marshal_test):
2896 * dbus/dbus-marshal.h:
2897 Add support for marshalling and demarshalling empty arrays and strings.
2899 * dbus/dbus-message.c: (dbus_message_append_args_valist),
2900 (dbus_message_append_string_array),
2901 (dbus_message_iter_get_boolean),
2902 (dbus_message_iter_get_boolean_array),
2903 (dbus_message_iter_get_int32_array),
2904 (dbus_message_iter_get_uint32_array),
2905 (dbus_message_iter_get_double_array),
2906 (dbus_message_iter_get_byte_array),
2907 (dbus_message_iter_get_string_array), (dbus_message_iter_get_dict),
2908 (check_message_handling):
2909 Add support for getting empty arrays and dicts.
2911 * dbus/dbus-string.c: (_dbus_string_validate_utf8):
2912 Don't do any validation at all for now, that's better than just checking
2915 * test/data/valid-messages/emptiness.message:
2916 New test message with lots of empty arrays.
2918 2003-03-16 Havoc Pennington <hp@pobox.com>
2920 * dbus/dbus-connection.c
2921 (_dbus_connection_queue_received_message_link): new function that
2922 can't fail due to OOM
2924 * dbus/dbus-message.c (_dbus_message_loader_pop_message_link):
2925 new function pops a message together with a list link
2928 * dbus/dbus-transport-unix.c (queue_messages): use new link-based
2929 message queuing functions to avoid needing to alloc memory
2931 2003-03-16 Havoc Pennington <hp@pobox.com>
2933 Oops - test code was only testing failure of around 30 of the
2934 mallocs in the test path, but it turns out there are 500+
2935 mallocs. I believe this was due to misguided linking setup such
2936 that there was one copy of dbus_malloc etc. in the daemon and one
2937 in the shared lib, and only daemon mallocs were tested. In any
2938 case, the test case now tests all 500+ mallocs, and doesn't pass
2939 yet, though there are lots of fixes in this patch.
2941 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
2942 this so that it doesn't need to allocate memory, since it
2943 has no way of indicating failure due to OOM (and would be
2944 annoying if it did).
2946 * dbus/dbus-list.c (_dbus_list_pop_first_link): new function
2948 * bus/Makefile.am: rearrange to create two self-contained
2949 libraries, to avoid having libraries with overlapping symbols.
2950 that was resulting in weirdness, e.g. I'm pretty sure there
2951 were two copies of global static variables.
2953 * dbus/dbus-internals.c: move the malloc debug stuff to
2956 * dbus/dbus-list.c (free_link): free list mempool if it becomes
2959 * dbus/dbus-memory.c (_dbus_disable_mem_pools): new function
2961 * dbus/dbus-address.c (dbus_parse_address): free list nodes
2964 * bus/dispatch.c (bus_dispatch_add_connection): free
2965 message_handler_slot when no longer using it, so
2966 memory leak checkers are happy for the test suite.
2968 * dbus/dbus-server-debug-pipe.c (debug_finalize): free server name
2970 * bus/bus.c (new_connection_callback): disconnect in here if
2971 bus_connections_setup_connection fails.
2973 * bus/connection.c (bus_connections_unref): fix to free the
2975 (bus_connections_setup_connection): if this fails, don't
2976 disconnect the connection, just be sure there are no side
2979 * dbus/dbus-string.c (undo_alignment): unbreak this
2981 * dbus/dbus-auth.c (_dbus_auth_unref): free some stuff we were
2983 (_dbus_auth_new): fix the order in which we free strings
2986 * bus/connection.c (bus_connection_disconnected): fix to
2987 not send ServiceDeleted multiple times in case of memory
2990 * dbus/dbus-bus.c (dbus_bus_get_base_service): new function to
2991 get the base service name
2992 (dbus_bus_register_client): don't return base service name,
2993 instead store it on the DBusConnection and have an accessor
2995 (dbus_bus_register_client): rename dbus_bus_register()
2997 * bus/dispatch.c (check_hello_message): verify that other
2998 connections on the bus also got the correct results, not
2999 just the one sending hello
3001 2003-03-15 Havoc Pennington <hp@pobox.com>
3003 Make it pass the Hello handling test including all OOM codepaths.
3004 Now to do other messages...
3006 * bus/services.c (bus_service_remove_owner): fix crash when
3007 removing owner from an empty list of owners
3008 (bus_registry_ensure): don't leave service in the list of
3009 a connection's owned services if we fail to put the service
3012 * bus/connection.c (bus_connection_preallocate_oom_error): set
3013 error flag on the OOM error.
3015 * dbus/dbus-connection.c (_dbus_connection_new_for_transport):
3016 handle _dbus_transport_set_connection failure
3018 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd): modify
3019 to create watches up front and simply enable/disable them as
3021 (unix_connection_set): this can now fail on OOM
3023 * dbus/dbus-timeout.c, dbus/dbus-watch.c: add concept
3024 of enabling/disabling a watch or timeout.
3026 * bus/loop.c (bus_loop_iterate): don't touch disabled
3029 * glib/dbus-gmain.c: adapt to enable/disable watches and timeouts
3031 2003-03-15 Havoc Pennington <hp@pobox.com>
3033 * bus/dispatch.c (bus_dispatch_test): OK, now finally actually
3034 write useful test code, after all that futzing around ;-)
3036 Test does not yet pass because we can't handle OOM in
3037 _dbus_transport_messages_pending (basically,
3038 dbus_connection_preallocate_send() does not prealloc the write
3039 watch). To fix this, I think we need to add new stuff to
3040 set_watch_functions, namely a SetEnabled function so we can alloc
3041 the watch earlier, then enable it later.
3043 * dbus/Makefile.am (libdbus_convenience_la_SOURCES): move
3044 dbus-memory.c to the convenience lib
3046 * bus/test.c: rename some static functions to keep them clearly
3047 distinct from stuff in connection.c. Handle client disconnection.
3049 2003-03-14 Havoc Pennington <hp@pobox.com>
3051 * bus/dispatch.c (bus_dispatch_test): do test using debug-pipe
3052 transport, tests more of the real codepath. Set up clients
3053 with bus_setup_debug_client.
3055 * bus/test.c (bus_setup_debug_client): function to set up debug
3056 "clients" on the main loop
3058 * dbus/dbus-transport.c (_dbus_transport_open): add debug-pipe
3061 * dbus/dbus-server.c (dbus_server_listen): add debug-pipe
3064 * dbus/dbus-server-debug.c: support a debug server based on pipes
3066 * dbus/dbus-sysdeps.c (_dbus_full_duplex_pipe): new function
3067 (_dbus_close): new function
3069 * configure.in: check for socketpair
3071 2003-03-14 Havoc Pennington <hp@redhat.com>
3073 * dbus/dbus-memory.c: add a "detect buffer overwrites on free"
3076 * dbus/dbus-transport-debug.c: rework this a good bit to be
3077 less complicated. hopefully still works.
3079 * dbus/dbus-server-debug.c (handle_new_client): remove timeout
3082 * glib/dbus-gmain.c (timeout_handler): don't remove timeout
3085 * dbus/dbus-message.c (dbus_message_copy): rename from
3086 dbus_message_new_from_message, fix it up to copy
3087 all the message fields, add test case
3089 * bus/dispatch.c (bus_dispatch_test): add some more test code,
3090 not quite passing yet
3092 2003-03-14 Havoc Pennington <hp@pobox.com>
3094 * bus/loop.c (bus_loop_iterate): add this so we can "run loop
3095 until no work remains" in test code. (the large diff here
3096 is just code movement, no actual changes)
3098 * dbus/dbus-server-debug.c (DEFAULT_INTERVAL): change interval to
3099 1, no point waiting around for test code.
3100 (_dbus_server_debug_accept_transport): unref the timeout
3101 after adding it (right?)
3103 * dbus/dbus-transport-debug.c (DEFAULT_INTERVAL): ditto
3105 2003-03-13 Havoc Pennington <hp@redhat.com>
3107 * dbus/dbus-timeout.c (_dbus_timeout_list_set_functions): handle
3110 * dbus/dbus-watch.c (_dbus_watch_list_set_functions): handle out
3113 * dbus/dbus-connection.h: Make AddWatchFunction and
3114 AddTimeoutFunction return a bool so they can fail on out-of-memory
3116 * bus/bus.c (bus_context_new): set up timeout handlers
3118 * bus/connection.c (bus_connections_setup_connection): set up
3121 * glib/dbus-gmain.c: adapt to the fact that set_functions stuff
3124 * bus/bus.c (bus_context_new): adapt to changes
3126 * bus/connection.c: adapt to changes
3128 * test/watch.c: adapt to DBusWatch changes
3130 * bus/dispatch.c (bus_dispatch_test): started adding this but
3133 2003-03-14 Anders Carlsson <andersca@codefactory.se>
3135 * bus/dispatch.c (send_service_nonexistent_error): Fix typo.
3137 2003-03-13 Havoc Pennington <hp@pobox.com>
3139 * bus/test.c, bus/test.h, bus/Makefile.am, bus/test-main.c:
3140 set up a test framework as for the library
3142 2003-03-12 Havoc Pennington <hp@pobox.com>
3144 Throughout: purge global variables, introduce BusActivation,
3145 BusConnections, BusRegistry, etc. objects instead.
3147 * bus/bus.h, bus/bus.c: introduce BusContext as a global
3150 * test/Makefile.am (TEST_BINARIES): disable bus-test for now,
3151 going to redo this a bit differently I think
3153 2003-03-12 Havoc Pennington <hp@redhat.com>
3155 Mega-patch that gets the message bus daemon initially handling
3156 out-of-memory. Work still needed. Also lots of random
3157 moving stuff to DBusError instead of ResultCode.
3159 * dbus/dbus-list.c (_dbus_list_length_is_one): new function
3161 * dbus/dbus-connection.c
3162 (dbus_connection_send_with_reply_and_block): use DBusError
3164 * dbus/dbus-bus.c: adapt to API changes, make it use DBusError not
3167 * dbus/dbus-connection.c (dbus_connection_send): drop the result
3168 code here, as the only failure possible is OOM.
3170 * bus/connection.c (bus_connection_disconnect):
3171 rename bus_connection_disconnected as it's a notification only
3173 * bus/driver.c (bus_driver_handle_acquire_service): don't free
3174 "name" on get_args failure, should be done by get_args;
3175 don't disconnect client for bad args, just return an error.
3176 (bus_driver_handle_service_exists): ditto
3178 * bus/services.c (bus_services_list): NULL-terminate returned array
3180 * bus/driver.c (bus_driver_send_service_lost)
3181 (bus_driver_send_service_acquired): send messages from driver to a
3182 specific client to the client's unique name, not to the broadcast
3185 * dbus/dbus-message.c (decode_header_data): reject messages that
3186 contain no name field
3187 (_dbus_message_get_client_serial): rename to
3188 dbus_message_get_serial and make public
3189 (_dbus_message_set_serial): rename from set_client_serial
3190 (_dbus_message_set_reply_serial): make public
3191 (_dbus_message_get_reply_serial): make public
3193 * bus/connection.c (bus_connection_foreach): allow stopping
3194 iteration by returning FALSE from foreach function.
3196 * dbus/dbus-connection.c (dbus_connection_send_preallocated)
3197 (dbus_connection_free_preallocated_send)
3198 (dbus_connection_preallocate_send): new API for sending a message
3199 without possibility of malloc failure.
3200 (dbus_connection_send_message): rename to just
3201 dbus_connection_send (and same for whole function family)
3203 * dbus/dbus-errors.c (dbus_error_free): make this reinit the error
3205 * dbus/dbus-sysdeps.c (_dbus_exit): new function
3207 * bus/activation.c: handle/return errors
3209 * dbus/dbus-errors.h: add more DBUS_ERROR #define
3211 * dbus/dbus-sysdeps.c (_dbus_directory_open) (_dbus_file_get_contents)
3212 (_dbus_directory_get_next_file): use DBusError instead of DBusResultCode
3213 (_dbus_result_from_errno): move to this file
3215 2003-03-10 Anders Carlsson <andersca@codefactory.se>
3217 * dbus/dbus-marshal.c:
3218 (_dbus_marshal_set_string):
3219 Take a length argument so we can marshal the correct string
3222 (_dbus_marshal_dict), (_dbus_demarshal_dict),
3223 (_dbus_marshal_get_arg_end_pos), (_dbus_marshal_validate_arg),
3224 (_dbus_marshal_test):
3225 * dbus/dbus-marshal.h:
3226 Add support for marshalling and demarshalling dicts.
3228 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
3229 Add support for TYPE DICT.
3231 * dbus/dbus-message.c: (set_string_field):
3232 Adjust header padding.
3234 (dbus_message_append_args_valist), (dbus_message_append_dict),
3235 (dbus_message_get_args_valist), (dbus_message_iter_get_arg_type),
3236 (dbus_message_iter_get_dict), (_dbus_message_loader_return_buffer),
3237 (check_message_handling), (check_have_valid_message):
3238 * dbus/dbus-message.h:
3239 Add functions for setting and getting dicts.
3241 * dbus/dbus-protocol.h:
3247 * doc/dbus-specification.sgml:
3248 Add information about how dicts are marshalled.
3250 * test/data/invalid-messages/dict-with-nil-value.message:
3251 * test/data/invalid-messages/too-short-dict.message:
3252 * test/data/valid-messages/dict-simple.message:
3253 * test/data/valid-messages/dict.message:
3254 Add sample messages containing dicts.
3256 2003-03-08 Anders Carlsson <andersca@codefactory.se>
3258 * dbus/dbus-dict.h: Add DBUS_END_DECLS.
3260 2003-03-07 Anders Carlsson <andersca@codefactory.se>
3263 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
3264 (dbus_dict_get_keys), (insert_entry), (dbus_dict_set_boolean),
3265 (dbus_dict_set_int32), (dbus_dict_set_uint32),
3266 (dbus_dict_set_double), (dbus_dict_set_string),
3267 (dbus_dict_set_boolean_array), (dbus_dict_set_int32_array),
3268 (dbus_dict_set_uint32_array), (dbus_dict_set_double_array),
3269 (dbus_dict_set_string_array), (_dbus_dict_test):
3271 Fix according to comments from Havoc.
3273 2003-03-06 Michael Meeks <michael@server.home>
3275 * configure.in: if we don't have kde-config, disable have_qt.
3277 2003-03-07 Anders Carlsson <andersca@codefactory.se>
3282 * dbus/dbus-dict.c: (dbus_dict_entry_free), (dbus_dict_new),
3283 (dbus_dict_ref), (dbus_dict_unref), (dbus_dict_contains),
3284 (dbus_dict_remove), (dbus_dict_get_value_type),
3285 (dbus_dict_get_keys), (dbus_dict_put_boolean),
3286 (dbus_dict_put_int32), (dbus_dict_put_uint32),
3287 (dbus_dict_put_double), (dbus_dict_put_string),
3288 (dbus_dict_put_boolean_array), (dbus_dict_put_int32_array),
3289 (dbus_dict_put_uint32_array), (dbus_dict_put_double_array),
3290 (dbus_dict_put_string_array), (dbus_dict_get_boolean),
3291 (dbus_dict_get_int32), (dbus_dict_get_uint32),
3292 (dbus_dict_get_double), (dbus_dict_get_string),
3293 (dbus_dict_get_boolean_array), (dbus_dict_get_int32_array),
3294 (dbus_dict_get_uint32_array), (dbus_dict_get_double_array),
3295 (dbus_dict_get_string_array), (_dbus_dict_test):
3297 Add DBusDict implementation
3299 * dbus/dbus-test.c: (dbus_internal_do_not_use_run_tests):
3303 2003-03-04 Havoc Pennington <hp@pobox.com>
3305 * test/data/auth/*: adapt to changes
3307 * dbus/dbus-auth-script.c (_dbus_auth_script_run): add
3308 USERID_BASE64 and change USERNAME_BASE64 to put in username not
3311 * dbus/dbus-keyring.c (_dbus_keyring_validate_context): prevent
3312 more stuff from being in a context name, to make the protocol
3313 simpler to deal with
3315 * dbus/dbus-errors.c (dbus_error_has_name): new function
3316 (dbus_error_is_set): new function
3318 * dbus/dbus-auth.c: replace DBUS_STUPID_TEST_MECH auth
3319 with DBUS_COOKIE_SHA1, implement DBUS_COOKIE_SHA1
3321 * dbus/dbus-connection.c (dbus_connection_flush): also read
3322 messages during a flush operation
3324 * dbus/Makefile.am: remove dbus-md5 since it isn't currently used.
3326 2003-03-05 Anders Carlsson <andersca@codefactory.se>
3328 * configure.in: Check for gethostbyname on Solaris.
3330 * dbus/dbus-transport.c: (_dbus_transport_open):
3331 Remove duplicate "tcp" entry.
3333 * doc/dbus-specification.sgml:
3334 Clarify some things.
3336 2003-03-05 Anders Carlsson <andersca@codefactory.se>
3338 * dbus/dbus-auth.c: (send_rejected), (process_test_subdir):
3339 * dbus/dbus-keyring.c: (_dbus_keyring_new_homedir),
3340 (_dbus_keyring_test):
3341 * dbus/dbus-md5.c: (_dbus_md5_compute):
3342 * dbus/dbus-sha.c: (_dbus_sha_compute):
3345 2003-03-05 Anders Carlsson <andersca@codefactory.se>
3347 * README: Add some things.
3349 2003-03-04 Anders Carlsson <andersca@codefactory.se>
3351 * dbus/dbus-message.c (dbus_message_append_args_valist): Add a break;
3352 after case DBUS_TYPE_BOOELAN.
3354 2003-03-02 Havoc Pennington <hp@pobox.com>
3356 * test/break-loader.c (randomly_set_extreme_ints): add test that
3357 sets really huge and small integers
3359 * dbus/dbus-marshal.c (_dbus_marshal_validate_arg): add check
3360 that length of boolean array fits in the string, and that
3361 string has room for boolean value in single-bool case.
3363 * dbus/dbus-message-builder.c (_dbus_message_data_load): add
3364 optional value to "ALIGN" command which is what to fill the
3367 * test/data/valid-messages/no-padding.message: add regression
3368 test for the message padding problem
3370 2003-03-02 Havoc Pennington <hp@pobox.com>
3372 * dbus/dbus-message.c (decode_header_data): fix to always init
3373 message_padding, from Benjamin Dauvergne
3375 2003-03-02 Havoc Pennington <hp@pobox.com>
3381 2003-03-01 Joe Shaw <joe@assbarn.com>
3383 * configure.in: Check for "struct cmsgcred" and try to access its
3384 members for BSD-like unices.
3386 * dbus/dbus-sysdeps.c (read_credentials_byte): Fold this back into
3387 _dbus_read_credentials_unix_socket().
3388 (_dbus_read_credentials_unix_socket): Use recvmsg() instead of
3389 read() for reading the credential byte off the unix socket. Use
3390 struct cmsgcred on systems that support it.
3392 2003-02-27 Alexander Larsson <alexl@redhat.com>
3396 Make gthreads-2.0 dependency optional. Don't build thread test if
3399 2003-02-27 Havoc Pennington <hp@pobox.com>
3401 * dbus/dbus-connection.c
3402 (dbus_connection_send_message_with_reply_and_block): fix doh!
3403 doh! doh! bug that resulted in never removing a reply from the
3404 queue, no wonder we called get_reply_serial so much ;-)
3406 * dbus/dbus-message.c (struct DBusMessage): cache reply serial
3407 and client serial instead of demarshaling them every time
3409 2003-02-27 Havoc Pennington <hp@pobox.com>
3411 * dbus/dbus-marshal.c (_dbus_demarshal_int32): rewrite to be much
3412 more inlined, using dbus-string-private.h, speeds things up
3415 * dbus/dbus-string.c (_dbus_string_free): apply align offset
3416 when freeing the string
3417 (_dbus_string_steal_data): fix for align offset
3418 (undo_alignment): new function
3420 2003-02-26 Havoc Pennington <hp@redhat.com>
3422 All kinds of audit fixes from Owen, plus initial attempt to
3423 handle unaligned memory returned from malloc.
3425 * dbus/dbus-string.c (_dbus_string_init): clamp max length to
3426 leave room for align_offset and nul byte
3427 (fixup_alignment): function to track an align_offset and
3428 ensure real->str is aligned
3429 (DBUS_GENERIC_STRING_PREAMBLE): len must be less than allocated,
3430 to allow a nul byte plus align offset
3431 (_dbus_string_lock): fix overflow issue
3432 (_dbus_string_init_const_len): add assertions on sanity of len,
3433 assign allocated to be ALLOCATION_PADDING larger than len
3434 (set_length): fixup the overflow handling
3435 (_dbus_string_get_data_len): fix overflow in assertion
3436 (open_gap): detect overflow in size of gap to be opened
3437 (_dbus_string_lengthen): add overflow check
3438 (_dbus_string_align_length): fix overflow with _DBUS_ALIGN_VALUE
3439 (_dbus_string_append): add overflow check
3440 (_dbus_string_append_unichar): overflow
3441 (_dbus_string_delete): fix overflow in assertion
3442 (_dbus_string_copy_len): overflow in assertion
3443 (_dbus_string_replace_len): overflows in assertions
3444 (_dbus_string_find): change to implement in terms of
3445 _dbus_string_find_to
3446 (_dbus_string_find_to): assorted fixage
3447 (_dbus_string_equal_c_str): assert c_str != NULL,
3448 fix logic so the function works
3449 (_dbus_string_ends_with_c_str): fix overflow thingy
3450 (_dbus_string_base64_encode): overflow fix
3451 (_dbus_string_validate_ascii): overflow
3452 (_dbus_string_validate_nul): overflow
3454 2003-02-26 Havoc Pennington <hp@redhat.com>
3456 * dbus/dbus-marshal.c (_dbus_marshal_test): fix to work with DISABLE_ASSERTS
3458 2003-02-26 Alexander Larsson <alexl@redhat.com>
3461 Set DBUS_GLIB_THREADS_LIBS for apps using gthread-2.0
3463 * dbus/dbus-connection.c:
3464 * dbus/dbus-connection.h:
3465 Fix _dbus_connection_acquire_io_path and _dbus_connection_acquire_dispatch.
3466 Add dbus_connection_set_wakeup_main_function and use it when queueing
3467 incoming and outgoing messages.
3470 * dbus/dbus-dataslot.c:
3471 Threadsafe usage of DBusDataSlotAllocator
3473 * dbus/dbus-message.c: (dbus_message_get_args_iter):
3476 * dbus/dbus-server-unix.c:
3479 * glib/dbus-gmain.c:
3480 Implement the new wakeup functions for glib.
3483 * glib/test-thread-client.c:
3484 * glib/test-thread-server.c:
3485 * glib/test-thread.h:
3486 Initial cut at some thread test code. Not really done yet.
3488 2003-02-26 Havoc Pennington <hp@pobox.com>
3490 * dbus/dbus-connection.c
3491 (dbus_connection_send_message_with_reply_and_block): fix crash
3492 where we ref'd the outgoing message instead of the returned reply
3494 * dbus/dbus-transport-unix.c (do_authentication): check read watch
3495 at the end of this function, so if we didn't need to read for
3496 authentication, we reinstall it for receiving messages
3498 * dbus/dbus-message.c (dbus_message_new_reply): allow replies to
3499 a NULL sender for peer-to-peer case
3501 * dbus/dbus-transport-unix.c (check_read_watch): handle
3502 !authenticated case correctly
3504 * glib/dbus-gmain.c: add support for DBusServer
3506 * dbus/dbus-server.c: add data slot support
3508 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): check
3509 return values and handle errors
3511 * dbus/dbus-dataslot.c: factor out the data slot stuff from
3514 * Doxyfile.in (INPUT): add glib subdir
3516 * glib/dbus-gmain.c (dbus_connection_setup_with_g_main): rename
3517 setup_with_g_main instead of hookup_with_g_main; write docs
3519 2003-02-24 Anders Carlsson <andersca@codefactory.se>
3521 * dbus/dbus-marshal.c: (_dbus_marshal_validate_arg):
3522 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
3523 * dbus/dbus-message.c: (dbus_message_append_boolean),
3524 (dbus_message_append_boolean_array),
3525 (dbus_message_get_args_valist), (_dbus_message_test):
3526 * dbus/dbus-message.h:
3527 * doc/dbus-specification.sgml:
3528 Various fixes as pointed out by Havoc.
3530 * test/data/invalid-messages/bad-boolean-array.message:
3531 * test/data/invalid-messages/bad-boolean.message:
3532 Add invalid boolean value test cases.
3534 2003-02-24 Anders Carlsson <andersca@codefactory.se>
3536 * dbus/dbus-internals.c: (_dbus_type_to_string):
3537 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
3538 (_dbus_marshal_validate_arg):
3539 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
3540 * dbus/dbus-message.c: (dbus_message_append_args_valist),
3541 (dbus_message_append_boolean), (dbus_message_append_boolean_array),
3542 (dbus_message_get_args_valist), (dbus_message_iter_get_boolean),
3543 (dbus_message_iter_get_int32), (dbus_message_iter_get_uint32),
3544 (dbus_message_iter_get_double),
3545 (dbus_message_iter_get_boolean_array), (message_iter_test):
3546 * dbus/dbus-message.h:
3547 * dbus/dbus-protocol.h:
3548 * doc/dbus-specification.sgml:
3549 * test/data/valid-messages/lots-of-arguments.message:
3550 Add support for boolean and boolean array types.
3552 2003-02-23 Havoc Pennington <hp@pobox.com>
3554 * dbus/dbus-keyring.c: finish most of this implementation and
3557 * dbus/dbus-errors.c (dbus_set_error_const, dbus_set_error): make
3558 these barf if the error isn't cleared to NULL
3560 * dbus/dbus-sysdeps.c (_dbus_delete_file): set error on failure
3561 (_dbus_create_directory): new function
3563 * dbus/dbus-errors.c (dbus_set_error): fix warning
3565 * dbus/dbus-string.c (_dbus_string_hex_encode): new function
3566 (_dbus_string_hex_decode): new function
3567 (test_hex_roundtrip): test code
3569 * dbus/dbus-sha.c (_dbus_sha_compute): use dbus_string_hex_encode
3571 * dbus/dbus-md5.c (_dbus_md5_compute): use dbus_string_hex_encode
3573 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): make this use
3574 the save-to-temp/rename trick to atomically write the new file
3575 (_dbus_string_parse_uint): new function
3577 2003-02-22 Havoc Pennington <hp@pobox.com>
3579 * test/Makefile.am (dist-hook): fix dist for test/data/sha-1
3581 2003-02-22 Havoc Pennington <hp@pobox.com>
3583 * dbus/dbus-message.c (dbus_message_iter_get_string_array):
3584 (dbus_message_iter_get_byte_array): Fix up doxygen warnings
3586 * dbus/dbus-sha.c: add implementation of SHA-1 algorithm
3588 * dbus/test/data/sha-1: add US government test suite for SHA-1
3590 2003-02-21 Anders Carlsson <andersca@codefactory.se>
3592 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
3593 Make string arrays NULL-terminated.
3595 * dbus/dbus-memory.c: (dbus_free_string_array):
3596 * dbus/dbus-memory.h:
3597 New function for freeing NULL-terminated string arrays.
3599 * dbus/dbus-message-builder.c: (append_quoted_string),
3600 (_dbus_message_data_load):
3601 Add support for array types.
3603 * dbus/dbus-message.c: (check_message_handling):
3604 Add more types as test cases.
3606 * dbus/dbus-sysdeps.c: (_dbus_string_parse_int),
3607 (_dbus_string_parse_double):
3608 Add the start offset to the end offset.
3610 * test/data/valid-messages/lots-of-arguments.message:
3611 New test message with lots of arguments.
3613 2003-02-21 Anders Carlsson <andersca@codefactory.se>
3615 * dbus/dbus-message.c: (dbus_message_append_nil),
3616 (dbus_message_append_int32), (dbus_message_append_uint32),
3617 (dbus_message_append_double), (dbus_message_append_string),
3618 (dbus_message_append_int32_array),
3619 (dbus_message_append_uint32_array),
3620 (dbus_message_append_double_array),
3621 (dbus_message_append_byte_array),
3622 (dbus_message_append_string_array):
3623 Fix all out-of-memory handling in these functions.
3625 2003-02-21 Anders Carlsson <andersca@codefactory.se>
3627 * dbus/dbus-message.c: (dbus_message_append_nil):
3630 2003-02-21 Anders Carlsson <andersca@codefactory.se>
3632 * dbus/dbus-message.c: (dbus_message_append_args_valist),
3633 (dbus_message_append_nil), (dbus_message_append_int32_array),
3634 (dbus_message_append_uint32_array),
3635 (dbus_message_append_double_array),
3636 (dbus_message_append_byte_array),
3637 (dbus_message_append_string_array), (dbus_message_get_args_valist),
3638 (dbus_message_iter_get_int32_array),
3639 (dbus_message_iter_get_uint32_array),
3640 (dbus_message_iter_get_double_array),
3641 (dbus_message_iter_get_byte_array),
3642 (dbus_message_iter_get_string_array):
3644 * dbus/dbus-message.h:
3645 Add functions for appending and getting arrays.
3647 2003-02-21 Anders Carlsson <andersca@codefactory.se>
3649 * dbus/dbus-mempool.c (_dbus_mem_pool_new): Make the
3650 element size at least 8 bytes, fixes mempool tests on
3653 2003-02-20 Alexander Larsson <alexl@redhat.com>
3655 * dbus/dbus-transport-unix.c (unix_do_iteration):
3656 Unlock the connection mutex during a blocking select call.
3657 Add todo about how we need a way to wake up the select.
3659 * dbus/dbus-connection-internal.h:
3660 * dbus/dbus-connection.c:
3661 Add _dbus_connection_lock and _dbus_connection_unlock.
3663 2003-02-19 Havoc Pennington <hp@pobox.com>
3665 * Doxyfile.in (PREDEFINED): put DOXYGEN_SHOULD_SKIP_THIS in
3666 Doxyfile.in, not Doxyfile
3668 * dbus/dbus-keyring.c: do some hacking on this
3670 * dbus/dbus-sysdeps.c (_dbus_delete_file): new
3672 * dbus/dbus-errors.c (dbus_set_error_const): do not call
3674 (dbus_set_error): remove dbus_error_init, check for message ==
3675 NULL *before* we sprintf into it, and add @todo about including
3676 system headers in this file
3678 * dbus/dbus-sysdeps.c (_dbus_create_file_exclusively): new
3680 * dbus/dbus-errors.h (DBUS_ERROR_FAILED): add
3682 * dbus/dbus-sysdeps.c (get_user_info): break this function out to
3683 get various bits of user information based on either username
3685 (_dbus_homedir_from_username): new function
3687 2003-02-19 Anders Carlsson <andersca@codefactory.se>
3690 Add check for nonposix getpwnam_r
3692 * dbus/dbus-mempool.c: (_dbus_mem_pool_new):
3693 Align the pool element size to a sizeof (void *) boundary.
3695 * dbus/dbus-sysdeps.c: (_dbus_setenv), (_dbus_connect_unix_socket),
3696 (_dbus_listen_unix_socket), (_dbus_credentials_from_username):
3697 General Solaris fixes.
3699 * test/data/valid-messages/simplest-manual.message:
3700 Explicitly state that we want little-endian packing.
3702 2003-02-19 Mikael Hallendal <micke@codefactory.se>
3704 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
3706 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_tcp_socket):
3707 Added to create a transport connecting using a tcp/ip socket.
3709 * dbus/dbus-sysdeps.c (_dbus_connect_tcp_socket): Added to connect
3710 to a tcp socket at given host and port.
3711 (_dbus_listen_tcp_socket): added to listen on tcp socket for given
3714 * dbus/dbus-server.c (dbus_server_listen): Support tcp: addresses.
3716 * dbus/dbus-server-unix.c (_dbus_server_new_for_tcp_socket):
3717 Added to create a server listening on a TCP/IP socket.
3719 2003-02-19 Havoc Pennington <hp@pobox.com>
3721 Throughout: mop up all the Doxygen warnings and undocumented
3724 * dbus/dbus-sysdeps.c (do_exec): do not use execvp, we don't want
3725 to search any paths.
3727 * dbus/dbus-threads.c: move global mutex initializers to
3728 dbus-internals.h, multiple prototypes was confusing doxygen
3729 besides being kind of ugly
3731 * Doxyfile (PREDEFINED): have Doxygen define
3732 DOXYGEN_SHOULD_SKIP_THIS so we can exclude things from
3733 docs with #ifndef DOXYGEN_SHOULD_SKIP_THIS
3734 (do not abuse the feature! it's for stuff like the autogenerated
3735 macros in dbus-md5.c, not just for things you don't feel like
3738 2003-02-18 Havoc Pennington <hp@pobox.com>
3740 * dbus/dbus-string.c (_dbus_string_zero): new function
3742 * dbus/dbus-md5.c: include MD5 implementation by L. Peter Deutsch,
3743 wrap it in some dbus-friendly API
3745 * dbus/dbus-types.h: add 16-bit types
3747 2003-02-18 Joe Shaw <joe@assbarn.com>
3749 * dbus/dbus-auth.c (handle_server_data_stupid_test_mech): Just get
3750 credentials from our currently running process.
3751 (get_word): Fix a buglet where we were copying the entire length
3752 instead of relative to our position.
3754 * dbus/dbus-hash.c (_dbus_hash_test): Don't try to allocate the
3755 keys on the stack... it's 640k of data.
3757 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): Always
3758 read the credentials byte off the socket, even if we don't have
3760 (_dbus_poll): Implement poll() using select() for systems which
3763 * glib/test-dbus-glib.c (main): Print out an error if no
3764 parameters are given.
3766 * test/data/auth/fallback.auth-script: Added. Tests that a client
3767 can fallback to a secondary auth mechanism if the first fails.
3769 2003-02-18 Havoc Pennington <hp@pobox.com>
3773 2003-02-17 Havoc Pennington <hp@pobox.com>
3775 * doc/dbus-specification.sgml: lots of cosmetic
3776 cleanups/rearrangement, add assorted FIXME, change DBUS_ADDRESS
3777 env variable to DBUS_BUS_ADDRESS, s/client/application/,
3778 s/server/bus/ (except in authentication section). Add a section
3779 "Message Bus Message Routing"
3781 2003-02-17 Anders Carlsson <andersca@codefactory.se.>
3787 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3789 * doc/dbus-specification.sgml:
3790 Specification updates.
3792 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3794 * bus/activation.c: (bus_activation_init), (child_setup),
3795 (bus_activation_activate_service):
3797 * bus/main.c: (main):
3798 Set DBUS_ADDRESS environment variable.
3800 * dbus/dbus-errors.c: (dbus_set_error):
3801 Don't use va_copy since that's a C99 feature.
3803 * dbus/dbus-sysdeps.c: (_dbus_setenv), (do_exec),
3804 (_dbus_spawn_async):
3805 * dbus/dbus-sysdeps.h:
3806 Add child_setup_func to _dbus_spawn_async.
3808 * doc/dbus-specification.sgml:
3809 Update specification.
3811 * test/spawn-test.c: (setup_func), (main):
3814 2003-02-17 Alexander Larsson <alexl@redhat.com>
3816 * dbus/dbus-connection.c (_dbus_connection_handler_destroyed_locked):
3819 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3823 * doc/dbus-test-plan.sgml:
3824 Add test plan document.
3829 2003-02-17 Anders Carlsson <andersca@codefactory.se>
3831 * dbus/dbus-message.c: (decode_header_data),
3832 (_dbus_message_loader_return_buffer):
3833 Set the header padding amount when loading a message.
3835 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3837 * bus/dispatch.c: (send_one_message):
3838 Only send broadcast messages to registered connections.
3840 * dbus/dbus-message.c: (dbus_message_name_is):
3841 * dbus/dbus-message.h:
3842 New convenience function.
3844 * dbus/dbus-transport-debug.c: (do_reading):
3845 Only dispatch one message per run.
3848 * test/bus-test.c: (new_connection_callback), (die),
3849 (test_hello_client1_handler), (test_hello_client2_handler),
3850 (test_hello_replies), (main):
3852 * test/bus-test-loop.[ch]:
3855 2003-02-16 Havoc Pennington <hp@pobox.com>
3857 * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
3858 backward conditional
3860 2003-02-16 Alexander Larsson <alexl@redhat.com>
3862 * dbus/dbus-connection.c:
3863 Implement sent_message_with_reply. (with_reply_and block is still
3865 Made dispatch_message not lose message if OOM.
3867 * dbus/dbus-errors.h:
3868 Add NoReply error (for reply timeouts).
3870 2003-02-16 Alexander Larsson <alexl@redhat.com>
3872 * dbus/dbus-hash.c (_dbus_hash_table_unref):
3873 Actually free keys and values when destroying hashtable.
3875 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3877 * dbus/dbus-auth.c: (client_try_next_mechanism):
3880 * dbus/dbus-threads.c: (dbus_condvar_wait_timeout):
3881 Return TRUE if there's no thread implementation around.
3883 * glib/dbus-gmain.c: (free_source),
3884 (dbus_connection_hookup_with_g_main):
3885 Make sure to remove the GSource when the connection is finalized.
3887 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3889 * bus/dispatch.c: (bus_dispatch_message_handler):
3890 * dbus/dbus-errors.h:
3891 Return an error if someone tries to send a message to a service
3894 2003-02-16 Anders Carlsson <andersca@codefactory.se>
3896 * bus/activation.c: (load_directory), (bus_activation_init),
3897 (bus_activation_activate_service):
3900 (bus_driver_handle_activate_service), (bus_driver_handle_message):
3901 More work on the activation handling.
3903 * dbus/dbus-errors.h:
3904 Add some error messages
3906 * dbus/dbus-message.c: (dbus_message_new_error_reply):
3907 * dbus/dbus-message.h:
3908 New function that creates an error message.
3910 * dbus/dbus-protocol.h:
3911 Add ACTIVATE_SERVER message.
3913 * dbus/dbus-server-unix.c: (unix_handle_watch),
3914 (_dbus_server_new_for_domain_socket):
3915 Call _dbus_fd_set_close_on_exec.
3917 * dbus/dbus-sysdeps.c: (make_pipe), (do_exec),
3918 (_dbus_spawn_async), (_dbus_disable_sigpipe),
3919 (_dbus_fd_set_close_on_exec):
3920 * dbus/dbus-sysdeps.h:
3921 Add _dbus_fd_set_close_on exec function. Also add function that checks
3922 that all open fds are set to close-on-exec and warns otherwise.
3924 * dbus/dbus-transport-unix.c:
3925 (_dbus_transport_new_for_domain_socket):
3926 Call _dbus_fd_set_close_on_exec.
3928 2003-02-16 Havoc Pennington <hp@pobox.com>
3930 * dbus/dbus-connection.c (dbus_connection_set_change_sigpipe):
3931 allow people to avoid setting SIGPIPE to SIG_IGN
3932 (_dbus_connection_new_for_transport): disable SIGPIPE unless
3933 we've been asked not to
3935 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3937 * dbus/dbus-list.c: (_dbus_list_append_link),
3938 (_dbus_list_prepend_link):
3939 * dbus/dbus-memory.c: (dbus_malloc), (dbus_malloc0),
3943 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3946 * bus/activation.c: (bus_activation_entry_free),
3947 (add_desktop_file_entry), (load_directory), (bus_activation_init):
3949 * bus/main.c: (main):
3950 Add simple activation support, doesn't work yet though.
3952 2003-02-15 Zack Rusin <zack@kde.org>
3954 * qt/dbus-qthread.cpp: small casting fix
3956 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3958 * dbus/dbus-errors.c: (dbus_set_error):
3959 * dbus/dbus-errors.h:
3960 Add a few errors and make dbus_set_error void.
3962 * dbus/dbus-sysdeps.c:
3963 (_dbus_errno_to_string), (close_and_invalidate), (make_pipe),
3964 (write_err_and_exit), (read_ints), (do_exec), (_dbus_spawn_async):
3965 * dbus/dbus-sysdeps.h:
3966 Add _dbus_spawn_async.
3968 * test/spawn-test.c: (main):
3969 Test for _dbus_spawn_async.
3971 2003-02-15 Anders Carlsson <andersca@codefactory.se>
3973 * dbus/dbus-internals.h:
3974 Fix build without tests.
3976 * dbus/dbus-list.c: (alloc_link):
3977 Fix a segfault when a malloc fails.
3979 * dbus/dbus-memory.c: (initialize_malloc_debug), (dbus_malloc),
3980 (dbus_malloc0), (dbus_realloc):
3981 Add support for malloc debugging.
3983 2003-02-15 Alexander Larsson <alexl@redhat.com>
3985 * dbus/dbus-threads.c:
3986 * dbus/dbus-threads.h:
3987 Add condvars. Remove static mutext from API.
3988 Implement static mutexes by initializing them from threads_init.
3990 * glib/dbus-gthread.c:
3991 * qt/dbus-qthread.cpp:
3992 Update with the thread api changes.
3997 Turn StaticMutex into normal mutex + init function.
3998 Export new functions _dbus_list_alloc_link, _dbus_list_free_link,
3999 _dbus_list_append_link, _dbus_list_prepend_link
4002 * dbus/dbus-sysdeps.c:
4003 * dbus/dbus-sysdeps.h:
4004 New type dbus_atomic_t, and new functions _dbus_atomic_inc,
4005 _dbus_atomic_dec. Only slow fallback implementation at the moment.
4007 * dbus/dbus-protocol.h:
4008 Add DBUS_MESSAGE_LOCAL_DISCONNECT define
4010 * dbus/dbus-message.c:
4011 Make ref/unref atomic.
4014 * dbus/dbus-connection-internal.h:
4015 * dbus/dbus-connection.c:
4016 * dbus/dbus-connection.h:
4018 Change _peek to _borrow,_return & _steal_borrowed.
4019 Change disconnect callback to event.
4020 Make dbus_connection_dispatch_messages reentrant.
4022 * dbus/dbus-transport.c:
4023 Don't ref the connection on calls to the transport
4026 * dbus/dbus-message-handler.c:
4029 * glib/dbus-gmain.c:
4030 Don't use peek_message anymore
4033 * test/debug-thread.c:
4034 * test/debug-thread.h:
4035 Simple thread implementation that asserts() on deadlocks in
4036 single-threaded code.
4039 (main) Call debug_threads_init.
4042 Use disconnect message instead of disconnect callback.
4046 Don't call dbus_connection_set_disconnect_function. Instead export
4047 bus_connection_disconnect.
4050 Call bus_connection_disconnect when we get a disconnected message.
4052 2003-02-15 Havoc Pennington <hp@pobox.com>
4054 * dbus/dbus-message.c (dbus_message_new): fool around with the
4057 2003-02-14 Havoc Pennington <hp@pobox.com>
4059 * dbus/dbus-mempool.c: fail if the debug functions so indicate
4061 * dbus/dbus-memory.c: fail if the debug functions indicate we
4064 * dbus/dbus-internals.c (_dbus_set_fail_alloc_counter)
4065 (_dbus_decrement_fail_alloc_counter): debug functions to
4066 simulate memory allocation failures
4068 2003-02-14 Havoc Pennington <hp@pobox.com>
4070 * dbus/dbus-errors.h (struct DBusError): add a word of padding
4073 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4075 * bus/driver.c: (bus_driver_handle_hello):
4077 * bus/services.c: (bus_service_lookup):
4078 Reorder message sending so we get a more sane order.
4080 * test/bus-test.c: (message_handler):
4083 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4085 * bus/driver.c: (bus_driver_send_service_deleted),
4086 (bus_driver_send_service_created), (bus_driver_send_service_lost),
4087 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
4088 (bus_driver_send_welcome_message),
4089 (bus_driver_handle_list_services),
4090 (bus_driver_handle_acquire_service),
4091 (bus_driver_handle_service_exists):
4092 * dbus/dbus-bus.c: (dbus_bus_register_client),
4093 (dbus_bus_acquire_service), (dbus_bus_service_exists):
4094 * dbus/dbus-errors.c: (dbus_result_to_string):
4095 * dbus/dbus-errors.h:
4096 * dbus/dbus-message.c: (dbus_message_append_args),
4097 (dbus_message_append_args_valist), (dbus_message_get_args),
4098 (dbus_message_get_args_valist), (dbus_message_get_args_iter),
4099 (dbus_message_iter_get_arg_type), (dbus_message_iter_get_string),
4100 (dbus_message_iter_get_byte_array),
4101 (dbus_message_iter_get_string_array), (message_iter_test),
4102 (check_message_handling), (_dbus_message_test):
4103 * dbus/dbus-message.h:
4104 * test/bus-test.c: (main):
4105 Change fields to arguments in messages, so that they won't be
4106 confused with header fields.
4108 * glib/test-dbus-glib.c: (main):
4109 Remove append_fields from hello message.
4111 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4113 * dbus/dbus-errors.c:
4114 * dbus/dbus-message.c:
4115 * dbus/dbus-string.c:
4116 Documentation fixes.
4118 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4120 * glib/dbus-gmain.c: (timeout_handler), (add_timeout),
4122 Implement support for timeouts in dbus-glib.
4124 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4126 * dbus/dbus-message-builder.c: (_dbus_message_data_load):
4127 * dbus/dbus-message.c: (process_test_subdir):
4128 * test/break-loader.c: (find_breaks_based_on):
4129 Plug some memory leaks.
4131 2003-02-13 Richard Hult <rhult@codefactory.se>
4133 * bus/main.c: Fix build.
4135 * dbus/dbus-errors.h:
4136 * dbus/dbus-errors.c: Fix copyright for Anders.
4138 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4143 * bus/connection.c: (bus_connection_foreach):
4146 * bus/desktop-file.c: (grow_lines_in_section), (grow_sections),
4147 (unescape_string), (new_section), (parse_section_start),
4148 (parse_key_value), (report_error), (bus_desktop_file_load),
4149 (bus_desktop_file_get_string):
4150 * bus/desktop-file.h:
4151 Use DBusError for error reporting.
4153 * bus/dispatch.c: (send_one_message),
4154 (bus_dispatch_message_handler):
4155 * bus/driver.c: (bus_driver_send_service_deleted),
4156 (bus_driver_send_service_created), (bus_driver_send_service_lost),
4157 (bus_driver_send_service_acquired), (bus_driver_handle_hello),
4158 (bus_driver_send_welcome_message),
4159 (bus_driver_handle_list_services),
4160 (bus_driver_handle_acquire_service),
4161 (bus_driver_handle_service_exists):
4162 * bus/loop.c: (bus_loop_run):
4164 Use BUS_HANDLE_OOM instead of _DBUS_HANDLE_OOM.
4166 * bus/utils.c: (bus_wait_for_memory):
4168 New files with general utility functions.
4170 * dbus/dbus-internals.h:
4171 Remove _DBUS_HANDLE_OOM.
4173 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4175 * dbus/dbus-errors.c: (dbus_result_to_string), (dbus_error_init),
4176 (dbus_error_free), (dbus_set_error_const), (dbus_set_error):
4177 * dbus/dbus-errors.h:
4178 Add DBusError structure.
4180 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4182 * test/data/valid-messages/standard-acquire-service.message:
4183 * test/data/valid-messages/standard-hello.message:
4184 * test/data/valid-messages/standard-list-services.message:
4185 * test/data/valid-messages/standard-service-exists.message:
4186 Add some standard messages.
4188 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4190 * bus/driver.c: (bus_driver_send_welcome_message),
4191 (bus_driver_handle_list_services),
4192 (bus_driver_handle_acquire_service),
4193 (bus_driver_handle_service_exists), (bus_driver_handle_message):
4194 Update for API changes in libdbus.
4196 * dbus/dbus-message.c: (dbus_message_new_reply):
4197 * dbus/dbus-message.h:
4198 Remove the name argument. The spec states that replies shouldn't
4201 2003-02-13 Anders Carlsson <andersca@codefactory.se>
4203 * bus/desktop-file.c: (parse_section_start), (parse_key_value),
4204 (report_error), (bus_desktop_file_load), (lookup_section),
4205 (lookup_line), (bus_desktop_file_get_raw),
4206 (bus_desktop_file_get_string):
4207 * bus/desktop-file.h:
4208 Some fixes, and new functions for getting a key value from a section.
4210 2003-02-13 Havoc Pennington <hp@pobox.com>
4212 * test/data/auth/fail-after-n-attempts.auth-script: new test
4214 * dbus/dbus-auth.c (send_rejected): shutdown_mech() when we
4217 2003-02-13 Havoc Pennington <hp@pobox.com>
4219 * dbus/dbus-auth.c (handle_server_data_external_mech): args to
4220 dbus_credentials_match were backward
4222 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support
4223 NO_CREDENTIALS and ROOT_CREDENTIALS
4225 * dbus/dbus-auth.c (_dbus_auth_do_work): move get_state() routine
4226 into here. Never process more commands after we've reached an
4227 end state; store further data as unused bytes.
4229 * test/data/auth/*: add more auth tests
4231 * dbus/dbus-auth-script.c (_dbus_auth_script_run): support EXPECT
4232 command to match exact string and EXPECT_UNUSED to match unused
4235 * test/Makefile.am (dist-hook): fix to dist all the test stuff
4237 2003-02-12 Havoc Pennington <hp@pobox.com>
4239 * dbus/dbus-string.c (_dbus_string_pop_line): fix to also strip
4240 \r off of popped lines
4242 * dbus/dbus-auth.c (_dbus_auth_test): write code to run auth
4245 * dbus/dbus-auth-script.c (_dbus_auth_script_run): when doing a
4248 2003-02-12 Havoc Pennington <hp@pobox.com>
4250 * dbus/Makefile.am: remove break-loader from the build, since it
4253 * configure.in: add --enable-gcov to turn on coverage profiling
4254 flags and disable optimization
4256 2003-02-10 Havoc Pennington <hp@pobox.com>
4258 * dbus/dbus-auth-script.c, dbus/dbus-auth-script.h: sync
4259 initial cut at test framework for DBusAuth from laptop.
4260 Doesn't quite work yet but it compiles and I need to get
4261 it off the 266mhz laptop. ;-)
4263 * dbus/dbus-server-debug.c (_dbus_server_debug_accept_transport):
4264 fix a memleak in error case
4266 2003-02-12 Anders Carlsson <andersca@codefactory.se>
4269 * bus/desktop-file.c:
4270 * bus/desktop-file.h:
4271 Add a desktop file parser.
4273 2003-02-11 Zack Rusin <zack@kde.org>
4275 * qt/message.[h|cpp]: sample implementation
4276 of the KDE wrapper for DBusMessage
4278 2003-02-09 Zack Rusin <zack@kde.org>
4280 * test/bus-test.c: make_it_compile
4281 * doc/dbus-specification.sgml: minimal semantic fix
4283 2003-02-06 Anders Carlsson <andersca@codefactory.se>
4289 2003-02-06 Anders Carlsson <andersca@codefactory.se>
4292 * dbus/dbus-break-loader.c:
4294 * test/break-loader.c:
4295 Move dbus-break-loader to test/ and rename it to break-loader.
4297 2003-02-02 Havoc Pennington <hp@pobox.com>
4299 * dbus/dbus-keyring.c, dbus/dbus-keyring.h: template files
4300 for code to manage cookies in your home directory
4302 * dbus/dbus-sysdeps.c (_dbus_generate_random_bytes): new function
4304 * dbus/dbus-auth.c (get_state): impose a maximum number of tries
4305 to authenticate, then disconnect the client.
4307 2003-02-03 Alexander Larsson <alexl@redhat.com>
4309 * dbus/dbus-message.c (dbus_message_append_fields):
4312 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4314 * doc/dbus-specification.sgml:
4315 Update address format section.
4317 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4320 * test/bus-test.c: (get_time), (add_timeout), (remove_timeout),
4321 (message_handler), (new_connection_callback), (loop_quit),
4325 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4327 * bus/driver.c: (bus_driver_handle_service_exists):
4328 Simplify the code a bit.
4330 * dbus/dbus-bus.c: (dbus_bus_service_exists):
4333 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4336 Add libdbus-daemon.la and link to it.
4338 2003-02-01 James Willcox <jwillcox@gnome.org>
4340 * bus/driver.c: (bus_driver_handle_own_service):
4341 Actually include the service reply code in the message.
4343 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4345 * bus/driver.c: (bus_driver_handle_service_exists):
4346 Don't unref the incoming message.
4348 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4350 * dbus/dbus.h: Add dbus-address.h and dbus-bus.h
4352 2003-02-02 Anders Carlsson <andersca@codefactory.se>
4354 * dbus/dbus-server.c: (dbus_server_listen):
4355 * dbus/dbus-transport.c: (_dbus_transport_open):
4356 ifdef out the calls to the debug transport and server.
4358 2003-02-02 Alexander Larsson <alexl@redhat.com>
4360 * dbus/dbus-watch.c (dbus_watch_get_flags):
4361 Add note in the docs that ERROR or HANGUP won't be returned
4362 and are assumed always on.
4364 * glib/dbus-gmain.c (add_watch):
4365 Always add IO_ERR | IO_HUP
4367 * dbus/dbus-message.h:
4368 Add semicolon after dbus_message_iter_get_string_array().
4369 Makes qt code build again
4371 2003-02-01 Anders Carlsson <andersca@codefactory.se>
4373 * bus/driver.c: (create_unique_client_name),
4374 (bus_driver_handle_hello):
4375 Don't take a name, just use a numeric id to identify
4379 * dbus/dbus-bus.c: (dbus_bus_register_client),
4380 (dbus_bus_acquire_service), (dbus_bus_service_exists):
4382 Add new convenience functions for communicating with the bus.
4384 * dbus/dbus-message.h:
4386 * dbus/dbus-protocol.h:
4389 2003-02-01 Alexander Larsson <alexl@redhat.com>
4391 * dbus/dbus-message.c (dbus_message_append_fields):
4392 Add some more doc comments.
4394 2003-02-01 Havoc Pennington <hp@pobox.com>
4396 * dbus/dbus-break-loader.c (randomly_modify_length): change
4397 a 4-byte value in the message as if it were a length
4399 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): don't set
4400 execute bit on saved files
4402 2003-02-01 Havoc Pennington <hp@pobox.com>
4404 * dbus/dbus-break-loader.c (main): new program to find messages
4405 that break the loader.
4407 * dbus/dbus-sysdeps.c (_dbus_string_append_uint): new function
4408 * dbus/dbus-sysdeps.c (_dbus_string_save_to_file): new function
4410 * dbus/dbus-string.c (_dbus_string_set_byte): new
4412 2003-01-31 Havoc Pennington <hp@pobox.com>
4414 * dbus/dbus-message.c: refactor the test code to be more general,
4415 in preparation for writing a "randomly permute test cases to
4416 try to break the loader" program.
4418 2003-01-31 Havoc Pennington <hp@pobox.com>
4420 * doc/dbus-specification.sgml: work on the specification
4422 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): check
4423 the protocol version of the message.
4425 * dbus/dbus-protocol.h: drop special _REPLY names, the spec
4426 no longer specifies that.
4427 (DBUS_SERVICE_REPLY_SERVICE_EXISTS): fix flags (1/2/4/8 not
4430 * dbus/dbus-marshal.c (_dbus_marshal_get_arg_end_pos): add missing
4431 "break" for DBUS_TYPE_NIL, remove @todo
4433 2003-01-31 Havoc Pennington <hp@pobox.com>
4435 * dbus/dbus-message.c (dbus_message_set_is_error_reply): rename
4436 just set_is_error/get_is_error as this is a commonly-used
4437 function, and write docs.
4439 2003-01-31 Anders Carlsson <andersca@codefactory.se>
4441 * dbus/dbus-address.c: (dbus_address_entry_free):
4442 Free key and value lists.
4444 * dbus/dbus-internals.c: (_dbus_type_to_string):
4445 Add the types we didn't have.
4447 * dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
4448 (_dbus_marshal_validate_arg):
4451 * dbus/dbus-message.c: (dbus_message_set_sender):
4452 Remove todo about being able to set sender to NULL.
4454 (dbus_message_set_is_error_reply),
4455 (dbus_message_get_is_error_reply):
4456 * dbus/dbus-message.h:
4459 * dbus/dbus-protocol.h:
4460 Add error reply flag.
4462 * test/data/valid-messages/opposite-endian.message:
4463 Add NIL type to test.
4465 2003-01-31 Havoc Pennington <hp@pobox.com>
4467 * doc/dbus-specification.sgml: fully specify the header. Add
4468 flags and major protocol version, and change header/body len to
4471 * dbus/dbus-message-builder.c (append_saved_length): append length
4474 * dbus/dbus-message.c (dbus_message_create_header): change header
4475 length and body length to unsigned. Add the new fields from the
4477 (_dbus_message_loader_return_buffer): unsigned header/body len
4479 2003-01-30 Havoc Pennington <hp@pobox.com>
4481 * dbus/dbus-auth.c: rework to use only REJECTED, no
4484 * doc/dbus-sasl-profile.txt: drop MECHANISMS and just
4485 use REJECTED, suggested by Mark McLoughlin
4487 2003-01-30 Havoc Pennington <hp@pobox.com>
4489 * dbus/dbus-server.c (dbus_server_listen): @todo about how we need
4490 a better way to report errors here. e.g. "unix address lacks
4491 path" or something. also "no such file" when the path doesn't
4494 * dbus/dbus-address.c (dbus_address_entries_free): add @todo about
4496 (dbus_parse_address): add @todo about documenting address format,
4497 and allowing , and ; to be escaped
4499 2003-01-30 Anders Carlsson <andersca@codefactory.se>
4502 Add dbus-address.[ch]
4504 * dbus/dbus-address.c: (dbus_address_entry_free),
4505 (dbus_address_entries_free), (create_entry),
4506 (dbus_address_entry_get_method), (dbus_address_entry_get_value),
4507 (dbus_parse_address), (_dbus_address_test):
4508 * dbus/dbus-address.h:
4509 New files for dealing with address parsing.
4511 * dbus/dbus-connection.c:
4512 Document timeout functions.
4514 * dbus/dbus-message.c:
4515 Document dbus_message_new_from_message.
4517 * dbus/dbus-server-debug.c:
4520 * dbus/dbus-server.c: (dbus_server_listen):
4521 Parse address and use correct server implementation.
4523 * dbus/dbus-string.c: (_dbus_string_find_to), (_dbus_string_test):
4524 * dbus/dbus-string.h:
4525 New function with test.
4527 * dbus/dbus-test.c: (dbus_internal_symbol_do_not_use_run_tests):
4531 * dbus/dbus-transport-debug.c:
4534 * dbus/dbus-transport.c: (_dbus_transport_open):
4535 Parse address and use correct transport implementation.
4537 2003-01-30 Havoc Pennington <hp@pobox.com>
4539 * dbus/dbus-message.c: use message->byte_order instead of
4540 DBUS_COMPILER_BYTE_ORDER throughout.
4541 (dbus_message_create_header): pad header to align the
4542 start of the body of the message to 8-byte boundary
4544 * dbus/dbus-marshal.h: make all the demarshalers take const
4545 DBusString arguments.
4547 * dbus/dbus-message.c (_dbus_message_loader_return_buffer):
4548 validate message args here, so we don't have to do slow validation
4549 later, and so we catch bad messages as they are incoming. Also add
4550 better checks on header_len and body_len. Also fill in
4553 * dbus/dbus-string.c (_dbus_string_validate_utf8): new (not
4554 implemented properly)
4555 (_dbus_string_validate_nul): new function to check all-nul
4557 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): rename
4558 get_arg_end_pos and remove all validation
4559 (_dbus_marshal_validate_arg): actually do validation here.
4561 2003-01-29 Havoc Pennington <hp@pobox.com>
4563 * dbus/dbus-message.c (check_message_handling): fix assertion
4564 failure on set_client_serial
4566 2003-01-28 Havoc Pennington <hp@pobox.com>
4568 * dbus/dbus-server-debug.c: Add doc section comments
4570 * dbus/dbus-transport-debug.c: add doc section comments
4572 2003-01-28 Havoc Pennington <hp@redhat.com>
4574 * dbus/dbus-string.c (_dbus_string_base64_decode): append bytes in
4575 the reverse order from how I had it
4576 (_dbus_string_base64_encode): reverse encoding order. I was
4577 basically byteswapping everything during encoding.
4579 2003-01-28 Anders Carlsson <andersca@codefactory.se>
4581 * dbus/dbus-connection-internal.h:
4582 * dbus/dbus-connection.c: (_dbus_connection_add_timeout),
4583 (_dbus_connection_remove_timeout):
4584 Add functions for adding and removing timeouts.
4586 * dbus/dbus-message.c: (dbus_message_new_from_message):
4587 Add new function that takes a message and creates an exact
4588 copy of it, but with the refcount set to 1.
4589 (check_message_handling):
4592 * dbus/dbus-server-protected.h:
4593 * dbus/dbus-server.c: (_dbus_server_init_base),
4594 (_dbus_server_finalize_base), (_dbus_server_add_timeout),
4595 (dbus_server_set_timeout_functions):
4596 (_dbus_server_remove_timeout):
4597 New functions so that a server can add and remove timeouts.
4599 (dbus_server_listen):
4600 Add commented out call to dbus_server_debug_new.
4602 * dbus/dbus-timeout.c: (_dbus_timeout_new):
4603 Actually set the handler, doh.
4605 * dbus/dbus-transport.c: (_dbus_transport_open):
4606 Add commented out call to dbus_transport_debug_client_new.
4609 Add dbus-transport-debug.[ch] and dbus-server-debug.[ch]
4611 2003-01-28 Havoc Pennington <hp@pobox.com>
4613 * dbus/dbus-message.c (check_message_handling): function to check
4614 on the loaded message, iterates over it etc.
4616 2003-01-28 Havoc Pennington <hp@pobox.com>
4618 * test/Makefile.am (dist-hook): fix make distdir
4620 * dbus/Makefile.am (TESTS_ENVIRONMENT): fix make check
4622 2003-01-27 Havoc Pennington <hp@pobox.com>
4624 * dbus/dbus-mempool.c (time_for_size): replace printf with
4627 * dbus/dbus-message-builder.c (_dbus_message_data_load): allow
4628 empty lines; fix the SAVE_LENGTH stuff to be
4629 START_LENGTH/END_LENGTH so it actually works; couple other
4632 * test/Makefile.am (dist-hook): add dist-hook for .message files
4634 * dbus/dbus-string.c (DBUS_STRING_COPY_PREAMBLE): source of a copy
4635 can be constant or locked.
4636 (_dbus_string_free): allow freeing a const string as
4639 * dbus/dbus-sysdeps.c (_dbus_concat_dir_and_file): utility
4641 * dbus/dbus-test-main.c (main): take an argument which is the
4642 directory containing test data
4644 * dbus/dbus-message.c (_dbus_message_test): pass a test_data_dir
4645 argument to this and load all the messages in test/data/
4646 checking that they can be loaded or not loaded as appropriate.
4648 2003-01-27 Anders Carlsson <andersca@codefactory.se>
4650 * bus/dispatch.c: (bus_dispatch_message_handler):
4651 Dispatch messages sent to services.
4653 * bus/driver.c: (bus_driver_send_service_deleted),
4654 (bus_driver_send_service_created), (bus_driver_send_service_lost),
4655 (bus_driver_send_service_acquired):
4656 Add helper functions for sending service related messages.
4658 (bus_driver_send_welcome_message):
4659 Send HELLO_REPLY instead of WELCOME.
4661 (bus_driver_handle_list_services):
4662 Send LIST_SERVICES_REPLY instead of SERVICES.
4664 (bus_driver_handle_own_service),
4665 (bus_driver_handle_service_exists):
4666 New message handlers.
4668 (bus_driver_handle_message):
4669 Invoke new message handlers.
4671 (bus_driver_remove_connection):
4672 Don't remove any services here since that's done automatically
4673 by bus_service_remove_owner now.
4676 New function signatures.
4678 * bus/services.c: (bus_service_add_owner):
4679 Send ServiceAcquired message if we're the only primary owner.
4681 (bus_service_remove_owner):
4682 Send ServiceAcquired/ServiceLost messages.
4684 (bus_service_set_prohibit_replacement),
4685 (bus_service_get_prohibit_replacement):
4686 Functions for setting prohibit replacement.
4688 (bus_service_has_owner):
4689 New function that checks if a connection is in the owner queue of
4693 Add new function signatures.
4695 * dbus/dbus-list.c: (_dbus_list_test):
4696 Add tests for _dbus_list_remove_last and traversing the list backwards.
4699 Fix a typo in _dbus_list_get_prev_link, if we're at the first element we can't
4700 go any further, so return NULL then.
4702 * dbus/dbus-protocol.h:
4703 Add new messages, service flags and service replies.
4705 2003-01-26 Havoc Pennington <hp@pobox.com>
4707 * dbus/dbus-message-builder.c: implement, completely untested.
4709 * test/data/*: add data to be used in testing.
4710 ".message" files are our simple loadable text format.
4711 ".message-raw" will be binary dumps of messages.
4713 * dbus/dbus-string.c (_dbus_string_starts_with_c_str): new
4715 2003-01-26 Havoc Pennington <hp@pobox.com>
4717 * dbus/dbus-sysdeps.c (_dbus_file_get_contents): new function
4719 * dbus/dbus-errors.c (dbus_result_to_string): add
4722 * dbus/dbus-message-builder.c: new file, will contain code to load
4723 up messages from files. Not implemented yet.
4725 2003-01-26 Havoc Pennington <hp@pobox.com>
4727 * dbus/dbus-message.c (dbus_message_set_sender): support deleting
4728 the sender by setting to NULL
4730 2003-01-26 Havoc Pennington <hp@pobox.com>
4732 The unit tests pass, but otherwise untested. If it breaks, the
4733 tests should have been better. ;-)
4735 * bus/driver.c (bus_driver_handle_hello): return if we disconnect
4738 * dbus/dbus-message.c: redo everything so we maintain
4739 message->header as the only copy of the various fields.
4740 This avoids the possibility of out-of-memory in some cases,
4741 for example dbus_message_lock() can't run out of memory anymore,
4742 and avoids extra copying. Figured I may as well go ahead and do
4743 this since it was busted for dbus_message_lock to not return
4744 failure on OOM, and dbus_message_write_header was totally
4745 unchecked for OOM. Also fixed some random other bugs.
4747 * dbus/dbus-marshal.c (_dbus_marshal_get_field_end_pos): verify
4748 that strings are nul-terminated. Also, end_pos can be equal
4749 to string length just not greater than, I think.
4750 (_dbus_marshal_set_int32): new function
4751 (_dbus_marshal_set_uint32): new function
4752 (_dbus_marshal_set_string): new function
4754 * dbus/dbus-connection.c (_dbus_connection_new_for_transport): fix
4755 a warning, init timeout_list to NULL
4756 (dbus_connection_send_message): don't use uninitialized variable
4759 * dbus/dbus-string.c (_dbus_string_replace_len): new function
4761 2003-01-26 Anders Carlsson <andersca@codefactory.se>
4763 * bus/driver.c: (bus_driver_handle_hello),
4764 (bus_driver_send_welcome_message):
4767 2003-01-26 Anders Carlsson <andersca@codefactory.se>
4769 * dbus/dbus-auth.c: (process_auth), (_dbus_auth_unref):
4770 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
4771 (dbus_connection_unref):
4772 * dbus/dbus-marshal.c: (_dbus_marshal_test):
4773 * dbus/dbus-message.c: (dbus_message_unref),
4776 (dbus_message_get_fields):
4777 Remove debugging printout.
4779 (_dbus_message_loader_return_buffer):
4780 Don't store the header string.
4782 (_dbus_message_test):
4785 2003-01-26 Richard Hult <rhult@codefactory.se>
4787 * glib/dbus-gmain.c (dbus_connection_dispatch): Traverse a copy of
4788 the file descriptor list, since it can change under us.
4790 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4792 * glib/dbus-gmain.c: (dbus_connection_prepare),
4793 (dbus_connection_check), (dbus_connection_dispatch), (add_watch),
4794 (remove_watch), (dbus_connection_hookup_with_g_main):
4795 Rewrite the glib handling to use its own GSource instead of a
4796 GIOChannel so we can catch messages put in the queue while waiting
4799 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4802 * bus/connection.c: (connection_disconnect_handler),
4803 (connection_watch_callback), (bus_connection_setup):
4804 * bus/dispatch.c: (send_one_message),
4805 (bus_dispatch_broadcast_message), (bus_dispatch_message_handler),
4806 (bus_dispatch_add_connection), (bus_dispatch_remove_connection):
4808 * bus/driver.c: (bus_driver_send_service_deleted),
4809 (bus_driver_send_service_created), (bus_driver_handle_hello),
4810 (bus_driver_send_welcome_message),
4811 (bus_driver_handle_list_services), (bus_driver_remove_connection),
4812 (bus_driver_handle_message):
4814 Refactor code, put the message dispatching in its own file. Use
4815 _DBUS_HANDLE_OOM. Also send ServiceDeleted messages when a client
4818 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4820 * dbus/dbus-internals.h:
4821 Add _DBUS_HANDLE_OOM macro, it doesn't do anything currently.
4823 * dbus/dbus-message.c: (dbus_message_get_sender):
4824 * dbus/dbus-message.h:
4825 Implement dbus_message_get_sender.
4827 * dbus/dbus-protocol.h:
4828 Add message and service defines.
4830 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4832 * dbus/dbus-connection.c: (dbus_connection_send_message):
4833 * dbus/dbus-message-internal.h:
4834 * dbus/dbus-message.c: (_dbus_message_get_client_serial),
4835 (dbus_message_write_header):
4836 Remove _dbus_messag_unlock and don't set the client serial on a
4837 message if one already exists.
4839 2003-01-24 Havoc Pennington <hp@pobox.com>
4841 * dbus/dbus-list.c (alloc_link): put a thread lock on the global
4844 * bus/driver.c (bus_driver_handle_list_services): fix a leak
4847 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4849 * dbus/dbus-list.c: (alloc_link), (free_link):
4850 Use a memory pool for the links.
4852 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4854 * bus/connection.c: (bus_connection_foreach):
4856 Add new bus_connection_foreach function.
4858 * bus/driver.c: (send_one_message), (bus_driver_broadcast_message):
4859 Add function that broadcasts a message to all clients.
4861 (bus_driver_send_service_created), (bus_driver_handle_hello),
4862 (bus_driver_send_welcome_message),
4863 (bus_driver_handle_list_services), (bus_driver_message_handler):
4864 Implement functions that take care of listing services, and notifying
4865 clients when new services are created.
4867 * bus/services.c: (bus_services_list):
4869 Add new function that returns an array of strings with the currently
4870 registered services.
4873 * glib/dbus-gmain.c:
4874 Update copyright year.
4876 2003-01-25 Anders Carlsson <andersca@codefactory.se>
4878 * dbus/dbus-connection.c: (dbus_connection_send_message):
4879 Unlock the message in case it was sent earlier.
4881 (dbus_connection_send_message_with_reply_and_block):
4882 Remove the reply message from the list.
4884 * dbus/dbus-marshal.c: (_dbus_demarshal_string_array):
4885 Set array_len and new_pos correctly.
4887 (_dbus_marshal_test):
4888 Remove debug output.
4890 * dbus/dbus-message-internal.h:
4891 * dbus/dbus-message.c: (_dbus_message_get_reply_serial):
4892 New function that returns the reply serial.
4894 (_dbus_message_unlock):
4895 New function that unlocks a message and resets its header.
4897 (dbus_message_append_string_array),
4898 (dbus_message_get_fields_valist),
4899 (dbus_message_iter_get_field_type),
4900 (dbus_message_iter_get_string_array),
4901 (dbus_message_get_fields),
4902 (dbus_message_append_fields_valist):
4903 Handle string arrays.
4905 (dbus_message_set_sender):
4906 Make this function public since the bus daemon needs it.
4908 (decode_header_data):
4909 Set the reply serial to -1 initially.
4911 * dbus/dbus-message.h:
4912 Add dbus_message_set_sender.
4914 2003-01-24 Havoc Pennington <hp@pobox.com>
4916 * doc/dbus-specification.sgml: add some stuff
4918 2003-01-22 Havoc Pennington <hp@pobox.com>
4920 * doc/dbus-specification.sgml: Start to document the protocol.
4922 2003-01-22 Havoc Pennington <hp@pobox.com>
4924 * dbus/dbus-connection.c
4925 (dbus_connection_send_message_with_reply_and_block): add some @todo
4927 * bus/driver.c (bus_driver_add_connection): add a FIXME about memleak
4929 2003-01-21 Havoc Pennington <hp@pobox.com>
4931 (patch untested because can't compile)
4933 * bus/driver.c (create_unique_client_name): make this function
4934 never recycle client names. Also, caller should initialize
4937 * dbus/dbus-sysdeps.c (_dbus_get_current_time): new function
4939 2003-01-21 Anders Carlsson <andersca@codefactory.se>
4941 * dbus/dbus-marshal.c: (_dbus_marshal_double),
4942 (_dbus_marshal_int32), (_dbus_marshal_uint32),
4943 (_dbus_marshal_int32_array), (_dbus_marshal_uint32_array),
4944 (_dbus_marshal_double_array), (_dbus_marshal_string_array),
4945 (_dbus_demarshal_int32_array), (_dbus_demarshal_uint32_array),
4946 (_dbus_demarshal_double_array), (_dbus_demarshal_string_array),
4947 (_dbus_marshal_get_field_end_pos), (_dbus_marshal_test):
4948 * dbus/dbus-marshal.h:
4949 * dbus/dbus-protocol.h:
4950 Add support for marshalling and demarshalling integer, double
4953 2003-01-21 Anders Carlsson <andersca@codefactory.se>
4958 * bus/connection.c: (connection_disconnect_handler):
4959 Remove the connection from the bus driver's list.
4961 (connection_watch_callback): Dispatch messages.
4963 (free_connection_data): Free connection name.
4965 (bus_connection_setup): Add connection to the bus driver's list.
4966 (bus_connection_remove_owned_service):
4967 (bus_connection_set_name), (bus_connection_get_name):
4968 Add functions for setting and getting the connection's name.
4971 Add function headers.
4973 * bus/driver.c: (create_unique_client_name),
4974 (bus_driver_handle_hello_message),
4975 (bus_driver_send_welcome_message), (bus_driver_message_handler),
4976 (bus_driver_add_connection), (bus_driver_remove_connection):
4979 * bus/services.c: (bus_service_free):
4981 New file that handles communication and registreation with the bus
4984 2003-01-21 Anders Carlsson <andersca@codefactory.se>
4986 * dbus/dbus-connection.c: (dbus_connection_send_message):
4987 Add a new client_serial parameter.
4989 (dbus_connection_send_message_with_reply):
4990 Remove a @todo since we've implemented the blocking function.
4992 (dbus_connection_send_message_with_reply_and_block):
4993 New function that sends a message and waits for a reply and
4994 then returns the reply.
4996 * dbus/dbus-connection.h:
4999 * dbus/dbus-errors.c: (dbus_result_to_string):
5000 * dbus/dbus-errors.h:
5001 Add new DBUS_RESULT.
5003 * dbus/dbus-message-internal.h:
5004 * dbus/dbus-message.c: (_dbus_message_get_reply_serial),
5005 (_dbus_message_set_sender), (dbus_message_write_header),
5006 (dbus_message_new_reply), (decode_header_data),
5007 (_dbus_message_loader_return_buffer), (_dbus_message_test):
5008 * dbus/dbus-message.h:
5009 Add new functions that set the reply serial and sender.
5010 Also marshal and demarshal them correctly and add test.
5012 * dbus/dbus-protocol.h:
5013 Add new DBUS_MESSAGE_TYPE_SENDER.
5016 * glib/dbus-gmain.c: (watch_callback), (free_callback_data),
5017 (add_watch), (remove_watch), (add_timeout), (remove_timeout),
5018 (dbus_connection_hookup_with_g_main):
5019 * glib/test-dbus-glib.c: (main):
5020 Rewrite to use GIOChannel and remove the GSource crack.
5022 * test/echo-client.c: (main):
5023 * test/watch.c: (check_messages):
5024 Update for changed APIs
5026 2003-01-19 Anders Carlsson <andersca@codefactory.se>
5028 * dbus/Makefile.am: Add dbus-timeout.[cħ]
5030 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport):
5031 Create a DBusTimeoutList.
5032 (dbus_connection_set_timeout_functions): Add new function to
5033 set timeout callbacks
5035 * dbus/dbus-connection.h: Add public DBusTimeout API.
5037 * dbus/dbus-message.c: (dbus_message_get_service):
5038 * dbus/dbus-message.h: New function.
5040 * dbus/dbus-server.c: Fix small doc typo.
5042 * dbus/dbus-timeout.[ch]: New files for mainloop timeouts.
5044 2003-01-19 Anders Carlsson <andersca@codefactory.se>
5046 * dbus/dbus-string.c (_dbus_string_move_len): Don't delete all
5047 of the string, just as long as specified.
5049 2003-01-19 Havoc Pennington <hp@pobox.com>
5051 * dbus/dbus-connection.c (dbus_connection_get_is_authenticated):
5054 * dbus/dbus-server.c (dbus_server_set_max_connections)
5055 (dbus_server_get_max_connections, dbus_server_get_n_connections):
5056 keep track of current number of connections, and add API for
5057 setting a max (but haven't implemented enforcing the max yet)
5059 2003-01-18 Havoc Pennington <hp@pobox.com>
5061 * dbus/dbus-transport-unix.c (unix_do_iteration): only do the
5062 reading/writing if read_watch != NULL or write_watch != NULL.
5064 * dbus/dbus-message.c (_dbus_message_loader_return_buffer): fix
5065 the message loader code to actually load message->header and
5066 message->body into the newly-created message.
5068 * dbus/dbus-transport-unix.c (check_write_watch): fix a mem leak
5071 * dbus/dbus-connection.c (dbus_connection_set_max_message_size)
5072 (dbus_connection_get_max_message_size)
5073 (dbus_connection_set_max_live_messages_size)
5074 (dbus_connection_get_max_live_messages_size): implement some
5075 resource limitation functions
5077 * dbus/dbus-resources.c: new file implementing some of the
5078 resource limits stuff
5080 * dbus/dbus-message.c (dbus_message_iter_get_byte_array): add
5081 missing docs, add @todo to handle OOM etc.
5083 * dbus/dbus-marshal.c (_dbus_demarshal_byte_array): add missing
5086 2003-01-18 Havoc Pennington <hp@pobox.com>
5088 * dbus/dbus-connection.c (dbus_connection_unref): disconnect the
5089 connection if it hasn't been already.
5091 * dbus/dbus-connection.h: kill off the idea of an ErrorFunction,
5092 replace with DisconnectFunction.
5094 2003-01-18 Havoc Pennington <hp@pobox.com>
5096 Building --disable-verbose-mode --disable-asserts --disable-tests
5097 cuts the library from 112K to 45K or so
5099 * configure.in: check for varargs macro support,
5100 add --enable-verbose-mode, --enable-asserts.
5102 * dbus/dbus-internals.h (_dbus_assert): support
5104 (_dbus_verbose): support DBUS_ENABLE_VERBOSE_MODE
5106 2003-01-18 Havoc Pennington <hp@pobox.com>
5108 * dbus/dbus-test.c: include config.h so that tests actually run
5110 * dbus/dbus-string.c: add assertions that stuff is 8-byte aligned,
5111 so the failure mode when that assumption fails will be plenty
5114 2003-01-18 Havoc Pennington <hp@pobox.com>
5116 * configure.in: default --enable-tests to $USE_MAINTAINER_MODE
5118 * dbus/Makefile.am: fix it up so dubs-test-main.c is included in
5121 * test/Makefile.am: don't use special variable "TESTS" for echo-*
5122 since we don't want to use those in make check
5124 2003-01-15 Havoc Pennington <hp@redhat.com>
5130 2003-01-15 Havoc Pennington <hp@redhat.com>
5132 * test/Makefile.am: fix so that test source code ends up in the
5133 distribution on make distcheck
5135 2003-01-15 Havoc Pennington <hp@redhat.com>
5141 2003-01-15 Havoc Pennington <hp@redhat.com>
5143 * dbus/dbus-test.c (dbus_internal_symbol_do_not_use_run_tests):
5144 fix build when --disable-tests
5146 * Makefile.am (EXTRA_DIST): put HACKING in here
5148 * HACKING: document procedure for making a tarball release.
5150 2003-01-14 Anders Carlsson <andersca@codefactory.se>
5152 * bus/connection.c: (connection_error_handler),
5153 (bus_connection_setup):
5154 * bus/main.c: (main):
5155 Make sure that the DBusConnectionData struct is NULLed
5156 out to prevent a segfault.
5158 * dbus/dbus-errors.c: (dbus_result_to_string):
5159 * dbus/dbus-errors.h:
5160 * dbus/dbus-message.c: (dbus_message_get_fields),
5161 (dbus_message_get_fields_valist), (_dbus_message_test):
5162 * dbus/dbus-message.h:
5163 Make dbus_message_get_fields return a result code so we can
5164 track invalid fields as well as oom.
5166 2003-01-11 Havoc Pennington <hp@pobox.com>
5168 * configure.in: change --enable-test/--enable-ansi action-if-given
5169 to enable_foo=$enableval instead of enable_foo=yes
5171 2003-01-08 Havoc Pennington <hp@pobox.com>
5173 * dbus/dbus-string.c (_dbus_string_align_length): new function
5175 * dbus/dbus-test-main.c: move main() for test app here
5177 (dbus_internal_symbol_do_not_use_run_tests): we have to export a
5178 symbol to run tests, because dbus-test isn't in the main
5181 Code review nitpicks.
5183 * dbus/dbus-message.c (dbus_message_write_header): add newlines
5184 for people with narrow emacs ;-). Assert client_serial was filled
5185 in. Assert message->name != NULL.
5186 (dbus_message_append_fields): have "first_field_type" arg separate
5187 from va list, needed for C++ binding that also uses varargs IIRC
5188 and helps with type safety
5189 (dbus_message_new): add @todo about using DBusString to store
5190 service/name internally
5191 (dbus_message_new): don't leak ->service and ->name on OOM later
5193 (dbus_message_unref): free the service name
5194 (dbus_message_get_fields): same change to varargs
5195 i.e. first_field_type
5196 (_dbus_message_loader_return_buffer): assert that the message data
5197 is aligned (if not it's a bug in our code). Put in verbose griping
5198 about why we set corrupted = TRUE.
5199 (decode_header_data): add FIXME that char* is evil. Was going to
5200 add FIXME about evil locale-specific string.h strncmp, but just
5201 switched to wacky string-as-uint32 optimization. Move check for
5202 "no room for field name" above get_const_data_len() to avoid
5203 assertion failure in get_const_data_len if we have trailing 2
5204 bytes or the like. Check for service and name fields being
5205 provided twice. Don't leak service/name on error. Require field
5206 names to be aligned to 4 bytes.
5208 * dbus/dbus-marshal.c: move byte swap stuff to header
5209 (_dbus_pack_int32): uscore-prefix
5210 (_dbus_unpack_int32): uscore-prefix
5211 (_dbus_unpack_uint32): export
5212 (_dbus_demarshal_string): add @todo complaining about use of
5214 (_dbus_marshal_get_field_end_pos): add @todo about bad error
5215 handling allowing corrupt data to go unchecked
5217 2003-01-08 Havoc Pennington <hp@redhat.com>
5219 * dbus/dbus-transport-unix.c (unix_do_iteration): add read/write
5220 to the select() as needed for authentication. (should be using
5221 _dbus_poll() not select, but for another day)
5223 * dbus/dbus.h: include dbus/dbus-protocol.h
5225 2003-01-08 Anders Carlsson <andersca@codefactory.se>
5227 * dbus/Makefile.am (dbusinclude_HEADERS): Install
5230 2003-01-08 Anders Carlsson <andersca@codefactory.se>
5232 * dbus/dbus-internals.c: (_dbus_type_to_string):
5233 New function that returns a string describing a type.
5235 * dbus/dbus-marshal.c: (_dbus_demarshal_byte_array):
5236 * dbus/dbus-marshal.h:
5237 * dbus/dbus-message.c: (dbus_message_get_fields_valist),
5238 (dbus_message_iter_get_field_type), (dbus_message_iter_get_double),
5239 (dbus_message_iter_get_byte_array):
5240 * dbus/dbus-message.h:
5241 Add new convenience functions for appending and getting message fields.
5242 Also add demarshalling routines for byte arrays.
5244 2003-01-07 Anders Carlsson <andersca@codefactory.se>
5246 * dbus/dbus-connection-internal.h:
5247 * dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
5248 (_dbus_connection_get_next_client_serial),
5249 (dbus_connection_send_message):
5250 * dbus/dbus-internals.h:
5251 * dbus/dbus-marshal.c: (unpack_uint32), (dbus_unpack_int32),
5252 (dbus_pack_int32), (_dbus_marshal_double), (_dbus_marshal_int32),
5253 (_dbus_marshal_uint32), (_dbus_demarshal_double),
5254 (_dbus_demarshal_int32), (_dbus_demarshal_uint32),
5255 (_dbus_demarshal_string), (_dbus_marshal_get_field_end_pos),
5256 (_dbus_verbose_bytes), (_dbus_marshal_test):
5257 * dbus/dbus-marshal.h:
5258 * dbus/dbus-message-internal.h:
5259 * dbus/dbus-message.c: (_dbus_message_set_client_serial),
5260 (dbus_message_write_header), (_dbus_message_lock),
5261 (dbus_message_new), (dbus_message_ref), (dbus_message_unref),
5262 (dbus_message_get_name), (dbus_message_append_int32),
5263 (dbus_message_append_uint32), (dbus_message_append_double),
5264 (dbus_message_append_string), (dbus_message_append_byte_array),
5265 (dbus_message_get_fields_iter), (dbus_message_iter_ref),
5266 (dbus_message_iter_unref), (dbus_message_iter_has_next),
5267 (dbus_message_iter_next), (dbus_message_iter_get_field_type),
5268 (dbus_message_iter_get_string), (dbus_message_iter_get_int32),
5269 (dbus_message_iter_get_uint32), (dbus_message_iter_get_double),
5270 (decode_header_data), (_dbus_message_loader_return_buffer),
5271 (message_iter_test), (_dbus_message_test):
5272 * dbus/dbus-message.h:
5273 * dbus/dbus-protocol.h:
5274 * dbus/dbus-test.c: (main):
5276 * glib/test-dbus-glib.c: (message_handler), (main):
5277 * test/echo-client.c: (main):
5278 * test/watch.c: (check_messages):
5279 Make messages sendable and receivable for real.
5281 2003-01-07 Anders Carlsson <andersca@codefactory.se>
5283 * dbus/dbus-marshal.c: (_dbus_marshal_double),
5284 (_dbus_marshal_string), (_dbus_marshal_byte_array):
5285 * dbus/dbus-message.c: (dbus_message_append_int32),
5286 (dbus_message_append_uint32), (dbus_message_append_double),
5287 (dbus_message_append_string), (dbus_message_append_byte_array):
5288 Handle OOM restoration.
5290 2003-01-07 Anders Carlsson <andersca@codefactory.se>
5292 * dbus/dbus-marshal.c: (_dbus_marshal_string),
5293 (_dbus_demarshal_string), (_dbus_marshal_test):
5294 * dbus/dbus-marshal.h:
5295 * dbus/dbus-message.c: (dbus_message_get_name),
5296 Document these functions.
5298 (dbus_message_append_int32), (dbus_message_append_uint32),
5299 (dbus_message_append_double), (dbus_message_append_string),
5300 (dbus_message_append_byte_array):
5301 * dbus/dbus-message.h:
5302 Add functions for adding message fields of different types.
5304 * dbus/dbus-protocol.h:
5305 Add the different types.
5307 2003-01-05 Havoc Pennington <hp@pobox.com>
5309 * bus/connection.c: implement routines for handling connections,
5310 first thing is keeping a list of owned services on each connection
5311 and setting up watches etc.
5313 * bus/services.c: implement a mapping from service names to lists
5316 * dbus/dbus-hash.c: add DBUS_HASH_POINTER
5318 * dbus/dbus-threads.c (dbus_static_mutex_lock): add functions
5319 to use static mutexes for global data
5321 * dbus/dbus-connection.c (dbus_connection_set_data): add new
5322 collection of functions to set/get application-specific data
5323 on the DBusConnection.
5325 2003-01-04 Havoc Pennington <hp@pobox.com>
5327 * dbus/dbus-sysdeps.c (_dbus_sleep_milliseconds): new function
5328 (_dbus_poll): new function
5330 * dbus/dbus-internals.h (_DBUS_STRUCT_OFFSET): new macro
5333 * bus/loop.c: initial code for the daemon main loop
5335 2003-01-04 Havoc Pennington <hp@pobox.com>
5337 * test/watch.c (error_handler): make it safe if the error handler
5338 is called multiple times (if we s/error handler/disconnect
5339 handler/ we should just guarantee it's called only once)
5341 * dbus/dbus-transport.c (_dbus_transport_disconnect): call the
5342 error handler on disconnect (it's quite possible we should
5343 just change the error handler to a "disconnect handler," I'm
5344 not sure we have any other meaningful errors)
5346 * configure.in: check for getpwnam_r
5348 * dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
5349 dbus/dbus-auth.c: add credentials support, add EXTERNAL auth
5350 mechanism as in SASL spec, using socket credentials
5352 * dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): new function
5353 (_dbus_send_credentials_unix_socket): new function
5355 * dbus/dbus-sysdeps.c (_dbus_accept_unix_socket): rename just
5357 (_dbus_write): only check errno if <0 returned
5358 (_dbus_write_two): ditto
5360 2003-01-02 Anders Carlsson <andersca@codefactory.se>
5362 * dbus/dbus-marshal.c: (_dbus_marshal_utf8_string),
5363 (_dbus_marshal_byte_array), (_dbus_demarshal_utf8_string),
5364 (_dbus_marshal_test):
5365 * dbus/dbus-marshal.h:
5366 Add _dbus_marshal_byte_array and rename _dbus_marshal_string
5367 to _dbus_marshal_utf8_string. Also fix some tests.
5369 2002-12-28 Harri Porten <porten@kde.org>
5371 * configure.in: added check for C++ compiler and a very cheesy
5372 check for the Qt integration
5374 * Makefile.am (SUBDIRS): compile qt subdir if support is enabled
5376 * qt/Makefile.am: added
5378 * qt/.cvsignore: added
5380 * qt/dbus-qthread.cc, qt/dbus-qthread.cpp: renamed former to
5381 latter, added #ifdef QT_THREAD_SUPPORT guard.
5383 * dbus/Makefile.am: added missing headers for make dist
5385 2002-12-28 Kristian Rietveld <kris@gtk.org>
5387 * dbus/Makefile.am: fixup export-symbols-regex.
5389 2002-12-27 Anders Carlsson <andersca@codefactory.se>
5391 * acinclude.m4: Add this file and put the
5392 PKG_CHECK_MODULE macro in it.
5394 2002-12-27 Anders Carlsson <andersca@codefactory.se>
5396 * dbus/dbus-marshal.c: (_dbus_marshal_string),
5397 (_dbus_demarshal_double), (_dbus_demarshal_int32),
5398 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
5399 (_dbus_marshal_test):
5400 Make the demarshalling routines align the pos argument.
5401 Add string marshalling tests and fix the obvious bugs
5404 2002-12-26 Havoc Pennington <hp@pobox.com>
5406 * dbus/dbus-auth.c: fixes fixes fixes
5408 * dbus/dbus-transport-unix.c: wire up support for
5409 encoding/decoding data on the wire
5411 * dbus/dbus-auth.c (_dbus_auth_encode_data)
5412 (_dbus_auth_decode_data): append to target string
5413 instead of nuking it.
5415 2002-12-26 Havoc Pennington <hp@pobox.com>
5417 * dbus/dbus-marshal.h (DBUS_COMPILER_BYTE_ORDER): #ifdef
5418 WORDS_BIGENDIAN then compiler byte order is DBUS_BIG_ENDIAN,
5421 * dbus/dbus-marshal.c: Add macros to do int swapping in-place and
5422 avoid swap_bytes() overhead (ignoring possible assembly stuff for
5423 now). Main point is because I wanted unpack_uint32 to implement
5425 (_dbus_verbose_bytes): new function
5427 * dbus/dbus-string.c (_dbus_string_validate_ascii): new function
5429 * dbus/dbus-message.c (_dbus_message_loader_get_is_corrupted): add
5430 mechanism to handle a corrupt message stream
5431 (_dbus_message_loader_new): fix preallocation to only prealloc,
5434 * dbus/dbus-string.c (_dbus_string_skip_blank): fix this function
5435 (_dbus_string_test): enhance tests for copy/move and fix the
5438 * dbus/dbus-transport-unix.c: Hold references in more places to
5439 avoid reentrancy problems
5441 * dbus/dbus-transport.c: ditto
5443 * dbus/dbus-connection.c (dbus_connection_dispatch_message): don't
5444 leak reference count in no-message case
5446 * test/watch.c (do_mainloop): handle adding/removing watches
5447 during iteration over the watches. Also, ref the connection/server
5448 stored on a watch, so we don't try to mangle a destroyed one.
5450 * dbus/dbus-transport-unix.c (do_authentication): perform
5453 * dbus/dbus-auth.c (get_state): add a state
5454 AUTHENTICATED_WITH_UNUSED_BYTES and return it if required
5455 (_dbus_auth_get_unused_bytes): append the unused bytes
5456 to the passed in string, rather than prepend
5458 * dbus/dbus-transport.c (_dbus_transport_init_base): create
5459 the auth conversation DBusAuth
5461 * dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd)
5462 (_dbus_transport_new_for_domain_socket): when creating a
5463 transport, pass in whether it's a client-side or server-side
5464 transport so we know which DBusAuth to create
5466 2002-12-03 Havoc Pennington <hp@pobox.com>
5468 * dbus/dbus-transport-unix.c (unix_finalize): finalize base
5469 _after_ finalizing the derived members
5470 (unix_connection_set): unref watch if we fail to add it
5472 * dbus/dbus-connection.c (dbus_connection_unref): delete the
5473 transport first, so that the connection owned by the
5474 transport will be valid as the transport finalizes.
5476 * dbus/dbus-transport-unix.c (unix_finalize): free the write_watch
5477 if necessary, and remove watches from the connection.
5479 * dbus/dbus-watch.c (_dbus_watch_list_free): improve a comment
5481 2002-12-26 Anders Carlsson <andersca@codefactory.se>
5483 * dbus/dbus-marshal.c: (_dbus_marshal_string),
5484 (_dbus_demarshal_double), (_dbus_demarshal_int32),
5485 (_dbus_demarshal_uint32), (_dbus_demarshal_string),
5486 (_dbus_marshal_test):
5487 * dbus/dbus-marshal.h:
5488 Add string marshal functions and have the demarshal functions
5489 return the new position.
5491 2002-12-25 Havoc Pennington <hp@pobox.com>
5493 * doc/dbus-sasl-profile.txt: docs on the authentication protocol,
5494 it is a simple protocol that just maps directly to SASL.
5496 * dbus/dbus-auth.h, dbus/dbus-auth.c: authentication protocol
5497 initial implementation, not actually used yet.
5499 * dbus/dbus-string.c (_dbus_string_find): new function
5500 (_dbus_string_equal): new function
5501 (_dbus_string_base64_encode): new function
5502 (_dbus_string_base64_decode): new function
5504 2002-12-25 Anders Carlsson <andersca@codefactory.se>
5507 * dbus/dbus-marshal.c: (swap_bytes), (_dbus_marshal_double),
5508 (_dbus_marshal_int32), (_dbus_marshal_uint32),
5509 (_dbus_demarshal_double), (_dbus_demarshal_int32),
5510 (_dbus_demarshal_uint32), (_dbus_marshal_test):
5511 * dbus/dbus-marshal.h:
5512 * dbus/dbus-protocol.h:
5513 * dbus/dbus-test.c: (main):
5515 Add un-optimized marshalling/demarshalling routines.
5517 2002-12-25 Harri Porten <porten@kde.org>
5519 * qt/dbus-qt.h: adjusted ctor and getter to KDE/Qt conventions
5521 2002-12-24 Zack Rusin <zack@kde.org>
5523 * qt/dbus-qthread.cc: adding - integrates QMutex into Dbus
5524 * qt/dbus-qt.h: skeleton with two sample implemenatation of the
5527 2002-12-24 Havoc Pennington <hp@pobox.com>
5529 * glib/dbus-gthread.c: fix include
5531 * glib/dbus-glib.h: rename DBusMessageHandler for now.
5532 I think glib API needs to change, though, as you don't
5533 want to use DBusMessageFunction, you want to use the
5534 DBusMessageHandler object. Probably
5535 dbus_connection_open_with_g_main_loop()
5536 and dbus_connection_setup_g_main_loop() or something like that
5537 (but think of better names...) that just create a connection
5538 that has watch/timeout functions etc. already set up.
5540 * dbus/dbus-connection.c
5541 (dbus_connection_send_message_with_reply): new function just to
5542 show how the message handler helps us deal with replies.
5544 * dbus/dbus-list.c (_dbus_list_remove_last): new function
5546 * dbus/dbus-string.c (_dbus_string_test): free a string that
5549 * dbus/dbus-hash.c: use memory pools for the hash entries
5550 (rebuild_table): be more paranoid about overflow, and
5551 shrink table when we can
5552 (_dbus_hash_test): reduce number of sprintfs and write
5553 valid C89. Add tests for case where we grow and then
5554 shrink the hash table.
5556 * dbus/dbus-mempool.h, dbus/dbus-mempool.c: memory pools
5558 * dbus/dbus-connection.c (dbus_connection_register_handler)
5559 (dbus_connection_unregister_handler): new functions
5561 * dbus/dbus-message.c (dbus_message_get_name): new
5563 * dbus/dbus-list.c: fix docs typo
5565 * dbus/dbus-message-handler.h, dbus/dbus-message-handler.c:
5566 an object representing a handler for messages.
5568 2002-12-16 Anders Carlsson <andersca@codefactory.se>
5571 * glib/dbus-gthread.c: (dbus_gthread_init):
5572 Don't use the gdbus prefix for public functions.
5574 2002-12-16 Anders Carlsson <andersca@codefactory.se>
5578 Add GLib checks and fixup .pc files
5582 * glib/dbus-gmain.c: (gdbus_connection_prepare),
5583 (gdbus_connection_check), (gdbus_connection_dispatch),
5584 (gdbus_add_connection_watch), (gdbus_remove_connection_watch),
5585 (dbus_connection_gsource_new):
5586 * glib/dbus-gthread.c: (dbus_gmutex_new), (dbus_gmutex_free),
5587 (dbus_gmutex_lock), (dbus_gmutex_unlock), (dbus_gthread_init):
5588 * glib/test-dbus-glib.c: (message_handler), (main):
5591 2002-12-15 Harri Porten <porten@kde.org>
5593 * autogen.sh: check for libtoolize before attempting to use it
5595 * dbus/dbus-transport-unix.c: include <sys/time.h> for timeval
5598 * .cvsignore: ignore more stamp files
5600 * dbus/dbus-watch.c (_dbus_watch_list_new): fixed doc error
5602 * test/Makefile.am: added -I$(top_srcdir) to be able to compile
5603 without make install.
5605 2002-12-15 Havoc Pennington <hp@pobox.com>
5607 * dbus/dbus-threads.c: add thread stubs that a higher library
5608 layer can fill in. e.g. the GLib wrapper might fill them in with
5609 GThread stuff. We still need to use this thread API to
5610 thread-safe-ize the library.
5612 2002-12-12 Havoc Pennington <hp@pobox.com>
5614 * dbus/dbus-transport-unix.c, dbus/dbus-server-unix.c: use the
5615 below new interfaces and include fewer system headers.
5617 * dbus/dbus-sysdeps.c (_dbus_read): new function
5618 (_dbus_write): new function
5619 (_dbus_write_two): new function
5620 (_dbus_connect_unix_socket): new function
5621 (_dbus_listen_unix_socket): new function
5623 * dbus/dbus-message-internal.h: change interfaces to use
5626 2002-12-11 Havoc Pennington <hp@pobox.com>
5628 * dbus/dbus-types.h: add dbus_unichar
5630 * dbus/dbus-internals.c (_dbus_verbose): use _dbus_getenv
5632 * dbus/dbus-connection.c (dbus_connection_send_message): return
5635 * dbus/dbus-transport.c: include dbus-watch.h
5637 * dbus/dbus-connection.c: include dbus-message-internal.h
5639 * HACKING: add file with coding guidelines stuff.
5641 * dbus/dbus-string.h, dbus/dbus-string.c: Encapsulate all string
5642 handling here, for security purposes (as in vsftpd). Not actually
5643 using this class yet.
5645 * dbus/dbus-sysdeps.h, dbus/dbus-sysdeps.c: Encapsulate all
5646 system/libc usage here, as in vsftpd, for ease of auditing (and
5647 should also simplify portability). Haven't actually moved all the
5648 system/libc usage into here yet.
5650 2002-11-25 Havoc Pennington <hp@pobox.com>
5652 * dbus/dbus-internals.c (_dbus_verbose): fix to not
5653 always print the first verbose message.
5655 2002-11-24 Havoc Pennington <hp@pobox.com>
5657 * test/echo-client.c, test/echo-server.c: cheesy test
5660 * configure.in (AC_CHECK_FUNCS): check for writev
5662 * dbus/dbus-message.c (_dbus_message_get_network_data): new
5665 * dbus/dbus-list.c (_dbus_list_foreach): new function
5667 * dbus/dbus-internals.c (_dbus_verbose): new function
5669 * dbus/dbus-server.c, dbus/dbus-server.h: public object
5670 representing a server that listens for connections.
5672 * dbus/.cvsignore: create
5674 * dbus/dbus-errors.h, dbus/dbus-errors.c:
5675 public API for reporting errors
5677 * dbus/dbus-connection.h, dbus/dbus-connection.c:
5678 public object representing a connection that
5679 sends/receives messages. (Same object used for
5680 both client and server.)
5682 * dbus/dbus-transport.h, dbus/dbus-transport.c:
5683 Basic abstraction for different kinds of stream
5684 that we might read/write messages from.
5686 2002-11-23 Havoc Pennington <hp@pobox.com>
5688 * dbus/dbus-internals.h (_DBUS_INT_MAX): add _DBUS_INT_MIN
5691 * dbus/dbus-test.c (main): add list test, and include
5692 dbus-test.h as intended
5694 * dbus/dbus-hash.c (_dbus_hash_table_remove_string)
5695 (_dbus_hash_table_remove_int): return value indicates
5696 whether the entry existed to remove
5698 * dbus/dbus-list.c: add linked list utility class,
5701 * dbus/dbus-hash.c: add TODO item about shrinking the hash bucket
5704 2002-11-23 Havoc Pennington <hp@pobox.com>
5706 * Doxyfile.in (INCLUDE_FILE_PATTERNS): expand DBUS_BEGIN_DECLS/
5707 DBUS_END_DECLS to nothing, that should fix this once and for all
5709 * Doxyfile.in (JAVADOC_AUTOBRIEF): set to YES
5711 * dbus/dbus-message.c, dbus/dbus-hash.c:
5712 add some missing @brief
5714 2002-11-23 Havoc Pennington <hp@pobox.com>
5716 * dbus/dbus-message.h: put semicolons after DEBUG_BEGIN_DECLS
5717 to avoid confusing Doxygen
5719 * dbus/dbus-hash.c: @} not }@
5721 * dbus/dbus-message.c (struct DBusMessage): split out
5724 2002-11-23 Havoc Pennington <hp@pobox.com>
5726 * configure.in: pile on more warning flags if using gcc
5728 * Doxyfile.in (EXTRACT_STATIC): set to NO, so we don't have
5729 to document static functions
5731 * configure.in: add summary to end of configure so it
5732 looks nice and attractive
5734 * dbus/dbus-hash.c: finish implementation and write unit
5737 * configure.in: add --enable-tests to enable unit tests
5739 * dbus/dbus-test.c: test program to run unit tests
5740 for all files in dbus/*, initially runs a test for
5743 * dbus/dbus-internals.h: file to hold some internal utility stuff
5745 2002-11-22 Havoc Pennington <hp@redhat.com>
5747 * dbus/dbus-hash.c: copy in Tcl hash table, not yet
5748 "ported" away from Tcl
5750 * dbus/dbus-types.h: header for types such as dbus_bool_t
5752 2002-11-22 Havoc Pennington <hp@redhat.com>
5754 * dbus/dbus.h: fixups for doc warnings
5756 * Doxyfile.in (FILE_PATTERNS): we need to scan .h to pick up
5758 (QUIET): make it quiet so we can see warnings
5760 * dbus/dbus-memory.c: teach D-BUS to allocate and free memory
5762 2002-11-22 Havoc Pennington <hp@redhat.com>
5764 * Makefile.am: include "Doxyfile" target in all-local
5766 * configure.in: generate the Doxyfile
5768 * Doxyfile.in: move Doxyfile here, so we can use
5769 configure to generate a Doxyfile with the right
5772 2002-11-22 Havoc Pennington <hp@redhat.com>
5774 * dbus/dbus-message.c: move inline docs into .c file
5776 * Doxyfile (OUTPUT_DIRECTORY): move output to doc/api
5777 so all docs are under doc/
5778 (MAN_EXTENSION): generate man pages. Use extension
5779 ".3dbus" which matches ".3qt" on my system,
5780 I guess this is OK, I don't know really.
5781 (FILE_PATTERNS): look for .c files not .h, makes sense
5784 2002-11-22 Havoc Pennington <hp@pobox.com>
5786 * Makefile.am (SUBDIRS): rename subdir "server" to "bus"
5787 because any app can be a server, and any app can be a client,
5788 the bus is a special kind of server.
5790 Thu Nov 21 23:35:31 2002 Zack Rusin <zack@kde.org>
5792 * Doxyfile : adding. Still needs Makefile rules to be generated
5793 automatically (just run "doxygen" in the toplevel dir for now to
5796 * dbus/dbus-message.h : Adding sample docs (javadoc since
5797 resembles gtk-doc a little more)
5799 * dbus/dbus.h : Adding sample docs
5801 2002-11-21 Havoc Pennington <hp@redhat.com>
5803 * dbus/Makefile.am (INCLUDES): define DBUS_COMPILATION
5804 so we can allow ourselves to include files directly,
5805 instead of having to use dbus.h
5807 * dbus/dbus.h: fill in
5809 * dbus/dbus-message.h: sketch out a sample header file.
5810 Include griping if you include it directly instead of
5813 * dbus/dbus-macros.h: new file with macros for extern "C",
5814 TRUE/FALSE, NULL, etc.
5816 * doc/file-boilerplate.c: put include guards in here
5818 2002-11-21 Havoc Pennington <hp@redhat.com>
5820 * doc/file-boilerplate.c: include both AFL and GPL boilerplate.
5822 * COPYING: include the GPL as well, and license code
5823 under both AFL and GPL.
5825 2002-11-21 Havoc Pennington <hp@redhat.com>
5827 * acconfig.h: get rid of this
5829 * autogen.sh (run_configure): add --no-configure option
5831 * configure.in: remove AC_ARG_PROGRAM to make
5832 autoconf complain less. add AC_PREREQ.
5833 add AC_DEFINE third arg.
5835 2002-11-21 Anders Carlsson <andersca@codefactory.se>
5838 Fix references so we can distcheck.
5840 2002-11-21 Havoc Pennington <hp@redhat.com>
5842 * Initial module creation