1 2006-06-26 Jim Meyering <jim@meyering.net>
3 * NEWS: rm no longer fails to remove an empty, unreadable directory
4 * src/remove.c (remove_cwd_entries): If we can't open a directory,
5 and the failure is not being ignored, try to remove the directory
6 with rmdir (aka unlinkat-with-AT_REMOVEDIR), in case it's empty.
7 Problem report and test case from Paul Eggert in
8 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7425>.
9 * tests/rm/empty-inacc: New test, for the above.
11 Avoid a segfault for wc --files0=- < /dev/null.
12 * src/wc.c (compute_number_width): Return right away if nfiles == 0.
14 2006-06-25 Jim Meyering <jim@meyering.net>
16 * NEWS: wc accepts a new option --files0-from=FILE, where FILE
17 contains a list of NUL-separated file names.
19 * src/wc.c: Include "readtokens.h".
20 (usage): Describe the new option, and adjust the `Usage':
21 with this option, no FILE may be specified on the command line.
22 (main): Handle the new option.
23 * tests/misc/wc-files0: New tests, for the above.
24 * tests/misc/wc-files0-from: Likewise.
25 * tests/misc/Makefile.am (TESTS): Add wc-files0.
27 2006-06-24 Jim Meyering <jim@meyering.net>
29 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
31 2006-06-22 Jim Meyering <jim@meyering.net>
33 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
34 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
36 2006-06-19 Jim Meyering <jim@meyering.net>
38 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
39 so this check is not run as part of "make distcheck".
41 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
43 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
45 2006-06-18 Jim Meyering <jim@meyering.net>
47 * tests/misc/pwd-long: Make error output a little clearer.
49 2006-06-17 Jim Meyering <jim@meyering.net>
51 * tests/rm/inaccessible: Skip this test on systems without openat
52 support. Reported by Bob Proulx.
54 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
56 * tests/misc/mknod: Improve permission checks to handle
57 running mkdir test in set-gid directories.
59 2006-06-14 Jim Meyering <jim@meyering.net>
61 * tests/du/basic: Revamp not to hard-code file system block sizes.
63 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
65 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
68 2006-06-11 Jim Meyering <jim@meyering.net>
70 * .gitignore: New file.
71 * Makefile.am (EXTRA_DIST): Add .gitignore.
73 Setting TIME_STYLE=long-iso in the environment would make the
74 cp/same-file test fail.
75 * tests/envvar-check (vars): Add TIME_STYLE to the list.
76 * tests/cp/same-file: Revert last change.
77 Source the envvar-check script, to ensure that TIME_STYLE
78 settings don't affect these tests.
80 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
82 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
83 uses POSIX time stamp formats. Problem reported by John Nixon in
84 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
86 2006-06-10 Jim Meyering <jim@meyering.net>
88 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
90 Require a "Version N.M" line at the top of the ChangeLog
91 file only when making the actual release, not when running
93 * Makefile.maint (maintainer-distcheck): Don't depend on
95 (alpha beta major): Depend on it here, instead.
97 2006-06-08 Jim Meyering <jim@meyering.net>
99 Ensure that cat works with any of the options, -A -v -e -E -T,
100 when applied to files in /proc and /sys, even when the FIONREAD
101 ioctl produces nonsensical results. Before this change, cat would
102 produce no output (or truncated output), for some linux kernels.
104 * src/cat.c (write_pending): New function, factored out of cat.
105 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
106 that there are bytes to read. Some versions of linux-2.6.16 do that.
107 Write any pending output before returning.
108 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
109 * NEWS: Mention this bug fix.
110 * tests/misc/cat-proc: New file. Test for the above.
111 * tests/misc/Makefile.am (TESTS): Add cat-proc.
113 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
115 * src/expr.c (eval4): Detect overflow properly when multiplying
118 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
120 * NEWS: The 'expr' command now detects and reports integer overflow.
121 (It would be better to use extended precision instead, but that
123 * src/expr.c (integer_overflow): New function.
124 (eval4, eval3): Check for integer overflow.
126 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
128 Fix problems when building with Solaris/SVR4/etc. make, which uses a
129 different and somewhat bogus implementation of VPATH. In the
130 directory tests/misc, rename tests whose names might appear in the
131 Automake-generated rules. For example, we can't use a test named
132 'test', since Automake generates a rule that contains the text
133 "if test -f ./$$tst; ...", and this might expand to something like
134 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
135 which executes the 'test' script rather than the 'test' command.
136 * tests/misc/false-status: Renamed from tests/misc/false.
137 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
138 * tests/misc/sort-merge: Renamed from tests/misc/sort.
139 ($prog): Set to 'sort' rather than to $PROG.
140 * tests/misc/test-diag: Renamed from tests/misc/test.
141 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
142 in case Solaris make has prepended the directory.
143 (TESTS): Adjust to above renamings.
144 * tests/misc/expand: Don't assign to PROG; no longer needed
145 now that Makefile.am sets PROG to the basename.
146 * tests/misc/fold: Likewise.
148 2006-06-03 Jim Meyering <jim@meyering.net>
150 Make `cp --link --no-dereference' work also on systems where the
151 link system call cannot create a hard link to a symbolic link.
152 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
153 the link syscall on a symlink when it would do the wrong thing.
154 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
155 * tests/cp/link-no-deref: New file/test for the above.
156 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
157 * NEWS: Mention the change (doesn't affect Linux).
159 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
161 Fix some porting problems in the test cases reported by
162 Ralf Wildenhues for HP-UX 11.23 in:
163 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
164 * tests/help-version: Don't assume that \< \> works in sed.
165 * tests/misc/close-stdout: Don't assume that >&- works.
166 Add a /dev/full test.
167 * tests/touch/no-create-missing: Don't assume that >&- works.
169 2006-05-30 Jim Meyering <jim@meyering.net>
171 * src/ls.c (usage): Add `v' to the list of sorting-related options.
174 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
176 * tests/cp/fail-perm: source lang-default.
177 * tests/rm/inaccessible: Likewise.
179 2006-05-28 Jim Meyering <jim@meyering.net>
181 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
182 Recognize it, too. Reported by Ralf Wildenhues, in
183 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
185 2006-05-27 Jim Meyering <jim@meyering.net>
187 * src/chgrp.c: Support new options: --preserve-root and
188 --no-preserve-root. Somehow this program was skipped when those
189 options were added to chown, chmod, and rm. Reported by
190 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
191 * NEWS: Mention this.
193 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
195 * NEWS: Remove mention of --seed. We'll replace it with something
196 better, and don't want to indicate that it is supported.
197 * src/sort.c (usage): Likewise.
199 2006-05-20 Jim Meyering <jim@meyering.net>
201 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
203 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
204 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
205 FTS_COMFOLLOW. Spotted by Justin Pryzby.
207 * gnupload: Merge changes from automake, retaining the ""--to...
208 kludge to placate overzealous `make distcheck' check.
210 2006-05-19 Jim Meyering <jim@meyering.net>
212 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
213 FTS_TIGHT_CYCLE_CHECK directory traversal option.
214 Reported by Justin Pryzby in http://bugs.debian.org/367691
216 2006-05-15 Jim Meyering <jim@meyering.net>
218 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
221 2006-05-13 Jim Meyering <jim@meyering.net>
223 * tests/mv/no-target-dir: Test two more cases.
225 2006-05-11 Jim Meyering <jim@meyering.net>
227 mv -T DIR EMPTY_DIR no longer fails unconditionally
228 * src/copy.c (copy_internal): Don't manually prohibit a move where
229 the destination is an existing directory. Sometimes doing that is
230 valid. Let the rename system call enforce the rules. That is
231 allowed only when the source is a directory and the destination
232 directory (to be replaced) is empty. Reported by Eric Blake.
233 * tests/mv/no-target-dir: New file/test for this.
234 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
235 * NEWS: Mention this.
237 * tests/mv/atomic: New file/test for yesterday's fix.
238 * tests/mv/Makefile.am (TESTS): Add atomic.
240 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
242 2006-05-10 Jim Meyering <jim@meyering.net>
244 * src/copy.c (copy_internal): Don't explicitly unlink the destination
245 when moving a symlink into the place of an existing non-directory.
246 Reported by Joshua Hudson.
247 * NEWS: mention this.
249 2006-05-07 Jim Meyering <jim@meyering.net>
251 * Makefile.maint (patch-check): Fail if patch generates any output,
252 even merely for changed offsets.
254 * src/c99-to-c89.diff: Adjust to reflect new offsets.
256 * NEWS: Mention changes affecting df, pwd, shred.
258 2006-05-06 Jim Meyering <jim@meyering.net>
260 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
261 system condition where dirent.d_ino != stat.st_ino.
262 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
264 2006-05-06 Eric Blake <ebb9@byu.net>
266 * tests/ls/inode: Expand to test inode from readdir case.
267 * tests/ls/follow-slink: Expand to test broken links encountered
268 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
270 2006-05-06 Eric Blake <ebb9@byu.net>
272 * tests/mv/leak-fd: Work even on case-insensitive file system.
274 2006-05-04 Jim Meyering <jim@meyering.net>
276 * NEWS: Mention the 2006-03-19 pwd-related change that makes
277 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
279 2006-05-03 Jim Meyering <jim@meyering.net>
281 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
282 Use better macro parameter names: s/basename/key_name/,
283 s/basefunc/key_cmp_func. Fix typo in comment.
285 2006-04-29 Eric Blake <ebb9@byu.net>
287 * src/ls.c (main): On systems with d_type, directories_first only
288 implies format_needs_type, not format_needs_stat.
290 2006-05-03 Jim Meyering <jim@meyering.net>
292 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
293 after comma in arg list, from Eric Blake.
295 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
297 * tests/misc/date (relative-3): New test, derived from a bug
298 report by John Thomas McDole.
300 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
302 New option for ls: --group-directories-first.
303 It makes ls list directories before files.
304 * NEWS [New features]: Mention it.
305 * src/ls.c (sort_type): Rearrange to use as an array index when
306 choosing sort function; added new sort_numtypes member for
308 (time_type): Add new time_numtypes member for compile-time check.
309 (directories_first): New global variable.
310 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
311 (long_options): Add --directories-first.
312 (main): Support new option.
313 (is_directory): New function.
314 (extract_dirs_from_files): Use it.
315 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
316 (LIST_SORTFUNCTION_VARIANTS): New macros.
317 (sort_functions): New global variable.
318 (sort_files): Use it.
319 (usage): Document new option.
321 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
323 * src/shred.c (fillrand): The assertion was way too weak, due to
324 what must be a typo. Strengthen it to its intended value.
325 (dopass): Don't use alloca; it's not worth the aggravation here,
326 since it's used only to get a page-aligned buffer, and page
327 alignment doesn't buy us much here. I'm suspicious that alloca
328 causes problems on some hosts, due to a recent bug report by Adam
329 Waltman: http://bugs.gentoo.org/130246.
331 2006-04-18 Jim Meyering <jim@meyering.net>
333 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
334 sha384sum, sha512sum.
336 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
338 * src/chmod.c (describe_change): Adjust to filemode changes.
339 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
340 (print_long_format): Use (new) filemodestring rather than
341 (old) mode_string, so that we get more file types right, at least
342 in theory. Adjust to filemode changes.
343 * src/stat.c (human_access): Likewise.
345 2006-04-18 Jim Meyering <jim@meyering.net>
347 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
348 ignore file. This has never been enabled. Reported by Eric Blake.
350 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
352 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
353 bug in Interix. Just call symlink or link directly. All uses changed.
354 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
355 * src/stat.c (USE_STATVFS): New macro.
356 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
357 (NAMEMAX_FORMAT): define a bit more clearly, now that the
358 statvfs-using code is a bit more regular.
359 * src/system.h (sync) [!HAVE_SYNC]: New macro.
361 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
363 * NEWS: csplit, nl, expr now conform to POSIX better, and are
364 more-compatible with traditional Unix, with respect to regular
366 * src/csplit.c (extract_regexp): Set re_syntax_options to a
367 value that is compatible with what POSIX requires.
368 * src/nl.c (build_type_arg): Likewise.
369 * src/expr.c (docolon): Likewise. Also, don't let anchors match
370 newline; this fixes an incompatibility with tradition and with POSIX.
371 Don't warn about leading ^. POSIX says it is unspecified whether
372 ^ is a special character, which means that implementations can
373 either treat it as special or not, but either way a warning is not
374 allowed (unless the regexp is otherwise invalid). Instead, anchor
375 the expression but treat ^ as an anchor; this is the traditional
376 behavior (e.g., Solaris 10).
377 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
378 and the like as invalid expressions (exit status 2), not as
379 failure of 'expr' (exit status 3). This is more consistent with
381 * tests/expr/basic (fail-a): Adjust exit status to match new expr
382 behavior, for status 2 versus 3.
384 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
385 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
386 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
387 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
388 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
389 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
390 (bre61, bre62): New tests.
391 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
395 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
396 "if !". Do not assume that 'sed' can handle long, newline-free input.
397 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
399 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
401 Adjust to new regex.h API (with new fastmap type), and clean
402 up the regex storage allocation a bit.
404 * src/csplit.c (struct control): Put re_compiled member at the
405 end, since it's large. Change regexpr member from char * to bool;
406 all uses changed. Add new member fastmap.
407 (extract_regexp): regexp arg is now char const *, not char *.
408 Don't bother duplicating the regular expression; it's not needed.
409 Set fastmap from new fastmap member. Don't bother allocating
410 a buffer, as the regexp code does a better job than we do.
411 * src/expr.c (docolon): Allocate and use a fastmap.
412 Don't bother allocating a buffer.
413 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
415 (build_type_arg): New fastmap arg. All uses changed.
416 Don't bother allocating a buffer, but set a fastmap.
417 * src/ptx.c (context_regex_string, word_regex_string): Remove.
418 (context_regex, word_regex): New vars, replacing the above.
420 (struct regex_data): New type.
421 (compile_regex): Renamed from alloc_and_compile_regex, since
422 we no longer allocate storage. Arg is now a struct regex_data *,
423 not a const char *. All uses changed. Don't allocate the fastmap;
424 instead, take it from the caller. Don't convert size_t to int,
425 to avoid arithmetic overflow problems. Don't bother freeing
426 storage afterwards; it's not worth the aggravation.
427 * src/tac.c (compiled_separator_fastmap): New ver.
428 (main): Use it. Don't bother allocating a buffer.
430 2006-03-30 Jim Meyering <jim@meyering.net>
432 * src/dd.c (iwrite): Remove assignment without effect.
433 Reported by Felix Rauch Valenti.
435 2006-03-22 Eric Blake <ebb9@byu.net>
437 * src/ptx.c (usage): Remove mention of --copyright/-C.
438 (main): Alias --copyright to --version plus a deprecation warning.
439 * NEWS: Mention this.
441 2006-03-27 Jim Meyering <jim@meyering.net>
443 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
444 use of strtod. Tiny patch from Nickolai Zeldovich.
446 2006-03-11 Eric Blake <ebb9@byu.net>
448 * tests/misc/dirname: New file.
449 * tests/basename/Makefile.am: Delete.
450 * tests/basename/basic: Move to...
451 * tests/misc/basename: ... this new file. Add some tests,
452 including fixed behavior for //.
453 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
454 * tests/Makefile.am (SUBDIRS): Remove basename.
455 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
457 Improvements to dirname/basename handling on platforms like
458 cygwin with distinct // and with drive letters.
459 * NEWS: Document new behavior.
460 * src/basename.c (main): Don't strip suffix from file system
462 * src/cp.c (target_directory_operand): Use new last_component.
463 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
464 traversing the string.
465 * src/dircolors.c (guess_shell_syntax): Use new last_component.
466 * src/install.c (target_directory_operand, install_file_in_dir):
468 * src/ln.c (target_directory_operand, main): Likewise.
469 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
470 * src/mv.c (target_directory_operand, movefile): Likewise.
471 * src/remove.c (rm_1): Likewise.
472 * src/shred.c (wipename): Likewise.
473 * src/split.c (next_file_name): Likewise.
474 * src/su.c (log_su, run_shell): Likewise.
476 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
478 * NEWS: nohup diagnostics are now more precise, and nohup now
479 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
480 * src/nohup.c (main): Implement this.
481 * tests/misc/nohup: Test the new behavior.
483 2006-03-12 Jim Meyering <jim@meyering.net>
485 * src/copy.c (set_author): Rename function, from preserve_author.
487 * src/remove.c (AD_pop_and_chdir): Use new macro,
488 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
490 * src/system.h (SAME_INODE): Remove definition.
491 Include "same-inode.h", instead.
493 2006-03-11 Eric Blake <ebb9@byu.net>
495 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
497 2006-03-10 Jim Meyering <jim@meyering.net>
499 Fix a bug whereby a user with write access to a directory being removed
500 could cause the removal of that directory to fail with an erroneous
501 diagnostic about a directory cycle. Reported by Vineet Chadha.
503 * NEWS: Mention this.
504 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
505 leave (and try to rmdir) is the one whose dev_ino is being used to
506 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
508 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
510 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
511 * src/dd.c (set_fd_flags): Handle file-creation flags on file
512 descriptors, rather than ignoring them.
513 * tests/dd/misc: Add test cases for append, nofollow, directory,
514 and nolinks flags. Simplify redirection to /dev/null in some cases.
516 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
517 noatime test never tested anything.
519 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
521 * src/dd.c (flags, usage): New flags directory, nolinks.
522 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
524 * src/ls.c (usage): Mention that -f disables --color.
525 Problem reported by Niels Möller.
527 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
529 * man/*.x: Add references to syscalls from utilities of the same name.
531 2006-03-05 Jim Meyering <jim@meyering.net>
533 * tests/help-version: Set SHELL, if not already set, in order to
534 avoid failure when `make check' is run through debuild; dircolors
535 would fail due to lack of $SHELL. Reported by Sven Joachim.
537 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
538 * src/base64.c (wrap_write, do_encode, main): Change type of
539 parameters and locals, wrap_column, form size_t to uintmax_t.
540 (main): Adjust to use xstrtoumax, accordingly.
542 2006-03-03 Jim Meyering <jim@meyering.net>
544 Don't fail when run from an environment with SHELL not a Bourne
545 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
546 * tests/dircolors/simple: Invoke each non-failing test with -b.
547 Reported by Michael Stone.
549 2006-02-27 Jim Meyering <jim@meyering.net>
551 * tests/misc/base64: Derive --decode-using tests from the
554 * tests/misc/base64: Factor out a long constant string.
555 Split lines to stay within 80 columns.
557 * tests/misc/Makefile.am (TESTS): Add base64.
558 * tests/misc/base64: Test base64. From Simon Josefsson.
560 * src/base64.c (do_decode): Use correct type for parameter,
561 ignore_garbage: s/size_t/bool/.
563 * src/base64.c: Don't include .h files already included by system.h:
564 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
565 Include "system.h" before the other lib/*.h header files.
566 Include <sys/types.h> before "system.h".
567 (wrap_write): Remove declaration of unused local, initial_column.
568 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
570 * README: Add base64 to the list.
572 2006-02-17 Simon Josefsson <jas@extundo.com>
575 * AUTHORS: Mention base64.
577 * man/Makefile.am: Build base64.1.
578 * man/base64.x: New file.
579 * src/Makefile.am (bin_PROGRAMS): Add base64.
580 * src/base64.c: New file.
582 2006-02-25 Eric Blake <ebb9@byu.net>
584 In ls, avoid calling stat for --inode (-i), when possible.
585 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
586 * src/system.h: ... here, for use in ...
587 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
589 (gobble_file): Add inode argument.
590 (print_dir): Pass inode if available.
591 (usage): Remove inaccuracy.
593 2006-02-23 Jim Meyering <jim@meyering.net>
595 * TODO: Update/correct some obsolete entries.
597 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
599 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
600 * src/join.c (usage): Likewise.
601 Documentation problem reported by Philip Kensche.
603 2006-02-20 Eric Blake <ebb9@byu.net>
605 * man/rm.x: Update documentation to match previous patch.
607 2006-02-18 Eric Blake <ebb9@byu.net>
609 New option for rm: --interactive=once (-I).
610 * NEWS: Document it, along with change to rm --interactive.
611 * TODO: Remove entry for implementing rm -I
612 * src/rm.c (INTERACTIVE_OPTION): New enum value.
613 (interactive_type): New enum.
614 (long_opts): Let interactive take an optional argument.
615 (interactive_args, interactive_types): New option arguments.
616 (usage): Document -I, --interactive=WHEN. Use program_name
617 instead of a basename.
618 (main): New -I option, new behavior to --interactive.
619 * tests/rm/interactive-once: New tests.
620 * tests/rm/interactive-always: Ditto.
621 * tests/rm/Makefile.am (TESTS): Run them.
623 2006-02-18 Jim Meyering <jim@meyering.net>
625 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
626 expression match more of the target lines, e.g., those that start with
627 `-S,' (short option followed by a comma) or that include `=[...]'.
628 Patch by Nicolas François.
629 Fix the four offenders thus exposed:
630 * src/join.c (usage): Use two spaces (not one) to separate the
631 --first-only option string from its description, so help2man formats
632 the derived man page properly.
633 * src/pr.c (usage): Likewise.
634 * src/uniq.c (usage): Likewise.
635 * src/install.c (usage): Likewise.
637 2006-02-15 Jim Meyering <jim@meyering.net>
639 * Makefile.maint (alpha beta major): For `make major', ensure that the
640 version string is of the form N.N[.N]*, where N is one or more digits.
642 2006-02-14 Jim Meyering <jim@meyering.net>
644 * INSTALL: Update from gnulib.
646 2006-02-13 Jim Meyering <jim@meyering.net>
648 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
650 2006-02-12 Jim Meyering <jim@meyering.net>
652 * Makefile.maint (patch-check): New target.
653 (local-checks-available): Add to the list.
655 2006-02-11 Jim Meyering <jim@meyering.net>
657 * src/c99-to-c89.diff: New file.
658 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
660 * .x-po-check: New file, with exclusions so that `make distcheck'
662 * Makefile.am (EXTRA_DIST): Add .x-po-check.
664 rm -r must remove an empty directory, even if it is inaccessible.
665 * src/remove.c (close_preserve_errno): New function.
666 (fd_to_subdirp): Don't print a diagnostic in this function.
667 Do it from the callers instead, unless rmdir succeeds.
668 (remove_cwd_entries, remove_dir): Adjust callers.
669 * tests/rm/empty-inacc: New test for the above.
670 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
671 * NEWS: Mention this bug fix.
672 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
673 a tiny bit less precise: cannot remove `a/1': ... instead of
674 cannot open directory `a/1': ...
676 * Makefile.maint (syntax-check-rules): Automatically derive this
677 list of sc_-prefixed rule names.
679 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
681 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
682 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
683 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
684 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
685 go away? was that an accident?)
686 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
687 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
688 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
689 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
690 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
691 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
692 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
693 (author_mark_check, makefile_path_separator_check):
694 Output line numbers, to simplify navigation of Emacs *compilation*
696 (sc_prohibit_atoi_atof, sc_file_system):
697 Rework slightly so that Makefile.maint doesn't get reported as a
698 violation of its own syntax rules.
699 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
700 it at run-time (which didn't work with Bison). Fix a makefile typo,
701 caught by Makefile.maint itself: spaces where a tab should be.
702 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
703 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
704 Ignore djgpp and man subdirectories, to avoid false matches with
705 Bison and coreutils, respectively. Use sort -u to remove the
706 resulting duplicates.
707 * gnupload: Rework slightly to avoid bogus warning from
708 sc_two_space_separator_in_usage.
710 2006-02-10 Jim Meyering <jim@meyering.net>
712 Use gzip's --rsyncable option only if it's available.
713 * Makefile.maint (gzip_rsyncable): New variable.
716 2006-02-08 Jim Meyering <jim@meyering.net>
718 * Makefile.maint (local-checks-available): Define in terms of
719 the expansion, $(syntax-check-rules), rather than the single,
720 top-level target `syntax-check', so that it's easier to exclude
721 individual rules (via $(local-checks-to-skip)).
722 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
724 2006-02-07 Jim Meyering <jim@meyering.net>
726 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
727 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
729 * tests/help-version (expected_failure_status_vdir):
730 Redirect an expected disk-full diagnostic to /dev/null.
732 2006-02-06 Jim Meyering <jim@meyering.net>
734 * src/unexpand.c (usage): Use two spaces (not one) to separate the
735 --first-only option string from its description, so help2man formats
736 the derived man page properly.
737 * src/rm.c (usage): Likewise for --no-preserve-root.
738 * src/chown.c (usage): Likewise.
739 * src/chgrp.c (usage): Likewise.
741 Add a rule to ensure that the above doesn't happen again.
742 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
743 (syntax-check-rules): Add it.
744 * .x-sc_two_space_separator_in_usage: New empty file.
745 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
747 2006-02-06 Jim Meyering <jim@meyering.net>
749 * src/cp.c (usage): Use two spaces (not one) to separate each
750 option string from its description, so help2man formats the
751 derived man page properly.
752 * src/mv.c (usage): Likewise.
753 Patch from Nicolas François in http://bugs.debian.org/351601.
755 2006-02-04 Jim Meyering <jim@meyering.net>
757 * src/copy.c (copy_internal): cp -RL would fail when encountering
758 the same directory more than once in the hierarchy beneath a single
759 command-line argument. That is legitimate, e.g. when there are
760 two or more symbolic links, each pointing to some directory that
761 would not otherwise be copied. Reported by Christophe LYON.
762 * tests/cp/cp-deref: New file. Test for today's fix.
763 * tests/cp/Makefile.am (TESTS): Add cp-deref.
764 * NEWS: Document this.
766 2006-02-03 Jim Meyering <jim@meyering.net>
768 * configure.ac: Require automake-1.9.6, not 1.8.3.
770 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
772 * src/od.c (usage): Mention that -t a ignores high order bit.
773 Documentation problem reported by Ed Avis.
775 2006-02-01 Jim Meyering <jim@meyering.net>
777 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
779 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
781 * src/head.c (main): Use a better diagnostic when someone uses a
782 trailing numeric option in an invalid way. Problem reported by
784 * src/tail.c (parse_options): Likewise.
786 2006-01-30 Jim Meyering <jim@meyering.net>
788 * man/wc.x: Include `count' keyword in man page synopsis,
789 per suggestion from http://bugs.debian.org/181585.
791 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
793 * src/df.c (show_dev): If the file system claims to have
794 more available than total blocks, report the number of used
795 blocks as being total - available (a negative number) rather
796 than as garbage. Problem reported by Toralf Foerster.
798 2006-01-24 Jim Meyering <jim@meyering.net>
800 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
801 to put a regular file in O_NONBLOCK mode fails with EPERM.
802 That happens on Linux (up to 2.6.15) when using tail -f on a file with
803 the append-only attribute. Reported by Dean Gaudet. For details,
804 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
805 * NEWS: Mention this fix.
806 * tests/tail-2/append-only: New file. Test for the above.
807 * tests/tail-2/Makefile.am (TESTS): Add append-only.
808 * tests/Makefile.am (check-root): Add tail-2/append-only
810 2006-01-21 Jim Meyering <jim@meyering.net>
812 * NEWS: Mention fts-related improvements and bug fixes.
814 2006-01-19 Jim Meyering <jim@meyering.net>
816 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
817 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
819 2006-01-18 Jim Meyering <jim@meyering.net>
821 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
823 2006-01-17 Jim Meyering <jim@meyering.net>
825 Now that fts no longer changes the current working directory, adjust
826 its clients accordingly -- note that du.c uses fts but doesn't need
827 any adjustment, since it doesn't operate on the actual files,
828 but rather just uses the stat buffers provided by fts.
830 * src/chown-core.c: Include "openat.h".
831 Don't include "lchown.h".
832 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
833 calling openat, lchownat, chownat, rather than open, lchown, chown.
835 * src/chmod.c: Include "openat.h".
836 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
838 * tests/du/long-from-unreadable: New test, to exercise one small
841 2006-01-13 Jim Meyering <jim@meyering.net>
843 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
844 addition of new directories under tests/.
846 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
849 2006-01-12 Jim Meyering <jim@meyering.net>
851 * tests/du/long-sloop: Adjust not to hard-code the expected
852 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
853 from that of GNU libc. Reported by Paul Eggert.
855 * tests/du/long-sloop: Create file at end of symlink chain.
857 * tests/misc/test: New file, with a test for one of the
858 bugs fixed by yesterday's test.c changes.
859 * tests/misc/Makefile.am (TESTS): Add test.
861 2006-01-11 Jim Meyering <jim@meyering.net>
863 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
864 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
865 a very long sequence of symbolic links (not necessarily a loop).
866 * tests/du/Makefile.am (TESTS): Add long-sloop.
868 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
870 * src/test.c (test_syntax_error): Append a newline. All callers
871 changed, except for the ones that didn't already append a newline.
872 Bug reported by Eric Blake.
874 2006-01-11 Jim Meyering <jim@meyering.net>
876 * src/system.h (X2NREALLOC): Now that verify_true is no longer
877 void, cast its result to void, to avoid gcc's warning that
878 ``left-hand operand of comma expression has no effect''.
879 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
881 2006-01-10 Jim Meyering <jim@meyering.net>
883 * tests/chmod/no-x: Add a test for today's fts.c fix.
885 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
887 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
888 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
890 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
892 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
893 Use verify_true instead of verify_expr, to sync with gnulib.
895 2006-01-08 Jim Meyering <jim@meyering.net>
897 * src/date.c (usage): Adjust the formatting of the entries for
898 %::z and %:::z (separate with two spaces, not one) so that help2man
899 formats them properly. Reported by Philip Rowlands.
901 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
903 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
905 2006-01-06 Jim Meyering <jim@meyering.net>
907 * Makefile.maint (copyright-check): Use date +%Y in place of
910 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
911 First off, the attribute should have been `volatile' (not static)
912 to avoid longjmp-related risk of clobber. Secondly, now there is
913 no longer any risk of a local variable being clobbered, so there's
914 no need for any attribute at all.
916 2006-01-05 Jim Meyering <jim@meyering.net>
918 * src/remove.c: Give a few functions the inline attribute.
919 (AD_pop_and_chdir): Use gotos to avoid some duplication.
920 (AD_push): Rewrite an assertion so that the entire computation
921 goes away when assertions are turned off.
923 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
924 It's already defined in "system.h".
925 * Makefile.maint: Add a FIXME comment.
927 2006-01-04 Jim Meyering <jim@meyering.net>
929 * ChangeLog: Remove entries from 2005-10-22 and earlier.
930 * ChangeLog-2005: New file, for entries up to version 5.92.
932 2006-01-03 Jim Meyering <jim@meyering.net>
934 * tests/du/no-x: Also allow a slightly different diagnostic -- the
935 one you get when using openat-enabled fts.c and du (coming soon).
936 * tests/chmod/no-x: Likewise.
937 * tests/chgrp/no-x: Likewise.
939 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
941 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
943 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
944 (restricted_chown): Return it, if the file cannot be accessed due
945 to EPERM, or if no uid or gid are required, or if the file is
946 neither a directory nor a regular file. Rewrite to avoid gotos.
947 (change_file_owner): Handle RC_do_ordinary_chown case.
948 Rewrite to avoid gotos.
949 * tests/chgrp/basic: Make sure we can change the group of
952 * src/date.c (usage): Explain %g, %G, and %V a bit better.
954 2006-01-02 Jim Meyering <jim@meyering.net>
956 * src/copy.c (set_owner): Correct a comment.
958 * src/tail.c (parse_options): Change warning to say that --retry
959 is useful `mainly' (not `only') when following by name.
960 Reported here: http://bugs.debian.org/273781
962 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
964 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
965 * src/copy.c: Include lchmod.h.
966 (copy_internal): Use lchmod rather than chmod.
967 * src/cp.c: Include lchmod.h.
968 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
969 * src/mkdir.c: Include lchmod.h.
970 (usage): Clarify -m's operation.
971 (main): Use lchmod rather than chmod. Don't use lchmod unless the
972 new mode contains bits outside the 777 range.
973 * src/mkfifo.c (usage): Clarify -m's operation.
974 (main): If -m is given, don't invoke chmod; use umask 0 instead.
975 Report an error if -m asks for bits outside the 777 range.
976 * src/mknod.c (usage, main): Likewise.
978 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
980 2005-12-27 Jim Meyering <jim@meyering.net>
982 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
983 (sc_prohibit_assert_without_use): New rule.
984 (syntax-check-rules): Add it to the list.
985 * .x-sc_prohibit_assert_without_use: New empty file.
986 * Makefile.am (EXTRA_DIST): Add it.
988 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
990 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
991 Don't include <assert.h>; it wasn't used.
993 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
995 * src/chown-core.c (restricted_chown):
996 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
997 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
998 | O_NOFOLLOW too, for consistency with other dir-openers.
999 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
1000 (is_empty_dir): Likewise.
1001 * src/shred.c (wipename): Likewise. Don't bother trying to open
1002 dir for writing, since POSIX prohibits it.
1004 2005-12-22 Jim Meyering <jim@meyering.net>
1006 * tests/help-version: Redirect stderr to /dev/full, to suppress
1007 write error diagnostic.
1009 2005-12-19 Jim Meyering <jim@meyering.net>
1011 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
1012 Avoid a minor race condition when `-m MODE' is specified, by using
1013 open, fchown, and close rather than just chown. To do that reliably --
1014 even with an overly restrictive umask -- ensure that each mkdir,
1015 mknod and mkfifo call uses a mode including at least owner-read access.
1016 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
1017 the subsequent chown (or equivalent open,fchown,close) fails.
1018 * tests/misc/mknod: New tests.
1019 * tests/misc/Makefile.am (TESTS): Add mknod.
1021 2005-12-17 Jim Meyering <jim@meyering.net>
1023 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
1024 e.g., on a named pipe.
1025 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
1026 place of all uses, since it is guaranteed (system.h) to be defined.
1028 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
1030 Add POSIX ACL support
1031 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
1032 is no requirement for ACL support; particularly, it does not exist
1033 on systems that have POSIX ACLs.
1034 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1035 * src/cp.c (umask_kill): With default acls, the umask is not to be
1036 applied. Remove umask_kill, don't change the process umask, and let
1037 the kernel apply the umask where appropriate.
1038 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1039 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1041 (copy_reg, copy_internal): Use copy_acl and set_acl
1042 instead of fchown/chown. Fix the logic for POSIX ACLs.
1043 (chown_succeded): Remove; we now always copy acls and
1044 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1045 did a chown before or not.
1046 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1047 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1048 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1049 to link with it via $(LIB_ACL), for the utilities that need it.
1051 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1053 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1054 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1055 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1056 value is now signified by whether cwd_errno is null.
1057 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1058 pointer-to-bool to pointer-to-errno-value. All callers changed.
1059 (rm_1): Don't bother setting a local cwd failure flag and then
1060 ORing it into the caller's. Just set the caller's.
1061 (rm): Use cwd failure errno value to print a slightly-better
1064 2005-12-15 Jim Meyering <jim@meyering.net>
1066 * src/stat.c (print_it): Properly handle a backslash at the
1067 end of a --printf format string. Reported by Paul Eggert.
1068 * tests/misc/stat-printf (end-bs): Add a test for the above.
1070 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1072 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1073 Don't assume /etc/passwd contains user names; use 'id' instead.
1075 2005-12-15 Jim Meyering <jim@meyering.net>
1077 stat: revert behavior of --format=FMT (-c)
1078 stat: add new option: --printf=FMT
1079 * NEWS: Mention this.
1080 * src/stat.c (isodigit, octtobin, hextobin): Define.
1081 (PRINTF_OPTION): Define.
1082 (interpret_backslash_escapes, trailing_delim): New globals.
1083 (usage): Document them. Alphabetize on long option names.
1084 (print_esc_char): New function.
1085 (print_it): Rewrite, in order to handle backslash escapes.
1086 (main): Handle new option. Set globals for --format, too.
1088 * tests/misc/stat-printf: Test --printf and --format.
1089 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1091 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1093 * NEWS: sort now reports incompatible options.
1094 * src/sort.c (incompatible_options, check_ordering_compatibility):
1096 (main): Use them. Don't bother with a usage message for
1097 "sort -c a b", for consistency with other error diagnostics.
1098 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1101 * src/cat.c (main): Undo previous change. close_stdout already
1102 does the check, so the previous change wasn't necessary.
1104 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1106 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1108 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1110 Install a more-conservative approach for sort -R. It's the
1111 same basic idea as the existing code, except it uses the full ISAAC
1112 approach (called the "more kosher" approach in the existing comments).
1113 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1114 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1115 better to be conservative here at first, and review any performance
1116 improvements carefully.
1117 * .x-sc_require_config_h: Add src/rand-isaac.c.
1118 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1119 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1120 (shred_SOURCES, sort_SOURCES): Remove.
1121 (EXTRA_DIST): Add rand-isaac.c.
1122 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1123 changing it to allow for varying numbers of words in the state.
1124 Alter so that we include rand-isaac.c directly rather than
1125 compiling it and linking to it. Don't include config.h or
1126 system.h; that's the includer's responsibility.
1127 Omit functions that are specific to shred.
1128 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1129 (isaac_step, struct irand_state):
1130 Resurrect these, with the same defns that used to be in shred.c.
1131 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1132 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1134 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1135 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1136 (irand_init, irand32, irand_mod):
1137 Number of words is constant again.
1138 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1139 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1140 * src/sort.c: Likewise.
1141 * src/shred.c (fillrand, dopass, main): Undo previous change.
1142 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1144 * src/sort.c: Don't include md5.h; it wasn't needed.
1145 (struct keyfield): Rename random_hash to random, for consistency
1146 with the other member names. All uses changed.
1147 (usage): Tweak wording to mention STRING for --seed option.
1148 (short_options): Rorder for consistency with other programs.
1149 (rand_state): Now a struct, not a pointer to one. All uses changed.
1150 (HASH_WORDS, HASH_SIZE): Remove.
1151 (get_hash): Remove comments around resbuf size, since we can assume C89.
1152 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1153 (keycompare): Adjust to the new get_hash.
1155 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1156 (main): Don't set need_random simply because gkey has it set; that
1157 doesn't necessarily mean we'll need random numbers.
1158 Redo seeding to match new get_hash approach.
1160 2005-12-10 Jim Meyering <jim@meyering.net>
1162 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1164 Avoid shred segfault on 64-bit systems.
1165 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1166 local of type uint32_t. Make the local an `int' instead.
1168 * NEWS: Mention sort's new options.
1170 * src/rand-isaac.c (isaac_mix): Declare to be static.
1171 Mark all other functions as `extern' so the tight-scope
1172 part of `make distcheck' passes once again.
1173 * src/rand-isaac.h (isaac_mix): Remove declaration.
1175 * src/sort.c (get_hash): Change position of `*' in parameter
1176 type to conform with convention.
1177 (main): Split a long line so it fits in 80 columns.
1178 (keycompare): Remove stray SPACE before TAB that was
1179 causing `make distcheck' to fail.
1181 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1183 * tests/misc/sort-rand: New file: basic tests for the new options.
1184 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1186 2005-12-10 Frederik Eaton <frederik@ofb.net>
1188 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1189 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1190 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1191 Make state size runtime-configurable.
1192 (isaac_new, isaac_copy): New functions.
1193 * src/rand-isaac.h: New file.
1194 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1195 (fillrand, main): Adjust to the fact that the state size is now
1196 runtime-configurable.
1197 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1198 (usage): Add options --random-sort and --seed to implement a random
1200 Include md5.h and rand-isaac.h.
1201 (get_hash): New function.
1202 (rand_state): New var.
1203 (HASH_WORDS, HASH_SIZE): New macros.
1205 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1207 * tests/dd/misc: Add test for dd iflags=noatime.
1209 2005-12-09 Jim Meyering <jim@meyering.net>
1211 * src/sort.c (usage): Mention white space vs -b and -t options.
1214 2005-12-09 Eric Blake <ebb9@byu.net>
1216 * src/test.c (main): Fix misleading comment.
1218 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1220 * NEWS: Mention dd's new noatime flag.
1221 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1222 * src/dd.c (flags, usage): Add support for noatime flag.
1224 2005-12-07 Jim Meyering <jim@meyering.net>
1226 Distribute the cvsu script, used only by `make syntax-check'.
1227 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1228 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1229 distribute a copy of this script.
1230 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1232 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1233 to create a temporary directory on another partition.
1234 From Andreas Gruenbacher.
1236 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1238 * man/basename.x: Cross-reference to dirname and readlink.
1239 * man/dirname.x: Cross-reference to basename and readlink.
1241 2005-12-05 Andreas Gruenbacher
1243 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1244 (set_owner, preserve_author): New functions, factored out of copy_reg.
1245 (copy_reg): Use them.
1246 (copy_internal): Use them here, too.
1248 2005-12-04 Jim Meyering <jim@meyering.net>
1250 * src/sleep.c (usage): Say what happens with two or more arguments.
1251 Suggested by Justin Pryzby.
1253 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1256 2005-12-03 Jim Meyering <jim@meyering.net>
1258 * src/rm.c (long_opts): Change the name of each undocumented, for-
1259 testing-only option to start with `-', so that it cannot render
1260 ambiguous any prefix it happens to share with some other option name.
1261 Problem reported by Eric Blake.
1262 * src/head.c (long_options): Likewise.
1263 * src/tail.c (long_options): Likewise.
1265 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1266 testing-only --presume* options to start with `---'.
1267 * tests/rm/dangling-symlink: Likewise.
1268 * tests/rm/dir-no-w: Likewise.
1269 * tests/rm/isatty: Likewise.
1271 2005-11-30 Jim Meyering <jim@meyering.net>
1273 * Makefile.maint: Add a comment about cvsu.
1275 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1277 * NEWS: df updates for "none", "proc", inaccessible file systems.
1278 * src/df.c (show_point): Ignore inaccessible file systems.
1279 (usage): -a includes dummy file systems, not size-0 file systems.
1281 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1282 to avoid collision with POSIX name space. All uses changed.
1284 2005-11-24 Jim Meyering <jim@meyering.net>
1286 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1287 * tests/acl: Add `$0: ' prefix to diagnostics.
1289 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1291 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1293 * src/copy.c: Improve performance a bit by optimizing away
1294 unnecessary system calls and going to a block size of at least
1295 8192 (on normal hosts, anyway). This improved performance 5% on my
1296 Debian stable host (2.4.27 kernel, x86, copying from root
1297 ext3 file system to itself).
1298 Include "buffer-lcm.h".
1299 (copy_reg): Omit last argument. All callers changed.
1300 Use xmalloc to allocate rather than trusting alloca
1301 (which is unwise with large block sizes).
1302 Declare locals more locally, if possible.
1303 Use uintptr_t words instead of int words, for a bit more speed
1304 when looking for null blocks on 64-bit hosts.
1305 Optimize away reads of zero bytes on regular files.
1306 In the typical case, insist on 8 KiB buffers, at least.
1307 Avoid unnecessary extra call to fstat when checking for sparse files.
1308 Avoid now-unnecessary cast to off_t, and "0L".
1309 Avoid unnecessary test of *new_dst when checking for same owner
1312 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1314 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1316 2005-11-22 Jim Meyering <jim@meyering.net>
1318 * src/remove.c (AD_push): Remove debugging cruft.
1320 * tests/rm/unread2 (rm): Change expected diagnostic,
1321 `cannot open directory' to `cannot remove', to align with
1323 * tests/rm/rm2: Ensure that rm now continues removing entries
1324 even after certain types of failure.
1326 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1327 that provide openat (Solaris), and on systems like Linux+procfs
1328 where our openat emulation code is reentrant. This also fixes a
1329 few low-probability leaks and eliminates some code that could,
1330 in very unusual circumstances, cause rm() (via a callee) to exit.
1331 * NEWS: Mention this.
1333 * configure.ac: Put copyright dates all on one line so the
1334 emacs function that updates them works properly.
1336 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1338 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1339 Problem reported by Eric Blake.
1340 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1341 we get a standard-conforming compiler. This relies on the new
1342 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1343 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1344 m4/c.m4 can go away with Autoconf 2.60 comes out.
1346 2005-11-17 Jim Meyering <jim@meyering.net>
1348 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1349 (AD_mark_current_as_unremovable): Likewise, but for a local.
1352 * tests/mv/acl: Let traps handle removing temporary directories.
1354 Expect acl-related tests to fail, until the corresponding
1355 patches are committed.
1356 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1357 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1359 ACL tests, from Andreas Gruenbacher.
1360 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1361 * tests/mv/Makefile.am (TESTS): Add acl.
1362 * tests/cp/Makefile.am (TESTS): Add acl.
1364 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1366 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1368 * NEWS: Improve quality of ln's diagnostics.
1369 * src/ln.c (do_link, usage): Likewise.
1370 (do_link): Don't use alloca on a buffer of unbounded size.
1372 2005-11-16 Jim Meyering <jim@meyering.net>
1374 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1375 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1376 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1377 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1378 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1380 2005-11-14 Jim Meyering <jim@meyering.net>
1382 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1384 2005-11-13 Jim Meyering <jim@meyering.net>
1386 * announce-gen: Accept new option, --gpg-key-id=ID and
1387 emit a blurb telling how to use the .sig files.
1388 * Makefile.cfg (gpg_key_ID): Define.
1389 * Makefile.maint (announcement): Use new option and key.
1391 Require that most .c files include <config.h>.
1392 * Makefile.maint (sc_require_config_h): New rule.
1393 (syntax-check-rules): Add it.
1394 * .x-sc_require_config_h: New file listing exceptions to the
1395 above rule. Some are legit, others are simply grandfathered in.
1396 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1398 2005-11-12 Jim Meyering <jim@meyering.net>
1400 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1402 2005-11-11 Jim Meyering <jim@meyering.net>
1404 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1405 Mention new readlink options in 5.3.0's `New features' section.
1406 Spotted by Thomas Hood.
1408 2005-11-08 Jim Meyering <jim@meyering.net>
1410 * NEWS: Merge in changes from b5_9x branch.
1412 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1414 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1415 like --time-style='posix-long-iso' if the locale settings are messed up.
1416 * src/ls.c (decode_switches): Implement this.
1418 2005-11-08 Jim Meyering <jim@meyering.net>
1420 * tests/du/2g: s/expensive/very expensive/ in a comment.
1423 2005-10-17 Eric Blake <ebb9@byu.net>
1425 * src/ls.c (usage): Fix descriptions of --sort, --time.
1426 Reported by Vitaly A. Ostanin.
1428 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1430 * src/ln.c: Include filenamecat.c.
1431 (FILE_BASENAME_CONCAT): Remove.
1432 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1433 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1434 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1437 2005-11-04 Jim Meyering <jim@meyering.net>
1439 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1440 on systems with stat.st_blocks of a signed 32-bit type.
1441 This bug causes trouble on some AIX 5.1 systems.
1442 Report and trivial patch from Paul Townsend:
1443 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1444 * NEWS: Mention this.
1446 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1447 * tests/du/Makefile.am (TESTS): Add it here.
1448 * tests/very-expensive: New file.
1449 * tests/Makefile.am (EXTRA_DIST): Add it here.
1450 * tests/cp/perm: Mark this test as `very-expensive', too.
1452 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1454 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1456 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1458 * src/rm.c (usage): Don't mention rm -d.
1460 2005-11-02 Jim Meyering <jim@meyering.net>
1462 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1463 From Andreas Schwab.
1465 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1466 `M+N records in/out' lines don't pollute `make check' output.
1468 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1469 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1470 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1471 to indicate that the input file should be piped into the command
1472 under test (via `cat FILE | $prog ...').
1474 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1475 (without -r) fails to remove a directory on a non-Linux system.
1476 This change affects only newer Solaris systems (with priv_*
1477 functions like priv_allocset). Reported by Keith Thompson.
1479 * tests/rm/dir-nonrecur: New file/test for the above fix.
1480 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1482 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1484 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1485 POSIX 1002.1-2001 requires.
1486 * src/tail.c (parse_obsolete_option): Implement this.
1487 Problem reported by Vincent Lefevre.
1488 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1489 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1490 (test_vector): Add special cases for _POSIX2_VERSION, and
1491 regularize the old ones a bit.
1492 * tests/touch/obsolescent: Add y2000 test.
1494 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1496 * src/dd.c (skip): Fix off-by-one error reported by
1497 Theodoros V. Kalamatianos.
1499 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1501 * tests/mkdir/p-3: Require that the test be run as non-root.
1502 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1504 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1506 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1507 boundary between DEST and SOURCE in the result.
1509 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1511 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1512 back to text, to sync with documentation and for backwards
1515 2005-10-25 Jim Meyering <jim@meyering.net>
1517 * tests/dircolors/simple (other-wr): Add an explicit test for
1518 the dircolors bug (NULL-dereference) fixed yesterday.
1520 2005-10-24 Jim Meyering <jim@meyering.net>
1522 * src/tac.c (tac_file): When determining whether a file is seekable,
1523 also test whether it is a tty. Using only the lseek-based test would
1524 give a false positive on Solaris. Reported by Peter Fales.
1526 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1528 * tests/install/d-slashdot: New test, for "install -d" failure.
1529 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1530 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1531 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1533 2005-10-24 Jim Meyering <jim@meyering.net>
1535 * src/dircolors.c (ls_codes): Add missing comma.
1536 Anonymous report and patch from
1537 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1539 * src/dircolors.c: Add compile-time assertion that the slack_codes
1540 and ls_codes arrays have the same number of elements. This would
1541 have prevented the above-fixed bug.
1543 * src/expand.c (parse_tab_stops): Add a comment to make this function
1544 identical to the one in unexpand.c.
1545 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1546 identical to the one in expand.c.
1548 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1550 2005-10-23 Jim Meyering <jim@meyering.net>
1552 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1553 a dangerous pointer-value-to-`unsigned' cast.
1554 * NEWS: mention the new sha* programs.
1555 * AUTHORS: Add new sha* programs.
1557 2005-08-28 David Madore <david.madore@ens.fr>
1559 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1560 * README: Add their names to the list.
1561 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1562 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1563 Rules for compiling sha-2 utilities
1564 (noinst_HEADERS): Remove checksum.h.
1565 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1567 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1568 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1569 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1570 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1571 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1572 sha384sum, sha512sum test scripts here rather that each in its
1575 2005-08-28 David Madore <david.madore@ens.fr>
1577 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1578 of the FIPS test vectors).
1580 2005-10-23 Jim Meyering <jim@meyering.net>
1582 * configure.ac: Use 6.0-cvs as the version string.
1583 * NEWS: Adjust accordingly.