1 2006-06-26 Jim Meyering <jim@meyering.net>
3 Attempt rmdir (actually, unlinkat-with-AT_REMOVEDIR) upon any
4 fd_to_subdirp failure, not just when errno == EACCES.
5 * src/remove.c (remove_dir): Use unlinkat-with-AT_REMOVEDIR, not
6 rmdir, here, even though rmdir may happen to be adequate.
8 * NEWS: rm no longer fails to remove an empty, unreadable directory
9 * src/remove.c (remove_cwd_entries): If we can't open a directory,
10 and the failure is not being ignored, try to remove the directory
11 with rmdir (aka unlinkat-with-AT_REMOVEDIR), in case it's empty.
12 Problem report and test case from Paul Eggert in
13 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7425>.
15 * tests/rm/empty-inacc: New test, for the above.
17 Avoid a segfault for wc --files0=- < /dev/null.
18 * src/wc.c (compute_number_width): Return right away if nfiles == 0.
20 2006-06-25 Jim Meyering <jim@meyering.net>
22 * NEWS: wc accepts a new option --files0-from=FILE, where FILE
23 contains a list of NUL-separated file names.
25 * src/wc.c: Include "readtokens.h".
26 (usage): Describe the new option, and adjust the `Usage':
27 with this option, no FILE may be specified on the command line.
28 (main): Handle the new option.
29 * tests/misc/wc-files0: New tests, for the above.
30 * tests/misc/wc-files0-from: Likewise.
31 * tests/misc/Makefile.am (TESTS): Add wc-files0.
33 2006-06-24 Jim Meyering <jim@meyering.net>
35 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
37 2006-06-22 Jim Meyering <jim@meyering.net>
39 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
40 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
42 2006-06-19 Jim Meyering <jim@meyering.net>
44 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
45 so this check is not run as part of "make distcheck".
47 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
49 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
51 2006-06-18 Jim Meyering <jim@meyering.net>
53 * tests/misc/pwd-long: Make error output a little clearer.
55 2006-06-17 Jim Meyering <jim@meyering.net>
57 * tests/rm/inaccessible: Skip this test on systems without openat
58 support. Reported by Bob Proulx.
60 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
62 * tests/misc/mknod: Improve permission checks to handle
63 running mkdir test in set-gid directories.
65 2006-06-14 Jim Meyering <jim@meyering.net>
67 * tests/du/basic: Revamp not to hard-code file system block sizes.
69 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
71 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
74 2006-06-11 Jim Meyering <jim@meyering.net>
76 * .gitignore: New file.
77 * Makefile.am (EXTRA_DIST): Add .gitignore.
79 Setting TIME_STYLE=long-iso in the environment would make the
80 cp/same-file test fail.
81 * tests/envvar-check (vars): Add TIME_STYLE to the list.
82 * tests/cp/same-file: Revert last change.
83 Source the envvar-check script, to ensure that TIME_STYLE
84 settings don't affect these tests.
86 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
88 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
89 uses POSIX time stamp formats. Problem reported by John Nixon in
90 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
92 2006-06-10 Jim Meyering <jim@meyering.net>
94 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
96 Require a "Version N.M" line at the top of the ChangeLog
97 file only when making the actual release, not when running
99 * Makefile.maint (maintainer-distcheck): Don't depend on
101 (alpha beta major): Depend on it here, instead.
103 2006-06-08 Jim Meyering <jim@meyering.net>
105 Ensure that cat works with any of the options, -A -v -e -E -T,
106 when applied to files in /proc and /sys, even when the FIONREAD
107 ioctl produces nonsensical results. Before this change, cat would
108 produce no output (or truncated output), for some linux kernels.
110 * src/cat.c (write_pending): New function, factored out of cat.
111 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
112 that there are bytes to read. Some versions of linux-2.6.16 do that.
113 Write any pending output before returning.
114 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
115 * NEWS: Mention this bug fix.
116 * tests/misc/cat-proc: New file. Test for the above.
117 * tests/misc/Makefile.am (TESTS): Add cat-proc.
119 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
121 * src/expr.c (eval4): Detect overflow properly when multiplying
124 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
126 * NEWS: The 'expr' command now detects and reports integer overflow.
127 (It would be better to use extended precision instead, but that
129 * src/expr.c (integer_overflow): New function.
130 (eval4, eval3): Check for integer overflow.
132 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
134 Fix problems when building with Solaris/SVR4/etc. make, which uses a
135 different and somewhat bogus implementation of VPATH. In the
136 directory tests/misc, rename tests whose names might appear in the
137 Automake-generated rules. For example, we can't use a test named
138 'test', since Automake generates a rule that contains the text
139 "if test -f ./$$tst; ...", and this might expand to something like
140 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
141 which executes the 'test' script rather than the 'test' command.
142 * tests/misc/false-status: Renamed from tests/misc/false.
143 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
144 * tests/misc/sort-merge: Renamed from tests/misc/sort.
145 ($prog): Set to 'sort' rather than to $PROG.
146 * tests/misc/test-diag: Renamed from tests/misc/test.
147 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
148 in case Solaris make has prepended the directory.
149 (TESTS): Adjust to above renamings.
150 * tests/misc/expand: Don't assign to PROG; no longer needed
151 now that Makefile.am sets PROG to the basename.
152 * tests/misc/fold: Likewise.
154 2006-06-03 Jim Meyering <jim@meyering.net>
156 Make `cp --link --no-dereference' work also on systems where the
157 link system call cannot create a hard link to a symbolic link.
158 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
159 the link syscall on a symlink when it would do the wrong thing.
160 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
161 * tests/cp/link-no-deref: New file/test for the above.
162 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
163 * NEWS: Mention the change (doesn't affect Linux).
165 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
167 Fix some porting problems in the test cases reported by
168 Ralf Wildenhues for HP-UX 11.23 in:
169 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
170 * tests/help-version: Don't assume that \< \> works in sed.
171 * tests/misc/close-stdout: Don't assume that >&- works.
172 Add a /dev/full test.
173 * tests/touch/no-create-missing: Don't assume that >&- works.
175 2006-05-30 Jim Meyering <jim@meyering.net>
177 * src/ls.c (usage): Add `v' to the list of sorting-related options.
180 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
182 * tests/cp/fail-perm: source lang-default.
183 * tests/rm/inaccessible: Likewise.
185 2006-05-28 Jim Meyering <jim@meyering.net>
187 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
188 Recognize it, too. Reported by Ralf Wildenhues, in
189 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
191 2006-05-27 Jim Meyering <jim@meyering.net>
193 * src/chgrp.c: Support new options: --preserve-root and
194 --no-preserve-root. Somehow this program was skipped when those
195 options were added to chown, chmod, and rm. Reported by
196 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
197 * NEWS: Mention this.
199 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
201 * NEWS: Remove mention of --seed. We'll replace it with something
202 better, and don't want to indicate that it is supported.
203 * src/sort.c (usage): Likewise.
205 2006-05-20 Jim Meyering <jim@meyering.net>
207 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
209 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
210 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
211 FTS_COMFOLLOW. Spotted by Justin Pryzby.
213 * gnupload: Merge changes from automake, retaining the ""--to...
214 kludge to placate overzealous `make distcheck' check.
216 2006-05-19 Jim Meyering <jim@meyering.net>
218 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
219 FTS_TIGHT_CYCLE_CHECK directory traversal option.
220 Reported by Justin Pryzby in http://bugs.debian.org/367691
222 2006-05-15 Jim Meyering <jim@meyering.net>
224 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
227 2006-05-13 Jim Meyering <jim@meyering.net>
229 * tests/mv/no-target-dir: Test two more cases.
231 2006-05-11 Jim Meyering <jim@meyering.net>
233 mv -T DIR EMPTY_DIR no longer fails unconditionally
234 * src/copy.c (copy_internal): Don't manually prohibit a move where
235 the destination is an existing directory. Sometimes doing that is
236 valid. Let the rename system call enforce the rules. That is
237 allowed only when the source is a directory and the destination
238 directory (to be replaced) is empty. Reported by Eric Blake.
239 * tests/mv/no-target-dir: New file/test for this.
240 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
241 * NEWS: Mention this.
243 * tests/mv/atomic: New file/test for yesterday's fix.
244 * tests/mv/Makefile.am (TESTS): Add atomic.
246 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
248 2006-05-10 Jim Meyering <jim@meyering.net>
250 * src/copy.c (copy_internal): Don't explicitly unlink the destination
251 when moving a symlink into the place of an existing non-directory.
252 Reported by Joshua Hudson.
253 * NEWS: mention this.
255 2006-05-07 Jim Meyering <jim@meyering.net>
257 * Makefile.maint (patch-check): Fail if patch generates any output,
258 even merely for changed offsets.
260 * src/c99-to-c89.diff: Adjust to reflect new offsets.
262 * NEWS: Mention changes affecting df, pwd, shred.
264 2006-05-06 Jim Meyering <jim@meyering.net>
266 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
267 system condition where dirent.d_ino != stat.st_ino.
268 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
270 2006-05-06 Eric Blake <ebb9@byu.net>
272 * tests/ls/inode: Expand to test inode from readdir case.
273 * tests/ls/follow-slink: Expand to test broken links encountered
274 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
276 2006-05-06 Eric Blake <ebb9@byu.net>
278 * tests/mv/leak-fd: Work even on case-insensitive file system.
280 2006-05-04 Jim Meyering <jim@meyering.net>
282 * NEWS: Mention the 2006-03-19 pwd-related change that makes
283 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
285 2006-05-03 Jim Meyering <jim@meyering.net>
287 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
288 Use better macro parameter names: s/basename/key_name/,
289 s/basefunc/key_cmp_func. Fix typo in comment.
291 2006-04-29 Eric Blake <ebb9@byu.net>
293 * src/ls.c (main): On systems with d_type, directories_first only
294 implies format_needs_type, not format_needs_stat.
296 2006-05-03 Jim Meyering <jim@meyering.net>
298 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
299 after comma in arg list, from Eric Blake.
301 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
303 * tests/misc/date (relative-3): New test, derived from a bug
304 report by John Thomas McDole.
306 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
308 New option for ls: --group-directories-first.
309 It makes ls list directories before files.
310 * NEWS [New features]: Mention it.
311 * src/ls.c (sort_type): Rearrange to use as an array index when
312 choosing sort function; added new sort_numtypes member for
314 (time_type): Add new time_numtypes member for compile-time check.
315 (directories_first): New global variable.
316 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
317 (long_options): Add --directories-first.
318 (main): Support new option.
319 (is_directory): New function.
320 (extract_dirs_from_files): Use it.
321 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
322 (LIST_SORTFUNCTION_VARIANTS): New macros.
323 (sort_functions): New global variable.
324 (sort_files): Use it.
325 (usage): Document new option.
327 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
329 * src/shred.c (fillrand): The assertion was way too weak, due to
330 what must be a typo. Strengthen it to its intended value.
331 (dopass): Don't use alloca; it's not worth the aggravation here,
332 since it's used only to get a page-aligned buffer, and page
333 alignment doesn't buy us much here. I'm suspicious that alloca
334 causes problems on some hosts, due to a recent bug report by Adam
335 Waltman: http://bugs.gentoo.org/130246.
337 2006-04-18 Jim Meyering <jim@meyering.net>
339 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
340 sha384sum, sha512sum.
342 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
344 * src/chmod.c (describe_change): Adjust to filemode changes.
345 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
346 (print_long_format): Use (new) filemodestring rather than
347 (old) mode_string, so that we get more file types right, at least
348 in theory. Adjust to filemode changes.
349 * src/stat.c (human_access): Likewise.
351 2006-04-18 Jim Meyering <jim@meyering.net>
353 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
354 ignore file. This has never been enabled. Reported by Eric Blake.
356 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
358 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
359 bug in Interix. Just call symlink or link directly. All uses changed.
360 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
361 * src/stat.c (USE_STATVFS): New macro.
362 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
363 (NAMEMAX_FORMAT): define a bit more clearly, now that the
364 statvfs-using code is a bit more regular.
365 * src/system.h (sync) [!HAVE_SYNC]: New macro.
367 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
369 * NEWS: csplit, nl, expr now conform to POSIX better, and are
370 more-compatible with traditional Unix, with respect to regular
372 * src/csplit.c (extract_regexp): Set re_syntax_options to a
373 value that is compatible with what POSIX requires.
374 * src/nl.c (build_type_arg): Likewise.
375 * src/expr.c (docolon): Likewise. Also, don't let anchors match
376 newline; this fixes an incompatibility with tradition and with POSIX.
377 Don't warn about leading ^. POSIX says it is unspecified whether
378 ^ is a special character, which means that implementations can
379 either treat it as special or not, but either way a warning is not
380 allowed (unless the regexp is otherwise invalid). Instead, anchor
381 the expression but treat ^ as an anchor; this is the traditional
382 behavior (e.g., Solaris 10).
383 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
384 and the like as invalid expressions (exit status 2), not as
385 failure of 'expr' (exit status 3). This is more consistent with
387 * tests/expr/basic (fail-a): Adjust exit status to match new expr
388 behavior, for status 2 versus 3.
390 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
391 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
392 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
393 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
394 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
395 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
396 (bre61, bre62): New tests.
397 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
401 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
402 "if !". Do not assume that 'sed' can handle long, newline-free input.
403 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
405 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
407 Adjust to new regex.h API (with new fastmap type), and clean
408 up the regex storage allocation a bit.
410 * src/csplit.c (struct control): Put re_compiled member at the
411 end, since it's large. Change regexpr member from char * to bool;
412 all uses changed. Add new member fastmap.
413 (extract_regexp): regexp arg is now char const *, not char *.
414 Don't bother duplicating the regular expression; it's not needed.
415 Set fastmap from new fastmap member. Don't bother allocating
416 a buffer, as the regexp code does a better job than we do.
417 * src/expr.c (docolon): Allocate and use a fastmap.
418 Don't bother allocating a buffer.
419 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
421 (build_type_arg): New fastmap arg. All uses changed.
422 Don't bother allocating a buffer, but set a fastmap.
423 * src/ptx.c (context_regex_string, word_regex_string): Remove.
424 (context_regex, word_regex): New vars, replacing the above.
426 (struct regex_data): New type.
427 (compile_regex): Renamed from alloc_and_compile_regex, since
428 we no longer allocate storage. Arg is now a struct regex_data *,
429 not a const char *. All uses changed. Don't allocate the fastmap;
430 instead, take it from the caller. Don't convert size_t to int,
431 to avoid arithmetic overflow problems. Don't bother freeing
432 storage afterwards; it's not worth the aggravation.
433 * src/tac.c (compiled_separator_fastmap): New ver.
434 (main): Use it. Don't bother allocating a buffer.
436 2006-03-30 Jim Meyering <jim@meyering.net>
438 * src/dd.c (iwrite): Remove assignment without effect.
439 Reported by Felix Rauch Valenti.
441 2006-03-22 Eric Blake <ebb9@byu.net>
443 * src/ptx.c (usage): Remove mention of --copyright/-C.
444 (main): Alias --copyright to --version plus a deprecation warning.
445 * NEWS: Mention this.
447 2006-03-27 Jim Meyering <jim@meyering.net>
449 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
450 use of strtod. Tiny patch from Nickolai Zeldovich.
452 2006-03-11 Eric Blake <ebb9@byu.net>
454 * tests/misc/dirname: New file.
455 * tests/basename/Makefile.am: Delete.
456 * tests/basename/basic: Move to...
457 * tests/misc/basename: ... this new file. Add some tests,
458 including fixed behavior for //.
459 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
460 * tests/Makefile.am (SUBDIRS): Remove basename.
461 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
463 Improvements to dirname/basename handling on platforms like
464 cygwin with distinct // and with drive letters.
465 * NEWS: Document new behavior.
466 * src/basename.c (main): Don't strip suffix from file system
468 * src/cp.c (target_directory_operand): Use new last_component.
469 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
470 traversing the string.
471 * src/dircolors.c (guess_shell_syntax): Use new last_component.
472 * src/install.c (target_directory_operand, install_file_in_dir):
474 * src/ln.c (target_directory_operand, main): Likewise.
475 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
476 * src/mv.c (target_directory_operand, movefile): Likewise.
477 * src/remove.c (rm_1): Likewise.
478 * src/shred.c (wipename): Likewise.
479 * src/split.c (next_file_name): Likewise.
480 * src/su.c (log_su, run_shell): Likewise.
482 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
484 * NEWS: nohup diagnostics are now more precise, and nohup now
485 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
486 * src/nohup.c (main): Implement this.
487 * tests/misc/nohup: Test the new behavior.
489 2006-03-12 Jim Meyering <jim@meyering.net>
491 * src/copy.c (set_author): Rename function, from preserve_author.
493 * src/remove.c (AD_pop_and_chdir): Use new macro,
494 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
496 * src/system.h (SAME_INODE): Remove definition.
497 Include "same-inode.h", instead.
499 2006-03-11 Eric Blake <ebb9@byu.net>
501 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
503 2006-03-10 Jim Meyering <jim@meyering.net>
505 Fix a bug whereby a user with write access to a directory being removed
506 could cause the removal of that directory to fail with an erroneous
507 diagnostic about a directory cycle. Reported by Vineet Chadha.
509 * NEWS: Mention this.
510 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
511 leave (and try to rmdir) is the one whose dev_ino is being used to
512 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
514 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
516 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
517 * src/dd.c (set_fd_flags): Handle file-creation flags on file
518 descriptors, rather than ignoring them.
519 * tests/dd/misc: Add test cases for append, nofollow, directory,
520 and nolinks flags. Simplify redirection to /dev/null in some cases.
522 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
523 noatime test never tested anything.
525 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
527 * src/dd.c (flags, usage): New flags directory, nolinks.
528 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
530 * src/ls.c (usage): Mention that -f disables --color.
531 Problem reported by Niels Möller.
533 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
535 * man/*.x: Add references to syscalls from utilities of the same name.
537 2006-03-05 Jim Meyering <jim@meyering.net>
539 * tests/help-version: Set SHELL, if not already set, in order to
540 avoid failure when `make check' is run through debuild; dircolors
541 would fail due to lack of $SHELL. Reported by Sven Joachim.
543 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
544 * src/base64.c (wrap_write, do_encode, main): Change type of
545 parameters and locals, wrap_column, form size_t to uintmax_t.
546 (main): Adjust to use xstrtoumax, accordingly.
548 2006-03-03 Jim Meyering <jim@meyering.net>
550 Don't fail when run from an environment with SHELL not a Bourne
551 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
552 * tests/dircolors/simple: Invoke each non-failing test with -b.
553 Reported by Michael Stone.
555 2006-02-27 Jim Meyering <jim@meyering.net>
557 * tests/misc/base64: Derive --decode-using tests from the
560 * tests/misc/base64: Factor out a long constant string.
561 Split lines to stay within 80 columns.
563 * tests/misc/Makefile.am (TESTS): Add base64.
564 * tests/misc/base64: Test base64. From Simon Josefsson.
566 * src/base64.c (do_decode): Use correct type for parameter,
567 ignore_garbage: s/size_t/bool/.
569 * src/base64.c: Don't include .h files already included by system.h:
570 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
571 Include "system.h" before the other lib/*.h header files.
572 Include <sys/types.h> before "system.h".
573 (wrap_write): Remove declaration of unused local, initial_column.
574 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
576 * README: Add base64 to the list.
578 2006-02-17 Simon Josefsson <jas@extundo.com>
581 * AUTHORS: Mention base64.
583 * man/Makefile.am: Build base64.1.
584 * man/base64.x: New file.
585 * src/Makefile.am (bin_PROGRAMS): Add base64.
586 * src/base64.c: New file.
588 2006-02-25 Eric Blake <ebb9@byu.net>
590 In ls, avoid calling stat for --inode (-i), when possible.
591 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
592 * src/system.h: ... here, for use in ...
593 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
595 (gobble_file): Add inode argument.
596 (print_dir): Pass inode if available.
597 (usage): Remove inaccuracy.
599 2006-02-23 Jim Meyering <jim@meyering.net>
601 * TODO: Update/correct some obsolete entries.
603 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
605 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
606 * src/join.c (usage): Likewise.
607 Documentation problem reported by Philip Kensche.
609 2006-02-20 Eric Blake <ebb9@byu.net>
611 * man/rm.x: Update documentation to match previous patch.
613 2006-02-18 Eric Blake <ebb9@byu.net>
615 New option for rm: --interactive=once (-I).
616 * NEWS: Document it, along with change to rm --interactive.
617 * TODO: Remove entry for implementing rm -I
618 * src/rm.c (INTERACTIVE_OPTION): New enum value.
619 (interactive_type): New enum.
620 (long_opts): Let interactive take an optional argument.
621 (interactive_args, interactive_types): New option arguments.
622 (usage): Document -I, --interactive=WHEN. Use program_name
623 instead of a basename.
624 (main): New -I option, new behavior to --interactive.
625 * tests/rm/interactive-once: New tests.
626 * tests/rm/interactive-always: Ditto.
627 * tests/rm/Makefile.am (TESTS): Run them.
629 2006-02-18 Jim Meyering <jim@meyering.net>
631 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
632 expression match more of the target lines, e.g., those that start with
633 `-S,' (short option followed by a comma) or that include `=[...]'.
634 Patch by Nicolas François.
635 Fix the four offenders thus exposed:
636 * src/join.c (usage): Use two spaces (not one) to separate the
637 --first-only option string from its description, so help2man formats
638 the derived man page properly.
639 * src/pr.c (usage): Likewise.
640 * src/uniq.c (usage): Likewise.
641 * src/install.c (usage): Likewise.
643 2006-02-15 Jim Meyering <jim@meyering.net>
645 * Makefile.maint (alpha beta major): For `make major', ensure that the
646 version string is of the form N.N[.N]*, where N is one or more digits.
648 2006-02-14 Jim Meyering <jim@meyering.net>
650 * INSTALL: Update from gnulib.
652 2006-02-13 Jim Meyering <jim@meyering.net>
654 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
656 2006-02-12 Jim Meyering <jim@meyering.net>
658 * Makefile.maint (patch-check): New target.
659 (local-checks-available): Add to the list.
661 2006-02-11 Jim Meyering <jim@meyering.net>
663 * src/c99-to-c89.diff: New file.
664 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
666 * .x-po-check: New file, with exclusions so that `make distcheck'
668 * Makefile.am (EXTRA_DIST): Add .x-po-check.
670 rm -r must remove an empty directory, even if it is inaccessible.
671 * src/remove.c (close_preserve_errno): New function.
672 (fd_to_subdirp): Don't print a diagnostic in this function.
673 Do it from the callers instead, unless rmdir succeeds.
674 (remove_cwd_entries, remove_dir): Adjust callers.
675 * tests/rm/empty-inacc: New test for the above.
676 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
677 * NEWS: Mention this bug fix.
678 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
679 a tiny bit less precise: cannot remove `a/1': ... instead of
680 cannot open directory `a/1': ...
682 * Makefile.maint (syntax-check-rules): Automatically derive this
683 list of sc_-prefixed rule names.
685 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
687 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
688 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
689 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
690 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
691 go away? was that an accident?)
692 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
693 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
694 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
695 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
696 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
697 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
698 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
699 (author_mark_check, makefile_path_separator_check):
700 Output line numbers, to simplify navigation of Emacs *compilation*
702 (sc_prohibit_atoi_atof, sc_file_system):
703 Rework slightly so that Makefile.maint doesn't get reported as a
704 violation of its own syntax rules.
705 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
706 it at run-time (which didn't work with Bison). Fix a makefile typo,
707 caught by Makefile.maint itself: spaces where a tab should be.
708 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
709 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
710 Ignore djgpp and man subdirectories, to avoid false matches with
711 Bison and coreutils, respectively. Use sort -u to remove the
712 resulting duplicates.
713 * gnupload: Rework slightly to avoid bogus warning from
714 sc_two_space_separator_in_usage.
716 2006-02-10 Jim Meyering <jim@meyering.net>
718 Use gzip's --rsyncable option only if it's available.
719 * Makefile.maint (gzip_rsyncable): New variable.
722 2006-02-08 Jim Meyering <jim@meyering.net>
724 * Makefile.maint (local-checks-available): Define in terms of
725 the expansion, $(syntax-check-rules), rather than the single,
726 top-level target `syntax-check', so that it's easier to exclude
727 individual rules (via $(local-checks-to-skip)).
728 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
730 2006-02-07 Jim Meyering <jim@meyering.net>
732 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
733 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
735 * tests/help-version (expected_failure_status_vdir):
736 Redirect an expected disk-full diagnostic to /dev/null.
738 2006-02-06 Jim Meyering <jim@meyering.net>
740 * src/unexpand.c (usage): Use two spaces (not one) to separate the
741 --first-only option string from its description, so help2man formats
742 the derived man page properly.
743 * src/rm.c (usage): Likewise for --no-preserve-root.
744 * src/chown.c (usage): Likewise.
745 * src/chgrp.c (usage): Likewise.
747 Add a rule to ensure that the above doesn't happen again.
748 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
749 (syntax-check-rules): Add it.
750 * .x-sc_two_space_separator_in_usage: New empty file.
751 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
753 2006-02-06 Jim Meyering <jim@meyering.net>
755 * src/cp.c (usage): Use two spaces (not one) to separate each
756 option string from its description, so help2man formats the
757 derived man page properly.
758 * src/mv.c (usage): Likewise.
759 Patch from Nicolas François in http://bugs.debian.org/351601.
761 2006-02-04 Jim Meyering <jim@meyering.net>
763 * src/copy.c (copy_internal): cp -RL would fail when encountering
764 the same directory more than once in the hierarchy beneath a single
765 command-line argument. That is legitimate, e.g. when there are
766 two or more symbolic links, each pointing to some directory that
767 would not otherwise be copied. Reported by Christophe LYON.
768 * tests/cp/cp-deref: New file. Test for today's fix.
769 * tests/cp/Makefile.am (TESTS): Add cp-deref.
770 * NEWS: Document this.
772 2006-02-03 Jim Meyering <jim@meyering.net>
774 * configure.ac: Require automake-1.9.6, not 1.8.3.
776 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
778 * src/od.c (usage): Mention that -t a ignores high order bit.
779 Documentation problem reported by Ed Avis.
781 2006-02-01 Jim Meyering <jim@meyering.net>
783 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
785 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
787 * src/head.c (main): Use a better diagnostic when someone uses a
788 trailing numeric option in an invalid way. Problem reported by
790 * src/tail.c (parse_options): Likewise.
792 2006-01-30 Jim Meyering <jim@meyering.net>
794 * man/wc.x: Include `count' keyword in man page synopsis,
795 per suggestion from http://bugs.debian.org/181585.
797 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
799 * src/df.c (show_dev): If the file system claims to have
800 more available than total blocks, report the number of used
801 blocks as being total - available (a negative number) rather
802 than as garbage. Problem reported by Toralf Foerster.
804 2006-01-24 Jim Meyering <jim@meyering.net>
806 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
807 to put a regular file in O_NONBLOCK mode fails with EPERM.
808 That happens on Linux (up to 2.6.15) when using tail -f on a file with
809 the append-only attribute. Reported by Dean Gaudet. For details,
810 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
811 * NEWS: Mention this fix.
812 * tests/tail-2/append-only: New file. Test for the above.
813 * tests/tail-2/Makefile.am (TESTS): Add append-only.
814 * tests/Makefile.am (check-root): Add tail-2/append-only
816 2006-01-21 Jim Meyering <jim@meyering.net>
818 * NEWS: Mention fts-related improvements and bug fixes.
820 2006-01-19 Jim Meyering <jim@meyering.net>
822 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
823 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
825 2006-01-18 Jim Meyering <jim@meyering.net>
827 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
829 2006-01-17 Jim Meyering <jim@meyering.net>
831 Now that fts no longer changes the current working directory, adjust
832 its clients accordingly -- note that du.c uses fts but doesn't need
833 any adjustment, since it doesn't operate on the actual files,
834 but rather just uses the stat buffers provided by fts.
836 * src/chown-core.c: Include "openat.h".
837 Don't include "lchown.h".
838 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
839 calling openat, lchownat, chownat, rather than open, lchown, chown.
841 * src/chmod.c: Include "openat.h".
842 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
844 * tests/du/long-from-unreadable: New test, to exercise one small
847 2006-01-13 Jim Meyering <jim@meyering.net>
849 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
850 addition of new directories under tests/.
852 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
855 2006-01-12 Jim Meyering <jim@meyering.net>
857 * tests/du/long-sloop: Adjust not to hard-code the expected
858 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
859 from that of GNU libc. Reported by Paul Eggert.
861 * tests/du/long-sloop: Create file at end of symlink chain.
863 * tests/misc/test: New file, with a test for one of the
864 bugs fixed by yesterday's test.c changes.
865 * tests/misc/Makefile.am (TESTS): Add test.
867 2006-01-11 Jim Meyering <jim@meyering.net>
869 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
870 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
871 a very long sequence of symbolic links (not necessarily a loop).
872 * tests/du/Makefile.am (TESTS): Add long-sloop.
874 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
876 * src/test.c (test_syntax_error): Append a newline. All callers
877 changed, except for the ones that didn't already append a newline.
878 Bug reported by Eric Blake.
880 2006-01-11 Jim Meyering <jim@meyering.net>
882 * src/system.h (X2NREALLOC): Now that verify_true is no longer
883 void, cast its result to void, to avoid gcc's warning that
884 ``left-hand operand of comma expression has no effect''.
885 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
887 2006-01-10 Jim Meyering <jim@meyering.net>
889 * tests/chmod/no-x: Add a test for today's fts.c fix.
891 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
893 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
894 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
896 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
898 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
899 Use verify_true instead of verify_expr, to sync with gnulib.
901 2006-01-08 Jim Meyering <jim@meyering.net>
903 * src/date.c (usage): Adjust the formatting of the entries for
904 %::z and %:::z (separate with two spaces, not one) so that help2man
905 formats them properly. Reported by Philip Rowlands.
907 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
909 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
911 2006-01-06 Jim Meyering <jim@meyering.net>
913 * Makefile.maint (copyright-check): Use date +%Y in place of
916 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
917 First off, the attribute should have been `volatile' (not static)
918 to avoid longjmp-related risk of clobber. Secondly, now there is
919 no longer any risk of a local variable being clobbered, so there's
920 no need for any attribute at all.
922 2006-01-05 Jim Meyering <jim@meyering.net>
924 * src/remove.c: Give a few functions the inline attribute.
925 (AD_pop_and_chdir): Use gotos to avoid some duplication.
926 (AD_push): Rewrite an assertion so that the entire computation
927 goes away when assertions are turned off.
929 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
930 It's already defined in "system.h".
931 * Makefile.maint: Add a FIXME comment.
933 2006-01-04 Jim Meyering <jim@meyering.net>
935 * ChangeLog: Remove entries from 2005-10-22 and earlier.
936 * ChangeLog-2005: New file, for entries up to version 5.92.
938 2006-01-03 Jim Meyering <jim@meyering.net>
940 * tests/du/no-x: Also allow a slightly different diagnostic -- the
941 one you get when using openat-enabled fts.c and du (coming soon).
942 * tests/chmod/no-x: Likewise.
943 * tests/chgrp/no-x: Likewise.
945 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
947 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
949 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
950 (restricted_chown): Return it, if the file cannot be accessed due
951 to EPERM, or if no uid or gid are required, or if the file is
952 neither a directory nor a regular file. Rewrite to avoid gotos.
953 (change_file_owner): Handle RC_do_ordinary_chown case.
954 Rewrite to avoid gotos.
955 * tests/chgrp/basic: Make sure we can change the group of
958 * src/date.c (usage): Explain %g, %G, and %V a bit better.
960 2006-01-02 Jim Meyering <jim@meyering.net>
962 * src/copy.c (set_owner): Correct a comment.
964 * src/tail.c (parse_options): Change warning to say that --retry
965 is useful `mainly' (not `only') when following by name.
966 Reported here: http://bugs.debian.org/273781
968 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
970 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
971 * src/copy.c: Include lchmod.h.
972 (copy_internal): Use lchmod rather than chmod.
973 * src/cp.c: Include lchmod.h.
974 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
975 * src/mkdir.c: Include lchmod.h.
976 (usage): Clarify -m's operation.
977 (main): Use lchmod rather than chmod. Don't use lchmod unless the
978 new mode contains bits outside the 777 range.
979 * src/mkfifo.c (usage): Clarify -m's operation.
980 (main): If -m is given, don't invoke chmod; use umask 0 instead.
981 Report an error if -m asks for bits outside the 777 range.
982 * src/mknod.c (usage, main): Likewise.
984 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
986 2005-12-27 Jim Meyering <jim@meyering.net>
988 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
989 (sc_prohibit_assert_without_use): New rule.
990 (syntax-check-rules): Add it to the list.
991 * .x-sc_prohibit_assert_without_use: New empty file.
992 * Makefile.am (EXTRA_DIST): Add it.
994 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
996 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
997 Don't include <assert.h>; it wasn't used.
999 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
1001 * src/chown-core.c (restricted_chown):
1002 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
1003 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
1004 | O_NOFOLLOW too, for consistency with other dir-openers.
1005 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
1006 (is_empty_dir): Likewise.
1007 * src/shred.c (wipename): Likewise. Don't bother trying to open
1008 dir for writing, since POSIX prohibits it.
1010 2005-12-22 Jim Meyering <jim@meyering.net>
1012 * tests/help-version: Redirect stderr to /dev/full, to suppress
1013 write error diagnostic.
1015 2005-12-19 Jim Meyering <jim@meyering.net>
1017 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
1018 Avoid a minor race condition when `-m MODE' is specified, by using
1019 open, fchown, and close rather than just chown. To do that reliably --
1020 even with an overly restrictive umask -- ensure that each mkdir,
1021 mknod and mkfifo call uses a mode including at least owner-read access.
1022 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
1023 the subsequent chown (or equivalent open,fchown,close) fails.
1024 * tests/misc/mknod: New tests.
1025 * tests/misc/Makefile.am (TESTS): Add mknod.
1027 2005-12-17 Jim Meyering <jim@meyering.net>
1029 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
1030 e.g., on a named pipe.
1031 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
1032 place of all uses, since it is guaranteed (system.h) to be defined.
1034 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
1036 Add POSIX ACL support
1037 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
1038 is no requirement for ACL support; particularly, it does not exist
1039 on systems that have POSIX ACLs.
1040 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1041 * src/cp.c (umask_kill): With default acls, the umask is not to be
1042 applied. Remove umask_kill, don't change the process umask, and let
1043 the kernel apply the umask where appropriate.
1044 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1045 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1047 (copy_reg, copy_internal): Use copy_acl and set_acl
1048 instead of fchown/chown. Fix the logic for POSIX ACLs.
1049 (chown_succeded): Remove; we now always copy acls and
1050 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1051 did a chown before or not.
1052 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1053 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1054 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1055 to link with it via $(LIB_ACL), for the utilities that need it.
1057 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1059 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1060 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1061 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1062 value is now signified by whether cwd_errno is null.
1063 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1064 pointer-to-bool to pointer-to-errno-value. All callers changed.
1065 (rm_1): Don't bother setting a local cwd failure flag and then
1066 ORing it into the caller's. Just set the caller's.
1067 (rm): Use cwd failure errno value to print a slightly-better
1070 2005-12-15 Jim Meyering <jim@meyering.net>
1072 * src/stat.c (print_it): Properly handle a backslash at the
1073 end of a --printf format string. Reported by Paul Eggert.
1074 * tests/misc/stat-printf (end-bs): Add a test for the above.
1076 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1078 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1079 Don't assume /etc/passwd contains user names; use 'id' instead.
1081 2005-12-15 Jim Meyering <jim@meyering.net>
1083 stat: revert behavior of --format=FMT (-c)
1084 stat: add new option: --printf=FMT
1085 * NEWS: Mention this.
1086 * src/stat.c (isodigit, octtobin, hextobin): Define.
1087 (PRINTF_OPTION): Define.
1088 (interpret_backslash_escapes, trailing_delim): New globals.
1089 (usage): Document them. Alphabetize on long option names.
1090 (print_esc_char): New function.
1091 (print_it): Rewrite, in order to handle backslash escapes.
1092 (main): Handle new option. Set globals for --format, too.
1094 * tests/misc/stat-printf: Test --printf and --format.
1095 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1097 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1099 * NEWS: sort now reports incompatible options.
1100 * src/sort.c (incompatible_options, check_ordering_compatibility):
1102 (main): Use them. Don't bother with a usage message for
1103 "sort -c a b", for consistency with other error diagnostics.
1104 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1107 * src/cat.c (main): Undo previous change. close_stdout already
1108 does the check, so the previous change wasn't necessary.
1110 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1112 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1114 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1116 Install a more-conservative approach for sort -R. It's the
1117 same basic idea as the existing code, except it uses the full ISAAC
1118 approach (called the "more kosher" approach in the existing comments).
1119 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1120 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1121 better to be conservative here at first, and review any performance
1122 improvements carefully.
1123 * .x-sc_require_config_h: Add src/rand-isaac.c.
1124 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1125 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1126 (shred_SOURCES, sort_SOURCES): Remove.
1127 (EXTRA_DIST): Add rand-isaac.c.
1128 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1129 changing it to allow for varying numbers of words in the state.
1130 Alter so that we include rand-isaac.c directly rather than
1131 compiling it and linking to it. Don't include config.h or
1132 system.h; that's the includer's responsibility.
1133 Omit functions that are specific to shred.
1134 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1135 (isaac_step, struct irand_state):
1136 Resurrect these, with the same defns that used to be in shred.c.
1137 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1138 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1140 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1141 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1142 (irand_init, irand32, irand_mod):
1143 Number of words is constant again.
1144 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1145 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1146 * src/sort.c: Likewise.
1147 * src/shred.c (fillrand, dopass, main): Undo previous change.
1148 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1150 * src/sort.c: Don't include md5.h; it wasn't needed.
1151 (struct keyfield): Rename random_hash to random, for consistency
1152 with the other member names. All uses changed.
1153 (usage): Tweak wording to mention STRING for --seed option.
1154 (short_options): Rorder for consistency with other programs.
1155 (rand_state): Now a struct, not a pointer to one. All uses changed.
1156 (HASH_WORDS, HASH_SIZE): Remove.
1157 (get_hash): Remove comments around resbuf size, since we can assume C89.
1158 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1159 (keycompare): Adjust to the new get_hash.
1161 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1162 (main): Don't set need_random simply because gkey has it set; that
1163 doesn't necessarily mean we'll need random numbers.
1164 Redo seeding to match new get_hash approach.
1166 2005-12-10 Jim Meyering <jim@meyering.net>
1168 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1170 Avoid shred segfault on 64-bit systems.
1171 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1172 local of type uint32_t. Make the local an `int' instead.
1174 * NEWS: Mention sort's new options.
1176 * src/rand-isaac.c (isaac_mix): Declare to be static.
1177 Mark all other functions as `extern' so the tight-scope
1178 part of `make distcheck' passes once again.
1179 * src/rand-isaac.h (isaac_mix): Remove declaration.
1181 * src/sort.c (get_hash): Change position of `*' in parameter
1182 type to conform with convention.
1183 (main): Split a long line so it fits in 80 columns.
1184 (keycompare): Remove stray SPACE before TAB that was
1185 causing `make distcheck' to fail.
1187 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1189 * tests/misc/sort-rand: New file: basic tests for the new options.
1190 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1192 2005-12-10 Frederik Eaton <frederik@ofb.net>
1194 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1195 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1196 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1197 Make state size runtime-configurable.
1198 (isaac_new, isaac_copy): New functions.
1199 * src/rand-isaac.h: New file.
1200 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1201 (fillrand, main): Adjust to the fact that the state size is now
1202 runtime-configurable.
1203 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1204 (usage): Add options --random-sort and --seed to implement a random
1206 Include md5.h and rand-isaac.h.
1207 (get_hash): New function.
1208 (rand_state): New var.
1209 (HASH_WORDS, HASH_SIZE): New macros.
1211 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1213 * tests/dd/misc: Add test for dd iflags=noatime.
1215 2005-12-09 Jim Meyering <jim@meyering.net>
1217 * src/sort.c (usage): Mention white space vs -b and -t options.
1220 2005-12-09 Eric Blake <ebb9@byu.net>
1222 * src/test.c (main): Fix misleading comment.
1224 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1226 * NEWS: Mention dd's new noatime flag.
1227 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1228 * src/dd.c (flags, usage): Add support for noatime flag.
1230 2005-12-07 Jim Meyering <jim@meyering.net>
1232 Distribute the cvsu script, used only by `make syntax-check'.
1233 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1234 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1235 distribute a copy of this script.
1236 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1238 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1239 to create a temporary directory on another partition.
1240 From Andreas Gruenbacher.
1242 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1244 * man/basename.x: Cross-reference to dirname and readlink.
1245 * man/dirname.x: Cross-reference to basename and readlink.
1247 2005-12-05 Andreas Gruenbacher
1249 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1250 (set_owner, preserve_author): New functions, factored out of copy_reg.
1251 (copy_reg): Use them.
1252 (copy_internal): Use them here, too.
1254 2005-12-04 Jim Meyering <jim@meyering.net>
1256 * src/sleep.c (usage): Say what happens with two or more arguments.
1257 Suggested by Justin Pryzby.
1259 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1262 2005-12-03 Jim Meyering <jim@meyering.net>
1264 * src/rm.c (long_opts): Change the name of each undocumented, for-
1265 testing-only option to start with `-', so that it cannot render
1266 ambiguous any prefix it happens to share with some other option name.
1267 Problem reported by Eric Blake.
1268 * src/head.c (long_options): Likewise.
1269 * src/tail.c (long_options): Likewise.
1271 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1272 testing-only --presume* options to start with `---'.
1273 * tests/rm/dangling-symlink: Likewise.
1274 * tests/rm/dir-no-w: Likewise.
1275 * tests/rm/isatty: Likewise.
1277 2005-11-30 Jim Meyering <jim@meyering.net>
1279 * Makefile.maint: Add a comment about cvsu.
1281 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1283 * NEWS: df updates for "none", "proc", inaccessible file systems.
1284 * src/df.c (show_point): Ignore inaccessible file systems.
1285 (usage): -a includes dummy file systems, not size-0 file systems.
1287 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1288 to avoid collision with POSIX name space. All uses changed.
1290 2005-11-24 Jim Meyering <jim@meyering.net>
1292 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1293 * tests/acl: Add `$0: ' prefix to diagnostics.
1295 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1297 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1299 * src/copy.c: Improve performance a bit by optimizing away
1300 unnecessary system calls and going to a block size of at least
1301 8192 (on normal hosts, anyway). This improved performance 5% on my
1302 Debian stable host (2.4.27 kernel, x86, copying from root
1303 ext3 file system to itself).
1304 Include "buffer-lcm.h".
1305 (copy_reg): Omit last argument. All callers changed.
1306 Use xmalloc to allocate rather than trusting alloca
1307 (which is unwise with large block sizes).
1308 Declare locals more locally, if possible.
1309 Use uintptr_t words instead of int words, for a bit more speed
1310 when looking for null blocks on 64-bit hosts.
1311 Optimize away reads of zero bytes on regular files.
1312 In the typical case, insist on 8 KiB buffers, at least.
1313 Avoid unnecessary extra call to fstat when checking for sparse files.
1314 Avoid now-unnecessary cast to off_t, and "0L".
1315 Avoid unnecessary test of *new_dst when checking for same owner
1318 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1320 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1322 2005-11-22 Jim Meyering <jim@meyering.net>
1324 * src/remove.c (AD_push): Remove debugging cruft.
1326 * tests/rm/unread2 (rm): Change expected diagnostic,
1327 `cannot open directory' to `cannot remove', to align with
1329 * tests/rm/rm2: Ensure that rm now continues removing entries
1330 even after certain types of failure.
1332 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1333 that provide openat (Solaris), and on systems like Linux+procfs
1334 where our openat emulation code is reentrant. This also fixes a
1335 few low-probability leaks and eliminates some code that could,
1336 in very unusual circumstances, cause rm() (via a callee) to exit.
1337 * NEWS: Mention this.
1339 * configure.ac: Put copyright dates all on one line so the
1340 emacs function that updates them works properly.
1342 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1344 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1345 Problem reported by Eric Blake.
1346 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1347 we get a standard-conforming compiler. This relies on the new
1348 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1349 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1350 m4/c.m4 can go away with Autoconf 2.60 comes out.
1352 2005-11-17 Jim Meyering <jim@meyering.net>
1354 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1355 (AD_mark_current_as_unremovable): Likewise, but for a local.
1358 * tests/mv/acl: Let traps handle removing temporary directories.
1360 Expect acl-related tests to fail, until the corresponding
1361 patches are committed.
1362 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1363 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1365 ACL tests, from Andreas Gruenbacher.
1366 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1367 * tests/mv/Makefile.am (TESTS): Add acl.
1368 * tests/cp/Makefile.am (TESTS): Add acl.
1370 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1372 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1374 * NEWS: Improve quality of ln's diagnostics.
1375 * src/ln.c (do_link, usage): Likewise.
1376 (do_link): Don't use alloca on a buffer of unbounded size.
1378 2005-11-16 Jim Meyering <jim@meyering.net>
1380 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1381 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1382 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1383 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1384 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1386 2005-11-14 Jim Meyering <jim@meyering.net>
1388 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1390 2005-11-13 Jim Meyering <jim@meyering.net>
1392 * announce-gen: Accept new option, --gpg-key-id=ID and
1393 emit a blurb telling how to use the .sig files.
1394 * Makefile.cfg (gpg_key_ID): Define.
1395 * Makefile.maint (announcement): Use new option and key.
1397 Require that most .c files include <config.h>.
1398 * Makefile.maint (sc_require_config_h): New rule.
1399 (syntax-check-rules): Add it.
1400 * .x-sc_require_config_h: New file listing exceptions to the
1401 above rule. Some are legit, others are simply grandfathered in.
1402 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1404 2005-11-12 Jim Meyering <jim@meyering.net>
1406 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1408 2005-11-11 Jim Meyering <jim@meyering.net>
1410 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1411 Mention new readlink options in 5.3.0's `New features' section.
1412 Spotted by Thomas Hood.
1414 2005-11-08 Jim Meyering <jim@meyering.net>
1416 * NEWS: Merge in changes from b5_9x branch.
1418 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1420 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1421 like --time-style='posix-long-iso' if the locale settings are messed up.
1422 * src/ls.c (decode_switches): Implement this.
1424 2005-11-08 Jim Meyering <jim@meyering.net>
1426 * tests/du/2g: s/expensive/very expensive/ in a comment.
1429 2005-10-17 Eric Blake <ebb9@byu.net>
1431 * src/ls.c (usage): Fix descriptions of --sort, --time.
1432 Reported by Vitaly A. Ostanin.
1434 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1436 * src/ln.c: Include filenamecat.c.
1437 (FILE_BASENAME_CONCAT): Remove.
1438 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1439 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1440 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1443 2005-11-04 Jim Meyering <jim@meyering.net>
1445 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1446 on systems with stat.st_blocks of a signed 32-bit type.
1447 This bug causes trouble on some AIX 5.1 systems.
1448 Report and trivial patch from Paul Townsend:
1449 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1450 * NEWS: Mention this.
1452 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1453 * tests/du/Makefile.am (TESTS): Add it here.
1454 * tests/very-expensive: New file.
1455 * tests/Makefile.am (EXTRA_DIST): Add it here.
1456 * tests/cp/perm: Mark this test as `very-expensive', too.
1458 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1460 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1462 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1464 * src/rm.c (usage): Don't mention rm -d.
1466 2005-11-02 Jim Meyering <jim@meyering.net>
1468 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1469 From Andreas Schwab.
1471 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1472 `M+N records in/out' lines don't pollute `make check' output.
1474 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1475 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1476 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1477 to indicate that the input file should be piped into the command
1478 under test (via `cat FILE | $prog ...').
1480 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1481 (without -r) fails to remove a directory on a non-Linux system.
1482 This change affects only newer Solaris systems (with priv_*
1483 functions like priv_allocset). Reported by Keith Thompson.
1485 * tests/rm/dir-nonrecur: New file/test for the above fix.
1486 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1488 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1490 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1491 POSIX 1002.1-2001 requires.
1492 * src/tail.c (parse_obsolete_option): Implement this.
1493 Problem reported by Vincent Lefevre.
1494 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1495 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1496 (test_vector): Add special cases for _POSIX2_VERSION, and
1497 regularize the old ones a bit.
1498 * tests/touch/obsolescent: Add y2000 test.
1500 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1502 * src/dd.c (skip): Fix off-by-one error reported by
1503 Theodoros V. Kalamatianos.
1505 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1507 * tests/mkdir/p-3: Require that the test be run as non-root.
1508 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1510 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1512 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1513 boundary between DEST and SOURCE in the result.
1515 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1517 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1518 back to text, to sync with documentation and for backwards
1521 2005-10-25 Jim Meyering <jim@meyering.net>
1523 * tests/dircolors/simple (other-wr): Add an explicit test for
1524 the dircolors bug (NULL-dereference) fixed yesterday.
1526 2005-10-24 Jim Meyering <jim@meyering.net>
1528 * src/tac.c (tac_file): When determining whether a file is seekable,
1529 also test whether it is a tty. Using only the lseek-based test would
1530 give a false positive on Solaris. Reported by Peter Fales.
1532 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1534 * tests/install/d-slashdot: New test, for "install -d" failure.
1535 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1536 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1537 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1539 2005-10-24 Jim Meyering <jim@meyering.net>
1541 * src/dircolors.c (ls_codes): Add missing comma.
1542 Anonymous report and patch from
1543 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1545 * src/dircolors.c: Add compile-time assertion that the slack_codes
1546 and ls_codes arrays have the same number of elements. This would
1547 have prevented the above-fixed bug.
1549 * src/expand.c (parse_tab_stops): Add a comment to make this function
1550 identical to the one in unexpand.c.
1551 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1552 identical to the one in expand.c.
1554 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1556 2005-10-23 Jim Meyering <jim@meyering.net>
1558 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1559 a dangerous pointer-value-to-`unsigned' cast.
1560 * NEWS: mention the new sha* programs.
1561 * AUTHORS: Add new sha* programs.
1563 2005-08-28 David Madore <david.madore@ens.fr>
1565 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1566 * README: Add their names to the list.
1567 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1568 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1569 Rules for compiling sha-2 utilities
1570 (noinst_HEADERS): Remove checksum.h.
1571 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1573 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1574 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1575 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1576 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1577 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1578 sha384sum, sha512sum test scripts here rather that each in its
1581 2005-08-28 David Madore <david.madore@ens.fr>
1583 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1584 of the FIPS test vectors).
1586 2005-10-23 Jim Meyering <jim@meyering.net>
1588 * configure.ac: Use 6.0-cvs as the version string.
1589 * NEWS: Adjust accordingly.