1 2006-05-27 Jim Meyering <jim@meyering.net>
5 * src/chgrp.c: Support new options: --preserve-root and
6 --no-preserve-root. Somehow this program was skipped when those
7 options were added to chown, chmod, and rm. Reported by
8 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
10 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
12 * NEWS: Remove mention of --seed. We'll replace it with something
13 better, and don't want to indicate that it is supported.
14 * src/sort.c (usage): Likewise.
16 2006-05-20 Jim Meyering <jim@meyering.net>
18 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
20 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
21 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
22 FTS_COMFOLLOW. Spotted by Justin Pryzby.
24 * gnupload: Merge changes from automake, retaining the ""--to...
25 kludge to placate overzealous `make distcheck' check.
27 2006-05-19 Jim Meyering <jim@meyering.net>
29 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
30 FTS_TIGHT_CYCLE_CHECK directory traversal option.
31 Reported by Justin Pryzby in http://bugs.debian.org/367691
33 2006-05-15 Jim Meyering <jim@meyering.net>
35 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
38 2006-05-13 Jim Meyering <jim@meyering.net>
40 * tests/mv/no-target-dir: Test two more cases.
42 2006-05-11 Jim Meyering <jim@meyering.net>
44 mv -T DIR EMPTY_DIR no longer fails unconditionally
45 * src/copy.c (copy_internal): Don't manually prohibit a move where
46 the destination is an existing directory. Sometimes doing that is
47 valid. Let the rename system call enforce the rules. That is
48 allowed only when the source is a directory and the destination
49 directory (to be replaced) is empty. Reported by Eric Blake.
50 * tests/mv/no-target-dir: New file/test for this.
51 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
54 * tests/mv/atomic: New file/test for yesterday's fix.
55 * tests/mv/Makefile.am (TESTS): Add atomic.
57 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
59 2006-05-10 Jim Meyering <jim@meyering.net>
61 * src/copy.c (copy_internal): Don't explicitly unlink the destination
62 when moving a symlink into the place of an existing non-directory.
63 Reported by Joshua Hudson.
66 2006-05-07 Jim Meyering <jim@meyering.net>
68 * Makefile.maint (patch-check): Fail if patch generates any output,
69 even merely for changed offsets.
71 * src/c99-to-c89.diff: Adjust to reflect new offsets.
73 * NEWS: Mention changes affecting df, pwd, shred.
75 2006-05-06 Jim Meyering <jim@meyering.net>
77 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
78 system condition where dirent.d_ino != stat.st_ino.
79 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
81 2006-05-06 Eric Blake <ebb9@byu.net>
83 * tests/ls/inode: Expand to test inode from readdir case.
84 * tests/ls/follow-slink: Expand to test broken links encountered
85 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
87 2006-05-06 Eric Blake <ebb9@byu.net>
89 * tests/mv/leak-fd: Work even on case-insensitive file system.
91 2006-05-04 Jim Meyering <jim@meyering.net>
93 * NEWS: Mention the 2006-03-19 pwd-related change that makes
94 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
96 2006-05-03 Jim Meyering <jim@meyering.net>
98 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
99 Use better macro parameter names: s/basename/key_name/,
100 s/basefunc/key_cmp_func. Fix typo in comment.
102 2006-04-29 Eric Blake <ebb9@byu.net>
104 * src/ls.c (main): On systems with d_type, directories_first only
105 implies format_needs_type, not format_needs_stat.
107 2006-05-03 Jim Meyering <jim@meyering.net>
109 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
110 after comma in arg list, from Eric Blake.
112 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
114 * tests/misc/date (relative-3): New test, derived from a bug
115 report by John Thomas McDole.
117 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
119 New option for ls: --group-directories-first.
120 It makes ls list directories before files.
121 * NEWS [New features]: Mention it.
122 * src/ls.c (sort_type): Rearrange to use as an array index when
123 choosing sort function; added new sort_numtypes member for
125 (time_type): Add new time_numtypes member for compile-time check.
126 (directories_first): New global variable.
127 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
128 (long_options): Add --directories-first.
129 (main): Support new option.
130 (is_directory): New function.
131 (extract_dirs_from_files): Use it.
132 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
133 (LIST_SORTFUNCTION_VARIANTS): New macros.
134 (sort_functions): New global variable.
135 (sort_files): Use it.
136 (usage): Document new option.
138 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
140 * src/shred.c (fillrand): The assertion was way too weak, due to
141 what must be a typo. Strengthen it to its intended value.
142 (dopass): Don't use alloca; it's not worth the aggravation here,
143 since it's used only to get a page-aligned buffer, and page
144 alignment doesn't buy us much here. I'm suspicious that alloca
145 causes problems on some hosts, due to a recent bug report by Adam
146 Waltman: http://bugs.gentoo.org/130246.
148 2006-04-18 Jim Meyering <jim@meyering.net>
150 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
151 sha384sum, sha512sum.
153 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
155 * src/chmod.c (describe_change): Adjust to filemode changes.
156 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
157 (print_long_format): Use (new) filemodestring rather than
158 (old) mode_string, so that we get more file types right, at least
159 in theory. Adjust to filemode changes.
160 * src/stat.c (human_access): Likewise.
162 2006-04-18 Jim Meyering <jim@meyering.net>
164 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
165 ignore file. This has never been enabled. Reported by Eric Blake.
167 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
169 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
170 bug in Interix. Just call symlink or link directly. All uses changed.
171 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
172 * src/stat.c (USE_STATVFS): New macro.
173 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
174 (NAMEMAX_FORMAT): define a bit more clearly, now that the
175 statvfs-using code is a bit more regular.
176 * src/system.h (sync) [!HAVE_SYNC]: New macro.
178 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
180 * NEWS: csplit, nl, expr now conform to POSIX better, and are
181 more-compatible with traditional Unix, with respect to regular
183 * src/csplit.c (extract_regexp): Set re_syntax_options to a
184 value that is compatible with what POSIX requires.
185 * src/nl.c (build_type_arg): Likewise.
186 * src/expr.c (docolon): Likewise. Also, don't let anchors match
187 newline; this fixes an incompatibility with tradition and with POSIX.
188 Don't warn about leading ^. POSIX says it is unspecified whether
189 ^ is a special character, which means that implementations can
190 either treat it as special or not, but either way a warning is not
191 allowed (unless the regexp is otherwise invalid). Instead, anchor
192 the expression but treat ^ as an anchor; this is the traditional
193 behavior (e.g., Solaris 10).
194 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
195 and the like as invalid expressions (exit status 2), not as
196 failure of 'expr' (exit status 3). This is more consistent with
198 * tests/expr/basic (fail-a): Adjust exit status to match new expr
199 behavior, for status 2 versus 3.
201 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
202 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
203 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
204 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
205 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
206 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
207 (bre61, bre62): New tests.
208 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
212 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
213 "if !". Do not assume that 'sed' can handle long, newline-free input.
214 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
216 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
218 Adjust to new regex.h API (with new fastmap type), and clean
219 up the regex storage allocation a bit.
221 * src/csplit.c (struct control): Put re_compiled member at the
222 end, since it's large. Change regexpr member from char * to bool;
223 all uses changed. Add new member fastmap.
224 (extract_regexp): regexp arg is now char const *, not char *.
225 Don't bother duplicating the regular expression; it's not needed.
226 Set fastmap from new fastmap member. Don't bother allocating
227 a buffer, as the regexp code does a better job than we do.
228 * src/expr.c (docolon): Allocate and use a fastmap.
229 Don't bother allocating a buffer.
230 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
232 (build_type_arg): New fastmap arg. All uses changed.
233 Don't bother allocating a buffer, but set a fastmap.
234 * src/ptx.c (context_regex_string, word_regex_string): Remove.
235 (context_regex, word_regex): New vars, replacing the above.
237 (struct regex_data): New type.
238 (compile_regex): Renamed from alloc_and_compile_regex, since
239 we no longer allocate storage. Arg is now a struct regex_data *,
240 not a const char *. All uses changed. Don't allocate the fastmap;
241 instead, take it from the caller. Don't convert size_t to int,
242 to avoid arithmetic overflow problems. Don't bother freeing
243 storage afterwards; it's not worth the aggravation.
244 * src/tac.c (compiled_separator_fastmap): New ver.
245 (main): Use it. Don't bother allocating a buffer.
247 2006-03-30 Jim Meyering <jim@meyering.net>
249 * src/dd.c (iwrite): Remove assignment without effect.
250 Reported by Felix Rauch Valenti.
252 2006-03-22 Eric Blake <ebb9@byu.net>
254 * src/ptx.c (usage): Remove mention of --copyright/-C.
255 (main): Alias --copyright to --version plus a deprecation warning.
256 * NEWS: Mention this.
258 2006-03-27 Jim Meyering <jim@meyering.net>
260 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
261 use of strtod. Tiny patch from Nickolai Zeldovich.
263 2006-03-11 Eric Blake <ebb9@byu.net>
265 * tests/misc/dirname: New file.
266 * tests/basename/Makefile.am: Delete.
267 * tests/basename/basic: Move to...
268 * tests/misc/basename: ... this new file. Add some tests,
269 including fixed behavior for //.
270 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
271 * tests/Makefile.am (SUBDIRS): Remove basename.
272 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
274 Improvements to dirname/basename handling on platforms like
275 cygwin with distinct // and with drive letters.
276 * NEWS: Document new behavior.
277 * src/basename.c (main): Don't strip suffix from file system
279 * src/cp.c (target_directory_operand): Use new last_component.
280 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
281 traversing the string.
282 * src/dircolors.c (guess_shell_syntax): Use new last_component.
283 * src/install.c (target_directory_operand, install_file_in_dir):
285 * src/ln.c (target_directory_operand, main): Likewise.
286 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
287 * src/mv.c (target_directory_operand, movefile): Likewise.
288 * src/remove.c (rm_1): Likewise.
289 * src/shred.c (wipename): Likewise.
290 * src/split.c (next_file_name): Likewise.
291 * src/su.c (log_su, run_shell): Likewise.
293 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
295 * NEWS: nohup diagnostics are now more precise, and nohup now
296 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
297 * src/nohup.c (main): Implement this.
298 * tests/misc/nohup: Test the new behavior.
300 2006-03-12 Jim Meyering <jim@meyering.net>
302 * src/copy.c (set_author): Rename function, from preserve_author.
304 * src/remove.c (AD_pop_and_chdir): Use new macro,
305 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
307 * src/system.h (SAME_INODE): Remove definition.
308 Include "same-inode.h", instead.
310 2006-03-11 Eric Blake <ebb9@byu.net>
312 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
314 2006-03-10 Jim Meyering <jim@meyering.net>
316 Fix a bug whereby a user with write access to a directory being removed
317 could cause the removal of that directory to fail with an erroneous
318 diagnostic about a directory cycle. Reported by Vineet Chadha.
320 * NEWS: Mention this.
321 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
322 leave (and try to rmdir) is the one whose dev_ino is being used to
323 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
325 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
327 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
328 * src/dd.c (set_fd_flags): Handle file-creation flags on file
329 descriptors, rather than ignoring them.
330 * tests/dd/misc: Add test cases for append, nofollow, directory,
331 and nolinks flags. Simplify redirection to /dev/null in some cases.
333 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
334 noatime test never tested anything.
336 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
338 * src/dd.c (flags, usage): New flags directory, nolinks.
339 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
341 * src/ls.c (usage): Mention that -f disables --color.
342 Problem reported by Niels Möller.
344 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
346 * man/*.x: Add references to syscalls from utilities of the same name.
348 2006-03-05 Jim Meyering <jim@meyering.net>
350 * tests/help-version: Set SHELL, if not already set, in order to
351 avoid failure when `make check' is run through debuild; dircolors
352 would fail due to lack of $SHELL. Reported by Sven Joachim.
354 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
355 * src/base64.c (wrap_write, do_encode, main): Change type of
356 parameters and locals, wrap_column, form size_t to uintmax_t.
357 (main): Adjust to use xstrtoumax, accordingly.
359 2006-03-03 Jim Meyering <jim@meyering.net>
361 Don't fail when run from an environment with SHELL not a Bourne
362 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
363 * tests/dircolors/simple: Invoke each non-failing test with -b.
364 Reported by Michael Stone.
366 2006-02-27 Jim Meyering <jim@meyering.net>
368 * tests/misc/base64: Derive --decode-using tests from the
371 * tests/misc/base64: Factor out a long constant string.
372 Split lines to stay within 80 columns.
374 * tests/misc/Makefile.am (TESTS): Add base64.
375 * tests/misc/base64: Test base64. From Simon Josefsson.
377 * src/base64.c (do_decode): Use correct type for parameter,
378 ignore_garbage: s/size_t/bool/.
380 * src/base64.c: Don't include .h files already included by system.h:
381 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
382 Include "system.h" before the other lib/*.h header files.
383 Include <sys/types.h> before "system.h".
384 (wrap_write): Remove declaration of unused local, initial_column.
385 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
387 * README: Add base64 to the list.
389 2006-02-17 Simon Josefsson <jas@extundo.com>
392 * AUTHORS: Mention base64.
394 * man/Makefile.am: Build base64.1.
395 * man/base64.x: New file.
396 * src/Makefile.am (bin_PROGRAMS): Add base64.
397 * src/base64.c: New file.
399 2006-02-25 Eric Blake <ebb9@byu.net>
401 In ls, avoid calling stat for --inode (-i), when possible.
402 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
403 * src/system.h: ... here, for use in ...
404 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
406 (gobble_file): Add inode argument.
407 (print_dir): Pass inode if available.
408 (usage): Remove inaccuracy.
410 2006-02-23 Jim Meyering <jim@meyering.net>
412 * TODO: Update/correct some obsolete entries.
414 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
416 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
417 * src/join.c (usage): Likewise.
418 Documentation problem reported by Philip Kensche.
420 2006-02-20 Eric Blake <ebb9@byu.net>
422 * man/rm.x: Update documentation to match previous patch.
424 2006-02-18 Eric Blake <ebb9@byu.net>
426 New option for rm: --interactive=once (-I).
427 * NEWS: Document it, along with change to rm --interactive.
428 * TODO: Remove entry for implementing rm -I
429 * src/rm.c (INTERACTIVE_OPTION): New enum value.
430 (interactive_type): New enum.
431 (long_opts): Let interactive take an optional argument.
432 (interactive_args, interactive_types): New option arguments.
433 (usage): Document -I, --interactive=WHEN. Use program_name
434 instead of a basename.
435 (main): New -I option, new behavior to --interactive.
436 * tests/rm/interactive-once: New tests.
437 * tests/rm/interactive-always: Ditto.
438 * tests/rm/Makefile.am (TESTS): Run them.
440 2006-02-18 Jim Meyering <jim@meyering.net>
442 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
443 expression match more of the target lines, e.g., those that start with
444 `-S,' (short option followed by a comma) or that include `=[...]'.
445 Patch by Nicolas François.
446 Fix the four offenders thus exposed:
447 * src/join.c (usage): Use two spaces (not one) to separate the
448 --first-only option string from its description, so help2man formats
449 the derived man page properly.
450 * src/pr.c (usage): Likewise.
451 * src/uniq.c (usage): Likewise.
452 * src/install.c (usage): Likewise.
454 2006-02-15 Jim Meyering <jim@meyering.net>
456 * Makefile.maint (alpha beta major): For `make major', ensure that the
457 version string is of the form N.N[.N]*, where N is one or more digits.
459 2006-02-14 Jim Meyering <jim@meyering.net>
461 * INSTALL: Update from gnulib.
463 2006-02-13 Jim Meyering <jim@meyering.net>
465 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
467 2006-02-12 Jim Meyering <jim@meyering.net>
469 * Makefile.maint (patch-check): New target.
470 (local-checks-available): Add to the list.
472 2006-02-11 Jim Meyering <jim@meyering.net>
474 * src/c99-to-c89.diff: New file.
475 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
477 * .x-po-check: New file, with exclusions so that `make distcheck'
479 * Makefile.am (EXTRA_DIST): Add .x-po-check.
481 rm -r must remove an empty directory, even if it is inaccessible.
482 * src/remove.c (close_preserve_errno): New function.
483 (fd_to_subdirp): Don't print a diagnostic in this function.
484 Do it from the callers instead, unless rmdir succeeds.
485 (remove_cwd_entries, remove_dir): Adjust callers.
486 * tests/rm/empty-inacc: New test for the above.
487 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
488 * NEWS: Mention this bug fix.
489 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
490 a tiny bit less precise: cannot remove `a/1': ... instead of
491 cannot open directory `a/1': ...
493 * Makefile.maint (syntax-check-rules): Automatically derive this
494 list of sc_-prefixed rule names.
496 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
498 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
499 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
500 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
501 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
502 go away? was that an accident?)
503 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
504 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
505 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
506 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
507 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
508 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
509 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
510 (author_mark_check, makefile_path_separator_check):
511 Output line numbers, to simplify navigation of Emacs *compilation*
513 (sc_prohibit_atoi_atof, sc_file_system):
514 Rework slightly so that Makefile.maint doesn't get reported as a
515 violation of its own syntax rules.
516 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
517 it at run-time (which didn't work with Bison). Fix a makefile typo,
518 caught by Makefile.maint itself: spaces where a tab should be.
519 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
520 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
521 Ignore djgpp and man subdirectories, to avoid false matches with
522 Bison and coreutils, respectively. Use sort -u to remove the
523 resulting duplicates.
524 * gnupload: Rework slightly to avoid bogus warning from
525 sc_two_space_separator_in_usage.
527 2006-02-10 Jim Meyering <jim@meyering.net>
529 Use gzip's --rsyncable option only if it's available.
530 * Makefile.maint (gzip_rsyncable): New variable.
533 2006-02-08 Jim Meyering <jim@meyering.net>
535 * Makefile.maint (local-checks-available): Define in terms of
536 the expansion, $(syntax-check-rules), rather than the single,
537 top-level target `syntax-check', so that it's easier to exclude
538 individual rules (via $(local-checks-to-skip)).
539 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
541 2006-02-07 Jim Meyering <jim@meyering.net>
543 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
544 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
546 * tests/help-version (expected_failure_status_vdir):
547 Redirect an expected disk-full diagnostic to /dev/null.
549 2006-02-06 Jim Meyering <jim@meyering.net>
551 * src/unexpand.c (usage): Use two spaces (not one) to separate the
552 --first-only option string from its description, so help2man formats
553 the derived man page properly.
554 * src/rm.c (usage): Likewise for --no-preserve-root.
555 * src/chown.c (usage): Likewise.
556 * src/chgrp.c (usage): Likewise.
558 Add a rule to ensure that the above doesn't happen again.
559 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
560 (syntax-check-rules): Add it.
561 * .x-sc_two_space_separator_in_usage: New empty file.
562 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
564 2006-02-06 Jim Meyering <jim@meyering.net>
566 * src/cp.c (usage): Use two spaces (not one) to separate each
567 option string from its description, so help2man formats the
568 derived man page properly.
569 * src/mv.c (usage): Likewise.
570 Patch from Nicolas François in http://bugs.debian.org/351601.
572 2006-02-04 Jim Meyering <jim@meyering.net>
574 * src/copy.c (copy_internal): cp -RL would fail when encountering
575 the same directory more than once in the hierarchy beneath a single
576 command-line argument. That is legitimate, e.g. when there are
577 two or more symbolic links, each pointing to some directory that
578 would not otherwise be copied. Reported by Christophe LYON.
579 * tests/cp/cp-deref: New file. Test for today's fix.
580 * tests/cp/Makefile.am (TESTS): Add cp-deref.
581 * NEWS: Document this.
583 2006-02-03 Jim Meyering <jim@meyering.net>
585 * configure.ac: Require automake-1.9.6, not 1.8.3.
587 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
589 * src/od.c (usage): Mention that -t a ignores high order bit.
590 Documentation problem reported by Ed Avis.
592 2006-02-01 Jim Meyering <jim@meyering.net>
594 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
596 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
598 * src/head.c (main): Use a better diagnostic when someone uses a
599 trailing numeric option in an invalid way. Problem reported by
601 * src/tail.c (parse_options): Likewise.
603 2006-01-30 Jim Meyering <jim@meyering.net>
605 * man/wc.x: Include `count' keyword in man page synopsis,
606 per suggestion from http://bugs.debian.org/181585.
608 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
610 * src/df.c (show_dev): If the file system claims to have
611 more available than total blocks, report the number of used
612 blocks as being total - available (a negative number) rather
613 than as garbage. Problem reported by Toralf Foerster.
615 2006-01-24 Jim Meyering <jim@meyering.net>
617 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
618 to put a regular file in O_NONBLOCK mode fails with EPERM.
619 That happens on Linux (up to 2.6.15) when using tail -f on a file with
620 the append-only attribute. Reported by Dean Gaudet. For details,
621 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
622 * NEWS: Mention this fix.
623 * tests/tail-2/append-only: New file. Test for the above.
624 * tests/tail-2/Makefile.am (TESTS): Add append-only.
625 * tests/Makefile.am (check-root): Add tail-2/append-only
627 2006-01-21 Jim Meyering <jim@meyering.net>
629 * NEWS: Mention fts-related improvements and bug fixes.
631 2006-01-19 Jim Meyering <jim@meyering.net>
633 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
634 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
636 2006-01-18 Jim Meyering <jim@meyering.net>
638 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
640 2006-01-17 Jim Meyering <jim@meyering.net>
642 Now that fts no longer changes the current working directory, adjust
643 its clients accordingly -- note that du.c uses fts but doesn't need
644 any adjustment, since it doesn't operate on the actual files,
645 but rather just uses the stat buffers provided by fts.
647 * src/chown-core.c: Include "openat.h".
648 Don't include "lchown.h".
649 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
650 calling openat, lchownat, chownat, rather than open, lchown, chown.
652 * src/chmod.c: Include "openat.h".
653 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
655 * tests/du/long-from-unreadable: New test, to exercise one small
658 2006-01-13 Jim Meyering <jim@meyering.net>
660 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
661 addition of new directories under tests/.
663 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
666 2006-01-12 Jim Meyering <jim@meyering.net>
668 * tests/du/long-sloop: Adjust not to hard-code the expected
669 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
670 from that of GNU libc. Reported by Paul Eggert.
672 * tests/du/long-sloop: Create file at end of symlink chain.
674 * tests/misc/test: New file, with a test for one of the
675 bugs fixed by yesterday's test.c changes.
676 * tests/misc/Makefile.am (TESTS): Add test.
678 2006-01-11 Jim Meyering <jim@meyering.net>
680 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
681 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
682 a very long sequence of symbolic links (not necessarily a loop).
683 * tests/du/Makefile.am (TESTS): Add long-sloop.
685 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
687 * src/test.c (test_syntax_error): Append a newline. All callers
688 changed, except for the ones that didn't already append a newline.
689 Bug reported by Eric Blake.
691 2006-01-11 Jim Meyering <jim@meyering.net>
693 * src/system.h (X2NREALLOC): Now that verify_true is no longer
694 void, cast its result to void, to avoid gcc's warning that
695 ``left-hand operand of comma expression has no effect''.
696 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
698 2006-01-10 Jim Meyering <jim@meyering.net>
700 * tests/chmod/no-x: Add a test for today's fts.c fix.
702 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
704 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
705 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
707 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
709 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
710 Use verify_true instead of verify_expr, to sync with gnulib.
712 2006-01-08 Jim Meyering <jim@meyering.net>
714 * src/date.c (usage): Adjust the formatting of the entries for
715 %::z and %:::z (separate with two spaces, not one) so that help2man
716 formats them properly. Reported by Philip Rowlands.
718 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
720 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
722 2006-01-06 Jim Meyering <jim@meyering.net>
724 * Makefile.maint (copyright-check): Use date +%Y in place of
727 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
728 First off, the attribute should have been `volatile' (not static)
729 to avoid longjmp-related risk of clobber. Secondly, now there is
730 no longer any risk of a local variable being clobbered, so there's
731 no need for any attribute at all.
733 2006-01-05 Jim Meyering <jim@meyering.net>
735 * src/remove.c: Give a few functions the inline attribute.
736 (AD_pop_and_chdir): Use gotos to avoid some duplication.
737 (AD_push): Rewrite an assertion so that the entire computation
738 goes away when assertions are turned off.
740 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
741 It's already defined in "system.h".
742 * Makefile.maint: Add a FIXME comment.
744 2006-01-04 Jim Meyering <jim@meyering.net>
746 * ChangeLog: Remove entries from 2005-10-22 and earlier.
747 * ChangeLog-2005: New file, for entries up to version 5.92.
749 2006-01-03 Jim Meyering <jim@meyering.net>
751 * tests/du/no-x: Also allow a slightly different diagnostic -- the
752 one you get when using openat-enabled fts.c and du (coming soon).
753 * tests/chmod/no-x: Likewise.
754 * tests/chgrp/no-x: Likewise.
756 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
758 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
760 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
761 (restricted_chown): Return it, if the file cannot be accessed due
762 to EPERM, or if no uid or gid are required, or if the file is
763 neither a directory nor a regular file. Rewrite to avoid gotos.
764 (change_file_owner): Handle RC_do_ordinary_chown case.
765 Rewrite to avoid gotos.
766 * tests/chgrp/basic: Make sure we can change the group of
769 * src/date.c (usage): Explain %g, %G, and %V a bit better.
771 2006-01-02 Jim Meyering <jim@meyering.net>
773 * src/copy.c (set_owner): Correct a comment.
775 * src/tail.c (parse_options): Change warning to say that --retry
776 is useful `mainly' (not `only') when following by name.
777 Reported here: http://bugs.debian.org/273781
779 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
781 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
782 * src/copy.c: Include lchmod.h.
783 (copy_internal): Use lchmod rather than chmod.
784 * src/cp.c: Include lchmod.h.
785 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
786 * src/mkdir.c: Include lchmod.h.
787 (usage): Clarify -m's operation.
788 (main): Use lchmod rather than chmod. Don't use lchmod unless the
789 new mode contains bits outside the 777 range.
790 * src/mkfifo.c (usage): Clarify -m's operation.
791 (main): If -m is given, don't invoke chmod; use umask 0 instead.
792 Report an error if -m asks for bits outside the 777 range.
793 * src/mknod.c (usage, main): Likewise.
795 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
797 2005-12-27 Jim Meyering <jim@meyering.net>
799 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
800 (sc_prohibit_assert_without_use): New rule.
801 (syntax-check-rules): Add it to the list.
802 * .x-sc_prohibit_assert_without_use: New empty file.
803 * Makefile.am (EXTRA_DIST): Add it.
805 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
807 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
808 Don't include <assert.h>; it wasn't used.
810 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
812 * src/chown-core.c (restricted_chown):
813 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
814 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
815 | O_NOFOLLOW too, for consistency with other dir-openers.
816 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
817 (is_empty_dir): Likewise.
818 * src/shred.c (wipename): Likewise. Don't bother trying to open
819 dir for writing, since POSIX prohibits it.
821 2005-12-22 Jim Meyering <jim@meyering.net>
823 * tests/help-version: Redirect stderr to /dev/full, to suppress
824 write error diagnostic.
826 2005-12-19 Jim Meyering <jim@meyering.net>
828 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
829 Avoid a minor race condition when `-m MODE' is specified, by using
830 open, fchown, and close rather than just chown. To do that reliably --
831 even with an overly restrictive umask -- ensure that each mkdir,
832 mknod and mkfifo call uses a mode including at least owner-read access.
833 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
834 the subsequent chown (or equivalent open,fchown,close) fails.
835 * tests/misc/mknod: New tests.
836 * tests/misc/Makefile.am (TESTS): Add mknod.
838 2005-12-17 Jim Meyering <jim@meyering.net>
840 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
841 e.g., on a named pipe.
842 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
843 place of all uses, since it is guaranteed (system.h) to be defined.
845 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
847 Add POSIX ACL support
848 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
849 is no requirement for ACL support; particularly, it does not exist
850 on systems that have POSIX ACLs.
851 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
852 * src/cp.c (umask_kill): With default acls, the umask is not to be
853 applied. Remove umask_kill, don't change the process umask, and let
854 the kernel apply the umask where appropriate.
855 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
856 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
858 (copy_reg, copy_internal): Use copy_acl and set_acl
859 instead of fchown/chown. Fix the logic for POSIX ACLs.
860 (chown_succeded): Remove; we now always copy acls and
861 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
862 did a chown before or not.
863 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
864 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
865 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
866 to link with it via $(LIB_ACL), for the utilities that need it.
868 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
870 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
871 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
872 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
873 value is now signified by whether cwd_errno is null.
874 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
875 pointer-to-bool to pointer-to-errno-value. All callers changed.
876 (rm_1): Don't bother setting a local cwd failure flag and then
877 ORing it into the caller's. Just set the caller's.
878 (rm): Use cwd failure errno value to print a slightly-better
881 2005-12-15 Jim Meyering <jim@meyering.net>
883 * src/stat.c (print_it): Properly handle a backslash at the
884 end of a --printf format string. Reported by Paul Eggert.
885 * tests/misc/stat-printf (end-bs): Add a test for the above.
887 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
889 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
890 Don't assume /etc/passwd contains user names; use 'id' instead.
892 2005-12-15 Jim Meyering <jim@meyering.net>
894 stat: revert behavior of --format=FMT (-c)
895 stat: add new option: --printf=FMT
896 * NEWS: Mention this.
897 * src/stat.c (isodigit, octtobin, hextobin): Define.
898 (PRINTF_OPTION): Define.
899 (interpret_backslash_escapes, trailing_delim): New globals.
900 (usage): Document them. Alphabetize on long option names.
901 (print_esc_char): New function.
902 (print_it): Rewrite, in order to handle backslash escapes.
903 (main): Handle new option. Set globals for --format, too.
905 * tests/misc/stat-printf: Test --printf and --format.
906 * tests/misc/Makefile.am (TESTS): Add stat-printf.
908 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
910 * NEWS: sort now reports incompatible options.
911 * src/sort.c (incompatible_options, check_ordering_compatibility):
913 (main): Use them. Don't bother with a usage message for
914 "sort -c a b", for consistency with other error diagnostics.
915 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
918 * src/cat.c (main): Undo previous change. close_stdout already
919 does the check, so the previous change wasn't necessary.
921 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
923 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
925 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
927 Install a more-conservative approach for sort -R. It's the
928 same basic idea as the existing code, except it uses the full ISAAC
929 approach (called the "more kosher" approach in the existing comments).
930 This makes "sort -R" quite a bit slower (about a factor of 2 on my
931 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
932 better to be conservative here at first, and review any performance
933 improvements carefully.
934 * .x-sc_require_config_h: Add src/rand-isaac.c.
935 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
936 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
937 (shred_SOURCES, sort_SOURCES): Remove.
938 (EXTRA_DIST): Add rand-isaac.c.
939 * src/rand-isaac.c: Revert to what used to be in shred.c, without
940 changing it to allow for varying numbers of words in the state.
941 Alter so that we include rand-isaac.c directly rather than
942 compiling it and linking to it. Don't include config.h or
943 system.h; that's the includer's responsibility.
944 Omit functions that are specific to shred.
945 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
946 (isaac_step, struct irand_state):
947 Resurrect these, with the same defns that used to be in shred.c.
948 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
949 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
951 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
952 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
953 (irand_init, irand32, irand_mod):
954 Number of words is constant again.
955 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
956 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
957 * src/sort.c: Likewise.
958 * src/shred.c (fillrand, dopass, main): Undo previous change.
959 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
961 * src/sort.c: Don't include md5.h; it wasn't needed.
962 (struct keyfield): Rename random_hash to random, for consistency
963 with the other member names. All uses changed.
964 (usage): Tweak wording to mention STRING for --seed option.
965 (short_options): Rorder for consistency with other programs.
966 (rand_state): Now a struct, not a pointer to one. All uses changed.
967 (HASH_WORDS, HASH_SIZE): Remove.
968 (get_hash): Remove comments around resbuf size, since we can assume C89.
969 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
970 (keycompare): Adjust to the new get_hash.
972 (badfieldspec): Omit recently-introduced comment; it isn't needed.
973 (main): Don't set need_random simply because gkey has it set; that
974 doesn't necessarily mean we'll need random numbers.
975 Redo seeding to match new get_hash approach.
977 2005-12-10 Jim Meyering <jim@meyering.net>
979 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
981 Avoid shred segfault on 64-bit systems.
982 * src/rand-isaac.c (isaac_refill): Don't try to negate a
983 local of type uint32_t. Make the local an `int' instead.
985 * NEWS: Mention sort's new options.
987 * src/rand-isaac.c (isaac_mix): Declare to be static.
988 Mark all other functions as `extern' so the tight-scope
989 part of `make distcheck' passes once again.
990 * src/rand-isaac.h (isaac_mix): Remove declaration.
992 * src/sort.c (get_hash): Change position of `*' in parameter
993 type to conform with convention.
994 (main): Split a long line so it fits in 80 columns.
995 (keycompare): Remove stray SPACE before TAB that was
996 causing `make distcheck' to fail.
998 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1000 * tests/misc/sort-rand: New file: basic tests for the new options.
1001 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1003 2005-12-10 Frederik Eaton <frederik@ofb.net>
1005 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1006 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1007 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1008 Make state size runtime-configurable.
1009 (isaac_new, isaac_copy): New functions.
1010 * src/rand-isaac.h: New file.
1011 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1012 (fillrand, main): Adjust to the fact that the state size is now
1013 runtime-configurable.
1014 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1015 (usage): Add options --random-sort and --seed to implement a random
1017 Include md5.h and rand-isaac.h.
1018 (get_hash): New function.
1019 (rand_state): New var.
1020 (HASH_WORDS, HASH_SIZE): New macros.
1022 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1024 * tests/dd/misc: Add test for dd iflags=noatime.
1026 2005-12-09 Jim Meyering <jim@meyering.net>
1028 * src/sort.c (usage): Mention white space vs -b and -t options.
1031 2005-12-09 Eric Blake <ebb9@byu.net>
1033 * src/test.c (main): Fix misleading comment.
1035 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1037 * NEWS: Mention dd's new noatime flag.
1038 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1039 * src/dd.c (flags, usage): Add support for noatime flag.
1041 2005-12-07 Jim Meyering <jim@meyering.net>
1043 Distribute the cvsu script, used only by `make syntax-check'.
1044 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1045 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1046 distribute a copy of this script.
1047 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1049 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1050 to create a temporary directory on another partition.
1051 From Andreas Gruenbacher.
1053 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1055 * man/basename.x: Cross-reference to dirname and readlink.
1056 * man/dirname.x: Cross-reference to basename and readlink.
1058 2005-12-05 Andreas Gruenbacher
1060 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1061 (set_owner, preserve_author): New functions, factored out of copy_reg.
1062 (copy_reg): Use them.
1063 (copy_internal): Use them here, too.
1065 2005-12-04 Jim Meyering <jim@meyering.net>
1067 * src/sleep.c (usage): Say what happens with two or more arguments.
1068 Suggested by Justin Pryzby.
1070 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1073 2005-12-03 Jim Meyering <jim@meyering.net>
1075 * src/rm.c (long_opts): Change the name of each undocumented, for-
1076 testing-only option to start with `-', so that it cannot render
1077 ambiguous any prefix it happens to share with some other option name.
1078 Problem reported by Eric Blake.
1079 * src/head.c (long_options): Likewise.
1080 * src/tail.c (long_options): Likewise.
1082 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1083 testing-only --presume* options to start with `---'.
1084 * tests/rm/dangling-symlink: Likewise.
1085 * tests/rm/dir-no-w: Likewise.
1086 * tests/rm/isatty: Likewise.
1088 2005-11-30 Jim Meyering <jim@meyering.net>
1090 * Makefile.maint: Add a comment about cvsu.
1092 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1094 * NEWS: df updates for "none", "proc", inaccessible file systems.
1095 * src/df.c (show_point): Ignore inaccessible file systems.
1096 (usage): -a includes dummy file systems, not size-0 file systems.
1098 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1099 to avoid collision with POSIX name space. All uses changed.
1101 2005-11-24 Jim Meyering <jim@meyering.net>
1103 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1104 * tests/acl: Add `$0: ' prefix to diagnostics.
1106 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1108 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1110 * src/copy.c: Improve performance a bit by optimizing away
1111 unnecessary system calls and going to a block size of at least
1112 8192 (on normal hosts, anyway). This improved performance 5% on my
1113 Debian stable host (2.4.27 kernel, x86, copying from root
1114 ext3 file system to itself).
1115 Include "buffer-lcm.h".
1116 (copy_reg): Omit last argument. All callers changed.
1117 Use xmalloc to allocate rather than trusting alloca
1118 (which is unwise with large block sizes).
1119 Declare locals more locally, if possible.
1120 Use uintptr_t words instead of int words, for a bit more speed
1121 when looking for null blocks on 64-bit hosts.
1122 Optimize away reads of zero bytes on regular files.
1123 In the typical case, insist on 8 KiB buffers, at least.
1124 Avoid unnecessary extra call to fstat when checking for sparse files.
1125 Avoid now-unnecessary cast to off_t, and "0L".
1126 Avoid unnecessary test of *new_dst when checking for same owner
1129 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1131 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1133 2005-11-22 Jim Meyering <jim@meyering.net>
1135 * src/remove.c (AD_push): Remove debugging cruft.
1137 * tests/rm/unread2 (rm): Change expected diagnostic,
1138 `cannot open directory' to `cannot remove', to align with
1140 * tests/rm/rm2: Ensure that rm now continues removing entries
1141 even after certain types of failure.
1143 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1144 that provide openat (Solaris), and on systems like Linux+procfs
1145 where our openat emulation code is reentrant. This also fixes a
1146 few low-probability leaks and eliminates some code that could,
1147 in very unusual circumstances, cause rm() (via a callee) to exit.
1148 * NEWS: Mention this.
1150 * configure.ac: Put copyright dates all on one line so the
1151 emacs function that updates them works properly.
1153 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1155 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1156 Problem reported by Eric Blake.
1157 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1158 we get a standard-conforming compiler. This relies on the new
1159 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1160 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1161 m4/c.m4 can go away with Autoconf 2.60 comes out.
1163 2005-11-17 Jim Meyering <jim@meyering.net>
1165 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1166 (AD_mark_current_as_unremovable): Likewise, but for a local.
1169 * tests/mv/acl: Let traps handle removing temporary directories.
1171 Expect acl-related tests to fail, until the corresponding
1172 patches are committed.
1173 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1174 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1176 ACL tests, from Andreas Gruenbacher.
1177 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1178 * tests/mv/Makefile.am (TESTS): Add acl.
1179 * tests/cp/Makefile.am (TESTS): Add acl.
1181 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1183 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1185 * NEWS: Improve quality of ln's diagnostics.
1186 * src/ln.c (do_link, usage): Likewise.
1187 (do_link): Don't use alloca on a buffer of unbounded size.
1189 2005-11-16 Jim Meyering <jim@meyering.net>
1191 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1192 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1193 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1195 2005-11-14 Jim Meyering <jim@meyering.net>
1197 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1199 2005-11-13 Jim Meyering <jim@meyering.net>
1201 * announce-gen: Accept new option, --gpg-key-id=ID and
1202 emit a blurb telling how to use the .sig files.
1203 * Makefile.cfg (gpg_key_ID): Define.
1204 * Makefile.maint (announcement): Use new option and key.
1206 Require that most .c files include <config.h>.
1207 * Makefile.maint (sc_require_config_h): New rule.
1208 (syntax-check-rules): Add it.
1209 * .x-sc_require_config_h: New file listing exceptions to the
1210 above rule. Some are legit, others are simply grandfathered in.
1211 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1213 2005-11-12 Jim Meyering <jim@meyering.net>
1215 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1217 2005-11-11 Jim Meyering <jim@meyering.net>
1219 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1220 Mention new readlink options in 5.3.0's `New features' section.
1221 Spotted by Thomas Hood.
1223 2005-11-08 Jim Meyering <jim@meyering.net>
1225 * NEWS: Merge in changes from b5_9x branch.
1227 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1229 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1230 like --time-style='posix-long-iso' if the locale settings are messed up.
1231 * src/ls.c (decode_switches): Implement this.
1233 2005-11-08 Jim Meyering <jim@meyering.net>
1235 * tests/du/2g: s/expensive/very expensive/ in a comment.
1238 2005-10-17 Eric Blake <ebb9@byu.net>
1240 * src/ls.c (usage): Fix descriptions of --sort, --time.
1241 Reported by Vitaly A. Ostanin.
1243 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1245 * src/ln.c: Include filenamecat.c.
1246 (FILE_BASENAME_CONCAT): Remove.
1247 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1248 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1249 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1252 2005-11-04 Jim Meyering <jim@meyering.net>
1254 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1255 on systems with stat.st_blocks of a signed 32-bit type.
1256 This bug causes trouble on some AIX 5.1 systems.
1257 Report and trivial patch from Paul Townsend:
1258 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1259 * NEWS: Mention this.
1261 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1262 * tests/du/Makefile.am (TESTS): Add it here.
1263 * tests/very-expensive: New file.
1264 * tests/Makefile.am (EXTRA_DIST): Add it here.
1265 * tests/cp/perm: Mark this test as `very-expensive', too.
1267 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1269 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1271 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1273 * src/rm.c (usage): Don't mention rm -d.
1275 2005-11-02 Jim Meyering <jim@meyering.net>
1277 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1278 From Andreas Schwab.
1280 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1281 `M+N records in/out' lines don't pollute `make check' output.
1283 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1284 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1285 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1286 to indicate that the input file should be piped into the command
1287 under test (via `cat FILE | $prog ...').
1289 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1290 (without -r) fails to remove a directory on a non-Linux system.
1291 This change affects only newer Solaris systems (with priv_*
1292 functions like priv_allocset). Reported by Keith Thompson.
1294 * tests/rm/dir-nonrecur: New file/test for the above fix.
1295 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1297 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1299 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1300 POSIX 1002.1-2001 requires.
1301 * src/tail.c (parse_obsolete_option): Implement this.
1302 Problem reported by Vincent Lefevre.
1303 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1304 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1305 (test_vector): Add special cases for _POSIX2_VERSION, and
1306 regularize the old ones a bit.
1307 * tests/touch/obsolescent: Add y2000 test.
1309 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1311 * src/dd.c (skip): Fix off-by-one error reported by
1312 Theodoros V. Kalamatianos.
1314 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1316 * tests/mkdir/p-3: Require that the test be run as non-root.
1317 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1319 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1321 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1322 boundary between DEST and SOURCE in the result.
1324 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1326 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1327 back to text, to sync with documentation and for backwards
1330 2005-10-25 Jim Meyering <jim@meyering.net>
1332 * tests/dircolors/simple (other-wr): Add an explicit test for
1333 the dircolors bug (NULL-dereference) fixed yesterday.
1335 2005-10-24 Jim Meyering <jim@meyering.net>
1337 * src/tac.c (tac_file): When determining whether a file is seekable,
1338 also test whether it is a tty. Using only the lseek-based test would
1339 give a false positive on Solaris. Reported by Peter Fales.
1341 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1343 * tests/install/d-slashdot: New test, for "install -d" failure.
1344 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1345 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1346 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1348 2005-10-24 Jim Meyering <jim@meyering.net>
1350 * src/dircolors.c (ls_codes): Add missing comma.
1351 Anonymous report and patch from
1352 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1354 * src/dircolors.c: Add compile-time assertion that the slack_codes
1355 and ls_codes arrays have the same number of elements. This would
1356 have prevented the above-fixed bug.
1358 * src/expand.c (parse_tab_stops): Add a comment to make this function
1359 identical to the one in unexpand.c.
1360 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1361 identical to the one in expand.c.
1363 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1365 2005-10-23 Jim Meyering <jim@meyering.net>
1367 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1368 a dangerous pointer-value-to-`unsigned' cast.
1369 * NEWS: mention the new sha* programs.
1370 * AUTHORS: Add new sha* programs.
1372 2005-08-28 David Madore <david.madore@ens.fr>
1374 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1375 * README: Add their names to the list.
1376 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1377 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1378 Rules for compiling sha-2 utilities
1379 (noinst_HEADERS): Remove checksum.h.
1380 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1382 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1383 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1384 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1385 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1386 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1387 sha384sum, sha512sum test scripts here rather that each in its
1390 2005-08-28 David Madore <david.madore@ens.fr>
1392 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1393 of the FIPS test vectors).
1395 2005-10-23 Jim Meyering <jim@meyering.net>
1397 * configure.ac: Use 6.0-cvs as the version string.
1398 * NEWS: Adjust accordingly.