1 2006-06-26 Jim Meyering <jim@meyering.net>
3 Avoid a segfault for wc --files0=- < /dev/null.
4 * src/wc.c (compute_number_width): Return right away if nfiles == 0.
6 2006-06-25 Jim Meyering <jim@meyering.net>
8 * NEWS: wc accepts a new option --files0-from=FILE, where FILE
9 contains a list of NUL-separated file names.
11 * src/wc.c: Include "readtokens.h".
12 (usage): Describe the new option, and adjust the `Usage':
13 with this option, no FILE may be specified on the command line.
14 (main): Handle the new option.
15 * tests/misc/wc-files0: New tests, for the above.
16 * tests/misc/wc-files0-from: Likewise.
17 * tests/misc/Makefile.am (TESTS): Add wc-files0.
19 2006-06-24 Jim Meyering <jim@meyering.net>
21 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
23 2006-06-22 Jim Meyering <jim@meyering.net>
25 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
26 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
28 2006-06-19 Jim Meyering <jim@meyering.net>
30 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
31 so this check is not run as part of "make distcheck".
33 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
35 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
37 2006-06-18 Jim Meyering <jim@meyering.net>
39 * tests/misc/pwd-long: Make error output a little clearer.
41 2006-06-17 Jim Meyering <jim@meyering.net>
43 * tests/rm/inaccessible: Skip this test on systems without openat
44 support. Reported by Bob Proulx.
46 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
48 * tests/misc/mknod: Improve permission checks to handle
49 running mkdir test in set-gid directories.
51 2006-06-14 Jim Meyering <jim@meyering.net>
53 * tests/du/basic: Revamp not to hard-code file system block sizes.
55 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
57 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
60 2006-06-11 Jim Meyering <jim@meyering.net>
62 * .gitignore: New file.
63 * Makefile.am (EXTRA_DIST): Add .gitignore.
65 Setting TIME_STYLE=long-iso in the environment would make the
66 cp/same-file test fail.
67 * tests/envvar-check (vars): Add TIME_STYLE to the list.
68 * tests/cp/same-file: Revert last change.
69 Source the envvar-check script, to ensure that TIME_STYLE
70 settings don't affect these tests.
72 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
74 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
75 uses POSIX time stamp formats. Problem reported by John Nixon in
76 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
78 2006-06-10 Jim Meyering <jim@meyering.net>
80 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
82 Require a "Version N.M" line at the top of the ChangeLog
83 file only when making the actual release, not when running
85 * Makefile.maint (maintainer-distcheck): Don't depend on
87 (alpha beta major): Depend on it here, instead.
89 2006-06-08 Jim Meyering <jim@meyering.net>
91 Ensure that cat works with any of the options, -A -v -e -E -T,
92 when applied to files in /proc and /sys, even when the FIONREAD
93 ioctl produces nonsensical results. Before this change, cat would
94 produce no output (or truncated output), for some linux kernels.
96 * src/cat.c (write_pending): New function, factored out of cat.
97 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
98 that there are bytes to read. Some versions of linux-2.6.16 do that.
99 Write any pending output before returning.
100 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
101 * NEWS: Mention this bug fix.
102 * tests/misc/cat-proc: New file. Test for the above.
103 * tests/misc/Makefile.am (TESTS): Add cat-proc.
105 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
107 * src/expr.c (eval4): Detect overflow properly when multiplying
110 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
112 * NEWS: The 'expr' command now detects and reports integer overflow.
113 (It would be better to use extended precision instead, but that
115 * src/expr.c (integer_overflow): New function.
116 (eval4, eval3): Check for integer overflow.
118 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
120 Fix problems when building with Solaris/SVR4/etc. make, which uses a
121 different and somewhat bogus implementation of VPATH. In the
122 directory tests/misc, rename tests whose names might appear in the
123 Automake-generated rules. For example, we can't use a test named
124 'test', since Automake generates a rule that contains the text
125 "if test -f ./$$tst; ...", and this might expand to something like
126 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
127 which executes the 'test' script rather than the 'test' command.
128 * tests/misc/false-status: Renamed from tests/misc/false.
129 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
130 * tests/misc/sort-merge: Renamed from tests/misc/sort.
131 ($prog): Set to 'sort' rather than to $PROG.
132 * tests/misc/test-diag: Renamed from tests/misc/test.
133 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
134 in case Solaris make has prepended the directory.
135 (TESTS): Adjust to above renamings.
136 * tests/misc/expand: Don't assign to PROG; no longer needed
137 now that Makefile.am sets PROG to the basename.
138 * tests/misc/fold: Likewise.
140 2006-06-03 Jim Meyering <jim@meyering.net>
142 Make `cp --link --no-dereference' work also on systems where the
143 link system call cannot create a hard link to a symbolic link.
144 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
145 the link syscall on a symlink when it would do the wrong thing.
146 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
147 * tests/cp/link-no-deref: New file/test for the above.
148 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
149 * NEWS: Mention the change (doesn't affect Linux).
151 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
153 Fix some porting problems in the test cases reported by
154 Ralf Wildenhues for HP-UX 11.23 in:
155 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
156 * tests/help-version: Don't assume that \< \> works in sed.
157 * tests/misc/close-stdout: Don't assume that >&- works.
158 Add a /dev/full test.
159 * tests/touch/no-create-missing: Don't assume that >&- works.
161 2006-05-30 Jim Meyering <jim@meyering.net>
163 * src/ls.c (usage): Add `v' to the list of sorting-related options.
166 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
168 * tests/cp/fail-perm: source lang-default.
169 * tests/rm/inaccessible: Likewise.
171 2006-05-28 Jim Meyering <jim@meyering.net>
173 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
174 Recognize it, too. Reported by Ralf Wildenhues, in
175 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
177 2006-05-27 Jim Meyering <jim@meyering.net>
179 * src/chgrp.c: Support new options: --preserve-root and
180 --no-preserve-root. Somehow this program was skipped when those
181 options were added to chown, chmod, and rm. Reported by
182 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
183 * NEWS: Mention this.
185 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
187 * NEWS: Remove mention of --seed. We'll replace it with something
188 better, and don't want to indicate that it is supported.
189 * src/sort.c (usage): Likewise.
191 2006-05-20 Jim Meyering <jim@meyering.net>
193 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
195 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
196 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
197 FTS_COMFOLLOW. Spotted by Justin Pryzby.
199 * gnupload: Merge changes from automake, retaining the ""--to...
200 kludge to placate overzealous `make distcheck' check.
202 2006-05-19 Jim Meyering <jim@meyering.net>
204 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
205 FTS_TIGHT_CYCLE_CHECK directory traversal option.
206 Reported by Justin Pryzby in http://bugs.debian.org/367691
208 2006-05-15 Jim Meyering <jim@meyering.net>
210 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
213 2006-05-13 Jim Meyering <jim@meyering.net>
215 * tests/mv/no-target-dir: Test two more cases.
217 2006-05-11 Jim Meyering <jim@meyering.net>
219 mv -T DIR EMPTY_DIR no longer fails unconditionally
220 * src/copy.c (copy_internal): Don't manually prohibit a move where
221 the destination is an existing directory. Sometimes doing that is
222 valid. Let the rename system call enforce the rules. That is
223 allowed only when the source is a directory and the destination
224 directory (to be replaced) is empty. Reported by Eric Blake.
225 * tests/mv/no-target-dir: New file/test for this.
226 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
227 * NEWS: Mention this.
229 * tests/mv/atomic: New file/test for yesterday's fix.
230 * tests/mv/Makefile.am (TESTS): Add atomic.
232 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
234 2006-05-10 Jim Meyering <jim@meyering.net>
236 * src/copy.c (copy_internal): Don't explicitly unlink the destination
237 when moving a symlink into the place of an existing non-directory.
238 Reported by Joshua Hudson.
239 * NEWS: mention this.
241 2006-05-07 Jim Meyering <jim@meyering.net>
243 * Makefile.maint (patch-check): Fail if patch generates any output,
244 even merely for changed offsets.
246 * src/c99-to-c89.diff: Adjust to reflect new offsets.
248 * NEWS: Mention changes affecting df, pwd, shred.
250 2006-05-06 Jim Meyering <jim@meyering.net>
252 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
253 system condition where dirent.d_ino != stat.st_ino.
254 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
256 2006-05-06 Eric Blake <ebb9@byu.net>
258 * tests/ls/inode: Expand to test inode from readdir case.
259 * tests/ls/follow-slink: Expand to test broken links encountered
260 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
262 2006-05-06 Eric Blake <ebb9@byu.net>
264 * tests/mv/leak-fd: Work even on case-insensitive file system.
266 2006-05-04 Jim Meyering <jim@meyering.net>
268 * NEWS: Mention the 2006-03-19 pwd-related change that makes
269 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
271 2006-05-03 Jim Meyering <jim@meyering.net>
273 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
274 Use better macro parameter names: s/basename/key_name/,
275 s/basefunc/key_cmp_func. Fix typo in comment.
277 2006-04-29 Eric Blake <ebb9@byu.net>
279 * src/ls.c (main): On systems with d_type, directories_first only
280 implies format_needs_type, not format_needs_stat.
282 2006-05-03 Jim Meyering <jim@meyering.net>
284 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
285 after comma in arg list, from Eric Blake.
287 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
289 * tests/misc/date (relative-3): New test, derived from a bug
290 report by John Thomas McDole.
292 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
294 New option for ls: --group-directories-first.
295 It makes ls list directories before files.
296 * NEWS [New features]: Mention it.
297 * src/ls.c (sort_type): Rearrange to use as an array index when
298 choosing sort function; added new sort_numtypes member for
300 (time_type): Add new time_numtypes member for compile-time check.
301 (directories_first): New global variable.
302 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
303 (long_options): Add --directories-first.
304 (main): Support new option.
305 (is_directory): New function.
306 (extract_dirs_from_files): Use it.
307 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
308 (LIST_SORTFUNCTION_VARIANTS): New macros.
309 (sort_functions): New global variable.
310 (sort_files): Use it.
311 (usage): Document new option.
313 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
315 * src/shred.c (fillrand): The assertion was way too weak, due to
316 what must be a typo. Strengthen it to its intended value.
317 (dopass): Don't use alloca; it's not worth the aggravation here,
318 since it's used only to get a page-aligned buffer, and page
319 alignment doesn't buy us much here. I'm suspicious that alloca
320 causes problems on some hosts, due to a recent bug report by Adam
321 Waltman: http://bugs.gentoo.org/130246.
323 2006-04-18 Jim Meyering <jim@meyering.net>
325 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
326 sha384sum, sha512sum.
328 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
330 * src/chmod.c (describe_change): Adjust to filemode changes.
331 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
332 (print_long_format): Use (new) filemodestring rather than
333 (old) mode_string, so that we get more file types right, at least
334 in theory. Adjust to filemode changes.
335 * src/stat.c (human_access): Likewise.
337 2006-04-18 Jim Meyering <jim@meyering.net>
339 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
340 ignore file. This has never been enabled. Reported by Eric Blake.
342 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
344 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
345 bug in Interix. Just call symlink or link directly. All uses changed.
346 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
347 * src/stat.c (USE_STATVFS): New macro.
348 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
349 (NAMEMAX_FORMAT): define a bit more clearly, now that the
350 statvfs-using code is a bit more regular.
351 * src/system.h (sync) [!HAVE_SYNC]: New macro.
353 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
355 * NEWS: csplit, nl, expr now conform to POSIX better, and are
356 more-compatible with traditional Unix, with respect to regular
358 * src/csplit.c (extract_regexp): Set re_syntax_options to a
359 value that is compatible with what POSIX requires.
360 * src/nl.c (build_type_arg): Likewise.
361 * src/expr.c (docolon): Likewise. Also, don't let anchors match
362 newline; this fixes an incompatibility with tradition and with POSIX.
363 Don't warn about leading ^. POSIX says it is unspecified whether
364 ^ is a special character, which means that implementations can
365 either treat it as special or not, but either way a warning is not
366 allowed (unless the regexp is otherwise invalid). Instead, anchor
367 the expression but treat ^ as an anchor; this is the traditional
368 behavior (e.g., Solaris 10).
369 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
370 and the like as invalid expressions (exit status 2), not as
371 failure of 'expr' (exit status 3). This is more consistent with
373 * tests/expr/basic (fail-a): Adjust exit status to match new expr
374 behavior, for status 2 versus 3.
376 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
377 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
378 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
379 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
380 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
381 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
382 (bre61, bre62): New tests.
383 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
387 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
388 "if !". Do not assume that 'sed' can handle long, newline-free input.
389 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
391 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
393 Adjust to new regex.h API (with new fastmap type), and clean
394 up the regex storage allocation a bit.
396 * src/csplit.c (struct control): Put re_compiled member at the
397 end, since it's large. Change regexpr member from char * to bool;
398 all uses changed. Add new member fastmap.
399 (extract_regexp): regexp arg is now char const *, not char *.
400 Don't bother duplicating the regular expression; it's not needed.
401 Set fastmap from new fastmap member. Don't bother allocating
402 a buffer, as the regexp code does a better job than we do.
403 * src/expr.c (docolon): Allocate and use a fastmap.
404 Don't bother allocating a buffer.
405 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
407 (build_type_arg): New fastmap arg. All uses changed.
408 Don't bother allocating a buffer, but set a fastmap.
409 * src/ptx.c (context_regex_string, word_regex_string): Remove.
410 (context_regex, word_regex): New vars, replacing the above.
412 (struct regex_data): New type.
413 (compile_regex): Renamed from alloc_and_compile_regex, since
414 we no longer allocate storage. Arg is now a struct regex_data *,
415 not a const char *. All uses changed. Don't allocate the fastmap;
416 instead, take it from the caller. Don't convert size_t to int,
417 to avoid arithmetic overflow problems. Don't bother freeing
418 storage afterwards; it's not worth the aggravation.
419 * src/tac.c (compiled_separator_fastmap): New ver.
420 (main): Use it. Don't bother allocating a buffer.
422 2006-03-30 Jim Meyering <jim@meyering.net>
424 * src/dd.c (iwrite): Remove assignment without effect.
425 Reported by Felix Rauch Valenti.
427 2006-03-22 Eric Blake <ebb9@byu.net>
429 * src/ptx.c (usage): Remove mention of --copyright/-C.
430 (main): Alias --copyright to --version plus a deprecation warning.
431 * NEWS: Mention this.
433 2006-03-27 Jim Meyering <jim@meyering.net>
435 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
436 use of strtod. Tiny patch from Nickolai Zeldovich.
438 2006-03-11 Eric Blake <ebb9@byu.net>
440 * tests/misc/dirname: New file.
441 * tests/basename/Makefile.am: Delete.
442 * tests/basename/basic: Move to...
443 * tests/misc/basename: ... this new file. Add some tests,
444 including fixed behavior for //.
445 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
446 * tests/Makefile.am (SUBDIRS): Remove basename.
447 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
449 Improvements to dirname/basename handling on platforms like
450 cygwin with distinct // and with drive letters.
451 * NEWS: Document new behavior.
452 * src/basename.c (main): Don't strip suffix from file system
454 * src/cp.c (target_directory_operand): Use new last_component.
455 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
456 traversing the string.
457 * src/dircolors.c (guess_shell_syntax): Use new last_component.
458 * src/install.c (target_directory_operand, install_file_in_dir):
460 * src/ln.c (target_directory_operand, main): Likewise.
461 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
462 * src/mv.c (target_directory_operand, movefile): Likewise.
463 * src/remove.c (rm_1): Likewise.
464 * src/shred.c (wipename): Likewise.
465 * src/split.c (next_file_name): Likewise.
466 * src/su.c (log_su, run_shell): Likewise.
468 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
470 * NEWS: nohup diagnostics are now more precise, and nohup now
471 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
472 * src/nohup.c (main): Implement this.
473 * tests/misc/nohup: Test the new behavior.
475 2006-03-12 Jim Meyering <jim@meyering.net>
477 * src/copy.c (set_author): Rename function, from preserve_author.
479 * src/remove.c (AD_pop_and_chdir): Use new macro,
480 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
482 * src/system.h (SAME_INODE): Remove definition.
483 Include "same-inode.h", instead.
485 2006-03-11 Eric Blake <ebb9@byu.net>
487 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
489 2006-03-10 Jim Meyering <jim@meyering.net>
491 Fix a bug whereby a user with write access to a directory being removed
492 could cause the removal of that directory to fail with an erroneous
493 diagnostic about a directory cycle. Reported by Vineet Chadha.
495 * NEWS: Mention this.
496 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
497 leave (and try to rmdir) is the one whose dev_ino is being used to
498 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
500 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
502 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
503 * src/dd.c (set_fd_flags): Handle file-creation flags on file
504 descriptors, rather than ignoring them.
505 * tests/dd/misc: Add test cases for append, nofollow, directory,
506 and nolinks flags. Simplify redirection to /dev/null in some cases.
508 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
509 noatime test never tested anything.
511 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
513 * src/dd.c (flags, usage): New flags directory, nolinks.
514 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
516 * src/ls.c (usage): Mention that -f disables --color.
517 Problem reported by Niels Möller.
519 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
521 * man/*.x: Add references to syscalls from utilities of the same name.
523 2006-03-05 Jim Meyering <jim@meyering.net>
525 * tests/help-version: Set SHELL, if not already set, in order to
526 avoid failure when `make check' is run through debuild; dircolors
527 would fail due to lack of $SHELL. Reported by Sven Joachim.
529 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
530 * src/base64.c (wrap_write, do_encode, main): Change type of
531 parameters and locals, wrap_column, form size_t to uintmax_t.
532 (main): Adjust to use xstrtoumax, accordingly.
534 2006-03-03 Jim Meyering <jim@meyering.net>
536 Don't fail when run from an environment with SHELL not a Bourne
537 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
538 * tests/dircolors/simple: Invoke each non-failing test with -b.
539 Reported by Michael Stone.
541 2006-02-27 Jim Meyering <jim@meyering.net>
543 * tests/misc/base64: Derive --decode-using tests from the
546 * tests/misc/base64: Factor out a long constant string.
547 Split lines to stay within 80 columns.
549 * tests/misc/Makefile.am (TESTS): Add base64.
550 * tests/misc/base64: Test base64. From Simon Josefsson.
552 * src/base64.c (do_decode): Use correct type for parameter,
553 ignore_garbage: s/size_t/bool/.
555 * src/base64.c: Don't include .h files already included by system.h:
556 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
557 Include "system.h" before the other lib/*.h header files.
558 Include <sys/types.h> before "system.h".
559 (wrap_write): Remove declaration of unused local, initial_column.
560 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
562 * README: Add base64 to the list.
564 2006-02-17 Simon Josefsson <jas@extundo.com>
567 * AUTHORS: Mention base64.
569 * man/Makefile.am: Build base64.1.
570 * man/base64.x: New file.
571 * src/Makefile.am (bin_PROGRAMS): Add base64.
572 * src/base64.c: New file.
574 2006-02-25 Eric Blake <ebb9@byu.net>
576 In ls, avoid calling stat for --inode (-i), when possible.
577 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
578 * src/system.h: ... here, for use in ...
579 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
581 (gobble_file): Add inode argument.
582 (print_dir): Pass inode if available.
583 (usage): Remove inaccuracy.
585 2006-02-23 Jim Meyering <jim@meyering.net>
587 * TODO: Update/correct some obsolete entries.
589 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
591 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
592 * src/join.c (usage): Likewise.
593 Documentation problem reported by Philip Kensche.
595 2006-02-20 Eric Blake <ebb9@byu.net>
597 * man/rm.x: Update documentation to match previous patch.
599 2006-02-18 Eric Blake <ebb9@byu.net>
601 New option for rm: --interactive=once (-I).
602 * NEWS: Document it, along with change to rm --interactive.
603 * TODO: Remove entry for implementing rm -I
604 * src/rm.c (INTERACTIVE_OPTION): New enum value.
605 (interactive_type): New enum.
606 (long_opts): Let interactive take an optional argument.
607 (interactive_args, interactive_types): New option arguments.
608 (usage): Document -I, --interactive=WHEN. Use program_name
609 instead of a basename.
610 (main): New -I option, new behavior to --interactive.
611 * tests/rm/interactive-once: New tests.
612 * tests/rm/interactive-always: Ditto.
613 * tests/rm/Makefile.am (TESTS): Run them.
615 2006-02-18 Jim Meyering <jim@meyering.net>
617 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
618 expression match more of the target lines, e.g., those that start with
619 `-S,' (short option followed by a comma) or that include `=[...]'.
620 Patch by Nicolas François.
621 Fix the four offenders thus exposed:
622 * src/join.c (usage): Use two spaces (not one) to separate the
623 --first-only option string from its description, so help2man formats
624 the derived man page properly.
625 * src/pr.c (usage): Likewise.
626 * src/uniq.c (usage): Likewise.
627 * src/install.c (usage): Likewise.
629 2006-02-15 Jim Meyering <jim@meyering.net>
631 * Makefile.maint (alpha beta major): For `make major', ensure that the
632 version string is of the form N.N[.N]*, where N is one or more digits.
634 2006-02-14 Jim Meyering <jim@meyering.net>
636 * INSTALL: Update from gnulib.
638 2006-02-13 Jim Meyering <jim@meyering.net>
640 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
642 2006-02-12 Jim Meyering <jim@meyering.net>
644 * Makefile.maint (patch-check): New target.
645 (local-checks-available): Add to the list.
647 2006-02-11 Jim Meyering <jim@meyering.net>
649 * src/c99-to-c89.diff: New file.
650 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
652 * .x-po-check: New file, with exclusions so that `make distcheck'
654 * Makefile.am (EXTRA_DIST): Add .x-po-check.
656 rm -r must remove an empty directory, even if it is inaccessible.
657 * src/remove.c (close_preserve_errno): New function.
658 (fd_to_subdirp): Don't print a diagnostic in this function.
659 Do it from the callers instead, unless rmdir succeeds.
660 (remove_cwd_entries, remove_dir): Adjust callers.
661 * tests/rm/empty-inacc: New test for the above.
662 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
663 * NEWS: Mention this bug fix.
664 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
665 a tiny bit less precise: cannot remove `a/1': ... instead of
666 cannot open directory `a/1': ...
668 * Makefile.maint (syntax-check-rules): Automatically derive this
669 list of sc_-prefixed rule names.
671 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
673 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
674 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
675 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
676 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
677 go away? was that an accident?)
678 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
679 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
680 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
681 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
682 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
683 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
684 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
685 (author_mark_check, makefile_path_separator_check):
686 Output line numbers, to simplify navigation of Emacs *compilation*
688 (sc_prohibit_atoi_atof, sc_file_system):
689 Rework slightly so that Makefile.maint doesn't get reported as a
690 violation of its own syntax rules.
691 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
692 it at run-time (which didn't work with Bison). Fix a makefile typo,
693 caught by Makefile.maint itself: spaces where a tab should be.
694 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
695 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
696 Ignore djgpp and man subdirectories, to avoid false matches with
697 Bison and coreutils, respectively. Use sort -u to remove the
698 resulting duplicates.
699 * gnupload: Rework slightly to avoid bogus warning from
700 sc_two_space_separator_in_usage.
702 2006-02-10 Jim Meyering <jim@meyering.net>
704 Use gzip's --rsyncable option only if it's available.
705 * Makefile.maint (gzip_rsyncable): New variable.
708 2006-02-08 Jim Meyering <jim@meyering.net>
710 * Makefile.maint (local-checks-available): Define in terms of
711 the expansion, $(syntax-check-rules), rather than the single,
712 top-level target `syntax-check', so that it's easier to exclude
713 individual rules (via $(local-checks-to-skip)).
714 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
716 2006-02-07 Jim Meyering <jim@meyering.net>
718 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
719 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
721 * tests/help-version (expected_failure_status_vdir):
722 Redirect an expected disk-full diagnostic to /dev/null.
724 2006-02-06 Jim Meyering <jim@meyering.net>
726 * src/unexpand.c (usage): Use two spaces (not one) to separate the
727 --first-only option string from its description, so help2man formats
728 the derived man page properly.
729 * src/rm.c (usage): Likewise for --no-preserve-root.
730 * src/chown.c (usage): Likewise.
731 * src/chgrp.c (usage): Likewise.
733 Add a rule to ensure that the above doesn't happen again.
734 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
735 (syntax-check-rules): Add it.
736 * .x-sc_two_space_separator_in_usage: New empty file.
737 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
739 2006-02-06 Jim Meyering <jim@meyering.net>
741 * src/cp.c (usage): Use two spaces (not one) to separate each
742 option string from its description, so help2man formats the
743 derived man page properly.
744 * src/mv.c (usage): Likewise.
745 Patch from Nicolas François in http://bugs.debian.org/351601.
747 2006-02-04 Jim Meyering <jim@meyering.net>
749 * src/copy.c (copy_internal): cp -RL would fail when encountering
750 the same directory more than once in the hierarchy beneath a single
751 command-line argument. That is legitimate, e.g. when there are
752 two or more symbolic links, each pointing to some directory that
753 would not otherwise be copied. Reported by Christophe LYON.
754 * tests/cp/cp-deref: New file. Test for today's fix.
755 * tests/cp/Makefile.am (TESTS): Add cp-deref.
756 * NEWS: Document this.
758 2006-02-03 Jim Meyering <jim@meyering.net>
760 * configure.ac: Require automake-1.9.6, not 1.8.3.
762 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
764 * src/od.c (usage): Mention that -t a ignores high order bit.
765 Documentation problem reported by Ed Avis.
767 2006-02-01 Jim Meyering <jim@meyering.net>
769 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
771 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
773 * src/head.c (main): Use a better diagnostic when someone uses a
774 trailing numeric option in an invalid way. Problem reported by
776 * src/tail.c (parse_options): Likewise.
778 2006-01-30 Jim Meyering <jim@meyering.net>
780 * man/wc.x: Include `count' keyword in man page synopsis,
781 per suggestion from http://bugs.debian.org/181585.
783 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
785 * src/df.c (show_dev): If the file system claims to have
786 more available than total blocks, report the number of used
787 blocks as being total - available (a negative number) rather
788 than as garbage. Problem reported by Toralf Foerster.
790 2006-01-24 Jim Meyering <jim@meyering.net>
792 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
793 to put a regular file in O_NONBLOCK mode fails with EPERM.
794 That happens on Linux (up to 2.6.15) when using tail -f on a file with
795 the append-only attribute. Reported by Dean Gaudet. For details,
796 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
797 * NEWS: Mention this fix.
798 * tests/tail-2/append-only: New file. Test for the above.
799 * tests/tail-2/Makefile.am (TESTS): Add append-only.
800 * tests/Makefile.am (check-root): Add tail-2/append-only
802 2006-01-21 Jim Meyering <jim@meyering.net>
804 * NEWS: Mention fts-related improvements and bug fixes.
806 2006-01-19 Jim Meyering <jim@meyering.net>
808 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
809 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
811 2006-01-18 Jim Meyering <jim@meyering.net>
813 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
815 2006-01-17 Jim Meyering <jim@meyering.net>
817 Now that fts no longer changes the current working directory, adjust
818 its clients accordingly -- note that du.c uses fts but doesn't need
819 any adjustment, since it doesn't operate on the actual files,
820 but rather just uses the stat buffers provided by fts.
822 * src/chown-core.c: Include "openat.h".
823 Don't include "lchown.h".
824 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
825 calling openat, lchownat, chownat, rather than open, lchown, chown.
827 * src/chmod.c: Include "openat.h".
828 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
830 * tests/du/long-from-unreadable: New test, to exercise one small
833 2006-01-13 Jim Meyering <jim@meyering.net>
835 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
836 addition of new directories under tests/.
838 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
841 2006-01-12 Jim Meyering <jim@meyering.net>
843 * tests/du/long-sloop: Adjust not to hard-code the expected
844 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
845 from that of GNU libc. Reported by Paul Eggert.
847 * tests/du/long-sloop: Create file at end of symlink chain.
849 * tests/misc/test: New file, with a test for one of the
850 bugs fixed by yesterday's test.c changes.
851 * tests/misc/Makefile.am (TESTS): Add test.
853 2006-01-11 Jim Meyering <jim@meyering.net>
855 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
856 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
857 a very long sequence of symbolic links (not necessarily a loop).
858 * tests/du/Makefile.am (TESTS): Add long-sloop.
860 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
862 * src/test.c (test_syntax_error): Append a newline. All callers
863 changed, except for the ones that didn't already append a newline.
864 Bug reported by Eric Blake.
866 2006-01-11 Jim Meyering <jim@meyering.net>
868 * src/system.h (X2NREALLOC): Now that verify_true is no longer
869 void, cast its result to void, to avoid gcc's warning that
870 ``left-hand operand of comma expression has no effect''.
871 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
873 2006-01-10 Jim Meyering <jim@meyering.net>
875 * tests/chmod/no-x: Add a test for today's fts.c fix.
877 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
879 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
880 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
882 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
884 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
885 Use verify_true instead of verify_expr, to sync with gnulib.
887 2006-01-08 Jim Meyering <jim@meyering.net>
889 * src/date.c (usage): Adjust the formatting of the entries for
890 %::z and %:::z (separate with two spaces, not one) so that help2man
891 formats them properly. Reported by Philip Rowlands.
893 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
895 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
897 2006-01-06 Jim Meyering <jim@meyering.net>
899 * Makefile.maint (copyright-check): Use date +%Y in place of
902 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
903 First off, the attribute should have been `volatile' (not static)
904 to avoid longjmp-related risk of clobber. Secondly, now there is
905 no longer any risk of a local variable being clobbered, so there's
906 no need for any attribute at all.
908 2006-01-05 Jim Meyering <jim@meyering.net>
910 * src/remove.c: Give a few functions the inline attribute.
911 (AD_pop_and_chdir): Use gotos to avoid some duplication.
912 (AD_push): Rewrite an assertion so that the entire computation
913 goes away when assertions are turned off.
915 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
916 It's already defined in "system.h".
917 * Makefile.maint: Add a FIXME comment.
919 2006-01-04 Jim Meyering <jim@meyering.net>
921 * ChangeLog: Remove entries from 2005-10-22 and earlier.
922 * ChangeLog-2005: New file, for entries up to version 5.92.
924 2006-01-03 Jim Meyering <jim@meyering.net>
926 * tests/du/no-x: Also allow a slightly different diagnostic -- the
927 one you get when using openat-enabled fts.c and du (coming soon).
928 * tests/chmod/no-x: Likewise.
929 * tests/chgrp/no-x: Likewise.
931 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
933 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
935 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
936 (restricted_chown): Return it, if the file cannot be accessed due
937 to EPERM, or if no uid or gid are required, or if the file is
938 neither a directory nor a regular file. Rewrite to avoid gotos.
939 (change_file_owner): Handle RC_do_ordinary_chown case.
940 Rewrite to avoid gotos.
941 * tests/chgrp/basic: Make sure we can change the group of
944 * src/date.c (usage): Explain %g, %G, and %V a bit better.
946 2006-01-02 Jim Meyering <jim@meyering.net>
948 * src/copy.c (set_owner): Correct a comment.
950 * src/tail.c (parse_options): Change warning to say that --retry
951 is useful `mainly' (not `only') when following by name.
952 Reported here: http://bugs.debian.org/273781
954 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
956 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
957 * src/copy.c: Include lchmod.h.
958 (copy_internal): Use lchmod rather than chmod.
959 * src/cp.c: Include lchmod.h.
960 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
961 * src/mkdir.c: Include lchmod.h.
962 (usage): Clarify -m's operation.
963 (main): Use lchmod rather than chmod. Don't use lchmod unless the
964 new mode contains bits outside the 777 range.
965 * src/mkfifo.c (usage): Clarify -m's operation.
966 (main): If -m is given, don't invoke chmod; use umask 0 instead.
967 Report an error if -m asks for bits outside the 777 range.
968 * src/mknod.c (usage, main): Likewise.
970 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
972 2005-12-27 Jim Meyering <jim@meyering.net>
974 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
975 (sc_prohibit_assert_without_use): New rule.
976 (syntax-check-rules): Add it to the list.
977 * .x-sc_prohibit_assert_without_use: New empty file.
978 * Makefile.am (EXTRA_DIST): Add it.
980 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
982 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
983 Don't include <assert.h>; it wasn't used.
985 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
987 * src/chown-core.c (restricted_chown):
988 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
989 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
990 | O_NOFOLLOW too, for consistency with other dir-openers.
991 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
992 (is_empty_dir): Likewise.
993 * src/shred.c (wipename): Likewise. Don't bother trying to open
994 dir for writing, since POSIX prohibits it.
996 2005-12-22 Jim Meyering <jim@meyering.net>
998 * tests/help-version: Redirect stderr to /dev/full, to suppress
999 write error diagnostic.
1001 2005-12-19 Jim Meyering <jim@meyering.net>
1003 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
1004 Avoid a minor race condition when `-m MODE' is specified, by using
1005 open, fchown, and close rather than just chown. To do that reliably --
1006 even with an overly restrictive umask -- ensure that each mkdir,
1007 mknod and mkfifo call uses a mode including at least owner-read access.
1008 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
1009 the subsequent chown (or equivalent open,fchown,close) fails.
1010 * tests/misc/mknod: New tests.
1011 * tests/misc/Makefile.am (TESTS): Add mknod.
1013 2005-12-17 Jim Meyering <jim@meyering.net>
1015 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
1016 e.g., on a named pipe.
1017 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
1018 place of all uses, since it is guaranteed (system.h) to be defined.
1020 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
1022 Add POSIX ACL support
1023 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
1024 is no requirement for ACL support; particularly, it does not exist
1025 on systems that have POSIX ACLs.
1026 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1027 * src/cp.c (umask_kill): With default acls, the umask is not to be
1028 applied. Remove umask_kill, don't change the process umask, and let
1029 the kernel apply the umask where appropriate.
1030 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1031 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1033 (copy_reg, copy_internal): Use copy_acl and set_acl
1034 instead of fchown/chown. Fix the logic for POSIX ACLs.
1035 (chown_succeded): Remove; we now always copy acls and
1036 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1037 did a chown before or not.
1038 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1039 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1040 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1041 to link with it via $(LIB_ACL), for the utilities that need it.
1043 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1045 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1046 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1047 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1048 value is now signified by whether cwd_errno is null.
1049 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1050 pointer-to-bool to pointer-to-errno-value. All callers changed.
1051 (rm_1): Don't bother setting a local cwd failure flag and then
1052 ORing it into the caller's. Just set the caller's.
1053 (rm): Use cwd failure errno value to print a slightly-better
1056 2005-12-15 Jim Meyering <jim@meyering.net>
1058 * src/stat.c (print_it): Properly handle a backslash at the
1059 end of a --printf format string. Reported by Paul Eggert.
1060 * tests/misc/stat-printf (end-bs): Add a test for the above.
1062 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1064 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1065 Don't assume /etc/passwd contains user names; use 'id' instead.
1067 2005-12-15 Jim Meyering <jim@meyering.net>
1069 stat: revert behavior of --format=FMT (-c)
1070 stat: add new option: --printf=FMT
1071 * NEWS: Mention this.
1072 * src/stat.c (isodigit, octtobin, hextobin): Define.
1073 (PRINTF_OPTION): Define.
1074 (interpret_backslash_escapes, trailing_delim): New globals.
1075 (usage): Document them. Alphabetize on long option names.
1076 (print_esc_char): New function.
1077 (print_it): Rewrite, in order to handle backslash escapes.
1078 (main): Handle new option. Set globals for --format, too.
1080 * tests/misc/stat-printf: Test --printf and --format.
1081 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1083 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1085 * NEWS: sort now reports incompatible options.
1086 * src/sort.c (incompatible_options, check_ordering_compatibility):
1088 (main): Use them. Don't bother with a usage message for
1089 "sort -c a b", for consistency with other error diagnostics.
1090 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1093 * src/cat.c (main): Undo previous change. close_stdout already
1094 does the check, so the previous change wasn't necessary.
1096 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1098 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1100 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1102 Install a more-conservative approach for sort -R. It's the
1103 same basic idea as the existing code, except it uses the full ISAAC
1104 approach (called the "more kosher" approach in the existing comments).
1105 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1106 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1107 better to be conservative here at first, and review any performance
1108 improvements carefully.
1109 * .x-sc_require_config_h: Add src/rand-isaac.c.
1110 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1111 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1112 (shred_SOURCES, sort_SOURCES): Remove.
1113 (EXTRA_DIST): Add rand-isaac.c.
1114 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1115 changing it to allow for varying numbers of words in the state.
1116 Alter so that we include rand-isaac.c directly rather than
1117 compiling it and linking to it. Don't include config.h or
1118 system.h; that's the includer's responsibility.
1119 Omit functions that are specific to shred.
1120 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1121 (isaac_step, struct irand_state):
1122 Resurrect these, with the same defns that used to be in shred.c.
1123 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1124 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1126 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1127 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1128 (irand_init, irand32, irand_mod):
1129 Number of words is constant again.
1130 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1131 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1132 * src/sort.c: Likewise.
1133 * src/shred.c (fillrand, dopass, main): Undo previous change.
1134 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1136 * src/sort.c: Don't include md5.h; it wasn't needed.
1137 (struct keyfield): Rename random_hash to random, for consistency
1138 with the other member names. All uses changed.
1139 (usage): Tweak wording to mention STRING for --seed option.
1140 (short_options): Rorder for consistency with other programs.
1141 (rand_state): Now a struct, not a pointer to one. All uses changed.
1142 (HASH_WORDS, HASH_SIZE): Remove.
1143 (get_hash): Remove comments around resbuf size, since we can assume C89.
1144 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1145 (keycompare): Adjust to the new get_hash.
1147 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1148 (main): Don't set need_random simply because gkey has it set; that
1149 doesn't necessarily mean we'll need random numbers.
1150 Redo seeding to match new get_hash approach.
1152 2005-12-10 Jim Meyering <jim@meyering.net>
1154 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1156 Avoid shred segfault on 64-bit systems.
1157 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1158 local of type uint32_t. Make the local an `int' instead.
1160 * NEWS: Mention sort's new options.
1162 * src/rand-isaac.c (isaac_mix): Declare to be static.
1163 Mark all other functions as `extern' so the tight-scope
1164 part of `make distcheck' passes once again.
1165 * src/rand-isaac.h (isaac_mix): Remove declaration.
1167 * src/sort.c (get_hash): Change position of `*' in parameter
1168 type to conform with convention.
1169 (main): Split a long line so it fits in 80 columns.
1170 (keycompare): Remove stray SPACE before TAB that was
1171 causing `make distcheck' to fail.
1173 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1175 * tests/misc/sort-rand: New file: basic tests for the new options.
1176 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1178 2005-12-10 Frederik Eaton <frederik@ofb.net>
1180 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1181 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1182 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1183 Make state size runtime-configurable.
1184 (isaac_new, isaac_copy): New functions.
1185 * src/rand-isaac.h: New file.
1186 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1187 (fillrand, main): Adjust to the fact that the state size is now
1188 runtime-configurable.
1189 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1190 (usage): Add options --random-sort and --seed to implement a random
1192 Include md5.h and rand-isaac.h.
1193 (get_hash): New function.
1194 (rand_state): New var.
1195 (HASH_WORDS, HASH_SIZE): New macros.
1197 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1199 * tests/dd/misc: Add test for dd iflags=noatime.
1201 2005-12-09 Jim Meyering <jim@meyering.net>
1203 * src/sort.c (usage): Mention white space vs -b and -t options.
1206 2005-12-09 Eric Blake <ebb9@byu.net>
1208 * src/test.c (main): Fix misleading comment.
1210 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1212 * NEWS: Mention dd's new noatime flag.
1213 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1214 * src/dd.c (flags, usage): Add support for noatime flag.
1216 2005-12-07 Jim Meyering <jim@meyering.net>
1218 Distribute the cvsu script, used only by `make syntax-check'.
1219 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1220 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1221 distribute a copy of this script.
1222 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1224 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1225 to create a temporary directory on another partition.
1226 From Andreas Gruenbacher.
1228 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1230 * man/basename.x: Cross-reference to dirname and readlink.
1231 * man/dirname.x: Cross-reference to basename and readlink.
1233 2005-12-05 Andreas Gruenbacher
1235 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1236 (set_owner, preserve_author): New functions, factored out of copy_reg.
1237 (copy_reg): Use them.
1238 (copy_internal): Use them here, too.
1240 2005-12-04 Jim Meyering <jim@meyering.net>
1242 * src/sleep.c (usage): Say what happens with two or more arguments.
1243 Suggested by Justin Pryzby.
1245 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1248 2005-12-03 Jim Meyering <jim@meyering.net>
1250 * src/rm.c (long_opts): Change the name of each undocumented, for-
1251 testing-only option to start with `-', so that it cannot render
1252 ambiguous any prefix it happens to share with some other option name.
1253 Problem reported by Eric Blake.
1254 * src/head.c (long_options): Likewise.
1255 * src/tail.c (long_options): Likewise.
1257 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1258 testing-only --presume* options to start with `---'.
1259 * tests/rm/dangling-symlink: Likewise.
1260 * tests/rm/dir-no-w: Likewise.
1261 * tests/rm/isatty: Likewise.
1263 2005-11-30 Jim Meyering <jim@meyering.net>
1265 * Makefile.maint: Add a comment about cvsu.
1267 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1269 * NEWS: df updates for "none", "proc", inaccessible file systems.
1270 * src/df.c (show_point): Ignore inaccessible file systems.
1271 (usage): -a includes dummy file systems, not size-0 file systems.
1273 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1274 to avoid collision with POSIX name space. All uses changed.
1276 2005-11-24 Jim Meyering <jim@meyering.net>
1278 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1279 * tests/acl: Add `$0: ' prefix to diagnostics.
1281 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1283 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1285 * src/copy.c: Improve performance a bit by optimizing away
1286 unnecessary system calls and going to a block size of at least
1287 8192 (on normal hosts, anyway). This improved performance 5% on my
1288 Debian stable host (2.4.27 kernel, x86, copying from root
1289 ext3 file system to itself).
1290 Include "buffer-lcm.h".
1291 (copy_reg): Omit last argument. All callers changed.
1292 Use xmalloc to allocate rather than trusting alloca
1293 (which is unwise with large block sizes).
1294 Declare locals more locally, if possible.
1295 Use uintptr_t words instead of int words, for a bit more speed
1296 when looking for null blocks on 64-bit hosts.
1297 Optimize away reads of zero bytes on regular files.
1298 In the typical case, insist on 8 KiB buffers, at least.
1299 Avoid unnecessary extra call to fstat when checking for sparse files.
1300 Avoid now-unnecessary cast to off_t, and "0L".
1301 Avoid unnecessary test of *new_dst when checking for same owner
1304 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1306 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1308 2005-11-22 Jim Meyering <jim@meyering.net>
1310 * src/remove.c (AD_push): Remove debugging cruft.
1312 * tests/rm/unread2 (rm): Change expected diagnostic,
1313 `cannot open directory' to `cannot remove', to align with
1315 * tests/rm/rm2: Ensure that rm now continues removing entries
1316 even after certain types of failure.
1318 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1319 that provide openat (Solaris), and on systems like Linux+procfs
1320 where our openat emulation code is reentrant. This also fixes a
1321 few low-probability leaks and eliminates some code that could,
1322 in very unusual circumstances, cause rm() (via a callee) to exit.
1323 * NEWS: Mention this.
1325 * configure.ac: Put copyright dates all on one line so the
1326 emacs function that updates them works properly.
1328 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1330 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1331 Problem reported by Eric Blake.
1332 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1333 we get a standard-conforming compiler. This relies on the new
1334 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1335 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1336 m4/c.m4 can go away with Autoconf 2.60 comes out.
1338 2005-11-17 Jim Meyering <jim@meyering.net>
1340 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1341 (AD_mark_current_as_unremovable): Likewise, but for a local.
1344 * tests/mv/acl: Let traps handle removing temporary directories.
1346 Expect acl-related tests to fail, until the corresponding
1347 patches are committed.
1348 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1349 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1351 ACL tests, from Andreas Gruenbacher.
1352 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1353 * tests/mv/Makefile.am (TESTS): Add acl.
1354 * tests/cp/Makefile.am (TESTS): Add acl.
1356 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1358 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1360 * NEWS: Improve quality of ln's diagnostics.
1361 * src/ln.c (do_link, usage): Likewise.
1362 (do_link): Don't use alloca on a buffer of unbounded size.
1364 2005-11-16 Jim Meyering <jim@meyering.net>
1366 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1367 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1368 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1369 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1370 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1372 2005-11-14 Jim Meyering <jim@meyering.net>
1374 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1376 2005-11-13 Jim Meyering <jim@meyering.net>
1378 * announce-gen: Accept new option, --gpg-key-id=ID and
1379 emit a blurb telling how to use the .sig files.
1380 * Makefile.cfg (gpg_key_ID): Define.
1381 * Makefile.maint (announcement): Use new option and key.
1383 Require that most .c files include <config.h>.
1384 * Makefile.maint (sc_require_config_h): New rule.
1385 (syntax-check-rules): Add it.
1386 * .x-sc_require_config_h: New file listing exceptions to the
1387 above rule. Some are legit, others are simply grandfathered in.
1388 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1390 2005-11-12 Jim Meyering <jim@meyering.net>
1392 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1394 2005-11-11 Jim Meyering <jim@meyering.net>
1396 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1397 Mention new readlink options in 5.3.0's `New features' section.
1398 Spotted by Thomas Hood.
1400 2005-11-08 Jim Meyering <jim@meyering.net>
1402 * NEWS: Merge in changes from b5_9x branch.
1404 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1406 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1407 like --time-style='posix-long-iso' if the locale settings are messed up.
1408 * src/ls.c (decode_switches): Implement this.
1410 2005-11-08 Jim Meyering <jim@meyering.net>
1412 * tests/du/2g: s/expensive/very expensive/ in a comment.
1415 2005-10-17 Eric Blake <ebb9@byu.net>
1417 * src/ls.c (usage): Fix descriptions of --sort, --time.
1418 Reported by Vitaly A. Ostanin.
1420 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1422 * src/ln.c: Include filenamecat.c.
1423 (FILE_BASENAME_CONCAT): Remove.
1424 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1425 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1426 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1429 2005-11-04 Jim Meyering <jim@meyering.net>
1431 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1432 on systems with stat.st_blocks of a signed 32-bit type.
1433 This bug causes trouble on some AIX 5.1 systems.
1434 Report and trivial patch from Paul Townsend:
1435 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1436 * NEWS: Mention this.
1438 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1439 * tests/du/Makefile.am (TESTS): Add it here.
1440 * tests/very-expensive: New file.
1441 * tests/Makefile.am (EXTRA_DIST): Add it here.
1442 * tests/cp/perm: Mark this test as `very-expensive', too.
1444 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1446 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1448 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1450 * src/rm.c (usage): Don't mention rm -d.
1452 2005-11-02 Jim Meyering <jim@meyering.net>
1454 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1455 From Andreas Schwab.
1457 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1458 `M+N records in/out' lines don't pollute `make check' output.
1460 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1461 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1462 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1463 to indicate that the input file should be piped into the command
1464 under test (via `cat FILE | $prog ...').
1466 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1467 (without -r) fails to remove a directory on a non-Linux system.
1468 This change affects only newer Solaris systems (with priv_*
1469 functions like priv_allocset). Reported by Keith Thompson.
1471 * tests/rm/dir-nonrecur: New file/test for the above fix.
1472 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1474 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1476 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1477 POSIX 1002.1-2001 requires.
1478 * src/tail.c (parse_obsolete_option): Implement this.
1479 Problem reported by Vincent Lefevre.
1480 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1481 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1482 (test_vector): Add special cases for _POSIX2_VERSION, and
1483 regularize the old ones a bit.
1484 * tests/touch/obsolescent: Add y2000 test.
1486 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1488 * src/dd.c (skip): Fix off-by-one error reported by
1489 Theodoros V. Kalamatianos.
1491 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1493 * tests/mkdir/p-3: Require that the test be run as non-root.
1494 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1496 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1498 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1499 boundary between DEST and SOURCE in the result.
1501 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1503 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1504 back to text, to sync with documentation and for backwards
1507 2005-10-25 Jim Meyering <jim@meyering.net>
1509 * tests/dircolors/simple (other-wr): Add an explicit test for
1510 the dircolors bug (NULL-dereference) fixed yesterday.
1512 2005-10-24 Jim Meyering <jim@meyering.net>
1514 * src/tac.c (tac_file): When determining whether a file is seekable,
1515 also test whether it is a tty. Using only the lseek-based test would
1516 give a false positive on Solaris. Reported by Peter Fales.
1518 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1520 * tests/install/d-slashdot: New test, for "install -d" failure.
1521 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1522 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1523 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1525 2005-10-24 Jim Meyering <jim@meyering.net>
1527 * src/dircolors.c (ls_codes): Add missing comma.
1528 Anonymous report and patch from
1529 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1531 * src/dircolors.c: Add compile-time assertion that the slack_codes
1532 and ls_codes arrays have the same number of elements. This would
1533 have prevented the above-fixed bug.
1535 * src/expand.c (parse_tab_stops): Add a comment to make this function
1536 identical to the one in unexpand.c.
1537 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1538 identical to the one in expand.c.
1540 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1542 2005-10-23 Jim Meyering <jim@meyering.net>
1544 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1545 a dangerous pointer-value-to-`unsigned' cast.
1546 * NEWS: mention the new sha* programs.
1547 * AUTHORS: Add new sha* programs.
1549 2005-08-28 David Madore <david.madore@ens.fr>
1551 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1552 * README: Add their names to the list.
1553 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1554 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1555 Rules for compiling sha-2 utilities
1556 (noinst_HEADERS): Remove checksum.h.
1557 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1559 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1560 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1561 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1562 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1563 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1564 sha384sum, sha512sum test scripts here rather that each in its
1567 2005-08-28 David Madore <david.madore@ens.fr>
1569 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1570 of the FIPS test vectors).
1572 2005-10-23 Jim Meyering <jim@meyering.net>
1574 * configure.ac: Use 6.0-cvs as the version string.
1575 * NEWS: Adjust accordingly.