1 2006-07-16 Paul Eggert <eggert@cs.ucla.edu>
3 * NEWS: chmod, install, and mkdir now leave setgid and setuid bits
4 of directories alone unless you specify them explicitly.
5 install and mkdir now implement X correctly.
6 install now creates parent directories with mode 755, without
7 changing their owner or group.
8 * src/chmod.c (process_file): Adjust to mode_adjust API change.
9 * src/install.c: Include mkancesdirs.h.
10 (announce_mkdir, make_ancestor): New functions.
11 (DEFAULT_MODE): New macro, specifying initial value of 'mode'.
13 (dir_mode, dir_mode_bits): New vars.
14 (main): Set dir modes separately from nondir, so that the X
15 op of -m works correctly.
16 (main): Remove cwd_errno cruft, since make_dir_parents no longer
17 affects cwd. Adjust to new make_dir_parents API.
18 (install_file_in_file_parents): 2nd arg is now char *, not char
19 const *. Use mkancesdirs instead of rolling our own code.
20 (change_attributes): Don't worry about AFS, since that kludge
21 should not be needed any more.
22 * src/mkdir.c (struct mkdir_options): New struct.
23 (announce_mkdir, make_ancestor): New functions.
24 (main): Use them. Adjust to mode_adjust API change. Stick with
25 umask 0. Use make_dir_parents for all the work.
26 * src/mkfifo.c (main): Adjust to new mode_adjust API.
27 * src/mknod.c (main): Likewise.
28 * tests/chmod/setgid: Do the setgid test instead of bailing.
29 * tests/mkdir/p-3: Remove re_protect case that no longer applies.
30 GNU chmod now behaves like other versions of chmod.
31 * tests/mkdir/perm: Add a test for the X bug.
33 2006-07-14 Paul Eggert <eggert@cs.ucla.edu>
35 * src/base64.c (do_decode): Output to parameter OUT, not to stdout.
36 This doesn't fix any bugs, since OUT always equals stdout, but it
37 makes the code easier to understand.
39 2006-07-14 Jim Meyering <jim@meyering.net>
41 * Makefile.maint (CVS_LIST): Use new file, build-aux/vc-list-files,
42 rather than open-coding it. Now supports mercurial, too.
43 * .hgignore: New file.
44 * Makefile.am (EXTRA_DIST): Add .hgignore, which ignores nearly
45 all generated files, including ones like configure and po/*.po
46 that are currently version-controlled in cvs.
48 * Makefile.am (EXTRA_DIST): Add a few more .??* files.
49 They've been in CVS, just haven't been distributed before this.
50 Distribute ChangeLog-2005, too.
51 (MAINTAINERCLEANFILES): Add THANKS-to-translators.
53 2006-07-11 Paul Eggert <eggert@cs.ucla.edu>
55 * src/system.h: Assume <dirent.h> exists, since gnulib assumes
58 2006-07-09 Jim Meyering <jim@meyering.net>
60 * tests/mv/dir2dir: Adjust so failing with ENOTEMPTY is ok, too.
61 That happens with Linux/tmpfs.
62 * tests/mv/Makefile.am (TESTS): Add dir2dir.
64 2006-07-09 Paul Eggert <eggert@cs.ucla.edu>
66 Adjust to recent updates from gnulib.
67 * src/dd.c (apply_translations): Use toupper rather than
68 islower followed by toupper; it's simpler and typically
69 faster now that we assume at least C89 semantics. Similarly
71 * src/sort.c (inittables): Likewise.
72 * src/expand.c (expand): Don't assume that isprint etc. return
73 booleans (needed for pre-C99 hosts).
74 * src/fmt.c (check_punctuation): Likewise.
75 * src/ptx.c (initialize_regex, fix_output_parameters): Likewise.
76 * src/tr.c (is_char_class_member): Likewise.
77 * src/unexpand.c (unexpand): Likewise.
78 * src/join.c (is_blank): Remove; no longer needed. All uses
79 replaced by isblank (to_uchar (...)).
80 * src/pinky.c (create_fullname): Don't assume char is unsigned.
81 * src/printf.c (print_esc): Likewise.
82 * src/ptx.c (SKIP_NON_WHITE, SKIP_WHITE, SKIP_WHITE_BACKWARDS):
83 (copy_unescaped_string): Likewise.
84 * src/stat.c (print_it): Likewise.
85 * src/system.h (_D_EXACT_NAMELEN): Renamed from NLENGTH, for
86 convenience on GNU systems. All uses changed. Don't bother
87 looking for any dirent.h substitute other than ndir.h.
88 (D_INO): Remove unnecessary parentheses.
89 (IN_CTYPE_DOMAIN, ISGRAPH, ISPRINT, ISALNUM, ISALPHA):
90 (ISCNTRL, ISLOWER, ISPUNCT, ISSPACE, ISUPPER, ISXDIGIT):
91 (ISDIGIT_LOCALE, TOLOWER, TOUPPER): Remove. All uses changed
92 to ctype.h equivalents.
93 (isblank): Renamed from ISBLANK. Check for HAVE_DECL_ISBLANK too.
96 2006-07-08 Jim Meyering <jim@meyering.net>
98 * tests/mv/dir2dir: New file, test for 2006-07-05 fix in copy.c.
100 * Makefile.maint (sc_the_the): New rule.
102 * src/dd.c (skip): Remove one of two adjacent "the"s in a comment.
103 * tests/Coreutils.pm (run_tests): Remove one of two adjacent "then"s
106 2006-07-07 Jim Meyering <jim@meyering.net>
108 * NEWS: Mention that mv can now remove an empty destination directory,
109 and give an example. Prompted by a report from Florent Bayle.
111 2006-07-05 Jim Meyering <jim@meyering.net>
113 * src/ls.c (usage): Correct the description of -G: it is useful
114 only in a long listing. Reported by Martin Pool in
115 <https://launchpad.net/distros/ubuntu/+source/coreutils/+bug/51653>.
117 * man/chmod.x: Correct the description of the sticky bit. Reported
118 by Chris Moore via Ian Jackson in <http://bugs.debian.org/376745>.
120 * src/copy.c (copy_internal): Don't work around old NFS clients like
121 SunOS-4.1.4 and Irix 5.3 that set errno to values like EIO and
122 ENOTEMPTY upon failed rename. Otherwise, we risk misinterpreting
123 a banal failure as a recursive move-into-self failure.
124 Reported by Florent Bayle in <http://bugs.debian.org/376749>.
126 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
128 2006-07-03 Jim Meyering <jim@meyering.net>
130 Plug another unusual leak.
131 (AD_mark_helper): Free malloc'd filename if hash_insert says
132 that string is already in the hash table.
134 The dev/inode of the topmost directory in each hierarchy were not
136 * src/remove.c (remove_cwd_entries): Don't call cycle_check here.
137 (AD_push): Call it from here instead.
140 * src/remove.c (AD_stack_clear): New function.
142 (AD_pop_and_chdir): Free *prev_dir just before longjmp.
144 * tests/Makefile.am, tests/*/Makefile.am: (TESTS_ENVIRONMENT):
145 Add $VG_PATH_PREFIX as a prefix to $PATH
147 * tests/envvar-check (vars): Add CDPATH and POSIXLY_CORRECT.
148 * tests/Makefile.am (evar-check): Remove rule.
149 (EXTRA_DIST): Remove .env-warn.
150 * tests/.env-warn: Remove file. No longer used.
151 Suggestion from Eric Blake.
153 2006-07-02 Paul Eggert <eggert@cs.ucla.edu>
155 * src/system.h: Include <stdint.h> unconditionally, since we
156 now assume the stdint module.
158 2006-07-01 Paul Eggert <eggert@cs.ucla.edu>
160 * NEWS: With no operand, 'tail -f' now silently ignores the '-f'
161 only if standard input is a FIFO or pipe and POSIXLY_CORRECT is set.
162 * src/tail.c (main): Implement this.
163 * tests/tail/Test.pm (f-pipe-1): Renamed from f-1.
164 (test_vector): Set POSIXLY_CORRECT for the f-pipe-* tests.
166 2006-07-01 Jim Meyering <jim@meyering.net>
168 * src/ln.c (do_link): Use new, shorter URL, for ag-review link.
170 * .x-sc_require_config_h: Add ^lib/xstrtold\.c$, so make distcheck
173 2006-06-30 Paul Eggert <eggert@cs.ucla.edu>
175 * NEWS: seq now uses long double internally rather than double.
176 It now defaults to a minimal fixed point format if possible.
177 It lets you use %a, %A, %E, %F, %G.
178 * src/Makefile.am (seq_LDADD): Remove $(SEQ_LIBM); add $(POW_LIB).
179 * src/seq.c: Don't include <math.h> or <xstrtol.h>; no longer needed.
180 (isfinite) [!defined isfinite]: New macro.
181 (separator, terminator): Now points to const.
182 (first, step, last): Remove.
183 (usage): Update to match new behavior.
184 (struct operand, operand): New type.
185 (scan_arg): Renamed from scan_double_arg, since we no longer use double.
187 Compute and return a value of type operand, not double.
188 (long_double_format): Renamed from valid_format, and now returns a
189 new format with an "L" added if needed, if the original format was
190 valid. Allow %a, %A, %E, %F, and %G formats.
191 (print_numbers): Take numeric values as args rather than from globals.
192 Print long double, not double.
193 (get_width_format): Remove.
194 (get_default_format): New function.
195 (main): Implement new way of calculating default format.
196 Don't worry about locale's representation of the decimal point, since
197 the arguments are always processed in the C locale.
198 * tests/seq/basic (neg-2): Adjust to new default format.
199 (eq-wid-1, eq-wid-2): Resurrect these tests, since the new
200 implementation should do the right thing.
202 2006-06-30 Jim Meyering <jim@meyering.net>
204 * tests/stty/basic-1: Work around an intermittent test failure
205 on HP-UX 11.11. Report and analysis from Bob Proulx.
206 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7475
208 2006-06-28 Paul Eggert <eggert@cs.ucla.edu>
210 * NEWS: Support obsolete usages like "sort +1 -2" even when
211 conforming to POSIX 1003.1-2001, since this is a pure extension to
212 POSIX. Problem reported by Christian in:
213 http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00220.html
214 * src/sort.c (main): Implement this.
216 * src/system.h (CLOSEDIR): Remove. All uses changed to closedir.
217 Autoconf 2.60 says this stuff was obsolete.
219 2006-06-28 Jim Meyering <jim@meyering.net>
221 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
223 2006-06-28 Bob Proulx <bob@proulx.com> (tiny change)
225 * tests/mv/i-link-no: Work around HP-UX /bin/sh tracing problem
226 (set -x when VERBOSE=yes) when stderr is redirected before stdout
227 causing shell tracing of the stdout redirection to be written to
228 the stderr file. Avoid problem and test failure on HP-UX by
229 redirecting stderr last.
230 * tests/dd/unblock-sync: Order shell file redirections for
231 stderr and stdout in the common style.
234 2006-06-27 Jim Meyering <jim@meyering.net>
236 * tests/misc/cat-proc: Try to avoid any spurious numeric
237 differences in frequently-changing /proc/cpuinfo.
238 Reported by Nelson Beebe.
240 2006-06-26 Jim Meyering <jim@meyering.net>
242 Attempt rmdir (actually, unlinkat-with-AT_REMOVEDIR) upon any
243 fd_to_subdirp failure, not just when errno == EACCES.
244 * src/remove.c (remove_dir): Use unlinkat-with-AT_REMOVEDIR, not
245 rmdir, here, even though rmdir may happen to be adequate.
247 * NEWS: rm no longer fails to remove an empty, unreadable directory
248 * src/remove.c (remove_cwd_entries): If we can't open a directory,
249 and the failure is not being ignored, try to remove the directory
250 with rmdir (aka unlinkat-with-AT_REMOVEDIR), in case it's empty.
251 Problem report and test case from Paul Eggert in
252 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7425>.
254 * tests/rm/empty-inacc: New test, for the above.
256 Avoid a segfault for wc --files0=- < /dev/null.
257 * src/wc.c (compute_number_width): Return right away if nfiles == 0.
259 2006-06-25 Jim Meyering <jim@meyering.net>
261 * NEWS: wc accepts a new option --files0-from=FILE, where FILE
262 contains a list of NUL-separated file names.
264 * src/wc.c: Include "readtokens.h".
265 (usage): Describe the new option, and adjust the `Usage':
266 with this option, no FILE may be specified on the command line.
267 (main): Handle the new option.
268 * tests/misc/wc-files0: New tests, for the above.
269 * tests/misc/wc-files0-from: Likewise.
270 * tests/misc/Makefile.am (TESTS): Add wc-files0.
272 2006-06-24 Jim Meyering <jim@meyering.net>
274 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
276 2006-06-22 Jim Meyering <jim@meyering.net>
278 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
279 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
281 2006-06-19 Jim Meyering <jim@meyering.net>
283 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
284 so this check is not run as part of "make distcheck".
286 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
288 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
290 2006-06-18 Jim Meyering <jim@meyering.net>
292 * tests/misc/pwd-long: Make error output a little clearer.
294 2006-06-17 Jim Meyering <jim@meyering.net>
296 * tests/rm/inaccessible: Skip this test on systems without openat
297 support. Reported by Bob Proulx.
299 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
301 * tests/misc/mknod: Improve permission checks to handle
302 running mkdir test in set-gid directories.
304 2006-06-14 Jim Meyering <jim@meyering.net>
306 * tests/du/basic: Revamp not to hard-code file system block sizes.
308 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
310 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
313 2006-06-11 Jim Meyering <jim@meyering.net>
315 * .gitignore: New file.
316 * Makefile.am (EXTRA_DIST): Add .gitignore.
318 Setting TIME_STYLE=long-iso in the environment would make the
319 cp/same-file test fail.
320 * tests/envvar-check (vars): Add TIME_STYLE to the list.
321 * tests/cp/same-file: Revert last change.
322 Source the envvar-check script, to ensure that TIME_STYLE
323 settings don't affect these tests.
325 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
327 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
328 uses POSIX time stamp formats. Problem reported by John Nixon in
329 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
331 2006-06-10 Jim Meyering <jim@meyering.net>
333 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
335 Require a "Version N.M" line at the top of the ChangeLog
336 file only when making the actual release, not when running
338 * Makefile.maint (maintainer-distcheck): Don't depend on
340 (alpha beta major): Depend on it here, instead.
342 2006-06-08 Jim Meyering <jim@meyering.net>
344 Ensure that cat works with any of the options, -A -v -e -E -T,
345 when applied to files in /proc and /sys, even when the FIONREAD
346 ioctl produces nonsensical results. Before this change, cat would
347 produce no output (or truncated output), for some linux kernels.
349 * src/cat.c (write_pending): New function, factored out of cat.
350 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
351 that there are bytes to read. Some versions of linux-2.6.16 do that.
352 Write any pending output before returning.
353 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
354 * NEWS: Mention this bug fix.
355 * tests/misc/cat-proc: New file. Test for the above.
356 * tests/misc/Makefile.am (TESTS): Add cat-proc.
358 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
360 * src/expr.c (eval4): Detect overflow properly when multiplying
363 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
365 * NEWS: The 'expr' command now detects and reports integer overflow.
366 (It would be better to use extended precision instead, but that
368 * src/expr.c (integer_overflow): New function.
369 (eval4, eval3): Check for integer overflow.
371 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
373 Fix problems when building with Solaris/SVR4/etc. make, which uses a
374 different and somewhat bogus implementation of VPATH. In the
375 directory tests/misc, rename tests whose names might appear in the
376 Automake-generated rules. For example, we can't use a test named
377 'test', since Automake generates a rule that contains the text
378 "if test -f ./$$tst; ...", and this might expand to something like
379 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
380 which executes the 'test' script rather than the 'test' command.
381 * tests/misc/false-status: Renamed from tests/misc/false.
382 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
383 * tests/misc/sort-merge: Renamed from tests/misc/sort.
384 ($prog): Set to 'sort' rather than to $PROG.
385 * tests/misc/test-diag: Renamed from tests/misc/test.
386 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
387 in case Solaris make has prepended the directory.
388 (TESTS): Adjust to above renamings.
389 * tests/misc/expand: Don't assign to PROG; no longer needed
390 now that Makefile.am sets PROG to the basename.
391 * tests/misc/fold: Likewise.
393 2006-06-03 Jim Meyering <jim@meyering.net>
395 Make `cp --link --no-dereference' work also on systems where the
396 link system call cannot create a hard link to a symbolic link.
397 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
398 the link syscall on a symlink when it would do the wrong thing.
399 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
400 * tests/cp/link-no-deref: New file/test for the above.
401 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
402 * NEWS: Mention the change (doesn't affect Linux).
404 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
406 Fix some porting problems in the test cases reported by
407 Ralf Wildenhues for HP-UX 11.23 in:
408 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
409 * tests/help-version: Don't assume that \< \> works in sed.
410 * tests/misc/close-stdout: Don't assume that >&- works.
411 Add a /dev/full test.
412 * tests/touch/no-create-missing: Don't assume that >&- works.
414 2006-05-30 Jim Meyering <jim@meyering.net>
416 * src/ls.c (usage): Add `v' to the list of sorting-related options.
419 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
421 * tests/cp/fail-perm: source lang-default.
422 * tests/rm/inaccessible: Likewise.
424 2006-05-28 Jim Meyering <jim@meyering.net>
426 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
427 Recognize it, too. Reported by Ralf Wildenhues, in
428 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
430 2006-05-27 Jim Meyering <jim@meyering.net>
432 * src/chgrp.c: Support new options: --preserve-root and
433 --no-preserve-root. Somehow this program was skipped when those
434 options were added to chown, chmod, and rm. Reported by
435 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
436 * NEWS: Mention this.
438 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
440 * NEWS: Remove mention of --seed. We'll replace it with something
441 better, and don't want to indicate that it is supported.
442 * src/sort.c (usage): Likewise.
444 2006-05-20 Jim Meyering <jim@meyering.net>
446 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
448 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
449 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
450 FTS_COMFOLLOW. Spotted by Justin Pryzby.
452 * gnupload: Merge changes from automake, retaining the ""--to...
453 kludge to placate overzealous `make distcheck' check.
455 2006-05-19 Jim Meyering <jim@meyering.net>
457 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
458 FTS_TIGHT_CYCLE_CHECK directory traversal option.
459 Reported by Justin Pryzby in http://bugs.debian.org/367691
461 2006-05-15 Jim Meyering <jim@meyering.net>
463 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
466 2006-05-13 Jim Meyering <jim@meyering.net>
468 * tests/mv/no-target-dir: Test two more cases.
470 2006-05-11 Jim Meyering <jim@meyering.net>
472 mv -T DIR EMPTY_DIR no longer fails unconditionally
473 * src/copy.c (copy_internal): Don't manually prohibit a move where
474 the destination is an existing directory. Sometimes doing that is
475 valid. Let the rename system call enforce the rules. That is
476 allowed only when the source is a directory and the destination
477 directory (to be replaced) is empty. Reported by Eric Blake.
478 * tests/mv/no-target-dir: New file/test for this.
479 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
480 * NEWS: Mention this.
482 * tests/mv/atomic: New file/test for yesterday's fix.
483 * tests/mv/Makefile.am (TESTS): Add atomic.
485 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
487 2006-05-10 Jim Meyering <jim@meyering.net>
489 * src/copy.c (copy_internal): Don't explicitly unlink the destination
490 when moving a symlink into the place of an existing non-directory.
491 Reported by Joshua Hudson.
492 * NEWS: mention this.
494 2006-05-07 Jim Meyering <jim@meyering.net>
496 * Makefile.maint (patch-check): Fail if patch generates any output,
497 even merely for changed offsets.
499 * src/c99-to-c89.diff: Adjust to reflect new offsets.
501 * NEWS: Mention changes affecting df, pwd, shred.
503 2006-05-06 Jim Meyering <jim@meyering.net>
505 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
506 system condition where dirent.d_ino != stat.st_ino.
507 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
509 2006-05-06 Eric Blake <ebb9@byu.net>
511 * tests/ls/inode: Expand to test inode from readdir case.
512 * tests/ls/follow-slink: Expand to test broken links encountered
513 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
515 2006-05-06 Eric Blake <ebb9@byu.net>
517 * tests/mv/leak-fd: Work even on case-insensitive file system.
519 2006-05-04 Jim Meyering <jim@meyering.net>
521 * NEWS: Mention the 2006-03-19 pwd-related change that makes
522 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
524 2006-05-03 Jim Meyering <jim@meyering.net>
526 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
527 Use better macro parameter names: s/basename/key_name/,
528 s/basefunc/key_cmp_func. Fix typo in comment.
530 2006-04-29 Eric Blake <ebb9@byu.net>
532 * src/ls.c (main): On systems with d_type, directories_first only
533 implies format_needs_type, not format_needs_stat.
535 2006-05-03 Jim Meyering <jim@meyering.net>
537 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
538 after comma in arg list, from Eric Blake.
540 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
542 * tests/misc/date (relative-3): New test, derived from a bug
543 report by John Thomas McDole.
545 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
547 New option for ls: --group-directories-first.
548 It makes ls list directories before files.
549 * NEWS [New features]: Mention it.
550 * src/ls.c (sort_type): Rearrange to use as an array index when
551 choosing sort function; added new sort_numtypes member for
553 (time_type): Add new time_numtypes member for compile-time check.
554 (directories_first): New global variable.
555 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
556 (long_options): Add --directories-first.
557 (main): Support new option.
558 (is_directory): New function.
559 (extract_dirs_from_files): Use it.
560 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
561 (LIST_SORTFUNCTION_VARIANTS): New macros.
562 (sort_functions): New global variable.
563 (sort_files): Use it.
564 (usage): Document new option.
566 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
568 * src/shred.c (fillrand): The assertion was way too weak, due to
569 what must be a typo. Strengthen it to its intended value.
570 (dopass): Don't use alloca; it's not worth the aggravation here,
571 since it's used only to get a page-aligned buffer, and page
572 alignment doesn't buy us much here. I'm suspicious that alloca
573 causes problems on some hosts, due to a recent bug report by Adam
574 Waltman: http://bugs.gentoo.org/130246.
576 2006-04-18 Jim Meyering <jim@meyering.net>
578 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
579 sha384sum, sha512sum.
581 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
583 * src/chmod.c (describe_change): Adjust to filemode changes.
584 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
585 (print_long_format): Use (new) filemodestring rather than
586 (old) mode_string, so that we get more file types right, at least
587 in theory. Adjust to filemode changes.
588 * src/stat.c (human_access): Likewise.
590 2006-04-18 Jim Meyering <jim@meyering.net>
592 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
593 ignore file. This has never been enabled. Reported by Eric Blake.
595 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
597 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
598 bug in Interix. Just call symlink or link directly. All uses changed.
599 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
600 * src/stat.c (USE_STATVFS): New macro.
601 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
602 (NAMEMAX_FORMAT): define a bit more clearly, now that the
603 statvfs-using code is a bit more regular.
604 * src/system.h (sync) [!HAVE_SYNC]: New macro.
606 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
608 * NEWS: csplit, nl, expr now conform to POSIX better, and are
609 more-compatible with traditional Unix, with respect to regular
611 * src/csplit.c (extract_regexp): Set re_syntax_options to a
612 value that is compatible with what POSIX requires.
613 * src/nl.c (build_type_arg): Likewise.
614 * src/expr.c (docolon): Likewise. Also, don't let anchors match
615 newline; this fixes an incompatibility with tradition and with POSIX.
616 Don't warn about leading ^. POSIX says it is unspecified whether
617 ^ is a special character, which means that implementations can
618 either treat it as special or not, but either way a warning is not
619 allowed (unless the regexp is otherwise invalid). Instead, anchor
620 the expression but treat ^ as an anchor; this is the traditional
621 behavior (e.g., Solaris 10).
622 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
623 and the like as invalid expressions (exit status 2), not as
624 failure of 'expr' (exit status 3). This is more consistent with
626 * tests/expr/basic (fail-a): Adjust exit status to match new expr
627 behavior, for status 2 versus 3.
629 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
630 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
631 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
632 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
633 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
634 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
635 (bre61, bre62): New tests.
636 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
640 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
641 "if !". Do not assume that 'sed' can handle long, newline-free input.
642 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
644 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
646 Adjust to new regex.h API (with new fastmap type), and clean
647 up the regex storage allocation a bit.
649 * src/csplit.c (struct control): Put re_compiled member at the
650 end, since it's large. Change regexpr member from char * to bool;
651 all uses changed. Add new member fastmap.
652 (extract_regexp): regexp arg is now char const *, not char *.
653 Don't bother duplicating the regular expression; it's not needed.
654 Set fastmap from new fastmap member. Don't bother allocating
655 a buffer, as the regexp code does a better job than we do.
656 * src/expr.c (docolon): Allocate and use a fastmap.
657 Don't bother allocating a buffer.
658 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
660 (build_type_arg): New fastmap arg. All uses changed.
661 Don't bother allocating a buffer, but set a fastmap.
662 * src/ptx.c (context_regex_string, word_regex_string): Remove.
663 (context_regex, word_regex): New vars, replacing the above.
665 (struct regex_data): New type.
666 (compile_regex): Renamed from alloc_and_compile_regex, since
667 we no longer allocate storage. Arg is now a struct regex_data *,
668 not a const char *. All uses changed. Don't allocate the fastmap;
669 instead, take it from the caller. Don't convert size_t to int,
670 to avoid arithmetic overflow problems. Don't bother freeing
671 storage afterwards; it's not worth the aggravation.
672 * src/tac.c (compiled_separator_fastmap): New ver.
673 (main): Use it. Don't bother allocating a buffer.
675 2006-03-30 Jim Meyering <jim@meyering.net>
677 * src/dd.c (iwrite): Remove assignment without effect.
678 Reported by Felix Rauch Valenti.
680 2006-03-22 Eric Blake <ebb9@byu.net>
682 * src/ptx.c (usage): Remove mention of --copyright/-C.
683 (main): Alias --copyright to --version plus a deprecation warning.
684 * NEWS: Mention this.
686 2006-03-27 Jim Meyering <jim@meyering.net>
688 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
689 use of strtod. Tiny patch from Nickolai Zeldovich.
691 2006-03-11 Eric Blake <ebb9@byu.net>
693 * tests/misc/dirname: New file.
694 * tests/basename/Makefile.am: Delete.
695 * tests/basename/basic: Move to...
696 * tests/misc/basename: ... this new file. Add some tests,
697 including fixed behavior for //.
698 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
699 * tests/Makefile.am (SUBDIRS): Remove basename.
700 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
702 Improvements to dirname/basename handling on platforms like
703 cygwin with distinct // and with drive letters.
704 * NEWS: Document new behavior.
705 * src/basename.c (main): Don't strip suffix from file system
707 * src/cp.c (target_directory_operand): Use new last_component.
708 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
709 traversing the string.
710 * src/dircolors.c (guess_shell_syntax): Use new last_component.
711 * src/install.c (target_directory_operand, install_file_in_dir):
713 * src/ln.c (target_directory_operand, main): Likewise.
714 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
715 * src/mv.c (target_directory_operand, movefile): Likewise.
716 * src/remove.c (rm_1): Likewise.
717 * src/shred.c (wipename): Likewise.
718 * src/split.c (next_file_name): Likewise.
719 * src/su.c (log_su, run_shell): Likewise.
721 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
723 * NEWS: nohup diagnostics are now more precise, and nohup now
724 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
725 * src/nohup.c (main): Implement this.
726 * tests/misc/nohup: Test the new behavior.
728 2006-03-12 Jim Meyering <jim@meyering.net>
730 * src/copy.c (set_author): Rename function, from preserve_author.
732 * src/remove.c (AD_pop_and_chdir): Use new macro,
733 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
735 * src/system.h (SAME_INODE): Remove definition.
736 Include "same-inode.h", instead.
738 2006-03-11 Eric Blake <ebb9@byu.net>
740 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
742 2006-03-10 Jim Meyering <jim@meyering.net>
744 Fix a bug whereby a user with write access to a directory being removed
745 could cause the removal of that directory to fail with an erroneous
746 diagnostic about a directory cycle. Reported by Vineet Chadha.
748 * NEWS: Mention this.
749 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
750 leave (and try to rmdir) is the one whose dev_ino is being used to
751 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
753 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
755 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
756 * src/dd.c (set_fd_flags): Handle file-creation flags on file
757 descriptors, rather than ignoring them.
758 * tests/dd/misc: Add test cases for append, nofollow, directory,
759 and nolinks flags. Simplify redirection to /dev/null in some cases.
761 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
762 noatime test never tested anything.
764 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
766 * src/dd.c (flags, usage): New flags directory, nolinks.
767 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
769 * src/ls.c (usage): Mention that -f disables --color.
770 Problem reported by Niels Möller.
772 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
774 * man/*.x: Add references to syscalls from utilities of the same name.
776 2006-03-05 Jim Meyering <jim@meyering.net>
778 * tests/help-version: Set SHELL, if not already set, in order to
779 avoid failure when `make check' is run through debuild; dircolors
780 would fail due to lack of $SHELL. Reported by Sven Joachim.
782 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
783 * src/base64.c (wrap_write, do_encode, main): Change type of
784 parameters and locals, wrap_column, form size_t to uintmax_t.
785 (main): Adjust to use xstrtoumax, accordingly.
787 2006-03-03 Jim Meyering <jim@meyering.net>
789 Don't fail when run from an environment with SHELL not a Bourne
790 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
791 * tests/dircolors/simple: Invoke each non-failing test with -b.
792 Reported by Michael Stone.
794 2006-02-27 Jim Meyering <jim@meyering.net>
796 * tests/misc/base64: Derive --decode-using tests from the
799 * tests/misc/base64: Factor out a long constant string.
800 Split lines to stay within 80 columns.
802 * tests/misc/Makefile.am (TESTS): Add base64.
803 * tests/misc/base64: Test base64. From Simon Josefsson.
805 * src/base64.c (do_decode): Use correct type for parameter,
806 ignore_garbage: s/size_t/bool/.
808 * src/base64.c: Don't include .h files already included by system.h:
809 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
810 Include "system.h" before the other lib/*.h header files.
811 Include <sys/types.h> before "system.h".
812 (wrap_write): Remove declaration of unused local, initial_column.
813 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
815 * README: Add base64 to the list.
817 2006-02-17 Simon Josefsson <jas@extundo.com>
820 * AUTHORS: Mention base64.
822 * man/Makefile.am: Build base64.1.
823 * man/base64.x: New file.
824 * src/Makefile.am (bin_PROGRAMS): Add base64.
825 * src/base64.c: New file.
827 2006-02-25 Eric Blake <ebb9@byu.net>
829 In ls, avoid calling stat for --inode (-i), when possible.
830 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
831 * src/system.h: ... here, for use in ...
832 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
834 (gobble_file): Add inode argument.
835 (print_dir): Pass inode if available.
836 (usage): Remove inaccuracy.
838 2006-02-23 Jim Meyering <jim@meyering.net>
840 * TODO: Update/correct some obsolete entries.
842 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
844 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
845 * src/join.c (usage): Likewise.
846 Documentation problem reported by Philip Kensche.
848 2006-02-20 Eric Blake <ebb9@byu.net>
850 * man/rm.x: Update documentation to match previous patch.
852 2006-02-18 Eric Blake <ebb9@byu.net>
854 New option for rm: --interactive=once (-I).
855 * NEWS: Document it, along with change to rm --interactive.
856 * TODO: Remove entry for implementing rm -I
857 * src/rm.c (INTERACTIVE_OPTION): New enum value.
858 (interactive_type): New enum.
859 (long_opts): Let interactive take an optional argument.
860 (interactive_args, interactive_types): New option arguments.
861 (usage): Document -I, --interactive=WHEN. Use program_name
862 instead of a basename.
863 (main): New -I option, new behavior to --interactive.
864 * tests/rm/interactive-once: New tests.
865 * tests/rm/interactive-always: Ditto.
866 * tests/rm/Makefile.am (TESTS): Run them.
868 2006-02-18 Jim Meyering <jim@meyering.net>
870 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
871 expression match more of the target lines, e.g., those that start with
872 `-S,' (short option followed by a comma) or that include `=[...]'.
873 Patch by Nicolas François.
874 Fix the four offenders thus exposed:
875 * src/join.c (usage): Use two spaces (not one) to separate the
876 --first-only option string from its description, so help2man formats
877 the derived man page properly.
878 * src/pr.c (usage): Likewise.
879 * src/uniq.c (usage): Likewise.
880 * src/install.c (usage): Likewise.
882 2006-02-15 Jim Meyering <jim@meyering.net>
884 * Makefile.maint (alpha beta major): For `make major', ensure that the
885 version string is of the form N.N[.N]*, where N is one or more digits.
887 2006-02-14 Jim Meyering <jim@meyering.net>
889 * INSTALL: Update from gnulib.
891 2006-02-13 Jim Meyering <jim@meyering.net>
893 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
895 2006-02-12 Jim Meyering <jim@meyering.net>
897 * Makefile.maint (patch-check): New target.
898 (local-checks-available): Add to the list.
900 2006-02-11 Jim Meyering <jim@meyering.net>
902 * src/c99-to-c89.diff: New file.
903 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
905 * .x-po-check: New file, with exclusions so that `make distcheck'
907 * Makefile.am (EXTRA_DIST): Add .x-po-check.
909 rm -r must remove an empty directory, even if it is inaccessible.
910 * src/remove.c (close_preserve_errno): New function.
911 (fd_to_subdirp): Don't print a diagnostic in this function.
912 Do it from the callers instead, unless rmdir succeeds.
913 (remove_cwd_entries, remove_dir): Adjust callers.
914 * tests/rm/empty-inacc: New test for the above.
915 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
916 * NEWS: Mention this bug fix.
917 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
918 a tiny bit less precise: cannot remove `a/1': ... instead of
919 cannot open directory `a/1': ...
921 * Makefile.maint (syntax-check-rules): Automatically derive this
922 list of sc_-prefixed rule names.
924 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
926 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
927 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
928 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
929 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
930 go away? was that an accident?)
931 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
932 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
933 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
934 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
935 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
936 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
937 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
938 (author_mark_check, makefile_path_separator_check):
939 Output line numbers, to simplify navigation of Emacs *compilation*
941 (sc_prohibit_atoi_atof, sc_file_system):
942 Rework slightly so that Makefile.maint doesn't get reported as a
943 violation of its own syntax rules.
944 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
945 it at run-time (which didn't work with Bison). Fix a makefile typo,
946 caught by Makefile.maint itself: spaces where a tab should be.
947 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
948 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
949 Ignore djgpp and man subdirectories, to avoid false matches with
950 Bison and coreutils, respectively. Use sort -u to remove the
951 resulting duplicates.
952 * gnupload: Rework slightly to avoid bogus warning from
953 sc_two_space_separator_in_usage.
955 2006-02-10 Jim Meyering <jim@meyering.net>
957 Use gzip's --rsyncable option only if it's available.
958 * Makefile.maint (gzip_rsyncable): New variable.
961 2006-02-08 Jim Meyering <jim@meyering.net>
963 * Makefile.maint (local-checks-available): Define in terms of
964 the expansion, $(syntax-check-rules), rather than the single,
965 top-level target `syntax-check', so that it's easier to exclude
966 individual rules (via $(local-checks-to-skip)).
967 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
969 2006-02-07 Jim Meyering <jim@meyering.net>
971 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
972 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
974 * tests/help-version (expected_failure_status_vdir):
975 Redirect an expected disk-full diagnostic to /dev/null.
977 2006-02-06 Jim Meyering <jim@meyering.net>
979 * src/unexpand.c (usage): Use two spaces (not one) to separate the
980 --first-only option string from its description, so help2man formats
981 the derived man page properly.
982 * src/rm.c (usage): Likewise for --no-preserve-root.
983 * src/chown.c (usage): Likewise.
984 * src/chgrp.c (usage): Likewise.
986 Add a rule to ensure that the above doesn't happen again.
987 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
988 (syntax-check-rules): Add it.
989 * .x-sc_two_space_separator_in_usage: New empty file.
990 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
992 2006-02-06 Jim Meyering <jim@meyering.net>
994 * src/cp.c (usage): Use two spaces (not one) to separate each
995 option string from its description, so help2man formats the
996 derived man page properly.
997 * src/mv.c (usage): Likewise.
998 Patch from Nicolas François in http://bugs.debian.org/351601.
1000 2006-02-04 Jim Meyering <jim@meyering.net>
1002 * src/copy.c (copy_internal): cp -RL would fail when encountering
1003 the same directory more than once in the hierarchy beneath a single
1004 command-line argument. That is legitimate, e.g. when there are
1005 two or more symbolic links, each pointing to some directory that
1006 would not otherwise be copied. Reported by Christophe LYON.
1007 * tests/cp/cp-deref: New file. Test for today's fix.
1008 * tests/cp/Makefile.am (TESTS): Add cp-deref.
1009 * NEWS: Document this.
1011 2006-02-03 Jim Meyering <jim@meyering.net>
1013 * configure.ac: Require automake-1.9.6, not 1.8.3.
1015 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
1017 * src/od.c (usage): Mention that -t a ignores high order bit.
1018 Documentation problem reported by Ed Avis.
1020 2006-02-01 Jim Meyering <jim@meyering.net>
1022 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
1024 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
1026 * src/head.c (main): Use a better diagnostic when someone uses a
1027 trailing numeric option in an invalid way. Problem reported by
1029 * src/tail.c (parse_options): Likewise.
1031 2006-01-30 Jim Meyering <jim@meyering.net>
1033 * man/wc.x: Include `count' keyword in man page synopsis,
1034 per suggestion from http://bugs.debian.org/181585.
1036 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
1038 * src/df.c (show_dev): If the file system claims to have
1039 more available than total blocks, report the number of used
1040 blocks as being total - available (a negative number) rather
1041 than as garbage. Problem reported by Toralf Foerster.
1043 2006-01-24 Jim Meyering <jim@meyering.net>
1045 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
1046 to put a regular file in O_NONBLOCK mode fails with EPERM.
1047 That happens on Linux (up to 2.6.15) when using tail -f on a file with
1048 the append-only attribute. Reported by Dean Gaudet. For details,
1049 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
1050 * NEWS: Mention this fix.
1051 * tests/tail-2/append-only: New file. Test for the above.
1052 * tests/tail-2/Makefile.am (TESTS): Add append-only.
1053 * tests/Makefile.am (check-root): Add tail-2/append-only
1055 2006-01-21 Jim Meyering <jim@meyering.net>
1057 * NEWS: Mention fts-related improvements and bug fixes.
1059 2006-01-19 Jim Meyering <jim@meyering.net>
1061 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
1062 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
1064 2006-01-18 Jim Meyering <jim@meyering.net>
1066 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
1068 2006-01-17 Jim Meyering <jim@meyering.net>
1070 Now that fts no longer changes the current working directory, adjust
1071 its clients accordingly -- note that du.c uses fts but doesn't need
1072 any adjustment, since it doesn't operate on the actual files,
1073 but rather just uses the stat buffers provided by fts.
1075 * src/chown-core.c: Include "openat.h".
1076 Don't include "lchown.h".
1077 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
1078 calling openat, lchownat, chownat, rather than open, lchown, chown.
1080 * src/chmod.c: Include "openat.h".
1081 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
1083 * tests/du/long-from-unreadable: New test, to exercise one small
1086 2006-01-13 Jim Meyering <jim@meyering.net>
1088 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
1089 addition of new directories under tests/.
1091 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
1094 2006-01-12 Jim Meyering <jim@meyering.net>
1096 * tests/du/long-sloop: Adjust not to hard-code the expected
1097 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
1098 from that of GNU libc. Reported by Paul Eggert.
1100 * tests/du/long-sloop: Create file at end of symlink chain.
1102 * tests/misc/test: New file, with a test for one of the
1103 bugs fixed by yesterday's test.c changes.
1104 * tests/misc/Makefile.am (TESTS): Add test.
1106 2006-01-11 Jim Meyering <jim@meyering.net>
1108 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
1109 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
1110 a very long sequence of symbolic links (not necessarily a loop).
1111 * tests/du/Makefile.am (TESTS): Add long-sloop.
1113 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
1115 * src/test.c (test_syntax_error): Append a newline. All callers
1116 changed, except for the ones that didn't already append a newline.
1117 Bug reported by Eric Blake.
1119 2006-01-11 Jim Meyering <jim@meyering.net>
1121 * src/system.h (X2NREALLOC): Now that verify_true is no longer
1122 void, cast its result to void, to avoid gcc's warning that
1123 ``left-hand operand of comma expression has no effect''.
1124 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
1126 2006-01-10 Jim Meyering <jim@meyering.net>
1128 * tests/chmod/no-x: Add a test for today's fts.c fix.
1130 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
1132 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
1133 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
1135 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
1137 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
1138 Use verify_true instead of verify_expr, to sync with gnulib.
1140 2006-01-08 Jim Meyering <jim@meyering.net>
1142 * src/date.c (usage): Adjust the formatting of the entries for
1143 %::z and %:::z (separate with two spaces, not one) so that help2man
1144 formats them properly. Reported by Philip Rowlands.
1146 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
1148 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
1150 2006-01-06 Jim Meyering <jim@meyering.net>
1152 * Makefile.maint (copyright-check): Use date +%Y in place of
1155 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
1156 First off, the attribute should have been `volatile' (not static)
1157 to avoid longjmp-related risk of clobber. Secondly, now there is
1158 no longer any risk of a local variable being clobbered, so there's
1159 no need for any attribute at all.
1161 2006-01-05 Jim Meyering <jim@meyering.net>
1163 * src/remove.c: Give a few functions the inline attribute.
1164 (AD_pop_and_chdir): Use gotos to avoid some duplication.
1165 (AD_push): Rewrite an assertion so that the entire computation
1166 goes away when assertions are turned off.
1168 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
1169 It's already defined in "system.h".
1170 * Makefile.maint: Add a FIXME comment.
1172 2006-01-04 Jim Meyering <jim@meyering.net>
1174 * ChangeLog: Remove entries from 2005-10-22 and earlier.
1175 * ChangeLog-2005: New file, for entries up to version 5.92.
1177 2006-01-03 Jim Meyering <jim@meyering.net>
1179 * tests/du/no-x: Also allow a slightly different diagnostic -- the
1180 one you get when using openat-enabled fts.c and du (coming soon).
1181 * tests/chmod/no-x: Likewise.
1182 * tests/chgrp/no-x: Likewise.
1184 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
1186 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
1188 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
1189 (restricted_chown): Return it, if the file cannot be accessed due
1190 to EPERM, or if no uid or gid are required, or if the file is
1191 neither a directory nor a regular file. Rewrite to avoid gotos.
1192 (change_file_owner): Handle RC_do_ordinary_chown case.
1193 Rewrite to avoid gotos.
1194 * tests/chgrp/basic: Make sure we can change the group of
1197 * src/date.c (usage): Explain %g, %G, and %V a bit better.
1199 2006-01-02 Jim Meyering <jim@meyering.net>
1201 * src/copy.c (set_owner): Correct a comment.
1203 * src/tail.c (parse_options): Change warning to say that --retry
1204 is useful `mainly' (not `only') when following by name.
1205 Reported here: http://bugs.debian.org/273781
1207 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
1209 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
1210 * src/copy.c: Include lchmod.h.
1211 (copy_internal): Use lchmod rather than chmod.
1212 * src/cp.c: Include lchmod.h.
1213 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
1214 * src/mkdir.c: Include lchmod.h.
1215 (usage): Clarify -m's operation.
1216 (main): Use lchmod rather than chmod. Don't use lchmod unless the
1217 new mode contains bits outside the 777 range.
1218 * src/mkfifo.c (usage): Clarify -m's operation.
1219 (main): If -m is given, don't invoke chmod; use umask 0 instead.
1220 Report an error if -m asks for bits outside the 777 range.
1221 * src/mknod.c (usage, main): Likewise.
1223 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
1225 2005-12-27 Jim Meyering <jim@meyering.net>
1227 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
1228 (sc_prohibit_assert_without_use): New rule.
1229 (syntax-check-rules): Add it to the list.
1230 * .x-sc_prohibit_assert_without_use: New empty file.
1231 * Makefile.am (EXTRA_DIST): Add it.
1233 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
1235 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
1236 Don't include <assert.h>; it wasn't used.
1238 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
1240 * src/chown-core.c (restricted_chown):
1241 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
1242 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
1243 | O_NOFOLLOW too, for consistency with other dir-openers.
1244 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
1245 (is_empty_dir): Likewise.
1246 * src/shred.c (wipename): Likewise. Don't bother trying to open
1247 dir for writing, since POSIX prohibits it.
1249 2005-12-22 Jim Meyering <jim@meyering.net>
1251 * tests/help-version: Redirect stderr to /dev/full, to suppress
1252 write error diagnostic.
1254 2005-12-19 Jim Meyering <jim@meyering.net>
1256 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
1257 Avoid a minor race condition when `-m MODE' is specified, by using
1258 open, fchown, and close rather than just chown. To do that reliably --
1259 even with an overly restrictive umask -- ensure that each mkdir,
1260 mknod and mkfifo call uses a mode including at least owner-read access.
1261 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
1262 the subsequent chown (or equivalent open,fchown,close) fails.
1263 * tests/misc/mknod: New tests.
1264 * tests/misc/Makefile.am (TESTS): Add mknod.
1266 2005-12-17 Jim Meyering <jim@meyering.net>
1268 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
1269 e.g., on a named pipe.
1270 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
1271 place of all uses, since it is guaranteed (system.h) to be defined.
1273 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
1275 Add POSIX ACL support
1276 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
1277 is no requirement for ACL support; particularly, it does not exist
1278 on systems that have POSIX ACLs.
1279 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1280 * src/cp.c (umask_kill): With default acls, the umask is not to be
1281 applied. Remove umask_kill, don't change the process umask, and let
1282 the kernel apply the umask where appropriate.
1283 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1284 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1286 (copy_reg, copy_internal): Use copy_acl and set_acl
1287 instead of fchown/chown. Fix the logic for POSIX ACLs.
1288 (chown_succeded): Remove; we now always copy acls and
1289 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1290 did a chown before or not.
1291 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1292 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1293 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1294 to link with it via $(LIB_ACL), for the utilities that need it.
1296 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1298 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1299 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1300 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1301 value is now signified by whether cwd_errno is null.
1302 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1303 pointer-to-bool to pointer-to-errno-value. All callers changed.
1304 (rm_1): Don't bother setting a local cwd failure flag and then
1305 ORing it into the caller's. Just set the caller's.
1306 (rm): Use cwd failure errno value to print a slightly-better
1309 2005-12-15 Jim Meyering <jim@meyering.net>
1311 * src/stat.c (print_it): Properly handle a backslash at the
1312 end of a --printf format string. Reported by Paul Eggert.
1313 * tests/misc/stat-printf (end-bs): Add a test for the above.
1315 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1317 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1318 Don't assume /etc/passwd contains user names; use 'id' instead.
1320 2005-12-15 Jim Meyering <jim@meyering.net>
1322 stat: revert behavior of --format=FMT (-c)
1323 stat: add new option: --printf=FMT
1324 * NEWS: Mention this.
1325 * src/stat.c (isodigit, octtobin, hextobin): Define.
1326 (PRINTF_OPTION): Define.
1327 (interpret_backslash_escapes, trailing_delim): New globals.
1328 (usage): Document them. Alphabetize on long option names.
1329 (print_esc_char): New function.
1330 (print_it): Rewrite, in order to handle backslash escapes.
1331 (main): Handle new option. Set globals for --format, too.
1333 * tests/misc/stat-printf: Test --printf and --format.
1334 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1336 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1338 * NEWS: sort now reports incompatible options.
1339 * src/sort.c (incompatible_options, check_ordering_compatibility):
1341 (main): Use them. Don't bother with a usage message for
1342 "sort -c a b", for consistency with other error diagnostics.
1343 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1346 * src/cat.c (main): Undo previous change. close_stdout already
1347 does the check, so the previous change wasn't necessary.
1349 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1351 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1353 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1355 Install a more-conservative approach for sort -R. It's the
1356 same basic idea as the existing code, except it uses the full ISAAC
1357 approach (called the "more kosher" approach in the existing comments).
1358 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1359 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1360 better to be conservative here at first, and review any performance
1361 improvements carefully.
1362 * .x-sc_require_config_h: Add src/rand-isaac.c.
1363 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1364 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1365 (shred_SOURCES, sort_SOURCES): Remove.
1366 (EXTRA_DIST): Add rand-isaac.c.
1367 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1368 changing it to allow for varying numbers of words in the state.
1369 Alter so that we include rand-isaac.c directly rather than
1370 compiling it and linking to it. Don't include config.h or
1371 system.h; that's the includer's responsibility.
1372 Omit functions that are specific to shred.
1373 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1374 (isaac_step, struct irand_state):
1375 Resurrect these, with the same defns that used to be in shred.c.
1376 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1377 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1379 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1380 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1381 (irand_init, irand32, irand_mod):
1382 Number of words is constant again.
1383 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1384 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1385 * src/sort.c: Likewise.
1386 * src/shred.c (fillrand, dopass, main): Undo previous change.
1387 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1389 * src/sort.c: Don't include md5.h; it wasn't needed.
1390 (struct keyfield): Rename random_hash to random, for consistency
1391 with the other member names. All uses changed.
1392 (usage): Tweak wording to mention STRING for --seed option.
1393 (short_options): Rorder for consistency with other programs.
1394 (rand_state): Now a struct, not a pointer to one. All uses changed.
1395 (HASH_WORDS, HASH_SIZE): Remove.
1396 (get_hash): Remove comments around resbuf size, since we can assume C89.
1397 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1398 (keycompare): Adjust to the new get_hash.
1400 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1401 (main): Don't set need_random simply because gkey has it set; that
1402 doesn't necessarily mean we'll need random numbers.
1403 Redo seeding to match new get_hash approach.
1405 2005-12-10 Jim Meyering <jim@meyering.net>
1407 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1409 Avoid shred segfault on 64-bit systems.
1410 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1411 local of type uint32_t. Make the local an `int' instead.
1413 * NEWS: Mention sort's new options.
1415 * src/rand-isaac.c (isaac_mix): Declare to be static.
1416 Mark all other functions as `extern' so the tight-scope
1417 part of `make distcheck' passes once again.
1418 * src/rand-isaac.h (isaac_mix): Remove declaration.
1420 * src/sort.c (get_hash): Change position of `*' in parameter
1421 type to conform with convention.
1422 (main): Split a long line so it fits in 80 columns.
1423 (keycompare): Remove stray SPACE before TAB that was
1424 causing `make distcheck' to fail.
1426 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1428 * tests/misc/sort-rand: New file: basic tests for the new options.
1429 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1431 2005-12-10 Frederik Eaton <frederik@ofb.net>
1433 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1434 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1435 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1436 Make state size runtime-configurable.
1437 (isaac_new, isaac_copy): New functions.
1438 * src/rand-isaac.h: New file.
1439 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1440 (fillrand, main): Adjust to the fact that the state size is now
1441 runtime-configurable.
1442 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1443 (usage): Add options --random-sort and --seed to implement a random
1445 Include md5.h and rand-isaac.h.
1446 (get_hash): New function.
1447 (rand_state): New var.
1448 (HASH_WORDS, HASH_SIZE): New macros.
1450 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1452 * tests/dd/misc: Add test for dd iflags=noatime.
1454 2005-12-09 Jim Meyering <jim@meyering.net>
1456 * src/sort.c (usage): Mention white space vs -b and -t options.
1459 2005-12-09 Eric Blake <ebb9@byu.net>
1461 * src/test.c (main): Fix misleading comment.
1463 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1465 * NEWS: Mention dd's new noatime flag.
1466 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1467 * src/dd.c (flags, usage): Add support for noatime flag.
1469 2005-12-07 Jim Meyering <jim@meyering.net>
1471 Distribute the cvsu script, used only by `make syntax-check'.
1472 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1473 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1474 distribute a copy of this script.
1475 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1477 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1478 to create a temporary directory on another partition.
1479 From Andreas Gruenbacher.
1481 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1483 * man/basename.x: Cross-reference to dirname and readlink.
1484 * man/dirname.x: Cross-reference to basename and readlink.
1486 2005-12-05 Andreas Gruenbacher
1488 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1489 (set_owner, preserve_author): New functions, factored out of copy_reg.
1490 (copy_reg): Use them.
1491 (copy_internal): Use them here, too.
1493 2005-12-04 Jim Meyering <jim@meyering.net>
1495 * src/sleep.c (usage): Say what happens with two or more arguments.
1496 Suggested by Justin Pryzby.
1498 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1501 2005-12-03 Jim Meyering <jim@meyering.net>
1503 * src/rm.c (long_opts): Change the name of each undocumented, for-
1504 testing-only option to start with `-', so that it cannot render
1505 ambiguous any prefix it happens to share with some other option name.
1506 Problem reported by Eric Blake.
1507 * src/head.c (long_options): Likewise.
1508 * src/tail.c (long_options): Likewise.
1510 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1511 testing-only --presume* options to start with `---'.
1512 * tests/rm/dangling-symlink: Likewise.
1513 * tests/rm/dir-no-w: Likewise.
1514 * tests/rm/isatty: Likewise.
1516 2005-11-30 Jim Meyering <jim@meyering.net>
1518 * Makefile.maint: Add a comment about cvsu.
1520 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1522 * NEWS: df updates for "none", "proc", inaccessible file systems.
1523 * src/df.c (show_point): Ignore inaccessible file systems.
1524 (usage): -a includes dummy file systems, not size-0 file systems.
1526 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1527 to avoid collision with POSIX name space. All uses changed.
1529 2005-11-24 Jim Meyering <jim@meyering.net>
1531 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1532 * tests/acl: Add `$0: ' prefix to diagnostics.
1534 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1536 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1538 * src/copy.c: Improve performance a bit by optimizing away
1539 unnecessary system calls and going to a block size of at least
1540 8192 (on normal hosts, anyway). This improved performance 5% on my
1541 Debian stable host (2.4.27 kernel, x86, copying from root
1542 ext3 file system to itself).
1543 Include "buffer-lcm.h".
1544 (copy_reg): Omit last argument. All callers changed.
1545 Use xmalloc to allocate rather than trusting alloca
1546 (which is unwise with large block sizes).
1547 Declare locals more locally, if possible.
1548 Use uintptr_t words instead of int words, for a bit more speed
1549 when looking for null blocks on 64-bit hosts.
1550 Optimize away reads of zero bytes on regular files.
1551 In the typical case, insist on 8 KiB buffers, at least.
1552 Avoid unnecessary extra call to fstat when checking for sparse files.
1553 Avoid now-unnecessary cast to off_t, and "0L".
1554 Avoid unnecessary test of *new_dst when checking for same owner
1557 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1559 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1561 2005-11-22 Jim Meyering <jim@meyering.net>
1563 * src/remove.c (AD_push): Remove debugging cruft.
1565 * tests/rm/unread2 (rm): Change expected diagnostic,
1566 `cannot open directory' to `cannot remove', to align with
1568 * tests/rm/rm2: Ensure that rm now continues removing entries
1569 even after certain types of failure.
1571 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1572 that provide openat (Solaris), and on systems like Linux+procfs
1573 where our openat emulation code is reentrant. This also fixes a
1574 few low-probability leaks and eliminates some code that could,
1575 in very unusual circumstances, cause rm() (via a callee) to exit.
1576 * NEWS: Mention this.
1578 * configure.ac: Put copyright dates all on one line so the
1579 emacs function that updates them works properly.
1581 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1583 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1584 Problem reported by Eric Blake.
1585 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1586 we get a standard-conforming compiler. This relies on the new
1587 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1588 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1589 m4/c.m4 can go away with Autoconf 2.60 comes out.
1591 2005-11-17 Jim Meyering <jim@meyering.net>
1593 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1594 (AD_mark_current_as_unremovable): Likewise, but for a local.
1597 * tests/mv/acl: Let traps handle removing temporary directories.
1599 Expect acl-related tests to fail, until the corresponding
1600 patches are committed.
1601 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1602 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1604 ACL tests, from Andreas Gruenbacher.
1605 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1606 * tests/mv/Makefile.am (TESTS): Add acl.
1607 * tests/cp/Makefile.am (TESTS): Add acl.
1609 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1611 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1613 * NEWS: Improve quality of ln's diagnostics.
1614 * src/ln.c (do_link, usage): Likewise.
1615 (do_link): Don't use alloca on a buffer of unbounded size.
1617 2005-11-16 Jim Meyering <jim@meyering.net>
1619 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1620 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1621 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1622 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1623 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1625 2005-11-14 Jim Meyering <jim@meyering.net>
1627 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1629 2005-11-13 Jim Meyering <jim@meyering.net>
1631 * announce-gen: Accept new option, --gpg-key-id=ID and
1632 emit a blurb telling how to use the .sig files.
1633 * Makefile.cfg (gpg_key_ID): Define.
1634 * Makefile.maint (announcement): Use new option and key.
1636 Require that most .c files include <config.h>.
1637 * Makefile.maint (sc_require_config_h): New rule.
1638 (syntax-check-rules): Add it.
1639 * .x-sc_require_config_h: New file listing exceptions to the
1640 above rule. Some are legit, others are simply grandfathered in.
1641 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1643 2005-11-12 Jim Meyering <jim@meyering.net>
1645 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1647 2005-11-11 Jim Meyering <jim@meyering.net>
1649 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1650 Mention new readlink options in 5.3.0's `New features' section.
1651 Spotted by Thomas Hood.
1653 2005-11-08 Jim Meyering <jim@meyering.net>
1655 * NEWS: Merge in changes from b5_9x branch.
1657 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1659 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1660 like --time-style='posix-long-iso' if the locale settings are messed up.
1661 * src/ls.c (decode_switches): Implement this.
1663 2005-11-08 Jim Meyering <jim@meyering.net>
1665 * tests/du/2g: s/expensive/very expensive/ in a comment.
1668 2005-10-17 Eric Blake <ebb9@byu.net>
1670 * src/ls.c (usage): Fix descriptions of --sort, --time.
1671 Reported by Vitaly A. Ostanin.
1673 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1675 * src/ln.c: Include filenamecat.c.
1676 (FILE_BASENAME_CONCAT): Remove.
1677 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1678 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1679 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1682 2005-11-04 Jim Meyering <jim@meyering.net>
1684 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1685 on systems with stat.st_blocks of a signed 32-bit type.
1686 This bug causes trouble on some AIX 5.1 systems.
1687 Report and trivial patch from Paul Townsend:
1688 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1689 * NEWS: Mention this.
1691 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1692 * tests/du/Makefile.am (TESTS): Add it here.
1693 * tests/very-expensive: New file.
1694 * tests/Makefile.am (EXTRA_DIST): Add it here.
1695 * tests/cp/perm: Mark this test as `very-expensive', too.
1697 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1699 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1701 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1703 * src/rm.c (usage): Don't mention rm -d.
1705 2005-11-02 Jim Meyering <jim@meyering.net>
1707 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1708 From Andreas Schwab.
1710 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1711 `M+N records in/out' lines don't pollute `make check' output.
1713 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1714 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1715 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1716 to indicate that the input file should be piped into the command
1717 under test (via `cat FILE | $prog ...').
1719 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1720 (without -r) fails to remove a directory on a non-Linux system.
1721 This change affects only newer Solaris systems (with priv_*
1722 functions like priv_allocset). Reported by Keith Thompson.
1724 * tests/rm/dir-nonrecur: New file/test for the above fix.
1725 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1727 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1729 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1730 POSIX 1002.1-2001 requires.
1731 * src/tail.c (parse_obsolete_option): Implement this.
1732 Problem reported by Vincent Lefevre.
1733 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1734 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1735 (test_vector): Add special cases for _POSIX2_VERSION, and
1736 regularize the old ones a bit.
1737 * tests/touch/obsolescent: Add y2000 test.
1739 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1741 * src/dd.c (skip): Fix off-by-one error reported by
1742 Theodoros V. Kalamatianos.
1744 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1746 * tests/mkdir/p-3: Require that the test be run as non-root.
1747 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1749 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1751 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1752 boundary between DEST and SOURCE in the result.
1754 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1756 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1757 back to text, to sync with documentation and for backwards
1760 2005-10-25 Jim Meyering <jim@meyering.net>
1762 * tests/dircolors/simple (other-wr): Add an explicit test for
1763 the dircolors bug (NULL-dereference) fixed yesterday.
1765 2005-10-24 Jim Meyering <jim@meyering.net>
1767 * src/tac.c (tac_file): When determining whether a file is seekable,
1768 also test whether it is a tty. Using only the lseek-based test would
1769 give a false positive on Solaris. Reported by Peter Fales.
1771 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1773 * tests/install/d-slashdot: New test, for "install -d" failure.
1774 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1775 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1776 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1778 2005-10-24 Jim Meyering <jim@meyering.net>
1780 * src/dircolors.c (ls_codes): Add missing comma.
1781 Anonymous report and patch from
1782 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1784 * src/dircolors.c: Add compile-time assertion that the slack_codes
1785 and ls_codes arrays have the same number of elements. This would
1786 have prevented the above-fixed bug.
1788 * src/expand.c (parse_tab_stops): Add a comment to make this function
1789 identical to the one in unexpand.c.
1790 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1791 identical to the one in expand.c.
1793 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1795 2005-10-23 Jim Meyering <jim@meyering.net>
1797 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1798 a dangerous pointer-value-to-`unsigned' cast.
1799 * NEWS: mention the new sha* programs.
1800 * AUTHORS: Add new sha* programs.
1802 2005-08-28 David Madore <david.madore@ens.fr>
1804 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1805 * README: Add their names to the list.
1806 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1807 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1808 Rules for compiling sha-2 utilities
1809 (noinst_HEADERS): Remove checksum.h.
1810 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1812 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1813 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1814 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1815 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1816 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1817 sha384sum, sha512sum test scripts here rather that each in its
1820 2005-08-28 David Madore <david.madore@ens.fr>
1822 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1823 of the FIPS test vectors).
1825 2005-10-23 Jim Meyering <jim@meyering.net>
1827 * configure.ac: Use 6.0-cvs as the version string.
1828 * NEWS: Adjust accordingly.