1 2006-02-14 Jim Meyering <jim@meyering.net>
5 * INSTALL: Update from gnulib.
7 2006-02-13 Jim Meyering <jim@meyering.net>
9 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
11 2006-02-12 Jim Meyering <jim@meyering.net>
13 * Makefile.maint (patch-check): New target.
14 (local-checks-available): Add to the list.
16 2006-02-11 Jim Meyering <jim@meyering.net>
18 * src/c99-to-c89.diff: New file.
19 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
21 * .x-po-check: New file, with exclusions so that `make distcheck'
23 * Makefile.am (EXTRA_DIST): Add .x-po-check.
25 rm -r must remove an empty directory, even if it is inaccessible.
26 * src/remove.c (close_preserve_errno): New function.
27 (fd_to_subdirp): Don't print a diagnostic in this function.
28 Do it from the callers instead, unless rmdir succeeds.
29 (remove_cwd_entries, remove_dir): Adjust callers.
30 * tests/rm/empty-inacc: New test for the above.
31 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
32 * NEWS: Mention this bug fix.
33 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
34 a tiny bit less precise: cannot remove `a/1': ... instead of
35 cannot open directory `a/1': ...
37 * Makefile.maint (syntax-check-rules): Automatically derive this
38 list of sc_-prefixed rule names.
40 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
42 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
43 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
44 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
45 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
46 go away? was that an accident?)
47 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
48 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
49 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
50 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
51 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
52 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
53 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
54 (author_mark_check, makefile_path_separator_check):
55 Output line numbers, to simplify navigation of Emacs *compilation*
57 (sc_prohibit_atoi_atof, sc_file_system):
58 Rework slightly so that Makefile.maint doesn't get reported as a
59 violation of its own syntax rules.
60 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
61 it at run-time (which didn't work with Bison). Fix a makefile typo,
62 caught by Makefile.maint itself: spaces where a tab should be.
63 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
64 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
65 Ignore djgpp and man subdirectories, to avoid false matches with
66 Bison and coreutils, respectively. Use sort -u to remove the
68 * gnupload: Rework slightly to avoid bogus warning from
69 sc_two_space_separator_in_usage.
71 2006-02-10 Jim Meyering <jim@meyering.net>
73 Use gzip's --rsyncable option only if it's available.
74 * Makefile.maint (gzip_rsyncable): New variable.
77 2006-02-08 Jim Meyering <jim@meyering.net>
79 * Makefile.maint (local-checks-available): Define in terms of
80 the expansion, $(syntax-check-rules), rather than the single,
81 top-level target `syntax-check', so that it's easier to exclude
82 individual rules (via $(local-checks-to-skip)).
83 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
85 2006-02-07 Jim Meyering <jim@meyering.net>
87 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
88 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
90 * tests/help-version (expected_failure_status_vdir):
91 Redirect an expected disk-full diagnostic to /dev/null.
93 2006-02-06 Jim Meyering <jim@meyering.net>
95 * src/unexpand.c (usage): Use two spaces (not one) to separate the
96 --first-only option string from its description, so help2man formats
97 the derived man page properly.
98 * src/rm.c (usage): Likewise for --no-preserve-root.
99 * src/chown.c (usage): Likewise.
100 * src/chgrp.c (usage): Likewise.
102 Add a rule to ensure that the above doesn't happen again.
103 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
104 (syntax-check-rules): Add it.
105 * .x-sc_two_space_separator_in_usage: New empty file.
106 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
108 2006-02-06 Jim Meyering <jim@meyering.net>
110 * src/cp.c (usage): Use two spaces (not one) to separate each
111 option string from its description, so help2man formats the
112 derived man page properly.
113 * src/mv.c (usage): Likewise.
114 Patch from Nicolas François in http://bugs.debian.org/351601.
116 2006-02-04 Jim Meyering <jim@meyering.net>
118 * src/copy.c (copy_internal): cp -RL would fail when encountering
119 the same directory more than once in the hierarchy beneath a single
120 command-line argument. That is legitimate, e.g. when there are
121 two or more symbolic links, each pointing to some directory that
122 would not otherwise be copied. Reported by Christophe LYON.
123 * tests/cp/cp-deref: New file. Test for today's fix.
124 * tests/cp/Makefile.am (TESTS): Add cp-deref.
125 * NEWS: Document this.
127 2006-02-03 Jim Meyering <jim@meyering.net>
129 * configure.ac: Require automake-1.9.6, not 1.8.3.
131 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
133 * src/od.c (usage): Mention that -t a ignores high order bit.
134 Documentation problem reported by Ed Avis.
136 2006-02-01 Jim Meyering <jim@meyering.net>
138 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
140 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
142 * src/head.c (main): Use a better diagnostic when someone uses a
143 trailing numeric option in an invalid way. Problem reported by
145 * src/tail.c (parse_options): Likewise.
147 2006-01-30 Jim Meyering <jim@meyering.net>
149 * man/wc.x: Include `count' keyword in man page synopsis,
150 per suggestion from http://bugs.debian.org/181585.
152 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
154 * src/df.c (show_dev): If the file system claims to have
155 more available than total blocks, report the number of used
156 blocks as being total - available (a negative number) rather
157 than as garbage. Problem reported by Toralf Foerster.
159 2006-01-24 Jim Meyering <jim@meyering.net>
161 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
162 to put a regular file in O_NONBLOCK mode fails with EPERM.
163 That happens on Linux (up to 2.6.15) when using tail -f on a file with
164 the append-only attribute. Reported by Dean Gaudet. For details,
165 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
166 * NEWS: Mention this fix.
167 * tests/tail-2/append-only: New file. Test for the above.
168 * tests/tail-2/Makefile.am (TESTS): Add append-only.
169 * tests/Makefile.am (check-root): Add tail-2/append-only
171 2006-01-21 Jim Meyering <jim@meyering.net>
173 * NEWS: Mention fts-related improvements and bug fixes.
175 2006-01-19 Jim Meyering <jim@meyering.net>
177 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
178 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
180 2006-01-18 Jim Meyering <jim@meyering.net>
182 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
184 2006-01-17 Jim Meyering <jim@meyering.net>
186 Now that fts no longer changes the current working directory, adjust
187 its clients accordingly -- note that du.c uses fts but doesn't need
188 any adjustment, since it doesn't operate on the actual files,
189 but rather just uses the stat buffers provided by fts.
191 * src/chown-core.c: Include "openat.h".
192 Don't include "lchown.h".
193 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
194 calling openat, lchownat, chownat, rather than open, lchown, chown.
196 * src/chmod.c: Include "openat.h".
197 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
199 * tests/du/long-from-unreadable: New test, to exercise one small
202 2006-01-13 Jim Meyering <jim@meyering.net>
204 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
205 addition of new directories under tests/.
207 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
210 2006-01-12 Jim Meyering <jim@meyering.net>
212 * tests/du/long-sloop: Adjust not to hard-code the expected
213 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
214 from that of GNU libc. Reported by Paul Eggert.
216 * tests/du/long-sloop: Create file at end of symlink chain.
218 * tests/misc/test: New file, with a test for one of the
219 bugs fixed by yesterday's test.c changes.
220 * tests/misc/Makefile.am (TESTS): Add test.
222 2006-01-11 Jim Meyering <jim@meyering.net>
224 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
225 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
226 a very long sequence of symbolic links (not necessarily a loop).
227 * tests/du/Makefile.am (TESTS): Add long-sloop.
229 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
231 * src/test.c (test_syntax_error): Append a newline. All callers
232 changed, except for the ones that didn't already append a newline.
233 Bug reported by Eric Blake.
235 2006-01-11 Jim Meyering <jim@meyering.net>
237 * src/system.h (X2NREALLOC): Now that verify_true is no longer
238 void, cast its result to void, to avoid gcc's warning that
239 ``left-hand operand of comma expression has no effect''.
240 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
242 2006-01-10 Jim Meyering <jim@meyering.net>
244 * tests/chmod/no-x: Add a test for today's fts.c fix.
246 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
248 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
249 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
251 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
253 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
254 Use verify_true instead of verify_expr, to sync with gnulib.
256 2006-01-08 Jim Meyering <jim@meyering.net>
258 * src/date.c (usage): Adjust the formatting of the entries for
259 %::z and %:::z (separate with two spaces, not one) so that help2man
260 formats them properly. Reported by Philip Rowlands.
262 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
264 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
266 2006-01-06 Jim Meyering <jim@meyering.net>
268 * Makefile.maint (copyright-check): Use date +%Y in place of
271 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
272 First off, the attribute should have been `volatile' (not static)
273 to avoid longjmp-related risk of clobber. Secondly, now there is
274 no longer any risk of a local variable being clobbered, so there's
275 no need for any attribute at all.
277 2006-01-05 Jim Meyering <jim@meyering.net>
279 * src/remove.c: Give a few functions the inline attribute.
280 (AD_pop_and_chdir): Use gotos to avoid some duplication.
281 (AD_push): Rewrite an assertion so that the entire computation
282 goes away when assertions are turned off.
284 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
285 It's already defined in "system.h".
286 * Makefile.maint: Add a FIXME comment.
288 2006-01-04 Jim Meyering <jim@meyering.net>
290 * ChangeLog: Remove entries from 2005-10-22 and earlier.
291 * ChangeLog-2005: New file, for entries up to version 5.92.
293 2006-01-03 Jim Meyering <jim@meyering.net>
295 * tests/du/no-x: Also allow a slightly different diagnostic -- the
296 one you get when using openat-enabled fts.c and du (coming soon).
297 * tests/chmod/no-x: Likewise.
298 * tests/chgrp/no-x: Likewise.
300 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
302 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
304 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
305 (restricted_chown): Return it, if the file cannot be accessed due
306 to EPERM, or if no uid or gid are required, or if the file is
307 neither a directory nor a regular file. Rewrite to avoid gotos.
308 (change_file_owner): Handle RC_do_ordinary_chown case.
309 Rewrite to avoid gotos.
310 * tests/chgrp/basic: Make sure we can change the group of
313 * src/date.c (usage): Explain %g, %G, and %V a bit better.
315 2006-01-02 Jim Meyering <jim@meyering.net>
317 * src/copy.c (set_owner): Correct a comment.
319 * src/tail.c (parse_options): Change warning to say that --retry
320 is useful `mainly' (not `only') when following by name.
321 Reported here: http://bugs.debian.org/273781
323 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
325 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
326 * src/copy.c: Include lchmod.h.
327 (copy_internal): Use lchmod rather than chmod.
328 * src/cp.c: Include lchmod.h.
329 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
330 * src/mkdir.c: Include lchmod.h.
331 (usage): Clarify -m's operation.
332 (main): Use lchmod rather than chmod. Don't use lchmod unless the
333 new mode contains bits outside the 777 range.
334 * src/mkfifo.c (usage): Clarify -m's operation.
335 (main): If -m is given, don't invoke chmod; use umask 0 instead.
336 Report an error if -m asks for bits outside the 777 range.
337 * src/mknod.c (usage, main): Likewise.
339 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
341 2005-12-27 Jim Meyering <jim@meyering.net>
343 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
344 (sc_prohibit_assert_without_use): New rule.
345 (syntax-check-rules): Add it to the list.
346 * .x-sc_prohibit_assert_without_use: New empty file.
347 * Makefile.am (EXTRA_DIST): Add it.
349 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
351 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
352 Don't include <assert.h>; it wasn't used.
354 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
356 * src/chown-core.c (restricted_chown):
357 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
358 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
359 | O_NOFOLLOW too, for consistency with other dir-openers.
360 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
361 (is_empty_dir): Likewise.
362 * src/shred.c (wipename): Likewise. Don't bother trying to open
363 dir for writing, since POSIX prohibits it.
365 2005-12-22 Jim Meyering <jim@meyering.net>
367 * tests/help-version: Redirect stderr to /dev/full, to suppress
368 write error diagnostic.
370 2005-12-19 Jim Meyering <jim@meyering.net>
372 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
373 Avoid a minor race condition when `-m MODE' is specified, by using
374 open, fchown, and close rather than just chown. To do that reliably --
375 even with an overly restrictive umask -- ensure that each mkdir,
376 mknod and mkfifo call uses a mode including at least owner-read access.
377 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
378 the subsequent chown (or equivalent open,fchown,close) fails.
379 * tests/misc/mknod: New tests.
380 * tests/misc/Makefile.am (TESTS): Add mknod.
382 2005-12-17 Jim Meyering <jim@meyering.net>
384 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
385 e.g., on a named pipe.
386 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
387 place of all uses, since it is guaranteed (system.h) to be defined.
389 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
391 Add POSIX ACL support
392 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
393 is no requirement for ACL support; particularly, it does not exist
394 on systems that have POSIX ACLs.
395 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
396 * src/cp.c (umask_kill): With default acls, the umask is not to be
397 applied. Remove umask_kill, don't change the process umask, and let
398 the kernel apply the umask where appropriate.
399 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
400 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
402 (copy_reg, copy_internal): Use copy_acl and set_acl
403 instead of fchown/chown. Fix the logic for POSIX ACLs.
404 (chown_succeded): Remove; we now always copy acls and
405 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
406 did a chown before or not.
407 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
408 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
409 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
410 to link with it via $(LIB_ACL), for the utilities that need it.
412 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
414 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
415 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
416 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
417 value is now signified by whether cwd_errno is null.
418 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
419 pointer-to-bool to pointer-to-errno-value. All callers changed.
420 (rm_1): Don't bother setting a local cwd failure flag and then
421 ORing it into the caller's. Just set the caller's.
422 (rm): Use cwd failure errno value to print a slightly-better
425 2005-12-15 Jim Meyering <jim@meyering.net>
427 * src/stat.c (print_it): Properly handle a backslash at the
428 end of a --printf format string. Reported by Paul Eggert.
429 * tests/misc/stat-printf (end-bs): Add a test for the above.
431 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
433 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
434 Don't assume /etc/passwd contains user names; use 'id' instead.
436 2005-12-15 Jim Meyering <jim@meyering.net>
438 stat: revert behavior of --format=FMT (-c)
439 stat: add new option: --printf=FMT
440 * NEWS: Mention this.
441 * src/stat.c (isodigit, octtobin, hextobin): Define.
442 (PRINTF_OPTION): Define.
443 (interpret_backslash_escapes, trailing_delim): New globals.
444 (usage): Document them. Alphabetize on long option names.
445 (print_esc_char): New function.
446 (print_it): Rewrite, in order to handle backslash escapes.
447 (main): Handle new option. Set globals for --format, too.
449 * tests/misc/stat-printf: Test --printf and --format.
450 * tests/misc/Makefile.am (TESTS): Add stat-printf.
452 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
454 * NEWS: sort now reports incompatible options.
455 * src/sort.c (incompatible_options, check_ordering_compatibility):
457 (main): Use them. Don't bother with a usage message for
458 "sort -c a b", for consistency with other error diagnostics.
459 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
462 * src/cat.c (main): Undo previous change. close_stdout already
463 does the check, so the previous change wasn't necessary.
465 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
467 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
469 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
471 Install a more-conservative approach for sort -R. It's the
472 same basic idea as the existing code, except it uses the full ISAAC
473 approach (called the "more kosher" approach in the existing comments).
474 This makes "sort -R" quite a bit slower (about a factor of 2 on my
475 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
476 better to be conservative here at first, and review any performance
477 improvements carefully.
478 * .x-sc_require_config_h: Add src/rand-isaac.c.
479 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
480 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
481 (shred_SOURCES, sort_SOURCES): Remove.
482 (EXTRA_DIST): Add rand-isaac.c.
483 * src/rand-isaac.c: Revert to what used to be in shred.c, without
484 changing it to allow for varying numbers of words in the state.
485 Alter so that we include rand-isaac.c directly rather than
486 compiling it and linking to it. Don't include config.h or
487 system.h; that's the includer's responsibility.
488 Omit functions that are specific to shred.
489 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
490 (isaac_step, struct irand_state):
491 Resurrect these, with the same defns that used to be in shred.c.
492 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
493 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
495 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
496 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
497 (irand_init, irand32, irand_mod):
498 Number of words is constant again.
499 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
500 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
501 * src/sort.c: Likewise.
502 * src/shred.c (fillrand, dopass, main): Undo previous change.
503 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
505 * src/sort.c: Don't include md5.h; it wasn't needed.
506 (struct keyfield): Rename random_hash to random, for consistency
507 with the other member names. All uses changed.
508 (usage): Tweak wording to mention STRING for --seed option.
509 (short_options): Rorder for consistency with other programs.
510 (rand_state): Now a struct, not a pointer to one. All uses changed.
511 (HASH_WORDS, HASH_SIZE): Remove.
512 (get_hash): Remove comments around resbuf size, since we can assume C89.
513 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
514 (keycompare): Adjust to the new get_hash.
516 (badfieldspec): Omit recently-introduced comment; it isn't needed.
517 (main): Don't set need_random simply because gkey has it set; that
518 doesn't necessarily mean we'll need random numbers.
519 Redo seeding to match new get_hash approach.
521 2005-12-10 Jim Meyering <jim@meyering.net>
523 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
525 Avoid shred segfault on 64-bit systems.
526 * src/rand-isaac.c (isaac_refill): Don't try to negate a
527 local of type uint32_t. Make the local an `int' instead.
529 * NEWS: Mention sort's new options.
531 * src/rand-isaac.c (isaac_mix): Declare to be static.
532 Mark all other functions as `extern' so the tight-scope
533 part of `make distcheck' passes once again.
534 * src/rand-isaac.h (isaac_mix): Remove declaration.
536 * src/sort.c (get_hash): Change position of `*' in parameter
537 type to conform with convention.
538 (main): Split a long line so it fits in 80 columns.
539 (keycompare): Remove stray SPACE before TAB that was
540 causing `make distcheck' to fail.
542 * src/shred.c: Don't include gethrxtime.h. No longer needed.
544 * tests/misc/sort-rand: New file: basic tests for the new options.
545 * tests/misc/Makefile.am (TESTS): Add sort-rand.
547 2005-12-10 Frederik Eaton <frederik@ofb.net>
549 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
550 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
551 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
552 Make state size runtime-configurable.
553 (isaac_new, isaac_copy): New functions.
554 * src/rand-isaac.h: New file.
555 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
556 (fillrand, main): Adjust to the fact that the state size is now
557 runtime-configurable.
558 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
559 (usage): Add options --random-sort and --seed to implement a random
561 Include md5.h and rand-isaac.h.
562 (get_hash): New function.
563 (rand_state): New var.
564 (HASH_WORDS, HASH_SIZE): New macros.
566 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
568 * tests/dd/misc: Add test for dd iflags=noatime.
570 2005-12-09 Jim Meyering <jim@meyering.net>
572 * src/sort.c (usage): Mention white space vs -b and -t options.
575 2005-12-09 Eric Blake <ebb9@byu.net>
577 * src/test.c (main): Fix misleading comment.
579 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
581 * NEWS: Mention dd's new noatime flag.
582 * src/system.h (O_NOATIME): Define to 0 if not already defined.
583 * src/dd.c (flags, usage): Add support for noatime flag.
585 2005-12-07 Jim Meyering <jim@meyering.net>
587 Distribute the cvsu script, used only by `make syntax-check'.
588 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
589 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
590 distribute a copy of this script.
591 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
593 * tests/mv/acl: exit-77 before the trap, not after, if we fail
594 to create a temporary directory on another partition.
595 From Andreas Gruenbacher.
597 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
599 * man/basename.x: Cross-reference to dirname and readlink.
600 * man/dirname.x: Cross-reference to basename and readlink.
602 2005-12-05 Andreas Gruenbacher
604 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
605 (set_owner, preserve_author): New functions, factored out of copy_reg.
606 (copy_reg): Use them.
607 (copy_internal): Use them here, too.
609 2005-12-04 Jim Meyering <jim@meyering.net>
611 * src/sleep.c (usage): Say what happens with two or more arguments.
612 Suggested by Justin Pryzby.
614 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
617 2005-12-03 Jim Meyering <jim@meyering.net>
619 * src/rm.c (long_opts): Change the name of each undocumented, for-
620 testing-only option to start with `-', so that it cannot render
621 ambiguous any prefix it happens to share with some other option name.
622 Problem reported by Eric Blake.
623 * src/head.c (long_options): Likewise.
624 * src/tail.c (long_options): Likewise.
626 * tests/misc/head-elide-tail: Update uses of undocumented, for-
627 testing-only --presume* options to start with `---'.
628 * tests/rm/dangling-symlink: Likewise.
629 * tests/rm/dir-no-w: Likewise.
630 * tests/rm/isatty: Likewise.
632 2005-11-30 Jim Meyering <jim@meyering.net>
634 * Makefile.maint: Add a comment about cvsu.
636 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
638 * NEWS: df updates for "none", "proc", inaccessible file systems.
639 * src/df.c (show_point): Ignore inaccessible file systems.
640 (usage): -a includes dummy file systems, not size-0 file systems.
642 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
643 to avoid collision with POSIX name space. All uses changed.
645 2005-11-24 Jim Meyering <jim@meyering.net>
647 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
648 * tests/acl: Add `$0: ' prefix to diagnostics.
650 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
652 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
654 * src/copy.c: Improve performance a bit by optimizing away
655 unnecessary system calls and going to a block size of at least
656 8192 (on normal hosts, anyway). This improved performance 5% on my
657 Debian stable host (2.4.27 kernel, x86, copying from root
658 ext3 file system to itself).
659 Include "buffer-lcm.h".
660 (copy_reg): Omit last argument. All callers changed.
661 Use xmalloc to allocate rather than trusting alloca
662 (which is unwise with large block sizes).
663 Declare locals more locally, if possible.
664 Use uintptr_t words instead of int words, for a bit more speed
665 when looking for null blocks on 64-bit hosts.
666 Optimize away reads of zero bytes on regular files.
667 In the typical case, insist on 8 KiB buffers, at least.
668 Avoid unnecessary extra call to fstat when checking for sparse files.
669 Avoid now-unnecessary cast to off_t, and "0L".
670 Avoid unnecessary test of *new_dst when checking for same owner
673 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
675 * src/remove.c (rm): Don't assume C99 for-loop syntax.
677 2005-11-22 Jim Meyering <jim@meyering.net>
679 * src/remove.c (AD_push): Remove debugging cruft.
681 * tests/rm/unread2 (rm): Change expected diagnostic,
682 `cannot open directory' to `cannot remove', to align with
684 * tests/rm/rm2: Ensure that rm now continues removing entries
685 even after certain types of failure.
687 * src/remove.c: Rewrite. Now, this module is reentrant on systems
688 that provide openat (Solaris), and on systems like Linux+procfs
689 where our openat emulation code is reentrant. This also fixes a
690 few low-probability leaks and eliminates some code that could,
691 in very unusual circumstances, cause rm() (via a callee) to exit.
692 * NEWS: Mention this.
694 * configure.ac: Put copyright dates all on one line so the
695 emacs function that updates them works properly.
697 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
699 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
700 Problem reported by Eric Blake.
701 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
702 we get a standard-conforming compiler. This relies on the new
703 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
704 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
705 m4/c.m4 can go away with Autoconf 2.60 comes out.
707 2005-11-17 Jim Meyering <jim@meyering.net>
709 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
710 (AD_mark_current_as_unremovable): Likewise, but for a local.
713 * tests/mv/acl: Let traps handle removing temporary directories.
715 Expect acl-related tests to fail, until the corresponding
716 patches are committed.
717 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
718 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
720 ACL tests, from Andreas Gruenbacher.
721 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
722 * tests/mv/Makefile.am (TESTS): Add acl.
723 * tests/cp/Makefile.am (TESTS): Add acl.
725 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
727 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
729 * NEWS: Improve quality of ln's diagnostics.
730 * src/ln.c (do_link, usage): Likewise.
731 (do_link): Don't use alloca on a buffer of unbounded size.
733 2005-11-16 Jim Meyering <jim@meyering.net>
735 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
736 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
737 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
739 2005-11-14 Jim Meyering <jim@meyering.net>
741 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
743 2005-11-13 Jim Meyering <jim@meyering.net>
745 * announce-gen: Accept new option, --gpg-key-id=ID and
746 emit a blurb telling how to use the .sig files.
747 * Makefile.cfg (gpg_key_ID): Define.
748 * Makefile.maint (announcement): Use new option and key.
750 Require that most .c files include <config.h>.
751 * Makefile.maint (sc_require_config_h): New rule.
752 (syntax-check-rules): Add it.
753 * .x-sc_require_config_h: New file listing exceptions to the
754 above rule. Some are legit, others are simply grandfathered in.
755 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
757 2005-11-12 Jim Meyering <jim@meyering.net>
759 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
761 2005-11-11 Jim Meyering <jim@meyering.net>
763 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
764 Mention new readlink options in 5.3.0's `New features' section.
765 Spotted by Thomas Hood.
767 2005-11-08 Jim Meyering <jim@meyering.net>
769 * NEWS: Merge in changes from b5_9x branch.
771 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
773 * NEWS: ls now defaults to --time-style='locale', which in turn acts
774 like --time-style='posix-long-iso' if the locale settings are messed up.
775 * src/ls.c (decode_switches): Implement this.
777 2005-11-08 Jim Meyering <jim@meyering.net>
779 * tests/du/2g: s/expensive/very expensive/ in a comment.
782 2005-10-17 Eric Blake <ebb9@byu.net>
784 * src/ls.c (usage): Fix descriptions of --sort, --time.
785 Reported by Vitaly A. Ostanin.
787 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
789 * src/ln.c: Include filenamecat.c.
790 (FILE_BASENAME_CONCAT): Remove.
791 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
792 (main): Use file_name_concat, base_name, and strip_trailing_slashes
793 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
796 2005-11-04 Jim Meyering <jim@meyering.net>
798 * src/du.c (process_file): Don't overflow for files of size >= 2^31
799 on systems with stat.st_blocks of a signed 32-bit type.
800 This bug causes trouble on some AIX 5.1 systems.
801 Report and trivial patch from Paul Townsend:
802 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
803 * NEWS: Mention this.
805 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
806 * tests/du/Makefile.am (TESTS): Add it here.
807 * tests/very-expensive: New file.
808 * tests/Makefile.am (EXTRA_DIST): Add it here.
809 * tests/cp/perm: Mark this test as `very-expensive', too.
811 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
813 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
815 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
817 * src/rm.c (usage): Don't mention rm -d.
819 2005-11-02 Jim Meyering <jim@meyering.net>
821 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
824 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
825 `M+N records in/out' lines don't pollute `make check' output.
827 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
828 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
829 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
830 to indicate that the input file should be piped into the command
831 under test (via `cat FILE | $prog ...').
833 * src/remove.c (remove_entry): Emit a better diagnostic when rm
834 (without -r) fails to remove a directory on a non-Linux system.
835 This change affects only newer Solaris systems (with priv_*
836 functions like priv_allocset). Reported by Keith Thompson.
838 * tests/rm/dir-nonrecur: New file/test for the above fix.
839 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
841 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
843 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
844 POSIX 1002.1-2001 requires.
845 * src/tail.c (parse_obsolete_option): Implement this.
846 Problem reported by Vincent Lefevre.
847 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
848 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
849 (test_vector): Add special cases for _POSIX2_VERSION, and
850 regularize the old ones a bit.
851 * tests/touch/obsolescent: Add y2000 test.
853 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
855 * src/dd.c (skip): Fix off-by-one error reported by
856 Theodoros V. Kalamatianos.
858 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
860 * tests/mkdir/p-3: Require that the test be run as non-root.
861 Problem and trivial fix reported by Theodoros V. Kalamatianos.
863 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
865 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
866 boundary between DEST and SOURCE in the result.
868 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
870 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
871 back to text, to sync with documentation and for backwards
874 2005-10-25 Jim Meyering <jim@meyering.net>
876 * tests/dircolors/simple (other-wr): Add an explicit test for
877 the dircolors bug (NULL-dereference) fixed yesterday.
879 2005-10-24 Jim Meyering <jim@meyering.net>
881 * src/tac.c (tac_file): When determining whether a file is seekable,
882 also test whether it is a tty. Using only the lseek-based test would
883 give a false positive on Solaris. Reported by Peter Fales.
885 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
887 * tests/install/d-slashdot: New test, for "install -d" failure.
888 * tests/install/Makefile.am (TESTS): Add d-slashdot.
889 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
890 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
892 2005-10-24 Jim Meyering <jim@meyering.net>
894 * src/dircolors.c (ls_codes): Add missing comma.
895 Anonymous report and patch from
896 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
898 * src/dircolors.c: Add compile-time assertion that the slack_codes
899 and ls_codes arrays have the same number of elements. This would
900 have prevented the above-fixed bug.
902 * src/expand.c (parse_tab_stops): Add a comment to make this function
903 identical to the one in unexpand.c.
904 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
905 identical to the one in expand.c.
907 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
909 2005-10-23 Jim Meyering <jim@meyering.net>
911 * src/md5sum.c (digest_check, main): Use ptr_align rather than
912 a dangerous pointer-value-to-`unsigned' cast.
913 * NEWS: mention the new sha* programs.
914 * AUTHORS: Add new sha* programs.
916 2005-08-28 David Madore <david.madore@ens.fr>
918 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
919 * README: Add their names to the list.
920 * src/md5sum.c: Provide framework for computing sha-2 hashes.
921 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
922 Rules for compiling sha-2 utilities
923 (noinst_HEADERS): Remove checksum.h.
924 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
926 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
927 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
928 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
929 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
930 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
931 sha384sum, sha512sum test scripts here rather that each in its
934 2005-08-28 David Madore <david.madore@ens.fr>
936 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
937 of the FIPS test vectors).
939 2005-10-23 Jim Meyering <jim@meyering.net>
941 * configure.ac: Use 6.0-cvs as the version string.
942 * NEWS: Adjust accordingly.