1 2006-08-10 Jim Meyering <jim@meyering.net>
3 * src/dircolors.hin: Add a TERM directive for each of the following:
4 ansi, color-xterm, gnome, konsole, kterm, rxvt-cygwin,
5 rxvt-cygwin-native, screen.linux, xterm-256color.
6 Sort the TERM directives.
9 2006-08-09 Paul Eggert <eggert@cs.ucla.edu>
11 * src/dd.c (usage): Warn about oflag=append without conv=notrunc.
12 See Debian bug 373736.
14 * src/dircolors.hin: Add mlterm, rxvt-unicode; this fixes Debian
17 * src/.cvsignore: Add shuf.
19 * Makefile.maint: Remove the po-update procedure; it doesn't
20 work with the new repository on http://www.iro.umontreal.ca/.
21 For now I guess we'll have to fix things by hand.
22 (do-po-update, po-update): Remove. All references removed.
24 * src/shuf.c (next_line): New function.
25 (read_input): Use it, to avoid relying on GCC-specific behavior
26 with void * arithmetic. Problem reported by Bob Proulx.
27 * Makefile.maint (my-distcheck): Compile with -Wpointer-arith
28 to detect this sort of problem automatically in the future.
30 2006-08-09 Jim Meyering <jim@meyering.net>
32 * src/ls.c: Add a compile-time check to ensure that filetype
33 and filetype_letter have the same number of elements.
35 * tests/misc/sort-rand: Remove use of --seed=S.
37 2006-08-08 Paul Eggert <eggert@cs.ucla.edu>
39 Add a command 'shuf', and modify shred and sort to use the new
40 random number generator library of 'shuf'.
44 * NEWS: Likewise. Mention new --random-source option for shred
45 and sort. Move "sort +1 -2" notice to the appropriate section,
46 and clarify its role with respect to POSIXLY_CORRECT.
47 * man/.cvsignore: Add shuf.1.
48 * man/Makefile.am (dist_man_MANS): Add shuf.1.
49 (shuf.1): New dependency.
50 * man/shuf.x: New file.
51 * src/Makefile.am (bin_PROGRAMS): Add shuf.
52 (EXTRA_DIST): Remove rand-isaac.c.
53 (shuf_LDADD): New macro.
54 * src/rand-isaac.c: Remove, moving most of its contents to
56 * src/shuf.c: New file.
57 * src/shred.c: Use new random-number interface rather than rand-isaac.c.
58 Don't include rand-isaac.c; include randint.h and randread.h instead.
59 (RANDOM_SOURCE_OPTION): New enum.
60 (long_opts, usage, main): New option --random-source.
61 * src/sort.c: Likewise.
62 * src/shred.c (struct irand_state, irand_init, irand32, irand_mod): Remove.
63 All callers changed to use randint interface.
64 (fillrand): Remove. All callers changed to use randread interface.
65 (dopass): Remove dependency on ISAAC buffer size.
66 (genpattern): Don't wipe the random state here.
67 (randint_source): New static var.
68 (clear_random_data): New function.
69 (main): Allocate random source, and arrange to wipe it on exit.
70 * src/sort.c: Include md5.h, randread.h, xmemxfrm.h.
71 (longopts, usage, main): Remove undocumented --seed option;
72 it's now replaced by --random-source.
73 (rand_state, get_hash): Remove.
74 (randread_source): New static var.
75 (random_state, cmp_hashes, compare_random): New functions; they guarantee
76 no collisions in the random hash function.
77 (keycompare): Use compare_random for -R; don't fall back on comparing
78 via memcoll, since compare_random does the right thing.
79 * tests/misc/Makefile.am (TESTS): Add shuf.
80 * tests/misc/shuf: New file.
82 2006-07-29 Paul Eggert <eggert@cs.ucla.edu>
84 * src/copy.c (set_author): Preserve the st_author field via the
85 file descriptor dest_desc.
87 2006-07-28 Paul Eggert <eggert@cs.ucla.edu>
89 * NEWS: chmod now preserves setuid and setgid bits on directories
90 if you use a numeric mode with them clear, e.g., "chmod 755 DIR".
92 Fix test case problems if working directory is setgid,
93 reported by Bob Proulx.
94 * tests/cp/fail-perm: Use symbolic mode so that we clear
95 setgid bit more reliably on directories.
96 * tests/mkdir/special-1 (set_mode_string): Likewise.
98 2006-07-27 Jim Meyering <jim@meyering.net>
100 * src/chgrp.c (usage): Use correct grammar in description of the
102 * src/chown.c (usage): Likewise.
104 2006-07-26 Thomas Schwinge <tschwinge@gnu.org> (tiny change)
106 * src/copy.c (set_author) [HAVE_STRUCT_STAT_ST_AUTHOR]:
107 Correctly access SRC_SB's element ST_AUTHOR.
109 2006-07-26 Jim Meyering <jim@meyering.net>
111 * tests/ls/stat-failed: Adapt to match new expected output.
114 * src/ls.c (print_color_indicator): Test for S_IFREG first, rather
115 than having the code test for all of the other types first.
116 Hoist the set-uid/gid-testing code "up" into this new block.
117 Classify any other type of file (e.g., S_TYPEISSHM, etc.) as
118 C_ORPHAN, not as C_FILE.
120 2006-07-26 Jim Meyering <jim@meyering.net>
122 Checking in a change from Paul.
124 2006-07-25 Paul Eggert <eggert@cs.ucla.edu>
126 * src/ls.c (DT_INIT): Remove. All uses removed.
127 (enum filetype): Use an ordinary enum rather than trying to keep
128 the values in sync with DT_FIFO etc. That way, we don't have
129 to make special assumptions about them. All uses changed.
130 (whiteout): New constant member of enum filetype.
131 (filetype_letter): New constant, for use with enum filetype.
132 (FILETYPE_INDICATORS): New initializer list.
133 (print_dir): Add case for DT_WHT.
134 (gobble_file): If stat fails, don't discard information from
135 readdir; instead, preserve it so it can be printed.
136 (print_long_format): Fall back on readdir result if stat info
137 is not available. Use "?" to denote each unknown mode char,
138 instead of an overall "?", since we now know some of the mode
140 (print_type_indicator): Now that MODE isn't necessarily
141 useful, guard all uses.
142 Now that two blocks in the type-checking tree can set "type = C_FILE",
143 move the suffix-handling code out and down.
145 2006-07-26 Jim Meyering <jim@meyering.net>
147 Prepare for the above change.
148 * src/ls.c [struct fileinfo] (stat_ok): Rename from stat_failed,
149 and adjust uses. From a patch by Paul Eggert.
151 2006-07-26 Jim Meyering <jim@meyering.net>
153 * src/ls.c: Correct indentation/formatting in a few places.
155 2006-07-25 Paul Eggert <eggert@cs.ucla.edu>
157 * tests/cp/fail-perm: Use "chmod 0500" rather than "chmod 500".
158 Problem report and fix from Bob Proulx.
159 * NEWS: Clarify the "chmod 0500" news, and correct the vague
160 statements about compatibility with BSD.
162 2006-07-25 Jim Meyering <jim@meyering.net>
164 * src/ls.c (gobble_file): When handling a stat-failed entry,
165 print the entry name not the absolute_name -- to be consistent
167 * tests/ls/stat-failed: Update accordingly.
169 * src/ls.c: Add parens around the new uses of ?: ternary operator.
171 * src/dircolors.hin: Mention that ORPHAN refers not just to dangling
174 Get --dired offsets right when handling stat-failed entries.
175 * src/ls.c (print_long_format): Be careful to increment P by the
176 appropriate amount, even when inode_number_width and nlink_width
178 * tests/ls/stat-failed: Test for the above.
180 * src/ls.c (gobble_file) [USE_ACL]: Don't use-uninitialized the
181 have_acl member. That would happen for a directory with both a
182 non-stat'able entry and one with an ACL.
184 * src/ls.c (gobble_file): Make it so failure to stat a
185 non-command-line file provokes an exit status of 1, not 0.
186 Say "cannot access" rather than "cannot stat".
187 * tests/ls/stat-failed: New file/test, for the above.
188 * tests/ls/Makefile.am (TESTS): Add stat-failed.
189 * tests/ls-2/tests (no-a-isdir-b): Update to reflect addition
190 of "cannot access " to diagnostic.
192 * src/ls.c: Declare stat_failed to be "bool", not "int" everywhere.
194 * src/ls.c [enum filetype] (command_line): Remove member. Not needed.
195 Replace all occurrences of "type == command_line" with the
196 equivalent, "command_line_arg".
198 * src/ls.c: Apply the stat-failed parts of Red Hat's
199 coreutils-selinux.patch. From Ulrich Drepper.
200 This makes it so files not mentioned on the command line (e.g.,
201 names read from a directory that *is* mentioned on the command
202 line) for which stat fails are still listed. With --color,
203 such files are colored just like ORPHANs (aka dangling symlinks).
205 * src/df.c (n_valid_args): Declare global to be static.
207 2006-07-24 Jim Meyering <jim@meyering.net>
209 * tests/ls/stat-dtype: Skip this test on reiserfs, since that file
210 system lacks d_type support.
212 2006-07-22 Paul Eggert <eggert@cs.ucla.edu>
214 * man/chmod.x: Update to reflect recent changes to coreutils.texi.
216 2006-07-21 Jim Meyering <jim@meyering.net>
218 * src/su.c (usage): Correct typo in --help output: s/commmand/command/
219 Reported by Tim Waugh.
220 Also remove the comment duplicating much of --help output.
222 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): Reposition this new
223 name so the list remains alphabetized.
225 Fix another bug: ls --indicator-style=file-type would call
226 stat for a symlink, even though it wasn't always needed.
227 In some cases, that unnecessary stat would cause ls to fail.
228 * src/ls.c (gobble_file): Don't treat symlinks specially (in
229 requiring a stat syscall). Remove the offending exclusion.
231 * NEWS: Mention the fix.
233 * tests/ls/stat-dtype: New file/test, for the above fix.
234 Also exercises the new df feature, below.
236 * src/df.c (main): Fail and don't print the headers if no
237 file system is processed. This makes it easy to test whether
238 a specified directory is on a file system of a given type or types.
239 Otherwise, applications would have had to parse df's output.
240 E.g., is "." either ext3 or reiserfs: df -t ext3 -t reiserfs .
242 Fix a bug: ls --file-type worked like --indicator-style=slash,
243 rather than like --indicator-style=file-type.
244 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): New enum member.
245 (long_options): Map "file-type" to FILE_TYPE_INDICATOR_OPTION,
247 (decode_switches): Handle new case: FILE_TYPE_INDICATOR_OPTION.
248 * NEWS: Mention the fix.
249 * tests/ls-2/tests (file-type): New test, for the above fix.
251 2006-07-19 Jim Meyering <jim@meyering.net>
253 * src/ls.c (print_dir): Give a better diagnostic for failed opendir.
255 * Makefile.am (EXTRA_DIST): Add build-aux/vc-list-files.
257 2006-07-16 Paul Eggert <eggert@cs.ucla.edu>
259 * NEWS: chmod, install, and mkdir now leave setgid and setuid bits
260 of directories alone unless you specify them explicitly.
261 install and mkdir now implement X correctly.
262 install now creates parent directories with mode 755, without
263 changing their owner or group.
264 * src/chmod.c (process_file): Adjust to mode_adjust API change.
265 * src/install.c: Include mkancesdirs.h.
266 (announce_mkdir, make_ancestor): New functions.
267 (DEFAULT_MODE): New macro, specifying initial value of 'mode'.
269 (dir_mode, dir_mode_bits): New vars.
270 (main): Set dir modes separately from nondir, so that the X
271 op of -m works correctly.
272 (main): Remove cwd_errno cruft, since make_dir_parents no longer
273 affects cwd. Adjust to new make_dir_parents API.
274 (install_file_in_file_parents): 2nd arg is now char *, not char
275 const *. Use mkancesdirs instead of rolling our own code.
276 (change_attributes): Don't worry about AFS, since that kludge
277 should not be needed any more.
278 * src/mkdir.c (struct mkdir_options): New struct.
279 (announce_mkdir, make_ancestor): New functions.
280 (main): Use them. Adjust to mode_adjust API change. Stick with
281 umask 0. Use make_dir_parents for all the work.
282 * src/mkfifo.c (main): Adjust to new mode_adjust API.
283 * src/mknod.c (main): Likewise.
284 * tests/chmod/setgid: Do the setgid test instead of bailing.
285 * tests/mkdir/p-3: Remove re_protect case that no longer applies.
286 GNU chmod now behaves like other versions of chmod.
287 * tests/mkdir/perm: Add a test for the X bug.
289 2006-07-14 Paul Eggert <eggert@cs.ucla.edu>
291 * src/base64.c (do_decode): Output to parameter OUT, not to stdout.
292 This doesn't fix any bugs, since OUT always equals stdout, but it
293 makes the code easier to understand.
295 2006-07-14 Jim Meyering <jim@meyering.net>
297 * Makefile.maint (CVS_LIST): Use new file, build-aux/vc-list-files,
298 rather than open-coding it. Now supports mercurial, too.
299 * .hgignore: New file.
300 * Makefile.am (EXTRA_DIST): Add .hgignore, which ignores nearly
301 all generated files, including ones like configure and po/*.po
302 that are currently version-controlled in cvs.
304 * Makefile.am (EXTRA_DIST): Add a few more .??* files.
305 They've been in CVS, just haven't been distributed before this.
306 Distribute ChangeLog-2005, too.
307 (MAINTAINERCLEANFILES): Add THANKS-to-translators.
309 2006-07-11 Paul Eggert <eggert@cs.ucla.edu>
311 * src/system.h: Assume <dirent.h> exists, since gnulib assumes
314 2006-07-09 Jim Meyering <jim@meyering.net>
316 * tests/mv/dir2dir: Adjust so failing with ENOTEMPTY is ok, too.
317 That happens with Linux/tmpfs.
318 * tests/mv/Makefile.am (TESTS): Add dir2dir.
320 2006-07-09 Paul Eggert <eggert@cs.ucla.edu>
322 Adjust to recent updates from gnulib.
323 * src/dd.c (apply_translations): Use toupper rather than
324 islower followed by toupper; it's simpler and typically
325 faster now that we assume at least C89 semantics. Similarly
327 * src/sort.c (inittables): Likewise.
328 * src/expand.c (expand): Don't assume that isprint etc. return
329 booleans (needed for pre-C99 hosts).
330 * src/fmt.c (check_punctuation): Likewise.
331 * src/ptx.c (initialize_regex, fix_output_parameters): Likewise.
332 * src/tr.c (is_char_class_member): Likewise.
333 * src/unexpand.c (unexpand): Likewise.
334 * src/join.c (is_blank): Remove; no longer needed. All uses
335 replaced by isblank (to_uchar (...)).
336 * src/pinky.c (create_fullname): Don't assume char is unsigned.
337 * src/printf.c (print_esc): Likewise.
338 * src/ptx.c (SKIP_NON_WHITE, SKIP_WHITE, SKIP_WHITE_BACKWARDS):
339 (copy_unescaped_string): Likewise.
340 * src/stat.c (print_it): Likewise.
341 * src/system.h (_D_EXACT_NAMELEN): Renamed from NLENGTH, for
342 convenience on GNU systems. All uses changed. Don't bother
343 looking for any dirent.h substitute other than ndir.h.
344 (D_INO): Remove unnecessary parentheses.
345 (IN_CTYPE_DOMAIN, ISGRAPH, ISPRINT, ISALNUM, ISALPHA):
346 (ISCNTRL, ISLOWER, ISPUNCT, ISSPACE, ISUPPER, ISXDIGIT):
347 (ISDIGIT_LOCALE, TOLOWER, TOUPPER): Remove. All uses changed
348 to ctype.h equivalents.
349 (isblank): Renamed from ISBLANK. Check for HAVE_DECL_ISBLANK too.
352 2006-07-08 Jim Meyering <jim@meyering.net>
354 * tests/mv/dir2dir: New file, test for 2006-07-05 fix in copy.c.
356 * Makefile.maint (sc_the_the): New rule.
358 * src/dd.c (skip): Remove one of two adjacent "the"s in a comment.
359 * tests/Coreutils.pm (run_tests): Remove one of two adjacent "then"s
362 2006-07-07 Jim Meyering <jim@meyering.net>
364 * NEWS: Mention that mv can now remove an empty destination directory,
365 and give an example. Prompted by a report from Florent Bayle.
367 2006-07-05 Jim Meyering <jim@meyering.net>
369 * src/ls.c (usage): Correct the description of -G: it is useful
370 only in a long listing. Reported by Martin Pool in
371 <https://launchpad.net/distros/ubuntu/+source/coreutils/+bug/51653>.
373 * man/chmod.x: Correct the description of the sticky bit. Reported
374 by Chris Moore via Ian Jackson in <http://bugs.debian.org/376745>.
376 * src/copy.c (copy_internal): Don't work around old NFS clients like
377 SunOS-4.1.4 and Irix 5.3 that set errno to values like EIO and
378 ENOTEMPTY upon failed rename. Otherwise, we risk misinterpreting
379 a banal failure as a recursive move-into-self failure.
380 Reported by Florent Bayle in <http://bugs.debian.org/376749>.
382 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
384 2006-07-03 Jim Meyering <jim@meyering.net>
386 Plug another unusual leak.
387 (AD_mark_helper): Free malloc'd filename if hash_insert says
388 that string is already in the hash table.
390 The dev/inode of the topmost directory in each hierarchy were not
392 * src/remove.c (remove_cwd_entries): Don't call cycle_check here.
393 (AD_push): Call it from here instead.
396 * src/remove.c (AD_stack_clear): New function.
398 (AD_pop_and_chdir): Free *prev_dir just before longjmp.
400 * tests/Makefile.am, tests/*/Makefile.am: (TESTS_ENVIRONMENT):
401 Add $VG_PATH_PREFIX as a prefix to $PATH
403 * tests/envvar-check (vars): Add CDPATH and POSIXLY_CORRECT.
404 * tests/Makefile.am (evar-check): Remove rule.
405 (EXTRA_DIST): Remove .env-warn.
406 * tests/.env-warn: Remove file. No longer used.
407 Suggestion from Eric Blake.
409 2006-07-02 Paul Eggert <eggert@cs.ucla.edu>
411 * src/system.h: Include <stdint.h> unconditionally, since we
412 now assume the stdint module.
414 2006-07-01 Paul Eggert <eggert@cs.ucla.edu>
416 * NEWS: With no operand, 'tail -f' now silently ignores the '-f'
417 only if standard input is a FIFO or pipe and POSIXLY_CORRECT is set.
418 * src/tail.c (main): Implement this.
419 * tests/tail/Test.pm (f-pipe-1): Renamed from f-1.
420 (test_vector): Set POSIXLY_CORRECT for the f-pipe-* tests.
422 2006-07-01 Jim Meyering <jim@meyering.net>
424 * src/ln.c (do_link): Use new, shorter URL, for ag-review link.
426 * .x-sc_require_config_h: Add ^lib/xstrtold\.c$, so make distcheck
429 2006-06-30 Paul Eggert <eggert@cs.ucla.edu>
431 * NEWS: seq now uses long double internally rather than double.
432 It now defaults to a minimal fixed point format if possible.
433 It lets you use %a, %A, %E, %F, %G.
434 * src/Makefile.am (seq_LDADD): Remove $(SEQ_LIBM); add $(POW_LIB).
435 * src/seq.c: Don't include <math.h> or <xstrtol.h>; no longer needed.
436 (isfinite) [!defined isfinite]: New macro.
437 (separator, terminator): Now points to const.
438 (first, step, last): Remove.
439 (usage): Update to match new behavior.
440 (struct operand, operand): New type.
441 (scan_arg): Renamed from scan_double_arg, since we no longer use double.
443 Compute and return a value of type operand, not double.
444 (long_double_format): Renamed from valid_format, and now returns a
445 new format with an "L" added if needed, if the original format was
446 valid. Allow %a, %A, %E, %F, and %G formats.
447 (print_numbers): Take numeric values as args rather than from globals.
448 Print long double, not double.
449 (get_width_format): Remove.
450 (get_default_format): New function.
451 (main): Implement new way of calculating default format.
452 Don't worry about locale's representation of the decimal point, since
453 the arguments are always processed in the C locale.
454 * tests/seq/basic (neg-2): Adjust to new default format.
455 (eq-wid-1, eq-wid-2): Resurrect these tests, since the new
456 implementation should do the right thing.
458 2006-06-30 Jim Meyering <jim@meyering.net>
460 * tests/stty/basic-1: Work around an intermittent test failure
461 on HP-UX 11.11. Report and analysis from Bob Proulx.
462 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7475
464 2006-06-28 Paul Eggert <eggert@cs.ucla.edu>
466 * NEWS: Support obsolete usages like "sort +1 -2" even when
467 conforming to POSIX 1003.1-2001, since this is a pure extension to
468 POSIX. Problem reported by Christian in:
469 http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00220.html
470 * src/sort.c (main): Implement this.
472 * src/system.h (CLOSEDIR): Remove. All uses changed to closedir.
473 Autoconf 2.60 says this stuff was obsolete.
475 2006-06-28 Jim Meyering <jim@meyering.net>
477 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
479 2006-06-28 Bob Proulx <bob@proulx.com> (tiny change)
481 * tests/mv/i-link-no: Work around HP-UX /bin/sh tracing problem
482 (set -x when VERBOSE=yes) when stderr is redirected before stdout
483 causing shell tracing of the stdout redirection to be written to
484 the stderr file. Avoid problem and test failure on HP-UX by
485 redirecting stderr last.
486 * tests/dd/unblock-sync: Order shell file redirections for
487 stderr and stdout in the common style.
490 2006-06-27 Jim Meyering <jim@meyering.net>
492 * tests/misc/cat-proc: Try to avoid any spurious numeric
493 differences in frequently-changing /proc/cpuinfo.
494 Reported by Nelson Beebe.
496 2006-06-26 Jim Meyering <jim@meyering.net>
498 Attempt rmdir (actually, unlinkat-with-AT_REMOVEDIR) upon any
499 fd_to_subdirp failure, not just when errno == EACCES.
500 * src/remove.c (remove_dir): Use unlinkat-with-AT_REMOVEDIR, not
501 rmdir, here, even though rmdir may happen to be adequate.
503 * NEWS: rm no longer fails to remove an empty, unreadable directory
504 * src/remove.c (remove_cwd_entries): If we can't open a directory,
505 and the failure is not being ignored, try to remove the directory
506 with rmdir (aka unlinkat-with-AT_REMOVEDIR), in case it's empty.
507 Problem report and test case from Paul Eggert in
508 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7425>.
510 * tests/rm/empty-inacc: New test, for the above.
512 Avoid a segfault for wc --files0=- < /dev/null.
513 * src/wc.c (compute_number_width): Return right away if nfiles == 0.
515 2006-06-25 Jim Meyering <jim@meyering.net>
517 * NEWS: wc accepts a new option --files0-from=FILE, where FILE
518 contains a list of NUL-separated file names.
520 * src/wc.c: Include "readtokens.h".
521 (usage): Describe the new option, and adjust the `Usage':
522 with this option, no FILE may be specified on the command line.
523 (main): Handle the new option.
524 * tests/misc/wc-files0: New tests, for the above.
525 * tests/misc/wc-files0-from: Likewise.
526 * tests/misc/Makefile.am (TESTS): Add wc-files0.
528 2006-06-24 Jim Meyering <jim@meyering.net>
530 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
532 2006-06-22 Jim Meyering <jim@meyering.net>
534 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
535 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
537 2006-06-19 Jim Meyering <jim@meyering.net>
539 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
540 so this check is not run as part of "make distcheck".
542 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
544 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
546 2006-06-18 Jim Meyering <jim@meyering.net>
548 * tests/misc/pwd-long: Make error output a little clearer.
550 2006-06-17 Jim Meyering <jim@meyering.net>
552 * tests/rm/inaccessible: Skip this test on systems without openat
553 support. Reported by Bob Proulx.
555 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
557 * tests/misc/mknod: Improve permission checks to handle
558 running mkdir test in set-gid directories.
560 2006-06-14 Jim Meyering <jim@meyering.net>
562 * tests/du/basic: Revamp not to hard-code file system block sizes.
564 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
566 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
569 2006-06-11 Jim Meyering <jim@meyering.net>
571 * .gitignore: New file.
572 * Makefile.am (EXTRA_DIST): Add .gitignore.
574 Setting TIME_STYLE=long-iso in the environment would make the
575 cp/same-file test fail.
576 * tests/envvar-check (vars): Add TIME_STYLE to the list.
577 * tests/cp/same-file: Revert last change.
578 Source the envvar-check script, to ensure that TIME_STYLE
579 settings don't affect these tests.
581 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
583 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
584 uses POSIX time stamp formats. Problem reported by John Nixon in
585 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
587 2006-06-10 Jim Meyering <jim@meyering.net>
589 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
591 Require a "Version N.M" line at the top of the ChangeLog
592 file only when making the actual release, not when running
594 * Makefile.maint (maintainer-distcheck): Don't depend on
596 (alpha beta major): Depend on it here, instead.
598 2006-06-08 Jim Meyering <jim@meyering.net>
600 Ensure that cat works with any of the options, -A -v -e -E -T,
601 when applied to files in /proc and /sys, even when the FIONREAD
602 ioctl produces nonsensical results. Before this change, cat would
603 produce no output (or truncated output), for some linux kernels.
605 * src/cat.c (write_pending): New function, factored out of cat.
606 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
607 that there are bytes to read. Some versions of linux-2.6.16 do that.
608 Write any pending output before returning.
609 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
610 * NEWS: Mention this bug fix.
611 * tests/misc/cat-proc: New file. Test for the above.
612 * tests/misc/Makefile.am (TESTS): Add cat-proc.
614 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
616 * src/expr.c (eval4): Detect overflow properly when multiplying
619 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
621 * NEWS: The 'expr' command now detects and reports integer overflow.
622 (It would be better to use extended precision instead, but that
624 * src/expr.c (integer_overflow): New function.
625 (eval4, eval3): Check for integer overflow.
627 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
629 Fix problems when building with Solaris/SVR4/etc. make, which uses a
630 different and somewhat bogus implementation of VPATH. In the
631 directory tests/misc, rename tests whose names might appear in the
632 Automake-generated rules. For example, we can't use a test named
633 'test', since Automake generates a rule that contains the text
634 "if test -f ./$$tst; ...", and this might expand to something like
635 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
636 which executes the 'test' script rather than the 'test' command.
637 * tests/misc/false-status: Renamed from tests/misc/false.
638 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
639 * tests/misc/sort-merge: Renamed from tests/misc/sort.
640 ($prog): Set to 'sort' rather than to $PROG.
641 * tests/misc/test-diag: Renamed from tests/misc/test.
642 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
643 in case Solaris make has prepended the directory.
644 (TESTS): Adjust to above renamings.
645 * tests/misc/expand: Don't assign to PROG; no longer needed
646 now that Makefile.am sets PROG to the basename.
647 * tests/misc/fold: Likewise.
649 2006-06-03 Jim Meyering <jim@meyering.net>
651 Make `cp --link --no-dereference' work also on systems where the
652 link system call cannot create a hard link to a symbolic link.
653 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
654 the link syscall on a symlink when it would do the wrong thing.
655 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
656 * tests/cp/link-no-deref: New file/test for the above.
657 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
658 * NEWS: Mention the change (doesn't affect Linux).
660 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
662 Fix some porting problems in the test cases reported by
663 Ralf Wildenhues for HP-UX 11.23 in:
664 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
665 * tests/help-version: Don't assume that \< \> works in sed.
666 * tests/misc/close-stdout: Don't assume that >&- works.
667 Add a /dev/full test.
668 * tests/touch/no-create-missing: Don't assume that >&- works.
670 2006-05-30 Jim Meyering <jim@meyering.net>
672 * src/ls.c (usage): Add `v' to the list of sorting-related options.
675 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
677 * tests/cp/fail-perm: source lang-default.
678 * tests/rm/inaccessible: Likewise.
680 2006-05-28 Jim Meyering <jim@meyering.net>
682 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
683 Recognize it, too. Reported by Ralf Wildenhues, in
684 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
686 2006-05-27 Jim Meyering <jim@meyering.net>
688 * src/chgrp.c: Support new options: --preserve-root and
689 --no-preserve-root. Somehow this program was skipped when those
690 options were added to chown, chmod, and rm. Reported by
691 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
692 * NEWS: Mention this.
694 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
696 * NEWS: Remove mention of --seed. We'll replace it with something
697 better, and don't want to indicate that it is supported.
698 * src/sort.c (usage): Likewise.
700 2006-05-20 Jim Meyering <jim@meyering.net>
702 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
704 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
705 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
706 FTS_COMFOLLOW. Spotted by Justin Pryzby.
708 * gnupload: Merge changes from automake, retaining the ""--to...
709 kludge to placate overzealous `make distcheck' check.
711 2006-05-19 Jim Meyering <jim@meyering.net>
713 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
714 FTS_TIGHT_CYCLE_CHECK directory traversal option.
715 Reported by Justin Pryzby in http://bugs.debian.org/367691
717 2006-05-15 Jim Meyering <jim@meyering.net>
719 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
722 2006-05-13 Jim Meyering <jim@meyering.net>
724 * tests/mv/no-target-dir: Test two more cases.
726 2006-05-11 Jim Meyering <jim@meyering.net>
728 mv -T DIR EMPTY_DIR no longer fails unconditionally
729 * src/copy.c (copy_internal): Don't manually prohibit a move where
730 the destination is an existing directory. Sometimes doing that is
731 valid. Let the rename system call enforce the rules. That is
732 allowed only when the source is a directory and the destination
733 directory (to be replaced) is empty. Reported by Eric Blake.
734 * tests/mv/no-target-dir: New file/test for this.
735 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
736 * NEWS: Mention this.
738 * tests/mv/atomic: New file/test for yesterday's fix.
739 * tests/mv/Makefile.am (TESTS): Add atomic.
741 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
743 2006-05-10 Jim Meyering <jim@meyering.net>
745 * src/copy.c (copy_internal): Don't explicitly unlink the destination
746 when moving a symlink into the place of an existing non-directory.
747 Reported by Joshua Hudson.
748 * NEWS: mention this.
750 2006-05-07 Jim Meyering <jim@meyering.net>
752 * Makefile.maint (patch-check): Fail if patch generates any output,
753 even merely for changed offsets.
755 * src/c99-to-c89.diff: Adjust to reflect new offsets.
757 * NEWS: Mention changes affecting df, pwd, shred.
759 2006-05-06 Jim Meyering <jim@meyering.net>
761 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
762 system condition where dirent.d_ino != stat.st_ino.
763 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
765 2006-05-06 Eric Blake <ebb9@byu.net>
767 * tests/ls/inode: Expand to test inode from readdir case.
768 * tests/ls/follow-slink: Expand to test broken links encountered
769 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
771 2006-05-06 Eric Blake <ebb9@byu.net>
773 * tests/mv/leak-fd: Work even on case-insensitive file system.
775 2006-05-04 Jim Meyering <jim@meyering.net>
777 * NEWS: Mention the 2006-03-19 pwd-related change that makes
778 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
780 2006-05-03 Jim Meyering <jim@meyering.net>
782 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
783 Use better macro parameter names: s/basename/key_name/,
784 s/basefunc/key_cmp_func. Fix typo in comment.
786 2006-04-29 Eric Blake <ebb9@byu.net>
788 * src/ls.c (main): On systems with d_type, directories_first only
789 implies format_needs_type, not format_needs_stat.
791 2006-05-03 Jim Meyering <jim@meyering.net>
793 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
794 after comma in arg list, from Eric Blake.
796 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
798 * tests/misc/date (relative-3): New test, derived from a bug
799 report by John Thomas McDole.
801 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
803 New option for ls: --group-directories-first.
804 It makes ls list directories before files.
805 * NEWS [New features]: Mention it.
806 * src/ls.c (sort_type): Rearrange to use as an array index when
807 choosing sort function; added new sort_numtypes member for
809 (time_type): Add new time_numtypes member for compile-time check.
810 (directories_first): New global variable.
811 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
812 (long_options): Add --directories-first.
813 (main): Support new option.
814 (is_directory): New function.
815 (extract_dirs_from_files): Use it.
816 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
817 (LIST_SORTFUNCTION_VARIANTS): New macros.
818 (sort_functions): New global variable.
819 (sort_files): Use it.
820 (usage): Document new option.
822 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
824 * src/shred.c (fillrand): The assertion was way too weak, due to
825 what must be a typo. Strengthen it to its intended value.
826 (dopass): Don't use alloca; it's not worth the aggravation here,
827 since it's used only to get a page-aligned buffer, and page
828 alignment doesn't buy us much here. I'm suspicious that alloca
829 causes problems on some hosts, due to a recent bug report by Adam
830 Waltman: http://bugs.gentoo.org/130246.
832 2006-04-18 Jim Meyering <jim@meyering.net>
834 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
835 sha384sum, sha512sum.
837 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
839 * src/chmod.c (describe_change): Adjust to filemode changes.
840 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
841 (print_long_format): Use (new) filemodestring rather than
842 (old) mode_string, so that we get more file types right, at least
843 in theory. Adjust to filemode changes.
844 * src/stat.c (human_access): Likewise.
846 2006-04-18 Jim Meyering <jim@meyering.net>
848 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
849 ignore file. This has never been enabled. Reported by Eric Blake.
851 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
853 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
854 bug in Interix. Just call symlink or link directly. All uses changed.
855 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
856 * src/stat.c (USE_STATVFS): New macro.
857 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
858 (NAMEMAX_FORMAT): define a bit more clearly, now that the
859 statvfs-using code is a bit more regular.
860 * src/system.h (sync) [!HAVE_SYNC]: New macro.
862 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
864 * NEWS: csplit, nl, expr now conform to POSIX better, and are
865 more-compatible with traditional Unix, with respect to regular
867 * src/csplit.c (extract_regexp): Set re_syntax_options to a
868 value that is compatible with what POSIX requires.
869 * src/nl.c (build_type_arg): Likewise.
870 * src/expr.c (docolon): Likewise. Also, don't let anchors match
871 newline; this fixes an incompatibility with tradition and with POSIX.
872 Don't warn about leading ^. POSIX says it is unspecified whether
873 ^ is a special character, which means that implementations can
874 either treat it as special or not, but either way a warning is not
875 allowed (unless the regexp is otherwise invalid). Instead, anchor
876 the expression but treat ^ as an anchor; this is the traditional
877 behavior (e.g., Solaris 10).
878 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
879 and the like as invalid expressions (exit status 2), not as
880 failure of 'expr' (exit status 3). This is more consistent with
882 * tests/expr/basic (fail-a): Adjust exit status to match new expr
883 behavior, for status 2 versus 3.
885 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
886 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
887 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
888 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
889 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
890 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
891 (bre61, bre62): New tests.
892 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
896 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
897 "if !". Do not assume that 'sed' can handle long, newline-free input.
898 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
900 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
902 Adjust to new regex.h API (with new fastmap type), and clean
903 up the regex storage allocation a bit.
905 * src/csplit.c (struct control): Put re_compiled member at the
906 end, since it's large. Change regexpr member from char * to bool;
907 all uses changed. Add new member fastmap.
908 (extract_regexp): regexp arg is now char const *, not char *.
909 Don't bother duplicating the regular expression; it's not needed.
910 Set fastmap from new fastmap member. Don't bother allocating
911 a buffer, as the regexp code does a better job than we do.
912 * src/expr.c (docolon): Allocate and use a fastmap.
913 Don't bother allocating a buffer.
914 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
916 (build_type_arg): New fastmap arg. All uses changed.
917 Don't bother allocating a buffer, but set a fastmap.
918 * src/ptx.c (context_regex_string, word_regex_string): Remove.
919 (context_regex, word_regex): New vars, replacing the above.
921 (struct regex_data): New type.
922 (compile_regex): Renamed from alloc_and_compile_regex, since
923 we no longer allocate storage. Arg is now a struct regex_data *,
924 not a const char *. All uses changed. Don't allocate the fastmap;
925 instead, take it from the caller. Don't convert size_t to int,
926 to avoid arithmetic overflow problems. Don't bother freeing
927 storage afterwards; it's not worth the aggravation.
928 * src/tac.c (compiled_separator_fastmap): New ver.
929 (main): Use it. Don't bother allocating a buffer.
931 2006-03-30 Jim Meyering <jim@meyering.net>
933 * src/dd.c (iwrite): Remove assignment without effect.
934 Reported by Felix Rauch Valenti.
936 2006-03-22 Eric Blake <ebb9@byu.net>
938 * src/ptx.c (usage): Remove mention of --copyright/-C.
939 (main): Alias --copyright to --version plus a deprecation warning.
940 * NEWS: Mention this.
942 2006-03-27 Jim Meyering <jim@meyering.net>
944 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
945 use of strtod. Tiny patch from Nickolai Zeldovich.
947 2006-03-11 Eric Blake <ebb9@byu.net>
949 * tests/misc/dirname: New file.
950 * tests/basename/Makefile.am: Delete.
951 * tests/basename/basic: Move to...
952 * tests/misc/basename: ... this new file. Add some tests,
953 including fixed behavior for //.
954 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
955 * tests/Makefile.am (SUBDIRS): Remove basename.
956 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
958 Improvements to dirname/basename handling on platforms like
959 cygwin with distinct // and with drive letters.
960 * NEWS: Document new behavior.
961 * src/basename.c (main): Don't strip suffix from file system
963 * src/cp.c (target_directory_operand): Use new last_component.
964 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
965 traversing the string.
966 * src/dircolors.c (guess_shell_syntax): Use new last_component.
967 * src/install.c (target_directory_operand, install_file_in_dir):
969 * src/ln.c (target_directory_operand, main): Likewise.
970 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
971 * src/mv.c (target_directory_operand, movefile): Likewise.
972 * src/remove.c (rm_1): Likewise.
973 * src/shred.c (wipename): Likewise.
974 * src/split.c (next_file_name): Likewise.
975 * src/su.c (log_su, run_shell): Likewise.
977 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
979 * NEWS: nohup diagnostics are now more precise, and nohup now
980 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
981 * src/nohup.c (main): Implement this.
982 * tests/misc/nohup: Test the new behavior.
984 2006-03-12 Jim Meyering <jim@meyering.net>
986 * src/copy.c (set_author): Rename function, from preserve_author.
988 * src/remove.c (AD_pop_and_chdir): Use new macro,
989 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
991 * src/system.h (SAME_INODE): Remove definition.
992 Include "same-inode.h", instead.
994 2006-03-11 Eric Blake <ebb9@byu.net>
996 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
998 2006-03-10 Jim Meyering <jim@meyering.net>
1000 Fix a bug whereby a user with write access to a directory being removed
1001 could cause the removal of that directory to fail with an erroneous
1002 diagnostic about a directory cycle. Reported by Vineet Chadha.
1004 * NEWS: Mention this.
1005 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
1006 leave (and try to rmdir) is the one whose dev_ino is being used to
1007 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
1009 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
1011 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
1012 * src/dd.c (set_fd_flags): Handle file-creation flags on file
1013 descriptors, rather than ignoring them.
1014 * tests/dd/misc: Add test cases for append, nofollow, directory,
1015 and nolinks flags. Simplify redirection to /dev/null in some cases.
1017 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
1018 noatime test never tested anything.
1020 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
1022 * src/dd.c (flags, usage): New flags directory, nolinks.
1023 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
1025 * src/ls.c (usage): Mention that -f disables --color.
1026 Problem reported by Niels Möller.
1028 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
1030 * man/*.x: Add references to syscalls from utilities of the same name.
1032 2006-03-05 Jim Meyering <jim@meyering.net>
1034 * tests/help-version: Set SHELL, if not already set, in order to
1035 avoid failure when `make check' is run through debuild; dircolors
1036 would fail due to lack of $SHELL. Reported by Sven Joachim.
1038 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
1039 * src/base64.c (wrap_write, do_encode, main): Change type of
1040 parameters and locals, wrap_column, form size_t to uintmax_t.
1041 (main): Adjust to use xstrtoumax, accordingly.
1043 2006-03-03 Jim Meyering <jim@meyering.net>
1045 Don't fail when run from an environment with SHELL not a Bourne
1046 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
1047 * tests/dircolors/simple: Invoke each non-failing test with -b.
1048 Reported by Michael Stone.
1050 2006-02-27 Jim Meyering <jim@meyering.net>
1052 * tests/misc/base64: Derive --decode-using tests from the
1055 * tests/misc/base64: Factor out a long constant string.
1056 Split lines to stay within 80 columns.
1058 * tests/misc/Makefile.am (TESTS): Add base64.
1059 * tests/misc/base64: Test base64. From Simon Josefsson.
1061 * src/base64.c (do_decode): Use correct type for parameter,
1062 ignore_garbage: s/size_t/bool/.
1064 * src/base64.c: Don't include .h files already included by system.h:
1065 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
1066 Include "system.h" before the other lib/*.h header files.
1067 Include <sys/types.h> before "system.h".
1068 (wrap_write): Remove declaration of unused local, initial_column.
1069 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
1071 * README: Add base64 to the list.
1073 2006-02-17 Simon Josefsson <jas@extundo.com>
1075 New program: base64.
1076 * AUTHORS: Mention base64.
1078 * man/Makefile.am: Build base64.1.
1079 * man/base64.x: New file.
1080 * src/Makefile.am (bin_PROGRAMS): Add base64.
1081 * src/base64.c: New file.
1083 2006-02-25 Eric Blake <ebb9@byu.net>
1085 In ls, avoid calling stat for --inode (-i), when possible.
1086 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
1087 * src/system.h: ... here, for use in ...
1088 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
1090 (gobble_file): Add inode argument.
1091 (print_dir): Pass inode if available.
1092 (usage): Remove inaccuracy.
1094 2006-02-23 Jim Meyering <jim@meyering.net>
1096 * TODO: Update/correct some obsolete entries.
1098 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
1100 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
1101 * src/join.c (usage): Likewise.
1102 Documentation problem reported by Philip Kensche.
1104 2006-02-20 Eric Blake <ebb9@byu.net>
1106 * man/rm.x: Update documentation to match previous patch.
1108 2006-02-18 Eric Blake <ebb9@byu.net>
1110 New option for rm: --interactive=once (-I).
1111 * NEWS: Document it, along with change to rm --interactive.
1112 * TODO: Remove entry for implementing rm -I
1113 * src/rm.c (INTERACTIVE_OPTION): New enum value.
1114 (interactive_type): New enum.
1115 (long_opts): Let interactive take an optional argument.
1116 (interactive_args, interactive_types): New option arguments.
1117 (usage): Document -I, --interactive=WHEN. Use program_name
1118 instead of a basename.
1119 (main): New -I option, new behavior to --interactive.
1120 * tests/rm/interactive-once: New tests.
1121 * tests/rm/interactive-always: Ditto.
1122 * tests/rm/Makefile.am (TESTS): Run them.
1124 2006-02-18 Jim Meyering <jim@meyering.net>
1126 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
1127 expression match more of the target lines, e.g., those that start with
1128 `-S,' (short option followed by a comma) or that include `=[...]'.
1129 Patch by Nicolas François.
1130 Fix the four offenders thus exposed:
1131 * src/join.c (usage): Use two spaces (not one) to separate the
1132 --first-only option string from its description, so help2man formats
1133 the derived man page properly.
1134 * src/pr.c (usage): Likewise.
1135 * src/uniq.c (usage): Likewise.
1136 * src/install.c (usage): Likewise.
1138 2006-02-15 Jim Meyering <jim@meyering.net>
1140 * Makefile.maint (alpha beta major): For `make major', ensure that the
1141 version string is of the form N.N[.N]*, where N is one or more digits.
1143 2006-02-14 Jim Meyering <jim@meyering.net>
1145 * INSTALL: Update from gnulib.
1147 2006-02-13 Jim Meyering <jim@meyering.net>
1149 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
1151 2006-02-12 Jim Meyering <jim@meyering.net>
1153 * Makefile.maint (patch-check): New target.
1154 (local-checks-available): Add to the list.
1156 2006-02-11 Jim Meyering <jim@meyering.net>
1158 * src/c99-to-c89.diff: New file.
1159 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
1161 * .x-po-check: New file, with exclusions so that `make distcheck'
1163 * Makefile.am (EXTRA_DIST): Add .x-po-check.
1165 rm -r must remove an empty directory, even if it is inaccessible.
1166 * src/remove.c (close_preserve_errno): New function.
1167 (fd_to_subdirp): Don't print a diagnostic in this function.
1168 Do it from the callers instead, unless rmdir succeeds.
1169 (remove_cwd_entries, remove_dir): Adjust callers.
1170 * tests/rm/empty-inacc: New test for the above.
1171 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
1172 * NEWS: Mention this bug fix.
1173 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
1174 a tiny bit less precise: cannot remove `a/1': ... instead of
1175 cannot open directory `a/1': ...
1177 * Makefile.maint (syntax-check-rules): Automatically derive this
1178 list of sc_-prefixed rule names.
1180 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
1182 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
1183 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
1184 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
1185 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
1186 go away? was that an accident?)
1187 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
1188 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
1189 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
1190 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
1191 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
1192 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
1193 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
1194 (author_mark_check, makefile_path_separator_check):
1195 Output line numbers, to simplify navigation of Emacs *compilation*
1197 (sc_prohibit_atoi_atof, sc_file_system):
1198 Rework slightly so that Makefile.maint doesn't get reported as a
1199 violation of its own syntax rules.
1200 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
1201 it at run-time (which didn't work with Bison). Fix a makefile typo,
1202 caught by Makefile.maint itself: spaces where a tab should be.
1203 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
1204 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
1205 Ignore djgpp and man subdirectories, to avoid false matches with
1206 Bison and coreutils, respectively. Use sort -u to remove the
1207 resulting duplicates.
1208 * gnupload: Rework slightly to avoid bogus warning from
1209 sc_two_space_separator_in_usage.
1211 2006-02-10 Jim Meyering <jim@meyering.net>
1213 Use gzip's --rsyncable option only if it's available.
1214 * Makefile.maint (gzip_rsyncable): New variable.
1217 2006-02-08 Jim Meyering <jim@meyering.net>
1219 * Makefile.maint (local-checks-available): Define in terms of
1220 the expansion, $(syntax-check-rules), rather than the single,
1221 top-level target `syntax-check', so that it's easier to exclude
1222 individual rules (via $(local-checks-to-skip)).
1223 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
1225 2006-02-07 Jim Meyering <jim@meyering.net>
1227 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
1228 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
1230 * tests/help-version (expected_failure_status_vdir):
1231 Redirect an expected disk-full diagnostic to /dev/null.
1233 2006-02-06 Jim Meyering <jim@meyering.net>
1235 * src/unexpand.c (usage): Use two spaces (not one) to separate the
1236 --first-only option string from its description, so help2man formats
1237 the derived man page properly.
1238 * src/rm.c (usage): Likewise for --no-preserve-root.
1239 * src/chown.c (usage): Likewise.
1240 * src/chgrp.c (usage): Likewise.
1242 Add a rule to ensure that the above doesn't happen again.
1243 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
1244 (syntax-check-rules): Add it.
1245 * .x-sc_two_space_separator_in_usage: New empty file.
1246 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
1248 2006-02-06 Jim Meyering <jim@meyering.net>
1250 * src/cp.c (usage): Use two spaces (not one) to separate each
1251 option string from its description, so help2man formats the
1252 derived man page properly.
1253 * src/mv.c (usage): Likewise.
1254 Patch from Nicolas François in http://bugs.debian.org/351601.
1256 2006-02-04 Jim Meyering <jim@meyering.net>
1258 * src/copy.c (copy_internal): cp -RL would fail when encountering
1259 the same directory more than once in the hierarchy beneath a single
1260 command-line argument. That is legitimate, e.g. when there are
1261 two or more symbolic links, each pointing to some directory that
1262 would not otherwise be copied. Reported by Christophe LYON.
1263 * tests/cp/cp-deref: New file. Test for today's fix.
1264 * tests/cp/Makefile.am (TESTS): Add cp-deref.
1265 * NEWS: Document this.
1267 2006-02-03 Jim Meyering <jim@meyering.net>
1269 * configure.ac: Require automake-1.9.6, not 1.8.3.
1271 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
1273 * src/od.c (usage): Mention that -t a ignores high order bit.
1274 Documentation problem reported by Ed Avis.
1276 2006-02-01 Jim Meyering <jim@meyering.net>
1278 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
1280 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
1282 * src/head.c (main): Use a better diagnostic when someone uses a
1283 trailing numeric option in an invalid way. Problem reported by
1285 * src/tail.c (parse_options): Likewise.
1287 2006-01-30 Jim Meyering <jim@meyering.net>
1289 * man/wc.x: Include `count' keyword in man page synopsis,
1290 per suggestion from http://bugs.debian.org/181585.
1292 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
1294 * src/df.c (show_dev): If the file system claims to have
1295 more available than total blocks, report the number of used
1296 blocks as being total - available (a negative number) rather
1297 than as garbage. Problem reported by Toralf Foerster.
1299 2006-01-24 Jim Meyering <jim@meyering.net>
1301 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
1302 to put a regular file in O_NONBLOCK mode fails with EPERM.
1303 That happens on Linux (up to 2.6.15) when using tail -f on a file with
1304 the append-only attribute. Reported by Dean Gaudet. For details,
1305 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
1306 * NEWS: Mention this fix.
1307 * tests/tail-2/append-only: New file. Test for the above.
1308 * tests/tail-2/Makefile.am (TESTS): Add append-only.
1309 * tests/Makefile.am (check-root): Add tail-2/append-only
1311 2006-01-21 Jim Meyering <jim@meyering.net>
1313 * NEWS: Mention fts-related improvements and bug fixes.
1315 2006-01-19 Jim Meyering <jim@meyering.net>
1317 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
1318 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
1320 2006-01-18 Jim Meyering <jim@meyering.net>
1322 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
1324 2006-01-17 Jim Meyering <jim@meyering.net>
1326 Now that fts no longer changes the current working directory, adjust
1327 its clients accordingly -- note that du.c uses fts but doesn't need
1328 any adjustment, since it doesn't operate on the actual files,
1329 but rather just uses the stat buffers provided by fts.
1331 * src/chown-core.c: Include "openat.h".
1332 Don't include "lchown.h".
1333 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
1334 calling openat, lchownat, chownat, rather than open, lchown, chown.
1336 * src/chmod.c: Include "openat.h".
1337 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
1339 * tests/du/long-from-unreadable: New test, to exercise one small
1342 2006-01-13 Jim Meyering <jim@meyering.net>
1344 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
1345 addition of new directories under tests/.
1347 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
1350 2006-01-12 Jim Meyering <jim@meyering.net>
1352 * tests/du/long-sloop: Adjust not to hard-code the expected
1353 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
1354 from that of GNU libc. Reported by Paul Eggert.
1356 * tests/du/long-sloop: Create file at end of symlink chain.
1358 * tests/misc/test: New file, with a test for one of the
1359 bugs fixed by yesterday's test.c changes.
1360 * tests/misc/Makefile.am (TESTS): Add test.
1362 2006-01-11 Jim Meyering <jim@meyering.net>
1364 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
1365 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
1366 a very long sequence of symbolic links (not necessarily a loop).
1367 * tests/du/Makefile.am (TESTS): Add long-sloop.
1369 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
1371 * src/test.c (test_syntax_error): Append a newline. All callers
1372 changed, except for the ones that didn't already append a newline.
1373 Bug reported by Eric Blake.
1375 2006-01-11 Jim Meyering <jim@meyering.net>
1377 * src/system.h (X2NREALLOC): Now that verify_true is no longer
1378 void, cast its result to void, to avoid gcc's warning that
1379 ``left-hand operand of comma expression has no effect''.
1380 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
1382 2006-01-10 Jim Meyering <jim@meyering.net>
1384 * tests/chmod/no-x: Add a test for today's fts.c fix.
1386 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
1388 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
1389 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
1391 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
1393 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
1394 Use verify_true instead of verify_expr, to sync with gnulib.
1396 2006-01-08 Jim Meyering <jim@meyering.net>
1398 * src/date.c (usage): Adjust the formatting of the entries for
1399 %::z and %:::z (separate with two spaces, not one) so that help2man
1400 formats them properly. Reported by Philip Rowlands.
1402 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
1404 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
1406 2006-01-06 Jim Meyering <jim@meyering.net>
1408 * Makefile.maint (copyright-check): Use date +%Y in place of
1411 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
1412 First off, the attribute should have been `volatile' (not static)
1413 to avoid longjmp-related risk of clobber. Secondly, now there is
1414 no longer any risk of a local variable being clobbered, so there's
1415 no need for any attribute at all.
1417 2006-01-05 Jim Meyering <jim@meyering.net>
1419 * src/remove.c: Give a few functions the inline attribute.
1420 (AD_pop_and_chdir): Use gotos to avoid some duplication.
1421 (AD_push): Rewrite an assertion so that the entire computation
1422 goes away when assertions are turned off.
1424 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
1425 It's already defined in "system.h".
1426 * Makefile.maint: Add a FIXME comment.
1428 2006-01-04 Jim Meyering <jim@meyering.net>
1430 * ChangeLog: Remove entries from 2005-10-22 and earlier.
1431 * ChangeLog-2005: New file, for entries up to version 5.92.
1433 2006-01-03 Jim Meyering <jim@meyering.net>
1435 * tests/du/no-x: Also allow a slightly different diagnostic -- the
1436 one you get when using openat-enabled fts.c and du (coming soon).
1437 * tests/chmod/no-x: Likewise.
1438 * tests/chgrp/no-x: Likewise.
1440 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
1442 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
1444 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
1445 (restricted_chown): Return it, if the file cannot be accessed due
1446 to EPERM, or if no uid or gid are required, or if the file is
1447 neither a directory nor a regular file. Rewrite to avoid gotos.
1448 (change_file_owner): Handle RC_do_ordinary_chown case.
1449 Rewrite to avoid gotos.
1450 * tests/chgrp/basic: Make sure we can change the group of
1453 * src/date.c (usage): Explain %g, %G, and %V a bit better.
1455 2006-01-02 Jim Meyering <jim@meyering.net>
1457 * src/copy.c (set_owner): Correct a comment.
1459 * src/tail.c (parse_options): Change warning to say that --retry
1460 is useful `mainly' (not `only') when following by name.
1461 Reported here: http://bugs.debian.org/273781
1463 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
1465 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
1466 * src/copy.c: Include lchmod.h.
1467 (copy_internal): Use lchmod rather than chmod.
1468 * src/cp.c: Include lchmod.h.
1469 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
1470 * src/mkdir.c: Include lchmod.h.
1471 (usage): Clarify -m's operation.
1472 (main): Use lchmod rather than chmod. Don't use lchmod unless the
1473 new mode contains bits outside the 777 range.
1474 * src/mkfifo.c (usage): Clarify -m's operation.
1475 (main): If -m is given, don't invoke chmod; use umask 0 instead.
1476 Report an error if -m asks for bits outside the 777 range.
1477 * src/mknod.c (usage, main): Likewise.
1479 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
1481 2005-12-27 Jim Meyering <jim@meyering.net>
1483 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
1484 (sc_prohibit_assert_without_use): New rule.
1485 (syntax-check-rules): Add it to the list.
1486 * .x-sc_prohibit_assert_without_use: New empty file.
1487 * Makefile.am (EXTRA_DIST): Add it.
1489 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
1491 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
1492 Don't include <assert.h>; it wasn't used.
1494 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
1496 * src/chown-core.c (restricted_chown):
1497 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
1498 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
1499 | O_NOFOLLOW too, for consistency with other dir-openers.
1500 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
1501 (is_empty_dir): Likewise.
1502 * src/shred.c (wipename): Likewise. Don't bother trying to open
1503 dir for writing, since POSIX prohibits it.
1505 2005-12-22 Jim Meyering <jim@meyering.net>
1507 * tests/help-version: Redirect stderr to /dev/full, to suppress
1508 write error diagnostic.
1510 2005-12-19 Jim Meyering <jim@meyering.net>
1512 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
1513 Avoid a minor race condition when `-m MODE' is specified, by using
1514 open, fchown, and close rather than just chown. To do that reliably --
1515 even with an overly restrictive umask -- ensure that each mkdir,
1516 mknod and mkfifo call uses a mode including at least owner-read access.
1517 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
1518 the subsequent chown (or equivalent open,fchown,close) fails.
1519 * tests/misc/mknod: New tests.
1520 * tests/misc/Makefile.am (TESTS): Add mknod.
1522 2005-12-17 Jim Meyering <jim@meyering.net>
1524 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
1525 e.g., on a named pipe.
1526 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
1527 place of all uses, since it is guaranteed (system.h) to be defined.
1529 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
1531 Add POSIX ACL support
1532 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
1533 is no requirement for ACL support; particularly, it does not exist
1534 on systems that have POSIX ACLs.
1535 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1536 * src/cp.c (umask_kill): With default acls, the umask is not to be
1537 applied. Remove umask_kill, don't change the process umask, and let
1538 the kernel apply the umask where appropriate.
1539 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1540 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1542 (copy_reg, copy_internal): Use copy_acl and set_acl
1543 instead of fchown/chown. Fix the logic for POSIX ACLs.
1544 (chown_succeded): Remove; we now always copy acls and
1545 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1546 did a chown before or not.
1547 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1548 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1549 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1550 to link with it via $(LIB_ACL), for the utilities that need it.
1552 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1554 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1555 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1556 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1557 value is now signified by whether cwd_errno is null.
1558 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1559 pointer-to-bool to pointer-to-errno-value. All callers changed.
1560 (rm_1): Don't bother setting a local cwd failure flag and then
1561 ORing it into the caller's. Just set the caller's.
1562 (rm): Use cwd failure errno value to print a slightly-better
1565 2005-12-15 Jim Meyering <jim@meyering.net>
1567 * src/stat.c (print_it): Properly handle a backslash at the
1568 end of a --printf format string. Reported by Paul Eggert.
1569 * tests/misc/stat-printf (end-bs): Add a test for the above.
1571 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1573 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1574 Don't assume /etc/passwd contains user names; use 'id' instead.
1576 2005-12-15 Jim Meyering <jim@meyering.net>
1578 stat: revert behavior of --format=FMT (-c)
1579 stat: add new option: --printf=FMT
1580 * NEWS: Mention this.
1581 * src/stat.c (isodigit, octtobin, hextobin): Define.
1582 (PRINTF_OPTION): Define.
1583 (interpret_backslash_escapes, trailing_delim): New globals.
1584 (usage): Document them. Alphabetize on long option names.
1585 (print_esc_char): New function.
1586 (print_it): Rewrite, in order to handle backslash escapes.
1587 (main): Handle new option. Set globals for --format, too.
1589 * tests/misc/stat-printf: Test --printf and --format.
1590 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1592 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1594 * NEWS: sort now reports incompatible options.
1595 * src/sort.c (incompatible_options, check_ordering_compatibility):
1597 (main): Use them. Don't bother with a usage message for
1598 "sort -c a b", for consistency with other error diagnostics.
1599 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1602 * src/cat.c (main): Undo previous change. close_stdout already
1603 does the check, so the previous change wasn't necessary.
1605 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1607 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1609 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1611 Install a more-conservative approach for sort -R. It's the
1612 same basic idea as the existing code, except it uses the full ISAAC
1613 approach (called the "more kosher" approach in the existing comments).
1614 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1615 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1616 better to be conservative here at first, and review any performance
1617 improvements carefully.
1618 * .x-sc_require_config_h: Add src/rand-isaac.c.
1619 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1620 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1621 (shred_SOURCES, sort_SOURCES): Remove.
1622 (EXTRA_DIST): Add rand-isaac.c.
1623 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1624 changing it to allow for varying numbers of words in the state.
1625 Alter so that we include rand-isaac.c directly rather than
1626 compiling it and linking to it. Don't include config.h or
1627 system.h; that's the includer's responsibility.
1628 Omit functions that are specific to shred.
1629 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1630 (isaac_step, struct irand_state):
1631 Resurrect these, with the same defns that used to be in shred.c.
1632 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1633 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1635 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1636 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1637 (irand_init, irand32, irand_mod):
1638 Number of words is constant again.
1639 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1640 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1641 * src/sort.c: Likewise.
1642 * src/shred.c (fillrand, dopass, main): Undo previous change.
1643 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1645 * src/sort.c: Don't include md5.h; it wasn't needed.
1646 (struct keyfield): Rename random_hash to random, for consistency
1647 with the other member names. All uses changed.
1648 (usage): Tweak wording to mention STRING for --seed option.
1649 (short_options): Rorder for consistency with other programs.
1650 (rand_state): Now a struct, not a pointer to one. All uses changed.
1651 (HASH_WORDS, HASH_SIZE): Remove.
1652 (get_hash): Remove comments around resbuf size, since we can assume C89.
1653 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1654 (keycompare): Adjust to the new get_hash.
1656 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1657 (main): Don't set need_random simply because gkey has it set; that
1658 doesn't necessarily mean we'll need random numbers.
1659 Redo seeding to match new get_hash approach.
1661 2005-12-10 Jim Meyering <jim@meyering.net>
1663 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1665 Avoid shred segfault on 64-bit systems.
1666 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1667 local of type uint32_t. Make the local an `int' instead.
1669 * NEWS: Mention sort's new options.
1671 * src/rand-isaac.c (isaac_mix): Declare to be static.
1672 Mark all other functions as `extern' so the tight-scope
1673 part of `make distcheck' passes once again.
1674 * src/rand-isaac.h (isaac_mix): Remove declaration.
1676 * src/sort.c (get_hash): Change position of `*' in parameter
1677 type to conform with convention.
1678 (main): Split a long line so it fits in 80 columns.
1679 (keycompare): Remove stray SPACE before TAB that was
1680 causing `make distcheck' to fail.
1682 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1684 * tests/misc/sort-rand: New file: basic tests for the new options.
1685 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1687 2005-12-10 Frederik Eaton <frederik@ofb.net>
1689 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1690 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1691 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1692 Make state size runtime-configurable.
1693 (isaac_new, isaac_copy): New functions.
1694 * src/rand-isaac.h: New file.
1695 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1696 (fillrand, main): Adjust to the fact that the state size is now
1697 runtime-configurable.
1698 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1699 (usage): Add options --random-sort and --seed to implement a random
1701 Include md5.h and rand-isaac.h.
1702 (get_hash): New function.
1703 (rand_state): New var.
1704 (HASH_WORDS, HASH_SIZE): New macros.
1706 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1708 * tests/dd/misc: Add test for dd iflags=noatime.
1710 2005-12-09 Jim Meyering <jim@meyering.net>
1712 * src/sort.c (usage): Mention white space vs -b and -t options.
1715 2005-12-09 Eric Blake <ebb9@byu.net>
1717 * src/test.c (main): Fix misleading comment.
1719 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1721 * NEWS: Mention dd's new noatime flag.
1722 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1723 * src/dd.c (flags, usage): Add support for noatime flag.
1725 2005-12-07 Jim Meyering <jim@meyering.net>
1727 Distribute the cvsu script, used only by `make syntax-check'.
1728 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1729 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1730 distribute a copy of this script.
1731 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1733 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1734 to create a temporary directory on another partition.
1735 From Andreas Gruenbacher.
1737 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1739 * man/basename.x: Cross-reference to dirname and readlink.
1740 * man/dirname.x: Cross-reference to basename and readlink.
1742 2005-12-05 Andreas Gruenbacher
1744 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1745 (set_owner, preserve_author): New functions, factored out of copy_reg.
1746 (copy_reg): Use them.
1747 (copy_internal): Use them here, too.
1749 2005-12-04 Jim Meyering <jim@meyering.net>
1751 * src/sleep.c (usage): Say what happens with two or more arguments.
1752 Suggested by Justin Pryzby.
1754 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1757 2005-12-03 Jim Meyering <jim@meyering.net>
1759 * src/rm.c (long_opts): Change the name of each undocumented, for-
1760 testing-only option to start with `-', so that it cannot render
1761 ambiguous any prefix it happens to share with some other option name.
1762 Problem reported by Eric Blake.
1763 * src/head.c (long_options): Likewise.
1764 * src/tail.c (long_options): Likewise.
1766 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1767 testing-only --presume* options to start with `---'.
1768 * tests/rm/dangling-symlink: Likewise.
1769 * tests/rm/dir-no-w: Likewise.
1770 * tests/rm/isatty: Likewise.
1772 2005-11-30 Jim Meyering <jim@meyering.net>
1774 * Makefile.maint: Add a comment about cvsu.
1776 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1778 * NEWS: df updates for "none", "proc", inaccessible file systems.
1779 * src/df.c (show_point): Ignore inaccessible file systems.
1780 (usage): -a includes dummy file systems, not size-0 file systems.
1782 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1783 to avoid collision with POSIX name space. All uses changed.
1785 2005-11-24 Jim Meyering <jim@meyering.net>
1787 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1788 * tests/acl: Add `$0: ' prefix to diagnostics.
1790 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1792 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1794 * src/copy.c: Improve performance a bit by optimizing away
1795 unnecessary system calls and going to a block size of at least
1796 8192 (on normal hosts, anyway). This improved performance 5% on my
1797 Debian stable host (2.4.27 kernel, x86, copying from root
1798 ext3 file system to itself).
1799 Include "buffer-lcm.h".
1800 (copy_reg): Omit last argument. All callers changed.
1801 Use xmalloc to allocate rather than trusting alloca
1802 (which is unwise with large block sizes).
1803 Declare locals more locally, if possible.
1804 Use uintptr_t words instead of int words, for a bit more speed
1805 when looking for null blocks on 64-bit hosts.
1806 Optimize away reads of zero bytes on regular files.
1807 In the typical case, insist on 8 KiB buffers, at least.
1808 Avoid unnecessary extra call to fstat when checking for sparse files.
1809 Avoid now-unnecessary cast to off_t, and "0L".
1810 Avoid unnecessary test of *new_dst when checking for same owner
1813 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1815 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1817 2005-11-22 Jim Meyering <jim@meyering.net>
1819 * src/remove.c (AD_push): Remove debugging cruft.
1821 * tests/rm/unread2 (rm): Change expected diagnostic,
1822 `cannot open directory' to `cannot remove', to align with
1824 * tests/rm/rm2: Ensure that rm now continues removing entries
1825 even after certain types of failure.
1827 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1828 that provide openat (Solaris), and on systems like Linux+procfs
1829 where our openat emulation code is reentrant. This also fixes a
1830 few low-probability leaks and eliminates some code that could,
1831 in very unusual circumstances, cause rm() (via a callee) to exit.
1832 * NEWS: Mention this.
1834 * configure.ac: Put copyright dates all on one line so the
1835 emacs function that updates them works properly.
1837 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1839 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1840 Problem reported by Eric Blake.
1841 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1842 we get a standard-conforming compiler. This relies on the new
1843 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1844 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1845 m4/c.m4 can go away with Autoconf 2.60 comes out.
1847 2005-11-17 Jim Meyering <jim@meyering.net>
1849 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1850 (AD_mark_current_as_unremovable): Likewise, but for a local.
1853 * tests/mv/acl: Let traps handle removing temporary directories.
1855 Expect acl-related tests to fail, until the corresponding
1856 patches are committed.
1857 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1858 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1860 ACL tests, from Andreas Gruenbacher.
1861 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1862 * tests/mv/Makefile.am (TESTS): Add acl.
1863 * tests/cp/Makefile.am (TESTS): Add acl.
1865 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1867 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1869 * NEWS: Improve quality of ln's diagnostics.
1870 * src/ln.c (do_link, usage): Likewise.
1871 (do_link): Don't use alloca on a buffer of unbounded size.
1873 2005-11-16 Jim Meyering <jim@meyering.net>
1875 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1876 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1877 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1878 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1879 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1881 2005-11-14 Jim Meyering <jim@meyering.net>
1883 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1885 2005-11-13 Jim Meyering <jim@meyering.net>
1887 * announce-gen: Accept new option, --gpg-key-id=ID and
1888 emit a blurb telling how to use the .sig files.
1889 * Makefile.cfg (gpg_key_ID): Define.
1890 * Makefile.maint (announcement): Use new option and key.
1892 Require that most .c files include <config.h>.
1893 * Makefile.maint (sc_require_config_h): New rule.
1894 (syntax-check-rules): Add it.
1895 * .x-sc_require_config_h: New file listing exceptions to the
1896 above rule. Some are legit, others are simply grandfathered in.
1897 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1899 2005-11-12 Jim Meyering <jim@meyering.net>
1901 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1903 2005-11-11 Jim Meyering <jim@meyering.net>
1905 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1906 Mention new readlink options in 5.3.0's `New features' section.
1907 Spotted by Thomas Hood.
1909 2005-11-08 Jim Meyering <jim@meyering.net>
1911 * NEWS: Merge in changes from b5_9x branch.
1913 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1915 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1916 like --time-style='posix-long-iso' if the locale settings are messed up.
1917 * src/ls.c (decode_switches): Implement this.
1919 2005-11-08 Jim Meyering <jim@meyering.net>
1921 * tests/du/2g: s/expensive/very expensive/ in a comment.
1924 2005-10-17 Eric Blake <ebb9@byu.net>
1926 * src/ls.c (usage): Fix descriptions of --sort, --time.
1927 Reported by Vitaly A. Ostanin.
1929 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1931 * src/ln.c: Include filenamecat.c.
1932 (FILE_BASENAME_CONCAT): Remove.
1933 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1934 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1935 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1938 2005-11-04 Jim Meyering <jim@meyering.net>
1940 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1941 on systems with stat.st_blocks of a signed 32-bit type.
1942 This bug causes trouble on some AIX 5.1 systems.
1943 Report and trivial patch from Paul Townsend:
1944 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1945 * NEWS: Mention this.
1947 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1948 * tests/du/Makefile.am (TESTS): Add it here.
1949 * tests/very-expensive: New file.
1950 * tests/Makefile.am (EXTRA_DIST): Add it here.
1951 * tests/cp/perm: Mark this test as `very-expensive', too.
1953 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1955 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1957 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1959 * src/rm.c (usage): Don't mention rm -d.
1961 2005-11-02 Jim Meyering <jim@meyering.net>
1963 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1964 From Andreas Schwab.
1966 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1967 `M+N records in/out' lines don't pollute `make check' output.
1969 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1970 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1971 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1972 to indicate that the input file should be piped into the command
1973 under test (via `cat FILE | $prog ...').
1975 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1976 (without -r) fails to remove a directory on a non-Linux system.
1977 This change affects only newer Solaris systems (with priv_*
1978 functions like priv_allocset). Reported by Keith Thompson.
1980 * tests/rm/dir-nonrecur: New file/test for the above fix.
1981 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1983 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1985 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1986 POSIX 1002.1-2001 requires.
1987 * src/tail.c (parse_obsolete_option): Implement this.
1988 Problem reported by Vincent Lefevre.
1989 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1990 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1991 (test_vector): Add special cases for _POSIX2_VERSION, and
1992 regularize the old ones a bit.
1993 * tests/touch/obsolescent: Add y2000 test.
1995 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1997 * src/dd.c (skip): Fix off-by-one error reported by
1998 Theodoros V. Kalamatianos.
2000 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
2002 * tests/mkdir/p-3: Require that the test be run as non-root.
2003 Problem and trivial fix reported by Theodoros V. Kalamatianos.
2005 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
2007 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
2008 boundary between DEST and SOURCE in the result.
2010 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
2012 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
2013 back to text, to sync with documentation and for backwards
2016 2005-10-25 Jim Meyering <jim@meyering.net>
2018 * tests/dircolors/simple (other-wr): Add an explicit test for
2019 the dircolors bug (NULL-dereference) fixed yesterday.
2021 2005-10-24 Jim Meyering <jim@meyering.net>
2023 * src/tac.c (tac_file): When determining whether a file is seekable,
2024 also test whether it is a tty. Using only the lseek-based test would
2025 give a false positive on Solaris. Reported by Peter Fales.
2027 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
2029 * tests/install/d-slashdot: New test, for "install -d" failure.
2030 * tests/install/Makefile.am (TESTS): Add d-slashdot.
2031 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
2032 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
2034 2005-10-24 Jim Meyering <jim@meyering.net>
2036 * src/dircolors.c (ls_codes): Add missing comma.
2037 Anonymous report and patch from
2038 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
2040 * src/dircolors.c: Add compile-time assertion that the slack_codes
2041 and ls_codes arrays have the same number of elements. This would
2042 have prevented the above-fixed bug.
2044 * src/expand.c (parse_tab_stops): Add a comment to make this function
2045 identical to the one in unexpand.c.
2046 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
2047 identical to the one in expand.c.
2049 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
2051 2005-10-23 Jim Meyering <jim@meyering.net>
2053 * src/md5sum.c (digest_check, main): Use ptr_align rather than
2054 a dangerous pointer-value-to-`unsigned' cast.
2055 * NEWS: mention the new sha* programs.
2056 * AUTHORS: Add new sha* programs.
2058 2005-08-28 David Madore <david.madore@ens.fr>
2060 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
2061 * README: Add their names to the list.
2062 * src/md5sum.c: Provide framework for computing sha-2 hashes.
2063 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
2064 Rules for compiling sha-2 utilities
2065 (noinst_HEADERS): Remove checksum.h.
2066 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
2068 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
2069 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
2070 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
2071 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
2072 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
2073 sha384sum, sha512sum test scripts here rather that each in its
2076 2005-08-28 David Madore <david.madore@ens.fr>
2078 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
2079 of the FIPS test vectors).
2081 2005-10-23 Jim Meyering <jim@meyering.net>
2083 * configure.ac: Use 6.0-cvs as the version string.
2084 * NEWS: Adjust accordingly.