1 2006-07-21 Jim Meyering <jim@meyering.net>
3 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): Reposition this new
4 name so the list remains alphabetized.
6 Fix another bug: ls --indicator-style=file-type would call
7 stat for a symlink, even though it wasn't always needed.
8 In some cases, that unnecessary stat would cause ls to fail.
9 * src/ls.c (gobble_file): Don't treat symlinks specially (in
10 requiring a stat syscall). Remove the offending exclusion.
12 * NEWS: Mention the fix.
14 * tests/ls/stat-dtype: New file/test, for the above fix.
15 Also exercises the new df feature, below.
17 * src/df.c (main): Fail and don't print the headers if no
18 file system is processed. This makes it easy to test whether
19 a specified directory is on a file system of a given type or types.
20 Otherwise, applications would have had to parse df's output.
21 E.g., is "." either ext3 or reiserfs: df -t ext3 -t reiserfs .
23 Fix a bug: ls --file-type worked like --indicator-style=slash,
24 rather than like --indicator-style=file-type.
25 * src/ls.c (FILE_TYPE_INDICATOR_OPTION): New enum member.
26 (long_options): Map "file-type" to FILE_TYPE_INDICATOR_OPTION,
28 (decode_switches): Handle new case: FILE_TYPE_INDICATOR_OPTION.
29 * NEWS: Mention the fix.
30 * tests/ls-2/tests (file-type): New test, for the above fix.
32 2006-07-19 Jim Meyering <jim@meyering.net>
34 * src/ls.c (print_dir): Give a better diagnostic for failed opendir.
36 * Makefile.am (EXTRA_DIST): Add build-aux/vc-list-files.
38 2006-07-16 Paul Eggert <eggert@cs.ucla.edu>
40 * NEWS: chmod, install, and mkdir now leave setgid and setuid bits
41 of directories alone unless you specify them explicitly.
42 install and mkdir now implement X correctly.
43 install now creates parent directories with mode 755, without
44 changing their owner or group.
45 * src/chmod.c (process_file): Adjust to mode_adjust API change.
46 * src/install.c: Include mkancesdirs.h.
47 (announce_mkdir, make_ancestor): New functions.
48 (DEFAULT_MODE): New macro, specifying initial value of 'mode'.
50 (dir_mode, dir_mode_bits): New vars.
51 (main): Set dir modes separately from nondir, so that the X
52 op of -m works correctly.
53 (main): Remove cwd_errno cruft, since make_dir_parents no longer
54 affects cwd. Adjust to new make_dir_parents API.
55 (install_file_in_file_parents): 2nd arg is now char *, not char
56 const *. Use mkancesdirs instead of rolling our own code.
57 (change_attributes): Don't worry about AFS, since that kludge
58 should not be needed any more.
59 * src/mkdir.c (struct mkdir_options): New struct.
60 (announce_mkdir, make_ancestor): New functions.
61 (main): Use them. Adjust to mode_adjust API change. Stick with
62 umask 0. Use make_dir_parents for all the work.
63 * src/mkfifo.c (main): Adjust to new mode_adjust API.
64 * src/mknod.c (main): Likewise.
65 * tests/chmod/setgid: Do the setgid test instead of bailing.
66 * tests/mkdir/p-3: Remove re_protect case that no longer applies.
67 GNU chmod now behaves like other versions of chmod.
68 * tests/mkdir/perm: Add a test for the X bug.
70 2006-07-14 Paul Eggert <eggert@cs.ucla.edu>
72 * src/base64.c (do_decode): Output to parameter OUT, not to stdout.
73 This doesn't fix any bugs, since OUT always equals stdout, but it
74 makes the code easier to understand.
76 2006-07-14 Jim Meyering <jim@meyering.net>
78 * Makefile.maint (CVS_LIST): Use new file, build-aux/vc-list-files,
79 rather than open-coding it. Now supports mercurial, too.
80 * .hgignore: New file.
81 * Makefile.am (EXTRA_DIST): Add .hgignore, which ignores nearly
82 all generated files, including ones like configure and po/*.po
83 that are currently version-controlled in cvs.
85 * Makefile.am (EXTRA_DIST): Add a few more .??* files.
86 They've been in CVS, just haven't been distributed before this.
87 Distribute ChangeLog-2005, too.
88 (MAINTAINERCLEANFILES): Add THANKS-to-translators.
90 2006-07-11 Paul Eggert <eggert@cs.ucla.edu>
92 * src/system.h: Assume <dirent.h> exists, since gnulib assumes
95 2006-07-09 Jim Meyering <jim@meyering.net>
97 * tests/mv/dir2dir: Adjust so failing with ENOTEMPTY is ok, too.
98 That happens with Linux/tmpfs.
99 * tests/mv/Makefile.am (TESTS): Add dir2dir.
101 2006-07-09 Paul Eggert <eggert@cs.ucla.edu>
103 Adjust to recent updates from gnulib.
104 * src/dd.c (apply_translations): Use toupper rather than
105 islower followed by toupper; it's simpler and typically
106 faster now that we assume at least C89 semantics. Similarly
108 * src/sort.c (inittables): Likewise.
109 * src/expand.c (expand): Don't assume that isprint etc. return
110 booleans (needed for pre-C99 hosts).
111 * src/fmt.c (check_punctuation): Likewise.
112 * src/ptx.c (initialize_regex, fix_output_parameters): Likewise.
113 * src/tr.c (is_char_class_member): Likewise.
114 * src/unexpand.c (unexpand): Likewise.
115 * src/join.c (is_blank): Remove; no longer needed. All uses
116 replaced by isblank (to_uchar (...)).
117 * src/pinky.c (create_fullname): Don't assume char is unsigned.
118 * src/printf.c (print_esc): Likewise.
119 * src/ptx.c (SKIP_NON_WHITE, SKIP_WHITE, SKIP_WHITE_BACKWARDS):
120 (copy_unescaped_string): Likewise.
121 * src/stat.c (print_it): Likewise.
122 * src/system.h (_D_EXACT_NAMELEN): Renamed from NLENGTH, for
123 convenience on GNU systems. All uses changed. Don't bother
124 looking for any dirent.h substitute other than ndir.h.
125 (D_INO): Remove unnecessary parentheses.
126 (IN_CTYPE_DOMAIN, ISGRAPH, ISPRINT, ISALNUM, ISALPHA):
127 (ISCNTRL, ISLOWER, ISPUNCT, ISSPACE, ISUPPER, ISXDIGIT):
128 (ISDIGIT_LOCALE, TOLOWER, TOUPPER): Remove. All uses changed
129 to ctype.h equivalents.
130 (isblank): Renamed from ISBLANK. Check for HAVE_DECL_ISBLANK too.
133 2006-07-08 Jim Meyering <jim@meyering.net>
135 * tests/mv/dir2dir: New file, test for 2006-07-05 fix in copy.c.
137 * Makefile.maint (sc_the_the): New rule.
139 * src/dd.c (skip): Remove one of two adjacent "the"s in a comment.
140 * tests/Coreutils.pm (run_tests): Remove one of two adjacent "then"s
143 2006-07-07 Jim Meyering <jim@meyering.net>
145 * NEWS: Mention that mv can now remove an empty destination directory,
146 and give an example. Prompted by a report from Florent Bayle.
148 2006-07-05 Jim Meyering <jim@meyering.net>
150 * src/ls.c (usage): Correct the description of -G: it is useful
151 only in a long listing. Reported by Martin Pool in
152 <https://launchpad.net/distros/ubuntu/+source/coreutils/+bug/51653>.
154 * man/chmod.x: Correct the description of the sticky bit. Reported
155 by Chris Moore via Ian Jackson in <http://bugs.debian.org/376745>.
157 * src/copy.c (copy_internal): Don't work around old NFS clients like
158 SunOS-4.1.4 and Irix 5.3 that set errno to values like EIO and
159 ENOTEMPTY upon failed rename. Otherwise, we risk misinterpreting
160 a banal failure as a recursive move-into-self failure.
161 Reported by Florent Bayle in <http://bugs.debian.org/376749>.
163 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
165 2006-07-03 Jim Meyering <jim@meyering.net>
167 Plug another unusual leak.
168 (AD_mark_helper): Free malloc'd filename if hash_insert says
169 that string is already in the hash table.
171 The dev/inode of the topmost directory in each hierarchy were not
173 * src/remove.c (remove_cwd_entries): Don't call cycle_check here.
174 (AD_push): Call it from here instead.
177 * src/remove.c (AD_stack_clear): New function.
179 (AD_pop_and_chdir): Free *prev_dir just before longjmp.
181 * tests/Makefile.am, tests/*/Makefile.am: (TESTS_ENVIRONMENT):
182 Add $VG_PATH_PREFIX as a prefix to $PATH
184 * tests/envvar-check (vars): Add CDPATH and POSIXLY_CORRECT.
185 * tests/Makefile.am (evar-check): Remove rule.
186 (EXTRA_DIST): Remove .env-warn.
187 * tests/.env-warn: Remove file. No longer used.
188 Suggestion from Eric Blake.
190 2006-07-02 Paul Eggert <eggert@cs.ucla.edu>
192 * src/system.h: Include <stdint.h> unconditionally, since we
193 now assume the stdint module.
195 2006-07-01 Paul Eggert <eggert@cs.ucla.edu>
197 * NEWS: With no operand, 'tail -f' now silently ignores the '-f'
198 only if standard input is a FIFO or pipe and POSIXLY_CORRECT is set.
199 * src/tail.c (main): Implement this.
200 * tests/tail/Test.pm (f-pipe-1): Renamed from f-1.
201 (test_vector): Set POSIXLY_CORRECT for the f-pipe-* tests.
203 2006-07-01 Jim Meyering <jim@meyering.net>
205 * src/ln.c (do_link): Use new, shorter URL, for ag-review link.
207 * .x-sc_require_config_h: Add ^lib/xstrtold\.c$, so make distcheck
210 2006-06-30 Paul Eggert <eggert@cs.ucla.edu>
212 * NEWS: seq now uses long double internally rather than double.
213 It now defaults to a minimal fixed point format if possible.
214 It lets you use %a, %A, %E, %F, %G.
215 * src/Makefile.am (seq_LDADD): Remove $(SEQ_LIBM); add $(POW_LIB).
216 * src/seq.c: Don't include <math.h> or <xstrtol.h>; no longer needed.
217 (isfinite) [!defined isfinite]: New macro.
218 (separator, terminator): Now points to const.
219 (first, step, last): Remove.
220 (usage): Update to match new behavior.
221 (struct operand, operand): New type.
222 (scan_arg): Renamed from scan_double_arg, since we no longer use double.
224 Compute and return a value of type operand, not double.
225 (long_double_format): Renamed from valid_format, and now returns a
226 new format with an "L" added if needed, if the original format was
227 valid. Allow %a, %A, %E, %F, and %G formats.
228 (print_numbers): Take numeric values as args rather than from globals.
229 Print long double, not double.
230 (get_width_format): Remove.
231 (get_default_format): New function.
232 (main): Implement new way of calculating default format.
233 Don't worry about locale's representation of the decimal point, since
234 the arguments are always processed in the C locale.
235 * tests/seq/basic (neg-2): Adjust to new default format.
236 (eq-wid-1, eq-wid-2): Resurrect these tests, since the new
237 implementation should do the right thing.
239 2006-06-30 Jim Meyering <jim@meyering.net>
241 * tests/stty/basic-1: Work around an intermittent test failure
242 on HP-UX 11.11. Report and analysis from Bob Proulx.
243 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7475
245 2006-06-28 Paul Eggert <eggert@cs.ucla.edu>
247 * NEWS: Support obsolete usages like "sort +1 -2" even when
248 conforming to POSIX 1003.1-2001, since this is a pure extension to
249 POSIX. Problem reported by Christian in:
250 http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00220.html
251 * src/sort.c (main): Implement this.
253 * src/system.h (CLOSEDIR): Remove. All uses changed to closedir.
254 Autoconf 2.60 says this stuff was obsolete.
256 2006-06-28 Jim Meyering <jim@meyering.net>
258 * src/c99-to-c89.diff: Regenerate, to remove fuzz.
260 2006-06-28 Bob Proulx <bob@proulx.com> (tiny change)
262 * tests/mv/i-link-no: Work around HP-UX /bin/sh tracing problem
263 (set -x when VERBOSE=yes) when stderr is redirected before stdout
264 causing shell tracing of the stdout redirection to be written to
265 the stderr file. Avoid problem and test failure on HP-UX by
266 redirecting stderr last.
267 * tests/dd/unblock-sync: Order shell file redirections for
268 stderr and stdout in the common style.
271 2006-06-27 Jim Meyering <jim@meyering.net>
273 * tests/misc/cat-proc: Try to avoid any spurious numeric
274 differences in frequently-changing /proc/cpuinfo.
275 Reported by Nelson Beebe.
277 2006-06-26 Jim Meyering <jim@meyering.net>
279 Attempt rmdir (actually, unlinkat-with-AT_REMOVEDIR) upon any
280 fd_to_subdirp failure, not just when errno == EACCES.
281 * src/remove.c (remove_dir): Use unlinkat-with-AT_REMOVEDIR, not
282 rmdir, here, even though rmdir may happen to be adequate.
284 * NEWS: rm no longer fails to remove an empty, unreadable directory
285 * src/remove.c (remove_cwd_entries): If we can't open a directory,
286 and the failure is not being ignored, try to remove the directory
287 with rmdir (aka unlinkat-with-AT_REMOVEDIR), in case it's empty.
288 Problem report and test case from Paul Eggert in
289 <http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/7425>.
291 * tests/rm/empty-inacc: New test, for the above.
293 Avoid a segfault for wc --files0=- < /dev/null.
294 * src/wc.c (compute_number_width): Return right away if nfiles == 0.
296 2006-06-25 Jim Meyering <jim@meyering.net>
298 * NEWS: wc accepts a new option --files0-from=FILE, where FILE
299 contains a list of NUL-separated file names.
301 * src/wc.c: Include "readtokens.h".
302 (usage): Describe the new option, and adjust the `Usage':
303 with this option, no FILE may be specified on the command line.
304 (main): Handle the new option.
305 * tests/misc/wc-files0: New tests, for the above.
306 * tests/misc/wc-files0-from: Likewise.
307 * tests/misc/Makefile.am (TESTS): Add wc-files0.
309 2006-06-24 Jim Meyering <jim@meyering.net>
311 * src/md5sum.c (DIGEST_BUFFER): Remove now-unused definitions.
313 2006-06-22 Jim Meyering <jim@meyering.net>
315 * src/tee.c (tee_files): Rename from tee, to avoid conflict with
316 the function in glibc's <fcntl.h>. Reported by Andreas Schwab.
318 2006-06-19 Jim Meyering <jim@meyering.net>
320 * Makefile.cfg (local-checks-to-skip): Add changelog-check,
321 so this check is not run as part of "make distcheck".
323 2006-06-18 Bob Proulx <bob@proulx.com> (tiny change)
325 * tests/misc/pwd-long: Fix typo (s/neq/ne/) in previous change.
327 2006-06-18 Jim Meyering <jim@meyering.net>
329 * tests/misc/pwd-long: Make error output a little clearer.
331 2006-06-17 Jim Meyering <jim@meyering.net>
333 * tests/rm/inaccessible: Skip this test on systems without openat
334 support. Reported by Bob Proulx.
336 2006-06-15 Bob Proulx <bob@proulx.com> (tiny change)
338 * tests/misc/mknod: Improve permission checks to handle
339 running mkdir test in set-gid directories.
341 2006-06-14 Jim Meyering <jim@meyering.net>
343 * tests/du/basic: Revamp not to hard-code file system block sizes.
345 2006-06-12 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
347 * tests/du/Makefile.am (TESTS_ENVIRONMENT): Pass $(PERL), for
350 2006-06-11 Jim Meyering <jim@meyering.net>
352 * .gitignore: New file.
353 * Makefile.am (EXTRA_DIST): Add .gitignore.
355 Setting TIME_STYLE=long-iso in the environment would make the
356 cp/same-file test fail.
357 * tests/envvar-check (vars): Add TIME_STYLE to the list.
358 * tests/cp/same-file: Revert last change.
359 Source the envvar-check script, to ensure that TIME_STYLE
360 settings don't affect these tests.
362 2006-06-11 Paul Eggert <eggert@cs.ucla.edu>
364 * tests/cp/same-file: Execute 'ls' in the C locale, so that it
365 uses POSIX time stamp formats. Problem reported by John Nixon in
366 <http://lists.gnu.org/archive/html/bug-coreutils/2006-06/msg00062.html>.
368 2006-06-10 Jim Meyering <jim@meyering.net>
370 * NEWS: Mention the AIX-strndup-bug vs. dircolors workaround.
372 Require a "Version N.M" line at the top of the ChangeLog
373 file only when making the actual release, not when running
375 * Makefile.maint (maintainer-distcheck): Don't depend on
377 (alpha beta major): Depend on it here, instead.
379 2006-06-08 Jim Meyering <jim@meyering.net>
381 Ensure that cat works with any of the options, -A -v -e -E -T,
382 when applied to files in /proc and /sys, even when the FIONREAD
383 ioctl produces nonsensical results. Before this change, cat would
384 produce no output (or truncated output), for some linux kernels.
386 * src/cat.c (write_pending): New function, factored out of cat.
387 (cat): Also interpret a negative ioctl/FIONREAD count as indicating
388 that there are bytes to read. Some versions of linux-2.6.16 do that.
389 Write any pending output before returning.
390 Reported by Dan Jacobson in <http://bugs.debian.org/370583>.
391 * NEWS: Mention this bug fix.
392 * tests/misc/cat-proc: New file. Test for the above.
393 * tests/misc/Makefile.am (TESTS): Add cat-proc.
395 2006-06-07 Paul Eggert <eggert@cs.ucla.edu>
397 * src/expr.c (eval4): Detect overflow properly when multiplying
400 2006-06-06 Paul Eggert <eggert@cs.ucla.edu>
402 * NEWS: The 'expr' command now detects and reports integer overflow.
403 (It would be better to use extended precision instead, but that
405 * src/expr.c (integer_overflow): New function.
406 (eval4, eval3): Check for integer overflow.
408 2006-06-05 Paul Eggert <eggert@cs.ucla.edu>
410 Fix problems when building with Solaris/SVR4/etc. make, which uses a
411 different and somewhat bogus implementation of VPATH. In the
412 directory tests/misc, rename tests whose names might appear in the
413 Automake-generated rules. For example, we can't use a test named
414 'test', since Automake generates a rule that contains the text
415 "if test -f ./$$tst; ...", and this might expand to something like
416 "if ../../../coreutils-6.0/tests/misc/test -f ./$$test; ...",
417 which executes the 'test' script rather than the 'test' command.
418 * tests/misc/false-status: Renamed from tests/misc/false.
419 * tests/misc/pwd-long: Renamed from tests/misc/pwd.
420 * tests/misc/sort-merge: Renamed from tests/misc/sort.
421 ($prog): Set to 'sort' rather than to $PROG.
422 * tests/misc/test-diag: Renamed from tests/misc/test.
423 * tests/misc/Makefile.am (PROG): Take the basename of $$tst,
424 in case Solaris make has prepended the directory.
425 (TESTS): Adjust to above renamings.
426 * tests/misc/expand: Don't assign to PROG; no longer needed
427 now that Makefile.am sets PROG to the basename.
428 * tests/misc/fold: Likewise.
430 2006-06-03 Jim Meyering <jim@meyering.net>
432 Make `cp --link --no-dereference' work also on systems where the
433 link system call cannot create a hard link to a symbolic link.
434 * src/copy.c (copy_internal) [LINK_FOLLOWS_SYMLINKS]: Don't use
435 the link syscall on a symlink when it would do the wrong thing.
436 Based on the patch by Aurelien Jarno: <http://bugs.debian.org/329451>
437 * tests/cp/link-no-deref: New file/test for the above.
438 * tests/cp/Makefile.am (TESTS): Add link-no-deref.
439 * NEWS: Mention the change (doesn't affect Linux).
441 2006-06-01 Paul Eggert <eggert@cs.ucla.edu>
443 Fix some porting problems in the test cases reported by
444 Ralf Wildenhues for HP-UX 11.23 in:
445 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00238.html
446 * tests/help-version: Don't assume that \< \> works in sed.
447 * tests/misc/close-stdout: Don't assume that >&- works.
448 Add a /dev/full test.
449 * tests/touch/no-create-missing: Don't assume that >&- works.
451 2006-05-30 Jim Meyering <jim@meyering.net>
453 * src/ls.c (usage): Add `v' to the list of sorting-related options.
456 2006-05-28 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
458 * tests/cp/fail-perm: source lang-default.
459 * tests/rm/inaccessible: Likewise.
461 2006-05-28 Jim Meyering <jim@meyering.net>
463 * tests/rm/inaccessible: AIX 4.3.3 gives a different diagnostic.
464 Recognize it, too. Reported by Ralf Wildenhues, in
465 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
467 2006-05-27 Jim Meyering <jim@meyering.net>
469 * src/chgrp.c: Support new options: --preserve-root and
470 --no-preserve-root. Somehow this program was skipped when those
471 options were added to chown, chmod, and rm. Reported by
472 vaqflabuopac@spammotel.com in <http://bugs.debian.org/365656>.
473 * NEWS: Mention this.
475 2006-05-25 Paul Eggert <eggert@cs.ucla.edu>
477 * NEWS: Remove mention of --seed. We'll replace it with something
478 better, and don't want to indicate that it is supported.
479 * src/sort.c (usage): Likewise.
481 2006-05-20 Jim Meyering <jim@meyering.net>
483 * src/chmod.c (main): Use FTS_PHYSICAL here, too.
485 * src/du.c (main): Rename local, s/symlink_deref_bit/symlink_deref_bits/
486 and arrange for -D to set fts' FTS_PHYSICAL bit as well as
487 FTS_COMFOLLOW. Spotted by Justin Pryzby.
489 * gnupload: Merge changes from automake, retaining the ""--to...
490 kludge to placate overzealous `make distcheck' check.
492 2006-05-19 Jim Meyering <jim@meyering.net>
494 * src/du.c (main): Don't let -D, -L, or -P turn off the internal
495 FTS_TIGHT_CYCLE_CHECK directory traversal option.
496 Reported by Justin Pryzby in http://bugs.debian.org/367691
498 2006-05-15 Jim Meyering <jim@meyering.net>
500 * src/cp.c (usage): Correct description of -a: s/-dpR/-dpPR/.
503 2006-05-13 Jim Meyering <jim@meyering.net>
505 * tests/mv/no-target-dir: Test two more cases.
507 2006-05-11 Jim Meyering <jim@meyering.net>
509 mv -T DIR EMPTY_DIR no longer fails unconditionally
510 * src/copy.c (copy_internal): Don't manually prohibit a move where
511 the destination is an existing directory. Sometimes doing that is
512 valid. Let the rename system call enforce the rules. That is
513 allowed only when the source is a directory and the destination
514 directory (to be replaced) is empty. Reported by Eric Blake.
515 * tests/mv/no-target-dir: New file/test for this.
516 * tests/mv/Makefile.am (TESTS): Add no-target-dir.
517 * NEWS: Mention this.
519 * tests/mv/atomic: New file/test for yesterday's fix.
520 * tests/mv/Makefile.am (TESTS): Add atomic.
522 * tests/du/long-sloop: Avoid harmless `ambiguous redirect' diagnostic.
524 2006-05-10 Jim Meyering <jim@meyering.net>
526 * src/copy.c (copy_internal): Don't explicitly unlink the destination
527 when moving a symlink into the place of an existing non-directory.
528 Reported by Joshua Hudson.
529 * NEWS: mention this.
531 2006-05-07 Jim Meyering <jim@meyering.net>
533 * Makefile.maint (patch-check): Fail if patch generates any output,
534 even merely for changed offsets.
536 * src/c99-to-c89.diff: Adjust to reflect new offsets.
538 * NEWS: Mention changes affecting df, pwd, shred.
540 2006-05-06 Jim Meyering <jim@meyering.net>
542 * tests/ls/stat-vs-dirent: New test, to detect the bogus file
543 system condition where dirent.d_ino != stat.st_ino.
544 * tests/ls/Makefile.am (TESTS): Add stat-vs-dirent.
546 2006-05-06 Eric Blake <ebb9@byu.net>
548 * tests/ls/inode: Expand to test inode from readdir case.
549 * tests/ls/follow-slink: Expand to test broken links encountered
550 implicitly, favoring Solaris 9 and OpenBSD 3.4 behavior.
552 2006-05-06 Eric Blake <ebb9@byu.net>
554 * tests/mv/leak-fd: Work even on case-insensitive file system.
556 2006-05-04 Jim Meyering <jim@meyering.net>
558 * NEWS: Mention the 2006-03-19 pwd-related change that makes
559 lib/getcwd.c work around inconsistent file system dirent.d_ino data.
561 2006-05-03 Jim Meyering <jim@meyering.net>
563 * src/ls.c (DEFINE_SORT_FUNCTIONS, LIST_SORTFUNCTION_VARIANTS):
564 Use better macro parameter names: s/basename/key_name/,
565 s/basefunc/key_cmp_func. Fix typo in comment.
567 2006-04-29 Eric Blake <ebb9@byu.net>
569 * src/ls.c (main): On systems with d_type, directories_first only
570 implies format_needs_type, not format_needs_stat.
572 2006-05-03 Jim Meyering <jim@meyering.net>
574 * src/ls.c (xstrcoll_df_version, rev_xstrcoll_df_version): Add space
575 after comma in arg list, from Eric Blake.
577 2006-04-25 Paul Eggert <eggert@cs.ucla.edu>
579 * tests/misc/date (relative-3): New test, derived from a bug
580 report by John Thomas McDole.
582 2006-04-23 Francesco Montorsi <fr_m@hotmail.com>
584 New option for ls: --group-directories-first.
585 It makes ls list directories before files.
586 * NEWS [New features]: Mention it.
587 * src/ls.c (sort_type): Rearrange to use as an array index when
588 choosing sort function; added new sort_numtypes member for
590 (time_type): Add new time_numtypes member for compile-time check.
591 (directories_first): New global variable.
592 (GROUP_DIRECTORIES_FIRST_OPTION): New enum.
593 (long_options): Add --directories-first.
594 (main): Support new option.
595 (is_directory): New function.
596 (extract_dirs_from_files): Use it.
597 (DIRFIRST_CHECK, DEFINE_SORT_FUNCTIONS)
598 (LIST_SORTFUNCTION_VARIANTS): New macros.
599 (sort_functions): New global variable.
600 (sort_files): Use it.
601 (usage): Document new option.
603 2006-04-18 Paul Eggert <eggert@cs.ucla.edu>
605 * src/shred.c (fillrand): The assertion was way too weak, due to
606 what must be a typo. Strengthen it to its intended value.
607 (dopass): Don't use alloca; it's not worth the aggravation here,
608 since it's used only to get a page-aligned buffer, and page
609 alignment doesn't buy us much here. I'm suspicious that alloca
610 causes problems on some hosts, due to a recent bug report by Adam
611 Waltman: http://bugs.gentoo.org/130246.
613 2006-04-18 Jim Meyering <jim@meyering.net>
615 * tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
616 sha384sum, sha512sum.
618 2006-04-17 Paul Eggert <eggert@cs.ucla.edu>
620 * src/chmod.c (describe_change): Adjust to filemode changes.
621 * src/ls.c (HAVE_ST_DM_MODE): Remove; moved to ../lib/filemode.c.
622 (print_long_format): Use (new) filemodestring rather than
623 (old) mode_string, so that we get more file types right, at least
624 in theory. Adjust to filemode changes.
625 * src/stat.c (human_access): Likewise.
627 2006-04-18 Jim Meyering <jim@meyering.net>
629 * src/ptx.c (main) [DEFAULT_IGNORE_FILE]: Remove code to use a default
630 ignore file. This has never been enabled. Reported by Eric Blake.
632 2006-04-12 Paul Eggert <eggert@cs.ucla.edu>
634 * src/ln.c (linkfunc): Remove. This method ran into a compiler/linker
635 bug in Interix. Just call symlink or link directly. All uses changed.
636 * src/setuidgid.c (main) [! HAVE_SETGROUPS]: Don't call setgroups.
637 * src/stat.c (USE_STATVFS): New macro.
638 Include <sys/statvfs.h> and use statvfs only if USE_STATVFS.
639 (NAMEMAX_FORMAT): define a bit more clearly, now that the
640 statvfs-using code is a bit more regular.
641 * src/system.h (sync) [!HAVE_SYNC]: New macro.
643 2006-04-11 Paul Eggert <eggert@cs.ucla.edu>
645 * NEWS: csplit, nl, expr now conform to POSIX better, and are
646 more-compatible with traditional Unix, with respect to regular
648 * src/csplit.c (extract_regexp): Set re_syntax_options to a
649 value that is compatible with what POSIX requires.
650 * src/nl.c (build_type_arg): Likewise.
651 * src/expr.c (docolon): Likewise. Also, don't let anchors match
652 newline; this fixes an incompatibility with tradition and with POSIX.
653 Don't warn about leading ^. POSIX says it is unspecified whether
654 ^ is a special character, which means that implementations can
655 either treat it as special or not, but either way a warning is not
656 allowed (unless the regexp is otherwise invalid). Instead, anchor
657 the expression but treat ^ as an anchor; this is the traditional
658 behavior (e.g., Solaris 10).
659 (eval4, eval3, eval2): Treat non-numeric args, division by zero,
660 and the like as invalid expressions (exit status 2), not as
661 failure of 'expr' (exit status 3). This is more consistent with
663 * tests/expr/basic (fail-a): Adjust exit status to match new expr
664 behavior, for status 2 versus 3.
666 (bre1, bre2, bre3, bre4, bre5, bre6, bre7, bre8, bre9, bre10):
667 (bre11, bre12, bre13, bre14, bre15, bre16, bre17, bre18, bre19, bre20):
668 (bre21, bre22, bre23, bre24, bre25, bre26, bre27, bre28, bre29, bre30):
669 (bre31, bre32, bre33, bre34, bre35, bre36, bre37, bre38, bre39, bre40):
670 (bre41, bre42, bre43, bre44, bre45, bre46, bre47, bre48, bre49, bre50):
671 (bre51, bre52, bre53, bre54, bre55, bre56, bre57, bre58, bre59, bre60):
672 (bre61, bre62): New tests.
673 * tests/misc/csplit: Use \{...\} in test RE, to test that we're
677 * tests/du/long-from-unreachable: Solaris 8 sh doesn't understand
678 "if !". Do not assume that 'sed' can handle long, newline-free input.
679 * tests/du/long-sloop: Likewise. Evaluate expr once, not $n times.
681 2006-04-10 Paul Eggert <eggert@cs.ucla.edu>
683 Adjust to new regex.h API (with new fastmap type), and clean
684 up the regex storage allocation a bit.
686 * src/csplit.c (struct control): Put re_compiled member at the
687 end, since it's large. Change regexpr member from char * to bool;
688 all uses changed. Add new member fastmap.
689 (extract_regexp): regexp arg is now char const *, not char *.
690 Don't bother duplicating the regular expression; it's not needed.
691 Set fastmap from new fastmap member. Don't bother allocating
692 a buffer, as the regexp code does a better job than we do.
693 * src/expr.c (docolon): Allocate and use a fastmap.
694 Don't bother allocating a buffer.
695 * src/nl.c (body_fastmap, header_fastmap, footer_fastmap):
697 (build_type_arg): New fastmap arg. All uses changed.
698 Don't bother allocating a buffer, but set a fastmap.
699 * src/ptx.c (context_regex_string, word_regex_string): Remove.
700 (context_regex, word_regex): New vars, replacing the above.
702 (struct regex_data): New type.
703 (compile_regex): Renamed from alloc_and_compile_regex, since
704 we no longer allocate storage. Arg is now a struct regex_data *,
705 not a const char *. All uses changed. Don't allocate the fastmap;
706 instead, take it from the caller. Don't convert size_t to int,
707 to avoid arithmetic overflow problems. Don't bother freeing
708 storage afterwards; it's not worth the aggravation.
709 * src/tac.c (compiled_separator_fastmap): New ver.
710 (main): Use it. Don't bother allocating a buffer.
712 2006-03-30 Jim Meyering <jim@meyering.net>
714 * src/dd.c (iwrite): Remove assignment without effect.
715 Reported by Felix Rauch Valenti.
717 2006-03-22 Eric Blake <ebb9@byu.net>
719 * src/ptx.c (usage): Remove mention of --copyright/-C.
720 (main): Alias --copyright to --version plus a deprecation warning.
721 * NEWS: Mention this.
723 2006-03-27 Jim Meyering <jim@meyering.net>
725 * src/Makefile.am (uptime_LDADD): Add $(POW_LIB), for uptime's
726 use of strtod. Tiny patch from Nickolai Zeldovich.
728 2006-03-11 Eric Blake <ebb9@byu.net>
730 * tests/misc/dirname: New file.
731 * tests/basename/Makefile.am: Delete.
732 * tests/basename/basic: Move to...
733 * tests/misc/basename: ... this new file. Add some tests,
734 including fixed behavior for //.
735 * tests/misc/Makefile.am (TESTS): Sort. Add basename, dirname.
736 * tests/Makefile.am (SUBDIRS): Remove basename.
737 * configure.ac (AC_CONFIG_FILES): Remove tests/basename.
739 Improvements to dirname/basename handling on platforms like
740 cygwin with distinct // and with drive letters.
741 * NEWS: Document new behavior.
742 * src/basename.c (main): Don't strip suffix from file system
744 * src/cp.c (target_directory_operand): Use new last_component.
745 (ASSIGN_BASENAME_STRDUPA): Likewise. Reduce time spent
746 traversing the string.
747 * src/dircolors.c (guess_shell_syntax): Use new last_component.
748 * src/install.c (target_directory_operand, install_file_in_dir):
750 * src/ln.c (target_directory_operand, main): Likewise.
751 * src/ls.c (basename_is_dot_or_dotdot): Likewise.
752 * src/mv.c (target_directory_operand, movefile): Likewise.
753 * src/remove.c (rm_1): Likewise.
754 * src/shred.c (wipename): Likewise.
755 * src/split.c (next_file_name): Likewise.
756 * src/su.c (log_su, run_shell): Likewise.
758 2006-03-23 Paul Eggert <eggert@cs.ucla.edu>
760 * NEWS: nohup diagnostics are now more precise, and nohup now
761 redirects stderr to nohup.out if stdout is closed and stderr is a tty.
762 * src/nohup.c (main): Implement this.
763 * tests/misc/nohup: Test the new behavior.
765 2006-03-12 Jim Meyering <jim@meyering.net>
767 * src/copy.c (set_author): Rename function, from preserve_author.
769 * src/remove.c (AD_pop_and_chdir): Use new macro,
770 CYCLE_CHECK_REFLECT_CHDIR_UP, rather than open-coding it.
772 * src/system.h (SAME_INODE): Remove definition.
773 Include "same-inode.h", instead.
775 2006-03-11 Eric Blake <ebb9@byu.net>
777 * src/pwd.c (robust_getcwd): Prepend only one slash, not two.
779 2006-03-10 Jim Meyering <jim@meyering.net>
781 Fix a bug whereby a user with write access to a directory being removed
782 could cause the removal of that directory to fail with an erroneous
783 diagnostic about a directory cycle. Reported by Vineet Chadha.
785 * NEWS: Mention this.
786 * src/remove.c (AD_pop_and_chdir): If the directory we're about to
787 leave (and try to rmdir) is the one whose dev_ino is being used to
788 detect a cycle, reset cycle_check_state.dev_ino to that of the parent.
790 2006-03-08 Paul Eggert <eggert@cs.ucla.edu>
792 * NEWS: Document dd's new 'directory' and 'nolinks' flags.
793 * src/dd.c (set_fd_flags): Handle file-creation flags on file
794 descriptors, rather than ignoring them.
795 * tests/dd/misc: Add test cases for append, nofollow, directory,
796 and nolinks flags. Simplify redirection to /dev/null in some cases.
798 * tests/dd/misc: iflags->iflag. This fixes a typo that meant the
799 noatime test never tested anything.
801 2006-03-05 Paul Eggert <eggert@cs.ucla.edu>
803 * src/dd.c (flags, usage): New flags directory, nolinks.
804 * src/system.h (O_NOLINKS): Define to 0 if not already defined.
806 * src/ls.c (usage): Mention that -f disables --color.
807 Problem reported by Niels Möller.
809 2006-03-03 Justin Pryzby <pryzbyj@justinpryzby.com>
811 * man/*.x: Add references to syscalls from utilities of the same name.
813 2006-03-05 Jim Meyering <jim@meyering.net>
815 * tests/help-version: Set SHELL, if not already set, in order to
816 avoid failure when `make check' is run through debuild; dircolors
817 would fail due to lack of $SHELL. Reported by Sven Joachim.
819 Make `base64 --wrap=N' work for N=0, and for N larger than SIZE_MAX.
820 * src/base64.c (wrap_write, do_encode, main): Change type of
821 parameters and locals, wrap_column, form size_t to uintmax_t.
822 (main): Adjust to use xstrtoumax, accordingly.
824 2006-03-03 Jim Meyering <jim@meyering.net>
826 Don't fail when run from an environment with SHELL not a Bourne
827 shell, e.g. `env SHELL=/bin/csh make check' would fail this test.
828 * tests/dircolors/simple: Invoke each non-failing test with -b.
829 Reported by Michael Stone.
831 2006-02-27 Jim Meyering <jim@meyering.net>
833 * tests/misc/base64: Derive --decode-using tests from the
836 * tests/misc/base64: Factor out a long constant string.
837 Split lines to stay within 80 columns.
839 * tests/misc/Makefile.am (TESTS): Add base64.
840 * tests/misc/base64: Test base64. From Simon Josefsson.
842 * src/base64.c (do_decode): Use correct type for parameter,
843 ignore_garbage: s/size_t/bool/.
845 * src/base64.c: Don't include .h files already included by system.h:
846 <string.h>, <stdlib.h>, <stdbool.h>, <limits.h>, <errno.h>.
847 Include "system.h" before the other lib/*.h header files.
848 Include <sys/types.h> before "system.h".
849 (wrap_write): Remove declaration of unused local, initial_column.
850 (wrap_write): Correct declaration syntax: s/size_t * V/size_t *V/.
852 * README: Add base64 to the list.
854 2006-02-17 Simon Josefsson <jas@extundo.com>
857 * AUTHORS: Mention base64.
859 * man/Makefile.am: Build base64.1.
860 * man/base64.x: New file.
861 * src/Makefile.am (bin_PROGRAMS): Add base64.
862 * src/base64.c: New file.
864 2006-02-25 Eric Blake <ebb9@byu.net>
866 In ls, avoid calling stat for --inode (-i), when possible.
867 * src/pwd.c (NOT_AN_INODE_NUMBER, D_INO): Move to ...
868 * src/system.h: ... here, for use in ...
869 * src/ls.c (main): ... here. Prefer dirent.d_ino to stat when
871 (gobble_file): Add inode argument.
872 (print_dir): Pass inode if available.
873 (usage): Remove inaccuracy.
875 2006-02-23 Jim Meyering <jim@meyering.net>
877 * TODO: Update/correct some obsolete entries.
879 2006-02-20 Paul Eggert <eggert@cs.ucla.edu>
881 * doc/coreutils.texi (join invocation): Mention `sort -k 1b,1'.
882 * src/join.c (usage): Likewise.
883 Documentation problem reported by Philip Kensche.
885 2006-02-20 Eric Blake <ebb9@byu.net>
887 * man/rm.x: Update documentation to match previous patch.
889 2006-02-18 Eric Blake <ebb9@byu.net>
891 New option for rm: --interactive=once (-I).
892 * NEWS: Document it, along with change to rm --interactive.
893 * TODO: Remove entry for implementing rm -I
894 * src/rm.c (INTERACTIVE_OPTION): New enum value.
895 (interactive_type): New enum.
896 (long_opts): Let interactive take an optional argument.
897 (interactive_args, interactive_types): New option arguments.
898 (usage): Document -I, --interactive=WHEN. Use program_name
899 instead of a basename.
900 (main): New -I option, new behavior to --interactive.
901 * tests/rm/interactive-once: New tests.
902 * tests/rm/interactive-always: Ditto.
903 * tests/rm/Makefile.am (TESTS): Run them.
905 2006-02-18 Jim Meyering <jim@meyering.net>
907 * Makefile.maint (sc_two_space_separator_in_usage): Make the regular
908 expression match more of the target lines, e.g., those that start with
909 `-S,' (short option followed by a comma) or that include `=[...]'.
910 Patch by Nicolas François.
911 Fix the four offenders thus exposed:
912 * src/join.c (usage): Use two spaces (not one) to separate the
913 --first-only option string from its description, so help2man formats
914 the derived man page properly.
915 * src/pr.c (usage): Likewise.
916 * src/uniq.c (usage): Likewise.
917 * src/install.c (usage): Likewise.
919 2006-02-15 Jim Meyering <jim@meyering.net>
921 * Makefile.maint (alpha beta major): For `make major', ensure that the
922 version string is of the form N.N[.N]*, where N is one or more digits.
924 2006-02-14 Jim Meyering <jim@meyering.net>
926 * INSTALL: Update from gnulib.
928 2006-02-13 Jim Meyering <jim@meyering.net>
930 * GNUmakefile (all): Emit diagnostics to stderr, not stdout.
932 2006-02-12 Jim Meyering <jim@meyering.net>
934 * Makefile.maint (patch-check): New target.
935 (local-checks-available): Add to the list.
937 2006-02-11 Jim Meyering <jim@meyering.net>
939 * src/c99-to-c89.diff: New file.
940 * src/Makefile.am (EXTRA_DIST): Add c99-to-c89.diff.
942 * .x-po-check: New file, with exclusions so that `make distcheck'
944 * Makefile.am (EXTRA_DIST): Add .x-po-check.
946 rm -r must remove an empty directory, even if it is inaccessible.
947 * src/remove.c (close_preserve_errno): New function.
948 (fd_to_subdirp): Don't print a diagnostic in this function.
949 Do it from the callers instead, unless rmdir succeeds.
950 (remove_cwd_entries, remove_dir): Adjust callers.
951 * tests/rm/empty-inacc: New test for the above.
952 * tests/rm/Makefile.am (TESTS): Add empty-inacc.
953 * NEWS: Mention this bug fix.
954 * tests/rm/rm2: Adjust two expected diagnostics, now that they're
955 a tiny bit less precise: cannot remove `a/1': ... instead of
956 cannot open directory `a/1': ...
958 * Makefile.maint (syntax-check-rules): Automatically derive this
959 list of sc_-prefixed rule names.
961 2006-02-10 Paul Eggert <eggert@cs.ucla.edu>
963 * Makefile.maint (CVS_LIST): Don't assume cvsu is available.
964 (CVS_LIST_EXCEPT): New macro, to simplify exception-processing.
965 Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT.
966 (syntax-check-rules): Bring back sc_changelong. (Hmm, why did it
967 go away? was that an accident?)
968 (sc_cast_of_argument_to_free, sc_cast_of_x_alloc_return_value):
969 (sc_cast_of_alloca_return_value, sc_space_tab, sc_prohibit_atoi_atof):
970 (sc_error_exit_success, sc_file_system, sc_no_if_have_config_h):
971 (sc_system_h_headers, sc_sun_os_names, sc_trailing_blank):
972 (sc_two_space_separator_in_usage, sc_unmarked_diagnostics):
973 (sc_obsolete_symbols, sc_changelog, sc_prohibit_jm_in_m4):
974 (sc_useless_cpp_parens, makefile-check, m4-check, po-check):
975 (author_mark_check, makefile_path_separator_check):
976 Output line numbers, to simplify navigation of Emacs *compilation*
978 (sc_prohibit_atoi_atof, sc_file_system):
979 Rework slightly so that Makefile.maint doesn't get reported as a
980 violation of its own syntax rules.
981 (sc_dd_max_sym_length): Use ifneq to do nothing, instead of doing
982 it at run-time (which didn't work with Bison). Fix a makefile typo,
983 caught by Makefile.maint itself: spaces where a tab should be.
984 (po-check): Check lib/*.[ch] even if not in CVS; used by Bison,
985 which copies from ../gnulib/lib/*.[ch] to lib/*.[ch].
986 Ignore djgpp and man subdirectories, to avoid false matches with
987 Bison and coreutils, respectively. Use sort -u to remove the
988 resulting duplicates.
989 * gnupload: Rework slightly to avoid bogus warning from
990 sc_two_space_separator_in_usage.
992 2006-02-10 Jim Meyering <jim@meyering.net>
994 Use gzip's --rsyncable option only if it's available.
995 * Makefile.maint (gzip_rsyncable): New variable.
998 2006-02-08 Jim Meyering <jim@meyering.net>
1000 * Makefile.maint (local-checks-available): Define in terms of
1001 the expansion, $(syntax-check-rules), rather than the single,
1002 top-level target `syntax-check', so that it's easier to exclude
1003 individual rules (via $(local-checks-to-skip)).
1004 (tgz-md5, tgz-sha1, ...): Remove now-unused definitions.
1006 2006-02-07 Jim Meyering <jim@meyering.net>
1008 * src/system.h (!defined O_DIRECT): If O_DIRECTIO is defined (as it
1009 is on Tru64), define O_DIRECT to that. Patch From James Lemley.
1011 * tests/help-version (expected_failure_status_vdir):
1012 Redirect an expected disk-full diagnostic to /dev/null.
1014 2006-02-06 Jim Meyering <jim@meyering.net>
1016 * src/unexpand.c (usage): Use two spaces (not one) to separate the
1017 --first-only option string from its description, so help2man formats
1018 the derived man page properly.
1019 * src/rm.c (usage): Likewise for --no-preserve-root.
1020 * src/chown.c (usage): Likewise.
1021 * src/chgrp.c (usage): Likewise.
1023 Add a rule to ensure that the above doesn't happen again.
1024 * Makefile.maint (sc_two_space_separator_in_usage): New rule.
1025 (syntax-check-rules): Add it.
1026 * .x-sc_two_space_separator_in_usage: New empty file.
1027 * Makefile.am (EXTRA_DIST): Add .x-sc_two_space_separator_in_usage.
1029 2006-02-06 Jim Meyering <jim@meyering.net>
1031 * src/cp.c (usage): Use two spaces (not one) to separate each
1032 option string from its description, so help2man formats the
1033 derived man page properly.
1034 * src/mv.c (usage): Likewise.
1035 Patch from Nicolas François in http://bugs.debian.org/351601.
1037 2006-02-04 Jim Meyering <jim@meyering.net>
1039 * src/copy.c (copy_internal): cp -RL would fail when encountering
1040 the same directory more than once in the hierarchy beneath a single
1041 command-line argument. That is legitimate, e.g. when there are
1042 two or more symbolic links, each pointing to some directory that
1043 would not otherwise be copied. Reported by Christophe LYON.
1044 * tests/cp/cp-deref: New file. Test for today's fix.
1045 * tests/cp/Makefile.am (TESTS): Add cp-deref.
1046 * NEWS: Document this.
1048 2006-02-03 Jim Meyering <jim@meyering.net>
1050 * configure.ac: Require automake-1.9.6, not 1.8.3.
1052 2006-02-01 Paul Eggert <eggert@cs.ucla.edu>
1054 * src/od.c (usage): Mention that -t a ignores high order bit.
1055 Documentation problem reported by Ed Avis.
1057 2006-02-01 Jim Meyering <jim@meyering.net>
1059 * src/pwd.c (find_dir_entry): Remove unused local, `ent_sb_valid'.
1061 2006-01-30 Paul Eggert <eggert@cs.ucla.edu>
1063 * src/head.c (main): Use a better diagnostic when someone uses a
1064 trailing numeric option in an invalid way. Problem reported by
1066 * src/tail.c (parse_options): Likewise.
1068 2006-01-30 Jim Meyering <jim@meyering.net>
1070 * man/wc.x: Include `count' keyword in man page synopsis,
1071 per suggestion from http://bugs.debian.org/181585.
1073 2006-01-24 Paul Eggert <eggert@cs.ucla.edu>
1075 * src/df.c (show_dev): If the file system claims to have
1076 more available than total blocks, report the number of used
1077 blocks as being total - available (a negative number) rather
1078 than as garbage. Problem reported by Toralf Foerster.
1080 2006-01-24 Jim Meyering <jim@meyering.net>
1082 * src/tail.c (tail_forever): Don't exit-nonzero when an attempt
1083 to put a regular file in O_NONBLOCK mode fails with EPERM.
1084 That happens on Linux (up to 2.6.15) when using tail -f on a file with
1085 the append-only attribute. Reported by Dean Gaudet. For details,
1086 see http://savannah.gnu.org/bugs/?func=detailitem&item_id=15473.
1087 * NEWS: Mention this fix.
1088 * tests/tail-2/append-only: New file. Test for the above.
1089 * tests/tail-2/Makefile.am (TESTS): Add append-only.
1090 * tests/Makefile.am (check-root): Add tail-2/append-only
1092 2006-01-21 Jim Meyering <jim@meyering.net>
1094 * NEWS: Mention fts-related improvements and bug fixes.
1096 2006-01-19 Jim Meyering <jim@meyering.net>
1098 * tests/fmt/basic (pfx-1, pfx-2): New tests, to demonstrate the bug
1099 reported as http://bugs.debian.org/147577. Forwarded by Thomas Hood.
1101 2006-01-18 Jim Meyering <jim@meyering.net>
1103 * tests/du/Makefile.am (TESTS): Add long-from-unreadable.
1105 2006-01-17 Jim Meyering <jim@meyering.net>
1107 Now that fts no longer changes the current working directory, adjust
1108 its clients accordingly -- note that du.c uses fts but doesn't need
1109 any adjustment, since it doesn't operate on the actual files,
1110 but rather just uses the stat buffers provided by fts.
1112 * src/chown-core.c: Include "openat.h".
1113 Don't include "lchown.h".
1114 (restricted_chown): Accept a new parameter, CWD_FD, and use it in
1115 calling openat, lchownat, chownat, rather than open, lchown, chown.
1117 * src/chmod.c: Include "openat.h".
1118 (process_file): Use chmodat (fts->fts_cwd_fd,... in place of chmod (...
1120 * tests/du/long-from-unreadable: New test, to exercise one small
1123 2006-01-13 Jim Meyering <jim@meyering.net>
1125 * tests/Makefile.am (SUBDIRS): Add comments discouraging the
1126 addition of new directories under tests/.
1128 * tests/acl: Redirect stdin to /dev/null. Otherwise, FreeBSD 5.0's
1131 2006-01-12 Jim Meyering <jim@meyering.net>
1133 * tests/du/long-sloop: Adjust not to hard-code the expected
1134 diagnostic corresponding to ELOOP. Solaris' diagnostic differs
1135 from that of GNU libc. Reported by Paul Eggert.
1137 * tests/du/long-sloop: Create file at end of symlink chain.
1139 * tests/misc/test: New file, with a test for one of the
1140 bugs fixed by yesterday's test.c changes.
1141 * tests/misc/Makefile.am (TESTS): Add test.
1143 2006-01-11 Jim Meyering <jim@meyering.net>
1145 * tests/du/long-sloop: New file. Test for today's fts.c bug fix.
1146 That bug could make du -L, chgrp -L, or chown -L fail to diagnose
1147 a very long sequence of symbolic links (not necessarily a loop).
1148 * tests/du/Makefile.am (TESTS): Add long-sloop.
1150 2006-01-11 Paul Eggert <eggert@cs.ucla.edu>
1152 * src/test.c (test_syntax_error): Append a newline. All callers
1153 changed, except for the ones that didn't already append a newline.
1154 Bug reported by Eric Blake.
1156 2006-01-11 Jim Meyering <jim@meyering.net>
1158 * src/system.h (X2NREALLOC): Now that verify_true is no longer
1159 void, cast its result to void, to avoid gcc's warning that
1160 ``left-hand operand of comma expression has no effect''.
1161 (DECIMAL_DIGIT_ACCUMULATE, X2REALLOC): Likewise.
1163 2006-01-10 Jim Meyering <jim@meyering.net>
1165 * tests/chmod/no-x: Add a test for today's fts.c fix.
1167 2006-01-10 Jim Meyering <jim@meyering.net> (tiny change)
1169 * src/ls.c (gobble_file): Use DTTOIF only if it's defined.
1170 This is necessary for Dragonfly. Patch by Joerg Sonnenberger.
1172 2006-01-10 Paul Eggert <eggert@cs.ucla.edu>
1174 * src/system.h (X2NREALLOC, X2REALLOC, DECIMAL_DIGIT_ACCUMULATE):
1175 Use verify_true instead of verify_expr, to sync with gnulib.
1177 2006-01-08 Jim Meyering <jim@meyering.net>
1179 * src/date.c (usage): Adjust the formatting of the entries for
1180 %::z and %:::z (separate with two spaces, not one) so that help2man
1181 formats them properly. Reported by Philip Rowlands.
1183 2006-01-06 Paul Eggert <eggert@cs.ucla.edu>
1185 * configure.ac (gl_IGNORE_UNUSED_LIBRARIES): Add.
1187 2006-01-06 Jim Meyering <jim@meyering.net>
1189 * Makefile.maint (copyright-check): Use date +%Y in place of
1192 * src/remove.c (rm_1): Remove `static' attribute on local `status'.
1193 First off, the attribute should have been `volatile' (not static)
1194 to avoid longjmp-related risk of clobber. Secondly, now there is
1195 no longer any risk of a local variable being clobbered, so there's
1196 no need for any attribute at all.
1198 2006-01-05 Jim Meyering <jim@meyering.net>
1200 * src/remove.c: Give a few functions the inline attribute.
1201 (AD_pop_and_chdir): Use gotos to avoid some duplication.
1202 (AD_push): Rewrite an assertion so that the entire computation
1203 goes away when assertions are turned off.
1205 * src/tail.c (ENOSYS) [!defined ENOSYS]: Don't define here.
1206 It's already defined in "system.h".
1207 * Makefile.maint: Add a FIXME comment.
1209 2006-01-04 Jim Meyering <jim@meyering.net>
1211 * ChangeLog: Remove entries from 2005-10-22 and earlier.
1212 * ChangeLog-2005: New file, for entries up to version 5.92.
1214 2006-01-03 Jim Meyering <jim@meyering.net>
1216 * tests/du/no-x: Also allow a slightly different diagnostic -- the
1217 one you get when using openat-enabled fts.c and du (coming soon).
1218 * tests/chmod/no-x: Likewise.
1219 * tests/chgrp/no-x: Likewise.
1221 * src/system.h (O_DIRECTORY) [!defined O_DIRECTORY]: Define.
1223 2006-01-02 Paul Eggert <eggert@cs.ucla.edu>
1225 * src/chown-core.c (RC_do_ordinary_chown): New enum value.
1226 (restricted_chown): Return it, if the file cannot be accessed due
1227 to EPERM, or if no uid or gid are required, or if the file is
1228 neither a directory nor a regular file. Rewrite to avoid gotos.
1229 (change_file_owner): Handle RC_do_ordinary_chown case.
1230 Rewrite to avoid gotos.
1231 * tests/chgrp/basic: Make sure we can change the group of
1234 * src/date.c (usage): Explain %g, %G, and %V a bit better.
1236 2006-01-02 Jim Meyering <jim@meyering.net>
1238 * src/copy.c (set_owner): Correct a comment.
1240 * src/tail.c (parse_options): Change warning to say that --retry
1241 is useful `mainly' (not `only') when following by name.
1242 Reported here: http://bugs.debian.org/273781
1244 2006-01-01 Paul Eggert <eggert@cs.ucla.edu>
1246 * NEWS: Document that mkfifo and mknod -m no longer set special bits.
1247 * src/copy.c: Include lchmod.h.
1248 (copy_internal): Use lchmod rather than chmod.
1249 * src/cp.c: Include lchmod.h.
1250 (re_protect, make_dir_parents_private): Use lchmod rather than chmod.
1251 * src/mkdir.c: Include lchmod.h.
1252 (usage): Clarify -m's operation.
1253 (main): Use lchmod rather than chmod. Don't use lchmod unless the
1254 new mode contains bits outside the 777 range.
1255 * src/mkfifo.c (usage): Clarify -m's operation.
1256 (main): If -m is given, don't invoke chmod; use umask 0 instead.
1257 Report an error if -m asks for bits outside the 777 range.
1258 * src/mknod.c (usage, main): Likewise.
1260 * src/mkdir.c, src/mkfifo.c, src/mknod.c: Undo 2005-12-19 changes.
1262 2005-12-27 Jim Meyering <jim@meyering.net>
1264 * Makefile.maint (sc_obsolete_symbols): Prohibit use of O_NDELAY.
1265 (sc_prohibit_assert_without_use): New rule.
1266 (syntax-check-rules): Add it to the list.
1267 * .x-sc_prohibit_assert_without_use: New empty file.
1268 * Makefile.am (EXTRA_DIST): Add it.
1270 * Makefile.maint (CVS_LIST): Define in terms of $(srcdir).
1272 * cp.c, df.c, link.c, mknod.c, nice.c, sleep.c, unlink.c:
1273 Don't include <assert.h>; it wasn't used.
1275 2005-12-26 Paul Eggert <eggert@cs.ucla.edu>
1277 * src/chown-core.c (restricted_chown):
1278 Don't try O_WRONLY unless O_RDONLY failed wth EACCES.
1279 * src/remove.c (fd_to_subdirp): Open with O_DIRECTORY | O_NOCTTY
1280 | O_NOFOLLOW too, for consistency with other dir-openers.
1281 Use POSIX-preferred O_NONBLOCK rather than O_NDELAY.
1282 (is_empty_dir): Likewise.
1283 * src/shred.c (wipename): Likewise. Don't bother trying to open
1284 dir for writing, since POSIX prohibits it.
1286 2005-12-22 Jim Meyering <jim@meyering.net>
1288 * tests/help-version: Redirect stderr to /dev/full, to suppress
1289 write error diagnostic.
1291 2005-12-19 Jim Meyering <jim@meyering.net>
1293 * src/mkdir.c, src/mknod.c, src/mkfifo.c (main)
1294 Avoid a minor race condition when `-m MODE' is specified, by using
1295 open, fchown, and close rather than just chown. To do that reliably --
1296 even with an overly restrictive umask -- ensure that each mkdir,
1297 mknod and mkfifo call uses a mode including at least owner-read access.
1298 * src/mknod.c (main): When `-m MODE' is specified, exit nonzero if
1299 the subsequent chown (or equivalent open,fchown,close) fails.
1300 * tests/misc/mknod: New tests.
1301 * tests/misc/Makefile.am (TESTS): Add mknod.
1303 2005-12-17 Jim Meyering <jim@meyering.net>
1305 * src/remove.c (is_empty_dir): Open with O_NDELAY, so we don't hang,
1306 e.g., on a named pipe.
1307 (OPEN_NO_FOLLOW_SYMLINK): Remove definition. Use O_NOFOLLOW in
1308 place of all uses, since it is guaranteed (system.h) to be defined.
1310 2005-12-05 Andreas Gruenbacher <agruen@suse.de>
1312 Add POSIX ACL support
1313 * src/ls.c: Switch back from HAVE_ACL to USE_ACL: The acl() syscall
1314 is no requirement for ACL support; particularly, it does not exist
1315 on systems that have POSIX ACLs.
1316 * src/copy.h (cp_option_init) [umask_kill]: Remove member.
1317 * src/cp.c (umask_kill): With default acls, the umask is not to be
1318 applied. Remove umask_kill, don't change the process umask, and let
1319 the kernel apply the umask where appropriate.
1320 * src/cp.c (make_dir_parents_private): Fix logic for POSIX ACLs.
1321 * src/copy.c (get_dest_mode): Remove; it is obsolete after removing
1323 (copy_reg, copy_internal): Use copy_acl and set_acl
1324 instead of fchown/chown. Fix the logic for POSIX ACLs.
1325 (chown_succeded): Remove; we now always copy acls and
1326 preserve S_ISUID, S_ISGID, and S_ISVTX when needed, no matter if we
1327 did a chown before or not.
1328 * src/mv.c, src/install.c (cp_option_init): Don't set umask_kill member.
1329 * src/Makefile.am (dir_LDADD, ls_LDADD, vdir_LDADD, cp_LDADD,
1330 mv_LDADD, ginstall_LDADD): On systems with an ACL library, arrange
1331 to link with it via $(LIB_ACL), for the utilities that need it.
1333 2005-12-16 Paul Eggert <eggert@cs.ucla.edu>
1335 * src/remove.c (OPENAT_CWD_RESTORE__REQUIRE): Remove.
1336 (OPENAT_CWD_RESTORE__ALLOW_FAILURE): Likewise.
1337 (fd_to_subdirp): Remove openat_cwd_restore_allow_failure arg; its
1338 value is now signified by whether cwd_errno is null.
1339 (fd_to_subdirp, remove_dir, rm_1); Change cwd failure indicator from
1340 pointer-to-bool to pointer-to-errno-value. All callers changed.
1341 (rm_1): Don't bother setting a local cwd failure flag and then
1342 ORing it into the caller's. Just set the caller's.
1343 (rm): Use cwd failure errno value to print a slightly-better
1346 2005-12-15 Jim Meyering <jim@meyering.net>
1348 * src/stat.c (print_it): Properly handle a backslash at the
1349 end of a --printf format string. Reported by Paul Eggert.
1350 * tests/misc/stat-printf (end-bs): Add a test for the above.
1352 2005-12-15 Paul Eggert <eggert@cs.ucla.edu>
1354 * tests/acl: Port to pre-POSIX shells like Solaris 8 /bin/sh.
1355 Don't assume /etc/passwd contains user names; use 'id' instead.
1357 2005-12-15 Jim Meyering <jim@meyering.net>
1359 stat: revert behavior of --format=FMT (-c)
1360 stat: add new option: --printf=FMT
1361 * NEWS: Mention this.
1362 * src/stat.c (isodigit, octtobin, hextobin): Define.
1363 (PRINTF_OPTION): Define.
1364 (interpret_backslash_escapes, trailing_delim): New globals.
1365 (usage): Document them. Alphabetize on long option names.
1366 (print_esc_char): New function.
1367 (print_it): Rewrite, in order to handle backslash escapes.
1368 (main): Handle new option. Set globals for --format, too.
1370 * tests/misc/stat-printf: Test --printf and --format.
1371 * tests/misc/Makefile.am (TESTS): Add stat-printf.
1373 2005-12-14 Paul Eggert <eggert@cs.ucla.edu>
1375 * NEWS: sort now reports incompatible options.
1376 * src/sort.c (incompatible_options, check_ordering_compatibility):
1378 (main): Use them. Don't bother with a usage message for
1379 "sort -c a b", for consistency with other error diagnostics.
1380 * tests/sort/Test.pm (incompat1, incompat2, incompat3, incompat4):
1383 * src/cat.c (main): Undo previous change. close_stdout already
1384 does the check, so the previous change wasn't necessary.
1386 2005-12-13 Paul Eggert <eggert@cs.ucla.edu>
1388 * src/cat.c (main): Check for close (STDOUT_FILENO) failure.
1390 2005-12-12 Paul Eggert <eggert@cs.ucla.edu>
1392 Install a more-conservative approach for sort -R. It's the
1393 same basic idea as the existing code, except it uses the full ISAAC
1394 approach (called the "more kosher" approach in the existing comments).
1395 This makes "sort -R" quite a bit slower (about a factor of 2 on my
1396 little tests involving 10000 lines on a 2.4 GHz P4), but I think it's
1397 better to be conservative here at first, and review any performance
1398 improvements carefully.
1399 * .x-sc_require_config_h: Add src/rand-isaac.c.
1400 * src/rand-isaac.h: Remove. All uses now simply include rand-isaac.c.
1401 * src/Makefile.am (noinst_HEADERS): Remove rand-isaac.h.
1402 (shred_SOURCES, sort_SOURCES): Remove.
1403 (EXTRA_DIST): Add rand-isaac.c.
1404 * src/rand-isaac.c: Revert to what used to be in shred.c, without
1405 changing it to allow for varying numbers of words in the state.
1406 Alter so that we include rand-isaac.c directly rather than
1407 compiling it and linking to it. Don't include config.h or
1408 system.h; that's the includer's responsibility.
1409 Omit functions that are specific to shred.
1410 (ISAAC_LOG, ISAAC_WORDS, ISAAC_BYTES, struct isaac_state, ind):
1411 (isaac_step, struct irand_state):
1412 Resurrect these, with the same defns that used to be in shred.c.
1413 (ISAAC_SIZE, isaac_new, isaac_copy): Remove.
1414 (isaac_refill, isaac_seed_start, isaac_seed_data, irand_init, irand32):
1416 (struct isaac_state, isaac_refill, isaac_mix, isaac_init):
1417 (isaac_seed_start, isaac_seed_data, isaac_seed_finish, isaac_seed):
1418 (irand_init, irand32, irand_mod):
1419 Number of words is constant again.
1420 (struct irand_state, irand_init, irand32, irand_mod): Move to shred.c.
1421 * src/shred.c: Include rand-isaac.c rather than rand-isaac.h.
1422 * src/sort.c: Likewise.
1423 * src/shred.c (fillrand, dopass, main): Undo previous change.
1424 (struct irand_state, irand_init, irand32, irand_mod): Moved back here,
1426 * src/sort.c: Don't include md5.h; it wasn't needed.
1427 (struct keyfield): Rename random_hash to random, for consistency
1428 with the other member names. All uses changed.
1429 (usage): Tweak wording to mention STRING for --seed option.
1430 (short_options): Rorder for consistency with other programs.
1431 (rand_state): Now a struct, not a pointer to one. All uses changed.
1432 (HASH_WORDS, HASH_SIZE): Remove.
1433 (get_hash): Remove comments around resbuf size, since we can assume C89.
1434 Use a "more-kosher" (but slower) approach of invoking isaac_refill.
1435 (keycompare): Adjust to the new get_hash.
1437 (badfieldspec): Omit recently-introduced comment; it isn't needed.
1438 (main): Don't set need_random simply because gkey has it set; that
1439 doesn't necessarily mean we'll need random numbers.
1440 Redo seeding to match new get_hash approach.
1442 2005-12-10 Jim Meyering <jim@meyering.net>
1444 * src/Makefile.am (noinst_HEADERS): Add rand-isaac.h.
1446 Avoid shred segfault on 64-bit systems.
1447 * src/rand-isaac.c (isaac_refill): Don't try to negate a
1448 local of type uint32_t. Make the local an `int' instead.
1450 * NEWS: Mention sort's new options.
1452 * src/rand-isaac.c (isaac_mix): Declare to be static.
1453 Mark all other functions as `extern' so the tight-scope
1454 part of `make distcheck' passes once again.
1455 * src/rand-isaac.h (isaac_mix): Remove declaration.
1457 * src/sort.c (get_hash): Change position of `*' in parameter
1458 type to conform with convention.
1459 (main): Split a long line so it fits in 80 columns.
1460 (keycompare): Remove stray SPACE before TAB that was
1461 causing `make distcheck' to fail.
1463 * src/shred.c: Don't include gethrxtime.h. No longer needed.
1465 * tests/misc/sort-rand: New file: basic tests for the new options.
1466 * tests/misc/Makefile.am (TESTS): Add sort-rand.
1468 2005-12-10 Frederik Eaton <frederik@ofb.net>
1470 * src/Makefile.am (sort_LDADD): Add $(LIB_GETHRXTIME).
1471 (shred_SOURCES, sort_SOURCES): New macros, so we compile rand-isaac.c.
1472 * src/rand-isaac.c: New file, containing ISAAC code that was in shred.c.
1473 Make state size runtime-configurable.
1474 (isaac_new, isaac_copy): New functions.
1475 * src/rand-isaac.h: New file.
1476 * src/shred.c: Include rand-isaac.h. Move ISAAC code to rand-isaac.c.
1477 (fillrand, main): Adjust to the fact that the state size is now
1478 runtime-configurable.
1479 * src/sort.c (short_options, long_options, WORDS, keycompare, main):
1480 (usage): Add options --random-sort and --seed to implement a random
1482 Include md5.h and rand-isaac.h.
1483 (get_hash): New function.
1484 (rand_state): New var.
1485 (HASH_WORDS, HASH_SIZE): New macros.
1487 2005-12-09 Paul Eggert <eggert@cs.ucla.edu>
1489 * tests/dd/misc: Add test for dd iflags=noatime.
1491 2005-12-09 Jim Meyering <jim@meyering.net>
1493 * src/sort.c (usage): Mention white space vs -b and -t options.
1496 2005-12-09 Eric Blake <ebb9@byu.net>
1498 * src/test.c (main): Fix misleading comment.
1500 2005-12-07 Paul Eggert <eggert@cs.ucla.edu>
1502 * NEWS: Mention dd's new noatime flag.
1503 * src/system.h (O_NOATIME): Define to 0 if not already defined.
1504 * src/dd.c (flags, usage): Add support for noatime flag.
1506 2005-12-07 Jim Meyering <jim@meyering.net>
1508 Distribute the cvsu script, used only by `make syntax-check'.
1509 * Makefile.am (EXTRA_DIST): Add build-aux/cvsu.
1510 * Makefile.maint (CVS_LIST): Use build-aux/cvsu, now that we
1511 distribute a copy of this script.
1512 * .x-sc_unmarked_diagnostics: Add build-aux/cvsu.
1514 * tests/mv/acl: exit-77 before the trap, not after, if we fail
1515 to create a temporary directory on another partition.
1516 From Andreas Gruenbacher.
1518 2005-12-06 Tomas Pospisek <tpo@sourcepole.ch> (tiny change)
1520 * man/basename.x: Cross-reference to dirname and readlink.
1521 * man/dirname.x: Cross-reference to basename and readlink.
1523 2005-12-05 Andreas Gruenbacher
1525 * src/copy.c [!HAVE_FCHOWN]: Define fchown(...) to -1.
1526 (set_owner, preserve_author): New functions, factored out of copy_reg.
1527 (copy_reg): Use them.
1528 (copy_internal): Use them here, too.
1530 2005-12-04 Jim Meyering <jim@meyering.net>
1532 * src/sleep.c (usage): Say what happens with two or more arguments.
1533 Suggested by Justin Pryzby.
1535 * src/uptime.c (print_uptime): Move decl of `upsecs' into scope
1538 2005-12-03 Jim Meyering <jim@meyering.net>
1540 * src/rm.c (long_opts): Change the name of each undocumented, for-
1541 testing-only option to start with `-', so that it cannot render
1542 ambiguous any prefix it happens to share with some other option name.
1543 Problem reported by Eric Blake.
1544 * src/head.c (long_options): Likewise.
1545 * src/tail.c (long_options): Likewise.
1547 * tests/misc/head-elide-tail: Update uses of undocumented, for-
1548 testing-only --presume* options to start with `---'.
1549 * tests/rm/dangling-symlink: Likewise.
1550 * tests/rm/dir-no-w: Likewise.
1551 * tests/rm/isatty: Likewise.
1553 2005-11-30 Jim Meyering <jim@meyering.net>
1555 * Makefile.maint: Add a comment about cvsu.
1557 2005-11-25 Paul Eggert <eggert@cs.ucla.edu>
1559 * NEWS: df updates for "none", "proc", inaccessible file systems.
1560 * src/df.c (show_point): Ignore inaccessible file systems.
1561 (usage): -a includes dummy file systems, not size-0 file systems.
1563 * src/od.c (unsigned_long_long_int): Renamed from ulonglong_t,
1564 to avoid collision with POSIX name space. All uses changed.
1566 2005-11-24 Jim Meyering <jim@meyering.net>
1568 * tests/Makefile.am (EXTRA_DIST): Add acl to the list.
1569 * tests/acl: Add `$0: ' prefix to diagnostics.
1571 * .x-sc_require_config_h: Add lib/buffer-lcm.c to the list.
1573 2005-11-23 Paul Eggert <eggert@cs.ucla.edu>
1575 * src/copy.c: Improve performance a bit by optimizing away
1576 unnecessary system calls and going to a block size of at least
1577 8192 (on normal hosts, anyway). This improved performance 5% on my
1578 Debian stable host (2.4.27 kernel, x86, copying from root
1579 ext3 file system to itself).
1580 Include "buffer-lcm.h".
1581 (copy_reg): Omit last argument. All callers changed.
1582 Use xmalloc to allocate rather than trusting alloca
1583 (which is unwise with large block sizes).
1584 Declare locals more locally, if possible.
1585 Use uintptr_t words instead of int words, for a bit more speed
1586 when looking for null blocks on 64-bit hosts.
1587 Optimize away reads of zero bytes on regular files.
1588 In the typical case, insist on 8 KiB buffers, at least.
1589 Avoid unnecessary extra call to fstat when checking for sparse files.
1590 Avoid now-unnecessary cast to off_t, and "0L".
1591 Avoid unnecessary test of *new_dst when checking for same owner
1594 2005-11-22 Paul Eggert <eggert@cs.ucla.edu>
1596 * src/remove.c (rm): Don't assume C99 for-loop syntax.
1598 2005-11-22 Jim Meyering <jim@meyering.net>
1600 * src/remove.c (AD_push): Remove debugging cruft.
1602 * tests/rm/unread2 (rm): Change expected diagnostic,
1603 `cannot open directory' to `cannot remove', to align with
1605 * tests/rm/rm2: Ensure that rm now continues removing entries
1606 even after certain types of failure.
1608 * src/remove.c: Rewrite. Now, this module is reentrant on systems
1609 that provide openat (Solaris), and on systems like Linux+procfs
1610 where our openat emulation code is reentrant. This also fixes a
1611 few low-probability leaks and eliminates some code that could,
1612 in very unusual circumstances, cause rm() (via a callee) to exit.
1613 * NEWS: Mention this.
1615 * configure.ac: Put copyright dates all on one line so the
1616 emacs function that updates them works properly.
1618 2005-11-18 Paul Eggert <eggert@cs.ucla.edu>
1620 * configure.ac (AM_PROG_CC_C_O): Add. Needed for CVS Automake.
1621 Problem reported by Eric Blake.
1622 (AC_PROG_CC_STDC): Use this instead of AC_PROG_CC, so that
1623 we get a standard-conforming compiler. This relies on the new
1624 m4/c.m4 file. Note that it's a bit tricky, since c.m4 doesn't
1625 define AC_PROG_CC_STDC; we are relying on Autoconf 2.59 internals.
1626 m4/c.m4 can go away with Autoconf 2.60 comes out.
1628 2005-11-17 Jim Meyering <jim@meyering.net>
1630 * src/remove.c (AD_mark_helper): Make a `char *' parameter `const'.
1631 (AD_mark_current_as_unremovable): Likewise, but for a local.
1634 * tests/mv/acl: Let traps handle removing temporary directories.
1636 Expect acl-related tests to fail, until the corresponding
1637 patches are committed.
1638 * tests/mv/Makefile.am (XFAIL_TESTS): Add acl.
1639 * tests/cp/Makefile.am (XFAIL_TESTS): Likewise.
1641 ACL tests, from Andreas Gruenbacher.
1642 * tests/acl, tests/mv/acl, tests/cp/acl: New files.
1643 * tests/mv/Makefile.am (TESTS): Add acl.
1644 * tests/cp/Makefile.am (TESTS): Add acl.
1646 * src/ls.c (basename_is_dot_or_dotdot): Correct wording in comment.
1648 2005-11-16 Paul Eggert <eggert@cs.ucla.edu>
1650 * NEWS: Improve quality of ln's diagnostics.
1651 * src/ln.c (do_link, usage): Likewise.
1652 (do_link): Don't use alloca on a buffer of unbounded size.
1654 2005-11-16 Jim Meyering <jim@meyering.net>
1656 * tests/cp/fail-perm: Accommodate HPUX. It appears to fail
1657 with EACCES rather than EPERM. Reported by Peter O'Gorman here:
1658 http://article.gmane.org/gmane.comp.gnu.core-utils.bugs/5766
1659 This also affects AIX 4.3.3, according to Ralf Wildenhues, in
1660 http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00192.html
1662 2005-11-14 Jim Meyering <jim@meyering.net>
1664 * NEWS (sort): Mention consequences of today's mkstemp-safer.c fix.
1666 2005-11-13 Jim Meyering <jim@meyering.net>
1668 * announce-gen: Accept new option, --gpg-key-id=ID and
1669 emit a blurb telling how to use the .sig files.
1670 * Makefile.cfg (gpg_key_ID): Define.
1671 * Makefile.maint (announcement): Use new option and key.
1673 Require that most .c files include <config.h>.
1674 * Makefile.maint (sc_require_config_h): New rule.
1675 (syntax-check-rules): Add it.
1676 * .x-sc_require_config_h: New file listing exceptions to the
1677 above rule. Some are legit, others are simply grandfathered in.
1678 * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h here, too.
1680 2005-11-12 Jim Meyering <jim@meyering.net>
1682 * src/checksum.h, src/md5.c, src/sha1sum.c: Remove now-unused files.
1684 2005-11-11 Jim Meyering <jim@meyering.net>
1686 * NEWS: Mention `readlink -f' bug fix in 5.3.0 news.
1687 Mention new readlink options in 5.3.0's `New features' section.
1688 Spotted by Thomas Hood.
1690 2005-11-08 Jim Meyering <jim@meyering.net>
1692 * NEWS: Merge in changes from b5_9x branch.
1694 2005-11-08 Paul Eggert <eggert@cs.ucla.edu>
1696 * NEWS: ls now defaults to --time-style='locale', which in turn acts
1697 like --time-style='posix-long-iso' if the locale settings are messed up.
1698 * src/ls.c (decode_switches): Implement this.
1700 2005-11-08 Jim Meyering <jim@meyering.net>
1702 * tests/du/2g: s/expensive/very expensive/ in a comment.
1705 2005-10-17 Eric Blake <ebb9@byu.net>
1707 * src/ls.c (usage): Fix descriptions of --sort, --time.
1708 Reported by Vitaly A. Ostanin.
1710 2005-11-04 Paul Eggert <eggert@cs.ucla.edu>
1712 * src/ln.c: Include filenamecat.c.
1713 (FILE_BASENAME_CONCAT): Remove.
1714 (do_link): Remove last arg DEST_IS_DIR. All callers changed.
1715 (main): Use file_name_concat, base_name, and strip_trailing_slashes
1716 instead of FILE_BASENAME_CONCAT. This simplifies the code, and avoids
1719 2005-11-04 Jim Meyering <jim@meyering.net>
1721 * src/du.c (process_file): Don't overflow for files of size >= 2^31
1722 on systems with stat.st_blocks of a signed 32-bit type.
1723 This bug causes trouble on some AIX 5.1 systems.
1724 Report and trivial patch from Paul Townsend:
1725 <http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00033.html>
1726 * NEWS: Mention this.
1728 * tests/du/2g: New (very-expensive) test for the above-fixed bug.
1729 * tests/du/Makefile.am (TESTS): Add it here.
1730 * tests/very-expensive: New file.
1731 * tests/Makefile.am (EXTRA_DIST): Add it here.
1732 * tests/cp/perm: Mark this test as `very-expensive', too.
1734 2005-11-02 Paul Eggert <eggert@cs.ucla.edu>
1736 * NEWS: Mention that rm -d and maybe ln -d are scheduled for
1738 * src/remove.h (struct rm_options): Remove unlink_dirs. All uses
1740 * src/rm.c (usage): Don't mention rm -d.
1742 2005-11-02 Jim Meyering <jim@meyering.net>
1744 * tests/dd/skip-seek: Fix typo in comment: s/fileutils/coreutils.
1745 From Andreas Schwab.
1747 * tests/dd/unblock-sync: Redirect stderr to /dev/null so the
1748 `M+N records in/out' lines don't pollute `make check' output.
1750 * tests/dd/skip-seek (sk-seek4): New test, to exercise the bug
1751 fixed on 2005-10-31. This test uses the new, IN_PIPE specifier.
1752 * tests/Coreutils.pm: Accept a new type of input specifier: IN_PIPE,
1753 to indicate that the input file should be piped into the command
1754 under test (via `cat FILE | $prog ...').
1756 * src/remove.c (remove_entry): Emit a better diagnostic when rm
1757 (without -r) fails to remove a directory on a non-Linux system.
1758 This change affects only newer Solaris systems (with priv_*
1759 functions like priv_allocset). Reported by Keith Thompson.
1761 * tests/rm/dir-nonrecur: New file/test for the above fix.
1762 * tests/rm/Makefile.am (TESTS): Add dir-nonrecur.
1764 2005-11-01 Paul Eggert <eggert@cs.ucla.edu>
1766 * NEWS: "tail -c 2 FILE" and "touch 0101000000" now operate as
1767 POSIX 1002.1-2001 requires.
1768 * src/tail.c (parse_obsolete_option): Implement this.
1769 Problem reported by Vincent Lefevre.
1770 * src/touch.c (main): Pass PDS_PRE_2000 to posixtime.
1771 * tests/tail/Test.pm (c-2, c-2-minus, c2, c2-minus): New tests.
1772 (test_vector): Add special cases for _POSIX2_VERSION, and
1773 regularize the old ones a bit.
1774 * tests/touch/obsolescent: Add y2000 test.
1776 2005-10-31 Paul Eggert <eggert@cs.ucla.edu>
1778 * src/dd.c (skip): Fix off-by-one error reported by
1779 Theodoros V. Kalamatianos.
1781 2005-10-30 Paul Eggert <eggert@cs.ucla.edu>
1783 * tests/mkdir/p-3: Require that the test be run as non-root.
1784 Problem and trivial fix reported by Theodoros V. Kalamatianos.
1786 2005-10-28 Paul Eggert <eggert@cs.ucla.edu>
1788 * src/ln.c (FILE_BASENAME_CONCAT): Omit unnecessary slashes in the
1789 boundary between DEST and SOURCE in the result.
1791 2005-10-26 Dmitry V. Levin <ldv@altlinux.org>
1793 * src/md5sum.c (main) [!O_BINARY]: Changed default read mode
1794 back to text, to sync with documentation and for backwards
1797 2005-10-25 Jim Meyering <jim@meyering.net>
1799 * tests/dircolors/simple (other-wr): Add an explicit test for
1800 the dircolors bug (NULL-dereference) fixed yesterday.
1802 2005-10-24 Jim Meyering <jim@meyering.net>
1804 * src/tac.c (tac_file): When determining whether a file is seekable,
1805 also test whether it is a tty. Using only the lseek-based test would
1806 give a false positive on Solaris. Reported by Peter Fales.
1808 2005-10-24 Dmitry V. Levin <ldv@altlinux.org>
1810 * tests/install/d-slashdot: New test, for "install -d" failure.
1811 * tests/install/Makefile.am (TESTS): Add d-slashdot.
1812 * tests/mkdir/p-slashdot: New test, for "mkdir -p" failure.
1813 * tests/mkdir/Makefile.am (TESTS): Add p-slashdot.
1815 2005-10-24 Jim Meyering <jim@meyering.net>
1817 * src/dircolors.c (ls_codes): Add missing comma.
1818 Anonymous report and patch from
1819 http://savannah.gnu.org/bugs/?func=detailitem&item_id=14849
1821 * src/dircolors.c: Add compile-time assertion that the slack_codes
1822 and ls_codes arrays have the same number of elements. This would
1823 have prevented the above-fixed bug.
1825 * src/expand.c (parse_tab_stops): Add a comment to make this function
1826 identical to the one in unexpand.c.
1827 * src/unexpand.c (parse_tab_stops): Adjust syntax to make this function
1828 identical to the one in expand.c.
1830 * src/expand.c (next_file): Don't assume fopen cannot return stdin.
1832 2005-10-23 Jim Meyering <jim@meyering.net>
1834 * src/md5sum.c (digest_check, main): Use ptr_align rather than
1835 a dangerous pointer-value-to-`unsigned' cast.
1836 * NEWS: mention the new sha* programs.
1837 * AUTHORS: Add new sha* programs.
1839 2005-08-28 David Madore <david.madore@ens.fr>
1841 Add new programs: sha224sum, sha256sum, sha384sum, sha512sum.
1842 * README: Add their names to the list.
1843 * src/md5sum.c: Provide framework for computing sha-2 hashes.
1844 * src/Makefile.am (sha224sum, sha256sum, sha384sum, sha512sum):
1845 Rules for compiling sha-2 utilities
1846 (noinst_HEADERS): Remove checksum.h.
1847 * man/sha512sum.x, man/sha384sum.x, man/sha256sum.x, man/sha224sum.x:
1849 * man/Makefile.am (dist_man_MANS): Add the corresponding .1 names.
1850 (sha224sum.1, sha256sum.1, sha384sum.1, sha512sum.1): New dependencies.
1851 * tests/misc/sha224sum, tests/misc/sha256sum: New files.
1852 * tests/misc/sha384sum, tests/misc/sha512sum: New files.
1853 * tests/misc/Makefile.am (TESTS): Add new sha224sum, sha256sum,
1854 sha384sum, sha512sum test scripts here rather that each in its
1857 2005-08-28 David Madore <david.madore@ens.fr>
1859 * tests/sha1sum/basic-1 (million-a): Add the "million a's" test (one
1860 of the FIPS test vectors).
1862 2005-10-23 Jim Meyering <jim@meyering.net>
1864 * configure.ac: Use 6.0-cvs as the version string.
1865 * NEWS: Adjust accordingly.